| *** bknudson has joined #openstack-oslo | 00:15 | |
| *** dims has quit IRC | 00:23 | |
| *** andreykurilin_ has quit IRC | 00:28 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Some package additions and adjustments to the env_builder.sh https://review.openstack.org/138910 | 00:31 |
|---|---|---|
| *** dims has joined #openstack-oslo | 00:42 | |
| *** tsekiyam_ has joined #openstack-oslo | 01:12 | |
| *** tsekiyama has quit IRC | 01:16 | |
| *** mtanino has quit IRC | 01:17 | |
| *** tsekiyam_ has quit IRC | 01:17 | |
| *** dims has quit IRC | 01:58 | |
| *** jecarey has joined #openstack-oslo | 02:04 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Exception and exception message cleanup (WIP) https://review.openstack.org/138935 | 02:22 |
| *** tsekiyama has joined #openstack-oslo | 02:23 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Exception and exception message cleanup (WIP) https://review.openstack.org/138935 | 02:24 |
| *** tsekiyama has quit IRC | 02:27 | |
| *** kgiusti has left #openstack-oslo | 02:42 | |
| *** arnaud__ has quit IRC | 02:47 | |
| *** mriedem has left #openstack-oslo | 02:48 | |
| *** mriedem has quit IRC | 02:48 | |
| openstackgerrit | Michael Bayer proposed openstack/oslo.db: Implement new oslo.db.sqlalchemy.enginefacade module https://review.openstack.org/138215 | 02:51 |
| *** noelbk has quit IRC | 03:23 | |
| *** zzzeek has quit IRC | 03:28 | |
| *** amotoki_ has quit IRC | 04:29 | |
| *** jecarey has quit IRC | 04:29 | |
| *** bnemec has quit IRC | 05:04 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo.concurrency: Add a reader/writer lock https://review.openstack.org/138217 | 05:06 |
| *** bnemec has joined #openstack-oslo | 05:10 | |
| *** arnaud__ has joined #openstack-oslo | 05:10 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.vmware: Imported Translations from Transifex https://review.openstack.org/138635 | 06:07 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.utils: Imported Translations from Transifex https://review.openstack.org/136566 | 06:11 |
| *** harlowja_ is now known as harlowja_away | 06:19 | |
| *** vigneshvar has joined #openstack-oslo | 06:20 | |
| *** ajo has joined #openstack-oslo | 06:26 | |
| *** ajo has quit IRC | 06:31 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow nested flows to be unnamed/anonymous https://review.openstack.org/136171 | 06:36 |
| *** ajo has joined #openstack-oslo | 06:39 | |
| sileht | I wonder why we need to reintroduce fake_rabbit flags: https://github.com/openstack/cinder/commit/313c33049f8d0cb0e41cef52f35f5ce96ac3373a | 06:39 |
| *** subscope has joined #openstack-oslo | 06:47 | |
| *** stevemar has quit IRC | 06:54 | |
| *** k4n0 has joined #openstack-oslo | 06:54 | |
| *** ishant has joined #openstack-oslo | 07:04 | |
| openstackgerrit | YangLei proposed openstack/oslo.log: Correct the position of the syslog handler https://review.openstack.org/138971 | 07:25 |
| *** yamahata has joined #openstack-oslo | 07:26 | |
| openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Reintroduces fake_rabbit config option https://review.openstack.org/138973 | 07:36 |
| openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: rabbit: add some tests when rpc_backend is set https://review.openstack.org/138974 | 07:36 |
| *** e0ne has joined #openstack-oslo | 07:41 | |
| openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: rabbit: add some tests when rpc_backend is set https://review.openstack.org/138974 | 07:45 |
| openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Reintroduces fake_rabbit config option https://review.openstack.org/138973 | 07:45 |
| sileht | dhellmann, jd__ https://review.openstack.org/138973 | 07:45 |
| *** denis_makogon has joined #openstack-oslo | 07:59 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Be explicit about publish keyword arguments https://review.openstack.org/117896 | 08:01 |
| *** e0ne has quit IRC | 08:02 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Be explicit about publish keyword arguments https://review.openstack.org/117896 | 08:05 |
| *** andreykurilin_ has joined #openstack-oslo | 08:09 | |
| *** dtantsur|afk is now known as dtantsur | 08:13 | |
| *** andreykurilin_ has quit IRC | 08:14 | |
| *** andreykurilin_ has joined #openstack-oslo | 08:15 | |
| *** yamahata has quit IRC | 08:21 | |
| openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: rabbit: add some tests when rpc_backend is set https://review.openstack.org/138974 | 08:23 |
| openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Reintroduces fake_rabbit config option https://review.openstack.org/138973 | 08:23 |
| sileht | dhellmann, not sure I really understand this issue: https://bugs.launchpad.net/oslo.messaging/+bug/1399085 | 08:26 |
| sileht | dhellmann, does that means that we can't add new options, too (/me thinking of AMQP1 options introduced in the last version) ? | 08:28 |
| *** stannie has joined #openstack-oslo | 08:28 | |
| openstackgerrit | Sabari proposed openstack/oslo.vmware: Fix re-create session during transient failures https://review.openstack.org/138986 | 08:28 |
| openstackgerrit | Merged openstack/taskflow: Raise value errors instead of asserts https://review.openstack.org/138533 | 08:28 |
| openstackgerrit | Sabari proposed openstack/oslo.vmware: Fix re-create session during transient failures https://review.openstack.org/138986 | 08:31 |
| openstackgerrit | Sabari proposed openstack/oslo.vmware: Fix re-create session during transient failures https://review.openstack.org/138986 | 08:33 |
| *** i159 has joined #openstack-oslo | 08:34 | |
| *** ishant has quit IRC | 08:43 | |
| *** ishant has joined #openstack-oslo | 08:43 | |
| *** vigneshvar_ has joined #openstack-oslo | 08:53 | |
| *** andreykurilin_ has quit IRC | 08:55 | |
| *** vigneshvar has quit IRC | 08:57 | |
| *** takedakn has joined #openstack-oslo | 09:05 | |
| *** f13o has joined #openstack-oslo | 09:12 | |
| *** takedakn has quit IRC | 09:22 | |
| *** e0ne has joined #openstack-oslo | 09:32 | |
| openstackgerrit | Ann Kamyshnikova proposed openstack/oslo.db: Remove check_foreign_keys from ModelsMigrationsSync https://review.openstack.org/139002 | 09:40 |
| *** ihrachyshka has joined #openstack-oslo | 09:40 | |
| *** arnaud__ has quit IRC | 10:05 | |
| *** viktors|afk is now known as viktors | 10:09 | |
| *** pblaho__ has joined #openstack-oslo | 10:31 | |
| *** ajo has quit IRC | 10:43 | |
| *** ajo has joined #openstack-oslo | 10:43 | |
| *** e0ne has quit IRC | 10:48 | |
| *** stannie has quit IRC | 10:50 | |
| *** e0ne has joined #openstack-oslo | 11:05 | |
| openstackgerrit | Nikola Dipanov proposed openstack/oslo.messaging: Make the RPCVersionCapError message clearer https://review.openstack.org/139012 | 11:06 |
| *** pblaho__ is now known as pblaho | 11:06 | |
| openstackgerrit | Nikola Dipanov proposed openstack/oslo.messaging: Make the RPCVersionCapError message clearer https://review.openstack.org/139012 | 11:09 |
| *** pblaho has quit IRC | 11:12 | |
| *** pblaho has joined #openstack-oslo | 11:12 | |
| openstackgerrit | Nikola Dipanov proposed openstack/oslo.messaging: Make the RPCVersionCapError message clearer https://review.openstack.org/139012 | 11:14 |
| openstackgerrit | Ilya Pekelny proposed openstack/oslo.db: Use alternative url string for Py3 https://review.openstack.org/139015 | 11:20 |
| *** kbyrne has joined #openstack-oslo | 11:28 | |
| *** viktors has quit IRC | 11:37 | |
| *** rdobosz has joined #openstack-oslo | 11:40 | |
| *** denis_makogon has quit IRC | 11:43 | |
| *** dmakogon_ is now known as denis_makogon | 11:44 | |
| *** denis_makogon_ has joined #openstack-oslo | 11:44 | |
| *** rdobosz is now known as _gryf | 11:45 | |
| dhellmann | good morning, sprinters! | 11:46 |
| dhellmann | sileht: adding options is ok, but in this case we removed something that was being used by the tests of the other projects so those tests broke | 11:48 |
| *** denis_makogon_ has quit IRC | 11:51 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging: Reintroduces fake_rabbit config option https://review.openstack.org/138973 | 11:54 |
| *** dims has joined #openstack-oslo | 11:55 | |
| *** e0ne has quit IRC | 12:07 | |
| openstackgerrit | Ihar Hrachyshka proposed openstack/oslo.log: Added helper decorator to log method arguments https://review.openstack.org/134363 | 12:21 |
| jd__ | totally forgot about oslo day | 12:21 |
| * jd__ drops everything on the floor | 12:21 | |
| dhellmann | yeah, I didn't send out a reminder earlier in the week like I meant to | 12:22 |
| openstackgerrit | Merged openstack/oslo.vmware: Fix re-create session during transient failures https://review.openstack.org/138986 | 12:26 |
| jd__ | is there an Etherpad or something to know who is working on what? | 12:26 |
| dhellmann | https://etherpad.openstack.org/p/oslo-kilo-sprint | 12:27 |
| dhellmann | I'm still catching up on the mailing list, and then I was going to start looking through bugs | 12:27 |
| dhellmann | I figure I'll alternate between bug triage and code review | 12:27 |
| dhellmann | jd__: is sileht around yet? I think I showed up around the time you all would be having lunch, if my time math is right | 12:27 |
| jd__ | he is | 12:28 |
| sileht | o/ | 12:28 |
| dhellmann | hi, sileht, that option fix is merging now so I just wanted to make sure you were on hand for the release. Have you looked to see what other changes merged so we can figure out the version number? | 12:28 |
| sileht | dhellmann, only translation have been merged since 1.5.0 | 12:29 |
| dhellmann | sileht: ok, then we can call this 1.5.1 safely | 12:30 |
| sileht | dhellmann, I need to eat first :), but I can do the release after | 12:30 |
| dhellmann | sileht: you have some time, we're waiting for it to merge :-) | 12:30 |
| * dhellmann has a "no release work on an empty stomach" policy | 12:30 | |
| sileht | :) | 12:31 |
| *** shardy has joined #openstack-oslo | 12:32 | |
| *** _gryf has quit IRC | 12:32 | |
| *** amrith is now known as _amrith_ | 12:54 | |
| openstackgerrit | Sridhar Gaddam proposed openstack/oslo-incubator: Curl statements to include globoff for IPv6 URLs https://review.openstack.org/136698 | 13:09 |
| *** jaosorior has joined #openstack-oslo | 13:17 | |
| *** bknudson has quit IRC | 13:22 | |
| *** haypo has joined #openstack-oslo | 13:31 | |
| *** jeckersb_gone is now known as jeckersb | 13:34 | |
| openstackgerrit | Merged openstack/oslo.messaging: Reintroduces fake_rabbit config option https://review.openstack.org/138973 | 13:35 |
| dhellmann | sileht: ^^ | 13:36 |
| *** yamahata has joined #openstack-oslo | 13:41 | |
| sileht | dhellmann, release done I will send the mail now | 13:54 |
| *** e0ne has joined #openstack-oslo | 13:55 | |
| *** dims has quit IRC | 13:58 | |
| *** dims has joined #openstack-oslo | 13:58 | |
| dhellmann | sileht: thanks | 14:03 |
| *** miqui_ has joined #openstack-oslo | 14:06 | |
| *** vigneshvar_ has quit IRC | 14:06 | |
| *** kgiusti has joined #openstack-oslo | 14:10 | |
| *** tcammann has quit IRC | 14:14 | |
| jd__ | who wants an easy one https://review.openstack.org/#/c/137476/ | 14:14 |
| *** _amrith_ is now known as amrith | 14:15 | |
| dims | jd__: done | 14:22 |
| *** mriedem has joined #openstack-oslo | 14:24 | |
| dhellmann | I'm closing disappointingly few of these pbr bugs :-/ | 14:27 |
| openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: safe_log Sanitize Passwords in List of Dicts https://review.openstack.org/123759 | 14:29 |
| openstackgerrit | Merged openstack/oslo-incubator: Improving docstrings for policy API https://review.openstack.org/137476 | 14:30 |
| *** bknudson has joined #openstack-oslo | 14:32 | |
| *** k4n0 has quit IRC | 14:33 | |
| *** miqui_ has quit IRC | 14:36 | |
| *** miqui_ has joined #openstack-oslo | 14:47 | |
| *** gordc has joined #openstack-oslo | 14:48 | |
| haypo | dhellmann: hi. if you are reviewing oslo patches, you may take a look at https://review.openstack.org/#/c/137604/ | 14:48 |
| *** ishant|2 has joined #openstack-oslo | 14:50 | |
| *** mjturek has joined #openstack-oslo | 14:51 | |
| *** mjturek has left #openstack-oslo | 14:51 | |
| *** mjturek has joined #openstack-oslo | 14:51 | |
| openstackgerrit | Merged openstack/oslo.messaging: Fix reconnect race condition with RabbitMQ cluster https://review.openstack.org/103157 | 14:52 |
| *** ishant has quit IRC | 14:53 | |
| openstackgerrit | Julien Danjou proposed openstack/oslo-incubator: Remove requirements-py3 https://review.openstack.org/139078 | 14:54 |
| openstackgerrit | Julien Danjou proposed openstack/oslo-incubator: Remove requirements-py3 https://review.openstack.org/139078 | 14:59 |
| *** stevemar has joined #openstack-oslo | 15:00 | |
| openstackgerrit | Julien Danjou proposed openstack/oslo-incubator: Remove requirements-py3 https://review.openstack.org/139078 | 15:00 |
| *** alexpilotti has joined #openstack-oslo | 15:00 | |
| dhellmann | haypo, jd__ : isn't processutils part of oslo.concurrency now? | 15:03 |
| jd__ | dhellmann: it is, why? | 15:03 |
| jd__ | oh | 15:03 |
| jd__ | haypo: didn't you propose that on oslo.concurrency back then? | 15:04 |
| dhellmann | yeah, that's a patch against the incubator | 15:04 |
| jd__ | or did I mix the review | 15:04 |
| dhellmann | bnemec: do you have a patch ready to remove the concurrency modules from the incubator? | 15:05 |
| *** andreykurilin_ has joined #openstack-oslo | 15:05 | |
| bnemec | dhellmann: I do, but it needs some cleanups. https://review.openstack.org/#/c/122796/ | 15:06 |
| dhellmann | bnemec: ok | 15:06 |
| *** sigmavirus24 has joined #openstack-oslo | 15:07 | |
| *** pblaho has quit IRC | 15:08 | |
| *** yamahata has quit IRC | 15:08 | |
| jd__ | huhu python -m subunit.run discover -t ./ --list in Python 3.4 in oslo-incubator never finishes due to probably some bug with eventlet | 15:09 |
| dhellmann | yay | 15:09 |
| dhellmann | I really really don't care about 3.4 support in the incubator. We can do that in the library repos as we graduate things. | 15:10 |
| *** mtanino has joined #openstack-oslo | 15:11 | |
| haypo | jd__: i worked on oslo-incubator | 15:11 |
| jd__ | haypo: too bad :/ | 15:12 |
| haypo | dhellmann, jd__ : i didn't know that processutils was moved, it is still present in oslo incubator | 15:12 |
| jd__ | yeah it's done in two times | 15:12 |
| jd__ | you didn't follow and I missed it was on the incubator | 15:12 |
| dhellmann | haypo: yeah, at this point it's best to assume modules in the incubator should not be modified unless you can't find an existing library -- look for the library first | 15:12 |
| jd__ | la sentence est irrévocable, -2 | 15:12 |
| haypo | no problem, i will propose a patch on oslo.concurrency | 15:13 |
| jd__ | but you can stay in the adventure | 15:13 |
| dhellmann | haypo: thanks | 15:13 |
| haypo | jd__: haha, i love koh lanta (survivors in english) | 15:14 |
| jd__ | easy one https://review.openstack.org/#/c/123759/ | 15:15 |
| jd__ | haypo: :-) | 15:15 |
| haypo | dhellmann: i'm trying to port oslo incubator to python 3, processutils was one of the remaining file which isn't python3 compatible | 15:15 |
| dhellmann | haypo: isn't it going to be easier to do that when the code is in the library repos? | 15:16 |
| haypo | dhellmann: i don't know | 15:16 |
| haypo | another easy patch, just add -g to curl to avoid errors with IPv6 domain in the URL: https://review.openstack.org/#/c/136698/ | 15:26 |
| *** subscope has quit IRC | 15:28 | |
| dims | haypo: +A'ed | 15:33 |
| openstackgerrit | Merged openstack/oslo.concurrency: Fix bug link in README.rst https://review.openstack.org/138441 | 15:33 |
| openstackgerrit | Merged openstack/oslo.concurrency: Remove noqa from test files https://review.openstack.org/138459 | 15:33 |
| *** jecarey has joined #openstack-oslo | 15:36 | |
| *** andreykurilin_ has quit IRC | 15:39 | |
| *** andreykurilin_ has joined #openstack-oslo | 15:39 | |
| *** prad has joined #openstack-oslo | 15:40 | |
| openstackgerrit | Merged openstack/oslo-incubator: Curl statements to include globoff for IPv6 URLs https://review.openstack.org/136698 | 15:42 |
| *** subscope has joined #openstack-oslo | 15:42 | |
| dhellmann | here's another easy one: https://review.openstack.org/#/c/136482/ | 15:50 |
| *** mjturek has quit IRC | 15:51 | |
| *** mjturek has joined #openstack-oslo | 15:51 | |
| bnemec | sileht: Can we just remove the note in https://review.openstack.org/#/c/123759 about the tests? Other than that it looks fine to me. | 15:54 |
| bnemec | dhellmann: I already +2'd https://review.openstack.org/#/c/136482/ - is there a reason you didn't vote on it? | 15:55 |
| * bnemec facepalsm | 15:56 | |
| bnemec | facepalms even | 15:56 |
| bnemec | dhellmann: Never mind | 15:56 |
| bnemec | It's a good thing I'm on vacation next week. I clearly need it. :-) | 15:56 |
| dhellmann | bnemec: :-) | 15:57 |
| openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: safe_log Sanitize Passwords in List of Dicts https://review.openstack.org/123759 | 15:58 |
| sileht | bnemec, done | 15:58 |
| bnemec | sileht: Thanks, +2 | 15:59 |
| sileht | bnemec, thanks | 15:59 |
| *** ishant|2 has quit IRC | 16:03 | |
| *** noelbk has joined #openstack-oslo | 16:03 | |
| *** e0ne_ has joined #openstack-oslo | 16:07 | |
| *** e0ne has quit IRC | 16:07 | |
| bnemec | dhellmann: So on changes like https://review.openstack.org/#/c/134660 we're leaving the top-level tests package for namespace compat testing, right? | 16:09 |
| bnemec | Also, I left a question inline about the noqa's. | 16:09 |
| dhellmann | bnemec: yes, the top level /tests should all still be using the namespace package for imports | 16:10 |
| dhellmann | bnemec: I should mark that WIP, I need to verify I haven't broken hacking rules still | 16:10 |
| bnemec | dhellmann: Okay, that's blocking https://review.openstack.org/#/c/136482/ too | 16:11 |
| *** subscope has quit IRC | 16:11 | |
| dhellmann | bnemec: yeah, that's unfortunate, but I think it's going to have to wait | 16:11 |
| *** e0ne_ has quit IRC | 16:11 | |
| dhellmann | unless someone wants to rewrite that patch | 16:11 |
| dhellmann | but as this is related to work for this cycle, I'm happy to leave it for today and focus on clearing out some older reviews | 16:12 |
| openstackgerrit | Ilya Pekelny proposed openstack/oslo-specs: db: Alembic environment runner specification https://review.openstack.org/112842 | 16:12 |
| bnemec | dhellmann: Okay, fair enough | 16:12 |
| dhellmann | I think I didn't notice it was blocked on my namespace patch when I asked for reviews | 16:12 |
| * bnemec is in no position to throw stones at people for not noticing things | 16:14 | |
| *** e0ne has joined #openstack-oslo | 16:14 | |
| *** miqui__ has joined #openstack-oslo | 16:15 | |
| *** gus_ has joined #openstack-oslo | 16:16 | |
| *** jroll has quit IRC | 16:18 | |
| *** noelbk has quit IRC | 16:18 | |
| *** miqui_ has quit IRC | 16:18 | |
| *** sigmavirus24 has quit IRC | 16:18 | |
| *** gus has quit IRC | 16:18 | |
| *** jroll has joined #openstack-oslo | 16:18 | |
| *** jroll has quit IRC | 16:19 | |
| *** jroll has joined #openstack-oslo | 16:19 | |
| *** noelbk has joined #openstack-oslo | 16:20 | |
| *** sigmavirus24 has joined #openstack-oslo | 16:20 | |
| *** tsekiyama has joined #openstack-oslo | 16:25 | |
| *** ihrachyshka has quit IRC | 16:28 | |
| *** subscope has joined #openstack-oslo | 16:28 | |
| *** zzzeek has joined #openstack-oslo | 16:28 | |
| *** vigneshvar_ has joined #openstack-oslo | 16:28 | |
| *** amrith is now known as _amrith_ | 16:30 | |
| dhellmann | this config patch isn't so easy, but it's not too tricky: https://review.openstack.org/#/c/135150/ | 16:41 |
| bnemec | dhellmann: Looking | 16:43 |
| dhellmann | bnemec: a simpler one: https://review.openstack.org/136893 | 16:44 |
| openstackgerrit | Merged openstack/oslo.config: add tests coverage for an oslo.messaging use case https://review.openstack.org/136406 | 16:48 |
| bnemec | dhellmann: Does oslo.config support short opts like -a thing -b thing -c thing? | 16:49 |
| bnemec | Wondering if the startswith check in https://review.openstack.org/#/c/135150/8/oslo/config/cfg.py should be for - instead of --. | 16:49 |
| *** exploreshaifali has joined #openstack-oslo | 16:49 | |
| dhellmann | bnemec: good question. I'm not sure. | 16:50 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.i18n: Force code sample to be treated as python https://review.openstack.org/139111 | 16:51 |
| dhellmann | trivial patch: ^^ | 16:52 |
| *** i159 has quit IRC | 16:56 | |
| *** arnaud__ has joined #openstack-oslo | 16:58 | |
| *** e0ne has quit IRC | 17:01 | |
| *** e0ne has joined #openstack-oslo | 17:04 | |
| *** dtantsur is now known as dtantsur|afk | 17:05 | |
| *** arnaud__ has quit IRC | 17:06 | |
| *** stevemar has quit IRC | 17:06 | |
| bnemec | dhellmann: So I think we do need short opt support too. Since it's a one character change, should I just merge the review and push a follow-up? | 17:07 |
| dhellmann | bnemec: maybe set up the follow-up first, and then we can merge them together? | 17:09 |
| dhellmann | and good call | 17:09 |
| bnemec | dhellmann: Sounds good. | 17:09 |
| openstackgerrit | Ben Nemec proposed openstack/oslo.config: Check for short opts too https://review.openstack.org/139118 | 17:12 |
| *** pabelanger has joined #openstack-oslo | 17:12 | |
| pabelanger | greetings | 17:12 |
| bnemec | dhellmann: ^ | 17:12 |
| pabelanger | I found this issue in the mailing list, but curious if anybody else had this problem: http://lists.openstack.org/pipermail/openstack-dev/2014-October/047842.html | 17:12 |
| pabelanger | basically I get ImportError: No module named urllib when oslo.messaging is installed | 17:12 |
| pabelanger | and like the post, I am using six 1.8.0 version too | 17:13 |
| bnemec | pabelanger: Are you also using jython? | 17:16 |
| openstackgerrit | Mike Fedosin proposed openstack/oslo.config: Fix wrong order of positional args in cli https://review.openstack.org/135150 | 17:17 |
| *** e0ne has quit IRC | 17:17 | |
| pabelanger | bnemec, No java if my app. Just a python app I'm writing that is using oslo.messaging | 17:17 |
| openstackgerrit | Michael Bayer proposed openstack/oslo.db: Implement new oslo.db.sqlalchemy.enginefacade module https://review.openstack.org/138215 | 17:18 |
| openstackgerrit | Merged openstack/oslo.config: Refactored help string generation https://review.openstack.org/136893 | 17:18 |
| bnemec | dhellmann: https://review.openstack.org/#/c/135150/ should be ready to merge on its own now. | 17:19 |
| mfedosin_ | bnemec, hello! I fixed it | 17:20 |
| bnemec | pabelanger: Okay, just wondering. I can't say that I've personally seen that. | 17:20 |
| bnemec | mfedosin_: Yep, I saw that. Thanks. | 17:20 |
| mfedosin_ | thanks for your comments | 17:20 |
| dhellmann | bnemec: +2a | 17:21 |
| dhellmann | pabelanger: that's very strange | 17:22 |
| dhellmann | pabelanger: is the code for your app available somewhere? | 17:24 |
| dhellmann | I definitely see urllib in six 1.8, so I wonder if some other dependency is downgrading six | 17:25 |
| dhellmann | I don't see anything in oslo.messaging changing six, though I know we do that in some other places (oslotest, I think) | 17:26 |
| *** boris-42 has joined #openstack-oslo | 17:29 | |
| *** _amrith_ is now known as amrith | 17:29 | |
| pabelanger | dhellmann, Ya, my app seems to work with oslo.messaging 1.3.1 but 1.5.1 seems to cause the issue | 17:31 |
| pabelanger | dhellmann, ya, code is https://github.com/kickstandproject/payload | 17:31 |
| pabelanger | http://jenkins.kickstand-project.org/job/gate-payload-docs/63/console shows the issue | 17:31 |
| pabelanger | dhellmann, problem seems to happen 1.4.0+ | 17:33 |
| dhellmann | pabelanger: weird, when I checked out the code and ran "tox -e py27" everything worked fine | 17:35 |
| dhellmann | pabelanger: is it possible there is an old version of six installed globally on that jenkins server, so it isn't being updated when tox runs and builds a virtualenv? | 17:36 |
| pabelanger | dhellmann, try tox -e docs | 17:36 |
| pabelanger | dhellmann, Ya, that is what I am checking | 17:36 |
| pabelanger | but think my dependencies are clean | 17:36 |
| dhellmann | pabelanger: I do get the error there | 17:36 |
| pabelanger | Ya, so I think I have a dependency issue some place | 17:37 |
| pabelanger | But, not sure why 1.3.1 works | 17:37 |
| pabelanger | and 1.4.0 of oslo.message does not | 17:37 |
| pabelanger | perhaps sphinx is doing something funky | 17:37 |
| dhellmann | pabelanger: that's possible | 17:38 |
| pabelanger | this appears to be the commit that is causing my issues: https://github.com/openstack/oslo.messaging/commit/13608437bb8d491badbc6c906f8d60b51e52cd79 | 17:39 |
| pabelanger | okay, thanks for looking | 17:39 |
| pabelanger | will pin to 1.3.1 for the moment | 17:39 |
| pabelanger | until I can debug properly | 17:39 |
| dhellmann | pabelanger: let me know if you determine that the fault is somewhere in oslo.messaging, but this feels like some sort of weird interaction with other modules or pip or something | 17:39 |
| pabelanger | dhellmann, will do | 17:40 |
| dhellmann | pabelanger: fwiw, I can import that symbol from both virtualenvs: http://paste.openstack.org/show/144730/ | 17:40 |
| dhellmann | pabelanger: that also works if I use "from six.moves.urllib import parse" | 17:41 |
| pabelanger | dhellmann, okay, thanks again for the help | 17:43 |
| dhellmann | pabelanger: ah, there's a copy of six in the d2to1 package you're using from setup.py. I wonder if that is added to the import path somehow? | 17:44 |
| pabelanger | Hmm | 17:44 |
| pabelanger | interesting | 17:44 |
| dhellmann | pabelanger: you shouldn't need d2to1 with the latest pbr | 17:44 |
| dhellmann | I have no idea if that's related, but you probably want to update that anyway | 17:44 |
| pabelanger | okay | 17:45 |
| pabelanger | let me try that | 17:45 |
| sigmavirus24 | dhellmann: thoughts on forking cmd2 to stackforge or would it be better to abandon it entirely? (re: https://bugs.launchpad.net/python-cliff/+bug/1379055) | 17:46 |
| dhellmann | sigmavirus24: I'm not sure we want to take over cmd2 maintenance. We could talk to Catherine about making a release, but she seems to have dropped support for the module. I had planned to stop using cmd2 anyway because of some issues we had getting a bug fix release a while back, I just never got around to it. | 17:48 |
| *** dims_ has joined #openstack-oslo | 17:48 | |
| sigmavirus24 | Sounds good to me | 17:49 |
| dhellmann | sigmavirus24: I guess that's the long way of saying, let's see what happens if we drop cmd2 and just use the stdlib cmd module | 17:49 |
| dhellmann | we have a few simple doc changes in oslosphinx that should be easy to land: https://review.openstack.org/#/q/project:openstack%2Foslosphinx+is:open,n,z | 17:52 |
| *** dims has quit IRC | 17:52 | |
| *** stevemar has joined #openstack-oslo | 17:54 | |
| *** prad has quit IRC | 17:58 | |
| pabelanger | dhellmann, Looks like you were correct about d2to1 | 17:58 |
| dhellmann | pabelanger: woo! | 17:58 |
| pabelanger | dhellmann, thank you sir :) | 17:59 |
| dhellmann | pabelanger: I'm glad I could help | 17:59 |
| pabelanger | If I make it our to Vancouver, I'l get you a beer | 17:59 |
| pabelanger | out* | 17:59 |
| dhellmann | well, I won't refuse, but it's not necessary :-) | 18:00 |
| dhellmann | harlowja_away: are you sprinting with us today, or should I take a stab at cleaning up the taskflow bug backlog? | 18:06 |
| *** arnaud__ has joined #openstack-oslo | 18:07 | |
| dhellmann | dims_: how do you want to handle the oslo.vmware bug triage? | 18:07 |
| * dhellmann notices it is raining just in time for him to go to lunch | 18:08 | |
| *** harlowja_away is now known as harlowja_ | 18:10 | |
| harlowja_ | dhellmann just got in, i'll be joining i think | 18:11 |
| *** arnaud__ has quit IRC | 18:11 | |
| openstackgerrit | Merged openstack/oslo-incubator: Remove requirements-py3 https://review.openstack.org/139078 | 18:14 |
| *** pabelanger has left #openstack-oslo | 18:18 | |
| dims_ | dhellmann: done | 18:23 |
| harlowja_ | if people want to look over https://review.openstack.org/#/c/135146/ and https://review.openstack.org/#/c/136958/ that would be cool , i can look over some other folks stuff to in the spirit of sprinting :-P | 18:32 |
| openstackgerrit | Merged openstack/oslo.i18n: Force code sample to be treated as python https://review.openstack.org/139111 | 18:35 |
| *** mjturek has quit IRC | 18:35 | |
| openstackgerrit | Merged openstack/oslosphinx: Tighten up documentation https://review.openstack.org/130007 | 18:40 |
| *** mjturek has joined #openstack-oslo | 18:42 | |
| openstackgerrit | Merged openstack/oslo.config: Fix wrong order of positional args in cli https://review.openstack.org/135150 | 18:43 |
| openstackgerrit | Merged openstack-dev/pbr: Support platform-specific requirements files https://review.openstack.org/136707 | 18:43 |
| *** arnaud__ has joined #openstack-oslo | 18:47 | |
| *** openstackgerrit has quit IRC | 18:50 | |
| *** openstackgerrit has joined #openstack-oslo | 18:50 | |
| *** andreykurilin_ has quit IRC | 18:50 | |
| dhellmann | harlowja_: ok | 18:51 |
| dhellmann | dims_: thanks | 18:51 |
| dhellmann | dims_, wait, is the triage done? | 18:52 |
| dims_ | y there wasn't much new | 18:53 |
| dhellmann | dims_: I see a bunch with status "new" on https://bugs.launchpad.net/oslo.vmware | 18:53 |
| *** stevemar2 has joined #openstack-oslo | 18:53 | |
| dims_ | refresh? | 18:54 |
| *** stevemar has quit IRC | 18:54 | |
| dhellmann | d'oh | 18:54 |
| dhellmann | I thought I had just loaded that page | 18:54 |
| * dhellmann returns to his sandwich | 18:54 | |
| dims_ | :) | 18:54 |
| openstackgerrit | Merged openstack/oslo.vmware: Imported Translations from Transifex https://review.openstack.org/138635 | 18:57 |
| *** stevemar3 has joined #openstack-oslo | 19:02 | |
| *** stevemar2 has quit IRC | 19:03 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow for the notifier to provide a 'details_filter' https://review.openstack.org/136969 | 19:04 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Update listeners to ensure they correctly handle all atoms https://review.openstack.org/136958 | 19:04 |
| openstackgerrit | Doug Hellmann proposed openstack/stevedore: Implement a __contains__ override for extension manager https://review.openstack.org/127037 | 19:06 |
| dhellmann | harlowja_: I wonder if you could abstract some of this tree/graph management stuff out of taskflow to its own library | 19:09 |
| harlowja_ | likely | 19:10 |
| dhellmann | just a thought; I'm still reading the change to flatten/skip empty flows | 19:10 |
| harlowja_ | i did start pulling out the finite state machine stuff for https://github.com/harlowja/automaton | 19:10 |
| harlowja_ | ironic may have a direct usage of just that | 19:10 |
| dhellmann | oh, cool | 19:10 |
| harlowja_ | *tbd* devanda is still messing around | 19:10 |
| harlowja_ | but ya, i could see that happening elsewhere as time goes on | 19:11 |
| *** e0ne has joined #openstack-oslo | 19:11 | |
| harlowja_ | will see what happens with automaton first, then see where else it could go :-P | 19:11 |
| harlowja_ | automaton still in stealth mode, ha | 19:12 |
| openstackgerrit | Merged openstack/oslo.log: Added helper decorator to log method arguments https://review.openstack.org/134363 | 19:12 |
| *** prad has joined #openstack-oslo | 19:20 | |
| harlowja_ | *automaton + ironic still in stealth mode, i meant | 19:20 |
| harlowja_ | dhellmann another one u might be interested in https://review.openstack.org/#/c/138607/ (tooz + nova spec) | 19:22 |
| *** jaosorior has quit IRC | 19:23 | |
| harlowja_ | jd__ on that one, when tooz -> oslo, is pymemcache goign to get added to the requirements repo? | 19:23 |
| harlowja_ | i noticed its still not there, so might be a problem in the near future with tooz joining oslo group | 19:24 |
| openstackgerrit | Merged openstack/pylockfile: Begin moving some of the common code to a shared base https://review.openstack.org/122253 | 19:25 |
| *** mjturek has quit IRC | 19:26 | |
| *** mjturek has joined #openstack-oslo | 19:26 | |
| harlowja_ | dims_ bnemec https://review.openstack.org/#/c/138607/ might be interesting for u guys also (and others...) | 19:26 |
| *** e0ne has quit IRC | 19:29 | |
| *** stevemar2 has joined #openstack-oslo | 19:30 | |
| *** stevemar3 has quit IRC | 19:33 | |
| dhellmann | harlowja_, I'm afraid I have no idea what's going on in https://review.openstack.org/#/c/135146/6/taskflow/engines/action_engine/compiler.py :-( | 19:39 |
| harlowja_ | shall i explain :) | 19:39 |
| harlowja_ | sooo, people using taskflow create a bunch of tasks as objects typically | 19:40 |
| dhellmann | right | 19:40 |
| harlowja_ | they then place these together into some kind of ordering and such, using patterns (linear, unordered, graph/dag like) | 19:40 |
| harlowja_ | they can nest such things (aka, pattern inside pattern) | 19:40 |
| harlowja_ | so thats great for creating i guess, but isn't so great for running | 19:40 |
| harlowja_ | so the compiler part decomposes those patterns into a flat graph | 19:41 |
| dhellmann | why is that better than just traversing what you have? Does it optimize out branches or something? | 19:41 |
| harlowja_ | so that if say u have a nested nested nested unordered pattern with a task, it can run in parallel with other things (if this is feasible/allowed) | 19:41 |
| dhellmann | ah | 19:41 |
| harlowja_ | ya, so in a way, its optimizing out branches (or a similar idea) | 19:42 |
| harlowja_ | but what happened was the following pattern | 19:42 |
| harlowja_ | a(b, c) -> d() -> e(f, g) | 19:42 |
| harlowja_ | where the things inside parens are tasks | 19:43 |
| harlowja_ | that was creating a graph that was losing the connection between b->c->f->g | 19:43 |
| harlowja_ | *a, d, e are patterns (structural things in this case) | 19:43 |
| harlowja_ | which is sorta sucky, but an edge case when someone gives a pattern that is empty (for wahtever reason) | 19:44 |
| dhellmann | ok | 19:44 |
| harlowja_ | thats the general gist of it : | 19:44 |
| harlowja_ | :) | 19:44 |
| dhellmann | so in _relink() what are "priors"? | 19:45 |
| *** stevemar2 is now known as stevemar | 19:45 | |
| dhellmann | the problem statement makes sense, I'm just not familiar with these classes so I don't know why a u goes into the priors list when decomposed[v] has no nodes, for example | 19:46 |
| harlowja_ | so priors is d, a in this case | 19:46 |
| harlowja_ | when f, g are being linked up | 19:46 |
| dhellmann | what are "u" and "v"? what does iter_links() return? pairs of patterns? | 19:47 |
| dhellmann | you have all of these single-letter variables.... | 19:47 |
| harlowja_ | u, v are graph terminology i think | 19:47 |
| harlowja_ | nodes u and v | 19:48 |
| dhellmann | ok, maybe it's just been too long since I've done that sort of thing | 19:48 |
| dhellmann | so v_g is the decomposed graph leading from node v? | 19:48 |
| harlowja_ | more the decomposed graph of node v | 19:49 |
| harlowja_ | for ex | 19:49 |
| harlowja_ | f(a(b, c), d) | 19:49 |
| harlowja_ | that could be a nested pattern | 19:49 |
| harlowja_ | a(b, c) would be decomposed a graph of (b, c) | 19:49 |
| harlowja_ | decomposed[a] -> that graph | 19:49 |
| jd__ | harlowja_: probably | 19:50 |
| dhellmann | harlowja_: so why do you put (u, v) into the priors list if v_g has no nodes? | 19:51 |
| dhellmann | isn't that what you're trying to filter out? | 19:51 |
| harlowja_ | so the main reason for that is that iter_links for graph patterns that are decomposed, to find out the priors of that u need to walk back through the predecessors | 19:52 |
| harlowja_ | ex | 19:52 |
| dhellmann | ah, for the stuff later in the function where you are actually making the edges | 19:53 |
| harlowja_ | ya | 19:53 |
| harlowja_ | f(a(b, c), d) is more linear, but u can actually do more weirdness by using graph patterns | 19:53 |
| harlowja_ | where its more like | 19:53 |
| harlowja_ | pattern a | 19:53 |
| harlowja_ | with tasks a, b, c | 19:53 |
| harlowja_ | but a -> c | 19:53 |
| harlowja_ | b->c | 19:53 |
| harlowja_ | not linear | 19:53 |
| dhellmann | right | 19:54 |
| harlowja_ | a, b, c, could also be nested flows themselves | 19:54 |
| harlowja_ | so lets say its b -> c -> d in that pattern a | 19:55 |
| harlowja_ | and also | 19:55 |
| harlowja_ | e -> f -> g in that same pattern a | 19:55 |
| dhellmann | ah, I see the other append of (u, v) on line 199 now -- I was thinking you were only updating priors if v didn't have any nodes, but it's always updated | 19:55 |
| harlowja_ | ya | 19:55 |
| harlowja_ | so that i can walk backwards for the situation of a graph flow having b -> c -> d and e -> f -> g in it | 19:55 |
| harlowja_ | so that i can correctly jump over say c, f (if both are empty) | 19:55 |
| dhellmann | and you don't want to do that earlier, because the priors list needs to not include v until you've processed v | 19:56 |
| harlowja_ | right :) | 19:56 |
| harlowja_ | someday i want to make that compiler stuff simpler, lol, if it can be | 19:56 |
| harlowja_ | lol | 19:56 |
| dhellmann | ok, I think I see now | 19:56 |
| harlowja_ | but it allows for doing things neatly in parellel after its all flattened out | 19:56 |
| *** jecarey has quit IRC | 19:57 | |
| harlowja_ | even though its sorta complicated :-/ | 19:57 |
| harlowja_ | there was an alternative back in the day that would use yielding to do something similar, but i didn't think that was much better :-/ | 19:58 |
| dhellmann | well, now that I understand it, I see it. I was thrown by the short var names and not knowing what objects were being manipulated | 19:58 |
| harlowja_ | kk | 19:58 |
| *** jecarey has joined #openstack-oslo | 19:58 | |
| harlowja_ | i shall update that with a bunch of comments | 19:58 |
| dhellmann | you could add a comment block to the top of that function based on our conversation and make it much easier to follow | 19:58 |
| dhellmann | yeah | 19:58 |
| harlowja_ | using this IRC log to help | 19:58 |
| harlowja_ | yup | 19:58 |
| harlowja_ | agreed | 19:58 |
| dhellmann | the logic isn't too bad, once you know what all of the variables mean :-) | 19:59 |
| harlowja_ | ya, damn graph crap, lol | 19:59 |
| harlowja_ | networkx https://github.com/networkx/networkx also gets involved | 20:00 |
| harlowja_ | since it provides most of the underlying logic for the graph objects | 20:00 |
| harlowja_ | the name of that library should have been different imho, lol | 20:00 |
| *** andreykurilin_ has joined #openstack-oslo | 20:01 | |
| harlowja_ | * http://networkx.github.io/ (more readable/user friendly) | 20:01 |
| *** openstackgerrit has quit IRC | 20:04 | |
| *** openstackgerrit has joined #openstack-oslo | 20:04 | |
| *** amrith is now known as _amrith_ | 20:05 | |
| *** e0ne has joined #openstack-oslo | 20:13 | |
| openstackgerrit | Merged openstack/oslo-incubator: Add ConnectionError exception https://review.openstack.org/137412 | 20:28 |
| *** e0ne has quit IRC | 20:32 | |
| *** alexpilotti has quit IRC | 20:32 | |
| dims_ | harlowja_: +1 to "World peace..." :) | 20:34 |
| harlowja_ | lol | 20:34 |
| harlowja_ | it just may do it | 20:34 |
| harlowja_ | the butterfly effect u know... | 20:34 |
| dims_ | harlowja_: so, have you considered a prototype a ToozServiceGroupDriver that just implements a new ServiceGroupDriver and sits beside the others? | 20:37 |
| dims_ | s/new/old/ | 20:37 |
| harlowja_ | dims_ ya, thats likely part of the depreciation strategy i think | 20:37 |
| dims_ | 2 step tango, first step to just another impl and then switch over completely | 20:37 |
| harlowja_ | ya | 20:38 |
| dims_ | then +1 from me :) | 20:38 |
| harlowja_ | there are weirdness there though, especially in nova mc.py | 20:39 |
| harlowja_ | that one is just odd imho, lol | 20:39 |
| harlowja_ | it should be better named half_mc_half_db | 20:39 |
| harlowja_ | or something, lol | 20:39 |
| *** e0ne has joined #openstack-oslo | 20:42 | |
| dims_ | harlowja_: agree | 20:43 |
| harlowja_ | the things u learn though (i wasn't aware that it did that) | 20:43 |
| *** exploreshaifali has quit IRC | 20:43 | |
| harlowja_ | code archaology, ha | 20:45 |
| *** jecarey has quit IRC | 20:45 | |
| *** alexpilotti has joined #openstack-oslo | 20:48 | |
| dims_ | y interesting ways in which the code evolves or dies | 20:49 |
| *** e0ne has quit IRC | 20:52 | |
| harlowja_ | yup | 20:55 |
| *** e0ne has joined #openstack-oslo | 20:57 | |
| *** jecarey has joined #openstack-oslo | 21:04 | |
| *** dims_ has quit IRC | 21:05 | |
| *** dims has joined #openstack-oslo | 21:06 | |
| *** kgiusti has left #openstack-oslo | 21:09 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging: Touch up grammar in warning messages https://review.openstack.org/139199 | 21:14 |
| *** ViswaV has joined #openstack-oslo | 21:20 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging: Treat sphinx warnings as errors https://review.openstack.org/139201 | 21:22 |
| *** jecarey has quit IRC | 21:35 | |
| *** jecarey has joined #openstack-oslo | 21:35 | |
| *** e0ne has quit IRC | 21:41 | |
| *** e0ne has joined #openstack-oslo | 21:45 | |
| *** e0ne has quit IRC | 21:45 | |
| *** prad has quit IRC | 21:46 | |
| *** prad has joined #openstack-oslo | 21:46 | |
| openstackgerrit | Merged openstack/oslo.messaging: Warn user if needed when the process is forked https://review.openstack.org/137651 | 21:47 |
| *** denis_makogon_ has joined #openstack-oslo | 21:51 | |
| *** ajo has quit IRC | 21:55 | |
| *** e0ne has joined #openstack-oslo | 22:02 | |
| *** e0ne has quit IRC | 22:04 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging: Treat sphinx warnings as errors https://review.openstack.org/139201 | 22:08 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Properly handle and skip empty intermediary flows https://review.openstack.org/135146 | 22:11 |
| *** andreykurilin_ has quit IRC | 22:15 | |
| *** andreykurilin__ has joined #openstack-oslo | 22:15 | |
| openstackgerrit | Merged openstack/oslo.messaging: Add more TLS protocols to rabbit impl https://review.openstack.org/137141 | 22:18 |
| *** bknudson has quit IRC | 22:18 | |
| *** vigneshvar_ has quit IRC | 22:26 | |
| *** ViswaV has quit IRC | 22:37 | |
| *** mriedem has quit IRC | 22:44 | |
| *** alexpilotti has quit IRC | 22:45 | |
| *** ViswaV has joined #openstack-oslo | 22:49 | |
| *** ViswaV_ has joined #openstack-oslo | 22:51 | |
| *** dims_ has joined #openstack-oslo | 22:53 | |
| *** ViswaV has quit IRC | 22:54 | |
| *** miqui__ has quit IRC | 22:54 | |
| *** gordc has quit IRC | 22:54 | |
| *** dims has quit IRC | 22:55 | |
| *** stevemar has quit IRC | 23:01 | |
| *** oomichi has joined #openstack-oslo | 23:07 | |
| *** jecarey has quit IRC | 23:08 | |
| *** andreykurilin__ has quit IRC | 23:09 | |
| *** andreykurilin_ has joined #openstack-oslo | 23:10 | |
| *** denis_makogon_ has quit IRC | 23:12 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:24 | |
| *** prad has quit IRC | 23:32 | |
| *** takedakn has joined #openstack-oslo | 23:50 | |
| *** takedakn has quit IRC | 23:56 | |
| *** takedakn has joined #openstack-oslo | 23:56 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Show compilation actions when __debug__ enabled https://review.openstack.org/139270 | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!