*** ftcjeff has quit IRC | 00:02 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Cache immutable visible scopes in the runtime component https://review.openstack.org/137241 | 00:25 |
---|---|---|
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add *basic* scope visibility constraints https://review.openstack.org/137245 | 00:25 |
*** stevemar has quit IRC | 00:28 | |
openstackgerrit | Merged openstack/taskflow: Move the _pformat() method to be a classmethod https://review.openstack.org/136513 | 00:29 |
openstackgerrit | Merged openstack/taskflow: Add a claims listener that connects job claims to engines https://review.openstack.org/136923 | 00:29 |
*** dims_ has joined #openstack-oslo | 00:31 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a simplistic hello world example https://review.openstack.org/138572 | 00:32 |
*** takedakn has quit IRC | 00:33 | |
*** dims has quit IRC | 00:34 | |
*** raildo_ has quit IRC | 00:47 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: Add an optional executor callback to dispatcher https://review.openstack.org/136652 | 00:50 |
openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: Add a new aioeventlet executor https://review.openstack.org/136653 | 00:50 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a simplistic hello world example https://review.openstack.org/138572 | 01:02 |
*** arnaud__ has joined #openstack-oslo | 01:05 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a simplistic hello world example https://review.openstack.org/138572 | 01:13 |
*** tsekiyam_ has joined #openstack-oslo | 01:32 | |
*** mtanino has quit IRC | 01:35 | |
*** tsekiyama has quit IRC | 01:35 | |
*** tsekiyam_ has quit IRC | 01:36 | |
openstackgerrit | Merged openstack/taskflow: Use a module level constant to provide the DEFAULT_LISTEN_FOR https://review.openstack.org/136983 | 01:36 |
*** jaypipes has quit IRC | 01:39 | |
*** stevemar has joined #openstack-oslo | 01:42 | |
*** mriedem has left #openstack-oslo | 01:59 | |
*** mriedem has quit IRC | 01:59 | |
*** zzzeek has quit IRC | 02:02 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 02:12 | |
*** dims_ has quit IRC | 02:36 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 02:52 | |
*** mtanino has joined #openstack-oslo | 02:54 | |
*** dims has joined #openstack-oslo | 03:36 | |
*** dims has quit IRC | 03:42 | |
*** harlowja_ is now known as harlowja_away | 03:47 | |
*** jaypipes has joined #openstack-oslo | 03:48 | |
*** mtanino has quit IRC | 04:02 | |
*** jeckersb is now known as jeckersb_gone | 04:28 | |
*** amotoki has joined #openstack-oslo | 04:53 | |
*** alexiz has quit IRC | 05:15 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 05:15 | |
*** stevemar has quit IRC | 05:36 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.vmware: Imported Translations from Transifex https://review.openstack.org/138635 | 06:04 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/138266 | 06:10 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.utils: Imported Translations from Transifex https://review.openstack.org/136566 | 06:10 |
*** k4n0 has joined #openstack-oslo | 06:20 | |
*** harlowja_at_home has joined #openstack-oslo | 06:26 | |
sileht | a | 06:27 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: safe_log Sanitize Passwords in List of Dicts https://review.openstack.org/123759 | 06:38 |
*** rdobosz has quit IRC | 06:43 | |
*** arnaud__ has quit IRC | 06:53 | |
*** vigneshvar has joined #openstack-oslo | 06:55 | |
*** arnaud__ has joined #openstack-oslo | 07:03 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a simplistic hello world example https://review.openstack.org/138572 | 07:11 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a simplistic hello world example https://review.openstack.org/138572 | 07:12 |
*** andreykurilin has quit IRC | 07:16 | |
*** andreykurilin has joined #openstack-oslo | 07:16 | |
openstackgerrit | Merged openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/138266 | 07:22 |
*** noelbk has quit IRC | 07:23 | |
*** arnaud__ has quit IRC | 07:43 | |
*** arnaud__ has joined #openstack-oslo | 07:49 | |
*** openstackgerrit has quit IRC | 07:50 | |
*** openstackgerrit has joined #openstack-oslo | 07:50 | |
*** harlowja_at_home has quit IRC | 08:21 | |
*** vigneshvar_ has joined #openstack-oslo | 08:28 | |
*** arnaud__ has quit IRC | 08:29 | |
*** arnaud__ has joined #openstack-oslo | 08:29 | |
*** vigneshvar has quit IRC | 08:32 | |
*** ajo has joined #openstack-oslo | 08:37 | |
*** ihrachyshka has joined #openstack-oslo | 08:47 | |
openstackgerrit | Merged openstack/taskflow: Cache immutable visible scopes in the runtime component https://review.openstack.org/137241 | 08:48 |
*** takedakn has joined #openstack-oslo | 08:50 | |
*** takedakn has quit IRC | 08:54 | |
openstackgerrit | Merged openstack/oslotest: Fix the URL for reporting bugs in the README https://review.openstack.org/138438 | 08:55 |
openstackgerrit | Merged openstack/taskflow: Split the scheduler into sub-schedulers https://review.openstack.org/138237 | 08:57 |
openstackgerrit | Merged openstack/taskflow: Use standard threading locks in the cache types https://review.openstack.org/130963 | 08:57 |
*** ishant has joined #openstack-oslo | 09:02 | |
*** dims has joined #openstack-oslo | 09:03 | |
*** ihrachyshka has quit IRC | 09:05 | |
openstackgerrit | Merged openstack/taskflow: Change messaging from handler connection timeouts -> operation timeouts https://review.openstack.org/127335 | 09:05 |
openstackgerrit | Merged openstack/taskflow: Allow the worker banner to be written to an arbitrary location https://review.openstack.org/126981 | 09:06 |
openstackgerrit | Merged openstack/taskflow: Improve some of the task docstrings https://review.openstack.org/128444 | 09:06 |
*** andreykurilin_ has joined #openstack-oslo | 09:06 | |
openstackgerrit | Julien Danjou proposed openstack/oslo.log: Replace RFCSysLogHandler by a syslog() based one https://review.openstack.org/136842 | 09:08 |
*** dims has quit IRC | 09:08 | |
sileht | sniff, the tarball of oslo.messaging 1.5.0 is not on pypi, and I don't find the upload job with logstash: | 09:13 |
sileht | eyJzZWFyY2giOiJcIi91c3IvbG9jYWwvamVua2lucy9zbGF2ZV9zY3JpcHRzL3B5cGktd2hlZWwtdXBsb2FkLnNoIG9zbG8ubWVzc2FnaW5nXCIgQU5EIHByb2plY3Q6XCJvcGVuc3RhY2svb3Nsby5tZXNzYWdpbmdcIiIsImZpZWxkcyI6WyJwcm9qZWN0Il0sIm9mZnNldCI6MCwidGltZWZyYW1lIjoiODY0MDAiLCJncmFwaG1vZGUiOiJjb3VudCIsInRpbWUiOnsidXNlcl9pbnRlcnZhbCI6MH0sInN0YW1wIjoxNDE3NTk3OTI2NzE2LCJtb2RlIjoiIiwiYW5hbHl6ZV9maWVsZCI6IiJ9 | 09:13 |
sileht | http://goo.gl/z8Ubbz | 09:14 |
*** i159 has joined #openstack-oslo | 09:20 | |
*** e0ne has joined #openstack-oslo | 09:24 | |
*** e0ne has quit IRC | 10:10 | |
*** alexpilotti has joined #openstack-oslo | 10:12 | |
*** e0ne has joined #openstack-oslo | 10:12 | |
*** andreykurilin_ has quit IRC | 10:14 | |
*** ihrachyshka has joined #openstack-oslo | 10:14 | |
*** arnaud__ has quit IRC | 10:26 | |
*** e0ne has quit IRC | 11:02 | |
*** e0ne_ has joined #openstack-oslo | 11:02 | |
*** e0ne has joined #openstack-oslo | 11:03 | |
*** i159_ has joined #openstack-oslo | 11:03 | |
*** i159 has quit IRC | 11:03 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Don't allow call with fanout target https://review.openstack.org/138684 | 11:19 |
*** k4n0 has quit IRC | 11:23 | |
*** dims has joined #openstack-oslo | 11:30 | |
*** takedakn has joined #openstack-oslo | 11:31 | |
*** ishant has quit IRC | 11:33 | |
*** takedakn has quit IRC | 11:36 | |
*** yamahata has joined #openstack-oslo | 11:37 | |
*** takedakn has joined #openstack-oslo | 11:38 | |
*** denis_makogon has joined #openstack-oslo | 11:52 | |
*** _amrith_ is now known as amrith | 11:54 | |
*** yamahata has quit IRC | 11:57 | |
*** takedakn has quit IRC | 12:50 | |
*** exploreshaifali has joined #openstack-oslo | 13:12 | |
*** takedakn has joined #openstack-oslo | 13:19 | |
openstackgerrit | Ilya Pekelny proposed openstack/oslo-specs: db: Alembic environment runner specification https://review.openstack.org/112842 | 13:19 |
*** pblaho has joined #openstack-oslo | 13:19 | |
*** bknudson1 has quit IRC | 13:21 | |
*** jaypipes is now known as jaypipes-afk | 13:34 | |
dhellmann | sileht: it looks like there were some errors in the release job: http://logs.openstack.org/5e/5ed43ae50ad6ef3539d029e4f72dcee1da94a221/ | 13:35 |
dhellmann | sileht: we should ask infra for suggestions about how to handle it | 13:35 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: NotifyPublisher need handle amqp_auto_delete https://review.openstack.org/138723 | 13:37 |
*** hogepodge has quit IRC | 13:37 | |
*** hogepodge has joined #openstack-oslo | 13:37 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: NotifyPublisher need handle amqp_auto_delete https://review.openstack.org/138723 | 13:38 |
sileht | dhellmann, ok thank | 13:39 |
*** oomichi has quit IRC | 13:40 | |
*** bknudson has joined #openstack-oslo | 13:40 | |
*** kgiusti has joined #openstack-oslo | 13:42 | |
*** takedakn has quit IRC | 13:43 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: Add a new aioeventlet executor https://review.openstack.org/136653 | 13:43 |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:54 | |
*** exploreshaifali has quit IRC | 13:57 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: Add a new aioeventlet executor https://review.openstack.org/136653 | 13:58 |
*** amrith is now known as _amrith_ | 13:59 | |
openstackgerrit | Julien Danjou proposed openstack/oslo.log: Replace RFCSysLogHandler by a syslog() based one https://review.openstack.org/136842 | 14:04 |
*** jeckersb_gone is now known as jeckersb | 14:05 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: Add a new aioeventlet executor https://review.openstack.org/136653 | 14:14 |
dhellmann | sileht: we might have to wait until the current issues with bandersnatch and the juno caps are resolved -- one problem at a time | 14:15 |
sileht | dhellmann, yep | 14:15 |
*** vigneshvar_ has quit IRC | 14:25 | |
*** mriedem has joined #openstack-oslo | 14:27 | |
openstackgerrit | Oleksii Chuprykov proposed openstack/oslo.db: Fix PatchStacktraceTest for pypy https://review.openstack.org/138746 | 14:31 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: RabbitMQ heartbeat implementation https://review.openstack.org/126330 | 14:40 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Rabbit: don't always start the heartbeart thread https://review.openstack.org/138325 | 14:40 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Add a info log when a reconnection occurs https://review.openstack.org/138411 | 14:40 |
*** jaypipes-afk is now known as jaypipes | 14:41 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Don't allow call with fanout target https://review.openstack.org/138684 | 14:41 |
*** dmitryme has left #openstack-oslo | 14:49 | |
*** _amrith_ is now known as amrith | 14:54 | |
*** dims has quit IRC | 15:04 | |
*** dims has joined #openstack-oslo | 15:04 | |
*** jamespage has joined #openstack-oslo | 15:10 | |
jamespage | dhellmann, sileht: up for a final review and landing for https://review.openstack.org/#/c/128233/ ? | 15:10 |
jamespage | I think I've addressed all your feedback | 15:10 |
dhellmann | jamespage: I'll put it on my review list | 15:11 |
jamespage | ta | 15:11 |
*** jecarey has joined #openstack-oslo | 15:16 | |
*** mtanino has joined #openstack-oslo | 15:24 | |
*** f13o has quit IRC | 15:36 | |
*** zz_jgrimm is now known as jgrimm | 15:39 | |
*** amotoki_ has joined #openstack-oslo | 15:43 | |
*** gordc has joined #openstack-oslo | 15:53 | |
*** tsekiyama has joined #openstack-oslo | 15:53 | |
*** stevemar has joined #openstack-oslo | 15:55 | |
openstackgerrit | ZhiQiang Fan proposed openstack/oslo.messaging: Keep __hash__ consistent with __eq__ https://review.openstack.org/138517 | 16:04 |
*** pblaho_ has joined #openstack-oslo | 16:04 | |
*** pblaho has quit IRC | 16:04 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: safe_log Sanitize Passwords in List of Dicts https://review.openstack.org/123759 | 16:09 |
*** jecarey has quit IRC | 16:13 | |
openstackgerrit | Victor Sergeyev proposed openstack/oslo.db: Ensure that create_engine() close test connection https://review.openstack.org/137001 | 16:15 |
*** jecarey has joined #openstack-oslo | 16:20 | |
*** pblaho__ has joined #openstack-oslo | 16:40 | |
*** pblaho_ has quit IRC | 16:40 | |
*** ihrachyshka has quit IRC | 16:43 | |
*** arnaud__ has joined #openstack-oslo | 16:48 | |
dhellmann | are any of the oslo.db folks around? I'm trying to understand what a test is trying to do, and I can't make sense of it | 16:48 |
*** i159_ has quit IRC | 16:53 | |
viktors|afk | dhellmann: I'm going to run away soon, but what test do you mean? | 17:03 |
*** viktors|afk is now known as viktors | 17:03 | |
dhellmann | viktors|afk: PatchStacktraceTest -- I figured out why it was failing after I moved everything into oslo_db, but I'm not sure how to fix it. | 17:04 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.db: Move files out of the namespace package https://review.openstack.org/138787 | 17:04 |
dhellmann | viktors: ^^ | 17:04 |
* viktors looking | 17:04 | |
*** prad has joined #openstack-oslo | 17:06 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Documents that wait the released driver resources https://review.openstack.org/138788 | 17:06 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Doc: 'wait' releases driver connection, not 'stop' https://review.openstack.org/138788 | 17:07 |
*** subscope has quit IRC | 17:08 | |
*** arnaud__ has quit IRC | 17:09 | |
*** sigmavirus24 has left #openstack-oslo | 17:09 | |
*** pblaho__ has quit IRC | 17:10 | |
viktors | dhellmann: it tests, that we keep debug information about the current stack trace | 17:10 |
viktors | see also https://review.openstack.org/#/c/106406 | 17:11 |
*** amrith is now known as _amrith_ | 17:11 | |
dhellmann | viktors: right, but the filter that's in place now for oslo_db means that the test file, after it is moved to oslo_db/tests/... is going to be filtered out, so that test will not work | 17:13 |
dhellmann | viktors: we still have the other copy of the test under /tests (and not in oslo_db) | 17:13 |
*** _amrith_ is now known as amrith | 17:14 | |
viktors | dhellmann: it seems to be, that assertion ("tests/sqlalchemy/test_sqlalchemy.py" in call[1][1]) will be correct after moving - same as ("oslo_db/tests/sqlalchemy/test_sqlalchemy.py" in call[1][1]) Or I get you in a wrong way? | 17:16 |
sileht | dhellmann, I made some bugs triaged on oslo.messaging today, I guess that a bug was fixed (but unsure due to the difficulty to reproduce it) is oslo.msg 1.5.0, should I mark it as Incomplete, because I need feedback, or do you prefer I mark it as 'Fix released' ? | 17:16 |
* sileht is thinking of https://bugs.launchpad.net/oslo.messaging/+bug/1362863 | 17:17 | |
dhellmann | viktors: http://git.openstack.org/cgit/openstack/oslo.db/tree/oslo/db/sqlalchemy/session.py#n623 | 17:18 |
dhellmann | viktors: that line and line 637 combined mean that anything under "oslo_db" is ignored | 17:19 |
dhellmann | sileht: if you think the fix is released, go ahead and mark it that way. If it's wrong, we'll find out from someone who can reproduce the problem. | 17:20 |
sileht | ok thanks | 17:20 |
*** noelbk has joined #openstack-oslo | 17:22 | |
viktors | dhellmann: got it, let me check with it https://review.openstack.org/#/c/138787/ | 17:22 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Doc: 'wait' releases driver connection, not 'stop' https://review.openstack.org/138788 | 17:23 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.db: Move files out of the namespace package https://review.openstack.org/138787 | 17:25 |
viktors | dhellmann: I have to go now, will look at your patch tomorrow | 17:33 |
dhellmann | viktors: ok, thanks | 17:34 |
*** viktors is now known as viktors|afk | 17:35 | |
openstackgerrit | Merged openstack/oslo-incubator: Add more to the release notes https://review.openstack.org/138439 | 17:39 |
*** jaypipes has quit IRC | 17:45 | |
*** hogepodge has quit IRC | 17:47 | |
*** hogepodge has joined #openstack-oslo | 17:49 | |
*** mriedem has quit IRC | 18:01 | |
*** harlowja_away is now known as harlowja_ | 18:04 | |
*** andreykurilin_ has joined #openstack-oslo | 18:07 | |
*** mriedem has joined #openstack-oslo | 18:16 | |
*** arnaud__ has joined #openstack-oslo | 18:16 | |
*** zzzeek has joined #openstack-oslo | 18:20 | |
*** exploreshaifali has joined #openstack-oslo | 18:26 | |
*** vigneshvar_ has joined #openstack-oslo | 18:33 | |
*** mriedem has quit IRC | 18:34 | |
dougwig | hi oslo. my CI exploded this morning, because keystone is using oslo_concurrency now, which isn't covered by the version range in requirements.txt (i think.) i fixed it by hand, but i think this is the real fix? https://review.openstack.org/#/c/138813/ | 18:43 |
*** yamahata has joined #openstack-oslo | 18:45 | |
*** mriedem has joined #openstack-oslo | 18:48 | |
dhellmann | dougwig: so keystone needs a newer version of oslo.concurrency than was listed in the global requirements? | 18:50 |
* morganfainberg feels a disturbance in the irc network. | 18:50 | |
*** bknudson has quit IRC | 18:50 | |
morganfainberg | dhellmann, we have a fix pending | 18:50 |
morganfainberg | but it's been fighting gate. | 18:50 |
morganfainberg | dhellmann, we did just block H302 until that fix lands. [should be merged] | 18:51 |
morganfainberg | block/ignore | 18:51 |
dhellmann | lifeless: are you around? I'm having an issue with testr giving me an error about importing a test base class from a module inside the installed package. I'm looking for a fix that doesn't involve renaming the file from test_base.py to something else. :/ | 18:51 |
dhellmann | morganfainberg: 302 is the "you're not importing a module" problem? | 18:52 |
morganfainberg | dhellmann, that was the oslo.concurrency issue i think. | 18:52 |
dhellmann | morganfainberg: because that should be fixed with the new hacking 0.9.4 | 18:52 |
morganfainberg | dhellmann, yeah. that fix to bump requirements was fighting gate - iirc | 18:52 |
morganfainberg | dhellmann, we had a quick "ignore h302" fix that landed more easily, will revert once the requirements is bumped hacking. | 18:53 |
morganfainberg | oooh | 18:53 |
morganfainberg | wait.. diff bug here | 18:53 |
* morganfainberg unwedges brain | 18:53 | |
morganfainberg | sorry | 18:53 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.db: Move files out of the namespace package https://review.openstack.org/138787 | 19:07 |
*** yamahata has quit IRC | 19:07 | |
*** andreykurilin__ has joined #openstack-oslo | 19:09 | |
*** andreykurilin_ has quit IRC | 19:09 | |
dougwig | dhellmann: yes, needed 1.3.0 | 19:20 |
dougwig | Jenkins didn't notice because the single use nodes grab the latest | 19:21 |
dhellmann | dougwig: ok, the other way to fix that is to make keystone degrade nicely with the older version of the library | 19:21 |
morganfainberg | dhellmann, that might be the easiest solution. (cc dougwig ) but either way works for me. | 19:22 |
dhellmann | dougwig, morganfainberg : what new feature of concurrency is needed? | 19:23 |
morganfainberg | dhellmann, unsure. | 19:23 |
morganfainberg | dhellmann, might be something new that was graduated to it? | 19:23 |
dougwig | I'm a neutron guy, I just noticed because my ci broke. | 19:23 |
dhellmann | could be | 19:24 |
dougwig | It's the namespace change | 19:24 |
morganfainberg | ah | 19:24 |
morganfainberg | yeah namespace change - thats a hard one to make work "nicely" with an older version | 19:24 |
morganfainberg | if it's broken. | 19:24 |
dhellmann | do you have a traceback? | 19:26 |
dhellmann | or is keystone using oslo_concurrency instead of oslo.concurrency now? | 19:26 |
dougwig | The latter | 19:29 |
dougwig | I'm at lunch, I can post a trace back in 45 mins | 19:29 |
dhellmann | dougwig: ok, if they updated to import using the new package name already then your requirements bump is accurate | 19:33 |
*** zzzeek has quit IRC | 19:41 | |
*** bknudson has joined #openstack-oslo | 19:41 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.db: Move files out of the namespace package https://review.openstack.org/138787 | 20:02 |
*** e0ne has quit IRC | 20:05 | |
*** ihrachyshka has joined #openstack-oslo | 20:24 | |
*** e0ne has joined #openstack-oslo | 20:40 | |
*** zzzeek has joined #openstack-oslo | 20:41 | |
*** sreshetnyak has quit IRC | 20:42 | |
*** sreshetnyak has joined #openstack-oslo | 20:42 | |
*** ihrachyshka has quit IRC | 20:43 | |
dougwig | dhellmann: my apologies, ceilometer, not keystone: | 20:44 |
dougwig | https://www.irccloud.com/pastebin/VoNavhz6 | 20:45 |
openstackgerrit | Merged openstack/taskflow: Add a sample script that can be used to build a test environment https://review.openstack.org/107506 | 21:01 |
*** amrith is now known as _amrith_ | 21:02 | |
dhellmann | dougwig: ok, same situation different app -- it still means we should bump the version, as your change proposes | 21:06 |
dougwig | right. | 21:06 |
*** ihrachyshka has joined #openstack-oslo | 21:09 | |
openstackgerrit | Sean Dague proposed openstack/oslo.messaging: Revert "Don't use oslo.cfg to set kombu in-memory driver" https://review.openstack.org/138863 | 21:10 |
dhellmann | dims, jd__, sileht : ^^ | 21:11 |
dhellmann | sileht: let's talk before releasing 1.5.1; I want to know what else has landed before we use that version number | 21:12 |
*** vigneshvar_ has quit IRC | 21:12 | |
*** denis_makogon_ has joined #openstack-oslo | 21:19 | |
*** exploreshaifali has quit IRC | 21:23 | |
openstackgerrit | Michael Bayer proposed openstack/oslo.db: Implement new oslo.db.sqlalchemy.enginefacade module https://review.openstack.org/138215 | 21:29 |
*** alexpilotti has quit IRC | 21:40 | |
*** denis_makogon has quit IRC | 21:40 | |
*** denis_makogon_ is now known as denis_makogon | 21:40 | |
*** dmakogon_ has joined #openstack-oslo | 21:40 | |
*** jgrimm is now known as zz_jgrimm | 21:46 | |
*** andreykurilin_ has joined #openstack-oslo | 21:53 | |
*** andreykurilin__ has quit IRC | 21:53 | |
*** ajo has quit IRC | 22:00 | |
*** prad has quit IRC | 22:00 | |
jd__ | dhellmann: hum that sounds like a joke, fake_rabbit is only used in oslo.messaging unit tests AFAIK | 22:03 |
dhellmann | jd__: it turns out many of the other projects were overriding that value in their unit tests | 22:03 |
jd__ | arf | 22:03 |
dhellmann | indeed | 22:03 |
jd__ | bad joke then :D | 22:03 |
sileht | dhellmann, , tomorrow I can propose a backward compatibilty patch that reintroduce fake_rabbit config option, but keep the new behavior for oslo.messaging unit tests | 22:03 |
dhellmann | yes, well, I've sent the angry mob in your direction | 22:03 |
jd__ | fair enogh | 22:04 |
jd__ | sileht: yeah sounds like a good plan | 22:04 |
dhellmann | sileht: that's fine, please comment on that review from sdague to that effect | 22:04 |
sileht | with deprecated path | 22:04 |
jd__ | another use case for flaper87 book about deprecation | 22:04 |
dhellmann | sileht, jd__ : we should also consider using a ConfigFilter to hide the options, but we'll have to look for other situations where unit tests are currently using them and provide an API or fixture or something for those tests | 22:06 |
sileht | dhellmann, ack | 22:07 |
sileht | so, good night | 22:08 |
dhellmann | sileht: good night, I'll watch for your patch tomorrow | 22:08 |
dhellmann | and thanks | 22:08 |
bnemec | dhellmann: sileht: It's worth noting that if we add a config filter to oslo.messaging it's likely to break a lot of unit tests. | 22:13 |
bnemec | It actually broke the oslo.concurrency lockutils tests because they assumed the options would be available in the global conf. | 22:13 |
dhellmann | bnemec: yes, I'm sure, that's why I said we should look at how they would break *before* adding it | 22:13 |
dhellmann | it may be a lot of work, and something we'd want to wait to do until next cycle | 22:13 |
bnemec | dhellmann: Ah, reading comprehension. Sorry. :-) | 22:14 |
dhellmann | bnemec: :-) | 22:16 |
*** jeckersb is now known as jeckersb_gone | 22:22 | |
*** _amrith_ is now known as amrith | 22:29 | |
*** ihrachyshka has quit IRC | 22:36 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.concurrency: Add a reader/writer lock https://review.openstack.org/138217 | 22:40 |
*** denis_makogon has quit IRC | 22:50 | |
openstackgerrit | Michael Bayer proposed openstack/oslo.db: Implement new oslo.db.sqlalchemy.enginefacade module https://review.openstack.org/138215 | 22:56 |
*** e0ne has quit IRC | 23:12 | |
*** bknudson has quit IRC | 23:19 | |
*** jecarey has quit IRC | 23:23 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.concurrency: Add a reader/writer lock https://review.openstack.org/138217 | 23:44 |
*** gordc has quit IRC | 23:47 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.concurrency: Add a reader/writer lock https://review.openstack.org/138217 | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!