| *** takedakn has quit IRC | 00:20 | |
| *** arnaud__ has quit IRC | 00:20 | |
| *** yamahata has quit IRC | 00:20 | |
| *** mtanino has quit IRC | 00:20 | |
| *** mtreinish has quit IRC | 00:20 | |
| *** vishy has quit IRC | 00:20 | |
| *** jokke_ has quit IRC | 00:20 | |
| *** sreshetnyak has quit IRC | 00:20 | |
| *** jraim has quit IRC | 00:20 | |
| *** hockeynut has quit IRC | 00:20 | |
| *** HenryG has quit IRC | 00:20 | |
| *** ttx has quit IRC | 00:20 | |
| *** jaypipes has quit IRC | 00:20 | |
| *** wendar has quit IRC | 00:20 | |
| *** viktors|afk has quit IRC | 00:20 | |
| *** zhiyan has quit IRC | 00:20 | |
| *** ajo has quit IRC | 00:20 | |
| *** boris-42 has quit IRC | 00:20 | |
| *** andreykurilin has quit IRC | 00:20 | |
| *** harlowja has quit IRC | 00:20 | |
| *** jgrimm has quit IRC | 00:20 | |
| *** tsekiyama has quit IRC | 00:20 | |
| *** anteaya has quit IRC | 00:20 | |
| *** ruhe has quit IRC | 00:20 | |
| *** dhellmann has quit IRC | 00:20 | |
| *** morganfainberg has quit IRC | 00:20 | |
| *** d0ugal has quit IRC | 00:20 | |
| *** mriedem has quit IRC | 00:20 | |
| *** tcammann has quit IRC | 00:20 | |
| *** bnemec has quit IRC | 00:20 | |
| *** ekarlso has quit IRC | 00:20 | |
| *** rodrigods has quit IRC | 00:20 | |
| *** palendae has quit IRC | 00:20 | |
| *** dims_ has quit IRC | 00:20 | |
| *** openstackgerrit has quit IRC | 00:20 | |
| *** sheeprine has quit IRC | 00:20 | |
| *** noelbk has quit IRC | 00:20 | |
| *** lifeless has quit IRC | 00:20 | |
| *** ujjain has quit IRC | 00:20 | |
| *** _amrith_ has quit IRC | 00:20 | |
| *** dougwig has quit IRC | 00:20 | |
| *** toabctl has quit IRC | 00:20 | |
| *** kevinbenton has quit IRC | 00:20 | |
| *** stevemar has quit IRC | 00:20 | |
| *** freyes has quit IRC | 00:20 | |
| *** sileht has quit IRC | 00:20 | |
| *** burgobianco has quit IRC | 00:20 | |
| *** jroll has quit IRC | 00:20 | |
| *** mgagne has quit IRC | 00:20 | |
| *** dmitryme has quit IRC | 00:20 | |
| *** AAzza_afk has quit IRC | 00:20 | |
| *** amaurymedeiros has quit IRC | 00:20 | |
| *** jamespage has quit IRC | 00:20 | |
| *** flaper87 has quit IRC | 00:20 | |
| *** lbragstad has quit IRC | 00:20 | |
| *** sigmavirus24_awa has quit IRC | 00:20 | |
| *** redrobot has quit IRC | 00:20 | |
| *** jd__ has quit IRC | 00:20 | |
| *** gus has quit IRC | 00:20 | |
| *** russellb has quit IRC | 00:20 | |
| *** SergeyLukjanov has quit IRC | 00:20 | |
| *** tsufiev has quit IRC | 00:20 | |
| *** BAKfr has quit IRC | 00:20 | |
| *** yamahata_ has quit IRC | 00:20 | |
| *** bogdando has quit IRC | 00:20 | |
| *** kragniz has quit IRC | 00:20 | |
| *** SlickNik has quit IRC | 00:20 | |
| *** r1chardj0n3s has quit IRC | 00:20 | |
| *** therve has quit IRC | 00:20 | |
| *** cburgess has quit IRC | 00:20 | |
| *** gmurphy has quit IRC | 00:20 | |
| *** ozamiatin has quit IRC | 00:20 | |
| *** dteselkin has quit IRC | 00:20 | |
| *** krotscheck has quit IRC | 00:20 | |
| *** jogo has quit IRC | 00:20 | |
| *** jeckersb_gone has quit IRC | 00:20 | |
| *** tristanC has quit IRC | 00:20 | |
| *** dstanek has quit IRC | 00:20 | |
| *** kevinbenton has joined #openstack-oslo | 00:27 | |
| *** toabctl has joined #openstack-oslo | 00:27 | |
| *** dougwig has joined #openstack-oslo | 00:27 | |
| *** _amrith_ has joined #openstack-oslo | 00:27 | |
| *** ujjain has joined #openstack-oslo | 00:27 | |
| *** lifeless has joined #openstack-oslo | 00:27 | |
| *** noelbk has joined #openstack-oslo | 00:27 | |
| *** takedakn has joined #openstack-oslo | 00:27 | |
| *** yamahata has joined #openstack-oslo | 00:27 | |
| *** dims_ has joined #openstack-oslo | 00:27 | |
| *** boris-42 has joined #openstack-oslo | 00:27 | |
| *** arnaud__ has joined #openstack-oslo | 00:27 | |
| *** stevemar has joined #openstack-oslo | 00:27 | |
| *** mriedem has joined #openstack-oslo | 00:27 | |
| *** freyes has joined #openstack-oslo | 00:27 | |
| *** andreykurilin has joined #openstack-oslo | 00:27 | |
| *** ozamiatin has joined #openstack-oslo | 00:27 | |
| *** sileht has joined #openstack-oslo | 00:27 | |
| *** openstackgerrit has joined #openstack-oslo | 00:27 | |
| *** hockeynut has joined #openstack-oslo | 00:27 | |
| *** HenryG has joined #openstack-oslo | 00:27 | |
| *** ttx has joined #openstack-oslo | 00:27 | |
| *** jaypipes has joined #openstack-oslo | 00:27 | |
| *** ajo has joined #openstack-oslo | 00:27 | |
| *** burgobianco has joined #openstack-oslo | 00:27 | |
| *** jroll has joined #openstack-oslo | 00:27 | |
| *** tcammann has joined #openstack-oslo | 00:27 | |
| *** mgagne has joined #openstack-oslo | 00:27 | |
| *** mtreinish has joined #openstack-oslo | 00:27 | |
| *** sheeprine has joined #openstack-oslo | 00:27 | |
| *** harlowja has joined #openstack-oslo | 00:27 | |
| *** morganfainberg has joined #openstack-oslo | 00:27 | |
| *** dmitryme has joined #openstack-oslo | 00:27 | |
| *** wendar has joined #openstack-oslo | 00:27 | |
| *** bnemec has joined #openstack-oslo | 00:27 | |
| *** rodrigods has joined #openstack-oslo | 00:27 | |
| *** AAzza_afk has joined #openstack-oslo | 00:27 | |
| *** viktors|afk has joined #openstack-oslo | 00:27 | |
| *** dteselkin has joined #openstack-oslo | 00:27 | |
| *** amaurymedeiros has joined #openstack-oslo | 00:27 | |
| *** jeckersb_gone has joined #openstack-oslo | 00:27 | |
| *** jamespage has joined #openstack-oslo | 00:27 | |
| *** anteaya has joined #openstack-oslo | 00:27 | |
| *** vishy has joined #openstack-oslo | 00:27 | |
| *** zhiyan has joined #openstack-oslo | 00:27 | |
| *** d0ugal has joined #openstack-oslo | 00:27 | |
| *** flaper87 has joined #openstack-oslo | 00:27 | |
| *** jokke_ has joined #openstack-oslo | 00:27 | |
| *** sreshetnyak has joined #openstack-oslo | 00:27 | |
| *** jgrimm has joined #openstack-oslo | 00:27 | |
| *** lbragstad has joined #openstack-oslo | 00:27 | |
| *** sigmavirus24_awa has joined #openstack-oslo | 00:27 | |
| *** ruhe has joined #openstack-oslo | 00:27 | |
| *** jraim has joined #openstack-oslo | 00:27 | |
| *** redrobot has joined #openstack-oslo | 00:27 | |
| *** BAKfr has joined #openstack-oslo | 00:27 | |
| *** dhellmann has joined #openstack-oslo | 00:27 | |
| *** jd__ has joined #openstack-oslo | 00:27 | |
| *** krotscheck has joined #openstack-oslo | 00:27 | |
| *** jogo has joined #openstack-oslo | 00:27 | |
| *** yamahata_ has joined #openstack-oslo | 00:27 | |
| *** ekarlso has joined #openstack-oslo | 00:27 | |
| *** tristanC has joined #openstack-oslo | 00:27 | |
| *** bogdando has joined #openstack-oslo | 00:27 | |
| *** gus has joined #openstack-oslo | 00:27 | |
| *** dstanek has joined #openstack-oslo | 00:27 | |
| *** kragniz has joined #openstack-oslo | 00:27 | |
| *** palendae has joined #openstack-oslo | 00:27 | |
| *** russellb has joined #openstack-oslo | 00:27 | |
| *** SergeyLukjanov has joined #openstack-oslo | 00:27 | |
| *** tsufiev has joined #openstack-oslo | 00:27 | |
| *** SlickNik has joined #openstack-oslo | 00:27 | |
| *** r1chardj0n3s has joined #openstack-oslo | 00:27 | |
| *** therve has joined #openstack-oslo | 00:27 | |
| *** cburgess has joined #openstack-oslo | 00:27 | |
| *** gmurphy has joined #openstack-oslo | 00:27 | |
| *** dims_ has quit IRC | 00:36 | |
| *** dims has joined #openstack-oslo | 00:36 | |
| *** dims has quit IRC | 00:40 | |
| *** takedakn has quit IRC | 00:47 | |
| *** bknudson has joined #openstack-oslo | 00:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/130088 | 00:50 |
|---|---|---|
| *** bknudson has quit IRC | 00:53 | |
| *** _amrith_ is now known as amrith | 00:59 | |
| amaurymedeiros | harlowja, is safe_utils.py (from ironic and nova) automatically synced with funcutils.py from oslo? i'm asking because so far i didn't find any usages of funcutils' getcallargs... and I'm wondering why not removing it | 01:04 |
| harlowja | i don't think so | 01:05 |
| harlowja | does anyone import funcutils? | 01:05 |
| harlowja | funcutils doesn't seem directly imported, but it could be a transitive dependency that is getting pulled in | 01:06 |
| harlowja | at least in https://github.com/openstack/nova/blob/master/openstack-common.conf#L3 (which defines all of this) | 01:06 |
| amaurymedeiros | I'm still looking... but so far i didn't see it being used | 01:06 |
| *** bknudson has joined #openstack-oslo | 01:06 | |
| amaurymedeiros | still need to check some projects | 01:06 |
| harlowja | grep for import funcutils ? | 01:08 |
| harlowja | if not used, then can probably get rid of it | 01:09 |
| harlowja | *if thats what people want to do | 01:09 |
| amaurymedeiros | yah, i'm cloning openstack/openstack so I can grep all projects at the same time | 01:10 |
| *** jgrimm is now known as zz_jgrimm | 01:10 | |
| harlowja | kk | 01:11 |
| harlowja | the hard part is that its also stackforge and such | 01:11 |
| harlowja | hard to know who's using it , although i think dhellmann did some analysis | 01:11 |
| harlowja | *similar analysis to what u are doing | 01:12 |
| amaurymedeiros | oh | 01:12 |
| amaurymedeiros | do you know the result of that? | 01:13 |
| harlowja | not off the top of my head | 01:13 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Mark 'task_notifier' as renamed to 'atom_notifier' https://review.openstack.org/103286 | 01:13 |
| *** amotoki has joined #openstack-oslo | 01:14 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 01:17 | |
| amaurymedeiros | harlowja, i generated the urls for each project in the format: https://github.com/openstack/project_name/search?utf8=%E2%9C%93&q=funcutils and visited them manually. The only project that returned results was oslo-incubador | 01:32 |
| amaurymedeiros | may i submit a patch removing the module? | 01:33 |
| harlowja | sure, see what happens, dhellmann and others might be able to comment on the review saying why it shouldn't happen | 01:35 |
| amaurymedeiros | ok | 01:37 |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 01:38 | |
| *** stevemar has quit IRC | 01:49 | |
| *** stevemar has joined #openstack-oslo | 01:50 | |
| *** sheeprine has quit IRC | 02:03 | |
| openstackgerrit | Amaury Medeiros proposed a change to openstack/oslo-incubator: Remove unused module funcutils.py https://review.openstack.org/130092 | 02:03 |
| *** sheeprine has joined #openstack-oslo | 02:05 | |
| amaurymedeiros | harlowja, submitted the patch and added dhellmann as a reviewer... is that a problem? if so, i can remove him | 02:11 |
| *** arnaud__ has quit IRC | 02:27 | |
| *** amrith is now known as _amrith_ | 02:30 | |
| *** mriedem has left #openstack-oslo | 02:35 | |
| *** mriedem has quit IRC | 02:35 | |
| *** harlowja is now known as harlowja_away | 02:43 | |
| zhiyan | jd__: jd hi still around? | 02:58 |
| *** yamahata has quit IRC | 03:25 | |
| *** jamespage has quit IRC | 04:00 | |
| *** arnaud__ has joined #openstack-oslo | 04:00 | |
| *** jamespage has joined #openstack-oslo | 04:00 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 04:06 | |
| *** yamahata has joined #openstack-oslo | 04:08 | |
| *** harlowja_at_home has joined #openstack-oslo | 04:36 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo-specs: Add a spec for a oslo.config dictionary based config opts https://review.openstack.org/130047 | 04:55 |
| *** takedakn has joined #openstack-oslo | 05:01 | |
| *** harlowja_at_home has quit IRC | 05:18 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/oslotest: Clean up the docs for oslo_debug_helper https://review.openstack.org/130118 | 05:20 |
| *** eezhova has quit IRC | 05:31 | |
| *** k4n0 has joined #openstack-oslo | 05:36 | |
| *** eezhova has joined #openstack-oslo | 05:42 | |
| *** ihrachyshka has joined #openstack-oslo | 05:43 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 05:47 | |
| *** noelbk has quit IRC | 06:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.concurrency: Imported Translations from Transifex https://review.openstack.org/130129 | 06:14 |
| *** ihrachyshka has quit IRC | 06:16 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/128566 | 06:17 |
| jd__ | zhiyan: "still", well it's morning :) | 06:25 |
| *** takedakn has quit IRC | 06:31 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 06:43 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add and use a new simple helper logging module https://review.openstack.org/123007 | 06:55 |
| *** ihrachyshka has joined #openstack-oslo | 06:58 | |
| *** ihrachyshka has quit IRC | 07:03 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add and use a new simple helper logging module https://review.openstack.org/123007 | 07:04 |
| *** exploreshaifali has joined #openstack-oslo | 07:32 | |
| *** AAzzal has joined #openstack-oslo | 07:33 | |
| *** AAzzal is now known as AAzza | 07:33 | |
| *** AAzzal has joined #openstack-oslo | 07:34 | |
| *** AAzza_afk has quit IRC | 07:36 | |
| *** AAzza has quit IRC | 07:37 | |
| *** AAzzal is now known as AAzza | 07:37 | |
| *** arnaud__ has quit IRC | 07:39 | |
| *** e0ne has joined #openstack-oslo | 07:39 | |
| *** stevemar has quit IRC | 07:40 | |
| *** e0ne has quit IRC | 07:45 | |
| *** AAzza is now known as AAzza_afk | 07:46 | |
| *** andreykurilin_ has joined #openstack-oslo | 07:49 | |
| *** pblaho has joined #openstack-oslo | 07:55 | |
| *** AAzza_afk is now known as AAzza | 08:10 | |
| *** alexpilotti has joined #openstack-oslo | 08:11 | |
| jd__ | people asking if you are around and not replying if you are | 08:20 |
| *** yamahata has quit IRC | 08:20 | |
| *** andreykurilin_ has quit IRC | 08:26 | |
| *** viktors|afk is now known as viktors | 08:51 | |
| *** e0ne has joined #openstack-oslo | 08:59 | |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/oslo.messaging: safe_log Sanitize Passwords in List of Dicts https://review.openstack.org/123759 | 09:00 |
| openstackgerrit | A change was merged to openstack/oslo-incubator: Add middleware.request_id shim for Kilo https://review.openstack.org/129858 | 09:06 |
| *** exploreshaifali has quit IRC | 09:28 | |
| *** exploreshaifali has joined #openstack-oslo | 09:29 | |
| *** myatsenko has joined #openstack-oslo | 09:31 | |
| *** ozamiatin has quit IRC | 09:41 | |
| *** alexpilotti has quit IRC | 09:43 | |
| *** alexpilotti has joined #openstack-oslo | 09:48 | |
| *** ihrachyshka has joined #openstack-oslo | 09:52 | |
| *** e0ne_ has joined #openstack-oslo | 10:02 | |
| *** e0ne has quit IRC | 10:04 | |
| *** myatsenko has quit IRC | 10:16 | |
| *** yamahata has joined #openstack-oslo | 10:22 | |
| *** dims has joined #openstack-oslo | 10:36 | |
| *** dims has quit IRC | 10:39 | |
| *** dims has joined #openstack-oslo | 10:39 | |
| *** exploreshaifali has quit IRC | 10:45 | |
| *** _amrith_ is now known as amrith | 10:49 | |
| *** amotoki has quit IRC | 10:59 | |
| *** exploreshaifali has joined #openstack-oslo | 11:03 | |
| *** exploreshaifali has quit IRC | 11:24 | |
| *** i159 has joined #openstack-oslo | 11:32 | |
| *** exploreshaifali has joined #openstack-oslo | 11:44 | |
| *** e0ne_ has quit IRC | 11:55 | |
| *** kgiusti has joined #openstack-oslo | 12:07 | |
| zhiyan | jd__: i'm just back to near the keyboard. sorry for the delay, i leave the IRC for other work early before your replied my first msg. | 12:14 |
| zhiyan | jd__: i can't stay here for 2 hours to continue check the reply. | 12:15 |
| *** amrith is now known as _amrith_ | 12:19 | |
| *** amotoki has joined #openstack-oslo | 12:27 | |
| jd__ | zhiyan: ah sorry I didn't have the correct timestamp of your message! | 12:39 |
| zhiyan | jd__: ok, np. | 12:39 |
| *** miqui has joined #openstack-oslo | 12:40 | |
| zhiyan | jd__: if you ok, i want to talk about https://review.openstack.org/#/c/128881/2//COMMIT_MSG with you due to it has a -1 from you, and it blocked oslo-inc syncup with glance. | 12:40 |
| zhiyan | jd__: can i speed it up a little? | 12:40 |
| jd__ | let me review the change and I'll get back to you on Gerrit I think | 12:42 |
| zhiyan | jd__: thanks | 12:42 |
| jd__ | zhiyan: so just to be sure I got things clear | 12:49 |
| jd__ | what you do in Glance is that you have different Enforcer/Rules object depending on what you do, and what you want for your example of ProtectProperty is to have a Rules that also have the more general rules loaded in it? | 12:50 |
| zhiyan | jd__: sorry i don't followed frankly | 12:51 |
| jd__ | zhiyan: ok, no problem it's not very clear to me either so I'm trying to ask questions that make sense but it's not necessary obvious | 12:52 |
| jd__ | zhiyan: so you actually use several Rules or Enforce object in Glance or just one? | 12:52 |
| zhiyan | jd__: currently in glance domain model, in normal/designed path (e.g. no exception happen), there's only one. | 12:53 |
| *** jeckersb_gone is now known as jeckersb | 12:53 | |
| jd__ | ok, and with that patch you could have several? | 12:54 |
| zhiyan | jd__: andI think it's a sensible and appropriate design | 12:54 |
| jd__ | or you still plan on using one only | 12:54 |
| zhiyan | jd__: only one. which followed the current design | 12:54 |
| jd__ | zhiyan: ok, so what you want to do is load custom rules, and then load default rules without overwriting? | 12:55 |
| zhiyan | jd__: yes | 12:55 |
| jd__ | ok I think I see what you want to do and why you can't do it | 12:55 |
| zhiyan | imo, default rules = policy.json | 12:55 |
| zhiyan | custom rules = ProtectProperty feature provided rules from the image | 12:56 |
| jd__ | and is there other things features like ProtectProperty that have their own set of rules? | 12:57 |
| zhiyan | jd__: there's no others in my mind now | 12:58 |
| jd__ | ok cool! | 12:59 |
| jd__ | zhiyan: so I'm just gonna suggest a different approach that'll do the same | 12:59 |
| jd__ | replied on Gerrit | 13:00 |
| jd__ | that should make a saner API and fix your problem | 13:00 |
| *** jaosorior has joined #openstack-oslo | 13:01 | |
| *** bknudson has quit IRC | 13:01 | |
| *** gordc has joined #openstack-oslo | 13:01 | |
| ihrachyshka | dhellmann: hey. I'm considering adding support for automatic thread pool resize for eventlet executor. do I need to post a spec for that? | 13:02 |
| *** stevemar has joined #openstack-oslo | 13:03 | |
| *** e0ne has joined #openstack-oslo | 13:07 | |
| *** dims has quit IRC | 13:09 | |
| *** dims has joined #openstack-oslo | 13:10 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:16 | |
| *** pblaho has quit IRC | 13:20 | |
| *** bknudson has joined #openstack-oslo | 13:21 | |
| *** dims has quit IRC | 13:25 | |
| *** dims has joined #openstack-oslo | 13:26 | |
| *** dims has quit IRC | 13:26 | |
| *** dims has joined #openstack-oslo | 13:27 | |
| *** dims has quit IRC | 13:27 | |
| *** dims has joined #openstack-oslo | 13:29 | |
| *** dims has quit IRC | 13:29 | |
| *** mriedem has joined #openstack-oslo | 13:31 | |
| *** stevemar has quit IRC | 13:31 | |
| *** sheeprine has quit IRC | 13:33 | |
| *** dims has joined #openstack-oslo | 13:36 | |
| *** exploreshaifali has quit IRC | 13:39 | |
| *** zz_jgrimm is now known as jgrimm | 13:44 | |
| *** jecarey has joined #openstack-oslo | 13:44 | |
| *** jeckersb is now known as jeckersb_gone | 13:47 | |
| *** amotoki has quit IRC | 13:52 | |
| *** bknudson has quit IRC | 13:52 | |
| *** yamahata has quit IRC | 13:55 | |
| *** yamahata has joined #openstack-oslo | 13:55 | |
| *** AAzza has quit IRC | 13:57 | |
| *** _amrith_ is now known as amrith | 13:59 | |
| *** AAzza has joined #openstack-oslo | 14:01 | |
| *** exploreshaifali has joined #openstack-oslo | 14:01 | |
| *** bknudson has joined #openstack-oslo | 14:06 | |
| *** jeckersb_gone is now known as jeckersb | 14:14 | |
| *** k4n0 has quit IRC | 14:17 | |
| dhellmann | ihrachyshka: I think so, yeah. | 14:20 |
| amaurymedeiros | dhellmann, I added you as a reviewer for this commit https://review.openstack.org/#/c/130092/ because harlowja_away mentioned that you might know reasons why the change shouldn't be done | 14:29 |
| ihrachyshka | dhellmann: with my stable maint hat on, I would like someone from oslo team to check https://review.openstack.org/129278 since it seems the patch cures failures in stable branches (in rpc module that is not present in master) | 14:32 |
| *** tsekiyama has joined #openstack-oslo | 14:34 | |
| *** stevemar has joined #openstack-oslo | 14:36 | |
| dhellmann | amaurymedeiros: looking | 14:36 |
| *** mtanino has joined #openstack-oslo | 14:37 | |
| dhellmann | amaurymedeiros: I have become generally suspicious of statements like "no one is using it" because we've thought that about other modules in the past. Are you absolutely certain? | 14:37 |
| dhellmann | ihrachyshka: looking | 14:41 |
| dhellmann | ihrachyshka: is there some way to trigger that case in a test? | 14:43 |
| dhellmann | the fix looks fine, but if we can test it directly that would be good, too | 14:43 |
| ihrachyshka | dhellmann: I don't know, maybe playing with ready_callback() that would sleep and yield to main thread that would kill the spawned service before we get to self.stop() would do the job. I'll explore that. thanks. | 14:54 |
| amaurymedeiros | dhellmann, I wrote a script to generate the urls https://github.com/openstack/project_name/search?utf8=%E2%9C%93&q=funcutils and https://github.com/openstack-dev/project_name/search?utf8=%E2%9C%93&q=funcutils | 14:58 |
| amaurymedeiros | after that I opened each url manually to check matching code | 14:58 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/oslo.messaging: Add driver independent functional tests https://review.openstack.org/84164 | 14:59 |
| amaurymedeiros | the only project that matches a use of funcutils is oslo-incubator | 14:59 |
| *** amotoki has joined #openstack-oslo | 15:00 | |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/oslo.messaging: Add driver independent functional tests https://review.openstack.org/84164 | 15:07 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/oslo.messaging: Prelimary functional tests in Gate https://review.openstack.org/130243 | 15:11 |
| *** dims_ has joined #openstack-oslo | 15:11 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add and use a new simple helper logging module https://review.openstack.org/123007 | 15:12 |
| *** dims__ has joined #openstack-oslo | 15:14 | |
| *** dims has quit IRC | 15:15 | |
| *** dims_ has quit IRC | 15:16 | |
| *** exploreshaifali has quit IRC | 15:17 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add and use a new simple helper logging module https://review.openstack.org/123007 | 15:18 |
| *** zzzeek has joined #openstack-oslo | 15:20 | |
| dhellmann | amaurymedeiros: the other solution to that problem is find the places with similar functions that led to the module being created, and update the projects to use the module instead of their local copy | 15:31 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/oslo.messaging: Prelimary functional tests in Gate https://review.openstack.org/130243 | 15:32 |
| *** amrith is now known as _amrith_ | 15:41 | |
| *** _amrith_ is now known as amrith | 15:44 | |
| amaurymedeiros | dhellmann, i'm not sure it's worth... this module contains a getcallargs implementation, which can be replaced by inspect.getcallargs in python 2.7+ and kilo will drop python 2.6 support | 15:46 |
| amaurymedeiros | i believe that's the reason the other projects doesn't use the module (nor their copy) anymore. some projects, such as nova and keystone (https://github.com/openstack/keystone/blob/master/keystone/notifications.py#L58) simply implement a try/except block. i assume the except block will be dropped after kilo is launched | 15:46 |
| dhellmann | amaurymedeiros: the oslo libraries have to keep python 2.6 support until the stable branches are no longer using python 2.6 | 15:46 |
| ihrachyshka | dhellmann: are we to drop py26 for clients?.. | 15:47 |
| ihrachyshka | dhellmann: I thought no, and those may rely on py26 | 15:47 |
| dhellmann | ihrachyshka: no, the clients will also need to maintain 2.6 support for the same period of time, since they are used in the services | 15:47 |
| ihrachyshka | dhellmann: so if a module is used in any client, it should not loose py26 support even if stable releases are all >= kilo | 15:48 |
| *** kgiusti has quit IRC | 15:48 | |
| amaurymedeiros | dhellmann, the patch does not remove 2.6 support... funcutils itself is not being used although i don't know why | 15:53 |
| *** exploreshaifali has joined #openstack-oslo | 16:02 | |
| bnemec | dhellmann: amaurymedeiros: I commented on that review. | 16:08 |
| *** arnaud__ has joined #openstack-oslo | 16:12 | |
| *** noelbk has joined #openstack-oslo | 16:15 | |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Organize provisioning to use testresources https://review.openstack.org/120870 | 16:47 |
| *** i159 has quit IRC | 16:54 | |
| morganfainberg | dhellmann: let's talk caching at the summit. | 16:54 |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo.messaging: Automatically expand and shrink eventlet greenpool https://review.openstack.org/130278 | 16:54 |
| morganfainberg | We can hash out a straw man or anything else and j can update the spec after. | 16:54 |
| morganfainberg | Hallway track meeting :) | 16:55 |
| *** andreykurilin_ has joined #openstack-oslo | 17:01 | |
| amaurymedeiros | bnemec, thanks | 17:01 |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Organize provisioning to use testresources https://review.openstack.org/120870 | 17:02 |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Reorganize DbTestCase to use provisioning completely https://review.openstack.org/110170 | 17:02 |
| *** ihrachyshka has quit IRC | 17:07 | |
| *** amotoki has quit IRC | 17:07 | |
| zhiyan | jd__: hi, I replied your inputs at https://review.openstack.org/#/c/128881/2/openstack/common/policy.py , pls let me know if you think it's sensible when/if you ok. thanks. | 17:11 |
| *** yamahata has quit IRC | 17:15 | |
| *** harlowja_away is now known as harlowja | 17:16 | |
| *** kgiusti has joined #openstack-oslo | 17:17 | |
| *** arnaud__ has quit IRC | 17:22 | |
| *** zzzeek has quit IRC | 17:33 | |
| *** dims__ has quit IRC | 17:45 | |
| *** dims has joined #openstack-oslo | 17:45 | |
| *** dims has quit IRC | 17:46 | |
| *** dims has joined #openstack-oslo | 17:46 | |
| *** arnaud__ has joined #openstack-oslo | 17:59 | |
| *** andreykurilin_ has quit IRC | 18:01 | |
| *** vigneshvar has joined #openstack-oslo | 18:04 | |
| *** vigneshvar has quit IRC | 18:04 | |
| *** dims has quit IRC | 18:07 | |
| *** dims has joined #openstack-oslo | 18:08 | |
| *** AJaeger_ has joined #openstack-oslo | 18:12 | |
| AJaeger_ | I'm currently syncing oslo-incubator to manila and get the following error from lockutils.py in the testsuite: | 18:13 |
| AJaeger_ | RequiredOptError: value required for option: lock_path | 18:13 |
| AJaeger_ | What do I have to change in manila to fix this? This surprised me... | 18:13 |
| AJaeger_ | looking at lockutils.py I'm confused ;( and would appreciate some hints | 18:14 |
| *** andreykurilin_ has joined #openstack-oslo | 18:17 | |
| dhellmann | bnemec, amaurymedeiros: so we brought a module into the incubator but no one adopted it before it became obsolete? | 18:18 |
| dhellmann | bnemec, amaurymedeiros, ihrachyshka: http://lists.openstack.org/pipermail/openstack-dev/2014-October/048999.html | 18:18 |
| dhellmann | AJaeger_: it looks like you either have to pass a lock path in or call lockutils.set_defaults() to provide a default for the option. There is no good way to provide a safe default for that value because your app needs to know it, but it should be secret and different from the other apps | 18:22 |
| dhellmann | AJaeger_: also be aware that lockutils is moving to oslo.concurrency during kilo | 18:23 |
| AJaeger_ | dhellmann: I'm currently obsoleting the *deprecated* modules in manila. | 18:23 |
| AJaeger_ | Moving to new modules comes later ;) | 18:23 |
| AJaeger_ | Thanks for the hint, will look into that. | 18:24 |
| AJaeger_ | Is it already ok to use oslo.concurrency in projects? | 18:24 |
| *** jgrimm is now known as zz_jgrimm | 18:26 | |
| dhellmann | AJaeger_: no, we haven't cut a release yet | 18:30 |
| *** ibravo has joined #openstack-oslo | 18:30 | |
| dhellmann | AJaeger_: I need to talk to bnemec about whether we're ready (I think so) | 18:30 |
| AJaeger_ | dhellmann: no need to rush it, I need to fix this first ;) | 18:31 |
| dhellmann | AJaeger_: :-) | 18:31 |
| AJaeger_ | seems this came in with commit 942e1aafbab06dbf128e9790a1976c92bcf659fb on 2nd of september - and no project has merged yet, I can't find a project that uses set_defaults... | 18:32 |
| *** e0ne has quit IRC | 18:33 | |
| *** andreykurilin_ has quit IRC | 18:34 | |
| *** zz_jgrimm is now known as jgrimm | 18:35 | |
| *** andreykurilin_ has joined #openstack-oslo | 18:37 | |
| *** andreykurilin_ has quit IRC | 18:41 | |
| *** AAzza is now known as AAzza_afk | 18:51 | |
| AJaeger_ | dhellmann, bnemec where would I call lockutils.set_defaults? | 19:01 |
| *** exploreshaifali has quit IRC | 19:04 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/130322 | 19:16 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/130088 | 19:16 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.config: Updated from global requirements https://review.openstack.org/130323 | 19:16 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Updated from global requirements https://review.openstack.org/130324 | 19:16 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.i18n: Updated from global requirements https://review.openstack.org/130325 | 19:16 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.log: Updated from global requirements https://review.openstack.org/130326 | 19:16 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/130327 | 19:16 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.middleware: Updated from global requirements https://review.openstack.org/130328 | 19:16 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.serialization: Updated from global requirements https://review.openstack.org/127782 | 19:16 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.utils: Updated from global requirements https://review.openstack.org/127783 | 19:16 |
| dhellmann | AJaeger_: somewhere in your app startup code, around where the config object is initialized | 19:17 |
| dhellmann | AJaeger_: it can be before or after | 19:17 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/stevedore: Updated from global requirements https://review.openstack.org/127795 | 19:17 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/taskflow: Updated from global requirements https://review.openstack.org/130332 | 19:17 |
| *** AAzza_afk is now known as AAzza | 19:18 | |
| *** jaosorior has quit IRC | 19:23 | |
| *** kgiusti has quit IRC | 19:26 | |
| *** noelbk has quit IRC | 19:26 | |
| *** noelbk has joined #openstack-oslo | 19:27 | |
| *** dims has quit IRC | 19:29 | |
| *** dims has joined #openstack-oslo | 19:30 | |
| *** e0ne has joined #openstack-oslo | 19:30 | |
| *** arnaud has joined #openstack-oslo | 19:31 | |
| *** kgiusti has joined #openstack-oslo | 19:33 | |
| *** dims has quit IRC | 19:34 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Mark 'task_notifier' as renamed to 'atom_notifier' https://review.openstack.org/103286 | 19:40 |
| AJaeger_ | dhellmann: I called lockutils.set_defaults in tests.py and that fixed the testsuite run - but I'm puzzled that I don't need to set it elsewhere. Temptest runs passed... | 19:41 |
| *** AAzza is now known as AAzza_afk | 19:51 | |
| *** e0ne has quit IRC | 19:52 | |
| *** exploreshaifali has joined #openstack-oslo | 19:57 | |
| *** dims has joined #openstack-oslo | 19:57 | |
| *** e0ne has joined #openstack-oslo | 20:00 | |
| *** e0ne has quit IRC | 20:00 | |
| *** amrith is now known as _amrith_ | 20:09 | |
| bnemec | dhellmann: Yeah, we should be ready to go on oslo.concurrency. I've been meaning to talk to you about it. | 20:10 |
| bnemec | dhellmann: I'm not sure what happened with funcutils. According to the commit history it was brought in because projects were copying it from Nova, but I can't really see where that has happened. | 20:10 |
| bnemec | I think the projects that have it (besides Nova) basically pulled it in as part of Nova's utils.py. | 20:11 |
| *** AAzza_afk is now known as AAzza | 20:15 | |
| AJaeger_ | bnemec, dhellmann: I think now that my change to test.py will handle the testsuite - and if the admin installing manila will set lock_path, everything should be fine as well. | 20:17 |
| AJaeger_ | But then this should be a mandatory setting. | 20:17 |
| amaurymedeiros | dhellmann, maybe funcutils was done aiming to put shared code, but time passed and nobody identified functions to be put there... | 20:18 |
| AJaeger_ | and calling set_defaults from the application itself seems wrong since this overrides the value | 20:18 |
| bnemec | AJaeger_: It is mandatory. lockutils will raise an exception if it's not set somehow. | 20:18 |
| *** AAzza is now known as AAzza_afk | 20:18 | |
| AJaeger_ | bnemec: that's what I noticed ;) But it was not the case in the old code, this changd recently (your commit from 2nd September) | 20:19 |
| bnemec | I'm not entirely sure set_defaults makes much sense for it. | 20:19 |
| AJaeger_ | bnemec: set_defaults is used by the testsuite... | 20:19 |
| AJaeger_ | bnemec: should we change the help string? It reads: | 20:19 |
| AJaeger_ | "Directory to use for lock files." | 20:19 |
| bnemec | AJaeger_: Well, it's been required off and on for close to a year. There was a period of time where we tried posix semaphores instead, but that had issues so we went back to file locks. | 20:19 |
| AJaeger_ | Perhaps "(Mandatory) Directory to use for lock files." | 20:20 |
| bnemec | AJaeger_: Seems like a good idea. | 20:21 |
| AJaeger_ | bnemec: do you want a patch for both concurrency and incubator? | 20:21 |
| bnemec | AJaeger_: Just concurrency. The incubator code is going away as soon as we release the lib. | 20:21 |
| AJaeger_ | bnemec: ok, will send a patch. | 20:22 |
| bnemec | (unless you think we should backport it to the stable branches, but I'm not sure it's worth the hassle) | 20:22 |
| AJaeger_ | bnemec, dhellmann: Thanks for your help here! | 20:22 |
| bnemec | np, that's what we're here for :-) | 20:22 |
| *** e0ne has joined #openstack-oslo | 20:23 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:24 | |
| openstackgerrit | Andreas Jaeger proposed a change to openstack/oslo.concurrency: Improve lock_path help and documentation https://review.openstack.org/130354 | 20:27 |
| *** AAzza_afk is now known as AAzza | 20:42 | |
| *** AAzza is now known as AAzza_afk | 20:44 | |
| *** exploreshaifali has quit IRC | 20:50 | |
| *** zzzeek has joined #openstack-oslo | 20:54 | |
| *** ibravo has quit IRC | 20:59 | |
| *** boris-42 has quit IRC | 21:00 | |
| *** kgiusti has quit IRC | 21:05 | |
| *** boris-42 has joined #openstack-oslo | 21:06 | |
| openstackgerrit | A change was merged to openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/130322 | 21:12 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Bring doc build up to standard https://review.openstack.org/129716 | 21:13 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Update link to docs in README https://review.openstack.org/129958 | 21:13 |
| *** AJaeger_ has quit IRC | 21:15 | |
| *** miqui has quit IRC | 21:20 | |
| *** andreykurilin_ has joined #openstack-oslo | 21:21 | |
| *** takedakn has joined #openstack-oslo | 21:23 | |
| *** takedakn has quit IRC | 21:24 | |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo-specs: Add long-lived-transactionalized-db-fixtures https://review.openstack.org/117335 | 21:28 |
| *** takedakn has joined #openstack-oslo | 21:32 | |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/oslo.messaging: Test broker connection in functional tests https://review.openstack.org/130243 | 21:33 |
| *** jeckersb is now known as jeckersb_gone | 21:39 | |
| *** jecarey has quit IRC | 21:46 | |
| *** mriedem has quit IRC | 21:52 | |
| *** takedakn has quit IRC | 21:53 | |
| *** takedakn has joined #openstack-oslo | 21:57 | |
| *** freyes has quit IRC | 22:04 | |
| *** jecarey has joined #openstack-oslo | 22:09 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:13 | |
| *** gordc has quit IRC | 22:16 | |
| *** bknudson has quit IRC | 22:27 | |
| *** andreykurilin_ has quit IRC | 22:28 | |
| *** takedakn has quit IRC | 22:34 | |
| *** e0ne has quit IRC | 22:38 | |
| *** stevemar has quit IRC | 22:40 | |
| *** dims_ has joined #openstack-oslo | 22:44 | |
| *** dims_ has quit IRC | 22:45 | |
| *** dims_ has joined #openstack-oslo | 22:46 | |
| *** dims has quit IRC | 22:47 | |
| *** jeckersb_gone is now known as jeckersb | 22:48 | |
| *** dims_ has quit IRC | 22:50 | |
| *** takedakn has joined #openstack-oslo | 22:57 | |
| *** alexpilotti has quit IRC | 23:19 | |
| *** jecarey has quit IRC | 23:30 | |
| *** dims has joined #openstack-oslo | 23:44 | |
| openstackgerrit | A change was merged to openstack/taskflow: Updated from global requirements https://review.openstack.org/130332 | 23:51 |
| amaurymedeiros | dhellmann, so funcutils stays until further notice? | 23:53 |
| *** takedakn has quit IRC | 23:53 | |
| openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Use debug log level when reraising the exception https://review.openstack.org/130404 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!