| *** kgiusti has left #openstack-oslo | 00:04 | |
| *** jecarey has quit IRC | 00:07 | |
| *** dimsum_ has joined #openstack-oslo | 00:21 | |
| *** tsekiyama has quit IRC | 00:33 | |
| *** _amrith_ is now known as amrith | 00:36 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use the 'SynchronousExecutor' instead of 'make_completed_future' https://review.openstack.org/129763 | 00:39 |
|---|---|---|
| *** tsekiyama has joined #openstack-oslo | 00:44 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use the 'SynchronousExecutor' instead of 'make_completed_future' https://review.openstack.org/129763 | 00:44 |
| *** zzzeek has quit IRC | 00:45 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use the 'SynchronousExecutor' instead of 'make_completed_future' https://review.openstack.org/129763 | 00:45 |
| *** arnaud has quit IRC | 00:57 | |
| *** arnaud__ has quit IRC | 00:57 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 01:02 | |
| *** amotoki has joined #openstack-oslo | 01:04 | |
| *** yamahata has joined #openstack-oslo | 01:04 | |
| *** gordc has joined #openstack-oslo | 01:20 | |
| *** tsekiyama has quit IRC | 01:22 | |
| *** tsekiyam_ has joined #openstack-oslo | 01:23 | |
| *** tsekiyam_ has quit IRC | 01:23 | |
| *** mtanino has quit IRC | 01:28 | |
| *** zzzeek has joined #openstack-oslo | 01:28 | |
| *** zzzeek has quit IRC | 01:34 | |
| *** amrith is now known as _amrith_ | 01:40 | |
| *** stevemar has quit IRC | 02:25 | |
| *** stevemar has joined #openstack-oslo | 02:25 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a conductor running example (WIP) https://review.openstack.org/129412 | 02:33 |
| *** tsekiyama has joined #openstack-oslo | 02:34 | |
| *** tsekiyama has quit IRC | 02:39 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Rework the in-memory backend https://review.openstack.org/124552 | 02:56 |
| *** dimsum_ has quit IRC | 02:58 | |
| *** dimsum_ has joined #openstack-oslo | 02:59 | |
| *** exploreshaifali has joined #openstack-oslo | 02:59 | |
| *** amotoki_ has joined #openstack-oslo | 03:01 | |
| *** dimsum_ has quit IRC | 03:03 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a conductor running example (WIP) https://review.openstack.org/129412 | 03:04 |
| *** amotoki has quit IRC | 03:09 | |
| *** amotoki_ is now known as amotoki | 03:10 | |
| *** exploreshaifali has quit IRC | 03:12 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 03:13 | |
| *** gordc has quit IRC | 03:19 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 03:53 | |
| *** exploreshaifali has joined #openstack-oslo | 04:05 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Mark 'task_notifier' as renamed to 'atom_notifier' https://review.openstack.org/103286 | 04:30 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Mark 'task_notifier' as renamed to 'atom_notifier' https://review.openstack.org/103286 | 04:30 |
| *** ajo_ has joined #openstack-oslo | 04:52 | |
| *** exploreshaifali has quit IRC | 04:53 | |
| *** ajo_ has quit IRC | 04:55 | |
| *** wendar_ is now known as wendar | 05:03 | |
| *** harlowja is now known as harlowja_away | 05:30 | |
| *** exploreshaifali has joined #openstack-oslo | 05:37 | |
| *** k4n0 has joined #openstack-oslo | 05:50 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 06:14 | |
| *** sileht has quit IRC | 06:19 | |
| openstackgerrit | Valeriy Ponomaryov proposed a change to openstack/oslo-incubator: Replace six.text_type in print funcs https://review.openstack.org/122252 | 06:21 |
| *** hockeynut has quit IRC | 06:30 | |
| *** hockeynut has joined #openstack-oslo | 06:32 | |
| *** flaper87|afk is now known as flaper87 | 06:39 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Mark 'task_notifier' as renamed to 'atom_notifier' https://review.openstack.org/103286 | 06:40 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Mark 'task_notifier' as renamed to 'atom_notifier' https://review.openstack.org/103286 | 06:42 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Mark 'task_notifier' as renamed to 'atom_notifier' https://review.openstack.org/103286 | 06:46 |
| openstackgerrit | Peng Wu proposed a change to openstack/oslo-specs: Add spec for more-gettext-support https://review.openstack.org/121459 | 06:50 |
| *** ihrachyshka has joined #openstack-oslo | 07:06 | |
| *** noelbk has quit IRC | 07:08 | |
| *** andreykurilin_ has joined #openstack-oslo | 07:11 | |
| *** e0ne has joined #openstack-oslo | 07:12 | |
| *** ihrachyshka has quit IRC | 07:13 | |
| *** i159 has joined #openstack-oslo | 07:19 | |
| *** AAzza_afk is now known as AAzza | 07:20 | |
| *** dimsum_ has joined #openstack-oslo | 07:37 | |
| *** andreykurilin_ has quit IRC | 07:41 | |
| *** dimsum_ has quit IRC | 07:41 | |
| *** stevemar has quit IRC | 07:50 | |
| *** stannie has joined #openstack-oslo | 07:54 | |
| *** alexpilotti has joined #openstack-oslo | 07:55 | |
| openstackgerrit | Peng Wu proposed a change to openstack/oslo-specs: Add spec for more-gettext-support https://review.openstack.org/121459 | 08:14 |
| *** yamahata has quit IRC | 08:21 | |
| *** AAzza is now known as AAzza_afk | 08:26 | |
| *** AAzza_afk is now known as AAzza | 08:28 | |
| *** e0ne has quit IRC | 08:30 | |
| *** openstackgerrit has quit IRC | 08:34 | |
| *** openstackgerrit has joined #openstack-oslo | 08:34 | |
| *** sileht has joined #openstack-oslo | 08:35 | |
| jd__ | dhellmann: in case you miss the Gerrit notification: https://review.openstack.org/#/c/129680/ | 08:42 |
| *** ihrachyshka has joined #openstack-oslo | 08:51 | |
| *** e0ne has joined #openstack-oslo | 09:37 | |
| *** pblaho has joined #openstack-oslo | 09:40 | |
| openstackgerrit | Steven Hardy proposed a change to openstack/oslo-incubator: Add middleware.request_id shim for Kilo https://review.openstack.org/129858 | 09:49 |
| openstackgerrit | Steven Hardy proposed a change to openstack/oslo-incubator: Add middleware.request_id shim for Kilo https://review.openstack.org/129858 | 09:51 |
| openstackgerrit | A change was merged to openstack/oslo-incubator: Correct default rule name for policy.Enforcer https://review.openstack.org/128909 | 09:58 |
| *** AAzza is now known as AAzza_afk | 10:00 | |
| *** yamahata has joined #openstack-oslo | 10:13 | |
| *** _amrith_ is now known as amrith | 10:33 | |
| *** exploreshaifali has quit IRC | 10:34 | |
| openstackgerrit | Jakub Libosvar proposed a change to openstack/oslo.rootwrap: Fix exit of subprocess in case it was terminated by signal https://review.openstack.org/118569 | 10:43 |
| openstackgerrit | Jakub Libosvar proposed a change to openstack/oslo.rootwrap: Fix exit of subprocess in case it was terminated by signal https://review.openstack.org/118569 | 10:44 |
| *** exploreshaifali has joined #openstack-oslo | 11:02 | |
| *** dimsum_ has joined #openstack-oslo | 11:21 | |
| *** miqui has quit IRC | 11:24 | |
| *** k4n0 has quit IRC | 11:37 | |
| *** ozamiatin has quit IRC | 11:37 | |
| *** andreykurilin has quit IRC | 11:37 | |
| *** ozamiatin has joined #openstack-oslo | 11:37 | |
| *** andreykurilin has joined #openstack-oslo | 11:38 | |
| *** k4n0 has joined #openstack-oslo | 11:38 | |
| *** flaper87 has quit IRC | 11:40 | |
| *** flaper87 has joined #openstack-oslo | 11:40 | |
| *** k4n0 has quit IRC | 11:46 | |
| *** k4n0 has joined #openstack-oslo | 11:46 | |
| *** amrith is now known as _amrith_ | 11:51 | |
| *** AAzza_afk is now known as AAzza | 11:53 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/cliff: Updated from global requirements https://review.openstack.org/122418 | 12:09 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/stevedore: Updated from global requirements https://review.openstack.org/127795 | 12:16 |
| *** k4n0 has quit IRC | 12:28 | |
| *** dimsum_ has quit IRC | 12:38 | |
| *** dimsum_ has joined #openstack-oslo | 12:39 | |
| *** kgiusti has joined #openstack-oslo | 12:39 | |
| *** exploreshaifali has quit IRC | 12:45 | |
| *** __hemanthm has joined #openstack-oslo | 12:50 | |
| *** gordc has joined #openstack-oslo | 12:52 | |
| *** kgiusti has quit IRC | 12:53 | |
| *** kgiusti has joined #openstack-oslo | 12:54 | |
| *** miqui has joined #openstack-oslo | 12:56 | |
| *** __hemanthm has left #openstack-oslo | 12:59 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:07 | |
| *** yamahata has quit IRC | 13:11 | |
| *** yamahata has joined #openstack-oslo | 13:11 | |
| *** amotoki has quit IRC | 13:11 | |
| *** freyes has quit IRC | 13:19 | |
| *** freyes has joined #openstack-oslo | 13:21 | |
| openstackgerrit | Steven Hardy proposed a change to openstack/oslo-incubator: Add middleware.request_id shim for Kilo https://review.openstack.org/129858 | 13:27 |
| *** bknudson has joined #openstack-oslo | 13:29 | |
| *** pblaho has quit IRC | 13:35 | |
| *** amotoki has joined #openstack-oslo | 13:37 | |
| *** pblaho has joined #openstack-oslo | 13:37 | |
| *** mriedem has joined #openstack-oslo | 13:37 | |
| openstackgerrit | A change was merged to openstack/oslo-incubator: Make it possible to get the request_id from python clients https://review.openstack.org/117493 | 13:46 |
| *** stevemar has joined #openstack-oslo | 13:57 | |
| *** exploreshaifali has joined #openstack-oslo | 13:58 | |
| *** jecarey has joined #openstack-oslo | 14:04 | |
| jd__ | if someone has 2 minutes to weight in on https://review.openstack.org/#/c/129601/ I failed to explain to the reviewers how things work I guess… | 14:14 |
| openstackgerrit | Oleksii Zamiatin proposed a change to openstack/oslo.messaging: RabbitMQ heartbeat implementation https://review.openstack.org/129920 | 14:17 |
| *** pblaho has quit IRC | 14:21 | |
| *** pblaho has joined #openstack-oslo | 14:23 | |
| *** hemanthm has joined #openstack-oslo | 14:25 | |
| *** pblaho has quit IRC | 14:26 | |
| *** pblaho has joined #openstack-oslo | 14:27 | |
| *** _amrith_ is now known as amrith | 14:28 | |
| flaper87 | jd__: done | 14:42 |
| *** zz_jgrimm is now known as jgrimm | 14:44 | |
| *** hemanthm is now known as __hemanthm | 14:44 | |
| *** noelbk has joined #openstack-oslo | 14:51 | |
| dhellmann | zzzeek, jd__ : looking | 14:53 |
| *** zzzeek has joined #openstack-oslo | 14:54 | |
| jd__ | thanks flaper87 :) | 14:55 |
| *** stevemar has quit IRC | 14:55 | |
| *** stevemar has joined #openstack-oslo | 14:56 | |
| dhellmann | flaper87: Well said. I added a bit more context in my comment. | 14:58 |
| jd__ | thanks guys | 15:00 |
| jd__ | sometimes I feel exhausted fighting all over place for Oslo | 15:00 |
| * jd__ wants a medal | 15:00 | |
| *** zzzeek has quit IRC | 15:01 | |
| *** stevemar has quit IRC | 15:01 | |
| *** stevemar has joined #openstack-oslo | 15:01 | |
| * flaper87 gives jd__ a medal of honor! | 15:02 | |
| flaper87 | man, I wasted so many hours playing that game | 15:02 |
| flaper87 | or invested ? | 15:03 |
| flaper87 | :P | 15:03 |
| *** zzzeek has joined #openstack-oslo | 15:03 | |
| *** zzzeek has quit IRC | 15:03 | |
| dhellmann | jd__: things are getting better with the libraries, but incubation is still confusing for people | 15:05 |
| jd__ | flaper87: I think it's wasted unless a war start or something? :) | 15:07 |
| dhellmann | jd__: re the local change in https://review.openstack.org/#/c/129680/ I think that looks good, assuming we create some sort of API in oslo.log instead of using the threading.local instance directly | 15:07 |
| jd__ | dhellmann: totally agreed | 15:07 |
| jd__ | I'll do that then | 15:07 |
| dhellmann | jd__: yeah, this was a proof-of-concept and I think you've proved it'll work | 15:07 |
| dhellmann | jd__: I still need to look at whether we need the context module itself to live outside of oslo.log so it can define apis used by oslo.log and oslo.messaging | 15:08 |
| * jd__ nods | 15:09 | |
| dhellmann | E_TOO_MANY_SPECS | 15:09 |
| *** zzzeek has joined #openstack-oslo | 15:11 | |
| dhellmann | zzzeek: for the exception string tests, do we need oslo.db tests to check the contents of strings generated by sqlalchemy? couldn't those tests either look at the class, or look for a couple of key substrings? | 15:13 |
| zzzeek | dhellmann: maybe. Id need to look more closely | 15:14 |
| dhellmann | zzzeek: yeah, this has a certain smell to it. I guess we can take this change for now to unblock you. :-/ | 15:14 |
| zzzeek | dhellmann: I feel like there was a reason i wanted to guarantee all those elements came through but i might have actually just been lazy, so give it a -1, ill try to look today | 15:15 |
| dhellmann | zzzeek: I gave it a +2 with a request for a bug to look at the tests further | 15:16 |
| zzzeek | ok | 15:16 |
| *** mtanino has joined #openstack-oslo | 15:21 | |
| zzzeek | dhellmann: do you think there’s a natural lull in folks interested in looking at specs right before summit time? | 15:22 |
| *** tsekiyama has joined #openstack-oslo | 15:27 | |
| sigmavirus24 | dhellmann: do you have a second? | 15:30 |
| dhellmann | zzzeek: a bit, although it's not great that it happens | 15:31 |
| dhellmann | sigmavirus24: sure, what's up? | 15:31 |
| *** exploreshaifali has quit IRC | 15:32 | |
| sigmavirus24 | so there seems to be an issue with how pbr does dependency resolution. If you make a clean temporary environment and do `pip install flake8 hacking` hacking's requirements don't properly parse and you have to do `pip install --force-reinstall -U hacking` for flake8 to work. there's more context here: https://gitlab.com/pycqa/flake8/issues/9 | 15:32 |
| dhellmann | sigmavirus24: reading | 15:33 |
| sigmavirus24 | further, if you (in a clean env) just do pip install hacking, you get flake8==2.1.0 and pep8==1.5.6 and I'm pretty sure the requirements allow for higher versions | 15:34 |
| sigmavirus24 | ugh, nevermind hacking's requirements have this pinned. so installing hacking after flake8 forcibly downgrades everything which is why it works. the errors are still quite bizarre | 15:37 |
| dhellmann | sigmavirus24: why are you saying "pip install flake8 hacking" and not just "pip install hacking"? | 15:37 |
| *** alexpilotti has quit IRC | 15:38 | |
| dhellmann | sigmavirus24: yeah, I think this is a pip/setuptools dependency resolution thing -- pbr just passes requirements in to one of them to be dealt with | 15:38 |
| sigmavirus24 | dhellmann: yeah, I have to find out why the bug reporter was doing that. I assume they wanted a modern flake8 for performance reasons | 15:38 |
| dhellmann | sigmavirus24: hacking pins flake8 and pep8 to avoid introducing new rules unexpectedly when the tools are updated | 15:39 |
| dhellmann | sigmavirus24: we update the requirements pin for each release cycle (jogo handles that, as the hacking dev lead) | 15:39 |
| sigmavirus24 | thanks for the pointer dhellmann I | 15:40 |
| dhellmann | sigmavirus24: sure thing! | 15:40 |
| *** AAzza is now known as AAzza_afk | 15:43 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/stevedore: Update link to docs in README https://review.openstack.org/129957 | 15:54 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Update link to docs in README https://review.openstack.org/129958 | 15:55 |
| *** pblaho has quit IRC | 15:55 | |
| ihrachyshka | guys, please take a look at service patch: https://review.openstack.org/129278 it seems that it cures juno and icehouse branches for incubator (master not failing due to missing RPC module) | 15:56 |
| *** viktors is now known as viktors|afk | 15:57 | |
| *** AAzza_afk is now known as AAzza | 16:01 | |
| openstackgerrit | Steven Hardy proposed a change to openstack/oslo-incubator: Add middleware.request_id shim for Kilo https://review.openstack.org/129858 | 16:01 |
| *** alexpilotti has joined #openstack-oslo | 16:01 | |
| *** yamahata has quit IRC | 16:03 | |
| *** alexpilotti_ has joined #openstack-oslo | 16:04 | |
| *** alexpilotti has quit IRC | 16:07 | |
| *** alexpilotti_ is now known as alexpilotti | 16:07 | |
| *** ihrachyshka has quit IRC | 16:18 | |
| *** exploreshaifali has joined #openstack-oslo | 16:20 | |
| *** i159 has quit IRC | 16:25 | |
| *** dimsum_ is now known as dims | 16:45 | |
| *** ihrachyshka has joined #openstack-oslo | 16:47 | |
| *** AAzza is now known as AAzza_afk | 16:51 | |
| *** AAzza_afk is now known as AAzza | 16:52 | |
| openstackgerrit | Steven Hardy proposed a change to openstack/oslo-incubator: Add middleware.request_id shim for Kilo https://review.openstack.org/129858 | 16:52 |
| *** harlowja_away is now known as harlowja | 17:15 | |
| *** exploreshaifali has quit IRC | 17:41 | |
| *** amotoki has quit IRC | 17:41 | |
| *** AAzza is now known as AAzza_afk | 17:51 | |
| openstackgerrit | Steven Hardy proposed a change to openstack/oslo-incubator: Add middleware.request_id shim for Kilo https://review.openstack.org/129858 | 18:00 |
| *** AAzza_afk is now known as AAzza | 18:02 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Mark 'task_notifier' as renamed to 'atom_notifier' https://review.openstack.org/103286 | 18:06 |
| *** arnaud__ has joined #openstack-oslo | 18:07 | |
| *** e0ne has quit IRC | 18:07 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Mark 'task_notifier' as renamed to 'atom_notifier' https://review.openstack.org/103286 | 18:13 |
| openstackgerrit | Dan Smith proposed a change to openstack/oslo-specs: Add adopt-oslo-versionedobjects spec https://review.openstack.org/127532 | 18:17 |
| *** exploreshaifali has joined #openstack-oslo | 18:18 | |
| *** ajo_ has joined #openstack-oslo | 18:41 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Bring doc build up to standard https://review.openstack.org/129716 | 18:50 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Update link to docs in README https://review.openstack.org/129958 | 18:50 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 18:51 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 18:52 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/stevedore: Update link to docs in README https://review.openstack.org/129957 | 18:56 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/stevedore: Bring doc build up to standard https://review.openstack.org/129719 | 18:56 |
| *** ajo_ has quit IRC | 19:00 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslosphinx: Tighten up documentation https://review.openstack.org/130007 | 19:03 |
| *** ajo_ has joined #openstack-oslo | 19:04 | |
| *** exploreshaifali has quit IRC | 19:04 | |
| *** stannie has quit IRC | 19:07 | |
| *** andreykurilin_ has joined #openstack-oslo | 19:08 | |
| *** ajo_ has quit IRC | 19:21 | |
| *** ajo_ has joined #openstack-oslo | 19:28 | |
| *** e0ne has joined #openstack-oslo | 19:51 | |
| *** boris-42 has quit IRC | 19:59 | |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Organize provisioning to use testresources https://review.openstack.org/120870 | 20:05 |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Organize provisioning to use testresources https://review.openstack.org/120870 | 20:09 |
| *** ajo_ has quit IRC | 20:13 | |
| *** amrith is now known as _amrith_ | 20:15 | |
| *** jecarey has quit IRC | 20:18 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:20 | |
| *** e0ne has quit IRC | 20:25 | |
| *** jecarey has joined #openstack-oslo | 20:27 | |
| *** miqui has quit IRC | 20:30 | |
| *** boris-42 has joined #openstack-oslo | 20:32 | |
| *** noelbk has quit IRC | 20:48 | |
| *** noelbk has joined #openstack-oslo | 20:52 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/stevedore: Update link to docs in README https://review.openstack.org/129957 | 21:13 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/stevedore: Bring doc build up to standard https://review.openstack.org/129719 | 21:13 |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Assert exceptions based on API, not string messages https://review.openstack.org/129484 | 21:14 |
| *** kgiusti has left #openstack-oslo | 21:14 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Bring doc build up to standard https://review.openstack.org/129716 | 21:18 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Update link to docs in README https://review.openstack.org/129958 | 21:18 |
| openstackgerrit | A change was merged to openstack/taskflow: Use the mock that finds a working implementation https://review.openstack.org/128474 | 21:18 |
| jogo | dims dhellmann: ping | 21:21 |
| dhellmann | jogo: like I said, it looks like we're throwing an error in oslo.config and something is catching it and not exiting | 21:21 |
| dims | i think the code is as it has been for a long time fwiw :) we don't exit out from the process that is | 21:22 |
| jogo | dhellmann: that is my understanding as well | 21:22 |
| dhellmann | yeah, and I'm not comfortable adding an exit call to the lib, so I think this is an app-level fix rather than something we can do in the library | 21:22 |
| jogo | dims: at one point it exited out | 21:22 |
| jogo | dhellmann: the idea is you can set fatal_deprecated and make sure you aren't using any deprecated flags | 21:22 |
| jogo | because it will exit out | 21:22 |
| jogo | every time it hits one | 21:23 |
| dims | jogo: with exit in Nova code or in the librarycommon module code? | 21:23 |
| dhellmann | jogo: I understand. I don't want oslo.config to call exit() though. | 21:23 |
| *** __hemanthm has left #openstack-oslo | 21:23 | |
| jogo | dims: maybe a specific exception that isn't caught? | 21:23 |
| dhellmann | jogo: so change the main loop in the app to treat that exception type as fatal. It will only be generated when the flag is turned on. | 21:23 |
| dims | either way it does not qualify as a show stopper right? | 21:23 |
| dhellmann | right | 21:23 |
| jogo | dhellmann: long as we can make it a show stopper I am happy | 21:23 |
| dims | haha | 21:24 |
| jogo | its a good tool for testing if deprecated options are used | 21:24 |
| dhellmann | jogo: make the bug a show stopper, or the exception? | 21:24 |
| jogo | and something we should enable in devstack by default | 21:24 |
| jogo | dhellmann: the exception | 21:24 |
| dhellmann | ok, sure, you can do that in nova -- if you get that exception, treat it as fatal | 21:25 |
| dhellmann | jogo: and if that code is in the incubator, we can put it there, too | 21:25 |
| dhellmann | the exception handling part, I mean | 21:25 |
| * dims nods | 21:25 | |
| jogo | dhellmann: adding in an exception to ignore DeprecatedConfig may be a lot of code in nova | 21:28 |
| jogo | we have try: except blocks in a lot of places | 21:28 |
| jogo | although it should be fin | 21:29 |
| jogo | efine | 21:29 |
| jogo | since it is DeprecatedConfig(Exception) | 21:29 |
| dhellmann | jogo: we could change that to DeprecatedConfig(SystemExit) maybe, but that's almost as bad as calling sys.exit() directly | 21:30 |
| jogo | but we do have a lot of "except Exceptions" | 21:30 |
| dhellmann | jogo: unfortunate :-/ | 21:30 |
| jogo | dhellmann: context I17b0c120d54b1db75c6bb29d107e4a15a5202e76 | 21:32 |
| jogo | original patch | 21:32 |
| dhellmann | jogo: is that a nova patch? | 21:32 |
| dhellmann | jogo: ah, gerrit doesn't care | 21:33 |
| jogo | dhellmann: yup original patch as per git pickaxe | 21:35 |
| *** alexpilotti has quit IRC | 21:35 | |
| jogo | dhellmann: so it looks like at some point we added a high level catch all | 21:37 |
| dhellmann | jogo: yeah, that's where the change needs to happen, then | 21:38 |
| *** alexpilotti has joined #openstack-oslo | 21:38 | |
| *** alexpilotti has quit IRC | 21:41 | |
| jogo | dhellmann: https://review.openstack.org/130041 | 21:41 |
| jogo | as a test | 21:41 |
| *** alexpilotti has joined #openstack-oslo | 21:43 | |
| *** andreykurilin_ has quit IRC | 21:51 | |
| *** AAzza is now known as AAzza_afk | 21:56 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo-specs: Add a spec for a oslo.config dictionary based config opts https://review.openstack.org/130047 | 21:56 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo-specs: Add a spec for a oslo.config dictionary based config opts https://review.openstack.org/130047 | 21:59 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo-specs: Add a spec for a oslo.config dictionary based config opts https://review.openstack.org/130047 | 22:05 |
| *** gordc has quit IRC | 22:08 | |
| *** jecarey has quit IRC | 22:11 | |
| *** bknudson has quit IRC | 22:12 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use the deprecation utility module instead of warnings https://review.openstack.org/129510 | 22:30 |
| *** takedakn has joined #openstack-oslo | 22:32 | |
| *** dims_ has joined #openstack-oslo | 22:35 | |
| *** dims_ has quit IRC | 22:36 | |
| *** dims_ has joined #openstack-oslo | 22:36 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Remove direct usage of the deprecated failure location https://review.openstack.org/129455 | 22:37 |
| *** dims has quit IRC | 22:38 | |
| *** takedakn has quit IRC | 22:38 | |
| *** jgrimm is now known as zz_jgrimm | 22:49 | |
| *** alexpilotti has quit IRC | 22:52 | |
| *** jeckersb_gone is now known as jeckersb | 22:52 | |
| *** jeckersb is now known as jeckersb_gone | 22:56 | |
| *** yamahata has joined #openstack-oslo | 23:16 | |
| openstackgerrit | A change was merged to openstack/oslo.db: ModelsMigrationsSync: Add check for foreign keys https://review.openstack.org/116238 | 23:18 |
| *** takedakn has joined #openstack-oslo | 23:24 | |
| *** ihrachyshka has quit IRC | 23:32 | |
| *** zz_jgrimm is now known as jgrimm | 23:46 | |
| *** zzzeek has quit IRC | 23:47 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!