| openstackgerrit | A change was merged to openstack/oslo.serialization: Clean up docs before first release https://review.openstack.org/116665 | 00:01 |
|---|---|---|
| *** bknudson has joined #openstack-oslo | 00:04 | |
| *** dims has quit IRC | 00:06 | |
| *** dims has joined #openstack-oslo | 00:06 | |
| *** dims has quit IRC | 00:11 | |
| *** stevemar has joined #openstack-oslo | 00:14 | |
| *** HenryG_ is now known as HenryG | 00:16 | |
| *** praneshp has quit IRC | 00:19 | |
| *** celttechie has joined #openstack-oslo | 00:21 | |
| *** mtanino has quit IRC | 00:22 | |
| *** tsekiyam_ has quit IRC | 00:23 | |
| *** markmcclain1 has quit IRC | 00:36 | |
| *** alexpilotti has quit IRC | 01:04 | |
| *** mtanino has joined #openstack-oslo | 01:06 | |
| *** dims_ has joined #openstack-oslo | 01:25 | |
| *** zzzeek has quit IRC | 01:26 | |
| openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Mask passwords in exceptions and error messages https://review.openstack.org/116763 | 01:28 |
| *** zzzeek has joined #openstack-oslo | 01:28 | |
| openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Handle a failure on communicate() https://review.openstack.org/114664 | 01:34 |
| dims_ | dhellmann: got some time, does this look ok? https://github.com/dims/oslo.log/ | 01:36 |
| openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Log stdout, stderr and command on execute() error https://review.openstack.org/114659 | 01:40 |
| openstackgerrit | amrith proposed a change to openstack/oslo-incubator: Handle a failure on communicate() https://review.openstack.org/110933 | 01:41 |
| openstackgerrit | A change was merged to openstack-dev/hacking: Updated from global requirements https://review.openstack.org/116242 | 01:56 |
| *** yamahata has joined #openstack-oslo | 01:57 | |
| *** shakamunyi has quit IRC | 02:05 | |
| *** sheeprine has joined #openstack-oslo | 02:15 | |
| *** sheeprine has joined #openstack-oslo | 02:15 | |
| *** shakamunyi has joined #openstack-oslo | 02:23 | |
| *** jeffreycoho has quit IRC | 02:23 | |
| *** dims_ has quit IRC | 02:29 | |
| *** dims_ has joined #openstack-oslo | 02:29 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a futures type that can contain most of our future functionality https://review.openstack.org/116489 | 02:45 |
| *** dims__ has joined #openstack-oslo | 02:48 | |
| *** dims_ has quit IRC | 02:48 | |
| openstackgerrit | A change was merged to openstack/oslo.vmware: Imported Translations from Transifex https://review.openstack.org/114732 | 02:52 |
| openstackgerrit | A change was merged to openstack/oslo.vmware: Updated from global requirements https://review.openstack.org/116251 | 02:52 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/115605 | 02:59 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.serialization: Updated from global requirements https://review.openstack.org/116768 | 02:59 |
| *** dims__ has quit IRC | 03:00 | |
| *** jecarey has joined #openstack-oslo | 03:30 | |
| *** zzzeek has quit IRC | 03:37 | |
| *** harlowja is now known as harlowja_away | 03:47 | |
| *** harlowja_away is now known as harlowja | 03:48 | |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Handle more legacy version numbers https://review.openstack.org/116775 | 03:48 |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Handle more legacy version numbers https://review.openstack.org/116775 | 04:01 |
| *** zzzeek has joined #openstack-oslo | 04:06 | |
| *** zzzeek has quit IRC | 04:11 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/taskflow: Updated from global requirements https://review.openstack.org/116782 | 04:11 |
| *** praneshp has joined #openstack-oslo | 04:16 | |
| *** amotoki has joined #openstack-oslo | 04:19 | |
| *** praneshp_ has joined #openstack-oslo | 04:21 | |
| *** praneshp has quit IRC | 04:21 | |
| *** praneshp_ is now known as praneshp | 04:21 | |
| *** zzzeek has joined #openstack-oslo | 04:36 | |
| *** oomichi_away has quit IRC | 04:37 | |
| *** zzzeek has quit IRC | 04:44 | |
| *** yamahata has quit IRC | 04:55 | |
| *** yamahata has joined #openstack-oslo | 04:55 | |
| *** celttechie has quit IRC | 05:05 | |
| *** zzzeek has joined #openstack-oslo | 05:15 | |
| *** shakamunyi has quit IRC | 05:16 | |
| *** zzzeek has quit IRC | 05:20 | |
| *** AAzza_afk is now known as AAzza | 05:39 | |
| *** AAzza is now known as AAzza_afk | 05:43 | |
| *** flaper87|afk is now known as flaper87 | 05:47 | |
| *** pblaho has joined #openstack-oslo | 05:52 | |
| *** stevemar has quit IRC | 05:54 | |
| *** k4n0 has joined #openstack-oslo | 05:57 | |
| *** flaper87 is now known as flaper87|afk | 05:57 | |
| *** flaper87|afk is now known as flaper87 | 05:58 | |
| *** AAzza_afk is now known as AAzza | 05:59 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.i18n: Imported Translations from Transifex https://review.openstack.org/116553 | 06:01 |
| *** pblaho is now known as pblaho|afk | 06:16 | |
| *** zzzeek has joined #openstack-oslo | 06:17 | |
| *** zzzeek has quit IRC | 06:22 | |
| *** AAzza is now known as AAzza_afk | 06:23 | |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.messaging: Fix Python 3 testing https://review.openstack.org/116606 | 06:24 |
| *** flaper87 is now known as flaper87|afk | 06:29 | |
| *** flaper87|afk is now known as flaper87 | 06:30 | |
| openstackgerrit | Vipin Balachandran proposed a change to openstack/oslo.vmware: Refactoring to reduce noise in log files https://review.openstack.org/116504 | 06:30 |
| *** harlowja is now known as harlowja_away | 06:31 | |
| *** flaper87 is now known as flaper87|afk | 06:45 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Tweak engine iteration 'close-up shop' runtime path https://review.openstack.org/116544 | 07:08 |
| *** flaper87|afk is now known as flaper87 | 07:15 | |
| *** zzzeek has joined #openstack-oslo | 07:18 | |
| *** Alexei_987 has quit IRC | 07:19 | |
| *** zzzeek has quit IRC | 07:24 | |
| *** AAzza_afk is now known as AAzza | 07:27 | |
| *** flaper87 is now known as flaper87|afk | 07:27 | |
| *** flaper87|afk is now known as flaper87 | 07:30 | |
| *** viktors|afk has quit IRC | 07:37 | |
| *** pblaho|afk is now known as pblaho | 07:38 | |
| *** markmc has joined #openstack-oslo | 07:42 | |
| *** stannie1 has joined #openstack-oslo | 07:48 | |
| *** Alexei_987 has joined #openstack-oslo | 08:14 | |
| *** zzzeek has joined #openstack-oslo | 08:20 | |
| *** sheeprine has quit IRC | 08:21 | |
| *** zzzeek has quit IRC | 08:25 | |
| *** yassine has joined #openstack-oslo | 08:26 | |
| *** yassine has quit IRC | 08:28 | |
| *** yassine has joined #openstack-oslo | 08:28 | |
| *** dtantsur|afk is now known as dtantsur | 08:29 | |
| *** andreykurilin has joined #openstack-oslo | 08:37 | |
| *** i159 has joined #openstack-oslo | 08:37 | |
| *** alexpilotti has joined #openstack-oslo | 08:46 | |
| *** zzzeek has joined #openstack-oslo | 09:21 | |
| *** viktors has joined #openstack-oslo | 09:22 | |
| *** zzzeek has quit IRC | 09:27 | |
| jd__ | working on oslo.messaging py3 gate fix again | 09:31 |
| openstackgerrit | Julien Danjou proposed a change to openstack/oslo.messaging: Fix Python 3 testing https://review.openstack.org/116606 | 09:32 |
| jd__ | sileht: ^ | 09:32 |
| sileht | jd__, done | 09:35 |
| markmc | jd__, approved | 09:35 |
| jd__ | thanks guys | 09:36 |
| *** tkelsey has joined #openstack-oslo | 09:37 | |
| *** dtantsur is now known as dtantsur|brb | 09:41 | |
| *** praneshp has quit IRC | 09:43 | |
| *** pblaho is now known as pblaho|afk | 09:47 | |
| *** flaper87 is now known as flaper87|afk | 09:48 | |
| *** flaper87|afk is now known as flaper87 | 09:57 | |
| *** yamahata has quit IRC | 10:01 | |
| openstackgerrit | Dirk Mueller proposed a change to openstack/oslotest: Require six https://review.openstack.org/116841 | 10:04 |
| *** yamahata has joined #openstack-oslo | 10:08 | |
| *** yassine has quit IRC | 10:12 | |
| openstackgerrit | Oleksii Chuprykov proposed a change to openstack/oslo.db: Add description for test_models_sync function https://review.openstack.org/116004 | 10:17 |
| *** yamahata has quit IRC | 10:17 | |
| *** AAzza is now known as AAzza_afk | 10:29 | |
| *** pcm_ has joined #openstack-oslo | 10:29 | |
| *** pcm_ has quit IRC | 10:30 | |
| *** pcm_ has joined #openstack-oslo | 10:31 | |
| openstackgerrit | A change was merged to openstack/oslo.vmware: Add missing session parameter to get_summary https://review.openstack.org/116389 | 10:31 |
| openstackgerrit | Roman Vasilets proposed a change to openstack/oslo.db: Extract logging setup into a separate function https://review.openstack.org/106992 | 10:32 |
| *** rvasilets has joined #openstack-oslo | 10:34 | |
| rvasilets | Can you look at change https://review.openstack.org/#/c/106992/ | 10:35 |
| *** AAzza_afk is now known as AAzza | 10:35 | |
| openstackgerrit | Julien Danjou proposed a change to openstack-dev/hacking: Add a check for old style class declarations https://review.openstack.org/116846 | 10:37 |
| *** rvasilets has quit IRC | 10:43 | |
| *** dtantsur|brb is now known as dtantsur | 10:47 | |
| *** flaper87 is now known as flaper87|afk | 10:53 | |
| *** flaper87|afk is now known as flaper87 | 10:56 | |
| *** jecarey has quit IRC | 10:56 | |
| *** pblaho|afk is now known as pblaho | 11:00 | |
| *** AAzza is now known as AAzza_afk | 11:03 | |
| *** yassine has joined #openstack-oslo | 11:11 | |
| *** pblaho is now known as pblaho|afk | 11:17 | |
| *** zzzeek has joined #openstack-oslo | 11:25 | |
| *** zzzeek has quit IRC | 11:30 | |
| *** pblaho|afk is now known as pblaho | 11:50 | |
| *** flaper87 is now known as flaper87|afk | 12:03 | |
| *** flaper87|afk is now known as flaper87 | 12:08 | |
| *** AAzza_afk is now known as AAzza | 12:08 | |
| *** gordc has joined #openstack-oslo | 12:12 | |
| *** AAzza is now known as AAzza_afk | 12:14 | |
| *** enykeev has quit IRC | 12:23 | |
| *** stevemar has joined #openstack-oslo | 12:26 | |
| *** yassine has quit IRC | 12:26 | |
| *** zzzeek has joined #openstack-oslo | 12:26 | |
| *** AAzza_afk is now known as AAzza | 12:26 | |
| *** enykeev has joined #openstack-oslo | 12:28 | |
| *** zzzeek has quit IRC | 12:32 | |
| *** yassine has joined #openstack-oslo | 12:32 | |
| *** jaosorior has joined #openstack-oslo | 12:33 | |
| *** kgiusti has joined #openstack-oslo | 12:36 | |
| *** k4n0 has quit IRC | 12:49 | |
| *** mtanino has quit IRC | 12:53 | |
| *** pblaho has quit IRC | 13:00 | |
| *** jeckersb_gone is now known as jeckersb | 13:06 | |
| *** yassine has quit IRC | 13:06 | |
| *** bknudson has quit IRC | 13:06 | |
| *** yassine has joined #openstack-oslo | 13:07 | |
| *** abhijeetm has joined #openstack-oslo | 13:07 | |
| *** yassine has quit IRC | 13:16 | |
| gordc | dhellmann: i think we should be ok to cut first release of oslo.middleware... did you want to verify and any suggestion on what version to tag first release? | 13:17 |
| *** mriedem has joined #openstack-oslo | 13:17 | |
| *** pblaho has joined #openstack-oslo | 13:19 | |
| *** inteq has joined #openstack-oslo | 13:22 | |
| *** AAzza is now known as AAzza_afk | 13:22 | |
| *** zz_jgrimm is now known as jgrimm | 13:23 | |
| *** AAzza_afk is now known as AAzza | 13:27 | |
| *** yassine has joined #openstack-oslo | 13:37 | |
| stevemar | gordc, 1.0 seems appropriate :P | 13:45 |
| gordc | stevemar: but then if it breaks i can't fall back on: 'its a 0.x release' | 13:48 |
| *** mtanino has joined #openstack-oslo | 13:58 | |
| *** mtanino has joined #openstack-oslo | 13:58 | |
| stevemar | gordc, ah safety version | 13:58 |
| *** celttechie has joined #openstack-oslo | 14:00 | |
| *** markmcclain has joined #openstack-oslo | 14:05 | |
| amrith | yoriksar, yt? | 14:07 |
| YorikSar | amrith: Hi | 14:07 |
| YorikSar | Yep | 14:07 |
| amrith | hi yoriksar. I'm not entirely sure how to use mock for the tests in https://review.openstack.org/#/c/116763/1 | 14:08 |
| amrith | there are effectively three channels; | 14:08 |
| amrith | one stdin, one stdout and one stderr | 14:08 |
| amrith | I have to fake them all to appear to have a read method | 14:08 |
| amrith | and a setup_channel | 14:08 |
| amrith | and I need to provide an exec_command method | 14:08 |
| amrith | this is all so I can make ssh_execute think it is working properly | 14:08 |
| amrith | I'm unsure how to do that with mock | 14:08 |
| amrith | would you have a couple of minutes to point me in the right direction | 14:09 |
| amrith | th | 14:09 |
| amrith | thx | 14:09 |
| *** markmcclain1 has joined #openstack-oslo | 14:09 | |
| *** bknudson has joined #openstack-oslo | 14:10 | |
| *** ildikov_ has joined #openstack-oslo | 14:10 | |
| YorikSar | amrith: So you basically need an object that returns 3-tuple when .exec_command called, right? | 14:10 |
| amrith | and the elements in the 3-tuple should each support some methods (like read) | 14:10 |
| *** dims has joined #openstack-oslo | 14:11 | |
| YorikSar | amrith: You can do like conn.exec_command.return_value = StringIO(), stdout, StringIO(smth) | 14:11 |
| YorikSar | amrith: Then you need some special stdout... | 14:11 |
| YorikSar | amrith: You can do stdout = Mock() and set necessary methods on it. | 14:11 |
| *** markmcclain has quit IRC | 14:12 | |
| YorikSar | amrith: Like stdout.channel.recv_exit_status = 0 | 14:12 |
| amrith | OK, I'll give that a shot | 14:12 |
| YorikSar | (or smth like that) | 14:12 |
| amrith | what's the .return_value do? | 14:12 |
| amrith | where you say conn.exec_command.return_value = ... | 14:13 |
| YorikSar | Oh, stdout.channel.recv_exit_status.return_value = 0 | 14:13 |
| amrith | is the .return_value a specific way of saying that's what Mock should return | 14:13 |
| YorikSar | With Mock every attribute is a new Mock. | 14:13 |
| *** markmcclain1 has quit IRC | 14:13 | |
| amrith | ok, sounds good, I'll give that a shot. | 14:13 |
| amrith | thanks YorikSar | 14:13 |
| YorikSar | So when one of those Mocks have .return_value, it'll return this value when it's called. | 14:13 |
| *** markmcclain has joined #openstack-oslo | 14:14 | |
| amrith | perfect, that should work nicely | 14:14 |
| YorikSar | amrith: That's a cool thing about Mock library - it's extremely easy to express your needs. And it's pythonic :) | 14:15 |
| *** markmcclain1 has joined #openstack-oslo | 14:15 | |
| amrith | understood. it took a while yesterday to understand how the previous code worked with fakessh | 14:15 |
| amrith | and when I finally figured out what he was up to, I promptly adapted it | 14:16 |
| amrith | to send back a customized stdout and stderr | 14:16 |
| amrith | instead of trying anything else (in honesty, didn't even think to do that). | 14:16 |
| amrith | but I'll do it for the new test. thanks much! | 14:16 |
| *** markmcclain has quit IRC | 14:19 | |
| YorikSar | dims, dhellmann: Hi. I'd like to understand what happens with importutils in https://review.openstack.org/114649 | 14:19 |
| YorikSar | We basically force all users to use oslo.utils version there. | 14:20 |
| *** pblaho is now known as pblaho|afk | 14:20 | |
| YorikSar | Why don't we do the same for other libs? | 14:21 |
| YorikSar | dims, dhellmann: ^ | 14:21 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.middleware: Update docs for first release https://review.openstack.org/116903 | 14:21 |
| dhellmann | gordc: let's see if we can get the docs cleaned up before releasing: https://review.openstack.org/116903 | 14:22 |
| dhellmann | YorikSar: looking | 14:22 |
| *** markmcclain1 has quit IRC | 14:22 | |
| *** markmcclain has joined #openstack-oslo | 14:23 | |
| dhellmann | YorikSar: we were going to be trying to leave the incubator alone, but having some projects adopt oslo.utils while the incubator does not use it makes their tests not work properly | 14:23 |
| dims | YorikSar: long story, let me try to summarize, we tried to get oslo.utils into nova and keystone and we found 2 issues, importutils hides some functions by adding '_' in oslo.utils and the utcnow() in timeutils clashes with the copy from oslo-incubator | 14:23 |
| dhellmann | much better summary :-) | 14:23 |
| gordc | dhellmann: ok cool. i'll have a look | 14:23 |
| dims | YorikSar: so we are trying to see if we can get oslo.utils into oslo-incubator itself (this is the guinea pig, we have not done this before) | 14:23 |
| *** pblaho|afk is now known as pblaho | 14:24 | |
| YorikSar | But why do we force users to use importutils then? | 14:24 |
| dhellmann | dims: I talked to ttx about an early branch today. I think what we want to do is cut stable/juno as soon as that oslo.log stuff you're working on is approved for import, and then we can start deleting things from the incubator and updating incubated modules to use graduated libs. | 14:24 |
| YorikSar | And we'll basically break tests for every project in a reverse way, won't we? | 14:24 |
| dims | YorikSar: not sure i understand | 14:24 |
| dhellmann | dims: I need to go through my process notes and make sure that's not going to introduce any other breakages, so don't start deleting stuff just yet :-) | 14:25 |
| dims | dhellmann: yep, all the old stuff is still there | 14:25 |
| dhellmann | YorikSar: we're going to have to shift to a model where adopting a library means syncing changes in incubated modules that used the graduated lib | 14:25 |
| dims | right | 14:26 |
| dhellmann | YorikSar: we have too many modules that depend on each other at the layer we're working now | 14:26 |
| YorikSar | dims: I mean we still have both openstack.common.timeutils and oslo.utils.timeutils, and if tests are mocking the first (which they do in projects that haven't adopted oslo.utils), incubator will use unmocked version from oslo.utils. | 14:26 |
| dhellmann | in retrospect, that was obvious from the dependency graph, but at the time it seemed like we would be OK | 14:26 |
| dhellmann | YorikSar: right, we're going to get rid of the incubated version of timeutils | 14:26 |
| dims | YorikSar: when they sync next, they need to fix their tests to adopt oslo.utils | 14:27 |
| dims | YorikSar: and remove the timeutils from oslo-inc | 14:27 |
| YorikSar | Ok... So after that sync timeutils from incubator just won't be used at all, right? | 14:28 |
| dims | YorikSar: ack | 14:28 |
| dims | YorikSar: we may need to update scripts to make it happen | 14:28 |
| YorikSar | dims, dhellmann: Ok, I get what happens with timeutils... But importutils issue still remains. | 14:28 |
| dims | so the importutils, if we change the hidden functions back in oslo.utils then i can take the stuff out from here | 14:29 |
| YorikSar | We have openstack/common/importutils.py that will never be imported because it's hidden in openstack/common/__init__.py | 14:29 |
| dims | YorikSar: yes, importutils needs to be removed as well along with timeutils when projects sync next | 14:29 |
| YorikSar | If we can do that, why don't just do the same for other modules in oslo.utils? | 14:29 |
| dhellmann | dims: yeah, we're going to just have to expose and support those functions I think | 14:30 |
| dims | YorikSar: we are going to force that | 14:30 |
| *** ekarlso has quit IRC | 14:31 | |
| dims | YorikSar: update.py needs to be enhanced to delete/skip modules from oslo.utils and possibly warn the user | 14:31 |
| dhellmann | dims: if we just delete them from the incubator, that won't be an issue, right? | 14:31 |
| YorikSar | dims, dhellmann: May be it'd be better to 'just' do 'from oslo.utils import *' and remove incubated code for oslo.utils at once? | 14:31 |
| dims | dhellmann: right, but our deprecation policy is stopping us from doing that | 14:31 |
| dhellmann | dims: right, that's the policy I'm talking about changing for kilo (which may delay adoption of oslo.utils, but we're late enough that I suspect most projects won't want to accept those patches now anyway) | 14:32 |
| dims | dhellmann: ok | 14:32 |
| dhellmann | dims: so if we make stable/juno in the next week or so, we can go through and delete everything we've graduated and fix up the incubator to use those libs, and then early in kilo projects can sync cleanly | 14:33 |
| dims | dhellmann: sounds good | 14:33 |
| YorikSar | dhellmann: When will this change land then? Before stable/juno or after? | 14:33 |
| dhellmann | fwiw, I really didn't expect anyone to accept a new lib after j2 | 14:33 |
| dims | dhellmann: i am away from thu till sun so works for me :) | 14:33 |
| dhellmann | YorikSar: which change? | 14:33 |
| YorikSar | dhellmann: oslo.utils in incubator one | 14:33 |
| *** tongli has joined #openstack-oslo | 14:33 | |
| dims | dhellmann: we need to add back the hidden methods in importutils | 14:34 |
| dhellmann | dims: ok, do you want to put together the import patch for oslo.log? | 14:34 |
| dhellmann | dims: yeah | 14:34 |
| *** jgrimm is now known as zz_jgrimm | 14:34 | |
| dhellmann | YorikSar: we will wait to update the incubator to use oslo.utils until after we cut stable/juno | 14:34 |
| dims | dhellmann: ack. will file a infra review for oslo.log and a patch for importutils | 14:34 |
| dhellmann | dims: cool, thanks | 14:34 |
| dhellmann | dims: zul was going to work on some of the log stuff, too, so we can tap him for a review | 14:35 |
| dims | YorikSar: thanks for follow up on irc | 14:35 |
| YorikSar | dhellmann: Ah... Then we can remove those modules in the same change, right? | 14:35 |
| dims | dhellmann: yea, one of you will have to shepherd it rest of the week | 14:35 |
| dhellmann | YorikSar: yeah, I haven't worked out the best process for that, but probably | 14:35 |
| dhellmann | dims: sure, we an take it over while you're out | 14:35 |
| dims | thanks | 14:35 |
| *** amotoki has quit IRC | 14:36 | |
| YorikSar | dims, dhellmann: Ok... It looks like my doubts weren't groundless. Thanks for clarifications! | 14:38 |
| jroll | hey, I'm looking for some direction with fixing this bug: https://bugs.launchpad.net/bugs/1300939 | 14:39 |
| jroll | wondering if there's any other projects that translate API responses based on accept-language headers I can check out? | 14:39 |
| dims | YorikSar: not at all, we need all the help in looking at it from all angles | 14:39 |
| YorikSar | But then after stable/juno cut we'll have to revert to patchset ~8 that had all those modules removed, right? | 14:39 |
| jroll | or is the best method just... set lazy translation in i18n and then translate right before sending the response? | 14:40 |
| jroll | (having trouble figuring out when lazy translation actually happens, is it when printed / written to a file-like object? | 14:41 |
| *** tsekiyama has joined #openstack-oslo | 14:41 | |
| YorikSar | dims: Yeah. I hope my angle-ing won't get much people annoyed :) | 14:41 |
| *** flaper87 is now known as flaper87|afk | 14:43 | |
| *** zzzeek has joined #openstack-oslo | 14:43 | |
| *** flaper87|afk is now known as flaper87 | 14:45 | |
| dhellmann | jroll: the API layer code is responsible for calling translate() when it knows both the locale/language and the message to be translated | 14:49 |
| dhellmann | jroll: I believe nova had some verison of that | 14:50 |
| jroll | dhellmann: ok, will look. thanks! :) | 14:50 |
| *** dims has quit IRC | 14:51 | |
| dhellmann | jroll: you might also ask on the -dev list | 14:51 |
| dhellmann | jroll: you want to call oslo.i18n.translate() http://docs.openstack.org/developer/oslo.i18n/api.html#oslo.i18n.translate | 14:51 |
| jroll | right, that's what I figured... just trying to figure out the best way to do so :) | 14:52 |
| dhellmann | jroll: sure :-) | 14:52 |
| *** dims has joined #openstack-oslo | 14:54 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Fix stable integration tests https://review.openstack.org/116731 | 14:54 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Add release notes for 1.7.0 https://review.openstack.org/116658 | 14:54 |
| *** ildikov_ has quit IRC | 14:56 | |
| i159 | zzzeek: hi! I just came back from vacation and feel myself out of context... I have questions about your comment https://review.openstack.org/106419/. How per-database setup affects design of the function? Show me, please, the change which gives to us an opportunity not to check `inspector.dialect.name == 'postgresql'`. Why ModelsMigrationsSync no longer needs to worry about cleanup at all? | 15:05 |
| zzzeek | hey | 15:05 |
| i159 | zzzeek: I'm sorry that I flunked you with all of this questions =) | 15:06 |
| zzzeek | i159: this patch has gotten sidetracked but id like drop to be within the provisioning system: https://review.openstack.org/#/c/110486/23/oslo/db/sqlalchemy/provision.py | 15:09 |
| *** zz_jgrimm is now known as jgrimm | 15:09 | |
| zzzeek | i159: as far as “if db.name == postgresql”, we should use this (merged) for all switch-on-db functions: https://review.openstack.org/#/c/109436/14/oslo/db/sqlalchemy/utils.py | 15:10 |
| dims | dhellmann: oslo.log, i had one question which may cause me to rework the repo...looks like we'll need log_handler.py too right? spec does not say so - https://github.com/openstack/oslo-specs/blob/master/specs/juno/graduate-oslo-log.rst | 15:11 |
| dhellmann | dims: based on our conversation this morning, I think the only thing blocking https://blueprints.launchpad.net/oslo/+spec/graduate-oslo-utils from being done is exposing those importutils functions, right? | 15:11 |
| dims | dhellmann: yep | 15:11 |
| dhellmann | dims: the log handler should probably go into oslo.messaging, since it's a notification handler | 15:11 |
| * dhellmann verifies that | 15:12 | |
| dims | dhellmann: ack i see it - https://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/notify/log_handler.py | 15:12 |
| dhellmann | dims: yeah, just re-found it myself :-) | 15:12 |
| dhellmann | we're going to have to be very careful with deleting code from the incubator | 15:13 |
| dims | cool. i'll add reviews this after noon | 15:13 |
| dims | yep | 15:13 |
| *** celttechie has quit IRC | 15:13 | |
| dhellmann | dims: awesome, thanks for stepping in on this one, it might have been a few more days before I got to it | 15:13 |
| i159 | zzzeek: lot of code ) thanks I'll see into it. And another question. You told that you have implemented almost the same function in the provision module. Should the utility function be used in provision? | 15:17 |
| zzzeek | i159: probably not because the PGProvision object woudl have the PG stuff in it, MySQLProvision would have MySQL stuff, etc. | 15:18 |
| zzzeek | i159: but timing-wise, im not sure I can make you wait for Provision because i have to write a blueprint and everything now | 15:18 |
| zzzeek | i159: it got pushed | 15:18 |
| i159 | zzzeek: so, do you think we shoud continue work around utility? | 15:19 |
| zzzeek | i159: what is dependent on your drop_schema featrue ? | 15:20 |
| *** viktors is now known as viktors|afk | 15:21 | |
| i159 | zzzeek: it has empty dependencies. Maybe somewhere in other projects It would be desirable. Answer is no... | 15:22 |
| zzzeek | i159: i have to write a blueprint for everything in https://bugs.launchpad.net/oslo/+bug/1339206 because theres some decisions that have to be agreed upon | 15:23 |
| *** pblaho has quit IRC | 15:24 | |
| i159 | zzzeek: Ok, I'll join to discussion when I will understand the meaning of the changes. But now, the idea with per database cleanup seem to me better than universal utility function. So, if you think, that we don't need complete the work with the utility function, please mark it with -2, maybe in this way we will cause required discussion. | 15:28 |
| i159 | *seems | 15:28 |
| zzzeek | i159: OK !:) | 15:28 |
| i159 | Thanks! :) | 15:29 |
| *** ekarlso has joined #openstack-oslo | 15:29 | |
| *** markmcclain has quit IRC | 15:33 | |
| *** zzzeek has quit IRC | 15:34 | |
| *** ekarlso has quit IRC | 15:40 | |
| *** ekarlso has joined #openstack-oslo | 15:40 | |
| *** zzzeek has joined #openstack-oslo | 15:41 | |
| *** i159 has quit IRC | 15:44 | |
| *** flaper87 is now known as flaper87|afk | 15:46 | |
| *** stevemar has quit IRC | 15:48 | |
| *** stevemar has joined #openstack-oslo | 15:48 | |
| *** abhijeetm has quit IRC | 15:53 | |
| *** celttechie has joined #openstack-oslo | 15:55 | |
| *** zzzeek has quit IRC | 16:00 | |
| *** stannie1 is now known as stannie | 16:01 | |
| *** ajo|mac has joined #openstack-oslo | 16:03 | |
| *** yamahata has joined #openstack-oslo | 16:10 | |
| *** yamahata has quit IRC | 16:16 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.utils: Re-enable _import* hidden methods in import_utils https://review.openstack.org/116940 | 16:24 |
| *** Alexei_987 has quit IRC | 16:29 | |
| *** markmc has quit IRC | 16:32 | |
| *** markmcclain has joined #openstack-oslo | 16:38 | |
| *** markmcclain has quit IRC | 16:38 | |
| openstackgerrit | A change was merged to openstack/oslo.messaging: Fix Python 3 testing https://review.openstack.org/116606 | 16:48 |
| *** markmcclain has joined #openstack-oslo | 16:51 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/115363 | 16:51 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack-dev/hacking: Updated from global requirements https://review.openstack.org/116946 | 16:53 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.version: Updated from global requirements https://review.openstack.org/116949 | 16:59 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/115605 | 17:07 |
| openstackgerrit | A change was merged to openstack/oslotest: Restructure oslotest docs https://review.openstack.org/116716 | 17:11 |
| *** celttechie has quit IRC | 17:15 | |
| openstackgerrit | A change was merged to openstack/oslotest: Add documentation for running oslo_debug_heler.sh https://review.openstack.org/116722 | 17:15 |
| *** harlowja_away is now known as harlowja | 17:15 | |
| *** praneshp has joined #openstack-oslo | 17:16 | |
| openstackgerrit | A change was merged to openstack/oslotest: Require six https://review.openstack.org/116841 | 17:20 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack-dev/hacking: Updated from global requirements https://review.openstack.org/116946 | 17:21 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.version: Updated from global requirements https://review.openstack.org/116949 | 17:27 |
| openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Mask passwords in exceptions and error messages https://review.openstack.org/116763 | 17:38 |
| openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Mask passwords in exceptions and error messages https://review.openstack.org/116763 | 17:39 |
| *** alexpilotti has quit IRC | 17:45 | |
| *** tkelsey has quit IRC | 17:49 | |
| *** sheeprine has joined #openstack-oslo | 18:01 | |
| *** ildikov has joined #openstack-oslo | 18:09 | |
| *** zzzeek has joined #openstack-oslo | 18:15 | |
| *** kgiusti has quit IRC | 18:23 | |
| *** kgiusti has joined #openstack-oslo | 18:24 | |
| *** kgiusti has quit IRC | 18:25 | |
| *** kgiusti has joined #openstack-oslo | 18:25 | |
| *** arnaud has joined #openstack-oslo | 18:29 | |
| ekarlso | zzzeek: when in a migration script | 18:30 |
| ekarlso | does each migrate_engine.execute() call get the same connection? | 18:30 |
| zzzeek | sqlalchemy-migrate? i dont know | 18:30 |
| zzzeek | alembic? yes | 18:30 |
| *** AAzza has left #openstack-oslo | 18:32 | |
| *** tkelsey has joined #openstack-oslo | 18:39 | |
| *** ajo|mac is now known as ajo_ | 18:40 | |
| *** tkelsey has quit IRC | 18:44 | |
| *** markmc has joined #openstack-oslo | 18:45 | |
| *** harlowja has quit IRC | 19:06 | |
| *** harlowja has joined #openstack-oslo | 19:08 | |
| *** tsekiyama has quit IRC | 19:09 | |
| *** AAzza_afk has joined #openstack-oslo | 19:18 | |
| *** AAzza_afk is now known as AAzza | 19:18 | |
| *** AAzza has left #openstack-oslo | 19:26 | |
| *** ajo_ has quit IRC | 19:35 | |
| *** ajo_ has joined #openstack-oslo | 19:38 | |
| *** dims has quit IRC | 19:38 | |
| *** dims has joined #openstack-oslo | 19:39 | |
| *** flaper87|afk is now known as flaper87 | 19:43 | |
| *** Alexei_987 has joined #openstack-oslo | 19:43 | |
| *** Alexei_987 has left #openstack-oslo | 19:47 | |
| *** yassine has quit IRC | 19:52 | |
| ekarlso | zzzeek: any better way to write http://paste.openstack.org/show/100614/ ? | 19:57 |
| zzzeek | havent had to do that before but looks like you worked out the issues | 19:58 |
| *** arnaud has quit IRC | 19:58 | |
| ekarlso | actually i wonder if we have :/ | 19:59 |
| ekarlso | we get an error on some migrations w it | 19:59 |
| *** ajo_ has quit IRC | 20:04 | |
| *** shakamunyi has joined #openstack-oslo | 20:04 | |
| *** dims_ has joined #openstack-oslo | 20:09 | |
| *** shakamunyi has quit IRC | 20:11 | |
| *** dims has quit IRC | 20:12 | |
| *** dims_ has quit IRC | 20:14 | |
| *** dims has joined #openstack-oslo | 20:17 | |
| *** alexpilotti has joined #openstack-oslo | 20:21 | |
| *** dims has quit IRC | 20:22 | |
| openstackgerrit | A change was merged to openstack/oslo.messaging: Add parameter to customize Qpid receiver capacity https://review.openstack.org/112536 | 20:24 |
| *** kgiusti has quit IRC | 20:29 | |
| openstackgerrit | Armando Migliaccio proposed a change to openstack/oslo.messaging: Track the attempted method when raising UnsupportedVersion https://review.openstack.org/107240 | 20:36 |
| *** morganfainberg is now known as morganfainberg_Z | 20:49 | |
| *** celttechie has joined #openstack-oslo | 20:52 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/115363 | 20:54 |
| jogo | any osloite want an easy +2 https://review.openstack.org/#/c/116946/ (flake8 2.2.3 in hacking) | 21:07 |
| *** dims has joined #openstack-oslo | 21:10 | |
| *** markmcclain has quit IRC | 21:12 | |
| *** markmc has quit IRC | 21:12 | |
| *** flaper87 is now known as flaper87|afk | 21:15 | |
| *** shakamunyi has joined #openstack-oslo | 21:19 | |
| *** ajo_ has joined #openstack-oslo | 21:22 | |
| *** ajo_ has quit IRC | 21:28 | |
| *** morganfainberg_Z is now known as morganfainberg | 21:33 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.middleware: Update docs for first release https://review.openstack.org/116903 | 21:35 |
| dhellmann | jogo: does the new flake8 have any rule changes that might bite us? | 21:36 |
| *** celttechie has quit IRC | 21:39 | |
| *** pcm_ has quit IRC | 21:40 | |
| jogo | dhellmann: nope | 21:41 |
| *** mriedem has quit IRC | 21:41 | |
| jogo | dhellmann: in fact 2.2.3 is what 2.2.0 should have been | 21:41 |
| jogo | dhellmann: but I will double and triple check before cutting a release | 21:41 |
| jogo | 2.2.2* should have been | 21:42 |
| dhellmann | jogo: ok, just thinking about timing | 21:42 |
| jogo | dhellmann: yeah, so am I in the other sense of the phrase | 21:42 |
| dhellmann | jogo: +2a | 21:42 |
| jogo | we can make flake8 much faster | 21:42 |
| jogo | dhellmann: I am planning on cutting hacking 0.9.3 | 21:43 |
| jogo | which will have no new rules | 21:43 |
| jogo | and just drop a few rules | 21:43 |
| jogo | and make things concurrent | 21:43 |
| *** ajo_ has joined #openstack-oslo | 21:43 | |
| *** harlowja is now known as harlowja_away | 21:43 | |
| jogo | but I will do extra checking before cutting it | 21:43 |
| dhellmann | jogo: cool. People generally know to yell at you and not me if hacking breaks things, so I'm OK with that whenever you're ready, I just wanted to verify. :-) | 21:43 |
| jogo | dhellmann: hehe sounds good | 21:44 |
| jogo | dhellmann: thanks | 21:44 |
| jogo | dhellmann: I should have cut this release a month ago or so | 21:44 |
| dhellmann | zzzeek: it looks like the work on https://blueprints.launchpad.net/oslo/+spec/use-events-for-error-wrapping is done. is there anything pending that's not linked to the bp? | 21:48 |
| dhellmann | zzzeek: nevermind, that bp is already marked implemented | 21:48 |
| zzzeek | i was just looking at that, as I found it odd that the BP doesn’t list out in the “all blueprints” listing | 21:48 |
| * dhellmann makes appointment for eye doctor | 21:48 | |
| zzzeek | dhellmann: starting out the BP for transactionalized tests: https://blueprints.launchpad.net/oslo/+spec/long-lived-transactionalized-db-fixtures now I actually listed out three things there. Do you think I should split out those three things, and do each need their own BP ? | 21:51 |
| zzzeek | dhellmann: that is, there’s opportunistic URL configuration, there’s “run tests in transactions against long lived shcemas”, then there’s use test scenarios | 21:51 |
| zzzeek | opprtunistic URL config is quite trivial and is sort of rolled up into “run tests aginst long lived schemas" | 21:52 |
| zzzeek | scenarios can be something separate | 21:52 |
| *** stannie has quit IRC | 21:54 | |
| *** markmcclain has joined #openstack-oslo | 21:54 | |
| *** markmcclain has quit IRC | 21:54 | |
| dhellmann | zzzeek: is this the thing you were going to write a spec about? I think you can probably include all of those aspects in the spec if they are tightly related | 21:54 |
| zzzeek | dhellmann: great, because they are :) | 21:55 |
| dhellmann | this is the thing you were talking with lifeless about, right? | 21:55 |
| zzzeek | yes | 21:55 |
| *** dims has quit IRC | 21:55 | |
| dhellmann | ok | 21:55 |
| *** tongli has quit IRC | 21:55 | |
| zzzeek | who has not gotten back to me with any code | 21:55 |
| dhellmann | yeah, write up your plan and then we'll see about robert's input | 21:55 |
| *** dims has joined #openstack-oslo | 21:56 | |
| *** markmcclain has joined #openstack-oslo | 21:56 | |
| *** praneshp has quit IRC | 21:56 | |
| *** praneshp has joined #openstack-oslo | 21:57 | |
| *** praneshp has quit IRC | 21:57 | |
| *** praneshp has joined #openstack-oslo | 21:57 | |
| dhellmann | cores, can I get a quick review of a small doc change? https://review.openstack.org/#/c/102819/ | 21:58 |
| *** harlowja_away is now known as harlowja | 22:00 | |
| *** dims has quit IRC | 22:00 | |
| *** alexpilotti has quit IRC | 22:06 | |
| *** ajo_ has quit IRC | 22:09 | |
| *** bknudson has quit IRC | 22:13 | |
| *** jecarey has joined #openstack-oslo | 22:19 | |
| *** xazel has joined #openstack-oslo | 22:21 | |
| *** enykeev has quit IRC | 22:22 | |
| *** mtanino has quit IRC | 22:22 | |
| *** GheRivero has quit IRC | 22:23 | |
| *** GheRivero has joined #openstack-oslo | 22:24 | |
| *** tsufiev has quit IRC | 22:29 | |
| *** tsufiev_ has joined #openstack-oslo | 22:29 | |
| *** stevemar has quit IRC | 22:32 | |
| *** dtantsur_ has joined #openstack-oslo | 22:34 | |
| *** andreykurilin1 has joined #openstack-oslo | 22:34 | |
| *** ildikov_ has joined #openstack-oslo | 22:36 | |
| *** praneshp_ has joined #openstack-oslo | 22:37 | |
| *** mrda has quit IRC | 22:37 | |
| *** dmitryme has quit IRC | 22:37 | |
| *** dtantsur has quit IRC | 22:37 | |
| *** dtantsur_ is now known as dtantsur | 22:37 | |
| *** praneshp has quit IRC | 22:39 | |
| *** praneshp_ is now known as praneshp | 22:39 | |
| *** jecarey_ has joined #openstack-oslo | 22:40 | |
| *** ildikov has quit IRC | 22:40 | |
| *** dmitryme has joined #openstack-oslo | 22:41 | |
| *** andreykurilin has quit IRC | 22:43 | |
| *** openstackgerrit has quit IRC | 22:43 | |
| *** jd__ has quit IRC | 22:43 | |
| *** jd__ has joined #openstack-oslo | 22:43 | |
| *** jecarey has quit IRC | 22:43 | |
| *** HenryG has quit IRC | 22:46 | |
| *** flaper87|afk has quit IRC | 22:48 | |
| *** flaper87|afk has joined #openstack-oslo | 22:48 | |
| *** jaosorior has quit IRC | 22:52 | |
| *** jgrimm is now known as zz_jgrimm | 22:52 | |
| *** dtantsur has quit IRC | 22:55 | |
| *** dtantsur has joined #openstack-oslo | 22:55 | |
| *** praneshp has quit IRC | 22:55 | |
| *** praneshp has joined #openstack-oslo | 22:55 | |
| *** mrda has joined #openstack-oslo | 23:04 | |
| *** alexpilotti has joined #openstack-oslo | 23:06 | |
| *** markmcclain has quit IRC | 23:07 | |
| *** tsekiyama has joined #openstack-oslo | 23:28 | |
| *** pcm has joined #openstack-oslo | 23:37 | |
| *** bknudson has joined #openstack-oslo | 23:37 | |
| *** gordc has quit IRC | 23:42 | |
| *** jecarey_ has quit IRC | 23:51 | |
| *** vishy has joined #openstack-oslo | 23:57 | |
| vishy | are there any oslo.messaging experts around? | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!