| *** SridharG has joined #openstack-oslo | 00:05 | |
| *** yamahata has quit IRC | 00:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/106591 | 00:11 |
|---|---|---|
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Updated from global requirements https://review.openstack.org/105173 | 00:11 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/106592 | 00:11 |
| *** tsekiyama has joined #openstack-oslo | 00:16 | |
| *** tsekiyama has quit IRC | 00:21 | |
| *** harlowja_away is now known as harlowja | 00:30 | |
| *** arnaud__ has quit IRC | 00:39 | |
| *** oomichi has joined #openstack-oslo | 00:42 | |
| *** arnaud__ has joined #openstack-oslo | 00:42 | |
| *** bknudson has joined #openstack-oslo | 00:43 | |
| *** dims__ has joined #openstack-oslo | 00:58 | |
| *** dims__ has quit IRC | 01:03 | |
| *** yamahata has joined #openstack-oslo | 01:09 | |
| *** bknudson has left #openstack-oslo | 01:17 | |
| openstackgerrit | Angus Lees proposed a change to openstack/oslo.db: Specify raise_on_warnings=False for mysqlconnector https://review.openstack.org/107221 | 01:30 |
| *** bknudson has joined #openstack-oslo | 01:35 | |
| *** mriedem has quit IRC | 01:37 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add existing types to generated documentation https://review.openstack.org/106930 | 01:41 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/oslo-specs: Convert oslo.cache to use dogpile.cache https://review.openstack.org/97155 | 01:43 |
| *** mriedem has joined #openstack-oslo | 01:46 | |
| openstackgerrit | A change was merged to openstack/oslo-incubator: Allow deprecated decorator to specify no plan for removal https://review.openstack.org/106599 | 01:50 |
| *** arnaud__ has quit IRC | 01:58 | |
| *** novas0x2a|laptop has quit IRC | 02:41 | |
| *** arnaud__ has joined #openstack-oslo | 02:44 | |
| *** praneshp has quit IRC | 02:47 | |
| *** dims__ has joined #openstack-oslo | 02:52 | |
| *** arnaud__ has quit IRC | 02:55 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.utils: export only try_import in __all__ https://review.openstack.org/106778 | 03:01 |
| *** arnaud__ has joined #openstack-oslo | 03:03 | |
| *** harlowja is now known as harlowja_away | 03:16 | |
| *** arnaud__ has quit IRC | 03:22 | |
| *** mriedem has left #openstack-oslo | 03:31 | |
| *** mriedem has quit IRC | 03:31 | |
| *** zzzeek has quit IRC | 04:01 | |
| *** dims__ has quit IRC | 04:10 | |
| *** SridharG has quit IRC | 04:12 | |
| *** jaosorior has joined #openstack-oslo | 04:13 | |
| *** praneshp_ has joined #openstack-oslo | 04:27 | |
| *** dstanek is now known as dstanek_zzz | 04:54 | |
| *** harlowja_at_home has joined #openstack-oslo | 04:54 | |
| *** SridharG has joined #openstack-oslo | 04:59 | |
| *** bnemec has quit IRC | 05:03 | |
| *** jecarey has quit IRC | 05:03 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Translate engine runner into a well defined state-machine https://review.openstack.org/106535 | 05:06 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add existing types to generated documentation https://review.openstack.org/106930 | 05:10 |
| *** harlowja_at_home has quit IRC | 05:23 | |
| *** harlowja_at_home has joined #openstack-oslo | 05:24 | |
| *** ildikov has quit IRC | 05:39 | |
| *** dims__ has joined #openstack-oslo | 05:39 | |
| *** harlowja_at_home has quit IRC | 05:41 | |
| *** dims__ has quit IRC | 05:44 | |
| *** noelbk has quit IRC | 05:51 | |
| *** noelbk has joined #openstack-oslo | 05:52 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.i18n: Imported Translations from Transifex https://review.openstack.org/106938 | 06:03 |
| *** ildikov has joined #openstack-oslo | 06:09 | |
| openstackgerrit | Armando Migliaccio proposed a change to openstack/oslo.messaging: Track the attempted method when raising UnsupportedVersion https://review.openstack.org/107240 | 06:14 |
| *** harlowja_at_home has joined #openstack-oslo | 06:21 | |
| *** abhishek_ has joined #openstack-oslo | 06:30 | |
| *** markmc has joined #openstack-oslo | 06:31 | |
| *** flaper87 has quit IRC | 06:34 | |
| *** flaper87 has joined #openstack-oslo | 06:34 | |
| *** harlowja_at_home has quit IRC | 06:40 | |
| *** dims__ has joined #openstack-oslo | 06:40 | |
| *** dims__ has quit IRC | 06:45 | |
| *** tkelsey has joined #openstack-oslo | 06:50 | |
| *** jecarey has joined #openstack-oslo | 06:53 | |
| *** praneshp_ has quit IRC | 06:59 | |
| *** i159 has joined #openstack-oslo | 07:15 | |
| *** pblaho has joined #openstack-oslo | 07:18 | |
| openstackgerrit | Roman Podoliaka proposed a change to openstack/oslo.db: WIP: PoC connection defaults checker https://review.openstack.org/106800 | 07:22 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Opportunistic migration tests https://review.openstack.org/93424 | 07:28 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Implementation Alembic as migration engine https://review.openstack.org/99965 | 07:28 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Utility function for robust schema drop https://review.openstack.org/106419 | 07:28 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Opportunistic migration tests https://review.openstack.org/93424 | 07:31 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Implementation Alembic as migration engine https://review.openstack.org/99965 | 07:31 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Utility function for robust schema drop https://review.openstack.org/106419 | 07:31 |
| *** ChanServ changes topic to "#openstack-oslo" | 07:55 | |
| *** pblaho has quit IRC | 08:04 | |
| *** nacim has joined #openstack-oslo | 08:08 | |
| *** alexpilotti has joined #openstack-oslo | 08:13 | |
| *** ihrachyshka has joined #openstack-oslo | 08:16 | |
| *** mrda is now known as mrda-afk | 08:17 | |
| *** ihrachyshka has quit IRC | 08:22 | |
| *** ihrachyshka has joined #openstack-oslo | 08:23 | |
| *** ildikov has quit IRC | 08:33 | |
| *** yamahata has quit IRC | 09:04 | |
| *** mkoderer has joined #openstack-oslo | 09:11 | |
| *** oomichi has quit IRC | 09:16 | |
| *** dims__ has joined #openstack-oslo | 09:29 | |
| *** dims__ has quit IRC | 09:33 | |
| *** dims__ has joined #openstack-oslo | 09:48 | |
| openstackgerrit | A change was merged to openstack/oslo.vmware: Fix docstrings of constructors https://review.openstack.org/106386 | 09:51 |
| *** Alexei_987 has quit IRC | 10:04 | |
| *** alexpilotti has quit IRC | 10:09 | |
| *** pcm_ has joined #openstack-oslo | 10:09 | |
| *** pcm_ has quit IRC | 10:11 | |
| *** pcm_ has joined #openstack-oslo | 10:12 | |
| openstackgerrit | garyk proposed a change to openstack/oslo.vmware: Add in a retry decorator https://review.openstack.org/107295 | 10:12 |
| openstackgerrit | garyk proposed a change to openstack/oslo.vmware: Add in a retry decorator https://review.openstack.org/107295 | 10:14 |
| openstackgerrit | A change was merged to openstack/oslo-incubator: Fix deletion of cached file for policy enforcer https://review.openstack.org/106433 | 10:22 |
| *** mrda-afk is now known as mrda | 10:29 | |
| openstackgerrit | Abhijeet Malawade proposed a change to openstack/oslo.messaging: Removing cyclic reference of listener object https://review.openstack.org/103186 | 10:33 |
| *** nacim has quit IRC | 10:35 | |
| openstackgerrit | Christian Berendt proposed a change to openstack/oslotest: cleaning up index.rst file https://review.openstack.org/96100 | 10:40 |
| *** Alexei_987 has joined #openstack-oslo | 10:42 | |
| openstackgerrit | Vipin Balachandran proposed a change to openstack/oslo.vmware: Fix seek and tell in BlockingQueue https://review.openstack.org/107311 | 10:45 |
| openstackgerrit | garyk proposed a change to openstack/oslo.vmware: Add in a retry decorator https://review.openstack.org/107295 | 10:47 |
| openstackgerrit | A change was merged to openstack/oslo.rootwrap: Continue on failure of leaf filters of chaining filters https://review.openstack.org/106071 | 10:55 |
| openstackgerrit | Oleksii Chuprykov proposed a change to openstack/oslo.db: Modification to test_utils.py for sqla_07 test passing https://review.openstack.org/107317 | 10:57 |
| *** dims__ has quit IRC | 11:10 | |
| *** dims__ has joined #openstack-oslo | 11:13 | |
| openstackgerrit | Roman Vasilets proposed a change to openstack/oslo.db: I have extract debug logging output to a separate function https://review.openstack.org/106992 | 11:20 |
| *** pblaho has joined #openstack-oslo | 11:28 | |
| *** mrda is now known as mrda-away | 11:42 | |
| *** viktors|afk is now known as viktors | 11:44 | |
| *** yamahata has joined #openstack-oslo | 11:49 | |
| *** linkid has joined #openstack-oslo | 11:51 | |
| *** ildikov has joined #openstack-oslo | 11:55 | |
| *** SridharG has quit IRC | 11:57 | |
| *** nacim has joined #openstack-oslo | 11:58 | |
| *** linkid has quit IRC | 11:58 | |
| *** linkid has joined #openstack-oslo | 12:14 | |
| openstackgerrit | Christian Berendt proposed a change to openstack/pycadf: Bump hacking to version 0.9.2 https://review.openstack.org/107346 | 12:20 |
| *** yamahata has quit IRC | 12:25 | |
| abhishek_ | hi all, can any one review this oslo-spec, https://review.openstack.org/#/c/106285/ | 12:27 |
| abhishek_ | thank you | 12:27 |
| *** dims__ has quit IRC | 12:28 | |
| *** dims__ has joined #openstack-oslo | 12:30 | |
| *** yamahata has joined #openstack-oslo | 12:30 | |
| openstackgerrit | Christian Berendt proposed a change to openstack/taskflow: Bump hacking to version 0.9.2 https://review.openstack.org/107353 | 12:34 |
| *** bknudson has quit IRC | 12:39 | |
| *** SridharG has joined #openstack-oslo | 12:47 | |
| *** bknudson has joined #openstack-oslo | 12:57 | |
| *** dstanek_zzz is now known as dstanek | 13:05 | |
| *** mriedem has joined #openstack-oslo | 13:11 | |
| openstackgerrit | Alex Frolov proposed a change to openstack/oslo-incubator: test lazy_pluggable https://review.openstack.org/107373 | 13:17 |
| *** lbragstad has joined #openstack-oslo | 13:21 | |
| *** krotscheck has quit IRC | 13:28 | |
| *** hyakuhei has quit IRC | 13:30 | |
| *** zzzeek has joined #openstack-oslo | 13:31 | |
| *** jecarey has quit IRC | 13:32 | |
| *** krotscheck has joined #openstack-oslo | 13:34 | |
| *** hyakuhei has joined #openstack-oslo | 13:38 | |
| *** yamahata has quit IRC | 13:54 | |
| *** yamahata has joined #openstack-oslo | 13:54 | |
| *** jecarey has joined #openstack-oslo | 13:57 | |
| *** bnemec has joined #openstack-oslo | 14:03 | |
| dhellmann | bnemec: I think there are enough +1 votes on the serialization repo to start the import process when you're ready. | 14:05 |
| dhellmann | harlowja_away: Have you looked at the retry stuff in oslo.vmware? I'm curious to know if they should have used taskflow for that, esp. in light of the issues adding a new dependency. | 14:07 |
| openstackgerrit | A change was merged to openstack/oslo.vmware: Add support for using extensions https://review.openstack.org/100911 | 14:13 |
| openstackgerrit | Christian Berendt proposed a change to openstack/oslo.vmware: Bump hacking to version 0.9.2 https://review.openstack.org/107399 | 14:18 |
| *** tsekiyama has joined #openstack-oslo | 14:19 | |
| *** lbragstad has quit IRC | 14:20 | |
| *** lbragstad has joined #openstack-oslo | 14:22 | |
| openstackgerrit | A change was merged to openstack/oslo-incubator: Make logging_context_format_string optional in log.set_defaults https://review.openstack.org/107082 | 14:22 |
| bnemec | dhellmann: Cool, I'll move forward with it then. | 14:24 |
| openstackgerrit | Christian Berendt proposed a change to openstack/oslo.messaging: Bump hacking to version 0.9.2 https://review.openstack.org/107401 | 14:26 |
| *** tongli has joined #openstack-oslo | 14:26 | |
| openstackgerrit | Christian Berendt proposed a change to openstack/oslo.db: Bump hacking to version 0.9.2 https://review.openstack.org/107402 | 14:28 |
| openstackgerrit | Christian Berendt proposed a change to openstack/oslo.config: Bump hacking to version 0.9.2 https://review.openstack.org/107403 | 14:29 |
| *** lbragstad has quit IRC | 14:33 | |
| *** nacim has quit IRC | 14:35 | |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/oslo-specs: Convert oslo.cache to use dogpile.cache https://review.openstack.org/97155 | 14:47 |
| *** lbragstad has joined #openstack-oslo | 14:54 | |
| *** lbragstad has quit IRC | 14:56 | |
| *** lbragstad has joined #openstack-oslo | 14:58 | |
| *** abhishek_ has quit IRC | 15:11 | |
| *** viktors is now known as viktors|afk | 15:21 | |
| openstackgerrit | Bryan Jones proposed a change to openstack/oslo.db: Added check for DB2 deadlock error https://review.openstack.org/106458 | 15:31 |
| openstackgerrit | Oleksii Chuprykov proposed a change to openstack/oslo.db: Make test_project_filter_allow_none pass SA 0.7.x https://review.openstack.org/107317 | 15:34 |
| *** i159 has quit IRC | 15:37 | |
| *** ihrachyshka has quit IRC | 15:38 | |
| *** ildikov_ has joined #openstack-oslo | 15:41 | |
| *** pcm_ has quit IRC | 15:41 | |
| *** ildikov has quit IRC | 15:43 | |
| openstackgerrit | Alex Frolov proposed a change to openstack/oslo-incubator: test lazy_pluggable https://review.openstack.org/107373 | 15:47 |
| openstackgerrit | Alex Frolov proposed a change to openstack/oslo-incubator: Transfer class LazyPluggable from nova to oslo-incubator https://review.openstack.org/107424 | 15:47 |
| openstackgerrit | Alex Frolov proposed a change to openstack/oslo-incubator: Transfer class LazyPluggable from nova to oslo-incubator https://review.openstack.org/107425 | 15:47 |
| *** yamahata has quit IRC | 15:47 | |
| *** HenryG is now known as HenryG_afk | 15:49 | |
| *** jonesbr has joined #openstack-oslo | 15:54 | |
| jonesbr | mriedem: ping | 15:55 |
| mriedem | jonesbr: so https://review.openstack.org/#/c/106458/, | 15:55 |
| mriedem | not all projects are using oslo.db yet | 15:55 |
| mriedem | but there are projects that will need that fix | 15:55 |
| mriedem | but i'm not sure if we can cherry pick things from oslo.db to oslo-incubator, but we'd need them in oslo-incubator to sync to projects that aren't using oslo.db | 15:55 |
| mriedem | bnemec: dhellmann: what's the policy on something like that right now when new projects aren't using the new libs yet? ^ | 15:56 |
| openstackgerrit | Romain Soufflet proposed a change to openstack/oslo-incubator: Fix tests.unit.reports.* with python3.4 https://review.openstack.org/105749 | 15:56 |
| mriedem | jonesbr: plus we'd want it on stable/icehouse | 15:56 |
| mriedem | so i'd think it would have to be cherry picked from oslo.db to oslo-incubator on master so it can be synced to projects on master not using oslo.db yet, and then cherry pick from those projects back to their stable/icehouse branches, something like that... | 15:57 |
| mriedem | or cherry pick from master o-i to stable/icehouse o-i and then sync from stable/icehouse o-i to e.g. nova stable/icehouse | 15:57 |
| mriedem | it's confusing | 15:57 |
| bnemec | mriedem: The flow goes: oslo.db -> oslo-incubator master -> oslo-incubator stable | 15:58 |
| mriedem | and sync from o-i on whatever branch you need | 15:58 |
| bnemec | Right | 15:58 |
| mriedem | ok, jonesbr make sense? | 15:59 |
| *** linkid has left #openstack-oslo | 15:59 | |
| mriedem | jonesbr: so try cherry picking your oslo.db change as-is now to oslo-incubator on master | 15:59 |
| mriedem | and see if it merges | 15:59 |
| jonesbr | mriedem: makes sense | 15:59 |
| mriedem | jonesbr: if the test refactor causes merge conflicts, i'd probably go back to ps3 and leave the cleanup of the tests in oslo.db to a separate change | 15:59 |
| mriedem | jonesbr: you can use gerrit UI to get the cherry pick string | 16:00 |
| mriedem | e.g. git fetch ssh://mriedem@review.openstack.org:29418/openstack/oslo.db refs/changes/58/106458/4 && git cherry-pick -x FETCH_HEAD | 16:00 |
| *** nacim has joined #openstack-oslo | 16:02 | |
| openstackgerrit | Alex Frolov proposed a change to openstack/oslo-incubator: Transfer class LazyPluggable from nova to oslo-incubator https://review.openstack.org/107429 | 16:04 |
| *** yamahata has joined #openstack-oslo | 16:08 | |
| *** praneshp has joined #openstack-oslo | 16:11 | |
| jonesbr | mriedem: merge conflicts, so I'll revert back to ps3 | 16:17 |
| *** markmc has quit IRC | 16:20 | |
| *** lbragstad has quit IRC | 16:20 | |
| openstackgerrit | A change was merged to openstack/oslo-incubator: Add default log level for websocket https://review.openstack.org/101908 | 16:21 |
| *** yamahata has quit IRC | 16:21 | |
| *** praneshp has quit IRC | 16:22 | |
| mriedem | jonesbr: well are they bad? and i'm assuming it's just in the tests? | 16:24 |
| *** praneshp has joined #openstack-oslo | 16:28 | |
| jonesbr | mriedem: merge conflicts in both files | 16:30 |
| mriedem | jonesbr: hmm, well if you're going to have merge conflicts anyway, might just do ps4 | 16:31 |
| mriedem | and be done with it | 16:31 |
| mriedem | i'd hope that people aren't doing things in oslo-incubator that aren't also going into oslo.db | 16:32 |
| mriedem | but it's probably the other way around | 16:32 |
| *** tkelsey has quit IRC | 16:38 | |
| jonesbr | mriedem: it doesn't look like the postgresql deadlock detection patch was ever backported to incubator so I'm getting merge conflicts from that | 16:43 |
| *** nacim has quit IRC | 16:47 | |
| *** Alexei_987 has quit IRC | 16:48 | |
| *** lbragstad has joined #openstack-oslo | 16:51 | |
| *** lbragstad has quit IRC | 16:56 | |
| *** HenryG_afk is now known as HenryG | 16:56 | |
| *** arnaud__ has joined #openstack-oslo | 16:57 | |
| *** jecarey has quit IRC | 17:04 | |
| *** dstanek is now known as dstanek_zzz | 17:06 | |
| *** pcm_ has joined #openstack-oslo | 17:06 | |
| *** openstackgerrit has quit IRC | 17:16 | |
| *** openstackgerrit has joined #openstack-oslo | 17:17 | |
| *** harlowja_away is now known as harlowja | 17:18 | |
| *** harlowja is now known as harlowja_away | 17:19 | |
| *** harlowja_away is now known as harlowja | 17:19 | |
| harlowja | dhellmann i haven't looked at much of oslo.vmware, i did see the retrying library pop up there | 17:20 |
| harlowja | as well as in tooz, jd__ i think is using it now also | 17:20 |
| harlowja | dhellmann i haven't actually looked at oslo.vmware really at all, let me give it a quick look | 17:21 |
| harlowja | on first notice i see, https://github.com/openstack/oslo.vmware/blob/master/oslo/vmware/api.py#L45 which seems to be exactly what the retry library itself does | 17:22 |
| *** amrith has joined #openstack-oslo | 17:22 | |
| amrith | hello oslo team ... anybody home? | 17:26 |
| amrith | dhellmann, ping ... | 17:27 |
| harlowja | amrith usually better to just ask your question and see if anyone responds, whats up, not sure if i can help but people are typically around | 17:28 |
| amrith | harlowja, thx. I work on trove and saw a bug https://review.openstack.org/#/c/106008/ | 17:29 |
| amrith | in this fix for bug https://bugs.launchpad.net/trove/+bug/1340124 | 17:29 |
| amrith | the request is that when an error occurs in execute() that more information is logged; like what really happened. | 17:30 |
| amrith | execute() has this information and returns it as part of the exception | 17:30 |
| amrith | In trove there is a wrapper (execute_with_timeout) that is being fixed to provide this additional logging. | 17:30 |
| harlowja | k | 17:30 |
| amrith | My request was to see whether oslo would like a patch to fix execute() to provide the same thing | 17:30 |
| amrith | it would help and make a common message get logged from all projects when an execute failed | 17:31 |
| amrith | I entered a bug in oslo for this based on feedback from a trove core team member | 17:31 |
| harlowja | right, it would seem to be useful to do in oslo | 17:31 |
| amrith | that bug is https://bugs.launchpad.net/oslo/+bug/1342857 | 17:31 |
| amrith | I'm happy to submit the patch to oslo but didn't want to go and do it if it was something that oslo felt was not appropriate; and that it is something best left up to the caller. | 17:32 |
| amrith | you'll see from the proposal I made in the fix to the trove bug that I wanted it to be a parameter sent by caller to execute() | 17:32 |
| amrith | that would trigger this additional logging | 17:32 |
| harlowja | so i'll let others say if they agree with it, but it seems reasonable to me | 17:32 |
| dhellmann | amrith: there's a discussion about logging standards that might apply to your question, especially if the inputs or outputs of the command might contain private data: https://review.openstack.org/#/c/91446/ | 17:33 |
| * amrith goes to look | 17:33 | |
| *** Alexei_987 has joined #openstack-oslo | 17:34 | |
| amrith | dhellmann, in trove there is a similar effort already ongoing. https://bugs.launchpad.net/trove/+bug/1324206 | 17:35 |
| amrith | I've been fixing some bugs in this area | 17:35 |
| dhellmann | amrith: ok, good. that nova spec is meant to be cross-project, but was put there because we didn't have a place for cross-project specs | 17:35 |
| amrith | and therefore my interest in this fix is in a similar direction | 17:35 |
| amrith | I'll bring it up at the trove meeting today at 2 | 17:36 |
| amrith | we've already got a bunch of code going in; rationalizing error logging and things to make it such that you don't have to do exactly what Jay Pipes said; that they have to run at level DEBUG to get anywhere. | 17:36 |
| amrith | and as part of that change in trove, one of the things we're doing is to make logging for specific exceptions and situations to be standardized | 17:37 |
| amrith | so that automation can run on these log files | 17:37 |
| amrith | it was in that latter context that I was hoping that when execute() encountered an error, all clients, across projects could spit out an identically formatted error with the same set of information. | 17:37 |
| amrith | so I'll submit some code for https://bugs.launchpad.net/oslo/+bug/1342857 for your review. Thanks much! | 17:39 |
| *** shakamunyi has joined #openstack-oslo | 17:39 | |
| *** shakamunyi has quit IRC | 17:39 | |
| amrith | And I'll bring https://review.openstack.org/#/c/91446/ up at the trove meeting today. thanks dhellmann and harlowja! | 17:39 |
| harlowja | np | 17:39 |
| mriedem | jonesbr: so i would probably cherry pick the postgresql fix back and then cherry pick yours on top of that | 17:40 |
| mriedem | jonesbr: since we should have both in nova | 17:40 |
| mriedem | and nova isn't using oslo.db yet | 17:40 |
| *** shakamunyi has joined #openstack-oslo | 17:40 | |
| dhellmann | amrith: I think following the new guidelines, it would really be up to the application and not the oslo library to decide if an error from an external application needed to be logged. So we should make it possible for the application to do that, but I don't think we want oslo to log all errors automatically. | 17:41 |
| amrith | dhellmann, oslo would not log automatically | 17:41 |
| dhellmann | amrith: ok, I thought that's what you were proposing above but I must have misunderstood | 17:41 |
| amrith | instead if a call to execute() came in with a parameter of log_errors or some such thing, then it would generate an error message indicating the command etc | 17:42 |
| *** shakamunyi has quit IRC | 17:42 | |
| dhellmann | ah | 17:42 |
| amrith | take a look at the change in https://review.openstack.org/#/c/106008/3/trove/common/utils.py,cm | 17:42 |
| amrith | you'll notice that if execute_with_timeout() receives the parameter log_output_on_error then it will spit out the message | 17:43 |
| amrith | and so it is up to the client application (trove, for example) which would in some cases request this. | 17:43 |
| amrith | dhellmann, does that make sense? | 17:44 |
| *** abhishek__ has joined #openstack-oslo | 17:46 | |
| *** tongli has quit IRC | 17:46 | |
| dhellmann | amrith: that does, but it raises the security concern -- the library has no idea if any of those arguments are passwords, or if the output might include user data or something else that shouldn't be logged | 17:48 |
| dhellmann | amrith: that's why it's better for the application to log the error, it knows what the args and outputs are likely to contain, and it can sanitize them | 17:48 |
| amrith | dhellmann, I hadn't thought of that; I will raise that in the review. | 17:49 |
| amrith | I primarily am interested in logging error (code/description) | 17:49 |
| amrith | and not the full command etc., | 17:49 |
| dhellmann | amrith: the trick is to figure out a way to do that without exposing data, but it should be possible | 17:50 |
| amrith | thanks for the pointer, I will keep that in mind as I create a solution. I hadn't considered it. thanks | 17:50 |
| dhellmann | amrith: sure thing :-) | 17:50 |
| *** lbragstad has joined #openstack-oslo | 17:55 | |
| *** lbragstad has quit IRC | 17:58 | |
| *** arnaud__ has quit IRC | 17:59 | |
| *** lbragstad has joined #openstack-oslo | 17:59 | |
| jonesbr | mriedem: no merge conflicts when done in that order | 18:03 |
| mriedem | jonesbr: ok, that's what i'd do then | 18:06 |
| mriedem | jonesbr: is there already a backport to oslo-incubator for the postgresql change? | 18:07 |
| jonesbr | mriedem: the postgresql change is not in oslo-incubator, which is why I had merge conflicts when I tried to cherry-pick my change because it depends on the postgresql change | 18:08 |
| mriedem | jonesbr: i know, just wondering if wingwj proposed a backport of the postgresql fix | 18:09 |
| mriedem | jonesbr: not seeing one | 18:10 |
| mriedem | so should be ok to backport both | 18:10 |
| *** flaper87 is now known as flaper87|afk | 18:10 | |
| jonesbr | mriedem: me either | 18:10 |
| *** dims__ has quit IRC | 18:11 | |
| *** pblaho has quit IRC | 18:12 | |
| jonesbr | mriedem: for that do I just submit the cherry-picks in incubator for review? | 18:12 |
| *** mkoderer has quit IRC | 18:12 | |
| mriedem | jonesbr: yes, you'd have 2 cherry picks in a series | 18:13 |
| mriedem | series == topic branch | 18:13 |
| dhellmann | jonesbr: yes, and please make sure the commit message describes them as a cherry pick of the work in oslo.db (the review should go more quickly that way) | 18:13 |
| *** flaper87 has joined #openstack-oslo | 18:25 | |
| jonesbr | mriedem, dhellmann: will the change-ids from the cherry-picked commits cause issues? should they be removed? | 18:27 |
| *** dims__ has joined #openstack-oslo | 18:35 | |
| *** SridharG has quit IRC | 18:44 | |
| *** pblaho has joined #openstack-oslo | 18:50 | |
| *** pblaho has quit IRC | 18:50 | |
| *** dims__ has quit IRC | 19:08 | |
| *** novas0x2a|laptop has joined #openstack-oslo | 19:09 | |
| *** ildikov has joined #openstack-oslo | 19:10 | |
| *** arnaud__ has joined #openstack-oslo | 19:12 | |
| *** jaosorior has quit IRC | 19:12 | |
| *** ildikov_ has quit IRC | 19:13 | |
| *** novas0x2a|laptop has quit IRC | 19:27 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Ensure state machine can be frozen https://review.openstack.org/107479 | 19:30 |
| *** lbragstad has quit IRC | 19:34 | |
| *** novas0x2a|laptop has joined #openstack-oslo | 19:36 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Better handle the tree freeze method https://review.openstack.org/107481 | 19:38 |
| *** arnaud__ has quit IRC | 19:41 | |
| *** lbragstad has joined #openstack-oslo | 19:46 | |
| openstackgerrit | A change was merged to openstack/oslo.db: Use explicit loops instead of list comprehensions https://review.openstack.org/106760 | 19:46 |
| *** ihrachyshka has joined #openstack-oslo | 19:52 | |
| HenryG | rpodolyaka: ping | 19:55 |
| HenryG | How do I make a mysql backend available for oslo.db sqlalchemy unit tests? | 19:57 |
| *** arnaud__ has joined #openstack-oslo | 19:58 | |
| *** flaper87 has quit IRC | 20:01 | |
| *** abhishek__ has quit IRC | 20:05 | |
| harlowja | HenryG http://paste.openstack.org/show/86801/ might work for u | 20:05 |
| harlowja | i use that for taskflow, which afaik has similar oppurtunoitic tests as oslo.db | 20:05 |
| harlowja | nothing special, ^ should not be used for any machine u don't control, lol | 20:06 |
| harlowja | but i shove that into a nova boot --userdata and then i get a new test host | 20:07 |
| *** dims has joined #openstack-oslo | 20:14 | |
| dims | dhellmann, ping (oslo.i18n / nova review) | 20:20 |
| dhellmann | dims: here | 20:20 |
| HenryG | harlowja: I picked and chose the bits that I needed from that and it works! Thanks!! | 20:20 |
| dhellmann | jonesbr: the change ids should be fine as long as the changes are on different branches -- it actually helps show the relationships in gerrit, so using the same idea is a good thing | 20:20 |
| jonesbr | dhellmann: thanks for the help | 20:21 |
| dhellmann | dims: I have a new patch, but was distracted while the tests were running | 20:22 |
| dhellmann | dims: pushing now | 20:22 |
| dims | dhellmann, thanks! :) | 20:22 |
| openstackgerrit | Bryan Jones proposed a change to openstack/oslo-incubator: Add _wrap_db_error support for postgresql https://review.openstack.org/107488 | 20:22 |
| openstackgerrit | Bryan Jones proposed a change to openstack/oslo-incubator: Backport deadlock detection from oslo.db https://review.openstack.org/107489 | 20:22 |
| dhellmann | dims: I had to rebase it, so you may want to review it a bit more carefully than just the __init__.py we were discussing | 20:22 |
| dims | yep, will do | 20:22 |
| *** pcm_ has quit IRC | 20:22 | |
| dhellmann | the conflicts were all in the import blocks in modules that had been touched elsewhere, so flake8 ought to catch them | 20:23 |
| *** yamahata has joined #openstack-oslo | 20:23 | |
| dhellmann | dims: and in fact I see pep8 errors here, let me fix those and try again | 20:23 |
| dims | k | 20:23 |
| *** dstanek_zzz is now known as dstanek | 20:25 | |
| dhellmann | dims: patch set 14 is up | 20:29 |
| dims | ack. thanks | 20:29 |
| *** ihrachyshka has quit IRC | 20:34 | |
| openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Store PBM wsdl in the oslo.vmware git repository https://review.openstack.org/102409 | 20:38 |
| *** pcm_ has joined #openstack-oslo | 20:39 | |
| *** pcm_ has quit IRC | 20:41 | |
| *** pcm_ has joined #openstack-oslo | 20:41 | |
| *** lbragstad has quit IRC | 20:44 | |
| *** lbragstad has joined #openstack-oslo | 20:45 | |
| harlowja | HenryG np | 20:45 |
| *** arnaud__ has quit IRC | 21:21 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a sample script that can be used to build a test environment https://review.openstack.org/107506 | 21:32 |
| harlowja | HenryG if u get a sec ^ (just posting that for others) | 21:33 |
| *** arnaud__ has joined #openstack-oslo | 21:33 | |
| harlowja | *at least as an example | 21:33 |
| openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Store PBM wsdl in the oslo.vmware git repository https://review.openstack.org/102409 | 21:35 |
| *** pcm_ has quit IRC | 21:45 | |
| *** mriedem has left #openstack-oslo | 21:50 | |
| *** zzzeek has quit IRC | 21:54 | |
| *** zzzeek_ has joined #openstack-oslo | 21:54 | |
| Alexei_987 | dhellmann: hi are you available? | 22:13 |
| Alexei_987 | harlowja: ping | 22:14 |
| harlowja | Alexei_987 yo | 22:14 |
| Alexei_987 | small question about messaging.rpc stuff https://wiki.openstack.org/wiki/Oslo/Messaging#Invoke_Method_on_all_of_Multiple_Servers | 22:14 |
| Alexei_987 | here wiki says that Rpc can invoke method on *all* servers | 22:15 |
| harlowja | k, not sure i can answer that one :-P | 22:15 |
| Alexei_987 | but it doesn't specify method type (call|cast) | 22:15 |
| Alexei_987 | so the question is do we support multicall? | 22:15 |
| harlowja | unsure | 22:15 |
| Alexei_987 | cause it seems unclear of how do fetch results of those | 22:15 |
| Alexei_987 | harlowja: I'm implementing a zeromq driver so it's a fundamental question that affects the overall design | 22:16 |
| harlowja | ya, no doubt | 22:16 |
| Alexei_987 | harlowja: IMHO we do not do it now and should not do in the future | 22:16 |
| harlowja | multicall == fanout in your view? | 22:17 |
| Alexei_987 | no | 22:17 |
| Alexei_987 | fanout in terms of send | 22:17 |
| harlowja | oh, i got it | 22:17 |
| Alexei_987 | but also get multiple results | 22:17 |
| harlowja | multicall in terms of scatter-gather like functionality | 22:17 |
| Alexei_987 | yeah | 22:17 |
| Alexei_987 | fanout == multicast | 22:17 |
| harlowja | i don't believe those calls gather | 22:17 |
| harlowja | *those casts | 22:18 |
| Alexei_987 | in theory current rabbit driver can do something like this | 22:18 |
| Alexei_987 | would only return first result so | 22:18 |
| harlowja | i am unsure if 'at startup, nova-scheduler invokes the 'publish_service_capabilities' method in fanout mode on the 'compute' topic in the 'nova' exchange and all nova-compute services handle it ' is a scatter-gather though | 22:18 |
| harlowja | i think its a scatter, but no gather, in that compute nodes are just expected to reply sometime | 22:18 |
| Alexei_987 | yeah + 1 | 22:19 |
| harlowja | but i'm not 100% sure on that | 22:19 |
| Alexei_987 | ok I won't implement multicall for now and we'll see later | 22:19 |
| harlowja | k | 22:19 |
| Alexei_987 | harlowja: thanks | 22:19 |
| harlowja | sure | 22:20 |
| *** jonesbr has left #openstack-oslo | 22:21 | |
| *** jecarey has joined #openstack-oslo | 22:25 | |
| *** zzzeek_ has quit IRC | 22:26 | |
| *** lbragstad has quit IRC | 22:30 | |
| *** zzzeek has joined #openstack-oslo | 22:30 | |
| *** zzzeek has quit IRC | 22:32 | |
| *** dims_ has joined #openstack-oslo | 22:34 | |
| *** bknudson has quit IRC | 22:36 | |
| *** lbragstad has joined #openstack-oslo | 22:37 | |
| *** zzzeek has joined #openstack-oslo | 22:37 | |
| *** zzzeek has quit IRC | 22:37 | |
| *** dims has quit IRC | 22:38 | |
| *** zzzeek has joined #openstack-oslo | 22:39 | |
| *** lbragsta_ has joined #openstack-oslo | 23:01 | |
| *** lbragsta_ has quit IRC | 23:01 | |
| *** yamahata has quit IRC | 23:03 | |
| *** lbragstad has quit IRC | 23:04 | |
| *** mrda-away is now known as mrda | 23:20 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!