| sean-k-mooney | mikal: ack. im going ot sleep now but ill take another look tomrow or next week | 00:39 |
|---|---|---|
| opendevreview | Cyril Roelandt proposed openstack/os-vif master: Zuul: do not use USE_PYTHON3 https://review.opendev.org/c/openstack/os-vif/+/953510 | 00:49 |
| mikal | sean-k-mooney: no worries. The good news it was me forgetting you need a very recent libvirt / qemu for virtio sound to actually work. | 03:37 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add objects and notifications for sound model. https://review.opendev.org/c/openstack/nova/+/926126 | 03:55 |
| opendevreview | Michael Still proposed openstack/nova master: Implement sound model extra spec for libvirt. https://review.opendev.org/c/openstack/nova/+/940770 | 03:55 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add objects and notifications for USB controller model. https://review.opendev.org/c/openstack/nova/+/927354 | 03:55 |
| opendevreview | Michael Still proposed openstack/nova master: Implement USB controller extra spec for libvirt. https://review.opendev.org/c/openstack/nova/+/950643 | 03:55 |
| *** ykarel__ is now known as ykarel | 06:08 | |
| gibi | sean-k-mooney: when you are up, dansmith is +2 on https://review.opendev.org/c/openstack/nova/+/952966 can I get a +A? | 07:11 |
| gibi | this is the py3.13 fix | 07:11 |
| opendevreview | Kamil Sambor proposed openstack/nova master: Replace eventlet.event.Event with threading.Event https://review.opendev.org/c/openstack/nova/+/949754 | 07:19 |
| gibi | is it just me or CI is mosty shit due to etcd fails to start with 'listen tcp 65.17.193.12:2379: bind: cannot assign requested address' | 07:25 |
| gibi | https://bugs.launchpad.net/devstack/+bug/2115338 | 07:26 |
| gibi | maybe it is already fixed ^^: | 07:29 |
| gibi | sean-k-mooney: also if you can look back to https://review.opendev.org/c/openstack/nova/+/953121 Dan is +2 as well. This is the build_and_run_instance error handling patch | 07:32 |
| priteau | Hello. One of our customer experienced this bug: https://bugs.launchpad.net/nova/+bug/2074219. They are on Caracal. It made me realise the fix had not been backported from Epoxy. I submitted backports: https://review.opendev.org/c/openstack/nova/+/953468 and https://review.opendev.org/c/openstack/nova/+/953474 | 09:08 |
| priteau | Backports for 2024.2 first, I will submit 2024.1 once approved. | 09:08 |
| gibi | priteau: thanks for the backports I'm +2. Could you change the gerrit topic to bug/2074219 for better tracking? | 09:17 |
| gibi | elodilles: ^^ some easy backport reviews :) | 09:18 |
| priteau | Thanks, done | 09:21 |
| elodilles | gibi: ACK, will review it today when I get there o/ | 09:42 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Run unit test with threading mode https://review.opendev.org/c/openstack/nova/+/953475 | 09:54 |
| sean-k-mooney | gibi: done for the 3.13 patch ill look at the other one next | 11:42 |
| gibi | sean-k-mooney: thanks! | 11:43 |
| sean-k-mooney | gibi: i should know this but its been a while. in my devstack env what is the simplest way to run tempest? | 11:43 |
| sean-k-mooney | do you happen to knwo of the top of your head. i knwo that it preconfigures it for you and you can use tox | 11:44 |
| sean-k-mooney | is that the best way or just using the tempest command in one of the venvs? | 11:44 |
| sean-k-mooney | i know i have done both before | 11:44 |
| gibi | cd /opt/stack/tempest/ | 11:45 |
| gibi | source .tox/tempest/bin/activate | 11:45 |
| gibi | tempest run | 11:45 |
| sean-k-mooney | ack thanks i was not sure if that was still thge correct thing or not | 11:45 |
| gibi | that works for me | 11:45 |
| sean-k-mooney | ya i know that there used to be some script for it before they moved things to tox envs for the jobs and i knwo it has the idea of "workspaces" or whatever | 11:46 |
| sean-k-mooney | so i was not sure if i need to cd to a specific dir or something beyond the root of the repo | 11:46 |
| gibi | I never dig into workspaces | 11:46 |
| sean-k-mooney | cool ill give that a go and if i have issue ill just ask gmann later | 11:47 |
| gibi | btw the majority of the unit tests now run with threading in zuul https://review.opendev.org/c/openstack/nova/+/953475 I will work on the exclude list now | 11:47 |
| gibi | dansmith: ^^ fyu | 11:47 |
| sean-k-mooney | +2w on the rpc decorator change too | 11:47 |
| gibi | thanks | 11:47 |
| sean-k-mooney | oh cool sodo you need to set NOVA_RAISE_ON_GREENLET_LEAK=True again explcitly | 11:48 |
| sean-k-mooney | im fine with doing that but shoul that not be inherited form {[testenv]setenv} | 11:48 |
| gibi | I'm not sure about that any more I will check it | 11:48 |
| sean-k-mooney | oh | 11:48 |
| gibi | I'm not sure the env list is merged | 11:48 |
| sean-k-mooney | sorry its false by default | 11:48 |
| sean-k-mooney | so we need to turn it on in teh unit tests | 11:48 |
| gibi | ahh I see | 11:49 |
| sean-k-mooney | that why we also do it her https://review.opendev.org/c/openstack/nova/+/953475/2/tox.ini#64 | 11:49 |
| sean-k-mooney | well its not false exactly its undefiend | 11:49 |
| stephenfin | sean-k-mooney: could you revisit https://review.opendev.org/c/openstack/nova/+/952213 when you have a moment. I respun it to address gmaan's comments | 11:49 |
| sean-k-mooney | same effect. but cool so you hae a exuclded test list and i assume the plan is to burn that down over time | 11:50 |
| sean-k-mooney | sure, i dont have a meeting for anout hour so if there are thing people want me to review between now and then ping away | 11:51 |
| priteau | sean-k-mooney: What about https://review.opendev.org/c/openstack/nova/+/953468 and https://review.opendev.org/c/openstack/nova/+/953474 :) | 11:52 |
| priteau | Although you are the author, unsure about the policy of approving your own patch as backports? | 11:52 |
| gibi | yepp I'm working on those tests. Some will propably need to wait until we transform nova-compute | 11:52 |
| sean-k-mooney | priteau: i opened the tabsl so sure if i have time (i should) ill do those next. although i shoudl kick off that tempest run in the background first | 11:55 |
| sean-k-mooney | stephenfin: i think that is a good enhancement as well so +2w | 11:59 |
| stephenfin | ta | 11:59 |
| sean-k-mooney | i think there are 6 with +2w pending i belive https://review.opendev.org/c/openstack/nova/+/952284/3 is the fristwehre we need to re reivew | 12:00 |
| sean-k-mooney | but i proably wont get to that today | 12:00 |
| sean-k-mooney | ill try and loop back to it on tuesday. | 12:01 |
| sean-k-mooney | priteau: ah that backport i saw the pin in my email but did not get to it yet. | 12:02 |
| priteau | No worries if you don't, elodilles said he will check later | 12:05 |
| sean-k-mooney | gibi: ya i think that is fine, it would be nice to get basic testing running in check and non voting | 12:06 |
| sean-k-mooney | priteau: well im just done so perhaps it will have merged and they can look at the 2024.1 version | 12:06 |
| sean-k-mooney | the orgianal bug was intorduced in 2024.1 so that shoudl be the last backprot requried | 12:07 |
| priteau | yes, that's my plan to submit 2024.1 next. Thanks! | 12:08 |
| sean-k-mooney | would you mind assigned the backprot ones to you https://bugs.launchpad.net/nova/+bug/2074219 | 12:09 |
| sean-k-mooney | technially there is nothigh that needs that i just like to do it | 12:09 |
| priteau | done | 12:10 |
| sean-k-mooney | cool feel free to ping once the patch is up and passed ci and i can take anohter look for 2024.1 | 12:11 |
| sean-k-mooney | is grenade-skip-level-always TIMED_OUT currently a thing that people are seeign or just a one off? | 13:00 |
| gibi | grenade-skip-level-always timeout happens frequently, it times out while dumping the DBs but I found nothing speficic in any logs | 13:02 |
| gibi | sean-k-mooney: dansmith: do you have any suggestions where to look why nova.tests.unit.test_baserpc.BaseAPITestCase.test_ping hangs at the rpc.call (the request never received on the server side) when run with tox, while it passing when run with stestr (same arg list) top of https://review.opendev.org/c/openstack/nova/+/953475 | 13:39 |
| gibi | and when it hands it hangs forever not just for an arbitrary timeout | 13:40 |
| gibi | (OK I never waited forever but it is not stop at the normal testcase timeout) | 13:41 |
| Uggla | gmann, sean-k-mooney can you please have a look at https://review.opendev.org/c/openstack/nova/+/952894 and https://review.opendev.org/c/openstack/nova/+/952895 this is a small bug fix, I'd like to close. | 13:57 |
| gibi | ahh never mind, it hangs with stestr as well. I just forgot to turn the threading mode on in that terminal | 14:06 |
| opendevreview | Tobias Urdin proposed openstack/nova master: Remove gabbi from test-requirements.txt https://review.opendev.org/c/openstack/nova/+/953578 | 14:11 |
| opendevreview | Takashi Kajinami proposed openstack/placement master: Use standard FPGA resource class https://review.opendev.org/c/openstack/placement/+/953580 | 14:26 |
| opendevreview | Takashi Kajinami proposed openstack/placement master: Replace deprecated assertItemsEqual https://review.opendev.org/c/openstack/placement/+/953582 | 14:36 |
| opendevreview | Takashi Kajinami proposed openstack/placement master: Replace deprecated assertItemsEqual https://review.opendev.org/c/openstack/placement/+/953582 | 14:36 |
| opendevreview | Takashi Kajinami proposed openstack/placement master: Replace deprecated assertItemsEqual https://review.opendev.org/c/openstack/placement/+/953582 | 14:44 |
| opendevreview | Merged openstack/nova master: api: Add response body schemas for server diagnostics API https://review.opendev.org/c/openstack/nova/+/940506 | 15:15 |
| opendevreview | Merged openstack/nova master: Fix neutron client dict grabbing https://review.opendev.org/c/openstack/nova/+/952966 | 16:42 |
| opendevreview | Merged openstack/nova master: Note on RPC error decorators around build_and_run_instance https://review.opendev.org/c/openstack/nova/+/953121 | 16:42 |
| opendevreview | Merged openstack/nova master: api: Address issues with remote consoles APIs https://review.opendev.org/c/openstack/nova/+/952213 | 17:32 |
| opendevreview | Merged openstack/nova stable/2024.2: Add repoducer test for bug 2074219 https://review.opendev.org/c/openstack/nova/+/953468 | 17:32 |
| opendevreview | Merged openstack/nova stable/2024.2: Fix detaching devices by alias with mdevs https://review.opendev.org/c/openstack/nova/+/953474 | 17:32 |
| -opendevstatus- NOTICE: Gerrit is being restarted to pick up a configuration change. You may notice a short outage. | 17:37 | |
| opendevreview | Pierre Riteau proposed openstack/nova stable/2024.1: Add repoducer test for bug 2074219 https://review.opendev.org/c/openstack/nova/+/953656 | 18:05 |
| opendevreview | Pierre Riteau proposed openstack/nova stable/2024.1: Fix detaching devices by alias with mdevs https://review.opendev.org/c/openstack/nova/+/953662 | 18:11 |
| opendevreview | Merged openstack/nova master: api: Address issues with server diagnostics APIs https://review.opendev.org/c/openstack/nova/+/952341 | 20:29 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!