| opendevreview | Takashi Kajinami proposed openstack/placement master: Remove Python 3.9 support https://review.opendev.org/c/openstack/placement/+/953367 | 01:17 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/placement master: Remove Python 3.9 support https://review.opendev.org/c/openstack/placement/+/953367 | 01:17 |
| opendevreview | Merged openstack/nova master: api: Add response body schemas for remote consoles https://review.opendev.org/c/openstack/nova/+/940114 | 02:23 |
| opendevreview | Takashi Kajinami proposed openstack/placement master: Remove Python 3.9 support https://review.opendev.org/c/openstack/placement/+/953367 | 02:24 |
| opendevreview | Merged openstack/nova master: api: Add response body schemas for keypairs APIs https://review.opendev.org/c/openstack/nova/+/940115 | 07:19 |
| opendevreview | Rodolfo Alonso proposed openstack/nova master: [DNM] Test "grenade-skip-level-always" job https://review.opendev.org/c/openstack/nova/+/953402 | 07:21 |
| opendevreview | Kamil Sambor proposed openstack/nova master: Replace eventlet.event.Event with threading.Event https://review.opendev.org/c/openstack/nova/+/949754 | 08:15 |
| stephenfin | sean-k-mooney: Could you grab this openapi follow-up? https://review.opendev.org/c/openstack/nova/+/952214/2 There's another one here but it's failing functional tests currently (I'm working on it) https://review.opendev.org/c/openstack/nova/+/952213 | 08:45 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Address issues with remote consoles APIs https://review.opendev.org/c/openstack/nova/+/952213 | 09:03 |
| sean-k-mooney | stephenfin: looks fine to me | 10:36 |
| opendevreview | Merged openstack/nova master: Translate scatter-gather to futurist https://review.opendev.org/c/openstack/nova/+/947966 | 11:34 |
| opendevreview | Merged openstack/nova master: api: Add response body schemas for image metadata APIs https://review.opendev.org/c/openstack/nova/+/940299 | 11:35 |
| sahid | o/ | 12:11 |
| sahid | have you already suffered issue like Live Migration failure: <mac address> | 12:12 |
| sahid | I'm not able to find what could be the issue and unfortunatly the exception is logged like that | 12:13 |
| sahid | except Exception as e: | 12:13 |
| sahid | with excutils.save_and_reraise_exception(): | 12:13 |
| sahid | LOG.error("Live Migration failure: %s", e, instance=instance) | 12:13 |
| sahid | it s in live migration operation | 12:14 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Remove unnecessary test module level code https://review.opendev.org/c/openstack/nova/+/953436 | 12:28 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Allow to start unit test without eventlet https://review.opendev.org/c/openstack/nova/+/953436 | 12:47 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Allow to start unit test without eventlet https://review.opendev.org/c/openstack/nova/+/953436 | 12:56 |
| stephenfin | gmaan: Got a follow-up for you to re-approve here, when you've time https://review.opendev.org/c/openstack/nova/+/952213/ | 12:58 |
| stephenfin | sean-k-mooney: Oh, I also addressed your comment on https://review.opendev.org/c/openstack/nova/+/952281/ here https://review.opendev.org/c/openstack/nova/+/953281/ | 13:10 |
| stephenfin | and thanks for the review 🙏 | 13:10 |
| sean-k-mooney | stephenfin: cool +2w on teh organl patch and +2 on the fixup patch | 13:26 |
| sean-k-mooney | sahid: was it for an sriov port? i know that there have been issues with sriov ports adn attach/detach if there are more then one port with the same mac. havign a vm with multipel prot with the same mac is sort of unsupproted. | 13:28 |
| sean-k-mooney | its not | 13:28 |
| sean-k-mooney | but it was never expiclty added as a feature and kind fo bolted on as bugs were reported | 13:28 |
| sean-k-mooney | it woudl never happen with nova networks and it cant happen in a signel neutron network | 13:28 |
| sean-k-mooney | so nova never really blocked it. over time as neturon becausem the default we got bug reports that usign the mac to attach/dtach the prots failed fi you had a vm with 2 prots htat had the same mac | 13:29 |
| sean-k-mooney | sahid: we coudl also hith that internally when live migrating vms with sriov vnic-type=direct ports | 13:30 |
| sean-k-mooney | sahid: that is the only mac related live migration failure that i recall | 13:30 |
| opendevreview | Merged openstack/nova master: api: Add response body schemas for server topology API https://review.opendev.org/c/openstack/nova/+/940300 | 13:31 |
| sahid | sean-k-mooney: thanks for this, we don't use srio port, but it's more or less realted to vms AVI loadbalancer | 13:37 |
| sahid | it's strange, when i'm doing a port list for given vm that is buggy, there is 2 ports attached, and when looking at the xml, 5 interfaces are indicated | 13:53 |
| sahid | sean-k-mooney: have you already noticed something like that, where xml is not well cleaned? | 13:53 |
| opendevreview | Pierre Riteau proposed openstack/nova stable/2024.2: Add repoducer test for bug 2074219 https://review.opendev.org/c/openstack/nova/+/953468 | 15:03 |
| opendevreview | Pierre Riteau proposed openstack/nova stable/2024.2: Fix detaching devices by alias with mdevs https://review.opendev.org/c/openstack/nova/+/953474 | 15:35 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Run unit test with threading mode https://review.opendev.org/c/openstack/nova/+/953475 | 15:40 |
| gmaan | stephenfin: one question about doc generation, if we allow rdp in schema then how we reflect that it is gone in latest version https://review.opendev.org/c/openstack/nova/+/952213/comment/e644f810_7e7b50c2/ | 16:44 |
| stephenfin | gmaan: that depends on whether you're talking about the API perspective (i.e. clients) or the docs (i.e. humans/AI scrapers) | 17:24 |
| stephenfin | from the API/client perspective, we're already handling that by returning HTTP 400 (Bad Request) if you attempt to use it on a newer version of Nova (or an earlier version not using HyperV) so nothing needs to change there, IMO | 17:25 |
| stephenfin | gmaan: From the latter perspective, we'd likely handle that by either (a) indicating it in the 'description' text or (b) using a custom property that os-api-ref or its replacement can pick up | 17:27 |
| gmaan | stephenfin: yeah, we should update the description saying it is gone but my main concern in this change is how to indicate that now via response schema | 17:29 |
| stephenfin | gmaan: beyond what we're doing here? https://review.opendev.org/c/openstack/nova/+/952213/4/nova/api/openstack/compute/remote_consoles.py#161 | 17:30 |
| stephenfin | With this patch, we're moving validation (and rejection) from the schema into the method itself. The end result is the same though. | 17:31 |
| gmaan | I am thinking either we need to version (add different schema for each releases if changed) schema based on releases like we do for microversions by adding the info in current api-ref description | 17:31 |
| gmaan | stephenfin: code behavior wise it is all good that is why i am +1. I am thinking what is usage of showing it in schema and how to handle the case where we can say it is gone after caracal | 17:32 |
| stephenfin | So to be clear, you're worried about what the OpenAPI-derived replacement for api-ref will look like? | 17:33 |
| gmaan | exactly | 17:33 |
| gmaan | I do not want new OpenAPI-derived replacement show rdp as valid value | 17:33 |
| gmaan | if it consume response schema as it is | 17:33 |
| stephenfin | Well it is valid *if* you're using pre-Caracal and Hyper-V | 17:34 |
| stephenfin | So we'll still document it, but in the description we'll say "rdp doesn't work since Caracal etc. etc. | 17:34 |
| stephenfin | just like we do currently in the api-ref | 17:34 |
| stephenfin | All of these schemas - query, request body, and response body - are going to have additional metadata layered on top in terms of the description field. We're not doing that yet because these reviews are already numerous and difficult enough, but the future api-ref will have to have all the same context the current one does in order to be useful | 17:36 |
| gmaan | yeah, if openAPI will use the same content of field description and use schema as example show then we should update about rdp field here https://github.com/openstack/nova/blob/master/api-ref/source/parameters.yaml#L5986-L5999 | 17:38 |
| gmaan | so that if your change showing it in schema then updating current description about rdp should be done | 17:39 |
| gmaan | and if new content for field description are generated ( from schema or so) by openapi then we need to manually review it and your comment in schema works fine | 17:40 |
| gmaan | stephenfin: basically my request is to update the current api-ref description also if you are adding it in schema | 17:42 |
| stephenfin | oh! | 17:42 |
| stephenfin | I agree. I can do that | 17:42 |
| gmaan | cool | 17:42 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Address issues with remote consoles APIs https://review.opendev.org/c/openstack/nova/+/952213 | 21:28 |
| mikal | sean-k-mooney: Just so you know, I've seen your review comments about release notes. I wrote some, but in the process noticed that the extra specs aren't working quite how I expected so I am now debugging those. | 23:36 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!