| sean-k-mooney | tkajinam: readded my +2 | 00:00 |
|---|---|---|
| sean-k-mooney | tkajinam: i think we can pretent thid mergd today and if bauzas and dansmith agree merge it tomorrow | 00:01 |
| Callum027 | Yep, exactly, I'm happy to hear that. Looks like Ceilometer also does an API lookup to get `server.metadata` as well, I think I'll add that to the blueprint as well and we can call this a "add everything missing that Ceilometer needs" | 00:01 |
| sean-k-mooney | so that a littel diffent | 00:01 |
| sean-k-mooney | the peroblem with server.metadat is tha tcan change at any time since its the metadta proved to the end user within the metadta api | 00:02 |
| sean-k-mooney | Callum027: that not exactly private data but it shoudl not really be in the xml | 00:02 |
| Callum027 | Oh, that's too bad then | 00:02 |
| Callum027 | In that case that might be a topic to discuss on the Ceilometer side on how to handle that in the future | 00:03 |
| sean-k-mooney | we coudl perhaps dicusss that as a follow up but i susptec that woudl get pushback on privacy grounds | 00:03 |
| Callum027 | Fair enough. For my use case it's not required, there might be scope to simply disable fetching that inside Ceilometer if the administrator doesn't require it, especially if it could cause privacy issues by exposing it. | 00:04 |
| sean-k-mooney | Callum027: ill put it to you this way. while you would never pass a password via server metadata you might pass the lookup keey to pull applciation config form vault via metadata | 00:04 |
| sean-k-mooney | Callum027: it proably shoud be configurable yes | 00:05 |
| dansmith | sean-k-mooney: tkajinam I am EOD but I will be glad to look tomorrow.. That said, this seems like a bug fix (or at least mitigation) to me, so I'm not worried about merging it later | 00:05 |
| Callum027 | Yep. Thanks for letting me know about that, wasn't aware of the full implications of exposing that | 00:06 |
| sean-k-mooney | dansmith: enforcign multi path ya i can see that angle | 00:06 |
| sean-k-mooney | i just logged in to check something so i should proably call it there too o/ | 00:07 |
| opendevreview | Merged openstack/placement master: requirements: Remove setuptools https://review.opendev.org/c/openstack/placement/+/932398 | 01:04 |
| opendevreview | Merged openstack/placement master: reno: Update master for unmaintained/2023.1 https://review.opendev.org/c/openstack/placement/+/935123 | 01:04 |
| opendevreview | Merged openstack/placement master: Adapt cmd unit test depending on python version https://review.opendev.org/c/openstack/placement/+/939637 | 01:41 |
| opendevreview | Merged openstack/nova master: Switch to using oslo.utils secretutils https://review.opendev.org/c/openstack/nova/+/939721 | 01:42 |
| opendevreview | Merged openstack/nova master: Replace oslo_utils.encodeutils.exception_to_unicode https://review.opendev.org/c/openstack/nova/+/940619 | 01:43 |
| opendevreview | Merged openstack/placement master: Changed OS version CentOS to CentOS Stream. https://review.opendev.org/c/openstack/placement/+/940492 | 01:43 |
| opendevreview | Merged openstack/nova master: Correctly patch get_by_flavor_id https://review.opendev.org/c/openstack/nova/+/939722 | 01:43 |
| opendevreview | Merged openstack/nova master: Add managed flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/937649 | 01:43 |
| opendevreview | Merged openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604 | 02:14 |
| opendevreview | zhou zhong proposed openstack/nova master: Logging exception when query servers for further debug https://review.opendev.org/c/openstack/nova/+/942897 | 02:22 |
| opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.96 for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942875 | 02:42 |
| opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.98 doc/tests for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942878 | 02:43 |
| opendevreview | Callum Dickinson proposed openstack/nova master: Fix image ID in libvirt metadata when unshelving https://review.opendev.org/c/openstack/nova/+/942973 | 04:12 |
| opendevreview | Callum Dickinson proposed openstack/nova master: Add flavor ID to libvirt guest XML https://review.opendev.org/c/openstack/nova/+/942974 | 04:59 |
| opendevreview | Callum Dickinson proposed openstack/nova master: Fix image ID in libvirt metadata when unshelving https://review.opendev.org/c/openstack/nova/+/942973 | 05:04 |
| opendevreview | Merged openstack/placement master: Replace deprecated FormatChecker.cls_checks https://review.opendev.org/c/openstack/placement/+/935734 | 07:23 |
| opendevreview | Ivan Anfimov proposed openstack/nova master: doc: Enabling of using LibvirtDriver for compute node. https://review.opendev.org/c/openstack/nova/+/939325 | 07:26 |
| opendevreview | Ivan Anfimov proposed openstack/nova master: doc: Enabling of using LibvirtDriver for compute node. https://review.opendev.org/c/openstack/nova/+/939325 | 07:26 |
| opendevreview | Ivan Anfimov proposed openstack/nova master: doc: Enabling of using LibvirtDriver for compute node. https://review.opendev.org/c/openstack/nova/+/939325 | 07:27 |
| opendevreview | Tobias Urdin proposed openstack/nova master: Retry more volume API functions on server error https://review.opendev.org/c/openstack/nova/+/942981 | 08:53 |
| opendevreview | Callum Dickinson proposed openstack/nova master: Add image meta to libvirt XML metadata https://review.opendev.org/c/openstack/nova/+/942766 | 09:12 |
| Callum027 | sean-k-mooney: I've updated the blueprint and the existing patch with the changes from our discussion. I've also proposed two new changes, one for implementing the flavor ID in metadata as discussed (https://review.opendev.org/c/openstack/nova/+/942974), and other that fixes an issue where the wrong image ID gets inserted into libvirt metadata if | 09:17 |
| Callum027 | an ephemeral instance is unshelved (https://review.opendev.org/c/openstack/nova/+/942973). Hopefully everything looks good. | 09:17 |
| opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing finish_time https://review.opendev.org/c/openstack/nova/+/928933 | 10:01 |
| opendevreview | Tobias Urdin proposed openstack/nova master: wip: Reserve volumes when doing instance resize https://review.opendev.org/c/openstack/nova/+/942985 | 10:12 |
| sean-k-mooney | Callum027: nice find on the unshelve issue. can you file a bug for that so it could be backported? | 10:43 |
| Callum027 | Yep, can do | 11:22 |
| opendevreview | Callum Dickinson proposed openstack/nova master: Fix image ID in libvirt metadata when unshelving https://review.opendev.org/c/openstack/nova/+/942973 | 11:46 |
| Callum027 | sean-k-mooney: Created bug: https://bugs.launchpad.net/nova/+bug/2100588 - The current patch *should* be able to be cherry-picked into 2024.2 cleanly, I think 2024.1 will need some changes though | 11:48 |
| sean-k-mooney | Callum027: ya we can asses that when we get to that point | 11:52 |
| opendevreview | Tobias Urdin proposed openstack/nova master: wip: Reserve volumes when doing instance resize https://review.opendev.org/c/openstack/nova/+/942985 | 12:56 |
| dansmith | sean-k-mooney: bauzas are you around to +W this? https://review.opendev.org/c/openstack/nova/+/845660 | 14:43 |
| sean-k-mooney | sure | 14:43 |
| sean-k-mooney | by the way i am around but ill be finishing early today i.e. in the next hour or so | 14:46 |
| sean-k-mooney | dansmith: i assume your glance series is not going to be there this cycle | 14:46 |
| sean-k-mooney | so we dont need to land the gpt change? | 14:46 |
| sean-k-mooney | i.e. this https://review.opendev.org/c/openstack/nova/+/933928 | 14:46 |
| dansmith | sean-k-mooney: yeah >:( .. the glance part of that has been sitting since november | 14:47 |
| sean-k-mooney | this just future proofs us for when it is aviable | 14:47 |
| sean-k-mooney | i assume there is no point in merging that in nova first? | 14:48 |
| sean-k-mooney | i know you have a wip patch follwoing it | 14:48 |
| dansmith | yeah I mean, if that other thing never merges (or someone complains about the format name or something) it would be kinda silly to have pre-merged that in nova | 14:49 |
| dansmith | and it would be an easy backport if we needed to for some reason, so no real need to jump the gun I think | 14:50 |
| opendevreview | Tobias Urdin proposed openstack/nova master: Retry more volume API functions on server error https://review.opendev.org/c/openstack/nova/+/942981 | 15:14 |
| opendevreview | Tobias Urdin proposed openstack/nova master: wip: Reserve volumes when doing instance resize https://review.opendev.org/c/openstack/nova/+/942985 | 15:14 |
| opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.96 for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942875 | 17:06 |
| opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.98 doc/tests for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942878 | 17:13 |
| opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.98 doc/tests for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942878 | 17:14 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!