| opendevreview | melanie witt proposed openstack/nova master: scheduler: Add an ephemeral encryption pre filter https://review.opendev.org/c/openstack/nova/+/760456 | 05:36 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova master: block_device: Add DriverImageBlockDevice to block_device_info https://review.opendev.org/c/openstack/nova/+/826527 | 05:36 |
| opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to image and ephemeral disks https://review.opendev.org/c/openstack/nova/+/826528 | 05:36 |
| opendevreview | melanie witt proposed openstack/nova master: virt: Add block_device_info helper to find encrypted disks https://review.opendev.org/c/openstack/nova/+/826529 | 05:36 |
| opendevreview | melanie witt proposed openstack/nova master: blockinfo: Add encryption details to the disk_info mappings when provided https://review.opendev.org/c/openstack/nova/+/772272 | 05:36 |
| opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add disk_info_mapping as an optional attribute of Image https://review.opendev.org/c/openstack/nova/+/826530 | 05:36 |
| opendevreview | melanie witt proposed openstack/nova master: privsep: Move qemu-img create calls under nova.privsep.qemu https://review.opendev.org/c/openstack/nova/+/826750 | 05:36 |
| opendevreview | melanie witt proposed openstack/nova master: privsep: Return QemuImgInfo objects from qemu-img info calls https://review.opendev.org/c/openstack/nova/+/826751 | 05:36 |
| opendevreview | melanie witt proposed openstack/nova master: privsep: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | 05:36 |
| gibi | good morning nova | 06:45 |
| *** icey_ is now known as icey | 06:59 | |
| *** amoralej|off is now known as amoralej | 07:10 | |
| Uggla | Hello guys, dumb question. Is there a preferred style syntax for string. I mean any preference for 'string' or "string" ? | 09:27 |
| opendevreview | Wenping Song proposed openstack/nova-specs master: Usage of new trait of OWNER_NOVA https://review.opendev.org/c/openstack/nova-specs/+/836583 | 09:31 |
| opendevreview | Wenping Song proposed openstack/nova-specs master: Usage of new trait of OWNER_NOVA https://review.opendev.org/c/openstack/nova-specs/+/836583 | 09:34 |
| gibi | Uggla: no hard rule exists. I try to follow the style from the code around my edit (if that is consistent :D) | 09:38 |
| * gibi would go with an automatic black run if we could preserve git blame easily | 09:39 | |
| sean-k-mooney | gibi: or we can have pre-comit do it | 09:41 |
| sean-k-mooney | there is a rule that will make them all '' | 09:41 |
| gibi | yeah | 09:41 |
| sean-k-mooney | i used it on one of my other repos personaly i prefer "" | 09:41 |
| gibi | but black would change everything so we would loose git blame and easy backport | 09:41 |
| gibi | I use black for personal projects too | 09:42 |
| sean-k-mooney | but i prefer machine enforced style more | 09:42 |
| sean-k-mooney | oh i dont use black | 09:42 |
| sean-k-mooney | i just use pre-commit + autopep8 | 09:42 |
| gibi | ahh autopep8 | 09:42 |
| gibi | can it only format the current diff? | 09:42 |
| sean-k-mooney | i was suggesting we could use pre-commit to normalise the strings and have that run in the pep8 target | 09:42 |
| sean-k-mooney | if we wanted too | 09:43 |
| sean-k-mooney | yes | 09:43 |
| gibi | then I'm supportive | 09:43 |
| gibi | I use https://github.com/gibizer/blacken_selection in my IDE | 09:43 |
| sean-k-mooney | but we already did the gloabl update for autopep8 but pre-commit only runs on the current diff by default | 09:43 |
| Uggla | sean-k-mooney, is autopep8 will be "smart" enough to not broke strings like: "Share '0000:1222:1144:7777'" ? (strings where you want to display quotes). | 09:46 |
| sean-k-mooney | autopep8 wont change this we would have to use a pre-commit hook. autopep8 is conservitive and tries to only enforce pep8 rules and sting format is not one of them | 09:47 |
| sean-k-mooney | so we shoudl just test the hook. | 09:48 |
| sean-k-mooney | https://pre-commit.com/hooks.html | 09:48 |
| sean-k-mooney | double-quote-string-fixer | 09:48 |
| sean-k-mooney | is the one i use in other repo | 09:48 |
| Uggla | I have question regarding https://specs.openstack.org/openstack/nova-specs/specs/yoga/approved/libvirt-virtiofs-attach-manila-shares.html | 09:54 |
| Uggla | Is there a reason to have an "attachmentId" ? Not saying that because I forget it... :) | 09:55 |
| Uggla | this field is not used by the api. | 09:58 |
| sean-k-mooney | yes | 10:02 |
| sean-k-mooney | so a volume can have multiple attachments when its moving | 10:02 |
| sean-k-mooney | althoguh this is a manilla share | 10:03 |
| sean-k-mooney | so not entirly sure | 10:03 |
| sean-k-mooney | i woudl ahve to read the spec again | 10:03 |
| sean-k-mooney | Uggla so attachment id is the interanl id filed in the share_mappings table https://specs.openstack.org/openstack/nova-specs/specs/yoga/approved/libvirt-virtiofs-attach-manila-shares.html#data-model-impact | 10:05 |
| sean-k-mooney | i think the intent is to allow the share to be assoated with teh vim but with differe exprot locations during move operations | 10:07 |
| sean-k-mooney | but im not certin | 10:08 |
| Uggla | sean-k-mooney, each line of the table is unique by the couple instance_uuid, share_id | 10:08 |
| sean-k-mooney | i think attachment id was ment to be in the unique constraint | 10:08 |
| sean-k-mooney | lyarwood: ^ if you are around | 10:09 |
| sean-k-mooney | lyarwood: do you remember why we have attachment id | 10:09 |
| sean-k-mooney | if the id filed is just intended as a primary key it should be an integer not a uuid so the fact its listed as a uuid is what is making me belive it for move operations | 10:11 |
| Uggla | sean-k-mooney, I think I can add it easily, it is just to understand the purpose of it. | 10:11 |
| sean-k-mooney | so that we can create a new attachmet with a different export location for the destination. | 10:11 |
| sean-k-mooney | yep | 10:12 |
| Uggla | let's see id lyarwood can answer. If not I'll try to ping him. | 10:13 |
| sean-k-mooney | have you already implemented move operations | 10:13 |
| * lyarwood reads back | 10:14 | |
| sean-k-mooney | i dont think you will need it before then | 10:14 |
| sean-k-mooney | the other suecases is allowign the share to be mounted to the vm multiple times | 10:14 |
| lyarwood | yeah I was just typing that | 10:15 |
| lyarwood | I think this was more to do with the multi attach case of a share | 10:15 |
| Uggla | sean-k-mooney, with this first version --> Support for move operations once a share is attached will also not be covered by this spec | 10:16 |
| Uggla | sean-k-mooney, ny requests to shelve, evacuate, resize, cold migrate or live migrate an instance with a share attached will be rejected for the time being | 10:16 |
| lyarwood | that and debugging issues, I've always found it easier to use the underlying bdm id when tracing volume attachment issues | 10:16 |
| Uggla | lyarwood, ok make sens. | 10:18 |
| Uggla | lyarwood, thx | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: hacking: Prevent use of six https://review.opendev.org/c/openstack/nova/+/836588 | 10:25 |
| stephenfin | sean-k-mooney: bauzas: ^ | 10:25 |
| sean-k-mooney | stephenfin: care to add a pre-commit check? i guess that should be picked up by the flake8 check | 10:33 |
| sean-k-mooney | so i guess it already is there | 10:33 |
| sean-k-mooney | have you tested that locally to confirm one way or another? | 10:33 |
| sean-k-mooney | otherwise ya that looks like a good idea to me | 10:33 |
| gibi | Uggla: left a bunch of comments / questions on https://review.opendev.org/c/openstack/nova-specs/+/833669 (manila shares spec). Let me know if something of them are unclear | 10:50 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Sync rootwrap.conf from oslo.rootwrap https://review.opendev.org/c/openstack/nova/+/823229 | 11:14 |
| sean-k-mooney | stephenfin: actully i need to add that to the cinder ptg | 11:19 |
| sean-k-mooney | stephenfin:we only have rootwrap because of os-brick | 11:19 |
| sean-k-mooney | nova does not use it directly | 11:19 |
| sean-k-mooney | so i would like to move ti to os-brick | 11:19 |
| sean-k-mooney | that or we could finsih porting os-brick to privsep so that it does not need it either | 11:20 |
| stephenfin | makes sense | 11:22 |
| sean-k-mooney | i pinged the cinder folks to see if i can get a slot to chat to them about it in there ptg adgenda | 11:25 |
| sean-k-mooney | it looks pretty full so maybe we can do it in ours if they can have people join | 11:25 |
| sean-k-mooney | stephenfin: ping me when you have time to review my comments on the hacking change https://review.opendev.org/c/openstack/nova/+/836588 | 11:57 |
| sean-k-mooney | ill be afk for the next 30 mins or so but happy to look at that again when im back | 11:57 |
| opendevreview | Stephen Finucane proposed openstack/nova master: hacking: Prevent use of six https://review.opendev.org/c/openstack/nova/+/836588 | 11:59 |
| *** whoami-rajat__ is now known as whoami-rajat | 12:01 | |
| opendevreview | Stephen Finucane proposed openstack/nova master: pre-commit: Sync hacking version, bump plugins https://review.opendev.org/c/openstack/nova/+/836639 | 12:03 |
| stephenfin | sean-k-mooney: Thanks for the review. Fixed that issue | 12:03 |
| stephenfin | (good spot) | 12:03 |
| Uggla | gibi, thx I'm will have a look at your comments. | 12:15 |
| *** amoralej is now known as amoralej|lunch | 12:15 | |
| gibi | ack | 12:16 |
| sean-k-mooney | stephenfin: ack ill test them both locally again and then review | 12:29 |
| bauzas | stephenfin: ack too | 12:30 |
| bauzas | stephenfin: given it's only for new changes (thanks to hacking), it looks good to me | 12:30 |
| bauzas | oh waity | 12:36 |
| opendevreview | Merged openstack/nova master: Fix unit tests when they are run with OS_DEBUG=True https://review.opendev.org/c/openstack/nova/+/833115 | 12:37 |
| bauzas | stephenfin: sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/836588/2/nova/hacking/checks.py#1046 | 12:39 |
| sean-k-mooney | bauzas: we shoudl not currently have any usage of six in the codebases | 12:39 |
| sean-k-mooney | bauzas: https://codesearch.opendev.org/?q=six&i=nope&literal=nope&files=&excludeFiles=&repos=openstack%2Fnova | 12:40 |
| bauzas | that's what I was verifying | 12:41 |
| sean-k-mooney | bauzas: tox -e pep8 check all files and i verified that with pre-commit run --all-files also | 12:42 |
| sean-k-mooney | so i know that the only files that it flagged on where the two places i added it for testing | 12:42 |
| sean-k-mooney | so on master at least we are all good. replied in the revew with the codesearch link too | 12:43 |
| bauzas | sean-k-mooney: sent to the gate | 12:49 |
| opendevreview | Merged openstack/nova master: Remove the code that never reach https://review.opendev.org/c/openstack/nova/+/809572 | 13:07 |
| opendevreview | Merged openstack/nova master: Fix eventlet.tpool import https://review.opendev.org/c/openstack/nova/+/830383 | 13:07 |
| opendevreview | Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/836113 | 13:08 |
| *** amoralej|lunch is now known as amoralej | 13:13 | |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/xena: stable/xena: fix openstack-tox-lower-constraints https://review.opendev.org/c/openstack/nova/+/836650 | 13:18 |
| tobias-urdin | now when running_vms key is removed from /os-hypervisors/detail after microversion 2.87 what is the best way (without looping every single servers) to get total amount of instance and running vms using api? | 13:19 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/xena: stable/xena: fix openstack-tox-lower-constraints https://review.opendev.org/c/openstack/nova/+/836650 | 13:24 |
| *** artom__ is now known as artom | 13:28 | |
| opendevreview | Maxim Korezkij proposed openstack/nova master: Handle volume attachments https://review.opendev.org/c/openstack/nova/+/833234 | 13:33 |
| bauzas | reminder : we start our PTG in 20 mins \o/ | 13:40 |
| artom | Precarious Tricky Game? | 13:45 |
| bauzas | muh | 13:46 |
| tobias-urdin | hm I guess I could hit os-instance_usage_audit_log but that isn't reliable | 13:47 |
| *** dasm|off is now known as dasm | 13:59 | |
| *** dasm is now known as dasm|ruck | 14:00 | |
| sean-k-mooney | normally you would get the totals form placment | 14:00 |
| sean-k-mooney | and the runnign instance i guess via a openstack server list --all-tenant and filter that for running | 14:00 |
| sean-k-mooney | it depends on what you actually are trying to do | 14:00 |
| sean-k-mooney | tobias-urdin: ^ | 14:00 |
| sean-k-mooney | https://www.openstack.org/ptg/rooms/newton | 14:01 |
| sean-k-mooney | nova room ^ | 14:01 |
| bauzas | what sean-k-mooney said | 14:03 |
| bauzas | opening the PTG | 14:03 |
| stephenfin | I'll be along at :30. Got a conflict | 14:03 |
| opendevreview | Maxim Korezkij proposed openstack/nova master: Handle volume attachments https://review.opendev.org/c/openstack/nova/+/833234 | 14:08 |
| tobias-urdin | sean-k-mooney: we get allocations from placement (vcpu, memory, disk, gpu etc) instead of the old hypervisor statistics API but cannot find a way to get number of instances only resource usage | 14:10 |
| sean-k-mooney | you would count allocations of type instance | 14:11 |
| tobias-urdin | oh there is a consumer_type on allocations, i see, thanks :) | 14:12 |
| sean-k-mooney | although honestly openstack server list --all-projects is proably the best way to do this | 14:12 |
| sean-k-mooney | if you are an admin at least | 14:12 |
| sean-k-mooney | placement wont actully count shelved instnaces | 14:13 |
| sean-k-mooney | since they are not on a host | 14:13 |
| tobias-urdin | it's just to get an overview the easiest way (an less intensive way), isn't actually used for anything else since we have resource usage for planning | 14:13 |
| sean-k-mooney | so one of the reasons we remvoed this is it was cached info that can get out of sync if the resouce tracker had a problem | 14:14 |
| sean-k-mooney | e.g. any that broke the update_available_resouces preiodic task ment the data in the hypervior api was out of date | 14:15 |
| sean-k-mooney | server list on the other hand will always be correct | 14:15 |
| sean-k-mooney | if you do no hit the server detail api then i think it also only hits the api db | 14:15 |
| sean-k-mooney | so its fast | 14:16 |
| tobias-urdin | for now i'll just lazy guess with len(allocations) when hitting /resource_provider/<uuid>/allocations since the returned allocations doesn't include consumer_type like /allocations does | 14:25 |
| tobias-urdin | it doesn't have to be perfect, seems inefficient to just loop all allocations to check for VCPU resource or similar, so just using that for now | 14:26 |
| sean-k-mooney | consumer types is new | 14:29 |
| sean-k-mooney | so unless you are on yoga it wont be there | 14:29 |
| sean-k-mooney | before yoga they are always vms | 14:30 |
| sean-k-mooney | well no vms or migrations | 14:30 |
| tobias-urdin | ah, ack good to know then I can check that when we move to yoga | 14:30 |
| sean-k-mooney | yep | 14:30 |
| tobias-urdin | thanks! | 14:32 |
| dansmith | bauzas: are ya'll on track for cadence discussion at 1500? | 14:45 |
| bauzas | yup | 14:45 |
| dansmith | cool | 14:45 |
| sean-k-mooney | dansmith: technially we are slightly behind but going to jump to it at the top of the hour | 14:47 |
| dansmith | okay, I'm planning to come over for that, FYI | 14:47 |
| bauzas | + | 14:50 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/xena: stable/xena: fix openstack-tox-lower-constraints https://review.opendev.org/c/openstack/nova/+/836650 | 14:58 |
| opendevreview | Andre Aranha proposed openstack/nova master: Remove Centos 8 jobs https://review.opendev.org/c/openstack/nova/+/836665 | 14:59 |
| sean-k-mooney | gmann: we are staring the release cadance discussion | 15:01 |
| gmann | sean-k-mooney: thanks, I am in keystone too but will jpin | 15:02 |
| stephenfin | sean-k-mooney: Are you using a monospace font as your system font? What is _wrong_ with you? :-D | 15:03 |
| sean-k-mooney | yes | 15:03 |
| sean-k-mooney | yes i am | 15:03 |
| sean-k-mooney | i think im using source code pro | 15:04 |
| sean-k-mooney | source code pro regualar 10pt :) | 15:05 |
| sean-k-mooney | althoug my desktop font is notserif Nerd Font medium | 15:05 |
| sean-k-mooney | so it depends on the app | 15:06 |
| clarkb | source code pro is a great font | 15:10 |
| opendevreview | Merged openstack/nova master: hacking: Prevent use of six https://review.opendev.org/c/openstack/nova/+/836588 | 15:27 |
| gibi | bauzas: i will be 10 minutes late for the next session | 15:49 |
| bauzas | we're restarting the sessions | 15:51 |
| *** dasm|ruck is now known as dasm|ruck|mtg | 17:01 | |
| opendevreview | Stephen Finucane proposed openstack/python-novaclient master: Deprecate nova CLI https://review.opendev.org/c/openstack/python-novaclient/+/836682 | 17:05 |
| opendevreview | Stephen Finucane proposed openstack/python-novaclient master: docs: Update docs to reflect deprecation status https://review.opendev.org/c/openstack/python-novaclient/+/836683 | 17:05 |
| stephenfin | dansmith: export NOVACLIENT_IAMDAN=1 ^ yw | 17:08 |
| dansmith | lol | 17:10 |
| dansmith | fine with me, but probably should make that something else.. but definitely keep the comment :) | 17:11 |
| stephenfin | I initially used NOVACLIENT_IGNORE_DEPRECATION but I wanted to avoid people using this in e.g. ansible playbooks (vs. just changing their used commands). Giving it a weird name should make it sound less official, right? | 17:12 |
| dansmith | stephenfin: yeah that's a good goal... what you have might be too unofficial, but whatever :) | 17:25 |
| *** dasm|ruck|mtg is now known as dasm|ruck | 17:57 | |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: extend_volume of libvirt/volume/iscsi should not use device_path https://review.opendev.org/c/openstack/nova/+/836604 | 19:16 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: extend_volume of libvirt/volume/iscsi should not use device_path https://review.opendev.org/c/openstack/nova/+/836605 | 19:17 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: extend_volume of libvirt/volume/iscsi should not use device_path https://review.opendev.org/c/openstack/nova/+/836606 | 19:17 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/train: extend_volume of libvirt/volume/iscsi should not use device_path https://review.opendev.org/c/openstack/nova/+/836607 | 19:17 |
| opendevreview | Merged openstack/nova master: Fix wrong attribute to find remote address https://review.opendev.org/c/openstack/nova/+/836248 | 20:27 |
| *** dasm|ruck is now known as dasm|off | 22:43 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!