| *** amoralej|off is now known as amoralej | 07:06 | |
| *** amoralej is now known as amoralej|lunch | 12:06 | |
| yuval | Hey how do I join the PTG I need to download the eventbrite app? | 12:38 |
|---|---|---|
| sean-k-mooney | yuval: no | 12:42 |
| sean-k-mooney | yuval: https://ptg.opendev.org/ptg.html | 12:42 |
| sean-k-mooney | this is the ptg site | 12:42 |
| sean-k-mooney | if you click on the project in the calandar it will open the zoom meeting for you | 12:42 |
| sean-k-mooney | there is also the list of etherpads at the top | 12:42 |
| sean-k-mooney | some will use jitsi meet instead of zoom | 12:43 |
| sean-k-mooney | but you just need a web browzer to join | 12:43 |
| sean-k-mooney | no need to install the client or download eventbrite | 12:43 |
| kashyap | gibi[m]: Just to give a heads-up (for later): on this (old) CPU APIs patch, I've addressed some comments from Stephen, and I'm systematically combing through some of your older remarks - https://review.opendev.org/c/openstack/nova/+/762330/ | 12:48 |
| kashyap | gibi[m]: ... and adress what I can. I'll include a short changelog of summary when I post a revison, so you know what's addressed | 12:48 |
| yuval | thanks | 12:48 |
| kashyap | gibi[m]: Don't look at it yet, but just giving a heads-up for later :) | 12:48 |
| gibi | kashyap: ack, thanks for the headsup | 12:50 |
| bauzas | happy PTG for everyone | 13:01 |
| gibi | bauzas: o/ | 13:02 |
| bauzas | I have nothing specific in the PTG agenda that I want to go, but ping me if you want me to be around | 13:08 |
| *** amoralej|lunch is now known as amoralej | 13:08 | |
| bauzas | gmann: do you want me to be around on the QA meeting given you would discuss about Secure RBAC ? | 13:08 |
| gmann | bauzas: not as such from nova perspective but you can join on what plan we will do | 13:18 |
| bauzas | gmann: ok, b/c we have a TC/community session at 2pm UTC | 13:18 |
| gmann | bauzas: yeah, there we need you. but TC one will be after QA RBAC | 13:21 |
| bauzas | gmann: I'm around on QA | 13:21 |
| gmann | cool | 13:22 |
| bauzas | gmann: then I'll go to the TC meeting at 2pm | 13:22 |
| gmann | bauzas: thanks. | 13:26 |
| kashyap | gibi: I have a question on an old comment of yours here on line-795: https://review.opendev.org/c/openstack/nova/+/762330/20..23/nova/virt/libvirt/host.py | 13:35 |
| kashyap | gibi: You're saying about capabilities being logged but then we modify. I just want to make sure you've noticed the two libvirt APIs in play here: | 13:36 |
| kashyap | - getCapabilities will tell you what libvirt code can do in general ("yes, this libvirt is new enough for particular XML constructs") | 13:37 |
| kashyap | - getDomainCapbilities will tell you what libvirt can do with the given qemu-kvm binary | 13:37 |
| kashyap | Isn't the logging being done there is of getCapabilties(), but the modification on line 809/810 (PS20) is being done of _get_domain_capabilities() - the second API? | 13:38 |
| gibi | kashyap: I have to look at it again | 13:49 |
| gibi | give me some time :) | 13:50 |
| kashyap | Yeah, new context. If you're busy w/ PTG stuff, let it wait | 13:50 |
| kashyap | Right, I'm posting a new rev (not touching this part yet). Also closely read the note from chengsheng, I think he's confusing. (Or I'm doing it) | 13:50 |
| gibi | yeah, it was hard to follow | 13:51 |
| * kashyap nods; I squinted hard and see that it _is_ modifying _caps with "domcap[s]" | 13:54 | |
| *** dasm|ruck|off is now known as dasm|ruck | 13:59 | |
| gibi | kashyap: yeah, I think that is what I thought when I wrote the comment. | 14:00 |
| kashyap | gibi: You're right | 14:00 |
| gibi | kashyap: looking at master we already do that in case of arm | 14:00 |
| gibi | to add cpu features | 14:00 |
| kashyap | gibi: Already do what, sorry? Can you give a code pointer | 14:00 |
| gibi | https://github.com/openstack/nova/blob/b0851b0e9c82446aec2ea0317514766fbc53abc0/nova/virt/libvirt/host.py#L806 | 14:01 |
| gibi | we already modify self._caps after we logged it | 14:01 |
| kashyap | Ahh, so it is just "following the existing behaviour" from Ari | 14:02 |
| kashyap | s/Ari/Arm/ | 14:02 |
| gibi | it seems like so | 14:02 |
| gibi | so feel free to ignore that comment | 14:02 |
| kashyap | Right; I'll leave it intact in this case. | 14:03 |
| gibi | OK | 14:03 |
| kashyap | I'm addressing your other comments. Thanks for the quick look | 14:03 |
| gibi | thanks for picking that patch up | 14:06 |
| kashyap | gibi: I might need some more help to get it to the finish line. This is getting more important as I see bugs in this area that can be fixed by these APIs | 14:23 |
| opendevreview | Kashyap Chamarthy proposed openstack/nova master: Libvirt: Use improved guest CPU config APIs https://review.opendev.org/c/openstack/nova/+/762330 | 16:07 |
| sean-k-mooney | bauzas: have you finished organising the ptg adgenda by the way? | 16:15 |
| bauzas | sean-k-mooney: yup | 16:15 |
| sean-k-mooney | cool | 16:15 |
| * bauzas removes the 'shuffling in progress' header, my bad | 16:15 | |
| sean-k-mooney | we are starting at 14:00 utc ok | 16:16 |
| gibi | bauzas: do we want to add a separate agenda point for the blind recheck discussion or we handle that as part of the nova's CI footprint topic? | 16:16 |
| sean-k-mooney | neutron i think are starting at 13:00 so i will likely be intere room before we start | 16:16 |
| bauzas | gibi: good question, I saw your addition | 16:16 |
| bauzas | gibi: I'm ok with leaving it as one topic | 16:16 |
| bauzas | gibi: I don't have anything more to say besides it | 16:16 |
| sean-k-mooney | gibi: we used to have contibutor docs for recheck i dont think it will be contoverl to re add them to nova | 16:17 |
| gibi | sean-k-mooney: that is a good action item | 16:17 |
| gibi | bauzas: OK, lets keep it as is then | 16:17 |
| sean-k-mooney | so i hope its more an FYI and then proceed to the gerrit doc review for main details | 16:17 |
| bauzas | then let's move the CI point closer to the procedural section | 16:17 |
| bauzas | gibi: ^ | 16:17 |
| gibi | bauzas: I have no problem with that | 16:17 |
| bauzas | done | 16:18 |
| gibi | sean-k-mooney: top of the doc change I think we should start pointing to that doc when we see blind rechecks (i.e. apply peer pressure) | 16:18 |
| gibi | bauzas: cool | 16:18 |
| *** amoralej is now known as amoralej|off | 16:19 | |
| bauzas | gibi: yup, I think we agreed on ideally having a zuul reply that would provide this link but at least we can comment using this link | 16:19 |
| bauzas | but let's not start the conversation by now | 16:19 |
| gibi | yepp, I would you the link in my comment :) | 16:19 |
| gibi | ack | 16:19 |
| sean-k-mooney | gibi: we currently point to the shared contibutor doc but its kind of burried | 16:21 |
| sean-k-mooney | so the shared one already tells peopel to not do a blind recheck | 16:21 |
| sean-k-mooney | but again its not trivial to find that | 16:21 |
| bauzas | ideally this should be a contributor doc, not a project doc | 16:23 |
| sean-k-mooney | so here https://docs.openstack.org/nova/latest/contributor/code-review.html we have https://docs.openstack.org/infra/manual/developers.html#peer-review as the first line | 16:23 |
| sean-k-mooney | bauzas: it is | 16:23 |
| sean-k-mooney | in https://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing | 16:23 |
| sean-k-mooney | point 2 | 16:24 |
| sean-k-mooney | Examine the console log or other relevant log files to determine the cause of the error. If it is related to your change, you should fix the problem and upload a new patchset. Do not use “recheck”. | 16:24 |
| sean-k-mooney | we link to that in our testing doc https://opendev.org/openstack/nova/src/branch/master/doc/source/contributor/testing.rst#voting-in-gerrit | 16:25 |
| bauzas | sean-k-mooney: the point is, this is acceptable to do 'recheck something' | 16:25 |
| bauzas | provided 'something' is meaningful | 16:25 |
| sean-k-mooney | https://docs.openstack.org/nova/latest/contributor/testing.html#voting-in-gerrit | 16:25 |
| bauzas | sean-k-mooney: add those links to the etherpad and we'll discuss it once we're at this topic | 16:25 |
| sean-k-mooney | right but my point is its hard to find the exsing docs on when you should recheck | 16:25 |
| sean-k-mooney | sure | 16:26 |
| bauzas | sean-k-mooney: I don't disagree, this is tribal knowledge | 16:29 |
| bauzas | hence why I'd have appreciated some automatic zuul reply with link | 16:29 |
| sean-k-mooney | yes that is why i suggested doing that | 16:29 |
| bauzas | sean-k-mooney: I think I expressed this beforehand :p | 16:30 |
| bauzas | anyway, if there is a consensus, we should see how to do this | 16:30 |
| sean-k-mooney | i know how to do this | 16:30 |
| sean-k-mooney | its trivial | 16:30 |
| bauzas | not for me :) | 16:31 |
| bauzas | but I'll review you :p | 16:31 |
| sean-k-mooney | update this https://github.com/openstack/project-config/blob/master/zuul.d/pipelines.yaml#L10-L12= | 16:31 |
| sean-k-mooney | it currently links to the section that contians the guidence on when to recheck | 16:31 |
| sean-k-mooney | this is part of the pipeline config so it affect all jobs in the pipeline | 16:32 |
| sean-k-mooney | so it woudl be for all projects | 16:32 |
| sean-k-mooney | we likely and update that to be more explcit and say do not recheck without first reading .... | 16:32 |
| *** dasm|ruck is now known as dasm| | 22:26 | |
| *** dasm| is now known as dasm|off | 22:26 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!