Friday, 2022-02-25

opendevreviewmelanie witt proposed openstack/nova master: Follow up for unified limits  https://review.opendev.org/c/openstack/nova/+/83091800:10
opendevreviewMerged openstack/nova master: Make more project level APIs scoped to project only  https://review.opendev.org/c/openstack/nova/+/82867000:17
opendevreviewMerged openstack/nova master: Add volume-rebuild support to cinder module  https://review.opendev.org/c/openstack/nova/+/83088200:17
opendevreviewmelanie witt proposed openstack/nova-specs master: Amend unified limits spec to explain "API limit" enforcement  https://review.opendev.org/c/openstack/nova-specs/+/82941300:27
opendevreviewMerged openstack/nova master: Move keypair quota error message into exception  https://review.opendev.org/c/openstack/nova/+/82818601:48
opendevreviewMerged openstack/nova master: Add stub unified limits driver  https://review.opendev.org/c/openstack/nova/+/71213701:49
opendevreviewmelanie witt proposed openstack/nova master: Follow up for unified limits  https://review.opendev.org/c/openstack/nova/+/83091802:10
*** bhagyashris is now known as bhagyashris|ruck04:38
*** amoralej|off is now known as amoralej07:11
opendevreviewRajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild  https://review.opendev.org/c/openstack/nova/+/82036807:31
opendevreviewRajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild  https://review.opendev.org/c/openstack/nova/+/83093907:55
opendevreviewRajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild  https://review.opendev.org/c/openstack/nova/+/82036808:10
opendevreviewRajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances  https://review.opendev.org/c/openstack/nova/+/83088308:13
opendevreviewMerged openstack/nova master: Assert quota related API behavior when noop  https://review.opendev.org/c/openstack/nova/+/71214009:46
*** bhagyashris_ is now known as bhagyashris|ruck09:55
*** bhagyashris_ is now known as bhagyashris|ruck10:44
sean-k-mooneygibi: bauzas FF also applies to docs changes?10:54
bauzasno10:54
sean-k-mooneyok stephen has https://review.opendev.org/q/topic:notifications-docs and i was going to go review them10:55
sean-k-mooneythey will need a second +2 anyway but just wonderingif they should wait until after rc110:55
sean-k-mooneyif they can merge before it ill try and review them later today10:56
sean-k-mooneyotherwise i was going to wait and come back in a few weeks10:56
opendevreviewsean mooney proposed openstack/nova master: reenable greendns in nova.  https://review.opendev.org/c/openstack/nova/+/83096611:12
elodillesbauzas sean-k-mooney : fyi, yesterday was the deadline for yoga-milestone-3 client library releases, python-novaclient - https://review.opendev.org/c/openstack/releases/+/830249 , and osc-placement - https://review.opendev.org/c/openstack/releases/+/83022711:23
elodillesif you have a sec and could review them that would be awesome :)11:24
sean-k-mooneyack ill look at them now11:24
elodillessean-k-mooney: thanks \o/11:24
sean-k-mooneythanks for the reminder i forgot that m3 was the release deadline for client libs11:25
sean-k-mooney/libs//11:25
elodillesno worries :)11:32
opendevreviewsean mooney proposed openstack/nova master: reenable greendns in nova.  https://review.opendev.org/c/openstack/nova/+/83096611:41
sean-k-mooneythe nova client one looks correct so ill +1 that shortly11:41
sean-k-mooneygibi: i have not reviewed this yet but do we want to try and land https://review.opendev.org/c/openstack/osc-placement/+/82854511:50
sean-k-mooneybefore we do the osc-pacement release later today11:50
whoami-rajatsean-k-mooney, Hi, I'm not totally sure if which of the two reason is for the -2 on my patch (https://review.opendev.org/c/openstack/python-novaclient/+/827163)12:01
whoami-rajat1) if it's regarding proposing changes directly to OSC (in favor of deprecation of novaclient), i can do that sure12:01
whoami-rajat2) If it's regarding client freeze (due to which my patch wouldn't land in yoga) then the patch is up for review since long time and noone provided this feedback before12:02
sean-k-mooneywhoami-rajat: the freeze was yesterday12:10
sean-k-mooneyam but as of this cycle we are nolonger addign feature to novaclients cli12:10
sean-k-mooneyso that is the main rason for -212:10
sean-k-mooneyif you want to add helper funciton its fine12:10
sean-k-mooneybut in this case i think just adding it to osc is the way to go12:11
sean-k-mooneyim not sure is see a usecase wehre other projects will want to import nova client to trigger a rebuild but i guess heat coudl leverage that so im not againt having the libary functions in novaclient12:12
sean-k-mooneythe sdk woudl be better in the long run12:12
sean-k-mooneybut we intend to keep supporting novaclient as a python lib for a few cycles until sdk has full parity12:13
sean-k-mooneywhoami-rajat: i know -2 can seam a bit harsh but it was a mix of procedual and directional i would have just left a -1 if we were not past the feature freeze for the cycle12:15
sean-k-mooneywhoami-rajat: by the way just incase you are not aware -2 does not mean never it means the review has an objection directonaly or procerdurally beyond the content or quality of the code under review. if you recive a -2 it should always have an explaination as to why and you shoudl always feel free to reach out and discuss how to move forward as you have12:26
gibisean-k-mooney: regarding the osc-placement change, I will take that later as the lib FF happend last week13:08
gibiohh the yoga schedul has the client FF at the same time as the service FF13:10
gibistill it is not super important 13:10
sean-k-mooneyyes13:10
gibithis part of placement is mostly for machine consumption13:10
sean-k-mooneytechnially it would have been yesterday13:11
sean-k-mooneyok in that case i guess this can wait till next cycle13:11
sean-k-mooneyand i can approve the release patch13:11
gibiyes it can wait13:17
gibithanks for looking at the release patches13:17
gibiI had a crazy morning so I will only start really looking at gerit now13:17
sean-k-mooneythats ok13:18
sean-k-mooneyi signed up to be release liason this cycle so i really shoudl have done it yesterday but i was kind of tired after all the reviews this week13:19
sean-k-mooneyits not that any of them were hard really but all that context switching has a way of catching up with you that other work does not13:19
gibiyes, the last two days was really review heavy13:20
gibibut I think we have a farly good FF period13:21
*** amoralej is now known as amoralej|lunch13:21
gibi*fairly13:21
chateaulavsean-k-mooney: with all the changes merged yesterday. is it best to rebase and then continue the ci job patchset13:44
kashyapchateaulav: Thank you for the work on https://blueprints.launchpad.net/nova/+spec/pick-guest-arch-based-on-host-arch-in-libvirt-driver13:48
kashyapchateaulav: Hehe, you also added RISC-V too13:49
kashyapSorry that I couldn't take a deeper look earlier!  I trust the existing reviews :)13:49
chateaulavkashyap: lol, well tried, that will be another cycle. hit some roadblocks with ovo and there is some other things in its early stages that will help for eaiser implementation later13:50
chateaulavthanks and no worries13:50
kashyapchateaulav: ;-) For RISC-V stuff, check out the blog of Rich Jones (of libguestfs) here: https://rwmj.wordpress.com/tag/risc-v/13:51
kashyapHe does a lot of testing w/ new hardware.  And also maintains the Fedora RISC-V 13:51
chateaulavwill do, i got to the point of having it somewhat function, i was working through the loading custom firmware descriptor files for riscv becuase it uses specific uboot and opensbi13:53
chateaulavhave a lot of links and hadnt stumbled upon that one, so def will help13:54
opendevreviewDmitrii Shcherbakov proposed openstack/nova master: Fix migration with remote-managed ports & add FT  https://review.opendev.org/c/openstack/nova/+/82997413:58
sean-k-mooneychateaulav: am you could rebase the zuul patch altohg if you do while you are working on it its proably better to disable the other jobs14:02
dmitriissean-k-mooney, gibi: addressed comments in https://review.opendev.org/c/openstack/nova/+/829974 Tried testing revert_resize with cold migration but connection info doesn't seem to be updated to the right state (of the node an instance was migrated from) - would prefer to figure out why that is in a follow-up if possible14:02
sean-k-mooneychateaulav: just comment them out until you get your jobs working14:02
sean-k-mooneythen you can uncomment them14:02
sean-k-mooneychateaulav: it just saves ci time14:02
chateaulavk14:02
sean-k-mooneydmitriis: ack sure we can likely cover revert seperatly in a differnt patch14:03
sean-k-mooneydmitriis: have you tried it locally14:03
gibidmitriis: thanks. I will try to look at the patch14:03
*** amoralej|lunch is now known as amoralej14:03
sean-k-mooneydmitriis: as in does it work in reality and this is a func test issue or is revert actully broken14:04
dmitriissean-k-mooney: I've only tried in a func test form, need to do that with updated packages on a real env and 2 nodes14:05
dmitriisstill need to set up a virtualized setup with only 1 DPU - will work on that14:05
dmitriissean-k-mooney: fwiw, I think the issue might not be specific to remote-managed ports as I get something like this:14:10
dmitriis> /home/ubuntu/src/opendev/nova/nova/tests/fixtures/libvirt.py(1226)verify_hostdevs_interface_are_vfs()14:10
dmitriis-> pci_info_from_connection = self._connection.pci_info.devices[14:10
dmitriisn14:10
dmitriisKeyError: 'pci_0000_80_00_4'14:10
sean-k-mooneydmitriis: technially resize can be doen on a singel host14:11
dmitriisI'll try adding a test case to regular SR-IOV suite and see if it fails in the same way14:11
sean-k-mooneyso you can resize to a new flavor 14:11
sean-k-mooneythen tell it to revert14:11
sean-k-mooneyresize and cold migration use the same code 14:11
sean-k-mooneycold migration is implemetned as a resize to the same flaovr14:11
sean-k-mooneydmitriis: ack, im not sure if we have revert resize test for sriov14:12
sean-k-mooneyso ya it might just be a defect in the fixture14:12
dmitriissean-k-mooney: yeah, I'll try to add one but I'll probably run into the same14:12
whoami-rajatsean-k-mooney, yes, and if i would've got the feedback that the patch is not acceptable in novaclient, I would've worked on the OSC alternative before feature freeze as my patch was proposed on Jan 31st14:29
whoami-rajatthe problem is the nova side changes have merged and to make the full feature working, we need nova side changes as well14:30
whoami-rajateven if we get the nova API patch merged, without the client, i don't see much use of it for an end user14:30
whoami-rajatI suppose they rely on clients rather than directly hitting the API14:31
whoami-rajats/nova/cinder side changes have merged for the feature14:32
sean-k-mooneywell i guess we can try and do a early osc release after rc114:33
sean-k-mooneytechnially it would be teh Zed version but that would be an option14:34
sean-k-mooneyonce rc1 is tagged the stable branches get created and master reopens for the next release14:34
sean-k-mooneythats in about 2 weeks time14:34
sean-k-mooneyso if the osc team were open to it you coudl still proably get it in a osc release before the zed release is widely available14:35
whoami-rajatsean-k-mooney, ack, i will explore that option, thanks14:36
sean-k-mooneyit looks like we have not actully compelte ll the work items form the last ptg14:38
sean-k-mooneywhoami-rajat: https://etherpad.opendev.org/p/nova-yoga-ptg#L51314:39
sean-k-mooneyspecificaly we have not update dthe sepc template to call out the requriemtn for sdk/osc14:39
sean-k-mooneyill try and update the zed one to make that more clear to other going forward14:39
whoami-rajatack, that will be helpful14:40
*** amoralej is now known as amoralej|off15:00
bauzasok, fwiw, starting to use the -2 hammer15:01
bauzasgibi: I guess there is no procedural markup for the any-traits series ?15:08
gibibauzas: what do you mean by procedural markup?15:08
bauzasoh shit, nevermind, found the story15:08
bauzasgibi: I guess we can close https://storyboard.openstack.org/#!/story/2005345 ?15:09
gibiyeeah15:09
bauzasok, doing it15:09
gibiI thought my commit messages updated the story but it didn't15:09
gibi:/15:09
gibiI will add a link to the story to point to the implementation topic15:09
gibihm15:10
gibithe comments are there15:10
gibijust no tasks were created15:10
gibiahh comments is only from the spec patch15:10
gibistoryboard :/15:10
bauzasyeah :(15:11
dansmithbauzas: are you starting the -2 hammer for features?15:17
bauzasdansmith: I'm on it15:18
bauzasjust did the implemented scrubbing15:18
bauzasnow, next is the procedural hammer15:18
dansmithokay15:18
dansmithI guess that volume-backed-rebuild one is going to be off the table15:18
dansmithI think it's missing osc support and tempest testing15:18
dansmithbummer :(15:18
sean-k-mooneyosc support missed yes but is the api change merged?15:19
opendevreviewJonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support  https://review.opendev.org/c/openstack/nova/+/82837215:19
dansmithbauzas: the splitting helped uncover that it was introducing a data loss bug for the old path, so I'm super glad we did that15:19
dansmithsean-k-mooney: no15:19
bauzasdansmith: hah, good to know15:19
sean-k-mooneydansmith: ok then ya i guess that will miss15:20
sean-k-mooneythe cinder side is done?15:20
opendevreviewJonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support  https://review.opendev.org/c/openstack/nova/+/82837215:23
whoami-rajatsean-k-mooney, yes, cinder side changes are merged15:24
whoami-rajatbauzas, dansmith is there a chance we can get FFE for it?15:25
dansmithwhoami-rajat: up to bauzas but without osc and tempest yet it seems like a stretch :/15:25
opendevreviewJonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support  https://review.opendev.org/c/openstack/nova/+/82837215:26
whoami-rajati think we already discussed the OSC thing above, tempest I will complete by monday for sure15:26
bauzaswhoami-rajat: I haven't planned any FFE yet15:26
dansmithwell, I'll review the latest set in a bit regardless15:27
bauzaswhoami-rajat: I can left dansmith to reviewing the series 15:27
bauzaswhoami-rajat: but my concern is about the API microversion, it's a bit late 15:27
dansmithwhoami-rajat: I really want to see tempest before I even +2, FWIW15:28
dansmithfor something like this that'd always be my plan15:28
whoami-rajatack, I'm still working on passing the reimage_boot_volume parameter from API->Compute, bumping up RPC versions for conductor, compute, tests for it etc that is more work than i anticipated15:29
whoami-rajatalmost done with it15:29
dansmithwhoami-rajat: ah, I thought that was done in the latest..15:30
whoami-rajatbut again, I don't want to force any decisions, if the team doesn't want to include this as part of Yoga, we can continue work in Z15:30
whoami-rajatdansmith, completed it in manager but the 3rd patch is getting larger and larger15:30
whoami-rajatwill update that in sometime15:30
whoami-rajatneed to deal with the breaking tests since there's a new parameter in like 10-15 methods15:31
whoami-rajatso the 2nd patch is ready for review15:31
whoami-rajatbut 3rd needs some more work15:31
opendevreviewJonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support  https://review.opendev.org/c/openstack/nova/+/82837215:32
chateaulavjust running my one ci job, please dont think im trying to kill the pippeline. lol15:34
bauzaswhoami-rajat: we'll open the Zed release in two weeks15:36
bauzasI mean, the master will be Zed in two weeks15:36
plibeau1gibi: Hello, I have reply on your question for this change: https://review.opendev.org/c/openstack/nova/+/80371315:36
bauzaswhoami-rajat: so I propose you to provide again the spec for Zed as just a pre-approved spec 15:36
bauzaswe could accept this spec quickly15:37
gibiplibeau1: I've added your patch to my review queue15:37
bauzasso we could just review your implementation changes again in less than one month15:37
plibeau1gibi: thx15:37
sean-k-mooneychateaulav: no worries did you see my comment15:37
bauzasgibi: do you know where I could find a document for the -2 comment ? :)15:37
bauzasgibi: I mean, when I'll -2 the existing changes15:38
gibiI don't think it is documented in the PTL guide15:38
chateaulavsean-k-mooney: yeah it was acting weird the first couple times when i did just that, think i got it set right now15:38
gibiI just used a sentece stating that we are in feature freeze 15:38
sean-k-mooneychateaulav: you still hae the templates mind if i quickly fix it for you15:39
bauzasgibi: yeah, that's what I thought15:39
bauzasgibi: I'm pretty sure I can find it15:39
kashyapbauzas: Thx for the paperwork here - https://blueprints.launchpad.net/nova/+spec/virtio-as-default-display-device15:39
kashyap!15:39
opendevreviewsean mooney proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support  https://review.opendev.org/c/openstack/nova/+/82837215:41
sean-k-mooneychateaulav: ^ that should just run your job in check and check for merge conflicts15:41
sean-k-mooneyoh the alias15:43
opendevreviewsean mooney proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support  https://review.opendev.org/c/openstack/nova/+/82837215:45
sean-k-mooneychateaulav: if you want to keep an eye on it you can see it running here https://zuul.openstack.org/status#82837215:47
whoami-rajatbauzas, ack15:47
sean-k-mooneyim going to go to the store at the top of the hour then work form my laptop. when i get back so ill be off irc for a bit15:57
bauzasgmann: melwitt: I trust you for rechecking again your already approved patches in case you have problems with the CI16:14
bauzasI'll do a quick check on Monday morning my time to see if everything is merged16:14
gmannbauzas: yeah. release time and CI will behave like that :)16:21
opendevreviewRajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances  https://review.opendev.org/c/openstack/nova/+/83088316:26
whoami-rajatdansmith, ^ done with final patch16:26
dansmithack16:27
opendevreviewMerged openstack/nova master: Make unified limits APIs return reserved of 0  https://review.opendev.org/c/openstack/nova/+/71214116:40
bauzasok, I'm done for this (busy) week16:50
bauzassee ya folks 16:50
whoami-rajatdansmith, hey, the OSC client rebuild call is calling novaclient (AFAICS) so we do need the change in novaclient as well right? https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L354116:56
whoami-rajator there will be a structural change proposal to remove dependency of novaclient somehow...16:57
dansmithwhoami-rajat: I'm not on top of the state of that stuff.. I expect there are a bunch of calls not converted to native that still use novaclient? not sure16:57
dansmithbut if rebuild is currently going through novaclient today, I doubt anyone is going to make you change that before you merge :)16:57
whoami-rajatack, I'm totally confused with the deprecating novaclient and proposing changes directly to OSC first then...16:59
whoami-rajatsean-k-mooney, can you help with my query above? ^16:59
dansmithwhoami-rajat: yeah just not sure, but you're right to be confused/frustrated.. I'll look for sean-k-mooney to answer aw well17:00
dansmith*as17:00
whoami-rajatgood to know I'm not the only one :)17:03
whoami-rajatso this is my patch for OSC but it won't work without the novaclient patch https://review.opendev.org/c/openstack/python-openstackclient/+/83101417:16
whoami-rajatsimilar to the --hostname parameter introduced in 2.90 which depends on the novaclient patch https://github.com/openstack/python-openstackclient/commit/8e833a3ed26467a1190ba69d8ba716a7cd1cccb317:17
opendevreviewJonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support  https://review.opendev.org/c/openstack/nova/+/82837217:19
dmitriissean-k-mooney: I ended up getting the same result while trying to do a revert for an instance with a non-remote-managed PCI device https://paste.opendev.org/show/blQLSgsFtQbryq3q6ZJM/. I'll see if I can modify the fixture in a follow-up to test this.17:39
sean-k-mooneywhoami-rajat: we deprecated the nova cli not the python-novaclient package17:55
sean-k-mooneyit can still be used as a lib but we declared we woudl not continue to extend the nova command line clint and only add new microversion to osc17:55
sean-k-mooneywhoami-rajat: you can helps to novaclient, openstack sdk or just osc direclty without updating novaclient17:59
dansmiththe latter would require him to refactor all of the rebuild code in osc, so not likely right?18:01
opendevreviewJonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support  https://review.opendev.org/c/openstack/nova/+/82837218:01
sean-k-mooneyyes. we idealy want people to update sdk instead of nova python client18:02
sean-k-mooneythe only thing we decided to deprecate this cycle was the nova cli so im fine with removing the -2 form the novaclient patch after rc1 if we remove the addtion of the new partmar to the cli18:03
whoami-rajatif i update my novaclient patch without the shell changes (not extending nova CLI) and modify the rebuild method called by OSC, would it be acceptable?18:04
sean-k-mooneyyep18:04
sean-k-mooneythat is perfectly fine18:04
whoami-rajatack18:04
sean-k-mooneywe will be keeping it as a lib for other projefct to use to programticaly call nova for a few releases18:04
sean-k-mooneyeventually we would like heat ectra to use the sdk18:05
sean-k-mooneybut we have not made plans to remove it as a lib in the near term18:05
sean-k-mooneybut now that we have feature partiy for api microversion in osc we dont wnat ot continute adding support for microversion in nova client18:06
whoami-rajatgot it18:10
opendevreviewJonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support  https://review.opendev.org/c/openstack/nova/+/82837218:10
opendevreviewRajat Dhasmana proposed openstack/python-novaclient master: Add support to rebuild boot volume  https://review.opendev.org/c/openstack/python-novaclient/+/82716318:15
sean-k-mooney[m]whoami-rajat:  I dropped -2 on ^ but the release note still reference the nova cli change you dropped18:32
whoami-rajatsean-k-mooney[m], ack, will update it18:34
opendevreviewRajat Dhasmana proposed openstack/python-novaclient master: Add support to rebuild boot volume  https://review.opendev.org/c/openstack/python-novaclient/+/82716318:35
opendevreviewJonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support  https://review.opendev.org/c/openstack/nova/+/82837219:15
chateaulavsean-k-mooney: last individual run, then i should be able to tie a bow on the ci job19:19
opendevreviewJonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support  https://review.opendev.org/c/openstack/nova/+/82837220:18
opendevreviewMerged openstack/nova master: Add logic to enforce local api and db limits  https://review.opendev.org/c/openstack/nova/+/71213921:37
opendevreviewJonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support  https://review.opendev.org/c/openstack/nova/+/82837221:58
chateaulavsean-k-mooney: ci is good to go, I uncommented the other jobs and moved it under the other nova-XX jobs. let me know if you need anything further for it.21:59
chateaulavo/21:59
opendevreviewMerged openstack/nova master: Log which instance event was timed out  https://review.opendev.org/c/openstack/nova/+/81981722:20
opendevreviewMerged openstack/nova master: Add debug log for scheduler weight calculation  https://review.opendev.org/c/openstack/nova/+/81763222:29

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!