| clarkb | sean-k-mooney[m]: it actually can be made to work with tox | 00:22 |
|---|---|---|
| clarkb | but ya a lot of projects don't bother with that | 00:22 |
| clarkb | (we have what we call tox siblings support in the tox jobs which enables this) | 00:22 |
| *** efried1 is now known as efried | 00:55 | |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Register defaults for undefined hw image properties https://review.opendev.org/c/openstack/nova/+/800708 | 01:02 |
| opendevreview | melanie witt proposed openstack/nova master: manage: Add image_property commands https://review.opendev.org/c/openstack/nova/+/824392 | 01:02 |
| opendevreview | Ghanshyam proposed openstack/nova master: Add DB and scheduler filter method for getting nodes,RP https://review.opendev.org/c/openstack/nova/+/830704 | 01:07 |
| *** lajoskatona_ is now known as lajoskatona | 02:25 | |
| melwitt | gibi: I respun https://review.opendev.org/c/openstack/nova/+/824392 and https://review.opendev.org/c/openstack/nova/+/800708 to address stephenfin's comments | 04:32 |
| melwitt | gibi: also the top two unified limits patches have +2 from bauzas if you might be able to take a look | 04:32 |
| opendevreview | Ghanshyam proposed openstack/nova master: API change to allow project admin to boot server on specific host https://review.opendev.org/c/openstack/nova/+/830543 | 04:46 |
| *** amoralej|off is now known as amoralej | 07:09 | |
| gibi | melwitt: o/ sure I will take look at both | 07:55 |
| yuval | Guys good morning | 09:04 |
| gibi | yuval: o/ good morning | 09:04 |
| yuval | this have +1 from zuul passed lightbits ci and +2 from gibi, can another core check it out: https://review.opendev.org/c/openstack/nova/+/821606 | 09:04 |
| yuval | today is the deadline right? | 09:05 |
| gibi | yuval: yes, today is the deadline | 09:05 |
| yuval | ok | 09:05 |
| gibi | but I think you are in a good position | 09:05 |
| yuval | thank you | 09:06 |
| bauzas | yuval: gibi: looking at it | 10:20 |
| bauzas | sean-k-mooney: ha | 11:00 |
| bauzas | you already +Wd the lightbits driver | 11:01 |
| bauzas | I had a comment | 11:01 |
| bauzas | we need a reno file | 11:01 |
| sean-k-mooney[m] | ah you are right | 11:02 |
| sean-k-mooney[m] | i can pull +w or we can add a followup patch | 11:02 |
| bauzas | yuval: https://review.opendev.org/c/openstack/nova/+/821606/16/nova/tests/unit/virt/libvirt/volume/test_lightos.py#28 | 11:02 |
| bauzas | sean-k-mooney: well, given it's already going, and given the deadline is today, that's OK | 11:02 |
| bauzas | sean-k-mooney: but I want yuval to create it | 11:03 |
| bauzas | and also I had a comment https://review.opendev.org/c/openstack/nova/+/821606/16/nova/tests/unit/virt/libvirt/volume/test_lightos.py#28 | 11:03 |
| bauzas | yuval: around ? | 11:03 |
| sean-k-mooney[m] | ok yuval if you add a follow up patch with a release note we can review that quickly | 11:03 |
| sean-k-mooney[m] | ya just saw the question re flags | 11:04 |
| sean-k-mooney[m] | i thihk that was a leftover form a previous patch | 11:04 |
| sean-k-mooney[m] | oh its for the retires | 11:05 |
| sean-k-mooney[m] | that is what they ment to set in the test | 11:05 |
| sean-k-mooney[m] | although they asserted its default value in the test so not entirly needed | 11:07 |
| yuval | hey | 11:17 |
| yuval | I am here | 11:17 |
| yuval | release note ok | 11:17 |
| bauzas | thanks | 11:18 |
| bauzas | yuval: do you know how to do it ? | 11:18 |
| yuval | last time I add it in cinder I copied an existing release note and edited it. | 11:18 |
| yuval | need to keep the correct format etc | 11:19 |
| sean-k-mooney[m] | we have a tool | 11:19 |
| sean-k-mooney[m] | you can do tox -e venv reno new lightos | 11:19 |
| sean-k-mooney[m] | that will create a release note you can edit | 11:20 |
| sean-k-mooney[m] | then you can test that its valied with tox -e releasenotes | 11:20 |
| bauzas | yuval: no, let me give you the doc | 11:20 |
| yuval | ok | 11:21 |
| sean-k-mooney[m] | in this case you can delete all sections except feature where you should provide a short overview of the feature and any version requirements | 11:21 |
| sean-k-mooney[m] | e.g. this need lightos version X | 11:21 |
| bauzas | yuval: https://docs.openstack.org/nova/latest/contributor/releasenotes.html | 11:22 |
| bauzas | yuval: just use the 'features' section for the YAML file | 11:22 |
| bauzas | yuval: also, I had a nit for a test | 11:23 |
| bauzas | yuval: could you just reply on gerrit ? | 11:23 |
| yuval | yes, I saw I didnt understand it actually | 11:23 |
| bauzas | https://review.opendev.org/c/openstack/nova/+/821606/16/nova/tests/unit/virt/libvirt/volume/test_lightos.py#28 | 11:23 |
| sean-k-mooney[m] | ok going to grab coffee. brb | 11:24 |
| gibi | bauzas: I'm +2 on the unified limits series. Is it OK with you if I go back and plug the missing +As to the series? | 11:31 |
| bauzas | gibi: sure | 11:31 |
| gibi | ack, on it | 11:31 |
| bauzas | do this if you want | 11:31 |
| sean-k-mooney | :) i care about that landign but also know i do not have the time before FF to load the context required to review it properly so i have been staying away from the series | 11:53 |
| gibi | melwitt: I have a small question in https://review.opendev.org/c/openstack/nova/+/789963 | 11:56 |
| *** bhagyashris_ is now known as bhagyashris | 11:57 | |
| *** amoralej is now known as amoralej|lunch | 12:19 | |
| opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | 12:23 |
| opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | 12:23 |
| chateaulav | gibi: fixed the pep8 error, i promise this is the last time the driver patch will be updated, focus is on the zuul patch today | 12:24 |
| gibi | chateaulav: no worries :) | 12:26 |
| sean-k-mooney | given gibi has +2'd the first two patches i take it this series is generally in a good postion for review | 12:32 |
| gibi | sean-k-mooney: yes | 12:33 |
| sean-k-mooney | cool i will try an take a look at them shortly so | 12:33 |
| gibi | the last patch adds the gate testing, that still has some failing tempest test but most of the tempest already green | 12:33 |
| gibi | which is a good sign that the emulation actually working | 12:33 |
| sean-k-mooney | ack do we want to hold +w until that last ci patch is green im not going to +w until we are happy with all 3 fo the feature patches as i think this should all merge at once anyway but is the zuul job part of the DOD | 12:35 |
| sean-k-mooney | oh the feature is now only 2 patches | 12:35 |
| sean-k-mooney | oh right the third is the ci patch | 12:35 |
| chateaulav | sean-k-mooney: correct | 12:35 |
| chateaulav | i figured once that one is green ill remove it from check, that way you guys can implement it the weekly and periodic\ | 12:36 |
| sean-k-mooney | honestly im ok with havign one emulated env in check | 12:37 |
| chateaulav | ok | 12:37 |
| sean-k-mooney | but if we want to test others i would put them in the periodic weekly pipeline | 12:37 |
| gibi | sean-k-mooney: I'm OK to land the feature today even without the CI path, I think the current state of the CI result on the CI patch already looks good enough | 12:38 |
| sean-k-mooney | its very unlikely that a change woudl break mips emulation but not arm | 12:38 |
| sean-k-mooney | gibi: ack ok ill focus on the first too so then take a look at the ci patch | 12:38 |
| sean-k-mooney | chateaulav: the m1.tiny flavor size might break some senario tests due to sapce if ti does i think m1.micro is big enough for arm cirros but small then m1.tiny | 12:39 |
| sean-k-mooney | for now lets leave it as you have it and see if it breaks anything | 12:40 |
| chateaulav | ok | 12:40 |
| yuval | File "/home/yuval/workspace/opendev/nova/nova/virt/driver.py", line 129, in <module> | 12:42 |
| yuval | "supports_remote_managed_ports": os_traits.COMPUTE_REMOTE_MANAGED_PORTS, | 12:42 |
| yuval | AttributeError: module 'os_traits' has no attribute 'COMPUTE_REMOTE_MANAGED_PORTS' | 12:42 |
| yuval | I get this while running unittests | 12:42 |
| yuval | what I am doing wrong? | 12:42 |
| opendevreview | Merged openstack/nova master: Lightbits LightOS driver https://review.opendev.org/c/openstack/nova/+/821606 | 12:43 |
| gibi | yuval: you need to rebuild you tox env | 12:43 |
| gibi | yuval: it probably has an old os-traits lib | 12:43 |
| yuval | tox -e ? | 12:43 |
| gibi | yuval: try tox -r -e <env> | 12:43 |
| yuval | or remove it | 12:43 |
| gibi | the -r is the rebuild | 12:43 |
| yuval | ok | 12:43 |
| gibi | or you can remove .tox dir | 12:43 |
| yuval | thanks | 12:43 |
| yuval | yes I will try it if it wont work | 12:43 |
| sean-k-mooney | yuval: ya this is likely just an old os-traits version | 12:44 |
| sean-k-mooney | the other way to fix it is to manually install it | 12:44 |
| sean-k-mooney | .tox/<env>/bin/python3 -m pip install -U os-traits | 12:44 |
| sean-k-mooney | that is also how you can locally test with os-triats changes that are not released | 12:45 |
| gibi | bauzas, gmann: I'v started re-reading the policy series and I have concerns about assisted volume snapshot https://review.opendev.org/c/openstack/nova/+/828994/7/nova/api/openstack/compute/assisted_volume_snapshots.py#42 | 12:45 |
| sean-k-mooney | just replace os-triats with the path to the git repo on disk | 12:45 |
| *** carloss is now known as carloss|afk | 12:56 | |
| opendevreview | Merged openstack/nova master: libvirt: Register defaults for undefined hw image properties https://review.opendev.org/c/openstack/nova/+/800708 | 13:00 |
| opendevreview | Merged openstack/nova master: manage: Add image_property commands https://review.opendev.org/c/openstack/nova/+/824392 | 13:00 |
| yuval | hey added release note | 13:02 |
| yuval | I got a little mixed up with git issues | 13:05 |
| yuval | I edited the changes without pulling latest version | 13:06 |
| yuval | then had to rebase | 13:06 |
| yuval | ahhh | 13:06 |
| yuval | its merged before I added the release note | 13:06 |
| yuval | ok, I am uploading a followup | 13:07 |
| gibi | yuval: release not as a follow up is OK | 13:10 |
| sean-k-mooney | yuval: since you have not pushed yet can you reference the gerrit change id for the lightos feature patch in the commit | 13:11 |
| yuval | its a special syntax or just followup for: <changeid> | 13:11 |
| sean-k-mooney | no special syntax so followup for: ... is fine | 13:12 |
| sean-k-mooney | just makes it simpler to corralate them in the future | 13:12 |
| sean-k-mooney | you will still need the normal change id | 13:12 |
| sean-k-mooney | in the normal way but if you reference the other one in the commit message body we can copy paste and find the relevent review if we ever need too in the future | 13:13 |
| opendevreview | yuval proposed openstack/nova master: Lightos driver release note https://review.opendev.org/c/openstack/nova/+/830817 | 13:14 |
| sean-k-mooney | cool commit message looks fine ill review the rest later | 13:15 |
| opendevreview | yuval proposed openstack/nova master: Lightos driver release note https://review.opendev.org/c/openstack/nova/+/830817 | 13:16 |
| yuval | thank you | 13:16 |
| *** amoralej|lunch is now known as amoralej | 13:19 | |
| sean-k-mooney | gibi: chateaulav im also +2 on the emulation patches. i think the testign coudl be imporved in the futrue but just wanted to point out that https://review.opendev.org/c/openstack/nova/+/822053/63 is in merge conflict | 13:33 |
| sean-k-mooney | so likely we will need to rebase the series before it can proceed | 13:34 |
| chateaulav | ok | 13:34 |
| sean-k-mooney | chateaulav: if you rebase it im ok with fast approving or im sure gibi woudl be happy to reapove too | 13:35 |
| chateaulav | ok, and just to make sure i dont screw this up i should follow: https://docs.opendev.org/opendev/infra-manual/latest/developers.html#rebasing-a-commit ? | 13:41 |
| sean-k-mooney | chateaulav: just do the following | 13:42 |
| sean-k-mooney | git fetch --all | 13:42 |
| sean-k-mooney | git rebase origin/master | 13:42 |
| sean-k-mooney | git review | 13:42 |
| sean-k-mooney | from the top patch in the series | 13:42 |
| chateaulav | ok, | 13:43 |
| sean-k-mooney | although you have a syntax error in the zuul patch where you defien the regex | 13:43 |
| chateaulav | sounds good | 13:43 |
| sean-k-mooney | so you might want to fix that before you do the git review | 13:43 |
| sean-k-mooney | https://zuul.opendev.org/t/openstack/build/fdf39c2132e844799465d04c6200429c/log/job-output.txt#30091 | 13:43 |
| sean-k-mooney | chateaulav: actully i think that issue is coming form the parent job | 13:45 |
| sean-k-mooney | chateaulav: can you add tox_envlist: 'all' https://review.opendev.org/c/openstack/nova/+/828372/28/.zuul.yaml | 13:51 |
| sean-k-mooney | chateaulav: that should fix the job issue | 13:51 |
| chateaulav | ok | 13:51 |
| gibi | chateaulav, sean-k-mooney: I can reapprove sure | 13:52 |
| sean-k-mooney | chateaulav: i think the job is defaulting to the smoke env https://github.com/openstack/tempest/blob/master/tox.ini#L227-L235 | 13:53 |
| sean-k-mooney | all https://github.com/openstack/tempest/blob/master/tox.ini#L58-L68 will allow you to fully contol what tests run via the zuul job | 13:53 |
| opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | 14:14 |
| opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | 14:14 |
| opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | 14:14 |
| chateaulav | most stressfull rebase ever... everything is updated, waiting on checks to run | 14:17 |
| sean-k-mooney | :) im sure it will be fine | 14:18 |
| sean-k-mooney | ah it was the image property regesistration patch it conflicted with | 14:20 |
| chateaulav | yeah | 14:20 |
| sean-k-mooney | ok well im +2 on the rebase it looks correct to me | 14:21 |
| chateaulav | thanks sean-k-mooney and gibi | 14:21 |
| *** carloss|afk is now known as carloss | 14:22 | |
| sean-k-mooney | ill check back on the ci results later for the zuul patch | 14:22 |
| opendevreview | sean mooney proposed openstack/nova master: update default overcommit https://review.opendev.org/c/openstack/nova/+/830829 | 14:46 |
| dmitriis | sean-k-mooney: RE https://review.opendev.org/c/openstack/nova/+/829974 I have a fix for the migration & unshelve scenarios here (binding:profile updates) along with func tests. I could work on making vf_num and pf_mac_address to be stored in extra_info but need to clarify the ordering. It's close to freeze time so I just wanted to know whether to | 14:53 |
| dmitriis | do the move to extra_info first or after this change is in. | 14:53 |
| gmann | gibi: thanks for catching that, I missed that it is called from cinder. | 14:53 |
| gmann | gibi: I will update | 14:53 |
| sean-k-mooney | dmitriis: im not sure of the status of gibis change to store the mac in extra info | 14:58 |
| gibi | sean-k-mooney: it is in the works | 14:59 |
| sean-k-mooney | i woudl proably defer moving it to extra_info until after this change | 14:59 |
| gibi | sean-k-mooney: I can publish the code today the funct testing will take more time | 14:59 |
| dmitriis | sean-k-mooney, gibi: ack | 15:00 |
| gibi | I'm OK moving forward with dmitriis fix that is up and refactor it later | 15:00 |
| sean-k-mooney | ack that is what i was going to ask | 15:00 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/829974 is addin more call to the pci utils but that can be refactored later | 15:01 |
| sean-k-mooney | and i think having move operation work is proably more imporant then purity in this case | 15:01 |
| sean-k-mooney | given we should be able to backport the refactor after FF i think | 15:01 |
| sean-k-mooney | dmitriis: ill try and review that fully later today | 15:02 |
| dmitriis | sean-k-mooney: ack, ty | 15:03 |
| gibi | ack I will review too | 15:15 |
| sean-k-mooney | dmitriis: +1 on https://review.opendev.org/c/openstack/nova/+/829974 comments inline | 15:55 |
| gibi | dmitriis: I also left comments inline https://review.opendev.org/c/openstack/nova/+/829974 just now | 15:56 |
| melwitt | gibi: answered. I also see the series is in merge conflict so I have to rebase it 😩 | 15:58 |
| sean-k-mooney | chateaulav: looking at the realtime status of https://review.opendev.org/c/openstack/nova/+/822053/64 in zuul the tox jobs are going to fail | 15:59 |
| chateaulav | tracking, taking a look now | 16:00 |
| dmitriis | sean-k-mooney, gibi: looking | 16:00 |
| sean-k-mooney | melwitt: do we need to start stacking series and or wait for unified limists to merge before mergeing others | 16:00 |
| gibi | melwitt: thanks for the answer I missed the fact that it ius differnt coverage. Then I think it make sense to keep both coverage in place | 16:00 |
| bauzas | melwitt: don't be afraid, we can merge your series tomorrow if needed | 16:01 |
| bauzas | melwitt: I mean, if gibi says +2 of course | 16:01 |
| gibi | melwitt: ping me after the rebase and I can put back the +A on the series | 16:02 |
| bauzas | me too | 16:02 |
| gibi | bauzas: I'm +2 on the series | 16:02 |
| melwitt | sean-k-mooney: dunno actually, I hadn't checked conflict with other things that need to go now | 16:02 |
| bauzas | gibi: cool then | 16:02 |
| * bauzas tries to look at https://review.opendev.org/c/openstack/nova/+/764292 | 16:02 | |
| bauzas | gmann: wdyt if we merge a few changes from this tenant-id series ? | 16:03 |
| melwitt | bauzas, gibi: that sounds great, thank you! | 16:03 |
| gibi | bauzas: is the tenant-id series an all-or-nothing situation as the microversion is in the first patch? | 16:04 |
| gmann | bauzas: humm that will be like need two microversion for single type of change. | 16:04 |
| gmann | gibi: indeed | 16:04 |
| gmann | we cannot split the single microversion changes in two series | 16:05 |
| gmann | two cycle | 16:05 |
| gmann | and it change the many APIs | 16:05 |
| chateaulav | any insight for resolution on a couple of the issues | 16:15 |
| chateaulav | https://www.irccloud.com/pastebin/sdXpnsVs/ | 16:15 |
| gibi | chateaulav: where do you see that error? on the gate? | 16:15 |
| chateaulav | i know yuval was doing the lightos stuff, just not sure how that gets triggered on my rebase | 16:16 |
| chateaulav | the driver patch check after rebase | 16:16 |
| yuval | whats the issue? | 16:16 |
| gibi | but locally | 16:16 |
| gibi | I assume | 16:16 |
| gibi | so I think you have to rebuild your tox env | 16:16 |
| gibi | tox -r -e <env> | 16:16 |
| gibi | you have an old os-brick in your env | 16:16 |
| chateaulav | yeah, running that now to make sure, takes a min | 16:16 |
| chateaulav | ok yeah, i see. ill focus on the 3 i see in zuul and then we should be good. | 16:17 |
| sean-k-mooney | im just on a dowstream call ill try and take a look after | 16:17 |
| chateaulav | for a sec I was like WTF im supposed to do with that | 16:18 |
| gibi | yeah, you tox is not always smart enought to detect that deps are changed | 16:18 |
| gibi | s/you// | 16:18 |
| chateaulav | fact | 16:18 |
| gibi | and now we are in a busy period integrating stuff on master | 16:18 |
| bauzas | gmann: gibi: sorry was in meeting (and still are :) ) | 16:18 |
| gibi | bauzas: ack | 16:19 |
| gibi | no worries | 16:19 |
| bauzas | gmann: gibi: I was asking for it as I knew it would mean two microversions for the same project_id change | 16:19 |
| yuval | gibi thanks for the fast response, chateaulav sorry about that | 16:19 |
| chateaulav | your good. just a sec of panic on my side | 16:19 |
| bauzas | gmann: gibi: but I was wondering about merging a few things for Yoga as we don't have any new microversions and just telling within the microversion what APIs were touched | 16:19 |
| bauzas | gmann: gibi: but if you guys prefer to merge it at once, fine by me | 16:20 |
| gibi | bauzas: we can technically split to two microversions it is a bit of a meh UX but yeah | 16:20 |
| bauzas | this is just unrealistic to merge the whole branch before today EOB | 16:20 |
| gibi | ack | 16:20 |
| bauzas | my only concern is that brinzhang isn't around as we speak | 16:21 |
| gibi | it is pretty late for him | 16:21 |
| bauzas | so we can't really ask him to change the microversion change for saying which APIs are modified | 16:21 |
| bauzas | this would mean some kind of exception | 16:21 |
| bauzas | so maybe not a priority | 16:21 |
| bauzas | as you can see, I'm not opinionated | 16:21 |
| gmann | yeah, I also prefer to merge it together | 16:21 |
| bauzas | OK, if there is no huge interesting in merging by pieces, let's then punt | 16:22 |
| gmann | as it is cleanup, I think we can move it to next cycle and make it priority in Zed since starting.? | 16:22 |
| gibi | my only fear that we never merge it ever and brinzhang gets mad and drops it | 16:22 |
| gmann | gibi: yeah, it has been going in many cycle. | 16:23 |
| gibi | yeah we somehow need tof force ourselve to look at that series early in the cycle | 16:23 |
| gibi | but we failed on it this time | 16:23 |
| gibi | or at least I failed | 16:23 |
| gmann | I too failed, but I will commit on this for Zed for sure. | 16:24 |
| gmann | there are few last patches not ready at least server tenant usage url one | 16:24 |
| gmann | which brin asked me to look and I did not get chance | 16:24 |
| melwitt | apologies for the upcoming spam | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Move keypair quota error message into exception https://review.opendev.org/c/openstack/nova/+/828186 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Add stub unified limits driver https://review.opendev.org/c/openstack/nova/+/712137 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Assert quota related API behavior when noop https://review.opendev.org/c/openstack/nova/+/712140 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Make unified limits APIs return reserved of 0 https://review.opendev.org/c/openstack/nova/+/712141 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Add logic to enforce local api and db limits https://review.opendev.org/c/openstack/nova/+/712139 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Enforce api and db limits https://review.opendev.org/c/openstack/nova/+/712142 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/c/openstack/nova/+/712143 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Update limit APIs https://review.opendev.org/c/openstack/nova/+/712707 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/c/openstack/nova/+/712749 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Tell oslo.limit how to count nova resources https://review.opendev.org/c/openstack/nova/+/713301 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Enforce resource limits using oslo.limit https://review.opendev.org/c/openstack/nova/+/615180 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Add legacy limits and usage to placement unified limits https://review.opendev.org/c/openstack/nova/+/713498 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Update quota apis with keystone limits and usage https://review.opendev.org/c/openstack/nova/+/713499 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Add reno for unified limits https://review.opendev.org/c/openstack/nova/+/715271 | 16:26 |
| opendevreview | melanie witt proposed openstack/nova master: Enable unified limits in the nova-next job https://review.opendev.org/c/openstack/nova/+/789963 | 16:26 |
| melwitt | gibi, bauzas: merge conflict was super easy, was due to requirements bump so only requirements.txt and test-requirements.txt | 16:28 |
| bauzas | ++ | 16:28 |
| gibi | OK, On it | 16:29 |
| opendevreview | Ghanshyam proposed openstack/nova master: Modify remaining APIs as per RBAC new guidelines https://review.opendev.org/c/openstack/nova/+/828994 | 16:32 |
| dansmith | bauzas: did you see my reply comment here about splitting? https://review.opendev.org/c/openstack/nova/+/820368 | 16:32 |
| gmann | gibi: bauzas fixed the assisted volume snapshot one https://review.opendev.org/c/openstack/nova/+/828994 | 16:33 |
| dansmith | bauzas: I think that's what you intended and I was picking the wrong seam, but just want clarification before I go trying to help split that as described in my most recent one | 16:33 |
| opendevreview | Ghanshyam proposed openstack/nova master: Separate flavor extra specs policy for server APIs https://review.opendev.org/c/openstack/nova/+/829626 | 16:33 |
| opendevreview | Ghanshyam proposed openstack/nova master: Complete phase-1 of RBAC community-wide goal https://review.opendev.org/c/openstack/nova/+/829866 | 16:33 |
| gibi | melwitt: rebase looks good, I did the paperwork to send the series to the gate | 16:35 |
| melwitt | thank you gibi! | 16:36 |
| gibi | gmann: you are next :) | 16:36 |
| gmann | gibi: thanks :) | 16:36 |
| gibi | I have to stop in about an hour | 16:36 |
| gibi | gmann: thanks for the fix | 16:54 |
| gibi | bauzas: this morning I re-read the policy series and I find no problems (except the assisted snapshot that is fixed now) so I upgraded my vote now to +2 on the policy series | 16:55 |
| gibi | bauzas: we still need you to check back to https://review.opendev.org/c/openstack/nova/+/828994/8 as that was updated recently | 16:55 |
| bauzas | gibi: ok | 16:55 |
| gibi | but otherwise the policy series is also going to the gate | 16:55 |
| bauzas | done | 16:56 |
| gibi | now zuul has things to do :D | 16:56 |
| bauzas | dansmith: sorry in an internal meeting but looking | 16:58 |
| bauzas | dansmith: so, | 17:01 |
| bauzas | we have two different things | 17:01 |
| bauzas | one is the REST API modification adding a new microversion | 17:01 |
| bauzas | the other is the new instance external event type we add in the related ovo | 17:02 |
| dansmith | well, the microversion for the event is specifically for the event api, not the ovo directly, but yeah | 17:02 |
| bauzas | agreed, it's in the event itself | 17:03 |
| bauzas | I'm speaking of https://review.opendev.org/c/openstack/nova/+/820368/9/nova/objects/external_event.py | 17:03 |
| bauzas | vs. https://review.opendev.org/c/openstack/nova/+/820368/9/nova/api/openstack/compute/rest_api_version_history.rst | 17:04 |
| dansmith | yah | 17:04 |
| bauzas | we were about discussing 5 mins ago about merging one microversion for tenant_id | 17:05 |
| bauzas | which could be 2.91 | 17:05 |
| bauzas | fortunately, this won't happen | 17:05 |
| bauzas | so, technically, the 2.91 slot is free to anyone | 17:05 |
| gmann | bauzas: gibi thanks for review. | 17:05 |
| bauzas | dansmith: just take note of https://review.opendev.org/c/openstack/nova/+/764292/34/nova/api/openstack/compute/rest_api_version_history.rst | 17:06 |
| bauzas | but we agreed 5 mins ago with gmann to not merge it | 17:06 |
| bauzas | that said, I'll have to leave in 10 mins | 17:07 |
| dansmith | bauzas: yeah, I really wish we shouldn't do those sorts of things | 17:07 |
| dansmith | but regardles | 17:07 |
| dansmith | all I'm trying to figure out is whether you actually wanted *two* microversions, one for the event and one for the rebuild change | 17:07 |
| bauzas | two REST microversions ? | 17:08 |
| dansmith | or if you meant to split the plumbing underneath (i.e. the actual event, the rebuild code) from the api changes | 17:08 |
| bauzas | no, I didn't ask for it | 17:08 |
| bauzas | I asked for splitting the plumbing as you speak | 17:08 |
| dansmith | I forgot that we started microversions for the events (which I'm not sure why we started doing that), but.. | 17:08 |
| dansmith | right okay | 17:08 |
| bauzas | let's call it event versioning, if you prefer :) | 17:08 |
| dansmith | cool cool, my mistake for forgetting that initially so I was on a slightly wrong track | 17:09 |
| bauzas | but gibi knows more than me on it | 17:09 |
| bauzas | dansmith: again, that said, I won't be able to review it honestly today | 17:09 |
| dansmith | bauzas: that's fine | 17:09 |
| bauzas | as I have an hard stop in 5 mins | 17:09 |
| dansmith | whoami-rajat: are you cool with me trying to split your patch accordingly or do you want to do it? | 17:09 |
| gibi | bauzas: I think you are conflating versioning notifications emitted by nova and microversion bump for the external_events REST API. | 17:11 |
| whoami-rajat | dansmith, either way is fine with me, maybe better if you do it because I still don't have full idea of the ask here or if guided i can | 17:11 |
| dansmith | whoami-rajat: ack, partially my fault anyway :D | 17:12 |
| whoami-rajat | dansmith, i think it's because the codebase is fairly new to me :) | 17:13 |
| dansmith | whoami-rajat: you should seize the opportunity to blame me ;P | 17:13 |
| bauzas | gibi: I'm not conflating, but I wrote a comment which was unclear :) | 17:13 |
| gibi | OK. I don't have the full context sorry :) | 17:13 |
| bauzas | https://review.opendev.org/c/openstack/nova/+/820368/9#message-f4b92b3310dee2af9598f108dc761f7fabafd34a | 17:14 |
| whoami-rajat | :D | 17:14 |
| bauzas | "event one" was unclear | 17:14 |
| bauzas | I was referring to the patch | 17:14 |
| gibi | OK. | 17:14 |
| gibi | I see now | 17:14 |
| bauzas | not to any other microversion | 17:14 |
| * bauzas has to disappear for the night | 17:17 | |
| bauzas | other cores, I trust you | 17:17 |
| bauzas | if you wanna continue to review, fine by me | 17:17 |
| * bauzas will look at all the blueprints by tomorrow and decide to use the -2 hammer only if none of the cores said +2 | 17:18 | |
| ralonsoh | gibi, https://review.opendev.org/c/openstack/neutron/+/829247 just a heads-up, if you didn't see my reply | 17:19 |
| gibi | ralonsoh: thank, I haven't seen it yet. I will check tomorrow or next week, as we are in feature freeze crazy :) | 17:22 |
| ralonsoh | sure, no rush | 17:22 |
| ralonsoh | ping me whenever you can | 17:22 |
| opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | 17:28 |
| opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | 17:28 |
| opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | 17:28 |
| gibi | ralonsoh: thanks | 17:29 |
| chateaulav | sean-k-mooney: that should do, sorry it took a litle bit the rebase got wonked so started fresh. | 17:29 |
| chateaulav | gibi: thanks as well | 17:29 |
| gibi | chateaulav: rebaswe looks clear | 17:30 |
| gibi | so I'm +2 | 17:30 |
| gibi | but now I have to stop for today | 17:30 |
| gibi | see you all tomorrow o/ | 17:30 |
| chateaulav | thanks | 17:31 |
| opendevreview | Merged openstack/nova master: Allow per-context rule in error messages https://review.opendev.org/c/openstack/nova/+/816865 | 17:41 |
| *** amoralej is now known as amoralej|off | 17:42 | |
| dansmith | whoami-rajat: so, functional tests fail without the api change in place, which I think means that we're not properly honoring the old microversion behavior | 17:45 |
| dansmith | which is a good reason for this split | 17:45 |
| whoami-rajat | dansmith, ack | 17:53 |
| opendevreview | Dan Smith proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | 17:59 |
| opendevreview | Dan Smith proposed openstack/nova master: Add volume-rebuild support to cinder module https://review.opendev.org/c/openstack/nova/+/830882 | 17:59 |
| opendevreview | Dan Smith proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 17:59 |
| dansmith | whoami-rajat: ^ | 17:59 |
| dansmith | whoami-rajat: assuming that first mini patch is good, we should be able to get that merged ASAP and cut down what remains | 18:00 |
| dansmith | hmm, did I lose the reno? | 18:00 |
| opendevreview | Dan Smith proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 18:01 |
| dansmith | there we go | 18:01 |
| whoami-rajat | ack, thanks for splitting it up | 18:01 |
| dansmith | whoami-rajat: so I think we need to get the rebuild flag down to the compute manager so it knows whether or not to trigger the new behavior | 18:02 |
| whoami-rajat | dansmith, i agree with the usage of an old version of API but if they don't pass the flag, it will never reach the compute manager and should fail at API level | 18:05 |
| whoami-rajat | but we need to still consider the old API new compute case | 18:05 |
| dansmith | whoami-rajat: see the test failure in that middle patch :) | 18:05 |
| whoami-rajat | will look into that | 18:05 |
| dansmith | whoami-rajat: if the image ref does not change, we should rebuild the instance but not the volume, | 18:05 |
| dansmith | but your code makes it still call rebuild, which will erase the root volume | 18:05 |
| whoami-rajat | Ah ok, we support rebuilding volume backed instances having same image as the provided one | 18:06 |
| whoami-rajat | so reimage_boot_volume should be checked in the manager, got it | 18:07 |
| dansmith | right, the image can't change, but we do that because we don't destroy the root disk, so we require the image to be the same | 18:07 |
| dansmith | yep | 18:07 |
| whoami-rajat | ack, will work on that | 18:07 |
| dansmith | also, | 18:07 |
| dansmith | your api will only check that field if the image-ref changes, so even with the new version of the API, you can trigger the accidental root volume erase | 18:08 |
| dansmith | so something needs to change there to make sure we never ever erase the root disk unless they specifically ask for it | 18:08 |
| dansmith | lemme comment on that to record that | 18:08 |
| whoami-rajat | if we don't trigger the rebuild_volume_backed_instance code in compute, something like, if reimage_boot_volume and is_volume_backed: , then we're safe from the same image case right? | 18:10 |
| whoami-rajat | but if you want the operation to get blocked at the API layer only then we can change that | 18:11 |
| dansmith | we have to support the old and new behavior in manager | 18:11 |
| dansmith | we need to make sure the api properly communicates what should happen to the manager | 18:11 |
| dansmith | the api may enforce certain behaviors of the api client, but we have to make sure manager knows what the right thing to do is | 18:11 |
| whoami-rajat | ok | 18:12 |
| dansmith | whoami-rajat: be sure to put your co-authored-by on those new patches when you revise.. I meant to do that, sorry | 18:14 |
| dansmith | I don't want to look like I took credit for your work | 18:15 |
| whoami-rajat | dansmith, np, will do it and doesn't matter much :) | 18:15 |
| whoami-rajat | :D | 18:15 |
| whoami-rajat | doesn't look like that at all | 18:15 |
| dansmith | it matters A LOT :) | 18:15 |
| whoami-rajat | :) | 18:16 |
| opendevreview | Merged openstack/nova master: Revert project-specific APIs for servers https://review.opendev.org/c/openstack/nova/+/816206 | 18:17 |
| opendevreview | Merged openstack/nova master: Test PROJECT_ADMIN APIs with no legacy rule case https://review.opendev.org/c/openstack/nova/+/824845 | 18:17 |
| opendevreview | Merged openstack/nova master: Move rule_if_system() method to base test class https://review.opendev.org/c/openstack/nova/+/824475 | 18:18 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add volume-rebuild support to cinder module https://review.opendev.org/c/openstack/nova/+/830882 | 18:19 |
| whoami-rajat | dansmith, so does the first patch looks good or anything to change there? (just added the co-authored-by to commit msg ^) | 18:21 |
| dansmith | whoami-rajat: I didn't actually look, but it's probably straightforward | 18:22 |
| whoami-rajat | yeah just sending the request to cinderclient | 18:22 |
| dansmith | yep, +2d | 18:23 |
| whoami-rajat | great thanks | 18:23 |
| opendevreview | Merged openstack/nova master: Convert SYSTEM_ADMIN|READER to Admin and system scope https://review.opendev.org/c/openstack/nova/+/819390 | 18:26 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | 18:51 |
| whoami-rajat | dansmith, i think test_api makes more sense in the 3rd patch where we introduce the API changes (since those are required to pass the reimage_boot_volume flag down to manager)? | 19:13 |
| opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | 19:14 |
| chateaulav | sean-k-mooney: Driver patch is good (+1 verified), and then ci should be good this go around watched zuul live and added the last test considerations | 19:16 |
| chateaulav | ill keep watching the ci patchset though | 19:17 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/830894 | 19:44 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 19:50 |
| opendevreview | melanie witt proposed openstack/nova master: Follow up for nova-manage image property commands https://review.opendev.org/c/openstack/nova/+/830895 | 19:55 |
| sean-k-mooney | chateaulav: one test failed but thats pretty good https://zuul.opendev.org/t/openstack/build/3cba136d39924d73b775a2b3a8d626ba | 20:03 |
| chateaulav | ok, ill get that | 20:07 |
| sean-k-mooney | nova.exception.InterfaceAttachFailed: Failed to attach network adapter device to 61a0c10a-930f-4b46-8651-c8583d1d9ff7 | 20:08 |
| sean-k-mooney | caused by r libvirt.libvirtError: internal error: No more available PCI slots | 20:09 |
| sean-k-mooney | chateaulav: so that is a simple fix | 20:09 |
| sean-k-mooney | i suspec that just as we have to preacllocatre pcie root ports for x86 with q35 machine type | 20:10 |
| sean-k-mooney | we likely need to do that too for aarch64 and virt machien type | 20:10 |
| sean-k-mooney | chateaulav: for q35 we use https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.num_pcie_ports to contol this | 20:11 |
| sean-k-mooney | so you proably need to set that to 28 | 20:11 |
| sean-k-mooney | or similar | 20:11 |
| sean-k-mooney | in the ci job and that should be all that is requried | 20:11 |
| chateaulav | alright | 20:11 |
| sean-k-mooney | its possibel we have to alter the driver slightly but it shoudl be trivial that is what i woudl try first to adress it | 20:12 |
| sean-k-mooney | chateaulav: i approved the previous patch and rechecke the first patch | 20:12 |
| sean-k-mooney | so they shoudl proceed | 20:12 |
| chateaulav | great! | 20:12 |
| chateaulav | sean-k-mooney: appreciate the help | 20:12 |
| sean-k-mooney | no worries | 20:13 |
| sean-k-mooney | im proably going to call it a day now | 20:13 |
| sean-k-mooney | the failure is here by the way if you were wonderign https://zuul.opendev.org/t/openstack/build/3cba136d39924d73b775a2b3a8d626ba/log/controller/logs/screen-n-cpu.txt#9219 | 20:13 |
| sean-k-mooney | looking at the xml https://zuul.opendev.org/t/openstack/build/3cba136d39924d73b775a2b3a8d626ba/log/controller/logs/screen-n-cpu.txt#9035 | 20:14 |
| sean-k-mooney | i dont see any addtional pcie root ports in the xml we sent to libvirt | 20:14 |
| sean-k-mooney | normally libvirt will allcoate 1 addtional pcie endpoint but that might only be for q35 | 20:15 |
| sean-k-mooney | anyway o/ | 20:15 |
| chateaulav | \o | 20:16 |
| opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | 20:18 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add volume-rebuild support to cinder module https://review.opendev.org/c/openstack/nova/+/830882 | 20:46 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/830894 | 20:46 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 20:46 |
| melwitt | gmann: do you know if there is any known issue with gate failure "[ERROR] /opt/stack/devstack/lib/neutron_plugins/ovn_agent:178 Socket /var/run/openvswitch/ovnnb_db.sock not found"? I've hit it twice today | 21:09 |
| gmann | melwitt: not i am aware of. seems new to me | 21:09 |
| melwitt | ack | 21:10 |
| gmann | latest i saw my rbac patches passed gate ~2hr ago | 21:11 |
| melwitt | thanks | 21:14 |
| opendevreview | Merged openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | 23:35 |
| opendevreview | Merged openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | 23:35 |
| sean-k-mooney | melwitt: locally or in the gate | 23:50 |
| melwitt | sean-k-mooney: gate. but looks like I was just unlucky | 23:50 |
| sean-k-mooney | locally devstack is not always proeperly cleaning up when you unstack | 23:51 |
| sean-k-mooney | ack | 23:51 |
| sean-k-mooney | im not sure what would cause that on a clean install | 23:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!