| opendevreview | melanie witt proposed openstack/nova-specs master: Re-propose Unified Limits in Nova https://review.opendev.org/c/openstack/nova-specs/+/809020 | 00:16 |
|---|---|---|
| *** bhagyashris is now known as bhagyashris|off | 05:35 | |
| bauzas | morning folks | 07:35 |
| bauzas | gibi: elodilles: good catch on the approval thing | 07:35 |
| bauzas | I was about to propose the release liaison role to anyone who'd like | 07:35 |
| bauzas | having a single person responsible for approving releases is a SPOF | 07:35 |
| gibi | bauzas: I agree to push out such proposal. It would be nice to see somebody picks that up. If not then I can be hooked for it | 08:51 |
| bauzas | I'll ask this at the next meeting | 08:51 |
| bauzas | for the moment, I'm still under the water | 08:51 |
| bauzas | :( | 08:51 |
| gibi | bauzas: no worries | 08:51 |
| bauzas | some customer is getting 4 FTEs | 08:52 |
| bauzas | ... | 08:52 |
| bauzas | anyway | 08:52 |
| * bauzas is the odds of testing eventlet.backdoor | 08:52 | |
| bauzas | has anyone played with this ? | 08:52 |
| gibi | I'm not | 08:53 |
| bauzas | ok, I found how | 09:03 |
| bauzas | that's working like a charm | 09:03 |
| bauzas | it just binds a new greenlet where you can access the whole process | 09:03 |
| gibi | bauzas: care to document that process somewhere after you surface from the escalations? | 09:04 |
| gibi | I think it would be useful | 09:04 |
| bauzas | gibi: yeah that's worth of interest, I'm also testing tracemalloc module | 09:04 |
| gibi | +1 for the tracemalloc too. | 09:04 |
| bauzas | context (I can tell if I don't tell the whole context) : the nova-compute service is consuming unusual memory space hence a potential memory leak to identify | 09:05 |
| bauzas | so the strategy is to compare memory allocations snapshots over time | 09:06 |
| gibi | does tracemalloc can differentiate between allocated but not used memory and actually used memory? | 09:08 |
| kashyap | Very good question | 09:08 |
| kashyap | tracemalloc.get_tracemalloc_memory() | 09:09 |
| bauzas | gibi: we're litterally doing baby steps here | 09:10 |
| kashyap | gibi: The above _should_ get the memory usag | 09:10 |
| bauzas | gibi: the idea is that you can generate snapshots | 09:10 |
| bauzas | and each snapshot (like a GMR) gives you bits of memory usage | 09:10 |
| * gibi once tried to tracked down an assumed memory leak in the python interpreter and has ptsd from it | 09:10 | |
| bauzas | tracemalloc even provides a compare method between snapshots | 09:10 |
| bauzas | kashyap: tracemalloc.get_traced_memory() only gives you the memory usage of the tracking module itself | 09:13 |
| opendevreview | Lee Yarwood proposed openstack/nova master: docs: Add nova-volume volume_attachment refresh admin workflow https://review.opendev.org/c/openstack/nova/+/809161 | 09:27 |
| opendevreview | Lee Yarwood proposed openstack/nova master: run-evacuate-hook: Switch to osc evacuate command and add --debug https://review.opendev.org/c/openstack/nova/+/809162 | 09:31 |
| opendevreview | Merged openstack/osc-placement stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/osc-placement/+/808456 | 09:42 |
| opendevreview | Merged openstack/python-novaclient stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/python-novaclient/+/808459 | 09:45 |
| opendevreview | Merged openstack/python-novaclient stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/python-novaclient/+/808460 | 09:45 |
| opendevreview | Merged openstack/osc-placement stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/osc-placement/+/808457 | 09:54 |
| viks__ | hi, what is the use of the code: `consumer_type = 'migration'` in https://github.com/openstack/nova/blob/01eaa627b406af9336a231caea6969aae9a62033/nova/cmd/manage.py#L2550 as the next condition after this line always overrides this? am i missing something? | 11:44 |
| sean-k-mooney | it will not override it if there is not instance that matches | 11:45 |
| sean-k-mooney | so we asume any allocation we find that doen have a consumer type are migration and then set them to instnace if we see a corresponding instnace | 11:46 |
| viks__ | sean-k-mooney: but if we check the earlier condition, we see it always seems to be setting `consumer_type = 'instance'` | 11:47 |
| viks__ | https://www.irccloud.com/pastebin/XOzn2XSW/ | 11:47 |
| sean-k-mooney | most allocation will be of type instance | 11:48 |
| sean-k-mooney | the not is likely wrong | 11:49 |
| sean-k-mooney | infact the not i think is wrong | 11:49 |
| viks__ | sean-k-mooney: ok... that's what i was thinking | 11:49 |
| sean-k-mooney | well unless the not is for deleted instnaces | 11:50 |
| viks__ | ok | 11:50 |
| sean-k-mooney | so the first if is if not (consumer_uuid in inst_uuids or | 11:51 |
| sean-k-mooney | consumer_uuid in mig_uuids): | 11:51 |
| sean-k-mooney | so if we enter it we know the consumer uuid is not in inst_uuids and it is not in mig_uuids | 11:52 |
| sean-k-mooney | so the second if will always be true | 11:53 |
| viks__ | sean-k-mooney: correct.. what should be the correct condition here... i'm not having full context of the overall code | 11:53 |
| sean-k-mooney | i think we need a third state of orpanded or deleted | 11:55 |
| viks__ | ok | 11:55 |
| sean-k-mooney | actully | 11:55 |
| sean-k-mooney | we might just be able to do https://paste.opendev.org/show/809339/ | 11:57 |
| sean-k-mooney | so if the consumer uuid is not an instance or migration | 11:57 |
| sean-k-mooney | then we know it was deleted | 11:57 |
| sean-k-mooney | so i think we can just delete https://github.com/openstack/nova/blob/01eaa627b406af9336a231caea6969aae9a62033/nova/cmd/manage.py#L2548-L2555 | 11:58 |
| sean-k-mooney | viks__: does that make sense | 11:58 |
| sean-k-mooney | we might need to modify https://github.com/openstack/nova/blob/01eaa627b406af9336a231caea6969aae9a62033/nova/cmd/manage.py#L2445 | 12:00 |
| sean-k-mooney | to correctly handel reciving None for the consumer type | 12:01 |
| sean-k-mooney | or https://github.com/openstack/nova/blob/01eaa627b406af9336a231caea6969aae9a62033/nova/scheduler/client/report.py#L2053 | 12:01 |
| sean-k-mooney | but i think that woudl be the correct way to fix this | 12:01 |
| viks__ | ok... | 12:05 |
| viks__ | sean-k-mooney: just changing it to below doesnt resolve: | 12:11 |
| viks__ | https://www.irccloud.com/pastebin/e2Zcf6le/ | 12:11 |
| sean-k-mooney | correct that would not work | 12:13 |
| viks__ | as per the comments in the code, it should work right? i.e. first we set it to migration,then if `consumer_uuid`is not found in `inst_uuids`, it should set it to `instance`... i do not have the detailed contex.. so just asking | 12:19 |
| *** artom_ is now known as artom | 13:35 | |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: [PoC][yoga] Off-path Networking Backends Support https://review.opendev.org/c/openstack/nova/+/808199 | 14:40 |
| MrClayPole | When attempting to live-migrate a VM between 2 compute nodes it fails with "Exception during message handling: TargetPortalNotFound: Unable to find target portal 1.1.1.1:3260". The storage is iSCSI iSER with multipath enabled in nova.conf. I can see cinder mapping the volume to the target but os_brick is scanning with "iscsiadm -m session" before iscsid has brought up the iSCSI session on the target compute node. Is there | 15:34 |
| MrClayPole | a way to make os_brick wait until the iSCSI session is up? | 15:34 |
| lyarwood | MrClayPole: it should retry for a while and iirc that's now configurable, which version of OpenStack is this? | 15:49 |
| MrClayPole | lyarwood: Openstack Rocky. os_bricks only tries once according to the logs | 15:51 |
| lyarwood | MrClayPole: kk I'm really not sure then, you might want o ask the folks in #openstack-cinder who maintain os-brick for more clues | 15:56 |
| lyarwood | to* | 15:56 |
| MrClayPole | lyarwood: Thanks I'll do that. I wasn't sure who looked after os_bricks. | 16:01 |
| lyarwood | np, sorry I couldn't help more | 16:02 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Test SRIOV port move operations with PCI conflicts https://review.opendev.org/c/openstack/nova/+/796908 | 19:54 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Update SRIOV port pci_slot when unshelving https://review.opendev.org/c/openstack/nova/+/796909 | 19:54 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Fix ImageBackendFixture not to support direct_snapshot https://review.opendev.org/c/openstack/nova/+/809282 | 19:54 |
| artom | That was a PITA to hunt down and figure out it was the ImageBackendFixture backport that was needed... | 19:54 |
| *** osmanlicilegi is now known as Guest0 | 21:20 | |
| *** prometheanfire is now known as Guest1 | 21:20 | |
| *** promethe- is now known as prometheanfire | 21:53 | |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Update SRIOV port pci_slot when unshelving https://review.opendev.org/c/openstack/nova/+/796909 | 23:52 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!