Tuesday, 2021-09-14

opendevreviewMaAoyu proposed openstack/nova master: swap multiattach volume, report an error VolumeNotFound  https://review.opendev.org/c/openstack/nova/+/80702501:07
*** oklhost_ is now known as oklhost06:11
opendevreviewVictor Coutellier proposed openstack/nova master: VMware: Support volumes backed by VStorageObject  https://review.opendev.org/c/openstack/nova/+/80879106:25
gibio/08:05
opendevreviewalecorps proposed openstack/nova master: VMware: Support volumes backed by VStorageObject  https://review.opendev.org/c/openstack/nova/+/80879108:12
lyarwood\o08:22
lyarwoodbauzas:  https://review.opendev.org/c/openstack/nova/+/807714 - would you mind hitting this today please08:22
bauzaslyarwood: sure, will look08:22
lyarwoodthanks08:22
bauzasthis time, I clicked on the right button :D08:23
bauzashttps://i.gifer.com/IqTa.gif08:25
bauzasor rather https://www.youtube.com/watch?v=Kz0PSSreCuE (wasn't able to find this one before ;)  )08:26
lyarwood^_^08:30
gibi:)08:41
opendevreviewMerged openstack/nova master: Add more retries to TestMigrateFromDownHost tests  https://review.opendev.org/c/openstack/nova/+/80771409:09
opendevreviewLee Yarwood proposed openstack/nova master: WIP configdrive: Move mkisofs_cmd default to mkisofs  https://review.opendev.org/c/openstack/nova/+/80892110:05
opendevreviewLee Yarwood proposed openstack/nova master: configdrive: Add TODO to replace vfat creation code with virt-make-fs  https://review.opendev.org/c/openstack/nova/+/80892210:20
opendevreviewalecorps proposed openstack/nova master: VMware: Support volumes backed by VStorageObject  https://review.opendev.org/c/openstack/nova/+/80879110:22
opendevreviewLee Yarwood proposed openstack/nova stable/train: guestfs: With libguestfs >= v1.41.1 decode returned bytes to string  https://review.opendev.org/c/openstack/nova/+/78790310:58
bauzasfolks, I'm a bit offloaded by something internal, but you can ping me for reviews12:55
bauzasgibi: I remember I need to update the doc change for the mdev support, but hopefully, I'll do it tomorrow12:55
gibibauzas: ack. no worries. I don' track any super important open patches for RC1. 13:01
gibibauzas: for the mdev doc, sure, we can merge that even on Friday as it low risk13:02
opendevreviewFabian Wiesel proposed openstack/nova master: Vmware: Fix indentation in conditionals  https://review.opendev.org/c/openstack/nova/+/80639113:08
opendevreviewVlad Gusev proposed openstack/nova stable/stein: Abort live-migration during instance_init  https://review.opendev.org/c/openstack/nova/+/80688113:10
*** lbragstad_ is now known as lbragstad13:15
spatelsean-k-mooney Default NIC bind to NUMA0 so is that NIC feature or CPU, i am planning to buy some hardware i looking for that feature where my NIC bind to both NUMA zone13:15
spatelI meant VF for SRIOV or DPCK13:16
spatelDPDK13:16
opendevreviewMerged openstack/nova master: Address release note nits for cpu-resources series  https://review.opendev.org/c/openstack/nova/+/70566713:22
spatelAssuming its NIC feature to map with NUMA, as per basic google :)13:22
sean-k-mooneyspatel: by default the nic binds to the first numa node in a cpu socket13:26
spatelYes, that is correct13:26
sean-k-mooneyso if you have a 2 socket system then it will bind to the firt numa node of the cpu socket that the pci lanes attach too13:26
sean-k-mooneywe have a new socket affinity policy to reflect that also13:27
sean-k-mooneywhich allows the device to be used if the cpu and devce are form the same socket13:27
spatelin which condition NIC will bind to both NUMA0 and NUMA1 ? 13:27
spatelDo i need to buy special NIC or special CPU?13:27
sean-k-mooneyit wont unless you have a nic with 2 uplinks13:27
spatelI have Intel X710 with 2x10G port (does that work to bind dual NUMA?)13:28
skazihi, can someone please take a look at https://review.opendev.org/c/openstack/nova/+/791807 and older backports?13:38
skazithe Ussuri version is already merged13:38
skaziZuul says +113:38
skaziwe need this fix all the way back to Rocky :o)13:39
skazithx!13:39
*** whoami-rajat__ is now known as whoami-rajat14:00
*** abhishekk is now known as abhishekk|away14:31
bauzasgibi: oh shit, forgot our team meeting was today and it conflicts with some physiotherapist appointmnet14:35
gibibauzas: ack14:35
sean-k-mooneyskazi: that is a partial fix you also need https://review.opendev.org/c/openstack/nova/+/80662915:10
elodillesskazi: that patch is a squash of two patch out of which one patch is still not merged on ussuri. (also worth to mention that there is another fix to make the bug completely dissappear... and that is still open in victoria: https://review.opendev.org/q/topic:bug/1927677 )15:38
gibinova meeting starts in 12 minutes here in the channel15:48
*** abhishekk|away is now known as abhishekk15:51
gibi#startmeeting nova16:00
opendevmeetMeeting started Tue Sep 14 16:00:05 2021 UTC and is due to finish in 60 minutes.  The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
opendevmeetThe meeting name has been set to 'nova'16:00
gibio/16:00
elodilleso/16:01
gibilets wait a bit for the others16:02
gibiif only elodilles and me are here then I will be extra quick16:05
gibiso we have to cut RC1 this week16:06
gibirelease tracking etherpad is here https://etherpad.opendev.org/p/nova-xena-rc-potential16:06
gibiplease review the reno prelude before Friday16:06
gibiprelude: #link https://review.opendev.org/c/openstack/nova/+/80778616:06
gibithat is the only thing I'm tracking as still have to land before RC116:07
gibiI looked at the untriaged backlog and I don't see any obvious regression for xena16:07
gibiif you do have such bug / fix then let me know16:07
sean-k-mooneyoh o/16:08
gibisean-k-mooney: o/16:08
sean-k-mooneyim here but a litte distracted16:08
gibithat was all important I wanted to say 16:08
gibielodilles, sean-k-mooney: is there anything to discuss?16:08
elodillesone thing regarding stable16:08
gibigo16:09
sean-k-mooneyah tere was a question about when to do the next stable release right16:09
elodillesyesterday we got a question whether we are planning to release16:09
elodilleson stable16:09
elodillessean-k-mooney: that's it :)16:09
elodilleslast release was exactly 2 months ago16:09
elodillesso I guess we could prepare releases16:10
gibiI'm happy to check release patches but I think I lost my PTL approve power since the election results were merged16:10
elodillesthat's probably true :)16:10
sean-k-mooneydo we want to wait until after rc1 is out and done with16:10
gibiso you have to ping bauzas to approve them16:10
elodillesthen we need bauzas either as PTL or as release liaison :)16:10
gibihopefully somebody can take the release liason over from bauzas 16:11
elodilles(he owns both role now)16:11
gibisean-k-mooney: is there a connection?16:11
sean-k-mooneyjust gate capastity so no not really16:11
elodillesand sean-k-mooney question is the next one: do we want to wait for something?16:11
sean-k-mooneywe might want to wait for the open redirect cve fixes16:12
elodillesif not, then I can prepare the releases today or tomorrow16:12
sean-k-mooneythats really the only thing im thinking of16:12
sean-k-mooneythey are merged to usuri i think so we could start with W->U16:13
elodillessean-k-mooney: some part are merged back till ussuri,16:13
elodillesbut if i'm not mistaken there is one part which is still waiting for review in victoria16:13
sean-k-mooneyand and do train after16:13
sean-k-mooneyah right for the /// case16:13
elodilles(reminder: train is EM, so there won't be any release)16:13
sean-k-mooneyah ok cool16:13
gibiI agree to release Wallaby now, then land the cve last fix to V and release that16:14
elodilleshttps://review.opendev.org/c/openstack/nova/+/80662616:14
elodillesthis needs stable review ^^^16:14
gibithen backort the last cve fix to U etc.16:14
elodillesand the also ussuri version of it16:14
gibican I get stable power?16:14
gibi;)16:14
elodilles:]16:14
sean-k-mooneyok so are we agreed we shoudl merge those then release them16:15
sean-k-mooneyonce we get the ack for bauzas 16:15
elodillessounds good to me16:15
sean-k-mooneylyarwood: melwitt  if you have time to review those on stable that would also help16:16
elodillesyes, reviews are welcome and appreciated for those patches16:16
sean-k-mooneyif there is nothing else we can likely wrap the meeting there16:17
gibiyeah16:17
gibianything else?16:17
elodillesnothing from me :X16:18
gibithen lets close this16:18
gibi#endmeeting16:18
opendevmeetMeeting ended Tue Sep 14 16:18:30 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:18
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2021/nova.2021-09-14-16.00.html16:18
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2021/nova.2021-09-14-16.00.txt16:18
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2021/nova.2021-09-14-16.00.log.html16:18
gibithanks16:20
elodillesthanks o/16:21
*** artom_ is now known as artom16:36
artomelodilles, while we're kinda on the topic (con't from the meeting, sorta), could you give an opinion on https://review.opendev.org/c/openstack/nova/+/791481 ?16:37
artomIt's "blocking" a few backports, so it'd be good to get fixed on whether it's get-in-able or not16:38
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: fixtures: Handle binding of first port  https://review.opendev.org/c/openstack/nova/+/79690516:40
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: Neutron fixture: don't clobber profile and vif_details if empty  https://review.opendev.org/c/openstack/nova/+/79690616:40
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: functional: Add live migration tests for PCI, SR-IOV servers  https://review.opendev.org/c/openstack/nova/+/79690716:40
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: Test SRIOV port move operations with PCI conflicts  https://review.opendev.org/c/openstack/nova/+/79690816:40
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: Update SRIOV port pci_slot when unshelving  https://review.opendev.org/c/openstack/nova/+/79690916:40
artomFor now I've just stacked on top16:40
elodillesartom: well, it's test-only so that's good. on the other hand it is just refactoring (which is usually refused to accept as valid backport - if it's not some trivial change), thus I think it's not really "blocking". I understand that it makes backporting easier for some cases, but...17:04
artomelodilles, so the alternative is that every backport that goes back to train (and Red Hat has to care about stable/train for a loooon time) is harder to write and review because it'll have a note about having to adjust method params or w/e17:05
elodilleswell, there will be ONE point where a patch needs modification / resolve of conflicts, but further back it can be still clean17:06
artomelodilles, right, I meant in the sense that *every* patch going back to train will need that modification17:07
artomAs opposed to landing the test refactor and forgetting about it17:07
elodilleslet's say if we backport it till train then a patch that needs backport to stein will need the very same modification (though I understand that stein expects way less backports)17:08
artomelodilles, ah, I see your point. We'd just be pushing back the point at which we need manual adjustments to the backport17:09
elodillesexactly17:10
artomI agree, I just don't know how much of an issue it will be in practice...17:10
elodillesit depends on the amount of similar patches I think :)17:11
artomelodilles, so, you have more experience reviewing stable branches, what would you say the ratio of RH to non-RH backports is?17:11
artomOr to put it slightly different, RH care about stable/train (queens is still a thing, though we expect way less work on it now)17:12
elodillesdefinitely RH wins over non-RH, that's true :)17:12
artomI'm trying to tread carefully here, because this is *not* just throwing our weight around17:13
artomIf CERN (to name a random example) or Vexxhost or whoever are still running stein a need loads of backports to it, it's a different conversation17:13
elodillesanyway, I'm not completely against backporting this, I'm just thinking as well where is the line and maybe this is somewhere there :)17:16
artom_But if stable/train happens to be the stable branch that's most popular by virtue of being what RH supports, it would make sense to me to make backports to train as easy as possible? <-- repeating myself in case it didn't send before my connection dropped17:17
mnaserartom: thanks for thinking of us :) we don't care about stein anymore (thankfully :])17:17
mnaserin the next few weeks wallaby will be the only thing we care about17:18
artom_mnaser, \o/17:18
*** artom_ is now known as artom17:22
artomDammit, how the crap does a new func test cause this trace:17:23
artom2021-09-14 13:22:47,973 ERROR [nova.api.openstack.wsgi] Unexpected exception in API method17:23
artomTraceback (most recent call last):17:23
artom  File "/home/artom/src/nova/.tox/functional-py36/lib/python3.6/site-packages/urllib3/connectionpool.py", line 417, in _make_request17:23
artom    httplib_response = conn.getresponse(buffering=True)17:23
artomTypeError: getresponse() got an unexpected keyword argument 'buffering'17:23
elodillesartom: another aspect is when we backport *everything* to train, then we make it harder (or even impossible?) to other contributors (with less weight) to backport a change from train to stein as they would require to resolve a mass of conflicts17:23
artomelodilles, valid point, though I'd counter that part of that has already been done, by virtue of the backport chain already existing for train17:26
artomSo you know you need at least those patches17:26
artomLike, I'm willing to bite that bullet, because I think overall it saves man hours17:26
artomI'll happily resolve conflicts for someone's stable/stein backport if it means making stable/train backporting easier17:27
artomThe question is - how do we even advertise that?17:27
artomTo let backporters know17:27
elodilles:) valid question :)17:27
elodillesanyway, I'll sleep on it and will review the patch tomorrow17:28
artomelodilles, ack, thanks for the conversation :)17:29
elodillesartom: np :)17:30
spatelanyone has any experience with server.com to rent servers? 17:30
spatelI am planning to rent to build openstack so looking for good feedback if anyone has :)17:31
artomelodilles, one last data point, FWIW, in the last 6 months, there's been 3 "pages" of patches to stable/train, vs 1 for stable/stein17:33
artomhttps://review.opendev.org/q/project:openstack/nova+branch:stable/train+-age:6month https://review.opendev.org/q/project:openstack/nova+branch:stable/stein+-age:6month17:34
artomSo about 3 times more backports to train than stein17:34
artomTbh, I expected a bigger difference, I thought stein would be way less active17:35
artomLooks like we need Vlad Gusev, he's the main stein contributor who's not RH17:35
opendevreviewMerged openstack/nova stable/ussuri: Reduce mocking in test_reject_open_redirect for compat  https://review.opendev.org/c/openstack/nova/+/80309418:22
skazielodilles: thx for additional info I didn't know that 18:39
skazielodilles: thx for additional info I didn't know that :o(18:39
skazisean-k-mooney: thank you too!18:40

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!