| opendevreview | Merged openstack/nova stable/train: Raise InstanceMappingNotFound if StaleDataError is encountered https://review.opendev.org/c/openstack/nova/+/777254 | 00:35 |
|---|---|---|
| jameshyde | is this a known bug? every time after live migrating a VM from one hypervisor (source) to another hypervisor (target), nova-compute service is still up and running, but nova-conductor from controller keeps saying this: Failed to compute_task_migrate_server: Compute service of hostname_here is unavailable at this time.: nova.exception.ComputeServiceUnavailable: Compute service of hostname_here is | 02:45 |
| jameshyde | it complains about nova compute service on source host | 02:46 |
| jameshyde | restarting nova-compute works around this issue, but this requiring restarting nova-compute every time after vm live migration away from source host. | 02:47 |
| *** abhishekk is now known as akekane|home | 03:55 | |
| *** akekane|home is now known as abhishekk | 03:55 | |
| *** akekane_ is now known as abhishekk | 06:01 | |
| *** iurygregory_ is now known as iurygregory | 06:28 | |
| opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209 | 06:57 |
| *** rpittau|afk is now known as rpittau | 07:24 | |
| kevinz | sean-k-mooney: thanks for the update, will ping them next week. | 07:28 |
| lyarwood | jamesdenton: That sounds like a bug if the source service is marked as up and active | 08:11 |
| lyarwood | jameshyde sorry | 08:12 |
| opendevreview | sean mooney proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663 | 09:59 |
| sean-k-mooney | lyarwood: it proably just the bug where rabbit mq loses i thin the topic on the compute recive queue | 10:00 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | 10:00 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | 10:00 |
| opendevreview | Stephen Finucane proposed openstack/nova master: policy: Deprecate field from 'os-extended-server-attributes' policy https://review.opendev.org/c/openstack/nova/+/806131 | 10:00 |
| sean-k-mooney | the one where the compute agent can send rpcs like the heartbeat but not recive them until you recreate the queue | 10:00 |
| sean-k-mooney | eight that or the hostname has change to the instace.host does not match the current host | 10:01 |
| sean-k-mooney | both would break the conductors ablity to manage vms on the host but the agent would be up | 10:01 |
| lyarwood | I was assuming it came from here and the servicegroup API tbh | 10:02 |
| lyarwood | https://github.com/openstack/nova/blob/2a78626a85954997d35f5fe62c50de297e2ca92d/nova/conductor/tasks/live_migrate.py#L284-L288 | 10:02 |
| lyarwood | so assuming that's using the db driver | 10:02 |
| sean-k-mooney | well the host in that case comes form instnace.host | 10:02 |
| sean-k-mooney | so if the host name changed on the node that would not fine it properly | 10:03 |
| lyarwood | yup right | 10:03 |
| sean-k-mooney | lyarwood: melwitt by the way just updated the db url test assertin gthe content of the alembic conf and equating it to the the input string | 10:05 |
| lyarwood | ah awesome missed that above | 10:06 |
| * lyarwood rechecks the tripleo test patch | 10:06 | |
| sean-k-mooney | just did | 10:06 |
| sean-k-mooney | altought its complaing about failing to merge? | 10:06 |
| sean-k-mooney | oh we both did | 10:06 |
| sean-k-mooney | right pep8... | 10:07 |
| sean-k-mooney | for some reason i dont have pre-commmit in this once copy of nova | 10:08 |
| lyarwood | failed to merge was just because you pushed a new ps of the nova change | 10:08 |
| sean-k-mooney | oh ok | 10:08 |
| sean-k-mooney | oh melwitt was right about the glbal needing to be reset | 10:11 |
| sean-k-mooney | depending on order the test breaks ill fix that and push it again | 10:12 |
| sean-k-mooney | this is infuriating | 10:58 |
| sean-k-mooney | my test works on its own but the connection string is not being passed to alembic if i run multiple db tests | 10:59 |
| sean-k-mooney | reference = 'sqlite:///:memory:?read_default_group=data+with%2Fa+percent_%25-and+symbols%21' | 10:59 |
| sean-k-mooney | actual = 'sqlite://' | 10:59 |
| sean-k-mooney | ok i think i have it working | 11:02 |
| sean-k-mooney | but its one of those thing where you need to run it many times to be sure | 11:03 |
| opendevreview | sean mooney proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663 | 11:07 |
| opendevreview | sean mooney proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663 | 11:14 |
| sean-k-mooney | lyarwood: ok unless there is review feedback ^ is the final version of that patch | 11:15 |
| sean-k-mooney | i have also restarted the ooo dnm patch so we will see if it works for them in a while | 11:15 |
| sean-k-mooney | stephenfin: oh you reviewd at some point am i did not see that until i looked at my eamil | 11:16 |
| lyarwood | melwitt: https://review.opendev.org/c/openstack/nova/+/800634/12..13/nova/tests/unit/cmd/test_manage.py - would you mind taking another look at this today when you're online, I think I've finally addressed everything. | 11:23 |
| opendevreview | sean mooney proposed openstack/nova master: [FUP] minor cleanup in db migration tests https://review.opendev.org/c/openstack/nova/+/806143 | 11:47 |
| opendevreview | sean mooney proposed openstack/nova master: [FUP] minor cleanup in db URL tests https://review.opendev.org/c/openstack/nova/+/806143 | 11:48 |
| artom | Heh, why the fup? Original patch hasn't gotten a single +2 yet? :) | 12:10 |
| artom | Ah, gate | 12:10 |
| sean-k-mooney | ya i want to see the results | 12:13 |
| sean-k-mooney | ill likely squash it | 12:13 |
| gibi | something is happening with placement concurrent allocation update issue https://paste.opendev.org/show/808348/ | 13:26 |
| gibi | the amount of job failure due to that getting significantly worse | 13:27 |
| sean-k-mooney | hehe that one way to shorten a url | 13:27 |
| gibi | if you have a hammer ... | 13:27 |
| sean-k-mooney | yes it hit melwitt patches yesterday i think | 13:27 |
| sean-k-mooney | i this the same issue that is cause by a concurent delete request | 13:28 |
| sean-k-mooney | if so melwitt has patches for that as im sure your aware | 13:28 |
| gibi | probably we always had this as in http://status.openstack.org/elastic-recheck/#1836754 | 13:28 |
| gibi | but now it become significant | 13:28 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/688802 this is what i was thinking of | 13:32 |
| sean-k-mooney | although i think we shoudl jsut go back to calling delete on the allocation and ignoring the version personally instead of doing a put | 13:33 |
| opendevreview | sean mooney proposed openstack/nova master: Add autopep8 to tox and pre-commit https://review.opendev.org/c/openstack/nova/+/806182 | 13:35 |
| artom | sean-k-mooney, we may need for melwitt to wake up for this one, but... does the database fixture actually mock out anything? | 13:41 |
| artom | I don't grok how it's actually used | 13:41 |
| sean-k-mooney | its creating a real db using sqlight in memory database feature | 13:42 |
| artom | OK... So for instance if you pass it a connection URL, it'll create a new context and use its engine: https://github.com/openstack/nova/blob/master/nova/tests/fixtures/nova.py#L625 | 13:43 |
| sean-k-mooney | its an interesting question though if i need it now that i have added the other fixture for get engine | 13:43 |
| artom | But then the migration code will always just use the main_db_api.get_engine: https://github.com/openstack/nova/blob/master/nova/db/migration.py#L47 | 13:43 |
| sean-k-mooney | ill try droping it now that i have added the addtional fixture and see if that is enough | 13:44 |
| artom | Reason I'm asking is - I've tried using the connection=url kwarg to the Database fixture to avoid your mocking while still fixing the global engine issue | 13:44 |
| sean-k-mooney | i am using this to run a db sync after all so i dont need the db fixture to set other things up for me | 13:44 |
| sean-k-mooney | artom: ya i trided that too but it wont work for 2 reaons | 13:45 |
| artom | And they are definitely different engines - but the test uses the main_db_api engine, and not the fixture engine | 13:45 |
| sean-k-mooney | artom: im mocking out get_enging in the migration | 13:46 |
| sean-k-mooney | module | 13:46 |
| sean-k-mooney | so it shoudl be useing the new fixtures engine | 13:46 |
| artom | Right, I get that. I'm trying to understand why it's even necessary with the database fixture | 13:46 |
| sean-k-mooney | because the engine.url is imutable | 13:47 |
| sean-k-mooney | and its reused between multipel tests | 13:47 |
| sean-k-mooney | so it end up with a different connection string then the one we pass | 13:47 |
| artom | Right - but we can't use different engines? | 13:47 |
| sean-k-mooney | even when we use the connection parmater in the db fixture | 13:47 |
| artom | Per test, for tests that need it? | 13:47 |
| sean-k-mooney | that is what https://review.opendev.org/c/openstack/nova/+/805663/6/nova/tests/unit/db/test_migration.py#50 is doing | 13:48 |
| sean-k-mooney | artom: the engine url used to be mutable im not sure our db fixtuer has worked with custom connections since that change in sqlalcahme about a year or 2 agao | 13:49 |
| artom | Yeah... I just thought the fixture would handle that | 13:49 |
| artom | ? | 13:49 |
| artom | Especially with the enticingly named connection=url kwarg :) | 13:49 |
| sean-k-mooney | i think it used too but it definetly does not now | 13:50 |
| artom | Weird. | 13:50 |
| artom | And it's only used in 1 spot, the kwarg | 13:50 |
| sean-k-mooney | ok so i dont need the db fixture just my one for 'nova.db.migration._get_engine' | 13:51 |
| sean-k-mooney | the test will still work if i remove the db fixture | 13:51 |
| sean-k-mooney | good catch ill update that when i squah things | 13:52 |
| sean-k-mooney | ooo is still runnign so i dont want to interupt that job | 13:53 |
| sean-k-mooney | artom: you mentioned its used in only one place? | 13:56 |
| sean-k-mooney | where is that | 13:56 |
| sean-k-mooney | maybe i should remove the parmater in a follow up and fix that | 13:56 |
| opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209 | 13:56 |
| sean-k-mooney | or well make the connnection parmater work by creating an new engin instnace | 13:57 |
| artom | sean-k-mooney, well, it appear to correctly create a new engine | 14:14 |
| artom | .. which then never gets used anywhere, AFAICT | 14:14 |
| artom | nova/tests/functional/db/test_connection_switch.py is where it gets used | 14:15 |
| artom | self.useFixture(nova_fixtures.Database(connection=self.fake_conn)) | 14:15 |
| lyarwood | stupid question if anyone with vif/neutron background can help, I'm trying to work out how to find a default for hw_vif_model when it's unset | 14:18 |
| lyarwood | I thought osinfo.HardwareProperties(instance.image_meta).network_model was what I wanted but I'm seeing it return None | 14:18 |
| sean-k-mooney | lyarwood: its virtio | 14:18 |
| lyarwood | just hardcoded? | 14:18 |
| sean-k-mooney | i think so i think i know where it is | 14:19 |
| lyarwood | kk I've missed it then | 14:19 |
| sean-k-mooney | its virt dirver dependent | 14:19 |
| sean-k-mooney | vmware default to a differnt thing then libvirt | 14:19 |
| opendevreview | Stephan Pampel proposed openstack/nova master: docs: admin/networking rename neutron_tunneled to neutron_tunnel https://review.opendev.org/c/openstack/nova/+/806197 | 14:20 |
| lyarwood | https://github.com/openstack/nova/blob/master/nova/virt/osinfo.py#L99-L112 was where I was looking FWIW | 14:20 |
| lyarwood | just without os_distro set this doesn't seem to do anything | 14:20 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L211-L215 | 14:21 |
| sean-k-mooney | sorry wrong link | 14:21 |
| sean-k-mooney | but its not commig form osinfo its form vif.py | 14:21 |
| lyarwood | kk | 14:21 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L162-L178 | 14:22 |
| sean-k-mooney | we do check os_info but its more complicated then that | 14:22 |
| lyarwood | ah | 14:23 |
| sean-k-mooney | this is where its then called in get_base_config https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L205 | 14:24 |
| sean-k-mooney | lyarwood: out of interest why were you looking for that | 14:25 |
| lyarwood | sean-k-mooney: for the device bus migration stuff, the initial part is to register the current values | 14:25 |
| lyarwood | sean-k-mooney: so I was trying to see if I can pull the default for this easily like I can with hw_disk_bus/hw_cdrom_bus from disk_info | 14:26 |
| sean-k-mooney | ah right ya so you can jsut call that driver function to get the model | 14:26 |
| lyarwood | sean-k-mooney: without inspecting the instance itself etc | 14:26 |
| lyarwood | sean-k-mooney: any idea how I'd get an instance of that VIF class? | 14:26 |
| sean-k-mooney | we construct it in the driver | 14:26 |
| * lyarwood greps around | 14:26 | |
| lyarwood | kk | 14:26 |
| lyarwood | ah self.vif_driver, awesome | 14:27 |
| sean-k-mooney | if you need too though you can just constuct it with no args | 14:27 |
| sean-k-mooney | get_vif_model does not rely on self.host but ya self.vif_driver | 14:28 |
| sean-k-mooney | this used to be plugable | 14:28 |
| sean-k-mooney | i dont think it is anymore | 14:28 |
| melwitt | gibi, sean-k-mooney: I support reverting the patch that changed from DELETE of allocations and I've been thinking about it more lately and think it's the better thing to do anyway | 14:59 |
| gibi | melwitt, sean-k-mooney: I have to load context for that. I only saw the placement conflict error appearnig more frequently in the last ~24 hours. | 15:00 |
| melwitt | gibi: yes, it's because of consumer types I'm afraid :( | 15:01 |
| gibi | melwitt: is there a connection? | 15:03 |
| melwitt | gibi: I think there is but I want to look through to make sure it makes sense | 15:03 |
| gibi | OK, I can also spend some time on it tomorrow | 15:05 |
| melwitt | lyarwood: ack will look again | 15:06 |
| melwitt | sean-k-mooney: ack will look at the db url patch again | 15:07 |
| sean-k-mooney | melwitt: i have one update to push for that which is the db fixture is not required | 15:54 |
| sean-k-mooney | and im going to suqah the follow up patch in to adress stephens nits but the main content of hte patch wont change | 15:54 |
| sean-k-mooney | melwitt: actully the ooo job has now completed so ill push those change in the next 5 mins or so | 15:55 |
| sean-k-mooney | ok that looks like it fixes ooo https://review.opendev.org/c/openstack/tripleo-heat-templates/+/806103 | 15:57 |
| *** rpittau is now known as rpittau|afk | 16:02 | |
| opendevreview | sean mooney proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663 | 16:07 |
| sean-k-mooney | artom: melwitt lyarwood ^ let me know if there is anything else needed im going to switch to something else for a bit | 16:08 |
| *** akekane_ is now known as abhishekk | 16:18 | |
| sean-k-mooney | artom: thanks ill adress those comments later today | 16:52 |
| opendevreview | Rodrigo Barbieri proposed openstack/nova stable/victoria: Fix 1vcpu error with multiqueue and vif_type=tap https://review.opendev.org/c/openstack/nova/+/806004 | 17:01 |
| sean-k-mooney | melwitt: actully in terms of gloabls i dont think we should be resetting them i relaly think we should be mocking them instead | 17:31 |
| sean-k-mooney | melwitt: but i didnt really want to open that discussion in those patches | 17:31 |
| sean-k-mooney | i dont think resetting them is safe from a concurancy point of view | 17:32 |
| melwitt | ok | 17:32 |
| sean-k-mooney | where asd the mock approch should be | 17:32 |
| sean-k-mooney | i guess it might be ok since we will be runing the test in different python processes | 17:33 |
| melwitt | yeah, that's why it's ok to do | 17:33 |
| melwitt | *ok to do in our case | 17:33 |
| melwitt | it's about (random) test ordering and whether leaving a particular state will impact a test running after | 17:34 |
| sean-k-mooney | right form a style point of view im not sure direct asignment is preferable vs the mock but ill pull this out into a follow up patch if that works for you and artom | 17:34 |
| sean-k-mooney | melwitt: yep i have defiently seen the issues sharing state can cause | 17:35 |
| melwitt | sean-k-mooney: I'm completely fine with waiting until it's a problem. it may be that we don't have any tests that would be impacted by leftover state | 17:35 |
| artom | Don't fix problems we don't have :) | 17:35 |
| artom | We have enough problems that we, err, have :P | 17:35 |
| sean-k-mooney | artom: well the concern here is this is really really hard to debug when it happens | 17:36 |
| melwitt | ++ | 17:36 |
| artom | Fair point, too | 17:37 |
| artom | It's just weird seeing code that basically goes "weeeell just in case" | 17:37 |
| melwitt | fwiw I agree the mocks in the patch should be removed, if we reset the globals it should be for all tests, not only the one | 17:39 |
| sean-k-mooney | i partly agree with taht but not convifced how we do it today is correct :) ill remove it for now | 17:40 |
| melwitt | re: resetting the globals in nova/test.py like the rest of them, I think that's the right thing to do (it's the correct thing to do) but it's not directly related to the patch at hand. that could and probably should be a separate patch | 17:40 |
| sean-k-mooney | artom: just to be clear what melwitt was concerned about is https://github.com/openstack/nova/blob/e27a0135f8ec986d3583b11276715a5c0d0c302a/nova/db/migration.py#L75-L83 would retrun a cached copy of the config object and that would have state that would break us or cause inter test depency | 17:40 |
| sean-k-mooney | which is technially a valid concern the connection stirg will proably leak if i remove the current mock | 17:41 |
| sean-k-mooney | it should not break anything but ya it will leak state | 17:42 |
| artom | Well, there's no proper way to fix that then, is there? | 17:42 |
| sean-k-mooney | its what the mock does | 17:42 |
| melwitt | it's just something I noticed and I have unfortunately broken the gate twice I think with forgetting to reset global vars I introduced, so I am particularly attuned to it 😂 | 17:42 |
| sean-k-mooney | it replace the dict its using as a cache | 17:42 |
| artom | Because while we can definitely reset state *after* our tests, what happens for concurrently running tests? | 17:42 |
| sean-k-mooney | artom: they are in differnt python processes | 17:42 |
| artom | They're not running 1 per process, are they? | 17:43 |
| sean-k-mooney | we only ever run one test in each proces at a time | 17:43 |
| melwitt | artom: we currently do them in test.py. here's some examples and there are more if you read further down in setUp() https://github.com/openstack/nova/blob/2a78626a85954997d35f5fe62c50de297e2ca92d/nova/test.py#L227-L231 | 17:43 |
| sean-k-mooney | the test a loadbalnce over a set of process by tox | 17:43 |
| sean-k-mooney | melwitt: well that is not the only place | 17:43 |
| sean-k-mooney | we have other local reset too | 17:44 |
| * artom is leaning to melwitt's approach - if any global state needs to be reset between tests, base setUp() is where to do it... | 17:44 | |
| artom | Otherwise it's whackamole, no? | 17:45 |
| sean-k-mooney | well we would have to reset alto more state tehere then we curerntly do | 17:45 |
| sean-k-mooney | normally we reset them in the test that tested the code tha tuse the global | 17:45 |
| melwitt | I didn't come up with the approach but I have followed the pattern when I had patches that introduced new global vars | 17:45 |
| sean-k-mooney | melwitt: i have always followed a differnt pattern like this https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/tests/unit/test_cinder.py#L87 https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/volume/cinder.py#L55 | 17:46 |
| melwitt | well, for things like a CELL_CACHE *lots* of things use it, even if they're not specifically setting out to use it | 17:47 |
| sean-k-mooney | this is the first time i have seen it centralised | 17:47 |
| dansmith | I dunno what patch ya'll are talking about, | 17:47 |
| sean-k-mooney | i expect that modules have a reset funciton in them to rest the module sttate | 17:47 |
| dansmith | but anything the test expects should be mocked, and only incidental globals i.e. CELL_CACHE should be reset in test.py each time, IMHO | 17:47 |
| sean-k-mooney | dansmith: https://review.opendev.org/c/openstack/nova/+/805663 | 17:48 |
| sean-k-mooney | we cache the alembic config in a global | 17:48 |
| sean-k-mooney | dansmith: so i was mocking the dict use for the cache so that we start form an empty dict and dont leak the state | 17:49 |
| dansmith | yeah, that's exactly the sort of incidental global we _should_ reset in test.py I think | 17:49 |
| sean-k-mooney | but we dont do that for a lot of other cases | 17:49 |
| dansmith | presumably that gets touched by some tests that don't even realize it right? | 17:49 |
| artom | sean-k-mooney, wait, shouldn't the clearing be happening *after* the test? | 17:49 |
| artom | Or before the other tests run, in setUp()? | 17:50 |
| dansmith | artom: in setUp() is conventional yeah | 17:50 |
| sean-k-mooney | artom: no with the mock it happens before and it restores the previous state after | 17:50 |
| dansmith | artom: i.e. don't clean up from other tests, reset state to known before running next test | 17:50 |
| artom | On right, the mock context manager | 17:50 |
| artom | But it'd still restore any state that was there previously, if another test leaked it... | 17:50 |
| sean-k-mooney | yes | 17:51 |
| artom | So yeah, I vote in setUp() in a follow up patch :) | 17:51 |
| artom | Also, the Database fixture connection= kwarg is weird and needs to go, it's misleading | 17:51 |
| sean-k-mooney | i can put it in setup but i dont think it should be in test.py | 17:51 |
| sean-k-mooney | https://github.com/openstack/nova/search?q=reset_globals | 17:51 |
| sean-k-mooney | i thikn that patern is cleaner the reset_gloals function is called in setup of the test class that test that module | 17:52 |
| dansmith | sean-k-mooney: is it only ever set by this test, or can it be set by other tests that use the DB and don't really pay attention to the fact that it's set? | 17:52 |
| artom | Nothing actually uses the engine that it creates with connection=url passed in | 17:52 |
| sean-k-mooney | dansmith: its only set by things that run the db migrations | 17:52 |
| dansmith | sean-k-mooney: well, everything runs the db migrations | 17:52 |
| sean-k-mooney | dansmith: they dont use creat_all? | 17:53 |
| dansmith | sean-k-mooney: do you mean only things that *test* the db migrations in specific ways? | 17:53 |
| sean-k-mooney | that woul dbe much quicker | 17:53 |
| sean-k-mooney | dansmith: i think its only set by thign that call migration.db_sync | 17:53 |
| dansmith | sean-k-mooney: but that's a ton of things, right? | 17:53 |
| dansmith | incidentally | 17:53 |
| dansmith | things that want a DB setup have that done for them in the background right? | 17:54 |
| sean-k-mooney | i dont know sound like i should add a function that will reset the gloabls and then either call that in test.py or in setup in the current test class | 17:54 |
| dansmith | ++ for test.py for db things | 17:54 |
| dansmith | DB stuff is so global and sticky IME that it belongs in the test.py, IMHO | 17:54 |
| sean-k-mooney | dansmith: there are 2 ways to create the db. either start with blank schema or tell the model to create_all | 17:55 |
| sean-k-mooney | ok ill do that so | 17:55 |
| sean-k-mooney | still not conviced it the best way long term but ill do that for now | 17:55 |
| melwitt | this is where we db_sync for every use of the Database fixture https://github.com/openstack/nova/blob/master/nova/tests/fixtures/nova.py#L643 | 17:56 |
| dansmith | I feel like melwitt and I get extra argument points for the scars we have from all the cellsv1 and v2 test setup experience | 17:56 |
| melwitt | and the CellDatabases fixture https://github.com/openstack/nova/blob/master/nova/tests/fixtures/nova.py#L397 | 17:56 |
| melwitt | 😂 | 17:56 |
| dansmith | by "argument points" i mean.. votes :) | 17:57 |
| dansmith | I didn't fully read the backscroll, but melwitt you're pro-test.py right? | 17:57 |
| sean-k-mooney | dansmith: well its more i have previosue used a different pattern for reseting global state mainly for cached stuff in the past | 17:57 |
| sean-k-mooney | dansmith: that was nto the db cofnig but its the first time i have seen a prefernce to do this in test.py centrally | 17:58 |
| melwitt | dansmith: yes | 17:58 |
| sean-k-mooney | rahter then in the test module that cares | 17:58 |
| sean-k-mooney | ok ill add a reset_globals function to the nova.db.migration module and then call that form test.py | 17:59 |
| sean-k-mooney | ill push that in a few minutes | 17:59 |
| *** tbachman is now known as Guest5500 | 19:14 | |
| *** tbachman is now known as Guest5504 | 20:26 | |
| *** tbachman is now known as Guest5507 | 20:50 | |
| *** tbachman is now known as Guest5510 | 21:18 | |
| *** tbachman is now known as Guest5516 | 23:03 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!