| NobodyCam | sean-k-mooney: I clarify that there is a reserve inventory instance that is tripping up our readiness checks.. | 01:36 |
|---|---|---|
| opendevreview | Merged openstack/nova stable/stein: Move 'check-cherry-picks' test to gate, n-v check https://review.opendev.org/c/openstack/nova/+/804615 | 01:46 |
| opendevreview | Merged openstack/nova stable/stein: Prevent archiving of pci_devices records because of 'instance_uuid' https://review.opendev.org/c/openstack/nova/+/760984 | 02:25 |
| opendevreview | Merged openstack/nova master: fup: Remove unused legacy block_device_info format https://review.opendev.org/c/openstack/nova/+/804286 | 02:25 |
| opendevreview | Merged openstack/nova master: fup: Increase service_down_time beyond INITIAL_REPORTING_DELAY in test https://review.opendev.org/c/openstack/nova/+/805667 | 02:25 |
| *** tamas_erdei is now known as terdei | 06:57 | |
| *** rpittau|afk is now known as rpittau | 07:06 | |
| *** mgoddard- is now known as mgoddard | 07:47 | |
| *** akekane_ is now known as abhishekk | 08:19 | |
| opendevreview | test proposed openstack/nova master: Add some missing parameters in docs of os-cells https://review.opendev.org/c/openstack/nova/+/805972 | 08:56 |
| opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | 09:26 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Restrict amqp indirect dep to speed up pip resolution https://review.opendev.org/c/openstack/placement/+/805979 | 09:51 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-traits to latest 2.6.0 https://review.opendev.org/c/openstack/placement/+/805830 | 09:51 |
| lyarwood | gibi: https://review.opendev.org/q/topic:remove_luks_workarounds some simple cleanups here if you have time | 09:55 |
| elodilles | lyarwood: I've commented on the stable/train's CI patch. I'm not completely against it, but it is not necessary in Train so I wouldn't merge it in all cost, plus I see one difference that would reduce coverage if I'm not mistaken: py2 grenade | 09:56 |
| gibi | lyarwood: ack, lookgin | 09:56 |
| lyarwood | elodilles: ack I'll look | 09:56 |
| lyarwood | gibi: thanks, I'm trying to get to your qos series btw, almost there :) | 09:56 |
| gibi | lyarwood: thanks in advance :) | 09:57 |
| opendevreview | Merged openstack/nova master: fup: Fix os-volume_attachments api-ref parameters https://review.opendev.org/c/openstack/nova/+/805876 | 10:16 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | 10:24 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | 10:24 |
| opendevreview | Lee Yarwood proposed openstack/placement master: Bump os-traits to latest 2.6.0 https://review.opendev.org/c/openstack/placement/+/805830 | 11:14 |
| opendevreview | Lee Yarwood proposed openstack/placement master: Restrict amqp indirect dep to speed up pip resolution https://review.opendev.org/c/openstack/placement/+/805979 | 11:14 |
| lyarwood | gibi: ^ just had to reorder these to avoid the 2.6.0 test failure | 11:14 |
| opendevreview | Merged openstack/nova master: Reproduce bug 1941005 https://review.opendev.org/c/openstack/nova/+/805882 | 11:30 |
| kevinz | kashyap: sbauza: Hi, could you help to review this live migration patch? https://review.opendev.org/c/openstack/nova/+/763928, the comments has been addressed. | 11:39 |
| kevinz | kashyap: sbauza: live migration on arm64 patch, really appreciated! | 11:40 |
| sean-k-mooney | kevinz: they are both on vaction this week | 12:04 |
| gibi | lyarwood: right that is the correct order. I knew I wanted to do something with them but I got distracted | 12:04 |
| sean-k-mooney | ill try and take a look at it | 12:04 |
| gibi | thanks | 12:04 |
| gibi | lyarwood: wait, now the 2.6.0 is the first patch, but that will fail due to timeout without the amqp restriciton | 12:05 |
| gibi | do we have a deadlock then | 12:06 |
| gibi | ? | 12:06 |
| gibi | the global req was bumped causing that we need the gabbit update, but that is failing as lower constraints is timing out without the amqp change, but the amqp patch alone will fail due to the gabbit failures | 12:07 |
| opendevreview | Merged openstack/nova master: compute: Query the service group API within check_instance_host https://review.opendev.org/c/openstack/nova/+/802317 | 12:14 |
| lyarwood | gibi: yeah sorry I didn't think the amqp change was causing a failure | 12:17 |
| lyarwood | gibi: in that case we should squash both changes into one I guess | 12:17 |
| gibi | yes, I don't see any other way around | 12:17 |
| gibi | I will squash them in a minute | 12:17 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-traits to latest 2.6.0 https://review.opendev.org/c/openstack/placement/+/805830 | 12:24 |
| gibi | lyarwood: this should be green now ^^ | 12:24 |
| opendevreview | Merged openstack/python-novaclient master: Microversion 2.89 - os-volume_attachments https://review.opendev.org/c/openstack/python-novaclient/+/805022 | 13:09 |
| opendevreview | lmercl proposed openstack/nova master: nova-api add flavorid value to server's flavor part https://review.opendev.org/c/openstack/nova/+/805995 | 13:25 |
| opendevreview | lmercl proposed openstack/nova stable/wallaby: nova-api add flavorid value to server's flavor part https://review.opendev.org/c/openstack/nova/+/805997 | 13:29 |
| opendevreview | lmercl proposed openstack/nova master: nova-api add flavorid value to server's flavor part https://review.opendev.org/c/openstack/nova/+/805995 | 13:40 |
| opendevreview | Rodrigo Barbieri proposed openstack/nova stable/victoria: Fix 1vcpu error with multiqueue and vif_type=tap https://review.opendev.org/c/openstack/nova/+/806004 | 14:20 |
| gmann | stephenfin: gibi replied on hostname policy chekcs https://review.opendev.org/c/openstack/nova/+/778550/10/nova/api/openstack/compute/views/servers.py#414 | 14:25 |
| gmann | we can chat to conclude it quickly | 14:26 |
| gmann | my point is, this is policy change and should not be controlled with microversion instead just deprecate and remove in next cycle for old microversion also | 14:26 |
| gmann | that is how other policy changes we do | 14:26 |
| gmann | old microversion in this case i mean >2.3 for GET and >2.75 for PUT/Rebuild as this attribute was added for them. | 14:27 |
| *** lbragstad_ is now known as lbragstad | 14:39 | |
| gibi | gmann: does this mean we are not implementing the POST /servers change to allow passing hostname in Xena? If we do implement that then delaying the policy change (at least of the new microversion) with deprecation does not make sense from usability perspective | 14:40 |
| gibi | I want see what I passed in | 14:41 |
| gibi | so what if in Xena we deprecate the policy BUT also in xena in the microversion that allows passing hostname in server create we introduce the hostname in the responses. Then in Yoga we remove the policy from the hostname attribute and that results that hostname will be shown in every microversion | 14:43 |
| gibi | this allows that the current POST change be usable in Xena and also follows deprecation policy | 14:44 |
| gmann | gibi: in that case we have to mention that policy is controlled with microversion. for >=2.90 you can see this attribute even previously you have restricted it for non-admin and even non-admin does not pass hostname in POST request. | 14:52 |
| gibi | gmann: purely from policy perspective yes, this would be a microversion that temporarily changes the policy. After Yoga where the policy is removed this microversion controlls policy situation would be resolved | 14:55 |
| gibi | honestly I don't want to delay the possibility to set hostnames | 14:55 |
| gibi | but only allow to set them in 2.90 but not allow to see what you set feels bad | 14:56 |
| gmann | gibi: they can see with policy change, but yes with default policy they would not be able to see | 15:02 |
| gmann | *policy override | 15:02 |
| gibi | gmann: is there a way to only override the policy for the hostname attribute only? | 15:03 |
| gmann | gibi: no, it is with other server extended attributes | 15:06 |
| gibi | but we don't want to show all the exteneded attribute as there are sensitive informations there like the hypervisor_hostname | 15:06 |
| gmann | humm | 15:06 |
| gibi | but the hostname of the VM is harmless | 15:06 |
| gibi | that does not reveal any infra informatiuon | 15:07 |
| gmann | yeah | 15:07 |
| *** abhishekk is now known as akekane|home | 15:08 | |
| *** akekane|home is now known as abhishekk | 15:08 | |
| gmann | gibi: I think in this exceptional case when there is related API change, I am getting your point. | 15:09 |
| gmann | let me rethink if any other way it can create inconsistency other seems ok to me | 15:10 |
| gmann | otherwise | 15:10 |
| gibi | gmann: for me it is the case when our strict rules (microversion and policy deprecation) get in our way to provide a meaningful and (for me) safe change for the end user | 15:11 |
| gmann | yeah. | 15:12 |
| gibi | and I support our strict rules in general as it is a safety net to avoid breaking users, but in this specific case I think we can allow an exception for the rules | 15:13 |
| gmann | i agree. especially with the point of using 2.90 changes completely (request and see the hostname by end users) | 15:14 |
| gmann | I think I am convinced now :). thanks | 15:15 |
| opendevreview | Merged openstack/placement master: Bump os-traits to latest 2.6.0 https://review.opendev.org/c/openstack/placement/+/805830 | 15:17 |
| gibi | gmann: thank you for the discussion | 15:24 |
| melwitt | lyarwood: thanks for noting that I need to rebase the consumer types set, going to do that now and will need +W reapplied after | 15:29 |
| lyarwood | melwitt: I think we can get away without a rebase now | 15:29 |
| lyarwood | melwitt: zuul should do it for us once it's rechecked | 15:30 |
| * lyarwood was about to do it before this call | 15:30 | |
| melwitt | o rly | 15:30 |
| melwitt | ok | 15:30 |
| melwitt | I'm glad I said something. thanks I can do that | 15:30 |
| stephenfin | gmann: gibi: Sorry, I had meetings. It _sounds_ like you've come to a conclusion and are ultimately happy with what I've done? | 15:30 |
| gmann | stephenfin: yeah, it looks good to me, reviewing that patch... | 15:31 |
| gibi | ohh consumer_types are going in \o/ | 15:33 |
| melwitt | yes \o/ | 15:36 |
| lyarwood | assuming it's rebased by zuul ;) | 15:36 |
| lyarwood | cool looks like it did | 15:39 |
| lyarwood | brb | 15:39 |
| *** rpittau is now known as rpittau|afk | 16:04 | |
| gmann | stephenfin: left few comments on test and documentation | 16:07 |
| artom | def _do_old_style_instance_list_for_poor_cellsv1_users() | 16:36 |
| artom | Right, who's the joker responsible for that? | 16:36 |
| artom | Mr Smith. | 16:37 |
| sean-k-mooney | someone who took pitty on the cell v1 users | 16:37 |
| sean-k-mooney | then need all the care we can give them | 16:37 |
| artom | (Yes, this is very old code - looking at a Queens bug report) | 16:37 |
| sean-k-mooney | ********* | 16:39 |
| sean-k-mooney | they are mising url quoting | 16:39 |
| sean-k-mooney | https://github.com/sqlalchemy/sqlalchemy/blob/master/lib/sqlalchemy/engine/url.py#L542 | 16:40 |
| artom | ? | 16:43 |
| sean-k-mooney | the query args secotion fo the url is enccoded using quote_plus | 16:44 |
| sean-k-mooney | where spaces are replaced with + | 16:44 |
| sean-k-mooney | but the protocol seciont of the url has a + in it that is not a spec | 16:44 |
| sean-k-mooney | *space | 16:45 |
| sean-k-mooney | so if i decode it with unqoute technically the queary args wont be decoded properly | 16:45 |
| artom | Ohhh | 16:45 |
| sean-k-mooney | which means if i want to properly decode it i need to hande eveything beofre the ? one way and everything after the other way | 16:46 |
| sean-k-mooney | i htink im just going to skip that and replcae % with %% | 16:46 |
| sean-k-mooney | and hope that config parser is ok with the url encoded value | 16:47 |
| artom | Yeah | 16:47 |
| artom | We'll get the tripleo job to run with the fix as a dependency | 16:47 |
| sean-k-mooney | ya i can add a depends on | 16:48 |
| sean-k-mooney | that works with ooo right | 16:48 |
| sean-k-mooney | via a dnm patch | 16:48 |
| artom | It should | 16:50 |
| artom | I was thinking the other way around, have an ooo DNM patch depending on the nova one, but whatever works | 16:51 |
| *** dprince is now known as Guest5389 | 16:52 | |
| sean-k-mooney | artom: that is what im going to do | 16:53 |
| lbragstad | gmann so - i'm working through a test where a system-admin creates a server in a project (specifically trying to find what needs to change in KSA to make that possible) | 17:01 |
| lbragstad | and it looks like the first failure is https://github.com/openstack/neutron/blob/master/neutron/notifiers/nova.py#L265 because neutron is using a novaclient with a project-scoped token (instead of a system-scoped one) | 17:02 |
| sean-k-mooney | that nova client should be using the token set in the neutron.conf | 17:03 |
| sean-k-mooney | which woudl normally be the nova user or a service user | 17:03 |
| lbragstad | yeah - exaclty | 17:03 |
| lbragstad | and it does | 17:04 |
| lbragstad | so - that's good | 17:04 |
| sean-k-mooney | so the nova user would have to be a project member or if it was a system_memeber we need a new parmater to specifcy a project id i ugess | 17:04 |
| sean-k-mooney | *guess | 17:04 |
| sean-k-mooney | the api its calling however is admin only and not really proejct specfic | 17:04 |
| sean-k-mooney | im surpised that is failing | 17:05 |
| lbragstad | in https://github.com/openstack/neutron/blob/master/neutron/notifiers/nova.py#L265 specifically - the nova user would need to be a system-admin https://github.com/openstack/nova/blob/master/nova/policies/server_external_events.py#L27 | 17:05 |
| lbragstad | iiuc | 17:05 |
| sean-k-mooney | yes | 17:05 |
| sean-k-mooney | so the nova user woul dhave to be a system_admin | 17:06 |
| lbragstad | right | 17:06 |
| lbragstad | so that neutron can use that user with a client to create external events in nova | 17:07 |
| sean-k-mooney | yes | 17:07 |
| sean-k-mooney | its calling this endpoint https://docs.openstack.org/api-ref/compute/?expanded=run-events-detail#run-events | 17:07 |
| lbragstad | in addition to that - we'd need a way to make sure neutron is using the right scope when building the auth request | 17:08 |
| lbragstad | https://github.com/openstack/neutron/blob/master/neutron/notifiers/nova.py#L61 | 17:08 |
| sean-k-mooney | yep we woudl need to add a new config parmater ofor the scop to use | 17:09 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/policies/server_external_events.py#L24-L35 | 17:09 |
| sean-k-mooney | in this case system scope | 17:09 |
| lbragstad | and i imagine that's going to be a pattern we need else where? | 17:10 |
| lbragstad | i'm expecting this is just the first time i'm hitting this issue, but there are other layers to the onion | 17:10 |
| sean-k-mooney | well its going to happen but worse for volume resize | 17:11 |
| lbragstad | sure - that makes sense | 17:11 |
| sean-k-mooney | cinder currently has bug where it calls that endpoing with the users token | 17:11 |
| sean-k-mooney | instead of actully using an admin one | 17:11 |
| sean-k-mooney | but yes i expect the pattern to be the same or similar | 17:12 |
| dansmith | sean-k-mooney: is that a bug, or just how it used to work? | 17:12 |
| sean-k-mooney | im surprised that it got that far by the way | 17:12 |
| sean-k-mooney | dansmith: no that is a bug | 17:12 |
| sean-k-mooney | which ooo worked around by hardcodeing cidner to call nova admin api endpoint directly | 17:12 |
| dansmith | is this the swap volume api or something else? | 17:12 |
| lbragstad | fwiw - this is what i'm doing to recreate this https://review.opendev.org/c/openstack/tempest/+/805452 | 17:13 |
| sean-k-mooney | i tought it was resize for nfs but ill have to go look it up | 17:13 |
| sean-k-mooney | lbragstad: by the way i was expecting a failure before that when nova called neutron to bind the port | 17:13 |
| lbragstad | yeah - me too | 17:13 |
| sean-k-mooney | we do that as a admin | 17:13 |
| dansmith | okay just saying.. the swap volume api has always been user-visible, but problematic.. people have used it for non-cinder tasks before and we discussed whether or not they should be able to.. but they are (or were) | 17:13 |
| sean-k-mooney | dansmith: im pretty sure the issue i was refering too was for online volume resize whne cinder calls nova back to tell it its done | 17:14 |
| sean-k-mooney | dansmith: ill see if i can find it | 17:14 |
| dansmith | okay, there's some volume op that uses swap_volume for that sort of thing (cinder calling to nova) | 17:15 |
| dansmith | but might be different | 17:15 |
| sean-k-mooney | dansmith: i dont have the ooo one to hand but this is the osa dup https://bugs.launchpad.net/openstack-ansible/+bug/1902914 and redhat kcs...https://access.redhat.com/solutions/3675991 | 17:16 |
| dansmith | okay I expect this is different | 17:17 |
| sean-k-mooney | yes lbragstad current issue is different and expected | 17:17 |
| sean-k-mooney | well expected in that each of the serviceis will need to know how to call each of the other services with the correct scopes | 17:18 |
| sean-k-mooney | lbragstad: you could try booting an instance with no network as a simpler starting point | 17:19 |
| sean-k-mooney | lbragstad: that would limit the interaction ot nova, keystone, glance and placment | 17:20 |
| sean-k-mooney | placment would be the only thing that used any admin creds in that flwo also | 17:20 |
| sean-k-mooney | we would use the user token for the glance image | 17:20 |
| sean-k-mooney | im not 100% shoure what you would need to add but i think it would be something like network=none to your self.create_test_server( call | 17:22 |
| lbragstad | yeah - that makes sense | 17:22 |
| gmann | lbragstad: for system scope enabled. tempest does not create network | 17:24 |
| gmann | lbragstad: that is skipped when create network was project scoped in neutron but that is changed i think | 17:24 |
| lbragstad | ah - interesting | 17:24 |
| gmann | lbragstad: | 17:25 |
| gmann | lbragstad: https://review.opendev.org/c/openstack/tempest/+/798130 | 17:25 |
| lbragstad | gmann is that still the case with https://review.opendev.org/c/openstack/tempest/+/805452/4/tempest/api/compute/admin/test_servers.py ? | 17:26 |
| gmann | lbragstad: for network created for network, we need to modify that also to pass the project_id in neutron request for system scope | 17:26 |
| gmann | lbragstad: yes. we have not changed that for ^^. and no network for system scoped cred | 17:26 |
| gmann | I can work on that tomorrow to pass projetc_id as slaweq mentioned in that review | 17:28 |
| lbragstad | gmann ok - that sounds good, i'm trying to track all of this stuff as a find it, but it's likely going to be a lot of sprawl | 17:42 |
| lbragstad | stepping out for about 30 minutes | 17:43 |
| opendevreview | melanie witt proposed openstack/placement master: Refactor consumer type methods for readability https://review.opendev.org/c/openstack/placement/+/806035 | 17:45 |
| melwitt | sean-k-mooney, lyarwood: fixups for consumer types ^ | 17:46 |
| sean-k-mooney | melwitt: im kind of +0.5 https://review.opendev.org/c/openstack/placement/+/806035/1/placement/objects/usage.py#91 | 18:12 |
| melwitt | sean-k-mooney: thanks, I will reword it | 18:14 |
| opendevreview | melanie witt proposed openstack/placement master: Refactor consumer type methods for readability https://review.opendev.org/c/openstack/placement/+/806035 | 18:22 |
| sean-k-mooney | melwitt: by the way im just looking at the db tests i assume somehting in here https://github.com/openstack/nova/blob/master/nova/tests/unit/db/main/test_migrations.py that uses the OpportunisticDBTestMixin would be what you want for the alembic urls | 18:26 |
| melwitt | sean-k-mooney: ah, cool. I have used that mixin once before I think. fwiw I wasn't clear on whether we need a database to cover some test inputs or if we only need the config parser behind it. whatever works | 18:30 |
| melwitt | want to be able to do at least a couple of cases, one with the encoded chars and one with a password for example with a literal "%" in it | 18:31 |
| melwitt | or I guess that could just be one case by putting both together in one example | 18:31 |
| sean-k-mooney | ok im just going thought the different fixture we have aviable to us | 18:32 |
| sean-k-mooney | https://github.com/openstack/oslo.db/blob/22b44ee18b1585bc2943a29ddaa18051cb1344ed/oslo_db/sqlalchemy/test_fixtures.py#L399 | 18:32 |
| sean-k-mooney | we have the fix ture and the mixins | 18:32 |
| melwitt | ah ok | 18:32 |
| sean-k-mooney | the adhock db fixture allows us to pass a url https://github.com/openstack/oslo.db/blob/22b44ee18b1585bc2943a29ddaa18051cb1344ed/oslo_db/sqlalchemy/test_fixtures.py#L273 | 18:33 |
| sean-k-mooney | the opertunistic mixin can be combind with any of the fixture i think | 18:34 |
| sean-k-mooney | we need to modify the engin url if we want to test this right before tuning the db sync | 18:35 |
| melwitt | meanwhile, the consumer types patches are failing on that dang server delete fail for AllocationDeleteFailed conflict 😑 | 18:36 |
| sean-k-mooney | melwitt: i have updated stephens exisitng test case already just trying to see if theyer is a good way to also add the extra tests you where hoping for | 18:37 |
| sean-k-mooney | if only there was a patch we could merge for that :) | 18:37 |
| sean-k-mooney | thats furstrating | 18:37 |
| melwitt | sean-k-mooney: ok, cool. lmk if you need a hand with it, I can try to help | 18:38 |
| opendevreview | sean mooney proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663 | 20:01 |
| sean-k-mooney | melwitt: ok that did not work but i found another way to test this | 20:01 |
| sean-k-mooney | i realised after i fot the adhoc fixture working that would not test any of our config loading ectra | 20:02 |
| sean-k-mooney | which is what we actully wanted to test | 20:02 |
| sean-k-mooney | well initalising the alembic config form our config | 20:02 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Update PCI requests in request spec on resize https://review.opendev.org/c/openstack/nova/+/806049 | 20:10 |
| melwitt | sean-k-mooney: sweet! just added some comments | 20:15 |
| opendevreview | Merged openstack/nova stable/wallaby: Allow X-OpenStack-Nova-API-Version header in CORS https://review.opendev.org/c/openstack/nova/+/796860 | 22:18 |
| opendevreview | Merged openstack/placement master: Add consumer_types migration, database and object changes https://review.opendev.org/c/openstack/placement/+/669170 | 22:18 |
| opendevreview | Merged openstack/placement master: Microversion 1.38: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | 22:18 |
| opendevreview | Merged openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | 22:18 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!