| *** whoami-rajat has quit IRC | 00:20 | |
| *** LinPeiWen has joined #openstack-nova | 00:44 | |
| *** rloo has quit IRC | 00:46 | |
| melwitt | gmann: I added a very late reply on https://review.opendev.org/c/openstack/nova/+/762013 if you could look at your convenience this week | 00:57 |
|---|---|---|
| gmann | melwitt: sure, will check tomorrow. | 00:58 |
| *** LinPeiWen has quit IRC | 00:58 | |
| *** LinPeiWen has joined #openstack-nova | 00:58 | |
| melwitt | cool thx | 00:59 |
| *** LinPeiWen has quit IRC | 00:59 | |
| *** LinPeiWen has joined #openstack-nova | 00:59 | |
| *** LinPeiWen has quit IRC | 01:00 | |
| *** LinPeiWen has joined #openstack-nova | 01:00 | |
| *** LinPeiWen has quit IRC | 01:14 | |
| *** LinPeiWen has joined #openstack-nova | 01:14 | |
| opendevreview | norman shen proposed openstack/nova master: Saving security group to info_cache https://review.opendev.org/c/openstack/nova/+/786348 | 01:34 |
| *** abhishekk has joined #openstack-nova | 04:39 | |
| *** abhishekk has quit IRC | 04:41 | |
| *** abhishekk has joined #openstack-nova | 04:41 | |
| *** hemanth_n has joined #openstack-nova | 04:58 | |
| *** bhagyashris_ has joined #openstack-nova | 05:03 | |
| *** bhagyashris has quit IRC | 05:10 | |
| *** vishalmanchanda has joined #openstack-nova | 05:14 | |
| *** bhagyashris_ has quit IRC | 05:47 | |
| *** ralonsoh has joined #openstack-nova | 06:10 | |
| opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | 06:11 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | 06:11 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | 06:12 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 06:12 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | 06:12 |
| *** bhagyashris has joined #openstack-nova | 06:15 | |
| *** luksky has joined #openstack-nova | 06:44 | |
| *** dklyle has quit IRC | 06:49 | |
| *** alex_xu has joined #openstack-nova | 07:04 | |
| *** andrewbonney has joined #openstack-nova | 07:19 | |
| *** bhagyashris has quit IRC | 07:23 | |
| *** bhagyashris has joined #openstack-nova | 07:23 | |
| yonglihe | Hi, gibi, alex_xu, sean, smartnic patch set is revised, to make your day easy, here is a change list since last review: | 07:24 |
| *** abhishekk has quit IRC | 07:24 | |
| yonglihe | current change set: 1) drop one unnecessary cyborg call(get_arq_device_rp_uuid) | 07:24 |
| yonglihe | 2) clean up arq: there is possible arq not bind to instance or port. | 07:24 |
| yonglihe | addressed in both compute and conductor stages | 07:24 |
| yonglihe | previous change set1: | 07:25 |
| yonglihe | * put the device_profile into reqeust_net(API stage), then we elimate one neutron call. | 07:25 |
| yonglihe | * add cyborg ARQ clean up for all sorts of failure | 07:25 |
| yonglihe | * clean up code logic for 2 kind of ARQ: port requested ARQ and flavor reqeust ARQ. | 07:25 |
| yonglihe | * functional tests | 07:25 |
| yonglihe | * bump compute service version number | 07:25 |
| yonglihe | * reject create smatnic port attached server while migration in progress | 07:25 |
| alex_xu | yonglihe: planning to review next around | 07:26 |
| *** bhagyashris_ has joined #openstack-nova | 07:38 | |
| *** bhagyashris has quit IRC | 07:44 | |
| *** mgariepy has quit IRC | 07:46 | |
| *** kaisers has joined #openstack-nova | 08:03 | |
| *** lucasagomes has joined #openstack-nova | 08:14 | |
| *** nightmare_unreal has joined #openstack-nova | 08:16 | |
| *** lucasagomes has quit IRC | 08:19 | |
| *** icey has joined #openstack-nova | 08:20 | |
| *** derekh has joined #openstack-nova | 08:21 | |
| *** lucasagomes has joined #openstack-nova | 08:26 | |
| *** lucasagomes has quit IRC | 08:27 | |
| *** lucasagomes has joined #openstack-nova | 08:56 | |
| *** lucasagomes has quit IRC | 08:58 | |
| *** Luzi has joined #openstack-nova | 09:10 | |
| *** mgoddard_ has joined #openstack-nova | 09:15 | |
| lyarwood | melwitt: https://bugs.launchpad.net/nova/+bug/1930406 - btw when you're around later can we chat about this and any workarounds you're aware of? | 09:17 |
| opendevmeet | Launchpad bug 1930406 in OpenStack Compute (nova) "parallel volume-attachment requests might starve out nova-api for others" [Undecided,New] | 09:17 |
| * lyarwood isn't great with uwsgi configs | 09:17 | |
| *** mgoddard_ is now known as mgoddard | 09:18 | |
| lyarwood | but tbh I've wanted to drop the offending RPC call for a while and this might be the report that finally pushes me to remove it | 09:18 |
| lyarwood | behind a microversion | 09:18 |
| lyarwood | as it changes what we return to the caller | 09:18 |
| *** mgariepy has joined #openstack-nova | 09:19 | |
| *** abhishekk has joined #openstack-nova | 09:19 | |
| *** lucasagomes has joined #openstack-nova | 09:34 | |
| *** lucasagomes has quit IRC | 09:37 | |
| *** lucasagomes has joined #openstack-nova | 09:42 | |
| *** nightmare_unreal has quit IRC | 09:43 | |
| *** lucasagomes has quit IRC | 09:44 | |
| *** jangutter_ has joined #openstack-nova | 10:01 | |
| *** jangutter has quit IRC | 10:08 | |
| sean-k-mooney | lyarwood is it just doing the rpc for the device name which we dont even garentee inside the guest | 10:09 |
| lyarwood | yeah we also create the bdm during the same call | 10:09 |
| lyarwood | via the conductor so it takes a little longer | 10:09 |
| sean-k-mooney | should we make this an async api and just make it a cast | 10:10 |
| sean-k-mooney | we have been talking about rpc version compatiablity downstream for a while on an off | 10:12 |
| lyarwood | we need the BDM creation to be sync to avoid races but we can do that on the api | 10:12 |
| lyarwood | and then move this device assignment behind the already async part | 10:12 |
| sean-k-mooney | one thing i have been debating in my mind is shoudl we be removing all direct calls to the compute from the api | 10:13 |
| lyarwood | casts are still fine right? | 10:13 |
| lyarwood | or move everything behind conductor tasks | 10:14 |
| lyarwood | the latter is lots of work | 10:14 |
| sean-k-mooney | i was thinking evenutally everything goes though conductor but cast might be ok | 10:14 |
| sean-k-mooney | the reasonign was so that the api does not need to speak the compute node rpc version | 10:15 |
| sean-k-mooney | but ya thats a larger change then you need | 10:15 |
| sean-k-mooney | having the api create the bdms and then cast to do the rest async shoudl be fine in this case | 10:16 |
| *** ralonsoh has quit IRC | 10:17 | |
| gibi | melwitt: when you are up, I managed to make CI green on https://review.opendev.org/c/openstack/nova-specs/+/788243 (and get bauzas +2) | 10:17 |
| *** ralonsoh has joined #openstack-nova | 10:17 | |
| *** jangutter_ is now known as jangutter | 10:20 | |
| *** jangutter has quit IRC | 10:21 | |
| *** jangutter has joined #openstack-nova | 10:21 | |
| *** jangutter_ has joined #openstack-nova | 10:24 | |
| opendevreview | Elod Illes proposed openstack/nova stable/wallaby: [stable-only] Fix ceph install in live migration hook https://review.opendev.org/c/openstack/nova/+/794000 | 10:25 |
| sean-k-mooney | melwitt: gibi: quick question about consumer types. will there be an api that allows me to list all allocation by consumer types and optionall filter that | 10:26 |
| sean-k-mooney | for filtering i was thinking by host, project and maybe consumer/vm id | 10:27 |
| sean-k-mooney | the reason im asking is the mailing list thread related to premptible instnaces. | 10:28 |
| sean-k-mooney | one of the suggtions i had was to explore using a "premptible" consumer type for premtiable instances | 10:29 |
| sean-k-mooney | initally if we had a query api it would allow and external service to esaisly determing what instance could be killed via a placment query | 10:30 |
| *** jangutter has quit IRC | 10:30 | |
| sean-k-mooney | but i coudl imaging later extending plamcnet so that it coudl optionalling include the capsity used by preamtiable instance in its allocation candates set with a new micorverion and query arg | 10:31 |
| *** lucasagomes has joined #openstack-nova | 10:32 | |
| sean-k-mooney | not that im going to work on that any time soon but i just taught that would enable and intersting desgin direction to explore | 10:33 |
| jkulik | lyarwood, sean-k-mooney: wouldnt "having the api create the bdms" mean, that we need distributed locking between the apis, so we don't run into races while creating those? | 10:37 |
| lyarwood | We'd need rely on the DB ensuring there's only ever one active BDM for a given instance UUID and volume ID combo | 10:38 |
| sean-k-mooney | jkulik: we are creating them in the db so we can do a db level lock if we needed too | 10:38 |
| jkulik | is multi-attach possible for the same VM? | 10:38 |
| lyarwood | not for the same instance no | 10:38 |
| sean-k-mooney | jkulik: within the same vm no | 10:38 |
| sean-k-mooney | if we need a lock we can take a row level lock on the instance uuid or instance and volumne uuid pair | 10:39 |
| lyarwood | tbh a constraint should be enough | 10:40 |
| lyarwood | at least that's what was agreed on in the past when this came up | 10:40 |
| lyarwood | but that was in the context of us creating duplicate BDMs on failure | 10:41 |
| lyarwood | *failure to attach | 10:41 |
| lyarwood | that hasn't been an issue for a while now | 10:41 |
| sean-k-mooney | ya there is no index in the bdm that we need to worry about is there | 10:41 |
| jkulik | lyarwood: "for a while" - which version do I need to upgrade to? :D | 10:41 |
| lyarwood | jkulik: this was way back in Kilo I think and only reported by one customer downstream | 10:42 |
| lyarwood | I've never seen it since | 10:42 |
| lyarwood | -> lunch brb | 10:42 |
| jkulik | hm ... I'm on rocky and need to investigate why there are like 10 bdm entries (pretty much empty) and one filled with connection_info in my DB for multiple VMs | 10:42 |
| jkulik | same (volume_id, instance_uuid) | 10:43 |
| sean-k-mooney | the uniqe constrati on rocky is just the bdm uuid | 10:44 |
| sean-k-mooney | https://github.com/openstack/nova/blob/stable/rocky/nova/db/sqlalchemy/models.py#L587 | 10:44 |
| sean-k-mooney | thats also the case for master | 10:45 |
| sean-k-mooney | lyarwood: ^ | 10:45 |
| stephenfin | bauzas: Friendly reminder that the 'instance_type' cleanup series is still waiting your attention, if you have some time https://review.opendev.org/q/topic:%2522compute_rpc_6.0%2522+status:open | 10:45 |
| sean-k-mooney | so the uniqe constraint in the db i currently not enough to prevent duplicats | 10:45 |
| lyarwood | jkulik: yeah the others are marked as soft deleted (deleted=id etc) | 10:45 |
| lyarwood | sean-k-mooney: yup this is a new constraint I'm talking about | 10:45 |
| *** martinkennelly has joined #openstack-nova | 10:45 | |
| sean-k-mooney | oh ok | 10:46 |
| jkulik | no. they're not soft-deleted | 10:46 |
| sean-k-mooney | well currently the could be not marked as soft deleted | 10:46 |
| sean-k-mooney | you can have duplicate entries with the current schema | 10:46 |
| lyarwood | right but that's the race I was saying we hadn't seen reported for a while | 10:46 |
| sean-k-mooney | ah ok | 10:47 |
| lyarwood | jkulik: what does `openstack server volume list $instance` show? | 10:47 |
| *** lucasagomes has quit IRC | 10:47 | |
| lyarwood | jkulik: the same duplicates? | 10:47 |
| sean-k-mooney | well backportbale way to fix this is to add a db trigger on insert to enforce the constraint then on master update the uniqe constratint | 10:48 |
| jkulik | lyarwood: let me find such an instance again. I cleaned them up already for the customer to continue | 10:48 |
| *** whoami-rajat has joined #openstack-nova | 10:49 | |
| lyarwood | jkulik: ah if this is outside of the instance creation flow there have been known and now resolved issues with things like live migration rollbacks etc that could cause this | 10:49 |
| lyarwood | and/or volume attach flows I should say | 10:49 |
| jkulik | we're on VMware, so no live-migration via Nova for us in rocky afaik. might be volume-attach flows then | 10:50 |
| *** lucasagomes has joined #openstack-nova | 10:51 | |
| jkulik | if they're fixed, I'll have a look through the commits. let's see what I can dig up. thank you | 10:51 |
| stephenfin | lyarwood: Replied on https://review.opendev.org/c/openstack/nova/+/794006 I wasn't hitting the code path you're expecting because I wasn't booting from volume | 10:52 |
| opendevreview | sean mooney proposed openstack/nova-specs master: Add no user token when get Cyborg client https://review.opendev.org/c/openstack/nova-specs/+/787178 | 10:53 |
| stephenfin | that's evidently a far less common request than boot from volume, which explains why nobody has (based on reports, anyway) hit this before | 10:53 |
| jkulik | lyarwood: I didn't even know "server volume list" was a thing. cool. it shows both bdm entries for the instance I found | 10:54 |
| sean-k-mooney | stephenfin: boot from volumen is often an optimasation fo boot form exsiting volume | 10:56 |
| lyarwood | jkulik: cool, and `openstack server event list $instance` shows just attaching the volume etc? | 10:56 |
| sean-k-mooney | i would expect the latter to maybe be more common for heat or horizon users where you are less likely to typo the uuid due to the indirection | 10:56 |
| *** artom has quit IRC | 10:57 | |
| sean-k-mooney | stephenfin: booting form an existing volume used to be common if you were creating the volum using an iso | 10:57 |
| jkulik | lyarwood: hm ... hard to say. k8s instance with lot's of attachments going on. but it looks like in this case the volume is in state error | 10:57 |
| sean-k-mooney | stephenfin: where boot form volume the normal way will not do what you want it too | 10:58 |
| stephenfin | sean-k-mooney: tbc, I'm not doing boot from volume here. I'm booting from an image and attaching an additional volume | 10:58 |
| stephenfin | so that's the unusual path, I think | 10:58 |
| lyarwood | good old k8s, kk then this could be an issue with the vmware driver not cleaning up correctly on failure | 10:58 |
| sean-k-mooney | not really i do that all the time | 10:58 |
| stephenfin | i.e. 'server create --image IMAGE --block-device BDM ...' | 10:58 |
| sean-k-mooney | that is proably the most common use of cinder | 10:59 |
| *** icey has quit IRC | 10:59 | |
| stephenfin | clearly you're fastidious when it comes to your use of UUIDs so :) | 10:59 |
| lyarwood | yeah that's a common use case, I wouldn't say the most common but it's up there | 10:59 |
| sean-k-mooney | i never use the bdms direclly | 10:59 |
| *** artom has joined #openstack-nova | 10:59 | |
| lyarwood | k8s etc boots and then attaches for example | 10:59 |
| sean-k-mooney | i used to use --volume | 10:59 |
| lyarwood | anyway stephenfin I think this was just missed tbh | 11:00 |
| stephenfin | sean-k-mooney: --volume is for a boot device though | 11:00 |
| lyarwood | I got slightly confused by some output you posted in here | 11:00 |
| sean-k-mooney | no its not | 11:00 |
| stephenfin | at least in OSC | 11:00 |
| stephenfin | it sets boot_index to 0 | 11:00 |
| lyarwood | yeah --volume is shorthand for bfv in osc | 11:00 |
| sean-k-mooney | ok i normally use horizon for this but im pretty sure i used --volume for this too | 11:01 |
| sean-k-mooney | that a pretty bad design choice then | 11:01 |
| stephenfin | Yeah, I'm not a fan either | 11:01 |
| stephenfin | it should be the equivalent of '--network' and '--port', which are shorthand for various permutations of '--nic' | 11:01 |
| lyarwood | didn't you have a change up to move that to --boot-volume? | 11:01 |
| stephenfin | not me, that I recall | 11:02 |
| lyarwood | okay I thought someone did | 11:02 |
| *** belmoreira has joined #openstack-nova | 11:02 | |
| lyarwood | I'd be fine with that but I'm not sure how you could then reuse --volume without breaking people | 11:02 |
| sean-k-mooney | --bfv was porposed at one point | 11:02 |
| stephenfin | I guess you could consider ordering and use 'parsed_args.volumes[0]' is 'parsed_args.image_uuid' was unset? | 11:03 |
| sean-k-mooney | lyarwood: given osc is ment to work the same acroos multiple clouds and this would not be a micorverison change | 11:03 |
| stephenfin | s/is/if/ | 11:03 |
| sean-k-mooney | we coudl only resue --volume after a major version bump | 11:03 |
| stephenfin | not really, iirc using '--volume' and '--image' together currently is illegal | 11:04 |
| stephenfin | so we'd be loosening restrictions, not adding new ones | 11:04 |
| *** mgariepy has quit IRC | 11:04 | |
| stephenfin | if it's not it probably should be, since I can't see how specifying an image_uuid and a BDM with a boot_index of 0 would be allowed by the server | 11:05 |
| sean-k-mooney | you can use --image and --boot-from-volume <size> today that is the short hand for that | 11:05 |
| * stephenfin tests | 11:05 | |
| stephenfin | yeah, that's not what I'm describing though and it's a different thing | 11:05 |
| sean-k-mooney | but i tought we could use --image and --volume today to boot form image and attach data volumes | 11:05 |
| stephenfin | that'll create a new volume iirc | 11:06 |
| sean-k-mooney | can we add --data-volumn | 11:06 |
| stephenfin | that's kind of ugly | 11:06 |
| sean-k-mooney | well if we cant reclaim --volume then its kind of the best we can do | 11:07 |
| sean-k-mooney | som of the osc optionts are kind of questionable | 11:07 |
| sean-k-mooney | for example --image-property | 11:07 |
| stephenfin | $ openstack server create --flavor m1.tiny --image cirros-0.5.1-x86_64-disk --network private --volume test-volume test-server | 11:08 |
| stephenfin | openstack server create: error: argument --volume: not allowed with argument --image | 11:08 |
| stephenfin | yeah, as expected you can't do that currently | 11:08 |
| stephenfin | so we could add it easily | 11:08 |
| stephenfin | if image is not specified, the first volume specified gets boot_index of 0 and the rest get -1; if it *is* specified, all volumes get boot_index of -1 | 11:09 |
| sean-k-mooney | no | 11:09 |
| sean-k-mooney | if volume and image as sprecifed the root disk is created form the image | 11:10 |
| sean-k-mooney | so that has boot index 0 | 11:10 |
| stephenfin | that would mean overwriting whatever's already on the volume, no? | 11:10 |
| stephenfin | that doesn't seem like something you'd want to happen automatically | 11:11 |
| sean-k-mooney | no because we would be generating the bdm | 11:11 |
| sean-k-mooney | its the only thing i would add to be honest | 11:11 |
| sean-k-mooney | i dont think i would ever use what you proposed | 11:11 |
| stephenfin | I don't understand what you're asking for though | 11:12 |
| lyarwood | sean-k-mooney: tbh I think that's pretty confusing UX | 11:12 |
| lyarwood | if you provide both --image and --volume you end up with an image based volume? | 11:12 |
| sean-k-mooney | no | 11:12 |
| sean-k-mooney | you end up with a image based root disk not on cinder and a data volume | 11:12 |
| lyarwood | ah | 11:13 |
| lyarwood | sorry I misunderstood something you said above | 11:13 |
| stephenfin | I think I did too | 11:13 |
| stephenfin | sean-k-mooney: the data volume would have a boot_index of -1, no? | 11:13 |
| stephenfin | since it's a data volume, not a boot volume | 11:13 |
| * stephenfin assumes -1 == auto | 11:13 | |
| lyarwood | haha I don't think it does | 11:14 |
| sean-k-mooney | well it typically would not be set as bootable in cinder at all | 11:14 |
| * lyarwood checks | 11:14 | |
| stephenfin | so would you just not set it? | 11:14 |
| sean-k-mooney | i dont know | 11:14 |
| stephenfin | so instead of: | 11:14 |
| stephenfin | if image is not specified, the first volume specified gets boot_index of 0 and the rest get -1; if it *is* specified, all volumes get boot_index of -1 | 11:14 |
| stephenfin | I should say: | 11:14 |
| sean-k-mooney | i assumed -1 means last possibel | 11:14 |
| sean-k-mooney | or not bootable | 11:14 |
| lyarwood | `To disable a device from booting, set the boot index to a negative value or use the default boot index value, which is None.` | 11:14 |
| lyarwood | I've always just left it as None | 11:15 |
| stephenfin | if image is not specified, the first volume specified gets boot_index of 0 and the rest get nothing; if it *is* specified, no volume gets a boot_index | 11:15 |
| sean-k-mooney | yes | 11:15 |
| sean-k-mooney | that would work | 11:15 |
| lyarwood | yup | 11:15 |
| stephenfin | so 'server create --image IMAGE --volume VOLUME ...' -> boot from image with an attached data volume (2 block devices) | 11:15 |
| sean-k-mooney | yes | 11:15 |
| stephenfin | so 'server create --volume VOLUME ...' -> boot from volume (1 block devices) | 11:16 |
| stephenfin | s/so/and/ | 11:16 |
| sean-k-mooney | yep | 11:16 |
| lyarwood | stephenfin: does the first one use BDMs for both block devices or just the volume? | 11:16 |
| stephenfin | okay, cool. That's what I was thinking all along but clearly didn't word it well. That should be easily doable | 11:16 |
| lyarwood | stephenfin: and provide the image via imageRef | 11:16 |
| stephenfin | probably just the volume with a separate imageRed | 11:16 |
| stephenfin | *f | 11:16 |
| lyarwood | cool | 11:16 |
| stephenfin | seeing as it's easier | 11:17 |
| stephenfin | presumably | 11:17 |
| lyarwood | I was going to say if it did bdms for both we could nuke that | 11:17 |
| sean-k-mooney | lyarwood: is there an advantate to use the bdm and setting the image one to local | 11:17 |
| lyarwood | as yeah it's easier to use imageRef | 11:17 |
| lyarwood | sean-k-mooney: no IMHO, given how weird osc already is about this stuff I was just checking it wasn't using them | 11:17 |
| sean-k-mooney | ack | 11:18 |
| stephenfin | sean-k-mooney: as for your concerns RE: --image-property: I share them https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L812-L814 | 11:18 |
| stephenfin | it's on the chopping block | 11:19 |
| stephenfin | or will be soon | 11:19 |
| sean-k-mooney | well my concern was actully that we approved overriding image properties on the command line in the pass at the spec stage | 11:19 |
| sean-k-mooney | but it never got implemented | 11:20 |
| sean-k-mooney | so that really should not exist because if we ever revived that it would be a problem | 11:20 |
| stephenfin | you really do need to play around with this stuff to realize the ugliness of some of the interactions | 11:20 |
| stephenfin | lots of good stuff there but so many rough edges too | 11:20 |
| stephenfin | sean-k-mooney: agreed | 11:20 |
| sean-k-mooney | are you going to add --ephemeral | 11:20 |
| stephenfin | it's already there | 11:21 |
| sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/virt-image-props-boot-override.html just in case people were not aware of this | 11:21 |
| stephenfin | I added it last cycle | 11:21 |
| stephenfin | OSC is effectively feature complete from a nova perspective now, IMO. The only thing I haven't done is the host evacuate commands | 11:22 |
| sean-k-mooney | oh not in in the version i have installed locally then | 11:22 |
| stephenfin | you need 5.5.0 | 11:22 |
| stephenfin | which should have been 6.0.0, since we removed stuff /o\ | 11:22 |
| sean-k-mooney | i just installed the latest release | 11:23 |
| stephenfin | that ship has sailed though | 11:23 |
| sean-k-mooney | i had 5.4.0 | 11:23 |
| sean-k-mooney | stephenfin: you could revert that and do a 5.5.1 | 11:23 |
| stephenfin | good point | 11:24 |
| stephenfin | I'll discuss in the SDK team meeting tomorrow | 11:24 |
| sean-k-mooney | stephenfin: looking at my old history it looks like i have been doing it in 3 commands volume create, boot and attach | 11:26 |
| sean-k-mooney | when i dont do it one go in horizon | 11:26 |
| sean-k-mooney | oh by the way my cloud should be back runnign for people to use again later this week | 11:27 |
| sean-k-mooney | it technicall is already deployed now with ceph but i have not tweek it form the default or configure the flaovr/networkign yet | 11:28 |
| *** icey has joined #openstack-nova | 11:33 | |
| *** lucasagomes has quit IRC | 11:35 | |
| *** luksky has quit IRC | 11:36 | |
| opendevreview | Merged openstack/nova-specs master: Add no user token when get Cyborg client https://review.opendev.org/c/openstack/nova-specs/+/787178 | 11:36 |
| *** luksky has joined #openstack-nova | 11:37 | |
| *** lucasagomes has joined #openstack-nova | 11:37 | |
| *** martinkennelly_ has joined #openstack-nova | 11:47 | |
| *** martinkennelly has quit IRC | 11:51 | |
| *** kaisers has quit IRC | 11:52 | |
| *** kaisers has joined #openstack-nova | 11:54 | |
| *** lucasagomes has quit IRC | 11:55 | |
| gibi | sean-k-mooney: I think the current consumer type impl only suggest a basic usage summary per type https://review.opendev.org/c/openstack/placement/+/679441/18/placement/tests/functional/gabbits/consumer-types-1.37.yaml#130 | 12:00 |
| gibi | sean-k-mooney: and of course consumer type is now visible in the allocation | 12:01 |
| *** lucasagomes has joined #openstack-nova | 12:01 | |
| gibi | sean-k-mooney: so right now the client would need to list all the allocation then filter it on the client side by the consumer type / host / project | 12:01 |
| gibi | sean-k-mooney: I don't think it is hard to add those filters to the placement API if one needs it | 12:01 |
| *** nightmare_unreal has joined #openstack-nova | 12:03 | |
| nightmare_unreal | is there a way to find kernel version of hyperviser through openstack command ? | 12:04 |
| gibi | nightmare_unreal: I don't think so | 12:07 |
| *** nightmare_unreal has quit IRC | 12:07 | |
| *** bhagyashris_ is now known as bhagyashris | 12:09 | |
| sean-k-mooney | gibi: ya i dont think it would be hard to do either | 12:12 |
| *** kaisers has quit IRC | 12:12 | |
| sean-k-mooney | gibi: what do you think about the idea of a premtiable consumer type with a prefilter that just looks for and extra spec and changes it | 12:13 |
| sean-k-mooney | again im not planning to work on that this cycle but eventually i think it would be a nice feature to support | 12:14 |
| sean-k-mooney | im partly using this as a tought experiment to reason about addtional usecase fo consumer types | 12:14 |
| *** abhishekk has quit IRC | 12:15 | |
| gibi | sean-k-mooney: I see that the external service needs to determine which instance can be preempted. I don't get why this needs to be a placement query. It can be a nova query as well. | 12:16 |
| gibi | the external service want to find servers to delete | 12:17 |
| gibi | nova api deals with servers | 12:17 |
| sean-k-mooney | we dont currently have a way to list nova instance by flavor extra spec do we? | 12:17 |
| gibi | so for me it fits nova API better | 12:17 |
| sean-k-mooney | or by server property | 12:17 |
| gibi | sean-k-mooney: I don't think so, that query also needed | 12:17 |
| sean-k-mooney | i mean john and co proved you can do it already with the poc they did so ya you can do it vai nova | 12:19 |
| gibi | if the external service try to preempt any kind of allocation not just servers then I would vote for extending the placement api | 12:20 |
| sean-k-mooney | ya i remember talking to jay an cdent about possible evoltuion of placment to supprot timed allcoation for blazar reservations at one point | 12:21 |
| sean-k-mooney | the concensous at the time was blazar shoudl manage the timing itself at least for now | 12:22 |
| sean-k-mooney | but i have wondered if we ever woudl want to have differnt type fo allcoation in the futrue that had semantic meanign to placemnt | 12:22 |
| sean-k-mooney | consumer types while not an alocation type would provide a way to do that without placment knowing about it | 12:23 |
| gibi | sean-k-mooney: is timed allocation ~= reservation? | 12:23 |
| sean-k-mooney | gibi: yes | 12:23 |
| gibi | yeah that would be an interesting thought experiment | 12:23 |
| gibi | I don't know how alive blazar is these days | 12:24 |
| sean-k-mooney | for now i think im going to leave it there and instead look at your reparenting spec then i need to get back to the smartnic one | 12:24 |
| gibi | there are soo many interesting things to work on :) | 12:26 |
| gibi | thanks for looking at re-parenting | 12:26 |
| *** mgariepy has joined #openstack-nova | 12:26 | |
| *** kaisers has joined #openstack-nova | 12:26 | |
| sean-k-mooney | gibi: for timed allocation to work i think you would need some kind of web hook callback in placment that could call our external events api to tell us it expired but ye i should focus on thing that people are actully working on for a bit | 12:27 |
| gibi | sean-k-mooney: that would be a bit similar to the external event that neutron sends us when a bound port is deleted. nova then unplugs the vif | 12:28 |
| sean-k-mooney | yep that was exactly what i was thinking of | 12:28 |
| gibi | sean-k-mooney: so basically placement would tell us that the allocation is expired and nova would ~delete~ the instaance | 12:28 |
| sean-k-mooney | yep | 12:28 |
| sean-k-mooney | or tell balzar if that is the endpoint you regestred | 12:29 |
| gibi | the delete would be a bit harsh but maybe shelve offload or snapshot would be ok | 12:29 |
| gibi | snapshot + delete | 12:29 |
| sean-k-mooney | basically i was thinging you would pass a url to call back an a payload to send whne cratign the payload | 12:30 |
| * bauzas disappears for a bit | 12:30 | |
| sean-k-mooney | *alloction | 12:30 |
| sean-k-mooney | gibi: not sure if that is a good idea or not but for nova we would make the payload be an extrenal event payload allocation-exired-event possible with an acction or encode the action in a flavor extra spec or image property | 12:31 |
| sean-k-mooney | i had not fully tought though the full semantics but ya that was the general thing i had in mind | 12:32 |
| gibi | sean-k-mooney: yeah these sounds like a workable set of ideas | 12:33 |
| sean-k-mooney | gibi: by the way i hope you dont mind i fast appoved the cyborg admin client spec i notice that you went and fixed the blueprint | 12:35 |
| sean-k-mooney | given the time zone differece i did not think the nits justifed asking them to respin or submit a followup | 12:36 |
| gibi | sean-k-mooney: no problema | 12:38 |
| gibi | sean-k-mooney: I did not notice the missing bp until I tried to approve the bp after I saw the spec merged | 12:38 |
| *** martinkennelly has joined #openstack-nova | 12:39 | |
| opendevreview | Stephen Finucane proposed openstack/os-vif stable/ussuri: [Stable Only] Drop lower constraints testing https://review.opendev.org/c/openstack/os-vif/+/794210 | 12:40 |
| opendevreview | Stephen Finucane proposed openstack/os-vif stable/train: [Stable Only] Drop lower constraints testing https://review.opendev.org/c/openstack/os-vif/+/794211 | 12:41 |
| stephenfin | gibi: lyarwood: Would appreciate eyes on those to unblock the other patches in os-vif ^ | 12:41 |
| stephenfin | that's what we agreed last week, iirc | 12:41 |
| stephenfin | also, sean-k-mooney: ^ | 12:41 |
| * lyarwood clicks | 12:42 | |
| gibi | on it | 12:42 |
| sean-k-mooney | more or less although i didnt end put trying to fix it beyond victoria | 12:42 |
| gibi | stephenfin: note that I have no +2 rights :) | 12:44 |
| stephenfin | oh, lovely | 12:44 |
| * stephenfin still thinks that's madness and we really should change that :-\ | 12:44 | |
| stephenfin | so I guess I need to poke elodilles ? | 12:45 |
| sean-k-mooney | well actully i forgot to bring this up | 12:46 |
| sean-k-mooney | anyone agaisnt me creating an os-vif-release team for stable | 12:46 |
| sean-k-mooney | i would like to be able to do stable review there too | 12:47 |
| sean-k-mooney | i can bring it up on the next nova meeting | 12:47 |
| sean-k-mooney | i ment to do it last week and forgot this week | 12:47 |
| stephenfin | I'd just add core to stable-core, personally. Probably something for the next meeting | 12:47 |
| gibi | I'm not against it, we need agreemet from stable cores though :) | 12:48 |
| sean-k-mooney | i could i wanted to add a new group to not need to add people to nova-stable-maint for os-vif stable | 12:48 |
| lyarwood | yup I'm not against that | 12:48 |
| sean-k-mooney | gibi: im +2 on the reparenting spec too but i did not give +w to allow melwitt and other to review | 12:50 |
| gibi | sean-k-mooney: ack, thanks | 12:50 |
| sean-k-mooney | stephenfin: should you have not cherry picked the stable train patch form stable ussuri | 12:56 |
| stephenfin | no point. It was just merge conflict hell and they're stable only | 12:57 |
| sean-k-mooney | well normally stable only patches would be cherry picked | 12:58 |
| sean-k-mooney | but ok | 12:58 |
| sean-k-mooney | if its generally effectivly a rewrite then ill change the -1 to +1 | 12:59 |
| *** rloo has joined #openstack-nova | 13:13 | |
| *** Luzi has quit IRC | 13:21 | |
| opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Do not destroy volume secrets during _hard_reboot https://review.opendev.org/c/openstack/nova/+/793463 | 13:29 |
| *** abhishekk has joined #openstack-nova | 13:31 | |
| *** abhishekk is now known as akekane|home | 13:32 | |
| *** akekane|home is now known as abhishekk | 13:32 | |
| *** lucasagomes has quit IRC | 13:38 | |
| sean-k-mooney | oh ok | 13:45 |
| sean-k-mooney | i guess its ok to not destroy the secreat for had reboot | 13:46 |
| sean-k-mooney | *hard | 13:46 |
| sean-k-mooney | soft reboot calls hard reboot also by the way if it does not soft reboot after a time out | 13:46 |
| *** lucasagomes has joined #openstack-nova | 13:48 | |
| *** tosky has joined #openstack-nova | 13:54 | |
| *** hemanth_n has quit IRC | 13:57 | |
| *** hemna has quit IRC | 14:16 | |
| *** hemna has joined #openstack-nova | 14:28 | |
| *** opendevreview has quit IRC | 14:38 | |
| mdbooth | sean-k-mooney: Incidentally, I've always felt that was a misfeature. Soft and hard reboots are quite different things. If the user asks for a soft reboot and it doesn't work, they should get an error (asynchronously, obvs). | 14:47 |
| sean-k-mooney | mdbooth: i think its configurable in the nova config | 14:49 |
| sean-k-mooney | https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.reboot_timeout | 14:49 |
| sean-k-mooney | so by default we dont | 14:50 |
| sean-k-mooney | but it can be enabled | 14:50 |
| *** Gue______ is now known as jamesdenton | 14:51 | |
| sean-k-mooney | which is config driveen api behavior which is awesome... | 14:51 |
| sean-k-mooney | mdbooth: i would much prefer a reboot --gradual or somehting like that to contol that | 14:51 |
| *** dklyle has joined #openstack-nova | 14:53 | |
| *** david-lyle has joined #openstack-nova | 14:57 | |
| *** dklyle has quit IRC | 14:57 | |
| *** david-lyle is now known as dklyle | 15:00 | |
| *** hemna has quit IRC | 15:07 | |
| *** luksky has quit IRC | 15:09 | |
| *** hemna has joined #openstack-nova | 15:19 | |
| *** opendevreview has joined #openstack-nova | 15:19 | |
| opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Do not destroy volume secrets during _hard_reboot https://review.opendev.org/c/openstack/nova/+/793463 | 15:19 |
| opendevreview | Lee Yarwood proposed openstack/nova master: virt: Add destroy_secrets kwarg to destroy and cleanup https://review.opendev.org/c/openstack/nova/+/794252 | 15:19 |
| melwitt | lyarwood: added a comment on the launchpad bug wrt wsgi config | 15:21 |
| lyarwood | melwitt: thanks | 15:21 |
| melwitt | sean-k-mooney: the current proposal is to reflect the allocations indirectly via /usages https://review.opendev.org/c/openstack/placement/+/679441/18/api-ref/source/usages.inc and you can filter by project and user | 15:32 |
| melwitt | gibi: ack, will look | 15:33 |
| gibi | melwitt: thanks | 15:33 |
| sean-k-mooney | melwitt: i see ok | 15:33 |
| opendevreview | Merged openstack/nova master: Honor [neutron]http_retries in the manual client https://review.opendev.org/c/openstack/nova/+/793512 | 15:33 |
| bauzas | sean-k-mooney: gibi: oh, just saw your discussion about reservations | 15:36 |
| bauzas | fwiw, blazar already supports timed reservations | 15:36 |
| bauzas | so, the concern here is that we duplicate allocations into blazar-like reservations | 15:36 |
| bauzas | while an idea could be to add timed allocations in placement | 15:36 |
| bauzas | but that's a massive change | 15:37 |
| sean-k-mooney | yes im aware | 15:37 |
| bauzas | the other issue is with quotas | 15:37 |
| sean-k-mooney | yep | 15:37 |
| sean-k-mooney | unified limits would have to understand consumer types and allow qutos per consumer type not just projects | 15:38 |
| bauzas | that's the problem | 15:38 |
| bauzas | blazar would need to support quotas for resources that are different from current quotas | 15:39 |
| melwitt | I'm working on consumer types this cycle fwiw | 15:39 |
| melwitt | just behind on updating the PS from last feedback | 15:39 |
| bauzas | just explaining one of the usecases | 15:39 |
| bauzas | if I have quota for 10 vCPUs | 15:40 |
| bauzas | could I reserve 20 vCPUs over time provided I only start 10 concurrently? | 15:40 |
| bauzas | I could honesly overload resource usage by this | 15:40 |
| bauzas | I could ask for 1000000 vCPUs provided I only have reservations for 10 by once | 15:41 |
| sean-k-mooney | yep i know there are many issue | 15:42 |
| sean-k-mooney | that is why i was suggesting to belmoreira that we proably dont have the design bandwith this cycle for premtibel instances | 15:43 |
| sean-k-mooney | but i think we should consider it for a future cycle and maybe have a sub team to figure this out | 15:43 |
| bauzas | preemptible instances are way simplier to design | 15:44 |
| bauzas | since we don't have reservations | 15:44 |
| bauzas | there are just prioritized instances and non-priortized ones | 15:44 |
| *** david-lyle has joined #openstack-nova | 15:45 | |
| *** dklyle has quit IRC | 15:45 | |
| opendevreview | Merged openstack/os-vif stable/ussuri: [Stable Only] Drop lower constraints testing https://review.opendev.org/c/openstack/os-vif/+/794210 | 15:54 |
| *** alex_xu has quit IRC | 15:57 | |
| *** rm_work has joined #openstack-nova | 16:04 | |
| rm_work | having an issue with the osc-placement==3.0.0 breaking `openstack completion`, is this the place, or does placement have their own channel, or would an sdk/client channel be better? :D | 16:05 |
| rm_work | http://paste.openstack.org/show/806280/ | 16:07 |
| sean-k-mooney | rm_work: ish | 16:10 |
| sean-k-mooney | ah you are using py 3.9.5 | 16:10 |
| sean-k-mooney | techinially that not supported yet | 16:10 |
| rm_work | ah ok, think it's related? | 16:11 |
| rm_work | I can test with 3.8 | 16:11 |
| sean-k-mooney | return self.session.request(url, method, | 16:11 |
| sean-k-mooney | AttributeError: 'NoneType' object has no attribute 'request | 16:11 |
| sean-k-mooney | i wonder if requests has moved somehing in 3.9 | 16:11 |
| rm_work | will try with 3.8.9 | 16:11 |
| rm_work | well, that implies self.session == None | 16:12 |
| rm_work | right? | 16:12 |
| rm_work | which almost makes sense, why would there be a session (or even need to be one) just to get a command list? | 16:12 |
| sean-k-mooney | yes i gues it does | 16:12 |
| *** lucasagomes has quit IRC | 16:13 | |
| sean-k-mooney | the erro is startin gin the client cache | 16:14 |
| sean-k-mooney | https://github.com/openstack/osc-lib/blob/master/osc_lib/clientmanager.py#L45 | 16:14 |
| sean-k-mooney | whcih is a mixin | 16:14 |
| rm_work | hmm yeah most of this code hasn't changed in years | 16:14 |
| sean-k-mooney | the sessin comes form the instance passed ot make_client https://github.com/openstack/osc-placement/blob/master/osc_placement/plugin.py#L29-L43 | 16:17 |
| sean-k-mooney | i wonder if this is a gregression in the api microversion auto negociation code | 16:17 |
| sean-k-mooney | since the failure is comming form inside self.negotiate_api_version(api_version) | 16:18 |
| sean-k-mooney | the auto complete code likely doe snot actully connect to the cloud | 16:19 |
| sean-k-mooney | well it should not connect ot the cloud | 16:19 |
| sean-k-mooney | so the auto complete code will need to handel that | 16:19 |
| sean-k-mooney | stephenfin: gibi ^ | 16:19 |
| sean-k-mooney | i would gues that OSC itself is passing None for the session to osc_placment | 16:21 |
| rm_work | that'd make sense I guess -- not sure what else it could reasonably pass | 16:24 |
| rm_work | and it'd expect the client to deal with that in this case but placement made a different assumption | 16:24 |
| rm_work | though again, not a change on the placement side I think? | 16:24 |
| rm_work | since I can't find any code in osc-placement that has changed since like 2019 lol | 16:24 |
| rm_work | maybe should bring this up in thee client channel | 16:25 |
| sean-k-mooney | we merged that auto negocaation code about last week or the week before | 16:25 |
| rm_work | oh, k | 16:25 |
| rm_work | wait where is that | 16:26 |
| *** bhagyashris_ has joined #openstack-nova | 16:26 | |
| sean-k-mooney | so this is causing the get to rfail https://github.com/openstack/osc-placement/blob/37e47afc88b188a338e3cb70adcf87bac513d4ef/osc_placement/version.py#L142 | 16:27 |
| sean-k-mooney | the allocation endpoing and like all the rest is chanck the api version and seeing if it supprot things | 16:28 |
| sean-k-mooney | File "/Users/rm_work/.pyenv/versions/3.9.5/envs/osc2/lib/python3.9/site-packages/osc_placement/resources/allocation.py", line 90, in get_parser | 16:28 |
| sean-k-mooney | required=self.compare_version(version.ge('1.8')) | 16:28 |
| sean-k-mooney | so the allocation class is using the compare_version mixin | 16:28 |
| gibi | rm_work, sean-k-mooney: I've just confirmed locally that 3.0.0 break the completion, while 2.2.0 still works | 16:28 |
| gibi | so it is pretty likely that the microversion negotiation break it as that is the only thing we merged in 3.0.0 | 16:29 |
| sean-k-mooney | doing obj.app.client_manager.placement.api_version tries to actully connect to placement to do the version negocation | 16:29 |
| sean-k-mooney | which cant work since bash completion will not have your auth details | 16:29 |
| sean-k-mooney | well not the auth deatials but it wont have the cloud endpoint | 16:30 |
| sean-k-mooney | form cloud.yaml | 16:30 |
| rm_work | yeah ideally it should work completely offline (same as "help") | 16:30 |
| sean-k-mooney | this would proably work if you exproted the env vars for the keystone endpoint | 16:30 |
| sean-k-mooney | like the openrc did | 16:30 |
| sean-k-mooney | rm_work: yes it should | 16:31 |
| sean-k-mooney | so here we catrch AttributeError | 16:31 |
| sean-k-mooney | https://github.com/openstack/osc-placement/blob/37e47afc88b188a338e3cb70adcf87bac513d4ef/osc_placement/version.py#L143 | 16:31 |
| sean-k-mooney | but we are rasing exceptions.PluginAttributeError | 16:32 |
| sean-k-mooney | https://github.com/openstack/osc-lib/blob/master/osc_lib/clientmanager.py#L49 | 16:32 |
| *** david-lyle is now known as dklyle | 16:33 | |
| *** mgariepy has quit IRC | 16:33 | |
| sean-k-mooney | really we should just check if we have a session and if not returnt true | 16:33 |
| *** bhagyashris has quit IRC | 16:34 | |
| sean-k-mooney | well | 16:34 |
| sean-k-mooney | if not obj.app.client_manager.session: return SUPPORTED_VERSIONS[0] | 16:35 |
| sean-k-mooney | here https://github.com/openstack/osc-placement/blob/master/osc_placement/version.py#L141 | 16:35 |
| sean-k-mooney | actully maybe SUPPORTED_VERSIONS[-1] would be better | 16:36 |
| sean-k-mooney | we have a choice of assume oldest or newest microversion for completion | 16:36 |
| sean-k-mooney | newset might be best | 16:36 |
| sean-k-mooney | gibi: do you think ^ is a vaild approch | 16:36 |
| gibi | sean-k-mooney: agree, for completion just assume the newest supported | 16:37 |
| sean-k-mooney | rm_work: you could proably work around this by changing the complation command used in bash | 16:38 |
| sean-k-mooney | to pass --os-placment-api-version or whatever that flag is to the openstack client | 16:38 |
| sean-k-mooney | as a tempory hack | 16:38 |
| sean-k-mooney | gibi: actully if you just run "openstack complete" you get "ould not clean up: 'ClientManager' object has no attribute 'sdk_connection'" | 16:40 |
| sean-k-mooney | at the end | 16:40 |
| gibi | that last error comes from 2.2.0 as well | 16:41 |
| gibi | but it does not break completion I think | 16:41 |
| gibi | or is it? | 16:41 |
| rm_work | yeah i've noticed that for a long time, not sure if that's placement related | 16:44 |
| rm_work | and no, it didn't break completion | 16:44 |
| sean-k-mooney | correct it does not but it does point to the fact that this is a general problem with the complete command | 16:45 |
| sean-k-mooney | in at least the cleanup path its trying to unconditonally clean up the sdk connection that is never established | 16:45 |
| rm_work | yeah | 16:46 |
| *** tosky has quit IRC | 16:48 | |
| sean-k-mooney | rm_work: can you try invoking complete but passing --os-cloud | 16:49 |
| rm_work | uhh sure | 16:49 |
| rm_work | I do have OS_CLOUD exported, FWIW | 16:49 |
| sean-k-mooney | oh in that case never mind | 16:49 |
| rm_work | and yeah no difference | 16:50 |
| sean-k-mooney | i was wondering if we told it what cloud to sue woudl the normal auth kick in | 16:50 |
| *** bhagyashris_ is now known as bhagyashris | 16:50 | |
| rm_work | what is an example `--os-placment-api-version` i could try btw | 16:50 |
| rm_work | well, typed a random number and it works | 16:50 |
| rm_work | `openstack complete --os-placement-api-version 1.2` | 16:51 |
| sean-k-mooney | ya caus its disabling the negocation | 16:51 |
| rm_work | yep | 16:51 |
| rm_work | just confirming your theory for that too | 16:51 |
| sean-k-mooney | thats the workaround for now more or less | 16:51 |
| rm_work | ok, LMK if there's something I can help review :) | 16:52 |
| sean-k-mooney | im just going to push something quickly | 16:52 |
| rm_work | i can test whatever locally | 16:52 |
| opendevreview | sean mooney proposed openstack/osc-placement master: [WIP] default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | 16:56 |
| rm_work | some other client actually IS trying to do auth I think... i have to yubi-key to do `openstack complete` lol | 16:57 |
| opendevreview | melanie witt proposed openstack/nova stable/wallaby: Honor [neutron]http_retries in the manual client https://review.opendev.org/c/openstack/nova/+/794186 | 16:57 |
| opendevreview | sean mooney proposed openstack/osc-placement master: [WIP] default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | 16:57 |
| sean-k-mooney | rm_work: ya as i said you would have to specificaly code for this with auto negociation | 16:59 |
| rm_work | hmmm | 16:59 |
| rm_work | `ValueError: invalid version number '1'` | 16:59 |
| rm_work | with your patch | 16:59 |
| rm_work | not sure exactly why | 16:59 |
| rm_work | http://paste.openstack.org/show/806286/ | 17:00 |
| rm_work | logically your fix seems right | 17:00 |
| sean-k-mooney | https://github.com/openstack/osc-placement/blob/master/osc_placement/version.py#L18 | 17:00 |
| sean-k-mooney | it is getting that | 17:00 |
| sean-k-mooney | because of https://github.com/openstack/osc-placement/blob/master/osc_placement/version.py#L52 | 17:00 |
| sean-k-mooney | let me try MAX_VERSION_NO_GAP | 17:00 |
| rm_work | OH yeah I see | 17:01 |
| opendevreview | sean mooney proposed openstack/osc-placement master: [WIP] default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | 17:01 |
| rm_work | I misread SUPPORTED_MICROVERSIONS as SUPPORTED_VERSIONS | 17:01 |
| sean-k-mooney | ya so did i when i wrote it | 17:02 |
| sean-k-mooney | i ment to get the last supported microveris | 17:02 |
| rm_work | k looks good | 17:02 |
| sean-k-mooney | i might change it back to SUPPORTED_MICROVERSIONS[-1] but does that seam to fix it | 17:03 |
| rm_work | this seems like it accomplishes your goal pretty explicitly | 17:03 |
| rm_work | since you wanted ... that | 17:03 |
| rm_work | max version | 17:03 |
| *** kaisers_ has joined #openstack-nova | 17:04 | |
| melwitt | stephenfin: are you interested in +W-ing the placement re-parenting spec? https://review.opendev.org/c/openstack/nova-specs/+/788243 | 17:04 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618 | 17:04 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | 17:04 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request https://review.opendev.org/c/openstack/nova/+/794306 | 17:04 |
| sean-k-mooney | rm_work: ok well i can see if we can turn that into a proper patch with some tests | 17:04 |
| rm_work | well I +1'd | 17:05 |
| rm_work | lol | 17:05 |
| sean-k-mooney | well it work but i want to put a unit test that asssert we dont call the thing that explode when session is None | 17:05 |
| *** kaisers has quit IRC | 17:06 | |
| rm_work | yep, makes sense | 17:06 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | 17:06 |
| *** derekh has quit IRC | 17:06 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | 17:08 |
| *** erbarr has joined #openstack-nova | 17:09 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | 17:13 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | 17:13 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support the new port resource_request format https://review.opendev.org/c/openstack/nova/+/787208 | 17:16 |
| *** ralonsoh has quit IRC | 17:17 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | 17:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | 17:21 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | 17:22 |
| *** abhishekk has quit IRC | 17:30 | |
| opendevreview | sean mooney proposed openstack/osc-placement master: default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | 17:30 |
| rm_work | \o/ | 17:33 |
| sean-k-mooney | lol i broke the docs because thre app is non | 17:35 |
| sean-k-mooney | File "/home/zuul/src/opendev.org/openstack/osc-placement/osc_placement/version.py", line 141, in get_version | 17:35 |
| sean-k-mooney | if obj.app.client_manager.session is None: | 17:35 |
| sean-k-mooney | AttributeError: 'NoneType' object has no attribute 'client_manager' | 17:35 |
| *** mgariepy has joined #openstack-nova | 17:37 | |
| opendevreview | sean mooney proposed openstack/osc-placement master: default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | 17:37 |
| sean-k-mooney | rm_work: ok ^ should be the final patch unless peopel ask for feedback | 17:38 |
| sean-k-mooney | well provide feedback | 17:38 |
| sean-k-mooney | gibi: can you add https://review.opendev.org/c/openstack/osc-placement/+/794276 to your review queue | 17:38 |
| rm_work | would docs not also want latest? | 17:39 |
| sean-k-mooney | maybe | 17:39 |
| rm_work | but, starts to be hard to code for every little case like that when you're basically making an inference about the caller | 17:39 |
| sean-k-mooney | but they were previouly getting the oldest | 17:39 |
| rm_work | not "if for_docs:" | 17:40 |
| rm_work | yeah... | 17:40 |
| sean-k-mooney | i can do this a different way | 17:40 |
| sean-k-mooney | i can catch the other error type | 17:40 |
| sean-k-mooney | PluginAtributeERROR | 17:40 |
| sean-k-mooney | but i dont like that since it actully trys to connect the cloud | 17:41 |
| stephenfin | melwitt: Won't have a chance now (I'm just finishing up) but I think I didn't have any concerns of my own, so if you're happy to +W then go for it :) | 17:41 |
| melwitt | cool, thanks stephenfin | 17:42 |
| sean-k-mooney | rm_work: let me see what the docs are using it for | 17:42 |
| *** erlon has joined #openstack-nova | 17:44 | |
| sean-k-mooney | rm_work: its from cliff/sphinxext.py | 17:48 |
| *** andrewbonney has quit IRC | 17:49 | |
| *** dklyle has quit IRC | 17:49 | |
| rm_work | so not the client auto-doc stuff? | 17:49 |
| rm_work | or that is it | 17:49 |
| *** dklyle has joined #openstack-nova | 17:49 | |
| sean-k-mooney | well kind of | 17:49 |
| sean-k-mooney | its form _generate_nodes_per_command | 17:49 |
| sean-k-mooney | so it is the auto generation of docs for cliff commands | 17:50 |
| sean-k-mooney | previously that was raising an atribute error but we were catching it and returning the oldest version | 17:50 |
| sean-k-mooney | rm_work: lol i may have missed that comment https://review.opendev.org/c/openstack/osc-placement/+/794276/5/osc_placement/version.py#146 | 17:55 |
| sean-k-mooney | that is why the try is there | 17:55 |
| rm_work | heh yeah | 17:56 |
| rm_work | I would say "let's use the maximum one" but that's just me | 17:56 |
| opendevreview | Merged openstack/nova master: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/784166 | 17:57 |
| sean-k-mooney | ya that would be my prefernce too | 17:57 |
| rm_work | might be a bigger change than just "bugfix regression on bash completion" | 17:58 |
| opendevreview | Merged openstack/nova-specs master: Allow provider re-parenting in placement https://review.opendev.org/c/openstack/nova-specs/+/788243 | 17:58 |
| sean-k-mooney | rm_work: ya for now im not going to chagne it | 17:59 |
| sean-k-mooney | but i left a review comment | 17:59 |
| rm_work | yep, left a reply too :D | 18:00 |
| opendevreview | Elod Illes proposed openstack/nova stable/wallaby: [stable-only] Fix ceph install in live migration hook https://review.opendev.org/c/openstack/nova/+/794000 | 18:31 |
| opendevreview | Rodrigo Barbieri proposed openstack/nova stable/wallaby: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/794328 | 18:35 |
| *** luksky has joined #openstack-nova | 19:05 | |
| *** luksky has quit IRC | 19:05 | |
| *** luksky has joined #openstack-nova | 19:05 | |
| *** belmoreira has quit IRC | 19:11 | |
| *** vishalmanchanda has quit IRC | 19:13 | |
| *** kaisers_ has quit IRC | 19:15 | |
| *** kaisers has joined #openstack-nova | 19:16 | |
| *** tosky has joined #openstack-nova | 19:23 | |
| *** slaweq has quit IRC | 20:34 | |
| *** rloo has quit IRC | 20:36 | |
| *** rloo has joined #openstack-nova | 20:36 | |
| *** jparker has joined #openstack-nova | 21:16 | |
| *** david-lyle has joined #openstack-nova | 21:18 | |
| *** dklyle has quit IRC | 21:18 | |
| *** jamesdenton has quit IRC | 21:21 | |
| *** Gues_____ has joined #openstack-nova | 21:23 | |
| *** kaisers has quit IRC | 21:47 | |
| opendevreview | melanie witt proposed openstack/nova stable/wallaby: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794345 | 22:13 |
| tosky | melwitt: crossing fingers :) | 22:32 |
| melwitt | :) | 22:33 |
| *** luksky has quit IRC | 22:35 | |
| *** tosky has quit IRC | 23:25 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!