| *** tosky has quit IRC | 00:04 | |
| openstackgerrit | Ghanshyam proposed openstack/placement master: Remove deprecated [placement]/policy_file config option https://review.opendev.org/c/openstack/placement/+/764409 | 00:13 |
|---|---|---|
| openstackgerrit | Ghanshyam proposed openstack/placement master: [goal] Deprecate the JSON formatted policy file https://review.opendev.org/c/openstack/placement/+/764394 | 00:13 |
| gmann | gibi: bauzas stephenfin please check these two placement patches also. for json->yaml migration community goal. https://review.opendev.org/c/openstack/placement/+/764409 https://review.opendev.org/c/openstack/placement/+/764394 | 00:15 |
| gmann | 764409 is to remove the deprecated policy_file config option which is needed for this migration | 00:16 |
| *** sapd1 has quit IRC | 00:32 | |
| brinzhang | gibi, bauzas, sean-k-mooney: Since Microversion 2.77, we support specifying an avaiability_zone to unshleve an instance, it allowed {'unshelve': null} and {'unshelve': {'availability_zone': <string>}}, but we restrict the empty dict {'unshelve': {}} as the request body for unshelve. this restrict asked by gmann in https://review.opendev.org/c/openstack/nova/+/663851/16/nova/api/openstack/compute/schemas/servers.py#663 | 00:56 |
| brinzhang | gibi, bauzas, sean-k-mooney, gmann: this is the record https://review.opendev.org/c/openstack/nova/+/663851/13/nova/api/openstack/compute/schemas/servers.py#659 | 00:57 |
| *** macz_ has quit IRC | 00:58 | |
| gmann | brinzhang: yeah as this action API need specific request body so disallow empty make sense. for other action API there is no specific request body so allowing null or anything is what we have during legacy way | 00:59 |
| brinzhang | and we note that in https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/shelve.py#L28-L31 | 00:59 |
| brinzhang | gmann: yes, I think gibi and bauzas's concern in the docs description, because of the availability_zone is optional, but we allowed request {'unshelve': {'availability_zone': <string>}}, if we dont chose the availability_zone, it will be {'unshelve': {} | 01:02 |
| gmann | ok and we only allow {'unshelve': null} in that case | 01:03 |
| *** LinPeiWen has joined #openstack-nova | 01:04 | |
| gmann | brinzhang: may be we can update it in api-ref too https://docs.openstack.org/api-ref/compute/?expanded=unshelve-restore-shelved-server-unshelve-action-detail | 01:04 |
| brinzhang | yes, I think this is reasonable too | 01:04 |
| gmann | saying 2.77 onwards | 01:05 |
| brinzhang | gmann: ok, let submit a patch to add a Note for the availability_zone | 01:05 |
| brinzhang | s/let/ let me | 01:06 |
| gmann | +1 | 01:06 |
| brinzhang | Will do, and pls review it later | 01:06 |
| gmann | thanks | 01:08 |
| *** rcernin_ has joined #openstack-nova | 01:09 | |
| *** rcernin has quit IRC | 01:10 | |
| brinzhang | gmann: how abot saying: Since microversion 2.77, we are allowed to request {'unshelve': null} and {'unshelve': {'availability_zone': <string>}}, but not allowed to request {'unshelve': {}}. | 01:12 |
| gmann | brinzhang: yeah, little modification- Since microversion 2.77, allowed request body schema are {'unshelve': null} or {'unshelve': {'availability_zone': <string>}}, and {'unshelve': {}} request body is not allowed. | 01:16 |
| *** mlavalle has quit IRC | 01:30 | |
| *** _mlavalle_1 has joined #openstack-nova | 01:30 | |
| brinzhang | gmann: and let me register a bug to trace this change | 01:31 |
| sean-k-mooney | gmann: brinzhang we were suggesting allowing {} ealier today | 01:32 |
| sean-k-mooney | i think its perfectly consitent to treat null and {} the same | 01:33 |
| gmann | sean-k-mooney: {} means allowed everything or any unknown request body which is later ignored so confusing for users. where {'unshelve': null} means allow only empty request body | 01:35 |
| gmann | sean-k-mooney: like for {}. i can pass {'unshelve': {'unknown': 'anything', ....}} | 01:35 |
| gmann | that was the reason we thought of improving it in 2.77 | 01:36 |
| *** k_mouza has joined #openstack-nova | 01:36 | |
| *** JamesBenson has quit IRC | 01:39 | |
| *** kevinz has joined #openstack-nova | 01:40 | |
| *** k_mouza has quit IRC | 01:41 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Improving the description for az of unshleve API https://review.opendev.org/c/openstack/nova/+/767251 | 01:50 |
| brinzhang | sean-k-mooney: yeah, I agree with gmann, while I do the change of specifying az to unshelve a server, already talked, also with mriedem | 01:51 |
| *** hoonetorg has quit IRC | 01:52 | |
| brinzhang | gmann: done, pls review https://review.opendev.org/c/openstack/nova/+/767251 | 01:52 |
| *** spatel has joined #openstack-nova | 01:59 | |
| *** hoonetorg has joined #openstack-nova | 02:03 | |
| *** artom has quit IRC | 02:12 | |
| *** dasp has quit IRC | 02:20 | |
| *** dasp has joined #openstack-nova | 02:21 | |
| *** hemanth_n has joined #openstack-nova | 02:26 | |
| *** benj_- has joined #openstack-nova | 02:35 | |
| *** benj_ has quit IRC | 02:35 | |
| *** benj_- is now known as benj_ | 02:35 | |
| *** LinPeiWen has quit IRC | 02:45 | |
| *** rcernin_ has quit IRC | 02:46 | |
| openstackgerrit | Merged openstack/nova master: Refactoring of functional.regression.test_bug_1702454 https://review.opendev.org/c/openstack/nova/+/765997 | 02:47 |
| *** macz_ has joined #openstack-nova | 02:55 | |
| *** mgoddard has quit IRC | 02:58 | |
| *** macz_ has quit IRC | 03:00 | |
| *** LinPeiWen has joined #openstack-nova | 03:05 | |
| *** songwenping__ has joined #openstack-nova | 03:12 | |
| *** songwenping_ has quit IRC | 03:16 | |
| *** sapd1 has joined #openstack-nova | 03:23 | |
| *** jamesden_ has quit IRC | 03:29 | |
| *** sapd1 has quit IRC | 03:35 | |
| *** gyee has quit IRC | 03:43 | |
| *** macz_ has joined #openstack-nova | 03:46 | |
| *** macz_ has quit IRC | 03:50 | |
| *** littleboyfury has joined #openstack-nova | 03:58 | |
| *** ociuhandu has joined #openstack-nova | 04:13 | |
| *** ociuhandu has quit IRC | 04:17 | |
| *** JamesBenson has joined #openstack-nova | 04:24 | |
| *** JamesBenson has quit IRC | 04:28 | |
| *** JamesBenson has joined #openstack-nova | 04:29 | |
| *** littleboyfury has quit IRC | 04:32 | |
| *** k_mouza has joined #openstack-nova | 04:48 | |
| *** k_mouza has quit IRC | 04:53 | |
| *** sapd1 has joined #openstack-nova | 05:00 | |
| *** vishalmanchanda has joined #openstack-nova | 05:02 | |
| *** hamalq_ has quit IRC | 05:16 | |
| *** sapd1 has quit IRC | 05:17 | |
| *** JamesBenson has quit IRC | 05:29 | |
| *** JamesBenson has joined #openstack-nova | 05:30 | |
| *** JamesBenson has quit IRC | 05:30 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-nova | 05:33 | |
| *** JamesBenson has joined #openstack-nova | 05:35 | |
| *** spatel has quit IRC | 05:36 | |
| *** zzzeek has quit IRC | 05:39 | |
| *** JamesBenson has quit IRC | 05:39 | |
| *** zzzeek has joined #openstack-nova | 05:39 | |
| *** zzzeek has quit IRC | 05:46 | |
| *** zzzeek has joined #openstack-nova | 05:48 | |
| *** ratailor has joined #openstack-nova | 05:49 | |
| *** zzzeek has quit IRC | 06:02 | |
| *** zzzeek has joined #openstack-nova | 06:06 | |
| openstackgerrit | Wenping Song proposed openstack/nova master: Resume accelerator guest state when a host is booted https://review.opendev.org/c/openstack/nova/+/767273 | 06:11 |
| *** zzzeek has quit IRC | 07:40 | |
| *** zzzeek has joined #openstack-nova | 07:41 | |
| *** dklyle has quit IRC | 07:41 | |
| *** ociuhandu has joined #openstack-nova | 07:50 | |
| *** zzzeek has quit IRC | 07:53 | |
| *** ociuhandu has quit IRC | 07:54 | |
| *** zzzeek has joined #openstack-nova | 07:55 | |
| *** slaweq has joined #openstack-nova | 08:00 | |
| *** teoobo_ has joined #openstack-nova | 08:04 | |
| *** andrewbonney has joined #openstack-nova | 08:07 | |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/ussuri: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765967 | 08:10 |
| *** tesseract has joined #openstack-nova | 08:15 | |
| openstackgerrit | Merged openstack/placement master: Fix l-c job and move to latest hacking 4.0.0 https://review.opendev.org/c/openstack/placement/+/766994 | 08:16 |
| *** rpittau|afk is now known as rpittau | 08:18 | |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/train: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765970 | 08:20 |
| gibi | brinzhang, gmann: thanks for the historical context on unshelve: {} | 08:22 |
| gibi | so the goal was to only allow unshelve:null but not unshelve:{'unknow': ''} but this still not mean we have to forbid unshelve:{} | 08:23 |
| *** ociuhandu has joined #openstack-nova | 08:31 | |
| *** zzzeek has quit IRC | 08:31 | |
| *** tosky has joined #openstack-nova | 08:33 | |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/stein: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765974 | 08:33 |
| *** zzzeek has joined #openstack-nova | 08:34 | |
| *** zzzeek has quit IRC | 08:39 | |
| *** zzzeek has joined #openstack-nova | 08:41 | |
| *** jawad_axd has joined #openstack-nova | 08:43 | |
| *** mgoddard has joined #openstack-nova | 08:46 | |
| *** ociuhandu has quit IRC | 08:51 | |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/rocky: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765977 | 08:56 |
| *** zzzeek has quit IRC | 08:59 | |
| *** zzzeek has joined #openstack-nova | 09:00 | |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/queens: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765983 | 09:00 |
| gibi | I think what what brinzhang proposed in the comment of https://review.opendev.org/c/openstack/nova/+/663851/13/nova/api/openstack/compute/schemas/servers.py#659 allows unshelve: {}, unshelve:{"availability_zone": "foo"}, unshelve: null, but forbid unshelve: {"foo": "bar"} | 09:01 |
| gibi | bauzas: you too ^^ | 09:01 |
| gibi | which I think what is bauzas after | 09:02 |
| *** zzzeek has quit IRC | 09:05 | |
| brinzhang | gibi: yes, that what I want to do privous, but after talked with gmann and mriedem, I was restrict the unshelve:{} request after PS13 | 09:05 |
| *** mgoddard has quit IRC | 09:06 | |
| *** zzzeek has joined #openstack-nova | 09:06 | |
| gibi | brinzhang: I see that gmann requested the restriction of unshelve: {}, | 09:06 |
| gibi | I don't see mriedem requesting that though | 09:07 |
| *** mgoddard has joined #openstack-nova | 09:07 | |
| gibi | gmann: could you elaborate on 01:59 < gmann> brinzhang: yeah as this action API need specific request body so disallow empty | 09:07 |
| brinzhang | maybe talked in IRC, sorry, I dont have the cleayly remember | 09:07 |
| gibi | make sense. for other action API there is no specific request body so allowing | 09:07 |
| gibi | null or anything is what we have during legacy way | 09:08 |
| gibi | gmann: what do you mean by specific request body? how this is differ from the lock action? | 09:08 |
| gibi | brinzhang: no worries, we have gmann to help :) | 09:08 |
| gibi | (it is just the timezone differences that will make it hard to get a decisions) | 09:08 |
| brinzhang | gibi: and Isubmit a patch for update the description of unshleve az parameter https://review.opendev.org/c/openstack/nova/+/767251 | 09:09 |
| *** zzzeek has quit IRC | 09:11 | |
| *** zzzeek has joined #openstack-nova | 09:14 | |
| *** adrian-a has joined #openstack-nova | 09:17 | |
| *** derekh has joined #openstack-nova | 09:18 | |
| *** zzzeek has quit IRC | 09:23 | |
| *** aarents has quit IRC | 09:24 | |
| *** zzzeek has joined #openstack-nova | 09:25 | |
| elod | lyarwood if you have a minute: can you hit this one? >>> https://review.opendev.org/c/openstack/nova/+/766497 (bandit 1.7.0 is not yet yanked, so maybe it's worth to push the bandit cap fixes, too... though that's also not a quick fix...) | 09:28 |
| *** adrian-a has quit IRC | 09:29 | |
| elod | the swift side has already merged | 09:29 |
| *** adrian-a has joined #openstack-nova | 09:30 | |
| *** jawad_axd has quit IRC | 09:30 | |
| *** jawad_axd has joined #openstack-nova | 09:30 | |
| *** vishalmanchanda has quit IRC | 09:36 | |
| *** zzzeek has quit IRC | 09:41 | |
| lyarwood | elod: ACK'd lets do this | 09:41 |
| * lyarwood -> coffee | 09:41 | |
| *** zzzeek has joined #openstack-nova | 09:42 | |
| *** tosky_ has joined #openstack-nova | 09:47 | |
| *** tosky is now known as Guest24372 | 09:49 | |
| *** tosky_ is now known as tosky | 09:49 | |
| *** Guest24372 has quit IRC | 09:50 | |
| bauzas | gibi: morning, saw your pings with brinzhang | 09:53 |
| gibi | lyarwood: about the lower contraint jobs, after elod summarized the situation to me as a nova PTL I think if we got blocked on the lower constraints jobs and we have no time to fix it then make it non-voting and ask the help of the deployers relying on that job to fix it | 09:54 |
| elod | and just an addition: lower-constraints jobs are (mostly) fixed, so this ^^^ is only valid for the future I think | 09:56 |
| elod | lyarwood: thx \o/ | 09:56 |
| *** zzzeek has quit IRC | 09:57 | |
| *** lpetrut has joined #openstack-nova | 09:57 | |
| *** zzzeek has joined #openstack-nova | 09:58 | |
| bauzas | does anyone know how to fix a blank page from Zuul with Firefox ? | 09:59 |
| bauzas | it does work fine with Chrome | 09:59 |
| bauzas | and I flushed cookes | 09:59 |
| bauzas | cookies* | 09:59 |
| *** dtantsur|afk is now known as dtantsur | 09:59 | |
| gibi | bauzas: havn't seen that problem yet in my firefox | 10:00 |
| bauzas | that's weird | 10:00 |
| bauzas | I get the 200s | 10:00 |
| bauzas | but looks like javascript is blocked or something like this | 10:00 |
| bauzas | ah, gotcha | 10:01 |
| bauzas | got a console exception | 10:01 |
| bauzas | Exception { name: "NS_ERROR_FILE_CORRUPTED", message: "", result: 2152857611, filename: "https://zuul.opendev.org/static/js/main.a8854164.chunk.js" | 10:01 |
| bauzas | gibi: could you try refreshing your local cache ? | 10:02 |
| bauzas | anyhow, the gate looks busted | 10:02 |
| gibi | let me check in a private mode | 10:02 |
| bauzas | all the jobs are in "queued" state | 10:03 |
| gibi | bauzas: this openes for me in a private mode or in an empty firefox profile https://zuul.opendev.org/t/openstack/build/fce6478a6842495f851b8c88336f0049/log/compute1/logs/screen-c-vol.txt | 10:03 |
| bauzas | super weirdo | 10:04 |
| gibi | there are jobs running https://zuul.opendev.org/t/openstack/status | 10:05 |
| bauzas | gibi: could you please tell me which main.js version you have ? | 10:05 |
| gibi | but we have 155 check queu | 10:05 |
| bauzas | mine https://zuul.opendev.org/static/js/main.a8854164.chunk.js is failing | 10:05 |
| gibi | bauzas: on which page? | 10:05 |
| gibi | I have this https://zuul.opendev.org/static/js/main.67746290.chunk.js | 10:05 |
| bauzas | not the same version | 10:06 |
| gibi | I'm not even sure it is them same main | 10:06 |
| gibi | who knows | 10:06 |
| *** vishalmanchanda has joined #openstack-nova | 10:07 | |
| bauzas | gibi: this JS was loaded on https://zuul.opendev.org/t/openstack/build/fce6478a6842495f851b8c88336f0049/log/compute1/logs/screen-c-vol.txt | 10:08 |
| gibi | I have this as well https://zuul.opendev.org/static/js/main.a8854164.chunk.js | 10:08 |
| gibi | in another pag | 10:08 |
| gibi | e | 10:08 |
| bauzas | which FF version ? | 10:08 |
| bauzas | mine is 83.0 | 10:08 |
| gibi | 83.0 (64-bit) | 10:09 |
| bauzas | and the check pipeline is super late, indeed | 10:09 |
| bauzas | ergh | 10:09 |
| bauzas | i'm then confused | 10:09 |
| bauzas | ok, restarted FF and now it works... | 10:10 |
| bauzas | what the heck | 10:10 |
| bauzas | sorry for the noise | 10:10 |
| bauzas | anyway, as I said, zuul is slow this morning | 10:10 |
| bauzas | I sent https://review.opendev.org/c/openstack/nova/+/749068/ to gerrit yesterday, but no jobs run yet | 10:11 |
| *** zzzeek has quit IRC | 10:13 | |
| *** zzzeek has joined #openstack-nova | 10:14 | |
| * bauzas runs off | 10:14 | |
| *** aarents has joined #openstack-nova | 10:22 | |
| *** jangutter has joined #openstack-nova | 10:22 | |
| openstackgerrit | Wenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client https://review.opendev.org/c/openstack/nova-specs/+/740184 | 10:25 |
| *** jangutter_ has quit IRC | 10:26 | |
| *** lbragstad has quit IRC | 10:31 | |
| *** lbragstad has joined #openstack-nova | 10:31 | |
| *** ociuhandu has joined #openstack-nova | 10:41 | |
| *** JamesBenson has joined #openstack-nova | 10:42 | |
| *** ociuhandu_ has joined #openstack-nova | 10:44 | |
| *** zzzeek has quit IRC | 10:44 | |
| *** ociuhandu_ has quit IRC | 10:46 | |
| *** JamesBenson has quit IRC | 10:47 | |
| *** zzzeek has joined #openstack-nova | 10:47 | |
| *** ociuhandu_ has joined #openstack-nova | 10:47 | |
| *** ociuhandu has quit IRC | 10:47 | |
| *** jangutter_ has joined #openstack-nova | 10:49 | |
| *** jangutter has quit IRC | 10:50 | |
| *** ociuhandu_ has quit IRC | 10:52 | |
| *** ociuhandu has joined #openstack-nova | 10:52 | |
| *** ociuhandu has quit IRC | 10:53 | |
| *** tkajinam has quit IRC | 10:54 | |
| *** zzzeek has quit IRC | 11:07 | |
| *** k_mouza has joined #openstack-nova | 11:08 | |
| *** zzzeek has joined #openstack-nova | 11:09 | |
| *** artom has joined #openstack-nova | 11:13 | |
| *** macz_ has joined #openstack-nova | 11:18 | |
| *** JamesBenson has joined #openstack-nova | 11:20 | |
| *** macz_ has quit IRC | 11:23 | |
| *** JamesBenson has quit IRC | 11:25 | |
| sean-k-mooney | gmann: no i was suggest allowing explictly {} so null or empty dict | 11:32 |
| sean-k-mooney | allowing {} does not meant allowing anytihng | 11:33 |
| *** zzzeek has quit IRC | 11:41 | |
| *** zzzeek has joined #openstack-nova | 11:44 | |
| *** jangutter_ is now known as jangutter | 11:46 | |
| *** raildo has joined #openstack-nova | 11:53 | |
| *** ociuhandu has joined #openstack-nova | 11:55 | |
| *** zzzeek has quit IRC | 11:55 | |
| *** tbachman has joined #openstack-nova | 11:57 | |
| *** zzzeek has joined #openstack-nova | 11:57 | |
| *** ociuhandu has quit IRC | 11:59 | |
| *** JamesBenson has joined #openstack-nova | 12:00 | |
| *** mgariepy has quit IRC | 12:02 | |
| *** JamesBenson has quit IRC | 12:03 | |
| *** JamesBenson has joined #openstack-nova | 12:04 | |
| *** zzzeek has quit IRC | 12:11 | |
| *** k_mouza has quit IRC | 12:13 | |
| *** ratailor has quit IRC | 12:13 | |
| *** sapd1 has joined #openstack-nova | 12:13 | |
| *** k_mouza has joined #openstack-nova | 12:13 | |
| *** zzzeek has joined #openstack-nova | 12:13 | |
| *** songwenping__ has quit IRC | 12:17 | |
| *** brinzhang_ has joined #openstack-nova | 12:17 | |
| *** songwenping__ has joined #openstack-nova | 12:17 | |
| *** k_mouza has quit IRC | 12:17 | |
| *** zzzeek has quit IRC | 12:18 | |
| *** LinPeiWen has quit IRC | 12:20 | |
| *** zzzeek has joined #openstack-nova | 12:20 | |
| *** brinzhang has quit IRC | 12:21 | |
| *** k_mouza has joined #openstack-nova | 12:29 | |
| *** zzzeek has quit IRC | 12:31 | |
| *** zzzeek has joined #openstack-nova | 12:32 | |
| *** ociuhandu has joined #openstack-nova | 12:58 | |
| *** hemanth_n has quit IRC | 13:03 | |
| *** mgariepy has joined #openstack-nova | 13:09 | |
| *** ociuhandu has quit IRC | 13:12 | |
| *** ociuhandu has joined #openstack-nova | 13:13 | |
| openstackgerrit | Merged openstack/nova stable/pike: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/nova/+/766497 | 13:14 |
| *** teoobo_ has quit IRC | 13:15 | |
| *** ociuhandu has quit IRC | 13:18 | |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Bump oslo.log version to 4.3.0 https://review.opendev.org/c/openstack/placement/+/760229 | 13:18 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Pass context objects to oslo.policy directly https://review.opendev.org/c/openstack/placement/+/766785 | 13:18 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 13:18 |
| openstackgerrit | Andrew Bonney proposed openstack/nova master: Fix URL construction for 'nova-manage placement audit' https://review.opendev.org/c/openstack/nova/+/767348 | 13:20 |
| *** ociuhandu has joined #openstack-nova | 13:21 | |
| *** spatel has joined #openstack-nova | 13:22 | |
| *** ociuhandu has quit IRC | 13:24 | |
| *** ociuhandu has joined #openstack-nova | 13:24 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _claim_pci_device_for_interface_attach to prepare for qos https://review.opendev.org/c/openstack/nova/+/756895 | 13:27 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow extending an existing instance allocation https://review.opendev.org/c/openstack/nova/+/757109 | 13:28 |
| *** brinzhang_ has quit IRC | 13:29 | |
| *** brinzhang_ has joined #openstack-nova | 13:29 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make remove allocation symmetric with add allocation https://review.opendev.org/c/openstack/nova/+/757110 | 13:30 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out port resource deallocation https://review.opendev.org/c/openstack/nova/+/757111 | 13:31 |
| *** k_mouza has quit IRC | 13:31 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/c/openstack/nova/+/757614 | 13:33 |
| *** zzzeek has quit IRC | 13:34 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support interface attach with qos ports https://review.opendev.org/c/openstack/nova/+/756530 | 13:34 |
| *** zzzeek has joined #openstack-nova | 13:36 | |
| *** k_mouza has joined #openstack-nova | 13:37 | |
| openstackgerrit | Adit Sarfaty proposed openstack/nova master: Retry on vmware create_vm when it fails https://review.opendev.org/c/openstack/nova/+/764586 | 13:37 |
| *** zzzeek has quit IRC | 13:45 | |
| *** nweinber has joined #openstack-nova | 13:48 | |
| *** zzzeek has joined #openstack-nova | 13:49 | |
| *** ociuhandu has quit IRC | 13:54 | |
| *** lbragstad has quit IRC | 13:54 | |
| *** lbragstad has joined #openstack-nova | 13:57 | |
| *** lbragstad has quit IRC | 13:57 | |
| *** lbragstad has joined #openstack-nova | 13:58 | |
| *** liuyulong has joined #openstack-nova | 13:59 | |
| *** lbragstad_ has joined #openstack-nova | 14:03 | |
| *** ociuhandu has joined #openstack-nova | 14:04 | |
| *** ociuhandu has quit IRC | 14:05 | |
| *** ociuhandu has joined #openstack-nova | 14:05 | |
| *** lbragstad has quit IRC | 14:05 | |
| *** ociuhandu has quit IRC | 14:08 | |
| *** ociuhandu has joined #openstack-nova | 14:09 | |
| *** ociuhandu has quit IRC | 14:29 | |
| *** brinzhang_ has quit IRC | 14:31 | |
| *** brinzhang_ has joined #openstack-nova | 14:32 | |
| *** ociuhandu has joined #openstack-nova | 14:40 | |
| openstackgerrit | Elod Illes proposed openstack/nova stable/queens: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/nova/+/767364 | 14:43 |
| *** ociuhandu has quit IRC | 14:51 | |
| *** belmoreira has joined #openstack-nova | 15:01 | |
| *** zzzeek has quit IRC | 15:06 | |
| *** zzzeek has joined #openstack-nova | 15:08 | |
| *** spatel has quit IRC | 15:09 | |
| *** ralonsoh has quit IRC | 15:15 | |
| *** ralonsoh has joined #openstack-nova | 15:15 | |
| openstackgerrit | sean mooney proposed openstack/nova master: only wait for plugtime events in pre-live-migration https://review.opendev.org/c/openstack/nova/+/767368 | 15:19 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow extending an existing instance allocation https://review.opendev.org/c/openstack/nova/+/757109 | 15:22 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make remove allocation symmetric with add allocation https://review.opendev.org/c/openstack/nova/+/757110 | 15:22 |
| *** lpetrut has quit IRC | 15:23 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out port resource deallocation https://review.opendev.org/c/openstack/nova/+/757111 | 15:23 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/c/openstack/nova/+/757614 | 15:23 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support interface attach with qos ports https://review.opendev.org/c/openstack/nova/+/756530 | 15:26 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/report.py https://review.opendev.org/c/openstack/nova/+/765152 | 15:29 |
| *** tbachman has quit IRC | 15:30 | |
| *** tbachman has joined #openstack-nova | 15:30 | |
| gibi | stephenfin: fixed your comments in the qos series | 15:35 |
| gibi | also I finished the main patch https://review.opendev.org/c/openstack/nova/+/756530 | 15:35 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove unused Instance method https://review.opendev.org/c/openstack/nova/+/757615 | 15:37 |
| *** ociuhandu has joined #openstack-nova | 15:41 | |
| *** liuyulong has quit IRC | 15:42 | |
| *** _mlavalle_1 has quit IRC | 15:46 | |
| *** adrian-a has quit IRC | 15:52 | |
| *** ociuhandu has quit IRC | 15:53 | |
| *** k_mouza has quit IRC | 15:53 | |
| *** k_mouza has joined #openstack-nova | 15:54 | |
| *** macz_ has joined #openstack-nova | 16:04 | |
| *** mgariepy has quit IRC | 16:04 | |
| *** ociuhandu has joined #openstack-nova | 16:08 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1907522 in functional test https://review.opendev.org/c/openstack/nova/+/766791 | 16:12 |
| openstack | bug 1907522 in OpenStack Compute (nova) "test_*_with_qos_min_bw_allocation fails in the nova-multi-cell job with: nova.exception.MigrationPreCheckError: Migration pre-check error: Failed to create port bindings for host <host>" [High,In progress] https://launchpad.net/bugs/1907522 - Assigned to Balazs Gibizer (balazs-gibizer) | 16:12 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fallback to same-cell resize with qos ports https://review.opendev.org/c/openstack/nova/+/766925 | 16:13 |
| gibi | stephenfin: and fixued up this as well ^^ | 16:15 |
| *** mlavalle has joined #openstack-nova | 16:16 | |
| gmann | gibi: for specific budy I mean, rest of the action APIs like lock does not take any parameter in request body so they are allowed everything since legacy time. But in unshelve API, 2.77 version added AZ to be a valid param in request body so in this action API we said if user can pass AZ as valid param then let's allow null or AZ only and block everything else. | 16:17 |
| gibi | gmann: lock takes a lock_reason optionally similarly how unshelve takes AZ optionally | 16:17 |
| gibi | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/lock_server.py | 16:18 |
| gmann | gibi: ah yeah, we have not added 'locked_reason' as required. | 16:21 |
| gibi | we not added AZ as required either | 16:21 |
| gmann | gibi: so we can pass anything in cok API like lock: {'unknown': 'unknown'} | 16:22 |
| gibi | no you cannot | 16:22 |
| gibi | as additionalProperties false | 16:22 |
| gmann | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/shelve.py#L31 | 16:22 |
| gmann | here it is ^^ | 16:22 |
| gmann | that required is specially to block the empty dict so that we can have more strict shcema. | 16:23 |
| gmann | let me check comments again if any other reason | 16:23 |
| gibi | gmann: but why we need more sticter schema? | 16:23 |
| *** jawad_axd has quit IRC | 16:23 | |
| gibi | the meaning of unshelve: {} and unshelve: null is the same from the impl perspective (except the schema) | 16:24 |
| gmann | gibi: schema main idea is to have a very strict checks so that user will only be able to pass the usable parameters and everything else will be 400 | 16:24 |
| gibi | sure, I'm OK not to allow 'unknown':'unknown' | 16:25 |
| gibi | what I see that our API acceptr "<action>":{} and "<action>": null in mot of the cases but not for unshelve | 16:26 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: stabilize unit test asserting log https://review.opendev.org/c/openstack/nova/+/764796 | 16:29 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: stabilize set_host libvirt driver unit test https://review.opendev.org/c/openstack/nova/+/764797 | 16:31 |
| gmann | gibi: this was the original discussion on disallow the {} and make it more strict like pass None or AZ. - https://review.opendev.org/c/openstack/nova/+/663851/34/nova/api/openstack/compute/schemas/servers.py#695 | 16:38 |
| gmann | gibi: that time we did not update api-ref for that | 16:39 |
| gmann | I personally did not see passing or allowing {} is more easy or ok than None | 16:39 |
| *** mgariepy has joined #openstack-nova | 16:41 | |
| gibi | but now has two different type of server action API, the unshelve where {} is disallowed and other actions where {} is allowed | 16:42 |
| gibi | for me the meaning of null and {} are the same | 16:42 |
| gibi | so unshelve now seems special, and I guess this was why bauzas was surprised | 16:43 |
| bauzas | gibi: also the fact that we changed the behaviour between 2.1 and 2.77 | 16:44 |
| bauzas | even if that's a microversion | 16:44 |
| gibi | so in pre 2.77 {} is OK but later it is disallowed? | 16:44 |
| gibi | that also feels a bit unnecesserly hars for the users | 16:45 |
| gmann | yeah there is no change for pre-277 | 16:45 |
| gibi | the meaning of {} pre 2.77 is the same as null. And we could keep this meaning after 2.77 but we chose to change it | 16:45 |
| gmann | for all other action except lock afrer 2.52 and unshelve after277, everything is allowed. | 16:45 |
| gmann | bauzas: pre 2.77 there is no change, you can pass {} or any unknown param | 16:46 |
| gmann | bauzas: gibi all action APIs does not use schema so they accept anything in request body and we improved that in lock and unshelve action as they started accepting request body. where two different pattern were selected for both of these APIs. in latest which is 2.77 unshelve we started disallow {} too | 16:48 |
| bauzas | gmann: gibi: sorry, on a meeting | 16:48 |
| bauzas | but yeah, {} was accepted before 2.77 and now not | 16:48 |
| gmann | I cannot say which one is more correct but I think disallowing {} make is more specific | 16:48 |
| *** ociuhandu_ has joined #openstack-nova | 16:49 | |
| *** markguz_ has joined #openstack-nova | 16:50 | |
| gibi | from api user perspective who is upgrading from pre 2.77 to 2.77 the new schema is overly restrictive for no good reason (from the api user perspective) | 16:50 |
| gibi | if we have technical reasons then fine, but I don't see any usability reasons to disallow {} | 16:51 |
| *** ociuhandu has quit IRC | 16:52 | |
| *** dklyle has joined #openstack-nova | 16:52 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Optionally prevent nova-compute start with DB credentials https://review.opendev.org/c/openstack/nova/+/762176 | 16:53 |
| gibi | can some core other than stephen look at this simple revert https://review.opendev.org/c/openstack/nova/+/755995 it re-enables a good chunk of test coverage | 16:53 |
| *** ociuhandu has joined #openstack-nova | 16:53 | |
| bauzas | gibi: I'll do | 16:53 |
| gibi | thanks | 16:53 |
| bauzas | but then I need to leave | 16:53 |
| bauzas | done | 16:54 |
| gibi | bauzas: thanks. | 16:55 |
| gibi | I need to leave soon too | 16:55 |
| * bauzas leaves | 16:55 | |
| bauzas | (taxi dad) | 16:55 |
| gibi | o/ | 16:55 |
| *** ociuhandu_ has quit IRC | 16:57 | |
| openstackgerrit | Ghanshyam proposed openstack/placement master: Remove deprecated [placement]/policy_file config option https://review.opendev.org/c/openstack/placement/+/764409 | 16:57 |
| gmann | gibi: ^^ updated this | 16:57 |
| gibi | gmann: looking | 16:58 |
| *** ralonsoh is now known as ralonsoh|afk | 17:00 | |
| *** ociuhandu_ has joined #openstack-nova | 17:02 | |
| gibi | gmann: replied about the new init parameter | 17:02 |
| gmann | checking | 17:04 |
| *** ociuhandu has quit IRC | 17:05 | |
| gmann | gibi: yeah, we can remove that as it was just for testing things and pick of policy file is on oslo side now | 17:06 |
| gmann | updating | 17:06 |
| gibi | thanks | 17:06 |
| *** ociuhandu_ has quit IRC | 17:07 | |
| *** gyee has joined #openstack-nova | 17:07 | |
| openstackgerrit | Ghanshyam proposed openstack/placement master: Remove deprecated [placement]/policy_file config option https://review.opendev.org/c/openstack/placement/+/764409 | 17:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use the non polling notification waiter in func test https://review.opendev.org/c/openstack/nova/+/758445 | 17:10 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Create a fixture around fake_notifier https://review.opendev.org/c/openstack/nova/+/758446 | 17:10 |
| gmann | gibi: done ^^ | 17:10 |
| *** rpittau is now known as rpittau|afk | 17:11 | |
| openstackgerrit | Ghanshyam proposed openstack/placement master: [goal] Deprecate the JSON formatted policy file https://review.opendev.org/c/openstack/placement/+/764394 | 17:11 |
| gibi | looking | 17:12 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use NotificationFixture for legacy notifications too https://review.opendev.org/c/openstack/nova/+/758448 | 17:13 |
| gibi | gmann: I'm +2 on both policy patch now, thanks for proposing them | 17:13 |
| gmann | gibi: thanks. | 17:14 |
| gmann | I am going to write the unit tests also for placement policy like we did in nova so that new policy changes can be validated correctly. but sometime next week | 17:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test the NotificationFixture https://review.opendev.org/c/openstack/nova/+/758450 | 17:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move fake_notifier impl under NotificationFixture https://review.opendev.org/c/openstack/nova/+/758451 | 17:16 |
| *** ociuhandu has joined #openstack-nova | 17:18 | |
| *** ociuhandu has quit IRC | 17:23 | |
| *** sean-k-mooney1 has joined #openstack-nova | 17:24 | |
| *** sean-k-mooney has quit IRC | 17:25 | |
| *** dklyle has quit IRC | 17:30 | |
| *** dklyle has joined #openstack-nova | 17:30 | |
| *** hamalq has joined #openstack-nova | 17:30 | |
| *** belmoreira has quit IRC | 17:34 | |
| *** hamalq_ has joined #openstack-nova | 17:34 | |
| *** k_mouza has quit IRC | 17:35 | |
| *** hamalq has quit IRC | 17:38 | |
| *** sapd1 has quit IRC | 17:38 | |
| sean-k-mooney1 | gibi: gmann so im about to drop for the day but where did we settelon on allowing {} in unshleve | 17:46 |
| sean-k-mooney1 | to me blocking it seams wrong and a bug that shoudl be corrected. { "unkonwn" :"unknown"} != {} the former should be blocked but i think the latter shoudl be treaded the same as null | 17:47 |
| gibi | gmann: ack, thanks | 17:49 |
| gibi | sean-k-mooney1: I don't think we had a final agreement | 17:49 |
| gibi | we just stopped arguing:) | 17:49 |
| sean-k-mooney1 | ok i might be back latter after dinner. but that is my perspective on the topic in anycase | 17:50 |
| *** tesseract has quit IRC | 18:06 | |
| gibi | sean-k-mooney1: ack, I share your view | 18:12 |
| melwitt | surely there's precedent for this? I thought a lot of the server actions apis are this way | 18:16 |
| melwitt | if other apis treat null == {} then it seems ok. if they don't, I would make it consistent with the other apis | 18:21 |
| *** sean-k-mooney2 has joined #openstack-nova | 18:23 | |
| *** derekh has quit IRC | 18:26 | |
| *** sean-k-mooney1 has quit IRC | 18:26 | |
| openstackgerrit | Merged openstack/nova master: Revert "Temporarily disable parts of heal port allocation test" https://review.opendev.org/c/openstack/nova/+/755995 | 18:38 |
| *** adrian-a has joined #openstack-nova | 18:39 | |
| gmann | sean-k-mooney2: ack, as gibi mentioned, no final agreement yet we can discuss further | 18:45 |
| gmann | melwitt: all other action API except lock-2.56 and unshelve-2.77 except everything in request, {} or {unknown: unknown} because there is no schema for those as per legacy compatibility. | 18:47 |
| gmann | lock-2.56 and unshelve-2.77 started accepted more param in request body and new schema for those follow different pattern. lock does not block {} but unshelve block {} | 18:48 |
| melwitt | gmann: sorry not sure I parse that. you're saying that all apis except lock-2.56 and unshelve-2.77 do not accept {} as null. but that lock-2.56 and unshelve-2.77 do accept it? | 18:49 |
| melwitt | and that is because the older apis have legacy behavior | 18:49 |
| gmann | melwitt: no, all other action APIs except {}, null, or {unknown: unknown} | 18:50 |
| *** dtantsur is now known as dtantsur|afk | 18:50 | |
| gmann | s/expect/accept | 18:50 |
| gmann | lock after 2.56 and unshelve after 2.77 started then schema checks but both in different pattern | 18:51 |
| melwitt | oh, ok. seems like unshelve should too by consistency. I may be missing some additional context | 18:51 |
| gmann | this is more context on that - https://review.opendev.org/c/openstack/nova/+/663851/34/nova/api/openstack/compute/schemas/servers.py#695 | 18:51 |
| melwitt | ok so this decision would likely affect all apis going to a newer microversion? | 18:52 |
| gmann | but yeah i agree on consistency part but which one we follow that is for discussion | 18:52 |
| melwitt | I see. so we will either make unshelve allow {} or make lock disallow {} | 18:52 |
| gmann | melwitt: yeah if we improve the other action APIs or when they have some request body change in new microversion then they will follow the pattern we decide now | 18:53 |
| melwitt | got it | 18:53 |
| gmann | yeah | 18:53 |
| melwitt | ok, so I think {unknown: unknown} seems like the weirdest one that makes sense to block in new apis | 18:54 |
| gmann | and brinzhang_ started to document the current behavior in api-ref https://review.opendev.org/c/openstack/nova/+/767251 | 18:54 |
| melwitt | (as sean said earlier) | 18:54 |
| gmann | melwitt: yeah {unknown: unknown} will be blocked for all new mprovement | 18:54 |
| gmann | improvement | 18:54 |
| melwitt | the {} makes some sense though and I could imagine veteran users being caught by surprise if we say that is no longer allowed to represent null | 18:54 |
| melwitt | so it will be tradeoff between api purity vs user ease it seems | 18:55 |
| melwitt | I think I'd be slightly in favor of allowing {} for the user ease reason | 18:57 |
| melwitt | I do appreciate that it is redundant with null though | 18:58 |
| gmann | ok, if user considering {} as null then not breaking existing users make sense. | 18:58 |
| melwitt | yeah I mean, I think the use case will be automation or something that is setting values by a dict and when there is nothing they just do {} instead of saying "if nothing then null". but I don't know whether that is a thing people do | 19:00 |
| gmann | i see, i think in python code it make sense as many automation might default to {} if nothing like kwargs or so. | 19:03 |
| gmann | i agree on doing it consistently. | 19:06 |
| gmann | melwitt: sean-k-mooney2 bauzas gibi let's do it in all action APIs to have consistency . i added this in api cleanup etherpad L89. https://etherpad.opendev.org/p/nova-api-cleanup | 19:07 |
| gmann | may be late in this cycle to do? if so we can do in X cycle? | 19:07 |
| gmann | brinzhang_: ^^ | 19:08 |
| gmann | or we can do one more 'multiple API improvement' microversion and pick few more improvement to do along with this. | 19:09 |
| sean-k-mooney2 | gmann: i woudl proably pair it with the return codes cleanup | 19:10 |
| sean-k-mooney2 | so number 8 on line 73 | 19:10 |
| gmann | sean-k-mooney2: that is huge change and in past discussion we thought it is not worth to do as it may change many users scripts or so. | 19:11 |
| sean-k-mooney2 | gmann: stephenfin has a patch for that up | 19:12 |
| gmann | but I am ok to re-iterate it | 19:12 |
| gmann | yeah | 19:12 |
| sean-k-mooney2 | so i assumed that would get done this cycle | 19:12 |
| gmann | that needed spec which i think stephenfin said not worth or so but let me check that | 19:13 |
| sean-k-mooney2 | it was a lower priority this cycle so i dont know if he filed one or was going to | 19:13 |
| gmann | https://review.opendev.org/c/openstack/nova/+/749505 | 19:14 |
| gmann | that is waiting for spec | 19:15 |
| sean-k-mooney2 | stephenfin might have been hoping to do it as a specless blueprint since its resolving exisitng todos in the code but ya i know it lower on his list then the other items he is working on this cycle | 19:16 |
| gmann | yeah. let's discuss it in X cycle PTG to pick few of them which are worth to do | 19:17 |
| sean-k-mooney2 | works for me | 19:17 |
| sean-k-mooney2 | i would like to see teh is_public flavor atitbue change done too at somepoint | 19:18 |
| gmann | :) was typing that. | 19:18 |
| sean-k-mooney2 | but not enought to prioritise it this cycle | 19:18 |
| gmann | that is worth to fix | 19:18 |
| sean-k-mooney2 | it is but on its own it a lot of work for littel benifit | 19:18 |
| sean-k-mooney2 | with other changes it much much more resonable to me | 19:19 |
| gmann | yeah with other improvement | 19:19 |
| *** andrewbonney has quit IRC | 19:26 | |
| *** zzzeek has quit IRC | 19:36 | |
| *** zzzeek has joined #openstack-nova | 19:38 | |
| *** lbragstad_ is now known as lbragstad | 19:54 | |
| *** zzzeek has quit IRC | 20:03 | |
| *** zzzeek has joined #openstack-nova | 20:07 | |
| *** jdillaman has quit IRC | 20:13 | |
| *** zzzeek has quit IRC | 20:14 | |
| *** zzzeek has joined #openstack-nova | 20:17 | |
| *** zzzeek has quit IRC | 20:25 | |
| *** zzzeek has joined #openstack-nova | 20:27 | |
| *** ociuhandu has joined #openstack-nova | 20:35 | |
| *** nweinber_ has joined #openstack-nova | 20:36 | |
| *** nweinber has quit IRC | 20:39 | |
| *** ociuhandu has quit IRC | 20:40 | |
| *** vishalmanchanda has quit IRC | 20:56 | |
| *** sean-k-mooney has joined #openstack-nova | 20:56 | |
| *** sean-k-mooney2 has quit IRC | 20:59 | |
| *** adrian-a has quit IRC | 21:19 | |
| *** larainema has quit IRC | 21:24 | |
| *** brinzhang0 has joined #openstack-nova | 21:42 | |
| *** songwenping_ has joined #openstack-nova | 21:43 | |
| *** brinzhang_ has quit IRC | 21:45 | |
| *** songwenping__ has quit IRC | 21:47 | |
| *** dklyle has quit IRC | 22:04 | |
| *** ralonsoh|afk has quit IRC | 22:09 | |
| *** rcernin has joined #openstack-nova | 22:17 | |
| *** dklyle has joined #openstack-nova | 22:21 | |
| *** spatel has joined #openstack-nova | 22:30 | |
| *** raildo has quit IRC | 22:30 | |
| *** spatel has quit IRC | 22:34 | |
| *** spatel has joined #openstack-nova | 22:40 | |
| *** slaweq has quit IRC | 22:42 | |
| *** spatel has quit IRC | 22:43 | |
| *** derekh has joined #openstack-nova | 22:58 | |
| *** tkajinam has joined #openstack-nova | 22:59 | |
| *** haleyb is now known as haleyb|away | 23:18 | |
| *** nweinber_ has quit IRC | 23:37 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!