Tuesday, 2020-12-15

*** tosky has quit IRC00:10
openstackgerritLance Bragstad proposed openstack/placement master: Pass context objects to oslo.policy directly  https://review.opendev.org/c/openstack/placement/+/76678500:24
openstackgerritLance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers  https://review.opendev.org/c/openstack/placement/+/76024000:24
openstackgerritLance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers  https://review.opendev.org/c/openstack/placement/+/76024000:25
*** zzzeek has quit IRC00:28
*** zzzeek has joined #openstack-nova00:31
*** JamesBenson has joined #openstack-nova00:44
*** JamesBenson has quit IRC00:50
openstackgerritGhanshyam proposed openstack/placement master: Fix l-c job for pyflakes, request version conflict  https://review.opendev.org/c/openstack/placement/+/76699400:54
openstackgerritWenping Song proposed openstack/nova master: Remove redundant code in instance delete  https://review.opendev.org/c/openstack/nova/+/75957700:55
*** hemanth_n has joined #openstack-nova00:55
*** zer0def has left #openstack-nova00:56
*** k_mouza has joined #openstack-nova01:00
*** efried has quit IRC01:01
*** k_mouza has quit IRC01:04
*** swp20 has joined #openstack-nova01:07
*** rcernin has quit IRC01:12
*** LinPeiWen has quit IRC01:20
*** rcernin has joined #openstack-nova01:20
*** JamesBenson has joined #openstack-nova01:23
gmanngibi: melwitt lyarwood this fixes the placement gate (l-c job )- https://review.opendev.org/c/openstack/placement/+/76699401:24
*** zzzeek has quit IRC01:24
gmanngibi: melwitt lyarwood I have moved it to latest hacking version which is easy than solving the old hacking + old pyflake compatible versions.01:25
*** LinPeiWen has joined #openstack-nova01:25
*** zzzeek has joined #openstack-nova01:26
*** JamesBenson has quit IRC01:28
*** songwenping_ has joined #openstack-nova01:31
*** swp20 has quit IRC01:35
*** songwenping__ has joined #openstack-nova01:37
*** macz_ has quit IRC01:37
*** macz_ has joined #openstack-nova01:38
*** songwenping_ has quit IRC01:41
*** swp20 has joined #openstack-nova01:58
*** songwenping__ has quit IRC01:58
*** mlavalle has quit IRC02:16
*** k_mouza has joined #openstack-nova02:38
*** rcernin has quit IRC02:42
*** k_mouza has quit IRC02:42
*** rcernin has joined #openstack-nova02:54
*** hamalq_ has quit IRC02:55
openstackgerritBrin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API  https://review.opendev.org/c/openstack/nova/+/76672603:06
*** JamesBenson has joined #openstack-nova03:24
*** JamesBenson has quit IRC03:28
*** lemko3 has joined #openstack-nova03:35
*** lemko has quit IRC03:38
*** lemko3 is now known as lemko03:38
*** sapd1 has joined #openstack-nova04:03
*** k_mouza has joined #openstack-nova04:46
*** k_mouza has quit IRC04:51
*** vishalmanchanda has joined #openstack-nova05:04
*** zzzeek has quit IRC05:11
*** zzzeek has joined #openstack-nova05:13
*** zzzeek has quit IRC05:20
*** zzzeek has joined #openstack-nova05:25
*** evrardjp has quit IRC05:33
*** evrardjp has joined #openstack-nova05:33
*** brinzhang has joined #openstack-nova05:55
*** zzzeek has quit IRC06:04
*** mtreinish has quit IRC06:05
*** zzzeek has joined #openstack-nova06:06
*** zzzeek has quit IRC06:16
*** zzzeek has joined #openstack-nova06:18
*** ratailor has joined #openstack-nova06:18
*** zzzeek has quit IRC06:30
*** zzzeek has joined #openstack-nova06:31
openstackgerritBrin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API  https://review.opendev.org/c/openstack/nova/+/76672606:38
*** macz_ has quit IRC06:38
*** avolkov has joined #openstack-nova06:44
*** zzzeek has quit IRC06:56
*** zzzeek has joined #openstack-nova06:58
*** rcernin has quit IRC07:06
*** ratailor has quit IRC07:08
*** brinzhang has quit IRC07:10
*** brinzhang has joined #openstack-nova07:10
*** ratailor has joined #openstack-nova07:13
*** zzzeek has quit IRC07:18
*** zzzeek has joined #openstack-nova07:20
*** gyee has quit IRC07:21
*** JamesBenson has joined #openstack-nova07:26
*** zzzeek has quit IRC07:28
*** zzzeek has joined #openstack-nova07:28
*** JamesBenson has quit IRC07:32
*** spatel has joined #openstack-nova07:33
*** mtreinish has joined #openstack-nova07:37
*** spatel has quit IRC07:38
*** rcernin has joined #openstack-nova07:43
*** dklyle has quit IRC07:45
*** rcernin has quit IRC07:48
*** slaweq has quit IRC07:56
gibisean-k-mooney: I do see that these test are slower then the others in the CI, but I don't see any timeout in nova. When it fails it fails from an exception from the db driver07:56
*** slaweq has joined #openstack-nova07:58
*** rcernin has joined #openstack-nova07:59
*** rcernin has quit IRC08:04
*** rpittau|afk is now known as rpittau08:06
*** rcernin has joined #openstack-nova08:08
*** rcernin has quit IRC08:12
*** LinPeiWen has quit IRC08:15
*** andrewbonney has joined #openstack-nova08:17
*** tesseract has joined #openstack-nova08:23
*** LinPeiWen has joined #openstack-nova08:24
gibigmann: I've left comment in https://review.opendev.org/c/openstack/placement/+/76699408:25
*** rcernin has joined #openstack-nova08:33
*** rcernin has quit IRC08:34
*** macz_ has joined #openstack-nova08:35
bauzasgood morning Nova08:37
hemanth_nsean-k-mooney: hey regarding backports which we discussed yesterday, I am afraid it requires more patches to backport to ussuri. For now i found these 3 bfe7b7f3ee340012b3a9f1294ce86b07456ab206, 6c4d1a6aabb101466d2a2d05ed4c6240425b76b5, 0ab8a03c782851d4019c90e6159bd1f83c0658e6 and tests are failing still which implies more patches are needed (placement fixtures related ones are needed for sure). I want to take a pause and see if this is the08:38
hemanth_ndirection we want given lot many patches are required to make the patch i submitted clean cherrypick.. thoughts?08:38
*** macz_ has quit IRC08:39
*** tosky has joined #openstack-nova08:41
*** zzzeek has quit IRC08:43
*** zzzeek has joined #openstack-nova08:44
*** LinPeiWen has quit IRC08:53
bauzasgmann: gibi: is https://review.opendev.org/c/openstack/placement/+/766994 helping the placement CI ?08:56
bauzaswe have a lof of open reviews from lbragstad about secure-rbac https://review.opendev.org/q/topic:%22secure-rbac%22+(status:open%20OR%20status:merged) , and I want to make sure that it would help08:56
*** lpetrut has joined #openstack-nova08:57
bauzaswhoops, bad gerrit query https://review.opendev.org/q/topic:%2522secure-rbac%2522+(status:open+OR+status:merged)+project:openstack/placement08:57
*** zzzeek has quit IRC09:04
*** zzzeek has joined #openstack-nova09:04
*** LinPeiWen has joined #openstack-nova09:07
*** derekh has joined #openstack-nova09:08
*** jangutter has joined #openstack-nova09:09
*** zzzeek has quit IRC09:11
*** zzzeek has joined #openstack-nova09:13
*** zzzeek has quit IRC09:27
*** JamesBenson has joined #openstack-nova09:29
*** zzzeek has joined #openstack-nova09:30
*** martinkennelly has joined #openstack-nova09:31
*** JamesBenson has quit IRC09:33
openstackgerritElod Illes proposed openstack/nova stable/pike: [stable-only] Cap bandit to 1.6.2  https://review.opendev.org/c/openstack/nova/+/76649709:35
*** ociuhandu has joined #openstack-nova09:37
*** jangutter_ has joined #openstack-nova09:52
*** jangutter has quit IRC09:55
*** k_mouza has joined #openstack-nova09:59
*** martinkennelly has quit IRC10:11
*** vishalmanchanda has quit IRC10:22
*** rpittau is now known as rpittau|bbl10:27
*** vishalmanchanda has joined #openstack-nova10:30
gibibauzas: regarding the rbac thing I need to rely on gmann but as far as I know we did similar things in nova in Victoria10:37
bauzasyup for sure10:37
gibibauzas: regarding the lower constraint fix I that is needed to unblock the placement gate10:37
bauzaslet's wait for gmann's reply10:37
*** spatel has joined #openstack-nova10:39
*** ociuhandu has quit IRC10:40
*** spatel has quit IRC10:44
*** zzzeek has quit IRC10:45
*** zzzeek has joined #openstack-nova10:47
*** zzzeek has quit IRC10:53
*** zzzeek has joined #openstack-nova10:56
openstackgerritSylvain Bauza proposed openstack/nova master: Add requested_networks field to RequestSpec object  https://review.opendev.org/c/openstack/nova/+/74997710:57
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Add a routed networks scheduler pre-filter  https://review.opendev.org/c/openstack/nova/+/74906810:57
*** dtantsur|afk is now known as dtantsur11:00
*** avolkov has quit IRC11:12
*** zzzeek has quit IRC11:16
*** zzzeek has joined #openstack-nova11:20
*** ociuhandu has joined #openstack-nova11:21
*** ociuhandu has quit IRC11:25
*** JamesBenson has joined #openstack-nova11:30
*** JamesBenson has quit IRC11:34
*** zzzeek has quit IRC11:39
*** zzzeek has joined #openstack-nova11:40
gibidoes somebody already looked into the volume handling timeout happening fairly frequently on master in tempest? there is a long timeout (196s) that runs out in various volume handling operations11:50
gibie.g. detach11:50
*** zzzeek has quit IRC11:50
*** zzzeek has joined #openstack-nova11:55
*** mgariepy has quit IRC11:59
*** JamesBenson has joined #openstack-nova12:00
lyarwoodgibi: I have not but I can if you point me at an example12:01
* lyarwood has been working on downstream things all week thus far sorry12:01
elodlyarwood: I'm back from PTO and I can work with the 'make LC non-voting' patch if you need help with that12:01
gibilyarwood: no started looking at https://zuul.opendev.org/t/openstack/build/fce6478a6842495f851b8c88336f004912:01
gibinow12:01
lyarwoodelod: cool, as above I haven't had much time to push things along12:01
lyarwoodelod: if you want to try get https://review.opendev.org/c/openstack/nova/+/766738 passing that would be awesome12:02
elodlyarwood: sure, I'll look at that patch too! thanks :)12:04
*** JamesBenson has quit IRC12:08
*** JamesBenson has joined #openstack-nova12:08
*** zzzeek has quit IRC12:10
*** zzzeek has joined #openstack-nova12:10
openstackgerritElod Illes proposed openstack/nova stable/ussuri: [stable-only] lower-contraints: Bump various packages  https://review.opendev.org/c/openstack/nova/+/76673812:21
*** raildo has joined #openstack-nova12:25
openstackgerritStephen Finucane proposed openstack/nova master: add openstack-python3-wallaby-jobs-arm64 job  https://review.opendev.org/c/openstack/nova/+/74209412:31
lyarwoodgibi: so I think this is just a race between the instance delete and following volume delete12:32
lyarwoodgibi: we need the volume to be listed as available before we try to delete it12:32
gibiso we need to wait for the instance to be deleted?12:32
lyarwoodgibi: trying to write this up in a tempest bug now12:32
lyarwoodgibi: it's technically async to that12:32
lyarwoodgibi: n-cpu deletes the volume attachment and that eventually leads c-vol to mark the volume as available again12:33
lyarwoodgibi: I just need to trace the cinder side through to confirm the race but n-cpu hasn't logged the call to delete the volume attachment for some reason12:33
gibiohh, so we would neet to wait for the volume become available before we call delete on it12:33
lyarwoodyeah indeed12:33
lyarwoodthat's awkward but that's life with async APIs12:33
gibiyeah, I think that is OK to add as a fix12:34
gibilyarwood: so the tearDownClass() needs to be smarter or we need to extend a specific test case?12:36
lyarwoodoh wait, actually it looks like n-cpu didn't delete the attachment12:37
*** teoobo_ has joined #openstack-nova12:44
teoobo_stephenfin: thanks for the code review12:45
*** ratailor has quit IRC12:46
lyarwoodgibi: ah ha! it's actually slow snapshot creation in c-vol that's causing this12:55
lyarwoodgibi: that's also async12:55
lyarwoodgibi: there's a TODO from Matt in the test that we should sort out to handle this, adding a waiter on the snapshot state etc12:55
gibilyarwood: I admire you that you was able to found this, I alway lost in the cinder logs12:56
*** ociuhandu has joined #openstack-nova12:58
*** zzzeek has quit IRC12:58
*** zzzeek has joined #openstack-nova12:58
gibiis there a way I can help fixing this in tempest?12:58
gibiI mean is it easy (for somebody like me without much tempest knowledge) to fix in tempest?13:00
lyarwoodgibi: haha thanks, I didn't have to sacrifice anything or anyone this time ;)13:04
lyarwoodgibi: so I think we just need to wait until the volume snapshot is ready13:04
gibiI can hack on that if you have better things to do13:04
lyarwoodgibi: the issue here is that we are using the Nova imageCreate API that creates the volume snapshot for us indirectly13:04
lyarwoodgibi: no I can write this up and fix it13:04
gibicool, thanks13:05
lyarwoodgibi: just need to extract the volume snapshot details from the image metadata13:05
*** mgariepy has joined #openstack-nova13:07
*** macz_ has joined #openstack-nova13:07
*** macz_ has quit IRC13:07
gibiso it is not _that_ simple :)13:08
lyarwoodhttps://bugs.launchpad.net/tempest/+bug/190826913:10
openstackLaunchpad bug 1908269 in tempest "test_snapshot_volume_backed_multiattach not waiting for volume snapshot to become available" [Undecided,New]13:10
lyarwoodhaha no nothing to do with bdms is13:10
*** rpittau|bbl is now known as rpittau13:12
*** zzzeek has quit IRC13:13
*** zzzeek has joined #openstack-nova13:16
*** songwenping_ has joined #openstack-nova13:20
*** brinzhang has quit IRC13:21
*** brinzhang has joined #openstack-nova13:22
*** swp20 has quit IRC13:22
*** brinzhang has quit IRC13:23
*** brinzhang has joined #openstack-nova13:23
gibilyarwood: thanks for the bugreport13:25
lyarwoodgibi: np, just rebuilding a devstack env, the fix should be trivial13:28
lyarwoodfamous last words and all13:28
gibi:)13:31
*** jangutter has joined #openstack-nova13:52
*** jangutter has quit IRC13:52
*** vishalmanchanda has quit IRC13:52
*** jangutter has joined #openstack-nova13:53
*** jangutter_ has quit IRC13:53
*** jangutter has quit IRC13:53
*** jangutter has joined #openstack-nova13:53
*** spatel has joined #openstack-nova13:56
gmanngibi: bauzas checking13:57
*** mlavalle has joined #openstack-nova13:58
*** spatel has quit IRC13:59
openstackgerritMerged openstack/nova master: Remove outdated comment from tox.ini  https://review.opendev.org/c/openstack/nova/+/76553414:01
*** spatel has joined #openstack-nova14:01
gmanngibi: bauzas on policy stuff in placement, I am waiting for the test case to be added and then we can start review. anyways I will check and leave the comment there.14:10
bauzasall cool14:10
gibigmann: thanks for following that14:11
gmanngibi: I will update the l-c fix comments after QA office hour.14:12
gibigmann: cool14:12
sean-k-mooneygibi: did you see my ping yesterday14:14
sean-k-mooneyoh you did14:14
sean-k-mooneyit still might be worht a try setting the timeout14:15
*** tbachman has quit IRC14:15
*** efried has joined #openstack-nova14:22
*** nweinber has joined #openstack-nova14:23
gibisean-k-mooney: you want get the test to time out if it slow? or you want to prevent the test to time out when it is slow?14:26
sean-k-mooneymanila just set a 5 minute timeout to workaround slow nodes14:28
sean-k-mooneyvs the default which i think is 60 seconds14:28
gibisean-k-mooney: we don't have per test timeout I saw these test run and pass after 300 seconds on the gate14:30
sean-k-mooneythats what the manila patch added14:30
gibihm, I saw these in the nova test suite14:31
sean-k-mooneyhttps://review.opendev.org/c/openstack/manila/+/291397/14:31
gibisean-k-mooney: yeah, I saw this patch yesterday, what I say is that in nova we don't have a per test case timeout, and also I see that in nova these tests run for a long time (both in case of failing or passing)14:33
gibiso I don't see how the extra timeout for these tests would help14:36
gibilogstash don't want to help me know to show some examples14:37
gibiI only found one: TestNovaAPIMigrationsWalkMySQL.test_walk_versions [192.038984s] ... FAILED14:37
gibiTestNovaAPIMigrationsWalkPostgreSQL.test_walk_versions [43.027941s]14:37
*** ralonsoh has quit IRC14:40
*** ralonsoh has joined #openstack-nova14:41
sean-k-mooneyah ok so its likely not a timeout issue14:41
sean-k-mooneyi did see a timeout in one of the logs14:42
sean-k-mooneybut i asumed that was a test timeout14:42
gibisean-k-mooney: link me the timeout case then I can double check that14:43
gibiI see them failing after random amont of time. the only time sensitvity I can see is that when it fails then the execution is slower then when it passes14:44
gibibut I saw slow passing executions too14:44
gibiI just haven't seen a fast failing execution14:44
openstackgerritGhanshyam proposed openstack/nova stable/rocky: DNM: testing gate  https://review.opendev.org/c/openstack/nova/+/76702714:54
*** LinPeiWen has quit IRC14:54
*** hemanth_n has quit IRC14:58
lyarwoodgibi: https://review.opendev.org/c/openstack/tempest/+/767165 btw, should resolve this.14:58
lyarwoodgibi: did you write an ER query for this btw?14:58
* lyarwood isn't sure it's worth it with the fix up now but could write one if you haven't14:59
openstackgerritGhanshyam proposed openstack/placement master: Fix l-c job and move to latest hacking 4.0.0  https://review.opendev.org/c/openstack/placement/+/76699414:59
gibilyarwood: I haven't as I was not able to find the root cause14:59
lyarwoodk np14:59
gibilyarwood: and I agree that as we have the fix the ER query is less important now14:59
gibilyarwood: thanks for the tempest fix15:01
gibiI might ping in the future with cinder timeouts :)15:01
gibiI might ping _you_ :)15:03
lyarwoodgibi: always happy to help, even if it debugging cinder timeouts ;)15:05
lyarwoodit is*15:05
gibihonestly, I'm so lost in cinder that I alway get stuck with these failures, give up and go do something else :)15:06
*** lpetrut has quit IRC15:07
*** ociuhandu has quit IRC15:07
lyarwoodgibi: I'm the same with Neutron and PCI stuff tbh15:08
lyarwoodactually not the PCI stuff anymore15:09
gibilyarwood: you can ping me with PCI stuff if needed15:09
gibiohh15:09
gibibumer15:09
lyarwoodbut the Neutron flows still confuse the hell out of me15:09
gibiI have nothing to offer :D15:09
bauzashmmm, TIL I learned that AZ is mandatory even if the doc says it's optional https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id7015:10
bauzasgibi: others ^15:10
*** ociuhandu has joined #openstack-nova15:10
*** ociuhandu has quit IRC15:10
bauzashttps://docs.openstack.org/api-ref/compute/?expanded=unshelve-restore-shelved-server-unshelve-action-detail#unshelve-restore-shelved-server-unshelve-action15:11
bauzasavailability_zone (Optional)15:11
bauzas15:11
bauzasbody15:11
bauzas15:11
bauzasstring15:11
bauzas15:11
bauzasThe availability zone name. Specifying an availability zone is only allowed when the server status is SHELVED_OFFLOADED otherwise a 409 HTTPConflict response is returned.15:11
bauzasNew in version 2.7715:11
bauzaswhat the heck it is15:11
* bauzas grumbles at https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/shelve.py#L3115:11
bauzasso, basically, if you use the latest microversion, we break you15:12
bauzasyou need to pass a specific AZ15:12
bauzaswhen unshelving15:12
lyarwoodhttps://github.com/openstack/nova/blob/240ee3091c5ec458753983afa90e3a0cc11dc322/nova/api/openstack/compute/shelve.py#L95-L9815:13
gibibauzas: is it an api ref doc bug or a code bug?15:13
lyarwoodso wouldn't {'unshelve': null} still work?15:13
bauzaslyarwood: no15:14
bauzassee https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/shelve.py#L3115:14
bauzasgibi: well, the doc says it's an optional field15:14
bauzasand honestly, I don't know why it should be a mandatory field15:14
* bauzas looks at the spec15:15
bauzasI'm a bit afraid we ask AZs everytime people want to unshelve15:15
gibibauzas: would it be defaulted to 'nova' if not provided?15:15
lyarwoodI think {'unshelve': null} still works looking at the API code at least15:15
bauzaslyarwood: no because of the schema15:15
bauzaslyarwood: and I tested it15:15
lyarwoodhuh it lists null as an acceptable type above15:16
gibihm, maybe we made the same too strict then, the code works without az provided15:16
lyarwoodkk if you've tested it then15:16
gibiohh, null is special cased15:16
bauzasgibi: lyarwood: http://paste.openstack.org/show/801061/15:16
gibiso unshelve: null OK but unshelve:{} is not15:17
bauzasanyway, I need to get my kids15:17
* bauzas goes off for 30 mins15:17
lyarwoodValue: {}15:17
lyarwoodack np15:17
gibiI vaguely remember other cases when we disallow {} for a server action15:18
gibiyepp, we have similar construct for lock, migrate and rescue, but they are not the same as they not require anything in {}. So it is interesting why we deviated from this pattern in case of unshelve15:23
gibigmann: I still think we should not try to satify both W503 and W504 at the same time just for the sake of the rules as it does not promote a good code style in my eyes15:27
gmanngibi: if we make all operator in same line with bracket '(' then W503 is automatically solved. that give more consistency also.15:30
gmannI mean fixing it in that consistent way automatically solve the both15:30
gibigmann: as far as I see you wrapped only the parts of the condition into and extra ()  that is over the line length15:32
gibi(amount_needed < min_unit or amount_needed > max_unit or (15:32
gibi                amount_needed % step_size != 0))15:32
gibieg ^^15:32
gibihere it is strange why we have an extra () only for the last or but not the other ors15:33
gibiI still think that we should not try to satisfy both W504 and W503 at the same time. we should decide to wrap the line before the operatr (504) or after the operator (503)15:34
*** ociuhandu has joined #openstack-nova15:37
*** k_mouza has quit IRC15:38
*** k_mouza has joined #openstack-nova15:39
*** markmcclain has joined #openstack-nova15:39
openstackgerritMatteo Sposato proposed openstack/nova master: Refactoring of functional.regression.test_bug_1702454  https://review.opendev.org/c/openstack/nova/+/76599715:40
*** dklyle has joined #openstack-nova15:41
*** arne_wiebalck has quit IRC15:43
openstackgerritMatteo Sposato proposed openstack/nova master: Refactoring of functional.regression.test_bug_1702454  https://review.opendev.org/c/openstack/nova/+/76599715:45
openstackgerritMatteo Sposato proposed openstack/nova master: Functional tests remmoved direct post call  https://review.opendev.org/c/openstack/nova/+/76606815:45
*** ociuhandu has quit IRC15:45
*** arne_wiebalck has joined #openstack-nova15:46
*** ociuhandu has joined #openstack-nova15:46
openstackgerritMatteo Sposato proposed openstack/nova master: Functional tests removed direct post call  https://review.opendev.org/c/openstack/nova/+/76606815:47
*** ociuhandu has quit IRC15:51
gmanngibi: ok. so doing in nova way and ignore W504 ?15:53
gibigmann: that would give us the consistency with nova too. So yes. If I would start a new project then I might use W504 instead and keep the binary operator at the beginnig of the line as that feels like the more imporant information.15:55
gmanngibi: yeah, i think consistency is imp for easy maintenance. will update the patch.15:55
gibigmann: thanks, I hope I did not sound too demanding above15:58
*** ralonsoh has quit IRC15:58
gmanngibi: no, it would take much time, i think less things to fix may be :)15:58
*** ralonsoh has joined #openstack-nova15:59
*** songwenping_ has quit IRC15:59
*** songwenping_ has joined #openstack-nova16:00
gibigmann: yeah, the above example pass W503 without the extra ()16:00
gibiat least I think16:00
gibiit does16:00
gmannyeah, there are only few with W503 i think.16:01
*** mgariepy has quit IRC16:02
*** ociuhandu has joined #openstack-nova16:04
*** ociuhandu has quit IRC16:08
*** ociuhandu has joined #openstack-nova16:08
*** ralonsoh has quit IRC16:15
*** ralonsoh has joined #openstack-nova16:15
openstackgerritGhanshyam proposed openstack/placement master: Fix l-c job and move to latest hacking 4.0.0  https://review.opendev.org/c/openstack/placement/+/76718216:20
openstackgerritGhanshyam proposed openstack/placement master: Fix l-c job and move to latest hacking 4.0.0  https://review.opendev.org/c/openstack/placement/+/76699416:21
gibigmann: do you wanted to push two separate patches for this ^^ ?16:22
gmanngibi: i meshed up the commit id initially. abandon the new commit and kept in old one16:23
*** ralonsoh has quit IRC16:23
gmanngibi: this is all good now https://review.opendev.org/c/openstack/placement/+/76699416:23
gibilooking...16:23
gmannneed to have strong coffee  i think :)16:24
bauzasgibi: lyarwood: I'm back, should I write then some bug asking to support {} for the unshelve action16:25
gibiI was lazy today to brew coffee, trying to survive with black tea16:25
bauzas?16:25
gibibauzas: I think that is a reasonable think to ask for16:25
gibiI don't see why we forbid the unshelve: {} format16:25
gibibrinzhang: do you happen to rememeber the reasoning here ^^16:26
gibibrinzhang: we are trying to figure out why your patch made the az mandatory in https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/shelve.py#L3116:27
bauzasgibi: thanks, let's wait for brinzhang16:28
sean-k-mooneyisnt it an instance action16:28
sean-k-mooneydont we need the action in the payload16:28
gibisean-k-mooney: the action is unshelve16:28
gibiso that is alway in the payload16:28
sean-k-mooneyhttps://docs.openstack.org/api-ref/compute/?expanded=unshelve-restore-shelved-server-unshelve-action-detail#unshelve-restore-shelved-server-unshelve-action16:28
gibibut unshelve has an optional parameter the az16:28
sean-k-mooneyya so {16:28
sean-k-mooney    "unshelve": null16:29
sean-k-mooney}16:29
sean-k-mooneyExample Unshelve server (unshelve16:29
sean-k-mooneyis allowed16:29
sean-k-mooneyyou are just suggesting {} instead of null16:29
*** ralonsoh has joined #openstack-nova16:29
sean-k-mooneyif so sure that seams fine16:29
gibisean-k-mooney: yeah we could allow both as far as I see16:29
gibisean-k-mooney: and lock, migrate and rescue allows it16:29
*** ociuhandu has quit IRC16:31
sean-k-mooneyyep anyway got to go to a doctors apointment ill be back online tomorrow16:31
gibisean-k-mooney: o/16:31
gibibauzas: you can send https://review.opendev.org/c/openstack/placement/+/766994 thorugh if you wish16:32
gmannyeah for most of server action request body are like 'allowed anything but API ignore those'16:32
bauzasgibi: looking16:33
bauzasall good16:33
gibithanks bauzas16:34
*** ociuhandu has joined #openstack-nova16:34
bauzassec16:35
*** jamesdenton has quit IRC16:36
*** jamesden_ has joined #openstack-nova16:36
*** ociuhandu has quit IRC16:39
bauzasgibi: gmann: I'm unclear, https://review.opendev.org/c/openstack/placement/+/766994/9/placement/conf/database.py changes aren't related to neither W503 nor W50416:41
bauzasand while we don't accept single lines in modules, we accept in nova indentations like L5816:42
gmannbauzas: that is E12816:42
bauzasyup, I was looking at https://www.flake8rules.com/rules/E128.html16:43
bauzasbut E128 anti-pattern is accepted by nova IIRC16:43
bauzasand tbc, my concern is that you're changing for supporting E128 without explaining why16:44
gmannyeah in nova we ignored E128 https://github.com/openstack/nova/blob/master/tox.ini#L25916:44
gmannbauzas: placement was using too old hacking checks.16:44
gmannmoving to new one end up with these multiple updates16:45
*** k_mouza has quit IRC16:47
bauzasgmann: okay, but then why not ignoring E128 and then not modify all the placement code ?16:47
gmanngibi: bauzas we can. even we can keep the same ignore list as in nova https://github.com/openstack/nova/blob/master/tox.ini#L25916:47
bauzasgmann: I'd indeed prefer this way16:47
bauzasgiven we did cut from nova16:47
gmannso that we can keep future consistency also16:48
bauzaswhen branching placement16:48
gmannbauzas: ok, let me update that.16:48
bauzasgibi: thoughts on it ?16:48
gmannk, waiting for gibi.16:49
gibiI'm meh on this. I think the new rules are meaningful and pretty cheap to introduce in placement so I'm happy to take them in16:49
gibiintroducing them to nova would make a lot of code change I guess16:49
stephenfinI'd rather we kept the default list too16:49
gibistephenfin: default, meansh what is in nova's tox.ini?16:49
stephenfinprobably not worth the effort for nova, but the placement changes are done already16:49
stephenfinno, what's in placement's tox.ini now16:50
*** ociuhandu has joined #openstack-nova16:50
gibiyeah, I tend to agree with stephenfin16:50
gmannyeah there are no other changes need in placement for those checks16:50
bauzasmy point is that we're changing placement code for the sake of a new hacking revision16:50
bauzasI'd rather prefer to make nova and placement consistent in terms of style16:50
bauzasbesides the fact this would allow us to merge this change without needing to touch at the code16:51
bauzasand later, we could just unignore rules one by one in placement if we really wish16:51
bauzasbaby steps, here, baby steps16:51
bauzas1/ upgrade hacking and ignore same list16:52
bauzas2/ unignore a specific rule and modify the code accordingly16:52
bauzas3/ iterate over every ignored rule16:52
gibibauzas: if you are after to split the hacking version change and the introdcution of new rules into separate patches then fine, but the current patch is not too big too16:52
gmannbauzas: but this change with not-ignoring does not change much code16:52
stephenfinif there were a significant amount of changes then I'd agree, but it doesn't seem worth the effort here16:52
bauzasgibi: the problem is that we are silently changing placement without really explaining which hacking errors we wanted to fixc16:53
gibibauzas: sure, we can add a list of new rules applied to the commit message16:53
bauzasand I don't think it's hard to just split this change in twice if you really want to unignore E128 and all the other rules16:53
gibiOK, I'm fine in both ways: a) add a bit more text the commit message about the new rules that required the code change OR b) split the current patch into two16:54
gmanngiving it unblock the gate I preferred to move the  code to latest hacking which is easy than doing one by one.16:54
gibigmann: agree, new hacknig is better16:55
gmannI can add checks fix in commit msg.16:55
stephenfinI don't think E128 is a big issue. W503/W504 seem to be the bulk of it. We could drop one of those, seeing as they conflict16:55
gmannyeah W504 is ignored now16:55
stephenfinsweet, then I don't care :)16:56
gmannhttps://review.opendev.org/c/openstack/placement/+/766994/9/tox.ini16:56
bauzasphew ok16:57
bauzasI just feel we're overcomplicating16:57
bauzasbumping hacking and providing the right ignore list will allow the gate to pass without needing to touch code16:57
bauzasunless I'm missing something obvious16:58
bauzasmy take is, gmann had to touch code instead of amending the ignore list in order to fix the gate, I just feel it was unnecessary16:58
stephenfinbauzas: not quite; a couple of the checks have been improved in newer versions of flake8 etc. To ignore those you'd have to disable the check and actually regress16:58
bauzasstephenfin: why then nova isn't a problem ?16:59
stephenfinbecause we fixed them there16:59
stephenfinexample: https://review.opendev.org/c/openstack/placement/+/766994/9/placement/conf/database.py16:59
stephenfinthat extra newline was (mistakenly) not required in an old version of flake816:59
bauzasfor the extra newline, OK17:00
bauzasfor the continuous indentation, that's still there17:00
bauzasso, ok, I mixed things17:00
gmannnova is on 3.1.0. i could move placement too to that but 4.0.0 is already out to moving to it is easy.17:00
bauzasgmann has to fix single lines within modules, but can just continue to leave uncontinuous indentation if he wishes17:01
gmannanyways code is up and green so merging it is faster than splitting the patch now17:01
* bauzas shrugs17:01
bauzaswell, I'm OK to remove my -1 for the sake of merging17:02
bauzasbut honestly, this is confisuing17:03
gmannbauzas: how about if i explain those check fixes in cmt msg ?17:04
bauzasI'm just saying we're again touching code for the beauty of our eyes and we're overcomplicating things, exactly like we did a couple of times in nova17:04
bauzasbut meh, I bail out17:04
bauzasso, stephenfin can look at the change, I removed my -117:05
* gibi already bailed :D17:05
bauzasthe +2 from gibi is there, so...17:05
gibiyeah17:05
gibihonestly I don't feel this as such a big issue17:05
gibibut that jsutme17:05
gibijust me17:05
gmannbauzas: you seems do not like hacking checks much :)17:05
bauzasit's more or less a matter of touching production code for the sake of ourselves being pedantic :)17:06
bauzasbut okay17:06
bauzasgmann: well, I'm just pragmatic about things that work17:07
bauzasbut fair enough17:07
gmannI see your point.17:08
*** mgariepy has joined #openstack-nova17:15
*** k_mouza has joined #openstack-nova17:19
stephenfinta, done17:20
*** teoobo__ has joined #openstack-nova17:24
*** k_mouza has quit IRC17:24
*** hamalq has joined #openstack-nova17:25
*** teoobo_ has quit IRC17:26
*** hamalq_ has joined #openstack-nova17:27
*** teoobo__ has quit IRC17:28
*** dtantsur is now known as dtantsur|afk17:29
*** hamalq has quit IRC17:31
stephenfingmann: Could you look at https://review.opendev.org/c/openstack/nova/+/765798/ at some point?17:33
openstackgerritStephen Finucane proposed openstack/nova master: tests: Merge 'test_hypervisor_status' into 'test_hypervisors'  https://review.opendev.org/c/openstack/nova/+/76403917:33
openstackgerritStephen Finucane proposed openstack/nova master: api: Drop statistics-style fields from os-hypervisors  https://review.opendev.org/c/openstack/nova/+/76404017:33
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Change default policy for '/os-hypervisors'  https://review.opendev.org/c/openstack/nova/+/76579817:33
stephenfinI'm not sure if I'm tackling that correctly17:33
stephenfinAlso, resolved your comment on https://review.opendev.org/c/openstack/nova/+/76403917:33
gmannstephenfin: sure, checking17:33
stephenfinlyarwood: you'd probably be interested in this at some point https://bugs.launchpad.net/nova/+bug/190626617:36
openstackLaunchpad bug 1906266 in OpenStack Compute (nova) "After upgrade: "libvirt.libvirtError: Requested operation is not valid: format of backing image %s of image %s was not specified"" [Undecided,New]17:36
*** tesseract has quit IRC17:36
lyarwoodstephenfin: didn't we fix that a while ago?17:37
* lyarwood looks17:37
stephenfinyup, they're saying the fix is incomplete17:37
gmannstephenfin: yeah that is right way, as system scope is disable by default and we still have old legacy rule in deprecated rule so we are good, - https://review.opendev.org/c/openstack/nova/+/765798/2/nova/policies/hypervisors.py#b3717:37
lyarwoodoh for existing images you actually need to add the backing format in, there's nothing n-cpu can do iirc17:38
gmannstephenfin: no microversion needed for policy default, but please add releasenotes for that. I am checking other patches in that series17:38
stephenfingmann++ Great, thanks :)17:38
lyarwoodtbh I thought this was relaxed17:38
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Add a routed networks scheduler pre-filter  https://review.opendev.org/c/openstack/nova/+/74906817:39
stephenfinmaybe it was; they don't give any details about the versions they're using17:39
stephenfinlyarwood: https://github.com/libvirt/libvirt/commit/ae9e6c2a2b75d958995c661f7bb64ed4353a640417:43
stephenfinthe few patches I grepped from https://www.redhat.com/archives/libvir-list/2020-February/msg00616.html appear to be in v6.1.017:44
lyarwoodah!17:46
lyarwoodthe error is still there but we don't get there now17:46
*** rpittau is now known as rpittau|afk17:46
stephenfinthat's my reading of it too, yeah17:47
gansoHi nova folks! Yesterday I logged bug https://bugs.launchpad.net/nova/+bug/1908133 and it has been closed as a duplicated. I'd like to discuss what possible workarounds there are (there are no mentions of workarounds in the duplicate entry). In my "steps to reproduce" I took 2 different approaches, the second one being relying on placement to control the shared allocations, but it is quite 100%, as I am not sure I am configuring it correctly. The17:50
openstackLaunchpad bug 1522307 in OpenStack Compute (nova) "duplicate for #1908133 Disk usage not work for shared storage" [Medium,Confirmed]17:50
gansoinstructions in the placement docs are not very detailed to achieve what I need. Is anyone familiar with this use case or can think of any possible workarounds?17:50
*** ociuhandu_ has joined #openstack-nova17:52
*** ociuhandu has quit IRC17:55
*** ociuhandu_ has quit IRC17:57
*** derekh has quit IRC18:00
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Change default policy for '/os-hypervisors'  https://review.opendev.org/c/openstack/nova/+/76579818:06
*** k_mouza has joined #openstack-nova18:43
*** k_mouza has quit IRC18:52
*** gyee has joined #openstack-nova19:00
jawad_axdHi folks! Error 43, windows 10 with gpu passthrough. Added img_hide_hypervisor_id=True to image property. Is there anything I need to do to load nvidia drivers in windows instance?19:13
jawad_axd*anything else19:14
*** andrewbonney has quit IRC19:17
*** artom has quit IRC19:25
*** adrian-a has joined #openstack-nova19:29
openstackgerritGhanshyam proposed openstack/nova master: Reuse code from oslo lib for JSON policy migration  https://review.opendev.org/c/openstack/nova/+/76348719:48
openstackgerritGhanshyam proposed openstack/nova master: Reuse code from oslo lib for JSON policy migration  https://review.opendev.org/c/openstack/nova/+/76348719:49
openstackgerritElod Illes proposed openstack/nova stable/ussuri: [stable-only] fix lower-constraints and disable qos resize  https://review.opendev.org/c/openstack/nova/+/76673820:02
*** artom has joined #openstack-nova20:42
*** lbragstad has quit IRC20:43
openstackgerritMerged openstack/nova master: libvirt: make cross cell resize spawn from snapshot image  https://review.opendev.org/c/openstack/nova/+/76556120:44
*** jawad_axd has quit IRC20:59
*** raildo has quit IRC21:03
*** JamesBenson has quit IRC21:13
*** JamesBenson has joined #openstack-nova21:14
*** ociuhandu has joined #openstack-nova21:17
*** JamesBenson has quit IRC21:19
*** rcernin has joined #openstack-nova21:25
*** ociuhandu_ has joined #openstack-nova21:26
*** ociuhandu has quit IRC21:29
*** ociuhandu has joined #openstack-nova21:30
*** k_mouza has joined #openstack-nova21:31
*** ociuhandu_ has quit IRC21:32
*** k_mouza has quit IRC21:35
*** nweinber has quit IRC21:41
*** jangutter_ has joined #openstack-nova21:42
*** ociuhandu_ has joined #openstack-nova21:44
*** ociuhandu has quit IRC21:45
*** jangutter has quit IRC21:45
*** ociuhandu has joined #openstack-nova21:45
*** ociuhandu_ has quit IRC21:46
*** ociuhandu_ has joined #openstack-nova21:46
*** ociuhand_ has joined #openstack-nova21:48
*** JamesBenson has joined #openstack-nova21:49
*** ociuhandu_ has quit IRC21:49
*** ociuhandu has quit IRC21:49
*** lbragstad has joined #openstack-nova21:53
*** JamesBenson has quit IRC21:54
*** trident has quit IRC21:56
*** markguz_ has joined #openstack-nova21:56
*** trident has joined #openstack-nova22:00
*** spatel has quit IRC22:11
*** markguz_ has quit IRC22:38
*** JamesBenson has joined #openstack-nova22:51
*** ociuhand_ has quit IRC22:58
*** macz_ has joined #openstack-nova23:09
*** adrian-a has quit IRC23:20
*** k_mouza has joined #openstack-nova23:31
*** slaweq has quit IRC23:32
*** k_mouza has quit IRC23:36
*** artom has quit IRC23:47
*** artom has joined #openstack-nova23:48

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!