| *** eharney has quit IRC | 00:05 | |
| *** bbowen has quit IRC | 00:07 | |
| *** grandchild has quit IRC | 00:13 | |
| *** eharney has joined #openstack-nova | 00:19 | |
| *** tetsuro has joined #openstack-nova | 00:33 | |
| *** brinzhang_ has joined #openstack-nova | 00:40 | |
| *** brinzhang0 has quit IRC | 00:42 | |
| *** rambo_li has joined #openstack-nova | 01:06 | |
| *** Liang__ has joined #openstack-nova | 01:15 | |
| *** hamalq has quit IRC | 01:28 | |
| *** rambo_li has quit IRC | 01:46 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: [Trivial] Remove wrong format_message() conversion https://review.opendev.org/744280 | 02:04 |
|---|---|---|
| *** sapd__x has joined #openstack-nova | 02:27 | |
| *** markvoelker has joined #openstack-nova | 02:31 | |
| *** markvoelker has quit IRC | 02:35 | |
| *** markvoelker has joined #openstack-nova | 02:37 | |
| *** jmlowe has quit IRC | 02:42 | |
| *** markvoelker has quit IRC | 02:47 | |
| *** sapd1_x has quit IRC | 02:59 | |
| *** mkrai has joined #openstack-nova | 03:02 | |
| *** psachin has joined #openstack-nova | 03:31 | |
| *** dave-mccowan has quit IRC | 03:46 | |
| openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | 04:07 |
| openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522 | 04:07 |
| openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | 04:07 |
| *** ratailor has joined #openstack-nova | 04:28 | |
| *** markvoelker has joined #openstack-nova | 04:31 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-nova | 04:33 | |
| *** markvoelker has quit IRC | 04:36 | |
| *** vishalmanchanda has joined #openstack-nova | 04:44 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: introduce a new driver interface 'cleanup_instance' https://review.opendev.org/714653 | 04:47 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: track error migrations in resource tracker https://review.opendev.org/745281 | 04:47 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: track orphans in resource tracker https://review.opendev.org/745282 | 04:47 |
| *** gyee has quit IRC | 04:48 | |
| *** udesale has joined #openstack-nova | 05:24 | |
| *** links has joined #openstack-nova | 05:27 | |
| *** tkajinam has quit IRC | 05:34 | |
| *** tkajinam has joined #openstack-nova | 05:35 | |
| *** tkajinam has quit IRC | 05:50 | |
| *** tkajinam has joined #openstack-nova | 05:51 | |
| *** yedongcan has joined #openstack-nova | 05:57 | |
| *** yaawang has quit IRC | 06:01 | |
| *** yaawang has joined #openstack-nova | 06:01 | |
| *** markvoelker has joined #openstack-nova | 06:21 | |
| *** markvoelker has quit IRC | 06:26 | |
| *** redrobot has quit IRC | 06:37 | |
| *** mkrai has quit IRC | 06:48 | |
| *** mkrai_ has joined #openstack-nova | 06:48 | |
| *** yedongcan has quit IRC | 06:52 | |
| *** mkrai_ has quit IRC | 06:57 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: track error migrations in resource tracker https://review.opendev.org/745281 | 06:59 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: track orphans in resource tracker https://review.opendev.org/745282 | 06:59 |
| gibi | good morning | 07:11 |
| *** bhagyashris is now known as bhagyashris|off | 07:13 | |
| *** mvorwerk has joined #openstack-nova | 07:16 | |
| *** tetsuro has quit IRC | 07:17 | |
| *** tesseract has joined #openstack-nova | 07:19 | |
| *** k_mouza has joined #openstack-nova | 07:27 | |
| *** k_mouza has quit IRC | 07:27 | |
| *** dougsz has joined #openstack-nova | 07:33 | |
| tony_su | stephenfin: gibi: alex_xu: new provider-config-file patches uploaded change log 1) all comments except one in the last patch relected in code or answered 2) add docstring for each test case | 07:38 |
| tony_su | unfortunately, so far I don't know how to use nova-manage command to help provider config. | 07:39 |
| tony_su | stephenfin: does it mean we need to upgrade nova-manage command to offer some new option to validate the validity of provider.yaml file? | 07:42 |
| tony_su | for this comment https://review.opendev.org/#/c/693460/35/doc/source/admin/managing-resource-providers.rst@205 | 07:42 |
| *** yaawang has quit IRC | 07:45 | |
| *** yaawang has joined #openstack-nova | 07:46 | |
| *** slaweq has joined #openstack-nova | 07:50 | |
| *** markvoelker has joined #openstack-nova | 07:51 | |
| *** Liang__ has quit IRC | 07:51 | |
| stephenfin | tony_su: Yeah, exactly. I'm thinking we simply add a command (e.g. 'nova-manage placement validate-schema $SCHEMA') that attempts to load the provided schema and provides an error code and message if it's not valid | 07:52 |
| *** brinzhang0 has joined #openstack-nova | 07:52 | |
| tony_su | Must we do it this time or can we do it later? I am not fairly faimiliar with nova-manage command and I dont' know how long it can be done. | 07:53 |
| tony_su | I am a little bit worried we will miss Victoria if do so. | 07:54 |
| *** ralonsoh has joined #openstack-nova | 07:54 | |
| *** brinzhang_ has quit IRC | 07:55 | |
| *** markvoelker has quit IRC | 07:56 | |
| *** Liang__ has joined #openstack-nova | 08:00 | |
| *** tosky has joined #openstack-nova | 08:04 | |
| *** ratailor has quit IRC | 08:21 | |
| *** sapd__x has quit IRC | 08:27 | |
| *** yaawang has quit IRC | 08:32 | |
| *** yaawang has joined #openstack-nova | 08:33 | |
| *** martinkennelly has joined #openstack-nova | 08:36 | |
| gibi | tony_su, stephenfin: I'm fine handling the nova-manage part as an addition on top of the series as I don't consider that as a blocker for the feature to merge. Let's focuse on merging what is ready (I know I should spend some time reviewing that series too). | 08:40 |
| *** tetsuro has joined #openstack-nova | 08:41 | |
| *** tetsuro has quit IRC | 08:41 | |
| *** derekh has joined #openstack-nova | 08:52 | |
| *** ociuhandu has joined #openstack-nova | 08:56 | |
| *** ociuhandu_ has quit IRC | 08:57 | |
| *** markvoelker has joined #openstack-nova | 09:04 | |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: mypy: Add type annotations https://review.opendev.org/745162 | 09:07 |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: mypy: Extend type annotations to 'vif_plug_noop' https://review.opendev.org/745163 | 09:07 |
| *** markvoelker has quit IRC | 09:09 | |
| *** jangutter has joined #openstack-nova | 09:12 | |
| *** mkrai has joined #openstack-nova | 09:12 | |
| *** jangutter_ has quit IRC | 09:14 | |
| *** tkajinam has quit IRC | 09:17 | |
| *** ratailor has joined #openstack-nova | 09:24 | |
| *** dtantsur|afk is now known as dtantsur | 09:30 | |
| tony_su | gibi: stephenfin has been doing great, detailed review for each patch. your review can still effectively speedup our progress... | 09:31 |
| *** ratailor_ has joined #openstack-nova | 09:32 | |
| *** k_mouza has joined #openstack-nova | 09:33 | |
| *** ratailor has quit IRC | 09:35 | |
| kashyap | lyarwood: Can you remind me, please: does Nova stash 'host-capabilities' somewhere? | 09:36 |
| kashyap | It does, IIRC | 09:37 |
| lyarwood | kashyap: hmm I know we grab them at startup | 09:38 |
| kashyap | lyarwood: Damn | 09:38 |
| kashyap | lyarwood: So the problem I'm debugging w/ a TripleO upgrade dev is this: | 09:38 |
| lyarwood | kashyap: it doesn't look like we stash them anywhere | 09:39 |
| lyarwood | kashyap: we appear to be grabbing a fresh copy from libvirt everytime we need them | 09:40 |
| kashyap | lyarwood: Hmm. Got a code pointer? | 09:40 |
| lyarwood | kashyap: https://paste.centos.org/view/86fa4860 | 09:42 |
| kashyap | lyarwood: Excellent! That helped | 09:44 |
| kashyap | lyarwood: Context: | 09:44 |
| kashyap | lyarwood: During FFU, some hosts report the CPU feature 'arch-facilities' (to make matters worse, it's called differently on EL8: 'arch-capabilities') | 09:45 |
| kashyap | lyarwood: So migration from EL7 to EL8 fails (on appropriate hardware) with: "libvirt.libvirtError: internal error: Unknown CPU feature arch-facilities" | 09:45 |
| kashyap | lyarwood: To 'workaround' that, we need to disable the 'arch-facilities' on the source host | 09:45 |
| lyarwood | kashyap: isn't that a libvirt bug? | 09:46 |
| kashyap | s/disable/comment-out | 09:46 |
| lyarwood | kashyap: ah wait, is it the way we generate the xml on the src? | 09:46 |
| *** jangutter has quit IRC | 09:46 | |
| kashyap | lyarwood: No, it's not :-( I talked w/ Jiri Denemark today | 09:46 |
| kashyap | In short, we (Nova) need to improve on how we're doing CPU checks. Some checks are redundant (as libvirt does them anyway) | 09:46 |
| *** jangutter has joined #openstack-nova | 09:46 | |
| lyarwood | kashyap: we can handle that in https://github.com/openstack/nova/blob/9ecefeb836964c52a5a2969b15c82b11c51d32ab/nova/virt/libvirt/migration.py#L56-L70 | 09:46 |
| kashyap | lyarwood: Yeah, indeed. The guest XML itself doesn't have 'arch-facilities' | 09:47 |
| kashyap | lyarwood: /me clicks | 09:50 |
| *** viks____ has joined #openstack-nova | 09:50 | |
| * kashyap should make some time to omplement this - https://opendev.org/openstack/nova-specs/commit/70811da221035044e27 | 09:50 | |
| kashyap | lyarwood: So, let me explain the sequence of the current workaround: | 09:52 |
| * kashyap types in an editor and pastes it here | 09:52 | |
| kashyap | 1. Double-check none of the EL7 instance XML contain 'arch-facilities' CPU feature. Normally, the guests do _not_ have them. | 09:59 |
| kashyap | 2. Run `virsh capabilities | grep arch-facilities` — it will be present | 09:59 |
| kashyap | 3. Comment out 'arch-facilties' in /usr/share/libvirt/cpu_share.xml | 09:59 |
| kashyap | 4. Restart 'libvirtd' and 'nova-compute' service (both are needed) | 09:59 |
| kashyap | 5. Then run `virsh capabilities`, again: it will now be absent (expected) | 09:59 |
| kashyap | 6. Now migrate the guest from EL7 to EL8: it _must_ succeed. | 09:59 |
| kashyap | (The above is when migrating only from source hardware that supports 'arch-facilities' CPU feature.) | 09:59 |
| lyarwood | urgh we need to fix this in Nova tbh | 10:01 |
| lyarwood | we can check on the dest if arch-capabilities is set | 10:02 |
| lyarwood | if it is, use it in the migration xml we send there | 10:02 |
| lyarwood | if it isn't but arch-facilities is set on the src, remove that from the migration xml | 10:03 |
| lyarwood | does that sound right? | 10:03 |
| kashyap | lyarwood: Reading the scroll | 10:05 |
| lyarwood | brb coffee | 10:05 |
| kashyap | lyarwood: Right, that does sound correct. I'm gonna file a bug for it | 10:06 |
| kashyap | lyarwood: Oh, but note: 'arch-facilties' is marked as *non-migratable* | 10:06 |
| lyarwood | /o\ | 10:10 |
| lyarwood | so should we always remove it? | 10:10 |
| kashyap | lyarwood: I'd change the plan to this: just drop 'arch-facilities' and let libvirt handle it — this works, Jiri from libvirt confirms | 10:12 |
| * kashyap --> lunch; bbiab | 10:12 | |
| lyarwood | kashyap: ack that's simple enough then | 10:13 |
| lyarwood | kashyap: as you're out on PTO next week I'd be happy to handle that once you've written up the bug | 10:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Follow up for Ibf8dca4bd57b3bddb39955b53cc03564506f5754 https://review.opendev.org/745095 | 10:22 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add helpers for suspend, resume and reboot of server https://review.opendev.org/741285 | 10:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Pass context, instance to '_create_guest' https://review.opendev.org/741286 | 10:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Reject non-spawn operations for vTPM https://review.opendev.org/741500 | 10:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add emulated TPM support to Nova https://review.opendev.org/631363 | 10:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support https://review.opendev.org/739213 | 10:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.compute.manager' https://review.opendev.org/742863 | 10:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/741995 | 10:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: privsep: Add support for recursive chown, move_tree operations https://review.opendev.org/742864 | 10:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils' https://review.opendev.org/742865 | 10:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | 10:25 |
| kashyap | lyarwood: A quick one, without checking the code, the migrate XML - is it the one we send to _compare_cpu() method or to libvirt's migrate API? | 10:30 |
| kashyap | lyarwood: I'll let you know once I've got the bug up... | 10:31 |
| lyarwood | kashyap: libvirt's migrate API | 10:32 |
| lyarwood | kashyap: is this failing in _compare_cpu? | 10:33 |
| kashyap | lyarwood: Yep, the failure is indeed from _compare_cpu() | 10:33 |
| kashyap | This whole thing needs replacing; see my earlier-mentinoned spec on newer APIs. I've got a draft patch branch for it somewhere (https://opendev.org/openstack/nova-specs/commit/70811da221035044e27) | 10:34 |
| kashyap | But the "full replacing" can wait. One step at a time | 10:34 |
| kashyap | lyarwood: Oh, sigh; 'arch-facilities' is a EL-only thing :-( | 10:35 |
| lyarwood | \o/ | 10:35 |
| kashyap | lyarwood: So, I don't think it makes sense for upstream; perhaps a EL-8 downstream-specific patch is needed | 10:35 |
| lyarwood | ggwp libvirt | 10:35 |
| kashyap | lyarwood: Yeah, annoying: | 10:36 |
| kashyap | [quote] | 10:36 |
| kashyap | The kernel calls this feature arch_capabilities and RHEL/CentOS 7.* use | 10:36 |
| kashyap | arch-facilities. Apparently some CPU test files were gathered with the | 10:36 |
| kashyap | RHEL version of QEMU. Let's update the test files to avoid possible | 10:36 |
| kashyap | confusion about the correct naming. | 10:36 |
| kashyap | [/quote] | 10:36 |
| kashyap | From here: https://libvirt.org/git/?p=libvirt.git;a=commit;h=511df17aec | 10:36 |
| kashyap | Err, wrong link | 10:36 |
| kashyap | No, that's correct. (Self, slow down) | 10:37 |
| *** artom has quit IRC | 10:40 | |
| *** k_mouza has quit IRC | 10:43 | |
| *** k_mouza has joined #openstack-nova | 10:51 | |
| *** jangutter_ has joined #openstack-nova | 10:57 | |
| *** Liang__ has quit IRC | 10:58 | |
| *** jangutter has quit IRC | 11:00 | |
| *** markvoelker has joined #openstack-nova | 11:05 | |
| *** markvoelker has quit IRC | 11:10 | |
| *** jangutter has joined #openstack-nova | 11:12 | |
| *** jangutter_ has quit IRC | 11:15 | |
| *** stephenfin has quit IRC | 11:29 | |
| *** bbowen has joined #openstack-nova | 11:37 | |
| *** stephenfin has joined #openstack-nova | 11:38 | |
| *** artom has joined #openstack-nova | 11:43 | |
| *** k_mouza has quit IRC | 11:46 | |
| *** ociuhandu has quit IRC | 11:47 | |
| *** ociuhandu has joined #openstack-nova | 11:48 | |
| sean-k-mooney | kashyap: we do cache the host capablities i belive too. i think i added that | 11:52 |
| sean-k-mooney | kashyap: but this is a downstream only bug anyway so not really an issue with caching | 11:53 |
| sean-k-mooney | well i think we cache the domain caps | 11:54 |
| sean-k-mooney | which is slitghly different | 11:54 |
| *** k_mouza has joined #openstack-nova | 11:56 | |
| sean-k-mooney | we cache both https://github.com/openstack/nova/blob/stable/train/nova/virt/libvirt/host.py#L693-L843 | 11:56 |
| kashyap | Yeah, domain caps is different from host capabilities | 11:57 |
| kashyap | 'virsh capabilities' vs. 'virsh domcapabilities' | 11:57 |
| kashyap | Confusing | 11:57 |
| sean-k-mooney | yep | 11:57 |
| sean-k-mooney | i know | 11:57 |
| sean-k-mooney | we cache both | 11:57 |
| *** vishalmanchanda has quit IRC | 11:58 | |
| sean-k-mooney | looks like we have cached the host capabilities since danpb added the function | 11:59 |
| sean-k-mooney | libvirt caches the data too in the drivers so its not going to chagne without restart the libvirt deamon anyway | 11:59 |
| *** k_mouza has quit IRC | 12:00 | |
| *** mkrai has quit IRC | 12:02 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add new default roles in FIP policies https://review.opendev.org/742030 | 12:05 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass the actual target in FIP policy https://review.opendev.org/742570 | 12:06 |
| *** brinzhang0 has quit IRC | 12:08 | |
| *** JamesBenson has joined #openstack-nova | 12:23 | |
| *** stephenfin has quit IRC | 12:24 | |
| *** rcernin has quit IRC | 12:32 | |
| *** stephenfin has joined #openstack-nova | 12:33 | |
| gibi | and now I clogged the gate with all the open, and now approved, policy patches | 12:33 |
| gibi | happy Friday :D | 12:33 |
| sean-k-mooney | :) | 12:34 |
| *** ratailor_ has quit IRC | 12:43 | |
| *** udesale_ has joined #openstack-nova | 12:44 | |
| *** udesale has quit IRC | 12:47 | |
| *** takamatsu has quit IRC | 12:52 | |
| *** jangutter_ has joined #openstack-nova | 12:54 | |
| *** jangutter has quit IRC | 12:58 | |
| *** jmlowe has joined #openstack-nova | 13:00 | |
| *** rcernin has joined #openstack-nova | 13:32 | |
| mnaser | i'm trying to clean up our configs and start using the service catalog for auto discovery of services in nova | 13:36 |
| mnaser | (to stop using glance api_servers) | 13:36 |
| mnaser | "NOTE: The preferred mechanism for endpoint discovery is via keystoneauth1 loading options. Only use api_servers if you need multiple endpoints and are unable to use a load balancer for some reason." | 13:37 |
| mnaser | does this mean i would fill this up like the neutron section? | 13:37 |
| mnaser | or is there a common section? the docs don't seem clera there | 13:37 |
| *** rcernin has quit IRC | 13:37 | |
| sean-k-mooney | are you using haproxy infront of glance api | 13:40 |
| sean-k-mooney | or are you listing multiple glance api_servers | 13:40 |
| sean-k-mooney | mnaser: you will have to fill it in if you are using nova as a loadbalncer for the glance api but ideally you would not use that and instead just deploy haproxy | 13:41 |
| sean-k-mooney | wicch you proably are already doing for other services | 13:41 |
| mnaser | sean-k-mooney: we already have haproxy :) i mainly just dont wanna hardcode the api_servers value and let nova do service discovery | 13:43 |
| *** dave-mccowan has joined #openstack-nova | 13:44 | |
| mnaser | so pretty much just want nova to use the value inside the service catalog | 13:45 |
| sean-k-mooney | mnaser: yep that is what we woudl prefer peopel to do too. some want to remove that config option but other find it useful in small edge deployments | 13:45 |
| gmann | thanks gibi or all the reviews on policy work and updating FIP one. | 13:45 |
| gibi | gmann: thanks for proposing these patches | 13:45 |
| sean-k-mooney | mnaser: the vaule in the service catalog will have to point to the ha proxy ip | 13:46 |
| gmann | gibi: I will do the audit of some TODO/cleanup if there us any by Monday/Tuesday and then we can mark that BP complete. | 13:46 |
| mnaser | sean-k-mooney: so i guess i just have to put in credentials in there the same way that the [neutron] section is filled out with a username/pw/etc? | 13:47 |
| sean-k-mooney | mnaser: you cant list the mupltile api service in the catalonge and get teh same loadbalncing behavior | 13:47 |
| gibi | gmann: cool. thanks | 13:47 |
| mnaser | sean-k-mooney: right, but in my case, we use k8s and the internal api endpoint will always forward to one of the three pods running glance (serviceip) | 13:47 |
| sean-k-mooney | ah ok ya that works | 13:48 |
| mnaser | it would be nice if we can have one section that nova uses for all services | 13:48 |
| mnaser | for those deployments where it makes sense | 13:48 |
| sean-k-mooney | then i think ya you just need to set the auth values but not set the api url | 13:48 |
| mnaser | what's interesting is my current glance section actually has no credentials, only api_servers | 13:49 |
| sean-k-mooney | you might be able to abuse service user for that | 13:49 |
| mnaser | so i wonder where the credentials is being used | 13:49 |
| sean-k-mooney | most of the time it would use the users token and not need them | 13:49 |
| sean-k-mooney | for neutron we do some admin only api calls which need it | 13:49 |
| mnaser | oh yes you're right, i forgot about that | 13:50 |
| sean-k-mooney | for glance i did not think we did but maybe we do for multiple locations | 13:50 |
| mnaser | i think that uses the service_user codebase, | 13:50 |
| sean-k-mooney | i think the rbd direct url/ multi location stuff is either admin only or configurable | 13:51 |
| mnaser | you can configure glance to expose the url | 13:51 |
| mnaser | so i think its not necessarily | 13:51 |
| sean-k-mooney | so what i was suggesting with service_user was | 13:51 |
| sean-k-mooney | if you did not set any other admin auth tokens | 13:51 |
| sean-k-mooney | im not sure if setting service_user config options would be enough | 13:52 |
| sean-k-mooney | if you use the same admin user for all services that is | 13:52 |
| sean-k-mooney | i have never really checked if that would work. | 13:52 |
| mnaser | sean-k-mooney: im actually hoping for a world where we deploy services using app credentials | 13:53 |
| mnaser | based off the main 'admin' user | 13:53 |
| mnaser | essentially its the same thing anyways | 13:53 |
| sean-k-mooney | mnaser: that technical shoudl already work right | 13:55 |
| *** jangutter_ has quit IRC | 13:55 | |
| sean-k-mooney | when you create app creds dont you get a new user name and passward you could use | 13:55 |
| sean-k-mooney | or do you jsut get a bearer token | 13:56 |
| *** gokhani has quit IRC | 13:56 | |
| *** jangutter has joined #openstack-nova | 13:56 | |
| sean-k-mooney | its been quite a while since i looked at them | 13:56 |
| *** k_mouza has joined #openstack-nova | 13:56 | |
| sean-k-mooney | but ya that would be quite nice if it coudl be made to work | 13:57 |
| sean-k-mooney | mnaser: https://docs.openstack.org/keystoneauth/latest/authentication-plugins.html | 13:58 |
| mnaser | sean-k-mooney: it actually should 100% work :) | 13:59 |
| mnaser | keystoneauth does support it yeah | 13:59 |
| *** ociuhandu_ has joined #openstack-nova | 14:00 | |
| *** ociuhandu has quit IRC | 14:01 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add reproducer for bug #1879878 https://review.opendev.org/744950 | 14:07 |
| openstack | bug 1879878 in OpenStack Compute (nova) "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Medium,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane) | 14:07 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/744958 | 14:07 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions https://review.opendev.org/745341 | 14:07 |
| *** k_mouza has quit IRC | 14:14 | |
| *** k_mouza has joined #openstack-nova | 14:15 | |
| *** martinkennelly has quit IRC | 14:25 | |
| *** sapd__x has joined #openstack-nova | 14:28 | |
| lyarwood | elod: https://review.opendev.org/#/q/topic:bug/1889108+status:open - would you have anytime to look at this today | 14:31 |
| lyarwood | elod: I'm including a number of func test refactors here as I'd like to keep things sane going back to stable/train | 14:31 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of tenant networks policies https://review.opendev.org/742765 | 14:37 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in tenant networks policy https://review.opendev.org/742766 | 14:38 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in tenant networks policies https://review.opendev.org/742771 | 14:38 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of security_groups policies https://review.opendev.org/742726 | 14:38 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in security_groups policy https://review.opendev.org/742757 | 14:38 |
| *** dklyle has quit IRC | 14:40 | |
| *** david-lyle has joined #openstack-nova | 14:40 | |
| elod | lyarwood: sure, looking! | 14:40 |
| *** david-lyle is now known as dklyle | 14:41 | |
| lyarwood | elod: thanks! :) | 14:41 |
| *** psachin has quit IRC | 14:58 | |
| *** Guest7899 has joined #openstack-nova | 15:03 | |
| *** Guest7899 is now known as redrobot | 15:06 | |
| *** ralonsoh has quit IRC | 15:08 | |
| *** ralonsoh has joined #openstack-nova | 15:08 | |
| gibi | I'm wrapping up my week now. I'll be on PTO during the next two weeks. See you around 24th! | 15:24 |
| *** gibi is now known as gibi_pto | 15:24 | |
| *** gibi_pto is now known as gibi_pto_til_24t | 15:24 | |
| *** gibi_pto_til_24t is now known as gibi_pto_24th | 15:24 | |
| *** mkrai has joined #openstack-nova | 15:28 | |
| *** rcernin has joined #openstack-nova | 15:34 | |
| *** rcernin has quit IRC | 15:38 | |
| openstackgerrit | Merged openstack/nova master: Add new default roles in security_groups policies https://review.opendev.org/742763 | 15:53 |
| openstackgerrit | Merged openstack/nova master: Pass the actual target in security_groups policy https://review.opendev.org/742764 | 15:53 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of networks policies https://review.opendev.org/742558 | 15:53 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in networks policy https://review.opendev.org/742561 | 15:53 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of volumes policies https://review.opendev.org/742773 | 15:53 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in volumes policy https://review.opendev.org/742774 | 15:53 |
| *** bbowen has quit IRC | 15:56 | |
| *** JamesBenson has quit IRC | 15:57 | |
| openstackgerrit | Merged openstack/nova master: Add new default roles in volumes policies https://review.opendev.org/742777 | 15:58 |
| *** bbowen has joined #openstack-nova | 15:58 | |
| *** dougsz has quit IRC | 16:02 | |
| *** dtantsur is now known as dtantsur|afk | 16:04 | |
| *** mkrai has quit IRC | 16:07 | |
| *** eharney has quit IRC | 16:08 | |
| elod | lyarwood: all good and +2'd :] | 16:10 |
| *** dtantsur|afk has quit IRC | 16:11 | |
| *** hamalq has joined #openstack-nova | 16:12 | |
| *** hamalq has quit IRC | 16:13 | |
| *** hamalq has joined #openstack-nova | 16:13 | |
| *** sapd__x has quit IRC | 16:14 | |
| *** tesseract has quit IRC | 16:25 | |
| openstackgerrit | Merged openstack/nova master: Add test coverage of hosts policies https://review.opendev.org/743013 | 16:29 |
| *** udesale_ has quit IRC | 16:41 | |
| *** tbachman has quit IRC | 17:00 | |
| *** derekh has quit IRC | 17:01 | |
| *** tbachman has joined #openstack-nova | 17:01 | |
| *** ralonsoh has quit IRC | 17:02 | |
| *** suryasingh has quit IRC | 17:03 | |
| *** k_mouza has quit IRC | 17:06 | |
| *** links has quit IRC | 17:09 | |
| openstackgerrit | Elancheran S proposed openstack/nova master: Removes the delta file once image is extracted https://review.opendev.org/734421 | 17:14 |
| *** tbachman_ has joined #openstack-nova | 17:14 | |
| *** tbachman has quit IRC | 17:16 | |
| *** tbachman_ is now known as tbachman | 17:16 | |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in hosts policy https://review.opendev.org/743014 | 17:18 |
| lyarwood | elod: thanks :) | 17:19 |
| smcginnis | Anyone know if the AOE and DISCO libvirt volume drivers are still used/supported? | 17:26 |
| smcginnis | They were both dropped from Cinder a long, long time ago. | 17:26 |
| smcginnis | I was looking at cleaning up some remnants in os-brick, but it looks like there is still some code present in nova. | 17:27 |
| sean-k-mooney | smcginnis: if they were droped form cinder then its dead code | 17:31 |
| lyarwood | I think they are only in nova because they were in cinder and os-brick so rm -rf away | 17:31 |
| lyarwood | yeah | 17:31 |
| sean-k-mooney | smcginnis: nova only uses os-brick for cinder volumes. if the cinder backend is remvoe then the nova code is nolonger useful in general unlesss the code is shared | 17:32 |
| sean-k-mooney | also wehn i see AOE i think fo Age of Empires | 17:33 |
| lyarwood | same haha | 17:34 |
| melwitt | Area Of Effect | 17:35 |
| lyarwood | ^_^ | 17:41 |
| *** mvorwerk has quit IRC | 17:42 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: migrate testing to ubuntu focal https://review.opendev.org/738126 | 17:43 |
| *** k_mouza has joined #openstack-nova | 17:44 | |
| *** mvorwerk has joined #openstack-nova | 17:45 | |
| *** k_mouza has quit IRC | 17:49 | |
| openstackgerrit | Merged openstack/nova master: Add new default roles in hosts policies https://review.opendev.org/743015 | 17:54 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of extensions policies https://review.opendev.org/743045 | 17:54 |
| lyarwood | melwitt: https://review.opendev.org/#/q/topic:bug/1889108+status:open - would you mind taking a look at that today if you have time | 18:01 |
| melwitt | lyarwood: sure thing | 18:01 |
| lyarwood | thanks | 18:02 |
| smcginnis | sean-k-mooney, lyarwood: Thanks, sounds good. | 18:06 |
| smcginnis | Do you think it needs to go through a deprecation cycle in nova? Or since it's just dead code anyway, all clear to just clean it out? | 18:06 |
| lyarwood | smcginnis: I think we can just remove it tbh | 18:08 |
| smcginnis | Sounds good. I'll put up something to do that. Then we can see if anyone has any objects on the patch. | 18:09 |
| lyarwood | smcginnis: the only way of loading these volume drivers is through cinder providing connection_info with driver_volume_type set to aoe or disco https://github.com/openstack/nova/blob/09ed4c21db5005b1c699a87bfb0e7cb051553342/nova/virt/libvirt/driver.py#L1593-L1597 | 18:09 |
| lyarwood | smcginnis: if the c-vol drivers are dead then that can't happen | 18:09 |
| smcginnis | Ah, that's how that works. Thanks, I've never dug into the nova side of these things. | 18:09 |
| smcginnis | So this really has been dead code for quite awhile then. | 18:10 |
| lyarwood | yup | 18:10 |
| lyarwood | smcginnis: actually thinking about it they were dropped more than a release ago from cinder right? | 18:11 |
| * lyarwood was thinking about the upgrade case | 18:11 | |
| smcginnis | Yeah. Like Ocata for some. | 18:11 |
| lyarwood | ha | 18:11 |
| lyarwood | okay rm -rf away sorry | 18:11 |
| smcginnis | There might be more than those two, but if there's anything I see that hasn't been gone since at least Stein, I'll leave it for later cleanup. | 18:12 |
| lyarwood | smcginnis: are the removals from cinder tracked anywhere outside of the releasenotes btw? Like an easy to read support table or something | 18:15 |
| smcginnis | We've started just marking them as unsupported, so there haven't been any new removals for at least a cycle now. | 18:16 |
| smcginnis | I think we did document the older ones though. Let me see if I can find that. | 18:16 |
| smcginnis | Probably incomplete though. I had to dig a bit to even figure out what the AOE connector was. | 18:17 |
| smcginnis | (assumed we didn't connect to the game ;) ) | 18:17 |
| lyarwood | haha | 18:20 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of FIP pools policies https://review.opendev.org/741795 | 18:23 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of baremetal nodes policies https://review.opendev.org/741707 | 18:23 |
| smcginnis | lyarwood: Some incomplete driver removal history: https://docs.openstack.org/cinder/latest/reference/support-matrix.html#driver-removal-history | 18:33 |
| openstackgerrit | Merged openstack/os-vif master: [goal] migrate testing to ubuntu focal https://review.opendev.org/738130 | 18:36 |
| lyarwood | smcginnis: thanks | 18:42 |
| *** bjolo has quit IRC | 18:42 | |
| openstackgerrit | Sean McGinnis proposed openstack/nova master: Remove dead volume driver code https://review.opendev.org/745393 | 19:01 |
| *** slaweq has quit IRC | 19:03 | |
| *** slaweq has joined #openstack-nova | 19:06 | |
| *** viks____ has quit IRC | 19:10 | |
| openstackgerrit | Merged openstack/nova master: Fix multinic policy for admin_or_owner https://review.opendev.org/742317 | 19:30 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of multinic policies https://review.opendev.org/742315 | 19:30 |
| openstackgerrit | Merged openstack/nova master: Pass the actual target in tenant networks policy https://review.opendev.org/742772 | 19:30 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in FIP pools https://review.opendev.org/741796 | 19:30 |
| *** KeithMnemonic has quit IRC | 19:31 | |
| *** mloza has joined #openstack-nova | 19:32 | |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in baremetal node https://review.opendev.org/741709 | 19:38 |
| mloza | hello, I have running instance which is launched with a invalid AZ and now, I can't do live migration. Where can I fix the issue in the db? | 19:40 |
| *** k_mouza has joined #openstack-nova | 19:45 | |
| *** slaweq has quit IRC | 19:50 | |
| *** k_mouza has quit IRC | 19:50 | |
| *** slaweq has joined #openstack-nova | 19:58 | |
| *** bbowen has quit IRC | 20:00 | |
| *** slaweq has quit IRC | 20:15 | |
| mnaser | mloza: i didn't tell you this but nova.instances.availability_zone | 20:30 |
| mnaser | that is an ID though | 20:30 |
| mnaser | mloza: but you can use an id from one that you know is right, but its friday and you should play with db :) | 20:32 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in multinic policy https://review.opendev.org/742328 | 21:04 |
| *** maciejjozefczyk has quit IRC | 21:10 | |
| *** raildo has quit IRC | 21:21 | |
| *** mvorwerk has quit IRC | 21:25 | |
| mloza | mnaser: it shows the correct AZ in the nova db | 21:26 |
| mnaser | maybe check nova_api | 21:26 |
| mloza | look like its in nova_api db, it's the request_specs table which shows the invalid AZ | 21:27 |
| mloza | manage to get it corrected | 21:27 |
| mloza | update request_specs set spec = replace (spec,'"availability_zone": "old-name"','"availability_zone": "new-name"') where instance_uuid = 'xxxxxxxxxxxxxxx'; | 21:27 |
| *** rcernin has joined #openstack-nova | 21:47 | |
| *** rcernin has quit IRC | 22:26 | |
| *** spatel has joined #openstack-nova | 22:27 | |
| *** rcernin has joined #openstack-nova | 22:32 | |
| *** spatel has quit IRC | 22:32 | |
| *** tosky has quit IRC | 22:58 | |
| *** artom has quit IRC | 23:00 | |
| *** k_mouza has joined #openstack-nova | 23:10 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove host CPU checks during check_can_live_migrate_destination https://review.opendev.org/745431 | 23:14 |
| *** k_mouza has quit IRC | 23:14 | |
| *** rcernin has quit IRC | 23:38 | |
| *** rcernin has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!