Thursday, 2020-08-06

openstackgerritLee Yarwood proposed openstack/nova master: WIP zuul: nova-evacuate  https://review.opendev.org/74488300:04
*** hamalq has quit IRC00:18
*** brinzhang0 has joined #openstack-nova00:29
*** tetsuro has joined #openstack-nova00:32
*** brinzhang_ has quit IRC00:32
*** songwenping_ has joined #openstack-nova00:37
*** songwenping__ has joined #openstack-nova00:40
*** swp20 has quit IRC00:41
*** Liang__ has joined #openstack-nova00:41
*** songwenping_ has quit IRC00:43
*** songwenping_ has joined #openstack-nova01:37
*** songwenping__ has quit IRC01:40
*** kaisers has quit IRC02:01
*** yaawang has quit IRC02:05
*** yaawang has joined #openstack-nova02:06
*** yaawang has quit IRC02:10
*** yaawang has joined #openstack-nova02:11
*** spatel has joined #openstack-nova02:13
*** yaawang has quit IRC02:15
*** yaawang has joined #openstack-nova02:16
*** markvoelker has quit IRC02:26
*** Yumeng has joined #openstack-nova02:31
*** Liang__ has quit IRC02:59
*** songwenping_ has quit IRC03:02
*** songwenping_ has joined #openstack-nova03:02
*** spatel has quit IRC03:02
*** songwenping_ has quit IRC03:03
*** songwenping_ has joined #openstack-nova03:03
*** songwenping_ has joined #openstack-nova03:04
*** xinranwang__ has joined #openstack-nova03:06
*** brinzhang_ has joined #openstack-nova03:08
*** brinzhang0 has quit IRC03:10
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs  https://review.opendev.org/69346003:20
*** psachin has joined #openstack-nova03:31
*** markmcclain has quit IRC03:31
*** mkrai has joined #openstack-nova03:31
*** markmcclain has joined #openstack-nova03:35
*** gyee has quit IRC03:50
*** rcernin has quit IRC04:03
*** mkrai has quit IRC04:23
*** rcernin has joined #openstack-nova04:24
*** mkrai has joined #openstack-nova04:26
*** ratailor has joined #openstack-nova04:30
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** links has joined #openstack-nova04:51
*** efried has quit IRC05:05
*** ociuhandu has joined #openstack-nova05:15
*** ociuhandu has quit IRC05:20
*** efried has joined #openstack-nova05:24
*** links has quit IRC05:30
*** links has joined #openstack-nova05:47
*** mlycka has joined #openstack-nova05:48
brinzhang_alex_xu: hi, do you know why this patch didnot run zuul +2? https://review.opendev.org/#/c/744280/05:54
brinzhang_is it due to the tag of Signed-off-by?05:55
*** mkrai has quit IRC05:59
*** mkrai_ has joined #openstack-nova05:59
*** brinzhang0 has joined #openstack-nova06:07
*** vishalmanchanda has joined #openstack-nova06:09
*** brinzhang_ has quit IRC06:10
*** udesale has joined #openstack-nova06:18
*** dklyle has quit IRC06:39
*** ociuhandu has joined #openstack-nova06:41
*** yaawang has quit IRC06:44
*** yaawang has joined #openstack-nova06:44
*** xiaolin has quit IRC06:49
*** slaweq has joined #openstack-nova06:53
*** rcernin has quit IRC06:54
*** tesseract has joined #openstack-nova07:03
*** tetsuro has quit IRC07:09
gibibrinzhang0: I don't think that Signed-off stops zuul.07:18
*** rcernin has joined #openstack-nova07:20
brinzhang0gibi: thanks. I dont know which stoped zuul to go :(07:20
*** maciejjozefczyk has joined #openstack-nova07:20
brinzhang0gibi: Do you have time to check?07:21
*** Liang__ has joined #openstack-nova07:21
*** mvorwerk has joined #openstack-nova07:23
*** rcernin has quit IRC07:25
*** xinranwang__ has quit IRC07:25
*** brinzhang_ has joined #openstack-nova07:29
*** nightmare_unreal has joined #openstack-nova07:29
*** dtantsur|afk is now known as dtantsur07:30
*** brinzhang0 has quit IRC07:32
*** brinzhang has joined #openstack-nova07:32
*** ociuhandu has quit IRC07:33
gibibrinzhang_: honestly I don't know where to look. I suggest to do a recheck, or even better fix the commit message according to stephenfin's comments and that will retrigger zuul07:34
*** brinzhang_ has quit IRC07:34
*** avolkov has joined #openstack-nova07:39
*** dougsz has joined #openstack-nova07:44
*** tosky has joined #openstack-nova07:46
*** ralonsoh has joined #openstack-nova07:47
*** ralonsoh has quit IRC07:48
*** udesale has quit IRC07:50
*** udesale has joined #openstack-nova07:50
*** jraju__ has joined #openstack-nova07:51
*** links has quit IRC07:52
*** ociuhandu has joined #openstack-nova07:54
*** Yumeng has quit IRC07:57
*** udesale has quit IRC08:00
*** udesale has joined #openstack-nova08:00
openstackgerritBrin Zhang proposed openstack/nova master: [Trivial] Remove wrong format_message() conversion  https://review.opendev.org/74428008:01
*** takamatsu has quit IRC08:02
brinzhanggibi: thanks, updated, and removed the singned-off-by, can you +2 for it?08:02
gibisure08:03
brinzhanggibi: thanks ^^08:04
*** sapd__x has joined #openstack-nova08:04
gibidoen08:04
gibidone08:05
gibiI hope zuul will pick it up this time08:05
*** ralonsoh has joined #openstack-nova08:06
brinzhanggibi: cool, looks the zuu can be run08:06
brinzhangbefore I rechecked it, and it also in zuul +1 status, I guess because of the signed-of-by, but Iam not sure08:07
*** jraju__ has quit IRC08:13
*** Liang__ has quit IRC08:17
*** Liang__ has joined #openstack-nova08:18
*** links has joined #openstack-nova08:23
*** belmoreira has joined #openstack-nova08:25
*** links has quit IRC08:29
*** priteau has joined #openstack-nova08:29
*** derekh has joined #openstack-nova08:30
*** osmanlicilegi has quit IRC08:32
*** xek has joined #openstack-nova08:35
*** links has joined #openstack-nova08:36
*** jraju__ has joined #openstack-nova08:42
*** arxcruz|off is now known as arxcruz08:42
*** links has quit IRC08:42
*** iurygregory has quit IRC08:51
openstackgerritStephen Finucane proposed openstack/nova master: Follow up for Ibf8dca4bd57b3bddb39955b53cc03564506f5754  https://review.opendev.org/74509508:54
*** takamatsu has joined #openstack-nova08:58
*** links has joined #openstack-nova08:59
*** jraju__ has quit IRC09:00
*** iurygregory has joined #openstack-nova09:02
*** jraju__ has joined #openstack-nova09:04
*** links has quit IRC09:04
*** takamatsu has quit IRC09:07
*** takamatsu has joined #openstack-nova09:07
*** k_mouza has joined #openstack-nova09:10
*** osmanlicilegi has joined #openstack-nova09:10
*** jangutter_ has joined #openstack-nova09:12
*** xek has quit IRC09:12
*** jangutter has quit IRC09:14
*** gokhani has joined #openstack-nova09:21
*** efried has quit IRC09:25
*** efried has joined #openstack-nova09:25
*** jangutter has joined #openstack-nova09:46
*** jangutter_ has quit IRC09:46
*** jangutter_ has joined #openstack-nova09:46
*** jangutter has quit IRC09:50
openstackgerritStephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary  https://review.opendev.org/74495809:52
*** takamatsu has quit IRC09:53
kashyapstephenfin: I think you used the change ID in the commit summary because it is not yet merged?10:00
stephenfinkashyap: No. I just wanted something to link back to the original patch for context10:01
kashyapI personally find it strange to see such a large change ID as part of commit summary.  How about "Follow-up for "Lookup nic feature by PCI address" patch10:01
stephenfinI could, though the change ID allows you to click through to the original change10:02
kashyapYeah, I see the value; but recall: we also have to bear in mind the "guy working from the woods" w/ no internet connection :-)  - all needed info present w/ no clicking required10:03
kashyapI'd personally put it in the commit body.  But I let you decide here.10:05
*** k_mouza has quit IRC10:06
*** markvoelker has joined #openstack-nova10:11
*** martinkennelly has joined #openstack-nova10:11
*** k_mouza has joined #openstack-nova10:18
sean-k-mooneystephenfin: they are on the same topic so at least in gerrit its easy to find10:19
sean-k-mooneyoh you are folding back in the funcion10:20
sean-k-mooneyya makes sense10:20
*** markvoelker has quit IRC10:21
sean-k-mooneystephenfin: by the way you realise that mypy support ducktyping10:27
stephenfinI do. What's the context?10:27
sean-k-mooneyyour responce to melwitt about not using mypy in tests10:28
sean-k-mooneyso ducktyping would not be an issue10:28
sean-k-mooneymock proably would be10:28
stephenfinIt would if the code expects a Instance object and we're passing a dict or a string10:28
sean-k-mooneybut if we create a local class and implement the same interface it would pass10:28
stephenfinwhich we do in placement10:28
stephenfin*places10:28
stephenfinPossibly, but that would be so much work10:29
sean-k-mooneyi know10:29
sean-k-mooneyi just mean if the thing we pass ducktypes to the real thing it will pass10:29
sean-k-mooneyif it does not we proably should not be passing it now :)10:29
sean-k-mooneyim hoping we ill graduly stop passing incorrect types in tests10:30
sean-k-mooneyim not going to hold my breath but i can hope10:30
openstackgerritMerged openstack/nova master: Lookup nic feature by PCI address  https://review.opendev.org/73913110:33
sean-k-mooney:)10:33
*** Liang__ has quit IRC10:33
*** tkajinam has quit IRC10:33
mlyckaHello, would anyone be kind enough to advise me on how one would go about getting a freeze exception for a spec?10:44
gibimlycka: what is the spec in question?10:46
gibimlycka: in general we will make decisions about spec freeze exception request on the today's nova meeting10:46
mlyckagibi: https://review.opendev.org/#/c/702810/10:46
mlyckaI was told by a Mr. Yarwood to go ahead and ask for an exception10:46
lyarwood\o ./me waves10:48
sean-k-mooneymlycka: johnthetubaguy  still had some concerns about why we are now taking a different approch then was previously apporved10:48
gibimlycka, lyarwood: does the sync - async problem was resolved in the spec?10:48
mlyckagibi: I think the idea was to treat is as sync for now and see where that gets us. The spec allows for a change later on during implementation.10:50
gibimlycka: I will add it to the meeting agenda. but we would need johnthetubaguy and Groka to check your answers to their questions as now we have -1s on the patch10:51
mlyckagibi: Right right, thank you. Should I contact them directly or are they likely to be present in the meeting?10:52
lyarwoodmlycka: well the os-server-external-events API that you're using is async so I don't see how this could ever be sync tbh10:52
sean-k-mooneythat api is not for enduser to invoke10:52
sean-k-mooneyits for other services10:53
lyarwoodand that's also a valid point that I missed10:53
gibimlycka: given that it is summer I don't think they will get back to the spec today or tomorrow10:53
mlyckaYeah, I think a separate endpoint is probably the way to go.10:53
sean-k-mooneymlycka: quiesing a vm shoudl be a server action10:53
sean-k-mooneyas would undoing it10:53
sean-k-mooneylike pause and unpause10:54
mlyckasean-k-mooney: What do you mean? Yeah, it would have to be done by the VM.10:54
sean-k-mooneyhttps://docs.openstack.org/api-ref/compute/#servers-run-an-action-servers-action10:54
sean-k-mooneyi mean you should be extending /servers/{server_id}/action10:55
mlyckaOkay, that doesn't sound unreasonable. Any objections?10:57
*** markvoelker has joined #openstack-nova10:57
*** ratailor has quit IRC10:57
sean-k-mooneyi object to you using the event api :) but other then that no  :)10:57
mlyckaSure, makes sense. I won't have the time change the spec today, but I should be able to get to it tomorrow10:58
lyarwoodmlycka: would you also be able to start posting code for this?10:59
*** ociuhandu has quit IRC11:00
mlyckalyarwood: I mean, not tomorrow but yeah, by next week I could start producing code.11:00
lyarwoodkk11:00
*** ociuhandu has joined #openstack-nova11:01
sean-k-mooneymlycka: by the way the fact you used the service only external events api is proably why peopel assume this is only for use with cinder11:03
mlyckasean-k-mooney: Might be. I think I misunderstood the use of that endpoint when I first found out about it.11:04
sean-k-mooneyya that is why we have the warning https://docs.openstack.org/api-ref/compute/?expanded=add-associate-floating-ip-addfloatingip-action-deprecated-detail#create-external-events-os-server-external-events11:04
mlyckaYep yep, clearly a reading comprehension failure on my part.11:05
*** sapd__x has quit IRC11:06
*** ociuhandu has quit IRC11:06
*** takamatsu has joined #openstack-nova11:06
*** xek has joined #openstack-nova11:07
*** markvoelker has quit IRC11:09
*** jangutter_ has quit IRC11:11
*** jangutter has joined #openstack-nova11:12
*** xek has quit IRC11:15
openstackgerritsean mooney proposed openstack/os-vif master: support pyroute2 0.5.13  https://review.opendev.org/74480911:21
openstackgerritsean mooney proposed openstack/nova stable/train: catch libvirt exception when nodedev not found.  https://review.opendev.org/74511611:24
*** mkrai_ has quit IRC11:25
*** mkrai_ has joined #openstack-nova11:25
*** brinzhang_ has joined #openstack-nova11:32
*** brinzhang has quit IRC11:35
*** ratailor has joined #openstack-nova11:37
*** ociuhandu has joined #openstack-nova11:38
*** artom has quit IRC11:42
*** mkrai_ has quit IRC11:44
*** ociuhandu has quit IRC11:44
*** JamesBenson has quit IRC11:48
*** k_mouza has quit IRC11:50
*** martinkennelly has quit IRC12:00
*** xek has joined #openstack-nova12:00
*** raildo has joined #openstack-nova12:01
*** artom has joined #openstack-nova12:02
*** udesale_ has joined #openstack-nova12:03
*** k_mouza has joined #openstack-nova12:03
*** udesale has quit IRC12:05
*** bbowen has quit IRC12:07
*** rcernin has joined #openstack-nova12:08
*** nweinber has joined #openstack-nova12:17
*** ralonsoh has quit IRC12:26
*** ralonsoh has joined #openstack-nova12:26
*** ociuhandu has joined #openstack-nova12:28
*** bbowen has joined #openstack-nova12:32
artomDammit, we never updated the emulator thread policy flavor extra spec docs following the CPU resources patches: https://docs.openstack.org/nova/ussuri/user/flavors.html12:35
artom(Scroll down to Emulator threads policy)12:36
*** dave-mccowan has joined #openstack-nova12:36
sean-k-mooneyartom: well its still technically correct12:36
sean-k-mooneyartom: it just does not mention that the second half is only true12:36
artomOnly if cpu_dedicated_set isn't also set12:36
sean-k-mooneyif you use vcpu_pin_set12:36
sean-k-mooneycorrect12:36
artomAnd what's the point of documenting the old legacy behavior12:37
sean-k-mooneyvcpu_pin_set is deprecated not removed and we default to the legacy behavior12:37
artomI suppose12:37
artomStill, stuff is definitely missing12:37
sean-k-mooneystephen can update it when he removes vcpu_pin_set in a few weeks12:37
sean-k-mooneyi guess you could update them to make it clear for train and ussuri before that12:38
sean-k-mooneybut its not going to be very useful on master since it wont matter when victoria is released12:39
artomTrue12:43
sean-k-mooneyi guess you could look at it as motivation12:43
sean-k-mooneyif you want to impove it better do it quick before its gone12:43
*** efried has quit IRC12:45
artomI need waaaay stronger motivation than that :P12:46
artomImproving something only for it to disappear is not motivating :)12:46
*** mkrai has joined #openstack-nova12:46
artomI realize that taken to the extreme I've just endorsed nihilism, but...12:46
*** efried has joined #openstack-nova12:49
*** ratailor has quit IRC12:49
openstackgerritsean mooney proposed openstack/nova master: remove deprecated schduler filters  https://review.opendev.org/74480012:50
*** links has joined #openstack-nova12:52
*** jraju__ has quit IRC12:53
lyarwoodcan I just edit https://wiki.openstack.org/wiki/Meetings/Nova with agenda items for todays meeting?13:10
* lyarwood always forgets what the process is upstream13:10
stephenfinlyarwood: yup13:14
lyarwoodstephenfin: cool done thanks13:15
*** mkrai has quit IRC13:21
*** ralonsoh has quit IRC13:22
*** jangutter_ has joined #openstack-nova13:30
*** jangutter has quit IRC13:34
openstackgerritMerged openstack/nova master: compute: As cellsv1 is no more fold _detach_volume back into detach_volume  https://review.opendev.org/73150613:37
*** mlycka has quit IRC13:37
*** Luzi has joined #openstack-nova13:40
*** rcernin has quit IRC13:40
artomstephenfin, we're not proposing bauzas's routed networks scheduling spec for exception?13:43
sean-k-mooneyi would have expected bauzas to do that13:43
artomPTO13:44
*** ralonsoh has joined #openstack-nova13:44
sean-k-mooneyoh then yes we should13:44
sean-k-mooneyhe was hoping that gibi would readd his +2 on monday13:44
sean-k-mooneyi think13:44
artomI don't recall anyone except stephenfin being +213:45
kashyaplyarwood: Hey, do you remember: when you cold-migrate an instance, will it in the end do a 'rebuild' on the destination?  (/me goes to check the code)13:45
gibisean-k-mooney: ohh, I missed that13:45
sean-k-mooneyartom: gibi was +2 on v413:45
sean-k-mooneygibi: we were ment to ping you to remind you, bauzas asked us too since he is on PTO13:46
sean-k-mooneyi mean we can still request an exception it technically needs one13:46
gibiI will check it shortly and if I'm OK with it then I will ask for an exception on the todays meeting13:46
lyarwoodkashyap: resize13:55
*** jangutter has joined #openstack-nova13:55
lyarwoodkashyap: https://github.com/openstack/nova/blob/9ecefeb836964c52a5a2969b15c82b11c51d32ab/nova/api/openstack/compute/migrate_server.py#L76-L7713:55
artomlyarwood, could you revisit https://review.opendev.org/#/c/729763/11 when you get a chance? I didn't actually address any of your feedback, but hopefully my reasons make sense to you13:57
artomstephenfin, ^^ same request, though I did fix the nit13:58
*** jangutter_ has quit IRC13:58
*** mkrai has joined #openstack-nova13:58
lyarwoodartom: yup was waiting for my changes to actually land before I went back to it14:01
lyarwoodartom: I'll hit it this afternoon14:01
*** artom has quit IRC14:05
*** artom has joined #openstack-nova14:05
sean-k-mooneyanyone rememebr off the top of there head when placment became required?14:10
sean-k-mooneywas it pike?14:10
lyarwoodsean-k-mooney: ocata  I think14:11
*** mkrai has quit IRC14:11
sean-k-mooneycool and  prefilters were added in rocky right14:12
*** mkrai has joined #openstack-nova14:12
*** brinzhang0 has joined #openstack-nova14:12
*** brinzhang_ has quit IRC14:15
sean-k-mooneyyes they were.14:16
*** xek has quit IRC14:17
*** mvorwerk has quit IRC14:23
*** mvorwerk has joined #openstack-nova14:25
*** links has quit IRC14:27
*** mvorwerk has quit IRC14:32
*** links has joined #openstack-nova14:34
*** links has quit IRC14:34
openstackgerritStephen Finucane proposed openstack/os-vif master: mypy: Add type annotations  https://review.opendev.org/74516214:40
openstackgerritStephen Finucane proposed openstack/os-vif master: mypy: Extend type annotations to 'vif_plug_noop'  https://review.opendev.org/74516314:40
*** psachin has quit IRC14:43
openstackgerritMerged openstack/os-vif master: support pyroute2 0.5.13  https://review.opendev.org/74480914:45
*** dklyle has joined #openstack-nova14:51
*** suryasingh has joined #openstack-nova14:54
*** belmoreira has quit IRC15:06
suryasinghHello Team15:12
suryasinghSorry to interrupt in middle of your work.15:12
suryasinghI have a query about downsizing the nova instance.15:12
suryasinghWhen I downsize with —poll status comes out to be Finished. But confirming the the same fails with below error.15:12
suryasinghERROR (Conflict): Cannot 'confirmResize' instance eaff75ba-1e16-4096-8882-33028d8b97fd while it is in vm_state active (HTTP 409) (Request-ID: req-71f53b9c-d01d-4bfe-a22c-b62401545f3c)15:12
suryasinghSo I just wanted to confirm, if it’s feasible operation from nova side and if not, is there any historical reason of it to not support downsize operation ?15:12
*** mlavalle has joined #openstack-nova15:19
*** Luzi has quit IRC15:22
suryasinghmelwitt:  dansmith lyarwood gmann efried   would be very thankful if any of you respond to my query.15:26
gibisuryasingh: do you try to downsize the disk in the flavor?15:27
suryasingh@gibi whole flavor including disk.15:27
lyarwoodyeah I didn't think we supported down sizing tbh15:28
lyarwoodwe can't downsize the disk at least15:28
*** jangutter_ has joined #openstack-nova15:28
gibithe resize action fails if you try to decrease the disk size with 'Resize error: Unable to resize disk down.'15:28
gibithe cpu and memory can be downsized15:28
sean-k-mooneyyou can downsize the ram or cpus15:29
sean-k-mooneybut not the disk15:29
sean-k-mooneyas that would loose data potentially15:29
sean-k-mooneyoh gibi just said that15:29
* gibi even tried that! :)15:30
suryasinghgibi: sean-k-mooney lyarwood  understood. Thanks for responding to query.15:30
*** jangutter has quit IRC15:31
stephenfinDoes anyone care to sanity check this idea for me? I end up wanting the feature every time I have to use osc-placement (along with auto-translation of RP names to UUIDs, but that's more work) https://review.opendev.org/#/c/743976/15:37
stephenfinAs an aside, there are a quite a few patches queued up for review at https://review.opendev.org/#/q/is:open+project:openstack/osc-placement15:38
*** mkrai has quit IRC15:44
gibinova meeting starts in 10 minutes on #openstack-meeting-315:50
*** penick has joined #openstack-nova15:54
gibistephenfin: https://review.opendev.org/#/c/743976/ work for me. Also I can pay (with some review time) for the RP name -> uuid translation in the client15:57
*** udesale_ has quit IRC16:01
*** penick has quit IRC16:03
*** penick has joined #openstack-nova16:04
sean-k-mooneygibi: i the neutron docs are confusing on the ip allocation policy. i think i saw one place refecne that neutorn would do it automaticlly but i know when it was first added it needed to be set manually16:09
gibisean-k-mooney: I don't have my  mutlisegment test env working so I cannot check right now but as far as I remember I had to set it manually16:10
*** iurygregory has quit IRC16:10
*** iurygregory has joined #openstack-nova16:11
sean-k-mooneyok nova does not actully support multisegment prodier netwroks correctly16:12
sean-k-mooneyif you try to use them it will fail in at least two cases16:12
sean-k-mooneysriov16:12
sean-k-mooneyand if one host has 2 phsynets it wont work right16:13
sean-k-mooneyalso numa_aware_vswitch or anything that depens on the phsynet wont work properly16:13
sean-k-mooneybut ya that as seperate problem16:13
gibiI guess I never tried with two physnets then16:15
*** nightmare_unreal has quit IRC16:16
*** hamalq has joined #openstack-nova16:17
sean-k-mooneygibi: we just grap the first physnet form the list in nova16:17
sean-k-mooneyso if a network has more then one phsynet then there is no guarenttee that it will be correct.16:18
sean-k-mooneythe current hack that existsi assuem that we will have at most 1 provider network and 1 tunnel network  but not multipele provider networks16:19
*** hamalq has quit IRC16:19
*** hamalq has joined #openstack-nova16:20
gibiwould it make sense to have two provide segment in the same network?16:23
*** dougsz has quit IRC16:29
sean-k-mooneyyes that is what the routed provider netwrok feature in neturon is for16:40
sean-k-mooneyit uses physnets to map hosts to segments16:40
sean-k-mooneythere is no other way to map host to segments that i have found16:40
*** k_mouza has quit IRC16:45
*** gyee has joined #openstack-nova16:51
*** bbowen has quit IRC16:54
*** JamesBenson has joined #openstack-nova16:56
openstackgerritGhanshyam Mann proposed openstack/os-vif master: [goal] migrate testing to ubuntu focal  https://review.opendev.org/73813016:58
gmannsean-k-mooney: ^^ need re Approved16:59
sean-k-mooneyalready done16:59
gmannthanks16:59
sean-k-mooneygmann: also nova core technically are os-vif cores although we bacsically just ask you to use your judgement. if you feel comfortably approving you can if not then you dont have too :)17:00
sean-k-mooneyos-vif review is totally optional17:00
*** derekh has quit IRC17:01
gmannsean-k-mooney: sure. as long as you are on irc (which is always :p) i am ok to bother you17:02
sean-k-mooneyyep happy to be pinged about os-vif17:03
*** dtantsur is now known as dtantsur|afk17:03
sean-k-mooneyoh i got the github "Arctic Code Vault Contributor" badge :) that is cool now in 1000 year peopel will see my terrible code and be equally stumped as we are now to how that ever worked :)17:05
sean-k-mooneyhttps://archiveprogram.github.com/17:05
sean-k-mooneyi wonder what version of nova the archived17:05
sean-k-mooneyoh it was master from 02/02/202017:07
sean-k-mooneyhuh that a pallandrome im sure they did that intentionally17:08
gibiohh, that was my brithday too :)17:08
sean-k-mooneynice17:11
*** penick has quit IRC17:19
*** martinkennelly has joined #openstack-nova17:20
*** k_mouza has joined #openstack-nova17:21
*** k_mouza has quit IRC17:26
*** priteau has quit IRC17:27
* gibi ends for today17:48
lyarwood\o17:52
*** tesseract has quit IRC17:53
openstackgerritMerged openstack/nova-specs master: Routed network scheduling spec  https://review.opendev.org/73370317:54
*** grandchild has joined #openstack-nova18:00
*** ralonsoh has quit IRC18:06
*** artom has quit IRC18:12
*** artom has joined #openstack-nova18:13
*** k_mouza has joined #openstack-nova18:19
*** artom has quit IRC18:23
*** k_mouza has quit IRC18:23
*** k_mouza has joined #openstack-nova18:29
*** gmann is now known as gmann_afk18:35
*** artom has joined #openstack-nova18:44
lyarwooddoes anyone know what the file paths for file backed memory look like in Nova?18:49
lyarwoodis it specific to the instance?18:49
*** k_mouza has quit IRC18:51
sean-k-mooneylyarwood: yes they are18:55
sean-k-mooneythey are generated by libvirt18:55
lyarwoodwonderful18:55
sean-k-mooneywith one per numa node18:55
sean-k-mooneythe are in the instance directory18:56
sean-k-mooneywhy do you ask18:56
sean-k-mooneythats one per guest numa node by the way18:56
lyarwoodoh no reason18:56
sean-k-mooneythere si a libvirt config option memory_backing_dir that you can set to chooese where to put them18:57
*** vishalmanchanda has quit IRC18:57
*** k_mouza has joined #openstack-nova18:58
*** avolkov has quit IRC18:59
*** k_mouza has quit IRC19:08
*** artom has quit IRC19:11
*** artom has joined #openstack-nova19:14
artomstephenfin, so you're saying you'll edit out the typing stuff when you backport https://review.opendev.org/#/c/744958/ ?19:14
artomI mean, I'd have done it right away by doing 2 patches, but w/e works19:14
stephenfinartom: Yup, though only because I have to for Train (it's not Python 3-only)19:16
stephenfinIf it was, I'd leave them since they're a noop until mypy is enabled for that file (via mypy-files.txt)19:16
artomstephenfin, ack, I'll remove my -1 then. I still don't fully get the problem/fix though :P19:17
stephenfina second patch is also doable, but I find the type hints help understand what's getting passed around19:17
stephenfinI'm replying with that now19:17
artomYeah, I can understand that (the typing hints helping)19:17
stephenfinartom: comments left. Let me know if that makes sense19:19
*** tosky has quit IRC19:20
artomstephenfin, ah, I think I get it - we don't "delta" the usage, we rebuild it from scratch every time. So if a certain migration/instance doesn't get counted as "tracked", it'll effectively unpin its PCPUs19:20
stephenfinYup, exactly19:21
artomOK, great, so that's 1 hour to understand the concept.19:21
artomNow to review the actual code :P19:21
artomNeed to pick up food first though19:22
stephenfinTBH, that whole periodic task feels racy and generally wrong to me, but it does state that it's intention is to blow everything away and start from scratch so...19:22
stephenfinyet another thing to add my "tech debt I really need to get back to" list, I guess19:22
artomIt's definitely not the first race in there19:23
artomSee: https://review.opendev.org/#/c/684409/19:23
stephenfinFor sure. I decided not to start listing the related bugs of the related bugs, because it started getting ridiculous19:23
stephenfinconcurrency is hard19:24
artomYeah, chill with that, you trying to one-up George RR Martin or something?19:24
stephenfinTry to write an explanation for https://review.opendev.org/744021 (with other nova devs that don't have this specific libvirt CPU pinning knowledge in mind) and let me know how you get on :P19:26
* stephenfin goes back to soldering stuff19:29
sean-k-mooneystephenfin: speaking about racy periodics19:44
sean-k-mooneyits possible that we have a race between them starting in general on inital boot and the compute agent looking up it compute node uuid or maybe even creating the compute node record19:45
sean-k-mooneyi say its posible becuase im expecting a bug to be filed for http://pastebin.test.redhat.com/89123719:46
sean-k-mooneyand that is my working theory on how we could be trying to update a compute node recored with a compute_node_id of none19:47
sean-k-mooneyoh but that one does not have have startup set....19:49
sean-k-mooneyhttps://github.com/openstack/nova/blob/9ecefeb836964c52a5a2969b15c82b11c51d32ab/nova/compute/manager.py#L972319:49
*** bbowen has joined #openstack-nova19:49
sean-k-mooneyand it gets the compute nodes at the start https://github.com/openstack/nova/blob/9ecefeb836964c52a5a2969b15c82b11c51d32ab/nova/compute/manager.py#L9697-L970019:49
sean-k-mooneywell that theroy did not last long19:50
sean-k-mooneyoh i did not read that write it was trying to insert a default consturced/empty pci deivcie object19:52
*** nweinber has quit IRC19:53
sean-k-mooneytommorows problem19:54
*** dave-mccowan has quit IRC20:19
*** dave-mccowan has joined #openstack-nova20:20
*** xek has joined #openstack-nova20:40
*** k_mouza has joined #openstack-nova21:09
*** k_mouza has quit IRC21:14
*** rcernin has joined #openstack-nova21:21
*** slaweq has quit IRC21:23
*** rcernin has quit IRC21:27
*** xek has quit IRC21:33
*** rcernin has joined #openstack-nova21:34
*** martinkennelly has quit IRC21:39
*** rcernin has quit IRC21:42
*** ociuhandu_ has joined #openstack-nova22:03
*** dklyle has quit IRC22:04
*** ociuhandu has quit IRC22:04
*** dklyle has joined #openstack-nova22:09
*** rcernin has joined #openstack-nova22:11
*** hoonetorg has quit IRC22:15
*** rcernin has quit IRC22:17
*** gmann_afk is now known as gmann22:35
*** rcernin has joined #openstack-nova22:47
*** rcernin has quit IRC22:52
*** tkajinam has joined #openstack-nova22:55
*** mlavalle has quit IRC22:56
*** JamesBenson has quit IRC23:01
*** dklyle has quit IRC23:20
*** rcernin has joined #openstack-nova23:20
*** dklyle has joined #openstack-nova23:20

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!