Tuesday, 2020-01-21

« Monday, 2020-01-20 Index Wednesday, 2020-01-22 »
*** zhanglong has quit IRC00:03
*** brinzhang has joined #openstack-nova00:08
*** mriedem has quit IRC00:11
*** brinzhang_ has quit IRC00:12
*** igordc has quit IRC00:25
*** igordc has joined #openstack-nova00:25
*** brinzhang has quit IRC00:39
*** zhanglong has joined #openstack-nova00:41
*** igordc has quit IRC00:49
*** brinzhang has joined #openstack-nova00:52
*** brinzhang has quit IRC00:54
*** artom has quit IRC01:00
*** xiaolin has joined #openstack-nova01:03
*** brinzhang has joined #openstack-nova01:07
*** jistr has quit IRC01:17
*** jistr has joined #openstack-nova01:19
*** gentoorax has quit IRC01:38
*** gentoorax has joined #openstack-nova01:43
*** ircuser-1 has joined #openstack-nova02:03
*** macz has joined #openstack-nova02:15
*** hoonetorg has quit IRC02:17
*** macz has quit IRC02:20
*** hoonetorg has joined #openstack-nova02:31
*** damien_r has joined #openstack-nova02:34
*** damien_r has quit IRC02:35
*** damien_r has joined #openstack-nova02:35
*** ociuhandu has joined #openstack-nova02:47
alex_xugibi: yea, I can be the liaison for that02:50
*** awalende has joined #openstack-nova02:50
alex_xumelwitt: i have few question for https://review.opendev.org/602201, still on the road to familar the spec02:51
*** ociuhandu has quit IRC02:51
*** awalende has quit IRC02:55
*** zhanglong has quit IRC03:03
*** dklyle has joined #openstack-nova03:07
*** damien_r has quit IRC03:10
*** brinzhang has quit IRC03:27
*** hongbin has joined #openstack-nova04:03
*** tetsuro has quit IRC04:18
*** mkrai_ has joined #openstack-nova04:18
*** tetsuro has joined #openstack-nova04:19
*** tetsuro has quit IRC04:23
*** hongbin has quit IRC04:39
*** udesale has joined #openstack-nova04:44
*** udesale has quit IRC04:44
*** udesale has joined #openstack-nova04:44
*** links has joined #openstack-nova04:49
*** tetsuro has joined #openstack-nova05:03
*** sridharg has joined #openstack-nova05:09
*** macz has joined #openstack-nova05:20
*** macz has quit IRC05:22
*** evrardjp has quit IRC05:34
*** evrardjp has joined #openstack-nova05:34
*** udesale_ has joined #openstack-nova05:34
*** udesale has quit IRC05:37
*** rchurch has quit IRC05:52
*** rchurch has joined #openstack-nova05:54
*** lpetrut has joined #openstack-nova06:08
*** lpetrut has quit IRC06:09
*** lpetrut has joined #openstack-nova06:10
*** adriant has quit IRC06:40
*** adriant has joined #openstack-nova06:41
*** lpetrut has quit IRC06:49
*** TxGirlGeek has joined #openstack-nova06:59
*** TxGirlGeek has quit IRC07:07
*** ociuhandu has joined #openstack-nova07:30
*** ociuhandu has quit IRC07:35
*** lpetrut has joined #openstack-nova07:38
*** maciejjozefczyk_ has joined #openstack-nova07:48
*** slaweq has joined #openstack-nova08:03
*** shilpasd has quit IRC08:06
*** bnemec has joined #openstack-nova08:06
*** awalende has joined #openstack-nova08:07
*** tkajinam has quit IRC08:10
*** iurygregory has joined #openstack-nova08:11
*** tesseract has joined #openstack-nova08:20
*** priteau has joined #openstack-nova08:29
*** ralonsoh has joined #openstack-nova08:30
*** shilpasd has joined #openstack-nova08:43
*** links has quit IRC08:47
*** rpittau|afk is now known as rpittau08:48
*** martinkennelly has joined #openstack-nova08:49
gibialex_xu: thanks08:49
*** links has joined #openstack-nova08:53
*** dtantsur|afk is now known as dtantsur08:57
*** iurygregory has quit IRC08:59
*** tosky has joined #openstack-nova09:07
*** shilpasd has quit IRC09:12
*** iurygregory has joined #openstack-nova09:13
*** brinzhang has joined #openstack-nova09:16
*** jaosorior has joined #openstack-nova09:19
*** brinzhang has quit IRC09:22
*** brinzhang has joined #openstack-nova09:23
*** xek has joined #openstack-nova09:24
*** udesale_ has quit IRC09:28
*** udesale_ has joined #openstack-nova09:28
*** derekh has joined #openstack-nova09:28
*** mkrai_ has quit IRC09:28
openstackgerritStephen Finucane proposed openstack/nova master: functional: Stop setting Flavor.id  https://review.opendev.org/70356809:51
stephenfinalex_xu, gibi, bauzas: Can you folks take a look at ^ since it's causing intermittent gate failures09:51
*** jaosorior has quit IRC09:54
stephenfinI also need someone to add me to nova-drivers again so I can triage bugs :/09:54
stephenfinhttps://launchpad.net/~nova-drivers09:54
*** tetsuro has quit IRC09:56
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module  https://review.opendev.org/70245109:57
openstackgerritStephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects  https://review.opendev.org/69715609:57
brinzhangstephenfin: https://review.opendev.org/#/c/702790/ this I was fixed the functional test fails, and leave the failed reason, please review again, while you are free09:59
*** sapd1_x has joined #openstack-nova09:59
brinzhangalex_xu: please reivew https://review.opendev.org/#/c/580271 and https://review.opendev.org/#/c/702790/ when you are free10:00
brinzhangstephenfin, alex_xu: thanks :)10:00
stephenfinbrinzhang: Done. I want to get dansmith to hit that again when he's online10:01
brinzhangstephenfin: yeah10:02
brinzhangdansmith: please reivew https://review.opendev.org/#/c/580271 and https://review.opendev.org/#/c/702790/ with bug 1663456 fix code, in your free time10:03
openstackbug 1663456 in OpenStack Compute (nova) "Field 'updated_at' always 'None' when show aggregate" [Low,In progress] https://launchpad.net/bugs/1663456 - Assigned to Brin Zhang (zhangbailin)10:03
*** links has quit IRC10:04
stephenfinbrinzhang: Does my comment on https://review.opendev.org/#/c/702790/ make sense?10:04
brinzhangstephenfin: ack10:05
*** links has joined #openstack-nova10:07
*** ivve has joined #openstack-nova10:07
*** mkrai_ has joined #openstack-nova10:08
brinzhangstephenfin: yeah, that's ture, your comment is makes sense.10:09
*** openstackgerrit has quit IRC10:12
bauzasstephenfin: sorry had some internal network issues since yesterday evening, but will add you10:23
bauzasstephenfin: oh, actually it's the wrong team10:24
stephenfinwell, that would explain things :-D10:24
bauzasstephenfin: you need to be in https://launchpad.net/~nova-bugs10:25
stephenfinperfect. thanks10:26
bauzasand +210:29
bauzasstephenfin: but I said we should wait a little bit for the CI to return first10:29
*** sapd1_x has quit IRC10:29
stephenfinCoolness10:30
kashyapTo those using Bash ... here's something useful (and fun):10:31
kashyapTo intelligently prepend an env. variable:10:32
kashyap    export LD_LIBRARY_PATH=/mypath${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}10:32
kashyap[ Source: http://stackoverflow.com/a/9631350 ]10:32
kashyap[And: https://www.gnu.org/savannah-checkouts/gnu/bash/manual/bash.html#Shell-Parameter-Expansion]10:32
kashyapIt's yet another obscure/magical-yet-useful combination of characters in Bash :D10:34
*** priteau has quit IRC10:41
*** CeeMac has joined #openstack-nova10:43
*** _rajat_ has joined #openstack-nova10:48
*** mkrai_ has quit IRC10:50
*** mkrai__ has joined #openstack-nova10:50
*** udesale_ has quit IRC10:51
*** mrch_ has joined #openstack-nova10:56
*** awalende has quit IRC11:13
*** awalende has joined #openstack-nova11:14
*** rpittau is now known as rpittau|bbl11:15
*** dviroel has joined #openstack-nova11:25
gibistephenfin: does the flavor ids in conflict within a test case or in between test cases running in the same test executor worker?11:27
stephenfingibi: It appears to be the latter, although I'm not sure if the DB fixture is supposed to prevent that or not11:33
stephenfini.e. if we tear down the DB after every test11:33
gibistephenfin: I think we should tear down the db after each step11:33
gibistephenfin: but there could be some global state that leaks11:34
gibistephenfin: your fix is still OK, I'm just wondering if we have a bigger problem somewhere deep11:37
*** zhanglong has joined #openstack-nova11:44
*** maciejjozefczyk_ has quit IRC11:45
stephenfingibi: I wonder where we'd start. Probably examine the SQLite DB after N tests11:47
gibiyeah something like that11:53
*** zhanglong has quit IRC11:53
gibibut don't spend too much time on this11:53
*** dtantsur is now known as dtantsur|bbl12:01
*** maciejjozefczyk_ has joined #openstack-nova12:04
*** priteau has joined #openstack-nova12:07
*** mkrai__ has quit IRC12:10
*** ociuhandu has joined #openstack-nova12:12
*** ociuhandu has quit IRC12:13
*** tkajinam has joined #openstack-nova12:14
*** openstackgerrit has joined #openstack-nova12:17
openstackgerritsean mooney proposed openstack/nova master: Revert "Skip cpu comparison on AArch64"  https://review.opendev.org/70359612:17
*** artom has joined #openstack-nova12:24
*** mkrai_ has joined #openstack-nova12:25
*** rcernin has quit IRC12:28
*** Luzi has joined #openstack-nova12:28
*** nweinber__ has joined #openstack-nova12:34
*** Liang__ has joined #openstack-nova12:46
*** dpawlik has joined #openstack-nova12:46
*** Liang__ is now known as LiangFang12:46
*** nicolasbock has joined #openstack-nova12:50
*** ociuhandu has joined #openstack-nova12:52
*** udesale has joined #openstack-nova12:59
*** ociuhandu has quit IRC13:01
*** _rajat_ has quit IRC13:02
*** nearyo has joined #openstack-nova13:03
*** priteau has quit IRC13:05
*** rpittau|bbl is now known as rpittau13:05
*** rouk has joined #openstack-nova13:05
*** mkrai_ has quit IRC13:06
*** zbr|drover has quit IRC13:18
sean-k-mooneystephenfin: the db fixture should be createing and delete the sqlite db for each test13:18
sean-k-mooneytox will execute the test in effectivly a random order so we cannot have an ordering depencies in how the tests are run so all the tests must use a clean copy13:19
*** zbr has joined #openstack-nova13:19
*** damien_r has joined #openstack-nova13:24
*** damien_r has quit IRC13:24
*** damien_r has joined #openstack-nova13:24
*** dpawlik has quit IRC13:33
*** ganso has quit IRC13:33
*** ganso has joined #openstack-nova13:34
*** iurygregory has quit IRC13:35
*** Liang__ has joined #openstack-nova13:37
stephenfinsean-k-mooney: Yeah, that's what we're thinking. Just seems unlikely that you'd have a randint conflict in the scope of one test13:37
stephenfinBut I guess not13:37
*** LiangFang has quit IRC13:38
openstackgerritBalazs Gibizer proposed openstack/nova master: Func test for failed and aborted live migration  https://review.opendev.org/69906513:39
openstackgerritBalazs Gibizer proposed openstack/nova master: Remove extra instance.save() calls related to qos SRIOV ports  https://review.opendev.org/70226113:41
openstackgerritBalazs Gibizer proposed openstack/nova master: Use common server create function for qos func tests  https://review.opendev.org/70135313:41
openstackgerritBalazs Gibizer proposed openstack/nova master: Enable live migration with qos ports  https://review.opendev.org/69906613:45
*** ociuhandu has joined #openstack-nova13:47
*** ociuhandu has quit IRC13:53
*** tbachman has joined #openstack-nova13:55
*** nearyo has quit IRC13:59
*** dtantsur|bbl is now known as dtantsur14:01
*** iurygregory has joined #openstack-nova14:05
*** bhagyashris_ has joined #openstack-nova14:09
*** bhagyashris_ has quit IRC14:10
openstackgerritAlexandre arents proposed openstack/nova master: Avoid allocation leak when deleting instance stuck in BUILD  https://review.opendev.org/70236814:11
*** mkrai_ has joined #openstack-nova14:13
*** awalende has quit IRC14:16
*** links has quit IRC14:24
*** mgariepy has joined #openstack-nova14:37
*** Luzi has quit IRC14:46
*** sridharg has quit IRC14:47
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests  https://review.opendev.org/61660314:56
kashyapgibi: Thanks for the review; hope the above looks better.14:56
*** tbachman has quit IRC14:58
efried_ptostephenfin: I'm trying to find out who the admins of lp nova-drivers are...15:03
sean-k-mooneyits owned by openstack adminstrators15:04
sean-k-mooneyhttps://launchpad.net/~nova-drivers15:04
sean-k-mooneyefried_pto: https://launchpad.net/~nova-drivers/+members#active15:05
*** efried_pto is now known as efried15:05
sean-k-mooneybut melwitt is an admin15:05
sean-k-mooneyso she can make you one if you need it15:05
efriedoh, why didn't I see that status column before?15:06
sean-k-mooneythe openstack amdinstartor group is https://launchpad.net/~openstack-admins/+members#active by the way15:06
efriedyeah, melwitt probably a good idea to give yourself a backup who's actually still on the core team.15:06
sean-k-mooneyin case you need them to change something15:06
efriedme or dansmith15:06
efriedthanks sean-k-mooney15:06
sean-k-mooneyno worries15:07
* sean-k-mooney goes to get coffee15:07
efriedWe should do the same for nova-bugs, if we can raise mriedem or mikal...15:08
*** Liang__ is now known as LiangFang15:09
sean-k-mooneyif you cant then corvus can fix it for us15:09
sean-k-mooneyactully anyone in the openstack administratros group should be able to do it15:11
johnthetubaguyefried: I can take a look15:14
johnthetubaguyI should have been removed from some of these mind!15:15
bauzaswe no longer really need nova-drivers FWIW15:15
bauzasit was for blueprints IIRC15:15
johnthetubaguybauzas: yeah, its mostly permissions around blueprints, from my memory15:16
*** tkajinam has quit IRC15:16
sean-k-mooneyyes the drivers group are teh one that can apporve blueprints i thin15:16
bauzasjust to set 'Accepted'15:16
johnthetubaguylooks like efried got added in nova-drivers now15:16
sean-k-mooneyi think its also used to create series and milestones too15:18
*** LiangFang has quit IRC15:18
openstackgerritMerged openstack/nova master: functional: Stop setting Flavor.id  https://review.opendev.org/70356815:24
gibikashyap: did you forget to publish your answer to https://review.opendev.org/#/c/616603/12..13/nova/virt/libvirt/driver.py@a5116 ?15:24
kashyapgibi: Whoops, indeed15:24
kashyapLet me hit 'submit'15:25
gibi:)15:25
kashyapDone.  Sorry :-)15:25
gibino problem15:25
kashyapgibi: In short, although good catch on the negation, we'd need the 'and' there.15:25
*** Sundar has joined #openstack-nova15:25
efriedjohnthetubaguy: thanks, I appear to be admin-y now.15:26
gibiif this is intentional then I'm OK with it. let me read your answer :)15:26
kashyapgibi: Unrelated to this change: /me has a TODO to allow two more possible values for 'hw_rng_model', besides "virtio".  Hence we need to retain that extra spec15:26
johnthetubaguyefried: cool15:26
efried...on -drivers. johnthetubaguy do you have power in nova-bugs?15:26
kashyapgibi: Yes, it is intentional; but of course your observation was correct15:26
johnthetubaguyefried: it seems not sadly15:26
kashyapgibi: And I noticed that you didn't frame it as "this is wrong", but rather "thinking it out loud; is this intentional" :-)15:27
*** ociuhandu has joined #openstack-nova15:30
gibikashyap: I'm still confused. If the user sets hw_rng:allowed = False but but does not set anything to hw_rng_model then he gets no rng device, but then if he sets anything to hw_rng_model the he will get an rng device even if hw_rng:allowed is still false15:31
kashyapgibi: 'hw_rng_model' will have no effect if 'hw_rng:allowed' is not set to True15:35
kashyapgibi: And the only currently allowable value for 'hw_rng_model' is "virtio"15:36
gibikashyap: I guess that "no effect" is outside fo Hi Balazs,15:36
gibikashyap: I guess that "no effect" is outside of _add_rng_device15:36
gibibecause in _add_rng_device if hw_rng:allowed is False but hw_rng_model is not empty then we are adding a device15:37
kashyapgibi: Yeah15:37
sean-k-mooneywell if hw_rng:allowed=False we shoudl nto add a RNG device15:38
sean-k-mooneyregardless of what the hw_rng_model is set to15:38
kashyapgibi: sean-k-mooney: Yes:15:40
kashyap-  if not rng_is_virtio and not rng_allowed:15:40
kashyap+  if not rng_allowed:15:40
kashyapThen 'hw_rng_model' will be "useless" (but we want to enhance the prop to allow two more values), as it isn't used outside this method.15:42
gibikashyap: if the value of hw_rng_model is not need to decide to add the device that is fine. As soon as we (you) add support the new model values then such change will make hw_rng_model used again, in the device parameters (I guess)15:43
kashyapgibi: Yes, I'll go with the above 'diff' and document the TODO the image props to extend it for new values15:44
kashyapgibi: Sounds okay?15:44
gibikashyap: yes, sounds good15:45
kashyap(The extended two values will also be virtio variants.)15:45
sean-k-mooneywe have not added new values in several cycle and like will not in the future15:45
sean-k-mooneyso we might just want to deprecate the model15:45
sean-k-mooneyis there support in qemu for other RNGs?15:46
gibisean-k-mooney: I guess kashyap disagrees ^^15:46
*** lpetrut has quit IRC15:46
kashyapsean-k-mooney: Wait: how do you know "not in the future"?  The new values were added to fix certain bugs with guest compat with old operating systems15:46
kashyapAs I mentioned on the change.15:46
sean-k-mooneywell im just asking is can it have other value form a qemu point of view15:46
kashyapsean-k-mooney: Yes:15:47
kashyaphttps://libvirt.org/formatdomain.html#elementsVirtioTransitional15:47
sean-k-mooney the model has noting to do with tanstional devices15:47
kashyapsean-k-mooney: Hang on.15:48
kashyapsean-k-mooney: 'virtio-transitional' is another possible value, instead of 'virtio'15:48
kashyapPlease take two minutes to read what the page is saying.15:48
sean-k-mooneyoh i see they aded that in 5.215:48
kashyapI also quoted *specific* bits in the Gerrit change!15:49
sean-k-mooneyso im not sure we should be exposing that to end users15:49
kashyapSo you haven't read the comment that clearly explains it here: https://review.opendev.org/#/c/616603/10/nova/virt/libvirt/driver.py@511415:50
kashyapIn short: we should _not_ deprecate it.15:50
kashyap(Where "it" == hw_rng_model)15:50
kashyapsean-k-mooney: I'm sure we should expose them as possible values for the user15:51
sean-k-mooneyim wondering if nova can just make the chioce itself without exposeing it to the user15:51
kashyapHmm, I don't think we have enough info about it.15:51
sean-k-mooneysure we do15:51
*** ociuhandu has quit IRC15:51
sean-k-mooneyif qemu/libvirt support the virtio-non-transitional version shoudl we not always use it15:52
kashyapI'm of course not saying we should unconditionally enable anything what QEMU/libvirt support.15:52
* gibi needs to leave15:53
kashyapAnyway, we're going into the weeds here.  The point being: we should not be in a hurry to deprecate that prop15:53
sean-k-mooneyok15:53
sean-k-mooneywe also shoudl not be in a hurry to extend it15:53
sean-k-mooneythat is not relevent to your patch however15:53
kashyapYes, I'm not hurrying to extend it; I wanted to keep it a potential option.15:54
sean-k-mooneyi guess we might need to expose it for legacy os support15:54
kashyapsean-k-mooney: gibi: To conclude the discussion: my previous comment still stands: will go with the `diff` noted earlier w/ a TODO in code15:54
sean-k-mooneybut they could jsut disbael the RNG15:54
kashyapsean-k-mooney: Yeah, indeed on the legacy OS15:55
sean-k-mooneyya the diff is fine with me15:55
kashyapOkido15:55
kashyapThanks for bearing with me15:55
kashyapCompletely unrelated: I can't even do Ctrl-c in Grrrrrit-- anymore.  Is it just me?15:56
sean-k-mooneyi got it working but i know other have had issues15:57
sean-k-mooneyits a browser thing i think15:57
sean-k-mooneyi dont think our gerrit was updated15:57
*** TxGirlGeek has joined #openstack-nova15:58
*** udesale has quit IRC15:59
kashyapsean-k-mooney: I tried it in both FF and Chromium :-(16:00
kashyap(To no effect)16:00
*** iurygregory has quit IRC16:01
*** maciejjozefczyk_ has quit IRC16:04
sean-k-mooneykashyap: so in chrome i  has the "webkit-user-select: none" css property applied16:12
sean-k-mooneyto the comment16:12
*** openstackgerrit has quit IRC16:13
sean-k-mooneyin firfox 67 it does not16:14
kashyapsean-k-mooney:  I see, will fiddle.  Thank you for the tip16:14
kashyapsean-k-mooney: Unrelated: do we have any examples of this:16:15
kashyap"* Some properties recognized by Nova may have no effect unless a corresponding property is enabled in the server flavor."16:15
kashyap(The 'hw_rng_model' / 'hw_rng:allowed' used to be one; but now we're changing it.)16:16
kashyapI quoted it from Glance docs; as I'm updating them16:16
*** mrch_ has quit IRC16:17
sean-k-mooneyam hw:mem_page_size in the image will only have an effect if hw:mem_page_size=any or hw:mem_page_size=large16:21
sean-k-mooneyi think the realtime mask in the image will also be ignored if you dont enable in in the flaovr but we normally try to make it an irror rather then ignore it16:22
sean-k-mooneythis is slightly different however16:22
*** ociuhandu has joined #openstack-nova16:23
sean-k-mooneyin that its more qulatitive. i.e. it is saying if i have a random number generateor make it of this type16:23
*** mriedem has joined #openstack-nova16:23
*** ociuhandu has quit IRC16:28
kashyapsean-k-mooney: Yeah, the hw:mem_page_size is not dependent on any other property; so it's different indeed16:29
*** tbachman has joined #openstack-nova16:29
sean-k-mooneyi think the realtime mask is the best example16:29
sean-k-mooneyrealtiem cpus can only be enabled in the falvor16:30
sean-k-mooneybut you can set the mask in the flavor or image16:30
sean-k-mooneyand the image mask only works if its enabled in the flavor16:30
sean-k-mooneyalso http://paste.openstack.org/show/788651/ is what i think is going on with gerrit16:30
kashyapsean-k-mooney: Got the exact property names, please?  So I can fix the Gerrit document right away16:30
* kashyap clicks16:30
*** macz has joined #openstack-nova16:31
sean-k-mooneyi should have added https://developer.mozilla.org/en-US/docs/Web/CSS/initial16:32
kashyapsean-k-mooney: Thank you :-)16:32
sean-k-mooneyso ya inial restores a property to its defaul state which may have changed16:32
sean-k-mooneyhehe i like that note " On inherited properties, the initial value may be unexpected. "16:33
*** tosky has quit IRC16:33
sean-k-mooneyin other words if you use it it will break16:33
sean-k-mooneyeventually16:33
*** eharney has quit IRC16:35
*** openstackgerrit has joined #openstack-nova16:35
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests  https://review.opendev.org/61660316:35
kashyapsean-k-mooney: When you can, does the TODO & NOTE added above make sense to you?16:36
*** ociuhandu has joined #openstack-nova16:36
sean-k-mooneyim not sure i agree with likely to be extended :P but yes they make sense although i proably woudl make them both NOTE16:38
*** gyee has joined #openstack-nova16:39
sean-k-mooneymainlly because virtion 1.0 was standarised in 201616:39
*** iurygregory has joined #openstack-nova16:40
sean-k-mooneyso im not sure how relevent support of explecitly running operating systems that predate that is given libvirt we will default to tansitional device model if you are using the pc machien type16:40
sean-k-mooneyrhel 6 or windows server 2013 are the two main things that come to mind but they are not going to be deploy on q35 anyway16:41
*** bnemec has quit IRC16:48
kashyapsean-k-mooney: :-) I don't want to be overly confident and remove it yet16:52
kashyapHence I just wanted to make triple-sure before we remove it (and then later realize, "oh, we need to re-introduce" :-))16:53
*** nweinber__ has quit IRC16:55
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests  https://review.opendev.org/61660316:56
kashyapsean-k-mooney: Okay, satisfied your request :-) --^16:56
kashyapsean-k-mooney: I even added "if a good reason shows up" :D16:56
*** mkrai_ has quit IRC17:00
*** tesseract has quit IRC17:01
*** TxGirlGeek has quit IRC17:02
*** rpittau is now known as rpittau|afk17:04
*** mkrai_ has joined #openstack-nova17:11
artomHas the XMLMatcher utility for unit tests not moved to oslo?17:14
artomKeystone has one, we have one...17:14
artomCan't find it in oslo anywhere17:14
sean-k-mooneykashyap: lol ok didnt i mark it as a nit17:15
sean-k-mooneykashyap: e.g. you dont need to respin but sure17:15
sean-k-mooneywe have one in nova17:16
sean-k-mooneyat least we used too17:16
*** mkrai_ has quit IRC17:16
artomsean-k-mooney, yeah, but I'd like to suggest amodi use it in his whitebox patch17:17
sean-k-mooneyyou can do self.assertXmlEqual17:17
artomNot in tempest...17:18
sean-k-mooneythis is the implementaion https://github.com/openstack/nova/blob/e80300ac20388890539a7f709e526a0a5ba8e63d/nova/test.py#L534-L53517:18
artomAnd actually that method just uses the XMLMatcher :)17:18
sean-k-mooneyyes from nova.tests.unit import matchers17:19
sean-k-mooneythere https://github.com/openstack/nova/blob/e80300ac20388890539a7f709e526a0a5ba8e63d/nova/tests/unit/matchers.py#L40417:20
kashyapsean-k-mooney: You did, but I aim to please :-)17:22
artomsean-k-mooney, yeah, so I'd rather not import nova bits into whitebox ;)17:26
* amodi agrees with artom17:27
sean-k-mooneyya we shoudl not but we shoudl have a similar function17:27
sean-k-mooneywe dont need 90% of what that is doing as it has extra complexity to be able to ignore things17:28
sean-k-mooneyfor the whitebox tests i woudl probaly use xpath expression to pull out the content we want to compre from the two doms17:29
sean-k-mooneyand then compare teh normalised pretty printed version17:30
sean-k-mooneybut i really wold depend on why we were comparing17:30
sean-k-mooneywe should not try to have precreated expected xmls for the rebuild tests17:32
sean-k-mooneywe shoudl be comparing the relevent xml section between the instance before an after rebuild17:32
sean-k-mooneywhich i think you already have example of for vcpus17:32
artomThat's exactly what it is17:32
artomFor the CPUs we pull out the individual IDs17:33
artomActually yeah, could do that here as well17:33
*** TxGirlGeek has joined #openstack-nova17:33
sean-k-mooneyyep for the test that tried to change the number of numa nodes you jsut need to count the numer of cell elements before and after17:33
*** evrardjp has quit IRC17:34
sean-k-mooneyyou dont need to do a full xml match. it shoudl be rejected at teh api and the xml should not change for the negitive tests17:34
*** evrardjp has joined #openstack-nova17:34
sean-k-mooneyfor the positive test the numa/pinning related element also shoudl not change17:35
sean-k-mooneythe <nova:metadata/> element will be update with the image uuid however17:35
kashyapsean-k-mooney: And here is the update to Glance's doc: https://review.opendev.org/#/c/703657/17:37
* kashyap stops the spam now :D17:37
sean-k-mooney:) im about to go have dinner but ill review it later this evening17:37
*** tbachman has quit IRC17:42
*** tbachman_ has joined #openstack-nova17:42
*** eharney has joined #openstack-nova17:46
*** iurygregory has quit IRC17:51
kashyapNo rush.  Thanks for review so far!  (Likewise, off for dinner)17:54
*** TxGirlGeek has quit IRC18:01
*** macz has quit IRC18:03
*** dtantsur is now known as dtantsur|afk18:11
*** ociuhandu_ has joined #openstack-nova18:13
*** ociuhandu has quit IRC18:17
*** TxGirlGeek has joined #openstack-nova18:17
*** ociuhandu_ has quit IRC18:18
*** martinkennelly has quit IRC18:18
openstackgerritMerged openstack/os-vif master: [Follow Up] OVS DPDK port representors support  https://review.opendev.org/66596518:21
*** slaweq_ has joined #openstack-nova18:26
*** slaweq has quit IRC18:27
*** ralonsoh has quit IRC18:31
*** tbachman has joined #openstack-nova18:40
*** tbachman_ has quit IRC18:41
*** CeeMac has quit IRC18:51
*** TxGirlGeek has quit IRC18:56
openstackgerritAdrian Chiris proposed openstack/os-vif master: Revert "[Follow Up] OVS DPDK port representors support"  https://review.opendev.org/70367218:57
openstackgerritAdrian Chiris proposed openstack/os-vif master: Revert "[Follow Up] OVS DPDK port representors support"  https://review.opendev.org/70367219:00
*** TxGirlGeek has joined #openstack-nova19:06
*** TxGirlGeek has quit IRC19:13
*** dustinc|PTO is now known as dustinc19:13
dustincgibi: thanks for the feedback on provider config, going through it now/this week19:14
*** TxGirlGeek has joined #openstack-nova19:14
*** TxGirlGeek has quit IRC19:22
*** tosky has joined #openstack-nova19:25
*** TxGirlGeek has joined #openstack-nova19:26
*** TxGirlGe_ has joined #openstack-nova19:31
*** TxGirlGeek has quit IRC19:31
*** iurygregory has joined #openstack-nova19:33
melwittefried: re: nova-drivers, yeah I hadn't looked at that in awhile. and nova-bugs is an open team, anyone can join on their own19:33
efriedoh, gtk19:36
melwittand what others said is correct, nova-drivers is just for doing blueprint-fu, for those involved in administrative tasks around releases, milestones, bp status, etc19:36
melwittI didn't join nova-drivers until I was ptl, then I used it to do some of the launchpad stuff described in the ptl guide I wrote19:37
openstackgerritMerged openstack/nova master: Add ironic hypervisor doc  https://review.opendev.org/70199819:37
openstackgerritMerged openstack/nova master: functional: Add '_create_server' helper  https://review.opendev.org/69754019:37
*** nicolasbock has quit IRC19:57
*** mlavalle has joined #openstack-nova20:15
*** eharney has quit IRC20:27
*** rcernin has joined #openstack-nova20:42
*** jmlowe has joined #openstack-nova21:00
*** eharney has joined #openstack-nova21:28
*** maciejjozefczyk_ has joined #openstack-nova21:28
*** seba has quit IRC21:29
openstackgerritsean mooney proposed openstack/nova stable/queens: Block rebuild when NUMA topology changed  https://review.opendev.org/70314021:33
openstackgerritsean mooney proposed openstack/nova stable/queens: Disable NUMATopologyFilter on rebuild  https://review.opendev.org/70314121:33
openstackgerritsean mooney proposed openstack/nova stable/queens: FUP for in-place numa rebuild  https://review.opendev.org/70314221:33
efriedfrickler: Seen21:35
efried2020-01-21 18:21:18.373 | ERROR: Cannot uninstall 'PyYAML'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.21:35
efrieda couple of times today. I noticed you seemed to have some clue what this was about when you were helping with https://review.opendev.org/#/c/649097/ -- can you help?21:35
*** maciejjozefczyk_ has quit IRC21:35
efriedfrickler: ^ was in the nova-live-migration job btw.21:36
efriedgmann: ^ any ideas?21:36
*** nweinber__ has joined #openstack-nova21:36
*** seba has joined #openstack-nova21:37
*** nweinber__ has quit IRC21:51
*** TxGirlGe_ has quit IRC21:54
*** TxGirlGeek has joined #openstack-nova21:56
*** rchurch has quit IRC21:57
*** rchurch has joined #openstack-nova22:00
*** eharney has quit IRC22:06
*** jmlowe has quit IRC22:09
*** jmlowe has joined #openstack-nova22:14
*** slaweq_ has quit IRC22:16
*** jmlowe has quit IRC22:17
*** Sundar has quit IRC22:36
*** tkajinam has joined #openstack-nova22:57
efrieddustinc: I went through gibi's comments on the provider config series and answered a few of them. I think the main thing is going to be the missing checks for duplicates by name+uuid.23:05
dustincefried: Thanks! I am also working through the nits and other small stuff since I need to update series anyway. I am only able to work on this bits at a time right this minute but plan to get it all done this week.23:06
*** mriedem has quit IRC23:07
*** rchurch has quit IRC23:13
*** rchurch has joined #openstack-nova23:14
efriedcool23:14
*** Liang__ has joined #openstack-nova23:20
sean-k-mooneyefried: so the PYYAML distutils thing is proably related to the fact we pin pip to a really old version in devstack.23:28
sean-k-mooneywe try to pin to a version below 10 to work around that so that pip will remove it anyway23:29
sean-k-mooneywithout configuring devstack to install in virutal envs with no site packages i dont know if there is a clean way to complete work around package conflict with teh os packages23:30
openstackgerritMerged openstack/nova stable/ocata: ocata-only: drop non-voting ceph job  https://review.opendev.org/70007723:37
gmannefried: sean-k-mooney pip 10 cap is removed now - https://review.opendev.org/#/c/561597/2123:46
gmannwhich job is failing23:47
*** tosky has quit IRC23:47
sean-k-mooneynova livemigration which is a legacy job23:48
sean-k-mooneygmann: efried was asking about https://review.opendev.org/#/c/649097/23:49
sean-k-mooneybut i think that was unrealted23:49
gmannok23:50
sean-k-mooneyoh that was just context for why he tought you would know23:50
sean-k-mooneyhum ya it looks like there are a decent number of failure on master https://zuul.opendev.org/t/openstack/builds?job_name=nova-live-migration23:51
*** damien_r has quit IRC23:51
sean-k-mooneyoh ya th ecompression thing is not fix on legacy jobs...23:53
*** dviroel has quit IRC23:57
« Monday, 2020-01-20 Index Wednesday, 2020-01-22 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!