*** zhanglong has joined #openstack-nova | 00:10 | |
*** ociuhandu has joined #openstack-nova | 00:10 | |
*** ociuhandu has quit IRC | 00:12 | |
*** ociuhandu has joined #openstack-nova | 00:14 | |
*** ociuhandu has quit IRC | 00:19 | |
*** brinzhang has joined #openstack-nova | 00:28 | |
*** tetsuro has joined #openstack-nova | 00:31 | |
*** zhanglong has quit IRC | 00:53 | |
*** zhanglong has joined #openstack-nova | 00:55 | |
*** Dinesh_Bhor has joined #openstack-nova | 01:24 | |
*** stephenfin has quit IRC | 01:50 | |
*** dosaboy has quit IRC | 01:50 | |
*** stephenfin has joined #openstack-nova | 01:50 | |
*** smcginnis|PTO has quit IRC | 01:51 | |
*** ganso has quit IRC | 01:52 | |
*** smcginnis|PTO has joined #openstack-nova | 01:52 | |
*** ganso has joined #openstack-nova | 01:52 | |
*** dosaboy has joined #openstack-nova | 01:59 | |
*** TxGirlGeek has joined #openstack-nova | 02:27 | |
*** TxGirlGeek has quit IRC | 02:30 | |
*** zhanglong has quit IRC | 02:35 | |
*** zhanglong has joined #openstack-nova | 02:39 | |
openstackgerrit | Merged openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_FILE_BACKED_VERSION https://review.opendev.org/695942 | 02:46 |
---|---|---|
*** brinzhang has quit IRC | 02:51 | |
*** brinzhang has joined #openstack-nova | 02:52 | |
*** brinzhang_ has joined #openstack-nova | 02:54 | |
*** brinzhang has quit IRC | 02:57 | |
*** hoonetorg has quit IRC | 02:59 | |
*** zhanglong has quit IRC | 03:11 | |
*** hoonetorg has joined #openstack-nova | 03:11 | |
*** zhanglong has joined #openstack-nova | 03:14 | |
*** links has joined #openstack-nova | 03:32 | |
*** brinzhang has joined #openstack-nova | 03:47 | |
*** brinzhang_ has quit IRC | 03:50 | |
*** nweinber__ has joined #openstack-nova | 03:54 | |
*** davee___ has joined #openstack-nova | 04:03 | |
*** brinzhang_ has joined #openstack-nova | 04:04 | |
*** davee__ has quit IRC | 04:05 | |
*** davee__ has joined #openstack-nova | 04:05 | |
*** davee_ has quit IRC | 04:05 | |
*** brinzhang has quit IRC | 04:07 | |
*** udesale has joined #openstack-nova | 04:18 | |
*** nweinber__ has quit IRC | 04:20 | |
*** mkrai_ has joined #openstack-nova | 04:36 | |
*** awalende has joined #openstack-nova | 04:45 | |
*** awalende has quit IRC | 04:49 | |
*** rcernin_ has joined #openstack-nova | 04:56 | |
*** udesale_ has joined #openstack-nova | 04:58 | |
*** ociuhandu has joined #openstack-nova | 04:59 | |
*** rcernin has quit IRC | 04:59 | |
*** udesale has quit IRC | 05:02 | |
*** ociuhandu has quit IRC | 05:04 | |
*** evrardjp has quit IRC | 05:34 | |
*** evrardjp has joined #openstack-nova | 05:34 | |
*** brinzhang_ has quit IRC | 05:41 | |
*** tkajinam has quit IRC | 05:52 | |
*** tkajinam has joined #openstack-nova | 05:53 | |
*** ircuser-1 has quit IRC | 06:06 | |
*** mkrai__ has joined #openstack-nova | 06:15 | |
*** mkrai_ has quit IRC | 06:19 | |
*** mkrai_ has joined #openstack-nova | 06:43 | |
*** zhanglong has quit IRC | 06:43 | |
*** zhanglong has joined #openstack-nova | 06:45 | |
*** mkrai__ has quit IRC | 06:46 | |
*** mkrai_ has quit IRC | 06:51 | |
*** davee___ has quit IRC | 06:58 | |
*** davee__ has quit IRC | 06:58 | |
*** davee_ has joined #openstack-nova | 07:01 | |
*** davee__ has joined #openstack-nova | 07:01 | |
*** jkulik has joined #openstack-nova | 07:04 | |
*** rcernin_ has quit IRC | 07:14 | |
*** ratailor has joined #openstack-nova | 07:22 | |
*** zhanglong has quit IRC | 07:24 | |
*** rpittau|afk is now known as rpittau | 07:51 | |
*** awalende has joined #openstack-nova | 07:52 | |
*** mkrai_ has joined #openstack-nova | 07:54 | |
*** damien_r has joined #openstack-nova | 07:54 | |
*** maciejjozefczyk has joined #openstack-nova | 07:57 | |
*** awalende has quit IRC | 07:58 | |
*** awalende has joined #openstack-nova | 07:59 | |
*** slaweq has joined #openstack-nova | 08:00 | |
*** zhanglong has joined #openstack-nova | 08:00 | |
*** ociuhandu has joined #openstack-nova | 08:02 | |
*** ociuhandu has quit IRC | 08:02 | |
*** ociuhandu has joined #openstack-nova | 08:03 | |
*** awalende has quit IRC | 08:03 | |
*** ociuhandu has quit IRC | 08:05 | |
*** awalende has joined #openstack-nova | 08:05 | |
*** slaweq has quit IRC | 08:05 | |
*** damien_r has quit IRC | 08:05 | |
*** ociuhandu has joined #openstack-nova | 08:05 | |
*** mkrai_ has quit IRC | 08:10 | |
*** ociuhandu has quit IRC | 08:11 | |
*** ociuhandu has joined #openstack-nova | 08:12 | |
*** tesseract has joined #openstack-nova | 08:16 | |
*** tosky has joined #openstack-nova | 08:17 | |
*** zhanglong has quit IRC | 08:18 | |
*** ociuhandu has quit IRC | 08:18 | |
*** ociuhandu has joined #openstack-nova | 08:19 | |
*** zhanglong has joined #openstack-nova | 08:21 | |
*** ociuhandu has quit IRC | 08:22 | |
*** ociuhandu has joined #openstack-nova | 08:23 | |
*** slaweq has joined #openstack-nova | 08:24 | |
*** ralonsoh has joined #openstack-nova | 08:26 | |
*** ociuhandu has quit IRC | 08:27 | |
*** tkajinam has quit IRC | 08:28 | |
*** ociuhandu has joined #openstack-nova | 08:29 | |
*** ociuhandu has quit IRC | 08:30 | |
*** ociuhandu has joined #openstack-nova | 08:30 | |
*** xek_ has joined #openstack-nova | 08:33 | |
*** xek has quit IRC | 08:36 | |
*** dpawlik has joined #openstack-nova | 08:37 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: Ensure source compute is up when confirming a resize https://review.opendev.org/699291 | 08:44 |
*** sridharg has joined #openstack-nova | 08:45 | |
*** iurygregory has quit IRC | 08:49 | |
*** jaosorior has joined #openstack-nova | 08:51 | |
*** ociuhandu has quit IRC | 08:51 | |
*** ociuhandu has joined #openstack-nova | 08:52 | |
*** ociuhandu has quit IRC | 08:53 | |
lyarwood | sean-k-mooney: ack, will do. | 08:54 |
*** ociuhandu has joined #openstack-nova | 08:54 | |
lyarwood | stephenfin: https://review.opendev.org/699291 - assuming this now passes CI can you +W again, I rebased by mistake. | 08:55 |
*** ociuhandu has quit IRC | 08:55 | |
*** ociuhandu has joined #openstack-nova | 08:58 | |
*** ociuhandu has quit IRC | 09:03 | |
*** iurygregory has joined #openstack-nova | 09:09 | |
*** shilpasd has joined #openstack-nova | 09:09 | |
*** ociuhandu has joined #openstack-nova | 09:10 | |
shilpasd | dansmith: hi, i want your opinion on my comment added https://review.opendev.org/#/c/694462/8/nova/db/sqlalchemy/api.py@2008 | 09:12 |
shilpasd | dansmith: would like to hear from you on this | 09:12 |
*** ociuhandu has quit IRC | 09:14 | |
*** damien_r has joined #openstack-nova | 09:17 | |
*** damien_r has quit IRC | 09:21 | |
*** arxcruz|off is now known as arxcruz | 09:22 | |
*** damien_r has joined #openstack-nova | 09:25 | |
*** jhesketh has quit IRC | 09:32 | |
*** jhesketh has joined #openstack-nova | 09:34 | |
*** mrch_ has joined #openstack-nova | 09:34 | |
*** brinzhang has joined #openstack-nova | 09:37 | |
*** david-lyle has joined #openstack-nova | 09:38 | |
*** dklyle has quit IRC | 09:41 | |
*** alex_xu has joined #openstack-nova | 09:41 | |
*** derekh has joined #openstack-nova | 09:47 | |
*** brinzhang_ has joined #openstack-nova | 09:48 | |
*** martinkennelly has joined #openstack-nova | 09:48 | |
*** brinzhang has quit IRC | 09:51 | |
*** awalende has quit IRC | 09:52 | |
*** awalende has joined #openstack-nova | 09:53 | |
*** awalende has quit IRC | 09:57 | |
*** awalende has joined #openstack-nova | 09:58 | |
*** xek_ has quit IRC | 10:01 | |
*** mkrai_ has joined #openstack-nova | 10:06 | |
*** damien_r has quit IRC | 10:09 | |
*** brinzhang has joined #openstack-nova | 10:11 | |
*** brinzhang_ has quit IRC | 10:14 | |
*** ivve has joined #openstack-nova | 10:15 | |
*** damien_r has joined #openstack-nova | 10:16 | |
*** jaosorior has quit IRC | 10:17 | |
*** zhanglong has quit IRC | 10:19 | |
*** damien_r has quit IRC | 10:27 | |
*** brinzhang_ has joined #openstack-nova | 10:34 | |
*** brinzhang has quit IRC | 10:37 | |
*** dviroel has joined #openstack-nova | 10:48 | |
*** ociuhandu has joined #openstack-nova | 10:51 | |
*** damien_r has joined #openstack-nova | 10:55 | |
*** xiaolin has quit IRC | 10:57 | |
*** udesale_ has quit IRC | 11:02 | |
*** damien_r has quit IRC | 11:07 | |
*** damien_r has joined #openstack-nova | 11:08 | |
*** ociuhandu has quit IRC | 11:08 | |
*** brinzhang has joined #openstack-nova | 11:08 | |
*** damien_r has quit IRC | 11:09 | |
*** ociuhandu has joined #openstack-nova | 11:09 | |
*** brinzhang_ has quit IRC | 11:11 | |
*** dtantsur|afk is now known as dtantsur | 11:13 | |
*** ociuhandu has quit IRC | 11:14 | |
*** ociuhandu has joined #openstack-nova | 11:17 | |
*** rpittau is now known as rpittau|bbl | 11:20 | |
*** dpawlik has quit IRC | 11:22 | |
*** brinzhang_ has joined #openstack-nova | 11:24 | |
*** ociuhandu has quit IRC | 11:24 | |
*** brinzhang has quit IRC | 11:27 | |
*** dpawlik has joined #openstack-nova | 11:34 | |
*** damien_r has joined #openstack-nova | 11:41 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: [OVS] VLAN tag should be set in the Port register https://review.opendev.org/703373 | 11:42 |
*** damien_r has quit IRC | 11:43 | |
*** damien_r has joined #openstack-nova | 11:43 | |
*** brinzhang has joined #openstack-nova | 11:49 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.vmwareapi' https://review.opendev.org/703148 | 11:49 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.hyperv' https://review.opendev.org/703149 | 11:49 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.powervm' https://review.opendev.org/703150 | 11:49 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.xenapi' https://review.opendev.org/703151 | 11:49 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: pytype: Resolve final issues with 'nova.virt' https://review.opendev.org/703153 | 11:49 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.cmd', 'nova.console', 'nova.db' https://review.opendev.org/703154 | 11:49 |
*** brinzhang has quit IRC | 11:50 | |
*** brinzhang has joined #openstack-nova | 11:51 | |
*** brinzhang_ has quit IRC | 11:52 | |
*** ociuhandu has joined #openstack-nova | 12:02 | |
*** ociuhandu has quit IRC | 12:08 | |
*** damien_r has quit IRC | 12:08 | |
*** brinzhang has quit IRC | 12:19 | |
*** brinzhang has joined #openstack-nova | 12:19 | |
openstackgerrit | Ilya Etingof proposed openstack/nova master: Add JSON schema for network_data.json https://review.opendev.org/703133 | 12:21 |
*** Luzi has joined #openstack-nova | 12:23 | |
*** brinzhang_ has joined #openstack-nova | 12:25 | |
*** mnaser has quit IRC | 12:27 | |
*** mnaser has joined #openstack-nova | 12:27 | |
*** brinzhang has quit IRC | 12:28 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: FUP Populate the 'updated_at' when aggregate metadata is updated https://review.opendev.org/702790 | 12:38 |
*** brinzhang has joined #openstack-nova | 12:38 | |
*** brinzhang has quit IRC | 12:38 | |
*** brinzhang__ has joined #openstack-nova | 12:38 | |
brinzhang__ | stephenfin: hi, adding metadata to the creating aggregate, it does not populate the aggregate's 'updated_at' field, that's why the functional tests failed | 12:41 |
*** brinzhang_ has quit IRC | 12:41 | |
brinzhang__ | stephenfin: please review the latest patch https://review.opendev.org/#/c/702790/5/nova/objects/aggregate.py@191, thanks | 12:41 |
*** brinzhang_ has joined #openstack-nova | 12:41 | |
*** xek has joined #openstack-nova | 12:41 | |
openstackgerrit | Merged openstack/nova master: functional: Add unified '_build_server' helper function https://review.opendev.org/697537 | 12:42 |
openstackgerrit | Merged openstack/nova master: functional: Add unified '_(build|create)_flavor' helper functions https://review.opendev.org/697538 | 12:42 |
openstackgerrit | Merged openstack/nova master: functional: Add '_delete_server' to 'InstanceHelperMixin' https://review.opendev.org/697539 | 12:42 |
*** brinzhang_ has quit IRC | 12:42 | |
*** brinzhang_ has joined #openstack-nova | 12:43 | |
*** slaweq has quit IRC | 12:48 | |
*** slaweq has joined #openstack-nova | 12:51 | |
*** ratailor has quit IRC | 12:56 | |
*** brinzhang has joined #openstack-nova | 13:01 | |
*** jaosorior has joined #openstack-nova | 13:04 | |
*** brinzhang_ has quit IRC | 13:04 | |
*** brinzhang_ has joined #openstack-nova | 13:07 | |
*** brinzhang__ has quit IRC | 13:08 | |
*** brinzhang__ has joined #openstack-nova | 13:09 | |
*** smcginnis|PTO is now known as smcginnis | 13:09 | |
*** brinzhang has quit IRC | 13:10 | |
*** rpittau|bbl is now known as rpittau | 13:11 | |
*** jaosorior has quit IRC | 13:26 | |
*** brinzhang has joined #openstack-nova | 13:30 | |
*** brinzhang_ has quit IRC | 13:33 | |
*** dpawlik has quit IRC | 13:34 | |
*** brinzhang has quit IRC | 13:34 | |
*** brinzhang_ has joined #openstack-nova | 13:34 | |
*** dpawlik has joined #openstack-nova | 13:35 | |
*** brinzhang has joined #openstack-nova | 13:36 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove extra instance.save() calls related to qos SRIOV ports https://review.opendev.org/702261 | 13:39 |
*** nweinber__ has joined #openstack-nova | 13:39 | |
*** ociuhandu has joined #openstack-nova | 13:39 | |
*** brinzhang_ has quit IRC | 13:40 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use common server create function for qos func tests https://review.opendev.org/701353 | 13:40 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable live migration with qos ports https://review.opendev.org/699066 | 13:42 |
*** brinzhang_ has joined #openstack-nova | 13:43 | |
openstackgerrit | Merged openstack/nova master: Make removal of host from aggregate consistent https://review.opendev.org/696392 | 13:44 |
*** ociuhandu has quit IRC | 13:44 | |
gibi | alex_xu: would you like to be a liaison for the api change https://review.opendev.org/#/c/701763 ? | 13:45 |
*** brinzhang has quit IRC | 13:46 | |
gibi | dansmith: replied in https://review.opendev.org/#/c/702261/ | 13:46 |
stephenfin | gibi: Care to hit this now that others have looked at it? https://review.opendev.org/#/c/696745/ | 13:47 |
openstackgerrit | Merged openstack/nova master: Set instance CPU policy to 'share' through image property https://review.opendev.org/688603 | 13:49 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Set instance CPU policy to 'share' through image property https://review.opendev.org/703393 | 13:50 |
*** johnthetubaguy has joined #openstack-nova | 13:50 | |
gibi | stephenfin: looking | 13:51 |
*** Luzi has quit IRC | 13:53 | |
*** jaosorior has joined #openstack-nova | 13:58 | |
*** mriedem has joined #openstack-nova | 13:59 | |
*** zhanglong has joined #openstack-nova | 14:06 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | 14:08 |
kashyap | stephenfin: When you get a moment --^ does that look better? | 14:08 |
kashyap | stephenfin: Quick change-log: (a) we should keep the both extra spec properties (see comments); (b) modified the driver function to make (correct) use of the extra spec props; (c) added a rel-note for change in semantics | 14:09 |
kashyap | stephenfin: Thanks for the earlier review. That was useful | 14:10 |
*** ociuhandu has joined #openstack-nova | 14:11 | |
*** mkrai_ has quit IRC | 14:15 | |
*** brinzhang has joined #openstack-nova | 14:16 | |
gibi | stephenfin: +A, thanks | 14:16 |
brinzhang__ | gibi: https://review.opendev.org/#/c/701763/2 I leave some comment on | 14:16 |
stephenfin | gibi: Thanks | 14:16 |
stephenfin | kashyap: Will do | 14:16 |
gibi | brinzhang__: ack | 14:17 |
*** brinzhang has quit IRC | 14:17 | |
*** brinzhang has joined #openstack-nova | 14:18 | |
*** ociuhandu has quit IRC | 14:18 | |
*** brinzhang_ has quit IRC | 14:19 | |
gibi | brinzhang__: replied | 14:20 |
*** zhanglong has quit IRC | 14:23 | |
brinzhang__ | Yeah, I think "rule:project_reader_api" role is good to me | 14:24 |
brinzhang__ | gibi | 14:24 |
brinzhang__ | gmann: are you around? | 14:25 |
*** ab-a has joined #openstack-nova | 14:27 | |
*** nweinber__ has quit IRC | 14:28 | |
gmann | stephenfin: one question on hacking cap - https://review.opendev.org/#/c/695733/4/test-requirements.txt@5 | 14:28 |
brinzhang__ | gmann: 'rule:project_reader_api' and 'rule:project_member_api' which different from 'rule:system_admin_or_owner' and 'rule:system_or_project_reader'? I am not sure | 14:28 |
gmann | brinzhang__: did not get completely. | 14:29 |
brinzhang__ | gmann: which scope? | 14:30 |
stephenfin | gmann: Makes sense. Will submit a follow-up | 14:30 |
gmann | brinzhang__: 'system_*' rules are with system level scope and project only rules are project scopped. | 14:30 |
gmann | stephenfin: +1 thanks | 14:30 |
gmann | brinzhang__: 'rule:system_admin_or_owner' and 'rule:system_or_project_reader' are [system, project] both scoped. | 14:30 |
*** links has quit IRC | 14:32 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add '_create_server' helper https://review.opendev.org/697540 | 14:33 |
brinzhang__ | gmann: other words, if we are *system_* role, we can get all projects resource. and if we are *project_* role, we just can get his own project's resource, right? | 14:33 |
gmann | brinzhang__: right. | 14:34 |
brinzhang__ | gmann: Thanks :) | 14:35 |
gmann | in addition to that, new default roles also considered like reader etc. so admin can get member,reader but not vice versa (on both scope case) | 14:35 |
brinzhang__ | gibi: so filter instances by az, I think use "rule:project_reader_api" is ok, what do you think? | 14:36 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: requirements: Limit hacking to one minor version https://review.opendev.org/703405 | 14:37 |
brinzhang__ | gmann: yeah, I reviewed your docs of this :P | 14:37 |
stephenfin | gmann: ^ | 14:38 |
gibi | brinzhang__: based on you discussion with gmann it looks OK to me | 14:38 |
gmann | brinzhang__: gibi link ? | 14:39 |
gmann | stephenfin: thanks | 14:39 |
brinzhang__ | gmann, https://review.opendev.org/#/c/701763/ | 14:39 |
gibi | gmann: we are reviewing https://review.opendev.org/#/c/701763/ with brinzhang__ | 14:39 |
gmann | ok, thanks. | 14:39 |
*** awalende has quit IRC | 14:41 | |
*** udesale has joined #openstack-nova | 14:42 | |
*** awalende has joined #openstack-nova | 14:42 | |
*** awalende has quit IRC | 14:42 | |
*** awalende has joined #openstack-nova | 14:42 | |
gmann | brinzhang__: gibi i left comment in review. we should not need policy there. we already have policy to allow admin filters to access by non-admin. | 14:45 |
gmann | this case of when operator/user want AZ to be always allowed for non-admin not based on configuration. | 14:46 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused code https://review.opendev.org/703408 | 14:46 |
gibi | gmann: thanks. does os_compute_api:servers:allow_all_filters' | 14:47 |
gibi | gmann: does os_compute_api:servers:allow_all_filters makes every filtering available for the user? | 14:48 |
gmann | gibi: yes, but that allow all admin filters. | 14:48 |
gibi | gmann: so that cannot be used to selectively enable AZ filtering for non-admin | 14:48 |
*** awalende has quit IRC | 14:49 | |
gmann | as per discussion with author on IRC, this policy is not they want to use for making AZ for non-admin and wanted AZ to be available by default | 14:49 |
gmann | gibi: yeah, i mean if we default any filter for non-admin then we do not need policy for that. | 14:49 |
gibi | gmann: so simply adding availiability_zone to nova.api.openstack.compute.servers.serverscontroller._get_server_search_options would make the AZ filter available to non-admin by default | 14:50 |
gmann | if we think AZ is for non-admin then we should not add config way to disallow for non-admin. | 14:50 |
gmann | gibi: yes | 14:51 |
gibi | gmann: I got it, thanks | 14:51 |
gmann | but i am little concern to bump microversion for this single fitler. i commented to do a audit for all such filter first. like we did for API clenup BP(doing such cleanup together in single microvesion) | 14:52 |
gibi | gmann: and I've just agreed with you about that | 14:52 |
gibi | :) | 14:53 |
gibi | in the review | 14:53 |
gibi | gmann: thanks for the review | 14:53 |
gmann | thanks. | 14:53 |
*** awalende has joined #openstack-nova | 14:54 | |
*** awalende has quit IRC | 14:54 | |
brinzhang__ | gmann, gibi: so this spec's context is ok, we donot car about the policy's limit :) | 14:54 |
brinzhang__ | gibi: I am ok with that ^ | 14:55 |
gmann | yeah, policy is not required for that. we should add another configurable way which is not required. | 14:55 |
gibi | brinzhang__: I still think this is a valid spec. we don't need a new policy. And we should review the other existing admin-only filters to se other need to be moved to the non-admin set | 14:55 |
gmann | s/should/should not | 14:56 |
brinzhang__ | gibi: yeah, like gmann said, *that* should done in a micoroversion, avoid more microversions to do one thing | 14:57 |
gibi | brinzhang__: exactly | 14:57 |
brinzhang__ | gibi: I think I would like to do, but it will be start after our holiday~ | 14:59 |
gibi | brinzhang__: sure. holiday recharging is important :) I also expect the author to do the first sweep of the existing filters | 15:00 |
brinzhang__ | gibi: ^^ | 15:01 |
*** johanssone has quit IRC | 15:03 | |
*** jaosorior has quit IRC | 15:05 | |
*** johanssone has joined #openstack-nova | 15:09 | |
*** artom has joined #openstack-nova | 15:12 | |
*** brinzhang_ has joined #openstack-nova | 15:15 | |
*** brinzhang__ has quit IRC | 15:16 | |
*** brinzhang_ has quit IRC | 15:16 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a placement audit command https://review.opendev.org/670112 | 15:17 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Avoid PlacementFixture silently swallowing kwargs https://review.opendev.org/695180 | 15:17 |
*** brinzhang_ has joined #openstack-nova | 15:17 | |
*** brinzhang has quit IRC | 15:18 | |
*** eharney has joined #openstack-nova | 15:21 | |
*** nweinber__ has joined #openstack-nova | 15:21 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | 15:21 |
kashyap | sean-k-mooney: ^ I reworded the commit message; and reworded the puropose more clearly. | 15:22 |
kashyap | sean-k-mooney: (And tweaked the driver.py; hop that looks OK.) | 15:22 |
* kashyap bbiab | 15:22 | |
*** awalende has joined #openstack-nova | 15:23 | |
sean-k-mooney | i would still delete the backgroud section to be honest. that should have beeen in the patch that chagne to use /dev/urandom by default not this chagne but i wont block on it | 15:25 |
sean-k-mooney | you could have just referencce the change id of that commit instead of providing the history again | 15:26 |
*** ociuhandu has joined #openstack-nova | 15:27 | |
*** awalende has quit IRC | 15:28 | |
gibi | stephenfin: I have one question in https://review.opendev.org/#/c/697153/15/nova/network/neutron.py | 15:30 |
*** ociuhandu has quit IRC | 15:32 | |
*** fyx has joined #openstack-nova | 15:35 | |
stephenfin | gibi: Replied (tl;dr: nothing has really changed, but we could probably improve it in a follow-up patch) | 15:37 |
gibi | stephenfin: ahh _setup_net_dict could raise a similar unhandled exception before. Then your change does not make it worse. thanks for the explanation | 15:38 |
stephenfin | yup, exactly | 15:39 |
gibi | stephenfin: do you have an estimate how much work still remains in the nova-net removal? | 15:40 |
stephenfin | gibi: I think the patches that are up there are it | 15:41 |
stephenfin | I'm sure I missed some stuff but that should have the bulk of the work (services, API, docs, tests) taken care of | 15:41 |
gibi | stephenfin: wow soo colse then I gather my brain and try to read through | 15:41 |
gibi | close | 15:41 |
*** mlavalle has joined #openstack-nova | 15:43 | |
*** bauzas has quit IRC | 15:43 | |
*** jaosorior has joined #openstack-nova | 15:43 | |
openstackgerrit | sean mooney proposed openstack/nova stable/stein: Block rebuild when NUMA topology changed https://review.opendev.org/702972 | 15:51 |
openstackgerrit | sean mooney proposed openstack/nova stable/stein: Disable NUMATopologyFilter on rebuild https://review.opendev.org/702973 | 15:51 |
openstackgerrit | sean mooney proposed openstack/nova stable/stein: FUP for in-place numa rebuild https://review.opendev.org/702974 | 15:51 |
*** maciejjozefczyk has quit IRC | 15:58 | |
gibi | stephenfin: thank you for your perseverance, it was an awesome job to remove all this logically dead code | 16:01 |
*** ociuhandu has joined #openstack-nova | 16:03 | |
*** udesale has quit IRC | 16:09 | |
*** openstackgerrit has quit IRC | 16:13 | |
*** brinzhang has joined #openstack-nova | 16:18 | |
*** gregwork has joined #openstack-nova | 16:18 | |
*** brinzhang has quit IRC | 16:19 | |
*** brinzhang has joined #openstack-nova | 16:19 | |
*** brinzhang has quit IRC | 16:20 | |
*** lpetrut has quit IRC | 16:20 | |
*** brinzhang has joined #openstack-nova | 16:21 | |
*** KeithMnemonic has joined #openstack-nova | 16:21 | |
*** brinzhang_ has quit IRC | 16:21 | |
*** ociuhandu has quit IRC | 16:21 | |
*** ociuhandu has joined #openstack-nova | 16:22 | |
KeithMnemonic | elod: thank you for the review on https://review.opendev.org/#/c/683008/ any idea who else i can ask to get the "W"? | 16:22 |
*** tosky has quit IRC | 16:23 | |
*** slaweq has quit IRC | 16:24 | |
elod | KeithMnemonic: no problem. well, I was a bit hesitant to give a +2+W, but decided to wait for other stable cores (list of stable cores: https://review.opendev.org/#/admin/groups/540,members ) | 16:27 |
*** mkrai_ has joined #openstack-nova | 16:27 | |
*** iurygregory has quit IRC | 16:29 | |
*** mlycka has joined #openstack-nova | 16:34 | |
KeithMnemonic | melwitt: can you please join the party here https://review.opendev.org/#/c/683008/ ;-) ? | 16:42 |
melwitt | KeithMnemonic: I can go through it later today. thanks for getting more people to review it, that helps | 16:43 |
KeithMnemonic | thank you and as i mentioned the customer with the issue confirmed those fixes correct the broken behavior | 16:44 |
*** rpittau is now known as rpittau|afk | 16:44 | |
*** brinzhang_ has joined #openstack-nova | 16:47 | |
*** brinzhang_ has quit IRC | 16:49 | |
*** brinzhang_ has joined #openstack-nova | 16:49 | |
*** bauzas has joined #openstack-nova | 16:50 | |
*** brinzhang has quit IRC | 16:51 | |
*** jaosorior has quit IRC | 16:55 | |
*** mkrai_ has quit IRC | 16:55 | |
*** openstackgerrit has joined #openstack-nova | 16:56 | |
openstackgerrit | Elod Illes proposed openstack/nova stable/stein: Enhance service restart in functional env https://review.opendev.org/703103 | 16:56 |
*** mrch_ has quit IRC | 17:00 | |
*** tesseract has quit IRC | 17:00 | |
kashyap | gibi: If you're looking a change of scenery, an "easy win", if I may say so myself :-) -- https://review.opendev.org/#/c/616603/ | 17:01 |
gibi | kashyap: I've saved it for tomorrow morning :) | 17:02 |
kashyap | gibi: Yep, it's EoD for us in CET anyway... | 17:02 |
gibi | yepp, I'm about to leave for today | 17:06 |
*** macz has joined #openstack-nova | 17:11 | |
*** tobiash has quit IRC | 17:14 | |
*** tobiash has joined #openstack-nova | 17:23 | |
*** ociuhandu_ has joined #openstack-nova | 17:26 | |
*** ociuhandu has quit IRC | 17:29 | |
*** ociuhandu_ has quit IRC | 17:30 | |
openstackgerrit | Ilya Etingof proposed openstack/nova master: Add JSON schema for network_data.json https://review.opendev.org/703133 | 17:31 |
*** dtantsur is now known as dtantsur|afk | 17:33 | |
*** evrardjp has quit IRC | 17:34 | |
*** evrardjp has joined #openstack-nova | 17:34 | |
*** gouthamr_ has joined #openstack-nova | 17:47 | |
*** dpawlik has quit IRC | 17:52 | |
*** bnemec has joined #openstack-nova | 17:52 | |
*** martinkennelly has quit IRC | 18:00 | |
*** derekh has quit IRC | 18:01 | |
*** bnemec has quit IRC | 18:08 | |
*** gouthamr_ has quit IRC | 18:10 | |
*** _erlon_ has quit IRC | 18:11 | |
*** _erlon_ has joined #openstack-nova | 18:11 | |
*** brinzhang has joined #openstack-nova | 18:15 | |
*** brinzhang_ has quit IRC | 18:18 | |
*** mlycka has quit IRC | 18:28 | |
*** tosky has joined #openstack-nova | 18:50 | |
*** hamzy__ has joined #openstack-nova | 18:55 | |
*** david-lyle has quit IRC | 18:56 | |
*** lpetrut has joined #openstack-nova | 18:56 | |
*** eharney has quit IRC | 18:56 | |
*** hamzy_ has quit IRC | 18:57 | |
*** ralonsoh has quit IRC | 19:00 | |
*** eharney has joined #openstack-nova | 19:09 | |
*** TxGirlGeek has joined #openstack-nova | 19:11 | |
*** mgariepy has quit IRC | 19:15 | |
openstackgerrit | Merged openstack/nova master: nova-net: Remove layer of indirection in 'nova.network' https://review.opendev.org/696745 | 19:17 |
*** igordc has joined #openstack-nova | 19:23 | |
*** sridharg has quit IRC | 19:38 | |
*** martinkennelly has joined #openstack-nova | 20:01 | |
*** slaweq has joined #openstack-nova | 20:11 | |
*** dosaboy has quit IRC | 20:12 | |
*** ganso has quit IRC | 20:15 | |
*** eharney has quit IRC | 20:48 | |
*** awalende has joined #openstack-nova | 20:50 | |
openstackgerrit | Merged openstack/nova stable/stein: Remove global state from the FakeDriver https://review.opendev.org/703102 | 20:51 |
openstackgerrit | Merged openstack/nova stable/queens: Improve metadata server performance with large security groups https://review.opendev.org/697518 | 20:51 |
*** awalende has quit IRC | 20:55 | |
*** ganso has joined #openstack-nova | 20:56 | |
*** dosaboy has joined #openstack-nova | 21:01 | |
openstackgerrit | sean mooney proposed openstack/nova stable/rocky: Block rebuild when NUMA topology changed https://review.opendev.org/703116 | 21:02 |
openstackgerrit | sean mooney proposed openstack/nova stable/rocky: Disable NUMATopologyFilter on rebuild https://review.opendev.org/703117 | 21:02 |
openstackgerrit | sean mooney proposed openstack/nova stable/rocky: FUP for in-place numa rebuild https://review.opendev.org/703118 | 21:02 |
*** lpetrut has quit IRC | 21:12 | |
*** slaweq_ has joined #openstack-nova | 21:14 | |
*** slaweq has quit IRC | 21:15 | |
*** slaweq_ is now known as slaweq | 21:15 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451 | 21:29 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | 21:29 |
*** mlavalle has quit IRC | 21:42 | |
*** bbowen has quit IRC | 21:44 | |
*** bbowen has joined #openstack-nova | 21:44 | |
*** rcernin has joined #openstack-nova | 21:49 | |
*** eharney has joined #openstack-nova | 21:50 | |
*** maciejjozefczyk has joined #openstack-nova | 21:59 | |
*** nweinber__ has quit IRC | 22:01 | |
*** xek has quit IRC | 22:03 | |
*** maciejjozefczyk has quit IRC | 22:07 | |
*** martinkennelly has quit IRC | 22:34 | |
*** slaweq has quit IRC | 22:36 | |
*** tkajinam has joined #openstack-nova | 22:51 | |
*** TxGirlGeek has quit IRC | 22:59 | |
*** dviroel has quit IRC | 22:59 | |
*** macz has quit IRC | 23:30 | |
*** ivve has quit IRC | 23:47 | |
*** brinzhang_ has joined #openstack-nova | 23:48 | |
*** brinzhang has quit IRC | 23:51 | |
*** tosky has quit IRC | 23:51 | |
*** zhanglong has joined #openstack-nova | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!