| *** markvoelker has quit IRC | 00:01 | |
| *** brinzhang has joined #openstack-nova | 00:13 | |
| *** gyee has quit IRC | 00:36 | |
| openstackgerrit | Merged openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.opendev.org/636508 | 00:46 |
|---|---|---|
| openstackgerrit | Merged openstack/nova master: Move dnsmasq restarts to privsep. https://review.opendev.org/639280 | 00:46 |
| *** altlogbot_1 has quit IRC | 00:46 | |
| *** altlogbot_3 has joined #openstack-nova | 00:48 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.77: Support Specifying AZ to unshelve https://review.opendev.org/665136 | 00:53 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Update api-ref for 2.75 to add config_drive in server update response https://review.opendev.org/677324 | 01:08 |
| *** bhagyashris has joined #openstack-nova | 01:11 | |
| *** igordc has quit IRC | 01:11 | |
| *** hongbin has joined #openstack-nova | 01:24 | |
| *** dviroel_ has quit IRC | 01:42 | |
| *** markvoelker has joined #openstack-nova | 01:51 | |
| *** markvoelker has quit IRC | 01:55 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/ocata: Fix misuse of nova.objects.base.obj_equal_prims https://review.opendev.org/676295 | 02:01 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/stein: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677329 | 02:23 |
| *** BjoernT has joined #openstack-nova | 02:25 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677330 | 02:38 |
| *** ricolin has joined #openstack-nova | 02:39 | |
| *** mkrai has joined #openstack-nova | 02:53 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677330 | 03:02 |
| *** spsurya has joined #openstack-nova | 03:03 | |
| *** jdillaman has quit IRC | 03:17 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/queens: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677378 | 03:41 |
| *** BjoernT has quit IRC | 03:42 | |
| *** psachin has joined #openstack-nova | 03:43 | |
| *** mkrai has quit IRC | 03:50 | |
| *** hongbin has quit IRC | 03:51 | |
| *** mkrai has joined #openstack-nova | 03:52 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/pike: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677379 | 03:53 |
| *** udesale has joined #openstack-nova | 04:02 | |
| *** tkajinam has quit IRC | 04:09 | |
| *** tkajinam has joined #openstack-nova | 04:16 | |
| *** tkajinam has quit IRC | 04:17 | |
| *** tkajinam has joined #openstack-nova | 04:18 | |
| openstackgerrit | huanhongda proposed openstack/nova master: Fix for auth during live-migration (2) https://review.opendev.org/669867 | 04:21 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/ocata: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677383 | 04:38 |
| *** ratailor has joined #openstack-nova | 04:46 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/stein: Fix wrong assertions in unit tests https://review.opendev.org/677388 | 04:55 |
| openstackgerrit | Merged openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.opendev.org/639281 | 04:57 |
| *** stakeda has joined #openstack-nova | 04:59 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: Fix wrong assertions in unit tests https://review.opendev.org/677389 | 05:04 |
| *** janki has joined #openstack-nova | 05:10 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/queens: Fix wrong assertions in unit tests https://review.opendev.org/677390 | 05:14 |
| *** maciejjozefczyk has joined #openstack-nova | 05:17 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/pike: Fix wrong assertions in unit tests https://review.opendev.org/677392 | 05:31 |
| *** jaosorior has joined #openstack-nova | 05:32 | |
| *** ratailor_ has joined #openstack-nova | 05:35 | |
| *** ratailor__ has joined #openstack-nova | 05:38 | |
| *** ratailor has quit IRC | 05:38 | |
| *** ratailor_ has quit IRC | 05:40 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/ocata: Fix wrong assertions in unit tests https://review.opendev.org/677393 | 05:45 |
| *** markvoelker has joined #openstack-nova | 05:55 | |
| *** markvoelker has quit IRC | 06:05 | |
| *** markvoelker has joined #openstack-nova | 06:06 | |
| *** markvoelker has quit IRC | 06:10 | |
| *** mkrai has quit IRC | 06:12 | |
| *** mkrai_ has joined #openstack-nova | 06:12 | |
| *** udesale has quit IRC | 06:33 | |
| *** udesale has joined #openstack-nova | 06:34 | |
| *** rcernin has quit IRC | 06:35 | |
| *** damien_r has joined #openstack-nova | 06:50 | |
| *** hongbin has joined #openstack-nova | 06:52 | |
| *** hongbin has quit IRC | 06:56 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/python-novaclient master: Microversion 2.75 - Multiple API cleanup changes https://review.opendev.org/676275 | 07:01 |
| *** udesale has quit IRC | 07:01 | |
| *** aojea has joined #openstack-nova | 07:02 | |
| *** udesale has joined #openstack-nova | 07:02 | |
| *** dpawlik has joined #openstack-nova | 07:08 | |
| *** trident has quit IRC | 07:16 | |
| *** trident has joined #openstack-nova | 07:24 | |
| *** psachin has quit IRC | 07:25 | |
| *** ivve has joined #openstack-nova | 07:36 | |
| *** xek has joined #openstack-nova | 07:39 | |
| *** ricolin has quit IRC | 07:39 | |
| *** bhagyashris has quit IRC | 07:39 | |
| *** ricolin has joined #openstack-nova | 07:39 | |
| *** _cale_kim has joined #openstack-nova | 07:46 | |
| *** ratailor has joined #openstack-nova | 07:50 | |
| *** ratailor__ has quit IRC | 07:50 | |
| *** ralonsoh has joined #openstack-nova | 07:55 | |
| *** ociuhandu has joined #openstack-nova | 07:58 | |
| *** ociuhandu has quit IRC | 07:59 | |
| *** ociuhandu has joined #openstack-nova | 08:00 | |
| *** priteau has joined #openstack-nova | 08:06 | |
| *** jaosorior has quit IRC | 08:16 | |
| *** jangutter has joined #openstack-nova | 08:16 | |
| *** panda has quit IRC | 08:18 | |
| *** panda has joined #openstack-nova | 08:20 | |
| *** ratailor_ has joined #openstack-nova | 08:24 | |
| *** bhagyashris has joined #openstack-nova | 08:25 | |
| *** ratailor has quit IRC | 08:27 | |
| *** derekh has joined #openstack-nova | 08:28 | |
| *** tkajinam has quit IRC | 08:32 | |
| *** shilpasd has joined #openstack-nova | 08:40 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 08:56 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | 08:57 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py https://review.opendev.org/636318 | 08:57 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565 | 08:57 |
| *** takashin has left #openstack-nova | 09:00 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | 09:00 |
| *** jchhatbar has joined #openstack-nova | 09:06 | |
| *** jchhatbar has quit IRC | 09:06 | |
| *** jchhatbar has joined #openstack-nova | 09:07 | |
| *** janki has quit IRC | 09:07 | |
| *** jchhatbar has quit IRC | 09:07 | |
| *** janki has joined #openstack-nova | 09:08 | |
| sean-k-mooney | ... awsome my test passes on py27 and py36 but not py37. this will be fun | 09:13 |
| sean-k-mooney | anyone spot anything in https://review.opendev.org/#/c/666914/7/nova/tests/unit/test_utils.py@266 | 09:14 |
| *** ociuhandu_ has joined #openstack-nova | 09:15 | |
| *** rcernin has joined #openstack-nova | 09:15 | |
| *** ociuhandu_ has quit IRC | 09:16 | |
| sean-k-mooney | oh its the inital assert | 09:17 |
| sean-k-mooney | self.assertEqual(utils._TRAITS_CACHE, {}) | 09:17 |
| sean-k-mooney | on python 27 and 36 applying @mock.patch.dict(utils._TRAITS_CACHE, clear=True) to the class patches it in every function but i guess its not working in py37 | 09:18 |
| aspiers | sean-k-mooney: oh that's interesting, just like what we were talking about yesterday | 09:20 |
| sean-k-mooney | yesterday as in have the mock apply to all functions | 09:21 |
| sean-k-mooney | in a class | 09:21 |
| aspiers | yes | 09:21 |
| sean-k-mooney | it might still be applying but the sematics of clear=True may have been broken but in any case it broken | 09:21 |
| aspiers | any chance you could test https://review.opendev.org/#/c/666616/31/nova/tests/unit/virt/libvirt/test_driver.py@23813 on py37? | 09:22 |
| aspiers | I don't have a py37 environment | 09:22 |
| aspiers | oh wait, I do | 09:22 |
| sean-k-mooney | adding the mock to the class was a way of sutbing out the field without needed to add a patcher and cleanup function in __init__ | 09:23 |
| aspiers | I found a way to apply a mock to all tests in a class, but efried hated it (and he was right, it's fugly) | 09:23 |
| aspiers | https://review.opendev.org/#/c/666616/23/nova/tests/unit/virt/libvirt/test_driver.py@23555 | 09:23 |
| aspiers | but it does work at least | 09:24 |
| aspiers | you call __enter__() during setUp() and __exit__() during tearDown() | 09:24 |
| * aspiers downloads nova onto his box with 3.7 | 09:24 | |
| aspiers | brb | 09:24 |
| sean-k-mooney | aspiers: there are cleaner ways | 09:25 |
| sean-k-mooney | ill test it locally with my change and then ill comment on yours | 09:26 |
| *** aojea has quit IRC | 09:28 | |
| *** aojea has joined #openstack-nova | 09:28 | |
| sean-k-mooney | well that is annoying my original code passes locally so i guess i need top use the gate to test this. | 09:41 |
| openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: report storage bus traits https://review.opendev.org/666914 | 09:43 |
| *** jaosorior has joined #openstack-nova | 09:47 | |
| *** ratailor__ has joined #openstack-nova | 09:53 | |
| *** ociuhandu has quit IRC | 09:54 | |
| *** ratailor_ has quit IRC | 09:56 | |
| *** bhagyashris has quit IRC | 10:06 | |
| *** udesale has quit IRC | 10:16 | |
| yaawang | stephenfin: Hi, can you take a look at the patch: https://review.opendev.org/#/c/670298, it's a part of spec vCPU model selection. :) | 10:16 |
| *** udesale has joined #openstack-nova | 10:17 | |
| *** priteau has quit IRC | 10:18 | |
| *** ociuhandu has joined #openstack-nova | 10:27 | |
| *** rcernin has quit IRC | 10:28 | |
| *** cervigni has joined #openstack-nova | 10:30 | |
| cervigni | hello guys, I am trying to have the VGPU feature working on rhel7 but I always hit this issue | 10:30 |
| cervigni | 2019-08-20 18:28:10.527 17202 ERROR nova.virt.libvirt.driver [req-031bc6f7-be61-406b-aefd-020a24e76f5e d7ef7ad4b0424f78a5010503b095ae84 35d0e97603b04dadaee6dfafbd19e5f9 - default default] [instance: 9300b931-12e5-421a-a8ae-ef1854d4cb38] Failed to start libvirt guest: libvirtError: internal error: qemu unexpectedly closed the monitor: 2019-08-20T10:28:10.301572Z qemu-kvm: -device vfio-pci,id=hostdev0,sysfsdev=/sys/bus/mdev/devices/a0543cde-3934- | 10:30 |
| cervigni | 460f-8994-6be8c80fe417,display=off,bus=pci.0,addr=0x6: vfio error: a0543cde-3934-460f-8994-6be8c80fe417: error getting device from group 81: Input/output error | 10:30 |
| cervigni | what can this be related to? I intalled the vGPU drivers, flavor is correct, vgpu is set to nvidia-106 | 10:31 |
| sean-k-mooney | have you enabled the iommu on the host | 10:31 |
| cervigni | GRUB_CMDLINE_LINUX="crashkernel=auto spectre_v2=retpoline rd.lvm.lv=rhel/root rd.lvm.lv=rhel/swap rhgb quiet intel_iommu=on iommu=pt modprobe.blacklist=nouveau" | 10:31 |
| cervigni | yes | 10:31 |
| cervigni | is there anything else I should enable/disable? | 10:32 |
| sean-k-mooney | is there a traceback in the libvirt instacne log | 10:32 |
| cervigni | yes | 10:32 |
| cervigni | 2019-08-20T10:28:10.301572Z qemu-kvm: -device vfio-pci,id=hostdev0,sysfsdev=/sys/bus/mdev/devices/a0543cde-3934-460f-8994-6be8c80fe417,display=off,bus=pci.0,addr=0x6: vfio error: a0543cde-3934-460f-8994-6be8c80fe417: error getting device from group 81: Input/output error | 10:32 |
| cervigni | Verify all devices in group 81 are bound to vfio-<bus> or pci-stub and not already in use | 10:32 |
| cervigni | 2019-08-20 10:28:10.318+0000: shutting down, reason=failed | 10:32 |
| sean-k-mooney | ah i know what happening then | 10:33 |
| cervigni | really? | 10:33 |
| sean-k-mooney | for sriov or vgpus to work all devices in the same iommu group need to use the same driver | 10:33 |
| cervigni | I had exactly the same issue with ubuntu. I moved to rhel7 because I thought that was the issue | 10:33 |
| sean-k-mooney | so you need to due a few things first you need to check what device are part of iommu group 81 | 10:34 |
| sean-k-mooney | and ensure that tey are all bound to vfio-pci | 10:34 |
| sean-k-mooney | for example but the gpu and the gpus onboard audio contoller | 10:34 |
| sean-k-mooney | they are two different pcie endpoint that share the same iommu group in most cases | 10:35 |
| *** ociuhandu has quit IRC | 10:35 | |
| aspiers | stephenfin: why does test-requirements.txt have psycopg2 at all? is postgres still supported? | 10:35 |
| cervigni | IOMMU Group 81: | 10:36 |
| cervigni | lspci: -s: Invalid slot number | 10:36 |
| sean-k-mooney | if you intalled the card in a pci slot connected to the chipset via the dmi bridge rahter then then directly to the cpu that could also cause the same issue were you are sharing an iommu groupe between multiple devices | 10:36 |
| cervigni | uhm that is definitely a wrong group | 10:36 |
| sean-k-mooney | that is not how you check | 10:36 |
| stephenfin | aspiers: I recall cfriesen mentioning something about them caring about postgres in the distant pass, but I honestly can't say any more than that | 10:36 |
| stephenfin | yaawang: Sure thing | 10:36 |
| aspiers | stephenfin: about who caring? | 10:36 |
| stephenfin | Windriver | 10:36 |
| aspiers | oh | 10:36 |
| aspiers | SUSE used to use pg for OpenStack, but ditched it quite a while ago | 10:37 |
| stephenfin | *Wind River? | 10:37 |
| stephenfin | Yeah, I've no idea if it even works nowadays | 10:37 |
| sean-k-mooney | cervigni: give me a sec and ill see if i can get the command | 10:37 |
| aspiers | Yeah X-D Windriver makes me think of DLLs *shudder* | 10:37 |
| aspiers | stephenfin: seems dumb that I have to install pg_config to run unit tests | 10:38 |
| stephenfin | Or build docs | 10:38 |
| stephenfin | or do anything, really | 10:38 |
| cervigni | thanks | 10:38 |
| stephenfin | tbh, we shouldn't even need the MySQL dependencies for that | 10:38 |
| aspiers | true | 10:39 |
| sean-k-mooney | cervigni: this is not the exact command but more or less does what you want | 10:39 |
| *** _cale_kim has quit IRC | 10:39 | |
| sean-k-mooney | http://paste.openstack.org/show/760302/ | 10:40 |
| sean-k-mooney | you will want to pipe that to less and check iommu group 81 | 10:41 |
| *** dosaboy has quit IRC | 10:42 | |
| cervigni | that is the same of what I pasted earlier, for IOMMU group 81 (where the problem comes from) | 10:42 |
| sean-k-mooney | you can also just do ls /sys/kernel/iommu_groups/81/devices/ | 10:42 |
| cervigni | it reports only a lspci: -s: Invalid slot number | 10:42 |
| *** ganso has quit IRC | 10:42 | |
| sean-k-mooney | yes -s take a pci address not iommu group number | 10:42 |
| *** bbowen has quit IRC | 10:42 | |
| sean-k-mooney | they are totally different things | 10:42 |
| cervigni | ok | 10:42 |
| sean-k-mooney | what do you get for "ls /sys/kernel/iommu_groups/81/devices/" | 10:43 |
| cervigni | [root@compute-r6-h28 ~]# ls /sys/kernel/iommu_groups/81/devices/a0543cde-3934-460f-8994-6be8c80fe417/ | 10:43 |
| cervigni | driver iommu_group mdev_type nvidia power remove subsystem uevent | 10:43 |
| *** spatel has joined #openstack-nova | 10:45 | |
| *** spatel has quit IRC | 10:50 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Note use of 'nova-manage db sync --config-file' https://review.opendev.org/671298 | 10:56 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document global options for nova-manage https://review.opendev.org/677443 | 10:56 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: config: Explicitly register 'remote_debug' CLI opts https://review.opendev.org/677444 | 10:56 |
| *** macz has joined #openstack-nova | 11:04 | |
| *** tesseract has joined #openstack-nova | 11:08 | |
| *** ociuhandu has joined #openstack-nova | 11:08 | |
| *** ociuhandu has quit IRC | 11:09 | |
| *** macz has quit IRC | 11:09 | |
| *** ociuhandu has joined #openstack-nova | 11:09 | |
| *** udesale has quit IRC | 11:18 | |
| *** dave-mccowan has joined #openstack-nova | 11:19 | |
| *** ganso has joined #openstack-nova | 11:24 | |
| *** dosaboy has joined #openstack-nova | 11:28 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.opendev.org/639282 | 11:34 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Move setting of device trust to privsep. https://review.opendev.org/639283 | 11:34 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Move final bridge commands to privsep. https://review.opendev.org/639580 | 11:34 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.opendev.org/639581 | 11:34 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: We no longer need rootwrap. https://review.opendev.org/554438 | 11:34 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.opendev.org/639826 | 11:34 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Address nits from privsep series https://review.opendev.org/677210 | 11:34 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP! Stop passing 'root_helper' argument to os-brick https://review.opendev.org/677451 | 11:34 |
| *** markvoelker has joined #openstack-nova | 11:35 | |
| *** markvoelker has quit IRC | 11:40 | |
| *** tbachman has quit IRC | 11:43 | |
| *** bbowen has joined #openstack-nova | 11:44 | |
| *** ociuhandu has quit IRC | 11:54 | |
| *** ociuhandu has joined #openstack-nova | 11:54 | |
| *** markvoelker has joined #openstack-nova | 11:57 | |
| *** rpittau|afk is now known as rpittau | 12:05 | |
| *** tbachman has joined #openstack-nova | 12:13 | |
| *** ociuhandu has quit IRC | 12:24 | |
| *** ratailor__ has quit IRC | 12:27 | |
| *** dviroel_ has joined #openstack-nova | 12:36 | |
| *** dviroel_ is now known as dviroel | 12:39 | |
| *** dviroel has left #openstack-nova | 12:40 | |
| *** jaosorior has quit IRC | 12:43 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Track libvirt host/domain capabilities for multiple machine types https://review.opendev.org/673151 | 12:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Track libvirt host/domain capabilities for multiple machine types https://review.opendev.org/673151 | 12:46 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Extract new base class for provider usage functional tests https://review.opendev.org/676964 | 12:50 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | 12:50 |
| openstackgerrit | Alexandra Settle proposed openstack/nova stable/rocky: Fixing broken links https://review.opendev.org/677460 | 12:51 |
| *** mriedem has joined #openstack-nova | 12:53 | |
| alex_xu | aspiers: the line 697-701 of https://review.opendev.org/#/c/673151/11/nova/virt/libvirt/host.py is about the why we need that set of machine type? | 12:53 |
| aspiers | alex_xu: We need to cover the main variants | 12:54 |
| alex_xu | aspiers: ok, so the pc and q35 can cover all the cases, right? | 12:54 |
| aspiers | yes | 12:54 |
| aspiers | this is mentioned in the commit message | 12:55 |
| alex_xu | aspiers: thanks, i see now | 12:55 |
| alex_xu | aspiers: is it too arch specific? | 12:55 |
| alex_xu | although I didn't see other arch need this method | 12:55 |
| aspiers | pc / q35 are not hardcoded | 12:55 |
| aspiers | alex_xu: they come from utils.get_default_machine_type() and libvirt's getCapabilities | 12:56 |
| alex_xu | I mean in other arch, it is also about default and canonical covering all the cases | 12:56 |
| aspiers | so other architectures will get a different set | 12:56 |
| aspiers | yes, correct | 12:56 |
| alex_xu | ok, I'm just going to trust the libvirt and platform experts | 12:57 |
| aspiers | that's why I had to remove 'bamboo' from the fixture | 12:57 |
| *** ociuhandu has joined #openstack-nova | 12:57 | |
| sean-k-mooney | bamboo as a fake arch or machine type :) | 12:58 |
| alex_xu | hah | 12:58 |
| aspiers | because the static fixtures for getDomainCapabilities on ppc did not return correct values for bamboo | 12:58 |
| sean-k-mooney | i can see both working | 12:58 |
| *** ociuhandu has quit IRC | 12:58 | |
| aspiers | bamboo is a real machine type for ppc | 12:58 |
| sean-k-mooney | really ok | 12:58 |
| *** ociuhandu has joined #openstack-nova | 12:58 | |
| sean-k-mooney | but ya its not in the static data we are using right | 12:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update api-ref for 2.75 to add config_drive in server update response https://review.opendev.org/677324 | 12:59 |
| alex_xu | aspiers: so the only complain is no unittest for host.py change, but I'm ok with a followup. | 12:59 |
| aspiers | https://review.opendev.org/#/c/673151/13/nova/tests/unit/virt/libvirt/fakelibvirt.py@1673 | 12:59 |
| *** jaosorior has joined #openstack-nova | 12:59 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova master: requirements: move to using psycopg2-binary https://review.opendev.org/676684 | 13:01 |
| openstackgerrit | Mohammed Naser proposed openstack/nova master: requirements: move to using psycopg2-binary https://review.opendev.org/676684 | 13:01 |
| aspiers | alex_xu: hmm that's a good point | 13:02 |
| *** jdillaman has joined #openstack-nova | 13:04 | |
| *** spatel has joined #openstack-nova | 13:05 | |
| *** BjoernT has joined #openstack-nova | 13:05 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.75 - Multiple API cleanup changes https://review.opendev.org/676275 | 13:08 |
| *** owalsh has quit IRC | 13:09 | |
| mriedem | final 2 patches for 2.75 https://review.opendev.org/#/q/topic:bp/api-consistency-cleanup+status:open | 13:10 |
| alex_xu | aspiers: the spec said the trait "a) it cannot be used yet, only in the future when SEV support is fully implemented,"...that confuse me | 13:11 |
| alex_xu | is there any update for the exist spec, we need that trait again? | 13:11 |
| sean-k-mooney | alex_xu: we will need that trait only when intels mktme feature is supported | 13:12 |
| aspiers | right | 13:12 |
| sean-k-mooney | need is also a strong word there in that it is only needed if you specifica want SEV | 13:13 |
| sean-k-mooney | if you jsut want encyrpetd memory you use the resouce class on its own | 13:13 |
| alex_xu | sean-k-mooney: they share same resource class? | 13:13 |
| aspiers | MKTME is not implemented yet | 13:14 |
| aspiers | but we expect it to use the same resource class | 13:14 |
| alex_xu | ok, i see now | 13:14 |
| aspiers | the MKTME spec is still in draft | 13:14 |
| alex_xu | yea, I didn't follow that spec | 13:14 |
| aspiers | but the resource class is not used directly by users/operators, only internally | 13:15 |
| alex_xu | but I "should" | 13:15 |
| aspiers | externally they use hw:mem_encryption extra spec and hw_mem_encryption image property | 13:15 |
| aspiers | and that gets translated in the RequestSpec to resources:MEM_ENCRYPTION_CONTEXT=1 | 13:15 |
| sean-k-mooney | given that one is an intel only tech and the other is an amd only tech we do not expec a singel RP to have inventoies fo both so 1 resouce class and 2 traits for what is effectvly the same thing form a guest point of view | 13:15 |
| aspiers | right | 13:16 |
| alex_xu | got it | 13:16 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 13:17 |
| sean-k-mooney | by the way these keystone auth issues "keystoneauth1.exceptions.auth_plugins.MissingAuthPlugin: An auth plugin is required to determine endpoint URL" if i rebase my patch these should go away right | 13:18 |
| sean-k-mooney | they are unrelated to my code in anycase so ill assume its as a result of keystone/sdk changes | 13:21 |
| *** brinzhang has quit IRC | 13:21 | |
| *** brinzhang has joined #openstack-nova | 13:21 | |
| sean-k-mooney | aspiers: by the way https://review.opendev.org/#/c/666914/7..8/nova/tests/unit/test_utils.py resolved my python 3.7 failure just in case you hit similar issues. | 13:22 |
| sean-k-mooney | mock.patch.dict works slightly different then some of the other patch function so you might not have issues | 13:23 |
| aspiers | sean-k-mooney: nice, thanks. | 13:23 |
| aspiers | this should work for my patch_{open,exists} too | 13:23 |
| *** artom has quit IRC | 13:24 | |
| sean-k-mooney | yep i commented on that | 13:24 |
| sean-k-mooney | on the older revision | 13:24 |
| *** artom has joined #openstack-nova | 13:28 | |
| *** cz2 has joined #openstack-nova | 13:30 | |
| *** zhubx has quit IRC | 13:32 | |
| aspiers | saw that, thanks | 13:32 |
| *** zhubx has joined #openstack-nova | 13:33 | |
| *** udesale has joined #openstack-nova | 13:35 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: report storage bus traits https://review.opendev.org/666914 | 13:38 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: use domain capablites to get supported device models https://review.opendev.org/666915 | 13:38 |
| sean-k-mooney | ill be rebasing ^ after i update the last patch in the series | 13:39 |
| *** zhubx has quit IRC | 13:40 | |
| *** zhubx has joined #openstack-nova | 13:40 | |
| *** ociuhandu has quit IRC | 13:41 | |
| *** owalsh has joined #openstack-nova | 13:41 | |
| *** eharney has joined #openstack-nova | 13:42 | |
| *** udesale has quit IRC | 13:42 | |
| *** udesale has joined #openstack-nova | 13:43 | |
| *** mkrai_ has quit IRC | 13:43 | |
| *** ociuhandu has joined #openstack-nova | 13:46 | |
| *** ralonsoh has quit IRC | 13:48 | |
| *** udesale has quit IRC | 13:50 | |
| openstackgerrit | Alexandra Settle proposed openstack/nova stable/rocky: [stable-only] Fixing broken links https://review.opendev.org/677460 | 13:51 |
| alex_xu | sean-k-mooney: efried mriedem https://etherpad.openstack.org/p/vpmems-non-virt-driver-specific | 13:54 |
| alex_xu | ^ I'm wating for Luyao ensure her code, but that is the basic idea | 13:54 |
| efried | alex_xu: Whereas it would be nice to be able to do without data model changes, I think this makes sense and makes a number of things much simpler. | 13:55 |
| *** ralonsoh has joined #openstack-nova | 13:55 | |
| alex_xu | efried: \o/ | 13:55 |
| mnaser | https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#scheduling-considerations | 13:56 |
| mnaser | is the note a bit contradicting, if i understand correctly, setting aggregate allocation ratios doesnt work in the scheduler anymore? | 13:57 |
| mnaser | so AggregateCoreFilter is technically useless? | 13:57 |
| mriedem | https://review.opendev.org/#/c/673496/ | 13:57 |
| mnaser | ok | 13:57 |
| mnaser | makes sense now | 13:57 |
| mriedem | maybe "The AggregateCoreFilter, AggregateDiskFilter and AggregateRamFilter filters allow overriding per-compute allocation ratios by setting an allocation ratio value using host aggregate metadata. This provides a convenient way to manage a group of compute hosts with similar allocation ratios while leaving the configuration settings alone." should just be removed | 13:58 |
| mnaser | yeah it seems to tell you "this is how to solve this problem. note, it doesn't work" | 13:58 |
| mriedem | because it's essentially saying, "before ocata, ^ was true, but since ocata it's not" | 13:58 |
| mnaser | so for a stein cloud, i can just update the placement service aggregate then? | 13:58 |
| mriedem | you have to set the allocation ratio on each provider in the placement aggregate | 13:59 |
| mriedem | mel has a convenience cli patch for doing this, sec | 13:59 |
| mriedem | https://review.opendev.org/#/c/640898/ | 13:59 |
| mriedem | so since pike your compute host aggregates and provider aggregates should be automatically mirrored, | 13:59 |
| mriedem | the thing that isn't is the compute host aggregate allocation ratio metadata, since placement resource provider aggregates don't have metadata | 14:00 |
| mnaser | oh neat, and technically i shouldn't worry about nova re-overriding it because it only adds it when the rp is first registered, right? | 14:00 |
| mriedem | if you change the allocation ratio config on a nova-compute it would be updated in placement | 14:00 |
| mriedem | that's where https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#usage-scenarios comes in | 14:00 |
| mnaser | oh i thought we now had initial_foo | 14:00 |
| mriedem | b/c some people (cern) want to manage allocation ratios in config always, | 14:01 |
| mriedem | and others (mgagne) want to manage allocation ratios in an API always | 14:01 |
| mriedem | config trumps api | 14:01 |
| mnaser | hmm okay, so either stick to initial_foo and leave others empty or foo | 14:01 |
| mriedem | if config is set | 14:01 |
| mriedem | yes | 14:01 |
| mnaser | yeah makes sense, i think ill stick to config for now | 14:01 |
| mriedem | you just described scenario 2 | 14:02 |
| *** janki has quit IRC | 14:04 | |
| *** ricolin has quit IRC | 14:04 | |
| *** bbowen_ has joined #openstack-nova | 14:05 | |
| *** bbowen has quit IRC | 14:05 | |
| *** liuyulong has joined #openstack-nova | 14:06 | |
| mriedem | ok i see how the note got mixed in and is confusing, will push a patch to clean that up | 14:06 |
| cfriesen | stephenfin: aspiers: we don't care about postgres anymore. :) | 14:07 |
| mriedem | but mnaser does now | 14:07 |
| mnaser | Oh I don't either | 14:07 |
| mnaser | It was just a pita to run tests locally | 14:08 |
| mnaser | And someone mentioned something about needing postgres libs so some postgres tests run | 14:08 |
| sean-k-mooney | alex_xu: ill come back to your etherpad in a bit just going to finish the thing i was in the middle of | 14:08 |
| alex_xu | sean-k-mooney: thanks! | 14:09 |
| mriedem | mnaser: oh :) | 14:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: remove confusing docs about aggregate allocation ratios https://review.opendev.org/677472 | 14:11 |
| mriedem | mnaser: also ^ | 14:11 |
| *** dave-mccowan has quit IRC | 14:12 | |
| mnaser | if we dont care about postgres ill gladly update that change to remove it entirely -- https://review.opendev.org/#/c/676684/ | 14:12 |
| mriedem | cfriesen said he, and by extension windriver/starlingx, don't care about postgres anymore | 14:12 |
| mriedem | that doesn't mean we're just ripping it out, there are others that use it i think | 14:13 |
| mriedem | we have a job in the experimental queue to test with pg on-demnd | 14:13 |
| mriedem | i think cdent dabbles with pg as well | 14:13 |
| stephenfin | openstack-discuss post time? | 14:13 |
| mriedem | why? | 14:13 |
| mriedem | it's already been discussed, several times, | 14:13 |
| mriedem | including with a TC resolution years ago | 14:13 |
| mriedem | and people came to the "meh, it's not hurting, so who cares" | 14:14 |
| stephenfin | mnaser, aspiers and I, for a start | 14:14 |
| stephenfin | idk, feels odd to keep testing something that no one uses or cares about | 14:15 |
| mriedem | what is prompting this coming up? | 14:15 |
| mriedem | we test and fix pg on demand when there is an issue someone reports, because there are people using it | 14:15 |
| mnaser | i assume when i ran unit tests locally and psycopg2 failed to build cause i was missing headers | 14:15 |
| mriedem | just because they aren't daily upstream contributors doesn't mean people are'nt using it, or that it's broken | 14:15 |
| mnaser | so i was like "well i scanned the source code and couldnt find any references, why is it in requirements?" | 14:15 |
| mnaser | and someone explianed something about some sort of test path that happened if the library was found | 14:16 |
| mnaser | and someone asked cfriesen if they used postgres and here we are, afaik | 14:16 |
| mriedem | it's really a bindep thing for the opportunistic schema migration tests | 14:16 |
| mnaser | https://review.opendev.org/#/c/676684/ means we dont have to carry it anymore | 14:16 |
| mriedem | we can just as easily remove mysql from test-requirements | 14:16 |
| stephenfin | I must say it'd be nice not to need to install those to build our docs. What happened to the idea to move them into 'extras', like oslo.db does? | 14:18 |
| stephenfin | I didn't know there were actually people using postgres though. I thought it was just cfriesen, tbh :) | 14:18 |
| *** tbachman has quit IRC | 14:18 | |
| mriedem | prometheanfire also uses pg | 14:19 |
| mriedem | and huawei | 14:19 |
| *** mkrai_ has joined #openstack-nova | 14:21 | |
| mnaser | stephenfin: i think to build docs we use doc/requirements.txt now? | 14:21 |
| mnaser | so you shouldn't need to install it.. i think? | 14:22 |
| stephenfin | mnaser: apidoc :( | 14:22 |
| stephenfin | that introspects the code so you need nova to be installed, which brings in all the dependencies | 14:22 |
| mnaser | ah gotcha | 14:22 |
| mnaser | hmm | 14:23 |
| mriedem | we don't publish an api module index | 14:23 |
| mriedem | in our docs | 14:23 |
| mnaser | but we dont have psycopg in requirements, only in test-requirements i think | 14:23 |
| mnaser | no db driver exists in requirements afaik | 14:23 |
| mriedem | if we're building an api doc, it's a waste of time | 14:23 |
| mriedem | mnaser: correct. -1 on the lower-constraints thing, otherwise i'd be +2. | 14:24 |
| *** tbachman has joined #openstack-nova | 14:24 | |
| mriedem | might as well address efried's comments as well | 14:24 |
| stephenfin | mriedem: We do. See doc/source/reference/services.rst and doc/source/reference/services.rst | 14:24 |
| stephenfin | doc/source/reference/notifications.rst | 14:25 |
| stephenfin | 145:.. automodule:: nova.notifications.objects.base | 14:25 |
| stephenfin | doc/source/reference/services.rst | 14:25 |
| stephenfin | 31:.. automodule:: nova.service | 14:25 |
| stephenfin | 41:.. automodule:: nova.manage | 14:25 |
| mriedem | oh god, we could just remove that | 14:25 |
| stephenfin | no argument from me (y) | 14:25 |
| mriedem | that's probably a relic from when you could extend that stuff via config out of tree | 14:25 |
| mriedem | we removed that eons ago | 14:26 |
| stephenfin | even the notifications stuff? | 14:26 |
| mriedem | ew this https://docs.openstack.org/nova/latest/reference/notifications.html#the-nova-notifications-objects-base-module | 14:26 |
| mriedem | that's actually useful for contributors adding new versioned notifications | 14:27 |
| mriedem | is there a way to only build part of the api doc and not all of it? | 14:27 |
| *** jmlowe has joined #openstack-nova | 14:27 | |
| stephenfin | not that I'm aware of, but that autodoc package is really tough to grok | 14:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Move DB, virt driver deps to 'extras' https://review.opendev.org/677475 | 14:29 |
| stephenfin | mnaser, mriedem, aspiers: WIP but I think that would do the trick ^ | 14:29 |
| *** mlavalle has joined #openstack-nova | 14:30 | |
| prometheanfire | if I had to do it again... | 14:30 |
| efried | alex_xu, sean-k-mooney: I think we now need to write a crisp discussion-free version of the design points as refined. I recommend either creating a new etherpad or shunting the current content down and doing it above. | 14:31 |
| aspiers | stephenfin: cool! how do you use extras? | 14:31 |
| stephenfin | prometheanfire: I'd do it with you? 🎶 | 14:31 |
| stephenfin | aspiers: 'cd nova; pip install .[mysql]' | 14:32 |
| sean-k-mooney | efried: yes we do. | 14:32 |
| aspiers | stephenfin: what is that voodoo syntax! :) | 14:32 |
| stephenfin | or 'pip install .[mysql,postgres,foo]' | 14:32 |
| sean-k-mooney | efried: over all do you think this is a workable direction | 14:32 |
| aspiers | never seen that before | 14:32 |
| alex_xu | efried: got it | 14:32 |
| stephenfin | now you know :) | 14:33 |
| sean-k-mooney | stephenfin: that is install the python module in the current folder with the [] extras packages listed in the brackets right | 14:33 |
| stephenfin | fwiw, that's what pbr is doing for 'doc/requirements.txt' under the hood | 14:33 |
| stephenfin | it just generates a docs extra | 14:33 |
| stephenfin | sean-k-mooney: correctamundo | 14:33 |
| stephenfin | it also works with packages for PyPI, e.g. 'pip install oslo.db[mysql]' | 14:34 |
| stephenfin | *from | 14:34 |
| sean-k-mooney | alex_xu: i think it would be useful if you used both pmem and vgpus as example of how this could be used | 14:35 |
| alex_xu | sean-k-mooney: good idea | 14:35 |
| efried | sean-k-mooney: Workable, yes. Whether it's going to get by mriedem and dansmith is another question. But let's have that crisp writeup for them to look at so they don't have to try to follow our chicken-scratch stream of consciousness | 14:37 |
| openstackgerrit | Mohammed Naser proposed openstack/nova master: requirements: move to using psycopg2-binary https://review.opendev.org/676684 | 14:38 |
| mnaser | mriedem: ^ good call on lower-constraints | 14:38 |
| *** tbachman has quit IRC | 14:40 | |
| *** dpawlik has quit IRC | 14:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338 | 14:42 |
| mriedem | sean-k-mooney: i fixed up some nits in the libvirt driver tests https://review.opendev.org/#/c/671338/13 | 14:43 |
| mriedem | +2 | 14:43 |
| *** aojea has quit IRC | 14:43 | |
| mriedem | stephenfin: i'm +2 on the vpmu change now https://review.opendev.org/#/c/671338/13 | 14:43 |
| stephenfin | (y) | 14:43 |
| mriedem | sean-k-mooney: you still need to update this v | 14:43 |
| mriedem | https://review.opendev.org/#/c/675182/2 | 14:43 |
| sean-k-mooney | mriedem: thanks :) | 14:43 |
| sean-k-mooney | is that the glance change | 14:43 |
| mriedem | yes | 14:43 |
| sean-k-mooney | its on the todo list for today | 14:43 |
| sean-k-mooney | im just finishing up myu prefilter change based on stephenfin commenst | 14:44 |
| sean-k-mooney | then ill update both glance patches | 14:44 |
| *** tbachman has joined #openstack-nova | 14:45 | |
| sean-k-mooney | stephenfin: ill address your comments on the deprecation patch after all of that is done ^ | 14:46 |
| *** zhubx has quit IRC | 14:48 | |
| mriedem | melwitt: so abandon https://review.opendev.org/#/c/675218/ at this point yeah? | 14:48 |
| *** zhubx has joined #openstack-nova | 14:48 | |
| aspiers | alex_xu: does https://review.opendev.org/#/c/638680/46/nova/tests/functional/libvirt/test_report_cpu_traits.py@92 make sense now? | 14:49 |
| *** zhubx has quit IRC | 14:50 | |
| mriedem | melwitt: actually https://review.opendev.org/#/c/507486/67/nova/db/sqlalchemy/api.py@5572 | 14:50 |
| *** zhubx has joined #openstack-nova | 14:51 | |
| *** mkrai_ has quit IRC | 14:51 | |
| sean-k-mooney | aspiers im changeing how some of that works by the way. | 14:52 |
| mriedem | heh yeah in PS65 you had this: | 14:52 |
| *** bbowen__ has joined #openstack-nova | 14:52 | |
| mriedem | meta = MetaData(get_engine(context=context, use_slave=True)) | 14:52 |
| aspiers | sean-k-mooney: some of which? | 14:52 |
| sean-k-mooney | how the libvirt driver reports traits | 14:52 |
| aspiers | sean-k-mooney: I'm just reviewing your patch now | 14:52 |
| aspiers | sean-k-mooney: you mean https://review.opendev.org/#/c/666915/8/nova/virt/libvirt/driver.py ? | 14:53 |
| *** artom has quit IRC | 14:54 | |
| sean-k-mooney | that and the general helper function i have intoduced to remove most of the bolier plate | 14:54 |
| *** bbowen_ has quit IRC | 14:54 | |
| sean-k-mooney | aspiers: hopefully the chagne wont conflict or wont confict too badly just wanted you to be aware | 14:57 |
| aspiers | sean-k-mooney: I don't think it will conflict because the SEV trait is provided via a capability | 14:57 |
| sean-k-mooney | ok | 14:58 |
| aspiers | fingers crossed anyway, because you are just ahead of me on the runway X-D | 14:58 |
| *** openstackstatus has quit IRC | 14:58 | |
| *** openstack has joined #openstack-nova | 15:01 | |
| *** ChanServ sets mode: +o openstack | 15:01 | |
| sean-k-mooney | sure i am vauguly aware that the new version of lxml broke things | 15:01 |
| sean-k-mooney | i had thought that there was a larger patch that capped 4 or 5 libs floating around somewhere | 15:02 |
| *** s1061123 has quit IRC | 15:03 | |
| *** pvradu has joined #openstack-nova | 15:03 | |
| *** nweinber_ has joined #openstack-nova | 15:03 | |
| sean-k-mooney | efried: this is the ml thread http://lists.openstack.org/pipermail/openstack-discuss/2019-August/008562.html | 15:05 |
| efried | yes | 15:05 |
| sean-k-mooney | i think the bug present in how we compare xmls as equal or somthing like that | 15:06 |
| *** nweinber has quit IRC | 15:06 | |
| sean-k-mooney | so i dont think it breaks the libvirt dirver but does break our unit tests | 15:06 |
| *** tbachman has quit IRC | 15:06 | |
| efried | sean-k-mooney: in short, we either need to see if we can fix this in nova, or blacklist the lxml version(s) and open bugs against them and eventually uncap if/when they fix etc etc. | 15:06 |
| sean-k-mooney | we likely shoudl be able to fix it in nova. ill see if i can repoduce this later today. | 15:07 |
| efried | thanks sean-k-mooney. It just looks like attr ordering. We could probably resolve it in XMLMatcher, I would think. | 15:08 |
| efried | I'm actually kind of surprised that that's not already taken into account there. | 15:08 |
| sean-k-mooney | current upper-constratis is set to 4.3.4? so we dont hit this | 15:08 |
| efried | or maybe those tests aren't using XMLMatcher. | 15:08 |
| efried | sean-k-mooney: that's the point, prometheanfire is trying to get u-c to the latest published versions and running into this. | 15:08 |
| sean-k-mooney | yep i know but we simply would not uncapp them in Train if that was not fixed by m3 | 15:09 |
| sean-k-mooney | we should be able to fix it if its not too pervasive before then | 15:09 |
| sean-k-mooney | it could be that it broke the XMLMatcher i just vaguly recall talking to prometheanfire about this so need to look at the actull error first to load context | 15:10 |
| prometheanfire | ya, think we talked about it, wasn't it an ordering thing? | 15:12 |
| sean-k-mooney | yep | 15:12 |
| sean-k-mooney | i think so | 15:12 |
| *** icarusfactor has quit IRC | 15:12 | |
| sean-k-mooney | once i reporduce it it will likely be a simple fix | 15:13 |
| sean-k-mooney | either use the matcher if its using it already or fix the matcher | 15:13 |
| sean-k-mooney | we created the xmlmatcher to ignore order | 15:13 |
| sean-k-mooney | unlike other markup formate whitespace in xml and order is technically signifcant | 15:14 |
| prometheanfire | just made https://review.opendev.org/677480 for you to submit reviews against to test (if you want) | 15:14 |
| sean-k-mooney | ya i saw i can just add a depens on to make sure it passes | 15:15 |
| efried | prometheanfire: Any particular temest test I should look at for the websockify thing? | 15:15 |
| efried | tempest* | 15:15 |
| prometheanfire | I'm not sure for that one | 15:15 |
| efried | so I can pare down the jobs and conserve resources | 15:15 |
| efried | okay, I'll just run 'em all then. | 15:15 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: Test websockify 0.9.0 https://review.opendev.org/677483 | 15:15 |
| prometheanfire | kk, if you want to wait for https://review.opendev.org/677479 you can | 15:15 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: Test websockify 0.9.0 https://review.opendev.org/677483 | 15:16 |
| efried | oh, is that going to run something tempestuous? | 15:16 |
| efried | I made --^ depend on it | 15:16 |
| sean-k-mooney | efried: i am going to loudly ignore that .... | 15:17 |
| sean-k-mooney | thats such a dad joke | 15:17 |
| prometheanfire | it does :D | 15:17 |
| efried | sean-k-mooney: non sequitur? Assume we're talking about aspiers's python-rather-than-bash thing now? | 15:17 |
| openstackgerrit | melanie witt proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.opendev.org/507486 | 15:18 |
| openstackgerrit | melanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook https://review.opendev.org/672840 | 15:18 |
| *** tbachman has joined #openstack-nova | 15:18 | |
| *** spatel has quit IRC | 15:18 | |
| sean-k-mooney | i assume the horrible pun between tempestuous and tempest was intentionally because if it wasnt that even worse some how | 15:19 |
| openstackgerrit | Merged openstack/nova master: Update api-ref for 2.75 to add config_drive in server update response https://review.opendev.org/677324 | 15:19 |
| prometheanfire | we do include a general tempest test in our test suite | 15:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1823370 https://review.opendev.org/650424 | 15:20 |
| openstack | bug 1823370 in OpenStack Compute (nova) "Evacuations are not restricted to the source cell during scheduling" [Medium,In progress] https://launchpad.net/bugs/1823370 - Assigned to Matt Riedemann (mriedem) | 15:20 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Restrict RequestSpec to cell when evacuating https://review.opendev.org/650429 | 15:20 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Use RequestSpec.requested_destination when rebuilding with new image https://review.opendev.org/650376 | 15:20 |
| sean-k-mooney | prometheanfire: did you have a patch that put all the constratis fixes into one by the way or were they just listed in the email | 15:21 |
| *** artom has joined #openstack-nova | 15:23 | |
| prometheanfire | no, generally the global-reqs nightly update will include it | 15:23 |
| prometheanfire | that's where I see it generally | 15:23 |
| sean-k-mooney | ok i might have been looking at an automated patch | 15:25 |
| *** ivve has quit IRC | 15:26 | |
| *** spatel has joined #openstack-nova | 15:28 | |
| *** spatel has quit IRC | 15:28 | |
| *** zhubx has quit IRC | 15:29 | |
| efried | stephenfin: Where was https://review.opendev.org/#/c/677444/1/doc/source/cli/nova-manage.rst rendering before? I don't see it anywhere in https://docs.openstack.org/nova/latest/cli/nova-manage.html | 15:31 |
| stephenfin | efried: https://review.opendev.org/#/c/677443/ | 15:31 |
| efried | o | 15:32 |
| stephenfin | I didn't want that patch to block the docs patch | 15:32 |
| stephenfin | plus the docs one might be worth backporting | 15:32 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: API microversion 2.76: Add 'power-update' external event https://review.opendev.org/666792 | 15:33 |
| efried | stephenfin: So the CLI remote_debug options... no longer work in that top patch? | 15:33 |
| stephenfin | efried: For nova-manage, nova-policy and nova-status, but they never actually worked there | 15:34 |
| stephenfin | Because there's no "service" to debug | 15:34 |
| efried | okay, that makes sense. So why bother documenting them in that middle patch? | 15:35 |
| efried | Or should we at least say "These don't work, don't try to use them"? | 15:35 |
| stephenfin | I wanted to be complete, but perhaps I should just drop them | 15:35 |
| stephenfin | Dropping them is probably the wiser option, actually | 15:35 |
| stephenfin | (never documenting them, that is) | 15:36 |
| efried | ++ | 15:37 |
| *** tbachman has quit IRC | 15:41 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document global options for nova-manage https://review.opendev.org/677443 | 15:42 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: config: Explicitly register 'remote_debug' CLI opts https://review.opendev.org/677444 | 15:42 |
| stephenfin | donezo | 15:43 |
| efried | stephenfin: we may have crossed in the mail, there was another comment on the middle one | 15:43 |
| stephenfin | efried: Hmm, there shouldn't be another '--version' parameter any more. I killed that | 15:44 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | 15:44 |
| stephenfin | looks like there's more cleanup to do \o/ | 15:45 |
| * stephenfin gets tea | 15:45 | |
| stephenfin | and red pen | 15:45 |
| *** gyee has joined #openstack-nova | 15:45 | |
| mriedem | mnaser: are you working around this in stein right now https://review.opendev.org/#/q/topic:bug/1839560+branch:stable/stein or is getting that in pretty critical for you? | 15:47 |
| stephenfin | sean-k-mooney: One easy follow-up on https://review.opendev.org/#/c/671338/ but it's +W'd | 15:48 |
| *** nweinber__ has joined #openstack-nova | 15:48 | |
| *** pvradu has quit IRC | 15:50 | |
| *** macz has joined #openstack-nova | 15:51 | |
| sean-k-mooney | ya i get a littel confused where that works and where it does not. e.g. does not in release notes but does in docs but not in someting else i tried | 15:51 |
| *** nweinber_ has quit IRC | 15:51 | |
| stephenfin | sean-k-mooney: Inside 'doc/source', it works. Everywhere else, it does not | 15:52 |
| stephenfin | That's because 'doc', 'releasenotes', 'api-ref' and 'api-guide' are all separate doc builds with their own indexes | 15:53 |
| sean-k-mooney | it was the api ref i think i tried to use it in | 15:54 |
| sean-k-mooney | ok so just docs | 15:54 |
| stephenfin | yeah, no go there | 15:54 |
| *** udesale has joined #openstack-nova | 16:00 | |
| *** maciejjozefczyk has quit IRC | 16:09 | |
| *** maciejjozefczyk has joined #openstack-nova | 16:14 | |
| *** tbachman has joined #openstack-nova | 16:16 | |
| *** rpittau is now known as rpittau|afk | 16:17 | |
| *** markvoelker has quit IRC | 16:17 | |
| *** maciejjozefczyk has quit IRC | 16:26 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document global options for nova-manage https://review.opendev.org/677443 | 16:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: config: Explicitly register 'remote_debug' CLI opts https://review.opendev.org/677444 | 16:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Correct 'nova-manage db sync' documentation https://review.opendev.org/677508 | 16:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: docs: Rewrite nova-manage docs to use proper directives https://review.opendev.org/677509 | 16:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Correct 'nova-manage db sync' documentation https://review.opendev.org/677508 | 16:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document global options for nova-manage https://review.opendev.org/677443 | 16:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: config: Explicitly register 'remote_debug' CLI opts https://review.opendev.org/677444 | 16:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: docs: Rewrite nova-manage docs to use proper directives https://review.opendev.org/677509 | 16:30 |
| *** owalsh_ has joined #openstack-nova | 16:32 | |
| *** markvoelker has joined #openstack-nova | 16:33 | |
| *** owalsh has quit IRC | 16:35 | |
| *** spsurya has quit IRC | 16:36 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: fakelibvirt: Stop distinguishing between NUMA, non-NUMA https://review.opendev.org/675570 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Rename 'nova.objects.instance_numa_topology' https://review.opendev.org/671789 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary try-catch around 'getCPUMap' https://review.opendev.org/671790 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary argument https://review.opendev.org/674396 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.opendev.org/537414 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: claims: Remove useless caching https://review.opendev.org/671791 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option https://review.opendev.org/671792 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rename exception argument https://review.opendev.org/671795 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance' https://review.opendev.org/671797 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host' https://review.opendev.org/671798 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance' https://review.opendev.org/671799 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Rework 'hardware.numa_usage_from_instances' https://review.opendev.org/672565 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Split NUMA object tests https://review.opendev.org/672336 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800 | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103 | 16:41 |
| sean-k-mooney | just on or two patches incoming is see | 16:42 |
| stephenfin | I put my own series into merge conflict | 16:42 |
| sean-k-mooney | nice | 16:42 |
| stephenfin | Must start annoying people to get the trivial patches that I've frontloaded merged | 16:42 |
| stephenfin | That's tomorrow's work though | 16:42 |
| *** ivve has joined #openstack-nova | 16:42 | |
| sean-k-mooney | stephenfin: thats the pcpu series | 16:43 |
| stephenfin | sean-k-mooney: Want to hit https://review.opendev.org/#/c/675570/ again (it was a trivial rebase due to commit 85ea4f703) | 16:43 |
| stephenfin | Yarp | 16:43 |
| openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: report storage bus traits https://review.opendev.org/666914 | 16:43 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: use domain capabilities to get supported device models https://review.opendev.org/666915 | 16:43 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775 | 16:43 |
| stephenfin | decision on upgrades still TBD | 16:43 |
| sean-k-mooney | sure ill take a look now | 16:44 |
| sean-k-mooney | ah you rebased it so too i see | 16:44 |
| stephenfin | Had to. I need that later in the series | 16:45 |
| sean-k-mooney | i would still like to murder cpu_nodes with fire at some point and rename it to numa_nodes... but ignoring that | 16:45 |
| sean-k-mooney | its look fine to me | 16:45 |
| stephenfin | Hmm, probably should have fixed that while I was at it | 16:45 |
| stephenfin | Oh well. Next time ¯\_(ツ)_/¯ | 16:45 |
| sean-k-mooney | its at the bottom of the serires so lets not | 16:46 |
| sean-k-mooney | we can fix it in a follow up patch | 16:46 |
| sean-k-mooney | eventually | 16:46 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite host aggregate, availability zone docs https://review.opendev.org/667133 | 16:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Scrub available quotas https://review.opendev.org/670125 | 16:52 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165 | 16:52 |
| *** owalsh_ is now known as owalsh | 16:55 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Trivial fixes to API version history https://review.opendev.org/649561 | 16:55 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add emulated TPM support to Nova https://review.opendev.org/631363 | 16:59 |
| *** derekh has quit IRC | 16:59 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rename exception argument https://review.opendev.org/671795 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance' https://review.opendev.org/671797 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host' https://review.opendev.org/671798 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance' https://review.opendev.org/671799 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Rework 'hardware.numa_usage_from_instances' https://review.opendev.org/672565 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Split NUMA object tests https://review.opendev.org/672336 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option https://review.opendev.org/671792 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hw:cpu_policy', 'hw:mem_page_size' extra specs from API samples https://review.opendev.org/675338 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Fold in argument to '_update_provider_tree_for_vgpu' https://review.opendev.org/676729 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | 17:02 |
| *** nweinber_ has joined #openstack-nova | 17:03 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | 17:04 |
| *** udesale has quit IRC | 17:04 | |
| *** nweinber__ has quit IRC | 17:06 | |
| *** gyee has quit IRC | 17:09 | |
| mnaser | mriedem: working around it by telling folks to not set baremetal machines into maintenance mode | 17:09 |
| *** tesseract has quit IRC | 17:10 | |
| sean-k-mooney | mnaser: does that not require you to use the iroic api and therefor have admin acess | 17:13 |
| sean-k-mooney | so what everyou your working aound i assume you can jsut tell the vxhost admins dont do that untill its fixed | 17:14 |
| mnaser | sean-k-mooney: yes exactly its more of an operator side workaround so its a lot easier than a user facing workaround | 17:14 |
| sean-k-mooney | mnaser: what the issue out of interest | 17:15 |
| mnaser | sean-k-mooney: setting a node to 'in maintenance' makes it not show up anymore in the api request to get active nodes from nova-compute so nova marks tyhe service as deleted | 17:15 |
| mnaser | but if you remove the flag, the node comes back up, and then it fails to be added to the db because there is already a record with the same uuid | 17:16 |
| sean-k-mooney | oh ok and are you getting duplicate errors when its marked as no longer in maintas in placemnet | 17:16 |
| sean-k-mooney | ya ok that makes sense | 17:16 |
| mnaser | yeah, this is because of a recent change where uuids now uses ironic uuid | 17:16 |
| sean-k-mooney | it also feel like that is pretty latent behavior | 17:16 |
| sean-k-mooney | recent as in rocky ish | 17:17 |
| mnaser | yes that was a recent addition | 17:17 |
| mnaser | https://review.opendev.org/#/c/571535/ rocky indeed | 17:17 |
| sean-k-mooney | ya i dont think we have many customer deployint that yet | 17:17 |
| sean-k-mooney | most are on queens | 17:17 |
| sean-k-mooney | well i lie most are proably on newton untill that is EOL in deceber then most will be on queens | 17:18 |
| *** ociuhandu has quit IRC | 17:18 | |
| *** gyee has joined #openstack-nova | 17:22 | |
| *** nweinber__ has joined #openstack-nova | 17:22 | |
| *** nweinber_ has quit IRC | 17:25 | |
| *** ralonsoh has quit IRC | 17:28 | |
| *** boxiang has joined #openstack-nova | 17:34 | |
| *** factor has joined #openstack-nova | 17:34 | |
| *** tesseract has joined #openstack-nova | 17:45 | |
| *** brinzhang_ has joined #openstack-nova | 17:47 | |
| *** igordc has joined #openstack-nova | 17:48 | |
| *** brinzhang has quit IRC | 17:50 | |
| openstackgerrit | Merged openstack/nova master: Add functional recreate test for bug 1823370 https://review.opendev.org/650424 | 18:06 |
| openstack | bug 1823370 in OpenStack Compute (nova) "Evacuations are not restricted to the source cell during scheduling" [Medium,In progress] https://launchpad.net/bugs/1823370 - Assigned to Matt Riedemann (mriedem) | 18:06 |
| *** maciejjozefczyk has joined #openstack-nova | 18:19 | |
| *** maciejjozefczyk has quit IRC | 18:28 | |
| *** jmlowe has quit IRC | 18:29 | |
| *** markvoelker has quit IRC | 18:34 | |
| *** factor has quit IRC | 18:40 | |
| *** jmlowe has joined #openstack-nova | 18:55 | |
| donnyd | mnaser: just ran into this issue this morning on FN | 19:06 |
| donnyd | A node didn't want to clean, was thrown into maintenance and then had to pull it from nova db to get it schedulable again | 19:08 |
| mnaser | yep | 19:11 |
| openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.75 - Multiple API cleanup changes https://review.opendev.org/676275 | 19:11 |
| *** brinzhang_ has quit IRC | 19:18 | |
| openstackgerrit | Merged openstack/python-novaclient master: API microversion 2.76: Add 'power-update' external event https://review.opendev.org/666792 | 19:28 |
| *** maciejjozefczyk has joined #openstack-nova | 19:48 | |
| *** mriedem has quit IRC | 19:50 | |
| *** bbowen__ has quit IRC | 19:51 | |
| *** mriedem has joined #openstack-nova | 19:54 | |
| mriedem | efried: i guess t-2 should be closed out in lp huh | 19:58 |
| mriedem | as of july 25 | 19:58 |
| mriedem | i closed out the bps for 2.75 and 2.76 | 20:00 |
| *** maciejjozefczyk has quit IRC | 20:03 | |
| *** ash2307 has joined #openstack-nova | 20:07 | |
| efried | mriedem: I don't know what you're saying. | 20:07 |
| mriedem | efried: the t-2 milestone in launchpad for nova is still open | 20:08 |
| mriedem | even though we're past the t-2 (fake-ish) milestone | 20:08 |
| mriedem | https://wiki.openstack.org/wiki/Nova/Train_Release_Schedule | 20:08 |
| mriedem | melwitt: https://review.opendev.org/#/c/672840/8 is busted - you remove the call to archive | 20:08 |
| mriedem | *removed | 20:08 |
| mriedem | i think my comment in PS4 caused the confusion, i just meant to remove the $conf passed to the bash function since we didn't need it anymore | 20:08 |
| efried | mriedem: I didn't know launchpad tracked "milestones". How do I look at that? | 20:09 |
| efried | (and, not to put too fine a point on it, but does anyone care?) | 20:09 |
| mriedem | https://launchpad.net/nova/+series | 20:10 |
| mriedem | efried: not really since the release team stopped doing milestone releases, | 20:10 |
| mriedem | we really only have them for internal tracking | 20:11 |
| efried | so... I can go into it and uncheck Active and that's it? | 20:11 |
| mriedem | i.e. t-2, nova-spec freeze | 20:11 |
| mriedem | in the past i've created a release | 20:11 |
| mriedem | which closes it out | 20:11 |
| melwitt | mriedem: argh, sorry. I saw the commands were in a function and then I promptly didn't realize that was the func call. will fix | 20:11 |
| mriedem | efried: i'm not sure if marking it as inactive just removes it from targeting for bugs and blueprints but still shows up in history | 20:12 |
| mriedem | since we don't create an actual release (we don't tag the repo), marking as not active is probably more correct | 20:12 |
| * efried tries | 20:12 | |
| efried | made it disappear from the little flow charty thingy. | 20:13 |
| *** markvoelker has joined #openstack-nova | 20:15 | |
| *** markvoelker has quit IRC | 20:16 | |
| *** markvoelker has joined #openstack-nova | 20:16 | |
| mriedem | i still see it here https://launchpad.net/nova/train | 20:17 |
| mriedem | but not marked active https://launchpad.net/nova/+milestone/train-2 | 20:17 |
| mriedem | which means, | 20:17 |
| mriedem | it doesn't show up as a milestone target either, which is what we want | 20:18 |
| mriedem | so we're good | 20:18 |
| *** boxiang has quit IRC | 20:21 | |
| *** zhubx has joined #openstack-nova | 20:21 | |
| *** zhubx has quit IRC | 20:22 | |
| efried | \o/ | 20:23 |
| *** factor has joined #openstack-nova | 20:26 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: objects: Rename 'nova.objects.instance_numa_topology' https://review.opendev.org/671789 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: libvirt: Remove unnecessary try-catch around 'getCPUMap' https://review.opendev.org/671790 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: libvirt: Remove unnecessary argument https://review.opendev.org/674396 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.opendev.org/537414 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: claims: Remove useless caching https://review.opendev.org/671791 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: trivial: Rename exception argument https://review.opendev.org/671795 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance' https://review.opendev.org/671797 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host' https://review.opendev.org/671798 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance' https://review.opendev.org/671799 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Rework 'hardware.numa_usage_from_instances' https://review.opendev.org/672565 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: tests: Split NUMA object tests https://review.opendev.org/672336 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option https://review.opendev.org/671792 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103 | 20:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571 | 20:38 |
| melwitt | mriedem: the archive command should go after 'set -e' too right? or no? | 20:38 |
| melwitt | oh, it shouldn't bc we expect it to return 1 several times | 20:39 |
| mriedem | melwitt: i think it can because the functions will only return a non-0 if they fail | 20:40 |
| *** eharney has quit IRC | 20:40 | |
| melwitt | mriedem: oh, I see. the function, not the individual commands. ok thanks | 20:41 |
| mriedem | that's one issue i've meant to cleanup in that script is if the archive or purge fails the script wouldn't actually fail and the job wouldnt' fail | 20:41 |
| melwitt | yeah, I see | 20:42 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Deprecate Aggregate[Core|Ram|Disk]Filters https://review.opendev.org/673496 | 20:42 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Deprecate Aggregate[Core|Ram|Disk]Filters https://review.opendev.org/673496 | 20:45 |
| mriedem | sean-k-mooney: stephenfin: i've addressed comments in ^ and am +2 now | 20:45 |
| openstackgerrit | melanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook https://review.opendev.org/672840 | 20:48 |
| *** bbowen__ has joined #openstack-nova | 20:51 | |
| mriedem | efried: looking at the grenade failures in https://review.opendev.org/#/c/676684/, it appears to be segfaults killing q-svc | 20:55 |
| mriedem | Aug 20 15:53:30 ubuntu-bionic-rax-dfw-0010301045 kernel: /usr/bin/python[21875]: segfault at a9 ip 000055aee57ec9e4 sp 00007ffed66329d8 error 4 in python2.7[55aee5716000+301000] | 20:55 |
| mriedem | which i've seen locally but not so much in the gate | 20:56 |
| efried | mriedem: segfault + switch-to-something-called-binary == suspicious | 20:56 |
| mriedem | but these jobs aren't even using postgresql | 20:56 |
| efried | I didn't go back and check the previous failures | 20:56 |
| efried | but it seemed like *all* the grenade jobs failed *every* patch set. | 20:57 |
| efried | (anecdotal ^ ) | 20:57 |
| mriedem | the pips are installed | 20:58 |
| mriedem | psycopg2==2.8.3 psycopg2-binary==2.8.3 | 20:58 |
| efried | Anyway, I have a definite -1 on the requirements-check problem. If the grenade thing turns out to be unrelated, great. | 20:58 |
| mriedem | the good news is there are hits in logstash | 20:58 |
| mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Unexpected%20exception%20in%20API%20method%3A%20ConnectFailure%3A%20Unable%20to%20establish%20connection%20to%5C%22%20AND%20message%3A%5C%22v2.0%2Fports%3Fdevice_id%5C%22%20AND%20message%3A%5C%22('Connection%20aborted.'%2C%20BadStatusLine('No%20status%20line%20received%20-%20the%20server%20has%20closed%20the%20connection'%2C))%5C%22%20AND%20tags | 20:58 |
| mriedem | 5C%22screen-n-api.txt%5C%22&from=7d | 20:58 |
| mriedem | the bad news is they are only on that one change | 20:58 |
| efried | is that bad news? | 20:58 |
| efried | It seems like it would be further evidence that the problem is *there*. | 20:58 |
| *** my_nd has joined #openstack-nova | 21:02 | |
| mriedem | well it's not good news | 21:02 |
| *** nweinber__ has quit IRC | 21:02 | |
| mriedem | i've seen this same thing in my devstack vms i've created lately b/c there is too much filling up a single 8gb ram/8vpu vm even after stripping the services to pretty bare bone | 21:03 |
| mriedem | clarkb has posted about it in the ML so it's a known issue | 21:03 |
| mriedem | but not many people working on it | 21:03 |
| efried | is it possible that the -binary thingy is just sucking up too much memory? | 21:05 |
| my_nd | hi there, is there a way to configure a compute node to use only some % of their available resources to host instances? | 21:07 |
| mriedem | my_nd: yes, you can configured reserved cpu, ram and disk for the host | 21:10 |
| mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.reserved_host_cpus | 21:10 |
| mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.reserved_host_disk_mb | 21:11 |
| mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.reserved_host_memory_mb | 21:11 |
| my_nd | thanks mriedem | 21:12 |
| mriedem | efried: postgresql shouldn't even be running | 21:13 |
| mriedem | i don't see it in https://a6b55b727208d469fce9-a76e08006e67cd388b33580b35bd0960.ssl.cf2.rackcdn.com/676684/7/check/nova-grenade-live-migration/8626716/logs/screen-peakmem_tracker.txt.gz anyway | 21:13 |
| mriedem | mysqld is in there | 21:13 |
| mriedem | unfortunately peakmemtracker seems to die before we start seeing segfaults | 21:16 |
| mriedem | top memory usage is unsurprisingly mysqld, neutron, and nova (api and compute) | 21:16 |
| efried | I can't make that logstash query work, because it split lines on me. Can you paste just the text from the query box? | 21:18 |
| mriedem | message:"Unexpected exception in API method: ConnectFailure: Unable to establish connection to" AND message:"v2.0/ports?device_id" AND message:"('Connection aborted.', BadStatusLine('No status line received - the server has closed the connection',))" AND tags:"screen-n-api.txt" | 21:18 |
| efried | or you can just tell me: are there hits from the earlier patch sets? | 21:18 |
| mriedem | 6 and 7 yes | 21:18 |
| efried | mm | 21:19 |
| mriedem | nothing really changed much since PS5 though... | 21:19 |
| efried | those are all from nova-grenade-live-migration. | 21:19 |
| efried | how did the other grenades fail? | 21:20 |
| *** xek has quit IRC | 21:20 | |
| *** markvoelker has quit IRC | 21:22 | |
| mriedem | similar, but in one case the grenade script calling neutron api directly rather than proxying through nova | 21:23 |
| mriedem | 2019-08-20 15:42:11.965 | + /opt/stack/new/grenade/projects/70_cinder/resources.sh:destroy:265 : openstack floating ip unset --port 172.24.5.75 2019-08-20 15:42:15.779 | Unable to establish connection to http://104.239.175.129:9696/v2.0/floatingips/172.24.5.75: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',)) | 21:23 |
| mriedem | Aug 20 15:42:15.153161 ubuntu-bionic-rax-iad-0010301032 neutron-server[11166]: INFO oslo_service.service [-] Child 24291 killed by signal 11 | 21:23 |
| mriedem | Aug 20 15:42:15 ubuntu-bionic-rax-iad-0010301032 kernel: /usr/bin/python[22305]: segfault at a9 ip 0000000000585794 sp 00007ffd8b90c5b8 error 4 in python3.6[400000+3bf000] | 21:24 |
| *** bnemec has quit IRC | 21:27 | |
| *** shilpasd has quit IRC | 21:29 | |
| *** tesseract has quit IRC | 21:32 | |
| efried | Is there a unifying logstash search to rule them all? | 21:32 |
| *** markvoelker has joined #openstack-nova | 21:35 | |
| efried | message:"Unable to establish connection to" AND tags:"screen-n-api.txt" | 21:35 |
| efried | with 7d | 21:35 |
| efried | gives me 64 hits on three different grenade jobs on both of those patches and no others | 21:35 |
| efried | (that one and its now-abandoned successor) | 21:36 |
| efried | That would be enough for me to say, "sorry, this -binary thing is no good". | 21:36 |
| *** markvoelker has quit IRC | 21:40 | |
| *** ivve has quit IRC | 21:42 | |
| mriedem | yeah there were hits on the now abandoned patch that was on top of the -binary one too | 21:47 |
| mriedem | super weird | 21:47 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete InstanceMapping in conductor if BuildRequest is already deleted https://review.opendev.org/666438 | 21:52 |
| *** my_nd has quit IRC | 21:56 | |
| mriedem | dansmith: would be nice to get this in https://review.opendev.org/#/c/673620/ so we can drop the service uuid online data migration in U | 21:57 |
| dansmith | mriedem: hmm, we've had other blocker migrations since havana that didn't get added to that special list | 21:59 |
| *** rcernin has joined #openstack-nova | 22:00 | |
| mriedem | i know, and they don't do anything | 22:00 |
| dansmith | why do you need to add yours there then? | 22:01 |
| mriedem | https://review.opendev.org/#/c/673620/1/nova/tests/unit/db/test_migrations.py@730 | 22:01 |
| mriedem | because it's cleaner? | 22:01 |
| mriedem | my guess is that skip list came after the older blocker migrations | 22:01 |
| dansmith | I don't think so, | 22:01 |
| dansmith | I think I added that a long time ago | 22:02 |
| *** trident has quit IRC | 22:02 | |
| mriedem | ok yeah https://review.opendev.org/#/c/122162/ vs https://review.opendev.org/#/c/174480/ | 22:03 |
| mriedem | but having said that, i'm not sure why it matters | 22:03 |
| mriedem | it's just making sure there is a method for the migration, but the method just passes so... | 22:03 |
| mriedem | the actual test is in another module | 22:03 |
| dansmith | well, it's more just the principle of the case where nothing should be added to those exclusion lists in the future, and I don't think you need to | 22:04 |
| mriedem | if you're +2 besides that will you fast approve if i make that change? | 22:04 |
| dansmith | yeah | 22:04 |
| dansmith | sorry | 22:05 |
| *** markvoelker has joined #openstack-nova | 22:10 | |
| mriedem | np, i have to rebase anyway | 22:10 |
| *** trident has joined #openstack-nova | 22:11 | |
| dansmith | mriedem: you meant soon right? :) | 22:14 |
| *** zbr has quit IRC | 22:14 | |
| *** markvoelker has quit IRC | 22:15 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add blocker migration for completing services.uuid migration https://review.opendev.org/673620 | 22:15 |
| mriedem | thar she blar | 22:15 |
| *** zbr has joined #openstack-nova | 22:16 | |
| dansmith | got it | 22:18 |
| *** markvoelker has joined #openstack-nova | 22:29 | |
| *** BjoernT has quit IRC | 22:46 | |
| *** markvoelker has quit IRC | 22:48 | |
| *** tkajinam has joined #openstack-nova | 22:55 | |
| mriedem | thanks | 23:04 |
| *** mriedem has quit IRC | 23:05 | |
| sean-k-mooney | mriedem: ack, thanks for updating the deprecation patch. i had planned to throw up a [WIP:U] patch to actully delete the thing in u but that is still future | 23:05 |
| sean-k-mooney | just missed him hehe | 23:05 |
| *** markvoelker has joined #openstack-nova | 23:12 | |
| *** zbr has quit IRC | 23:22 | |
| *** markvoelker has quit IRC | 23:22 | |
| *** zbr has joined #openstack-nova | 23:23 | |
| *** mlavalle has quit IRC | 23:29 | |
| *** takashin has joined #openstack-nova | 23:39 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Public method to retrieve custom resource providers https://review.opendev.org/676029 | 23:41 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP: Load the custom resource providers to resource tracker https://review.opendev.org/676522 | 23:41 |
| *** takashin has quit IRC | 23:42 | |
| *** takashin has joined #openstack-nova | 23:45 | |
| *** macz has quit IRC | 23:48 | |
| *** brinzhang has joined #openstack-nova | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!