Monday, 2019-08-19

« Sunday, 2019-08-18 Index Tuesday, 2019-08-20 »
*** rcernin has joined #openstack-nova00:02
*** BjoernT has joined #openstack-nova00:43
*** BjoernT has quit IRC00:49
*** prometheanfire has quit IRC00:52
*** prometheanfire has joined #openstack-nova00:56
*** spsurya has joined #openstack-nova01:09
*** ircuser-1 has joined #openstack-nova01:09
*** markvoelker has joined #openstack-nova01:20
*** markvoelker has quit IRC01:25
*** bhagyashris has joined #openstack-nova01:48
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix wrong assertions in unit tests  https://review.opendev.org/67710201:56
*** boxiang has joined #openstack-nova01:59
*** licanwei has joined #openstack-nova02:01
*** redrobot has quit IRC02:23
*** Guest90568 has joined #openstack-nova02:29
*** Guest90568 is now known as redrobot02:32
*** BjoernT has joined #openstack-nova02:45
*** brinzhang has joined #openstack-nova02:48
openstackgerritBoxiang Zhu proposed openstack/nova master: Preserve UEFI NVRAM variable store  https://review.opendev.org/62164603:00
openstackgerritya.wang proposed openstack/nova master: vCPU model selection  https://review.opendev.org/67029803:01
openstackgerritya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags  https://review.opendev.org/67029903:01
openstackgerritya.wang proposed openstack/nova master: Support report multi CPU model traits  https://review.opendev.org/67030003:01
*** ricolin has joined #openstack-nova03:10
*** boxiang has quit IRC03:12
*** boxiang has joined #openstack-nova03:13
*** takashin has quit IRC03:38
*** takashin has joined #openstack-nova03:38
*** ricolin has quit IRC03:44
*** dklyle has joined #openstack-nova03:46
*** dklyle has quit IRC03:52
*** boxiang has quit IRC04:02
*** boxiang has joined #openstack-nova04:02
*** ratailor has joined #openstack-nova04:14
*** jhesketh has quit IRC04:18
*** jhesketh has joined #openstack-nova04:19
*** udesale has joined #openstack-nova04:30
*** abhishekk has joined #openstack-nova04:33
*** BjoernT has quit IRC04:43
*** dpawlik has joined #openstack-nova05:00
*** trident has quit IRC05:06
*** bhagyashris has quit IRC05:09
*** ociuhandu has joined #openstack-nova05:15
*** ash2307 has left #openstack-nova05:15
*** trident has joined #openstack-nova05:15
*** ricolin has joined #openstack-nova05:16
*** trident has quit IRC05:21
*** markvoelker has joined #openstack-nova05:23
*** janki has joined #openstack-nova05:24
*** markvoelker has quit IRC05:27
*** trident has joined #openstack-nova05:27
*** ociuhandu has quit IRC05:36
openstackgerritBrin Zhang proposed openstack/nova master: Specify availability_zone to unshelve  https://review.opendev.org/66385105:36
*** yikun has quit IRC05:43
*** jaosorior has joined #openstack-nova05:51
*** cfriesen has joined #openstack-nova06:01
*** ociuhandu has joined #openstack-nova06:02
*** threestrands has quit IRC06:34
*** threestrands has joined #openstack-nova06:35
*** maciejjozefczyk has joined #openstack-nova06:36
*** damien_r has joined #openstack-nova06:47
*** ociuhandu has quit IRC06:53
*** ociuhandu has joined #openstack-nova07:00
*** cfriesen has quit IRC07:04
*** udesale has quit IRC07:05
*** udesale has joined #openstack-nova07:06
*** jaosorior has quit IRC07:14
*** ociuhandu has quit IRC07:16
*** rcernin has quit IRC07:17
*** threestrands has quit IRC07:19
*** dpawlik has quit IRC07:34
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix 'has_calls' method calls in unit tests  https://review.opendev.org/67653607:34
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix wrong assertions in unit tests  https://review.opendev.org/67710207:34
*** rpittau|afk is now known as rpittau07:35
*** takamatsu has joined #openstack-nova07:37
*** udesale has quit IRC07:43
*** udesale has joined #openstack-nova07:44
*** ivve has joined #openstack-nova07:45
openstackgerritVieri proposed openstack/nova-specs master: Add Python 3 Train unit tests  https://review.opendev.org/67590807:51
*** jaosorior has joined #openstack-nova08:05
*** trident has quit IRC08:11
*** xek has joined #openstack-nova08:12
*** tkajinam has quit IRC08:18
*** trident has joined #openstack-nova08:19
openstackgerritGhanshyam Mann proposed openstack/python-novaclient master: Microversion 2.75 - Multiple API cleanup changes  https://review.opendev.org/67627508:22
*** adriant has quit IRC08:29
*** adriant has joined #openstack-nova08:31
*** derekh has joined #openstack-nova08:34
*** ociuhandu has joined #openstack-nova08:37
*** ociuhandu has quit IRC08:41
*** mdbooth has joined #openstack-nova09:00
*** dpawlik has joined #openstack-nova09:03
*** bhagyashris has joined #openstack-nova09:17
openstackgerritTakashi NATSUME proposed openstack/nova master: Tests: autospecs all the mock.patch usages  https://review.opendev.org/47077509:17
*** janki has quit IRC09:17
*** markvoelker has joined #openstack-nova09:35
*** takashin has left #openstack-nova09:35
aspierso/09:36
aspiersanyone around?09:36
aspiersI just had an idea09:36
aspiersCould write a script a bit like tools/flake8wrap.sh -HEAD, but specifically for running tests09:37
aspiersActually, I could just write a Guardfile09:38
aspiersCan't quite believe I didn't think of that before09:38
aspiersAh, Python has watchdog09:39
*** markvoelker has quit IRC09:40
bhagyashrisstephenfin: Hi, I saw you have send mail on mailing list #link http://lists.openstack.org/pipermail/openstack-discuss/2019-August/008501.html ... So what will be the exact plan for upgrade ... actually I was working on functional test part10:08
stephenfinbhagyashris: I'm still trying to decide10:09
stephenfinBut I _think_ I'm going to go with the global config option10:09
stephenfinSomething like 'pcpus_in_placement' that will default to False in Train and True in U10:10
stephenfinThat'll be set on both the compute node and controller10:10
stephenfinOnce you've upgraded everything to Train, you'll toggle the config option on the controller, followed by the config options on the compute node10:11
bhagyashrisOkay and then that will translate the flavor extra specs at controller node and will report the PCPU inventory at placement side .... Right?10:13
stephenfinonce toggled, yes10:13
stephenfinand do the reshape10:13
stephenfinUntil it's toggled though, the compute nodes will not report PCPUs, the extra specs will not be translated, and the reshape will not occur10:14
*** ociuhandu has joined #openstack-nova10:15
bhagyashrisAnd if the global config option set is false that means not toggle and user defines the cpu_dedicated_set then in that case what will happen?10:18
stephenfinWe error out10:18
bhagyashrisstephenfin: means 'pcpus_in_placement' and the cpu config options should be set properly by operator10:19
stephenfinWell, by the deployment tool they're using10:20
stephenfinActuallly10:20
stephenfinWe don't necessarily need to set 'pcpus_in_placement'10:20
stephenfin...on the compute nodes10:20
*** ociuhandu has quit IRC10:20
stephenfinWe could just say "set 'pcpus_in_placement'" on the controller, and then set 'cpu_dedicated_set' and 'cpu_shared_set' on the compute nodes10:21
stephenfinHowever, fwiw, I wouldn't worry about this too much right now. I assume you're still testing things out? This should only affect upgrades and nothing else10:22
bhagyashrisYeah actually I was fixing the review comments that you have given patch https://review.opendev.org/#/c/674895/ and also added the functional test case for upgrade ... but looking at the recent patch set you have added the functional test ... so that makes the duplications of efforts10:24
stephenfinYeah, I've reworked the reshape to address one of my comments. I don't know how much sense the new approach makes. I know mriedem has some comments left that I need to address10:26
bhagyashrisstephenfin: and from above discussion it seems that upgrade will need some changes10:26
*** abhishekk has quit IRC10:26
bhagyashrisstephenfin: okay ..10:27
bhagyashrisstephenfin: I just have one question from above discussion you said that "set 'pcpus_in_placement'" on the controller, and then set 'cpu_dedicated_set' and 'cpu_shared_set' on the compute nodes and We don't necessarily need to set 'pcpus_in_placement' on compute node10:28
stephenfinyup?10:29
bhagyashrisSo in that case if the 'pcpus_in_placement' = false at controller node and at co mute if I define the cpu_dedicated_set then this will report the PCPU as inventory at placement10:29
bhagyashrisAnd the instance request will ask for VCPU in that case10:30
bhagyashrisRight?10:30
bhagyashrisThen that looks like issue then10:30
stephenfinYeah, and that's an issue. I was thinking we'd check to see if PCPUs were reported by any compute node and error out if so10:30
stephenfinI haven't thought through it properly yet though10:30
bhagyashrisstephenfin: okay10:31
stephenfinThere's one other thing I can do, which is add a check on the compute node to see if I'm requesting PCPUs (either directly or through 'hw:cpu_policy' and just hard fail if so. That would involve making a request to placement to get allocations though and I'm not sure we can do that.10:32
stephenfinAs you can see, this is very much in flux at the moment :(10:32
*** ralonsoh has joined #openstack-nova10:37
bhagyashrisstephenfin: yeah,10:37
bhagyashrisif any idea will comes to my mind I will let you know10:45
*** elod is now known as elod_off10:47
*** bhagyashris has quit IRC10:50
*** dave-mccowan has joined #openstack-nova11:07
openstackgerritAndreas Jaeger proposed openstack/nova stable/rocky: Remove experimental job on openSUSE 42.3  https://review.opendev.org/67717611:11
openstackgerritAndreas Jaeger proposed openstack/nova stable/queens: Remove experimental job on openSUSE 42.3  https://review.opendev.org/67717711:12
openstackgerritAndreas Jaeger proposed openstack/nova stable/pike: Remove experimental job on openSUSE 42.3  https://review.opendev.org/67717811:14
*** udesale has quit IRC11:15
*** tesseract has joined #openstack-nova11:15
alex_xustephenfin: I replied your email, but not sure I understand the problem fully11:15
openstackgerritBrin Zhang proposed openstack/nova master: Specify availability_zone to unshelve  https://review.opendev.org/66385111:16
*** tbachman has quit IRC11:16
openstackgerritAdam Spiers proposed openstack/nova master: Make it easier to run a selection of tests relevant to ongoing work  https://review.opendev.org/67718011:26
aspiersstephenfin, alex_xu: happy Monday ;-) ^^^^11:26
openstackgerritAdam Spiers proposed openstack/nova master: Make it easier to run a selection of tests relevant to ongoing work  https://review.opendev.org/67718011:29
*** boxiang has quit IRC11:32
*** zhubx has joined #openstack-nova11:32
*** markvoelker has joined #openstack-nova11:36
*** markvoelker has quit IRC11:41
openstackgerritAdam Spiers proposed openstack/nova master: Switch some GitHub URLs to point to opendev.org  https://review.opendev.org/67718511:50
*** janki has joined #openstack-nova11:50
*** markvoelker has joined #openstack-nova11:57
*** shilpasd has joined #openstack-nova11:59
*** weshay_pto is now known as weshay12:00
*** ociuhandu has joined #openstack-nova12:07
*** ociuhandu has quit IRC12:11
*** dviroel_ has joined #openstack-nova12:12
*** jaosorior has quit IRC12:14
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix wrong assertions in unit tests  https://review.opendev.org/67710212:21
yonglihestephenfin: Hi, good morning.12:23
openstackgerritTakashi NATSUME proposed openstack/nova master: Tests: autospecs all the mock.patch usages  https://review.opendev.org/47077512:27
*** tbachman_ has joined #openstack-nova12:31
sean-k-mooneyyonglihe: i have not seen stephenfin online yet today12:37
*** nweinber has joined #openstack-nova12:38
sean-k-mooneyhe proably is around but im guessing he is still catching up on email/gerrit after the weekend12:38
*** jaosorior has joined #openstack-nova12:38
stephenfinno, I'm here12:42
stephenfin(sean-k-mooney: See discussion with bhagyashris from earlier :))12:42
sean-k-mooneystephenfin: ah ok sorry12:42
sean-k-mooneyyep i missed that12:43
*** spsurya has quit IRC12:43
stephenfinyonglihe: Those patches are on my list, but there's a big queue of stuff ahead of them. I'll get to it eventually :)12:44
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Microversion 2.77: Support Specifying AZ to unshelve  https://review.opendev.org/66513612:47
sean-k-mooneystephenfin: did you reach any decision with the path forward for PCPU upgrades12:49
*** mriedem has joined #openstack-nova12:57
*** ratailor has quit IRC13:00
stephenfinsean-k-mooney: I'm still on the fence, tbh13:01
sean-k-mooneyi think the global + 3 cycle process will be the safest13:01
stephenfinI'm leaning towards the global config option still, but we're going to need some way to ensure people don't toggle it on the compute node first13:01
sean-k-mooneyya13:01
sean-k-mooneyi think our best way to prevent that is to work with the intaller project to support enabling it13:03
stephenfinI think so too13:03
stephenfinBut I've no idea how to fix things if people do it wrong13:03
stephenfinWe're kind of handing people a loaded gun here13:03
sean-k-mooneye.g how to rever a reshape13:03
sean-k-mooneyya it is. its not the only one we have given people in the past13:04
stephenfinPretty much13:04
stephenfinOr how to keep reshaping13:04
sean-k-mooneyhave we talked to the OSA,kolla or triplo folk about it yet?13:05
sean-k-mooneyi know we plan to go over the triplo stuff internally with our deployment folks but did any of the install project comment on your ml post13:06
stephenfinefried: I've started discussing it with TripleO guys, of course13:06
stephenfinBut not OSA or Kolla. I don't think Kolla supported pinned CPUs as a rule atm13:06
*** eharney has joined #openstack-nova13:07
stephenfinI recall being in a call where there was talk of it at a previous summit but I don't know how much further it went13:07
stephenfinefried: I've noticed that there are many more gaps in test coverage with that privsep series. Are you okay with a giant follow-up to close said gaps?13:09
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442013:09
stephenfinCos I'll have to recuse myself from reviews if I go add said missing tests to each patch13:10
stephenfinunless you're happy to single +2 the tests, that is13:10
efriedstephenfin: I have no doubt there are gaps in test coverage overall, but what bugs me is the coverage being reduced by each patch. Is that what you're talking about?13:10
aspiersstephenfin: responses to your feedback there ^^^13:10
stephenfinefried: Yeah, that specifically13:10
stephenfini.e. missing tests in nova/tests/unit/privsep13:11
stephenfinaspiers: sweet13:11
efriedIn that case, yes, a fup is good for me, but I'll want to wait to merge a given patch until its coverage is at least proposed.13:11
aspiersstephenfin: but you might find more enjoyment in https://review.opendev.org/#/c/677180/13:11
efriedand yes, good plan wrt reviews, since it's tough to convince other cores to care about that series, we should take advantage of the two of us being willing to dig into it :P13:12
aspiersefried: you too :)13:12
aspiersmy dream is never having to *manually* run tests locally again13:12
aspiersjust edit files and watch things turn red or green13:12
aspiersit's entirely doable13:13
aspiersI've done it with many other projects13:13
stephenfinefried: Yeah, of course. Maybe just keep an eye out for gaps as you're reviewing so I've something to hit "Done" on13:13
efriedwfm13:14
efriedaspiers, stephenfin: Love this idea, add it to the list of workflow improvements it's hard to get people to pay attention to: https://review.opendev.org/#/c/673356/13:15
aspiersefried: personally I *never* tire of workflow improvements13:16
aspiersyou can always count me in for reviewing those13:16
efriedaspiers: what's mybranch^! ?13:18
aspiersthe commit at the tip of mybranch13:18
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: Exclude build request marker from server listing  https://review.opendev.org/67720113:18
aspiersefried: https://git-scm.com/docs/git-rev-parse#_other_rev_parent_shorthand_notations13:19
stephenfinWell it's not a workflow improvement, but this would save us some time https://review.opendev.org/#/c/470775/13:19
stephenfin(make mock fail if you call a mocked function incorrectly or a function that doesn't exist)13:19
*** janki has quit IRC13:20
stephenfinand it's been around in one form or another for...2 years, 2 months and 17 days :'D13:20
efriedyeah, I thought claudiub had been working on this for ages and was never able to get it quiiite right.13:21
efriedis it right now?13:21
efriedI guess you think so according to your +2 :)13:21
stephenfinIt all looks sane and I'm relying on CI to catch anything we might have missed13:21
stephenfinso...yes.13:21
* efried adds self, waits for zuul13:22
efriedaspiers: So foo^! is like foo~1..foo ?13:22
efriedI admit, I learned like two of the weird shorthands and then cordoned off the rest of my brain for other things.13:24
efried80/20 rule13:25
*** beekneemech is now known as bnemec13:26
sean-k-mooneywoudl foo~1..foo not be git show13:27
sean-k-mooneye.g. compare ing n-1 to n13:27
sean-k-mooneywhich is the diff of n or what git show displays13:27
efriedif you're using it for a diff, yes13:27
sean-k-mooneyok13:27
sean-k-mooneyjust makeing sure13:28
sean-k-mooneythe ~1 thing always confused me13:28
*** spatel has joined #openstack-nova13:28
sean-k-mooneyi only ever use it if im doing "git reset --hard HEAD~1"13:29
*** dklyle has joined #openstack-nova13:29
sean-k-mooneyto remove the top commit form my branch when i commit to master by mistake13:29
*** ociuhandu has joined #openstack-nova13:30
*** spatel has quit IRC13:33
efriedwhen I commit to master by mistake, I do something like:13:33
efriedgit branch -m oops13:33
efriedgit checkout -b master origin/master13:33
*** ociuhandu has quit IRC13:34
stephenfinSomewhat related https://github.blog/2019-08-16-highlights-from-git-2-23/13:35
stephenfin(git 2.23 adds experimental 'git restore' and 'git switch' commands that each do a bit of what 'git checkout' is doing currently)13:36
*** shilpasd has quit IRC13:40
mriedemgibi: answered your question about multi-cell migration reschedule https://review.opendev.org/#/c/635668/4113:47
yonglihestephenfin: Thanks, its stressful.13:47
mriedemgibi: tl;dr yes it's a todo, i just didn't do it yet since i wanted to get the main flow written, tested and reviewed first13:47
gregworkwhat kind of access does a tenant need to create private flavors within their tenant13:52
*** BjoernT has joined #openstack-nova13:52
gregworkgetting ERROR: You are not authorized to use resource_types: OS::Nova::Flavor when deploying a stack in this tenant as _member_... I also get this error as ResellerAdmin and Creator13:54
gregworkthe "admin" role appears to transform the tenant into a cloud operator able to see and modify all other tenants so this is not useful13:55
*** ociuhandu has joined #openstack-nova13:58
*** cfriesen has joined #openstack-nova14:02
*** ociuhandu has quit IRC14:03
openstackgerritStephen Finucane proposed openstack/nova master: Address nits from privsep series  https://review.opendev.org/67721014:03
stephenfinefried: ^14:03
* stephenfin offline for ~45 minutes14:03
efriedack14:05
*** ociuhandu has joined #openstack-nova14:11
*** jdillaman has joined #openstack-nova14:13
mriedemgibi: now that there has been more review on the cross-cell-resize series, i'm thinking about moving https://review.opendev.org/#/c/642590/ and https://review.opendev.org/#/c/642183/ and https://review.opendev.org/#/c/637605/ to the front of the series to get those merged out of the way (next time i do a rebase) - any problems with that?14:17
*** spatel has joined #openstack-nova14:18
mriedemdansmith: this is a pretty simple +2d bottom of the cross-cell series which is the prep_resize equivalent and would help move a few things https://review.opendev.org/#/c/633293/ - it's basically just a call to the dest compute to do a resize_claim for pci/numa and send back the migration context14:20
*** dpawlik has quit IRC14:20
*** tbachman_ has quit IRC14:21
*** KeithMnemonic has joined #openstack-nova14:25
dansmithmriedem: okay14:25
*** eharney_ has joined #openstack-nova14:25
*** eharney has quit IRC14:26
dansmithmriedem: is this not something we should be doing all the time to make numa lm easier?14:26
dansmithbecause they're kinda stuffing the claim into other calls right now14:27
mriedemmeaning the numa lm series is doing the move claim as part of pre_live_migrate_at_dest or whatever, right?14:28
dansmithyeah,14:28
mriedemand same-cell resize/cold migrate does it in prep_resize14:28
dansmithI had just read the commit message when I said ^ but it struck an immediate chord with me14:29
dansmiththat we're going to have three ways for the three types, AFAICT14:29
*** artom has quit IRC14:29
mriedemi would need to refresh on the live migration claim to know if it's needing to use migrate data from the source or anything14:30
dansmithit does14:30
efriedaspiers: Didn't you write a mock_open wrapper?14:30
aspiersI did14:30
aspierspatch_open and patch_exists14:30
mriedemprep_resize for same-cell is quite a bit different from the cross-cell one since it's a cast, does reschedule logic, and then casts to the resize_instance method on the source14:30
mriedemso i'm not sure that trying to munge those into a single method to work for all is going to be better14:31
mriedemfeels like the rebuild/evacuate trap to me14:31
aspiersefried: and yes, foo^! is foo^..foo14:31
sean-k-mooneyaspiers: how do you determin all test that need to be run for a change14:31
efriedaspiers: found it14:31
sean-k-mooneyreliable that is14:31
efriedsean-k-mooney: he's not mapping source changes to tests.14:31
aspierssean-k-mooney: I don't yet, but you would need to hardcode those mappings14:31
efriedsean-k-mooney: he's just running test files you changed in the commits14:32
aspierswhich is exactly what you can do with a Guardfile14:32
mriedemefried: so no tests no failures yay!14:32
sean-k-mooneyok that14:32
efriedaspiers: I was thinking you could get partway by mapping nova/a/b/c.py to nova/tests/{unit|functional}/a/b/test_c.py14:32
aspiershell, that's the kind of thing people used to do with Makefiles, in the olden days before actually useful dependency trees went out of fashion and all the modern bullshit came in14:32
sean-k-mooneywill likely miss relevent tests then14:32
efriedand then hardcode anything that doesn't hit with that.14:32
aspiersefried: yes for sure14:33
mriedemefried: note that lots of the modules aren't 1:1 like that14:33
sean-k-mooneyi really dont like the idea of hardcoding any mappings14:33
efriedmriedem: Yes, I get that, I'm saying that would get you a big chunk for free, and then you hardcode the rest.14:33
mriedemgross14:33
efriedbut that's not the point of this patch at all.14:34
mriedemit's just auto-run the test module changes in my commit, i know14:34
efriedthis patch just runs "tests I changed in XXX commit(s)"14:34
aspierssean-k-mooney: the entire CI test suite is "relevant" in a sense. The point of locally rapidly running a small subset of tests every time you make a local code change is not to be complete, it's to catch the 80% of stupid mistakes and make sure the tests you *are* changing on are correct14:34
mriedemthis is proposed as totally optional yes?14:34
mriedemmeaning i never have to deal with this?14:34
aspiersyes14:34
sean-k-mooneyya i get that but generally i jsut use the regex support for that14:35
mriedemsame,14:35
mriedemtox -e py36 -- test_compute14:35
aspierssean-k-mooney: but then you have to maintain lists of regexes. the point is to save you the hassle for quick obvious stuff14:35
sean-k-mooneye.g. tox -e py36 -- "libvirt|compute"14:35
sean-k-mooneyaspiers: no you just add words that relate to the thing your doing when you type it14:35
aspiersright, except that will take like 20-30s longer because a) it goes through tox and b) it does test discovery14:36
sean-k-mooneyif i change ovo i add objecst if i modify the libvirt dirver i add libvirt14:36
aspierssean-k-mooney: sure but that's a different use case14:36
aspiersI'm not proposing to replace any existing workflows, just add the option of a quick and easy extra one14:36
sean-k-mooneyright but if i want to run just one test it add teh test name or use an ide.14:36
aspiersit's already saved me a bunch of typing this morning since I wrote it14:37
sean-k-mooneyanyway it nice to have a script for the new stuff14:37
sean-k-mooneyjust i dont want it to imply that it will run all the relevent tests14:37
sean-k-mooneyaspiers: its good for saving time locally as long as it does not encurage people to waste gate time but not running the test they should have locally14:39
openstackgerritAdam Spiers proposed openstack/nova master: Switch some GitHub URLs to point to opendev.org  https://review.opendev.org/67718514:40
*** damien_r has quit IRC14:40
aspierssean-k-mooney: I'm not sure how providing another way to run tests locally would discourage people from running tests locally ;-)14:40
*** damien_r has joined #openstack-nova14:40
sean-k-mooneyaspiers: if that is all they run they will miss test they should have run14:41
aspierstools are never gonna be able to stop developers from being stupid14:41
sean-k-mooneyyes but it can make it easier for them to be :)14:41
aspierssure but at some point you just have to trust people to use their brain14:41
aspiersand this is not rocket science14:41
aspiersnoone is saying "OK now we have this new tool and that is the ONLY tool you should eer use"14:42
aspiersever14:42
sean-k-mooneyi know but even with the regex approch its rare but sometime if i dont do a full tox run i will miss a test that the gate finds14:42
*** markvoelker has quit IRC14:42
aspiersI'd also argue that developer time is more expensive than gate time, but that's a whole other debate14:43
openstackgerritEric Fried proposed openstack/nova master: Tests: autospecs all the mock.patch usages  https://review.opendev.org/47077514:43
aspiersyeah, so use your regex approach14:43
aspiersor, use my new approach while you are in the middle of coding because it's quicker, then use yours when you think you are done and ready to upload14:43
aspiersdoing both gets the best of both worlds14:43
aspiersthis is just basic 80/20 rule application14:44
efriedaspiers: this bud's for you https://review.opendev.org/#/c/470775/42/nova/tests/unit/test_json_ref.py@5814:44
*** BjoernT_ has joined #openstack-nova14:45
sean-k-mooneyya i get that. i like fast8 for example but that is always correct.14:45
aspiersefried: you mean you want me to submit a separate fixup later?14:46
aspierssean-k-mooney: running a single test is always correct, it's not just complete :)14:46
aspiersthis is no different to fast814:46
aspiersfast8 is not complete either14:46
efriedaspiers: "want"... it's a suggestion I thought might interest you :)14:46
mriedemsean-k-mooney: a few more small things in the pmu change https://review.opendev.org/#/c/671338/1114:46
aspiersefried: indeed, it will make me happy to see others using it :)14:46
*** BjoernT has quit IRC14:47
sean-k-mooneymriedem: ya i just got the email for your ps8 comments14:47
sean-k-mooneyill look at them now14:47
sean-k-mooneyare you ok with me moveing the bool_form_strng as i have in the latest version?14:48
*** mlavalle has joined #openstack-nova14:48
sean-k-mooneyassuming i add the new tests you suggested14:49
efriedmriedem: I think you were complaining about how long it takes to build specs at some point, and since you're clearly so enthusiastic about this kind of workflow improvement: https://review.opendev.org/#/c/673356/14:50
mriedemcomplain yes, but not so much to want to review a bash script :)14:51
sean-k-mooneyefried: the specs are not too bad. recently started building releasenotes locally for some of my patches and was suprised at how long those take.14:52
dansmithmriedem: I dropped some comments on the bottom two patches, but I'm still mulling  my feelings about it, but am out of time before my next call14:52
dansmithmriedem: it really seems like an unfortunate purpose-built call to do part of the work of the other two for a specific situation, which just feels wrong and very fragile14:53
dansmithI know it's more work to refactor, and I don't really want to review *that* either14:53
dansmithso I dunno14:53
mriedemto refactor prep_resize?14:57
dansmithwell, all of them to do this as a single thing14:57
dansmithI dunno, I'll try to think on it when I'm done with my next call14:58
mriedemi think that would be gross in other ways14:58
mriedemack14:58
dansmiththis just seems like piling on another copy of a bunch of existing logic14:58
*** markvoelker has joined #openstack-nova15:03
*** macz has joined #openstack-nova15:03
*** jaosorior has quit IRC15:04
fricklermriedem: I'm cleaning up old patches and found https://bugs.launchpad.net/nova/+bug/1815082 , is that just forgotten or has it been resolved?15:05
openstackLaunchpad bug 1815082 in OpenStack Compute (nova) ""DBNonExistentTable: (sqlite3.OperationalError) no such table: services" when starting nova-metadata under uwsgi" [Medium,In progress] - Assigned to Matt Riedemann (mriedem)15:05
mriedemit has not been resolved15:06
mriedemdansmith: well the whole cross-cell series was also agreed to be separate from trying to munge it into existing compute manager code for sanity15:07
sean-k-mooneyefried: comments in https://review.opendev.org/#/c/673356/115:07
mriedemi've refactored and made common the obvious stuff along the way like the notification bits15:07
mriedemfrickler: i ran out of steam trying to debug it15:10
*** artom has joined #openstack-nova15:14
*** brinzhang has quit IRC15:15
*** brinzhang has joined #openstack-nova15:16
*** brinzhang has quit IRC15:16
*** eharney_ is now known as eharney15:20
*** factor has quit IRC15:32
*** factor has joined #openstack-nova15:32
*** ivve has quit IRC15:33
mriedemefried: i can +2 now if sean is ok with a FUP or +2 after you address his comments, either way https://review.opendev.org/#/c/673356/15:35
*** ociuhandu has quit IRC15:37
openstackgerritEric Fried proposed openstack/nova-specs master: tox -e fast-specs  https://review.opendev.org/67335615:37
efriedsean-k-mooney, mriedem: Addressed some of the comments, but mostly for the sake of compromise.15:38
efriedshit15:38
openstackgerritEric Fried proposed openstack/nova-specs master: tox -e fast-specs  https://review.opendev.org/67335615:38
*** gyee has joined #openstack-nova15:38
*** damien_r has quit IRC15:38
fricklermriedem: np, I'll keep it on my list, then. I've reduced my list of open patches to less than a screenful already with a bit of headroom even, that's enough for my summer cleanup ;)15:39
*** factor has quit IRC15:40
*** factor has joined #openstack-nova15:41
*** ociuhandu has joined #openstack-nova15:51
efriedmriedem: o hey mon, got a sec to help me with logstash?15:53
mriedemyes15:53
efriedmriedem: I was trying to logstash that kombu thing. I should be able to search for15:54
efriedmessage:"TypeError: open: path should be string, bytes or os.PathLike, not _NormalAccessor"15:54
efriedright??15:54
mriedemgot a link to a log with the failure?15:55
efriedhttps://zuul.opendev.org/t/openstack/build/369bc38f57134ece8befdf4f3d6d670e15:55
efriedmriedem: note that it's in tox-py37 (always), not sure if that's significant15:57
mriedemsince the console log is huge is it failing to publish logs to elasticsearch15:57
mriedem?15:57
mriedemhttps://review.opendev.org/#/c/673356/115:58
mriedemoops15:58
mriedem222.4M15:58
efriedso you mean, elasticsearch is only good if something blows up in a small way?15:59
mriedemi wonder why job-output is not compressed15:59
mriedemi don't see subsequent ansible task failures for compressing and publishing logs though15:59
efriedswift cutover something something15:59
mriedemthe b' is screwing with your query16:00
efriedthat's going to be prevalent in py3* logs, tho16:01
mriedemyes i know16:01
efriedAnd I'm not including the b'' in my search16:01
efriedshould I be?16:01
mriedemand it's always been a problem16:01
efriedo16:01
mriedemso i'm using:16:01
mriedemmessage:"b'TypeError: open: path should be string, bytes or os.PathLike, not _NormalAccessor'" AND tags:"console"16:01
mriedembut that's not showing hits either,16:02
efriedI got hits16:02
efried(this got resolved over the weekend, so you have to spread to last week)16:02
mriedemi'm goign to 7 days16:02
mriedemare you sure those are real hits? kibana has this weird thing where the first query results are always garbage16:03
mriedemand i have to hit the magnifying glass thing to re-query16:03
efriedweird, I'm getting lots of hits with that sea... oh, 'and' is case-sensitive16:03
efriedso yeah, I'm getting nothing.16:03
mriedemthen we need to talk to clarkb16:03
*** rpittau is now known as rpittau|afk16:07
*** icarusfactor has joined #openstack-nova16:07
*** factor has quit IRC16:09
openstackgerritShilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter  https://review.opendev.org/67107216:10
openstackgerritShilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata  https://review.opendev.org/67107416:11
openstackgerritShilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates  https://review.opendev.org/67107516:12
openstackgerritShilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates  https://review.opendev.org/66795216:13
*** igordc has joined #openstack-nova16:18
*** tesseract has quit IRC16:35
openstackgerritAdam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection  https://review.opendev.org/63633416:37
openstackgerritAdam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py  https://review.opendev.org/63631816:37
openstackgerritAdam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required  https://review.opendev.org/64456516:37
openstackgerritEric Fried proposed openstack/nova-specs master: tox -e fast-specs  https://review.opendev.org/67335616:37
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442016:41
openstackgerritAdam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection  https://review.opendev.org/63633416:42
openstackgerritAdam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py  https://review.opendev.org/63631816:42
openstackgerritAdam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required  https://review.opendev.org/64456516:42
openstackgerritAdam Spiers proposed openstack/nova master: Make it easier to run a selection of tests relevant to ongoing work  https://review.opendev.org/67718016:48
openstackgerritsean mooney proposed openstack/nova master: Libvirt: add support for vPMU configuration.  https://review.opendev.org/67133816:54
sean-k-mooneymriedem: ^ should address your vpmu nits. im going to grab something to eat quickly but if you see anything else leave a comment and ill fix it in an hour or so16:55
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661616:55
efriedmriedem: are you in favor of gating requirements on py37 using cross-nova? https://review.opendev.org/#/c/677071/517:01
efriedBasically (IMO) we need *some* reasonable py37 coverage in there, and nova seemed as good as any.17:01
*** derekh has quit IRC17:03
mriedemgmann: comments in your novaclient 2.75 change https://review.opendev.org/#/c/676275/17:06
mriedemis openstack-py37 voting on nova changes?17:07
mriedemlooks like yes17:07
mriedemhttps://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/zuul.d/jobs.yaml#L16617:08
mriedemso yeah +117:09
efriedthanks mriedem17:09
*** mdbooth_ has joined #openstack-nova17:13
openstackgerritMatt Riedemann proposed openstack/nova master: doc: cleanup 2.75 REST API microversion history doc  https://review.opendev.org/67725917:13
*** mdbooth has quit IRC17:16
*** ociuhandu_ has joined #openstack-nova17:16
*** ralonsoh has quit IRC17:16
*** ociuhandu has quit IRC17:19
*** ociuhandu_ has quit IRC17:21
*** ociuhandu has joined #openstack-nova17:24
*** mdbooth_ has quit IRC17:27
*** ociuhandu has quit IRC17:29
openstackgerritAkihiro Motoki proposed openstack/nova master: PDF documentation build  https://review.opendev.org/67673017:29
*** ricolin has quit IRC17:31
openstackgerritAdam Spiers proposed openstack/nova-specs master: Allow deep-linking to memory reservation section of AMD SEV spec  https://review.opendev.org/67726417:38
*** icarusfactor has quit IRC17:53
aspierserr, why is there no direct link from https://docs.openstack.org/nova/latest/ to https://docs.openstack.org/nova/latest/user/ ?18:01
efriedaspiers: fix it!18:04
*** spatel has quit IRC18:07
aspiersefried: I was wondering if it was deliberate18:07
aspiers"Todo18:08
aspiersThe rest of this document should probably move to the admin guide."18:08
aspiersThe top-level page directly links to some of the stuff under doc/source/user/18:08
efriedI can't imagine why the nova doc landing page wouldn't have a link to the user landing page anyway.18:09
aspiersIt does seem odd18:09
aspiersbut I find the whole doc organisation pretty confusing18:09
efriedagree18:10
efriedAt some point donnyd was on a mission to reorganize, perhaps y'all could meet minds18:10
aspierswhen I've got this damn SEV series done18:11
aspiersI'm pretty close now, just addressing your feedback on the tip of the series and then my backlog is clear I think18:11
aspiersthat is, until the next flood of -1s come in ;-)18:11
aspiersefried: now I'm longing for tox -e fast-docs ...18:14
openstackgerritMatt Riedemann proposed openstack/nova master: api-ref: add config_drive to 2.75 rebuild response parameters  https://review.opendev.org/67726718:15
efriedmriedem: Does this https://review.opendev.org/675908 smell like a stat mining / ATC grab exercise to you?18:17
mriedemyou mean just b/c it's nova-specs?18:18
efriedand because it's pointless, and because they put a co-author without any evidence of that person having co-authored anything, and because there's really nothing to co-author18:21
efriedbasically this patch now has three contributors18:21
efriedTempting to say, "you want a free summit ticket, go get it from somebody else's project"18:21
donnydefried: Still on that mission, but its hard to even get a start18:21
efriedI hear ya.18:22
donnydI am starting in docs with cyborg atm18:23
*** mtreinish has joined #openstack-nova18:29
*** ociuhandu has joined #openstack-nova18:48
mriedemefried: yeah... https://review.opendev.org/#/c/675908/3..4//COMMIT_MSG18:49
mriedemi know "Add Python 3 Train unit tests" is a Train cycle goal - i don't really know what it is, but i know it's a goal18:50
mriedemhttps://review.opendev.org/#/q/owner:%22Filippo+Inzaghi%22+status:open18:51
efriedyeah, I was okay with it at that point18:51
efriedBut when Vieri, a notorious silent +1er, uploaded a new PS that added not him/her, but 98k, another notorious silent +1er, as co-author, my spidey sense went nuts.18:52
*** ociuhandu has quit IRC18:53
efrieddustinc: Are you busily debugging the ironic CI failure in patch #3 at this point?19:00
openstackgerritMatt Riedemann proposed openstack/nova master: doc: cleanup 2.75 REST API microversion history doc  https://review.opendev.org/67725919:01
openstackgerritMatt Riedemann proposed openstack/nova master: api-ref: add config_drive to 2.75 rebuild response parameters  https://review.opendev.org/67726719:01
sean-k-mooneyefried: well give we dont run the in repo test in the nova-specs gate i dont think https://review.opendev.org/#/c/675908/4 is relly useful19:01
efriedagree, it would be just for consistency with other projects, but I really don't think it's worthwhile.19:02
mriedemefried: welcome to my world of being annoyed with random changes like this that just look like stat padding19:02
mriedemand then my annoyance with people that are like, "what's the harm?! let them have their fun."19:03
efriedI don't mind stat padding if the change has *some* utility. But this one... doesn't.19:03
efriedmriedem: btw, I made this for you https://review.opendev.org/#/c/674678/19:05
efriedcmon man, I need to pad my stats19:06
sean-k-mooneyalso nova-specs does not actully have any python deliverables. so personally i would rather remvoe the setup.cfg ectra that came form teh template to make it claer this is just a repo of text files and the tools needed to manage it. but i also dont really feel like writing a patch to do that or wasing your time reviewing it19:06
sean-k-mooneyi.e. rather then saying i support py37 and such. but thats just me19:07
efriedcmon sean-k-mooney, you need the stats19:08
efriedokay, enough of that joke19:08
*** ivve has joined #openstack-nova19:09
sean-k-mooneyi -1'd it that will bump them enough19:09
dustincefried: actually was working on the providers stuff19:13
dustincproviders.yaml19:13
efriedokay. Not trying to pressure you one way or another. Just lmk if you want help on that.19:13
*** tbachman has joined #openstack-nova19:15
dustincthanks, I probably need help on everything but just focusing on one thing at a time :)19:16
*** factor has joined #openstack-nova19:22
*** eharney has quit IRC19:26
*** mriedem has quit IRC19:29
*** mriedem has joined #openstack-nova19:30
openstackgerritmelanie witt proposed openstack/nova master: Re-use DB MetaData during archive_deleted_rows  https://review.opendev.org/67521819:33
openstackgerritmelanie witt proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware  https://review.opendev.org/50748619:33
openstackgerritmelanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook  https://review.opendev.org/67284019:33
openstackgerritmelanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook  https://review.opendev.org/67284019:35
*** icarusfactor has joined #openstack-nova19:44
*** factor has quit IRC19:46
openstackgerritAdam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported  https://review.opendev.org/63868020:03
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442020:03
openstackgerritAdam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection  https://review.opendev.org/63633420:03
openstackgerritAdam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py  https://review.opendev.org/63631820:03
openstackgerritAdam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required  https://review.opendev.org/64456520:03
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661620:03
openstackgerritAdam Spiers proposed openstack/nova master: Switch some GitHub URLs to point to opendev.org  https://review.opendev.org/67718520:08
*** eharney has joined #openstack-nova20:14
aspiersefried: all outstanding feedback on the SEV series has now been addressed, or at least replied to with a "not sure what to do next" kind of comment20:18
efriedaspiers: ack. I think at this point I need to let the other reviewers get satisfied before I jump back in, right?20:19
efriedcause I was mostly +2?20:19
efriedon the ones I could grok20:19
aspiersefried: mostly, but I just addressed a whole bunch of your feedback on the final patch20:19
aspiersefried: and actually there's a request for info from you on that: https://review.opendev.org/#/c/666616/23/nova/tests/unit/virt/libvirt/test_driver.py@2355520:20
aspiersI guess I must have missed some magic when implementing my decorators in order to make them work on classes20:20
efriedmm20:21
aspiersactually, now I think about it, it's kind of obvious that my patch_* code would not successfully patch classes20:22
efriedokay, well, it's going to take a significant context switch to get back in there, but I'll get there eventually.20:22
aspierswell, unless Python has some magic which automatically applies decorators on a class to the methods within that class20:22
aspiersbut I suspect it doesn't20:23
efriedno, I suspect that's magic in mock's decorators20:32
sean-k-mooneyaspiers: well that depends on the decorator20:33
aspiersefried: yes I suspect so too20:34
*** mmethot has quit IRC20:47
*** mmethot has joined #openstack-nova20:47
openstackgerritMerged openstack/nova master: Fix 'has_calls' method calls in unit tests  https://review.opendev.org/67653620:50
openstackgerritMerged openstack/nova master: Fix wrong assertions in unit tests  https://review.opendev.org/67710220:50
*** maciejjozefczyk has quit IRC21:03
openstackgerritMerged openstack/nova-specs master: Allow deep-linking to memory reservation section of AMD SEV spec  https://review.opendev.org/67726421:07
*** DinaBelova has quit IRC21:09
*** DinaBelova has joined #openstack-nova21:10
*** eharney has quit IRC21:18
*** xek has quit IRC21:21
*** mdbooth has joined #openstack-nova21:26
*** markvoelker has quit IRC21:36
*** BjoernT_ has quit IRC21:36
*** oomichi_ has joined #openstack-nova21:40
openstackgerritMerged openstack/nova master: Tests: autospecs all the mock.patch usages  https://review.opendev.org/47077521:44
*** mdbooth has quit IRC21:45
*** oomichi_ has quit IRC21:49
*** mdbooth has joined #openstack-nova21:50
mriedemefried: so with https://review.opendev.org/#/c/674678/ we shouldn't see the warnings about things like cinder and barbican, right?22:00
efriedmriedem: that's correct.22:01
efriedI thought I checked it; are you still seeing those?22:01
efriedyeah, looks clean https://zuul.opendev.org/t/openstack/build/6d2b6e55df8949ad9ff19ac305de8b3e/log/logs/screen-n-cpu.txt.gz?severity=322:02
mriedemno, but i expected to see them in the functional job console log in the patch before that one in the series and don't see them either22:02
efriedvs https://logs.opendev.org/57/666857/6/check/nova-live-migration/a379339/logs/screen-n-cpu.txt.gz#_Aug_01_21_21_25_51795722:02
efriedI don't think you would see them in console log22:02
efriedOnly in compute log22:02
efriedbecause that's the only place we're asking for a placement client from22:03
efrieduhm, I guess from scheduler as well22:03
efriedbut yeah, wouldn't expect to see them in console log22:03
*** trident has quit IRC22:03
mriedemi'd seen those in functional test runs i thought, but yeah i do see them in here https://storage.bhs1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/logs_07/676707/1/check/tempest-integrated-compute/cafd458/controller/logs/screen-n-cpu.txt.gz22:03
mriedemEncountered an exception attempting to process config for project 'cinder' (service type 'block-storage'): no such option valid_interfaces in group [cinder]: oslo_config.cfg.NoSuchOptError: no such option valid_interfaces in group [cinder]22:03
efriedyup, that's the one.22:04
mriedembut not https://c8d945454956429a3061-cc9346598d5bf68c66bcb59fd4223863.ssl.cf1.rackcdn.com/674678/4/check/tempest-integrated-compute/c72e0e2/controller/logs/screen-n-cpu.txt.gz22:04
mriedemok +222:05
efriedthanks mriedem22:05
efriedchipping away at this sdk thing slowly but surely.22:05
mriedemgot sidetracked spending time writing a script to cleanup old e-r queries which i'd always just done manually before22:06
*** trident has joined #openstack-nova22:11
*** mriedem has quit IRC22:12
*** mlavalle has quit IRC22:20
*** dave-mccowan has quit IRC22:22
*** dave-mccowan has joined #openstack-nova22:25
*** dave-mccowan has quit IRC22:32
*** ivve has quit IRC22:34
*** mdbooth has quit IRC22:49
*** KeithMnemonic has quit IRC22:49
*** rcernin has joined #openstack-nova22:57
*** macz has quit IRC23:02
*** macz has joined #openstack-nova23:03
*** macz has quit IRC23:07
*** KeithMnemonic has joined #openstack-nova23:14
*** tkajinam has joined #openstack-nova23:27
openstackgerritsean mooney proposed openstack/nova master: Libvirt: report storage bus traits  https://review.opendev.org/66691423:29
*** takashin has joined #openstack-nova23:36
openstackgerritMerged openstack/nova master: doc: cleanup 2.75 REST API microversion history doc  https://review.opendev.org/67725923:37
openstackgerritMerged openstack/nova master: Fix use of mock.patch with new_callable=PropertyMock  https://review.opendev.org/67673823:38
openstackgerritMerged openstack/nova master: api-ref: add config_drive to 2.75 rebuild response parameters  https://review.opendev.org/67726723:38
*** markvoelker has joined #openstack-nova23:48
« Sunday, 2019-08-18 Index Tuesday, 2019-08-20 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!