Wednesday, 2019-07-24

« Tuesday, 2019-07-23 Index Thursday, 2019-07-25 »
*** brinzhang has joined #openstack-nova00:03
*** brinzhang_ has quit IRC00:06
*** adriant has joined #openstack-nova00:09
*** _hemna has joined #openstack-nova00:15
*** bbowen has quit IRC00:19
*** bbowen has joined #openstack-nova00:19
*** gyee has quit IRC00:31
*** tetsuro has joined #openstack-nova00:40
*** kodama_ has left #openstack-nova00:47
*** mlavalle has quit IRC00:57
*** ricolin has joined #openstack-nova00:59
*** igordc has quit IRC01:04
*** _hemna has quit IRC01:14
*** eharney has quit IRC01:15
*** imacdonn has quit IRC01:18
*** imacdonn has joined #openstack-nova01:18
*** mkrai_ has joined #openstack-nova01:19
*** hongbin has joined #openstack-nova01:29
*** hongbin_ has joined #openstack-nova01:32
*** hongbin has quit IRC01:33
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove test_pre_live_migration_instance_has_no_fixed_ip  https://review.opendev.org/67094801:43
*** _erlon_ has quit IRC02:05
*** hongbin_ has quit IRC02:06
*** brinzhang_ has joined #openstack-nova02:08
*** brinzhang has quit IRC02:12
*** tbachman has quit IRC02:15
*** zzzeek has quit IRC02:16
*** stakeda has joined #openstack-nova02:17
*** zzzeek has joined #openstack-nova02:19
*** hongbin has joined #openstack-nova02:23
*** tetsuro has quit IRC02:29
*** dklyle has quit IRC02:34
*** david-lyle has joined #openstack-nova02:35
*** tkajinam_ has joined #openstack-nova02:57
*** tkajinam has quit IRC02:59
*** tetsuro has joined #openstack-nova03:01
*** tetsuro_ has joined #openstack-nova03:06
*** tkajinam__ has joined #openstack-nova03:07
*** tetsuro has quit IRC03:08
*** tkajinam_ has quit IRC03:09
openstackgerritZhouHeng proposed openstack/nova-specs master: Support set port vnic type to create server  https://review.opendev.org/67240003:09
*** tetsuro_ has quit IRC03:11
openstackgerritZhouHeng proposed openstack/nova-specs master: Support set port vnic type to create server  https://review.opendev.org/67240003:26
openstackgerritMerged openstack/nova master: Use the safe get_binding_profile  https://review.opendev.org/66981703:27
*** psachin has joined #openstack-nova03:31
*** hongbin has quit IRC03:33
*** abhishekk has joined #openstack-nova03:34
*** hongbin has joined #openstack-nova03:47
*** whoami-rajat has joined #openstack-nova03:52
*** udesale has joined #openstack-nova03:54
openstackgerritMerged openstack/nova master: xvp: Start using consoleauth tokens  https://review.opendev.org/65296703:57
openstackgerritMerged openstack/nova master: xvp: Remove use of '_LI' marker  https://review.opendev.org/66542503:57
*** sapd1_x has joined #openstack-nova03:57
*** igordc has joined #openstack-nova03:58
*** igordc has quit IRC04:01
openstackgerritAlex Xu proposed openstack/nova master: Add the virt driver interface for claim and unclaim the devices  https://review.opendev.org/67078204:04
openstackgerritAlex Xu proposed openstack/nova master: Moves the allocation retrieving early  https://review.opendev.org/67078304:04
openstackgerritAlex Xu proposed openstack/nova master: Calling the virt driver's claim/unclaim_for_instance in resource tracker  https://review.opendev.org/67078404:04
openstackgerritAlex Xu proposed openstack/nova master: Add DeviceManager to the libvirt virt driver  https://review.opendev.org/67138804:04
openstackgerritAlex Xu proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager  https://review.opendev.org/67078704:04
openstackgerritAlex Xu proposed openstack/nova master: Using the claim/unclaim_for_instance for mdevs  https://review.opendev.org/67122204:04
openstackgerritAlex Xu proposed openstack/nova master: Adds functional test for creating the instance with vgpus  https://review.opendev.org/67139804:04
*** hongbin has quit IRC04:06
*** etp has joined #openstack-nova04:07
*** sapd1_x has quit IRC04:07
*** pcaruana has joined #openstack-nova04:27
*** tetsuro has joined #openstack-nova04:35
*** brault has joined #openstack-nova04:36
*** brault has quit IRC04:37
*** jaypipes has joined #openstack-nova04:49
*** Luzi has joined #openstack-nova04:55
*** tetsuro has quit IRC04:58
*** vishwanathj has joined #openstack-nova04:59
*** pcaruana has quit IRC05:12
*** jangutter has quit IRC05:18
*** boxiang has joined #openstack-nova05:25
*** pcaruana has joined #openstack-nova05:25
openstackgerritAlex Xu proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager  https://review.opendev.org/67078705:31
openstackgerritAlex Xu proposed openstack/nova master: Using the claim/unclaim_for_instance for mdevs  https://review.opendev.org/67122205:31
openstackgerritAlex Xu proposed openstack/nova master: Adds functional test for creating the instance with vgpus  https://review.opendev.org/67139805:31
*** vishwanathj has quit IRC05:55
*** vishwanathj has joined #openstack-nova06:11
*** vishwanathj has quit IRC06:17
*** maciejjozefczyk has joined #openstack-nova06:21
*** zhouyao has joined #openstack-nova06:26
*** tetsuro has joined #openstack-nova06:28
*** jawad_axd has joined #openstack-nova06:33
*** takashin has left #openstack-nova06:43
*** brinzhang has joined #openstack-nova06:48
openstackgerritBrin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot  https://review.opendev.org/58033606:50
*** tetsuro has quit IRC06:54
openstackgerritBrin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api  https://review.opendev.org/61294906:59
*** bhagyashris_ has joined #openstack-nova07:02
*** rcernin has quit IRC07:04
*** tesseract has joined #openstack-nova07:05
*** dpawlik has joined #openstack-nova07:07
*** slaweq has joined #openstack-nova07:11
*** _hemna has joined #openstack-nova07:12
*** _hemna has quit IRC07:16
*** jangutter has joined #openstack-nova07:19
*** jangutter has quit IRC07:23
*** ttsiouts has joined #openstack-nova07:25
*** zhouyao has quit IRC07:26
*** rpittau|afk is now known as rpittau07:27
*** brault has joined #openstack-nova07:30
*** brault has quit IRC07:30
openstackgerritYumengBao proposed openstack/nova master: add cyborg tempest job  https://review.opendev.org/67099907:31
*** tssurya has joined #openstack-nova07:39
kashyapaspiers: Morning07:41
kashyap"Previously get_domain_capabilities() in nova.virt.libvirt.host.Host assumed that 'q35' would be an acceptable fallback default for any architecture if no default machine type was hardcoded in nova"07:42
kashyapsean-k-mooney: aspiers: Whoops, totally missed to notice that first time around07:42
*** ttsiouts has quit IRC07:43
*** ttsiouts has joined #openstack-nova07:44
boxiangmake evacuation respects anti-affinity rule https://review.opendev.org/#/c/649963/07:46
boxiangfix live migration break group policy simultaneously https://review.opendev.org/#/c/651969/07:46
boxiang^ there are two patches need someone review07:47
boxiangthanks07:47
*** ttsiouts has quit IRC07:48
*** ralonsoh has joined #openstack-nova07:53
*** belmoreira has joined #openstack-nova07:59
*** threestrands has joined #openstack-nova08:02
*** shilpasd has joined #openstack-nova08:07
*** tkajinam__ has quit IRC08:18
*** ttsiouts has joined #openstack-nova08:18
*** priteau has joined #openstack-nova08:19
*** elod has quit IRC08:19
openstackgerritZhouHeng proposed openstack/nova-specs master: Support set port vnic type to create server  https://review.opendev.org/67240008:28
*** tetsuro has joined #openstack-nova08:30
openstackgerritMartin Midolesov proposed openstack/nova master: Implementing graceful shutdown.  https://review.opendev.org/66624508:33
*** belmoreira has quit IRC08:34
*** elod2 has joined #openstack-nova08:35
tetsurohi08:36
*** tetsuro has quit IRC08:42
*** priteau has quit IRC08:43
*** priteau has joined #openstack-nova08:44
*** priteau has quit IRC08:44
aspierskashyap: yeah, that was totally my bad, but true you should have noticed me being an idiot at the time ;-)08:45
kashyapaspiers: No, not at all.  You did much of the donkey work.  I am just adding a note in the review08:45
*** altlogbot_1 has quit IRC08:51
*** irclogbot_1 has quit IRC08:51
*** altlogbot_1 has joined #openstack-nova08:52
*** irclogbot_1 has joined #openstack-nova08:53
*** shilpasd has quit IRC08:53
*** belmoreira has joined #openstack-nova09:06
*** lpetrut has joined #openstack-nova09:07
*** awalende has joined #openstack-nova09:10
*** derekh has joined #openstack-nova09:13
openstackgerritAlex Xu proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager  https://review.opendev.org/67078709:14
openstackgerritAlex Xu proposed openstack/nova master: Adds functional test for creating the instance with vgpus  https://review.opendev.org/67139809:14
*** jangutter has joined #openstack-nova09:16
openstackgerritAdam Spiers proposed openstack/nova master: libvirt: harden Host.get_domain_capabilities()  https://review.opendev.org/67018909:16
*** ccamacho has joined #openstack-nova09:20
*** ttsiouts has quit IRC09:21
*** ttsiouts has joined #openstack-nova09:22
kashyapaspiers: Oops, I was commenting on PS-509:23
openstackgerritAlex Xu proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager  https://review.opendev.org/67078709:26
openstackgerritAlex Xu proposed openstack/nova master: Using the claim/unclaim_for_instance for mdevs  https://review.opendev.org/67122209:26
openstackgerritAlex Xu proposed openstack/nova master: Adds functional test for creating the instance with vgpus  https://review.opendev.org/67139809:26
*** ttsiouts has quit IRC09:27
*** cdent has joined #openstack-nova09:27
aspierskashyap: PS6 is just a pep8 fix09:30
kashyapAh, okay09:30
aspiersPS7 will address your feedback, and PS8 will rebase09:31
kashyapNod; thank you09:31
*** priteau has joined #openstack-nova09:32
kashyapaspiers: How did you guys "suddenly" discover this?09:32
*** ttsiouts has joined #openstack-nova09:32
kashyapMy guess is sean-k-mooney or you were probably using the Nova wrapper functions and came across it...09:32
alex_xucdent: good morning09:32
cdenthi alex_xu09:33
aspierskashyap: sean-k-mooney noticed it broke his qemu emulators for other archs09:33
aspiersthe ones which noone uses ;-)09:34
alex_xucdent: so I have question about vmware driver. since I found we need a way to distinguish the src node claim and dest node claim when we do the same host resizing, so I add flavor to the claim/unclaim interface also https://review.opendev.org/#/c/670782/5/nova/virt/driver.py@1082. So I can distinguish the claim by instance_uuid + flavor.id09:34
alex_xucdent: but I found the vmware driver is the only driver supports same host cold migration, for the cold migration, it means the flavor is same.09:35
kashyapaspiers: Hehe09:35
cdentalex_xu: yeah09:35
kashyapalex_xu: Can you also take a look at this one? -- https://review.opendev.org/#/c/67018909:35
alex_xucdent: so want to hear your opionion on this. since vmware driver can supports same host cold migraiton, so whether it has a way to distinguish the claim by itself09:36
alex_xu or this interface doesn't work for you09:36
kashyapaspiers: We should get this merged in Train.  Should we file a bug to track?09:36
alex_xukashyap: got it09:36
aspierskashyap: it will probably merge later today with your +109:36
kashyapalex_xu: Thank you.  It's a bit important to not break other architectures.09:36
kashyapaspiers: Excellent09:36
aspierskashyap: since implicit +1 from me and sean09:37
kashyaps/a bit//09:37
alex_xucdent: not need to answer for now, you can comment on the patch when you get a chance09:37
cdentalex_xu: good question. I can't really answer it off the top of my head so will need to do a bit of poking around, but my initial thought is that within the driver it's not really same host, it's simply same nova-compute. under the covers it is probably changing esxi host09:38
cdentbut yeah, will look more closely at the code and see if it can be workable, and will leave some comments09:38
aspierskashyap: I'm just going to copy your qemu/libvirt defaults note in verbatim - I think it's useful09:39
kashyapaspiers: Sure, go for it09:39
alex_xucdent: yea, thanks!09:39
*** boxiang has quit IRC09:42
cdentalex_xu: I'm trying to think of a situation where you'd want to do a same size flavor cold migration: resize with different size to the same host would make sense as something you want to trigger externally. But if you need/want a migration within the same cluster to something that is the same size, the DRS might do that.09:42
*** eandersson has quit IRC09:42
cdentI'll have to inquire with some internal colleagues. The alignment between how vsphere and nova think is not perfect...09:43
openstackgerritAdam Spiers proposed openstack/nova master: libvirt: harden Host.get_domain_capabilities()  https://review.opendev.org/67018909:43
openstackgerritAdam Spiers proposed openstack/nova master: libvirt: harden Host.get_domain_capabilities()  https://review.opendev.org/67018909:43
aspierskashyap: ^^^09:43
* kashyap clicks09:44
alex_xucdent: yea, that is special for vsphere. for other driver, the cold migration with same host probably just a stop and a start, that doesn't make sense09:44
aspierskashyap: you'll want to diff PS5 against 709:45
kashyapRight, will do09:45
*** lpetrut has quit IRC09:47
kashyapaspiers: And, nice work on the commit message.  I see you've expanded from PS-1 (noticing from a diff of PS-1 to PS-5)09:49
aspiersyep09:50
aspiersIt took me a while to grok, so I wanted to save others the effort09:50
kashyapYes, it lays it all out.  Thanks for taking time09:51
kashyapsean-k-mooney: aspiers: One thing, though: In the test,     def test_get_domain_capabilities_other_archs(self):09:52
kashyapWhy aren't AArch64, s390x et al aren't included in the 'archs' dictionary?09:53
aspiersbecause they're not covered by fakelibvirt getCapabilities09:54
*** arxcruz is now known as arxcruz|brb09:54
kashyapAh, right.  (As I prefixed, I was still looking at the full test data)09:54
kashyapProbably worth mentioning as a note in the test?  It's optional, only if you are respinning09:55
aspiersI don't have anything else to respin09:55
aspiersbut I can add it09:55
bhagyashris_stephenfin: Hi Thank you for review all my patches! I have some questions regarding some review comments.09:57
bhagyashris_stephenfin: Regarding comment on https://review.opendev.org/#/c/672221/1/nova/objects/instance_numa_topology.py  , Yeah  I agree we are not going to support both PCPU and VCPU resource allocation for single instance and that I have handle at both api and scheduler side by adding the check https://review.opendev.org/#/c/672222/1/nova/virt/hardware.py@1437  and  https://review.opendev.org/#/c/672223/1/nova/scheduler/request_fil09:57
bhagyashris_ter.py@21509:57
openstackgerritAdam Spiers proposed openstack/nova master: libvirt: harden Host.get_domain_capabilities()  https://review.opendev.org/67018909:58
*** jaosorior has joined #openstack-nova09:59
*** etp has quit IRC09:59
*** etp has joined #openstack-nova09:59
kashyapaspiers: Thank you10:00
stephenfinbhagyashris_: Okay. If that's the case, why do we need to add a pcpuset field? Can't we just use cpuset for both?10:02
stephenfinLike we've been doing for the host NUMATopology object for a while now10:02
*** luksky123 has joined #openstack-nova10:02
stephenfinFor forever10:02
*** jovial[m] has quit IRC10:04
*** trident has quit IRC10:06
*** ganso has quit IRC10:06
*** ganso has joined #openstack-nova10:07
*** trident has joined #openstack-nova10:08
*** threestrands has quit IRC10:08
*** lpetrut has joined #openstack-nova10:09
*** ttsiouts has quit IRC10:09
bhagyashris_stephenfin:  as our future plan is to support both the PCPU and VCPU resources so that time we will anyways will required the pcpuset field so making this change now will be anyways used in the future10:09
*** ttsiouts has joined #openstack-nova10:10
*** brinzhang has quit IRC10:10
stephenfinHmm, it just feels like putting the cart ahead of the horse. I need to figure out if it adds much complexity or not10:10
bhagyashris_stephenfin: ok, waiting for your inputs then... :)10:12
*** ttsiouts has quit IRC10:14
*** tbachman has joined #openstack-nova10:18
*** boxiang has joined #openstack-nova10:18
bhagyashris_stephenfin:  I have one more question about the comment you have given on  patch https://review.opendev.org/#/c/672222/110:19
bhagyashris_stephenfin:  As you are not sure about allowing the new syntax to request PCPU or VCPU resources using the flavor extra specs ‘resources:VCPU’ so then what is the plan because I saw in the specs https://review.opendev.org/#/c/555081/28/specs/train/approved/cpu-resources.rst@242 that we are going to allow this syntax so I consider this point and implemented the spec10:19
*** purplerbot has quit IRC10:19
*** tbachman has quit IRC10:19
*** purplerbot has joined #openstack-nova10:20
*** tbachman has joined #openstack-nova10:20
*** abhishekk has quit IRC10:24
bhagyashris_stephenfin: ^10:29
*** dpawlik has quit IRC10:39
openstackgerritAdam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported  https://review.opendev.org/63868010:45
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442010:45
openstackgerritAdam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection  https://review.opendev.org/63633410:45
openstackgerritAdam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py  https://review.opendev.org/63631810:45
openstackgerritAdam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required  https://review.opendev.org/64456510:45
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661610:45
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661610:45
openstackgerritdzogchen proposed openstack/nova master: Nova: node should be deleted when nova-compute is removed  https://review.opendev.org/67173110:46
bhagyashris_stephenfin: and also what is the plan I mean still 'cpuset' will be used incase of [compute] cpu_dedicated_set is define ?10:51
bhagyashris_stephenfin: Actually I am working in the JST zone so here almost 8 PM so I am leaving office so plz give me your opinion whenever you will get time I will check it by tomorrow.10:53
*** bhagyashris_ has quit IRC10:55
*** ttsiouts has joined #openstack-nova10:59
openstackgerritAdam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported  https://review.opendev.org/63868011:00
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442011:00
openstackgerritAdam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection  https://review.opendev.org/63633411:00
openstackgerritAdam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py  https://review.opendev.org/63631811:00
openstackgerritAdam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required  https://review.opendev.org/64456511:00
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661611:00
openstackgerritdzogchen proposed openstack/nova master: Nova: node should be deleted when nova-compute is removed  https://review.opendev.org/67173111:05
*** tbachman has joined #openstack-nova11:06
openstackgerritAdam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests  https://review.opendev.org/66255611:07
openstackgerritAdam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests  https://review.opendev.org/66255611:08
*** dpawlik has joined #openstack-nova11:08
*** boxiang has quit IRC11:10
*** boxiang has joined #openstack-nova11:11
*** udesale has quit IRC11:15
*** cdent has quit IRC11:16
*** cdent has joined #openstack-nova11:27
aspiersefried: in *theory* SEV is now code complete ... for at least the next few minutes until you find another flaw ;-)11:29
aspiersefried: I am now going to do some more testing on real hardware11:30
aspiersif that goes well, I have to backport to Rocky :-O11:30
cdentalex_xu: if you're still around, do you have a pointer to an example of how the flavor will be used during the resize activity we discussed above?11:32
aspiersefried: and after an internal deadline on this stuff, maybe I can get back to some more generic nova hacking :)11:32
cdentwhat I mean is how the claim distinguishing needs to happen11:32
*** irclogbot_1 has quit IRC11:33
*** belmoreira has quit IRC11:34
*** irclogbot_0 has joined #openstack-nova11:35
*** shilpasd has joined #openstack-nova11:36
kashyapcoreycb: Hi, on this -- https://bugs.launchpad.net/ubuntu/+source/edk2/+bug/183685911:42
openstackLaunchpad bug 1836859 in edk2 (Ubuntu) "RFE: Ship the firmware "descriptor files" as part of the 'ovmf' package" [Undecided,New]11:42
kashyapcoreycb: Christian Ehrhardt said he'll ping 'dannf', whom I've pinged myself several times on #debian-QEMU on OFTC.  And it is complete crickets so far11:43
kashyapcoreycb: Do you know anyone _else_ who is able to get that to the finish line?11:43
*** belmoreira has joined #openstack-nova11:46
*** jaosorior has quit IRC11:48
*** etp has quit IRC12:21
kashyapaspiers: Unrelated: I like the `return supported and requested` here in your SEV patch: https://review.opendev.org/#/c/644565/21/nova/virt/libvirt/utils.py12:26
aspierskashyap: readability is key :)12:28
kashyapI think I will steal it for Secure Boot patches12:29
*** arxcruz|brb is now known as arxcruz12:29
kashyapaspiers: I'd appreciate your feedback, once I get them rolling :D.  (The spec is merged: https://opendev.org/openstack/nova-specs/src/branch/master/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.rst)12:29
*** mriedem has joined #openstack-nova12:35
*** ttsiouts has quit IRC12:36
mriedembauzas: libvirt vgpu queens bug in triage if you've seen the error before https://bugs.launchpad.net/nova/+bug/183768112:36
openstackLaunchpad bug 1837681 in OpenStack Compute (nova) "Failed to create vgpu cause of IOError" [Undecided,New]12:36
*** ttsiouts has joined #openstack-nova12:36
alex_xucdent: the problem is on the drop the claim https://review.opendev.org/#/c/670784/5/nova/compute/resource_tracker.py@49812:37
alex_xucdent: this is mdev's unclaim I try to implement https://review.opendev.org/#/c/671222/8/nova/virt/libvirt/device.py@15012:38
* cdent reads12:39
*** ttsiouts has quit IRC12:41
cdentalex_xu: so when mdev.flavor_id != flavor_id we don't clear the mdev.instance_uuid because that signals we are on destination?12:42
cdentUsing the flavor in that way seems hard to follow. Would it not be better further up the stack to make the distinction, rather than being implicit?12:43
*** mkrai_ has quit IRC12:43
*** mkrai has joined #openstack-nova12:43
*** coreycb has quit IRC12:45
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442012:46
openstackgerritAdam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection  https://review.opendev.org/63633412:46
openstackgerritAdam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py  https://review.opendev.org/63631812:46
openstackgerritAdam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required  https://review.opendev.org/64456512:46
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661612:46
alex_xucdent: we will pass old or new flavor_id to the unclaim_for_instance based on the unclaim is on src or dest node. But yes, you are right, it is implicity12:46
*** coreycb has joined #openstack-nova12:47
alex_xucdent: I can pass a flag to indicate this is src or dest host. Then the virt driver depends on that flag fetch the new or old flavor id, and assign to mdev.flavor_id12:48
*** mkrai has quit IRC12:48
cdentthat seems like it would be more clear. it would also make it easier to ignore flavors entirely if we want to12:48
coreycbkashyap: i'll check with dannf in a bit when he gets in and see if I can get any info12:49
*** jaosorior has joined #openstack-nova12:49
alex_xucdent: yea, agree with you, that is too implicity, not clear to the virt driver what behavior should be implement.12:49
* cdent nods12:49
kashyapcoreycb: Thanks.  I've pinged him on #debian-qemu twice in the last two weeks, FWIW.12:49
kashyapI assumed he's on vacation.12:49
*** eharney has joined #openstack-nova12:49
alex_xualthough still have a little implicit on the virt driver need to use flavor as part of identify of claim12:50
alex_xucdent: how about nova just compose an id by (instance_uuid, flavor_id), then the virt driver needn't care about it.12:52
cdentalex_xu: I'm unclear where that id is being used?12:53
alex_xucdent: I use instance_uuid and flavor_id to distingush the claim. so combine them to as a key12:53
*** belmoreira has quit IRC12:54
*** maciejjozefczyk_ has joined #openstack-nova12:56
*** liuyulong has joined #openstack-nova12:56
bauzasmriedem: ack12:57
bauzasmriedem: thanks12:57
*** maciejjozefczyk has quit IRC12:59
mriedemstephenfin: dansmith: i'm not sure about some stuff in this estimate_instance_overhead "removal" change https://review.opendev.org/#/c/672106/12:59
*** elod has joined #openstack-nova13:01
*** jawad_axd has quit IRC13:01
*** elod2 has quit IRC13:02
*** awalende has quit IRC13:04
*** awalende has joined #openstack-nova13:05
stephenfinmriedem: I'd initially just removed the whole lot but then I spotted that path that I thought used it. Perhaps not though. Will update shortly (y)13:05
mriedemwell don't take my word for it, but you should double check13:05
mriedembut i don't see those *used compute node fields used in any of the non-upt fallback flows for reporting provider inventory13:05
mriedemiow overhead has always been separate from what we report to placement13:06
mriedemwhich is i think why we talked about it in boston - how to account for the driver overhead stuff in our inventory/allocation reporting and just settled on operators needing to bump reserved13:07
mriedemif you do respin, it'd be nice to address my comments in https://review.opendev.org/#/c/551026/ and then i'd re-+213:07
*** awalende has quit IRC13:09
alex_xustephenfin: good morning, appreciate if you can take a look at https://review.opendev.org/66865613:10
*** ttsiouts has joined #openstack-nova13:12
alex_xustephenfin: after go through your code on standard cpu tracking, I think there is no data model for ^ that spec. I can totally reuse InstanceNumaCell.cpu_pinning_raw13:13
openstackgerritMatt Riedemann proposed openstack/nova master: Test heal port allocations in nova-next  https://review.opendev.org/66987913:21
openstackgerritMatt Riedemann proposed openstack/nova master: Disable cinder-backup service in nova-next job  https://review.opendev.org/67251813:21
*** artom has quit IRC13:25
*** maciejjozefczyk_ is now known as maciejjozefczyk13:25
*** ttsiouts has quit IRC13:28
*** ttsiouts has joined #openstack-nova13:29
stephenfinalex_xu: Sure thing13:31
efriedstephenfin: If you get a minute, would you please have a look at this oldy moldy again? We're one patch away from being able to kill fake_libvirt_utils https://review.opendev.org/#/c/644793/13:32
*** ttsiouts has quit IRC13:33
*** awalende has joined #openstack-nova13:34
*** awalende has quit IRC13:38
*** cdent has quit IRC13:38
*** ganso has quit IRC13:39
*** brault has joined #openstack-nova13:39
*** liuyulong has quit IRC13:41
*** cdent has joined #openstack-nova13:42
*** ttsiouts has joined #openstack-nova13:45
*** vishwanathj has joined #openstack-nova13:46
*** belmoreira has joined #openstack-nova14:00
*** ganso has joined #openstack-nova14:01
openstackgerritEric Fried proposed openstack/nova master: Disable cinder-backup service in nova-next job  https://review.opendev.org/67251814:05
openstackgerritEric Fried proposed openstack/nova master: Test heal port allocations in nova-next  https://review.opendev.org/66987914:07
*** brault has quit IRC14:07
efriedmriedem: ftfy ^14:08
*** Laszlo-74 has joined #openstack-nova14:13
*** Luzi has quit IRC14:14
mriedemah yeah bad rebase on my part14:16
*** lennyb has quit IRC14:18
openstackgerritMartin Midolesov proposed openstack/nova master: Implementing graceful shutdown.  https://review.opendev.org/66624514:21
*** JamesBenson has joined #openstack-nova14:21
*** dpawlik has quit IRC14:25
*** mriedem has quit IRC14:29
stephenfinefried: Done (https://review.opendev.org/#/c/644793/)14:30
Laszlo-74Hello everybody. Is there a document that describes the nova cold migration? I have a problem migrating instances and I want to read about how the things are supposed to happen in the background. On the openstack docs I've found info only about how to use the migration, but I want to understand how it is happening.Thank you14:33
*** dpawlik has joined #openstack-nova14:33
edleafell14:33
efriedthanks stephenfin14:37
kashyapefried: jroll: Hey, got a link to that TPM passthrough spec/BP?14:38
efriedkashyap: The emulated one? (The physical one is dead)14:38
kashyapAh, good -- the physical one is dead14:38
efriedhttp://specs.openstack.org/openstack/nova-specs/specs/train/approved/add-emulated-virtual-tpm.html14:38
kashyapThat was about to be my "news"14:38
efriedoh, what is your perspective, see if it matches our discoveries14:38
*** mlavalle has joined #openstack-nova14:39
kashyapBecause, FWIW, the RHEL Virt folks are going to disable / unspport the TPM passthrough14:39
dansmithwoot14:39
efriedkashyap: here was the draft https://review.opendev.org/#/c/667926/ based on some invalid assumptions, like the ability to wipe / transfer ownership of the pTPM without a frickin reboot.14:39
kashyap... now that vTPM is secure enough (with the vTPM state encryption patches for libvirt are merged.)14:39
kashyapefried: I'm on a loong call :-(  Will look once done.14:40
efriedkashyap: no need14:40
kashyapI just wanted to convey what I learned14:40
efriedThanks kashyap.14:41
*** psachin has quit IRC14:41
*** belmoreira has quit IRC14:42
*** ricolin_ has joined #openstack-nova14:42
jrolllol, thanks kashyap14:43
*** rouk has quit IRC14:43
*** jmlowe has quit IRC14:45
*** ricolin has quit IRC14:45
*** david-lyle is now known as dklyle14:45
openstackgerritMerged openstack/nova master: Remove test_pre_live_migration_instance_has_no_fixed_ip  https://review.opendev.org/67094814:45
*** belmoreira has joined #openstack-nova14:47
*** dpawlik has quit IRC14:48
*** igordc has joined #openstack-nova14:49
*** belmoreira has quit IRC14:50
*** artom has joined #openstack-nova14:52
*** belmoreira has joined #openstack-nova14:53
*** belmoreira has quit IRC14:57
*** jmlowe has joined #openstack-nova15:00
*** belmoreira has joined #openstack-nova15:00
*** ricolin_ is now known as ricolin15:02
*** shilpasd has quit IRC15:03
*** ccamacho has quit IRC15:05
melwittkashyap: do you happen to have a link to look at about the libvirt patches that were landed? or version available?15:09
*** mriedem has joined #openstack-nova15:09
kashyapmelwitt: Hmm, the news.html -- let me get that15:09
kashyap(On my request, they even added per-release hyperlink)15:09
kashyapmelwitt: So for a year or two libvirt upstream has been documenting each new feature as part of the 'news' for each release.15:10
kashyap    https://libvirt.org/news.html15:10
melwittkashyap: a-ha, cool. thanks!15:10
kashyapBy "documenting" don't expect anything super useful :D -- just a small one- or two-line description15:11
kashyapjroll: Not sure you might've noticed -- the vTPM state encryption patches for libvirt are merged.15:11
jrollkashyap: I hadn't noticed yet, thanks15:12
*** gyee has joined #openstack-nova15:13
* kashyap double-checks, actually.15:14
kashyapjroll: No, I tell a lie.  It is "ready to be merged".15:14
jrollheh15:14
*** belmoreira has quit IRC15:25
mriedemgot a few easy stable/stein backports with +2s waiting on another core https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/stein+label:Code-Review=215:27
artommriedem, FWIW Lee's in a meetup this week, so he's not really around15:28
*** ttsiouts has quit IRC15:28
mriedemlee's not the only stable core15:29
artomI know, just saying :)15:29
*** ttsiouts has joined #openstack-nova15:29
artom(Someone was asking about his whereabouts, probably you)15:29
openstackgerritStephen Finucane proposed openstack/nova master: Remove deprecated CPU, RAM, disk claiming in resource tracker  https://review.opendev.org/55102615:29
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'nova.virt.driver.ComputeDriver.estimate_instance_overhead'  https://review.opendev.org/67210615:29
openstackgerritStephen Finucane proposed openstack/nova master: objects: Rename 'nova.objects.instance_numa_topology'  https://review.opendev.org/67178915:29
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary try-catch around 'getCPUMap'  https://review.opendev.org/67179015:29
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions  https://review.opendev.org/53741415:29
openstackgerritStephen Finucane proposed openstack/nova master: claims: Remove useless caching  https://review.opendev.org/67179115:29
openstackgerritStephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option  https://review.opendev.org/67179215:29
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement  https://review.opendev.org/67179315:29
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Rename exception argument  https://review.opendev.org/67179515:29
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Remove unused function parameter  https://review.opendev.org/67179615:29
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance'  https://review.opendev.org/67179715:29
stephenfinwheeee15:29
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host'  https://review.opendev.org/67179815:29
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance'  https://review.opendev.org/67179915:29
openstackgerritStephen Finucane proposed openstack/nova master: WIP: hardware: Differentiate between shared and dedicated CPUs  https://review.opendev.org/67180015:29
openstackgerritStephen Finucane proposed openstack/nova master: tests: Split NUMA object tests  https://review.opendev.org/67233615:29
openstackgerritStephen Finucane proposed openstack/nova master: Add support translating CPU policy extra specs, image meta  https://review.opendev.org/67180115:29
mriedemi do like to keep tabs on lee15:30
mriedemthat's true15:30
artomBtw, while you were out, I believe it was Sean who typo'ed your name as mriderman. I found that highly amusing :D15:31
mriedemdansmith: ^15:32
mriedemnot at all surprising15:32
dansmithartom: people have been calling him riderman for a long time15:32
artom/r/outoftheloop :(15:32
*** tssurya has quit IRC15:32
*** ttsiouts has quit IRC15:34
kashyapHehe, mriedem - you gotta admit, that's a nice Friday nick :D15:35
kashyapriderman :D15:35
openstackgerritStephen Finucane proposed openstack/nova master: compute: Use source_bdms to reset attachment_ids during LM rollback  https://review.opendev.org/65280015:35
openstackgerritStephen Finucane proposed openstack/nova master: compute: refactor volume bdm rollback error handling  https://review.opendev.org/65650015:36
*** hongbin has joined #openstack-nova15:36
*** sean-k-mooney has joined #openstack-nova15:37
artom♩ Rider man, rider man / Does whatever a rider can / Spins his wheels, lots of smoke / Wear your helmet, don't be a joke / Look out! Here comes the Riderman! ♩15:37
* artom -> lunch15:38
*** hongbin has quit IRC15:42
*** hongbin has joined #openstack-nova15:42
*** hongbin has quit IRC15:43
*** hongbin has joined #openstack-nova15:44
*** maciejjozefczyk has quit IRC15:48
*** boxiang has quit IRC15:50
*** boxiang has joined #openstack-nova15:50
sean-k-mooneymriedem: so i havent read the full thread on the imageProperties thing but what are your current feeiling on that topic.  i remmeber discusing this at one of the ptgs and i had though we were not going to expose the use of kvm via the api or limit you to only kvm if you had virt_type=kvm16:05
sean-k-mooneygive that https://review.opendev.org/#/c/531347/3 was merged i guess we change our minds on the latter16:05
*** brault has joined #openstack-nova16:06
sean-k-mooneybut i though we were going to allow qemu with the tsg backend to be used on host with virt-type=kvm if the architrure of the imge did not match the host architeture16:06
mriedemsean-k-mooney: idk, i don't remember all of the previous discussions about it but i know the "hypervisor_type=QEMU in the API when i'm actually using KVM really confuses me" is a really old thing - given that bug was from 201316:08
mriedemi was on the team at ibm that reported it....16:08
sean-k-mooneywell i expect hyperviors_type=QEMU to be reported for virt_type=kvm16:08
mriedemas i said somewhere in the ml thread, that the api is reporting QEMU still but the driver is reporting (to the node, which is used by the scheduler) whatever the virt_type config is, makes the api<>scheduler interaction really confusing for knowing how to set the hypervisor_type image property16:09
sean-k-mooneybecause we are not chagne the hypeviro just the qemu backend form tcg to kvm16:09
dansmithI also thought the argument was that qemu *is* the hypervisor and that kvm was just the acceleration mechanism (of which there could be different ones)16:09
sean-k-mooneyboth are still qemu16:09
mriedemso the change was clearly a regression,16:09
mriedemalso as noted the docs (nova scheduler filter and glance image prop) docs say hypervisor_type is qemu for both qemu and kvm16:09
mriedemi'd be fine with reverting the change16:09
sean-k-mooneyhttps://review.opendev.org/#/c/531347/3 this one?16:10
mriedemif we don't, i think we need a compat shim in the filter16:10
mriedemyes16:10
mriedembecause like i said and massimo confirmed in the thread, any existing instances with the hypervisor_type=qemu aren't going to be migratable now16:10
mriedemw/o db surgery16:10
mriedemwhich sucks16:10
*** mvkr_ has quit IRC16:10
sean-k-mooneyya personally i wold prefer to revert and then maybe use trait or the vm_mode image prperty to contol if emulation is allowed16:10
*** brault has quit IRC16:11
sean-k-mooneyfor example if we report NATIVE_ARCH_X86_64 and ARCH_ARACH64 as tratis16:11
*** cdent has quit IRC16:12
sean-k-mooneythat would mean its a x86_64 host but the arm arch64 emulator is also aviable16:12
sean-k-mooneythen in the image you could say NATIVE_ if you wanted hardware accleartion or ust ARCH_* if you didnt care16:12
sean-k-mooneyfor the x86_64 host you would have both NATIVE_x86_64 and ARCH_X86_6416:13
dansmithwait,16:13
mriedemi'm not sure vm_mode would help, since it'd be hvm in either qemu or kvm wouldn't it?16:13
*** pcaruana has quit IRC16:13
dansmithare you saying tetsuro's patch causes us to report kvm only instead of qemu?16:13
mriedemdansmith: to the ImagePropertiesFilter yes16:14
mriedemso presumably he wanted that because he had nodes with virt_type=qemu and nodes with virt_type=kvm and was using separate images with different hypervisor_type values to distinguish and pin on them16:14
dansmithokay that's not really what I thought the change was for16:14
mriedemrather than using something like aggregates16:14
sean-k-mooneyya so i think traits and a prefilter are a better option at least today16:16
*** mvkr_ has joined #openstack-nova16:16
sean-k-mooneymriedem: regarding vm-mode im not sure if they both would be hvm but it was the closet exitsing image prop that seamed relevent16:16
sean-k-mooneyif people were gernerally open to the traits approch i can quickly write up a spec for that and code it up. i have more or less gottend to a code complete point with my two remaining feature for train so they are just pending review and ill be switching to fixing bug once they land16:19
sean-k-mooneybut i could proably get a traits based version working quickly if people liked that idea16:20
openstackgerritMatt Riedemann proposed openstack/nova master: Revert "[libvirt] Filter hypervisor_type by virt_type"  https://review.opendev.org/67255916:22
*** ricolin has quit IRC16:23
sean-k-mooneyi would also be fine with just saying lets file a blueprint and do it next release16:25
openstackgerritMerged openstack/nova master: Remove fake_libvirt_utils users in functional testing.  https://review.opendev.org/64479316:25
sean-k-mooneywe have quite a few features already in flight16:25
*** rpittau is now known as rpittau|afk16:26
mriedemi would be fine with people that actually care about this use case showing up and doing the work for it16:26
mriedemsean-k-mooney: so i'd say don't worry about it16:27
mriedemand yes we already have a lot of stuff in flight16:27
sean-k-mooneycool ill leave it so until we get asked to support it by someone16:28
openstackgerritMatt Riedemann proposed openstack/nova master: Revert "[libvirt] Filter hypervisor_type by virt_type"  https://review.opendev.org/67255916:28
sean-k-mooneyi personaly (e.g. not because redhat wants it) would like to imporve our support for emulating other plathform over time, but that more so i can more eaisily test those when we have bugs and since that doent come up too often i have not pursued it much16:29
sean-k-mooneybeing able to land a vm onto a host that has the right emulator installed would help with that but its overkill for the 1 time in every 2-3 years i have to check what happens on arm or ppc16:30
mriedemit is now time for me to eat a sandwich and watch sports talk guys16:33
sean-k-mooneyaspiers: are you around?16:33
sean-k-mooneyaspiers: kashyap can ye review https://review.opendev.org/#/c/670189/9 specifcally https://review.opendev.org/#/c/670189/9/nova/virt/libvirt/host.py@78116:47
* artom wonders if there's a way to mock the libvirt connection per compute service/libvirt driver instance16:48
kashyapsean-k-mooney: Hiya, just began reading16:48
sean-k-mooneyartom: we do that in the functional tests16:49
kashyapsean-k-mooney: It requires me to concentrate for at least 20 minutes, and I'm cooking :-)  Will look after that.  Or earliest in the morning16:49
artomsean-k-mooney, right, but with a different hostcaps for each?16:49
sean-k-mooneyyes i think so16:49
artom(Which is what I should have said I wanted to do)16:49
sean-k-mooneylook at the numa ones16:49
sean-k-mooneyartom: https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_numa_servers.py#L43716:51
sean-k-mooneynot sure if that is what you are looking for16:51
artomsean-k-mooney, exactly that16:51
sean-k-mooneyartom: cool thank stephenfin i know it was a pain when he was trying to figure out how to do that the first time16:52
artomAnd I'm very grateful that he did :D16:52
kashyapsean-k-mooney: BTW, I learnt this morning that you found "that bug" -- nice that at least _someone_ is testing non-x86 arches :D16:54
kashyapIf not for you, I wonder how long it must've stayed dormant16:55
*** luksky123 has quit IRC16:55
kashyapAnyway, nice find.16:55
sean-k-mooneykashyap: well i have non x86 emulators installed and it caused the compute agent to expolde when i added a use of that function16:55
aspiersYeah good catch16:56
sean-k-mooneyso it was kind of obvious once we actully used it outside of tests16:56
aspierssean-k-mooney: I saw your comment about setting virt_type before16:56
*** derekh has quit IRC16:56
kashyap(Right, I have non-x86 emulators installed, too)16:57
aspiersand I couldn't understand why it was a bug16:57
aspierssurely you shouldn't set virt_type to an invalid value16:57
sean-k-mooneythe reason that it was not exploding on aspiers patch sets is because they only condtionally call it if sev is supported and the gate vms dont16:57
kashyapsean-k-mooney: Why do you think we don't need to call get_domain_capabilities() for KVM/QEMU?16:57
sean-k-mooneykashyap: i think we dont need to call it when its not kvm/qemu16:58
aspierssean-k-mooney: I don't see why it should be considered OK to set virt_type=kvm on a host which doesn't support kvm16:58
kashyapIt spits out caps for other hypervisors, too, surely.  (Although I haven't done extensive testing with others)16:58
sean-k-mooneye.g. if it was lxc16:58
kashyapsean-k-mooney: Err, that's what I meant, when _not_ KVM|QEMU.16:58
kashyapaspiers: Yeah, that is bogus config16:58
sean-k-mooneykashyap: well we are parsing thing like what disk types can you emulatate16:58
sean-k-mooneyfor lxc you dont emulate anything16:58
aspierssean-k-mooney: aren't you just seeing this because you have a fake environment with multiple arch emulators?16:58
sean-k-mooneybut for sev i guess i could be relevent16:59
sean-k-mooneyaspiers: all the emulators are installed by defualt on ubuntu16:59
sean-k-mooneyand they used to be installed by defualt on fedora and centos16:59
kashyapsean-k-mooney: BTW, quickly: I don't like option-(2), that is black magic for users, and can be an unwanted surprise.16:59
sean-k-mooneykashyap: cool this is why i asked17:00
kashyap(I'm saying this because you seem to list it, option-2, as one of the valid ones.)17:00
sean-k-mooneyit is vaild but it is also magic17:00
kashyapsean-k-mooney: Yeah, saw your solication for views.  I'll write a fuller comment after I've thought through.  (Need a clearer head, and it's melting hot here...)17:00
*** mmethot_ is now known as mmethot17:02
aspiersOK so IIUC the situation is Ubuntu compute nodes where non-native arch is supported but the operator only wants nova to use kvm?17:03
sean-k-mooneyi assume we pass virt-type for a reason which is why i was kind of discounting 1 and i was pering not to advace 4 as i assume we want to report data for all the emultors you have installed. 5 might be the more sain option but i dont like raising exceptions.17:03
openstackgerritMerged openstack/nova stable/stein: Remove redundant group host setup  https://review.opendev.org/66733417:03
aspiersso they set virt_type but then get_dom_caps iterates over all archs discovered by getCaps which includes the non-native ones17:03
sean-k-mooneyaspiers: if you set virt-type=qemu kvm will never be used even for the native arch17:03
sean-k-mooneyso you would want to set virt-type=kvm17:04
aspiersright17:04
aspiersbut then that gets used in every API call to getDomCaps17:04
aspierswhich then explodes17:04
aspiersI think I understand17:04
sean-k-mooneyyes17:04
aspierswhat's wrong with option 1?17:04
aspiersdo we need to pass virt_type?17:04
sean-k-mooneyam i just assumed that we passed it for a reason intially17:05
aspierswell I was assuming that every host could only have 1 virt_type17:05
sean-k-mooneybut we have not documented why we do so i didnt want to assume we could jsut not pass it17:05
aspiersI didn't know about this crazy Ubuntu stuff17:05
*** Laszlo-74 has left #openstack-nova17:05
sean-k-mooneywell every host today can only have one virt type17:05
aspierscan we just ignore archs which don't match virt_type, if it's set?17:06
aspiersif the operator sets virt_type=kvm, we should ignore any arch which doesn't support that17:06
sean-k-mooneybut the issue is that if you set kvm we should not explode just becasue you have the binary for a different emultor installed17:06
sean-k-mooneythat would be 417:06
aspiersright, so I'm suggesting option 117:06
aspiersor yeah, or 417:06
aspierswhat is the exception?17:07
sean-k-mooneyi would be fine with any of the option honestly17:07
sean-k-mooneylibvirtError17:07
aspierswell kashyap veto'd 217:07
aspiersand I don't like that one much either17:07
sean-k-mooneyaspiers: you mean he nack'd 2 because its magic17:09
aspiersright17:09
aspierswhy not pass None and then ignore if <domain> doesn't match?17:09
sean-k-mooneythis is the exception we get by the way17:10
sean-k-mooneyhttp://paste.openstack.org/show/754776/17:10
sean-k-mooneyaspiers: that is option 1 and im fine with that17:11
aspiersmy only concern is that there's a risk of getting non-accelerated qemu instead of kvm on x86_6417:11
aspiersalthough it seems fine here17:12
aspierskashyap: do you know if that's a real risk?17:12
sean-k-mooneyaspiers: its possible yes but i dont know if that would change things17:12
sean-k-mooneythat is why i listed 217:12
aspierssean-k-mooney: well in theory it might return different feature sets for qemu vs kvm17:12
aspiersbut on my SEV box here it is returning kvm anyway17:12
aspierswith the SEV feature17:12
aspiersso it seems OK17:13
sean-k-mooneyaspiers: right it could17:13
sean-k-mooneythings like sev i think would only work in kvm mode right17:13
aspiersyeah I would expect so17:13
aspierskashyap: can you check with one of your libvirt / qemu gurus?17:13
aspiersI'll ping mine17:13
sean-k-mooneyso if you had virt-type=qemu but your host had kvm installed it might report sev suppport eventhough the vm would not work17:14
sean-k-mooneyso i think we proably do want to use the virt-type where possible and only fall back to not setting it if that result in an error17:15
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance'  https://review.opendev.org/67179717:15
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host'  https://review.opendev.org/67179817:15
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance'  https://review.opendev.org/67179917:15
openstackgerritStephen Finucane proposed openstack/nova master: tests: Split NUMA object tests  https://review.opendev.org/67233617:15
openstackgerritStephen Finucane proposed openstack/nova master: WIP: hardware: Differentiate between shared and dedicated CPUs  https://review.opendev.org/67180017:15
openstackgerritStephen Finucane proposed openstack/nova master: Add support translating CPU policy extra specs, image meta  https://review.opendev.org/67180117:15
openstackgerritStephen Finucane proposed openstack/nova master: Rework 'numa_usage_from_instances'  https://review.opendev.org/67256517:15
sean-k-mooneyor add some magic to make sure we dont raise the error if we know a combination would be invaild17:15
aspierssean-k-mooney: I'm suggesting to ignore any results where virt_type doesn't match <domain>17:15
openstackgerritStephen Finucane proposed openstack/nova master: Rework 'hardware.numa_usage_from_instances'  https://review.opendev.org/67256517:16
openstackgerritStephen Finucane proposed openstack/nova master: tests: Split NUMA object tests  https://review.opendev.org/67233617:16
openstackgerritStephen Finucane proposed openstack/nova master: WIP: hardware: Differentiate between shared and dedicated CPUs  https://review.opendev.org/67180017:16
openstackgerritStephen Finucane proposed openstack/nova master: Add support translating CPU policy extra specs, image meta  https://review.opendev.org/67180117:16
sean-k-mooneywhat do you mean by domain17:16
*** igordc has quit IRC17:16
aspiersthe <domain> element returned in the XML17:16
sean-k-mooneyoh your suggesting we go with 417:16
aspiersno17:16
aspiersoption 117:16
aspierspass None, but check <domain>17:16
sean-k-mooneybut why not do 417:16
sean-k-mooneypass the virt type so livbrit checks it17:16
sean-k-mooneyand if it errors skip17:17
*** igordc has joined #openstack-nova17:17
aspiersI guess that's OK too17:17
aspiersbut you prefer 5 to 4?17:17
aspiersI think we should start conservative and not bend over backwards to try and cover every case before we actually understand what the corner cases are exactly17:18
sean-k-mooneyactully i prefer 2 and i dislike raising exception but i think 1 would break if you have virt-type=qemu but have kvm installed17:18
aspiersI just tried with qemu17:18
sean-k-mooneybecause libvirt would default to kvm in that case17:18
aspiersit returns <domain>qemu</domain> and with sev supported='yes' too17:19
sean-k-mooneyand we would then skip it because it did not match qemu17:19
aspiersbut it also returns <path>/usr/bin/qemu-kvm</path>17:19
aspiersso there would be no skipping, and it would still use acceleration and get SEV17:20
aspiers(assuming that is deterministic)17:20
sean-k-mooneyif i run "virsh domcapabilities --arch x86_64" it retruns <domain>kvm</domain>17:20
sean-k-mooneyif i run "virsh domcapabilities --arch x86" it retruns <domain>kvm</domain>17:20
sean-k-mooneysame for virsh domcapabilities --arch i68617:21
aspierserror: failed to get emulator capabilities17:21
aspierserror: invalid argument: unknown architecture: x8617:21
sean-k-mooneyya x86 is not a thing17:21
aspiersi686 works here17:21
sean-k-mooneyits i 386, i486,i586 or  i68617:22
aspiers  <path>/usr/bin/qemu-system-i386</path>17:22
aspiers  <domain>qemu</domain>17:22
aspiersI feel like we are in bikeshedding territory now17:22
sean-k-mooneyoh i guess only i686 works17:22
sean-k-mooneyaspiers: do you have the kvm kernel module loaded17:22
aspiersyes17:22
sean-k-mooneyi think based on what you are showing me in anycase we cant use 117:23
aspierswhy?17:23
sean-k-mooneybecause if i set virt-type=kvm it wont match17:23
sean-k-mooneyand on my system where i get back kvm if i set virt-type=qemu it wont match17:23
aspiershuh17:24
aspiersit matches here17:24
aspiersif I pass None, I get kvm17:24
aspiersif I pass qemu, I get qemu17:24
sean-k-mooneyi though you were always passing none or not setting it17:25
sean-k-mooneyanyway that is also a proably if i set virt-type=qemu and i pass none which is option 1 you would get back kvm17:25
sean-k-mooneyand it would not match so we would ignore it17:25
sean-k-mooneywhere as 4 we pass the virt-type form the conf and if we get an error we skip that emulator17:26
aspierssean-k-mooney: http://paste.openstack.org/show/754808/17:26
sean-k-mooneyyep17:26
aspiersif you set virt-type=qemu then you should not expect kvm acceleration to be available, so that is correct17:26
aspierswhy would anyone set virt_type to qemu if they wanted kvm?17:27
sean-k-mooneythey would not17:27
aspiersOK, so the behaviour you describe is what we want17:27
*** igordc has quit IRC17:27
aspiersif virt_type is set to qemu, ignore kvm17:27
sean-k-mooneycool ok that is option 417:27
aspiersor my modified option 1 yeah17:28
aspierslet's just do 417:28
aspiersI doubt it will cause issues but if it does we can fix them later17:28
aspierskashyap: that OK with you?17:28
sean-k-mooneyno option 1 is "do not pass the virt type ever ..." and your modifation is and then check the domain.  cool ill push up a patch for 4 soon after i test it locally17:29
sean-k-mooneyand assumign kashyap agrees17:29
aspierssounds good17:30
sean-k-mooneyaspiers: and then hopfuly we can start merging the sev code and my deivce model stuff17:30
aspiersyup17:30
*** priteau has quit IRC17:30
aspiersI wouldn't mind a Co-Authored-By if that's OK, so my managers can see where I'm spending my time :)17:30
aspiersor even so that I can recall where I'm spending my time in case managers ask ;p17:31
sean-k-mooneyof course ill add it when i push it up.17:31
aspiersawesome thanks17:31
aspiersI tend to forget what I've done soon after doing it :-o17:31
sean-k-mooneyits like exams sometimes. you jsut spent 3 hours writing everyting you know about a topic and you go outside and someone asks you what you though of it and your like. i cant rembeber what i just did17:33
*** awalende has joined #openstack-nova17:34
* artom remembers OS_DEBUG=True17:39
*** awalende has quit IRC17:39
artomaspiers, same here. Manager: "So, let's make a quick retro of your past year." Me: *rabbit in headlights*17:40
*** pcaruana has joined #openstack-nova17:41
openstackgerritMatt Riedemann proposed openstack/nova master: api-ref: touch up the os-services docs  https://review.opendev.org/67257117:54
*** KeithMnemonic has joined #openstack-nova17:55
*** ralonsoh has quit IRC17:55
KeithMnemonicdoes anyone know the rule for running instances outside of nova (virsh define) on a KVM host that is running nova-compute. Is it allowed/forbidden/supported,...,..17:56
sean-k-mooneyKeithMnemonic: its allowed but discuraged17:56
sean-k-mooneyyou need to adjust the reserved host values for memeory ram and disk17:56
sean-k-mooneyso that we dont double count the resouce used by the out of band instances17:57
KeithMnemonicThanks do you know if we list the discouragement anywhere ;-)17:57
sean-k-mooneyi dont think we do explcitly17:57
sean-k-mooneyyou milage migth also vary based on your hypervior of choice17:58
sean-k-mooneyfor kvm as long as you tell nova in the config what cpus and how much ram you are using by reseving it then its fine. for ironic unless you want your data to be lost dont use a node without telling ironic17:59
*** maciejjozefczyk has joined #openstack-nova17:59
sean-k-mooneyfor hyperv or vmare it proably works but i would suspect you have to similary tell there virt driver you are using some of the resouces18:00
*** igordc has joined #openstack-nova18:01
KeithMnemonicthanks sean-k-mooney!18:05
aspierssean-k-mooney: one of the benefits of being old is that I've managed to wipe all exams from my memory :)18:11
aspiersartom: exactly :)18:12
sean-k-mooneyits been 8 years since i took my last exam. i generally didnt mind them but if i go back and do a masters at some point i still wont be looking forward to them18:13
*** gary_perkins_ has quit IRC18:19
*** gary_perkins has joined #openstack-nova18:20
aspierswow finally managed to get devstack working18:21
aspiersthat took all day18:21
sean-k-mooneyits always better to start with a clean install if you are setting up an environment18:23
sean-k-mooneyif you had it working previous it can be quick to updated it but if you start hitting18:23
sean-k-mooneypackage issues its often faster to start form scratch18:23
*** panda has quit IRC18:25
*** panda has joined #openstack-nova18:33
*** jmlowe has quit IRC18:33
* artom is angry that https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L89-L94 is allowed to continue to exist.18:41
artomWho thinks like that?!18:41
mriedemmlavalle: you might care about this https://review.opendev.org/#/c/672577/18:44
*** tesseract has quit IRC18:49
*** lpetrut has quit IRC18:50
mlavallemriedem: nice. Thanks!18:58
openstackgerritMerged openstack/nova master: nova-status: Remove consoleauth workaround check  https://review.opendev.org/65296819:01
openstackgerritMerged openstack/nova master: Remove nova-consoleauth  https://review.opendev.org/65296919:08
openstackgerritMerged openstack/nova stable/rocky: Fix double word hacking test  https://review.opendev.org/66578819:09
*** maciejjozefczyk has quit IRC19:21
*** jmlowe has joined #openstack-nova19:22
*** priteau has joined #openstack-nova19:40
*** BjoernT has joined #openstack-nova19:44
*** priteau has quit IRC20:02
*** eharney has quit IRC20:05
*** portdirect has joined #openstack-nova20:06
portdirecthey - im having some difficulty updating the transport url for a cell with cells v220:07
portdirectis there any documentation for doing this?20:07
portdirective seen the comments here re cacheing: https://docs.openstack.org/nova/latest/user/cells.html20:08
portdirectbut still seem to be unable to scedule vms20:09
dansmithportdirect: you're having trouble updating the transport url, or you think the transport url is wrong?20:09
portdirectI'm gonna double check that, but it should be correct20:09
portdirecthere is a ps im working on atm: https://review.opendev.org/#/c/672527/11/nova/templates/bin/_db-sync.sh.tpl20:09
dansmithlooks to me like it runs create_cell with no transport or db urls first?20:10
dansmiththat means it'll stab whatever is in the config into the database, fwiw20:11
dansmithbut still, are you failing to run the command? or are you running it but not seeing what you expect in the db? or just not scheduling vms and you think this is why ?20:11
portdirectso without this addition20:12
portdirectthings are working ok20:12
portdirectbut we cannot change the password, etc for rabbit20:12
dansmithso the create_cell is taking the values from the config and it's working,20:12
portdirectthats what im looking to be able to achive20:12
portdirectyup20:12
dansmithbut you're now adding this update_cell step and that breaks things?20:12
portdirectyes20:12
openstackgerritsean mooney proposed openstack/nova master: libvirt: harden Host.get_domain_capabilities()  https://review.opendev.org/67018920:13
openstackgerritsean mooney proposed openstack/nova master: Libvirt: report storage bus traits  https://review.opendev.org/66691420:13
openstackgerritsean mooney proposed openstack/nova master: libvirt: use domain capablites to get supported device models  https://review.opendev.org/66691520:13
openstackgerritsean mooney proposed openstack/nova master: Add transform_image_metadata request filter  https://review.opendev.org/66577520:13
dansmithportdirect: it would really help if you could answer my questions... is the command failing or is the *result* not what you expect?20:13
portdirectthe result20:13
portdirectfollowing running this, and then restarting all processes, im unable to launch vms20:13
portdirectthe command itself exits 020:14
melwittto the earlier question about documentation, this is the command doc for future reference https://docs.openstack.org/nova/latest/cli/nova-manage.html#nova-cells-v220:14
dansmithportdirect: and you're running the update with the same urls that are in the config or differentones?20:14
portdirectat this point, the same20:14
dansmithportdirect: okay, so look at the cell_mapping record before/after and see what is happening20:14
dansmithportdirect: no template substitutions in the urls I assume?20:15
portdirectno - its just a string at this point - in the normal format20:16
dansmithokay, then it should be fairly straightforward20:16
dansmithportdirect: can you pastebin what is in the config and what you're running it with?20:16
portdirectsure20:16
dansmithportdirect: and, just to be clear, you're apparently seeing failures to talk to the cell1 rabbit after this in conductor, api logs?20:17
portdirecthttp://paste.openstack.org/show/754815/20:18
mriedemsmells like https://review.opendev.org/#/c/605414/ or https://review.opendev.org/#/c/662383/ ?20:19
dansmithhmm, I wonder if update is somehow horking in the multiple hosts20:19
dansmithmriedem: I dunno, they're running update with both params right?20:19
openstackgerritMerged openstack/nova stable/stein: Replace joinedload_all with joinedload  https://review.opendev.org/67153220:20
dansmithoh,20:20
dansmithnot database I see20:20
openstackgerritMerged openstack/nova stable/stein: Perf: Use dicts for ProviderTree roots  https://review.opendev.org/67017920:20
openstackgerritMerged openstack/nova stable/stein: doc: Fix a parameter of NotificationPublisher  https://review.opendev.org/67006420:20
dansmithsaw two params but didn't pay attention20:20
openstackgerritMerged openstack/nova stable/stein: docs: Correct issues with 'openstack quota set' commands  https://review.opendev.org/67009620:20
dansmithso could be,20:20
openstackgerritMerged openstack/nova stable/stein: libvirt: move checking CONF.my_ip to init_host()  https://review.opendev.org/67215420:20
portdirectonly transport, not db20:20
portdirectcould try that20:20
portdirect(using both)20:20
dansmithbut still,20:20
dansmithcan you confirm what the symptom is you're seeing? you mentioned rabbit stuff above20:21
mriedemignore me, i'm just randomly interjecting but there are a few patches floating around for update_cell20:21
dansmithbut maybe you're actually seeing db breakage?20:21
mriedemsahid posted https://review.opendev.org/#/c/672045/ yesterday for trying to update the db connection in a cell mapping20:21
mriedemi haven't dug into it yet20:21
mriedemgotta run20:22
portdirectthe zuul check will proabably help most there - but after doing this, i cannot get hypervisor details, or schedule vms20:22
portdirectwill come back with something more definative in a few mins20:22
melwittmriedem: yeah, I'm wondering the same, especially https://bugs.launchpad.net/nova/+bug/182985220:22
openstackLaunchpad bug 1829852 in OpenStack Compute (nova) "'--database_connection' changes when update cell with '--transport-url' only" [Medium,In progress] - Assigned to Takashi NATSUME (natsume-takashi)20:22
dansmithportdirect: okay but no zuul report in a bunch of changesets, so is it relevant?20:23
dansmithbut yeah, probably related.. I thought the behavior would be to keep what is in the config file, but surya's patch says it goes to none:// ?20:23
dansmithoh, that's map_cell020:24
dansmithyeah, takashi's says update_cell keeps the one from the config if you dont' specify currently, so I wouldn't think this would be wrong20:24
dansmithmelwitt: ^20:24
dansmith(right?)20:25
portdirecthow can i get query the db to see what is currently in there for the cells config?20:25
portdirecti had a quick look in the cells table, but it was empty20:25
dansmithportdirect: in the api database cell_mappings table20:26
portdirect(so assume im in the wrong place :) )20:26
dansmithshould look exactly like you expect20:26
portdirectgotcha20:26
dansmiththe cells table in the main nova db is different and unrelated20:26
portdirectoh!20:27
portdirectim an idiot20:27
portdirecti'm giving it the rmq rest endpoint, not ampq20:28
dansmiththat's not going to work20:28
dansmith:D20:28
portdirectbut WHY!20:28
portdirectlol - sorry people - thanks for all the help though20:28
openstackgerritMerged openstack/nova stable/stein: Add 'path' query parameter to console access url  https://review.opendev.org/67097220:29
dansmithI'm guessing that sahid's patch is a dupe of takashi's and maybe surya's as well20:30
melwittdansmith: yeah, it's confusing me. takashin's patch says about the config being used, but the bug reporter said they updated a cell with --transport-url only and ended up with the database connection url getting changed as well, to cell0's database url20:30
dansmithmelwitt: sure that's probably because they used the api's config file, which would point at cell0 by default20:31
dansmithso makes sense20:31
melwittI see.20:31
*** panda has quit IRC20:35
*** panda has joined #openstack-nova20:37
melwittre-read the bug comments again, takashin got a "The specified transport_url and/or database_connection combination already exists for another cell with uuid 00000000-0000-0000-0000-000000000000." error message when he tried it. but the bug reporter did not get that error and the url changed to not exactly cell0's url but the same host (as though a templated change). I don't get that20:39
artomFunctional tests for NUMA live migration are going to require a *lot* of scaffolding...20:39
sean-k-mooneyartom: we should have some if not all of it20:40
artomsean-k-mooney, ehhhh20:41
artomhttps://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/fakelibvirt.py#L962-L96720:41
dansmithmelwitt: order of operations I imagine.. if you haven't created cell0 yet, you'd get the cell0 url incorrectly, and if you did, you'd get takashi's error20:41
sean-k-mooneywe technically have 1 functional test that does livie migration( granted it just asserts that it fails) and we have numa tests already20:41
artomAnd all of https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/fakelibvirt.py#L100820:41
artomThe way is returns instance XML is completely broken20:41
sean-k-mooneyya20:41
artomAdding and/or removing elements that weren't/were there20:41
sean-k-mooneythe only functional test we have for migration assert a failure condition for multi attach volumes20:42
artomI did a live migration test, but with the fake driver20:42
*** hemna has quit IRC20:50
*** hemna has joined #openstack-nova20:50
openstackgerritArtom Lifshitz proposed openstack/nova master: [WIP] Functional tests for NUMA live migration  https://review.opendev.org/67259520:50
artom^^ what I have so far20:50
*** eharney has joined #openstack-nova20:56
*** BjoernT has quit IRC20:57
*** pcaruana has quit IRC21:05
openstackgerritArtom Lifshitz proposed openstack/nova master: [WIP-until-series-is-ready] Introduce live_migration_claim()  https://review.opendev.org/63566921:07
openstackgerritArtom Lifshitz proposed openstack/nova master: New objects for NUMA live migration  https://review.opendev.org/63482721:07
sean-k-mooneyartom: having this scafolding is not a badting in general and should allow use to add more live migration tests later so other the the amount of work i dont think its a bad thing21:07
openstackgerritArtom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source  https://review.opendev.org/63482821:07
openstackgerritArtom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source  https://review.opendev.org/63522921:07
openstackgerritArtom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration  https://review.opendev.org/63460521:07
openstackgerritArtom Lifshitz proposed openstack/nova master: NUMA live migration support  https://review.opendev.org/63460621:07
openstackgerritArtom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration  https://review.opendev.org/64002121:07
openstackgerritArtom Lifshitz proposed openstack/nova master: [WIP] Functional tests for NUMA live migration  https://review.opendev.org/67259521:07
artomsean-k-mooney, yeah, and for all I know it's not as much as I thought21:08
artomIt was just discouraging to find out at the end of a day of decent progress21:08
sean-k-mooneyya still you seam to be makinging good progress on the test infrastucture too21:09
artomHeh yeah, at least that part's done21:11
artomOr close to done, anyways21:11
sean-k-mooneyoh im back in shannon as of like 4 hours am i can try and test your sriov/vfio-pci thing tomorow if i get time21:11
artomI'll also need to figure out how to run the periodic resource audit *during* the migration, 'cuz that's what's left to fix21:12
artomsean-k-mooney, eh, don't sweat it, it's not urgent21:12
openstackgerritEric Fried proposed openstack/nova master: Completely remove fake_libvirt_utils.  https://review.opendev.org/64389721:14
openstackgerritEric Fried proposed openstack/nova master: Remove usused umask argument to virt.libvirt.utils.write_to_file  https://review.opendev.org/64508621:16
openstackgerritEric Fried proposed openstack/nova master: Remove write_to_file.  https://review.opendev.org/64508721:16
*** imacdonn has quit IRC21:16
*** artom has quit IRC21:17
openstackgerritsean mooney proposed openstack/nova master: Libvirt: add support for vPMU configuration.  https://review.opendev.org/67133821:37
sean-k-mooneyok so that both my pending feautre tested and ready for review. time to get somthing to eat and and relax for the evening o/21:38
*** takashin has joined #openstack-nova21:39
*** brault has joined #openstack-nova21:43
*** brault has quit IRC21:44
*** brault has joined #openstack-nova21:44
efriedmriedem: Is there a (documented?) spec freeze exception process?21:53
*** JamesBenson has quit IRC21:58
*** mchlumsky has quit IRC21:59
efrieddansmith: --^ ?22:10
*** xek has quit IRC22:12
openstackgerritmelanie witt proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware  https://review.opendev.org/50748622:17
openstackgerritmelanie witt proposed openstack/nova master: Remove "last context manager" from CellDatabases fixture  https://review.opendev.org/67260422:17
dansmithefried: I'm the wrong person to ask about process documentation22:32
dansmithefried: it has drifted over time, so it would surprise me if anything written down is accurate22:32
dansmithefried: generally it involves emailing the list, bringing it up at the meeting, and the spec cores decide on it22:32
*** slaweq has quit IRC22:45
*** tkajinam has joined #openstack-nova22:57
*** xek has joined #openstack-nova22:58
openstackgerritAdam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required  https://review.opendev.org/64456523:15
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661623:16
*** hongbin has quit IRC23:18
*** ivve has quit IRC23:25
*** rcernin has joined #openstack-nova23:30
*** JamesBenson has joined #openstack-nova23:31
*** JamesBenson has quit IRC23:35
openstackgerritMerged openstack/nova master: compute: Use source_bdms to reset attachment_ids during LM rollback  https://review.opendev.org/65280023:51
*** JamesBenson has joined #openstack-nova23:54
*** xek has quit IRC23:56
*** JamesBenson has quit IRC23:59
« Tuesday, 2019-07-23 Index Thursday, 2019-07-25 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!