| *** _hemna has joined #openstack-nova | 00:05 | |
| *** gyee has quit IRC | 00:07 | |
| *** tkajinam has quit IRC | 00:10 | |
| *** jdillaman has quit IRC | 00:37 | |
| *** jdillaman has joined #openstack-nova | 00:38 | |
| *** betherly has joined #openstack-nova | 00:42 | |
| *** betherly has quit IRC | 00:46 | |
| *** hongbin has joined #openstack-nova | 00:55 | |
| *** igordc has quit IRC | 00:55 | |
| *** _hemna has quit IRC | 00:55 | |
| *** kashyap has quit IRC | 00:57 | |
| *** eharney has quit IRC | 00:57 | |
| *** TxGirlGeek has joined #openstack-nova | 00:58 | |
| *** bbowen has quit IRC | 01:02 | |
| *** bbowen has joined #openstack-nova | 01:02 | |
| *** imacdonn has quit IRC | 01:18 | |
| *** imacdonn has joined #openstack-nova | 01:18 | |
| *** ricolin has joined #openstack-nova | 01:19 | |
| *** TxGirlGeek has quit IRC | 01:32 | |
| *** betherly has joined #openstack-nova | 01:34 | |
| *** betherly has quit IRC | 01:38 | |
| *** tbachman has quit IRC | 01:41 | |
| *** whoami-rajat has joined #openstack-nova | 01:43 | |
| *** _erlon_ has quit IRC | 01:46 | |
| *** TxGirlGeek has joined #openstack-nova | 01:50 | |
| *** TxGirlGeek has quit IRC | 01:54 | |
| *** tetsuro has joined #openstack-nova | 01:58 | |
| *** tbachman has joined #openstack-nova | 02:03 | |
| *** betherly has joined #openstack-nova | 02:15 | |
| *** tetsuro has quit IRC | 02:17 | |
| *** tetsuro has joined #openstack-nova | 02:18 | |
| *** betherly has quit IRC | 02:20 | |
| *** tbachman has quit IRC | 02:21 | |
| *** mdbooth_ has joined #openstack-nova | 02:32 | |
| *** BjoernT has joined #openstack-nova | 02:32 | |
| *** mdbooth has quit IRC | 02:35 | |
| *** BjoernT has quit IRC | 02:36 | |
| *** BjoernT has joined #openstack-nova | 02:41 | |
| *** BjoernT has quit IRC | 02:58 | |
| *** BjoernT_ has joined #openstack-nova | 02:58 | |
| *** BjoernT_ has quit IRC | 03:07 | |
| *** artom has quit IRC | 03:15 | |
| *** psachin has joined #openstack-nova | 03:28 | |
| *** betherly has joined #openstack-nova | 03:29 | |
| *** artom has joined #openstack-nova | 03:32 | |
| *** betherly has quit IRC | 03:33 | |
| *** hongbin has quit IRC | 03:45 | |
| *** betherly has joined #openstack-nova | 03:49 | |
| *** hongbin has joined #openstack-nova | 03:50 | |
| *** hongbin has quit IRC | 03:50 | |
| *** betherly has quit IRC | 03:54 | |
| *** udesale has joined #openstack-nova | 04:01 | |
| *** tetsuro has quit IRC | 04:09 | |
| *** rcernin has quit IRC | 04:13 | |
| *** rcernin has joined #openstack-nova | 04:14 | |
| *** etp has joined #openstack-nova | 04:17 | |
| *** rcernin has quit IRC | 04:20 | |
| *** etp has quit IRC | 04:24 | |
| *** etp has joined #openstack-nova | 04:25 | |
| *** etp has quit IRC | 04:26 | |
| *** etp has joined #openstack-nova | 04:27 | |
| *** betherly has joined #openstack-nova | 04:31 | |
| *** betherly has quit IRC | 04:36 | |
| *** pcaruana has joined #openstack-nova | 04:43 | |
| *** betherly has joined #openstack-nova | 04:47 | |
| *** vishwanathj has quit IRC | 04:51 | |
| *** betherly has quit IRC | 04:51 | |
| *** vishwanathj has joined #openstack-nova | 04:52 | |
| *** threestrands has quit IRC | 05:04 | |
| *** tetsuro has joined #openstack-nova | 05:05 | |
| *** Luzi has joined #openstack-nova | 05:05 | |
| *** tetsuro has quit IRC | 05:08 | |
| *** ratailor has joined #openstack-nova | 05:13 | |
| *** TxGirlGeek has joined #openstack-nova | 05:16 | |
| *** maciejjozefczyk has joined #openstack-nova | 05:27 | |
| *** TxGirlGeek has quit IRC | 05:43 | |
| *** dpawlik has joined #openstack-nova | 05:44 | |
| *** cervigni has joined #openstack-nova | 05:50 | |
| cervigni | Hello, I am struggling to set up a compute node with VGPU. I read there is support (experimental) and I am using rocky | 05:51 |
|---|---|---|
| cervigni | the set up seems fine, until nova tries to use the mdev and bombs out with this error | 05:51 |
| cervigni | vfio error: a5ddfb5b-8066-4e51-82b5-d750eecd4c58: error getting device from group 81: Input/output error | 05:54 |
| cervigni | (nova in debug mode) | 05:54 |
| cervigni | 019-07-23T05:54:05.295069Z qemu-system-x86_64: -device vfio-pci,id=hostdev0,sysfsdev=/sys/bus/mdev/devices/a5ddfb5b-8066-4e51-82b5-d750eecd4c58,bus=pci.0,addr=0x6: vfio error: a5ddfb5b-8066-4e51-82b5-d750eecd4c58: error getting device from group 81: Input/output error | 05:55 |
| cervigni | Verify all devices in group 81 are bound to vfio-<bus> or pci-stub and not already in use | 05:55 |
| *** vishwanathj has quit IRC | 05:55 | |
| cervigni | for VGPUs do I have to enable iommu and pt ? | 05:59 |
| openstackgerrit | ya.wang proposed openstack/nova-specs master: Add spec for expose-auto-converge-post-copy https://review.opendev.org/651681 | 06:08 |
| *** igordc has joined #openstack-nova | 06:08 | |
| *** jhesketh has quit IRC | 06:11 | |
| *** jhesketh has joined #openstack-nova | 06:11 | |
| *** igordc has quit IRC | 06:15 | |
| cervigni | anyone? | 06:18 |
| *** yachik1234 has joined #openstack-nova | 06:23 | |
| yachik1234 | hello | 06:23 |
| openstackgerrit | ya.wang proposed openstack/nova-specs master: Add spec for expose-auto-converge-post-copy https://review.opendev.org/651681 | 06:24 |
| openstackgerrit | ya.wang proposed openstack/nova-specs master: Add spec for expose-auto-converge-post-copy https://review.opendev.org/651681 | 06:30 |
| *** etp has quit IRC | 06:31 | |
| *** etp_ has joined #openstack-nova | 06:31 | |
| *** etp_ has quit IRC | 06:35 | |
| *** etp has joined #openstack-nova | 06:35 | |
| *** etp has quit IRC | 06:36 | |
| *** etp_ has joined #openstack-nova | 06:36 | |
| *** bhagyashris has joined #openstack-nova | 06:38 | |
| *** etp_ has quit IRC | 06:40 | |
| *** etp has joined #openstack-nova | 06:45 | |
| *** georgeakahiron has joined #openstack-nova | 06:46 | |
| *** ttsiouts has joined #openstack-nova | 06:48 | |
| *** kodama_ has joined #openstack-nova | 06:50 | |
| *** Aki-Hasegawa-27 has joined #openstack-nova | 06:51 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476 | 06:51 |
| *** NewBruce has quit IRC | 06:53 | |
| *** slaweq has joined #openstack-nova | 07:07 | |
| *** tesseract has joined #openstack-nova | 07:09 | |
| *** rpittau|afk is now known as rpittau | 07:09 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 07:20 | |
| *** zbr_ has joined #openstack-nova | 07:20 | |
| *** irclogbot_2 has quit IRC | 07:20 | |
| *** kaisers has quit IRC | 07:20 | |
| *** openstackstatus has quit IRC | 07:20 | |
| *** kaisers has joined #openstack-nova | 07:21 | |
| *** irclogbot_3 has joined #openstack-nova | 07:21 | |
| *** dansmith has quit IRC | 07:23 | |
| *** maciejjozefczyk has quit IRC | 07:23 | |
| *** francoisp has quit IRC | 07:23 | |
| *** zbr has quit IRC | 07:23 | |
| *** maciejjozefczyk_ is now known as maciejjozefczyk | 07:23 | |
| *** dansmith has joined #openstack-nova | 07:24 | |
| *** Anticimex has quit IRC | 07:24 | |
| *** beagles has quit IRC | 07:26 | |
| *** Anticimex has joined #openstack-nova | 07:29 | |
| *** ttsiouts has quit IRC | 07:42 | |
| *** ttsiouts has joined #openstack-nova | 07:43 | |
| *** ttsiouts has quit IRC | 07:48 | |
| *** avolkov has joined #openstack-nova | 07:58 | |
| *** priteau has joined #openstack-nova | 08:00 | |
| *** Aki-Hasegawa-27 has quit IRC | 08:13 | |
| *** mkrai_ has joined #openstack-nova | 08:19 | |
| *** betherly has joined #openstack-nova | 08:20 | |
| *** ivve has joined #openstack-nova | 08:22 | |
| *** ttsiouts has joined #openstack-nova | 08:22 | |
| *** ralonsoh has joined #openstack-nova | 08:26 | |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: WIP: Report PCPU to placement https://review.opendev.org/672221 | 08:26 |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: WIP: Virt driver: Build guest xml https://review.opendev.org/672222 | 08:26 |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: WIP: Add scheduler request filter to alias cpu_policy https://review.opendev.org/672223 | 08:26 |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: WIP Upgrade patch to handle PCPU resource https://review.opendev.org/672224 | 08:26 |
| *** tssurya has joined #openstack-nova | 08:28 | |
| *** panda has quit IRC | 08:38 | |
| *** panda has joined #openstack-nova | 08:38 | |
| bhagyashris | stephenfin, : Hi, I have uploaded patches to implement Standardize CPU resource tracking spec ^ . I would like you insights on it. | 08:41 |
| bhagyashris | your* | 08:41 |
| *** cervigni has quit IRC | 08:42 | |
| openstackgerrit | sahid proposed openstack/nova master: cellv2: make update_cell to support cell0 https://review.opendev.org/672045 | 08:46 |
| *** ileixe has quit IRC | 08:49 | |
| *** sapd1_x has joined #openstack-nova | 08:55 | |
| *** priteau has quit IRC | 09:00 | |
| *** jangutter has quit IRC | 09:01 | |
| *** priteau has joined #openstack-nova | 09:02 | |
| *** betherly has quit IRC | 09:11 | |
| *** _hemna has joined #openstack-nova | 09:12 | |
| stephenfin | bhagyashris: https://review.opendev.org/#/c/672106/1 | 09:14 |
| stephenfin | I can take a look but I do have a good chunk of that done now | 09:15 |
| *** _hemna has quit IRC | 09:16 | |
| stephenfin | Should probably look to combine them | 09:17 |
| bhagyashris | stephenfin: Sorry for the late but I was covering maximum points that's why its took time to upload the patches | 09:18 |
| stephenfin | Yup, np. Will be interesting compare the two approaches | 09:19 |
| *** psachin has quit IRC | 09:20 | |
| bhagyashris | stephenfin: ok thank you :) | 09:22 |
| stephenfin | bhagyashris: Probably worth looking through mine while I do the same for yours | 09:23 |
| stephenfin | I see you've done the reshape stuff, which I was still working on, though I managed to avoid doing InstanceNUMATopology changes which might be something you could copy | 09:23 |
| stephenfin | I imagine we'll end up taking bits from one and adding it to the other, fwiw :) | 09:23 |
| *** jangutter has joined #openstack-nova | 09:26 | |
| *** ociuhandu has joined #openstack-nova | 09:31 | |
| bhagyashris | stephenfin: ok. Yeah and the patches I have uploaded are full working now including the upgrade | 09:32 |
| bhagyashris | stephenfin: I haven't gone through your patches I will take look on it | 09:32 |
| *** cdent has joined #openstack-nova | 09:33 | |
| *** psachin has joined #openstack-nova | 09:35 | |
| *** georgeakahiron has quit IRC | 09:40 | |
| *** kodama_ has quit IRC | 09:43 | |
| *** jojoda has quit IRC | 09:45 | |
| openstackgerrit | **** proposed openstack/nova master: Nova: node should be deleted when last service is deleted https://review.opendev.org/671731 | 09:46 |
| *** betherly has joined #openstack-nova | 09:46 | |
| *** ociuhandu has quit IRC | 09:48 | |
| *** ociuhandu has joined #openstack-nova | 09:50 | |
| *** jaosorior has joined #openstack-nova | 09:52 | |
| *** bhagyashris has quit IRC | 09:54 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove deprecated Core/Ram/DiskFilter https://review.opendev.org/672065 | 10:00 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove deprecated CPU, RAM, disk claiming in resource tracker https://review.opendev.org/551026 | 10:00 |
| *** dpawlik has quit IRC | 10:02 | |
| *** dpawlik has joined #openstack-nova | 10:03 | |
| *** ttsiouts has quit IRC | 10:11 | |
| *** ttsiouts has joined #openstack-nova | 10:12 | |
| *** traskat has quit IRC | 10:13 | |
| *** kashyap has joined #openstack-nova | 10:13 | |
| *** ttsiouts has quit IRC | 10:16 | |
| openstackgerrit | **** proposed openstack/nova master: Nova: node should be deleted when last service is deleted https://review.opendev.org/671731 | 10:20 |
| *** lpetrut has joined #openstack-nova | 10:21 | |
| *** brinzhang_ has joined #openstack-nova | 10:26 | |
| *** brinzhang has quit IRC | 10:30 | |
| *** ricolin_ has joined #openstack-nova | 10:34 | |
| *** bbowen has quit IRC | 10:37 | |
| *** ricolin has quit IRC | 10:37 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.virt.driver.ComputeDriver.estimate_instance_overhead' https://review.opendev.org/672106 | 10:44 |
| *** mkrai_ has quit IRC | 10:45 | |
| *** tbachman has joined #openstack-nova | 10:46 | |
| *** luksky11 has joined #openstack-nova | 10:47 | |
| *** luksky123 has joined #openstack-nova | 10:48 | |
| *** luksky11 has quit IRC | 10:52 | |
| *** tbachman has quit IRC | 11:06 | |
| *** zhouyao has joined #openstack-nova | 11:10 | |
| openstackgerrit | **** proposed openstack/nova master: Nova: node should be deleted when last service is deleted https://review.opendev.org/671731 | 11:14 |
| *** jaypipes has joined #openstack-nova | 11:14 | |
| zhouyao | @Chris Friesen May i ask you if you still focusing on this patch? https://review.opendev.org/#/c/621646 | 11:15 |
| *** sean-k-mooney has joined #openstack-nova | 11:20 | |
| *** spatel has joined #openstack-nova | 11:20 | |
| *** zhouyao has quit IRC | 11:21 | |
| *** spatel has quit IRC | 11:25 | |
| *** ttsiouts has joined #openstack-nova | 11:30 | |
| *** b3nt_pin has joined #openstack-nova | 11:35 | |
| *** shilpasd has joined #openstack-nova | 11:54 | |
| *** bbowen has joined #openstack-nova | 11:55 | |
| *** markvoelker has quit IRC | 11:58 | |
| *** eharney has joined #openstack-nova | 12:01 | |
| *** udesale has quit IRC | 12:04 | |
| *** udesale has joined #openstack-nova | 12:04 | |
| *** ricolin_ is now known as ricolin | 12:05 | |
| *** etp has quit IRC | 12:11 | |
| *** markvoelker has joined #openstack-nova | 12:16 | |
| *** ttsiouts has quit IRC | 12:17 | |
| *** ttsiouts has joined #openstack-nova | 12:17 | |
| *** sean-k-mooney1 has joined #openstack-nova | 12:22 | |
| *** ttsiouts has quit IRC | 12:22 | |
| *** ccamacho has joined #openstack-nova | 12:22 | |
| *** sean-k-mooney has quit IRC | 12:25 | |
| *** francoisp has joined #openstack-nova | 12:29 | |
| openstackgerrit | dzogchen proposed openstack/nova master: Nova: node should be deleted when last service is deleted https://review.opendev.org/671731 | 12:35 |
| openstackgerrit | Josephine Seifert proposed openstack/nova-specs master: Spec for the Nova part of Image Encryption https://review.opendev.org/608696 | 12:37 |
| *** mriedem has joined #openstack-nova | 12:38 | |
| *** luksky123 has quit IRC | 12:39 | |
| *** ratailor has quit IRC | 12:46 | |
| *** efried_pto is now known as efried | 12:49 | |
| openstackgerrit | Merged openstack/python-novaclient master: Update api-ref location https://review.opendev.org/672135 | 12:55 |
| efried | sean-k-mooney1: alex_xu: Care to re-ack https://review.opendev.org/#/c/651681/ please? | 12:56 |
| *** zhouyao has joined #openstack-nova | 12:57 | |
| efried | alex_xu: Please don't +W -- we need a non-Intel core to do that. (mriedem, bauzas, and johnthetubaguy have all had hands on this previously) | 12:57 |
| efried | mriedem: Since gibi_off is _off for 2w, I'm going to propose the change to consts for https://review.opendev.org/#/c/668925/ as a fup so we can merge it, cool? | 12:59 |
| efried | Unless you think it's okay to make the change there and fast approve? | 12:59 |
| mriedem | efried: wfm | 13:01 |
| mriedem | the fup i mean | 13:01 |
| bauzas | efried: I can look | 13:03 |
| bauzas | like I said, I already reviewed it | 13:03 |
| cdent | I can never remember this: what, if anything, is the special magic to force a migration to a specific host/az? | 13:04 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Consts for need_healing https://review.opendev.org/672284 | 13:05 |
| efried | mriedem: ^ | 13:05 |
| efried | cdent: the old way or the new way? | 13:05 |
| efried | API or CLI? | 13:06 |
| jroll | when adding a new compute host, is there a way to bring it on disabled for scheduling, until we can go set up aggregates and such? | 13:06 |
| cdent | efried: CLI, ocata-ish | 13:06 |
| bauzas | cdent: live-migrate --host ? | 13:06 |
| efried | jroll: for new code or old? | 13:06 |
| jroll | efried: ocata and rocky :| | 13:07 |
| bauzas | cdent: for a specific AZ, you need to first asking for an AZ when creating the instance | 13:07 |
| bauzas | (or using the default_az option) | 13:07 |
| cdent | bauzas: yeah, in this case the issue is that by some unknown series of events the instance is in an AZ that no longer exists, so forcing it out of that one is desired | 13:07 |
| cdent | s/in/started in/ | 13:07 |
| mriedem | https://docs.openstack.org/nova/latest/user/aggregates.html#implications-for-moving-servers | 13:08 |
| mriedem | https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#server-migrate | 13:09 |
| mriedem | openstack server migrate --live | 13:09 |
| mriedem | *openstack server migrate --live <host> will by default forcefully live migrate the server to the specified host and bypass the scheduler | 13:10 |
| efried | jroll: mriedem was just in this code. I suspect with his new feature you could create the provider and tagg it with COMPUTE_STATUS_DISABLED before adding it to the service. But prior to that... I'm not sure. | 13:10 |
| cdent | mriedem: thanks, i was in the first link (been there many times, it seems) | 13:10 |
| mriedem | cdent: what i'm not sure about is if, on ocata, the forced live migration will update the az in the request spec (probably not) and it might not update the az on the instance record either | 13:10 |
| mriedem | cdent: i wrote it for you :) | 13:10 |
| * cdent feels blessed | 13:10 | |
| mriedem | if the az is gone you're kind of in manual db surgery area, at least on ocata | 13:11 |
| cdent | yeah, I figured that and already passed that along | 13:11 |
| mriedem | there was a newer bug fix to not allow deleting an az that had instances in it, but that's not on ocata | 13:11 |
| mriedem | there is also a blueprint in train to allow changing the az on unshelve | 13:11 |
| mriedem | but that won't help you in ocata either | 13:12 |
| jroll | efried: cool, thanks | 13:12 |
| cdent | mriedem: and what about queens? | 13:13 |
| cdent | any diff? | 13:13 |
| * cdent is in a sea of many different version numbers and names | 13:13 | |
| efried | bauzas: Thanks. If it's acceptable, could you please +A? | 13:16 |
| stephenfin | dansmith: You're going to hate this, but can we do this? http://paste.openstack.org/show/754754/ | 13:16 |
| stephenfin | And I mean just that | 13:17 |
| tssurya | jroll: for the old code if you have the ComputeFilter enabled it will automatically filter out disabled computes | 13:17 |
| openstackgerrit | sahid proposed openstack/nova master: cellv2: fix update_cell to support cell0 https://review.opendev.org/672045 | 13:17 |
| tssurya | as long as you don't have the "max_placement_results" set | 13:17 |
| *** ttsiouts has joined #openstack-nova | 13:17 | |
| jroll | tssurya: right, but I want the computes to join the cluster disabled, to remove a race condition where they could get a VM scheduled before we can disable them or configure them properly | 13:18 |
| tssurya | jroll: ah ok understood | 13:18 |
| jroll | :) | 13:19 |
| stephenfin | dansmith: I _think_ that with that change, we'll still be storing the same JSON-ified representation of the object in any database fields, only now we get the automatic conversion back to the object instead of having to remember to do it manually | 13:19 |
| mriedem | cdent: the bug fix to prevent deleting an az with servers in it might have been backported to queens, i can check | 13:21 |
| mriedem | but the unshelve to a new az thing is a new feature so wouldn't be backported (and isn't merged yet anyway) | 13:21 |
| *** openstackstatus has joined #openstack-nova | 13:21 | |
| *** ChanServ sets mode: +v openstackstatus | 13:21 | |
| cdent | mriedem: thanks. the deleting the az bug isn't an immediate concern | 13:22 |
| efried | bauzas: If you're in a spec approving mood, would you mind hitting https://review.opendev.org/#/c/608696/ (nova part of image encryption) as well please? | 13:22 |
| *** shilpasd has quit IRC | 13:22 | |
| mriedem | cdent: ok, looks like it only went back to rocky anyway https://review.opendev.org/#/q/Ic27195e46502067c87ee9c71a811a3ca3f610b73 | 13:23 |
| bauzas | efried: opening another tab | 13:25 |
| efried | melwitt, lyarwood, mdbooth_: Could we get a comeback on https://review.opendev.org/#/c/658903/ (RBD image up/download spec) please? | 13:26 |
| openstackgerrit | Merged openstack/nova master: Update AZ admin doc to mention the new way to specify hosts https://review.opendev.org/666767 | 13:28 |
| *** davidsha has joined #openstack-nova | 13:28 | |
| efried | stephenfin: gibi is +2 on https://review.opendev.org/#/c/641670/ (unaddressed port spec) -- looks like you're the man to send it? | 13:29 |
| efried | jangutter: sean-k-mooney1: are you happy with ^ at this point? | 13:30 |
| jangutter | efried: no objections from me. I'm pretty sure any security concerns can be sorted during implementation. | 13:31 |
| stephenfin | efried: Yup, I'll get to that before EOD | 13:31 |
| efried | donkey jangutter | 13:31 |
| efried | thanks stephenfin | 13:31 |
| jangutter | buy a donkey you too efried | 13:32 |
| mriedem | cdent: just fyi https://review.opendev.org/#/q/I9f73c237923fdcbf4096edc5aedd2c968d4b893e was backported which updates the instance az during live migration but that still doesn't update the request spec az, which is the key thing since that's what will be used when you run the server through the scheduler to move it later (if not forced) | 13:35 |
| mriedem | and if the request spec az is referencing something that's gone, and the az filter is enabled, the scheduler will novalidhost the move | 13:36 |
| cdent | thanks mriedem | 13:36 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.virt.driver.ComputeDriver.estimate_instance_overhead' https://review.opendev.org/672106 | 13:36 |
| mriedem | so, recovery is likely: (1) force live migrate the server to some new host in a new az and then (2) manuall update the request spec az for the instance in the api db | 13:36 |
| mriedem | note the request spec is a json blob in the db as well...so that's fun | 13:36 |
| mriedem | i've got to run to an appointment, will be back on in a bit | 13:37 |
| *** mriedem has quit IRC | 13:38 | |
| *** mkrai_ has joined #openstack-nova | 13:43 | |
| openstackgerrit | Merged openstack/nova-specs master: Add spec for expose-auto-converge-post-copy https://review.opendev.org/651681 | 13:45 |
| openstackgerrit | Merged openstack/nova-specs master: Boot a VM with an unaddressed port https://review.opendev.org/641670 | 13:46 |
| *** zhouyao has quit IRC | 13:47 | |
| efried | stephenfin: If you agree https://review.opendev.org/#/c/672077/3/README.rst needs to be changed, I can fix it real quick and we can tag-team it? | 13:48 |
| efried | uh, actually, I'm not sure what that should be changed to tbh | 13:48 |
| stephenfin | efried: Drop it | 13:48 |
| stephenfin | and yes | 13:48 |
| dansmith | stephenfin: yeah you can't do that because it'll break rpc | 13:48 |
| dansmith | stephenfin: but no, compute node won't auto serialize that to json, you have to make it do that | 13:49 |
| stephenfin | Oh yeah. Duh | 13:50 |
| stephenfin | Proxy field it is | 13:50 |
| stephenfin | Also, what's horrible about bumping a major version again? | 13:50 |
| stephenfin | *major object version | 13:50 |
| stephenfin | I recall we bumped the Instance object and said never again, but I don't know why never again | 13:50 |
| dansmith | stephenfin: it's not too terrible, but it is a little complicated. instance was the most complicated object, but I don't think we said never again, | 13:51 |
| dansmith | it's just that it needs to be worth it | 13:51 |
| *** Luzi has quit IRC | 13:51 | |
| efried | (stephenfin nm, there's no replacement for the landing page yet, I +Wed) | 13:51 |
| dansmith | stephenfin: compute node would probably be much less annoying because of how limited its use is.. i.e. we don't send compute node objects all around to every node like we do instance, | 13:52 |
| dansmith | it's mostly just the compute and conductor that have to touch them | 13:52 |
| stephenfin | Yeah, that's the one I'm most interested in | 13:52 |
| stephenfin | I think I'll wait til os-hypervisors is talking to placement instead of consuming the xxx_usage fields from ComputeNode first though | 13:53 |
| stephenfin | So we can remove those while we're at it | 13:53 |
| stephenfin | (Assuming that ends up being possible) | 13:53 |
| dansmith | the point being to objectify that field, right? why is that a thing now vs. before? Because you're adding stuff to that field or something? | 13:53 |
| *** ttsiouts has quit IRC | 13:53 | |
| dansmith | stephenfin: that sounds like a good idea | 13:53 |
| dansmith | an object change for one field type is less good, but deprecating unused fields with that change is more meaty | 13:54 |
| *** ttsiouts has joined #openstack-nova | 13:54 | |
| *** yachik1234 has quit IRC | 13:55 | |
| stephenfin | dansmith: Mostly because it wasn't initially obvious and led to me being bitten by it | 13:55 |
| stephenfin | I am tackling it at in a more piecemeal fashion with https://review.opendev.org/#/c/671799/3 and the two preceding patches though | 13:55 |
| stephenfin | moving the calls to convert the string to an object (and vice versa) close to where the field is actually read/set | 13:55 |
| stephenfin | tl;dr: hardware.py is nasty | 13:55 |
| *** ttsiouts has quit IRC | 13:58 | |
| *** ttsiouts has joined #openstack-nova | 13:58 | |
| *** lbragstad has joined #openstack-nova | 14:00 | |
| *** rpittau is now known as rpittau|afk | 14:03 | |
| dansmith | stephenfin: I don't want to nitpick your reno to death, but I do think it's important to note that the change it is describing happened quite a while ago, instead of implying that as of train, something is different | 14:05 |
| dansmith | also happy to edit it myself if you want | 14:05 |
| stephenfin | wrt to which patch now? | 14:05 |
| stephenfin | Sure, suits me :) | 14:05 |
| stephenfin | Assume you mean https://review.opendev.org/#/c/672065/ ? | 14:06 |
| dansmith | yeah | 14:06 |
| stephenfin | Yeah, go for it. Think mriedem made a similar comment when it was part of the claims patch | 14:06 |
| *** tbachman has joined #openstack-nova | 14:07 | |
| dansmith | yeah, that feedback didn't seem to make the jump, but it's hard to tell because I can't diff revs now | 14:08 |
| stephenfin | I changed 'is now' to 'is' and changed the wording of the libvirt section | 14:08 |
| dansmith | heh | 14:08 |
| stephenfin | Was going to state that it's performed natively in placement since X, but I couldn't determine fully when X was. Thought it was Ocata but mriedem referenced Pikle | 14:09 |
| stephenfin | *Pike | 14:09 |
| dansmith | stephenfin: so, matt's comment was that none of the virt specific stuff belongs in that reno, but in admin docs | 14:13 |
| stephenfin | Oh, I misread that /o\ | 14:13 |
| *** tssurya has quit IRC | 14:13 | |
| stephenfin | I thought he was saying the reno was fine but the admin docs should be additional | 14:13 |
| *** belmoreira has joined #openstack-nova | 14:14 | |
| dansmith | well I guess maybe | 14:14 |
| dansmith | here's the thing though: | 14:14 |
| dansmith | these filters would be conflicting with placement since pike | 14:14 |
| dansmith | meaning, they should have been disabled since then, and they warn at startup if enabled | 14:14 |
| dansmith | *that* is when this virt overhead change happened, not now | 14:15 |
| stephenfin | Fair point | 14:15 |
| dansmith | so putting it in a reno for train makes it sound like that behavior is now changing, but it is not | 14:15 |
| stephenfin | Strip it out so? | 14:15 |
| dansmith | so that's why *I* want it not in a reno :) | 14:15 |
| stephenfin | I have the important bits noted at https://review.opendev.org/#/c/672065/2/api-ref/source/parameters.yaml and https://review.opendev.org/#/c/672065/2/doc/source/admin/configuration/schedulers.rst@1355 I think | 14:15 |
| stephenfin | the latter being more importnat | 14:15 |
| stephenfin | *important | 14:15 |
| dansmith | yeah, so I'll strip it out and add some more words to this, and then go hunting for a place to maybe explain it in a generalized way or something | 14:15 |
| dansmith | stephenfin: oh, yeah, that second bit is perfect | 14:16 |
| dansmith | so I think we can just strip this out of the reno then | 14:16 |
| stephenfin | Sounds good to me | 14:16 |
| stephenfin | Happy to do that or will I? | 14:16 |
| dansmith | I have it open already | 14:16 |
| stephenfin | (y) | 14:17 |
| stephenfin | In that case, I've two references to config options in that second bit that should probably do with the ':oslo.config:option:' role, but as a nice-to-have | 14:18 |
| dansmith | can you barf up the rst for me to link to that schedulers section? | 14:19 |
| *** mkrai_ has quit IRC | 14:19 | |
| *** gyee has joined #openstack-nova | 14:23 | |
| dansmith | hmm, maybe i just use the full link? I thought there was a shortcut | 14:23 |
| stephenfin | To the section I added? | 14:24 |
| stephenfin | You need to add an anchor before the title and then you can use the :ref: role, assuming it's within the same doc build | 14:25 |
| stephenfin | so add e.g. '.. _hypervisor-specific-considerations:' | 14:25 |
| stephenfin | then reference wherever you want with ':ref:`hypervisor-specific-considerations`' | 14:26 |
| stephenfin | or https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#hypervisor-specific-considerations if it's from a reno or something | 14:27 |
| dansmith | ack was just piecing that together from mah grepping | 14:27 |
| dansmith | I have to re-learn this every damn time | 14:27 |
| dansmith | stephenfin: er, I don't see any other :ref: usage in the renos.. are renos in the same build as the other docs? | 14:28 |
| stephenfin | You've to use a URL there | 14:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: experiment with GreenThread passthrough https://review.opendev.org/672299 | 14:28 |
| stephenfin | because they're a different build | 14:29 |
| dansmith | right okay, but the anchor makes it #able yeah? | 14:29 |
| stephenfin | Yup | 14:29 |
| dansmith | stephenfin: aren't you glad I'm saving you time by doing this myself? :P | 14:29 |
| stephenfin | Very :) | 14:29 |
| dansmith | haha | 14:29 |
| stephenfin | Here's another example, fwiw https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios | 14:29 |
| stephenfin | That should have an anchor in the rST | 14:29 |
| dansmith | that's the one I was copying yeah | 14:30 |
| stephenfin | though interestingly that has no anchor | 14:30 |
| dansmith | it does | 14:31 |
| dansmith | oh no, | 14:31 |
| dansmith | that one was auto from the heading I think | 14:31 |
| dansmith | I found another one though | 14:31 |
| dansmith | capabilities-as-traits is what I copied | 14:31 |
| stephenfin | Ah yeah, the auto from the heading behavior isn't the default, I thought | 14:31 |
| stephenfin | Might be a thing we do in openstackdocstheme | 14:31 |
| stephenfin | Or not, idk. Doesn't matter. capabilities-as-traits is good | 14:32 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use OpenStack SDK for placement https://review.opendev.org/656023 | 14:34 |
| *** mriedem has joined #openstack-nova | 14:36 | |
| sean-k-mooney1 | stephenfin: the headings are automaticaly referenceable via the css selector | 14:37 |
| sean-k-mooney1 | its thte content list or what ever we use that arnt | 14:37 |
| *** sean-k-mooney1 is now known as sean-k-mooney | 14:37 | |
| dansmith | stephenfin: I'm going to address my other nit I just commented as well | 14:39 |
| *** mlavalle has joined #openstack-nova | 14:40 | |
| *** lbragstad has quit IRC | 14:40 | |
| *** dosaboy has joined #openstack-nova | 14:41 | |
| dansmith | and your comment on the config option | 14:42 |
| stephenfin | coolness | 14:43 |
| *** lbragstad has joined #openstack-nova | 14:43 | |
| * aspiers is back | 14:47 | |
| *** _hemna has joined #openstack-nova | 14:47 | |
| aspiers | sean-k-mooney: I'm about to review your https://review.opendev.org/#/c/670189/ - thanks for working on that | 14:48 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Remove deprecated Core/Ram/DiskFilter https://review.opendev.org/672065 | 14:49 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Remove deprecated CPU, RAM, disk claiming in resource tracker https://review.opendev.org/551026 | 14:49 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Remove 'nova.virt.driver.ComputeDriver.estimate_instance_overhead' https://review.opendev.org/672106 | 14:49 |
| sean-k-mooney | aspiers: nice to see you around again. and i need it for my own stuff too so its not entily un selfish :) | 14:50 |
| *** _hemna has quit IRC | 14:52 | |
| *** TxGirlGeek has joined #openstack-nova | 14:52 | |
| aspiers | sean-k-mooney: :) | 14:56 |
| aspiers | sean-k-mooney: I am not sure why I thought that defaulting to q35 would be OK :-/ | 14:56 |
| mriedem | ralonsoh: jangutter: efried: stephenfin: i'm late but have some concerns in https://review.opendev.org/#/c/641670/ that should be addressed | 15:02 |
| efried | mriedem: should I unapprove the bp? | 15:03 |
| mriedem | efried: probably not right now | 15:03 |
| efried | k | 15:03 |
| efried | mriedem: if you're in a spec reviewing mood, this one could use some love https://review.opendev.org/#/c/608696/ | 15:03 |
| ralonsoh | mriedem, I'll check your comments today | 15:04 |
| mriedem | efried: i'm not really | 15:05 |
| mriedem | i just saw that one was merged and short | 15:05 |
| *** mkrai_ has joined #openstack-nova | 15:06 | |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.opendev.org/602432 | 15:10 |
| stephenfin | efried: It looks like we've gone from zero to two implementations of the cpu-resources spec in less than a week \o/ | 15:14 |
| stephenfin | I'm working on comparing and likely merging the two, but I'd like your thoughts on this particular difference of implementation when you can https://review.opendev.org/#/c/672223/ and https://review.opendev.org/#/c/671801/ | 15:15 |
| stephenfin | They're the two patches to convert legacy 'hw:cpu_(thread_)policy' extra specs to PCPU requests and they've taken very different approaches. I can't decide which one I prefer | 15:16 |
| *** trident has quit IRC | 15:18 | |
| *** belmoreira has quit IRC | 15:18 | |
| *** _hemna has joined #openstack-nova | 15:18 | |
| stephenfin | TIL '(x or y) in foo' is a valid Python statement | 15:20 |
| *** trident has joined #openstack-nova | 15:20 | |
| *** ccamacho has quit IRC | 15:21 | |
| * stephenfin would have expected that to render as result of the 'x or y' (True) in 'foo' (so 'True in foo') | 15:21 | |
| *** dpawlik has quit IRC | 15:30 | |
| stephenfin | Actually, it does (thank ralonsoh) | 15:30 |
| stephenfin | >>> (0 or None) in [0] | 15:30 |
| stephenfin | False | 15:30 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Convert nova-next to a zuul v3 job https://review.opendev.org/670196 | 15:33 |
| mriedem | is there a follow up needed for surya's spec here https://review.opendev.org/#/c/636132/ ? before digging into the code series i was going to go over the spec again but don't really want to if it's a mess that needs an update. | 15:38 |
| *** david-lyle is now known as dklyle | 15:40 | |
| *** sean-k-mooney1 has joined #openstack-nova | 15:44 | |
| *** sapd1_x has quit IRC | 15:44 | |
| stephenfin | sean-k-mooney: Question: do we want to allow users to request 'resources:VCPU' or 'resources:PCPU' in their flavor extra specs? | 15:44 |
| stephenfin | as opposed to 'hw:cpu_policy=dedicated' and whatever the new mask option to allow instances with both types of CPU ends up being | 15:44 |
| stephenfin | or in addition to, I should say | 15:44 |
| openstackgerrit | Merged openstack/nova master: Translatable output strings in heal allocation https://review.opendev.org/668925 | 15:46 |
| *** sean-k-mooney has quit IRC | 15:46 | |
| *** trident has quit IRC | 15:52 | |
| *** _hemna has quit IRC | 15:53 | |
| *** jaosorior has quit IRC | 15:53 | |
| *** ttsiouts has quit IRC | 15:54 | |
| *** ttsiouts has joined #openstack-nova | 15:55 | |
| *** trident has joined #openstack-nova | 15:55 | |
| *** ttsiouts_ has joined #openstack-nova | 15:57 | |
| *** ttsiouts has quit IRC | 15:57 | |
| efried | stephenfin: you may be expecting too much of me wrt those PCPU impls, but I'll do what I can. | 15:59 |
| stephenfin | That's all I can ask (y) | 15:59 |
| *** ttsiouts_ has quit IRC | 15:59 | |
| stephenfin | They both "work", I'm more interested in which approach is preferable | 16:00 |
| efried | stephenfin: also, to answer "do we want to allow users to request 'resources:VCPU' or 'resources:PCPU' in their flavor extra specs?" -- I think we need to *allow* it, because downstream thingies are going to want to override the meanings of the RCs for things like frequency/priority (per ptg direction) -- | 16:01 |
| efried | but we should definitely *support* (and encourage as the primary usage) flavor-ese lingo translated by request_filter to placement-ese. | 16:01 |
| stephenfin | Aye, so allow it unless the 'hw:cpu_policy' extra spec/image meta prop is present | 16:02 |
| stephenfin | In which case we spit the dummy out? | 16:02 |
| *** sean-k-mooney1 has quit IRC | 16:07 | |
| *** tesseract has quit IRC | 16:07 | |
| mriedem | efried: dansmith: melwitt: you were all +2 on the spec for https://review.opendev.org/#/c/645611/ so i might be off base on my comments, | 16:18 |
| mriedem | nothing major but i'm not sure why the driver even needs to implement this | 16:18 |
| dansmith | mriedem: what do you mean? | 16:18 |
| *** lpetrut has quit IRC | 16:19 | |
| dansmith | why we're plumbing this to the driver instead of just telling the compute about the change? | 16:19 |
| mriedem | all the virt driver does is set the values on the instance and save them to the db, | 16:20 |
| mriedem | which is what stop/start_instance in the compute manager does for normal stop/start, | 16:20 |
| mriedem | so why not just do the db updates in the compute manager code rather than muck with driver plumbing | 16:20 |
| mriedem | just seems weird to me, | 16:20 |
| mriedem | if it's "we don't want non-ironic drivers to do this" then add a driver capability flag | 16:21 |
| dansmith | mriedem: compute start/stop will call the driver and tell it what to do right? | 16:21 |
| mriedem | to actually power on / off a guest yeah | 16:21 |
| mriedem | this is just db muckery | 16:21 |
| dansmith | the point of this is to decide what needs to happen when some external change happens to the instance, just like how libvirt gets direct events | 16:21 |
| dansmith | the point being, ironic needs to know this should be swallowed and the db updated, | 16:22 |
| mriedem | none of that logic is in the actual driver | 16:22 |
| dansmith | but that's not necessarily what should happen for vmware | 16:22 |
| openstackgerrit | Merged openstack/nova master: Update api-ref location https://review.opendev.org/672077 | 16:22 |
| mriedem | ok i guess "it's just a simple abstraction" is the answer then | 16:22 |
| dansmith | remember the first version of this *did* just call start/top, | 16:22 |
| mriedem | i don't expect any other drivers to ever implement this, but i guess it's generic enough that they could | 16:23 |
| dansmith | but had a "don't actually call the virt driver=True" if we're ironic | 16:23 |
| dansmith | so the change to delgate "what should I do with this external change?" to the driver was to make that cleaner | 16:23 |
| mriedem | yeah i agree that was gross | 16:23 |
| dansmith | didn't we discuss all this during spec review? | 16:23 |
| dansmith | I thought you were involved with that | 16:23 |
| mriedem | not really | 16:23 |
| mriedem | that's why i asked earlier in here if the spec was going to be updated so i could sanely read it before reviewing the code | 16:24 |
| mriedem | but i just dove in anyway | 16:24 |
| dansmith | okay you did review it at one point, but I see not in the later revs | 16:24 |
| mriedem | anyway, that's fine when you explain it that way | 16:24 |
| dansmith | okay | 16:24 |
| *** davidsha has quit IRC | 16:32 | |
| *** ricolin has quit IRC | 16:34 | |
| *** jamesdenton has quit IRC | 16:36 | |
| *** jamesdenton has joined #openstack-nova | 16:36 | |
| *** mkrai_ has quit IRC | 16:44 | |
| efried | mriedem, dansmith: what's your take on the race condition & lock? Add it to the code, or take it out of the spec? | 16:45 |
| mriedem | lock.... | 16:47 |
| mriedem | the api is validating the vm/task/power state right? | 16:47 |
| mriedem | and the compute manager is making the change | 16:47 |
| efried | mriedem: The concern I raised top-level, which was apparently also discussed in the spec. | 16:47 |
| efried | that we could start the power sync before the event hits | 16:47 |
| mriedem | if the sync task runs it would call api.stop() which would set the task_state and then the event should be ignored, | 16:48 |
| mriedem | but there could be a window where we passed the event from the api to compute before compute calls api.stop | 16:49 |
| mriedem | the task_state is generally our lock for stuff, i.e. the task state ignores instances with a non-None task_state | 16:49 |
| mriedem | i'm not sure how you're going to impose a lock otherwise, unless you lock on the instance uuid in the compute manager or something | 16:49 |
| *** betherly has quit IRC | 16:49 | |
| mriedem | note that stop_instance in compute manager already locks on instance uuid | 16:50 |
| efried | I'm okay accepting the risk, but it should probably be noted in a code comment. | 16:50 |
| *** jaypipes has quit IRC | 16:54 | |
| openstackgerrit | dzogchen proposed openstack/nova master: Nova: node should be deleted when nova-compute is removed https://review.opendev.org/671731 | 16:54 |
| mriedem | efried: i left a comment in the code, | 16:56 |
| mriedem | i *think* if we lose a race somewhere, chances are one of the threads is going to fail with UnexpectedTaskStateError | 16:56 |
| efried | thanks | 16:56 |
| mriedem | which is maybe ok - worst case is the node gets powered off when it shouldn't be, which is the original bug she's trying to fix right? | 16:56 |
| mriedem | some lab monkey powered on the box when nova thinks it's off | 16:57 |
| mriedem | so nova's task shuts it off | 16:57 |
| mriedem | fwiw i think we also have races with the existing sync task and the libvirt lifecycle event callback stuff which is why we have a workaround option to ignore those | 16:57 |
| mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#workarounds.handle_virt_lifecycle_events | 16:58 |
| efried | right, so like, fixing that bug is the whole reason this patch exists. So if we're leaving that bug open -- even if we're drastically reducing the probability -- we need to own that somehow. | 16:59 |
| *** udesale has quit IRC | 17:03 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove super old unnecessary TODO from API start() method https://review.opendev.org/672330 | 17:05 |
| *** trident has quit IRC | 17:07 | |
| *** trident has joined #openstack-nova | 17:10 | |
| *** priteau has quit IRC | 17:11 | |
| *** ociuhandu has quit IRC | 17:13 | |
| *** sean-k-mooney has joined #openstack-nova | 17:21 | |
| *** efried has quit IRC | 17:23 | |
| *** _erlon_ has joined #openstack-nova | 17:25 | |
| *** efried has joined #openstack-nova | 17:27 | |
| sean-k-mooney | lyarwood: mriedem: can ye add this depercation warning backport to your review queue https://review.opendev.org/#/c/671532/ | 17:32 |
| *** mdbooth_ has quit IRC | 17:33 | |
| *** ralonsoh has quit IRC | 17:36 | |
| mriedem | sean-k-mooney: done | 17:39 |
| mriedem | note that issue is also in cinder | 17:40 |
| mriedem | i'll add cinder to the bug | 17:40 |
| efried | artom, mriedem: Why is https://review.opendev.org/#/c/668631/ (pass migration to finish_revert_migration) on top of https://review.opendev.org/#/c/670393/ (func test for crash of same)? | 17:42 |
| efried | Are we making sure the former doesn't change any of the (broken) behavior demonstrated by the latter? | 17:42 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Rename 'nova.objects.instance_numa_topology' https://review.opendev.org/671789 | 17:42 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary try-catch around 'getCPUMap' https://review.opendev.org/671790 | 17:42 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.opendev.org/537414 | 17:42 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: claims: Remove useless caching https://review.opendev.org/671791 | 17:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option https://review.opendev.org/671792 | 17:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793 | 17:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rename exception argument https://review.opendev.org/671795 | 17:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove unused function parameter https://review.opendev.org/671796 | 17:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance' https://review.opendev.org/671797 | 17:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host' https://review.opendev.org/671798 | 17:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance' https://review.opendev.org/671799 | 17:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800 | 17:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support translating CPU policy extra specs, image meta https://review.opendev.org/671801 | 17:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Split NUMA object tests https://review.opendev.org/672336 | 17:43 |
| mriedem | efried: they were written independenty and artom had a bug i pointed out in his change which prompted me to write the functional test since the unit tests were just asserting the broken mock call, | 17:44 |
| mriedem | he rebased on top of the functional test to assert that it would hit the issue in his patch, | 17:44 |
| efried | okay | 17:44 |
| mriedem | regardless of his patch, i think it's a useful functional test for that init host restart code since we don't test that stuff in gate runs and unit tests for that kind of code kind of suck.... | 17:44 |
| mriedem | as you see from the test we leak allocations and things in the nova db etc | 17:45 |
| *** panda is now known as panda|off | 17:45 | |
| aspiers | kashyap: I guess you're not around? | 17:45 |
| efried | mriedem: Yeah, no doubt it's a useful test, I just wasn't sure if it needed to block artom's patch, which is closer to mergeable. | 17:46 |
| mriedem | i have heard "oh for pete's sakes" from this old woman in a hospital waiting room at least a few times | 17:46 |
| mriedem | and "thank you kindly" from an old man | 17:46 |
| mriedem | the muzak, it's.....killing me | 17:46 |
| mriedem | efried: it's not needed to block his patch, he rebased it though | 17:47 |
| mriedem | i'm completely innocent | 17:47 |
| *** _hemna has joined #openstack-nova | 17:49 | |
| jamesdenton | hey sean-k-mooney - if you get a chance, can you take a peek at https://bugs.launchpad.net/os-vif/+bug/1837252? | 17:50 |
| openstack | Launchpad bug 1837252 in neutron "IFLA_BR_AGEING_TIME of 0 causes flooding across bridges" [Undecided,Incomplete] | 17:50 |
| artom | efried, yeah, I don't mind being on top, it keeps me honest | 17:52 |
| efried | ight, np | 17:52 |
| artom | efried, that being said, if we can use that as an excuse to marshal attention to mriedem's patch, I'd be cool with that ;) | 17:52 |
| efried | that has more or less happened, viz. this conversation. | 17:52 |
| artom | #winning | 17:53 |
| sean-k-mooney | jamesdenton: yes ill take a look now just finishing a patch | 17:59 |
| jamesdenton | great, thank you! | 17:59 |
| sean-k-mooney | jamesdenton: as far as i am aware the aging behavior is quite old. we recently ported it to use pyroute two to set it instead of brctl but i dont think we change the behaivor in stien | 18:00 |
| sean-k-mooney | that said we can always make this configurable. | 18:01 |
| sean-k-mooney | ill take a look at the code and see why we orginially set this | 18:01 |
| aspiers | hey sean-k-mooney I think found an issue | 18:03 |
| jamesdenton | configurable could be ok. creating a bridge manually with brctl results in a 300 sec aging timer. And looking at some older environments, this appears to be the case as well. thanks for looking | 18:04 |
| aspiers | sean-k-mooney: fakelibvirt returns capabilities for other architectures like mips | 18:05 |
| aspiers | sean-k-mooney: but your patch doesn't provide a default machine type for those | 18:05 |
| aspiers | so we get a few None keys in dict returned by get_domain_capabilities | 18:05 |
| sean-k-mooney | jamesdenton: it looks like it was previously commented out https://github.com/openstack/os-vif/blob/stable/ocata/vif_plug_linux_bridge/linux_net.py#L132 | 18:07 |
| sean-k-mooney | aspiers: i know that is not an issue | 18:07 |
| sean-k-mooney | i have mips installed locally | 18:08 |
| sean-k-mooney | i didnt add an example for mip to force it t use the dynamic version which is used for x86_64 | 18:08 |
| sean-k-mooney | aspiers: we really should not be provideing default machine types in nova IMO, instead we should leave libvirt choose the defualt | 18:09 |
| jamesdenton | sean-k-mooney even as recently as Rocky, it looks like. undocumented comment. love it. | 18:10 |
| sean-k-mooney | ya so this looks like it was an unitntional change. ill see if there is a commit that warrented it. | 18:10 |
| sean-k-mooney | jamesdenton: i know that shaid wanted to set it to 0 for a live migration edge cases at one point | 18:11 |
| sean-k-mooney | that might be valid for ovs hybrid plug | 18:11 |
| sean-k-mooney | but for linux bridge | 18:11 |
| sean-k-mooney | i think we should rever back to the default | 18:11 |
| jamesdenton | agreed. | 18:12 |
| *** factor has joined #openstack-nova | 18:14 | |
| jamesdenton | sean-k-mooney Using common code now? See OVS https://github.com/openstack/os-vif/blob/stable/rocky/vif_plug_ovs/linux_net.py#L180 vs LXB https://github.com/openstack/os-vif/blob/stable/rocky/vif_plug_linux_bridge/linux_net.py#L148 | 18:15 |
| sean-k-mooney | jamesdenton: this was the patch that changed it originally https://github.com/openstack/os-vif/commit/fa4ff64b86e6e1b6399f7250eadbee9775c22d32#diff-f55bc78ffb4c10000bbf81b88bf68673 | 18:15 |
| *** ociuhandu has joined #openstack-nova | 18:16 | |
| sean-k-mooney | ya we are using common code now and i did ovs first so i guess we ended up with the ovs default | 18:16 |
| jamesdenton | makes sense | 18:16 |
| sean-k-mooney | ok ill go fix this shortly and we can get this backported | 18:16 |
| jamesdenton | thank you | 18:16 |
| sean-k-mooney | thanks for reporting it. ill update the bug | 18:17 |
| jamesdenton | right on | 18:17 |
| aspiers | sean-k-mooney: which bit of libvirt provides defaults? caps or domcaps or something else? | 18:17 |
| aspiers | sean-k-mooney: I guess /domainCapabilities/machine ? | 18:18 |
| aspiers | oh no, that's dependent on the API parameter | 18:18 |
| *** psachin has quit IRC | 18:19 | |
| aspiers | although I now remember that the CLI supported a default and the API didn't which was a bug they fixed after I reported it | 18:19 |
| aspiers | amazing how much I forgot in a month :-/ | 18:19 |
| *** amodi has quit IRC | 18:20 | |
| sean-k-mooney | aspiers: ya so how i have re written it we now pass none to the libvirt python bindings and libvirt interally select a machine type and we parse it from the result | 18:22 |
| sean-k-mooney | aspiers: i can add mips and other example if you like | 18:22 |
| *** _hemna has quit IRC | 18:22 | |
| sean-k-mooney | its just another contstant in the fake data file | 18:22 |
| sean-k-mooney | aspiers: i personally think however that we might want to allow passing the arch and or machine type to the funtion have it lookup the value form libvirt if its not already cached | 18:24 |
| sean-k-mooney | but i currently dont have a usecase where that is strictly needed | 18:24 |
| sean-k-mooney | which is why i havent changed it | 18:24 |
| *** rouk has joined #openstack-nova | 18:26 | |
| *** igordc has joined #openstack-nova | 18:27 | |
| mriedem | efried: i saw your questions on https://review.opendev.org/#/c/665138/ | 18:28 |
| mriedem | i put a bunch of notes on it - i think it's correct for a narrow window, but i'd like to see a functional test as well | 18:28 |
| mriedem | it's basically https://review.opendev.org/#/c/641806/ but revert instead of confirm | 18:29 |
| *** ociuhandu has quit IRC | 18:34 | |
| efried | mriedem: did you see the func test I tried to write? | 18:35 |
| efried | https://review.opendev.org/#/c/665253/ | 18:36 |
| efried | which I suspect was totally stolen from the one you mention | 18:36 |
| mriedem | no i didn't | 18:38 |
| mriedem | might want to compare your test to what my scenario is in the commit message on the other patch | 18:39 |
| *** mriedem has quit IRC | 18:42 | |
| *** amodi has joined #openstack-nova | 18:45 | |
| aspiers | sean-k-mooney: I finally found it https://www.mail-archive.com/libvir-list@redhat.com/msg182746.html | 18:55 |
| aspiers | https://github.com/libvirt/libvirt-python/commit/5004b4ad532ffa93ed4b62c8021eaa9210855209 | 18:55 |
| sean-k-mooney | aspiers: ah ok so we need to libvirt-python version to be bumped to 5.3 | 18:58 |
| aspiers | sean-k-mooney: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-04-26.log.html#t2019-04-26T11:30:18 | 18:58 |
| *** cdent has quit IRC | 18:59 | |
| sean-k-mooney | aspiers: ya that vaguely rings a bell | 18:59 |
| aspiers | sean-k-mooney: IIUC the workaround was to explicitly pass None to the API | 18:59 |
| aspiers | We don't want to introduce a dependency on newer libvirt-python unless we really have to | 18:59 |
| sean-k-mooney | if explctily passing none works then we dont need too | 19:00 |
| sean-k-mooney | that is what we are doing in my current patch | 19:00 |
| aspiers | right | 19:00 |
| aspiers | but still the nested dict gets broken | 19:00 |
| *** igordc has quit IRC | 19:00 | |
| sean-k-mooney | how so? | 19:01 |
| sean-k-mooney | i never allow a key or value to be none in the current code | 19:02 |
| aspiers | 'ppc': {'None': <nova.virt.libvirt.config.LibvirtConfigDomainCaps object at 0x7f243d3ec7b8>} | 19:02 |
| aspiers | I see entries like that in the domcaps dict | 19:02 |
| aspiers | using your patch | 19:02 |
| sean-k-mooney | that should not happen maybe i missed something | 19:02 |
| aspiers | there is no guarantee that machine_type is not None | 19:02 |
| aspiers | since you removed the "or 'q35'" | 19:02 |
| sean-k-mooney | i was depending on qemu not returing none | 19:03 |
| sean-k-mooney | we cant just default to q35 but we can register default for as many acrhs as we care to support | 19:03 |
| aspiers | where is it supposed to be getting the default from? | 19:03 |
| aspiers | it's currently None for mips, mipsel, and ppc | 19:04 |
| *** ociuhandu has joined #openstack-nova | 19:04 | |
| sean-k-mooney | https://review.opendev.org/#/c/670189/4/nova/virt/libvirt/host.py@763 | 19:04 |
| sean-k-mooney | we use the value we got back from libvirt as the key | 19:05 |
| aspiers | back from which libvirt call? | 19:05 |
| sean-k-mooney | getDomainCapabilities | 19:05 |
| aspiers | getCapabilities or getDomainCapabilities? | 19:05 |
| aspiers | OK I'll try to track it down | 19:06 |
| sean-k-mooney | so if we dont have a defualt for the arch we call getDomainCapabilities with machine_type=None | 19:06 |
| aspiers | right and then look at the machine type which was returned in the XML | 19:07 |
| sean-k-mooney | then i added https://review.opendev.org/#/c/670189/4/nova/virt/libvirt/config.py@132 to parse the machine type and store it in the object | 19:07 |
| *** factor has quit IRC | 19:07 | |
| sean-k-mooney | ya so i was assuming that there would aways be a machine type returned in the xml | 19:08 |
| aspiers | I think there is | 19:08 |
| *** factor has joined #openstack-nova | 19:08 | |
| sean-k-mooney | Maybe we are getting the default from https://review.opendev.org/#/c/670189/4/nova/virt/libvirt/config.py@121 | 19:08 |
| *** ociuhandu_ has joined #openstack-nova | 19:09 | |
| sean-k-mooney | that would cause it to be none if we did not get a machine type in the xml | 19:09 |
| *** ociuhandu has quit IRC | 19:09 | |
| sean-k-mooney | i could just skip storing it if we get none back | 19:09 |
| aspiers | yeah but I'm not yet convinced that's the issue | 19:10 |
| *** factor has quit IRC | 19:10 | |
| *** factor has joined #openstack-nova | 19:11 | |
| aspiers | sean-k-mooney: OK if I tweak your patch with a few extra comments and typo fixes? | 19:12 |
| *** factor has quit IRC | 19:13 | |
| redkrieg | lyarwood: I've come across your work on rescue mode and it's exactly what I need to offer ISO based OS installs for my clients. I see it's Abandoned for Train, but I was wondering if you knew off-hand what else needs to be done. https://blueprints.launchpad.net/nova/+spec/virt-rescue-stable-disk-devices | 19:13 |
| *** factor has joined #openstack-nova | 19:13 | |
| aspiers | sean-k-mooney: the bug is here https://review.opendev.org/#/c/670189/4/nova/tests/unit/virt/libvirt/fakelibvirt.py@1369 | 19:19 |
| aspiers | e.g. for mips we don't have a default machine type, so the x86_64 template gets used with mtype: None | 19:20 |
| aspiers | also, it shouldn't be using the x86_64 template for mips arch | 19:20 |
| aspiers | sean-k-mooney: recommendations welcome on how we should fix this. Ideally I guess we would get fake domcaps for all the architectures returned by the fakelibvirt getCapabilities - currently we are missing mips/mipsel/ppc | 19:22 |
| aspiers | efried: do we have access to mips/mipsel/ppc boxes to grab that XML from? | 19:22 |
| *** whoami-rajat has quit IRC | 19:22 | |
| * aspiers goes to cook dinner | 19:22 | |
| *** panda|off has quit IRC | 19:23 | |
| sean-k-mooney | aspiers: sure feel free too | 19:25 |
| efried | aspiers: I sure don't. edleafe, do you know who might be able to spin up kvm on Power (or PowerKVM, or whatever tf it's called) for this purpose? | 19:25 |
| *** panda has joined #openstack-nova | 19:25 | |
| sean-k-mooney | aspiers: efried i can just generate them locally | 19:25 |
| sean-k-mooney | aspiers: efried i have the emultators installed for all of them | 19:26 |
| edleafe | efried: sorry, no | 19:27 |
| sean-k-mooney | you can just use the virsh cli and specify the arch and it will give you the domain caps for any emulator you have installed | 19:27 |
| sean-k-mooney | aspiers: here are the xmls for the ppc/mips/mipsel http://paste.openstack.org/show/754771/ | 19:29 |
| *** mdbooth has joined #openstack-nova | 19:30 | |
| sean-k-mooney | aspiers: ah and ya the bug makes sesne gald it was just in the tests | 19:31 |
| *** bbowen has quit IRC | 19:35 | |
| aspiers | sean-k-mooney: cool thanks! how did you set up the emulators? | 19:43 |
| sean-k-mooney | aspiers: if you install qemu, qemu-kvm and libvirt on ubunut 18.04 it pulls in all the qemu emulators that are available by default | 19:45 |
| sean-k-mooney | on fedora/centos you have to install them one by one | 19:46 |
| sean-k-mooney | so in my ubunut vm i have all of them on my centos one i only have x86 and x86_64 | 19:46 |
| *** maciejjozefczyk has quit IRC | 19:52 | |
| *** factor has quit IRC | 19:52 | |
| *** factor has joined #openstack-nova | 19:53 | |
| *** factor has quit IRC | 19:55 | |
| *** factor has joined #openstack-nova | 19:55 | |
| *** factor has quit IRC | 19:55 | |
| *** mriedem has joined #openstack-nova | 20:00 | |
| *** lbragstad has quit IRC | 20:01 | |
| aspiers | interesting | 20:04 |
| *** slaweq has quit IRC | 20:08 | |
| mriedem | efried: i'm tickling your ksa/sdk funny bone here https://review.opendev.org/#/c/664842/7/ironic/common/nova.py@13 | 20:19 |
| *** _hemna has joined #openstack-nova | 20:19 | |
| sean-k-mooney | aspiers: looks like we have other issue too. if manually set virt_type=kvm in the nova.conf it also breaks on archittures where its not supported | 20:25 |
| sean-k-mooney | aspiers: http://paste.openstack.org/show/754776/ | 20:31 |
| aspiers | sean-k-mooney: looking | 20:32 |
| *** ociuhandu_ has quit IRC | 20:32 | |
| aspiers | sean-k-mooney: BTW I've imported those domain caps you gave me | 20:32 |
| *** ociuhandu has joined #openstack-nova | 20:33 | |
| sean-k-mooney | im in two minds if we shoudl catch the libvirt excption or not | 20:35 |
| sean-k-mooney | we could just catch the invalid combination and continue with the rest | 20:36 |
| mriedem | dansmith: stephenfin: question on https://review.opendev.org/#/c/672065/3 but i'm not sure why the libvirt driver overhead stuff is missing from the docs like we have for hyperv and xenapi in there | 20:48 |
| mriedem | that's my only hangup | 20:48 |
| dansmith | mriedem: because there's nothing to do I thought | 20:49 |
| dansmith | the reno said "nothing to do" for libvirt I think | 20:49 |
| mriedem | it also said some stuff about PCPU | 20:49 |
| mriedem | which is not a thing yet | 20:49 |
| mriedem | i think that was when stephen had that later in the series after the PCPU stuff, | 20:49 |
| mriedem | now it's moved to the front | 20:49 |
| dansmith | "No change is necessary as this was never accounted for properly using | 20:49 |
| dansmith | the overhead model" | 20:49 |
| mriedem | where do you see that? | 20:50 |
| dansmith | that was in the reno before I cut out the virt stuff | 20:50 |
| dansmith | which is why I thought having it missing from the admin docs made sense | 20:50 |
| *** pcaruana has quit IRC | 20:50 | |
| dansmith | because it's not per-instance unless you have dedicated CPUs, but even still, it wasn't accounted for by the overhead calcs anyway | 20:50 |
| mriedem | ok this reno https://review.opendev.org/#/c/672065/2..3/releasenotes/notes/remove-core-ram-disk-filters-9510cbe5b4e295b6.yaml@a21 | 20:51 |
| dansmith | yeah | 20:51 |
| mriedem | and the overhead isn't used here https://github.com/openstack/nova/blob/383a4cf3710b5da2fe0b580bc25783ec8fefed48/nova/compute/claims.py#L108 | 20:53 |
| mriedem | like for disk and ram above | 20:53 |
| mriedem | wtf, why was it even in the gd driver | 20:53 |
| mriedem | anyway, i see now | 20:53 |
| *** _hemna has quit IRC | 20:53 | |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: use domain capablites to get supported device models https://review.opendev.org/666915 | 20:54 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775 | 20:54 |
| *** slaweq has joined #openstack-nova | 20:56 | |
| *** sean-k-mooney has quit IRC | 21:01 | |
| *** slaweq has quit IRC | 21:01 | |
| *** ociuhandu has quit IRC | 21:02 | |
| *** bbowen has joined #openstack-nova | 21:03 | |
| *** lpetrut has joined #openstack-nova | 21:22 | |
| *** lpetrut has quit IRC | 21:22 | |
| *** lpetrut has joined #openstack-nova | 21:23 | |
| mriedem | dansmith: on the claims removal one what am i not understanding here? https://review.opendev.org/#/c/551026/4//COMMIT_MSG@16 | 21:30 |
| *** lpetrut has quit IRC | 21:30 | |
| *** altlogbot_3 has quit IRC | 21:33 | |
| *** irclogbot_3 has quit IRC | 21:33 | |
| *** altlogbot_2 has joined #openstack-nova | 21:34 | |
| *** irclogbot_1 has joined #openstack-nova | 21:34 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: libvirt: harden Host.get_domain_capabilities() https://review.opendev.org/670189 | 21:35 |
| aspiers | efried: ^^^ I've beefed up the commit message so it may be slightly less impenetrable now :) | 21:40 |
| efried | noted | 21:41 |
| aspiers | but since this is now a joint effort between sean-k-mooney and myself, maybe it's enough to get a +1 from kashyap | 21:42 |
| mriedem | dustinc: efried: a few questions in the bottom sdk patch https://review.opendev.org/#/c/643664/ | 21:45 |
| efried | mriedem: I have just emerged from the ironic-to-novaclient rabbit hole you sent me down. | 21:46 |
| mriedem | haha | 21:46 |
| efried | thanks (sincerely, no sarcasm) for that. | 21:46 |
| mriedem | i knew it would happen | 21:46 |
| efried | see https://review.opendev.org/#/c/672369/ | 21:47 |
| *** takashin has joined #openstack-nova | 21:47 | |
| *** irclogbot_1 has quit IRC | 21:59 | |
| *** altlogbot_2 has quit IRC | 22:01 | |
| dansmith | mriedem: regarding my BFV comment? | 22:01 |
| mriedem | yeah | 22:02 |
| dansmith | yes, that's obviously old from the first WIPpy version of this where I was just taking shots against the caching scheduler | 22:02 |
| mriedem | dustinc: efried: also some questions in the ironic driver + sdk patch https://review.opendev.org/#/c/642899/33 - looks like at least in our ci where nova-compute is started once before ironic, we now fail to start the service that first time unlike before where we'd swallow the VirtDriverNotReady error | 22:03 |
| efried | mriedem: responded on https://review.opendev.org/#/c/643664/ | 22:03 |
| dustinc | mriedem: checking them out now, thanks | 22:03 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020 | 22:05 |
| efried | mriedem: Note that the series forks; if you want an easy +Win, the placement one should be ready (zuul connection borkage notwithstanding) https://review.opendev.org/#/c/656023/ | 22:05 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027 | 22:05 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031 | 22:05 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299 | 22:06 |
| mriedem | dansmith: poor caching scheduler | 22:06 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344 | 22:06 |
| dansmith | we could work up a remix of the office space printer scene with the caching scheduler | 22:06 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673 | 22:06 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676 | 22:07 |
| dansmith | mriedem: https://imgflip.com/i/36cp5t | 22:07 |
| *** adriant has quit IRC | 22:11 | |
| *** altlogbot_3 has joined #openstack-nova | 22:22 | |
| *** gyee has quit IRC | 22:23 | |
| *** TxGirlGeek has quit IRC | 22:25 | |
| *** altlogbot_3 has quit IRC | 22:27 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689 | 22:31 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709 | 22:31 |
| mriedem | oh dan | 22:32 |
| mriedem | there are things i've hated in nova more than that | 22:32 |
| redkrieg | mriedem: I was looking at your blueprint for improving rescue mode and it's exactly what I need to offer ISO based OS installs for my clients. I see it's Abandoned for Train, but I was wondering if you knew off-hand what else needs to be done. https://blueprints.launchpad.net/nova/+spec/virt-rescue-stable-disk-devices | 22:34 |
| mriedem | redkrieg: that's not mine | 22:34 |
| mriedem | it's lyarwood's i think | 22:34 |
| redkrieg | my apoligies, I just saw "Started by | 22:34 |
| redkrieg | had your name | 22:35 |
| redkrieg | I pinged him earlier but I think he's away today | 22:35 |
| mriedem | he's in....UK timezone (can't remember if he's london or dublin, i know that's a grave error if i get it wrong) | 22:35 |
| mriedem | dansmith: is lyarwood out this week? ^ | 22:35 |
| dansmith | mriedem: not according to the vacay calendar | 22:36 |
| mriedem | ok i saw that he had re-proposed the spec for train https://review.opendev.org/#/c/651151/ but then abandoned it without any comment why, so idk | 22:36 |
| dansmith | lyarwood is in angleand, not eye'r'land | 22:36 |
| mriedem | but spec freeze is thursday | 22:36 |
| mriedem | can i say he's in the "british isles"? | 22:36 |
| mriedem | he's in a cold dark land of boiled meats and dark brews | 22:37 |
| redkrieg | I pinged him earlier today with a similar message, hopefully he'll see it when he gets in tomorrow. | 22:38 |
| *** aarents has quit IRC | 22:41 | |
| openstackgerrit | Merged openstack/nova master: Drop delete_build_requests_with_no_instance_uuid online migration https://review.opendev.org/651001 | 22:43 |
| openstackgerrit | Merged openstack/nova master: Handle Invalid exceptions as expected in attach_interface https://review.opendev.org/650077 | 22:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing. https://review.opendev.org/644793 | 22:46 |
| efried | stephenfin: I put that ^ back to PS10, which was passing tests, thereby resurrecting johnthetubaguy's +2. You were +2 at PS8; would you mind sending it? TIA. | 22:48 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712 | 22:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Handle Invalid exceptions as expected in attach_interface https://review.opendev.org/672384 | 22:49 |
| *** _hemna has joined #openstack-nova | 22:49 | |
| *** tkajinam has joined #openstack-nova | 22:51 | |
| *** mriedem has quit IRC | 22:55 | |
| *** avolkov has quit IRC | 23:07 | |
| *** gyee has joined #openstack-nova | 23:10 | |
| *** altlogbot_3 has joined #openstack-nova | 23:14 | |
| *** rcernin has joined #openstack-nova | 23:16 | |
| *** altlogbot_3 has quit IRC | 23:19 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Deprecate the '--config-drive' option https://review.opendev.org/653683 | 23:23 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047 | 23:24 |
| *** _hemna has quit IRC | 23:24 | |
| *** altlogbot_1 has joined #openstack-nova | 23:28 | |
| *** irclogbot_1 has joined #openstack-nova | 23:32 | |
| *** igordc has joined #openstack-nova | 23:35 | |
| openstackgerrit | Merged openstack/nova master: Remove deprecated Core/Ram/DiskFilter https://review.opendev.org/672065 | 23:36 |
| *** kodama_ has joined #openstack-nova | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!