Tuesday, 2019-06-25

openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Add a guide to add a new microversion support  https://review.opendev.org/66700200:04
openstackgerritBrin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot  https://review.opendev.org/58033600:07
openstackgerritBrin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api  https://review.opendev.org/61294900:08
*** igordc has quit IRC00:13
*** Sundar has quit IRC00:18
*** hongbin has quit IRC00:19
*** brinzhang has joined #openstack-nova00:25
*** wwriverrat has quit IRC00:39
*** spatel has joined #openstack-nova00:48
*** _alastor_ has quit IRC00:58
*** bbowen has joined #openstack-nova01:01
*** brinzhang_ has joined #openstack-nova01:07
*** brinzhang has quit IRC01:10
openstackgerritAlex Xu proposed openstack/nova master: Correct the comment of RequestSpec's network_metadata  https://review.opendev.org/66706101:12
*** mkrai_ has joined #openstack-nova01:13
*** spatel has quit IRC01:26
*** BjoernT has quit IRC01:31
*** rcernin has quit IRC01:48
*** rcernin has joined #openstack-nova01:48
*** hongbin has joined #openstack-nova02:04
*** whoami-rajat has joined #openstack-nova02:07
*** mkrai_ has quit IRC02:24
*** brinzhang__ has joined #openstack-nova02:26
*** brinzhang_ has quit IRC02:29
*** mkrai_ has joined #openstack-nova02:30
*** jaypipes has joined #openstack-nova02:36
*** rcernin has quit IRC02:42
*** rcernin has joined #openstack-nova02:42
*** threestrands has joined #openstack-nova02:54
*** rcernin has quit IRC03:04
*** rcernin has joined #openstack-nova03:04
*** sapd1_x has joined #openstack-nova03:07
*** lbragstad has joined #openstack-nova03:18
*** fyx has quit IRC03:18
*** mnaser has quit IRC03:19
*** fyx has joined #openstack-nova03:19
*** mnaser has joined #openstack-nova03:20
*** BjoernT has joined #openstack-nova03:26
*** rcernin has quit IRC03:30
*** rcernin has joined #openstack-nova03:31
*** BjoernT has quit IRC03:31
*** BjoernT has joined #openstack-nova03:35
*** psachin has joined #openstack-nova03:39
openstackgerrithuichen proposed openstack/nova master: Support pagination for sever groups by sql  https://review.opendev.org/66725903:40
*** udesale has joined #openstack-nova03:53
*** lbragstad has quit IRC03:59
*** BjoernT has quit IRC04:18
*** hongbin has quit IRC04:25
*** hongbin has joined #openstack-nova04:42
*** hongbin has quit IRC04:49
*** ratailor has joined #openstack-nova04:58
*** ivve has joined #openstack-nova05:04
*** cf__ has joined #openstack-nova05:18
*** dannins has joined #openstack-nova05:26
*** sapd1_x has quit IRC05:34
*** artom has joined #openstack-nova05:34
*** artom is now known as artom|gmtplus305:35
*** ysandeep has joined #openstack-nova05:43
*** Luzi has joined #openstack-nova05:44
cf__Hi! I asked in cinder channel yesterday regarding delete_on_termination and they pointed me towards nova, which make sense, however, when I do nova show <uuid>, I do not receive any information about delete_on_termination, even that I did set it when creating the instance.. What am I doing wrong, to check if the volume is going to be deleted on instance termnination?05:50
cf__$ nova show 83fcdb58-045a-4475-b4eb-5b9287daebcc |grep volume05:56
cf__| os-extended-volumes:volumes_attached | [{"id": "f3e192b6-f8b0-4a9b-8512-4e7ffa37756d"}]05:56
*** pcaruana has joined #openstack-nova05:56
*** pcaruana has quit IRC05:57
*** pcaruana has joined #openstack-nova05:57
*** lpetrut has joined #openstack-nova06:01
brinzhang__cf__: What about your volume? root disk? or data disk ?06:05
cf__brinzhang__: it's my root disk06:06
brinzhang__cf__: If it's a root disk, you can see the delete_on_termination from 'nova show server_id'06:06
brinzhang__[root@localhost ~]# nova show ec939a46-9e1e-4126-8214-6ceb3b95676a |grep volume06:06
brinzhang__| image                                | Attempt to boot from volume - no image supplied                                 |06:06
brinzhang__| os-extended-volumes:volumes_attached | [{"id": "df191675-0ac1-4101-a590-7ad2f7607e89", "delete_on_termination": true}] |06:06
cf__The thing is, the person that started a bunch of instances did it with config_drive enabled which is kinda destroying the idea of a flexible environment, by making it extremely hard to live migrate running instances06:07
cf__Yeah, that's what i'm trying to find, however as pasted above, it dosnt show.. This is a test instance I made with delete_on_termination true, but I wanted to check if I was able to see it anywhere because for my production instances, i cannot risk to lose my volumes when i'm forced to delete the running instances and create new ones with the existing volumes in order to get rid of config_drive06:08
cf__for a random production instance i get:06:10
cf__stack@j3499-cp1-c1-m1-mgmt:~$ nova show f0c664e6-f161-41ac-93bd-cc2500644583 |grep volume06:10
cf__| image                                | Attempt to boot from volume - no image supplied                                                                                                  |06:10
cf__| os-extended-volumes:volumes_attached | [{"id": "d86ea1ef-1b31-435d-8d3c-f106b61501ec"}, {"id": "d6fc7a5b-2cc0-4764-9a47-8cc89a609e0f"}, {"id": "9ff316b7-ff6d-4f63-a3fe-97dde0ba8803"}] |06:10
cf__ofcause this one, I do not know if delete_on_termination was set uppon creation - however it is on the first one I pasted, which was made only to check if I was able to find the info about delete_on_termination06:11
brinzhang__cf__: I think you can check it in block_device_mapping table, is that the delete_on_termination was set?06:12
cf__brinzhang__: so check the database? or is there a way to check it from cli?06:12
brinzhang__Because there is no scene for you, you can’t be sure that the problem exists.06:13
cf__Yeah, i just want to make sure not to lose data when I delete the running instances :)06:13
brinzhang__Currently, the delete_on_termination can only set when the server boot, there are two specs want to support config and reconfig that change, but not start working ...06:15
cf__It make sense.. maybe I should just create some backup before testing this :P06:16
brinzhang__Thanks, you can try test this, and report a but on launchpad https://bugs.launchpad.net/nova06:17
brinzhang__If ensure that issue exist :P06:18
cf__Will do, thanks :)06:19
cf__Oh btw, it's worth mentioning that this is a rather old instance of openstack since we're currently running Newton, but I guess that shouldnt do much of a difference06:19
brinzhang__Oh.. good luck.06:24
*** belmoreira has joined #openstack-nova06:30
*** belmoreira has quit IRC06:31
openstackgerritYongli He proposed openstack/nova master: Clean up orphan instances virt driver  https://review.opendev.org/64891206:33
openstackgerritYongli He proposed openstack/nova master: clean up orphan instances  https://review.opendev.org/62776506:33
*** belmoreira has joined #openstack-nova06:33
*** slaweq has joined #openstack-nova06:38
*** luksky has joined #openstack-nova06:41
*** rcernin has quit IRC06:41
*** altlogbot_0 has quit IRC06:46
*** altlogbot_2 has joined #openstack-nova06:50
*** altlogbot_2 has quit IRC06:50
cf__brinzhang__: I found it! Turns out that the easiest way was to check it in the nova database...06:54
cf__mysql> select delete_on_termination from block_device_mapping where instance_uuid = '83fcdb58-045a-4475-b4eb-5b9287daebcc';06:54
cf__+-----------------------+06:54
cf__| delete_on_termination |06:54
cf__+-----------------------+06:54
cf__|                     1 |06:54
cf__+-----------------------+06:54
*** dpawlik has joined #openstack-nova06:55
*** altlogbot_1 has joined #openstack-nova06:55
*** threestrands has quit IRC07:00
*** threestrands has joined #openstack-nova07:00
brinzhang__cf__:So, next, you should to check that 'nova show' why not return this attribute, is there some error? Or some useful log?07:01
brinzhang__I am sorry, I am not have the newton environment to support more help :P07:02
*** tesseract has joined #openstack-nova07:11
*** artom has joined #openstack-nova07:13
*** artom|gmtplus3 has quit IRC07:13
*** rdopiera has joined #openstack-nova07:17
*** xek has joined #openstack-nova07:22
*** ttsiouts has joined #openstack-nova07:28
*** ttsiouts has quit IRC07:33
*** artom is now known as artom|gmtplus307:35
*** jangutter has joined #openstack-nova07:41
*** ccamacho has joined #openstack-nova07:41
*** ccamacho has quit IRC07:41
*** jangutter has quit IRC07:42
*** jangutter_ has joined #openstack-nova07:42
*** ccamacho has joined #openstack-nova07:43
*** tssurya has joined #openstack-nova07:46
*** damien_r has joined #openstack-nova07:54
*** threestrands has quit IRC07:57
openstackgerritzhaixiaojun proposed openstack/python-novaclient master: Modify the url of upper_constraints_file  https://review.opendev.org/66593407:59
*** ttsiouts has joined #openstack-nova08:00
*** takashin has left #openstack-nova08:00
*** udesale has quit IRC08:01
*** udesale has joined #openstack-nova08:03
*** udesale has quit IRC08:03
*** udesale has joined #openstack-nova08:03
*** ricolin has joined #openstack-nova08:05
*** adrianc_ has quit IRC08:06
*** ricolin has quit IRC08:13
*** adrianc has joined #openstack-nova08:14
*** ricolin has joined #openstack-nova08:22
*** tkajinam has quit IRC08:27
*** tkajinam has joined #openstack-nova08:28
*** ralonsoh has joined #openstack-nova08:28
*** Dinesh_Bhor has quit IRC08:29
*** tkajinam has quit IRC08:29
*** imacdonn has quit IRC08:42
*** imacdonn has joined #openstack-nova08:42
*** martinkennelly has joined #openstack-nova08:44
*** priteau has joined #openstack-nova08:56
*** tssurya has quit IRC08:59
*** Dinesh_Bhor has joined #openstack-nova09:01
openstackgerritRui Zang proposed openstack/nova-specs master: support virtual persistent memory  https://review.opendev.org/60159609:02
*** jaosorior has joined #openstack-nova09:03
openstackgerritArnaud Morin proposed openstack/nova master: Do not refresh deleted instance info cache  https://review.opendev.org/66729409:06
*** jaosorior has quit IRC09:11
*** ratailor_ has joined #openstack-nova09:14
*** ratailor has quit IRC09:17
*** tetsuro_ has joined #openstack-nova09:18
*** mdbooth has joined #openstack-nova09:21
*** tssurya has joined #openstack-nova09:29
*** artom|gmtplus3 has quit IRC09:35
*** davidsha has joined #openstack-nova09:37
*** Bidwe_jay77 has joined #openstack-nova09:37
*** tetsuro_ has quit IRC09:41
*** shilpasd has joined #openstack-nova09:43
*** mkrai_ has quit IRC09:47
*** mrch_ has quit IRC09:49
*** mrch_ has joined #openstack-nova09:50
*** ratailor__ has joined #openstack-nova09:53
openstackgerrithuichen proposed openstack/nova master: Support pagination for sever groups by sql  https://review.opendev.org/66725909:53
*** panda has quit IRC09:55
*** ratailor_ has quit IRC09:56
*** gmann has quit IRC09:57
openstackgerrithuichen proposed openstack/nova master: Support pagination for sever groups by sql  https://review.opendev.org/66725910:00
*** panda has joined #openstack-nova10:00
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552010:06
*** ociuhandu has joined #openstack-nova10:13
*** artom has joined #openstack-nova10:16
*** Dinesh_Bhor has quit IRC10:16
*** artom is now known as artom|gmtplus310:16
*** ociuhandu_ has joined #openstack-nova10:16
*** ociuhandu has quit IRC10:16
*** mkrai_ has joined #openstack-nova10:18
*** ttsiouts has quit IRC10:21
*** ttsiouts has joined #openstack-nova10:21
*** brinzhang_ has joined #openstack-nova10:25
*** ttsiouts has quit IRC10:26
*** brinzhang__ has quit IRC10:28
openstackgerritStephen Finucane proposed openstack/nova master: nova-status: Remove consoleauth workaround check  https://review.opendev.org/65296810:34
openstackgerritStephen Finucane proposed openstack/nova master: Remove nova-consoleauth  https://review.opendev.org/65296910:34
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict  https://review.opendev.org/65297010:34
openstackgerritStephen Finucane proposed openstack/nova master: docs: Rework nova console diagram  https://review.opendev.org/66014710:34
openstackgerritStephen Finucane proposed openstack/nova master: docs: Integrate 'sphinx.ext.imgconverter'  https://review.opendev.org/66569310:34
*** bbowen has quit IRC10:36
*** brinzhang__ has joined #openstack-nova10:47
*** brinzhang_ has quit IRC10:50
*** mdbooth has quit IRC10:51
*** mdbooth has joined #openstack-nova10:55
*** gmann has joined #openstack-nova10:58
*** jaosorior has joined #openstack-nova10:59
*** jaosorior has quit IRC11:02
*** jaosorior has joined #openstack-nova11:03
*** mdbooth has quit IRC11:05
*** mdbooth has joined #openstack-nova11:05
*** udesale has quit IRC11:06
*** udesale has joined #openstack-nova11:08
*** ttsiouts has joined #openstack-nova11:16
*** ratailor__ has quit IRC11:18
*** mdbooth has quit IRC11:20
openstackgerritBalazs Gibizer proposed openstack/nova stable/stein: Remove redundant group host setup  https://review.opendev.org/66733411:24
*** mdbooth has joined #openstack-nova11:31
*** mmethot_ has quit IRC11:32
*** lbragstad has joined #openstack-nova11:33
*** priteau has quit IRC11:43
*** bbowen has joined #openstack-nova11:43
*** francoisp has quit IRC11:45
*** _erlon_ has joined #openstack-nova11:48
openstackgerritArnaud Morin proposed openstack/nova stable/stein: Always Set dhcp_server in network_info  https://review.opendev.org/66734011:50
*** mlavalle has joined #openstack-nova11:53
*** psachin has quit IRC11:54
*** jamesdenton has quit IRC11:54
*** spatel has joined #openstack-nova11:55
*** luksky has quit IRC12:00
*** spatel has quit IRC12:00
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance  https://review.opendev.org/45788612:04
lyarwoodmdbooth / dansmith ; ^ rebased and touched up slightly, should be ready for review again.12:05
*** mmethot has joined #openstack-nova12:07
*** mlavalle has quit IRC12:07
mdboothlyarwood: Hehe, I managed to avoid the external_events conflict with my patch by out-waiting it :)12:07
mdboothAh, you didn't conflict with it. Lucky.12:08
mdboothartom|gmtplus3 sean-k-mooney: Do you expect your fixed hybrid vif plugged patch to land soon?12:16
sean-k-mooneyam i hope so but that depend on stealing review time from peole to land it12:17
sean-k-mooneyit looks like artom has some concerns12:19
sean-k-mooneyso maybe not right away12:20
sean-k-mooneymdbooth: are you asking for you patch that is in merge conflict12:20
mdboothsean-k-mooney: Well it was in merge conflict while the patch was landed, but is now no longer conflicting but I need to rebase anyway because it seems gerrit can't tell that.12:20
sean-k-mooneyah well you might as well rebase12:21
*** Bidwe_jay77 has quit IRC12:21
mdboothsean-k-mooney: https://youtu.be/N0BkjvUOtX4?t=2912:21
sean-k-mooneyhave you got any review on it lately12:22
mdboothsean-k-mooney: Yeah, a bit.12:22
*** Bidwe_jay87 has joined #openstack-nova12:22
*** mrch_ has quit IRC12:23
sean-k-mooneyhum i havent seen fifth element in a while12:23
*** Bidwe_jay has joined #openstack-nova12:24
mdboothMe neither, but I love that film. Your comment just reminded me of the 'I have a doubt' scene :)12:24
*** davidsha has quit IRC12:43
*** martinkennelly has quit IRC12:43
openstackgerritStephen Finucane proposed openstack/nova stable/stein: Ignore hw_vif_type for direct, direct-physical vNIC types  https://review.opendev.org/66735412:46
openstackgerritStephen Finucane proposed openstack/nova stable/rocky: Ignore hw_vif_type for direct, direct-physical vNIC types  https://review.opendev.org/66735512:46
stephenfinlyarwood: Could you take a look at those two ^ Clean backports, both of them12:47
lyarwoodstephenfin: ack sure12:49
*** mriedem has joined #openstack-nova12:50
*** jangutter_ is now known as jangutter12:51
*** ttsiouts has quit IRC12:55
*** ttsiouts has joined #openstack-nova12:56
artom|gmtplus3mdbooth, if I'm right it's not as simple as we thought12:57
artom|gmtplus3I'll let sean-k-mooney respond12:57
*** ttsiouts has quit IRC13:01
*** mdbooth has quit IRC13:01
*** mdbooth has joined #openstack-nova13:02
sean-k-mooneyartom|gmtplus3: well i dont know why we would recive plug time event for same host resize of hybrid plug13:03
sean-k-mooneythe vif is already plugged and the binding host does not change13:03
artom|gmtplus3sean-k-mooney, I don't either, but it looks like we do13:03
*** luksky has joined #openstack-nova13:03
*** ysandeep has quit IRC13:04
*** dave-mccowan has joined #openstack-nova13:05
*** ttsiouts has joined #openstack-nova13:06
sean-k-mooneyfor what its worth the patch i have up passed the same host reszie test in tempest13:06
mriedemmgoddard: johnthetubaguy: i have a few questions in https://bugs.launchpad.net/nova/+bug/1833542 for what you want to see13:06
sean-k-mooneyit was tested by the neutron iptables hybird job13:06
openstackLaunchpad bug 1833542 in OpenStack Compute (nova) "No mechanism to wait for computes to update service version before restarting to remove RPC version cap after upgrade" [Wishlist,Triaged]13:06
mgoddardmriedem: fire away13:06
sean-k-mooneyi have not had time to go through your comment properly and read the logs however13:06
artom|gmtplus3sean-k-mooney, it would, because I think it just don't wait for any events in case of same host resize13:08
sean-k-mooneyright it wont be considerd a plug time event so we wont wait13:08
sean-k-mooneywe would wait for plug time events13:09
mriedemmgoddard: they are in the bug report, answer when you have time13:09
mriedemmgoddard: mostly asking about what interface you need13:09
artom|gmtplus3sean-k-mooney, in fact, I don't think tests would pick it up at all - even migrate revert guest connectivity tests would succeed eventually, assuming everything went well13:10
artom|gmtplus3There'd just be a few seconds (dozens of seconds?) between instance boot and network connectivity being established13:10
mgoddardmriedem: ah, got it. Have to head out soon but will respond13:11
mriedemmgoddard: feel free to post to the ML for other ops to weigh in if they need something like this13:12
bauzasmriedem: efried: I'm working on https://bugs.launchpad.net/nova/+bug/179356913:16
openstackLaunchpad bug 1793569 in OpenStack Compute (nova) "Add placement audit commands" [Wishlist,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza)13:16
*** whoami-rajat has quit IRC13:16
bauzasmriedem: efried: should we use the reportclient or just calling the placement API directly?13:17
efriedbauzas: looking...13:17
mriedemi'm pretty sure the other nova-manage placement commands use the reportclient13:17
bauzasthey do, yet13:17
bauzasyes*13:18
*** dave-mccowan has quit IRC13:18
mriedemso yeah just use that13:18
bauzasok13:18
efriedbauzas: agree13:18
bauzasI was about to do this, but I wonder whether the placement folks would prefer to just use other clients13:19
efriedbauzas: All nova code should go through SchedulerReportClient to talk to Placement.13:19
efriedSchedulerReportClient should really be called PlacementClient or similar13:20
bauzask13:20
mriedemright...nova doesn't have any other placement client13:20
mriedemnor is there a python-placementclient13:20
mriedemonly the sdk13:20
*** ratailor has joined #openstack-nova13:21
mriedemkeep in mind that if this is something you think your customers on older branches might want, you're best to not introduce a bunch of new dependencies here13:21
mriedemunrelated, doesn't suse and red hat have docs writers that could verify the install guide issue mentioned here https://bugs.launchpad.net/nova/+bug/1833650 ?13:21
openstackLaunchpad bug 1833650 in OpenStack Compute (nova) "Populate nova databases failed with mysql access denied" [Undecided,New] - Assigned to Chason Chan (chen-xing)13:21
efriedNote that as soon as this [1] is approved, we can merge this [2] and this [3], and then we'll be using openstacksdk for placement -- but still via the SchedulerReportClient.13:21
efried[1] https://review.opendev.org/#/c/662881/13:21
efried[2] https://review.opendev.org/#/c/643664/13:21
efried[3] https://review.opendev.org/#/c/656023/13:21
*** mkrai_ has quit IRC13:24
yonglihemriedem, Hi, good morning.13:26
mriedemalex_xu: john hou has a major problem with your patch :) https://review.opendev.org/#/c/667061/13:27
mriedemso major in fact he -1ed without a comment13:27
mriedemyonglihe: hi13:27
artom|gmtplus3mriedem, I suspect ours only have ooo-related deployment docs13:28
lyarwoodyup was just about to say, manual steps would be out of scope for them. Should be something we (devel) can help with however.13:28
lyarwoodI've asked our deployment folks to take a look13:30
mriedemi thought i heard at one of the last face to face things that red hat had a docs writer working on cinder upstream so that's where i got the idea13:31
*** dave-mccowan has joined #openstack-nova13:32
mriedemsmcginnis might have just been making it all up13:32
smcginnisLies, all lies.13:33
smcginnismriedem: There was someone at the Vancouver Forum that said he was new there and had a whole team that was going to be switching focus to be more upstream on docs. Never saw anything come of that though.13:33
*** brinzhang__ has quit IRC13:33
mriedemok that's about the level of expectation i'd have...13:34
openstackgerritMerged openstack/nova master: doc: Fix nova-manage cell_v2 list_cells output  https://review.opendev.org/66699513:34
*** mkrai_ has joined #openstack-nova13:34
lyarwoodyeah I think there is a push to upstream more of their stuff but even then, if we don't support it downstream I can't see them working on it upstream.13:35
lyarwoodstephenfin knows more about the docs team tbh13:35
mriedemred hat doesn't support installing nova on control nodes?13:35
lyarwoodnot manually no13:35
artom|gmtplus3Docs is... touchy? IIUC the argument for *not* upstreaming docs more is that docs is part of the added value that a RH sub brings13:35
mriedemoh gotcha13:35
artom|gmtplus3But yeah, stephenfin's your man13:36
mriedemyeah that's fine, i'm just looking for someone with time to validate the bug and the fix but it seems correct13:36
yongliheneed another +2 to move forward https://review.opendev.org/#/c/658716/13:37
mriedemyonglihe: if you're asking me for ^ that's not really my area13:37
sean-k-mooneymriedem: redhat requires OSP to be installed via osp director(triplo) for it to be supported form OSP13 (queens) on13:37
efriedyonglihe: I was hoping johnthetubaguy would be able to look at that one.13:37
mriedemefried: yonglihe: and i was hoping sean would ack or nack it13:37
*** BjoernT has joined #openstack-nova13:37
*** mriedem is now known as mriedem_afk13:38
efriedmriedem_afk: The delta since sean-k-mooney's last +1 is negligible, I'm assuming he's still +1.13:38
yonglihemriedem: that's ok.  Sean already given a +1.  we discussed that and got concern resolved.13:38
sean-k-mooneyefried: on which ?13:38
efriedhttps://review.opendev.org/#/c/658716/13:38
sean-k-mooneyoh the show numa stuff13:38
yonglihesean-k-mooney: i do got your +1, and alex's comment, while i address that. i got +2 from alex.13:39
sean-k-mooneyya it still has one nit but im fine with it13:39
artom|gmtplus3yonglihe, efried, it's missing the Train history bit13:40
artom|gmtplus3(I realize this is the epitome of late nitpicking)13:40
sean-k-mooney "pagesize_kb": 4096, shoudl still be 4 if they inteded it to be the defaul 4k pages13:40
artom|gmtplus3(It's jut that I thought it looked familiar, and scrolled down to history immediately)13:40
yonglihesean-k-mooney: your are right. i can fix it.13:41
sean-k-mooneyi dont think its worth anothr respin13:41
*** munimeha1 has joined #openstack-nova13:41
sean-k-mooneyit can be fixed but alex has +2'd and its not really that important13:41
sean-k-mooneyprovide we do it correctly in the code13:42
yongliheartom: it's reopen from S to D, so lost some history.13:42
yongliheS to T13:42
sean-k-mooneyso im happy to leave that as an implemenatin detail and assume you ment 4MB pages for the spec :)13:42
artom|gmtplus3yonglihe, yeah, no need to respin just for that, you have a +2 already13:42
efriedNormally I would probably feel fine proxying sean-k-mooney's vote as a +2, but that would be three Intels on paper, so I'd rather wait for another core.13:42
*** Conqueror has joined #openstack-nova13:43
*** eharney has joined #openstack-nova13:44
yonglihesean-k-mooney: sure.  efried: yeah, i also think so.13:44
sean-k-mooneyjohnthetubaguy: you previously were ok with https://review.opendev.org/#/c/658716/5 feel like being the final +2+w ?13:45
yongliheanother patch 'clean up orphan instances' , https://review.opendev.org/#/c/627765/.  From S to T,  not got enough core force ever, is that patch so mass or mess ?   It's lots of detail stuff, though.13:46
ConquerorHello everybody, I want to move VM from one project to another. How can I do that? I was googling and found the using nova-image download and nova-image create commands.. But, there should be an easier way to do this...13:47
dansmithsean-k-mooney: I'll take a look at this13:47
sean-k-mooneydansmith: you will love it amost as much as jay would13:48
*** openstackgerrit has quit IRC13:48
dansmithConqueror: there's not13:49
dansmithConqueror: you can try this, but it's just a POC. Worked at some point, but buyer beware: https://github.com/kk7ds/oschown13:49
sean-k-mooneyoh speaking of ^ we were ment to propose moving that to openstack/oschown at somepoint13:50
yonglihedansmith, sean-k-mooney: thanks.13:50
sean-k-mooneyand then moving each module into the indeivgual projects and importing it via stevador13:51
*** Bidwe_jay65 has joined #openstack-nova13:51
sean-k-mooneyi wonder if we ever opensed a bug/blueprint or somthing to track that so we dont have the same converstaion next time13:51
*** med_ has joined #openstack-nova13:51
*** spatel has joined #openstack-nova13:52
*** spatel has quit IRC13:52
*** francoisp has joined #openstack-nova13:52
*** shilpasd has quit IRC13:53
*** Bidwe_jay has quit IRC13:54
*** Bidwe_jay87 has quit IRC13:54
Conquerordansmith, wow this looks very good :)13:57
dansmithConqueror: trust me, it's not :)13:57
Conquerordansmith, :D13:57
*** mkrai_ has quit IRC13:58
*** mkrai__ has joined #openstack-nova13:58
*** ratailor has quit IRC14:04
efrieddansmith: on a resize, does the 'flavor' arg to migrate_disk_and_power_off represent the new size?14:08
efried...and the old size can be had via instance.flavor?14:09
*** openstackgerrit has joined #openstack-nova14:18
openstackgerritMerged openstack/nova-specs master: add spec "show-server-numa-topology"  https://review.opendev.org/65871614:18
dansmithefried: argument, probably, but I'd  have to look.. efried instance has an old_flavor and new_flavor property during resize14:19
efrieddansmith: Based on what the libvirt driver is doing with it, it looks like instance.flavor is the old one and flavor is the new one.14:19
efriedthanks14:19
dansmithefried: instance.flavor doesn't change until it changes I think, but old_flavor and new_flavor should be set14:20
efriedcool14:20
*** mriedem_afk is now known as mriedem14:20
mriedemmigrate_disk_and_power_off happens in resize_instance on the source, right?14:20
efriedyes14:20
mriedempretty sure that code flips the instance.flavor to new_flavor before calling the driver14:20
mriedemi have this code mostly memorized by now14:21
dansmithI thought it was after poweroff14:21
efriedI don't actually need to know the details right now; just wanted to make sure both flavors are available in some form to the virt driver at the early stage of the resize. See ML.14:21
mriedemoh i was thinking of this https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L468614:21
mriedemwe do'nt update the instance.flavor to the new flavor until finish_resize on the dest14:22
dansmithyeah, that's what I thought14:22
mriedemhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L455014:22
mriedeminstance_type in that case is the new flavor14:22
mriedeminstance.flavor is still the old flavor14:22
efriedtldr: ironic could theoretically implement a super-restricted same-node-only 'resize' to twiddle tunables in their deploy template.14:22
mriedemand instance.new_flavor is set before that https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L433814:22
mriedemwell you don't even need the flavor to determine if it's the same host14:23
mriedemwe pass in the dest host, so you'd just check if dest_host == CONF.host14:23
mriedemthat doesn't tell you it's the same node...14:24
efriedokay, but they also need to be able to make sure that nothing has changed outside the limited subset of allowable changes14:24
efriedswhy they would need the flavors14:24
*** Dinesh_Bhor has joined #openstack-nova14:25
efriedbut yeah, also some way to know it's same-node. Maybe that part wouldn't be wrong to do in the cond/api14:25
mriedemso...gonna plumb this all up through the api and everything just to eventually have the ironic driver check if the only thing changing in the new flavor is the deploy template and fail if not?14:25
efriedwell, except the plumbing is already there, no?14:26
efriedbasically all they have to do is implement two virt driver methods to make it work the dumb way14:26
mriedemi wouldn't assume so14:26
efriedand yeah, late fail14:26
efriedbut that's no different than e.g. libvirt failing if you try to downsize the eph disk14:26
mriedemthe api / controller is pretty opinionated that during a move operation the host:node relationship is 1:1 b/c we don't support moving baremetal instances14:26
mriedemand you've got the CONF.allow_resize_to_same_host issues14:27
mnasereh, it looks like there is no nested virt trait eh?14:27
mriedemwhich reminds me of https://bugs.launchpad.net/nova/+bug/1819216 but that's for cold migration14:27
openstackLaunchpad bug 1819216 in OpenStack Compute (nova) "in devstack, "nova migrate <uuid>" will try to migrate to the same host (and then fail)" [Medium,Triaged]14:27
efriedmnaser: wha?14:27
*** dpawlik has quit IRC14:27
mnasernot all of our hypervisors have been updated to have nested virt enabled (its disabled by default on rhel based hosts)14:28
mnaserso i was hoping to create a flavor for a user so they always got a machine that had nested virt14:28
mnaser(rather than building a host aggregate and trying to keep it sync'd)14:28
*** _alastor_ has joined #openstack-nova14:30
mriedemdoes HW_CPU_X86_VMX only show up on your nested virt enabled hosts?14:30
efriedsorry, this isn't going to be very helpful, but what does "nested virt" mean?14:30
mnaserefried: oh sorry, it means enabling an option in kvm to expose the vmx flag to the virtual machine14:31
mnaserso that it can start up kvm accelerated vms (instead of qemu emulated ones)14:31
kashyapefried: It means you're running on "turtles all the way down"14:31
* efried has days like that14:31
kashyapIt's only a part troll; as the original nested virt paper was titled that way14:31
mnaserHW_CPU_X86_VMX will probably always be exposed on the host i assume (though libvirt can give you the answer if its enabled or not)14:31
dansmithefried: it means... if random() % 10 < 4, segfault()14:31
kashyaphttps://www.usenix.org/legacy/events/osdi10/tech/slides/ben-yehuda.pdf14:31
mnaserlolol14:31
kashyapSorry, here's the paper: "The Turtles Project": https://www.usenix.org/legacy/event/osdi10/tech/full_papers/Ben-Yehuda.pdf14:32
artom|gmtplus3mnaser, are flavors with more than 1 NUMA node also in the pipeline?14:32
mnaserit's actually been pretty stable in kata's ci (in our nested virt hosts) and doing nested virt on newer kernels is pretty well14:32
mnaserartom|gmtplus3: in this case, no14:32
mnaserbut we've looked into it in the past :>14:32
mnaserbut yeah, im gonna guess HW_CPU_X86_VMX is probably exposed in all kvm hosts14:32
* mnaser checks14:32
dansmithI would expect the same, FWIW14:33
dansmithI think those come from host caps14:33
kashyapmnaser: Nit-pick: "nested virt" can mean QEMU or KVM in level-1 :-).  I use nested KVM to distinguish the "no emulator" part.14:33
artom|gmtplus3mnaser, because I will be eternally grateful when they come :)14:33
mnaserkashyap: oh cool, good to know14:33
mnaserartom|gmtplus3: i'll keep that in mind then :)14:33
artom|gmtplus3mnaser, heh, I don't need to tell you how badly we're missing NUMA test coverage with real hardware :)14:34
kashyapmnaser: So, as mriedem said, assuming you have 'nested' as '1' on bare metal, and then set the flavor property:14:35
*** Luzi has quit IRC14:35
kashyapopenstack flavor set 1 --property trait:HW_CPU_X86_VMX=required`14:35
kashyapThen launching the level-1 guest (or "guest hypervisor") should have VMX exposed14:35
mriedemyonglihe: regarding https://review.opendev.org/#/c/627765/ i remember hearing at the ptg that there were concerns that it duplicated too much of _cleanup_running_deleted_instances and asked if it could just be integrated into _cleanup_running_deleted_instances with new choices for the running_deleted_instance_action option, but i'm not sure how feasible that is (or beneficial)14:35
kashyapmnaser: dansmith: By the way GCE officially supports nested KVM; they've even done (in the community) extensive security audit, FWIW.14:37
dansmithkashyap: omg, I'm convinced.14:37
kashyapGood; otherwise, you need to show data for not being convinced ;-)14:38
dansmithkashyap: you don't remember this,14:38
*** lpetrut has quit IRC14:38
dansmithbut when I joined redhat almost six years ago, my first interaction with you was you saying this exact thing14:38
dansmiththat nested virt was 110% ready for prime time and you were fine if your bank ran it14:39
dansmithdon't make me dig up the logs, 'cause I'll do it!14:39
kashyapI'm pretty confident I don't make such superlative remarks.  Do dig them up14:40
kashyapI used to systematically file kernel bugs since 2013 for nested KVM14:40
dansmithsuperlatives are mine :)14:40
kashyapAnd 98% of them are resolved (https://kashyapc.fedorapeople.org/kernel-kvm-bugs.txt)14:40
*** Dinesh_Bhor has quit IRC14:40
kashyapSure, there are cases where it doesn't work; but what exists already works for good number of cases14:40
kashyapHeck, even upstream kernel itself now has 'nested' flag enabled by default for Intel14:41
mnaser^ yeah, i've seen this updated lately too14:41
*** panda has quit IRC14:41
sean-k-mooneyit was enabled in 4.19 ish14:41
sean-k-mooneymaybe a little earlier14:42
kashyap[https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1e58e5e]14:42
kashyap["KVM: VMX: enable nested virtualization by default14:42
kashyap]14:42
sean-k-mooneythere were some bug in both the ubuntu kernel however until 4.2014:42
sean-k-mooneyfedora was broken too14:43
sean-k-mooneybut the upstream on was fine14:43
dansmithheh, Celebrated-By.. that's one I haven't seen14:43
*** panda has joined #openstack-nova14:43
kashyapdansmith: Then you will enjoy this: https://lwn.net/Articles/503829/14:43
kashyapA sample from the KM-long list:14:44
kashyap- Bitten-by-and-tested-by:14:44
kashyap- Antagonized-by:14:44
kashyap- Fatfingered-by:14:44
kashyap- Signed-off-and-morning-tea-spilled-by:14:44
dansmithyup, nice14:44
*** mdbooth has quit IRC14:45
artom|gmtplus3Drive-by: Shoo Ting14:45
kashyapmnaser: Live migrating level-1 guest (level-2 can be migrated fine) is the remaining gnarly problem that is being worked on (both in KVM and QEMU)14:45
sean-k-mooneyso Most-Definitely-Acked-by:14:46
sean-k-mooneyMostly-acked-by:14:46
sean-k-mooneyNACKed-by:14:46
sean-k-mooneyare used as +2 +1 and -114:46
sean-k-mooneyalso i like More-or-less-tested-by14:46
mriedemkashyap: what are the chances GCE has forked everything to make nested KVM work for just their cloud?14:47
dansmith*gasp*14:48
dansmiththey would NEVER do such a thing, surely14:48
*** igordc has joined #openstack-nova14:49
kashyapmriedem: The chances are 100% sunny :D  I see what you mean, they do have their kernel; that said ... they contribute most KVM-related stuff back to the upstream, and post results of security audit, too14:49
*** mdbooth has joined #openstack-nova14:49
sean-k-mooneymriedem: from my past experience with kvm it works beeter if you use a vanial upstream kernel then a disto packaged one although that has change in the last 12-18 months or so as i think distors have got better at testing nested virt or just break it less14:50
mriedemhmm, me checks notes...sean says things from a distro are better since about the time he started working for a distro...yup it checks out14:52
sean-k-mooneygoes back to his ubunut based laptop...14:53
dansmithmmm, ubunut14:53
dansmiththat has to be about the best ubuntu type I've seen14:53
sean-k-mooneymy devstack vms are centos14:53
dansmith*typo, hah14:53
* artom|gmtplus3 is more impressed they can make laptops out of them14:54
mriedemdid you know a cashew is not a nut?14:54
dansmithartom|gmtplus3: like a fancy brazilian walnut laptop, or the *really* fancy "ubunut" laptop14:54
sean-k-mooney:)14:54
*** mkrai_ has joined #openstack-nova14:55
*** mkrai__ has quit IRC14:55
*** udesale has quit IRC14:55
sean-k-mooneymriedem: that was most based on the fact that centos finally started to wrok with nested vert although canonica broke it in 18.04 which made me sad14:55
mriedemlyarwood: just so you're aware, stable/stein and rocky are essentially blocked until these devstack changes land https://review.opendev.org/#/q/I0d7f9f2baaee2836a719f199939156bd4f53f77814:55
artom|gmtplus3Oh, not the whole laptop, just the CPU: Hazwellnut architecture :D14:56
sean-k-mooneyhaha i would totally by that14:56
lyarwoodmriedem: was that behind tempest-slow etc timing out due to the network tests taking ages?14:57
lyarwoodah nvm it doesn't look like it is14:58
*** munimeha1 has quit IRC14:59
mriedemthe agent on the tempest-slow jobs blows up15:00
lyarwoodah I see15:01
lyarwoodwell thanks for the heads up, I've had a tab open to look at that all day, I'll get on with some reviews once that has started to land in stable.15:02
sean-k-mooneydansmith: im always amazed by how many grammer and spelling issue my brain just completely ignores15:04
dansmithsean-k-mooney: and they make it really difficult for me to concentrate on the content.. diff'rent strokes.15:05
sean-k-mooneyya, it just show how differently we read. not that you have pointed them out they are obvious but without your commets my brain just fills in the gaps/corrects them on the fly unless i force myself to read word by word really slowly15:07
artom|gmtplus3Yeah, there's a "severity" boundary where it switches from "distracting but harmless" to "active sabotage"15:08
jangutterartom|gmtplus3: the late, great Iain M Banks had one of the most frustratingly good stories that tripped that balance in "Feersum Endjinn"15:10
mriedemyay everything i had in the gate last night failed with RETRY_LIMIT and now i get to recheck everything15:10
artom|gmtplus3jangutter, will read15:10
sean-k-mooneyjangutter: im kind of tempted to read that15:12
jangutterI think he's much more known for the Culture work, but FE was a good diversion. Just be warned that some chapters are physically hard to read, intentionally.15:14
sean-k-mooneyi have no issue reading "Woak up. Got dresd. Had brekfast. Spoke wif Ergates thi ant who sed itz juss been wurk wurk wurk 4 u lately master Bascule, Y dont u ½ a holiday? & I agreed & that woz how we decided we otter go 2 c Mr Zoliparia in thi I-ball ov thi gargoyle Rosbrith. "15:15
*** sapd1_x has joined #openstack-nova15:16
*** lpetrut has joined #openstack-nova15:17
efriedmriedem: would you please give this a quick look for sanity https://review.opendev.org/655985 before I invest in test?15:19
*** ccamacho has quit IRC15:22
artom|gmtplus3sean-k-mooney, your brain is weird, I can barely parse that15:23
*** lpetrut has quit IRC15:23
*** xek has quit IRC15:26
sean-k-mooneyartom|gmtplus3: "Woke up. Got dressed. Had breakfast. spoke with Ergates the ant, who said, it's just been work work work for you lately master Bascule, why dont you have a holiday? And i aggred, an that was how we decied we ought to go to see Mr Zoliparia in the eye ball of the gargoyle Rosbrith." :)15:29
*** BjoernT_ has joined #openstack-nova15:29
artom|gmtplus3sean-k-mooney, aha, thi = the didn't register at all15:29
artom|gmtplus3I was thinking "thy", the old English possessive15:29
*** yan0s has joined #openstack-nova15:30
*** BjoernT has quit IRC15:30
* artom|gmtplus3 -> done15:30
sean-k-mooneyo/15:30
*** igordc has quit IRC15:32
*** xek has joined #openstack-nova15:34
mriedemefried: comments inline15:34
*** artom|gmtplus3 has quit IRC15:34
*** jaosorior has quit IRC15:38
*** jaosorior has joined #openstack-nova15:38
*** ttsiouts has quit IRC15:39
*** ttsiouts has joined #openstack-nova15:40
*** sapd1_x has quit IRC15:40
openstackgerritMatt Riedemann proposed openstack/nova master: (Re-)enable vnc console tests in nova-multi-cell job  https://review.opendev.org/66738815:42
*** xek has quit IRC15:43
*** tssurya has quit IRC15:43
*** ttsiouts has quit IRC15:44
*** mkrai_ has quit IRC15:50
*** mkrai__ has joined #openstack-nova15:50
openstackgerritKashyap Chamarthy proposed openstack/nova stable/stein: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path  https://review.opendev.org/66738915:51
*** sapd1_x has joined #openstack-nova15:51
*** hamzy has quit IRC15:54
*** rajinir has joined #openstack-nova15:55
*** damien_r has quit IRC16:00
*** luksky has quit IRC16:00
*** BjoernT has joined #openstack-nova16:00
*** sapd1_x has quit IRC16:02
*** BjoernT_ has quit IRC16:02
*** udesale has joined #openstack-nova16:03
*** igordc has joined #openstack-nova16:04
*** yan0s has quit IRC16:05
*** mkrai__ has quit IRC16:05
openstackgerritBalazs Gibizer proposed openstack/nova master: Functional reproduce for bug 1833581  https://review.opendev.org/66739616:09
openstackbug 1833581 in OpenStack Compute (nova) "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer)16:09
openstackgerritBalazs Gibizer proposed openstack/nova master: Error out interrupted builds  https://review.opendev.org/66685716:09
openstackgerritBalazs Gibizer proposed openstack/nova master: Functional reproduce for bug 1833581  https://review.opendev.org/66739716:09
openstackgerritBalazs Gibizer proposed openstack/nova master: Enhance service restart in functional env  https://review.opendev.org/51255216:11
openstackgerritBalazs Gibizer proposed openstack/nova master: Add functional test coverage for bug 1724172  https://review.opendev.org/51255316:11
openstackbug 1724172 in OpenStack Compute (nova) rocky "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,Confirmed] https://launchpad.net/bugs/172417216:11
openstackgerritBalazs Gibizer proposed openstack/nova master: Functional reproduce for bug 1833581  https://review.opendev.org/66739616:12
openstackbug 1833581 in OpenStack Compute (nova) "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer)16:12
openstackgerritStephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands  https://review.opendev.org/66716416:13
openstackgerritStephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation  https://review.opendev.org/66716516:13
openstackgerritBalazs Gibizer proposed openstack/nova master: Error out interrupted builds  https://review.opendev.org/66685716:14
stephenfindansmith: Want to take another look through this? https://review.opendev.org/#/c/666629/16:16
*** maciejjozefczyk has quit IRC16:21
*** belmoreira has quit IRC16:24
dansmithstephenfin: will in a bit16:29
stephenfinno rush16:30
openstackgerritStephen Finucane proposed openstack/nova master: Remove no longer required "inner" methods.  https://review.opendev.org/65528216:31
openstackgerritStephen Finucane proposed openstack/nova master: Privsepify ipv4 forwarding enablement.  https://review.opendev.org/63543116:31
openstackgerritStephen Finucane proposed openstack/nova master: Remove unused FP device creation and deletion methods.  https://review.opendev.org/63543316:31
openstackgerritStephen Finucane proposed openstack/nova master: Privsep the ebtables modification code.  https://review.opendev.org/63543516:31
openstackgerritStephen Finucane proposed openstack/nova master: Move adding vlans to interfaces to privsep.  https://review.opendev.org/63543616:31
openstackgerritStephen Finucane proposed openstack/nova master: Move iptables rule fetching and setting to privsep.  https://review.opendev.org/63650816:31
openstackgerritStephen Finucane proposed openstack/nova master: Move dnsmasq restarts to privsep.  https://review.opendev.org/63928016:31
openstackgerritStephen Finucane proposed openstack/nova master: Move router advertisement daemon restarts to privsep.  https://review.opendev.org/63928116:31
openstackgerritStephen Finucane proposed openstack/nova master: Move calls to ovs-vsctl to privsep.  https://review.opendev.org/63928216:31
openstackgerritStephen Finucane proposed openstack/nova master: Move setting of device trust to privsep.  https://review.opendev.org/63928316:31
openstackgerritStephen Finucane proposed openstack/nova master: Move final bridge commands to privsep.  https://review.opendev.org/63958016:31
openstackgerritStephen Finucane proposed openstack/nova master: Cleanup the _execute shim in nova/network.  https://review.opendev.org/63958116:31
openstackgerritStephen Finucane proposed openstack/nova master: We no longer need rootwrap.  https://review.opendev.org/55443816:31
openstackgerritStephen Finucane proposed openstack/nova master: Cleanup no longer required filters and add a release note.  https://review.opendev.org/63982616:31
efriedthanks mriedem16:33
*** ricolin has quit IRC16:33
*** tesseract has quit IRC16:35
*** tesseract has joined #openstack-nova16:36
mriedemefried: how do you feel about having a mini personal goal of making https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L985-L997 obsolete for in-tree drivers so we could deprecate or remove it in Train - out of tree drivers could be hit so if we wanted to be nice we'd just log a deprecation warning in T and remove in U16:41
mriedemthe only in-tree drivers that would hit those paths are xenapi and hyperv,16:41
mriedemthe former implements get_inventory,16:41
mriedemthe latter implements neither get_inventory or upt16:41
mriedemoh looky here the hyperv out of tree driver has upt implemented https://opendev.org/openstack/compute-hyperv/src/branch/master/compute_hyperv/nova/driver.py#L46416:43
efriedmriedem: I'm big in favor of this. At some point I looked into doing it myself, but it (possibly hyperv) was going to be hairier than I was ready to deal with at that time.16:44
efriedmriedem: by "personal" you mean me or you?  :P16:46
efriedstephenfin: I should wait to re-look at rootwrap series, yes?16:46
*** panda has quit IRC16:46
mriedemefried: as in something we call each other about late on a friday night to talk about yes16:47
efriedstephenfin: The 'done' on the ipv4 patch is still forthcoming?16:47
openstackgerritMatt Riedemann proposed openstack/nova master: Fix update_provider_tree signature in reference docs  https://review.opendev.org/66740816:47
stephenfinefried: 2 secs16:47
efriedmriedem: ack, I like it.16:47
stephenfinActually, I want to test this more so I'll leave it til the morning16:48
*** panda has joined #openstack-nova16:48
stephenfinefried: Sort of. I'm going to drop the first patch and then address the open TODOs in the remainder. If you want to take a look at any you haven't reviewed yet though, that could be helpful16:48
efriedsomething weird just happened16:49
stephenfinOhh, that's interesting16:50
stephenfinI Ctrl + C'd git-review during the upload once I realized I'd more work to do16:50
efriedbot didn't notify, and when I look at the review it seems... corrupted.16:50
efriedthe series isn't showing up on the right16:51
stephenfinFeck it, I'll push it again just to fix that16:51
openstackgerritStephen Finucane proposed openstack/nova master: Privsepify ipv4 forwarding enablement.  https://review.opendev.org/63543116:51
openstackgerritStephen Finucane proposed openstack/nova master: Remove unused FP device creation and deletion methods.  https://review.opendev.org/63543316:51
openstackgerritStephen Finucane proposed openstack/nova master: Privsep the ebtables modification code.  https://review.opendev.org/63543516:51
openstackgerritStephen Finucane proposed openstack/nova master: Move adding vlans to interfaces to privsep.  https://review.opendev.org/63543616:51
openstackgerritStephen Finucane proposed openstack/nova master: Move iptables rule fetching and setting to privsep.  https://review.opendev.org/63650816:51
openstackgerritStephen Finucane proposed openstack/nova master: Move dnsmasq restarts to privsep.  https://review.opendev.org/63928016:51
openstackgerritStephen Finucane proposed openstack/nova master: Move router advertisement daemon restarts to privsep.  https://review.opendev.org/63928116:51
openstackgerritStephen Finucane proposed openstack/nova master: Move calls to ovs-vsctl to privsep.  https://review.opendev.org/63928216:51
openstackgerritStephen Finucane proposed openstack/nova master: Move setting of device trust to privsep.  https://review.opendev.org/63928316:51
openstackgerritStephen Finucane proposed openstack/nova master: Move final bridge commands to privsep.  https://review.opendev.org/63958016:51
openstackgerritStephen Finucane proposed openstack/nova master: Cleanup the _execute shim in nova/network.  https://review.opendev.org/63958116:51
openstackgerritStephen Finucane proposed openstack/nova master: We no longer need rootwrap.  https://review.opendev.org/55443816:51
openstackgerritStephen Finucane proposed openstack/nova master: Cleanup no longer required filters and add a release note.  https://review.opendev.org/63982616:51
*** admin0 has joined #openstack-nova16:52
efriedthat seems to have worked.16:53
stephenfinIndeed16:53
stephenfinand with that16:53
efriedwhy did you drop the bottom patch?16:53
sean-k-mooney thats strang it should not have currpted it16:53
* stephenfin -> 🏡16:53
stephenfinefried: It seemed like you didn't want it https://review.opendev.org/#/c/655282/16:53
efriedstephenfin: just one piece of it. The rest was good.16:54
efriedanyway, can do it elsewhere in the series16:54
stephenfinAh, then I can come back and stick that back in higher up in the series16:54
efried++ thanks stephenfin16:54
*** igordc has quit IRC16:56
*** tesseract has quit IRC16:59
*** igordc has joined #openstack-nova16:59
*** udesale has quit IRC17:07
openstackgerritMatt Riedemann proposed openstack/nova master: Implement update_provider_tree  https://review.opendev.org/66741717:11
*** hamzy has joined #openstack-nova17:12
*** ralonsoh has quit IRC17:20
openstackgerritMatt Riedemann proposed openstack/nova master: Clean up test_virtapi  https://review.opendev.org/66741917:24
*** ociuhandu has joined #openstack-nova17:41
*** ociuhandu_ has quit IRC17:44
openstackgerritLee Yarwood proposed openstack/nova master: WIP libvirt: Add rbd_connect_timeout configurable  https://review.opendev.org/66742117:44
*** ociuhandu has quit IRC17:45
openstackgerritGhanshyam Mann proposed openstack/nova master: Multiple API cleanup changes  https://review.opendev.org/66688918:05
openstackgerritMatt Riedemann proposed openstack/nova master: xenapi: implement update_provider_tree  https://review.opendev.org/66743518:29
openstackgerritMatt Riedemann proposed openstack/nova master: xenapi: implement update_provider_tree  https://review.opendev.org/66743518:32
openstackgerritKashyap Chamarthy proposed openstack/nova stable/rocky: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path  https://review.opendev.org/66743618:39
*** luksky has joined #openstack-nova18:53
openstackgerritMatt Riedemann proposed openstack/nova master: Deprecate non-update_provider_tree compat code  https://review.opendev.org/66744218:54
mriedemefried: thoughts on only logging the warning on startup in ^ or every update_available_resource periodic?18:55
mriedemthe latter would be really chatty, but maybe that's the level of annoying we want18:55
*** hongbin has joined #openstack-nova19:02
NewBruceevening all! mriedem have you seen this issue before mate?19:11
NewBruce2019-06-25 20:47:45.167 166805 INFO nova.compute.manager [req-bda9173a-31ed-447f-bf57-3ad85c565141 - - - - -] [instance: 5123fa51-512f-4f13-ae4b-5bbc7dd64e94] Migrating instance to cc-compute25-sto2 finished successfully.19:11
NewBruce2019-06-25 20:47:45.302 166805 WARNING nova.virt.libvirt.driver [req-bda9173a-31ed-447f-bf57-3ad85c565141 - - - - -] [instance: 5123fa51-512f-4f13-ae4b-5bbc7dd64e94] Error monitoring migration: Compute host cc-compute04-sto2 could not be found.: ComputeHostNotFound: Compute host cc-compute04-sto2 could not be found.19:11
*** mlavalle has joined #openstack-nova19:12
NewBrucegot me stumped…. and why always me and migration issues? :)19:12
NewBrucethe instance is migrated, but is left in status ERROR19:12
*** cfriesen has joined #openstack-nova19:15
*** mriedem has quit IRC19:15
*** mriedem has joined #openstack-nova19:16
*** lpetrut has joined #openstack-nova19:18
NewBruceNot sure if its related, but the source node is throwing this error… a lot19:21
NewBruce  File "/openstack/venvs/nova-18.0.0/lib/python2.7/site-packages/oslo_utils/timeutils.py", line 68, in parse_isotime19:21
NewBruce    raise ValueError(six.text_type(e))19:21
NewBruceValueError: year is out of range19:21
*** lpetrut has quit IRC19:23
Nick_Awhy is nova (?) metadata sending all /24 routes in a region to each instance? http://paste.openstack.org/show/y0lE42EA59yhnu7G1KnY/19:36
*** pcaruana has quit IRC19:38
mriedembauzas: dansmith: i take it from the comments here https://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L150 that one shouldn't rely on ComputeNode.service_id is that correct?19:39
mriedemthe Service object has a compute_node field, and ComputeNode has a nullable service_id19:39
mriedembut it looks like neither should really be used...19:39
dansmithum, I dunno19:39
*** factor has joined #openstack-nova19:39
*** icarusfactor has quit IRC19:40
mriedemala https://github.com/openstack/nova/commit/551be2c52a29cb2755de4825a3fcb2c8f7d7b3f1 and https://github.com/openstack/nova/commit/0b177f18264ca842e16c2c989a081e773b3d86b719:40
mriedemok, lots of really old compat notes from bauzas in all of that code19:40
mriedemgoing back to kilo/liberty era19:41
mriedemwonder if we'll ever clean that stuff up19:41
dansmithyeah,19:41
dansmithI'd think that that comment is probably old and that a migration fixed the ambiguity long ago, but.. I haven't looked19:41
mriedemhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L12319:43
mriedemi don't think there was ever a migration19:43
mriedemjust lots of todos from ~liberty19:44
dansmithhrm19:45
mriedemok i'd think the migration would be pretty simple,19:45
mriedemiterate cells looking for compute_nodes where host is null19:46
mriedemif so, find their service record and update the compute_nodes.host value19:46
mriedemor a migration run per-cell (we haven't really be consistent there)19:46
dansmithor just have computes update compute nodes on RT update19:46
dansmithno reason to make it a manual-only thing19:47
mriedemyeah i don't think it's even possible to get through RT with a cn that doesn't have a host value set19:48
mriedemwe lookup the cn by host and node and if it doesn't exist we create it and always have those values set now19:48
mriedemso...maybe this is as good as a simple nova-status upgrade check to sniff out anything lingering and in U drop all of this compat code19:48
dansmithsure19:48
mriedemnot sure we'd want to do the db alter table statements to make the column non-nullable...19:48
mriedembut that's less of an issue19:48
efriedmriedem: upt also gets called on spawn & delete, doesn't it?20:03
efriedvia update_available_resource20:03
*** bbowen has quit IRC20:03
mriedemefried: i don't think so, you're thinking of instance_claim20:05
efriedokay20:05
mriedemand rt.update_usage20:06
mriedem^ is the one that has the vm_state check for DELETED/SHELVED_OFFLOADED on the instance and if it's one of those it removes the usage20:06
mriedemlooks like _post_live_migration also hits update_available_resource for kicks20:07
mriedempresumably b/c we don't do rt claims for live migration20:08
efriedokay, so chattier than just once every 10 minutes.20:12
sean-k-mooneymriedem: well we do in some cases20:14
sean-k-mooneymriedem: we claim pci devices for the sriov case and we will claim cpus and hugepages once artoms numa migration code lands20:14
mriedemupdate_available_resource is once per minute i think20:15
mriedemhttps://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.update_resources_interval20:15
mriedemhttps://github.com/openstack/oslo.service/blob/master/oslo_service/periodic_task.py#L3120:15
sean-k-mooneyits configurable in the config but i thought it was 300 seconds20:16
mriedemi think you're both high on goofballs20:16
mriedemefried: so every minute by default20:17
sean-k-mooneyon no its 60s you are right https://docs.openstack.org/nova/latest/configuration/config.html#scheduler.periodic_task_interval20:17
sean-k-mooneyoh wait is that only set for the schduler ? i though we had a compute node version too?20:18
*** factor has quit IRC20:20
*** factor has joined #openstack-nova20:21
*** ohwhyosa- has quit IRC20:24
*** ivve has quit IRC20:24
* mriedem hangs head20:24
mriedemwhat are you asking20:24
mriedemhttps://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.update_resources_interval is used by the ComputeManager.update_available_resource periodic task20:24
*** francoisp has quit IRC20:25
*** factor has quit IRC20:31
*** factor has joined #openstack-nova20:32
*** hamzy has quit IRC20:33
openstackgerritEric Fried proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models  https://review.opendev.org/64203020:40
*** factor has quit IRC20:52
*** factor has joined #openstack-nova20:52
*** ttsiouts has joined #openstack-nova20:55
*** factor has quit IRC20:59
*** slaweq has quit IRC20:59
*** slaweq has joined #openstack-nova21:11
*** slaweq has quit IRC21:15
*** openstackgerrit has quit IRC21:18
*** ttsiouts has quit IRC21:22
*** ttsiouts has joined #openstack-nova21:22
*** slaweq has joined #openstack-nova21:26
*** ttsiouts has quit IRC21:27
*** slaweq has quit IRC21:31
*** factor has joined #openstack-nova21:37
*** openstackgerrit has joined #openstack-nova21:38
openstackgerritsean mooney proposed openstack/nova-specs master: add libvirt pqos spec  https://review.opendev.org/66226421:38
openstackgerritEric Fried proposed openstack/nova-specs master: Add spec for expose-auto-converge-post-copy  https://review.opendev.org/65168121:39
*** jaypipes has quit IRC21:46
*** tobberydberg has quit IRC21:49
*** tobberydberg has joined #openstack-nova21:51
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add placement request filter for disabled computes  https://review.opendev.org/65459621:52
*** mriedem has quit IRC21:52
*** rdopiera has quit IRC22:02
*** _erlon_ has quit IRC22:18
*** BjoernT has quit IRC22:23
*** sean-k-mooney has quit IRC22:31
*** luksky has quit IRC22:34
*** mlavalle has quit IRC22:40
*** sapd1_x has joined #openstack-nova22:41
*** bbowen has joined #openstack-nova22:48
*** tkajinam has joined #openstack-nova22:56
*** rcernin has joined #openstack-nova23:05
*** hongbin has quit IRC23:07

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!