*** threestrands has joined #openstack-nova | 00:04 | |
*** rcernin has quit IRC | 00:06 | |
*** eharney has quit IRC | 00:15 | |
*** rcernin has joined #openstack-nova | 00:18 | |
*** sapd1_x has joined #openstack-nova | 00:27 | |
*** sapd1_x has quit IRC | 00:44 | |
*** ajo has quit IRC | 00:51 | |
*** ajo has joined #openstack-nova | 00:51 | |
*** masayukig has quit IRC | 00:51 | |
*** mrhillsman has quit IRC | 00:51 | |
*** awestin1 has quit IRC | 00:52 | |
*** niceplace has quit IRC | 00:52 | |
*** masayukig has joined #openstack-nova | 00:53 | |
*** awestin1 has joined #openstack-nova | 00:54 | |
*** niceplace has joined #openstack-nova | 00:54 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: doc: Fix nova-manage cell_v2 list_cells output https://review.opendev.org/666995 | 01:10 |
---|---|---|
*** rcernin has quit IRC | 01:12 | |
*** markvoelker has quit IRC | 01:14 | |
*** markvoelker has joined #openstack-nova | 01:16 | |
*** rcernin has joined #openstack-nova | 01:17 | |
*** brinzhang has joined #openstack-nova | 01:21 | |
*** Dinesh_Bhor has quit IRC | 01:27 | |
*** Dinesh_Bhor has joined #openstack-nova | 01:31 | |
*** threestrands has quit IRC | 01:41 | |
*** jhesketh has quit IRC | 02:12 | |
*** jhesketh has joined #openstack-nova | 02:13 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.opendev.org/641200 | 02:24 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.opendev.org/566153 | 02:29 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020 | 02:29 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027 | 02:31 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031 | 02:31 |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Add a guide to add a new microversion support https://review.opendev.org/667002 | 02:46 |
*** dklyle has quit IRC | 03:00 | |
*** psachin has joined #openstack-nova | 03:16 | |
openstackgerrit | Merged openstack/nova master: extend libvirt video model support https://review.opendev.org/647733 | 03:53 |
*** whoami-rajat has joined #openstack-nova | 03:54 | |
*** udesale has joined #openstack-nova | 04:01 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299 | 04:11 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344 | 04:11 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673 | 04:11 |
*** bhagyashris has joined #openstack-nova | 04:14 | |
*** ricolin has joined #openstack-nova | 04:19 | |
*** adrianreza has joined #openstack-nova | 04:44 | |
*** ivve has joined #openstack-nova | 04:51 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676 | 05:32 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689 | 05:33 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709 | 05:33 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712 | 05:33 |
*** ratailor has joined #openstack-nova | 05:40 | |
*** Luzi has joined #openstack-nova | 05:45 | |
*** brault has joined #openstack-nova | 06:02 | |
*** ildikov_ has joined #openstack-nova | 06:07 | |
*** coreycb_ has joined #openstack-nova | 06:08 | |
*** tinwood_ has joined #openstack-nova | 06:10 | |
*** Anticime1 has joined #openstack-nova | 06:10 | |
*** ircuser-1 has joined #openstack-nova | 06:14 | |
*** gouthamr_ has joined #openstack-nova | 06:14 | |
*** tinwood has quit IRC | 06:15 | |
*** coreycb has quit IRC | 06:15 | |
*** smcginnis has quit IRC | 06:15 | |
*** Anticimex has quit IRC | 06:15 | |
*** fnordahl has quit IRC | 06:15 | |
*** ildikov has quit IRC | 06:15 | |
*** gouthamr has quit IRC | 06:15 | |
*** coreycb_ is now known as coreycb | 06:15 | |
*** ildikov_ is now known as ildikov | 06:15 | |
*** irclogbot_3 has quit IRC | 06:18 | |
*** dpawlik has joined #openstack-nova | 06:18 | |
*** panda has quit IRC | 06:18 | |
*** alex_xu has quit IRC | 06:18 | |
*** ccamacho has joined #openstack-nova | 06:19 | |
*** irclogbot_0 has joined #openstack-nova | 06:19 | |
*** panda has joined #openstack-nova | 06:20 | |
*** pcaruana has joined #openstack-nova | 06:25 | |
*** belmoreira has joined #openstack-nova | 06:44 | |
*** martinkennelly has joined #openstack-nova | 06:47 | |
*** lpetrut has joined #openstack-nova | 06:49 | |
*** rdopiera has joined #openstack-nova | 06:52 | |
*** rcernin has quit IRC | 06:57 | |
*** maciejjozefczyk has joined #openstack-nova | 06:58 | |
*** damien_r has joined #openstack-nova | 07:02 | |
*** damien_r has quit IRC | 07:02 | |
*** damien_r has joined #openstack-nova | 07:03 | |
*** damien_r has quit IRC | 07:03 | |
*** damien_r has joined #openstack-nova | 07:04 | |
*** markvoelker has quit IRC | 07:07 | |
*** jaosorior has joined #openstack-nova | 07:11 | |
*** tesseract has joined #openstack-nova | 07:11 | |
*** lwq has joined #openstack-nova | 07:14 | |
*** helenafm has joined #openstack-nova | 07:23 | |
*** hjensas has quit IRC | 07:25 | |
*** ccamacho has quit IRC | 07:31 | |
*** xek has joined #openstack-nova | 07:33 | |
*** brinzhang has quit IRC | 07:34 | |
*** brinzhang has joined #openstack-nova | 07:35 | |
*** ccamacho has joined #openstack-nova | 07:39 | |
*** tssurya has joined #openstack-nova | 07:39 | |
*** trident has quit IRC | 07:40 | |
*** trident has joined #openstack-nova | 07:41 | |
*** fnordahl has joined #openstack-nova | 07:44 | |
openstackgerrit | Slawek Kaplonski proposed openstack/nova master: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/667035 | 07:50 |
*** ralonsoh has joined #openstack-nova | 07:54 | |
*** luksky has joined #openstack-nova | 08:03 | |
*** ttsiouts has joined #openstack-nova | 08:04 | |
*** jaosorior has quit IRC | 08:13 | |
*** jaosorior has joined #openstack-nova | 08:17 | |
*** tkajinam has quit IRC | 08:29 | |
lyarwood | ~. | 08:36 |
*** imacdonn has quit IRC | 08:42 | |
*** imacdonn has joined #openstack-nova | 08:42 | |
*** factor has quit IRC | 08:43 | |
*** whoami-rajat has quit IRC | 08:48 | |
bhagyashris | Hi all, I am trying to live migrate the instance but getting this error: http://paste.openstack.org/show/753291/ on nova compute side can any one have nay idea about the same? | 08:55 |
kashyap | bhagyashris: My first guess from the error is that you don't have enough free RAM. | 08:57 |
kashyap | Oh, wait. Thre's also a "length mismatch" error | 08:57 |
kashyap | bhagyashris: What distro is this, and what are you rversions of libvirt and QEMU? | 09:00 |
*** udesale has quit IRC | 09:02 | |
*** udesale has joined #openstack-nova | 09:03 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886 | 09:03 |
*** udesale has quit IRC | 09:04 | |
bhagyashris | kashyap: Hi, I have pasted all details here : http://paste.openstack.org/show/753292/ please check and let me know. | 09:05 |
*** markvoelker has joined #openstack-nova | 09:08 | |
stephenfin | bhagyashris: This looks relevant https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1713490 | 09:08 |
openstack | Launchpad bug 1713490 in Ubuntu Cloud Archive "error migrating blocked on virtio-net-pci.rom" [Undecided,Confirmed] | 09:08 |
*** udesale has joined #openstack-nova | 09:08 | |
stephenfin | bhagyashris: As does this https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01663.html | 09:08 |
kashyap | stephenfin: You wouldn't believe: that "Length mismatch" is the improved (unactionable) error from QEMU | 09:09 |
kashyap | s/improved/"improved"/ (missed the scare quotes :D) | 09:09 |
stephenfin | o rly? | 09:10 |
kashyap | Yeah, checking with Dave from QEMU, he says: | 09:10 |
kashyap | < dgilbert> kashyap: So, that's a packaging bug for their virtio rom; they need to pad | 09:10 |
kashyap | stephenfin: Reference for the "improvement" (it actually _is_, though, relative to the previous one): https://bugzilla.redhat.com/show_bug.cgi?id=1090093 | 09:11 |
openstack | bugzilla.redhat.com bug 1090093 in libvirt "Improve error reporting when QEMU fails with incoming migration" [Unspecified,Closed: errata] - Assigned to jdenemar | 09:11 |
kashyap | bhagyashris: So I was told it's a distribution bug, so please file with Ubuntu. (Where the packager needs to pad the ROM with 0 bytes, using `dd`.) thanks, Dave Gilbert for the suggestion. | 09:13 |
*** udesale has quit IRC | 09:13 | |
*** udesale has joined #openstack-nova | 09:14 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047 | 09:18 |
*** ricolin has quit IRC | 09:22 | |
*** davidsha has joined #openstack-nova | 09:29 | |
*** ociuhandu has joined #openstack-nova | 09:30 | |
openstackgerrit | Sam Morrison proposed openstack/nova stable/rocky: Fix double word hacking test https://review.opendev.org/665788 | 09:32 |
*** takashin has left #openstack-nova | 09:33 | |
openstackgerrit | Sam Morrison proposed openstack/nova stable/queens: Fix double word hacking test https://review.opendev.org/665790 | 09:33 |
*** damien_r has quit IRC | 09:34 | |
*** damien_r has joined #openstack-nova | 09:36 | |
bhagyashris | kashyap: ok thank you! So for workaround I will set the kvm version same for both the machine and will try . | 09:39 |
kashyap | bhagyashris: Also see the guidance here: https://wiki.qemu.org/Features/Migration/Troubleshooting#Length_mismatch:_....:_...._in_.21.3D_..... | 09:40 |
kashyap | It does require work from distros. | 09:40 |
*** markvoelker has quit IRC | 09:42 | |
bhagyashris | kashyap: ok you mean it should install through bistro? | 09:43 |
bhagyashris | distro* | 09:43 |
kashyap | bhagyashris: I mean, there is an action item for Ubuntu QEMU packager to "pad the ROM" (it's a low-level thing) | 09:43 |
lwq | Hi there, I would like to discuss possible improvement of nova resize/migrate process - I mean the SCP part … Anyone with experience with this topic? :-) | 09:50 |
*** udesale has quit IRC | 09:51 | |
*** udesale has joined #openstack-nova | 09:52 | |
*** udesale has quit IRC | 09:56 | |
*** udesale has joined #openstack-nova | 09:57 | |
*** udesale has quit IRC | 10:00 | |
*** udesale has joined #openstack-nova | 10:00 | |
*** HD|Laptop has quit IRC | 10:09 | |
*** belmoreira has quit IRC | 10:12 | |
*** ttsiouts has quit IRC | 10:17 | |
*** ttsiouts has joined #openstack-nova | 10:18 | |
openstackgerrit | Merged openstack/python-novaclient master: Fix duplicate object description error https://review.opendev.org/666203 | 10:20 |
bhagyashris | kashyap: ohh ok thank you ! | 10:22 |
*** ttsiouts has quit IRC | 10:22 | |
*** bhagyashris has quit IRC | 10:23 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator) https://review.opendev.org/651555 | 10:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name) https://review.opendev.org/652103 | 10:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence) https://review.opendev.org/652104 | 10:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Use consistent URL regex substitution https://review.opendev.org/665949 | 10:35 |
openstackgerrit | Alex Xu proposed openstack/nova master: Assign the request_spec's network_metadata after create https://review.opendev.org/667061 | 10:35 |
openstackgerrit | Slawek Kaplonski proposed openstack/nova master: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/667035 | 10:36 |
*** markvoelker has joined #openstack-nova | 10:39 | |
*** mandre has quit IRC | 10:41 | |
*** rnoriega- has joined #openstack-nova | 10:44 | |
*** rnoriega has quit IRC | 10:45 | |
*** mandre has joined #openstack-nova | 10:45 | |
*** ttsiouts has joined #openstack-nova | 10:46 | |
*** alex_xu has joined #openstack-nova | 10:50 | |
*** ttsiouts has quit IRC | 10:50 | |
alex_xu | stephenfin: something should be under your radar https://review.opendev.org/667061 | 10:51 |
stephenfin | alex_xu: Looking at it at the moment :) | 10:51 |
*** sapd1_x has joined #openstack-nova | 10:56 | |
*** jaypipes has joined #openstack-nova | 10:57 | |
*** mvkr has joined #openstack-nova | 11:04 | |
*** belmoreira has joined #openstack-nova | 11:04 | |
*** markvoelker has quit IRC | 11:13 | |
*** ttsiouts has joined #openstack-nova | 11:19 | |
*** ttsiouts has quit IRC | 11:19 | |
*** _erlon_ has joined #openstack-nova | 11:19 | |
*** ttsiouts has joined #openstack-nova | 11:19 | |
*** jaosorior_ has joined #openstack-nova | 11:21 | |
*** jaosorior has quit IRC | 11:23 | |
*** mkrai_ has joined #openstack-nova | 11:39 | |
*** udesale has quit IRC | 11:39 | |
NewBruce3 | has anyone ever been able to live migrate VMs from CentOS (RDO) with SELinux to Ubuntu (OSA) with AppArmor? | 11:45 |
*** NewBruce3 is now known as NewBruce | 11:49 | |
NewBruce | i am convinced there is a way to do it, reading into the libvirt docs, but nothing has worked so far | 11:50 |
kashyap | NewBruce: I don't think (read: "I'm pretty sure") you will find official libvirt docs for it :-) | 11:57 |
*** ratailor has quit IRC | 11:58 | |
kashyap | If you're trying that, be aware that you might be left holding holding a bag of broken VM parts. | 11:58 |
kashyap | s/"holding holding"/holding/ | 11:58 |
kashyap | NewBruce: But ... if you _did_ succeed (or otherwise) might want to write a public blog post, with your exploits | 11:59 |
*** markvoelker has joined #openstack-nova | 12:04 | |
*** edleafe has joined #openstack-nova | 12:08 | |
NewBruce | well you can ask mnaser how he did it ;) | 12:10 |
NewBruce | sorry, having a quick chat with some libvirt people who think im doing some horrible sorcery to get migration from centos to ubuntu in the first place and that is courtesy of mnaser but long story short seems… impossible? | 12:11 |
*** jangutter has joined #openstack-nova | 12:12 | |
NewBruce | i expected to see a seclabel=selinux in the xml, but wasnt there but migrations fail…. | 12:13 |
NewBruce | Live Migration failure: unsupported configuration: Unable to find security driver for model selinux: libvirtError: unsupported configuration: Unable to find security driver for model selinux | 12:13 |
*** whoami-rajat has joined #openstack-nova | 12:14 | |
kashyap | NewBruce: Ah, I see you're on #virt, OFTC. (Haven't read the detail; buried in too many things) | 12:19 |
NewBruce | yeah, figured someone here might have tried before; but more likely the libvirt peoples would be up on it - seems this is a corner case; though surprising no one has ever moved from RDO to OSA before…. | 12:20 |
kashyap | Your machine types on source and destination won't match -- one of your main blockers... | 12:21 |
NewBruce | i beleive that is what mnaser has helped patch for us (wasnt around when he did that) | 12:21 |
NewBruce | but live migrating from RDO -> OSA definitely works for us; ive done it thousands of times now on another site - its just this setup im with now has SELinux on the RDO side which is a pain on the Ubuntu side as there are horrible bugs on Ubuntu with SELinux | 12:22 |
NewBruce | like not being able to create new users (which we can work around…. but still) | 12:22 |
NewBruce | running SELinux on Ubuntu is not a preferred long-term solution | 12:23 |
*** markvoelker has quit IRC | 12:24 | |
kashyap | Right, as I just noted on #virt; you do need some way of recompiling QEMU on Ubuntu, based on CentOS QEMU source (for the machine types) | 12:24 |
NewBruce | which it appears we have | 12:24 |
NewBruce | … should we move this over to #virt? :D | 12:24 |
*** jroll has quit IRC | 12:28 | |
*** jroll has joined #openstack-nova | 12:29 | |
kashyap | Yeah. | 12:33 |
*** priteau has joined #openstack-nova | 12:42 | |
mnaser | kashyap, NewBruce: pretty much deconstructed the srpm from redhat and added all the patches to the Deb which included all the machine typed etc to make it possible | 12:42 |
kashyap | mnaser: Wauw; have to admit, that's one really burdensome source you'll have to maintain | 12:46 |
NewBruce | according to the folks ok #virsh mnaser this makes you certifiable! :D | 12:46 |
mnaser | kashyap: I did tell the NewBruce and co that this will survive one single live migration and we reinstall the original binaries right after and it will block live migrations after | 12:47 |
* kashyap nods | 12:47 | |
mnaser | So the goal was just to get the one live migration done, reinstall original qemu and then on any full reboot they get the Ubuntu machine type | 12:48 |
kashyap | mnaser: If I may ask, is the goal to get off of CentOS altogether? | 12:49 |
*** beekneemech is now known as bnemec | 12:51 | |
*** zbr is now known as zbr|ruck | 12:53 | |
*** mkrai_ has quit IRC | 12:58 | |
*** mkrai__ has joined #openstack-nova | 12:58 | |
*** lbragstad has joined #openstack-nova | 13:02 | |
*** lwq has quit IRC | 13:02 | |
*** ttsiouts has quit IRC | 13:12 | |
*** ttsiouts has joined #openstack-nova | 13:13 | |
*** ttsiouts has quit IRC | 13:14 | |
*** ttsiouts has joined #openstack-nova | 13:14 | |
efried_pto | sean-k-mooney: Is https://blueprints.launchpad.net/nova/+spec/libvirt-video-device-models code complete since https://review.opendev.org/#/c/647733/ has merged? | 13:14 |
efried_pto | sean-k-mooney: I see there's some minor cleanup, but that doesn't look critical. And something on the glance side? | 13:15 |
*** brinzhang_ has joined #openstack-nova | 13:16 | |
*** jdillaman has joined #openstack-nova | 13:19 | |
*** brinzhang has quit IRC | 13:20 | |
*** BjoernT has joined #openstack-nova | 13:24 | |
openstackgerrit | Merged openstack/os-traits master: add libvirt image metadata traits https://review.opendev.org/652996 | 13:25 |
openstackgerrit | Merged openstack/os-traits master: add GOP, NONE and VIRTIO grapics models https://review.opendev.org/665830 | 13:25 |
*** trident has quit IRC | 13:29 | |
*** mriedem has joined #openstack-nova | 13:29 | |
openstackgerrit | Merged openstack/nova master: Remove redundant group host setup https://review.opendev.org/665954 | 13:33 |
openstackgerrit | Merged openstack/nova master: [FUP] fix backleveling unit test for video models https://review.opendev.org/666919 | 13:33 |
openstackgerrit | Merged openstack/nova master: Mention [cinder]/cross_az_attach in the AZ docs https://review.opendev.org/650456 | 13:34 |
*** trident has joined #openstack-nova | 13:35 | |
*** eharney has joined #openstack-nova | 13:37 | |
*** BjoernT_ has joined #openstack-nova | 13:39 | |
mriedem | sean-k-mooney: so same host revert resize huh, who know neutron had a gate job for ovs hybrid plug... | 13:41 |
mriedem | we should probably throw that into nova's experimental queue to be run on-demand | 13:41 |
*** BjoernT has quit IRC | 13:41 | |
mriedem | s/should/could/ since that means someone would have to remember to run it | 13:41 |
*** _erlon_ has quit IRC | 13:43 | |
sean-k-mooney | ya we should | 13:44 |
efried_pto | sean-k-mooney: see question above about libvirt-video-device-models? | 13:45 |
efried_pto | oh | 13:46 |
*** efried_pto is now known as efried | 13:46 | |
sean-k-mooney | sorry give me 5 mins | 13:47 |
efried | sure, no hurry. Meanwhile, I'll hammer you in -placement as well. | 13:47 |
*** jaosorior_ has quit IRC | 13:48 | |
*** jaosorior has joined #openstack-nova | 13:49 | |
*** jaosorior has quit IRC | 13:49 | |
mriedem | sean is also working on pushing a patch to try and fix the neutron gate, | 13:49 |
mriedem | unless we just go with this revert https://review.opendev.org/#/c/667035/2 | 13:50 |
mriedem | slaweq: looks like ^ makes the job pass now, i checked zuul on your neutron change that depends on the nova revrt | 13:50 |
mriedem | *Revert | 13:50 |
efried | that's way more important than my blueprint paperwork | 13:51 |
mriedem | slaweq: what i'd like to know is do we still get a network-vif-plugged event for ovs hybrid plug ports during same host revert resize at the time of plugging the vif (because apparently we don't when binding the port and the host doesn't change - which is different in behavior from how non-hybrid plug ovs ports work apparently) | 13:51 |
efried | (</ptl-hat> for pretty much any value of $that) | 13:51 |
sean-k-mooney | mriedem: actully we had a production outage of our internal cloud and i just spent the last 2 hours helping them fix it | 13:52 |
mriedem | sean-k-mooney: please oh please say it was because of this ovs hybrid plug patch :) | 13:52 |
sean-k-mooney | mriedem: so im about to start on a patch to fix the neutron issue but ill leave it up to you do we want to revert it and merge a fixed patch later or merge a fix and wait form me to write it | 13:53 |
sean-k-mooney | mriedem: no it was releated to messing up the neutorn policy.json that currpted the network info_cache and all vms nolonger had interfaces | 13:53 |
mriedem | sean-k-mooney: aha that sounds familiar (the same thing ovh fixed in stein) | 13:54 |
sean-k-mooney | yep | 13:54 |
sean-k-mooney | we have not backported it to 13 yet | 13:54 |
mriedem | apparently screwing up your neutron policy and blasting the nova info cache is something a lot of people do... | 13:54 |
sean-k-mooney | ya so i just figured out what db surgery is need and our devops folks are now doing it | 13:55 |
sean-k-mooney | so do we want to fast revert the event change | 13:55 |
mriedem | sean-k-mooney: for artom's patch i think we likely should land the revert and then work the same host thing into a combined patch | 13:55 |
mriedem | since you guys want to backport this | 13:55 |
sean-k-mooney | or will i write a patch quickly to skip waiting for event for same host resize | 13:55 |
mriedem | reverting gives time to sort out why same host resize events are different for this vif type than non-hybrid plug ovs - that inconsistency is really screwy | 13:56 |
sean-k-mooney | ok im fine with that i just didnt want to cause more revew burden for you/others | 13:56 |
mriedem | slaweq's revert patch's commit message likely needs work | 13:56 |
rouk | sean-k-mooney: i found the ceph issue and it fixed the nova issue, it was an MTU someone thought would be fun to drop to 1500 on a single switch of the 2 switches doing LACP to that host. | 13:57 |
*** Luzi has quit IRC | 13:57 | |
rouk | so some ceph responses would just fail, cause 9k byte, and then nova would sit forever silently | 13:57 |
*** brinzhang_ has quit IRC | 13:58 | |
*** udesale has joined #openstack-nova | 13:58 | |
dansmith | rouk: ouch :) | 13:58 |
rouk | nova needs some logging of its check cycle in debug mode though, having to trace from rabbitmq heartbeats as the symptom is rough | 13:59 |
sean-k-mooney | rouk: im sure that was fun to debug | 13:59 |
sean-k-mooney | it explains the behavior you were seeing however | 14:00 |
rouk | 4 days of man hours tracing through from the rabbitmq server because im always told "its not the network". | 14:00 |
sean-k-mooney | im still slightly annoyed/upsent/concerned that the nova-compute agent basicaly hard locks when it cant connect to ceph to get the capsity fo the ceph rbd pool | 14:01 |
rouk | so, can i wishlist some debug messages for the check phases in nova's cycle? lol | 14:01 |
rouk | yeah, it would send the message to ceph, and the ceph client retries every 30 seconds or so, and random dice based on what primary connection the LAPC uses determines if it returns or not, and it hangs forever till it gets a response. | 14:01 |
*** mrch_ has quit IRC | 14:01 | |
sean-k-mooney | hehe if you can suggest what they should be we can proably add them | 14:02 |
*** smcginnis has joined #openstack-nova | 14:02 | |
rouk | issue was only found tcpdumping ceph, would see a 9k byte response out of ceph and the client wouldnt hear about it. | 14:03 |
rouk | well... im not aware of all the checks, would be good if it was even just a basic debug on what function it was checking, just to narrow down debug. | 14:03 |
rouk | right now the messages stop pretty high up, so the only thing to check is everything. | 14:04 |
sean-k-mooney | im guessing it was working just well enough for the tcp connection not to drop | 14:04 |
sean-k-mooney | if we got a disconnect that would proably have shown up in the logs | 14:05 |
rouk | any tcp/udp/icmp with RESPONSES under 1500 worked perfectly 100% of the time. | 14:05 |
sean-k-mooney | ya im not sure nova could figure that our however. | 14:05 |
sean-k-mooney | rouk: did you file a bug for this by the way? | 14:05 |
rouk | nope, since its my fault. | 14:06 |
rouk | if nova would give up on the ceph client after even 20 seconds it would be fine imo | 14:06 |
sean-k-mooney | well we proably should be making that call with a timeout and raising an error if we dont get the resopce | 14:06 |
*** lpetrut has quit IRC | 14:06 | |
rouk | packet loss ceph client hangs for 30 seconds per retry or so, but if the backend is not responding for even over 1 second, somethings up. | 14:06 |
*** dave-mccowan has joined #openstack-nova | 14:07 | |
rouk | yeah, anything over 1 second is bad, and 20 seconds imo is an ERROR tier. | 14:07 |
sean-k-mooney | ya i think as a general enchancement haveing a config option to control a timout on ceph calls would likely be a good thing | 14:07 |
rouk | should i fill it out somewhere in particular? | 14:08 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove comments about mirroring changes to nova/cells/messaging.py https://review.opendev.org/667107 | 14:09 |
sean-k-mooney | rouk: https://bugs.launchpad.net/nova/+filebug | 14:09 |
sean-k-mooney | rouk: if you just file a bug and state i asked you too then it wont get closed imediatly as a ceph issue :) | 14:10 |
* mriedem waits to close immediately | 14:10 | |
sean-k-mooney | state something like "nova should timeout request to ceph, instead of hanging on network issues" and descibe the behavior you saw | 14:11 |
*** belmoreira has quit IRC | 14:11 | |
*** dave-mccowan has quit IRC | 14:11 | |
sean-k-mooney | mriedem: i dont know if we can fix it but at least we can sse if its sane or not and then close it :) | 14:11 |
mriedem | i was just joking | 14:12 |
rouk | sean-k-mooney: can do. | 14:13 |
sean-k-mooney | :) i was assuming that but i also need to go grab coffe so brb | 14:14 |
rouk | oh, launchpad, my ubuntuone cant use launchpad due to "oops" error, no response from support about it... guess ill make a new account or something. | 14:14 |
dansmith | mriedem: sean-k-mooney: so what's the deal? is there another patch to fix same host we're watching, or are we going to merge this, re-propose, etc? | 14:18 |
dansmith | I imagine neutron people want to know | 14:19 |
mriedem | dansmith: i said i think we should land the revert | 14:21 |
mriedem | the commit message could use a tweak to explain why the original is busted | 14:21 |
mriedem | but slaweq appears to be gone | 14:21 |
dansmith | mriedem: okay I saw you said you were "OK" with it, but didn't see that was the plan | 14:21 |
dansmith | so let's update it for him and approve? | 14:21 |
mriedem | yeah i can do that | 14:21 |
sean-k-mooney | dansmith: ya we are going to revert | 14:22 |
openstackgerrit | Slawek Kaplonski proposed openstack/nova master: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/667035 | 14:23 |
sean-k-mooney | to be honest this give me more time to test this for the same host resize case too and the backport will be simpler since it will be 1 patch so it better in the log run | 14:23 |
dansmith | mriedem: ^ good? | 14:23 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/667035 | 14:24 |
mriedem | d'oh | 14:24 |
mriedem | dansmith: +2 | 14:25 |
*** ccamacho has quit IRC | 14:25 | |
*** dpawlik has quit IRC | 14:25 | |
dansmith | okay cool | 14:26 |
slaweq | mriedem: hi, I just updated this commit message, sorry for the delay, I was on meeting | 14:29 |
mriedem | sean-k-mooney: i've marked the original bug as "triaged" rather than "fix released" so your patch can still close the original bug https://bugs.launchpad.net/nova/+bug/1832028 | 14:29 |
openstack | Launchpad bug 1832028 in OpenStack Compute (nova) stein "revert resize: vif-plugged external event sent too soon if Neutron is using OVS hybrid plug" [Medium,In progress] - Assigned to Lee Yarwood (lyarwood) | 14:29 |
mriedem | slaweq: yup me too :) the revert is approved | 14:29 |
slaweq | mriedem: thx a lot | 14:29 |
mriedem | slaweq: i'll just say again that the inconsistency of when neutron sends these events per vif type sucks | 14:29 |
mriedem | from a consumer pov | 14:29 |
slaweq | mriedem: yes, I know | 14:30 |
*** mlavalle has joined #openstack-nova | 14:30 | |
slaweq | we also found other issue with live-migration and e.g. networking-ovn recently but that will be reported separately later | 14:30 |
mriedem | i've heard (from the rh nova team) | 14:31 |
mriedem | which is why you changed to ovs hybrid plug and then found this issue | 14:31 |
sean-k-mooney | mriedem: ack, do i need to respond on the ml | 14:31 |
mriedem | sean-k-mooney: saying we approved the revert on the ML is probably good for people to hold their rechecks | 14:32 |
*** belmoreira has joined #openstack-nova | 14:32 | |
* mriedem realizes this will probably reset the gate for about a day | 14:32 | |
dansmith | promotion time? | 14:33 |
mriedem | i'm not the person to ask probably | 14:33 |
*** jaosorior has joined #openstack-nova | 14:33 | |
* sean-k-mooney resets days since last gate blocking patch | 14:33 | |
dansmith | sean-k-mooney: lol | 14:33 |
mriedem | it won't block nova of course | 14:33 |
mriedem | we're just blocked by the rate limiting | 14:33 |
*** belmoreira has quit IRC | 14:34 | |
sean-k-mooney | mriedem: on the upside since neutron are not using there gate currently nova should speed up :P | 14:34 |
* mriedem rebases 45 patch cross-cell-resize series | 14:35 | |
*** belmoreira has joined #openstack-nova | 14:36 | |
zigo | Is there an openstackclient equivalent to nova server-migration-show? | 14:36 |
amorin | hey all | 14:37 |
sean-k-mooney | zigo: not that i see at a glance | 14:38 |
zigo | sean-k-mooney: Ok, so I'm not completely bind then! :) | 14:38 |
stephenfin | zigo: I don't think so. That was one of the gaps we identified in Denver (summit) | 14:39 |
sean-k-mooney | you are not :) we dont have full parity | 14:39 |
sean-k-mooney | zigo: initally osc did not have admin commnds so that is the area we have the most gaps today | 14:39 |
zigo | Right. | 14:39 |
zigo | If I put arp_responder = True, will this speed-up MAC learning for the network equipment connected to my compute? | 14:40 |
zigo | It usually takes dozens of seconds for it to learn what the new floating IP location is... | 14:41 |
sean-k-mooney | no | 14:41 |
*** rajinir has joined #openstack-nova | 14:41 | |
zigo | sean-k-mooney: Is there some tricks? :) | 14:41 |
sean-k-mooney | arp_resopnder = true need the l2_population ml2 driver and does arp suppression so that openflow rules rewrite the arp request to an arp responce | 14:42 |
amorin | I am currently facing a race condition in my OpenStack deployment. If I delete a port while the instance was booting (before nova plug the interface), then nova plug the interface and left the interface like this, after a while I have a lot of interface staying on the host | 14:42 |
sean-k-mooney | so if you set that and the vswich has the flow installed the arp will never get to the tor | 14:42 |
zigo | Right. | 14:42 |
sean-k-mooney | so it will have the opisite effect in that learnign will only happen when you get an non arp packet | 14:43 |
rouk | sean-k-mooney: https://bugs.launchpad.net/nova/+bug/1834048 let me know if more is needed. | 14:43 |
openstack | Launchpad bug 1834048 in OpenStack Compute (nova) "Nova waits indefinitely on ceph client hangs due to network problems" [Undecided,New] | 14:43 |
zigo | sean-k-mooney: Ok, thanks. | 14:43 |
mriedem | amorin: like this? https://review.opendev.org/#/c/663382/ | 14:44 |
sean-k-mooney | rouk: cool thanks for filing ^ lyarwood you might be able to determing if there is soemthing we can do to fix the ceph issue | 14:44 |
sean-k-mooney | mriedem: hehe i was looking for that but it might help | 14:44 |
sean-k-mooney | mriedem: that is specifcaly for the case wehre you delete the instance after teh vm has started running but before we have updated the db | 14:45 |
sean-k-mooney | i belive there are other case were this can happen too | 14:45 |
mriedem | dansmith: regarding promoting that revert, slaweq could request it since i wouldn't be surprised if it takes all day to run the nova change through and even then will likely fail on some gate bug | 14:45 |
sean-k-mooney | that was the one i know was definetly broken | 14:45 |
amorin | mriedem, sean-k-mooney almost like this | 14:45 |
dansmith | mriedem: yeah that's what I was thinking.. looking at how many other things have -1s on them, this could take a while | 14:46 |
dansmith | slaweq: mriedem: is that neutron job in neutron's gate? | 14:46 |
mriedem | it's voting for neutron so i expect it's in neutron's gate queue yeah | 14:46 |
sean-k-mooney | dansmith: yes it is | 14:46 |
dansmith | so anything that has a recent check on it will head to the gate but fail every time, making the gate queue super slow too yeah? | 14:47 |
amorin | mriedem: something like this: | 14:47 |
amorin | http://paste.openstack.org/show/753313/ | 14:47 |
sean-k-mooney | amorin: right in your case you are deleteing the neutorn port | 14:47 |
amorin | yes, while booting the instance | 14:47 |
sean-k-mooney | well you should not actully get stale port in that case in ovs | 14:48 |
mriedem | amorin: so nova plugs the vif, starts waiting for the network-vif-plugged event, the port is then deleted and we don't get the event so we timeout and fail the server build | 14:48 |
sean-k-mooney | in you logg you have the vif unplug which should clean it up | 14:48 |
mriedem | sean-k-mooney: pretty sure we don't handle vif unplug and actually unplug | 14:48 |
mriedem | from out of band network-vif-deleted events | 14:48 |
sean-k-mooney | mriedem: we dont but we do on instance delete | 14:48 |
sean-k-mooney | so when we role back the spawn we should call unplug and clean up | 14:49 |
amorin | I dont have unplug call | 14:49 |
mriedem | isn't that stephen's patch? | 14:49 |
sean-k-mooney | no his is for a specifc case were we get an exception form the db | 14:49 |
sean-k-mooney | in that case we dont call cleanup | 14:50 |
sean-k-mooney | for the timeout case we do | 14:50 |
mriedem | https://review.opendev.org/#/c/663382/3/nova/compute/manager.py@2023 | 14:50 |
mriedem | stephen's patch doesn't have any specific cases in it from what i can tell | 14:50 |
sean-k-mooney | the downstream bug did | 14:51 |
mriedem | "If an instance fails to build, which is possible for a variety of reasons, we may end up in a situation where we have remnants of a plugged VIF (typically files) left of the host. This is because we cleanup from the neutron perspective but don't attempt to unplug the VIF, a call which may have many side-effects depending on the VIF driver." | 14:51 |
amorin | my bad, I have unplug in my logs | 14:51 |
mriedem | oh well the downstream bug... | 14:51 |
sean-k-mooney | it should be linkend in the upstream one but its addressing the case of when UnexpectedDeletingTaskStateError is raised | 14:52 |
mriedem | the rh bz is linked into the lp bug, | 14:52 |
mriedem | i'm just annoyed that i need to follow the breadcrumb trail of bugs to know wtf is going on in a patch | 14:53 |
sean-k-mooney | ya it should have been copied into the upstream bug | 14:53 |
mriedem | amorin: if you have a reproducer of *your* scenario can you apply https://review.opendev.org/#/c/663382/ and see if that resolves it? | 14:53 |
sean-k-mooney | sorry about that. stephen pick that bug up from me because i didnt have time to start on it two weeks ago | 14:54 |
amorin | mriedem: yes | 14:54 |
amorin | will do | 14:54 |
mriedem | sean-k-mooney: no i'm wrong, the details are in the lp bug, it's fine | 14:55 |
*** BjoernT_ has quit IRC | 14:56 | |
sean-k-mooney | amorin: by the way stephenfin patch will just prevent new interface form leaking it will not clean up existing stale ports | 14:56 |
amorin | sean-k-mooney: yes of course :p | 14:56 |
sean-k-mooney | mriedem: as far as i can tell we could leak ports this way for years so its supper latent | 14:57 |
*** BjoernT has joined #openstack-nova | 14:57 | |
*** cfriesen has joined #openstack-nova | 15:00 | |
*** jaypipes_ has joined #openstack-nova | 15:01 | |
*** jaypipes has quit IRC | 15:04 | |
*** cfriesen has quit IRC | 15:04 | |
*** jaosorior has quit IRC | 15:05 | |
*** panda has quit IRC | 15:09 | |
*** factor has joined #openstack-nova | 15:11 | |
*** panda has joined #openstack-nova | 15:11 | |
*** _alastor_ has joined #openstack-nova | 15:13 | |
*** priteau has quit IRC | 15:17 | |
*** ttsiouts has quit IRC | 15:17 | |
*** ttsiouts has joined #openstack-nova | 15:18 | |
*** jaosorior has joined #openstack-nova | 15:18 | |
*** ttsiouts has quit IRC | 15:19 | |
*** ttsiouts has joined #openstack-nova | 15:19 | |
*** tinwood_ is now known as tinwood | 15:20 | |
Nick_A | How do you set quota defaults for new projects? I did openstack quota set --instances 100 default, but new projects still show the instance limit at 10 | 15:22 |
*** rouk has quit IRC | 15:24 | |
mriedem | Nick_A: i suggest you read through https://docs.openstack.org/nova/latest/user/quotas.html and/or https://docs.openstack.org/nova/latest/admin/quotas.html | 15:25 |
mriedem | and if there is a problem in those docs, then bring it here | 15:25 |
*** priteau has joined #openstack-nova | 15:25 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: docs: Rewrite host aggregate, availability zone docs https://review.opendev.org/667133 | 15:26 |
Nick_A | I read through both before asking. Double checked my quota set command matches the docs. | 15:28 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove orphaned comment from _get_group_details https://review.opendev.org/667135 | 15:28 |
mriedem | Nick_A: check if there are per-project quotas set on the project which would override the defaults | 15:28 |
openstackgerrit | Merged openstack/python-novaclient master: Add irrelevant files in dsvm job https://review.opendev.org/666217 | 15:30 |
mriedem | https://docs.openstack.org/nova/latest/user/quotas.html#checking-quota is the thing you want to check | 15:30 |
*** mkrai__ has quit IRC | 15:31 | |
mriedem | stephenfin: pretty sure https://review.opendev.org/666217 is broken | 15:31 |
stephenfin | mriedem: Yup :( I'll submit a fixup | 15:33 |
*** tesseract has quit IRC | 15:33 | |
openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Only ignore unit test changes for functional jobs https://review.opendev.org/667147 | 15:34 |
Nick_A | http://paste.openstack.org/show/OOfHU4BMoigiHYmODPMm/ also set instance quota to 100 for "admin" before creating the new project | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Only ignore unit test changes for functional jobs https://review.opendev.org/667147 | 15:35 |
*** jaosorior has quit IRC | 15:37 | |
mriedem | Nick_A: I think your usage is wrong here: "openstack quota set --instances 100 default" | 15:37 |
*** BjoernT_ has joined #openstack-nova | 15:37 | |
mriedem | that's setting instances quota to 100 for the "default" project, which doesn't exist | 15:37 |
*** BjoernT has quit IRC | 15:38 | |
mriedem | you should be using "--class default" https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/quota.html#quota-set | 15:38 |
Nick_A | That's what I thought but that seems to be what the docs indicate | 15:38 |
mriedem | the osc cli docs aren't clear about what a class is or that "default" is the only class supported by nova... | 15:38 |
Nick_A | https://docs.openstack.org/nova/latest/admin/quotas.html these specifically | 15:39 |
mriedem | you mean "2. Update a default value for a new project, for example:" | 15:39 |
mriedem | yeah that looks busted | 15:39 |
Nick_A | heh | 15:39 |
*** wwriverrat has quit IRC | 15:39 | |
mriedem | "$ openstack quota set --QUOTA_NAME QUOTA_VALUE PROJECT_OR_CLASS" is also misleading | 15:39 |
mriedem | since if you use a class you need to specify --class | 15:40 |
*** wwriverrat has joined #openstack-nova | 15:40 | |
mriedem | Nick_A: please hit the bug link at the top of the page and report a nova docs bug | 15:40 |
*** luksky has quit IRC | 15:40 | |
Nick_A | # openstack quota set --class --instances 100 default <-- worked thank you | 15:42 |
mriedem | looks like that's been broken since pike https://review.opendev.org/#/c/490952/4 | 15:44 |
mriedem | when the admin guide was using the nova cli correctly before the import of the docs and then it was changed to use the osc cli incorrectly | 15:45 |
mriedem | i didn't notice that change since it wasn't mentioned in the commit message.... | 15:45 |
openstackgerrit | Merged openstack/nova master: Ignore hw_vif_type for direct, direct-physical vNIC types https://review.opendev.org/609460 | 15:45 |
Nick_A | bug submitted - thank you | 15:45 |
*** helenafm has quit IRC | 15:46 | |
mriedem | gdi that whole page probably has to be validated now | 15:47 |
mriedem | Nick_A: thanks | 15:47 |
*** sapd1_x has quit IRC | 15:48 | |
mriedem | stephenfin: maybe you want to fix this https://bugs.launchpad.net/nova/+bug/1834057 | 15:48 |
openstack | Launchpad bug 1834057 in OpenStack Compute (nova) "change default quota command example is incorrect" [Undecided,New] | 15:48 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382 | 15:48 |
mriedem | since you imported those docs and changed the cli used to be wrong w/o mentioning it in the commit | 15:48 |
stephenfin | mriedem: https://github.com/openstack/openstack-manuals/commit/655a9ce2c6372b94d2023242292aaae3a511e631 | 15:51 |
mriedem | that's not what's in https://github.com/openstack/openstack-manuals/blob/stable/ocata/doc/admin-guide/source/cli-set-compute-quotas.rst | 15:53 |
*** damien_r has quit IRC | 15:55 | |
stephenfin | You're talking about the footer, I assume. I'm guessing that's because I wanted some kind of semi-permanent record though not the exact one | 15:58 |
stephenfin | But idk what I was thinking nearly two years ago | 15:58 |
dansmith | that neutron event patch is making it through check pretty well, compared to how it's been the last few weeks, so maybe not quite as long to gate as we thought | 15:59 |
stephenfin | Point is, I didn't change anything to be wrong. You could have just asked me to investigate and fix without assigning blame | 15:59 |
* stephenfin goes to fix that other guys mistake | 15:59 | |
*** belmoreira has quit IRC | 16:02 | |
*** belmoreira has joined #openstack-nova | 16:04 | |
*** mkrai__ has joined #openstack-nova | 16:05 | |
*** priteau has quit IRC | 16:05 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Revert "Add irrelevant files in dsvm job" https://review.opendev.org/667151 | 16:05 |
*** belmoreira has quit IRC | 16:06 | |
mriedem | stephenfin: yes the footer in the commit message points at the docs from stable/ocata so that's what i assumed you imported from, and those ocata docs were using nova CLIs but your change was not, so i assumed you changed things while importing | 16:06 |
mriedem | dansmith: can you slam this through? https://review.opendev.org/#/c/667151/ | 16:07 |
*** ttsiouts has quit IRC | 16:07 | |
mriedem | keep the revert train rolling | 16:07 |
*** ttsiouts has joined #openstack-nova | 16:08 | |
*** tssurya has quit IRC | 16:11 | |
*** ttsiouts has quit IRC | 16:12 | |
Nick_A | quota value of -1 = unlimited? | 16:14 |
sean-k-mooney | Nick_A: yes | 16:15 |
Nick_A | ty | 16:15 |
*** icarusfactor has joined #openstack-nova | 16:23 | |
*** factor has quit IRC | 16:23 | |
openstackgerrit | Dustin Cowles proposed openstack/nova-specs master: Spec: Use OpenStack SDK in Nova https://review.opendev.org/662881 | 16:26 |
*** dpawlik has joined #openstack-nova | 16:27 | |
openstackgerrit | Rui Zang proposed openstack/nova-specs master: support virtual persistent memory https://review.opendev.org/601596 | 16:29 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add neutron-tempest-iptables_hybrid job to experimental queue https://review.opendev.org/667154 | 16:29 |
mriedem | sean-k-mooney: ^ you can lay your change on top of that and then we can test it in the nova change itself | 16:30 |
*** trident has quit IRC | 16:30 | |
*** trident has joined #openstack-nova | 16:32 | |
sean-k-mooney | mriedem: yep ill do that. i was in meeting for the last hour and im just getting dinner now. ill submit a fixed patch later today hopefuly before i log off. if not ill work with artom to fix this tomorow. it should not be that hard to do but i have been tied up with other stuff so far today | 16:35 |
mriedem | sure, that's fine, and why i thought the fast revert was the way to go | 16:36 |
sean-k-mooney | ya. if it wasnt for the downstream prod issue this would have been the first thing i worked on today | 16:37 |
sean-k-mooney | anyway ill be back in an hour or so | 16:37 |
sean-k-mooney | tonyb: the cap that was added for sphinx in global-requirements is breaking the requiremetns check job | 16:39 |
sean-k-mooney | tonyb: https://github.com/openstack/requirements/blob/master/global-requirements.txt#L459 | 16:39 |
sean-k-mooney | tonyb: we could merge https://review.opendev.org/#/c/666387/ however can you comment on why this cap was put in global-requirements and not upper-constraits | 16:39 |
sean-k-mooney | by doing it in global-requirements it is breaking os-vif and other repo but upper-constratis would have just worked | 16:40 |
sean-k-mooney | https://github.com/openstack/requirements/commit/00b2bcf7d664b1526b4eefe157c33113206d6251 | 16:40 |
sean-k-mooney | does not really explain why this was chosen but it does call out that you expect it might break things | 16:41 |
*** igordc has joined #openstack-nova | 16:42 | |
*** mrch_ has joined #openstack-nova | 16:43 | |
Nick_A | do network quota defaults still need to be set with neutron quota-update ? | 16:44 |
sean-k-mooney | i personally would prefer to remove the cap in global constratig and make the docs jobs use upper-constratits if they dont already | 16:44 |
Nick_A | # openstack quota set --class default --floating-ips 0 | 16:44 |
Nick_A | Network quotas are ignored since quota class is not supported | 16:44 |
*** whoami-rajat has quit IRC | 16:44 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Drop source node allocations if finish_resize fails https://review.opendev.org/667155 | 16:44 |
Nick_A | "neutron CLI is deprecated and will be removed in the future. Use openstack CLI instead. | 16:45 |
Nick_A | " | 16:45 |
mriedem | neutron doesn't have quota classes as far as i know, | 16:45 |
mriedem | only nova and cinder | 16:45 |
mriedem | the osc cli docs are not clear about that either | 16:45 |
mriedem | i'm not sure what the quota options are with neutron, if it's just config (global) and per-project | 16:46 |
mriedem | that's a question for the -neutron channel | 16:46 |
Nick_A | gotcha | 16:46 |
mriedem | https://developer.openstack.org/api-ref/network/v2/index.html#quotas-extension-quotas | 16:47 |
mriedem | https://docs.openstack.org/neutron/stein/search.html?q=quota isn't helping | 16:47 |
mriedem | so my uneducated guess is (1) config for global defaults, (2) per-project defaults and (3) project-specific overrides | 16:48 |
*** dklyle has joined #openstack-nova | 16:49 | |
*** mkrai__ has quit IRC | 16:51 | |
*** gfhellma has joined #openstack-nova | 16:54 | |
Nick_A | we'll set them globally for now - https://docs.openstack.org/openstack-ansible-os_neutron/latest/ - thank you for looking | 16:55 |
stephenfin | https://docs.openstack.org/neutron/rocky/contributor/internals/quota.html | 16:56 |
stephenfin | Not sure if that's relevant or not | 16:56 |
*** icarusfactor has quit IRC | 17:00 | |
*** whoami-rajat has joined #openstack-nova | 17:02 | |
*** udesale has quit IRC | 17:07 | |
*** psachin has quit IRC | 17:17 | |
*** panda has quit IRC | 17:18 | |
openstackgerrit | Dustin Cowles proposed openstack/nova-specs master: Spec: Use OpenStack SDK in Nova https://review.opendev.org/662881 | 17:19 |
*** panda has joined #openstack-nova | 17:20 | |
*** ociuhandu_ has joined #openstack-nova | 17:21 | |
*** ralonsoh has quit IRC | 17:23 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | 17:25 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Rewrite quotas documentation https://review.opendev.org/667165 | 17:25 |
*** ociuhandu has quit IRC | 17:25 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165 | 17:26 |
*** ociuhandu_ has quit IRC | 17:27 | |
*** davidsha has quit IRC | 17:27 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047 | 17:36 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047 | 17:36 |
*** eharney_ has joined #openstack-nova | 17:51 | |
*** eharney has quit IRC | 17:53 | |
dansmith | mriedem: sorry was in a meeting | 17:53 |
*** luksky has joined #openstack-nova | 17:55 | |
*** martinkennelly has quit IRC | 18:04 | |
*** luksky has quit IRC | 18:12 | |
*** dpawlik has quit IRC | 18:39 | |
*** dpawlik has joined #openstack-nova | 18:40 | |
openstackgerrit | sean mooney proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/667177 | 18:42 |
*** dklyle has quit IRC | 18:49 | |
*** david-lyle has joined #openstack-nova | 18:49 | |
*** eharney_ is now known as eharney | 18:56 | |
*** jangutter has quit IRC | 18:58 | |
*** luksky has joined #openstack-nova | 19:04 | |
openstackgerrit | Merged openstack/nova master: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/667035 | 19:14 |
*** xek has quit IRC | 19:23 | |
openstackgerrit | Eric Fried proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator) https://review.opendev.org/651555 | 19:24 |
openstackgerrit | Eric Fried proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name) https://review.opendev.org/652103 | 19:24 |
openstackgerrit | Eric Fried proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence) https://review.opendev.org/652104 | 19:24 |
openstackgerrit | Eric Fried proposed openstack/nova master: tests: Use consistent URL regex substitution https://review.opendev.org/665949 | 19:24 |
openstackgerrit | sean mooney proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/667177 | 19:24 |
sean-k-mooney | efried: thanks for reviewing the libvirt pqos spec. ill review and responed tomorrow | 19:26 |
efried | yahyoubetcha | 19:26 |
openstackgerrit | Dustin Cowles proposed openstack/nova-specs master: Spec: Use OpenStack SDK in Nova https://review.opendev.org/662881 | 19:30 |
*** whoami-rajat has quit IRC | 19:34 | |
*** BjoernT_ has quit IRC | 19:49 | |
*** markmcclain has quit IRC | 19:49 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 19:51 |
efried | johnthetubaguy: Would you please have a (hopefully final) look at https://review.opendev.org/#/c/658716/ and see if it's approvable? | 19:54 |
openstackgerrit | Matt Riedemann proposed openstack/os-traits master: Add COMPUTE_STATUS_DISABLED trait https://review.opendev.org/667209 | 20:00 |
*** bnemec has quit IRC | 20:00 | |
*** david-lyle is now known as dklyle | 20:06 | |
*** bnemec has joined #openstack-nova | 20:08 | |
*** spatel has joined #openstack-nova | 20:12 | |
*** _erlon_ has joined #openstack-nova | 20:12 | |
mriedem | efried: i have one of your favorite all time questions, | 20:15 |
efried | airspeed velocity of an unladen European swallow? | 20:16 |
mriedem | SchedulerReportClient.set_traits_for_provider uses the ProviderTree cache https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1019 | 20:16 |
mriedem | but get_provider_traits does not https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L373 | 20:17 |
mriedem | i'm working on splitting up https://review.opendev.org/#/c/654596/ and the first thing I was going to do was https://review.opendev.org/#/c/654596/2/nova/scheduler/client/report.py as a separate patch which was set_provider_traits w/o the cache, | 20:17 |
mriedem | so the ComputeVirtAPI/virt driver usage for get/set provider traits would not be tied to a cache | 20:18 |
mriedem | but now i can't remember why i decided to go the no-cache route, | 20:18 |
mriedem | since i could link the compute manager / virt api / driver / RT reportclient together and then they'd all be using the same instance of the ProviderTree cache | 20:18 |
mriedem | and maybe that's desirable | 20:18 |
mriedem | so i guess main question is, is there any reason get_provider_traits isn't using the cache? | 20:19 |
mriedem | my more nagging question is if i should try to share the reportclient among compute/rt/virtapi and lean on the cache...though i'm not sure i trust the cache (i guess we'd know if the cache was wrong when we try to set traits on the provider using the wrong generation) | 20:22 |
efried | mriedem: get_provider_traits is in code paths that have already decided whether the cache is in play or not. It's kind of one of those "low-level" methods that probably - I haven't checked - started off as private and was developed before we had fully developed the caching model. | 20:22 |
efried | set_traits_for_provider is currently only being used in the rt resource update loop, which has a retry on generation conflicts, i.e. "using" the cache "safely". | 20:23 |
efried | In principle, up to this point I think we've been avoiding using the cache for any report client *outside* of the compute service. | 20:24 |
efried | are you intending to *write* traits from the *scheduler*? | 20:24 |
efried | or conductor | 20:24 |
efried | ? | 20:24 |
mriedem | no | 20:26 |
mriedem | ComputeVirtAPI is part of the ComputeManager/ComputeDriver/RT turducken | 20:26 |
efried | IMO for "compute disabled" filter you should not use the cache, so get_provider_traits ought to be good as is. | 20:27 |
mriedem | the trait stuff in this case can be managed started from the compute manager (via call from the API), the driver, or the RT - and the former two are using the same VirtAPI instance | 20:27 |
*** gfhellma has quit IRC | 20:27 | |
efried | you may have to walk me through the flow at a high level here, or I can reread the spec quick... | 20:28 |
mriedem | ok if i'm not using the cache then i do need https://review.opendev.org/#/c/654596/2/nova/scheduler/client/report.py to set w/o the cache as well | 20:28 |
sean-k-mooney | mriedem: can it be managed from teh compute manager if the host is down | 20:28 |
mriedem | sean-k-mooney: no | 20:28 |
sean-k-mooney | that what i assumed | 20:28 |
*** bbowen has quit IRC | 20:28 | |
sean-k-mooney | so if the host is actully down how would we update the trait | 20:28 |
mriedem | we wouldn't | 20:29 |
mriedem | see the note here https://specs.openstack.org/openstack/nova-specs/specs/train/approved/pre-filter-disabled-computes.html#scheduler-changes | 20:29 |
efried | mriedem: I'm not sure I see the purpose of the split in https://review.opendev.org/#/c/654596/2/nova/scheduler/client/report.py | 20:29 |
*** bbowen has joined #openstack-nova | 20:29 | |
sean-k-mooney | ah right | 20:29 |
efried | where were you getting the generation from? | 20:29 |
sean-k-mooney | this is just covering disabled vs enabled not up vs down | 20:30 |
efried | if not from the cache? | 20:30 |
mriedem | efried: | 20:30 |
mriedem | get_provider_traits | 20:30 |
mriedem | returns a named tuple | 20:30 |
mriedem | with the traits list and the gen | 20:30 |
mriedem | i wasn't going to use set_traits_for_provider because if i'm not relying on the cache at all, then i don't want this to f me: | 20:31 |
mriedem | if not self._provider_tree.have_traits_changed(rp_uuid, traits): | 20:31 |
mriedem | i'm doing that myself here https://review.opendev.org/#/c/654596/2/nova/compute/manager.py@494 | 20:32 |
efried | mriedem: compute manager is same process (and using same report client) as RT? | 20:33 |
efried | (sorry if I'm asking you to repeat yourself) | 20:34 |
mriedem | yeah | 20:34 |
efried | then the cache is hot | 20:34 |
efried | and you don't need to duplicate all that logic. | 20:34 |
mriedem | https://review.opendev.org/#/c/654596/2/nova/compute/manager.py@573 | 20:34 |
efried | but you're concerned that the cache could be stale? | 20:34 |
*** ociuhandu has joined #openstack-nova | 20:35 | |
mriedem | well my initial concern was just why get_provider_traits wasn't using the cache if set_traits_for_provider relies on the cache | 20:35 |
mriedem | which if i use the cache, just becomes an optimization | 20:35 |
mriedem | i.e. later adding a use_cache kwarg to get_provider_traits or whatever | 20:35 |
mriedem | looks like only fill_provider_mapping uses get_provider_traits today which was the stuff gibi added and isn't in compute, so i guess that's why it doesn't use the cache | 20:37 |
efried | Yes, and _refresh_associations, which is the low-level thing that updates the cache, but it refreshes a bunch of other shit you don't need as well. | 20:37 |
mriedem | there might have been some other reason i needed to hit placement directly, but it's been too long since i wrote this so i guess i'll just rebase and then try to see if things still work after re-using the same report client in the virtapi | 20:38 |
mriedem | might have been when the virt driver calls the virtapi, but the virtapi in the virt driver is the same virtapi that ComputeManager creates and passes a reference of itself | 20:39 |
efried | yeah at some point we made sure the report client was a singleton per process | 20:41 |
efried | mriedem: I think we want to tweak the report client to make this process more generic & reusable. Stand by. | 20:43 |
*** pcaruana has quit IRC | 20:44 | |
efried | Pull this bit of _refresh_associations | 20:45 |
efried | https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/client/report.py#L794-L803 | 20:45 |
efried | into get_provider_traits itself -- iow calling get_provider_traits should also update the cache | 20:45 |
efried | (...and dedup that part of _refresh_associations) | 20:46 |
*** luksky has quit IRC | 20:46 | |
efried | So then your thingy, and other thingies that do similar, can | 20:46 |
efried | get_provider_traits() to retrieve the trait info you want to muck with | 20:46 |
efried | muck with it | 20:46 |
efried | set_traits_for_provider() with the changed trait list | 20:46 |
efried | If we wanted to optimize that, we could add a refresh=$bool kwarg to get_provider_traits so you could optionally have it *just* return whatever's in the cache rather than refetching. | 20:47 |
mriedem | we can't have https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/client/report.py#L802 in get_provider_traits for things that aren't using the cache, like gibi's calls from conductor for fill_provider_mapping | 20:47 |
mriedem | right? | 20:47 |
efried | I don't see why not. | 20:48 |
efried | We'd be updating the cache, but not reading from it anywhere. | 20:48 |
efried | Updating the cache is of negligible cost | 20:48 |
mriedem | " # NOTE(efried): This will blow up if called for a RP that doesn't # exist in our _provider_tree. " | 20:48 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add placement request filter for disabled computes https://review.opendev.org/654596 | 20:48 |
*** BjoernT has joined #openstack-nova | 20:50 | |
efried | mriedem: by that point in _refresh_associations, we're already assured the provider is in our cache. | 20:50 |
*** hongbin has joined #openstack-nova | 20:50 | |
efried | you're saying if it's called from elsewhere where that's not the case | 20:50 |
efried | so yeah, trap and ignore ValueError | 20:50 |
efried | done | 20:50 |
openstackgerrit | Merged openstack/python-novaclient master: Revert "Add irrelevant files in dsvm job" https://review.opendev.org/667151 | 20:50 |
mriedem | blech | 20:51 |
efried | you could do that from within the new-and-improved get_provider_traits | 20:51 |
mriedem | but yeah that's what i meant - called from conductor where the rp isn't in the cache | 20:51 |
efried | or check the cache first. | 20:51 |
mriedem | i'm going to avoid all of that for now because then you could have questions like, "should the caller say if they want the cache and should fail if the rp isn't in the cache?" | 20:52 |
efried | if self._provider_tree.exists(rp_uuid): | 20:52 |
efried | "avoid all of that for now" is going to be harder and introduce more technical debt. | 20:52 |
mriedem | sure - but if i'm compute and expect it in the cache and it's not, we'd want that to fail, not be swallowed | 20:52 |
mriedem | that's why i said a use_cache kwarg on get_provider_traits seems easier | 20:53 |
mriedem | the caller says what it wants | 20:53 |
efried | but you need two knobs | 20:53 |
mriedem | the very first thing i want to do is just split this large-ish change up into several pieces so i can test in isolation and reason about it | 20:53 |
efried | 1) retrieve from the cache | 20:53 |
efried | 2) update the cache | 20:53 |
efried | one does not imply the other | 20:54 |
mriedem | ... | 20:54 |
mriedem | meaning refresh if it's not in the cache and return the cached results, | 20:54 |
mriedem | or don't get from the cache, get from the API, but update the cache... | 20:54 |
mriedem | ? | 20:54 |
mriedem | i'm just going to work on splitting this all up and put a TODO in my code that uses get_provider_traits to somehow leverage the cache - it can be debated in review at that point i think when i actually have something working end to end (which the change is now - the func test shows that, but i'm going to be splitting up and possibly breaking things) | 20:55 |
efried | okay | 20:56 |
spatel | sean-k-mooney: hey | 20:57 |
efried | nts: http://specs.openstack.org/openstack/nova-specs/specs/train/approved/pre-filter-disabled-computes.html | 20:58 |
*** BjoernT has quit IRC | 20:59 | |
mriedem | heh well i've got a chicken-and-egg so i likely can't use the cache anyway | 21:08 |
mriedem | rt init needs the driver https://github.com/openstack/nova/blob/914ee91a5caedcaba64472762c9f08d7bb644d11/nova/compute/manager.py#L538 | 21:08 |
mriedem | and the driver init needs the virtapi https://github.com/openstack/nova/blob/914ee91a5caedcaba64472762c9f08d7bb644d11/nova/compute/manager.py#L535 | 21:08 |
mriedem | unless i do something hacky like self.virtapi.reportclient = self.reportclient.... | 21:09 |
*** Sundar has joined #openstack-nova | 21:14 | |
efried | that's what we've done all over the place, innit? | 21:14 |
efried | I guess mostly the other way around, self.reportclient = self.otherthingy.reportclient | 21:14 |
efried | you could pass the reportclient into the virtapi constructor | 21:15 |
mriedem | yeah i'm constructing the singleton reportclient in ComputeManager and passing that to RT and ComputeVirtAPI | 21:16 |
efried | ++ | 21:16 |
*** gouthamr_ is now known as gouthamr | 21:16 | |
*** markmcclain has joined #openstack-nova | 21:17 | |
*** eharney has quit IRC | 21:20 | |
*** ivve has quit IRC | 21:20 | |
*** factor has joined #openstack-nova | 21:37 | |
*** rajinir has quit IRC | 21:38 | |
tonyb | sean-k-mooney: We needed to do it in requirements in order to *generate* constraints | 21:42 |
*** spatel has quit IRC | 21:44 | |
*** dpawlik has quit IRC | 21:44 | |
tonyb | sean-k-mooney: You say it's breaking the requirements-check job but I don't see that | 21:45 |
tonyb | sean-k-mooney: Given our, lack, of TZ overlap might be best to do this via email? | 21:45 |
sean-k-mooney | im here | 21:45 |
sean-k-mooney | we do not generate constratis to project anymore | 21:46 |
sean-k-mooney | at least the lower constratits | 21:46 |
sean-k-mooney | the reason i say i breaks the requirement check is https://review.opendev.org/#/c/666651/2/doc/requirements.txt | 21:47 |
sean-k-mooney | simply addint a comment or otherwise modifying the requiremetns file cause the requirements-check job to fail | 21:47 |
sean-k-mooney | we can see the error here | 21:48 |
sean-k-mooney | http://logs.openstack.org/51/666651/2/check/requirements-check/c8c82c5/job-output.txt.gz#_2019-06-20_17_39_08_901350 | 21:48 |
sean-k-mooney | tonyb: ^ | 21:48 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add placement request filter for disabled computes https://review.opendev.org/654596 | 21:48 |
tonyb | sean-k-mooney: okay so there are a couple of things | 21:49 |
tonyb | sean-k-mooney: the requirements team needs to generate constraints (upper) daily and without capping sphinx (and others) in g-r we can't do that | 21:49 |
*** sapd1_x has joined #openstack-nova | 21:49 | |
sean-k-mooney | ah so when you said generate you ment upper-constraitns not requirement files for projects | 21:50 |
tonyb | sean-k-mooney: and also the 'fix' to that error is to just merge the chnage that caps sphinx, which is the expected process albeit a little ugly now that we don't auto-sync | 21:50 |
tonyb | sean-k-mooney: correct | 21:51 |
sean-k-mooney | yes we have a patch for that but my understdaint is project are not ment to cap any package in ther own reqiuremets file | 21:51 |
sean-k-mooney | the can balcklis tthing the know do not work but if cap we can break compatiobliy for the intergrated services | 21:51 |
tonyb | sean-k-mooney: In general we try very hard not to cap in g-r or per project but it isn't "forbidden" | 21:52 |
tonyb | sean-k-mooney: and with this whole no more py2 support thing we don't have a choice | 21:52 |
sean-k-mooney | well that is due to useing gloabl-requiremtns for two thing | 21:52 |
sean-k-mooney | generatihing upper-constratints and capping python2 things | 21:53 |
tonyb | sean-k-mooney: and listing "approved libraries" so that's 3 things | 21:53 |
sean-k-mooney | well no it because we use it for generating uppercontratitgs | 21:53 |
sean-k-mooney | ya | 21:53 |
sean-k-mooney | so the last point is what i thought its priamary pourpous was | 21:54 |
sean-k-mooney | listing the appoved libs that wee know are compatiable and are manged by the requiremetns project | 21:54 |
tonyb | sean-k-mooney: I'm interested in your statement "if cap we can break compatiobliy for the intergrated services" can you elaborate? | 21:54 |
*** mriedem has quit IRC | 21:55 | |
sean-k-mooney | os-vif say mock < X some other poject requires mock > x | 21:55 |
sean-k-mooney | os-vif and that service can nolonger be installed together | 21:55 |
tonyb | sean-k-mooney: ahhh okay .... that's handled in the generate-constraints job so it *shouldn't* be possible | 21:56 |
*** Sundar has quit IRC | 21:56 | |
tonyb | sean-k-mooney: for *upper* constraints for lower all bets are off | 21:56 |
sean-k-mooney | can you explain breifly how upper-constratis is generated | 21:56 |
sean-k-mooney | i.e. how is gr used for uc | 21:56 |
tonyb | sean-k-mooney: basically we pip install -r global-requirements.txt and "freeze" the output | 21:57 |
sean-k-mooney | i was not aware uc was generated for gr | 21:57 |
*** rdopiera has quit IRC | 21:57 | |
sean-k-mooney | i though uc was manually updated as needed | 21:57 |
sean-k-mooney | rathar then auto updating as upstream releases? | 21:57 |
sean-k-mooney | i guess that is not the case? | 21:58 |
tonyb | for master it's a daily update and then "fixed" if needed, for stable it's all manual | 21:58 |
*** panda has quit IRC | 21:58 | |
sean-k-mooney | ah ok so master allows latest unless we know somthing is broken | 21:58 |
sean-k-mooney | is gr used to pin things that are broken in that case ? | 21:58 |
tonyb | https://review.opendev.org/#/c/666981/ was last night's auto generate | 21:58 |
tonyb | sean-k-mooney: Yes, if lib $foo has a broken version we add a != in g-r to avoid it | 21:59 |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Libvirt: add vPMU spec for train https://review.opendev.org/651269 | 21:59 |
sean-k-mooney | and we are now using sphinx < 2.0 as a shorthad to cover all the non py27 versions | 22:00 |
*** icarusfactor has joined #openstack-nova | 22:01 | |
sean-k-mooney | ok i can approve https://review.opendev.org/#/c/666387/ but its kind of regretable that we will have to modify requirement every time gr is modifed to reflect a new cap. | 22:01 |
*** factor has quit IRC | 22:02 | |
sean-k-mooney | if the cap was only done via upper-constratits then it would just automaticlly work | 22:02 |
tonyb | sean-k-mooney: Yes, we've always needed to do that but it's just more obvious now | 22:02 |
tonyb | sean-k-mooney: I agre it's ugly but we can't think of a better way with the tools we have | 22:02 |
sean-k-mooney | nova os-vif and other project that generate docs form code need to use uc to pin to compatible verions anyway otherwise they can fail | 22:02 |
tonyb | sean-k-mooney: correct | 22:03 |
*** panda has joined #openstack-nova | 22:03 | |
tonyb | sean-k-mooney: gotta disappear I'll be back in a bit | 22:03 |
sean-k-mooney | hehe im going to drop too. i was playing games on my desktop but its late enough now that i should praobbly call it a day o/ | 22:04 |
sean-k-mooney | tonyb: thanks for explainin | 22:04 |
sean-k-mooney | i had taken the view that capping in requiremetn in repo was nolonger allowed but ill adjust to allowing it if it is capped that way in gr going forward | 22:05 |
*** Sundar has joined #openstack-nova | 22:08 | |
*** bbowen has quit IRC | 22:10 | |
*** mlavalle has quit IRC | 22:14 | |
tonyb | sean-k-mooney: we (the requirements team) clearly need better reference docs or a FAQ or something | 22:27 |
*** ociuhandu has quit IRC | 22:30 | |
*** ociuhandu_ has joined #openstack-nova | 22:30 | |
*** ociuhandu_ has quit IRC | 22:31 | |
*** lbragstad has quit IRC | 22:41 | |
openstackgerrit | Merged openstack/nova master: bdm: store empty object as connection_info by default https://review.opendev.org/645352 | 22:47 |
*** rcernin has joined #openstack-nova | 22:51 | |
*** BjoernT has joined #openstack-nova | 22:54 | |
*** tkajinam has joined #openstack-nova | 22:55 | |
*** ianw_pto is now known as ianw | 23:08 | |
*** jaypipes_ has quit IRC | 23:18 | |
*** _erlon_ has quit IRC | 23:22 | |
*** slaweq has quit IRC | 23:24 | |
*** takashin has joined #openstack-nova | 23:33 | |
*** sapd1_x has quit IRC | 23:52 | |
*** rcernin has quit IRC | 23:59 | |
*** rcernin has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!