Monday, 2019-06-24

*** threestrands has joined #openstack-nova00:04
*** rcernin has quit IRC00:06
*** eharney has quit IRC00:15
*** rcernin has joined #openstack-nova00:18
*** sapd1_x has joined #openstack-nova00:27
*** sapd1_x has quit IRC00:44
*** ajo has quit IRC00:51
*** ajo has joined #openstack-nova00:51
*** masayukig has quit IRC00:51
*** mrhillsman has quit IRC00:51
*** awestin1 has quit IRC00:52
*** niceplace has quit IRC00:52
*** masayukig has joined #openstack-nova00:53
*** awestin1 has joined #openstack-nova00:54
*** niceplace has joined #openstack-nova00:54
openstackgerritTakashi NATSUME proposed openstack/nova master: doc: Fix nova-manage cell_v2 list_cells output  https://review.opendev.org/66699501:10
*** rcernin has quit IRC01:12
*** markvoelker has quit IRC01:14
*** markvoelker has joined #openstack-nova01:16
*** rcernin has joined #openstack-nova01:17
*** brinzhang has joined #openstack-nova01:21
*** Dinesh_Bhor has quit IRC01:27
*** Dinesh_Bhor has joined #openstack-nova01:31
*** threestrands has quit IRC01:41
*** jhesketh has quit IRC02:12
*** jhesketh has joined #openstack-nova02:13
openstackgerritTakashi NATSUME proposed openstack/nova master: Add a live migration regression test  https://review.opendev.org/64120002:24
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py  https://review.opendev.org/56615302:29
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13)  https://review.opendev.org/57602002:29
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14)  https://review.opendev.org/57602702:31
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15)  https://review.opendev.org/57603102:31
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Add a guide to add a new microversion support  https://review.opendev.org/66700202:46
*** dklyle has quit IRC03:00
*** psachin has joined #openstack-nova03:16
openstackgerritMerged openstack/nova master: extend libvirt video model support  https://review.opendev.org/64773303:53
*** whoami-rajat has joined #openstack-nova03:54
*** udesale has joined #openstack-nova04:01
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16)  https://review.opendev.org/57629904:11
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17)  https://review.opendev.org/57634404:11
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18)  https://review.opendev.org/57667304:11
*** bhagyashris has joined #openstack-nova04:14
*** ricolin has joined #openstack-nova04:19
*** adrianreza has joined #openstack-nova04:44
*** ivve has joined #openstack-nova04:51
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19)  https://review.opendev.org/57667605:32
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20)  https://review.opendev.org/57668905:33
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21)  https://review.opendev.org/57670905:33
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22)  https://review.opendev.org/57671205:33
*** ratailor has joined #openstack-nova05:40
*** Luzi has joined #openstack-nova05:45
*** brault has joined #openstack-nova06:02
*** ildikov_ has joined #openstack-nova06:07
*** coreycb_ has joined #openstack-nova06:08
*** tinwood_ has joined #openstack-nova06:10
*** Anticime1 has joined #openstack-nova06:10
*** ircuser-1 has joined #openstack-nova06:14
*** gouthamr_ has joined #openstack-nova06:14
*** tinwood has quit IRC06:15
*** coreycb has quit IRC06:15
*** smcginnis has quit IRC06:15
*** Anticimex has quit IRC06:15
*** fnordahl has quit IRC06:15
*** ildikov has quit IRC06:15
*** gouthamr has quit IRC06:15
*** coreycb_ is now known as coreycb06:15
*** ildikov_ is now known as ildikov06:15
*** irclogbot_3 has quit IRC06:18
*** dpawlik has joined #openstack-nova06:18
*** panda has quit IRC06:18
*** alex_xu has quit IRC06:18
*** ccamacho has joined #openstack-nova06:19
*** irclogbot_0 has joined #openstack-nova06:19
*** panda has joined #openstack-nova06:20
*** pcaruana has joined #openstack-nova06:25
*** belmoreira has joined #openstack-nova06:44
*** martinkennelly has joined #openstack-nova06:47
*** lpetrut has joined #openstack-nova06:49
*** rdopiera has joined #openstack-nova06:52
*** rcernin has quit IRC06:57
*** maciejjozefczyk has joined #openstack-nova06:58
*** damien_r has joined #openstack-nova07:02
*** damien_r has quit IRC07:02
*** damien_r has joined #openstack-nova07:03
*** damien_r has quit IRC07:03
*** damien_r has joined #openstack-nova07:04
*** markvoelker has quit IRC07:07
*** jaosorior has joined #openstack-nova07:11
*** tesseract has joined #openstack-nova07:11
*** lwq has joined #openstack-nova07:14
*** helenafm has joined #openstack-nova07:23
*** hjensas has quit IRC07:25
*** ccamacho has quit IRC07:31
*** xek has joined #openstack-nova07:33
*** brinzhang has quit IRC07:34
*** brinzhang has joined #openstack-nova07:35
*** ccamacho has joined #openstack-nova07:39
*** tssurya has joined #openstack-nova07:39
*** trident has quit IRC07:40
*** trident has joined #openstack-nova07:41
*** fnordahl has joined #openstack-nova07:44
openstackgerritSlawek Kaplonski proposed openstack/nova master: Revert "Revert resize: wait for events according to hybrid plug"  https://review.opendev.org/66703507:50
*** ralonsoh has joined #openstack-nova07:54
*** luksky has joined #openstack-nova08:03
*** ttsiouts has joined #openstack-nova08:04
*** jaosorior has quit IRC08:13
*** jaosorior has joined #openstack-nova08:17
*** tkajinam has quit IRC08:29
lyarwood~.08:36
*** imacdonn has quit IRC08:42
*** imacdonn has joined #openstack-nova08:42
*** factor has quit IRC08:43
*** whoami-rajat has quit IRC08:48
bhagyashrisHi all, I am trying to live migrate the instance but getting this error: http://paste.openstack.org/show/753291/  on nova compute side can any one have nay idea about the same?08:55
kashyapbhagyashris: My first guess from the error is that you don't have enough free RAM.08:57
kashyapOh, wait.  Thre's also a "length mismatch" error08:57
kashyapbhagyashris: What distro is this, and what are you rversions of libvirt and QEMU?09:00
*** udesale has quit IRC09:02
*** udesale has joined #openstack-nova09:03
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance  https://review.opendev.org/45788609:03
*** udesale has quit IRC09:04
bhagyashriskashyap: Hi, I have pasted all details here : http://paste.openstack.org/show/753292/ please check and let me know.09:05
*** markvoelker has joined #openstack-nova09:08
stephenfinbhagyashris: This looks relevant https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/171349009:08
openstackLaunchpad bug 1713490 in Ubuntu Cloud Archive "error migrating blocked on virtio-net-pci.rom" [Undecided,Confirmed]09:08
*** udesale has joined #openstack-nova09:08
stephenfinbhagyashris: As does this https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01663.html09:08
kashyapstephenfin: You wouldn't believe: that "Length mismatch" is the improved (unactionable) error from QEMU09:09
kashyaps/improved/"improved"/ (missed the scare quotes :D)09:09
stephenfino rly?09:10
kashyapYeah, checking with Dave from QEMU, he says:09:10
kashyap< dgilbert> kashyap: So, that's a packaging bug for their virtio rom; they need to pad09:10
kashyapstephenfin: Reference for the "improvement" (it actually _is_, though, relative to the previous one): https://bugzilla.redhat.com/show_bug.cgi?id=109009309:11
openstackbugzilla.redhat.com bug 1090093 in libvirt "Improve error reporting when QEMU fails with incoming migration" [Unspecified,Closed: errata] - Assigned to jdenemar09:11
kashyapbhagyashris: So I was told it's a distribution bug, so please file with Ubuntu.  (Where the packager needs to pad the ROM with 0 bytes, using `dd`.) thanks, Dave Gilbert for the suggestion.09:13
*** udesale has quit IRC09:13
*** udesale has joined #openstack-nova09:14
openstackgerritTakashi NATSUME proposed openstack/nova master: Add database schema upgrade check  https://review.opendev.org/66704709:18
*** ricolin has quit IRC09:22
*** davidsha has joined #openstack-nova09:29
*** ociuhandu has joined #openstack-nova09:30
openstackgerritSam Morrison proposed openstack/nova stable/rocky: Fix double word hacking test  https://review.opendev.org/66578809:32
*** takashin has left #openstack-nova09:33
openstackgerritSam Morrison proposed openstack/nova stable/queens: Fix double word hacking test  https://review.opendev.org/66579009:33
*** damien_r has quit IRC09:34
*** damien_r has joined #openstack-nova09:36
bhagyashriskashyap: ok thank you! So for workaround I will set the kvm version same for both the machine and will try .09:39
kashyapbhagyashris: Also see the guidance here: https://wiki.qemu.org/Features/Migration/Troubleshooting#Length_mismatch:_....:_...._in_.21.3D_.....09:40
kashyapIt does require work from distros.09:40
*** markvoelker has quit IRC09:42
bhagyashriskashyap: ok you mean it should install through bistro?09:43
bhagyashrisdistro*09:43
kashyapbhagyashris: I mean, there is an action item for Ubuntu QEMU packager to "pad the ROM" (it's a low-level thing)09:43
lwqHi there, I would like to discuss possible improvement of nova resize/migrate process - I mean the SCP part … Anyone with experience with this topic? :-)09:50
*** udesale has quit IRC09:51
*** udesale has joined #openstack-nova09:52
*** udesale has quit IRC09:56
*** udesale has joined #openstack-nova09:57
*** udesale has quit IRC10:00
*** udesale has joined #openstack-nova10:00
*** HD|Laptop has quit IRC10:09
*** belmoreira has quit IRC10:12
*** ttsiouts has quit IRC10:17
*** ttsiouts has joined #openstack-nova10:18
openstackgerritMerged openstack/python-novaclient master: Fix duplicate object description error  https://review.opendev.org/66620310:20
bhagyashriskashyap: ohh ok thank you !10:22
*** ttsiouts has quit IRC10:22
*** bhagyashris has quit IRC10:23
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator)  https://review.opendev.org/65155510:35
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name)  https://review.opendev.org/65210310:35
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence)  https://review.opendev.org/65210410:35
openstackgerritStephen Finucane proposed openstack/nova master: tests: Use consistent URL regex substitution  https://review.opendev.org/66594910:35
openstackgerritAlex Xu proposed openstack/nova master: Assign the request_spec's network_metadata after create  https://review.opendev.org/66706110:35
openstackgerritSlawek Kaplonski proposed openstack/nova master: Revert "Revert resize: wait for events according to hybrid plug"  https://review.opendev.org/66703510:36
*** markvoelker has joined #openstack-nova10:39
*** mandre has quit IRC10:41
*** rnoriega- has joined #openstack-nova10:44
*** rnoriega has quit IRC10:45
*** mandre has joined #openstack-nova10:45
*** ttsiouts has joined #openstack-nova10:46
*** alex_xu has joined #openstack-nova10:50
*** ttsiouts has quit IRC10:50
alex_xustephenfin: something should be under your radar https://review.opendev.org/66706110:51
stephenfinalex_xu: Looking at it at the moment :)10:51
*** sapd1_x has joined #openstack-nova10:56
*** jaypipes has joined #openstack-nova10:57
*** mvkr has joined #openstack-nova11:04
*** belmoreira has joined #openstack-nova11:04
*** markvoelker has quit IRC11:13
*** ttsiouts has joined #openstack-nova11:19
*** ttsiouts has quit IRC11:19
*** _erlon_ has joined #openstack-nova11:19
*** ttsiouts has joined #openstack-nova11:19
*** jaosorior_ has joined #openstack-nova11:21
*** jaosorior has quit IRC11:23
*** mkrai_ has joined #openstack-nova11:39
*** udesale has quit IRC11:39
NewBruce3has anyone ever been able to live migrate VMs from CentOS (RDO) with SELinux to Ubuntu (OSA) with AppArmor?11:45
*** NewBruce3 is now known as NewBruce11:49
NewBrucei am convinced there is a way to do it, reading into the libvirt docs, but nothing has worked so far11:50
kashyapNewBruce: I don't think (read: "I'm pretty sure") you will find official libvirt docs for it :-)11:57
*** ratailor has quit IRC11:58
kashyapIf you're trying that, be aware that you might be left holding holding a bag of broken VM parts.11:58
kashyaps/"holding holding"/holding/11:58
kashyapNewBruce: But ... if you _did_ succeed (or otherwise) might want to write a public blog post, with your exploits11:59
*** markvoelker has joined #openstack-nova12:04
*** edleafe has joined #openstack-nova12:08
NewBrucewell you can ask mnaser how he did it ;)12:10
NewBrucesorry, having a quick chat with some libvirt people who think im doing some horrible sorcery to get migration from centos to ubuntu in the first place and that is courtesy of mnaser but long story short seems… impossible?12:11
*** jangutter has joined #openstack-nova12:12
NewBrucei expected to see a seclabel=selinux in the xml, but wasnt there but migrations fail….12:13
NewBruceLive Migration failure: unsupported configuration: Unable to find security driver for model selinux: libvirtError: unsupported configuration: Unable to find security driver for model selinux12:13
*** whoami-rajat has joined #openstack-nova12:14
kashyapNewBruce: Ah, I see you're on #virt, OFTC.  (Haven't read the detail; buried in too many things)12:19
NewBruceyeah, figured someone here might have tried before; but more likely the libvirt peoples would be up on it - seems this is a corner case; though surprising no one has ever moved from RDO to OSA before….12:20
kashyapYour machine types on source and destination won't match -- one of your main blockers...12:21
NewBrucei beleive that is what mnaser has helped patch for us (wasnt around when he did that)12:21
NewBrucebut live migrating from RDO -> OSA definitely works for us; ive done it thousands of times now on another site - its just this setup im with now has SELinux on the RDO side which is a pain on the Ubuntu side as there are horrible bugs on Ubuntu with SELinux12:22
NewBrucelike not being able to create new users (which we can work around…. but still)12:22
NewBrucerunning SELinux on Ubuntu is not a preferred long-term solution12:23
*** markvoelker has quit IRC12:24
kashyapRight, as I just noted on #virt; you do need some way of recompiling QEMU on Ubuntu, based on CentOS QEMU source (for the machine types)12:24
NewBrucewhich it appears we have12:24
NewBruce… should we move this over to #virt? :D12:24
*** jroll has quit IRC12:28
*** jroll has joined #openstack-nova12:29
kashyapYeah.12:33
*** priteau has joined #openstack-nova12:42
mnaserkashyap, NewBruce: pretty much deconstructed the srpm from redhat and added all the patches to the Deb which included all the machine typed etc to make it possible12:42
kashyapmnaser: Wauw; have to admit, that's one really burdensome source you'll have to maintain12:46
NewBruceaccording to the folks ok #virsh mnaser this makes you certifiable! :D12:46
mnaserkashyap: I did tell the NewBruce and co that this will survive one single live migration and we reinstall the original binaries right after and it will block live migrations after12:47
* kashyap nods12:47
mnaserSo the goal was just to get the one live migration done, reinstall original qemu and then on any full reboot they get the Ubuntu machine type12:48
kashyapmnaser: If I may ask, is the goal to get off of CentOS altogether?12:49
*** beekneemech is now known as bnemec12:51
*** zbr is now known as zbr|ruck12:53
*** mkrai_ has quit IRC12:58
*** mkrai__ has joined #openstack-nova12:58
*** lbragstad has joined #openstack-nova13:02
*** lwq has quit IRC13:02
*** ttsiouts has quit IRC13:12
*** ttsiouts has joined #openstack-nova13:13
*** ttsiouts has quit IRC13:14
*** ttsiouts has joined #openstack-nova13:14
efried_ptosean-k-mooney: Is https://blueprints.launchpad.net/nova/+spec/libvirt-video-device-models code complete since https://review.opendev.org/#/c/647733/ has merged?13:14
efried_ptosean-k-mooney: I see there's some minor cleanup, but that doesn't look critical. And something on the glance side?13:15
*** brinzhang_ has joined #openstack-nova13:16
*** jdillaman has joined #openstack-nova13:19
*** brinzhang has quit IRC13:20
*** BjoernT has joined #openstack-nova13:24
openstackgerritMerged openstack/os-traits master: add libvirt image metadata traits  https://review.opendev.org/65299613:25
openstackgerritMerged openstack/os-traits master: add GOP, NONE and VIRTIO grapics models  https://review.opendev.org/66583013:25
*** trident has quit IRC13:29
*** mriedem has joined #openstack-nova13:29
openstackgerritMerged openstack/nova master: Remove redundant group host setup  https://review.opendev.org/66595413:33
openstackgerritMerged openstack/nova master: [FUP] fix backleveling unit test for video models  https://review.opendev.org/66691913:33
openstackgerritMerged openstack/nova master: Mention [cinder]/cross_az_attach in the AZ docs  https://review.opendev.org/65045613:34
*** trident has joined #openstack-nova13:35
*** eharney has joined #openstack-nova13:37
*** BjoernT_ has joined #openstack-nova13:39
mriedemsean-k-mooney: so same host revert resize huh, who know neutron had a gate job for ovs hybrid plug...13:41
mriedemwe should probably throw that into nova's experimental queue to be run on-demand13:41
*** BjoernT has quit IRC13:41
mriedems/should/could/ since that means someone would have to remember to run it13:41
*** _erlon_ has quit IRC13:43
sean-k-mooneyya we should13:44
efried_ptosean-k-mooney: see question above about libvirt-video-device-models?13:45
efried_ptooh13:46
*** efried_pto is now known as efried13:46
sean-k-mooneysorry give me 5 mins13:47
efriedsure, no hurry. Meanwhile, I'll hammer you in -placement as well.13:47
*** jaosorior_ has quit IRC13:48
*** jaosorior has joined #openstack-nova13:49
*** jaosorior has quit IRC13:49
mriedemsean is also working on pushing a patch to try and fix the neutron gate,13:49
mriedemunless we just go with this revert https://review.opendev.org/#/c/667035/213:50
mriedemslaweq: looks like ^ makes the job pass now, i checked zuul on your neutron change that depends on the nova revrt13:50
mriedem*Revert13:50
efriedthat's way more important than my blueprint paperwork13:51
mriedemslaweq: what i'd like to know is do we still get a network-vif-plugged event for ovs hybrid plug ports during same host revert resize at the time of plugging the vif (because apparently we don't when binding the port and the host doesn't change - which is different in behavior from how non-hybrid plug ovs ports work apparently)13:51
efried(</ptl-hat> for pretty much any value of $that)13:51
sean-k-mooneymriedem: actully we had a production outage of our internal cloud and i just spent the last 2 hours helping them fix it13:52
mriedemsean-k-mooney: please oh please say it was because of this ovs hybrid plug patch :)13:52
sean-k-mooneymriedem: so im about to start on a patch to fix the neutron issue but ill leave it up to you do we want to revert it and merge a fixed patch later or merge a fix and wait form me to write it13:53
sean-k-mooneymriedem: no it was releated to messing up the neutorn policy.json that currpted the network info_cache and all vms nolonger had interfaces13:53
mriedemsean-k-mooney: aha that sounds familiar (the same thing ovh fixed in stein)13:54
sean-k-mooneyyep13:54
sean-k-mooneywe have not backported it to 13 yet13:54
mriedemapparently screwing up your neutron policy and blasting the nova info cache is something a lot of people do...13:54
sean-k-mooneyya so i just figured out what db surgery is need and our devops folks are now doing it13:55
sean-k-mooneyso do we want to fast revert the event change13:55
mriedemsean-k-mooney: for artom's patch i think we likely should land the revert and then work the same host thing into a combined patch13:55
mriedemsince you guys want to backport this13:55
sean-k-mooneyor will i write a patch quickly to skip waiting for event for same host resize13:55
mriedemreverting gives time to sort out why same host resize events are different for this vif type than non-hybrid plug ovs - that inconsistency is really screwy13:56
sean-k-mooneyok im fine with that i just didnt want to cause more revew burden for you/others13:56
mriedemslaweq's revert patch's commit message likely needs work13:56
rouksean-k-mooney: i found the ceph issue and it fixed the nova issue, it was an MTU  someone thought would be fun to drop to 1500 on a single switch of the 2 switches doing LACP to that host.13:57
*** Luzi has quit IRC13:57
roukso some ceph responses would just fail, cause 9k byte, and then nova would sit forever silently13:57
*** brinzhang_ has quit IRC13:58
*** udesale has joined #openstack-nova13:58
dansmithrouk: ouch :)13:58
rouknova needs some logging of its check cycle in debug mode though, having to trace from rabbitmq heartbeats as the symptom is rough13:59
sean-k-mooneyrouk: im sure that was fun to debug13:59
sean-k-mooneyit explains the behavior you were seeing however14:00
rouk4 days of man hours tracing through from the rabbitmq server because im always told "its not the network".14:00
sean-k-mooneyim still slightly annoyed/upsent/concerned that the nova-compute agent basicaly hard locks when it cant connect to ceph to get the capsity fo the ceph rbd pool14:01
roukso, can i wishlist some debug messages for the check phases in nova's cycle? lol14:01
roukyeah, it would send the message to ceph, and the ceph client retries every 30 seconds or so, and random dice based on what primary connection the LAPC uses determines if it returns or not, and it hangs forever till it gets a response.14:01
*** mrch_ has quit IRC14:01
sean-k-mooneyhehe if you can suggest what they should be we can proably add them14:02
*** smcginnis has joined #openstack-nova14:02
roukissue was only found tcpdumping ceph, would see a 9k byte response out of ceph and the client wouldnt hear about it.14:03
roukwell... im not aware of all the checks, would be good if it was even just a basic debug on what function it was checking, just to narrow down debug.14:03
roukright now the messages stop pretty high up, so the only thing to check is everything.14:04
sean-k-mooneyim guessing it was working just well enough for the tcp connection not to drop14:04
sean-k-mooneyif we got a disconnect that would proably have shown up in the logs14:05
roukany tcp/udp/icmp with RESPONSES under 1500 worked perfectly 100% of the time.14:05
sean-k-mooneyya im not sure nova could figure that our however.14:05
sean-k-mooneyrouk: did you file a bug for this by the way?14:05
rouknope, since its my fault.14:06
roukif nova would give up on the ceph client after even 20 seconds it would be fine imo14:06
sean-k-mooneywell we proably should be making that call with a timeout and raising an error if we dont get the resopce14:06
*** lpetrut has quit IRC14:06
roukpacket loss ceph client hangs for 30 seconds per retry or so, but if the backend is not responding for even over 1 second, somethings up.14:06
*** dave-mccowan has joined #openstack-nova14:07
roukyeah, anything over 1 second is bad, and 20 seconds imo is an ERROR tier.14:07
sean-k-mooneyya i think as a general enchancement haveing a config option to control a timout on ceph calls would likely be a good thing14:07
roukshould i fill it out somewhere in particular?14:08
openstackgerritMatt Riedemann proposed openstack/nova master: Remove comments about mirroring changes to nova/cells/messaging.py  https://review.opendev.org/66710714:09
sean-k-mooneyrouk: https://bugs.launchpad.net/nova/+filebug14:09
sean-k-mooneyrouk: if you just file a bug and state i asked you too then it wont get closed imediatly as a ceph issue :)14:10
* mriedem waits to close immediately14:10
sean-k-mooneystate something like "nova should timeout request to ceph, instead of hanging on network issues" and descibe the behavior you saw14:11
*** belmoreira has quit IRC14:11
*** dave-mccowan has quit IRC14:11
sean-k-mooneymriedem: i dont know if we can fix it but at least we can sse if its sane or not and then close it :)14:11
mriedemi was just joking14:12
rouksean-k-mooney: can do.14:13
sean-k-mooney:) i was assuming that but i also need to go grab coffe so brb14:14
roukoh, launchpad, my ubuntuone cant use launchpad due to "oops" error, no response from support about it... guess ill make a new account or something.14:14
dansmithmriedem: sean-k-mooney: so what's the deal? is there another patch to fix same host we're watching, or are we going to merge this, re-propose, etc?14:18
dansmithI imagine neutron people want to know14:19
mriedemdansmith: i said i think we should land the revert14:21
mriedemthe commit message could use a tweak to explain why the original is busted14:21
mriedembut slaweq appears to be gone14:21
dansmithmriedem: okay I saw you said you were "OK" with it, but didn't see that was the plan14:21
dansmithso let's update it for him and approve?14:21
mriedemyeah i can do that14:21
sean-k-mooneydansmith: ya we are going to revert14:22
openstackgerritSlawek Kaplonski proposed openstack/nova master: Revert "Revert resize: wait for events according to hybrid plug"  https://review.opendev.org/66703514:23
sean-k-mooneyto be honest this give me more time to test this for the same host resize case too and the backport will be simpler since it will be  1 patch so it better in the log run14:23
dansmithmriedem: ^ good?14:23
openstackgerritMatt Riedemann proposed openstack/nova master: Revert "Revert resize: wait for events according to hybrid plug"  https://review.opendev.org/66703514:24
mriedemd'oh14:24
mriedemdansmith: +214:25
*** ccamacho has quit IRC14:25
*** dpawlik has quit IRC14:25
dansmithokay cool14:26
slaweqmriedem: hi, I just updated this commit message, sorry for the delay, I was on meeting14:29
mriedemsean-k-mooney: i've marked the original bug as "triaged" rather than "fix released" so your patch can still close the original bug https://bugs.launchpad.net/nova/+bug/183202814:29
openstackLaunchpad bug 1832028 in OpenStack Compute (nova) stein "revert resize: vif-plugged external event sent too soon if Neutron is using OVS hybrid plug" [Medium,In progress] - Assigned to Lee Yarwood (lyarwood)14:29
mriedemslaweq: yup me too :) the revert is approved14:29
slaweqmriedem: thx a lot14:29
mriedemslaweq: i'll just say again that the inconsistency of when neutron sends these events per vif type sucks14:29
mriedemfrom a consumer pov14:29
slaweqmriedem: yes, I know14:30
*** mlavalle has joined #openstack-nova14:30
slaweqwe also found other issue with live-migration and e.g. networking-ovn recently but that will be reported separately later14:30
mriedemi've heard (from the rh nova team)14:31
mriedemwhich is why you changed to ovs hybrid plug and then found this issue14:31
sean-k-mooneymriedem: ack, do i need to respond on the ml14:31
mriedemsean-k-mooney: saying we approved the revert on the ML is probably good for people to hold their rechecks14:32
*** belmoreira has joined #openstack-nova14:32
* mriedem realizes this will probably reset the gate for about a day14:32
dansmithpromotion time?14:33
mriedemi'm not the person to ask probably14:33
*** jaosorior has joined #openstack-nova14:33
* sean-k-mooney resets days since last gate blocking patch14:33
dansmithsean-k-mooney: lol14:33
mriedemit won't block nova of course14:33
mriedemwe're just blocked by the rate limiting14:33
*** belmoreira has quit IRC14:34
sean-k-mooneymriedem: on the upside since neutron are not using there gate currently nova should speed up  :P14:34
* mriedem rebases 45 patch cross-cell-resize series14:35
*** belmoreira has joined #openstack-nova14:36
zigoIs there an openstackclient equivalent to nova server-migration-show?14:36
amorinhey all14:37
sean-k-mooneyzigo: not that i see at a glance14:38
zigosean-k-mooney: Ok, so I'm not completely bind then! :)14:38
stephenfinzigo: I don't think so. That was one of the gaps we identified in Denver (summit)14:39
sean-k-mooneyyou are not :) we dont have full parity14:39
sean-k-mooneyzigo: initally osc did not have admin commnds so that is the area we have the most gaps today14:39
zigoRight.14:39
zigoIf I put arp_responder = True, will this speed-up MAC learning for the network equipment connected to my compute?14:40
zigoIt usually takes dozens of seconds for it to learn what the new floating IP location is...14:41
sean-k-mooneyno14:41
*** rajinir has joined #openstack-nova14:41
zigosean-k-mooney: Is there some tricks? :)14:41
sean-k-mooneyarp_resopnder = true need the l2_population ml2 driver and does arp suppression so that openflow rules rewrite the arp request to an arp responce14:42
amorinI am currently facing a race condition in my OpenStack deployment. If I delete a port while the instance was booting (before nova plug the interface), then nova plug the interface and left the interface like this, after a while I have a lot of interface staying on the host14:42
sean-k-mooneyso if you set that and the vswich has the flow installed the arp will never get to the tor14:42
zigoRight.14:42
sean-k-mooneyso it will have the opisite effect in that learnign will only happen when you get an non arp packet14:43
rouksean-k-mooney: https://bugs.launchpad.net/nova/+bug/1834048 let me know if more is needed.14:43
openstackLaunchpad bug 1834048 in OpenStack Compute (nova) "Nova waits indefinitely on ceph client hangs due to network problems" [Undecided,New]14:43
zigosean-k-mooney: Ok, thanks.14:43
mriedemamorin: like this? https://review.opendev.org/#/c/663382/14:44
sean-k-mooneyrouk: cool thanks for filing ^ lyarwood  you might be able to determing if there is soemthing we can do to fix the ceph issue14:44
sean-k-mooneymriedem: hehe i was looking for that but it might help14:44
sean-k-mooneymriedem: that is specifcaly for the case wehre you delete the instance after teh vm has started running but before we have updated the db14:45
sean-k-mooneyi belive there are other case were this can happen too14:45
mriedemdansmith: regarding promoting that revert, slaweq could request it since i wouldn't be surprised if it takes all day to run the nova change through and even then will likely fail on some gate bug14:45
sean-k-mooneythat was the one i know was definetly broken14:45
amorinmriedem, sean-k-mooney almost like this14:45
dansmithmriedem: yeah that's what I was thinking.. looking at how many other things have -1s on them, this could take a while14:46
dansmithslaweq: mriedem: is that neutron job in neutron's gate?14:46
mriedemit's voting for neutron so i expect it's in neutron's gate queue yeah14:46
sean-k-mooneydansmith: yes it is14:46
dansmithso anything that has a recent check on it will head to the gate but fail every time, making the gate queue super slow too yeah?14:47
amorinmriedem: something like this:14:47
amorinhttp://paste.openstack.org/show/753313/14:47
sean-k-mooneyamorin: right in your case you are deleteing the neutorn port14:47
amorinyes, while booting the instance14:47
sean-k-mooneywell you should not actully get stale port in that case in ovs14:48
mriedemamorin: so nova plugs the vif, starts waiting for the network-vif-plugged event, the port is then deleted and we don't get the event so we timeout and fail the server build14:48
sean-k-mooneyin you logg you have the vif unplug which should clean it up14:48
mriedemsean-k-mooney: pretty sure we don't handle vif unplug and actually unplug14:48
mriedemfrom out of band network-vif-deleted events14:48
sean-k-mooneymriedem: we dont but we do on instance delete14:48
sean-k-mooneyso when we role back the spawn we should call unplug and clean up14:49
amorinI dont have unplug call14:49
mriedemisn't that stephen's patch?14:49
sean-k-mooneyno his is for a specifc case were we get an exception form the db14:49
sean-k-mooneyin that case we dont call cleanup14:50
sean-k-mooneyfor the timeout case we do14:50
mriedemhttps://review.opendev.org/#/c/663382/3/nova/compute/manager.py@202314:50
mriedemstephen's patch doesn't have any specific cases in it from what i can tell14:50
sean-k-mooney the downstream bug did14:51
mriedem"If an instance fails to build, which is possible for a variety of reasons, we may end up in a situation where we have remnants of a plugged VIF (typically files) left of the host. This is because we cleanup from the neutron perspective but don't attempt to unplug the VIF, a call which may have many side-effects depending on the VIF driver."14:51
amorinmy bad, I have unplug in my logs14:51
mriedemoh well the downstream bug...14:51
sean-k-mooneyit should be linkend in the upstream one but its addressing the case of when UnexpectedDeletingTaskStateError is raised14:52
mriedemthe rh bz is linked into the lp bug,14:52
mriedemi'm just annoyed that i need to follow the breadcrumb trail of bugs to know wtf is going on in a patch14:53
sean-k-mooneyya it should have been copied into the upstream bug14:53
mriedemamorin: if you have a reproducer of *your* scenario can you apply https://review.opendev.org/#/c/663382/ and see if that resolves it?14:53
sean-k-mooneysorry about that. stephen pick that bug up from me because i didnt have time to start on it two weeks ago14:54
amorinmriedem: yes14:54
amorinwill do14:54
mriedemsean-k-mooney: no i'm wrong, the details are in the lp bug, it's fine14:55
*** BjoernT_ has quit IRC14:56
sean-k-mooneyamorin: by the way stephenfin patch will just prevent new interface form leaking it will not clean up existing stale ports14:56
amorinsean-k-mooney: yes of course :p14:56
sean-k-mooneymriedem: as far as i can tell we could leak ports this way for years so its supper latent14:57
*** BjoernT has joined #openstack-nova14:57
*** cfriesen has joined #openstack-nova15:00
*** jaypipes_ has joined #openstack-nova15:01
*** jaypipes has quit IRC15:04
*** cfriesen has quit IRC15:04
*** jaosorior has quit IRC15:05
*** panda has quit IRC15:09
*** factor has joined #openstack-nova15:11
*** panda has joined #openstack-nova15:11
*** _alastor_ has joined #openstack-nova15:13
*** priteau has quit IRC15:17
*** ttsiouts has quit IRC15:17
*** ttsiouts has joined #openstack-nova15:18
*** jaosorior has joined #openstack-nova15:18
*** ttsiouts has quit IRC15:19
*** ttsiouts has joined #openstack-nova15:19
*** tinwood_ is now known as tinwood15:20
Nick_AHow do you set quota defaults for new projects? I did openstack quota set --instances 100 default, but new projects still show the instance limit at 1015:22
*** rouk has quit IRC15:24
mriedemNick_A: i suggest you read through https://docs.openstack.org/nova/latest/user/quotas.html and/or https://docs.openstack.org/nova/latest/admin/quotas.html15:25
mriedemand if there is a problem in those docs, then bring it here15:25
*** priteau has joined #openstack-nova15:25
openstackgerritStephen Finucane proposed openstack/nova master: WIP: docs: Rewrite host aggregate, availability zone docs  https://review.opendev.org/66713315:26
Nick_AI read through both before asking. Double checked my quota set command matches the docs.15:28
openstackgerritMatt Riedemann proposed openstack/nova master: Remove orphaned comment from _get_group_details  https://review.opendev.org/66713515:28
mriedemNick_A: check if there are per-project quotas set on the project which would override the defaults15:28
openstackgerritMerged openstack/python-novaclient master: Add irrelevant files in dsvm job  https://review.opendev.org/66621715:30
mriedemhttps://docs.openstack.org/nova/latest/user/quotas.html#checking-quota is the thing you want to check15:30
*** mkrai__ has quit IRC15:31
mriedemstephenfin: pretty sure https://review.opendev.org/666217 is broken15:31
stephenfinmriedem: Yup :( I'll submit a fixup15:33
*** tesseract has quit IRC15:33
openstackgerritStephen Finucane proposed openstack/python-novaclient master: Only ignore unit test changes for functional jobs  https://review.opendev.org/66714715:34
Nick_Ahttp://paste.openstack.org/show/OOfHU4BMoigiHYmODPMm/ also set instance quota to 100 for "admin" before creating the new project15:35
openstackgerritStephen Finucane proposed openstack/python-novaclient master: Only ignore unit test changes for functional jobs  https://review.opendev.org/66714715:35
*** jaosorior has quit IRC15:37
mriedemNick_A: I think your usage is wrong here: "openstack quota set --instances 100 default"15:37
*** BjoernT_ has joined #openstack-nova15:37
mriedemthat's setting instances quota to 100 for the "default" project, which doesn't exist15:37
*** BjoernT has quit IRC15:38
mriedemyou should be using "--class default" https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/quota.html#quota-set15:38
Nick_AThat's what I thought but that seems to be what the docs indicate15:38
mriedemthe osc cli docs aren't clear about what a class is or that "default" is the only class supported by nova...15:38
Nick_Ahttps://docs.openstack.org/nova/latest/admin/quotas.html these specifically15:39
mriedemyou mean "2. Update a default value for a new project, for example:"15:39
mriedemyeah that looks busted15:39
Nick_Aheh15:39
*** wwriverrat has quit IRC15:39
mriedem"$ openstack quota set --QUOTA_NAME QUOTA_VALUE PROJECT_OR_CLASS" is also misleading15:39
mriedemsince if you use a class you need to specify --class15:40
*** wwriverrat has joined #openstack-nova15:40
mriedemNick_A: please hit the bug link at the top of the page and report a nova docs bug15:40
*** luksky has quit IRC15:40
Nick_A# openstack quota set --class --instances 100 default <-- worked thank you15:42
mriedemlooks like that's been broken since pike https://review.opendev.org/#/c/490952/415:44
mriedemwhen the admin guide was using the nova cli correctly before the import of the docs and then it was changed to use the osc cli incorrectly15:45
mriedemi didn't notice that change since it wasn't mentioned in the commit message....15:45
openstackgerritMerged openstack/nova master: Ignore hw_vif_type for direct, direct-physical vNIC types  https://review.opendev.org/60946015:45
Nick_Abug submitted - thank you15:45
*** helenafm has quit IRC15:46
mriedemgdi that whole page probably has to be validated now15:47
mriedemNick_A: thanks15:47
*** sapd1_x has quit IRC15:48
mriedemstephenfin: maybe you want to fix this https://bugs.launchpad.net/nova/+bug/183405715:48
openstackLaunchpad bug 1834057 in OpenStack Compute (nova) "change default quota command example is incorrect" [Undecided,New]15:48
openstackgerritStephen Finucane proposed openstack/nova master: Unplug VIFs as part of cleanup of networks  https://review.opendev.org/66338215:48
mriedemsince you imported those docs and changed the cli used to be wrong w/o mentioning it in the commit15:48
stephenfinmriedem: https://github.com/openstack/openstack-manuals/commit/655a9ce2c6372b94d2023242292aaae3a511e63115:51
mriedemthat's not what's in https://github.com/openstack/openstack-manuals/blob/stable/ocata/doc/admin-guide/source/cli-set-compute-quotas.rst15:53
*** damien_r has quit IRC15:55
stephenfinYou're talking about the footer, I assume. I'm guessing that's because I wanted some kind of semi-permanent record though not the exact one15:58
stephenfinBut idk what I was thinking nearly two years ago15:58
dansmiththat neutron event patch is making it through check pretty well, compared to how it's been the last few weeks, so maybe not quite as long to gate as we thought15:59
stephenfinPoint is, I didn't change anything to be wrong. You could have just asked me to investigate and fix without assigning blame15:59
* stephenfin goes to fix that other guys mistake15:59
*** belmoreira has quit IRC16:02
*** belmoreira has joined #openstack-nova16:04
*** mkrai__ has joined #openstack-nova16:05
*** priteau has quit IRC16:05
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Revert "Add irrelevant files in dsvm job"  https://review.opendev.org/66715116:05
*** belmoreira has quit IRC16:06
mriedemstephenfin: yes the footer in the commit message points at the docs from stable/ocata so that's what i assumed you imported from, and those ocata docs were using nova CLIs but your change was not, so i assumed you changed things while importing16:06
mriedemdansmith: can you slam this through? https://review.opendev.org/#/c/667151/16:07
*** ttsiouts has quit IRC16:07
mriedemkeep the revert train rolling16:07
*** ttsiouts has joined #openstack-nova16:08
*** tssurya has quit IRC16:11
*** ttsiouts has quit IRC16:12
Nick_Aquota value of -1 = unlimited?16:14
sean-k-mooneyNick_A: yes16:15
Nick_Aty16:15
*** icarusfactor has joined #openstack-nova16:23
*** factor has quit IRC16:23
openstackgerritDustin Cowles proposed openstack/nova-specs master: Spec: Use OpenStack SDK in Nova  https://review.opendev.org/66288116:26
*** dpawlik has joined #openstack-nova16:27
openstackgerritRui Zang proposed openstack/nova-specs master: support virtual persistent memory  https://review.opendev.org/60159616:29
openstackgerritMatt Riedemann proposed openstack/nova master: Add neutron-tempest-iptables_hybrid job to experimental queue  https://review.opendev.org/66715416:29
mriedemsean-k-mooney: ^ you can lay your change on top of that and then we can test it in the nova change itself16:30
*** trident has quit IRC16:30
*** trident has joined #openstack-nova16:32
sean-k-mooneymriedem: yep ill do that. i was in meeting for the last hour and im just getting dinner now. ill  submit a fixed patch later today hopefuly before i log off. if not ill work with artom to fix this tomorow. it should not be that hard to do but i have been tied up with other stuff so far today16:35
mriedemsure, that's fine, and why i thought the fast revert was the way to go16:36
sean-k-mooneyya. if it wasnt for the downstream prod issue this would have been the first thing i worked on today16:37
sean-k-mooneyanyway ill be back in an hour or so16:37
sean-k-mooneytonyb: the cap that was added for sphinx in global-requirements is breaking the requiremetns check job16:39
sean-k-mooneytonyb: https://github.com/openstack/requirements/blob/master/global-requirements.txt#L45916:39
sean-k-mooneytonyb: we could merge https://review.opendev.org/#/c/666387/ however can you comment on why this cap was put in global-requirements and not upper-constraits16:39
sean-k-mooneyby doing it in global-requirements it is breaking os-vif and other repo but upper-constratis would have just worked16:40
sean-k-mooneyhttps://github.com/openstack/requirements/commit/00b2bcf7d664b1526b4eefe157c33113206d625116:40
sean-k-mooneydoes not really explain why this was chosen but it does call out that you expect it might break things16:41
*** igordc has joined #openstack-nova16:42
*** mrch_ has joined #openstack-nova16:43
Nick_Ado network quota defaults still need to be set with neutron quota-update ?16:44
sean-k-mooneyi personally would prefer to remove the cap in global constratig and make the docs jobs use upper-constratits if they dont already16:44
Nick_A# openstack quota set --class default --floating-ips 016:44
Nick_ANetwork quotas are ignored since quota class is not supported16:44
*** whoami-rajat has quit IRC16:44
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Drop source node allocations if finish_resize fails  https://review.opendev.org/66715516:44
Nick_A"neutron CLI is deprecated and will be removed in the future. Use openstack CLI instead.16:45
Nick_A"16:45
mriedemneutron doesn't have quota classes as far as i know,16:45
mriedemonly nova and cinder16:45
mriedemthe osc cli docs are not clear about that either16:45
mriedemi'm not sure what the quota options are with neutron, if it's just config (global) and per-project16:46
mriedemthat's a question for the -neutron channel16:46
Nick_Agotcha16:46
mriedemhttps://developer.openstack.org/api-ref/network/v2/index.html#quotas-extension-quotas16:47
mriedemhttps://docs.openstack.org/neutron/stein/search.html?q=quota isn't helping16:47
mriedemso my uneducated guess is (1) config for global defaults, (2) per-project defaults and (3) project-specific overrides16:48
*** dklyle has joined #openstack-nova16:49
*** mkrai__ has quit IRC16:51
*** gfhellma has joined #openstack-nova16:54
Nick_Awe'll set them globally for now - https://docs.openstack.org/openstack-ansible-os_neutron/latest/ - thank you for looking16:55
stephenfinhttps://docs.openstack.org/neutron/rocky/contributor/internals/quota.html16:56
stephenfinNot sure if that's relevant or not16:56
*** icarusfactor has quit IRC17:00
*** whoami-rajat has joined #openstack-nova17:02
*** udesale has quit IRC17:07
*** psachin has quit IRC17:17
*** panda has quit IRC17:18
openstackgerritDustin Cowles proposed openstack/nova-specs master: Spec: Use OpenStack SDK in Nova  https://review.opendev.org/66288117:19
*** panda has joined #openstack-nova17:20
*** ociuhandu_ has joined #openstack-nova17:21
*** ralonsoh has quit IRC17:23
openstackgerritStephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands  https://review.opendev.org/66716417:25
openstackgerritStephen Finucane proposed openstack/nova master: Rewrite quotas documentation  https://review.opendev.org/66716517:25
*** ociuhandu has quit IRC17:25
openstackgerritStephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation  https://review.opendev.org/66716517:26
*** ociuhandu_ has quit IRC17:27
*** davidsha has quit IRC17:27
openstackgerritTakashi NATSUME proposed openstack/nova master: Add database schema upgrade check  https://review.opendev.org/66704717:36
openstackgerritTakashi NATSUME proposed openstack/nova master: Add database schema upgrade check  https://review.opendev.org/66704717:36
*** eharney_ has joined #openstack-nova17:51
*** eharney has quit IRC17:53
dansmithmriedem: sorry was in a meeting17:53
*** luksky has joined #openstack-nova17:55
*** martinkennelly has quit IRC18:04
*** luksky has quit IRC18:12
*** dpawlik has quit IRC18:39
*** dpawlik has joined #openstack-nova18:40
openstackgerritsean mooney proposed openstack/nova master: Revert resize: wait for events according to hybrid plug  https://review.opendev.org/66717718:42
*** dklyle has quit IRC18:49
*** david-lyle has joined #openstack-nova18:49
*** eharney_ is now known as eharney18:56
*** jangutter has quit IRC18:58
*** luksky has joined #openstack-nova19:04
openstackgerritMerged openstack/nova master: Revert "Revert resize: wait for events according to hybrid plug"  https://review.opendev.org/66703519:14
*** xek has quit IRC19:23
openstackgerritEric Fried proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator)  https://review.opendev.org/65155519:24
openstackgerritEric Fried proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name)  https://review.opendev.org/65210319:24
openstackgerritEric Fried proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence)  https://review.opendev.org/65210419:24
openstackgerritEric Fried proposed openstack/nova master: tests: Use consistent URL regex substitution  https://review.opendev.org/66594919:24
openstackgerritsean mooney proposed openstack/nova master: Revert resize: wait for events according to hybrid plug  https://review.opendev.org/66717719:24
sean-k-mooneyefried: thanks for reviewing the libvirt pqos spec. ill review and responed tomorrow19:26
efriedyahyoubetcha19:26
openstackgerritDustin Cowles proposed openstack/nova-specs master: Spec: Use OpenStack SDK in Nova  https://review.opendev.org/66288119:30
*** whoami-rajat has quit IRC19:34
*** BjoernT_ has quit IRC19:49
*** markmcclain has quit IRC19:49
openstackgerritMatt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method  https://review.opendev.org/61403619:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add Instance.hidden field  https://review.opendev.org/63112319:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add TargetDBSetupTask  https://review.opendev.org/62789219:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask  https://review.opendev.org/63158119:51
openstackgerritMatt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask  https://review.opendev.org/63385319:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method  https://review.opendev.org/63329319:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask  https://review.opendev.org/62789019:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method  https://review.opendev.org/63483219:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image  https://review.opendev.org/63760519:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask  https://review.opendev.org/62789119:51
efriedjohnthetubaguy: Would you please have a (hopefully final) look at https://review.opendev.org/#/c/658716/ and see if it's approvable?19:54
openstackgerritMatt Riedemann proposed openstack/os-traits master: Add COMPUTE_STATUS_DISABLED trait  https://review.opendev.org/66720920:00
*** bnemec has quit IRC20:00
*** david-lyle is now known as dklyle20:06
*** bnemec has joined #openstack-nova20:08
*** spatel has joined #openstack-nova20:12
*** _erlon_ has joined #openstack-nova20:12
mriedemefried: i have one of your favorite all time questions,20:15
efriedairspeed velocity of an unladen European swallow?20:16
mriedemSchedulerReportClient.set_traits_for_provider uses the ProviderTree cache https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L101920:16
mriedembut get_provider_traits does not https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L37320:17
mriedemi'm working on splitting up https://review.opendev.org/#/c/654596/ and the first thing I was going to do was https://review.opendev.org/#/c/654596/2/nova/scheduler/client/report.py as a separate patch which was set_provider_traits w/o the cache,20:17
mriedemso the ComputeVirtAPI/virt driver usage for get/set provider traits would not be tied to a cache20:18
mriedembut now i can't remember why i decided to go the no-cache route,20:18
mriedemsince i could link the compute manager / virt api / driver / RT reportclient together and then they'd all be using the same instance of the ProviderTree cache20:18
mriedemand maybe that's desirable20:18
mriedemso i guess main question is, is there any reason get_provider_traits isn't using the cache?20:19
mriedemmy more nagging question is if i should try to share the reportclient among compute/rt/virtapi and lean on the cache...though i'm not sure i trust the cache (i guess we'd know if the cache was wrong when we try to set traits on the provider using the wrong generation)20:22
efriedmriedem: get_provider_traits is in code paths that have already decided whether the cache is in play or not. It's kind of one of those "low-level" methods that probably - I haven't checked - started off as private and was developed before we had fully developed the caching model.20:22
efriedset_traits_for_provider is currently only being used in the rt resource update loop, which has a retry on generation conflicts, i.e. "using" the cache "safely".20:23
efriedIn principle, up to this point I think we've been avoiding using the cache for any report client *outside* of the compute service.20:24
efriedare you intending to *write* traits from the *scheduler*?20:24
efriedor conductor20:24
efried?20:24
mriedemno20:26
mriedemComputeVirtAPI is part of the ComputeManager/ComputeDriver/RT turducken20:26
efriedIMO for "compute disabled" filter you should not use the cache, so get_provider_traits ought to be good as is.20:27
mriedemthe trait stuff in this case can be managed started from the compute manager (via call from the API), the driver, or the RT - and the former two are using the same VirtAPI instance20:27
*** gfhellma has quit IRC20:27
efriedyou may have to walk me through the flow at a high level here, or I can reread the spec quick...20:28
mriedemok if i'm not using the cache then i do need https://review.opendev.org/#/c/654596/2/nova/scheduler/client/report.py to set w/o the cache as well20:28
sean-k-mooneymriedem: can it be managed from teh compute manager if the host is down20:28
mriedemsean-k-mooney: no20:28
sean-k-mooneythat what i assumed20:28
*** bbowen has quit IRC20:28
sean-k-mooneyso if the host is actully down how would we update the trait20:28
mriedemwe wouldn't20:29
mriedemsee the note here https://specs.openstack.org/openstack/nova-specs/specs/train/approved/pre-filter-disabled-computes.html#scheduler-changes20:29
efriedmriedem: I'm not sure I see the purpose of the split in https://review.opendev.org/#/c/654596/2/nova/scheduler/client/report.py20:29
*** bbowen has joined #openstack-nova20:29
sean-k-mooneyah right20:29
efriedwhere were you getting the generation from?20:29
sean-k-mooneythis is just covering disabled vs enabled not up vs down20:30
efriedif not from the cache?20:30
mriedemefried:20:30
mriedemget_provider_traits20:30
mriedemreturns a named tuple20:30
mriedemwith the traits list and the gen20:30
mriedemi wasn't going to use set_traits_for_provider because if i'm not relying on the cache at all, then i don't want this to f me:20:31
mriedemif not self._provider_tree.have_traits_changed(rp_uuid, traits):20:31
mriedemi'm doing that myself here https://review.opendev.org/#/c/654596/2/nova/compute/manager.py@49420:32
efriedmriedem: compute manager is same process (and using same report client) as RT?20:33
efried(sorry if I'm asking you to repeat yourself)20:34
mriedemyeah20:34
efriedthen the cache is hot20:34
efriedand you don't need to duplicate all that logic.20:34
mriedemhttps://review.opendev.org/#/c/654596/2/nova/compute/manager.py@57320:34
efriedbut you're concerned that the cache could be stale?20:34
*** ociuhandu has joined #openstack-nova20:35
mriedemwell my initial concern was just why get_provider_traits wasn't using the cache if set_traits_for_provider relies on the cache20:35
mriedemwhich if i use the cache, just becomes an optimization20:35
mriedemi.e. later adding a use_cache kwarg to get_provider_traits or whatever20:35
mriedemlooks like only fill_provider_mapping uses get_provider_traits today which was the stuff gibi added and isn't in compute, so i guess that's why it doesn't use the cache20:37
efriedYes, and _refresh_associations, which is the low-level thing that updates the cache, but it refreshes a bunch of other shit you don't need as well.20:37
mriedemthere might have been some other reason i needed to hit placement directly, but it's been too long since i wrote this so i guess i'll just rebase and then try to see if things still work after re-using the same report client in the virtapi20:38
mriedemmight have been when the virt driver calls the virtapi, but the virtapi in the virt driver is the same virtapi that ComputeManager creates and passes a reference of itself20:39
efriedyeah at some point we made sure the report client was a singleton per process20:41
efriedmriedem: I think we want to tweak the report client to make this process more generic & reusable. Stand by.20:43
*** pcaruana has quit IRC20:44
efriedPull this bit of _refresh_associations20:45
efriedhttps://opendev.org/openstack/nova/src/branch/master/nova/scheduler/client/report.py#L794-L80320:45
efriedinto get_provider_traits itself -- iow calling get_provider_traits should also update the cache20:45
efried(...and dedup that part of _refresh_associations)20:46
*** luksky has quit IRC20:46
efriedSo then your thingy, and other thingies that do similar, can20:46
efriedget_provider_traits() to retrieve the trait info you want to muck with20:46
efriedmuck with it20:46
efriedset_traits_for_provider() with the changed trait list20:46
efriedIf we wanted to optimize that, we could add a refresh=$bool kwarg to get_provider_traits so you could optionally have it *just* return whatever's in the cache rather than refetching.20:47
mriedemwe can't have https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/client/report.py#L802 in get_provider_traits for things that aren't using the cache, like gibi's calls from conductor for fill_provider_mapping20:47
mriedemright?20:47
efriedI don't see why not.20:48
efriedWe'd be updating the cache, but not reading from it anywhere.20:48
efriedUpdating the cache is of negligible cost20:48
mriedem"            # NOTE(efried): This will blow up if called for a RP that doesn't             # exist in our _provider_tree. "20:48
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add placement request filter for disabled computes  https://review.opendev.org/65459620:48
*** BjoernT has joined #openstack-nova20:50
efriedmriedem: by that point in _refresh_associations, we're already assured the provider is in our cache.20:50
*** hongbin has joined #openstack-nova20:50
efriedyou're saying if it's called from elsewhere where that's not the case20:50
efriedso yeah, trap and ignore ValueError20:50
efrieddone20:50
openstackgerritMerged openstack/python-novaclient master: Revert "Add irrelevant files in dsvm job"  https://review.opendev.org/66715120:50
mriedemblech20:51
efriedyou could do that from within the new-and-improved get_provider_traits20:51
mriedembut yeah that's what i meant - called from conductor where the rp isn't in the cache20:51
efriedor check the cache first.20:51
mriedemi'm going to avoid all of that for now because then you could have questions like, "should the caller say if they want the cache and should fail if the rp isn't in the cache?"20:52
efriedif self._provider_tree.exists(rp_uuid):20:52
efried"avoid all of that for now" is going to be harder and introduce more technical debt.20:52
mriedemsure - but if i'm compute and expect it in the cache and it's not, we'd want that to fail, not be swallowed20:52
mriedemthat's why i said a use_cache kwarg on get_provider_traits seems easier20:53
mriedemthe caller says what it wants20:53
efriedbut you need two knobs20:53
mriedemthe very first thing i want to do is just split this large-ish change up into several pieces so i can test in isolation and reason about it20:53
efried1) retrieve from the cache20:53
efried2) update the cache20:53
efriedone does not imply the other20:54
mriedem...20:54
mriedemmeaning refresh if it's not in the cache and return the cached results,20:54
mriedemor don't get from the cache, get from the API, but update the cache...20:54
mriedem?20:54
mriedemi'm just going to work on splitting this all up and put a TODO in my code that uses get_provider_traits to somehow leverage the cache - it can be debated in review at that point i think when i actually have something working end to end (which the change is now - the func test shows that, but i'm going to be splitting up and possibly breaking things)20:55
efriedokay20:56
spatelsean-k-mooney: hey20:57
efriednts: http://specs.openstack.org/openstack/nova-specs/specs/train/approved/pre-filter-disabled-computes.html20:58
*** BjoernT has quit IRC20:59
mriedemheh well i've got a chicken-and-egg so i likely can't use the cache anyway21:08
mriedemrt init needs the driver https://github.com/openstack/nova/blob/914ee91a5caedcaba64472762c9f08d7bb644d11/nova/compute/manager.py#L53821:08
mriedemand the driver init needs the virtapi https://github.com/openstack/nova/blob/914ee91a5caedcaba64472762c9f08d7bb644d11/nova/compute/manager.py#L53521:08
mriedemunless i do something hacky like self.virtapi.reportclient = self.reportclient....21:09
*** Sundar has joined #openstack-nova21:14
efriedthat's what we've done all over the place, innit?21:14
efriedI guess mostly the other way around, self.reportclient = self.otherthingy.reportclient21:14
efriedyou could pass the reportclient into the virtapi constructor21:15
mriedemyeah i'm constructing the singleton reportclient in ComputeManager and passing that to RT and ComputeVirtAPI21:16
efried++21:16
*** gouthamr_ is now known as gouthamr21:16
*** markmcclain has joined #openstack-nova21:17
*** eharney has quit IRC21:20
*** ivve has quit IRC21:20
*** factor has joined #openstack-nova21:37
*** rajinir has quit IRC21:38
tonybsean-k-mooney: We needed to do it in requirements in order to *generate* constraints21:42
*** spatel has quit IRC21:44
*** dpawlik has quit IRC21:44
tonybsean-k-mooney: You say it's breaking the requirements-check job but I don't see that21:45
tonybsean-k-mooney: Given our, lack, of TZ overlap might be best to do this via email?21:45
sean-k-mooneyim here21:45
sean-k-mooneywe do not generate constratis to project anymore21:46
sean-k-mooneyat least the lower constratits21:46
sean-k-mooneythe reason i say i breaks the requirement check is https://review.opendev.org/#/c/666651/2/doc/requirements.txt21:47
sean-k-mooneysimply addint a comment or otherwise modifying the requiremetns file cause the requirements-check job to fail21:47
sean-k-mooneywe can see the error here21:48
sean-k-mooneyhttp://logs.openstack.org/51/666651/2/check/requirements-check/c8c82c5/job-output.txt.gz#_2019-06-20_17_39_08_90135021:48
sean-k-mooneytonyb: ^21:48
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add placement request filter for disabled computes  https://review.opendev.org/65459621:48
tonybsean-k-mooney: okay so there are a couple of things21:49
tonybsean-k-mooney: the requirements team needs to generate constraints (upper) daily and without capping sphinx (and others) in g-r we can't do that21:49
*** sapd1_x has joined #openstack-nova21:49
sean-k-mooneyah so when you said generate you ment upper-constraitns not requirement files for projects21:50
tonybsean-k-mooney: and also the 'fix' to that error is to just merge the chnage that caps sphinx, which is the expected process albeit a little ugly now that we don't auto-sync21:50
tonybsean-k-mooney: correct21:51
sean-k-mooneyyes we have a patch for that but my understdaint is project are not ment to cap any package in ther own reqiuremets file21:51
sean-k-mooneythe can balcklis tthing the know do not work but if cap we can break compatiobliy for the intergrated services21:51
tonybsean-k-mooney: In general we try very hard not to cap in g-r or per project but it isn't "forbidden"21:52
tonybsean-k-mooney: and with this whole no more py2 support thing we don't have a choice21:52
sean-k-mooneywell that is due to useing gloabl-requiremtns for two thing21:52
sean-k-mooneygeneratihing upper-constratints and capping  python2 things21:53
tonybsean-k-mooney: and listing "approved libraries" so that's 3 things21:53
sean-k-mooneywell no it because we use it for generating uppercontratitgs21:53
sean-k-mooneyya21:53
sean-k-mooneyso the last point is what i thought its priamary pourpous was21:54
sean-k-mooneylisting the appoved libs that wee know are compatiable and are manged by the requiremetns project21:54
tonybsean-k-mooney: I'm interested in your statement "if cap we can break compatiobliy for the intergrated services" can you elaborate?21:54
*** mriedem has quit IRC21:55
sean-k-mooneyos-vif say mock < X some other poject requires mock > x21:55
sean-k-mooneyos-vif and that service can nolonger be installed together21:55
tonybsean-k-mooney: ahhh okay .... that's handled in the generate-constraints job so it *shouldn't* be possible21:56
*** Sundar has quit IRC21:56
tonybsean-k-mooney: for *upper* constraints for lower all bets are off21:56
sean-k-mooneycan you explain breifly how upper-constratis is generated21:56
sean-k-mooneyi.e. how is gr used for uc21:56
tonybsean-k-mooney: basically we pip install -r global-requirements.txt and "freeze" the output21:57
sean-k-mooneyi was not aware uc was generated for gr21:57
*** rdopiera has quit IRC21:57
sean-k-mooneyi though uc was manually updated as needed21:57
sean-k-mooneyrathar then auto updating as upstream releases?21:57
sean-k-mooneyi guess that is not the case?21:58
tonybfor master it's a daily update and then "fixed" if needed, for stable it's all manual21:58
*** panda has quit IRC21:58
sean-k-mooneyah ok so master allows latest unless we know somthing is broken21:58
sean-k-mooneyis gr used to pin things that are broken in that case ?21:58
tonybhttps://review.opendev.org/#/c/666981/ was last night's auto generate21:58
tonybsean-k-mooney: Yes, if lib $foo has a broken version we add a != in g-r to avoid it21:59
openstackgerritEric Fried proposed openstack/nova-specs master: Libvirt: add vPMU spec for train  https://review.opendev.org/65126921:59
sean-k-mooneyand we are now using sphinx < 2.0 as a shorthad to cover all the non py27 versions22:00
*** icarusfactor has joined #openstack-nova22:01
sean-k-mooneyok i can approve https://review.opendev.org/#/c/666387/ but its kind of regretable that we will have to modify requirement every time gr is modifed to reflect a new cap.22:01
*** factor has quit IRC22:02
sean-k-mooneyif the cap was only done via upper-constratits then it would just automaticlly work22:02
tonybsean-k-mooney: Yes, we've always needed to do that but it's just more obvious now22:02
tonybsean-k-mooney: I agre it's ugly but we can't think of a better way with the tools we have22:02
sean-k-mooneynova os-vif and other project that generate docs form code need to use uc to pin to compatible verions anyway otherwise they can fail22:02
tonybsean-k-mooney: correct22:03
*** panda has joined #openstack-nova22:03
tonybsean-k-mooney: gotta disappear I'll be back in a bit22:03
sean-k-mooneyhehe im going to drop too. i was playing games on my desktop but its late enough now that i should praobbly call it a day o/22:04
sean-k-mooneytonyb: thanks for explainin22:04
sean-k-mooneyi had taken the view that capping in requiremetn in repo was nolonger allowed but ill adjust to allowing it if it is capped that way in gr going forward22:05
*** Sundar has joined #openstack-nova22:08
*** bbowen has quit IRC22:10
*** mlavalle has quit IRC22:14
tonybsean-k-mooney: we (the requirements team) clearly need better reference docs or a FAQ or something22:27
*** ociuhandu has quit IRC22:30
*** ociuhandu_ has joined #openstack-nova22:30
*** ociuhandu_ has quit IRC22:31
*** lbragstad has quit IRC22:41
openstackgerritMerged openstack/nova master: bdm: store empty object as connection_info by default  https://review.opendev.org/64535222:47
*** rcernin has joined #openstack-nova22:51
*** BjoernT has joined #openstack-nova22:54
*** tkajinam has joined #openstack-nova22:55
*** ianw_pto is now known as ianw23:08
*** jaypipes_ has quit IRC23:18
*** _erlon_ has quit IRC23:22
*** slaweq has quit IRC23:24
*** takashin has joined #openstack-nova23:33
*** sapd1_x has quit IRC23:52
*** rcernin has quit IRC23:59
*** rcernin has joined #openstack-nova23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!