| *** markvoelker has joined #openstack-nova | 00:16 | |
| *** nicolasbock has quit IRC | 00:16 | |
| Nick_A | Is there a way to take online snapshots of LXC instances? | 00:22 |
|---|---|---|
| *** brinzhang has joined #openstack-nova | 00:27 | |
| *** brinzh has joined #openstack-nova | 00:37 | |
| *** tbachman has quit IRC | 00:40 | |
| *** rcernin_ has quit IRC | 00:41 | |
| *** rcernin has joined #openstack-nova | 00:41 | |
| *** tbachman has joined #openstack-nova | 00:41 | |
| openstackgerrit | Merged openstack/nova master: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/663607 | 00:42 |
| *** lbragstad has quit IRC | 00:48 | |
| *** markvoelker has quit IRC | 00:49 | |
| *** igordc has quit IRC | 00:56 | |
| *** icarusfactor has joined #openstack-nova | 01:00 | |
| *** tbachman_ has joined #openstack-nova | 01:00 | |
| openstackgerrit | Merged openstack/nova-specs master: Clarify the error response in proposed change https://review.opendev.org/664198 | 01:01 |
| *** factor has quit IRC | 01:02 | |
| *** tbachman has quit IRC | 01:02 | |
| *** tbachman_ is now known as tbachman | 01:02 | |
| *** ricolin has joined #openstack-nova | 01:10 | |
| *** threestrands_ has joined #openstack-nova | 01:11 | |
| *** threestrands has quit IRC | 01:14 | |
| *** icarusfactor has quit IRC | 01:19 | |
| *** factor__ has joined #openstack-nova | 01:19 | |
| *** threestrands_ has quit IRC | 01:21 | |
| *** factor__ has quit IRC | 01:24 | |
| *** factor__ has joined #openstack-nova | 01:25 | |
| *** bhagyashris has joined #openstack-nova | 01:33 | |
| *** gyee has quit IRC | 01:34 | |
| *** markvoelker has joined #openstack-nova | 01:46 | |
| *** factor__ has quit IRC | 01:49 | |
| *** factor__ has joined #openstack-nova | 01:50 | |
| *** guozijn has joined #openstack-nova | 01:54 | |
| *** whoami-rajat has joined #openstack-nova | 02:09 | |
| openstackgerrit | Keerthi Reddy proposed openstack/nova master: [do not review] [Learning] Add a new link https://review.opendev.org/664483 | 02:09 |
| *** sapd1_x has joined #openstack-nova | 02:14 | |
| *** factor__ has quit IRC | 02:17 | |
| *** itlinux has joined #openstack-nova | 02:17 | |
| *** factor__ has joined #openstack-nova | 02:18 | |
| *** factor__ has quit IRC | 02:18 | |
| *** markvoelker has quit IRC | 02:20 | |
| *** hongbin has joined #openstack-nova | 02:25 | |
| *** guozijn has quit IRC | 02:30 | |
| *** cfriesen has quit IRC | 02:54 | |
| *** cfriesen has joined #openstack-nova | 03:02 | |
| *** bhagyashris has quit IRC | 03:03 | |
| *** bnemec has quit IRC | 03:07 | |
| *** bnemec has joined #openstack-nova | 03:08 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | 03:14 |
| *** markvoelker has joined #openstack-nova | 03:17 | |
| *** psachin has joined #openstack-nova | 03:39 | |
| *** markvoelker has quit IRC | 03:50 | |
| *** brinzhang has quit IRC | 03:53 | |
| *** brinzhang has joined #openstack-nova | 03:54 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix default values in update_cell command https://review.opendev.org/662383 | 03:55 |
| *** hongbin has quit IRC | 04:01 | |
| *** udesale has joined #openstack-nova | 04:05 | |
| *** janki has joined #openstack-nova | 04:10 | |
| *** dave-mccowan has quit IRC | 04:23 | |
| *** shilpasd has joined #openstack-nova | 04:38 | |
| *** sorrison has joined #openstack-nova | 04:46 | |
| *** markvoelker has joined #openstack-nova | 04:47 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix default values in update_cell command https://review.opendev.org/662383 | 05:04 |
| *** luksky has joined #openstack-nova | 05:09 | |
| *** markvoelker has quit IRC | 05:21 | |
| *** luksky has quit IRC | 05:25 | |
| *** lpetrut has joined #openstack-nova | 05:28 | |
| *** udesale has quit IRC | 05:35 | |
| *** udesale has joined #openstack-nova | 05:36 | |
| *** brinzh has quit IRC | 05:42 | |
| *** brinzh has joined #openstack-nova | 05:42 | |
| *** lpetrut has quit IRC | 05:43 | |
| *** threestrands has joined #openstack-nova | 05:52 | |
| *** Luzi has joined #openstack-nova | 05:53 | |
| *** threestrands has quit IRC | 05:53 | |
| *** ratailor has joined #openstack-nova | 06:04 | |
| *** hamdyk has joined #openstack-nova | 06:15 | |
| *** markvoelker has joined #openstack-nova | 06:18 | |
| *** cfriesen has quit IRC | 06:23 | |
| *** udesale has quit IRC | 06:32 | |
| *** udesale has joined #openstack-nova | 06:32 | |
| *** ccamacho has joined #openstack-nova | 06:36 | |
| *** lpetrut has joined #openstack-nova | 06:46 | |
| *** markvoelker has quit IRC | 06:51 | |
| *** pcaruana has joined #openstack-nova | 06:55 | |
| *** damien_r has joined #openstack-nova | 06:55 | |
| *** slaweq has joined #openstack-nova | 06:56 | |
| *** nicolasbock has joined #openstack-nova | 06:57 | |
| *** rpittau|afk is now known as rpittau | 07:08 | |
| *** rcernin has quit IRC | 07:08 | |
| *** tesseract has joined #openstack-nova | 07:08 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:14 | |
| *** slaweq has quit IRC | 07:20 | |
| *** tssurya has joined #openstack-nova | 07:29 | |
| *** maciejjozefczyk has quit IRC | 07:30 | |
| openstackgerrit | Edward Hope-Morley proposed openstack/nova stable/stein: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/664512 | 07:39 |
| openstackgerrit | Edward Hope-Morley proposed openstack/nova stable/rocky: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/664513 | 07:40 |
| *** markvoelker has joined #openstack-nova | 07:48 | |
| *** helenafm has joined #openstack-nova | 07:53 | |
| *** udesale has quit IRC | 07:53 | |
| *** udesale has joined #openstack-nova | 07:53 | |
| *** takashin has left #openstack-nova | 08:00 | |
| *** ttsiouts has joined #openstack-nova | 08:01 | |
| *** dtantsur|afk is now known as dtantsur | 08:02 | |
| *** nicolasbock has quit IRC | 08:04 | |
| *** tkajinam has quit IRC | 08:05 | |
| *** ociuhandu has joined #openstack-nova | 08:07 | |
| *** ralonsoh has joined #openstack-nova | 08:09 | |
| *** liuyulong has joined #openstack-nova | 08:16 | |
| *** ttsiouts has quit IRC | 08:19 | |
| *** ttsiouts has joined #openstack-nova | 08:20 | |
| *** mdbooth has quit IRC | 08:21 | |
| *** markvoelker has quit IRC | 08:22 | |
| *** mdbooth has joined #openstack-nova | 08:24 | |
| *** ttsiouts has quit IRC | 08:24 | |
| *** bhagyashris has joined #openstack-nova | 08:27 | |
| *** davidsha has joined #openstack-nova | 08:29 | |
| lyarwood | stephenfin / bauzas ; would you mind taking a look at https://review.opendev.org/#/c/663011/ & https://review.opendev.org/#/c/664036/ this morning please? | 08:31 |
| stephenfin | sure | 08:32 |
| *** ttsiouts has joined #openstack-nova | 08:33 | |
| *** imacdonn has quit IRC | 08:38 | |
| *** imacdonn has joined #openstack-nova | 08:38 | |
| *** derekh has joined #openstack-nova | 08:40 | |
| *** cdent has joined #openstack-nova | 08:42 | |
| kashyap | Nit-pick: please don't use "fup" as a summary, it's this IRC channel specifc lingo, and most people might not be aware of it. | 08:43 |
| kashyap | s/"as a summary"/"in the summary of Git commits"/ | 08:44 |
| aspiers | kashyap: it could also be misinterpreted as "f*** up" ;-) | 08:44 |
| lyarwood | sigh | 08:44 |
| kashyap | aspiers: That too. :D | 08:44 |
| aspiers | my brain still does that every time I see it | 08:45 |
| kashyap | aspiers: Really, I was confused when I heard it first time here. | 08:45 |
| kashyap | I don't like it it at all. | 08:45 |
| kashyap | s/it it/it/ | 08:45 |
| lyarwood | fup is a prefectly useful summary tag for a commit IMHO | 08:45 |
| kashyap | lyarwood: Really, who knows it? | 08:45 |
| aspiers | lyarwood: fixup is only 2 bytes more, and far clearer | 08:45 |
| stephenfin | Have to agree here | 08:46 |
| lyarwood | meh | 08:46 |
| kashyap | I bet if you ask any non-native speaker to guess that is, 10/10 won't be able to guess it. | 08:46 |
| * stephenfin ducks back out | 08:46 | |
| kashyap | Clarity is power. | 08:46 |
| lyarwood | bike sheds need painting | 08:46 |
| aspiers | it needs painting RED | 08:46 |
| lyarwood | I'll continue to use it | 08:46 |
| stephenfin | lyarwood: Question on https://review.opendev.org/#/c/664036/ | 08:46 |
| kashyap | Not really; it's a death by thousand cuts | 08:46 |
| lyarwood | ack looking | 08:46 |
| stephenfin | other one is +W | 08:46 |
| lyarwood | stephenfin: gah, why is it always so obvious when someone comments on my change | 08:48 |
| lyarwood | stephenfin: I'll respin for the elif now | 08:48 |
| stephenfin | It's the same for everyone else, I assure you :) | 08:48 |
| stephenfin | Thoughts on the logging? Do we want to do a full run through first to catch potential issues, or just highlight them as we encounter them? | 08:49 |
| lyarwood | stephenfin: just left a note, I don't think we care enough to loop through everything everytime to find invalid values. | 08:51 |
| stephenfin | Cool | 08:51 |
| lyarwood | stephenfin: worst case is that we can't find a mapping for our arch and find the invalid mappings that way | 08:51 |
| aspiers | stephenfin: sorry, just remembered you asked me to look at a potential bug I might have caused with the machtype mapping stuff | 08:53 |
| stephenfin | aspiers: I think lyarwood's patch has fixed it so we should be good | 08:53 |
| aspiers | stephenfin: ah cool | 08:53 |
| aspiers | stephenfin: feel free to add me to review | 08:54 |
| stephenfin | aspiers: It was this comment https://review.opendev.org/#/c/663011/9/nova/virt/libvirt/utils.py@563 | 08:54 |
| stephenfin | lyarwood has moved it to 'get_default_machine_type' so the potential mixup should be resolved | 08:55 |
| lyarwood | on stephenfin's suggestion FWIW, thanks for that. | 08:56 |
| *** priteau has joined #openstack-nova | 08:57 | |
| *** udesale has quit IRC | 08:59 | |
| kashyap | lyarwood: When we can't find a valid mapping, _do_ we print everything out? | 08:59 |
| * kashyap goes to read the code | 08:59 | |
| aspiers | lyarwood: there's still the {} default mapping bug stephenfin pointed out in https://review.opendev.org/#/c/663011/9/nova/virt/libvirt/utils.py@571 | 08:59 |
| *** cdent has quit IRC | 09:00 | |
| lyarwood | kashyap: no, just the invalid mappings | 09:01 |
| kashyap | (Nod) | 09:02 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Merge machine_type_mappings into get_default_machine_type https://review.opendev.org/664036 | 09:02 |
| *** rcernin has joined #openstack-nova | 09:03 | |
| kashyap | Sigh; the crappy "fup" again | 09:04 |
| lyarwood | As I said above, I'm going to continue using it. | 09:05 |
| *** ttsiouts has quit IRC | 09:06 | |
| kashyap | Sure, at the cost of the death by shitty commit messages | 09:06 |
| *** ttsiouts has joined #openstack-nova | 09:06 | |
| *** udesale has joined #openstack-nova | 09:07 | |
| *** ttsiouts has quit IRC | 09:11 | |
| *** liuyulong has quit IRC | 09:11 | |
| *** ratailor_ has joined #openstack-nova | 09:16 | |
| *** ttsiouts has joined #openstack-nova | 09:18 | |
| *** ratailor has quit IRC | 09:19 | |
| *** markvoelker has joined #openstack-nova | 09:19 | |
| *** tobberydberg has quit IRC | 09:22 | |
| *** kaliya has joined #openstack-nova | 09:23 | |
| *** nicolasbock has joined #openstack-nova | 09:26 | |
| *** ratailor__ has joined #openstack-nova | 09:29 | |
| *** tobberydberg has joined #openstack-nova | 09:31 | |
| *** bhagyashris has quit IRC | 09:32 | |
| *** ratailor_ has quit IRC | 09:32 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | 09:33 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245 | 09:33 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102 | 09:33 |
| *** cdent has joined #openstack-nova | 09:36 | |
| stephenfin | lyarwood: Can you put this through? https://review.opendev.org/#/c/657844/ | 09:41 |
| stephenfin | (as a stable patch) | 09:41 |
| *** maciejjozefczyk has joined #openstack-nova | 09:47 | |
| *** panda has quit IRC | 09:47 | |
| *** slaweq has joined #openstack-nova | 09:47 | |
| lyarwood | stephenfin: ack, I'll look now | 09:48 |
| lyarwood | stephenfin: ah no sorry, I'm not actually stable-maint | 09:48 |
| lyarwood | stephenfin: only nova-stable-core | 09:49 |
| stephenfin | Ah, I thought you were. Np | 09:49 |
| *** panda has joined #openstack-nova | 09:49 | |
| *** markvoelker has quit IRC | 09:52 | |
| *** hamdykhader has joined #openstack-nova | 10:05 | |
| *** hamdyk has quit IRC | 10:06 | |
| *** hamdyk has joined #openstack-nova | 10:16 | |
| *** hamdykhader has quit IRC | 10:17 | |
| *** pcaruana has quit IRC | 10:19 | |
| *** brinzhang has quit IRC | 10:22 | |
| *** brinzhang has joined #openstack-nova | 10:23 | |
| *** ttsiouts has quit IRC | 10:28 | |
| *** ttsiouts has joined #openstack-nova | 10:29 | |
| *** slaweq has quit IRC | 10:31 | |
| *** maciejjozefczyk has quit IRC | 10:32 | |
| *** ttsiouts has quit IRC | 10:33 | |
| *** bbowen has quit IRC | 10:38 | |
| *** slaweq has joined #openstack-nova | 10:40 | |
| *** markvoelker has joined #openstack-nova | 10:49 | |
| *** jchhatbar has joined #openstack-nova | 10:55 | |
| *** janki has quit IRC | 10:56 | |
| *** slaweq has quit IRC | 10:59 | |
| *** jchhatbar has quit IRC | 10:59 | |
| *** janki has joined #openstack-nova | 10:59 | |
| *** janki has quit IRC | 11:00 | |
| *** janki has joined #openstack-nova | 11:01 | |
| *** pcaruana has joined #openstack-nova | 11:09 | |
| *** udesale has quit IRC | 11:20 | |
| *** markvoelker has quit IRC | 11:21 | |
| *** dave-mccowan has joined #openstack-nova | 11:23 | |
| *** ttsiouts has joined #openstack-nova | 11:40 | |
| *** rcernin has quit IRC | 11:43 | |
| openstackgerrit | Harald Jensås proposed openstack/nova master: cell_mapping - wrap IPv6 address in format_url https://review.opendev.org/664559 | 11:46 |
| *** hjensas has joined #openstack-nova | 11:46 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | 11:46 |
| *** bbowen has joined #openstack-nova | 11:50 | |
| *** janki has quit IRC | 11:51 | |
| *** janki has joined #openstack-nova | 11:51 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011 | 11:55 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Merge machine_type_mappings into get_default_machine_type https://review.opendev.org/664036 | 11:55 |
| lyarwood | ^ I've rebased these as both keep failing on nova.tests.unit.test_hacking.HackingTestCase.test_check_doubled_words in check queue and gate but are passing locally. stephenfin ^ any ideas? | 11:55 |
| *** dave-mccowan has quit IRC | 12:05 | |
| *** brinzhang has quit IRC | 12:10 | |
| *** brinzh has quit IRC | 12:10 | |
| artom | lyarwood, you've seen https://bugs.launchpad.net/nova/+bug/1804062 I assume? | 12:12 |
| openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | 12:12 |
| artom | (It's in the comment immediately above your failing test) | 12:12 |
| aspiers | am I right in thinking use of _LE() etc. is deprecated since Pike? as per https://docs.openstack.org/oslo.i18n/latest/user/usage.html | 12:15 |
| artom | aspiers, think so, yeah | 12:21 |
| *** maciejjozefczyk has joined #openstack-nova | 12:21 | |
| *** jchhatbar has joined #openstack-nova | 12:21 | |
| lyarwood | artom: no missed that thanks, however this is on 2.7 oddly enough. | 12:22 |
| lyarwood | ah https://bugs.launchpad.net/nova/+bug/1804062/comments/4 | 12:23 |
| openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | 12:23 |
| artom | lyarwood, I didn't really read it TBH, just kinda left it for you, like a cat leaving a mouse corpse | 12:24 |
| sean-k-mooney | aspiers: we nolonger translate exception or logs | 12:24 |
| sean-k-mooney | aspiers: only end user facing content | 12:24 |
| *** janki has quit IRC | 12:24 | |
| *** ricolin_ has joined #openstack-nova | 12:27 | |
| stephenfin | sean-k-mooney: I thought we still translated exceptions but not logs? | 12:27 |
| *** jchhatbar has quit IRC | 12:27 | |
| sean-k-mooney | stephenfin: not since pike as far as i am aware | 12:27 |
| *** jchhatbar has joined #openstack-nova | 12:27 | |
| aspiers | AFAICS exceptions are translated according to https://docs.openstack.org/oslo.i18n/latest/user/usage.html | 12:28 |
| sean-k-mooney | https://docs.openstack.org/oslo.i18n/latest/user/guidelines.html#log-translation | 12:28 |
| sean-k-mooney | aspiers: excetions retruned from the api might be | 12:28 |
| aspiers | right, logs != exceptions | 12:28 |
| sean-k-mooney | excptions that are logged are not | 12:28 |
| aspiers | obviously :) I mean exceptions which are raised | 12:29 |
| * aspiers reads some more | 12:29 | |
| sean-k-mooney | no what i mean is if you raise an excetip and also log it then the logged version is not translated | 12:29 |
| *** ricolin has quit IRC | 12:29 | |
| *** slaweq has joined #openstack-nova | 12:30 | |
| aspiers | right | 12:30 |
| aspiers | anyway the page you linked answers my questions so thanks for that | 12:30 |
| *** READ10 has joined #openstack-nova | 12:32 | |
| *** eharney has quit IRC | 12:39 | |
| *** zbr|ruck is now known as zbr|rover | 12:44 | |
| *** maciejjozefczyk has quit IRC | 12:44 | |
| *** slaweq has quit IRC | 12:46 | |
| yaawang | johnthetubaguy: Hi, are you good with the spec after updates? https://review.opendev.org/#/c/651681/ | 12:49 |
| *** ttsiouts has quit IRC | 12:49 | |
| *** ttsiouts has joined #openstack-nova | 12:50 | |
| *** pchavva has joined #openstack-nova | 12:53 | |
| *** pchavva has left #openstack-nova | 12:54 | |
| *** ttsiouts has quit IRC | 12:54 | |
| *** udesale has joined #openstack-nova | 12:55 | |
| *** ratailor__ has quit IRC | 13:01 | |
| *** lbragstad has joined #openstack-nova | 13:03 | |
| *** nicolasbock has quit IRC | 13:07 | |
| *** nicolasbock has joined #openstack-nova | 13:08 | |
| *** mriedem has joined #openstack-nova | 13:16 | |
| openstackgerrit | Hamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786 | 13:17 |
| openstackgerrit | Hamdy Khader proposed openstack/os-vif master: Fix mock of built in "open" function in unit tests https://review.opendev.org/664583 | 13:17 |
| *** READ10 has quit IRC | 13:17 | |
| *** markvoelker has joined #openstack-nova | 13:18 | |
| *** ttsiouts has joined #openstack-nova | 13:22 | |
| *** markvoelker has quit IRC | 13:23 | |
| sean-k-mooney | mriedem: when you have a sec i need your advice on how we should be mocking "open" in os-vif if you can comment on https://review.opendev.org/#/c/664583/1/vif_plug_ovs/tests/unit/test_linux_net.py | 13:23 |
| sean-k-mooney | that would be awsome | 13:23 |
| *** eharney has joined #openstack-nova | 13:26 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add functional test for bug 1550919 https://review.opendev.org/631294 | 13:28 |
| openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | 13:28 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846 | 13:28 |
| mriedem | sean-k-mooney: i just said should probably be using the mock_open stuff that's part of mock rather than directly mocking the builtin | 13:28 |
| mriedem | since i think that's what you're supposed to do | 13:29 |
| sean-k-mooney | mriedem: ah ok i was not sure if there was more or not | 13:29 |
| aspiers | mriedem: he is using mock_open() | 13:29 |
| aspiers | oh ok sorry, not in test__disable_ipv6() | 13:30 |
| yonglihe | spec "show-server-numa-topology" need core reviewer, alex_xu, mriedem , hope you have time , thanks. https://review.opendev.org/#/c/658716/ | 13:30 |
| yonglihe | sean-k-mooney, hi, have a good day. | 13:30 |
| sean-k-mooney | i got confused by the other stuff that aspiers is andding in nova for conditional mocking which we dont need | 13:30 |
| aspiers | sean-k-mooney: right, the conditional stuff isn't usually needed for unit tests, just for functional | 13:31 |
| aspiers | the docstring I added for patch_open covers that in detail | 13:31 |
| sean-k-mooney | yonglihe: o/ | 13:31 |
| sean-k-mooney | aspiers: right but i dont want to prot that to os-vif unless we really need it for something | 13:31 |
| sean-k-mooney | in the unit test we have we dont really need it | 13:32 |
| sean-k-mooney | and our functional test are intended to actully create bridges and ports | 13:32 |
| aspiers | sean-k-mooney: sure, I think I just said that :) | 13:32 |
| aspiers | you don't need it in this case | 13:32 |
| sean-k-mooney | yep | 13:32 |
| *** BjoernT has joined #openstack-nova | 13:34 | |
| yonglihe | sean-k-mooney, we kind of address the NUMA stuff concern, i hope this spec cloud get approved. wish me lucky. | 13:36 |
| sean-k-mooney | yonglihe: yes i reviewd the latest version and it looked fine to me https://review.opendev.org/#/c/658716/ | 13:37 |
| sean-k-mooney | yonglihe: johnthetubaguy and alex_xu are p[roably the people you need to convicne now | 13:38 |
| yonglihe | sean-k-mooney, sure, only if they got spare time. | 13:40 |
| *** boxiang has joined #openstack-nova | 13:40 | |
| *** boxiang has quit IRC | 13:42 | |
| yonglihe | sean-k-mooney, and i'm working on to checking the vm's signature to make sure we delete only the VM OS created. That cleanup orphan suff. | 13:42 |
| stephenfin | lyarwood, artom: Do I need to rebase the whole series for this so? http://logs.openstack.org/11/651311/11/check/openstack-tox-py27/5910a90/testr_results.html.gz | 13:43 |
| stephenfin | Not sure if it's even fixed yet | 13:43 |
| stephenfin | Or do we need a fix? | 13:44 |
| openstackgerrit | Eric Fried proposed openstack/nova master: fup: Remove unused mock in libvirt functional base https://review.opendev.org/664449 | 13:44 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove unused mock in libvirt functional base https://review.opendev.org/664449 | 13:45 |
| *** mchlumsky has joined #openstack-nova | 13:46 | |
| *** BjoernT_ has joined #openstack-nova | 13:48 | |
| *** BjoernT has quit IRC | 13:48 | |
| sean-k-mooney | yonglihe: ah ok cool yes that would be a nice saftey feature to add for the libvirt driver so im glad to hear your looking into it | 13:49 |
| yonglihe | There may have some gap, if that VM no db recording and we want get the whole xml parsed i guess. | 13:50 |
| *** mlavalle has joined #openstack-nova | 13:52 | |
| *** jchhatbar has quit IRC | 13:52 | |
| *** hongbin has joined #openstack-nova | 13:55 | |
| *** slaweq has joined #openstack-nova | 13:56 | |
| artom | stephenfin, not sure what to tell you, lyarwood has more context I believe | 13:56 |
| *** mchlumsky has quit IRC | 13:59 | |
| *** pcaruana has quit IRC | 14:04 | |
| lyarwood | stephenfin / artom ; no you don't need to rebase, I just did it blind before artom pointed out it was a known unresolved issue | 14:04 |
| stephenfin | ah, it's still unresolved | 14:04 |
| *** liuyulong has joined #openstack-nova | 14:04 | |
| * stephenfin dives down that rabbit hole | 14:04 | |
| yaawang | sean-k-mooney: Hi, I've replied your comment on gerrit, please take a look if you have time. https://review.opendev.org/#/c/651681 | 14:08 |
| *** maciejjozefczyk has joined #openstack-nova | 14:09 | |
| artom | dannins, thanks for the review :) I'm not married to the naming, obviously, so I'll try to come up with something better | 14:09 |
| artom | Err, dansmith ^^ | 14:09 |
| dansmith | artom: ack, I feel like an ass complaining about the hardest problem in computer science, but.. | 14:10 |
| dansmith | might be that I'm just feeling my base state | 14:10 |
| artom | dansmith, in terms of where to put them... get_virt_ in to libvirt/driver.py and get_manager_ in the compute manager? They're 2 sides of the same logic, so I kinda think they should go in the same place, one that's callable by both libvirt and the compute manager, so...? | 14:11 |
| artom | dansmith, no, naming is important, it's fine :) | 14:11 |
| dansmith | artom: virtapi is the wrong place for that, IMHO. I'm not opposed to them being adjacent | 14:12 |
| kashyap | efried: Thanks for not minding my nit-pick! New PS looks good to me | 14:12 |
| kashyap | [With the test failures fixed.] | 14:12 |
| efried | thanks. Any idea wtf is up with the doubled words hacking test?? | 14:13 |
| artom | dansmith, fair enough about virtapi being wrong, but... what else do we have? We talked about putting them in utils somewhere | 14:13 |
| kashyap | efried: Which are those? | 14:13 |
| efried | kashyap: This morning I saw py27 failing on several totally unrelated patches on hacking test_check_doubled_words | 14:14 |
| efried | e.g. http://logs.openstack.org/49/664449/1/check/openstack-tox-py27/4ad64aa/testr_results.html.gz | 14:14 |
| dansmith | artom: yeah, I dunno. utils feels a little generic.. what about in neutronapi or thereabouts? | 14:16 |
| efried | nothing about that test has changed. No new hacking rules have been added recently (months). The only thing around hacking that's changed is when stephenfin updated hacking reqs, but that was like 6 weeks ago. | 14:16 |
| stephenfin | efried: Scroll up | 14:16 |
| artom | efried, https://bugs.launchpad.net/nova/+bug/1804062 I think | 14:16 |
| openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | 14:16 |
| kashyap | efried: No idea about that one, afraid. | 14:16 |
| stephenfin | <artom> lyarwood, you've seen https://bugs.launchpad.net/nova/+bug/1804062 I assume? | 14:16 |
| stephenfin | efried: ^ | 14:17 |
| stephenfin | (or down) | 14:17 |
| stephenfin | I'm looking at it | 14:17 |
| efried | stephenfin: But all the failures I saw today were in py27 | 14:17 |
| artom | efried, <lyarwood> artom: no missed that thanks, however this is on 2.7 oddly enough. | 14:17 |
| artom | <lyarwood> ah https://bugs.launchpad.net/nova/+bug/1804062/comments/4 | 14:17 |
| openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | 14:17 |
| stephenfin | Hmm, Canonical hardly backported the change, did they? | 14:17 |
| artom | dansmith, hrmm, neutronapi does make sense | 14:18 |
| artom | And it's something both compute manager and driver use already | 14:18 |
| artom | *libvirt driver | 14:18 |
| dansmith | artom: mmhmm :) | 14:18 |
| artom | It's still kinda weird that suddenly neutronapi will understand about compute manager and libvirt | 14:19 |
| artom | But... that was going to be weird regardless | 14:19 |
| dansmith | well, it doesn't reall,y | 14:19 |
| dansmith | it just declares "late" and "early" events or something | 14:19 |
| dansmith | it doesn't need to be revert specific, or even compute/virt specific | 14:19 |
| artom | dansmith, ah I see - "bind-time" vs "plug-time" | 14:19 |
| dansmith | something like that yeah | 14:19 |
| artom | Well, except it's *very* revert specific | 14:19 |
| artom | Because IIUC it doesn't happen unless the instance is present on the host, shut off | 14:20 |
| dansmith | the fact that it's revert specific is a nova detail | 14:20 |
| dansmith | it's specific to re-binding without changing the host, or whatever the eff it is | 14:20 |
| efried | stephenfin: looks like it may have been backported, yeah. | 14:20 |
| artom | Updating the binding to a host that already has the instance | 14:20 |
| *** prometheanfire has joined #openstack-nova | 14:21 | |
| dansmith | artom: there's also nova/network/somethingelse | 14:21 |
| dansmith | if you prefer | 14:21 |
| prometheanfire | nova tests flakey? | 14:21 |
| *** maciejjozefczyk has quit IRC | 14:21 | |
| efried | prometheanfire: We think we're hitting https://bugs.launchpad.net/nova/+bug/1804062/comments/4 | 14:21 |
| openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | 14:21 |
| artom | dansmith, events.py? | 14:21 |
| artom | neutronapi is fine | 14:21 |
| dansmith | artom: but the detail here is pretty neutron specific, as I understand it | 14:21 |
| artom | dansmith, oh yeah | 14:22 |
| efried | stephenfin: I'm going to propose a patch to disable in 2.7.15, unless you're already on that. | 14:22 |
| stephenfin | I was just going to fix the test | 14:22 |
| efried | stephenfin: oh, what's the fix? | 14:22 |
| stephenfin | No idea. I'm working on that :) | 14:22 |
| dansmith | artom: if you meant nova/network/events.py as a new modiule.. maybe but that's pretty heavy.. I dunno, I don't care that much, I just don't want it in virtapi | 14:22 |
| stephenfin | Wait, is this fixed in 2.7.16? | 14:22 |
| dansmith | artom: I bet mriedem has an opinion | 14:22 |
| stephenfin | i.e. is it a Python bug? | 14:22 |
| dansmith | artom: and it's probably contrary to my opinion | 14:23 |
| artom | dansmith, mriedem, well you guys can oil-wrestle it out | 14:23 |
| artom | I'm gonna go write code ;) | 14:23 |
| dansmith | artom: I think he likes to disagree with me because he thinks it makes him look smart, whereas I like to think agreeing with him makes _me_ look smart | 14:23 |
| efried | cdent: Do you understand the issue underlying https://bugs.launchpad.net/nova/+bug/1804062/comments/4 ? | 14:25 |
| openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | 14:25 |
| * cdent reads | 14:25 | |
| *** cfriesen has joined #openstack-nova | 14:26 | |
| efried | (whoah, that's a pretty serious regex in that hacking check) | 14:27 |
| prometheanfire | efried: thanks for the pointer | 14:27 |
| *** slaweq has quit IRC | 14:28 | |
| cdent | weird. I have no memory of any of this | 14:28 |
| sean-k-mooney | cdent: efried do vmware or powervm have a similar feature to libvirt auto converge livemigation optio where the vm is slowed if the migration is taking a long time to allow it too complete | 14:29 |
| *** dave-mccowan has joined #openstack-nova | 14:29 | |
| efried | sean-k-mooney: I don't recall any such thing, but that doesn't mean it doesn't exist. | 14:29 |
| sean-k-mooney | i dont think any driver other then libvirt support it in nova but i was wondering if it was supported by other hyperviors in general | 14:30 |
| *** pcaruana has joined #openstack-nova | 14:30 | |
| cdent | efried: I don't know if the underlying issue much matters? Basically if we take off the skip and things work, groovy, if not, we still stuck? Or are you after "can we fix the regex"? | 14:30 |
| efried | actually, I think powervm live migrate might actually quiesce the vm while it's migrating | 14:30 |
| *** pcaruana has quit IRC | 14:31 | |
| cdent | sean-k-mooney: the mysteries of the DRS are beyond me. If you can think it, it probably does it if you set the right setting. | 14:31 |
| *** pcaruana has joined #openstack-nova | 14:31 | |
| kashyap | yonglihe: I've also asked the QEMU post-copy migration author/maintainer to look at the spec, too. (I myself need to re-look at it, just been buried) | 14:31 |
| kashyap | (s/need/"wanted to"/) | 14:31 |
| sean-k-mooney | cdent: ya i assumed that its proably done under the hood in vspher or whatever | 14:32 |
| efried | cdent: Well, stephenfin is looking for a way to fix whatever we're doing in the test, but so far we're stymied on that. If it's not possible (or if it takes us longer than a few more minutes to figure out) I'd like to just disable the test. But since you touched it, and your code change implies some kind of understanding of the root cause of the breakage, I though I would ask you if you know what's going on there. | 14:32 |
| cdent | my understanding was based on chasing many links through the interwebs, not understanding the tokenizer | 14:32 |
| efried | okay | 14:33 |
| *** hamdyk has quit IRC | 14:34 | |
| efried | I'm trying to repro on bionic. Not happening at 2.7.15rc1 | 14:34 |
| efried | aha, but does reproduce on latest | 14:35 |
| stephenfin | yeah, I can't reproduce on Fedora 20 with 2.7.16 | 14:35 |
| efried | which lists self as 2.7.15+ -- not helpful :( | 14:35 |
| *** prometheanfire has left #openstack-nova | 14:36 | |
| stephenfin | or 3.6.8. Hmm | 14:42 |
| stephenfin | I always forget how damn big the nova repo is | 14:44 |
| stephenfin | Definitely should have shallow cloned | 14:44 |
| kashyap | sean-k-mooney: In that PostCopy spec, this naming sounds scary to me: "*_permit_reboot_risk" | 14:52 |
| *** itlinux has quit IRC | 14:55 | |
| *** ttsiouts has quit IRC | 14:57 | |
| *** ttsiouts has joined #openstack-nova | 14:58 | |
| *** mchlumsky has joined #openstack-nova | 14:59 | |
| *** ttsiouts_ has joined #openstack-nova | 15:00 | |
| *** ttsiouts has quit IRC | 15:01 | |
| efried | stephenfin: It's looking like it's only broken at 3.6.7 (some releaselevels - at least 'final') and 2.7.15 (likewise). So we could skip those and move on with life. | 15:03 |
| efried | oh, never mind, I just reproduced at 3.6.8 'final'. | 15:04 |
| stephenfin | If that's the case, yup, let's do that | 15:04 |
| stephenfin | damn | 15:04 |
| efried | stephenfin: what's your 3.6.8 where it wasn't reproducing? | 15:05 |
| efried | stephenfin: and did you remember to turn off the skip decorator? :P | 15:05 |
| stephenfin | python36-3.6.8-6.fc30.x86_64 | 15:05 |
| stephenfin | That only applies to 2.7, no? | 15:05 |
| stephenfin | I've got it reproduced in an Ubuntu VM | 15:06 |
| sean-k-mooney | kashyap: yes i agree i dont like that charaterisation which is why i suggeted other names instead | 15:06 |
| efried | stephenfin: The skip decorator is skipping the test in anything >= 3.6.7 | 15:06 |
| stephenfin | Sorry, yeah, 3.6 | 15:07 |
| sean-k-mooney | kashyap: my -1 is mainly for the extraspec names an di have one question regarding if post copy and auto converge can be used togeter at teh qemu/libvirt layer | 15:07 |
| kashyap | sean-k-mooney: Thanks. Didn't read everything yet; need a fresher mind. | 15:07 |
| kashyap | sean-k-mooney: I asked Dave (PostCopy author) to also comment, FWIW. | 15:07 |
| *** damien_r has quit IRC | 15:07 | |
| sean-k-mooney | kashyap: cool | 15:07 |
| kashyap | sean-k-mooney: Another thing is, how does one prioritize between PostCopy and AutoConverge | 15:07 |
| *** slaweq has joined #openstack-nova | 15:08 | |
| sean-k-mooney | kashyap: currently its states its an error to use both | 15:08 |
| sean-k-mooney | aparently nova perfers post copy over auto converge | 15:09 |
| sean-k-mooney | although if i rememebr correctly danpb prefered the idea of having auto converge enabled by default in nova and was less confindent in post copy | 15:09 |
| kashyap | sean-k-mooney: That's the response: | 15:09 |
| kashyap | 17:08 < kashyap> dgilbert: Can you use PostCopy and AutoConverge at the _same_ time, Dave? | 15:09 |
| kashyap | 17:08 < dgilbert> hmmmm | 15:10 |
| kashyap | 17:09 < dgilbert> if you can I don't think we've ever tested it | 15:10 |
| kashyap | sean-k-mooney: The thing is, some workloads will be "surprized" in a bad way to realize AutoConverge is auto-enabled | 15:10 |
| cfriesen | it doesn't make sense to use postcopy and autoconverge at the same time | 15:10 |
| kashyap | cfriesen: Yeah, it doesn't. One needs to know WTF they're doing before they start trying things | 15:11 |
| sean-k-mooney | kashyap: ya i know things like watcher | 15:11 |
| cfriesen | once you've enabled postcopy it'll naturally slow down as it pulls pages over the network, no need to artificially slow it down to allow to converge | 15:11 |
| sean-k-mooney | cfriesen: well autoconverge only slow it down if it failed to copy less the half of the outstanding pages in the last interval | 15:11 |
| kashyap | cfriesen: Yeah, the unsatisfying answer, as usual is, "it depends on the workload" | 15:11 |
| sean-k-mooney | and it does not slow down the workload intially untill a certin time has passed | 15:12 |
| cfriesen | sean-k-mooney: details. :) | 15:12 |
| stephenfin | printf-debugging++ | 15:12 |
| sean-k-mooney | if you are dirtiying memory fast enough i dont know if post-copy is required to ever finish or if write to remote memory will always be paged to local memory instead | 15:12 |
| *** lpetrut has quit IRC | 15:12 | |
| cfriesen | sean-k-mooney: once you've written to all local pages, then post-copy is done. :) | 15:13 |
| sean-k-mooney | if post-copy works by treating the remote meory as read only then its fine | 15:13 |
| cfriesen | sean-k-mooney: it does | 15:13 |
| sean-k-mooney | ok then ya no need to use both | 15:13 |
| cfriesen | sean-k-mooney: but if you lose the network while in post-copy, you're hosed | 15:13 |
| sean-k-mooney | yep i know | 15:13 |
| sean-k-mooney | but if you looes netwroking with shared storage your equally screwed | 15:14 |
| artom | We're allowed methods in neutronv2/api.py that aren't in network/api.py, right? | 15:16 |
| artom | Or is this like virt drivers, they all need to match? | 15:16 |
| sean-k-mooney | private ones yes | 15:16 |
| artom | Public ones | 15:16 |
| sean-k-mooney | what methods are you adding | 15:16 |
| sean-k-mooney | that moduel shoudl really only have methods that call neutron | 15:16 |
| artom | The get_events stuff, see convo with dansmith above | 15:16 |
| sean-k-mooney | its does not interact with the api | 15:17 |
| sean-k-mooney | so why would it be in that module | 15:17 |
| *** hamzy_ is now known as hamzy | 15:17 | |
| *** pcaruana has quit IRC | 15:17 | |
| artom | TBH, because dansmith said so, and it makes sense to me as well | 15:17 |
| artom | But mostly because he said so ;) | 15:17 |
| artom | This is not something I have the energy to debate | 15:17 |
| dansmith | artom: don | 15:17 |
| dansmith | artom: don't hedge :) | 15:18 |
| *** Luzi has quit IRC | 15:18 | |
| efried | stephenfin: I'm stumped. Are you getting anywhere? If not, I'm going to call time and just disable the test for now. | 15:18 |
| sean-k-mooney | dansmith: why in the api module and not here https://github.com/openstack/nova/blob/master/nova/network/model.py#L460 | 15:18 |
| stephenfin | efried: Yeah, I'm down in pycodestle | 15:18 |
| stephenfin | *pycodestyle | 15:19 |
| dansmith | sean-k-mooney: I said nova/network/something would be fine too | 15:19 |
| artom | I wasn't aware of the "must call neutron API" rule | 15:19 |
| efried | stephenfin: Was that "yeah I'm getting somewhere" or "yeah disable the test"? | 15:20 |
| dansmith | artom: I'm aware of no such rule | 15:20 |
| sean-k-mooney | artom: im not sure it a rule but that module is nova.network.neutronv2.api | 15:20 |
| artom | sean-k-mooney, actually yeah, with the new abstraction suggested by dansmith (plug-time vs bind-time), it fits in model as well | 15:20 |
| stephenfin | efried: Disable it. I'll keep looking | 15:20 |
| stephenfin | Here's our issue though https://github.com/PyCQA/pycodestyle/blob/2.0.0/pycodestyle.py#L1639 | 15:20 |
| stephenfin | We shouldn't be getting there but I don't know yet what's changed | 15:20 |
| sean-k-mooney | pretty much everything it does interacts with the neutron api in one way or another | 15:20 |
| *** sapd1_x has quit IRC | 15:21 | |
| dansmith | sean-k-mooney: we have constants defined in that module, and this detail is completely related to "what to expect from the neutron api" so I have no problem saying it should (or can) be in there | 15:21 |
| stephenfin | Things like this are why I was trying to get us onto a newer hacking version. Things invariably break | 15:21 |
| efried | stephenfin: aren't we on a newer hacking version at this point? | 15:21 |
| sean-k-mooney | artom: plugtime and bind time is more or less what i was thinking about in the neutron spec too so that makes sense to me | 15:21 |
| stephenfin | not really. Hacking is relying on a really old version of flake8 | 15:22 |
| artom | kawn sen suss! | 15:22 |
| stephenfin | Like, super old | 15:22 |
| stephenfin | and I can't update because they broke all the things in flake8 3.x :( https://gitlab.com/pycqa/flake8/issues/545 | 15:23 |
| * stephenfin stops grumbling | 15:23 | |
| *** maciejjozefczyk has joined #openstack-nova | 15:23 | |
| sean-k-mooney | ok well its not where i would instintivly look for them but i can live with it. | 15:23 |
| * artom moves stuff around once more | 15:24 | |
| *** ociuhandu_ has joined #openstack-nova | 15:24 | |
| sean-k-mooney | artom: to your orginal question https://github.com/openstack/nova/blob/master/nova/network/api.py isthe old nova networks api and the neton one extends it | 15:25 |
| sean-k-mooney | i think you can ignore https://github.com/openstack/nova/blob/master/nova/network/api.py at this point | 15:25 |
| artom | sean-k-mooney, ack, thanks for looking :) | 15:25 |
| *** ociuhand_ has joined #openstack-nova | 15:25 | |
| artom | (Though tbf my original question was rendered moot when we agreed to put it in model) | 15:26 |
| *** ociuhandu_ has quit IRC | 15:26 | |
| sean-k-mooney | artom: :) by the way i proposed https://review.opendev.org/#/c/664442/ to test this | 15:27 |
| artom | sean-k-mooney, yep, thanks for that | 15:28 |
| *** ociuhandu has quit IRC | 15:28 | |
| *** ociuhand_ has quit IRC | 15:29 | |
| *** ociuhandu has joined #openstack-nova | 15:30 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Skip test_check_doubled_words hacking check UT https://review.opendev.org/664622 | 15:30 |
| efried | stephenfin: ^ | 15:30 |
| efried | dansmith: mind unblocking the gate ^ | 15:35 |
| * efried bbiab | 15:35 | |
| *** udesale has quit IRC | 15:42 | |
| *** pcaruana has joined #openstack-nova | 15:43 | |
| *** maciejjozefczyk has quit IRC | 15:44 | |
| *** igordc has joined #openstack-nova | 15:44 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 15:45 |
| aspiers | efried: vastly improved patchset based on your feedback ^^^ | 15:45 |
| *** eharney has quit IRC | 15:46 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA affinity for vGPUs https://review.opendev.org/650963 | 15:47 |
| *** luksky has joined #openstack-nova | 15:47 | |
| efried | aspiers: looking. | 15:48 |
| *** _alastor_ has joined #openstack-nova | 15:48 | |
| *** tbachman has quit IRC | 15:48 | |
| *** helenafm has quit IRC | 15:49 | |
| stephenfin | efried, cdent: Here's what's happening | 15:49 |
| stephenfin | Because of https://bugs.python.org/issue33899, we now insert a NEWLINE token at the end of all lines | 15:50 |
| stephenfin | that manifests itself in pycodestyle | 15:50 |
| stephenfin | which is interating through all the tokens on the test line | 15:50 |
| stephenfin | https://github.com/PyCQA/pycodestyle/blob/2.0.0/pycodestyle.py#L1616 | 15:50 |
| *** tbachman has joined #openstack-nova | 15:51 | |
| stephenfin | previously, when we got to the end of the line we were falling through to this case https://github.com/PyCQA/pycodestyle/blob/2.0.0/pycodestyle.py#L1650-L1652 | 15:51 |
| stephenfin | but now, because we see this newline token, we hit this case instead https://github.com/PyCQA/pycodestyle/blob/2.0.0/pycodestyle.py#L1632-L1635 | 15:52 |
| stephenfin | note that that case doesn't include a call to 'check_physical' | 15:52 |
| stephenfin | so our test never gets run | 15:52 |
| stephenfin | I don't know how to fix that. It feels like this is now a bug in pycodestyle | 15:53 |
| stephenfin | I note that the latest version of pycodestyle does pretty much the same thing too https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2104-L2107 | 15:54 |
| cdent | stephenfin: sorry stephenfin, I thought most of what you said above was already understood: and it being a bug on pycodestyle was known | 15:54 |
| cdent | or rather: pycodestyle's continued behavior is the root | 15:54 |
| stephenfin | Um, whut? :) | 15:54 |
| stephenfin | Clearly I didn't read far enough | 15:55 |
| *** aram1s has quit IRC | 15:55 | |
| cdent | Or maybe I just reached that conclusion based on the discussion on https://bugs.python.org/issue33899 which if I recall right suggests the same thing | 15:55 |
| *** pcaruana has quit IRC | 15:55 | |
| stephenfin | Yup, now that I search for pycodestyle I see the line of course. Dang it | 15:56 |
| stephenfin | Their fix is rather odd though https://github.com/PyCQA/pycodestyle/pull/801/files | 15:56 |
| * stephenfin keeps looking | 15:56 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556 | 15:58 |
| *** eharney has joined #openstack-nova | 15:58 | |
| *** tbachman has quit IRC | 15:59 | |
| aspiers | efried: What's supposed to happen when hw:mem_encryption=True but trait:HW_CPU_X86_AMD_SEV=required is missing? | 16:01 |
| efried | aspiers: How could that happen? | 16:02 |
| efried | oh | 16:02 |
| aspiers | efried: Should the filter automatically add it for now, but then later error if we add support for MKTME? | 16:02 |
| efried | No, we should never add the trait. | 16:02 |
| stephenfin | efried: If you apply this to '.tox/py27/lib/python2.7/site-packages/pycodestyle.py' it fixes things, yeah? http://paste.openstack.org/show/752752/ | 16:02 |
| aspiers | OK, so then we need to error if it's missing, which somewhat reduces the user-friendliness benefit of hw:mem_encryption | 16:03 |
| efried | aspiers: You're assured of landing on capable hosts because they're the only ones that can satisfy the MEM_ENCRYPTION_CONTEXT inventory. | 16:03 |
| efried | No | 16:03 |
| efried | if the image/flavor prop is specified, it means I want mem encryption | 16:04 |
| efried | if I care that it's SEV, I specify the SEV trait and land on an AMD host | 16:04 |
| efried | if I care that it's MKTME, I specify the MKTME trait and land on an Intel host | 16:04 |
| efried | if I don't care which, I leave the trait out and land on either one. | 16:04 |
| aspiers | Sure, but I'm talking about the last case | 16:04 |
| aspiers | In that case, there needs to be logic *somewhere* in the code which says "OK, the user wants encrypted memory, and the only way to achieve that currently is SEV" | 16:04 |
| aspiers | so that it triggers usage of all the SEV bits | 16:04 |
| efried | No. | 16:04 |
| efried | I never land on a non-capable host, because only capable hosts have MEM_ENCRYPTION_CONTEXT inventory. | 16:04 |
| *** ttsiouts_ has quit IRC | 16:04 | |
| efried | Today the only hosts exposing that inventory will be SEV-capable hosts, so that falls into place. | 16:05 |
| aspiers | Sure | 16:05 |
| aspiers | but where does that logic go? ^^^ | 16:05 |
| *** ttsiouts has joined #openstack-nova | 16:05 | |
| efried | It's implicit. It's free. It doesn't "go" anywhere. | 16:05 |
| aspiers | It's not enough to land on the right host | 16:05 |
| aspiers | nova needs to know to add all the extra bits to the guest config | 16:05 |
| efried | extra bits | 16:06 |
| aspiers | yes, like <launchSecurity /> and <locked /> | 16:06 |
| aspiers | and a whole bunch of iommu stuff | 16:06 |
| efried | always the same if I'm SEV, right? | 16:06 |
| *** cdent has quit IRC | 16:06 | |
| aspiers | Not sure I understand the question | 16:07 |
| aspiers | That extra config varies depending on a whole bunch of things | 16:07 |
| efried | okay, but the virt driver knows how to twiddle the guest config based on a) mem_encryption flavor/image prop, and b) fact I'm on an AMD host | 16:07 |
| efried | If there are user-/admin-configurable options beyond "yes" or "no", we should talk about where those should go. | 16:08 |
| efried | But my understanding was that from the admin/user pov it was "yes" or "no". | 16:08 |
| aspiers | It is | 16:08 |
| efried | and if there are any variations, it's discovered based on specifics of the system | 16:08 |
| efried | okay | 16:08 |
| efried | so the virt driver knows b) | 16:08 |
| efried | that's how it knows it's doing SEV | 16:09 |
| aspiers | It sounds like you are saying that the logic should go in the virt driver and it should be "if the current context has MEM_ENCRYPTION_CONTEXT=1 and the current host is SEV, then add the SEV bits" | 16:09 |
| efried | okay, yes | 16:09 |
| *** ttsiouts has quit IRC | 16:10 | |
| aspiers | OK, thanks - think I know how to write it now | 16:10 |
| efried | I suppose if you're being careful, you should raise a nice exception if you get MEM_ENCRYPTION_CONTEXT without being SEV-capable (regardless of AMD-ness) | 16:10 |
| aspiers | Yes can do. BTW SEV is AMD-only | 16:11 |
| aspiers | Very much a vendor-specific thing | 16:11 |
| aspiers | You probably knew that and I'm just misinterpreting the point of your last clause in parentheses | 16:12 |
| *** boxiang_ has quit IRC | 16:14 | |
| efried | Yes, what I'm saying is, theoretically there should have been no way you got this far if the host wasn't SEV-capable, but, I don't know, if someone switched off the capability between allocation and spawn, you should fail hard. | 16:14 |
| aspiers | Yep, absolutely | 16:15 |
| aspiers | It was the "(regardless of AMD-ness)" bit I didn't quite get | 16:15 |
| efried | stephenfin: fixes it py27 | 16:15 |
| stephenfin | sweet | 16:16 |
| stephenfin | I'll submit that as a fix to pycodestyle | 16:16 |
| *** kaliya has quit IRC | 16:17 | |
| efried | stephenfin: fixes in py36 as well | 16:17 |
| efried | stephenfin: why is self.lines[-1] correct? | 16:18 |
| *** tesseract has quit IRC | 16:18 | |
| stephenfin | It's not, actually, now that you mention it | 16:19 |
| stephenfin | Or maybe it is. Needs more tests | 16:21 |
| aspiers | efried: bbobrov is on vacation so I'm taking over his SEV patches, and thinking about rebasing them all into a single linear commit series (even though this won't accurately reflect the dependencies between them) - does that make sense? | 16:21 |
| efried | aspiers: Yes it does. I was kind of wondering why they weren't already in one line. | 16:22 |
| aspiers | efried: Well, I gave a few reasons for that in our previous discussions on this, but an additional reason is weak coordination between me and him ... :) | 16:23 |
| efried | ack | 16:23 |
| aspiers | One downside is that if an earlier patch fails CI, it bottlenecks merging of anything higher up | 16:23 |
| aspiers | but if it makes life easier for reviewers then that probably overrules any other considerations | 16:24 |
| *** mdbooth has quit IRC | 16:24 | |
| efried | It's not just that. It's that ultimately you're going to need a patch that ties everything together. And as previously discussed, you can't have a dep tree that's upside down. | 16:24 |
| aspiers | Sure | 16:24 |
| aspiers | Another downside is that it will significantly increase the number of rebases | 16:25 |
| efried | So yes, the fact that some patches *could* be merged independently if they were separated - it's just something that we live with. | 16:25 |
| aspiers | but again I can live with those | 16:25 |
| aspiers | Definitely a nice future enhancement for Gerrit | 16:25 |
| aspiers | One can dream ... | 16:25 |
| aspiers | I guess I'll rebase all his stuff on top of mine, since it's the next phase | 16:26 |
| aspiers | My stuff is all about feature detection and scheduling; his is about guest config and booting | 16:26 |
| aspiers | Then the series will roughly match the order of work items | 16:27 |
| aspiers | as listed http://specs.openstack.org/openstack/nova-specs/specs/train/approved/amd-sev-libvirt-support.html#work-items | 16:27 |
| efried | aspiers: | 16:29 |
| efried | > It was the "(regardless of AMD-ness)" bit I didn't quite get | 16:29 |
| efried | I just meant "being on AMD isn't enough; other stars must align for SEV to be supported" | 16:29 |
| efried | So your check in the virt driver should just reuse the same "am I SEV capable" method that it used to expose the MEM_ENCRYPTION_CONTEXT inventory and the HW_CPU_X86_AMD_SEV trait in the first place. Which is why there should be no way for that check to fail - unless something changed in between update_provider_tree and spawn. | 16:29 |
| efried | and yes, I agree with your ordering, especially since your patches are already 2/3 with one +2 and the last one very close to same, but the other ones are still awaiting your nod before I even dig into them. | 16:31 |
| *** spatel has joined #openstack-nova | 16:32 | |
| *** ccamacho has quit IRC | 16:36 | |
| *** davidsha has quit IRC | 16:36 | |
| aspiers | efried: OK thanks, we're 100% aligned :) | 16:37 |
| *** whoami-rajat has quit IRC | 16:38 | |
| *** ociuhandu_ has joined #openstack-nova | 16:39 | |
| *** ociuhandu has quit IRC | 16:39 | |
| aspiers | efried: Oh, one extra detail regarding the above - yes the check can just look at the supports_amd_sev instance variable, but it also needs to check extra_specs for resources:MEM_ENCRYPTION_CONTEXT=1 to know that encrypted memory was requested, right? | 16:40 |
| aspiers | If *both* are true then it should add all the SEV guest config tweaks | 16:40 |
| efried | s/check extra_specs/check the allocation/ but otherwise, ja, genau | 16:42 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886 | 16:44 |
| *** slaweq has quit IRC | 16:49 | |
| aspiers | efried: OK thanks, I guess that will become self-evident when I look into how to check allocations | 16:49 |
| *** pcaruana has joined #openstack-nova | 16:49 | |
| efried | aspiers: Well, I would rather you check the allocations rather than duplicating the logic you just put in your request filter to check and validate the flavor & image | 16:49 |
| efried | The allocations are passed to spawn. They're just a dict. See the placement API reference for the format. | 16:50 |
| aspiers | Cool, thanks! | 16:50 |
| aspiers | I'm beginning to feel that this is nearing code-completion and maybe can be added to the runway queue soon | 16:50 |
| efried | yup | 16:51 |
| *** dtantsur is now known as dtantsur|afk | 16:51 | |
| aspiers | I do want to test the whole series on real SEV hardware first though | 16:51 |
| aspiers | (which I have available to me right now) | 16:51 |
| *** slaweq has joined #openstack-nova | 16:52 | |
| *** rpittau is now known as rpittau|afk | 16:55 | |
| *** spatel has quit IRC | 16:56 | |
| *** slaweq has quit IRC | 16:56 | |
| *** itlinux has joined #openstack-nova | 16:57 | |
| efried | dustinc: sdk release 0.31.0 is in u-c now, so I'd like to respin the series to bump that and fix up that other thing we talked about yesterday. Let me know when you're clear of local edits. | 16:58 |
| *** luksky has quit IRC | 16:59 | |
| *** derekh has quit IRC | 17:01 | |
| *** tssurya has quit IRC | 17:04 | |
| *** whoami-rajat has joined #openstack-nova | 17:05 | |
| *** luksky has joined #openstack-nova | 17:05 | |
| *** luksky has quit IRC | 17:12 | |
| *** hemna has quit IRC | 17:30 | |
| *** hemna has joined #openstack-nova | 17:30 | |
| dustinc | efried: Hmm...might be a bit, go for it and I can deal with merging my local edits | 17:44 |
| *** ralonsoh has quit IRC | 17:53 | |
| *** priteau has quit IRC | 17:54 | |
| *** ociuhandu has joined #openstack-nova | 17:54 | |
| *** ociuhandu_ has quit IRC | 17:57 | |
| *** ociuhandu has quit IRC | 17:59 | |
| *** spatel has joined #openstack-nova | 18:03 | |
| spatel | sean-k-mooney: any idea about this setting https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1724614 ? | 18:03 |
| openstack | Launchpad bug 1724614 in linux (Ubuntu) "[KVM] Lower the default for halt_poll_ns to 200000 ns" [Medium,Triaged] | 18:03 |
| spatel | i have default value but i heard it gives good boost to CPU if you play with this setting | 18:03 |
| mriedem | efried: do we have a bug for the test_check_doubled_words py27 failures? | 18:05 |
| *** mdbooth has joined #openstack-nova | 18:08 | |
| sean-k-mooney | spatel: i have not had experience with tweaking that specific tunable in the past. | 18:09 |
| spatel | even i am running in default, i heard from someone but may be its application specific. | 18:10 |
| sean-k-mooney | spatel: i would proably try to find some infomation on it form nfv/hpc tuning guide but there are man paramaters that can be tweaked not all of which will help for all workloads | 18:10 |
| spatel | +1 | 18:11 |
| spatel | but i am seeing sometime my ksm cpu usage going high on compute node | 18:11 |
| spatel | [ksmd] | 18:12 |
| sean-k-mooney | you proably want to read this https://www.kernel.org/doc/Documentation/virtual/kvm/halt-polling.txt | 18:12 |
| *** christopher_mcca has joined #openstack-nova | 18:16 | |
| sean-k-mooney | spatel: ibm seam to be recommendign a value fo 80000 ns based on https://www.ibm.com/support/knowledgecenter/en/linuxonibm/liaag/wkvm/wkvm_c_tune_kvm.htm but this seams to be a tradeoff between powersavings and latency which translated to higher throughput at the cost of cpu efficenty | 18:17 |
| *** christopher_mcca has left #openstack-nova | 18:18 | |
| spatel | it seem that setting will schedule in very less time which increase power usage | 18:19 |
| spatel | anyway i am not going to change until i have solid reason to do | 18:20 |
| *** tbachman has joined #openstack-nova | 18:35 | |
| mriedem | coreycb: is this the right change log to be looking at for ubuntu bionic py27? http://changelogs.ubuntu.com/changelogs/pool/main/p/python2.7/python2.7_2.7.15~rc1-1ubuntu0.1/changelog | 18:37 |
| mriedem | efried: https://bugs.launchpad.net/nova/+bug/1832392 | 18:38 |
| openstack | Launchpad bug 1832392 in OpenStack Compute (nova) "nova.tests.unit.test_hacking.HackingTestCase.test_check_doubled_words failing in py27 jobs since June 10" [High,Confirmed] | 18:38 |
| *** ricolin_ has quit IRC | 18:38 | |
| *** pcaruana has quit IRC | 18:39 | |
| efried | mriedem: Tracking it against bug/1804062 | 18:40 |
| efried | mriedem: https://review.opendev.org/664622 is merging to disable the test | 18:40 |
| coreycb | mriedem: that is the latest update for the bionic-security pocket but bionic-updates is more recent. you can see the versions here: https://launchpad.net/ubuntu/+source/python2.7 | 18:40 |
| efried | mriedem: and stephenfin is working on a patch to pycodestyle to get closer to fixing the core issue. | 18:40 |
| mriedem | coreycb: ah ok here is the june 10 change then https://launchpad.net/ubuntu/+source/python2.7/2.7.15-4ubuntu4~18.04 | 18:41 |
| coreycb | mriedem: yep | 18:43 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 18:44 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Include direct-physical in compute manager events check https://review.opendev.org/664431 | 18:44 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | 18:45 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 18:46 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Include direct-physical in compute manager events check https://review.opendev.org/664431 | 18:46 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | 18:46 |
| artom | Fscked up my rebases | 18:46 |
| mriedem | ok so probably no point in rechecking anything | 18:48 |
| mriedem | or working on nova for a few days... | 18:48 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refresh instance network info on deletion https://review.opendev.org/660761 | 18:49 |
| *** tbachman has quit IRC | 18:52 | |
| *** markvoelker has joined #openstack-nova | 18:55 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 19:03 |
| aspiers | efried: there ya go ^^^ | 19:03 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix default values in update_cell command https://review.opendev.org/662383 | 19:03 |
| aspiers | artom: reflog is your friend ;-) | 19:04 |
| artom | aspiers, wasn't that bad | 19:04 |
| artom | If I need reflog then I've really messed up | 19:05 |
| aspiers | hehe | 19:05 |
| aspiers | Oh I dunno, it can be a real handy shortcut sometimes | 19:06 |
| artom | I'm off to the gym, during the day, for a change, while Zuul runs | 19:07 |
| *** tbachman has joined #openstack-nova | 19:09 | |
| efried | mriedem: Once that bypass merges, which should hopefully happen pdq (test-only patches don't run tempest/dsvm stuff, right?) you can recheck the world. | 19:09 |
| mriedem | dansmith: would you see a use for a weigher config option for the vgpu/numa affinity weigher in sylvain's spec? https://review.opendev.org/#/c/650963/ | 19:13 |
| mriedem | since we have config options to control all other weighers | 19:13 |
| dansmith | just in general? I mean, I would expect all weighers to be controllable like that | 19:13 |
| mriedem | in general yes | 19:13 |
| dansmith | unless it was something SUPER airtight like the failed computes weigher | 19:14 |
| * dansmith shoots self | 19:14 | |
| dansmith | dude | 19:15 |
| dansmith | you should have snipped that last line | 19:15 |
| mriedem | ha | 19:15 |
| mriedem | sorry | 19:16 |
| mriedem | also not sure what he's proposing for the claim stuff, | 19:16 |
| mriedem | normally if we were to link up the scheduler to some RT claim, we'd use the limits so that if you disable the filter we don't claim on those limits in the RT, | 19:16 |
| mriedem | but with this, it sounds like the compute would always just pull the VGPU allocations and pass those onto the claim | 19:17 |
| dansmith | erm | 19:19 |
| dansmith | is this really adding new claims to the RT? | 19:20 |
| mriedem | it says it is | 19:20 |
| mriedem | https://review.opendev.org/#/c/650963/7/specs/train/approved/libvirt-vgpu-numa-affinity.rst@99 | 19:21 |
| dansmith | yeah, that's the line I'm wondering about | 19:21 |
| *** igordc has quit IRC | 19:26 | |
| *** markvoelker has quit IRC | 19:29 | |
| melwitt | does anyone know if the failed_builds count is exposed out of the REST API at all? | 19:29 |
| *** mdbooth has quit IRC | 19:31 | |
| mriedem | melwitt: it's not | 19:32 |
| melwitt | danke | 19:32 |
| mriedem | it's shoved into compute_nodes.stats which is a json blob in the db | 19:32 |
| melwitt | ah ok, I was wondering about that too. I found the nova/compute/stats.py file and didn't know how it's used. thanks | 19:33 |
| Nick_A | Is there a way to take online snapshots of lxd containers? | 19:34 |
| mriedem | Nick_A: you should ask the lxd devs in #lxcontainers | 19:34 |
| Nick_A | thank you | 19:34 |
| mriedem | https://github.com/openstack/nova-lxd#support-and-discussions | 19:34 |
| *** damien_r has joined #openstack-nova | 19:47 | |
| *** damien_r has quit IRC | 19:51 | |
| *** amodi has quit IRC | 19:59 | |
| *** efried has quit IRC | 20:01 | |
| *** psachin has quit IRC | 20:02 | |
| *** Sundar has joined #openstack-nova | 20:04 | |
| *** bbowen has quit IRC | 20:09 | |
| *** efried has joined #openstack-nova | 20:10 | |
| efried | dustinc: gonna do that now, mkay? | 20:11 |
| dustinc | 👍 | 20:11 |
| *** JamesBenson has joined #openstack-nova | 20:17 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Introduces the openstacksdk to nova https://review.opendev.org/643664 | 20:23 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | 20:23 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use SDK instead of ironicclient for node.list https://review.opendev.org/656027 | 20:23 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use SDK instead of ironicclient for validating instance and node https://review.opendev.org/656028 | 20:23 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use SDK instead of ironicclient for setting instance id https://review.opendev.org/659690 | 20:23 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use SDK instead of ironicclient for add/remove instance info from node https://review.opendev.org/659691 | 20:23 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use OpenStack SDK for placement https://review.opendev.org/656023 | 20:23 |
| efried | dustinc: ^ | 20:23 |
| *** markvoelker has joined #openstack-nova | 20:26 | |
| *** eharney has quit IRC | 20:32 | |
| *** tbachman has quit IRC | 20:35 | |
| efried | f f f f. bug 1823251 hit https://review.opendev.org/#/c/664622/ after sitting in the queue for 5h. | 20:44 |
| openstack | bug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019 on limestone-regionone" [High,Confirmed] https://launchpad.net/bugs/1823251 | 20:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: [ironic] Don't remove instance info twice in destroy https://review.opendev.org/662584 | 20:46 |
| sean-k-mooney | efried: is the 5 hour lag just a general issue with the gate being slow or is it related | 20:47 |
| efried | sean-k-mooney: I'm sure it's just because we had a couple dozen patches in the queue (all of which failed on that issue of course) so that one got pushed. | 20:48 |
| mordred | efried: ooh - and you've got the ironicclient patches too - that's so cool | 20:51 |
| efried | mordred: Yes, dustinc has been working on those. I'm not sure how done he is (percentage-wise) - dustinc? | 20:51 |
| * mordred hands dustinc a somewhat uneaten bunch of carrots | 20:51 | |
| sean-k-mooney | i have a ptach queue in neutron for a little over 2 and a half hours without it starting so i think the gate is slow to start jobs currently in general | 20:51 |
| efried | mordred: I'm pretty sure we're going to need some feature parity for ironic in sdk before we can be all the way complete there, but fortunately dtantsur|afk knows his sdk AND his ironic :) | 20:52 |
| * dustinc munches | 20:52 | |
| dustinc | I am not even sure how far done I am percentage-wise | 20:52 |
| mordred | efried: yah - and has already been working through feature parity for other usage | 20:53 |
| dustinc | but it is coming along | 20:53 |
| * mordred is excited for the additional usage surface-area ... we should probably add a tempest test job to sdk's gate | 20:54 | |
| mordred | (we don't have one of those right now, because it wouldn't be valuable - but with nova using it to talk to services, it's an additinoal useful thing to check) | 20:55 |
| openstackgerrit | Eric Fried proposed openstack/nova master: get_ksa_adapter: nix by-service-type confgrp hack https://review.opendev.org/664689 | 20:56 |
| *** markvoelker has quit IRC | 20:59 | |
| efried | mordred: probably not relevant until some of the above merges, eh? | 20:59 |
| efried | mordred: We don't even have an approved blueprint yet :P | 20:59 |
| redkrieg | does anyone have any troubleshooting tips for tracking down why cloud-init on my guests isn't getting ssh keys or passwords from metadata? it works for me in one of my regions but not another, I don't see anything odd in my nova metadata wsgi logs either. | 21:00 |
| efried | sean-k-mooney: your patch is going to fail unless you rebase it on https://review.opendev.org/#/c/664622/ | 21:01 |
| sean-k-mooney | which one? | 21:02 |
| sean-k-mooney | the one i said is 2 and a half hours in the queue? | 21:02 |
| sean-k-mooney | if so its a neutorn patch so its fine | 21:02 |
| sean-k-mooney | my other nova paths will fail however yes | 21:03 |
| sean-k-mooney | im not going to push anything more today so if that isnt merged tommorw ill rebase things on top of it as needed | 21:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Disable limit if affinity(anti)/same(different)host is requested https://review.opendev.org/659246 | 21:04 |
| *** nicolasbock has quit IRC | 21:06 | |
| *** itlinux has quit IRC | 21:07 | |
| *** nicolasbock has joined #openstack-nova | 21:08 | |
| mriedem | can i get some stable core love on https://review.opendev.org/#/q/topic:bug/1830747+branch:stable/rocky ? | 21:08 |
| mriedem | working on flushing stable/rocky for a release | 21:09 |
| *** luksky has joined #openstack-nova | 21:09 | |
| mordred | efried: oh - yeah - definitely not until it's actually going to test something | 21:10 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove _ContextAuthPlugin.get_endpoint* workaround https://review.opendev.org/664703 | 21:21 |
| openstackgerrit | Merged openstack/nova master: Replace 'is comprised of' with 'comprises' https://review.opendev.org/663175 | 21:29 |
| *** igordc has joined #openstack-nova | 21:31 | |
| sean-k-mooney | can we revert ^ | 21:32 |
| sean-k-mooney | efried: it is not correct | 21:32 |
| sean-k-mooney | ... i guess i dont care enought but "is comprised of" was correct "comprises" as used in that patch is not. | 21:33 |
| sean-k-mooney | "Nova is composed of multiple server processes" would also be correct | 21:34 |
| *** luksky has quit IRC | 21:35 | |
| efried | sean-k-mooney: google it | 21:35 |
| efried | pick any result | 21:35 |
| efried | "is composed of" would be correct. "is comprised of" is not, nor is "comprises of". | 21:35 |
| efried | but it is correct as patched | 21:36 |
| sean-k-mooney | the current wording read quite badly to me | 21:36 |
| sean-k-mooney | the pacing feels wrong | 21:37 |
| efried | I would have accepted "is composed of", but now that it's grammatically correct, I don't see it being worth changing. | 21:38 |
| *** nicolasbock has quit IRC | 21:39 | |
| *** spatel has quit IRC | 21:39 | |
| sean-k-mooney | i keep wanting to read it as if there is a comma after comprises | 21:39 |
| sean-k-mooney | if i force my self t to read it as written the its fine | 21:40 |
| *** nicolasbock has joined #openstack-nova | 21:41 | |
| sean-k-mooney | hum i can reluctanlty agree to never use comprises but https://www.grammarly.com/blog/comprise-vs-compose/ makes some sense | 21:46 |
| *** JamesBenson has quit IRC | 21:48 | |
| melwitt | I'm surprised someone opened a doc bug for that. as far as I've known, "is comprised of" makes OK sense | 21:53 |
| sean-k-mooney | melwitt: i was assuming it was a us vs uk thing | 21:53 |
| melwitt | yeah, I assumed must be a regional thing | 21:53 |
| *** markvoelker has joined #openstack-nova | 21:56 | |
| *** bbowen has joined #openstack-nova | 21:58 | |
| efried | no, just such a common mistake it's almost become accepted | 22:05 |
| efried | Ask asettle :P | 22:05 |
| sean-k-mooney | got distracted reading the wiki article https://en.wikipedia.org/wiki/Comprised_of | 22:07 |
| sean-k-mooney | apparently its is commonly used in us patents and dates forn the 18 century | 22:07 |
| melwitt | ¯\_(ツ)_/¯ | 22:08 |
| sean-k-mooney | so i think its on better footing then performant | 22:08 |
| melwitt | haha right? | 22:08 |
| efried | oh, please do not base real english on what's in patents | 22:09 |
| melwitt | of all the other non-words we accept, "is comprised of" is the one to go after | 22:09 |
| sean-k-mooney | efried: the stonger argument is dont belive everything you read on wikipedia :P | 22:10 |
| *** rcernin has joined #openstack-nova | 22:10 | |
| *** itlinux has joined #openstack-nova | 22:14 | |
| *** slaweq has joined #openstack-nova | 22:22 | |
| *** markvoelker has quit IRC | 22:30 | |
| *** slaweq has quit IRC | 22:30 | |
| *** itlinux has quit IRC | 22:38 | |
| openstackgerrit | Merged openstack/nova stable/rocky: libvirt: Avoid using os-brick encryptors when device_path isn't provided https://review.opendev.org/656463 | 22:50 |
| *** whoami-rajat has quit IRC | 22:55 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Stop logging traceback when skipping quiesce https://review.opendev.org/660327 | 22:57 |
| *** tkajinam has joined #openstack-nova | 23:04 | |
| *** mriedem has quit IRC | 23:06 | |
| *** BjoernT_ has quit IRC | 23:09 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Restore connection_info after live migration rollback https://review.opendev.org/660375 | 23:16 |
| openstackgerrit | Merged openstack/nova stable/rocky: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/660362 | 23:17 |
| *** JamesBenson has joined #openstack-nova | 23:18 | |
| *** JamesBenson has quit IRC | 23:22 | |
| *** factor has joined #openstack-nova | 23:22 | |
| *** markvoelker has joined #openstack-nova | 23:26 | |
| *** mlavalle has quit IRC | 23:28 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make get_provider_by_name public and remove safe_connect https://review.opendev.org/664062 | 23:33 |
| openstackgerrit | Merged openstack/nova stable/rocky: Replace the invalid index of nova-rocky releasenote https://review.opendev.org/663178 | 23:37 |
| openstackgerrit | Merged openstack/nova stable/rocky: [stable-only] Improve the reno for consoleauth upgrade check https://review.opendev.org/661118 | 23:37 |
| *** lbragstad has quit IRC | 23:41 | |
| *** liuyulong has quit IRC | 23:48 | |
| *** BjoernT has joined #openstack-nova | 23:50 | |
| *** BjoernT_ has joined #openstack-nova | 23:52 | |
| *** BjoernT has quit IRC | 23:54 | |
| *** brinzhang has joined #openstack-nova | 23:56 | |
| *** nicolasbock has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!