| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Enable omission of the value of '--config-drive' https://review.opendev.org/653683 | 00:22 |
|---|---|---|
| *** takashin has quit IRC | 00:39 | |
| *** dave-mccowan has quit IRC | 00:41 | |
| *** frank_wang has quit IRC | 00:44 | |
| *** dave-mccowan has joined #openstack-nova | 00:53 | |
| *** frankwang has joined #openstack-nova | 00:57 | |
| *** bhagyashris has joined #openstack-nova | 01:16 | |
| *** Dinesh_Bhor has quit IRC | 01:24 | |
| *** takashin has joined #openstack-nova | 01:24 | |
| *** boxiang_ has quit IRC | 01:27 | |
| *** boxiang_ has joined #openstack-nova | 01:27 | |
| *** rcernin has quit IRC | 01:30 | |
| *** tbachman has quit IRC | 01:31 | |
| *** j99 has joined #openstack-nova | 01:38 | |
| *** markvoelker has joined #openstack-nova | 01:42 | |
| *** rcernin has joined #openstack-nova | 01:46 | |
| *** brinzhang has joined #openstack-nova | 01:53 | |
| *** sapd1 has quit IRC | 01:58 | |
| *** markvoelker has quit IRC | 02:15 | |
| *** edleafe has quit IRC | 02:17 | |
| *** irclogbot_3 has quit IRC | 02:17 | |
| *** altlogbot_2 has quit IRC | 02:19 | |
| *** irclogbot_3 has joined #openstack-nova | 02:20 | |
| *** altlogbot_0 has joined #openstack-nova | 02:21 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix no propagation of nova context request_id https://review.opendev.org/662715 | 02:23 |
| *** _hemna has joined #openstack-nova | 02:24 | |
| *** sapd1 has joined #openstack-nova | 02:25 | |
| *** whoami-rajat has joined #openstack-nova | 03:08 | |
| *** dklyle has joined #openstack-nova | 03:22 | |
| *** ricolin has joined #openstack-nova | 03:22 | |
| *** psachin has joined #openstack-nova | 03:33 | |
| *** dklyle has quit IRC | 03:37 | |
| *** dklyle has joined #openstack-nova | 03:37 | |
| *** dave-mccowan has quit IRC | 03:38 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:45 | |
| *** factor has joined #openstack-nova | 03:45 | |
| *** BjoernT has joined #openstack-nova | 03:47 | |
| *** BjoernT has quit IRC | 03:47 | |
| *** udesale has joined #openstack-nova | 03:54 | |
| *** BjoernT has joined #openstack-nova | 03:58 | |
| *** BjoernT has quit IRC | 04:02 | |
| *** BjoernT has joined #openstack-nova | 04:03 | |
| *** BjoernT_ has joined #openstack-nova | 04:06 | |
| *** BjoernT has quit IRC | 04:07 | |
| *** BjoernT_ has quit IRC | 04:10 | |
| *** _hemna has quit IRC | 04:12 | |
| *** markvoelker has joined #openstack-nova | 04:12 | |
| *** janki has joined #openstack-nova | 04:34 | |
| *** _hemna has joined #openstack-nova | 04:42 | |
| *** markvoelker has quit IRC | 04:46 | |
| *** abhishekk has joined #openstack-nova | 04:47 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Replace joinedload_all with joinedload https://review.opendev.org/664193 | 04:59 |
| *** swamireddy has quit IRC | 05:01 | |
| *** pcaruana has joined #openstack-nova | 05:03 | |
| *** markvoelker has joined #openstack-nova | 05:09 | |
| *** _hemna has quit IRC | 05:15 | |
| *** ratailor has joined #openstack-nova | 05:29 | |
| *** ricolin has quit IRC | 05:29 | |
| *** slaweq has joined #openstack-nova | 05:31 | |
| *** slaweq has quit IRC | 05:35 | |
| *** udesale has quit IRC | 05:40 | |
| *** udesale has joined #openstack-nova | 05:41 | |
| *** udesale has quit IRC | 05:41 | |
| *** udesale has joined #openstack-nova | 05:42 | |
| *** ivve has quit IRC | 05:44 | |
| *** tkajinam has quit IRC | 05:51 | |
| *** tkajinam has joined #openstack-nova | 05:53 | |
| *** xek_ has joined #openstack-nova | 05:56 | |
| *** tkajinam_ has joined #openstack-nova | 05:56 | |
| *** guozijn has joined #openstack-nova | 05:56 | |
| *** tkajinam has quit IRC | 05:58 | |
| *** _hemna has joined #openstack-nova | 06:01 | |
| openstackgerrit | Merged openstack/nova-specs master: Specifying az when restore shelved server https://review.opendev.org/624689 | 06:01 |
| *** ratailor_ has joined #openstack-nova | 06:21 | |
| *** ratailor has quit IRC | 06:24 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Clarify the error response in proposed change https://review.opendev.org/664198 | 06:29 |
| *** slaweq has joined #openstack-nova | 06:30 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Validate requested host/node during servers create https://review.opendev.org/661237 | 06:31 |
| *** _hemna has quit IRC | 06:35 | |
| *** yikun has joined #openstack-nova | 06:41 | |
| *** ratailor_ has quit IRC | 06:47 | |
| *** ratailor_ has joined #openstack-nova | 06:47 | |
| *** ratailor__ has joined #openstack-nova | 06:50 | |
| *** ratailor__ has quit IRC | 06:50 | |
| *** udesale has quit IRC | 06:50 | |
| *** ratailor has joined #openstack-nova | 06:51 | |
| *** udesale has joined #openstack-nova | 06:51 | |
| *** ratailor_ has quit IRC | 06:51 | |
| *** ratailor_ has joined #openstack-nova | 06:55 | |
| *** ratailor has quit IRC | 06:58 | |
| *** ricolin has joined #openstack-nova | 06:58 | |
| *** ivve has joined #openstack-nova | 07:01 | |
| *** luksky has joined #openstack-nova | 07:05 | |
| *** guozijn has quit IRC | 07:06 | |
| *** rcernin has quit IRC | 07:09 | |
| *** _hemna has joined #openstack-nova | 07:10 | |
| *** dpawlik has joined #openstack-nova | 07:22 | |
| *** jangutter has joined #openstack-nova | 07:29 | |
| *** helenafm has joined #openstack-nova | 07:40 | |
| *** _hemna has quit IRC | 07:44 | |
| *** ralonsoh has joined #openstack-nova | 07:53 | |
| *** zbr has joined #openstack-nova | 07:55 | |
| *** zbr is now known as zbr|ruck | 07:55 | |
| *** guozijn has joined #openstack-nova | 07:58 | |
| *** ricolin has quit IRC | 08:02 | |
| sapd1 | Hi everyone, In this line, https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L362 I think I can get devices which are being attached to the instance, But When I tried, It returns None. | 08:05 |
| sapd1 | Can any one tell me why? | 08:07 |
| *** markvoelker has quit IRC | 08:10 | |
| *** markvoelker has joined #openstack-nova | 08:10 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Replace 'is comprised of' with 'comprises' https://review.opendev.org/663175 | 08:14 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove unnecessary setUp methods https://review.opendev.org/663179 | 08:14 |
| *** markvoelker has quit IRC | 08:15 | |
| *** _hemna has joined #openstack-nova | 08:22 | |
| *** imacdonn has quit IRC | 08:38 | |
| *** ociuhandu has joined #openstack-nova | 08:38 | |
| *** imacdonn has joined #openstack-nova | 08:38 | |
| *** xek_ has quit IRC | 08:40 | |
| *** tkajinam_ has quit IRC | 08:52 | |
| *** _hemna has quit IRC | 08:57 | |
| *** markvoelker has joined #openstack-nova | 09:11 | |
| *** owalsh has quit IRC | 09:26 | |
| *** owalsh has joined #openstack-nova | 09:27 | |
| *** jaosorior has joined #openstack-nova | 09:30 | |
| *** takashin has left #openstack-nova | 09:33 | |
| *** markvoelker has quit IRC | 09:44 | |
| openstackgerrit | Edward Hope-Morley proposed openstack/nova master: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/663607 | 09:45 |
| *** _hemna has joined #openstack-nova | 09:46 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | 09:52 |
| *** luksky has quit IRC | 09:55 | |
| *** slaweq has quit IRC | 09:57 | |
| *** cdent has joined #openstack-nova | 10:02 | |
| *** guozijn has quit IRC | 10:09 | |
| *** priteau has joined #openstack-nova | 10:10 | |
| *** _hemna has quit IRC | 10:21 | |
| *** frankwang has quit IRC | 10:24 | |
| *** bhagyashris has quit IRC | 10:36 | |
| *** davidsha has joined #openstack-nova | 10:37 | |
| *** udesale has quit IRC | 10:37 | |
| *** luksky has joined #openstack-nova | 10:41 | |
| *** guozijn has joined #openstack-nova | 10:46 | |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.opendev.org/602432 | 10:50 |
| *** brinzhang has quit IRC | 10:57 | |
| *** jaypipes has joined #openstack-nova | 11:02 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245 | 11:04 |
| *** _hemna has joined #openstack-nova | 11:10 | |
| *** slaweq has joined #openstack-nova | 11:18 | |
| *** nicolasbock has joined #openstack-nova | 11:24 | |
| *** abhishekk has quit IRC | 11:25 | |
| *** rcernin has joined #openstack-nova | 11:32 | |
| *** ttsiouts has joined #openstack-nova | 11:35 | |
| *** ttsiouts has quit IRC | 11:37 | |
| *** ttsiouts has joined #openstack-nova | 11:37 | |
| *** guozijn has quit IRC | 11:40 | |
| *** markvoelker has joined #openstack-nova | 11:41 | |
| *** ttsiouts has quit IRC | 11:42 | |
| *** rcernin has quit IRC | 11:43 | |
| *** _hemna has quit IRC | 11:45 | |
| *** BjoernT has joined #openstack-nova | 11:46 | |
| *** BjoernT has quit IRC | 11:51 | |
| *** jroll has quit IRC | 11:54 | |
| *** guozijn has joined #openstack-nova | 11:54 | |
| *** jroll has joined #openstack-nova | 11:54 | |
| *** keerthidg has joined #openstack-nova | 11:55 | |
| *** guozijn has quit IRC | 11:57 | |
| *** slaweq has quit IRC | 12:03 | |
| *** tbachman has joined #openstack-nova | 12:05 | |
| *** lbragstad has joined #openstack-nova | 12:08 | |
| *** edleafe has joined #openstack-nova | 12:13 | |
| *** ratailor_ has quit IRC | 12:14 | |
| *** markvoelker has quit IRC | 12:15 | |
| *** janki has quit IRC | 12:18 | |
| *** slaweq has joined #openstack-nova | 12:24 | |
| *** udesale has joined #openstack-nova | 12:25 | |
| *** _hemna has joined #openstack-nova | 12:34 | |
| *** lpetrut has joined #openstack-nova | 12:37 | |
| *** _hemna has quit IRC | 13:09 | |
| *** markvoelker has joined #openstack-nova | 13:12 | |
| *** _hemna has joined #openstack-nova | 13:16 | |
| *** artom has quit IRC | 13:16 | |
| *** jdillaman has joined #openstack-nova | 13:27 | |
| stephenfin | efried: I'd like a python-novaclient release with https://review.opendev.org/#/c/650363/ in it. Have proposed https://review.opendev.org/#/c/664259/, assuming that's okay? | 13:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102 | 13:32 |
| *** eharney has joined #openstack-nova | 13:32 | |
| *** tbachman has quit IRC | 13:33 | |
| *** yikun has quit IRC | 13:41 | |
| *** _hemna has quit IRC | 13:43 | |
| *** markvoelker has quit IRC | 13:45 | |
| *** dave-mccowan has joined #openstack-nova | 13:46 | |
| efried | stephenfin: looking | 13:47 |
| *** slaweq has quit IRC | 13:47 | |
| *** ricolin has joined #openstack-nova | 13:50 | |
| efried | stephenfin: gross. Are you going to blacklist all 8 versions the original got included in, for py27? | 13:51 |
| efried | I guess if this only affects the CLI, no need for that. | 13:51 |
| stephenfin | I don't think so | 13:51 |
| stephenfin | It's a lot of effort and I figure distros will pick this up pretty quickly | 13:51 |
| dansmith | is gibi out? | 13:51 |
| efried | stephenfin: +1 | 13:53 |
| *** mriedem has joined #openstack-nova | 13:54 | |
| *** dave-mccowan has quit IRC | 13:56 | |
| *** jistr is now known as jistr|call | 14:00 | |
| *** _alastor_ has joined #openstack-nova | 14:08 | |
| *** jistr|call is now known as jistr | 14:16 | |
| stephenfin | efried: Want to take a look at this too and unblock the rest of the series https://review.opendev.org/#/c/651311/ | 14:20 |
| efried | stephenfin: Will do. I was just looking at the "all call super" patch in that series... | 14:21 |
| stephenfin | Also got https://review.opendev.org/#/c/660950/ working, though that's lower priority (turns out it's 'foo(x=None, *args, **kwargs)' and not 'foo(*args, x=None, **kwargs)', but flake8 doesn't catch that) | 14:21 |
| stephenfin | Heh, jinx | 14:21 |
| *** dpawlik has quit IRC | 14:24 | |
| efried | stephenfin: bottom one is +A. | 14:29 |
| efried | imo the super one shouldn't be adding *args or **kwargs anywhere they weren't already. | 14:29 |
| *** slaweq has joined #openstack-nova | 14:29 | |
| *** lpetrut has quit IRC | 14:31 | |
| *** mlavalle has joined #openstack-nova | 14:32 | |
| *** maciejjozefczyk has joined #openstack-nova | 14:36 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make get_provider_by_name public and remove safe_connect https://review.opendev.org/664062 | 14:36 |
| *** keerthidg has quit IRC | 14:37 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950 | 14:38 |
| stephenfin | efried: Cool. Fixed the super one by removing all the *args and **kwargs (none of them were necessary, fwict) ^ | 14:38 |
| *** maciejjozefczyk has quit IRC | 14:42 | |
| *** markvoelker has joined #openstack-nova | 14:42 | |
| *** itlinux_ has quit IRC | 14:48 | |
| efried | stephenfin: Cool man, +2. | 14:53 |
| stephenfin | mriedem, sean-k-mooney: What am I missing here? I see only one callers to the revert_resize function and that's from the API https://review.opendev.org/#/c/662522/3/nova/compute/api.py@3420 | 14:53 |
| stephenfin | We wouldn't call "openstack resize --revert" on a failed migration, would we? | 14:53 |
| *** slaweq has quit IRC | 14:54 | |
| sean-k-mooney | stephenfin: im pretty sure we use teh revert_resize api endpoint to revert a cold-migration | 14:54 |
| mriedem | stephenfin: cold migrate == resize except same flavor | 14:55 |
| mriedem | it's the same code flow | 14:55 |
| stephenfin | I realize that | 14:55 |
| stephenfin | 100% | 14:55 |
| mriedem | your comment says, "This is the 'revert_resize' function. There's no way we could get here for anything unless we were doing a revert of the resize operation (i.e. no cold migration flow through here), right?" | 14:55 |
| stephenfin | but would a user revert a cold migration | 14:55 |
| mriedem | yes | 14:55 |
| mriedem | sure | 14:55 |
| sean-k-mooney | stephenfin: yes they can | 14:55 |
| mriedem | just because it's called "resize" doesn't mean it's not also used by the cold migrate flow | 14:55 |
| mriedem | same as rebuild is used for evacuate | 14:55 |
| stephenfin | Seriously? Why can't I find any documentation on the internet about this? | 14:56 |
| sean-k-mooney | because its an internal detail of nova implemeation | 14:56 |
| sean-k-mooney | it should be in a dev ref | 14:56 |
| stephenfin | The ability of a user to revert their failed cold migration is a internal detail? | 14:56 |
| stephenfin | How it's implemented, sure, but not the raw ability to do the thing | 14:57 |
| sean-k-mooney | its in the api ref | 14:57 |
| mriedem | for one, users don't cold migrate, admins do | 14:57 |
| mriedem | https://developer.openstack.org/api-ref/compute/?expanded=migrate-server-migrate-action-detail#migrate-server-migrate-action | 14:57 |
| mriedem | "after a successful cold migration and then must be confirmed or reverted." | 14:57 |
| stephenfin | the more you know | 14:58 |
| sean-k-mooney | i think revert does not require admin https://developer.openstack.org/api-ref/compute/?expanded=migrate-server-migrate-action-detail,revert-resized-server-revertresize-action-detail#migrate-server-migrate-action | 14:58 |
| sean-k-mooney | except as indicated in teh precondions | 14:58 |
| mriedem | "Policy defaults enable only users with the administrative role to perform this operation. " | 14:58 |
| *** BlackDex has quit IRC | 14:58 | |
| mriedem | cold migrate is admin_api by default | 14:59 |
| stephenfin | Hmm, why don't we have an 'openstack server migrate --revert' thing for this? | 14:59 |
| mriedem | we do | 14:59 |
| mriedem | https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#server-resize | 14:59 |
| mriedem | resize --revert | 14:59 |
| stephenfin | that's 'resize --revert', not 'migrate --revert' | 15:00 |
| mriedem | they hit the same api | 15:00 |
| stephenfin | Then why have an 'openstack migrate' command | 15:00 |
| mriedem | for cold and live migration | 15:00 |
| mriedem | which are not resizes | 15:00 |
| stephenfin | live migration, sure, but not cold migration | 15:01 |
| stephenfin | that's the same thing but with the same image? | 15:01 |
| stephenfin | *flavor | 15:01 |
| *** artom has joined #openstack-nova | 15:01 | |
| sean-k-mooney | stephenfin: we could delete migrate and jsut use resize for the cold migration case but most user dont think a resize and migration are the same thing | 15:02 |
| mriedem | cold migrate == resize but with no flavor change | 15:02 |
| stephenfin | sean-k-mooney: Yeah, that's my point. Why would a user think "oh, my migration failed. Best revert this resize" | 15:02 |
| sean-k-mooney | migrate is just syntactic sugar over resize really. | 15:03 |
| stephenfin | yeah | 15:03 |
| mriedem | note that a revert isn't to recover a failed move | 15:03 |
| mriedem | you can only revert if the resize/cold migration *didn't* fali | 15:03 |
| mriedem | *fail | 15:03 |
| stephenfin | Actually, yeah, I've done this in tests now that I think about | 15:03 |
| stephenfin | *it | 15:03 |
| stephenfin | (Or rather avoided doing it because confirming a resize/migration requires a lot of mocking out of libvirt stuff in functional tests that's not worth the effort) | 15:04 |
| stephenfin | mriedem: I think a '--revert' flag for the 'openstack server migrate' command would be helpful syntactic sugar. Any reason not to? | 15:05 |
| mriedem | if you're concerned about docs, you could update the description on https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#server-migrate to talk about how after a successful cold migration you need to revert or confirm the migration and which commad does that | 15:05 |
| stephenfin | I can do that too, sure | 15:05 |
| mriedem | idk, ask dean. one reason could be someone thinking they could revert a live migration since that's built into the same command. | 15:05 |
| Nick_A | sorry if this is not the right place - we have a kvm compute with qcow2, but snapshots are being stored as raw. is there a setting we're overlooking to take snapshots as qcow2? | 15:05 |
| mriedem | but that's likely solved with a good description of the parameter and validation in the command. | 15:05 |
| stephenfin | I'm annoyed that I work on this stuff and _I_ wasn't able to find information about this easily. That seems...silly :) | 15:05 |
| stephenfin | Yeah, we already have that issue for other flags so this is just one more | 15:06 |
| mriedem | Nick_A: probably this https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.force_raw_images | 15:06 |
| Nick_A | thank you, looking | 15:07 |
| mriedem | Nick_A: I think glance also has an option to convert everything to raw | 15:07 |
| stephenfin | Okay, I'll start on that. Thanks for the clarification, mriedem, sean-k-mooney | 15:07 |
| sean-k-mooney | stephenfin: there are some docs here too https://github.com/openstack/nova/blob/master/doc/source/admin/migration.rst | 15:08 |
| mriedem | Nick_A: I think this https://docs.openstack.org/glance/latest/configuration/glance_api.html#taskflow_executor.conversion_format | 15:09 |
| sean-k-mooney | stephenfin: we show we use "openstack server resize --confrim" to confrim the migration but not how to revert | 15:09 |
| Nick_A | thank you | 15:09 |
| stephenfin | sean-k-mooney: Sweet, I'll fix that too and add some some 'migrate --confirm' syntactic sugar for good measure | 15:10 |
| *** hongbin has joined #openstack-nova | 15:13 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Avoid unnecessary joins in InstanceGroup.get_hosts https://review.opendev.org/664271 | 15:15 |
| *** _alastor_ has quit IRC | 15:16 | |
| *** markvoelker has quit IRC | 15:16 | |
| *** ivve has quit IRC | 15:26 | |
| *** luksky has quit IRC | 15:34 | |
| dansmith | mriedem: are you going to update the pre-filter disabled computes spec? | 15:40 |
| dansmith | I assume gibi is on vacay or something and hasn't circled back, | 15:40 |
| dansmith | but I figure he's probably fine with it as long as we have a plan for that (which we do) | 15:40 |
| mriedem | dansmith: i was waiting for gibi | 15:41 |
| dansmith | okay | 15:42 |
| mriedem | what was the plan again? :) on disable, check if down and if down, return 200 (like if it was an old compute) and let upt sync the trait on restart of the service | 15:43 |
| *** helenafm has quit IRC | 15:43 | |
| mriedem | if that's the plan i can write that edge case into the spec | 15:44 |
| dansmith | yeah, always set compute.disabled=True, not make the rpc call if it's down, return 200 | 15:44 |
| mriedem | ok i can wordsmith that after tearing up artom's patch here | 15:44 |
| dansmith | by all means, prioritize tearing up anything of artom's | 15:44 |
| artom | ;_: | 15:44 |
| artom | (That's from both emotional and physical pain) | 15:45 |
| *** ericyoung has quit IRC | 15:48 | |
| aspiers | stephenfin: ok to add you to reviewers for a couple of SEV patches which need more core attention? they're not particularly big or complex | 15:48 |
| stephenfin | sure | 15:48 |
| aspiers | thanks! | 15:48 |
| *** ericyoung has joined #openstack-nova | 15:49 | |
| *** BlackDex has joined #openstack-nova | 15:52 | |
| *** wwriverrat has quit IRC | 15:53 | |
| *** itlinux has joined #openstack-nova | 15:54 | |
| *** itlinux has quit IRC | 15:56 | |
| *** _alastor_ has joined #openstack-nova | 15:58 | |
| *** itlinux has joined #openstack-nova | 16:00 | |
| mriedem | artom: sean-k-mooney: mdbooth: dansmith: comments in https://review.opendev.org/#/c/644881/ | 16:00 |
| artom | Whoa, you weren't kidding about tearing up | 16:01 |
| mdbooth | Whoa! | 16:01 |
| mdbooth | mriedem: Thanks, btw | 16:01 |
| artom | sean-k-mooney, correct me if I'm wrong, but I don't believe "The bigger issue I have is the concern that we could have a server with both ovs hybrid plugged ports and ports without that" is possible | 16:02 |
| sean-k-mooney | it is only posible if you have ovs +sriov ports | 16:03 |
| sean-k-mooney | e.g. if they are all ovs ports then it would all be hybrid_plug true or false | 16:03 |
| artom | sean-k-mooney, ah, so ports on which the firewall driver that causes hybrid plug to be used doens't apply | 16:03 |
| sean-k-mooney | but if you have some vswitch prot for say managmenet and some sriov ports for the data plane then you could have a mixx | 16:04 |
| artom | (https://review.opendev.org/#/c/660782/6/playbooks/legacy/nova-multinode/run.yaml@55) | 16:04 |
| sean-k-mooney | right so if you are using sriov there is no firewall | 16:06 |
| artom | So... do we need to handle that? Ie, wait for hybrid plugged ports in the compute manager, and for the sriov ones in the virt driver? | 16:06 |
| artom | Or is there no vif to plug for the latter case, so it's irrelevant? | 16:06 |
| mriedem | or will you get an event regardless b/c of the port binding change, in which case you don't need to filter on ovs hybrid plug in the compute manager | 16:07 |
| sean-k-mooney | that is a good question there should be a vif plugged in that case | 16:07 |
| sean-k-mooney | so i guess we would | 16:07 |
| mriedem | which would take this change back to when artom, dansmith and i talked about it on hangouts 2 months ago | 16:07 |
| sean-k-mooney | we would get an event for the sriov port | 16:09 |
| artom | *sigh* | 16:09 |
| artom | I suppose we better test it | 16:10 |
| sean-k-mooney | but im trying to remeber when | 16:10 |
| sean-k-mooney | plug is a noop for sriov. it is handeled by libvirt. | 16:10 |
| artom | Actually, wait | 16:11 |
| artom | Is resizing an instance with SRIOV supported? | 16:11 |
| sean-k-mooney | yes | 16:11 |
| sean-k-mooney | its kind of buggy but yes | 16:11 |
| *** igordc has joined #openstack-nova | 16:12 | |
| sean-k-mooney | althogh https://review.opendev.org/#/q/topic:bug/1809095+(status:open+OR+status:merged) will fix the most recent one | 16:12 |
| *** markvoelker has joined #openstack-nova | 16:13 | |
| sean-k-mooney | this is concerning https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py#L131-L143 | 16:16 |
| artom | I suppose I could hax _get_neutron_events_for_migration() to be smart about what vifs it returns... | 16:16 |
| artom | That seems fragile as hell, event more than the patch in its current form | 16:16 |
| sean-k-mooney | if the the prot is a PF https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py#L163-L168 | 16:16 |
| sean-k-mooney | we will send the event when we update the binding | 16:17 |
| sean-k-mooney | if the port if a vf we will send the event when the agent wires it up | 16:17 |
| artom | At point do we just say screw it and start queuing reveived events? | 16:18 |
| artom | *At what | 16:18 |
| artom | Or unload all those problems on Neutron and tell them to send the events consistently? | 16:18 |
| sean-k-mooney | well https://review.opendev.org/#/c/645173/ is ment to help with this | 16:19 |
| artom | Because assuming what sean-k-mooney is saying is True (and I have no reason to doubt it, but it def needs testing), we now have 3 different port "types" that we need to be aware of | 16:19 |
| sean-k-mooney | but i have not been working on it because of other stuff like RDT/CAT | 16:19 |
| artom | sean-k-mooney, yeah, but depending on that spec would make the Nova patch unbackportable, which I'm trying to avoid | 16:20 |
| artom | (Never mind that it would take forever | 16:21 |
| artom | ) | 16:21 |
| sean-k-mooney | right also i have not had time to work on it for a month and likely wont in the short term as i have nto figured out how to expresss when the event will be sent yet in an abstct way | 16:21 |
| artom | I guess "do what we did before (wait in libvirt), except for known cases where it doesn't work and we have to do new thing (wait in compute manager)" would be a valid guiding principle | 16:22 |
| artom | I'm gonna go get lunch, then try and see if I can code that in a palatable way | 16:23 |
| sean-k-mooney | you would have to wait if hybrid_plug=true or vnic_type=direct-physical | 16:23 |
| sean-k-mooney | in the manager | 16:23 |
| sean-k-mooney | else waith in the driver | 16:23 |
| artom | sean-k-mooney, so, that latter part hasn't actually come up (yet?), so I don't think I want to include it | 16:23 |
| artom | But I'm going to try to genericize my _uses_hybrid_plug() method a bit to make it extensible | 16:24 |
| sean-k-mooney | we could fix sriov in a sperate patch? | 16:24 |
| sean-k-mooney | artom: mriedem thoughts ^ | 16:24 |
| artom | ... and also do as yet unclear things to allow the compute manager to communicate to the virt driver *which VIFs* it needs to listen to events for | 16:25 |
| artom | Or some other way of achieving the same effect | 16:25 |
| sean-k-mooney | artom: we would need to be able to express on a per vf bassis if we should wait which is what i want to do with that sepec anyway | 16:25 |
| artom | sean-k-mooney, yeah, it's basically the same, just without the Neutron part | 16:25 |
| sean-k-mooney | we would have to embed logcici into the vif object to encode "wait in dirver" or what ever instead of using a flag for all vifs yes | 16:26 |
| artom | sean-k-mooney, that's not going to be backportable either, is it? | 16:27 |
| sean-k-mooney | the vif "objects" we store in the networkin info cache are dicts so its not versioned | 16:28 |
| efried | stephenfin: I've got a permalink in nova docs | 16:28 |
| efried | https://opendev.org/openstack/nova/blame/commit/1316c1c2850d2f966f335b628f7f5fe88cef611c/doc/source/user/flavors.rst#L776 | 16:28 |
| efried | that I want to use from a reno. How do I do that? | 16:28 |
| sean-k-mooney | but i would have to check the code to determin that | 16:29 |
| efried | stephenfin: I don't think I can just use extra-specs-numbered-resource-groupings_ - because the renos and the docs are in separate repositories? | 16:29 |
| mriedem | efried: https://docs.openstack.org/nova/latest/user/flavors.html#extra-specs-numbered-resource-groupings | 16:29 |
| mriedem | unless nova-doc works in reno builds | 16:29 |
| stephenfin | efried: https://docs.openstack.org/nova/latest/user/flavors.html#extra-specs-numbered-resource-groupings | 16:30 |
| stephenfin | yeah | 16:30 |
| stephenfin | it doesn't because release note builds aren't versioned | 16:30 |
| efried | stephenfin: mriedem: Right, so I have to use the whole URL, okay. Thanks. | 16:30 |
| artom | sean-k-mooney, oh, those VIFs. Well, we have what we need already, no? ovs_hybrid_plug and type | 16:30 |
| sean-k-mooney | artom: ya the vif you are using in that code is an instance of nova.network.model.Vif https://github.com/openstack/nova/blob/master/nova/network/model.py#L380 | 16:30 |
| sean-k-mooney | yes we do | 16:30 |
| *** davidsha has quit IRC | 16:31 | |
| sean-k-mooney | but if you wanted to add a flag so you did not check bot of those you could add a property to that class that return a vlaue base on if ether of the dict values were set | 16:31 |
| sean-k-mooney | e.g. put the logic to wait into the Vif class and have a property "wait_location" that return "driver" or "manager" based on the vnic_type or hybrid_plug | 16:32 |
| sean-k-mooney | artom: like https://github.com/openstack/nova/blob/master/nova/network/model.py#L461 | 16:32 |
| sean-k-mooney | i guess it could be just a fuction too | 16:33 |
| aspiers | efried: according to the SEV spec, our current plan is to add hw:mem_encryption to flavor extra specs and image properties, but I've just noticed that while existing extra specs params use the "hw:" prefix, image properties all use the "hw_" prefix. Presumably I should remain consistent with those conventions? | 16:33 |
| artom | sean-k-mooney, not sure about putting logic in the model itself, but yeah, it's an idea | 16:33 |
| mriedem | sean-k-mooney: so as it stands, artom's patch will do: | 16:34 |
| sean-k-mooney | artom: well we have is_hybrid_plug_enabled in the Vif object | 16:34 |
| mriedem | 1. if all ports are ovs_hybrid_plug=True, wait for all in the manager and you're fine, | 16:34 |
| artom | 0. drive artom to even moar excessive alcoholism | 16:34 |
| mriedem | 2. if all ports are ovs_hybrid_plug=false, wait in the driver and you're fine (tested in the gate), | 16:34 |
| artom | sean-k-mooney, yeah, but that's basically just a getter | 16:34 |
| mriedem | 3. if some ports are ovs_hybrid_plug=True but not all, we'll wait for all events for all ports in the manager and some might not come (at least direct-physical) | 16:35 |
| *** ricolin has quit IRC | 16:35 | |
| *** udesale has quit IRC | 16:35 | |
| sean-k-mooney | mriedem: correctr | 16:35 |
| mriedem | ok so based on #3, | 16:35 |
| mriedem | what if we only wait for the known ones in the manager (ovs_hyrbid_plug=True), | 16:36 |
| *** gyee has joined #openstack-nova | 16:36 | |
| sean-k-mooney | direct-pysical will be the same as ovs_hyrbid_plug=True | 16:36 |
| mriedem | and if there are others, we pass vifs_already_plugged=False to the driver? that would fail in the ovs_hybrid_plug=true ports b/c we already processed that event yeah? | 16:36 |
| *** takamatsu has quit IRC | 16:36 | |
| sean-k-mooney | vnic_type=direct and macvatap are teh same as ovs_hyrbid_plug=False and will arrive at the dirver | 16:36 |
| sean-k-mooney | mriedem: yes it would fail for ovs_hyrbid_plug=True because we already processed it | 16:37 |
| mriedem | i'm trying to get at some best effort kind of logic if we don't have good enough details from neutron and when we get the events from neutron is inconsistent per backend (which we know it is) | 16:37 |
| mriedem | thinking like, compute manager waits for all that are ovs_hybrid_plug=True and if there are others (a mix), we pass vifs_already_plugged=True so the driver doesn't wait | 16:38 |
| sean-k-mooney | if we get a mix we could just not wait at all or wait wait for the ones we expect in the manager and not wait in the driver | 16:38 |
| mriedem | yup i just said the same | 16:38 |
| sean-k-mooney | ya that would work | 16:39 |
| sean-k-mooney | its technically racy but its better then what we have today | 16:39 |
| sean-k-mooney | but i also think it would be simple to have the driver check if it should wait per vif | 16:39 |
| mriedem | in the #2 case where none of the ports are ovs_hybrid_plug=True, we'd pass vifs_already_plugged=false to the driver and assume the driver will wait and get all of the events after it plugs | 16:39 |
| sean-k-mooney | instead of needing to set teh flag | 16:39 |
| sean-k-mooney | yep | 16:39 |
| sean-k-mooney | 1 and 2 are easy | 16:40 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Defaults missing group_policy to 'none' https://review.opendev.org/657796 | 16:40 |
| sean-k-mooney | but we really shoudl be checking "ovs_hyrbid_plug=True or vnic_type=direct-physical" | 16:41 |
| mriedem | how many different types of vifs are in the wild? | 16:41 |
| sean-k-mooney | technically its a finite set defiend in neutron lib | 16:41 |
| sean-k-mooney | but not all backend will treat them all the same | 16:41 |
| mriedem | i just kind of vomit in my mouth a bit when we try encoding this in nova | 16:41 |
| efried | aspiers: Yes | 16:41 |
| sean-k-mooney | mriedem: ya i know it sucks | 16:42 |
| artom | mriedem, we really shouldn't have to in theory | 16:42 |
| artom | But reality and all that | 16:42 |
| efried | aspiers: And if you're collecting a spec tweak fup patch, clarify in there. | 16:42 |
| sean-k-mooney | for what its worth however i think we can encode it here in a new 3 line function https://github.com/openstack/nova/blob/master/nova/network/model.py#L461 | 16:42 |
| artom | sean-k-mooney, yeah, that part's not hard | 16:43 |
| artom | It's how we use it that I'm fuzzier on | 16:43 |
| artom | Ie, split events to be waited for between compute and libvirt | 16:43 |
| artom | I'm making an executing decision: ph00d, then hax. A patch, even broken WIP, is better than endless discussion | 16:44 |
| mriedem | i'm not terribly comfortable in backporting something that gets this complicated especially since we don't test any of these vif types in the gate | 16:44 |
| sean-k-mooney | e.g. def wait_in_manager(self): | 16:44 |
| sean-k-mooney | retrun self.is_hybrid_plug_enabled or self.get("vnic_type") == "direct-physical" | 16:44 |
| mriedem | artom: hacking something up that you do'nt have agreement on from the people reviewing it isn't going to speed this up | 16:45 |
| sean-k-mooney | then in the manager an driver we just do if vif.wait_in_manager(): | 16:45 |
| artom | mriedem, I thought we kinda did? | 16:45 |
| mriedem | how about, 1. artom gets food, 2. sean comments on the change | 16:45 |
| mriedem | 3. artom digests both | 16:45 |
| artom | mriedem, for backporting, if we split the patch and only backport the hybrid stuff? | 16:45 |
| artom | Leaving the SRIOV stuff for master only | 16:45 |
| *** markvoelker has quit IRC | 16:46 | |
| *** takamatsu has joined #openstack-nova | 16:46 | |
| sean-k-mooney | artom: or we can backport this downstream only if we really have to | 16:46 |
| sean-k-mooney | but ill comment on the review i think we can make this simpler | 16:46 |
| *** whoami-rajat has quit IRC | 16:46 | |
| artom | sean-k-mooney, it's always an option, but not my first one, obviously | 16:46 |
| sean-k-mooney | i think if we only fix it for ovs we will get a bug report form a different custoemr for sriov | 16:47 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document how to revert, confirm a cold migration https://review.opendev.org/664396 | 16:47 |
| sean-k-mooney | so we will have to fix both eventually | 16:47 |
| artom | sean-k-mooney, yeah, and that's fine, and we can address it later | 16:47 |
| artom | Especially since it'd be as simple as adding a check to that 3-line method of yours :) | 16:47 |
| artom | We could even do it now in a fup patch, and backport if/when some testing happens | 16:48 |
| sean-k-mooney | its actully 2 lines :P untill we have pep8 it | 16:48 |
| artom | *fup patch now | 16:48 |
| artom | (Though realistically it shouldn't merge until if/when some testing happens :) | 16:49 |
| *** cfriesen has joined #openstack-nova | 16:52 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Deprecate RetryFilter https://review.opendev.org/663953 | 17:02 |
| *** ociuhandu has quit IRC | 17:05 | |
| openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Change new image property to hw_mem_encryption https://review.opendev.org/664397 | 17:06 |
| *** lpetrut has joined #openstack-nova | 17:09 | |
| *** mvkr has quit IRC | 17:12 | |
| *** takamatsu has quit IRC | 17:15 | |
| *** lpetrut has quit IRC | 17:18 | |
| *** luksky has joined #openstack-nova | 17:20 | |
| *** itlinux has quit IRC | 17:25 | |
| aspiers | efried: should I hold off including doc change fragments covering SEV support until the whole series lands? | 17:26 |
| efried | aspiers: "doc change fragments" in the spec or in the codebase? | 17:27 |
| aspiers | codebase | 17:27 |
| aspiers | otherwise there's a risk of documenting stuff which doesn't work yet | 17:27 |
| aspiers | especially if it didn't all land before Train | 17:27 |
| efried | Right, those go in in the patch that flips the switch that makes it work. | 17:27 |
| aspiers | OK thanks | 17:27 |
| efried | docs & reno etc. | 17:27 |
| aspiers | Yup | 17:27 |
| *** itlinux has joined #openstack-nova | 17:29 | |
| *** itlinux has quit IRC | 17:31 | |
| *** ralonsoh has quit IRC | 17:33 | |
| *** itlinux has joined #openstack-nova | 17:35 | |
| *** takamatsu has joined #openstack-nova | 17:36 | |
| *** amodi has quit IRC | 17:40 | |
| *** markvoelker has joined #openstack-nova | 17:43 | |
| *** takamatsu has quit IRC | 17:43 | |
| *** spatel has joined #openstack-nova | 17:45 | |
| spatel | sean-k-mooney: is there anyway to stop migration instance? I have initiate block migration and i want to cancel it | 17:45 |
| sean-k-mooney | spatel: as in cancel a livemigration | 17:46 |
| sean-k-mooney | i think we have a way too | 17:46 |
| sean-k-mooney | let me check | 17:46 |
| sean-k-mooney | i know people have asked for it before | 17:46 |
| spatel | i didn't find any command line option or GUI option | 17:46 |
| sean-k-mooney | well what you can do with crul directly to the api is > then the clis enable | 17:47 |
| sean-k-mooney | i dont know if we ever landed the force complete and force abourt apis however | 17:47 |
| spatel | ? | 17:47 |
| sean-k-mooney | we dont always get around to adding everyting that the api support to the command line clients | 17:48 |
| sean-k-mooney | or somethimes it takes a while | 17:48 |
| spatel | what if i kill TCP connection which is transferring disk | 17:49 |
| sean-k-mooney | spatel: you can abort it via libvirt using virsh | 17:49 |
| sean-k-mooney | spatel: so ya it looke like you can use the old nova cli | 17:50 |
| sean-k-mooney | nova live-migration-abort INSTANCE_ID MIGRATION_ID or nova live-migration-force-complete INSTANCE_ID MIGRATION_ID | 17:51 |
| sean-k-mooney | spatel: https://docs.openstack.org/nova/pike/admin/live-migration-usage.html#addressing-migration-timeouts | 17:51 |
| sean-k-mooney | spatel: nova live-migration-abort is what you are looking for. | 17:52 |
| spatel | let me see | 17:52 |
| sean-k-mooney | you need the instance id + the migration_id for the currently running migration | 17:52 |
| sean-k-mooney | you get the migration id by doing "nova server-migration-list <server/instance uuid>" | 17:53 |
| spatel | how do i find MIGRATION_ID? | 17:54 |
| sean-k-mooney | spatel: ^ :) | 17:54 |
| sean-k-mooney | spatel: its covered in the monitoring migration part of that doc https://docs.openstack.org/nova/pike/admin/live-migration-usage.html#monitoring-the-migration | 17:54 |
| spatel | reading it.. | 17:55 |
| sean-k-mooney | does that make sense you do "nova server-migration-list <server id>" | 17:57 |
| sean-k-mooney | then that give you the list of migrations. | 17:57 |
| sean-k-mooney | then if you have more then one you use nova server-migration-show <server uuid > <migration id> | 17:58 |
| sean-k-mooney | to see which one was the most recent | 17:58 |
| sean-k-mooney | and then that one is the migration you want to canchel with | 17:58 |
| sean-k-mooney | nova live-migration-abort INSTANCE_ID MIGRATION_ID | 17:58 |
| spatel | nova server-migration-list <server id> this is showing nothing about migration except saying | OS-EXT-STS:task_state | resize_migrating | 18:00 |
| -spatel- [root@ostack-osa ~(keystone_admin)]# openstack server show 580e624f-d1c9-496c-a591-a36c2de92e62 | grep mig | 18:00 | |
| -spatel- | OS-EXT-STS:task_state | resize_migrating | 18:00 | |
| spatel | i am not seeing any ID... | 18:00 |
| *** psachin has quit IRC | 18:02 | |
| *** itlinux has quit IRC | 18:03 | |
| sean-k-mooney | spatel: am can you past the output to paste.openstack.org. feel free to remove anything sensitive | 18:04 |
| *** mgariepy has quit IRC | 18:04 | |
| sean-k-mooney | nova server-migration list shoudl vice you an output that start with Id | Source Node | Dest Node .... | 18:04 |
| sean-k-mooney | the Id colum is the migration id | 18:05 |
| spatel | hmm | 18:06 |
| *** mgariepy has joined #openstack-nova | 18:07 | |
| spatel | http://paste.openstack.org/show/752693/ | 18:09 |
| spatel | sean-k-mooney: ^^ | 18:09 |
| sean-k-mooney | spatel: openstack server show not migration list | 18:09 |
| *** itlinux has joined #openstack-nova | 18:09 | |
| sean-k-mooney | do "nova migration-list --instance-uuid 580e624f-d1c9-496c-a591-a36c2de92e62 | 18:10 |
| sean-k-mooney | " | 18:10 |
| spatel | I can see lots of info npw | 18:11 |
| spatel | now | 18:11 |
| *** itlinux has quit IRC | 18:11 | |
| sean-k-mooney | ok do you have more then 1 row | 18:11 |
| sean-k-mooney | if not you just need the value of the ID colum | 18:11 |
| *** itlinux has joined #openstack-nova | 18:12 | |
| sean-k-mooney | then you can do "nova live-migration-abort 580e624f-d1c9-496c-a591-a36c2de92e62 <id> | 18:12 |
| sean-k-mooney | " | 18:12 |
| spatel | http://paste.openstack.org/show/752695/ | 18:12 |
| spatel | sean-k-mooney: ^6 | 18:12 |
| sean-k-mooney | ya so it would be | 18:13 |
| spatel | is that UUID is migration ID? | 18:13 |
| sean-k-mooney | "nova live-migration-abort 580e624f-d1c9-496c-a591-a36c2de92e62 384" | 18:13 |
| sean-k-mooney | mp Id | 18:13 |
| sean-k-mooney | *no | 18:13 |
| sean-k-mooney | it the first column | 18:13 |
| sean-k-mooney | the UUID column is the instance uuid | 18:13 |
| *** itlinux has quit IRC | 18:13 | |
| spatel | to abort it i need migration ID right ( that i not able to find :( ) | 18:14 |
| *** itlinux has joined #openstack-nova | 18:14 | |
| sean-k-mooney | spatel: so as i said its call Id in the output | 18:14 |
| sean-k-mooney | so in this case it 384 and the command would be "nova live-migration-abort 580e624f-d1c9-496c-a591-a36c2de92e62 384" | 18:14 |
| spatel | 384 | 18:15 |
| sean-k-mooney | yep does that make sense | 18:15 |
| *** markvoelker has quit IRC | 18:17 | |
| *** mriedem has quit IRC | 18:17 | |
| sean-k-mooney | the migration has a UUID also but which is the firt UUID column i miss typed earlirer but the id colume "384" is what you were looking for. let me kno if that works for you :) | 18:18 |
| spatel | http://paste.openstack.org/show/752698/ | 18:19 |
| *** mriedem has joined #openstack-nova | 18:19 | |
| spatel | sean-k-mooney: ^^ | 18:19 |
| sean-k-mooney | ok so it looks like we dont allow you to abort if its already copying the guest memory... that seams weird | 18:20 |
| *** _alastor_ has quit IRC | 18:21 | |
| sean-k-mooney | spatel: are you doing a live migration or a cold migration | 18:21 |
| spatel | My compute nodes attached to shared storage. | 18:22 |
| spatel | so live migration isn't possible it has to be block migration | 18:22 |
| *** takamatsu has joined #openstack-nova | 18:22 | |
| sean-k-mooney | live migration is unrealted to shared storage | 18:22 |
| spatel | my compute nodes **NOT** attached to shared storage | 18:22 |
| sean-k-mooney | and if you are on shared storage you do not use block migration | 18:22 |
| sean-k-mooney | ah | 18:22 |
| sean-k-mooney | what command did you use to start the migration | 18:23 |
| spatel | Oh! wait.. i though live migration only possible when you are using shared storage like ceph | 18:23 |
| sean-k-mooney | no you can do live migration with block storage too | 18:23 |
| sean-k-mooney | we just rsync the disk image to the destaion | 18:23 |
| spatel | I didn't do anything, someone else just drop down in horizon and said "live migrate" | 18:23 |
| sean-k-mooney | or rather libvirt does | 18:23 |
| sean-k-mooney | ah ok just making sure its a live migration | 18:24 |
| spatel | I meant "Migrate instance" option in GUI | 18:24 |
| sean-k-mooney | ok so that is different | 18:24 |
| spatel | what is the difference between | 18:24 |
| *** whoami-rajat has joined #openstack-nova | 18:24 | |
| sean-k-mooney | the instance is shutdown http://paste.openstack.org/show/752693/ | 18:24 |
| sean-k-mooney | so its doing a cold or offline migration | 18:24 |
| spatel | "Migrate instance" vs "Live migration" in GUI drop down? | 18:24 |
| sean-k-mooney | migrate instance in horizon i think is a cold migration | 18:25 |
| sean-k-mooney | i would have to double check. | 18:25 |
| spatel | We powered down machine before migration (its safe) | 18:25 |
| *** takamatsu has quit IRC | 18:25 | |
| sean-k-mooney | well live migration are only done if the vm is running | 18:25 |
| *** takamatsu has joined #openstack-nova | 18:25 | |
| sean-k-mooney | that what makes the a live migration | 18:26 |
| sean-k-mooney | so the api i asked you to try is only used for live migration but you are doing a cold migration | 18:26 |
| spatel | I talled to you couple month back NOVA has bug which doesn't copy full disk and that cause instance never get full migrate... | 18:26 |
| spatel | I am worried about that bug... (someone did migration without checking with me) now i want to stop this :( | 18:26 |
| sean-k-mooney | i vaguly rememeber that yes | 18:26 |
| sean-k-mooney | mriedem: is there any way to stop a cold migration that is in flight? | 18:27 |
| *** priteau has quit IRC | 18:27 | |
| sean-k-mooney | mriedem: can we revert it | 18:27 |
| mriedem | nope | 18:27 |
| spatel | nova start block migration and then kill it source disk without verifying full disk migration.. that was the bug | 18:27 |
| sean-k-mooney | when the instance is in task_sate resize_migrating | 18:27 |
| sean-k-mooney | mriedem: what about reseting the state on the vm? | 18:28 |
| *** nicolasbock has quit IRC | 18:29 | |
| *** nicolasbock has joined #openstack-nova | 18:29 | |
| mriedem | sean-k-mooney: that would reset the task_state to None so you'd maybe fail somewhere along the way in compute if it tries to update the task_state and is using instance.save(expected_task_state=...) | 18:29 |
| mriedem | but clearly that's not any kind of supported way to interrupt a cold migration | 18:30 |
| *** priteau has joined #openstack-nova | 18:30 | |
| sean-k-mooney | mriedem: yes i know | 18:30 |
| *** _alastor_ has joined #openstack-nova | 18:30 | |
| spatel | cold migration = when machine is shutdown it does cold migration ? | 18:30 |
| spatel | is that true? | 18:31 |
| sean-k-mooney | spatel: by machine you mean the vm? | 18:31 |
| mriedem | NTT (i think it was NTT) had a spec up for several releases to add support to abort a cold migration, with the main reason being "we shove logs into a 100GB+ local disk and migrating those VMs takes a long time so we'd maybe like to abort the cold migration" | 18:31 |
| spatel | yes machine = VM | 18:31 |
| sean-k-mooney | mriedem: ya i vaguly rememebr that | 18:31 |
| sean-k-mooney | spatel: do you have nova configured to auto confim migrations/resize | 18:32 |
| sean-k-mooney | spatel: if not then nova will not delete the souce disk unless you confim the resize. | 18:32 |
| spatel | NO i don't have auto confim | 18:33 |
| sean-k-mooney | at which point you can either boot up the vm and check its ok or you can do "nova resize-revert <server uuid>" | 18:33 |
| spatel | oh! can i boot instance without confirm ? | 18:33 |
| sean-k-mooney | i think so. i have not tried this in quite a while. | 18:34 |
| *** _alastor_ has quit IRC | 18:35 | |
| sean-k-mooney | maybe we cant but i know that has also been asked for in the past | 18:35 |
| sean-k-mooney | spatel: in anycase when the migration eventually complete you can revert it which will be quick as teh data will not have been delete on the souce node. | 18:36 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 18:36 |
| aspiers | efried: is this roughly along the right lines? ^^^ | 18:37 |
| spatel | i will revert it without confirm it | 18:38 |
| efried | aspiers: I'm going to have to look a bit later, I'm afraid. | 18:38 |
| *** amodi has joined #openstack-nova | 18:38 | |
| aspiers | efried: np. Don't need a full review yet, just confirmation I'm barking up the right tree | 18:38 |
| *** ivve has joined #openstack-nova | 18:39 | |
| *** tbachman has joined #openstack-nova | 18:43 | |
| *** cdent has quit IRC | 18:52 | |
| *** francoisp has quit IRC | 18:54 | |
| spatel | sean-k-mooney: revert works! | 18:55 |
| spatel | what a pain :) | 18:55 |
| spatel | sean-k-mooney: thank you again for saving my a... :) | 18:56 |
| *** bbowen has joined #openstack-nova | 19:03 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Spec to pre-filter disabled computes with placement https://review.opendev.org/657884 | 19:14 |
| *** markvoelker has joined #openstack-nova | 19:14 | |
| *** amodi has quit IRC | 19:21 | |
| *** ociuhandu has joined #openstack-nova | 19:43 | |
| *** markvoelker has quit IRC | 19:47 | |
| *** dave-mccowan has joined #openstack-nova | 19:48 | |
| *** eharney has quit IRC | 19:51 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 19:53 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Remove finish_revert_migration TypeError try/except https://review.opendev.org/664013 | 19:53 |
| *** tbachman has quit IRC | 19:53 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Include direct-physical in compute manager events check https://review.opendev.org/664431 | 19:53 |
| artom | sean-k-mooney, mriedem, ^^ did a thing. Still lots of cleanup to do, but maybe check the compute manager/libvirt driver parts to see if the general approach is palatable? | 19:53 |
| *** tbachman has joined #openstack-nova | 19:54 | |
| sean-k-mooney | that likely wont be backportable. due to the chagne in the signiture of finish_revert_migration or at least its more invasive then it needs to be | 19:59 |
| sean-k-mooney | still reading it | 19:59 |
| artom | finish_revert_migration was changed with the previous approach as well (was adding vifs_already_plugged) | 20:00 |
| sean-k-mooney | yes but we can actully make this work without adding any new parmater to finish_revert_migration | 20:01 |
| sean-k-mooney | if we take the approch i was suggesting. we actully did not need to pass vif_already_plugged | 20:01 |
| artom | Why is adding a parameter bad though? That's not RPC, don't think it'll affect backportability... | 20:02 |
| artom | It's compute manager talking to its virt driver, both are updated at the same time | 20:02 |
| sean-k-mooney | its chaning the virt dirver api right | 20:02 |
| artom | Yeah | 20:02 |
| sean-k-mooney | so it would break out of tree drivers without the try catch | 20:02 |
| artom | Well, yeah | 20:03 |
| sean-k-mooney | * try excpet | 20:03 |
| artom | I don't see a way around passing the virt driver *something* | 20:04 |
| sean-k-mooney | we have all the info we need in the network_info object since that is a list of vifs | 20:05 |
| sean-k-mooney | so we can calualte if we need to wait in the driver or manager form that without passing anything | 20:05 |
| sean-k-mooney | which is part of the reason i suggested adding the function in the vif model class | 20:05 |
| *** jaypipes has quit IRC | 20:06 | |
| *** jaypipes has joined #openstack-nova | 20:06 | |
| artom | The problem is that finish_revert_migration isn't always called for revert resize... | 20:07 |
| artom | So even if network_info has all it needs in terms of event "types" | 20:07 |
| artom | We still need a way to tell the virt driver when to actually use that information | 20:07 |
| sean-k-mooney | im not following | 20:08 |
| artom | All of this stuff, it's only applicable in the revert resize case, right? | 20:09 |
| sean-k-mooney | and revert migration yes | 20:09 |
| sean-k-mooney | *cold migration | 20:09 |
| artom | Is it? Does the instance remain shutoff on the source with the VIFs still wired while it's cold migrating? | 20:10 |
| sean-k-mooney | yes | 20:10 |
| sean-k-mooney | to both questions | 20:11 |
| artom | So, the only other instance of driver.finish_revert_migration that I've found is https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1001 | 20:11 |
| artom | So maybe you're right, driver.finish_revert_migration is called if and only iff we need to do the compute manager/virt driver events checking thing | 20:11 |
| sean-k-mooney | yes cold migration uses the resize_migrating task state | 20:11 |
| sean-k-mooney | right it only used in two case | 20:12 |
| sean-k-mooney | if we are migrating/resizing instance.task_state == task_states.RESIZE_MIGRATING | 20:13 |
| artom | So in that case yeah, we can stuff the logic inside the VIF model | 20:13 |
| sean-k-mooney | which is that auto rollback if things go wrong | 20:13 |
| artom | Kinda weird for something so specific to go in the model, but I guess it makes sense | 20:13 |
| sean-k-mooney | or if the user revert the migraion/resize form the api after we succeed in the migratio/resize instead of confiming | 20:13 |
| sean-k-mooney | artom: well i had planned to stuff the event info form neutron in that data stcutrue if we implement the spec in anycase | 20:14 |
| sean-k-mooney | artom: we can always add a untility module or make it a free fucntion if you like but i think the encapsulation makes sense | 20:16 |
| * artom just tried it - yeah, 'nova migrate' will leave the instance shutoff on the source | 20:16 | |
| artom | Until confirmed (or reverted) | 20:17 |
| sean-k-mooney | yep | 20:17 |
| sean-k-mooney | and we default to auto confirm disabled | 20:17 |
| sean-k-mooney | i more or less had this conversation with stephenfin and mriedem a few hours ago :) | 20:18 |
| artom | (Which is weird UX, btw - because you 'nova migrate', but then you 'nova resize-revert') | 20:18 |
| sean-k-mooney | yep we know :) | 20:18 |
| artom | Yeah, didn't think I was teaching anyone anything | 20:18 |
| *** francoisp has joined #openstack-nova | 20:19 | |
| sean-k-mooney | hehe its just funny to me because you are reiterating what stephenfin said more or less like 6 hours ago | 20:19 |
| artom | Better late than never, I suppose | 20:20 |
| sean-k-mooney | artom: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-06-10.log.html#t2019-06-10T14:53:27 :) | 20:20 |
| artom | *snerk* Yeah | 20:21 |
| sean-k-mooney | so are you open to trying to remove the api change to the driver api and filtering the events as i was suggesting ? it shoudl reduce the size of the patch a resonable amount | 20:24 |
| artom | sean-k-mooney, yeah | 20:24 |
| artom | Still opposed to passing 'revert' to _create_domain_and_network though :) | 20:25 |
| *** tbachman has quit IRC | 20:25 | |
| artom | But less oot driver pain is indeed better | 20:25 |
| *** amodi has joined #openstack-nova | 20:25 | |
| * artom h4x | 20:25 | |
| sean-k-mooney | well you might be able to tell form somthing else but why dont you like passing revert to _create_domain_and_network | 20:26 |
| sean-k-mooney | i dont think you replied to the commets did you? | 20:26 |
| * sean-k-mooney goes to look | 20:26 | |
| artom | It's higher up logic that should live higher up | 20:27 |
| artom | I kinda replied | 20:27 |
| artom | So what I came up with is passing a list of events to wait for | 20:27 |
| artom | I say higher up | 20:28 |
| sean-k-mooney | oh ok. am i guess you could generate that in the driver | 20:28 |
| sean-k-mooney | rather then pass it from teh compute manager | 20:28 |
| sean-k-mooney | that an internal api so it more ok to modify the the driver api as you wont break anything at that point | 20:29 |
| artom | Yeah, so really "higher up" means "more specific" | 20:29 |
| artom | Ie, finish_revert_migration knows we're doing a revert, _cdan has no idea, nor should it | 20:30 |
| sean-k-mooney | artom: dansmith raised a vaild point we need to make sure not to change livemigration behavior | 20:30 |
| sean-k-mooney | artom: oh and i just saw your top level comment regarding revert | 20:30 |
| *** pcaruana has quit IRC | 20:31 | |
| artom | sean-k-mooney, yeah, which is why I straight up added https://review.opendev.org/#/c/644881/24/nova/compute/manager.py@6499 | 20:31 |
| artom | I can probably just call it revert | 20:31 |
| artom | Because it also applied for reverting cold migrations | 20:32 |
| sean-k-mooney | ya you could rename the other one and add live | 20:32 |
| sean-k-mooney | actully no | 20:32 |
| sean-k-mooney | that is more work | 20:32 |
| sean-k-mooney | and its unrelated | 20:32 |
| artom | sean-k-mooney, where are you in Ireland again, btw? | 20:35 |
| sean-k-mooney | Shannon | 20:35 |
| sean-k-mooney | on the west coast more or less | 20:35 |
| artom | https://i.imgur.com/lqfeJZk.jpg West Coast! | 20:37 |
| * artom kinda wants to put the get_revert_events part into the compute manager virtapi | 20:39 | |
| sean-k-mooney | i was debating if it could go into the compute untils module | 20:39 |
| * artom is still bothered by putting it into the VIF model | 20:40 | |
| sean-k-mooney | so in here somewhere https://github.com/openstack/nova/blob/master/nova/compute/utils.py | 20:40 |
| sean-k-mooney | then you can use it for the driver or the compute manger | 20:40 |
| sean-k-mooney | and not put it in the vif if you dont like that | 20:40 |
| artom | It just feels so alien there | 20:40 |
| artom | It's business logic, after all, right? | 20:41 |
| artom | Really specific one at that | 20:41 |
| sean-k-mooney | i was not suggsting puting the event generation in teh VIF by the way | 20:41 |
| sean-k-mooney | jsut the function that says if it should wait in the manager or driver | 20:41 |
| artom | Well.... "is_manager_vif" or w/e you called it is basically the same logic :) | 20:41 |
| artom | It's not the generation part that I have issues with, it's that the VIF model suddenly understand the difference between compute manager and virt driver | 20:42 |
| sean-k-mooney | yes but if we get teh info form neutron in the future i can simply change the impliation of that method | 20:42 |
| artom | Anyways, we're ratholing :) | 20:42 |
| sean-k-mooney | and only for the revert resize case too | 20:43 |
| sean-k-mooney | so nova.compute.utils | 20:43 |
| sean-k-mooney | i think it qualifies as a """Compute-related Utilities and helpers.""" | 20:43 |
| *** eharney has joined #openstack-nova | 20:43 | |
| sean-k-mooney | that has things like is_volume_backed_instance | 20:44 |
| artom | Fair enough | 20:44 |
| *** spatel has quit IRC | 20:45 | |
| sean-k-mooney | you could put it in the virtapi i guess too | 20:45 |
| sean-k-mooney | if you did that then the manager would call the driver to get teh events | 20:46 |
| artom | Eh? | 20:46 |
| artom | How so? | 20:46 |
| sean-k-mooney | well were you thinking of making it a module level function or adding it to the driver interface | 20:46 |
| *** ociuhandu has quit IRC | 20:47 | |
| sean-k-mooney | virtapi is actuly just event stuff... | 20:47 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/virtapi.py | 20:47 |
| sean-k-mooney | i guess that would be fine too. | 20:48 |
| artom | This *is* event stuff :) | 20:49 |
| sean-k-mooney | ya i would be fine with adding it there | 20:49 |
| sean-k-mooney | i assummed wrongly that the base compute driver api would be defiended there but that is in driver.py | 20:50 |
| efried | aspiers: Reviewed. | 20:51 |
| aspiers | thanks! | 20:51 |
| sean-k-mooney | damn no wonder the libvirt virt driver is 5000 lines lon the base class is almost 2000 | 20:51 |
| *** tbachman has joined #openstack-nova | 20:55 | |
| *** mvkr has joined #openstack-nova | 20:57 | |
| *** tbachman has quit IRC | 20:57 | |
| *** tbachman has joined #openstack-nova | 21:07 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 21:12 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Include direct-physical in compute manager events check https://review.opendev.org/664431 | 21:12 |
| artom | sean-k-mooney, mriedem, ^^ | 21:13 |
| artom | And I think I need to head home at this point. | 21:13 |
| artom | Or potentially to daycare, if wife doesn't make it there in time :/ | 21:13 |
| sean-k-mooney | ack | 21:14 |
| sean-k-mooney | at first glance it certenly shorter | 21:14 |
| sean-k-mooney | if it fixes the issue even better ill take a look | 21:14 |
| artom | Well tests are missing | 21:14 |
| sean-k-mooney | details :) | 21:15 |
| mriedem | probably want to revive sean-k-mooney's dnm test patch to recreate the issue on top of this again if you changed the fix | 21:17 |
| sean-k-mooney | sure i can restroe it and rebase | 21:17 |
| sean-k-mooney | mriedem: did your change to tempest merge or shoudl i add a depense on to remvoe teh skip | 21:18 |
| *** artom has quit IRC | 21:19 | |
| mriedem | it's approved | 21:20 |
| mriedem | sorry, +2 | 21:20 |
| mriedem | but i'm not sure that matters for what you were testing, | 21:20 |
| mriedem | you could merge artom's patch to run the revert resize tests in the nova-live-migration job and add your ovs_hybrid_plug config | 21:20 |
| sean-k-mooney | well artom abandoned his chagne that ran the revert tests | 21:20 |
| mriedem | and you abandoned yours - just copy his stuff into your DNM change right? | 21:21 |
| sean-k-mooney | ya i could do that | 21:21 |
| *** priteau has quit IRC | 21:22 | |
| *** itlinux has quit IRC | 21:23 | |
| *** whoami-rajat has quit IRC | 21:24 | |
| openstackgerrit | sean mooney proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | 21:29 |
| sean-k-mooney | interesting... gerrit auto added artom to the comitt i jsut pushed and also aprently he is the author of ^ | 21:32 |
| sean-k-mooney | i didnt think i was ment to be allowed to that but whatever | 21:33 |
| *** tbachman_ has joined #openstack-nova | 21:35 | |
| *** tbachman has quit IRC | 21:35 | |
| *** tbachman_ is now known as tbachman | 21:35 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.opendev.org/614012 | 21:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | 21:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | 21:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269 | 21:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656 | 21:44 |
| *** panda has quit IRC | 21:58 | |
| *** panda has joined #openstack-nova | 22:01 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: fup: Remove unused mock in libvirt functional base https://review.opendev.org/664449 | 22:01 |
| *** mriedem has quit IRC | 22:08 | |
| *** mlavalle has quit IRC | 22:12 | |
| *** spatel has joined #openstack-nova | 22:12 | |
| *** spatel has quit IRC | 22:17 | |
| *** artom has joined #openstack-nova | 22:33 | |
| *** efried has quit IRC | 22:39 | |
| *** hongbin has quit IRC | 22:40 | |
| *** efried has joined #openstack-nova | 22:41 | |
| *** markvoelker has joined #openstack-nova | 22:44 | |
| redkrieg | I'm trying to get my nova instances to not use a backing file so I can remove images from _base. for some reason even when I set use_cow_images=False I still have _base backed instances. Is there some new config for this feature? I'm using info from here: https://www.pixelbeat.org/docs/openstack_libvirt_images/ | 22:47 |
| *** tkajinam has joined #openstack-nova | 22:53 | |
| *** tkajinam has quit IRC | 22:53 | |
| *** tkajinam has joined #openstack-nova | 22:55 | |
| redkrieg | nevermind, I had images_type under [libvirt] set to qcow2 instead of default | 22:56 |
| *** rcernin has joined #openstack-nova | 23:04 | |
| *** rcernin_ has joined #openstack-nova | 23:05 | |
| *** rcernin has quit IRC | 23:09 | |
| *** slaweq has joined #openstack-nova | 23:10 | |
| *** luksky has quit IRC | 23:13 | |
| *** markvoelker has quit IRC | 23:18 | |
| *** slaweq has quit IRC | 23:19 | |
| *** sorrison has quit IRC | 23:34 | |
| *** takashin has joined #openstack-nova | 23:37 | |
| *** factor has quit IRC | 23:42 | |
| *** icarusfactor has joined #openstack-nova | 23:42 | |
| *** threestrands has joined #openstack-nova | 23:44 | |
| *** factor__ has joined #openstack-nova | 23:49 | |
| *** factor__ has quit IRC | 23:51 | |
| *** icarusfactor has quit IRC | 23:52 | |
| *** factor has joined #openstack-nova | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
