Wednesday, 2019-05-29

« Tuesday, 2019-05-28 Index Thursday, 2019-05-30 »
*** jaypipes has quit IRC00:09
*** slaweq has joined #openstack-nova00:11
*** takashin has joined #openstack-nova00:17
*** hamzy has joined #openstack-nova00:20
*** slaweq has quit IRC00:24
*** brinzhang has joined #openstack-nova00:27
*** dave-mccowan has joined #openstack-nova00:32
*** markvoelker has quit IRC00:33
*** dave-mccowan has quit IRC00:35
*** efried has quit IRC00:37
*** ricolin_ has joined #openstack-nova00:44
*** efried has joined #openstack-nova00:45
*** wwriverrat has quit IRC00:48
openstackgerritTony Breeds proposed openstack/nova stable/queens: Delete allocations even if _confirm_resize raises  https://review.opendev.org/65215300:50
openstackgerritTony Breeds proposed openstack/nova stable/queens: [stable-only] Delete allocations even if _confirm_resize raises (part 2)  https://review.opendev.org/66134900:52
openstackgerritTony Breeds proposed openstack/nova stable/queens: Add functional confirm_migration_error test  https://review.opendev.org/65813600:54
*** itlinux has joined #openstack-nova00:55
*** minmin has joined #openstack-nova01:07
*** tetsuro has joined #openstack-nova01:12
*** slaweq has joined #openstack-nova01:16
*** guozijn has joined #openstack-nova01:19
openstackgerritYikun Jiang proposed openstack/nova master: Fix the server group "policy" field type in api-ref  https://review.opendev.org/66186901:19
yikun^ mriedem, Yes, I think it's a api-ref bug. And I also saw why it happened: it came from original patch PS31~32 [1], the policy code had been change from "object" to "string", but I forgot to change the api-ref together.01:20
yikun[1] https://review.opendev.org/#/c/567534/31..32/doc/api_samples/os-server-groups/v2.64/server-groups-post-req.json01:20
*** slaweq has quit IRC01:24
*** itlinux has quit IRC01:37
*** itlinux has joined #openstack-nova01:45
*** boxiang has joined #openstack-nova01:45
*** hongbin has quit IRC01:51
*** itlinux has quit IRC01:56
*** Spencer_Yu has joined #openstack-nova01:57
*** BjoernT has joined #openstack-nova02:08
*** BjoernT has quit IRC02:08
*** slaweq has joined #openstack-nova02:11
*** BjoernT has joined #openstack-nova02:22
*** bbowen has joined #openstack-nova02:24
*** slaweq has quit IRC02:25
*** itlinux has joined #openstack-nova02:25
*** BjoernT_ has joined #openstack-nova02:27
*** BjoernT has quit IRC02:29
*** markvoelker has joined #openstack-nova02:34
*** JamesBenson has joined #openstack-nova02:44
*** tetsuro has quit IRC02:45
*** cfriesen has quit IRC02:47
*** tetsuro has joined #openstack-nova02:51
*** tetsuro has quit IRC02:55
*** tetsuro has joined #openstack-nova02:55
openstackgerritGuo Jingyu proposed openstack/nova master: Define and catch QemuGuestAgentNotRunning for set-password failure  https://review.opendev.org/66146602:57
*** lbragstad has quit IRC02:58
*** BjoernT_ has quit IRC03:00
*** tetsuro has quit IRC03:01
*** panda|ruck has quit IRC03:03
*** panda has joined #openstack-nova03:03
*** markvoelker has quit IRC03:08
*** tetsuro has joined #openstack-nova03:09
*** slaweq has joined #openstack-nova03:11
*** tetsuro has quit IRC03:12
*** tetsuro has joined #openstack-nova03:20
*** tetsuro has quit IRC03:24
*** slaweq has quit IRC03:25
openstackgerritguangchao.pan proposed openstack/nova master: Add a name for the automatically created volume  https://review.opendev.org/66009603:25
*** threestrands has joined #openstack-nova03:31
*** igordc has quit IRC03:40
*** altlogbot_0 has quit IRC03:44
*** altlogbot_3 has joined #openstack-nova03:45
*** psachin has joined #openstack-nova03:48
*** minmin has quit IRC03:49
*** ykarel|away has joined #openstack-nova03:53
*** ykarel|away has quit IRC03:53
*** ykarel|away has joined #openstack-nova03:55
*** ykarel|away has quit IRC03:55
openstackgerritMerged openstack/nova master: Use run_immediately=True for _cleanup_running_deleted_instances  https://review.opendev.org/65713203:56
openstackgerritMerged openstack/nova master: Remove 'instance_update_from_api'  https://review.opendev.org/65130203:56
openstackgerritMerged openstack/nova master: Stop handling 'update_cells' on 'BandwidthUsage.create'  https://review.opendev.org/65130303:56
openstackgerritMerged openstack/nova master: Stop handling cells v1 for instance naming  https://review.opendev.org/65130403:56
openstackgerritMerged openstack/nova master: Remove cells code  https://review.opendev.org/65130603:56
openstackgerritMerged openstack/nova master: Remove conductor_api and _last_host_check from manager.py  https://review.opendev.org/65105903:56
openstackgerritMerged openstack/nova master: Remove 'etc/nova/cells.json'  https://review.opendev.org/66014603:57
*** tetsuro has joined #openstack-nova03:59
openstackgerritMerged openstack/nova master: Reduce logging of host hypervisor capabilities to DEBUG level  https://review.opendev.org/66137904:00
*** tetsuro has quit IRC04:04
*** markvoelker has joined #openstack-nova04:05
*** frankwang has quit IRC04:06
openstackgerritMerged openstack/nova master: Fix live-migration when glance image deleted  https://review.opendev.org/65905404:09
*** JamesBenson has quit IRC04:12
*** slaweq has joined #openstack-nova04:16
*** sapd1_x has joined #openstack-nova04:17
*** slaweq has quit IRC04:24
*** tetsuro has joined #openstack-nova04:26
*** whoami-rajat has joined #openstack-nova04:31
*** ratailor has joined #openstack-nova04:34
*** boxiang has quit IRC04:35
*** markvoelker has quit IRC04:37
*** ivve has quit IRC04:37
*** altlogbot_3 has quit IRC04:38
*** trident has quit IRC04:39
*** altlogbot_2 has joined #openstack-nova04:40
*** altlogbot_2 has quit IRC04:40
*** janki has joined #openstack-nova04:40
*** trident has joined #openstack-nova04:41
*** altlogbot_0 has joined #openstack-nova04:41
*** sapd1_x has quit IRC05:00
*** slaweq has joined #openstack-nova05:11
*** tetsuro has quit IRC05:12
*** pcaruana has joined #openstack-nova05:15
*** slaweq has quit IRC05:18
*** brinzhang has quit IRC05:27
*** boxiang has joined #openstack-nova05:33
*** psachin has quit IRC05:34
*** markvoelker has joined #openstack-nova05:34
*** ivve has joined #openstack-nova05:41
*** frankwang has joined #openstack-nova05:45
*** yaawang has quit IRC05:48
*** yaawang has joined #openstack-nova05:48
*** boxiang has quit IRC05:53
*** cfriesen has joined #openstack-nova05:54
*** boxiang has joined #openstack-nova05:57
*** dtantsur|afk is now known as dtantsur06:00
*** rcernin has quit IRC06:01
*** rcernin has joined #openstack-nova06:01
*** tetsuro has joined #openstack-nova06:02
*** dpawlik has joined #openstack-nova06:03
*** tetsuro has quit IRC06:07
*** markvoelker has quit IRC06:08
*** slaweq has joined #openstack-nova06:12
*** brinzhang has joined #openstack-nova06:18
*** tetsuro has joined #openstack-nova06:19
*** lpetrut has joined #openstack-nova06:23
*** brinzhang has quit IRC06:32
*** brinzhang has joined #openstack-nova06:33
*** maciejjozefczyk has joined #openstack-nova06:34
*** maciejjozefczyk has quit IRC06:35
*** maciejjozefczyk has joined #openstack-nova06:35
*** takamatsu has joined #openstack-nova06:48
*** rcernin has quit IRC06:52
*** cfriesen has quit IRC07:02
*** tesseract has joined #openstack-nova07:05
*** markvoelker has joined #openstack-nova07:05
openstackgerritYongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology"  https://review.opendev.org/65871607:06
*** awalende has joined #openstack-nova07:13
*** minmin has joined #openstack-nova07:14
*** tetsuro has quit IRC07:16
*** ralonsoh has joined #openstack-nova07:21
*** tetsuro has joined #openstack-nova07:22
*** rpittau|afk is now known as rpittau07:23
*** helenafm has joined #openstack-nova07:31
*** markvoelker has quit IRC07:37
*** tetsuro has quit IRC07:41
*** itlinux has quit IRC07:42
*** tetsuro has joined #openstack-nova07:47
*** xek_ has joined #openstack-nova07:47
*** takamatsu has quit IRC07:52
*** tstrul has joined #openstack-nova07:56
*** tetsuro has quit IRC07:56
*** takashin has left #openstack-nova07:57
*** takamatsu has joined #openstack-nova08:00
kashyapefried: aspiers: Thanks for the review on that os-traits patch.  Will address it soon.08:00
*** ricolin_ has quit IRC08:07
*** ricolin has joined #openstack-nova08:07
*** tkajinam has quit IRC08:10
openstackgerritguangchao.pan proposed openstack/nova master: Add a name for the automatically created volume  https://review.opendev.org/66009608:15
*** panda is now known as panda|ruck08:23
*** ociuhandu has quit IRC08:31
*** markvoelker has joined #openstack-nova08:34
*** ociuhandu has joined #openstack-nova08:35
*** derekh has joined #openstack-nova08:39
*** takamatsu has quit IRC08:52
*** boxiang has quit IRC08:59
*** yedongcan has joined #openstack-nova09:02
*** cdent has joined #openstack-nova09:05
*** markvoelker has quit IRC09:08
aspierskashyap: cool09:12
* kashyap goes back to messing with unit tests09:17
kashyapaspiers: Still about?09:48
aspiersyep09:48
kashyapaspiers: When you get a moment, I'm stuck in "unit test rut", wonder if you can have a gander at this WIP (line 102): http://paste.openstack.org/show/752226/09:48
kashyapaspiers: The code it is testing is also pasted in the pastebin, for convenience.  (It is in relation to this patch you reviewed in the past: https://review.opendev.org/#/c/639091/)09:49
kashyapMaybe I should just post the WIP, broken unit test, so you could comment in Gerrit itself :D09:49
kashyapLet me post it09:51
*** davidsha has joined #openstack-nova09:51
stephenfinjohnthetubaguy++ Thanks for running through those remove-cellsv1 patches09:52
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path  https://review.opendev.org/63909109:52
kashyapaspiers: ^ The "broken" unit test09:52
zigoIs there a way to remove an already runningn instance from a server group?09:53
*** threestrands has quit IRC09:54
aspierskashyap: oh nice, didn't know it was possible to refer to abbreviated change-ids09:55
kashyapaspiers: Yeah, I just tried it, based on commit ID trimming I do09:57
aspierskashyap: what's the FIXME for?09:57
aspierswon't that fail flake8 or something?09:58
kashyapaspiers: As I felt the test was not 100% accurate, although it "passes"09:58
aspiersI think any FIXME needs an explanation09:58
kashyapWanted someone to double-check it; will remove it on next PS (as I need one more test)09:58
kashyapYes, yes.  I was not going to put in a "naked FIXME" like that.  It won't exist.09:58
aspiersOh, sorry I missed your previous messages09:59
aspiersNevertheless, I think I'm missing (i.e. probably forgot) some context here10:00
aspiersHow are you stuck?10:00
kashyapaspiers: Err, not exactly 'stuck' (bad wording); but just needs a once-over of the test.  Is the "mocking" correct, etc10:01
aspiersOh right10:01
aspiersOK so this one is for testing the >= 4.7.0 behaviour?10:01
kashyapaspiers: Right10:02
kashyapaspiers: Both, test with and without MIN_LIBVIRT_BETTER_SIGKILL_HANDLING10:03
kashyapaspiers: I.e. hit the warining of _SIGKILL_HANDLING isn't satisfied10:03
aspiersI mean the test with the FIXME10:03
*** markvoelker has joined #openstack-nova10:05
kashyapYeah, it is "supposed" to :D10:05
* kashyap bbiab10:07
*** frankwang has quit IRC10:12
openstackgerritBalazs Gibizer proposed openstack/nova master: DNM:test  https://review.opendev.org/66193110:13
openstackgerritGuo Jingyu proposed openstack/nova master: Define and catch QemuGuestAgentNotRunning for set-password failure  https://review.opendev.org/66146610:16
*** nowster has left #openstack-nova10:16
openstackgerritChris Dent proposed openstack/nova master: Make all functional tests reusable by other projects  https://review.opendev.org/65765910:26
*** slaweq has quit IRC10:30
*** dave-mccowan has joined #openstack-nova10:31
openstackgerritBalazs Gibizer proposed openstack/nova master: DNM:test  https://review.opendev.org/66193110:34
*** dave-mccowan has quit IRC10:37
*** markvoelker has quit IRC10:37
*** dtantsur is now known as dtantsur|lunch10:43
*** bbowen has quit IRC10:44
openstackgerritBalazs Gibizer proposed openstack/nova master: DNM:test  https://review.opendev.org/66193110:48
mdboothkashyap: Are you going to respin https://review.opendev.org/#/c/639091/ quickly?10:51
mdboothkashyap: Looks like you could fix up the nits in 2 minutes, and not much point wasting CI resources.10:51
kashyapmdbooth: Yeah, trying the reg-ex thingie10:51
mdboothkashyap: I proposed a simpler alternative10:52
kashyapAh, let me look10:52
kashyapNo need to muck with regex'es then10:52
kashyapThanks for the review!10:52
kashyapmdbooth: Relatd aside: would you be amenable if I simply do (instead of hard-coding a PID):10:53
kashyap        str=("Failed to terminate process \d+ with SIGKILL: Device "10:53
kashyap             "or resource busy")10:53
*** slaweq has joined #openstack-nova10:54
mdboothkashyap: Does it matter?10:54
aspierskashyap: then you'd need an exc_template10:54
kashyapmdbooth: It doesn't10:54
mdboothkashyap: Surely you could write "Error: abducted by aliens"10:54
kashyapHeh10:55
aspiersexc_template % random_pid for raising, and exc_template % '\d+' for matching10:55
openstackgerritGuo Jingyu proposed openstack/nova master: Define and catch QemuGuestAgentNotRunning for set-password failure  https://review.opendev.org/66146610:55
aspiersThe important thing there is not so much the contents of the string, as ensuring that the test case isn't accidentally catching a totally different exception10:55
mdboothRight. We especially don't want to go asserting that libvirt is generating particular error text for us.10:56
aspiersassertRaises(fakelibvirt.libvirtError, ...) doesn't guarantee that it's a VIR_ERR_SYSTEM_ERROR10:56
aspiers(IIUC)10:56
aspiersand also that int1=errno.EBUSY10:56
aspiersso six.assertRaisesRegex can function as a substitute for those two checks10:57
*** jaypipes has joined #openstack-nova10:57
mdboothaspiers: My suggestion was to assert that the error raised is the identity of the fake error10:57
mdboothi.e. we raised literally the expected error object10:57
aspiersmdbooth: yeah, that probably sounds like the best option to me10:57
aspiershow do you code that though?10:58
mdboothassertRaises(ex, ...)10:58
aspiersoh, that easy :)10:58
mdboothActually, lemme try something. Would that work if I copied it?10:58
aspiersI thought the first parameter had to be the exception _class_10:58
aspiersthe docs are kinda unclear on this10:58
kashyapmdbooth: Hmm, I tried the assertRaises(ex, ...) it fails with:10:59
kashyapTypeError: issubclass() arg 2 must be a class or tuple of classes10:59
aspiersright10:59
aspiersthe prose suggests you can use the exception instance, but the examples suggest otherwise10:59
mdboothkashyap: I only ran it under py37, so maybe.10:59
mdboothI hate python10:59
aspiers;)11:00
kashyapSigh11:00
aspiersyeah, Python APIs aren't the best11:00
aspiersbiab11:00
openstackgerritBalazs Gibizer proposed openstack/nova master: DNM:test  https://review.opendev.org/66193111:00
kashyapmdbooth: Do you have a preference given that the above goes bonkers on non-PY37?11:01
kashyaps/preference/preference,/11:01
mdboothkashyap: My test was bogus...11:01
kashyapAh11:02
aspiersI figured it out11:02
kashyapPlease educate11:02
aspierswith self.assertRaises(ex) as cm:11:02
aspiers    ... do assertions on cm.exception ...11:02
mdboothraised = self.assertRaises(fakelibvirt.libvirtError, ...)11:02
mdboothself.assertEqual("Foo", raised.foo)11:03
aspiersOh, context manager only works with >= 3.1 :-/11:03
* mdbooth tries ^^^ on my2711:03
mdboothpy2711:03
aspiersAlthough IIRC maybe we don't use native py27 unittest?11:04
mdboothI think it inherits at some point11:04
aspierstesttools>=2.2.011:04
aspiersin test-requirements.txt11:04
* kashyap goes to fiddle11:05
aspiershttps://testtools.readthedocs.io/en/latest/for-test-authors.html#improved-assertraises11:05
aspiers"Note that this is incompatible with the assertRaises in unittest2 and Python2.7."11:05
* kashyap wonders if he should try six.assertRaisesRegex()?11:06
mdboothkashyap: Sec...11:06
aspiersI would try the approach in that link11:06
aspierswhich is basically what mdbooth suggested11:06
kashyapmdbooth: Nod11:06
* mdbooth is just testing against py2711:07
aspiersI suspect his suggestion only works *because* we are using testtools not native unittest11:07
aspiersbut yeah, we'll see in a few seconds :)11:07
mdbooth...works11:07
mdboothcode is:11:07
aspiers\o/11:07
* aspiers really goes now, back shortly11:07
mdbooth~             raised = self.assertRaises(fakelibvirt.libvirtError, drvr._destroy,11:08
mdbooth                                instance)11:08
mdbooth+             self.assertEqual(fakelibvirt.VIR_ERR_SYSTEM_ERROR,11:08
mdbooth+                     raised.get_error_code())11:08
mdboothyou can add more11:08
mdbooth^^^ tested on py(2|3)711:08
kashyapmdbooth: Thanks!  Let me try11:09
*** janki has quit IRC11:11
kashyapmdbooth: That get_error_code() needs a mock, no?11:12
kashyap  @mock.patch.object(fakelibvirt.libvirtError, 'get_error_code')11:12
mdboothkashyap: No11:12
mdboothkashyap: I didn't look, but it must already be implemented by fake libvirtError11:12
* kashyap checks11:13
mdboothIt certainly works and returns the expected value11:13
*** guozijn has quit IRC11:16
*** ratailor has quit IRC11:18
kashyapmdbooth: You're of course correct11:19
kashyapmdbooth: Before I take CI resources, does it look OK to you: http://paste.openstack.org/show/752232/11:27
kashyapaspiers: BTW, on self.assertTrue(mock_warning.called) vs. mock_warning.assert_called_once() -- I went with the former as that seemed to be the "pattern"11:30
aspiersOK11:30
aspiersI don't really mind much either way11:31
aspiersLatter feels a bit more idiomatic to me (after all, presumably they implemented it for a reason) but whatever :)11:31
kashyapYeah, I see what you mean, though.  I like the latter less obtuse11:31
*** jangutter_ has joined #openstack-nova11:32
*** markvoelker has joined #openstack-nova11:34
*** brinzhang has quit IRC11:35
*** brinzhang has joined #openstack-nova11:36
*** jangutter has quit IRC11:36
*** macza has joined #openstack-nova11:38
*** redrobot has quit IRC11:39
*** bbowen has joined #openstack-nova11:41
*** macza has quit IRC11:43
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path  https://review.opendev.org/63909111:46
*** guozijn has joined #openstack-nova11:48
kashyapaspiers: BTW, I fully share your horror of super-long methods; I just made an elaborate TODO to address it into 3 other refactor commits, based on your remarks.11:50
*** tbachman has quit IRC11:50
*** Spencer_Yu has quit IRC11:52
cdent(super-long {methods,packages,tests,files,documents})--11:52
kashyapcdent: :-)11:53
cdentbut11:53
cdent(super-log emails)++ ;)11:53
*** tesseract has quit IRC11:53
cdentdamn: long!11:53
*** tesseract has joined #openstack-nova11:53
kashyapmdbooth: Hopefully I addressed "all things", including Adam's nits.  Hope that one test suffices?  Or do we need _another_ test?  (I don't want to add more without a very good reason)11:54
*** markvoelker has quit IRC11:54
* kashyap changes 'office' to library; bbiab11:54
*** markvoelker has joined #openstack-nova11:54
*** helenafm has quit IRC12:05
*** guozijn has quit IRC12:10
*** redrobot has joined #openstack-nova12:23
*** udesale has joined #openstack-nova12:25
*** guozijn has joined #openstack-nova12:27
*** Spencer_Yu has joined #openstack-nova12:29
*** lbragstad has joined #openstack-nova12:32
*** guozijn has quit IRC12:32
openstackgerritFrançois Palin proposed openstack/nova stable/rocky: Include all network devices in nova diagnostics  https://review.opendev.org/66196212:34
*** tbachman has joined #openstack-nova12:35
*** mtreinish has quit IRC12:36
*** mtreinish has joined #openstack-nova12:36
*** brinzhang has quit IRC12:39
openstackgerritStephen Finucane proposed openstack/nova master: docs: Don't version links to reno docs  https://review.opendev.org/66196712:40
*** whoami-rajat has quit IRC12:51
*** jangutter has joined #openstack-nova12:51
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path  https://review.opendev.org/63909112:52
*** gmann has quit IRC12:53
*** jangutter_ has quit IRC12:54
*** helenafm has joined #openstack-nova12:55
kashyapmdbooth: Addressed the two nits ^^; can I have my +1 back? :D12:55
kashyap(Thanks!)12:55
artomsean-k-mooney, tempest-full-py3/nova-multinode all passed on top of https://review.opendev.org/#/c/644881/1812:57
artomNeed to fix unit tests now12:58
artomUnless mriedem or dansmith want to sanity check the approach to make sure it's acceptable first12:58
artom(The revert resize thing)12:58
*** guozijn has joined #openstack-nova12:59
*** kaisers has quit IRC13:01
*** kaisers has joined #openstack-nova13:02
*** guozijn has quit IRC13:04
aspierskashyap: great :)13:11
openstackgerritFrançois Palin proposed openstack/nova stable/rocky: Include all network devices in nova diagnostics  https://review.opendev.org/66196213:12
sean-k-mooney artom well its a race or was so you might want to do a few rechecks to confirm but cool ill take a look13:15
*** Spencer_Yu has quit IRC13:15
sean-k-mooneyartom: although im also plannign to change how hybrid plug works to fix a different issue...13:16
sean-k-mooneyi need to get back to working on this https://review.opendev.org/#/c/602432/ but if i end up altering the beahvior i geuss we could revert or update your change if hybrid plug nolonger matters13:17
sean-k-mooneythis is actully next on my todo list once i get the spec im working on finished13:18
kashyapmdbooth: Haha, you caught me sneaking in the \d+13:19
mdboothkashyap: It makes no difference :)13:19
*** mriedem has joined #openstack-nova13:20
*** eharney has joined #openstack-nova13:20
kashyapYeah, indeed13:20
mdboothi.e. I don't care if you don't change it13:20
artomsean-k-mooney, I don't think it was a race in this case13:24
artomWe were blocking on the wait before Neutron could ever send us the event13:24
*** HD|Laptop has joined #openstack-nova13:25
artomWhen waiting in the compute manager13:25
HD|Laptophello all. I have an ISO image (with drivers) imported with --container-format bare --disk-format iso.13:25
sean-k-mooneybut only when using a speicic firewall driver13:25
artomBut yeah, a few rechecks won't harm - they'll happen regardless when I fix the unit tests13:25
HD|LaptopStarting from ISOs with server create --image <OS ISO image> works fine and the ISO gets mapped in qemu-kvm as a CDROM drive13:25
HD|Laptopbut when trying to attach an ISO via volume, it gets mapped as "-device virtio-blk-pci" despite setting hw_cdrom_bus='ide', hw_disk_bus='ide' on both image and volume13:26
HD|Laptophow do I force the volume with the driver ISO to be mapped as -device ide-cd?13:27
*** BjoernT has joined #openstack-nova13:34
*** dtantsur|lunch is now known as dtantsur13:35
*** BjoernT_ has joined #openstack-nova13:39
*** BjoernT has quit IRC13:39
*** tbachman has quit IRC13:42
*** tbachman has joined #openstack-nova13:45
*** aarents has quit IRC13:51
*** mmethot_ has joined #openstack-nova13:53
*** yedongcan has left #openstack-nova13:53
*** awalende has quit IRC13:53
*** mmethot has quit IRC13:54
*** awalende has joined #openstack-nova13:54
*** mlavalle has joined #openstack-nova13:56
*** awalende_ has joined #openstack-nova13:57
*** Woutifier has quit IRC13:58
*** awalende has quit IRC13:58
*** liuyulong|away is now known as liuyulong14:00
*** awalende_ has quit IRC14:02
mriedembauzas: can you take a look at this functional regression recreate test patch? https://review.opendev.org/#/c/661822/14:03
mriedemrelated to your favorite, request spec14:03
*** whoami-rajat has joined #openstack-nova14:03
*** tbachman has quit IRC14:06
*** gmann has joined #openstack-nova14:10
*** itlinux has joined #openstack-nova14:11
*** JamesBenson has joined #openstack-nova14:15
stephenfinmriedem: You think we can push ahead with this now? https://review.opendev.org/#/c/629597/14:17
*** JamesBenson has quit IRC14:19
*** ricolin has quit IRC14:20
stephenfinefried: Easy docs fix here that'll need to be backported after https://review.opendev.org/66196714:20
*** kaisers has quit IRC14:20
*** mrch_ has quit IRC14:20
*** dkehn has left #openstack-nova14:20
*** JamesBenson has joined #openstack-nova14:21
*** kaisers has joined #openstack-nova14:22
efriedstephenfin: +214:22
*** awalende has joined #openstack-nova14:22
mriedemstephenfin: you will have to decouple it from https://review.opendev.org/#/c/620111/14:23
mriedemwhich is waiting on how https://review.opendev.org/#/c/637217/ gets sorted out which i'm not actively working on14:24
stephenfinokidok14:24
*** ricolin has joined #openstack-nova14:26
*** awalende has quit IRC14:27
*** ivve has quit IRC14:29
*** lpetrut has quit IRC14:30
sean-k-mooneymriedem: johnthetubaguy when one of ye have time can you look at this backport for os-vif14:33
sean-k-mooneywe dont use upper constraits on all stable branches so we want to fix that14:34
sean-k-mooneyit still need more backports but that one is blocking a different backport too14:34
*** artom has quit IRC14:35
*** artom has joined #openstack-nova14:35
*** tbachman has joined #openstack-nova14:38
mriedemstephenfin: do you plan on backporting this? https://review.opendev.org/#/c/661967/14:39
mriedemsean-k-mooney: did you intend on pasting a link to a backport?14:40
stephenfinmriedem: yeah, once it's merged14:40
mriedemstephenfin: ok, then you should have a bug for it14:40
stephenfinoh yeah, good point that. I can do that now14:40
sean-k-mooneymriedem: yes https://review.opendev.org/#/c/658780/ is the queens backport14:41
*** itlinux has quit IRC14:41
sean-k-mooneymriedem: of using upper constaints14:41
sean-k-mooneythere is also the backport of https://review.opendev.org/#/q/topic:bug/1825888+(status:open+OR+status:merged) but that needs to be done on stien and rocky first14:42
mriedemsean-k-mooney: https://review.opendev.org/#/c/658780/ looks like it's doing the trick but i can't tell at all from the tox logs, a comment in line if you have the answer14:50
mriedemthe tox logs make it look like they are installing from master u-c:14:50
mriedemhttp://logs.openstack.org/80/658780/4/check/openstack-tox-py35/b70c01b/tox/py35-1.log14:50
mriedemcmd: /home/zuul/src/opendev.org/openstack/os-vif/.tox/py35/bin/pip install -U -c/home/zuul/src/opendev.org/openstack/requirements/upper-constraints.txt -r/home/zuul/src/opendev.org/openstack/os-vif/requirements.txt -r/home/zuul/src/opendev.org/openstack/os-vif/test-requirements.txt14:50
mriedemCollecting oslo.versionedobjects===1.31.3 (from -c /home/zuul/src/opendev.org/openstack/requirements/upper-constraints.txt (line 235))   Downloading http://mirror.bhs1.ovh.openstack.org/pypifiles/packages/fc/55/09c89a3c1724732f435b1639640ac58f4ab485f07c26aa5d1e452633040f/oslo.versionedobjects-1.31.3-py2.py3-none-any.whl (74kB)14:50
sean-k-mooneyhum ill take a closer look again. the tox job should overdie the uppercontarints file use to use teh one it cloned by setting the env varible14:51
mriedemit is using the queens constraints, it's just not obvious at all from the logs14:52
sean-k-mooneysphix was the package that was breaking the follow up package14:52
sean-k-mooneyit was previously uncpped v7 or this failed but v8 works after it was rebased on the constraitns patch https://review.opendev.org/#/c/655694/814:53
mriedemyup i can see http://logs.openstack.org/94/655694/7/check/openstack-tox-py35/c0ad3dc/tox/py35-3.log14:54
mriedemok +W on the queens uc change14:55
*** artom has quit IRC14:55
sean-k-mooneythanks when you have time it would be good to merge the bugfix backport too but as i said it still need to be backported on stien and rock + we wont be doing a release for a while so it not urgent14:57
mriedemyeah i'm looking, creating the missing release series in lp for os-vif first14:57
mriedemso i can target the bug14:57
*** tbachman has quit IRC14:58
sean-k-mooneyon a related note im planning to do an intermediate releaseof os-vif before m2 so that any nova features that need the new release can technicall merge before m2 assuming they are ready15:01
sean-k-mooneybut i dont think there is enough currently to justify a release so it will be at leat another couple of weeks.15:03
mriedemsean-k-mooney: ralonsoh: i don't know if this came up in review on the change on master, but we should probably use mock_open here https://review.opendev.org/#/c/655678/3/vif_plug_ovs/tests/unit/test_linux_net.py@8315:03
openstackgerritMerged openstack/os-vif stable/queens: add upper_constraints support  https://review.opendev.org/65878015:05
sean-k-mooneyjust on a meeting but will look15:05
sean-k-mooneyafter15:05
sean-k-mooneymriedem: mock open is python3 only i think15:07
sean-k-mooneythere was a reason we dont use it in os-vif i think nova has implemented a fallback for py2715:08
*** cfriesen has joined #openstack-nova15:08
mriedemwe get mock in py27 from the mock library15:13
ralonsohmriedem, but this is what I'm doing (same as the example provided in the link): I'm replacing open with mock_open15:13
sean-k-mooneymriedem: we dont in os-vif i think15:13
sean-k-mooneye.g. we are not using the lib version15:14
sean-k-mooneywe could15:14
ralonsohmriedem, with "@mock.patch.object(builtins, 'open')" I'm avoiding the problem between py2 and py315:14
ralonsohmriedem, sean-k-mooney mock_open is in both versions15:14
mriedemsean-k-mooney: umm, i don't see how py27 tests in os-vif could work then15:14
sean-k-mooneyralonsoh: i dont think its in py27 without the mock lib15:14
mriedemos-vif isn't directly requiring mock but it's getting it from oslotest https://github.com/openstack/oslotest/blob/master/requirements.txt15:14
mriedemas a transitive dependency15:15
aspierssean-k-mooney: we use mock_open in lots of places15:15
sean-k-mooneyah ok15:15
aspierssee also https://review.opendev.org/#/c/661266/ although I don't think it's useful in this case15:15
sean-k-mooneyin which case then yes we could replace all of those with mock_open15:15
sean-k-mooneyaspiers: maybe im still not conviced that is better but that is becasue at least in os-vif i dont think we need it for our current tests15:16
sean-k-mooneybut yes it might be useful15:16
aspiersBTW mock_open does not work in all scenarios15:17
aspierse.g. if the code reading the file uses enumerate()15:17
sean-k-mooneyaspiers: yes i have noticed it didnt work when i have tried to used it somethimes15:17
aspierssee my comment May 24 9:18PM on https://review.opendev.org/#/c/661266/215:17
aspierse.g. it does not work when mocking oslo.config files15:18
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path  https://review.opendev.org/63909115:21
kashyapaspiers: Can I get my ACK, now? :D  ---^15:22
aspiersprobably15:22
kashyapaspiers: On addressing the NOTE thing, indeed what MattB said (and what my note itself says)15:23
aspierskashyap: I probably misread it15:23
kashyapaspiers: Aw, thought I write clearest phrases15:23
aspiers"TODO(kchamart): Rewrite the above note, ..."15:23
openstackgerritStephen Finucane proposed openstack/nova master: docs: Don't version links to reno docs  https://review.opendev.org/66196715:24
kashyapaspiers: (I.e. the TODO will be addresed  _once_ the MIN_LIBVIRT_VERSION reaches v4.7.0)15:24
aspiersYes, but you buried that qualifier deep in the sentence :)15:24
stephenfinefried, mriedem: Added a bug link to https://review.opendev.org/#/c/661967/15:24
aspierskashyap: "TODO(kchamart): Once MIN_LIBVIRT_VERSION reaches v4.7.0, rewrite the above note ..."15:24
kashyapaspiers: Yeah, darn.  I always worry sometimes, whether the qualifier is better at the start or a bit deeper inside15:24
aspiersAt the start, when it modifies the entire context15:24
kashyapaspiers: Fair enough, actually let me do that.  It will satisfiy my OCD-ness15:25
aspiers:)15:25
aspiersmine too15:25
kashyapI even vaguely recall starting with the qualifier, but not sure what crack I was smoking, and changed it15:25
aspiersNo worries :)15:26
aspierskashyap: Once 4.7.0 as min version is reached, it's not just the note which gets rewritten, right? Indeed, I think you already say this but the comma after "above note" slightly obscures that the code needs to be removed too.15:27
aspiersWhen it's reached, it's at least as important to update the code as the note, so I would write it more like:15:28
kashyapaspiers: No, not just the note; the "remove the following code" as well15:28
kashyapNew phrasing coming soon to an IRC window near you15:28
aspierskashyap: "TODO(kchamart): Once MIN_LIBVIRT_VERSION reaches v4.7.0, remove the code [...] and rewrite the above note ..."15:28
aspiersi.e. put the code removal first15:28
aspiersUnfortunately my pedantry has no "off" button15:29
kashyapI enjoy English phrasing pedantry.15:31
aspiersMe too, for some reason15:32
*** gyee has joined #openstack-nova15:33
kashyapaspiers: How about this:15:34
kashyap                        # TODO(kchamart): Once MIN_LIBVIRT_VERSION15:34
kashyap                        # reaches v4.7.0, (a) rewrite the above note,15:34
kashyap                        # and (b) remove the following code that retries15:34
kashyap                        # _destroy() API call (which gives SIGKILL 3015:34
kashyap                        # seconds to take effect) -- because from v4.7.015:34
kashyap                        # onwards, libvirt _automatically_ increases the15:34
kashyap                        # timeout to 30 seconds.  This was added in the15:34
kashyap                        # following libvirt commits:15:34
aspiersYeah, that's good15:34
mriedemsean-k-mooney: i bet you know the answer to this, is "x in y" where y is a set the same time as if y were a dict?15:34
aspiersthe (a) and (b) addresses the problem with the comma after "note"15:34
kashyapaspiers: Yeah, indeed, it can't be misunderstood even if one tries to.15:34
*** altlogbot_0 has quit IRC15:34
sean-k-mooneyif y is a dict its checking is x in the keys15:35
aspiersmriedem: same time as in complexity? or same thing? I think the answer to both is yes15:35
aspiersyeah, what sean-k-mooney said15:35
sean-k-mooneymriedem: if you want to check the values you need to do x in y.values15:35
mriedemsean-k-mooney: yes i realize what it's looking for15:35
aspiersboth should be O(1)15:35
mriedemi'm asking if both are O(1)15:36
*** irclogbot_3 has quit IRC15:36
sean-k-mooneyyes they are both O(1)15:36
*** altlogbot_3 has joined #openstack-nova15:36
*** macza has joined #openstack-nova15:37
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path  https://review.opendev.org/63909115:37
*** irclogbot_3 has joined #openstack-nova15:37
kashyapmdbooth: aspiers ^ Wording in the note rephrased to clearly spell out what's to do.15:38
aspierskashyap: is https://review.opendev.org/#/c/655193/ next on your list? since that's a major blocker for the newer changes on my SEV series15:40
kashyapaspiers: Without guessing, is it the 'os_traits' rework?  Yes15:40
aspierskashyap: and it sounds like pretty much all you have to do is empty x86.py15:40
aspiersOK, cool15:40
kashyapaspiers: Tomm is holiday; but today & Friday I'll be working on it, too.15:40
kashyapaspiers: Yeah, let me do that right away15:40
kashyapaspiers: It's amazing, what that change turned into.  I was just a drive-by "observer" of the 'os_traits' repo & the corresponding call in driver.py.  Thought I'll make a tiny change15:42
aspierskashyap: oh, and some simple nits from me in amd.py15:42
kashyap... and it turned into a multi-week thing15:42
kashyapaspiers: Certainly, saw that.  Typo: s/SVM/SEV/15:42
kashyapAnd others.  Reading...15:42
aspierskashyap: that's what happened to me with https://review.opendev.org/#/c/538498/, more or less15:44
*** tesseract has quit IRC15:44
kashyapaspiers: Ah, I saw this fly by.  Thanks for the diagrams!15:45
aspierskashyap: https://docs.openstack.org/nova/latest/reference/update-provider-tree.html#taxonomy-of-traits-and-capabilities15:46
aspiersadded since then15:46
* kashyap bbiab; phone15:46
*** tstrul has quit IRC15:47
*** guozijn has joined #openstack-nova15:48
kashyapaspiers: (While I wait on the almost-human-sounding-bot), what's the source on that neat digram?15:48
kashyaps/digram/diagram/15:48
* stephenfin notes that he's overtaken cdent for most lines of code changed in nova during Train. Take that, cdent https://www.stackalytics.com/?metric=loc&module=nova-group ;)15:48
aspierskashyap: it's just SVG15:48
* cdent shakes fist at stephenfin 15:48
aspiersstephenfin: search and replace? ;-p15:48
kashyapaspiers: Ah, okay.15:49
stephenfinaspiers: Deleting cells v115:49
* cdent deletes vmware virt driver15:49
*** helenafm has quit IRC15:49
cdentthat'll show you!15:49
aspiersROFL15:49
stephenfin:D15:49
aspiersWTF, I'm #4 by LoC15:50
aspiersHow is that possible15:50
stephenfinspecs?15:50
cdentugh, this is not great: https://www.stackalytics.com/?metric=loc&module=placement-group15:50
*** dtantsur is now known as dtantsur|afk15:51
edleafecdent: they have been saying that their numbers have been out of whack for a while15:51
cdentedleafe: they reported recently that they fixed it. that looks right15:52
edleafeI thought they were still working on it15:52
*** guozijn has quit IRC15:52
cdentthere was a post couple days ago15:52
cdentbut who knows, I don't think we can ever really fully rely on it15:52
openstackgerritStephen Finucane proposed openstack/nova stable/stein: docs: Don't version links to reno docs  https://review.opendev.org/66202515:52
melwittmriedem, johnthetubaguy: thanks for the reviews on counting quotas <3 I'm going to add a follow up patch for the nits/notes and then also propose the spec amendment for the deviations from the spec15:52
edleafeYou mean Eric has only contribute 25 lines of code??15:53
aspiersedleafe: they were missing a whole bunch of commits for nova, but I think that got fixed in the last day or 215:53
cdentedleafe: of merged stuff in train, yeah, I'd say that's right15:54
aspiersedleafe: it says 809 LoC for Eric15:54
*** itlinux has joined #openstack-nova15:54
aspiersI'm looking at https://www.stackalytics.com/?metric=loc&release=train&module=nova-group15:55
edleafeaspiers: for Train?15:55
edleafeaspiers: ah, we're looking at placement15:55
aspiersah sorry15:55
mriedemmelwitt: just posted comments on https://review.opendev.org/#/c/638073/15:56
mriedemmelwitt: i'm going to post a DNM patch to test the pg flow15:56
melwittwhoa, that is a lot of comments15:57
*** tbachman has joined #openstack-nova15:59
mriedemonly 12, that's nothing15:59
openstackgerritStephen Finucane proposed openstack/nova stable/queens: Fail to live migration if instance has a NUMA topology  https://review.opendev.org/62959716:01
openstackgerritStephen Finucane proposed openstack/nova stable/queens: fix up numa-topology live migration hypervisor check  https://review.opendev.org/64893916:01
*** ivve has joined #openstack-nova16:02
*** _erlon_ has joined #openstack-nova16:04
*** lpetrut has joined #openstack-nova16:06
*** rpittau is now known as rpittau|afk16:06
*** artom has joined #openstack-nova16:08
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: Test count_usage_from_placement=True with postgresql  https://review.opendev.org/66202816:09
*** phillw has joined #openstack-nova16:11
phillwHi good people, a quick question if I may. Regarding using GPUs in compute nodes, I managed to find an article from CERN on the subject but nothing else (http://openstack-in-production.blogspot.com/2018/05/introducing-gpus-to-cern-cloud.html) Does anyone know of anything else current;y on-going / in the pipe line for this?16:11
mriedemphillw: vGPUs? because that's documented here https://docs.openstack.org/nova/latest/admin/virtual-gpu.html16:12
phillwmriedem: thanks :)16:13
mriedemphysical GPUs can be accessed using pci-passthrough since...juno?16:13
mriedemvGPU support in the libvirt and xenapi drivers is since queens16:13
mriedemhttps://docs.openstack.org/nova/latest/admin/pci-passthrough.html for the latter16:13
mriedem*er pcpu pci passthrough16:13
mriedem*pgpu16:14
*** lpetrut has quit IRC16:14
mriedemthat doc mostly talks about sriov ports though16:14
sean-k-mooneyyou sould also be about to use amds sriov based vgpu "MxGpu" or something like that via pci passthrough from juno or whenever we added that16:14
sean-k-mooneyi.e. if your gpu support virtualisation via sriov then that will jsut work like any other sriov vf with pci passhtough16:15
sean-k-mooneythe same we we supprot qat virtualistion via sriov16:15
phillwI'll go and have a read up. A colleague of mine wants to use the gpu power for AI learning and I'm at the start of re-learning openstack after a break since 2014 :)16:17
mriedemscanning the cern article it looks pretty comprehensive16:18
mriedemand says what we just told you anyway :)16:18
mriedemi'm not aware of who is using vgpus yet16:18
sean-k-mooneythe current state is we have dedicated support for the nvida data center gpus( which need a license) and untested support for sriov stuff which shoudl jsut work via pcie passthough16:18
mriedembauzas might know16:18
phillwit  missed out about deployment :)16:18
mriedemphillw: yeah but it linked to those same docs16:18
mriedemthat's your homework16:18
sean-k-mooneyphillw: so you your colleage wants to use a consomer gpu they are out of luck unless they do a complte passthough which technicall violates nvidas eula16:20
phillwmriedem: it's Tims home work, he wants to add gpu's :) As both our instances are private we'll be using packstack.16:20
sean-k-mooneyphillw: is packstack still a thing?16:20
phillwsean-k-mooney: so not possible with sriov without breaching EULA?16:20
sean-k-mooneyon the nvida side16:21
phillwsean-k-mooney: yeah, it's still hanging on in there :P16:21
sean-k-mooneytechnically if you dont use the binary driver then your fine16:21
*** wwriverrat has joined #openstack-nova16:21
sean-k-mooneybut if you use the opensocrce driver you dont have gpu compute16:21
sean-k-mooneyso its kind of a catch 2216:21
phillwah, understood.16:21
*** cdent has quit IRC16:22
sean-k-mooneynvida really want people bying the datacenter gpus insteadk of ther gaming ones for viutalisation16:22
mriedemthere is a workaround i believe16:23
mriedemhttps://review.opendev.org/#/c/579897/16:23
sean-k-mooneyyes there is16:23
phillwyeah, i can understand that. I recall playstation upgrade being done which would prevent USAF using a cluster of them as cloud :)16:23
sean-k-mooneyyou set the hypervior to hidden16:23
mriedem^ is from CERN btw16:23
sean-k-mooneyyes that is for hyperv i think16:23
openstackgerritStephen Finucane proposed openstack/nova master: Stop handling 'InstanceUnknownCell' exception  https://review.opendev.org/65130716:23
openstackgerritStephen Finucane proposed openstack/nova master: Remove unnecessary wrapper  https://review.opendev.org/65130816:23
openstackgerritStephen Finucane proposed openstack/nova master: db: Remove cell APIs  https://review.opendev.org/65130916:23
openstackgerritStephen Finucane proposed openstack/nova master: conf: Remove cells v1 options, group  https://review.opendev.org/65131016:23
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'ComputeManager._reschedule'  https://review.opendev.org/66077416:23
openstackgerritStephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance'  https://review.opendev.org/65131116:24
openstackgerritStephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance'  https://review.opendev.org/65131216:24
openstackgerritStephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance'  https://review.opendev.org/65131316:24
openstackgerritStephen Finucane proposed openstack/nova master: filters: Stop handling cells v1  https://review.opendev.org/65131416:24
openstackgerritStephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims  https://review.opendev.org/66052716:24
openstackgerritStephen Finucane proposed openstack/nova master: Ensure controllers all call super  https://review.opendev.org/66095016:24
sean-k-mooneyfor libvirt it already works16:24
phillwthat's cool, I'm on nodding terms with libvirt as I use it for my VMs :)16:24
mriedemsean-k-mooney: that patch is for making nvidia work with windows guests in libvirt16:25
mriedemthe existing support is for libvirt guests only16:25
sean-k-mooney* linux guests16:25
* aspiers finally hauls his Python IDE into the 21st century16:25
mriedemi never really understood the opposition to that patch since it's just doing the same thing for windows guests on kvm that we allow for linux guests16:26
mriedemi.e. we've already opened pandora's box there16:26
sean-k-mooneywe nack it however as we did not want to add a feature to specically workaound a driver check that is there to prevent you breaching nvidas eula16:26
mriedem*we already do*16:26
mriedemhttps://blueprints.launchpad.net/nova/+spec/hide-hypervisor-id-flavor-extra-spec16:26
sean-k-mooneythe hypervior hidden flag was not added for that use however16:26
sean-k-mooneyit was already there16:27
mriedemyes it was16:27
mriedemhttps://blueprints.launchpad.net/nova/+spec/add-kvm-hidden-feature16:27
mriedemhttps://review.opendev.org/#/c/459753/18//COMMIT_MSG@1416:27
mriedemso jay was +W on that change, but not this other one to allow the same thing for windows guests16:28
mriedemwhich i don't understand16:28
sean-k-mooneyhuh in that case i guess i dont know why we have not made it work for windows guests16:28
sean-k-mooneyi had under stood this was not sepcifcally for the nvida case but i guess it was16:28
openstackgerritStephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies  https://review.opendev.org/66203116:28
* phillw will be running C7 and eventually C8 at some point in the future :)16:28
mriedemthat said i don't see any cern people around to rev that patch16:30
mriedemor ovh people16:30
mriedemamorin: you're ovh right? do you guys want to revive this? https://review.opendev.org/#/c/579897/16:31
mriedemlooks like Maciej and Piotr cared about it at one point16:31
phillwon a not totally dissimilar topic, I was actually paying attention on my last C7 installation and it offers to install a compute instance. Am I correct in my reading that this is a nova instance?16:32
mriedemC7 = centos7?16:33
phillwyes, sorry16:33
mriedem"it offers to install a compute instance. Am I correct in my reading that this is a nova instance?" no idea16:33
jcosmaohi mriedem, i'll forward info to my teammate (i work at ovh also)16:33
mriedemjcosmao: thanks16:33
phillwmriedem: home work for me, then :)16:34
mriedemjust make tim do it16:34
openstackgerritMatt Riedemann proposed openstack/nova master: Refresh instance network info on deletion  https://review.opendev.org/66076116:35
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve E731 (do not assign a lambda expression, use a def)  https://review.opendev.org/65155416:39
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator)  https://review.opendev.org/65155516:39
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name)  https://review.opendev.org/65210316:39
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence)  https://review.opendev.org/65210416:39
*** dave-mccowan has joined #openstack-nova16:40
aspiersmriedem: does this look familiar to you? b'/home/zuul/src/opendev.org/openstack/nova/.tox/lower-constraints/lib/python3.6/site-packages/pymysql/cursors.py:167: Warning: (1831, "Duplicate index \'block_device_mapping_instance_uuid_virtual_name_device_name_idx\' defined on the table \'fjisjekoia.block_device_mapping\'. This is deprecated and will be disallowed in a future release.")'16:40
aspiersseems completely unrelated to my patch which is failing in the gate16:40
aspiersand I think I've seen it a few times in the last 24 hours16:40
*** ricolin has quit IRC16:42
aspiersoh, that's just a warning16:43
aspiersstill trying to find the real issue in http://logs.openstack.org/66/661266/4/gate/openstack-tox-lower-constraints/7af4be7/job-output.txt.gz16:43
aspiersI see a bunch of timeouts16:43
openstackgerritMerged openstack/os-vif stable/stein: Prevent "qbr" Linux Bridge from replying to ARP messages  https://review.opendev.org/65567816:45
kashyapaspiers: Remind me again, in 'os-traits' repo, what to do when 'tox' complains too long lines for a URL?16:47
aspierskashyap: isn't that just a warning?16:47
aspiersif not, I guess # noqa or similar16:47
kashyapaspiers: It moans an ERROR -- "E501 line too long (108 > 79 characters)"16:48
kashyapaspiers: Before I go off shortly, I'm pushing the change.  For convenience, I'm including a short "changelog" noting explicitly what I addressed16:48
kashyap... so that if you want to rebase on it tomm.16:48
aspierskashyap: http://flake8.pycqa.org/en/3.1.1/user/ignoring-errors.html#in-line-ignoring-errors16:49
aspiers# noqa: E50116:49
kashyapRight, thanks!16:49
*** davidsha has quit IRC16:53
mriedemaspiers: that duplicate index thing is super old yes16:53
*** derekh has quit IRC16:53
*** kmalloc_away is now known as kmalloc16:55
*** lbragstad has quit IRC16:59
*** lbragstad has joined #openstack-nova17:00
*** phillw has left #openstack-nova17:00
aspiersmriedem: the failures are very similar to https://bugs.launchpad.net/nova/+bug/1823251, but without the InterfaceError17:05
openstackLaunchpad bug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019 on limestone-regionone" [High,Confirmed]17:05
aspiersI wonder if the InterfaceError is just one symptom of a timeout17:06
aspiersMy timeouts show stuff like IndexError: tuple index out of range17:06
aspiersand 'sqlalchemy.exc.ResourceClosedError: This result object does not return rows. It has been closed automatically.'17:06
aspiersah, that latter one looks similar to https://bugs.launchpad.net/nova/+bug/179336417:08
openstackLaunchpad bug 1793364 in Manila "mysql db opportunistic unit tests timing out intermittently in the gate (bad thread switch?)" [Undecided,In progress] - Assigned to Goutham Pacha Ravi (gouthamr)17:08
mriedemright17:09
mriedemi've been down that road17:09
aspiersI guess elastic recheck will tell me as much when the other gate jobs finish17:10
openstackgerritKashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Rework the directory layout; add missing traits  https://review.opendev.org/65519317:11
*** priteau has joined #openstack-nova17:11
*** jcosmao has left #openstack-nova17:12
kashyapaspiers: When you get a moment, does the short change log address all things you want --^17:12
aspierskashyap: already looking at it17:12
kashyapThank you very much, sir.17:13
* aspiers wonders what the "ref: " is for, but I guess the precedent was already set on that17:13
kashyapaspiers: Yeah, I wondered, too.  Just cargo-culted it.17:14
aspiers+117:15
kashyapaspiers: Ah, thanks.  My focus was in Gerrit, and I saw the "Update" pop-up (your comment).  I was expecting a firm -1 :D17:15
aspiersOh ye of little faith :)17:16
kashyapOkay, now I cook food17:16
aspiersGood plan17:16
*** priteau has quit IRC17:33
gansolyarwood, melwitt, dansmith: Hello! When you have a minute, could you please take a look at those backports that are missing just a final +2? https://review.opendev.org/#/c/652153 , https://review.opendev.org/#/c/658136 and https://review.opendev.org/#/c/661349 ? Thanks in advance! =)17:35
gansotonyb: thanks a lot =D17:35
*** luksky has joined #openstack-nova17:41
*** maciejjozefczyk has quit IRC17:41
openstackgerritmelanie witt proposed openstack/nova master: Follow up for counting quota usage from placement  https://review.opendev.org/66205617:49
*** awalende has joined #openstack-nova17:55
*** ociuhandu has quit IRC17:57
*** awalende has quit IRC17:59
*** guozijn has joined #openstack-nova18:02
*** priteau has joined #openstack-nova18:04
*** guozijn has quit IRC18:07
*** guozijn has joined #openstack-nova18:18
*** guozijn has quit IRC18:22
melwittmriedem: replied to your comments on https://review.opendev.org/#/c/63807318:24
melwittand I dunno if you saw, but it looks like https://review.opendev.org/661391 fixes the novnc tests on the multi-cell job18:24
*** BjoernT_ has quit IRC18:33
*** panda|ruck has quit IRC18:35
*** priteau has quit IRC18:35
*** ralonsoh has quit IRC18:35
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug  https://review.opendev.org/64488118:36
openstackgerritArtom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration  https://review.opendev.org/65349818:36
openstackgerritArtom Lifshitz proposed openstack/nova master: [DNM] use iptables in nova-multinode  https://review.opendev.org/66078218:36
artommriedem, ^^ when you get some time, assuming unit tests pass (I've fixed all of them, normally). I think sean-k-mooney and I have finally figured it out.18:37
*** panda has joined #openstack-nova18:37
artomThe DNM patch is... optional? I'm not sure what we want to do upstream, but it's good to have it on top to show that both hybrid and normal plug work18:37
*** konetzed has joined #openstack-nova18:47
sean-k-mooneythe DNM patch change the job to use iptables. if we wanted to merge it we should add a second job that use iptable rather then changing multinode job to use it instead of the defualt contrack driver18:47
konetzedwill the scheduler honor setting ram_weight_multiplier as extra metadata on a host aggregate?  The goal is just to have one host aggregate stack vs spread.18:49
sean-k-mooneykonetzed:  i dont think so https://github.com/openstack/nova/blob/master/nova/scheduler/weights/ram.py18:50
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L108918:51
melwittkonetzed: to do that, I think you'd have to set ram_weight_multiplier as desired in the nova.conf of the compute hosts that are a member of the host aggregate you want to stack vs spread18:51
sean-k-mooneyactully look like it might18:51
melwittok, I didn't know that :\18:52
sean-k-mooneyneither did i i assume we broke that when we broke the allocation ratios18:52
sean-k-mooneyi guess not18:52
sean-k-mooneyits proably suppor fragile if the host is in two aggrates with different values18:53
*** BjoernT has joined #openstack-nova18:54
mriedemyou can have per-aggregate weights18:54
sean-k-mooneywell from the code yes but if a host is in two aggrates and they have differnt values im not sure what we do18:55
konetzedmelwitt: sean-k-mooney: thanks for the quick answer.18:55
mriedemhttps://docs.openstack.org/nova/latest/user/filter-scheduler.html#weights18:55
mriedem"If more than one value is found for a host in aggregate metadata, the minimum value will be used."18:56
mriedemdepends on the weigher18:56
mriedembut the docs are all tehre18:56
mriedem*there18:56
mriedemper-aggregate weights is new in stein18:56
mriedemyikun added it18:56
melwittkonetzed ^ updated answer :P sorry18:56
konetzedmriedem: thanks.  Looks like i need to update from Rocky ;)18:57
*** BjoernT_ has joined #openstack-nova18:59
*** BjoernT has quit IRC18:59
*** konetzed has quit IRC19:05
*** sapd1_x has joined #openstack-nova19:06
*** ociuhandu has joined #openstack-nova19:18
*** dklyle has quit IRC19:21
mriedemmelwitt: ack i'll get back to it in a bit19:26
melwittthanks19:26
mriedemunrelated plug for a question about the first stable stein release for anyone that has input http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006617.html19:27
mriedemotherwise i'll probably just punt and un-WIP the release patch19:27
sean-k-mooneymriedem: oh ya i ment to reply. i think adding a known issuse release not makes sense19:27
sean-k-mooneyim just not sure what it shoudl say19:28
*** dklyle has joined #openstack-nova19:29
mriedembtw is this the heartbeat thing we'd expect to see in the n-api logs for that bug http://logs.openstack.org/28/662028/1/experimental/tempest-pg-full/91f6094/controller/logs/screen-n-api.txt.gz?level=TRACE#_May_29_18_00_29_897709 ?19:33
mriedembecause it's all over these tempest-pg-full logs19:33
melwittI haven't actually seen that log for this.. when I reproduced it in devstack I only saw the "connection reset" error message from oslo.messaging. and some other messages about retrying/reconnecting19:36
mriedemi see lots of "missed heartbeats from client, timeout: 60s" in the rabbit logs19:37
mriedemhttp://logs.openstack.org/28/662028/1/experimental/tempest-pg-full/91f6094/controller/logs/rabbitmq/rabbit@ubuntu-bionic-rax-iad-0006739854_log.txt.gz19:37
sean-k-mooneyit looks like the tcp connection is also being closed19:37
*** konetzed has joined #openstack-nova19:38
sean-k-mooneymriedem: ya that is expected19:38
sean-k-mooneyif we dont disabel monkey patching or disabel the heartbeat then we will have missed heartbeat message in rabbitmq19:39
mriedemi guess my point is there was concern about not hitting this in the gate19:40
mriedemeven though we run with uwsgi in devstack and eventlet monkey-patched19:40
sean-k-mooneywell in the gate we should see this since we have 1 thread per wsgi process19:41
sean-k-mooneybut the api sould actuly still work19:41
melwittyeah, the gate is normally too busy with activity to cause the heartbeat interruption where the wsgi app pauses bc of lack of activity19:42
melwittso... I dunno how that's showing up in tempest-pg-full :\19:43
zigomriedem: Hey matt, thanks again for your patch, it fixed it for us. I've uploaded the fix to Sid, and hopefully it will be part of Buster (currently filling-up an unblock bug to the Debian release team).19:43
mriedemzigo: yw. as noted on the review, i'll likely be modifying that patch a bit.19:44
sean-k-mooneymelwitt: wll its not printing constantly so it posible that ocationally we do time out even in the gate19:44
melwitto19:45
mriedembrb19:48
*** mriedem has quit IRC19:48
efriedaspiers, kashyap: Minor tweaks to https://review.opendev.org/#/c/655193/ if either of you is around.19:50
aspierskashyap's gone I think19:50
aspiersand of course I'm not here19:50
efriedokay, nbd19:50
aspiersI wouldn't be so crazy as to be working at 9pm19:50
aspiershe said, while writing functional tests :-/19:51
sean-k-mooneymelwitt: you know one thing people could try is setting the ideal time for the wsgi server to like 300s instead of whatever teh default is19:53
sean-k-mooneyif you are not reciving at least 1 api request every 5 minutes to keep it alive you proabley dont need the performace boost from moneypatching19:54
sean-k-mooneyyou will endup useing more ram as the wsgi app will be loaded more often but its tradoffs nomater what we do19:55
melwittwell... what about in the middle of the night, when no one's using the api potentially? I feels like any deployment, no matter how large or busy, will have some down time at some point during the day19:55
*** mriedem has joined #openstack-nova19:55
*** imacdonn has quit IRC19:56
sean-k-mooneyin that case it will suspend after 5 mins and then the next request it recived it will reconnect19:56
*** imacdonn has joined #openstack-nova19:56
melwittok, so you're still talking in the context of threads=1 and just avoiding the scary heartbeat messages more19:56
sean-k-mooneybut if people want to reduce how often that log message is printed they can tweak how agress the wsgi server is at sleeping19:57
sean-k-mooneyya19:57
melwittI thought you were suggesting increasing the idle timeout as a way of allowing threads > 1 to work19:57
melwittok19:57
aspiersefried: I finally found MAX_INT in placement.db.constants, but that's not available from the unit testing testenvs19:57
efriedaspiers: Swear there was somewhere else we were using that.19:57
aspiersusing nova.db.constants for now19:57
aspiersbut that's not really correct19:58
aspierseven if they happen to be the same value19:58
*** ociuhandu has quit IRC19:58
aspiersefried: it's available to functional testenvs, but I need it in one unit test also19:58
melwittmriedem: I can take a stab at the stein reno and then have sean-k-mooney correct me because sean knows more than I do about it at this point19:58
efriedaspiers: You need it in your code too19:58
sean-k-mooneyaspiers: you could just use 2**64 or 2**3219:59
aspiersefried: well sure, but presumably it's safe to use placement from nova code?19:59
efriednot at all19:59
aspiershuh19:59
sean-k-mooneyaspiers: we cant import random parts of placement in nova19:59
aspiersOK20:00
efriedRight. Placement, from nova's perspective, is supposed to be purely a REST interface. Absolutely nothing else.20:00
efriedI think we're importing a fixture to make some testing easier20:00
efriedbut prod code should be purely REST touchpoints.20:00
aspiersSeems totally reasonable to me if it exported constants at least, if nothing else20:00
*** hongbin has joined #openstack-nova20:00
efriedyeah, I could get behind that in theory.20:00
efriedThere has been talk of making a placement20:00
efriedplacement-lib project20:01
sean-k-mooneywhy not just creat the constant in nova20:01
melwittsean-k-mooney: aside, I wonder did we ever get this sorted downstream in the bz's now that we know we should _not_ disable heartbeats20:01
aspierssean-k-mooney: like I said, I'm just using nova.db.constants.MAX_INT20:01
sean-k-mooneyif its a constant its not going to change often one would hope20:01
efriedwhich would contain things like os-traits and os-resource-classes as well as constants and test fixtures.20:01
artomWouldn't test fixtures go into oslo_test?20:01
efriednot placement test fixtures20:01
sean-k-mooneymelwitt: i think martin was going to try testing it with heatbeats disabel to see what happens20:01
aspiersnova.db.constants.MAX_INT isn't technically correct, but it's so damn close that I think it's good enough20:02
efriedaspiers: Yeah, was gonna say, as long as you use something you're sure is <= what placement can handle, "arbitrarily large" could be pretty much anything.20:02
artom31337 :D20:02
efriedYou could hard code it to 2000 and that would probably be fine.20:02
aspiersefried: actually answering that might breach an NDA ...20:03
melwittsean-k-mooney: hm... well, it will work on the surface but the issues dansmith pointed out were that rabbit will leave stale connections lying around in that case, so overall it's not a good idea to disable. hopefully martin will test that out as part of it20:03
sean-k-mooneyoh i did not know about the stale connection issue?20:03
aspiersartom: probably safer than 1337 ;)20:04
sean-k-mooneymelwitt: we we ar confident we should not disable heatbeats then we can save martin time and do?20:04
aspiersartom: which was one of the codes in one of the Denver escape rooms XD20:04
artomNoice.20:05
sean-k-mooneynothing? supress log? make ideal time 5 minuets for mod_wsgi?20:05
sean-k-mooneyi think the current situation is more or less lets figure out how to fix it upstream and then backport that fix upstream and downstream20:06
melwittsean-k-mooney: yes, based on the fact that rabbit will not clean up stale connections in that case, I don't think we should disable it. admittedly I don't understand a ton about this, but the docs recommend against disabling unless tcp keepalives are used in their place https://www.rabbitmq.com/heartbeats.html#disabling20:07
sean-k-mooneywe do use tcp keepalives20:08
sean-k-mooneyand we set it to like 1 second intervals20:08
sean-k-mooneytriplos defalts are pretty agressive in trying to keep the connection alive20:08
melwittthe only possible thing we could do with the logging, if oslo.messaging ppl are agreeable, would be to downgrade the "connection reset" message to WARNING and then set our log level to ERROR to hide it20:09
sean-k-mooneymelwitt: i was looking it python log filters a bit too20:09
melwittand then obviously we have to have threads=120:09
sean-k-mooneyi think we could intall a logfilter that would match on the oslo meesge and drop them too if oslo do not want to change the level20:10
mriedemmelwitt: ok, i'm torn between waffling over a reno on the issue and figuring out just the right words vs releasing what we have (which is quite a bit unreleased in stable/stein) and just letting the reno happen later if at all20:10
melwittoh, I see20:10
mriedemb/c i'm not an authority to review that reno20:10
melwittyeah, that's fair20:11
melwittwe don't need to do a release to get the reno out there right? it will just get published to the docs automatically20:11
sean-k-mooneymriedem: i dont think the reno is critcal jsut nice to have and sice we are still debating what the best solution is im not sure we should hold up the release for it20:11
melwittsean-k-mooney: ok, well, I guess according to that doc it's maybe probably ok to disable heartbeats if we have tcp keepalives in place https://www.rabbitmq.com/heartbeats.html#tcp-keepalives I think either way we'd want thorough testing of it before we go ahead and put the change out there20:15
sean-k-mooneymelwitt: this is what triplo configures https://github.com/openstack/tripleo-heat-templates/blob/d90434187315e96d3ebc184866dcd91954c0471d/deployment/kernel/kernel-baremetal-puppet.yaml#L117-L12220:19
*** xek_ has quit IRC20:21
sean-k-mooneyit looks like that is even more agressive then rabbitmqs suggestions https://www.rabbitmq.com/networking.html#tcp-keepalives20:21
melwittmriedem: ack20:22
melwittoops20:22
melwittsean-k-mooney: ack20:22
sean-k-mooney:)20:22
melwittmriedem: I'm fine either way releasing the reno now vs "soon" since AFAIK it doesn't have to be connected with the release, reno gets published independently. I was mostly saying I think we should publish a known issue vs not20:25
mriedemi removed the -WIP so the release gods can do as they please20:26
melwittk20:26
*** maciejjozefczyk has joined #openstack-nova20:35
*** ociuhandu has joined #openstack-nova20:35
*** sapd1_x has quit IRC20:41
*** maciejjozefczyk has quit IRC20:44
*** ociuhandu has quit IRC20:45
sean-k-mooneyfun fact. resize between flavor with different size hugepages is broken20:52
sean-k-mooneymainly becasue the nova.virt.hardware modeuld does not know what a rebuild or resize is and we end up using the page size form the embed instance numa toplogy instead of the new flavor/image20:53
*** slaweq has quit IRC21:03
*** itlinux has quit IRC21:05
*** wwriverrat has quit IRC21:08
*** slaweq has joined #openstack-nova21:11
*** whoami-rajat has quit IRC21:13
*** itlinux has joined #openstack-nova21:13
melwittsean-k-mooney: reading through the full comments on https://bugs.launchpad.net/nova/+bug/1829062 it doesn't look like it's the same issue as the pause/resume rabbit reconnecting thing we were talking about21:14
openstackLaunchpad bug 1829062 in StarlingX "nova placement api non-responsive due to eventlet error" [Critical,In progress] - Assigned to Gerry Kopec (gerry-kopec)21:14
mriedemmelwitt: replies to your replies in https://review.opendev.org/#/c/638073/31 but +W - some of the stuff in there could go into your FUP21:15
melwittI would expect their wsgi config is default threads=121:15
melwittmriedem: yaaaaaay thanks. will add to the FollowUP21:16
*** slaweq has quit IRC21:16
sean-k-mooneymelwitt: the fact that its complaining about resuming on a different thread implies they have treads!=121:16
sean-k-mooneybut part of the annoyance it that placmeent has never used eventlet and we only started monkeypatching it in stien after extracting placment21:17
melwittsean-k-mooney: o. yeah21:18
sean-k-mooneyso people running runnign placment under the non extract version are running a config that we really have not tested well at all21:18
sean-k-mooneysince the gate uses extracted placement21:18
melwittright21:19
melwittok, I'll throw another comment onto that bug to clarify the wsgi config thing21:19
melwittI'm trying to write the reno also21:19
sean-k-mooneyplacement is written assuming eventlet is not used so there might be dragons there wen run under eventlet in general21:19
sean-k-mooneyack21:20
melwittthis whole issue makes me :*****(21:20
melwitthave two paragraphs so far21:21
sean-k-mooneythere are too many ways to fix it all of which suck for different reasons21:21
*** priteau has joined #openstack-nova21:22
*** pcaruana has quit IRC21:23
mriedemtonyb: this is all yours https://review.opendev.org/#/c/655692/21:25
tonyb[m]mriedem: Okay I21:26
tonyb[m]'ll look after the school run21:26
*** priteau has quit IRC21:26
aspiersefried: you still around?21:27
efriedy21:27
aspiersturns out that placement's inventory policy hardcodes a minimum of 1, not 0, for resource class inventory :-/21:27
aspiersfor MEM_ENCRYPTION_CONTEXT, this is clearly a problem21:27
efriedwhy?21:28
aspiersthere are even explicit tests for this https://opendev.org/openstack/placement/src/branch/master/placement/tests/functional/gabbits/allocations.yaml#L10721:28
aspiersbecause hosts which can't do SEV need to be inventoried as 0 units21:28
efriedthe test you pointed to is for an *allocation* requesting zero units of a thing.21:29
aspiersyes, and it expects a 400 failure21:29
efriedI don't see the issue here.21:29
aspiersthe issue is that if I lower the minimum from 1 to 0 then these tests fail21:29
efried"lower the minimum" - of what?21:30
aspiersin the schema21:30
efriedargh, in *what* schema?21:30
aspiershttps://opendev.org/openstack/placement/src/branch/master/placement/schemas/inventory.py#L2921:30
aspierswithout that, MEM_ENCRYPTION_CONTEXT can't be inventoried as 021:30
efriedIf you can't do SEV, you don't put up any inventory of MEM_ENC_CTX. If you don't want SEV, you don't include MEM_ENC_CTX in your GET /a_c request or consequently in your allocation.21:31
aspiersmaybe we can tweak the schema to treat this resource class differently21:31
efriedYou never inventory a thing with 0 total21:31
efriedno21:31
efrieddo not muck with the schema21:31
aspiersohhh I see21:31
efriedthe schema is right21:31
aspiersOK, so just don't include it in the inventory21:31
efriedright21:31
aspierssounds good, I'll try that. thanks!21:31
efried++21:31
sean-k-mooneyaspiers: ya you only create an invetory if there is capasity to consume21:32
sean-k-mooneyso if a host does not support sev dont create an sev inventory on the RP21:32
openstackgerritmelanie witt proposed openstack/nova stable/stein: Add reno about nova-api eventlet monkey-patching and rabbitmq  https://review.opendev.org/66209521:34
openstackgerritMatt Riedemann proposed openstack/nova master: Fix hard-delete of instance with soft-deleted referential constraints  https://review.opendev.org/66139821:35
openstackgerritMatt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize  https://review.opendev.org/64180621:35
openstackgerritMatt Riedemann proposed openstack/nova master: Robustify attachment tracking in CinderFixtureNewAttachFlow  https://review.opendev.org/65890421:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid  https://review.opendev.org/61401221:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method  https://review.opendev.org/61403621:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add Instance.hidden field  https://review.opendev.org/63112321:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add TargetDBSetupTask  https://review.opendev.org/62789221:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask  https://review.opendev.org/63158121:35
openstackgerritMatt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask  https://review.opendev.org/63385321:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method  https://review.opendev.org/63329321:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask  https://review.opendev.org/62789021:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method  https://review.opendev.org/63483221:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image  https://review.opendev.org/63760521:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask  https://review.opendev.org/62789121:35
openstackgerritMatt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection  https://review.opendev.org/64218321:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method  https://review.opendev.org/64259021:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method  https://review.opendev.org/63508021:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask  https://review.opendev.org/63564621:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add archive_deleted_rows wrinkle to cross-cell functional test  https://review.opendev.org/65165021:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add CrossCellWeigher  https://review.opendev.org/61435321:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration  https://review.opendev.org/66185921:35
openstackgerritMatt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event  https://review.opendev.org/65847821:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API  https://review.opendev.org/63826921:35
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job  https://review.opendev.org/65665621:35
*** mriedem has quit IRC21:36
openstackgerritmelanie witt proposed openstack/nova stable/stein: Add reno about nova-api eventlet monkey-patching and rabbitmq  https://review.opendev.org/66209521:36
openstackgerritmelanie witt proposed openstack/nova stable/stein: Add reno about nova-api eventlet monkey-patching and rabbitmq  https://review.opendev.org/66209521:37
*** priteau has joined #openstack-nova21:39
*** jaypipes has quit IRC21:41
*** udesale has quit IRC21:43
openstackgerritMerged openstack/nova master: Fix the server group "policy" field type in api-ref  https://review.opendev.org/66186921:44
openstackgerritMerged openstack/nova master: docs: Don't version links to reno docs  https://review.opendev.org/66196721:45
*** eharney has quit IRC21:48
*** efried has quit IRC21:49
*** bbowen has quit IRC21:49
*** takashin has joined #openstack-nova21:49
*** BjoernT_ is now known as BjoernT21:51
*** priteau has quit IRC21:51
*** efried has joined #openstack-nova21:51
*** JamesBenson has quit IRC21:53
*** tjgresha has quit IRC22:07
*** slaweq has joined #openstack-nova22:11
*** slaweq has quit IRC22:16
openstackgerritAdam Spiers proposed openstack/nova master: WIP: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported  https://review.opendev.org/63868022:23
openstackgerritAdam Spiers proposed openstack/nova master: Track inventory for new MEM_ENCRYPTION_CONTEXT resource class  https://review.opendev.org/66210522:24
*** mlavalle has quit IRC22:32
aspiersefried: brand new patch added to the top of the SEV series ^^^22:33
efriedyup, looking at the series now.22:33
aspiersThis should be the last of the detection / inventory changes. The remaining ones are all about actually consuming the results of that and booting an SEV guest.22:34
aspiersLooking at http://specs.openstack.org/openstack/nova-specs/specs/train/approved/amd-sev-libvirt-support.html#work-items, there are now Gerrit reviews (some merged) for the first 6 out of 11 MVP work items. So halfway ... kinda :)22:35
aspiers#7 is gonna be the tough one22:36
aspiersThe others are mostly polish22:36
aspiersAlright, I'm done for today22:37
openstackgerritMerged openstack/nova master: cleanup evacuated instances not on hypervisor  https://review.opendev.org/51262322:41
*** BjoernT has quit IRC22:43
*** tkajinam has joined #openstack-nova22:54
*** awalende has joined #openstack-nova23:00
*** _erlon_ has quit IRC23:03
*** artom has quit IRC23:05
*** awalende has quit IRC23:05
*** rcernin has joined #openstack-nova23:06
*** rcernin has quit IRC23:07
*** rcernin has joined #openstack-nova23:07
*** macza has quit IRC23:09
*** luksky has quit IRC23:13
*** lbragstad has quit IRC23:34
*** lbragstad has joined #openstack-nova23:34
*** artom has joined #openstack-nova23:42
*** tbachman has quit IRC23:54
*** ccamacho has quit IRC23:58
*** tbachman has joined #openstack-nova23:59
« Tuesday, 2019-05-28 Index Thursday, 2019-05-30 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!