| openstackgerrit | sean mooney proposed openstack/nova master: extend libvirt video model support https://review.opendev.org/647733 | 00:03 |
|---|---|---|
| *** macza has quit IRC | 00:03 | |
| *** rcernin has quit IRC | 00:17 | |
| *** rcernin has joined #openstack-nova | 00:18 | |
| *** rcernin has quit IRC | 00:49 | |
| *** rcernin has joined #openstack-nova | 00:50 | |
| *** markvoelker has quit IRC | 01:05 | |
| *** whoami-rajat has joined #openstack-nova | 01:06 | |
| *** hongbin has joined #openstack-nova | 01:10 | |
| *** ricolin has joined #openstack-nova | 01:13 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027 | 01:14 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031 | 01:14 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299 | 01:15 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344 | 01:15 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673 | 01:16 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676 | 01:16 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689 | 01:21 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709 | 01:22 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712 | 01:22 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens https://review.opendev.org/637716 | 01:23 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.opendev.org/566153 | 01:23 |
| *** BjoernT has quit IRC | 01:24 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix a description for config_drive parameter https://review.opendev.org/653683 | 01:26 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.opendev.org/641200 | 01:26 |
| *** guozijn has joined #openstack-nova | 01:44 | |
| *** BjoernT has joined #openstack-nova | 01:51 | |
| openstackgerrit | guangchao.pan proposed openstack/nova stable/ocata: OpenDev Migration Patch https://review.opendev.org/661662 | 01:56 |
| *** tbachman has joined #openstack-nova | 01:57 | |
| openstackgerrit | guangchao.pan proposed openstack/nova master: Add a name for the automatically created volume https://review.opendev.org/660096 | 02:11 |
| *** Spencer_Yu has joined #openstack-nova | 02:15 | |
| *** udesale has quit IRC | 02:15 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 02:27 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration https://review.opendev.org/653498 | 02:27 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] use iptables in nova-multinode https://review.opendev.org/660782 | 02:27 |
| *** gmann has quit IRC | 02:31 | |
| *** takashin has left #openstack-nova | 02:32 | |
| *** cfriesen has quit IRC | 02:42 | |
| *** _alastor_ has joined #openstack-nova | 02:43 | |
| *** _alastor_ has quit IRC | 02:47 | |
| *** hoonetorg has quit IRC | 02:56 | |
| *** markvoelker has joined #openstack-nova | 03:06 | |
| openstackgerrit | Seyeong Kim proposed openstack/nova stable/queens: Share snapshot image membership with instance owner https://review.opendev.org/661667 | 03:10 |
| *** hoonetorg has joined #openstack-nova | 03:13 | |
| *** jamesdenton has quit IRC | 03:20 | |
| *** licanwei has joined #openstack-nova | 03:21 | |
| *** psachin has joined #openstack-nova | 03:21 | |
| *** markvoelker has quit IRC | 03:40 | |
| *** tbachman has quit IRC | 03:45 | |
| *** tbachman has joined #openstack-nova | 03:50 | |
| *** abhishekk has joined #openstack-nova | 04:09 | |
| *** ileixe has quit IRC | 04:09 | |
| *** ileixe has joined #openstack-nova | 04:11 | |
| *** ratailor has joined #openstack-nova | 04:19 | |
| *** imacdonn has quit IRC | 04:20 | |
| *** imacdonn has joined #openstack-nova | 04:21 | |
| *** pcaruana has joined #openstack-nova | 04:22 | |
| *** ykarel|afk has joined #openstack-nova | 04:31 | |
| *** ivve has quit IRC | 04:32 | |
| *** markvoelker has joined #openstack-nova | 04:37 | |
| *** psachin has quit IRC | 04:39 | |
| *** psachin has joined #openstack-nova | 04:40 | |
| Spencer_Yu | https://bugs.launchpad.net/nova/+bug/1830669 | 04:40 |
| openstack | Launchpad bug 1830669 in OpenStack Compute (nova) "Telemetry service can not get right "operator" of nova resources from notification" [Undecided,New] | 04:40 |
| *** hongbin has quit IRC | 04:49 | |
| *** janki has joined #openstack-nova | 04:51 | |
| *** ykarel|afk is now known as ykarel | 05:10 | |
| *** markvoelker has quit IRC | 05:10 | |
| *** ykarel_ has joined #openstack-nova | 05:13 | |
| *** ykarel has quit IRC | 05:15 | |
| *** ykarel__ has joined #openstack-nova | 05:16 | |
| *** ykarel_ has quit IRC | 05:19 | |
| *** jchhatbar has joined #openstack-nova | 05:27 | |
| *** janki has quit IRC | 05:30 | |
| *** ileixe has quit IRC | 05:33 | |
| *** ivve has joined #openstack-nova | 05:38 | |
| *** BjoernT has quit IRC | 05:40 | |
| *** cfriesen has joined #openstack-nova | 05:40 | |
| *** sridharg has joined #openstack-nova | 05:43 | |
| *** lpetrut has joined #openstack-nova | 06:01 | |
| *** guozijn has quit IRC | 06:03 | |
| *** guozijn has joined #openstack-nova | 06:04 | |
| *** abhishekk has quit IRC | 06:06 | |
| *** markvoelker has joined #openstack-nova | 06:07 | |
| openstackgerrit | zhaixiaojun proposed openstack/nova master: Blacklist python-cinderclient 4.0.0 https://review.opendev.org/661578 | 06:10 |
| *** ykarel__ is now known as ykarel|afk | 06:14 | |
| *** Spencer_Yu has quit IRC | 06:15 | |
| *** ccamacho has joined #openstack-nova | 06:18 | |
| *** sridharg has quit IRC | 06:20 | |
| *** slaweq has joined #openstack-nova | 06:22 | |
| *** Spencer_Yu has joined #openstack-nova | 06:25 | |
| *** tetsuro has joined #openstack-nova | 06:25 | |
| *** Spencer_Yu has quit IRC | 06:30 | |
| *** dpawlik has joined #openstack-nova | 06:32 | |
| *** sridharg has joined #openstack-nova | 06:35 | |
| *** sridharg has quit IRC | 06:37 | |
| openstackgerrit | Guo Jingyu proposed openstack/nova master: Define and catch QemuGuestAgentNotRunning for set-password failure https://review.opendev.org/661466 | 06:38 |
| *** markvoelker has quit IRC | 06:40 | |
| *** Spencer_Yu has joined #openstack-nova | 06:44 | |
| *** macza has joined #openstack-nova | 06:45 | |
| *** Spencer_Yu has quit IRC | 06:48 | |
| *** macza has quit IRC | 06:50 | |
| *** cfriesen has quit IRC | 06:50 | |
| *** ykarel|afk is now known as ykarel | 06:55 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:57 | |
| *** Spencer_Yu has joined #openstack-nova | 06:57 | |
| openstackgerrit | Guo Jingyu proposed openstack/nova master: Define and catch QemuGuestAgentNotRunning for set-password failure https://review.opendev.org/661466 | 06:58 |
| *** rpittau|afk is now known as rpittau | 07:02 | |
| *** awalende has joined #openstack-nova | 07:04 | |
| *** takamatsu has joined #openstack-nova | 07:07 | |
| *** tetsuro has quit IRC | 07:09 | |
| *** yikun has joined #openstack-nova | 07:09 | |
| *** jhesketh has quit IRC | 07:11 | |
| *** ricolin_ has joined #openstack-nova | 07:12 | |
| *** tesseract has joined #openstack-nova | 07:12 | |
| *** takamatsu has quit IRC | 07:13 | |
| *** ricolin has quit IRC | 07:15 | |
| *** jhesketh has joined #openstack-nova | 07:29 | |
| *** helenafm has joined #openstack-nova | 07:29 | |
| *** logan- has quit IRC | 07:33 | |
| *** logan- has joined #openstack-nova | 07:36 | |
| *** markvoelker has joined #openstack-nova | 07:37 | |
| openstackgerrit | Adrian Chiris proposed openstack/nova stable/stein: Allow driver to properly unplug VIFs on destination on confirm resize https://review.opendev.org/661495 | 07:39 |
| *** xek_ has joined #openstack-nova | 07:48 | |
| openstackgerrit | Adrian Chiris proposed openstack/nova stable/rocky: Move get_pci_mapping_for_migration to MigrationContext https://review.opendev.org/661499 | 07:49 |
| openstackgerrit | Adrian Chiris proposed openstack/nova stable/rocky: Allow driver to properly unplug VIFs on destination on confirm resize https://review.opendev.org/661500 | 07:49 |
| *** tetsuro has joined #openstack-nova | 07:51 | |
| kashyap | sean-k-mooney: I first checked in this channel where to put that doc, and was suggested the reference guide (doc/source/reference). | 07:57 |
| gibi | Spencer_Yu: replied in https://bugs.launchpad.net/nova/+bug/1830669 | 07:58 |
| openstack | Launchpad bug 1830669 in OpenStack Compute (nova) "Telemetry service can not get right "operator" of nova resources from notification" [Undecided,New] | 07:58 |
| *** ykarel is now known as ykarel|lunch | 08:00 | |
| kashyap | sean-k-mooney: I think it actually belongs to the nova/doc/source/admin | 08:07 |
| *** markvoelker has quit IRC | 08:10 | |
| *** gmann has joined #openstack-nova | 08:13 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations https://review.opendev.org/637954 | 08:13 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: pull out put_allocation call from _heal_* https://review.opendev.org/655459 | 08:13 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.opendev.org/637955 | 08:13 |
| *** yan0s has joined #openstack-nova | 08:20 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif stable/rocky: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655692 | 08:22 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655694 | 08:23 |
| *** awalende_ has joined #openstack-nova | 08:25 | |
| *** ralonsoh has joined #openstack-nova | 08:26 | |
| *** awalende has quit IRC | 08:29 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: Document mitigation for Intel MDS security flaws https://review.opendev.org/661574 | 08:29 |
| *** awalende_ has quit IRC | 08:30 | |
| *** tetsuro has quit IRC | 08:38 | |
| *** mgoddard has joined #openstack-nova | 08:41 | |
| mrch_ | this is funny, when you start an instance on a 100GB volume, fill it with >DATA< importatnt, its saved in ceph in raw, when you create a snapshot(in incance menu not volume) nova creates a 0Byte QCOW2 image snapshot and a volume snapshot (2x wtf?!), start instance from image snapshot and /var/lib/cinder/conversion/volume-XXXX will eat up your apinode root disk, thats dogsht isnt it? following is kind of decribing it, but volume to image | 08:47 |
| mrch_ | is fixed already in rocky, vm on volume to image not, it produces raw: https://bugzilla.redhat.com/show_bug.cgi?id=1677054 Has anyone touched nova.conf qcow parameter and validated it:https://docs.openstack.org/nova/rocky/configuration/config.html | 08:47 |
| openstack | bugzilla.redhat.com bug 1677054 in openstack-glance "[osp 13]Creating images from cinder volumes with ceph backend is very inefficient" [Medium,New] - Assigned to cyril | 08:47 |
| *** frankwang has joined #openstack-nova | 08:52 | |
| *** derekh has joined #openstack-nova | 08:52 | |
| *** sapd1_x has joined #openstack-nova | 08:53 | |
| *** tetsuro has joined #openstack-nova | 08:57 | |
| *** priteau has joined #openstack-nova | 08:58 | |
| ralonsoh | stephenfin, hi. How should I proceed here? https://github.com/openstack/os-vif/blob/stable/queens/tox.ini | 09:00 |
| ralonsoh | stephenfin, in Queens there is no CONSTRAINTS_OPT=-c {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h=stable/rocky} | 09:00 |
| ralonsoh | stephenfin, and https://review.opendev.org/#/c/655694/ is failing because of sphinx | 09:01 |
| ralonsoh | stephenfin, actually, in Queens, requirements doesn't have https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L431 | 09:02 |
| *** markvoelker has joined #openstack-nova | 09:07 | |
| *** sapd1_x has quit IRC | 09:10 | |
| sean-k-mooney | ralonsoh: stephenfin is at the cern openstackday | 09:10 |
| ralonsoh | sean-k-mooney, hahaha now I remember | 09:10 |
| sean-k-mooney | ralonsoh: are you not currently backporting that | 09:10 |
| sean-k-mooney | the upper constratits | 09:10 |
| ralonsoh | sean-k-mooney, no, I shouldn't because is useless | 09:11 |
| sean-k-mooney | no its not | 09:11 |
| ralonsoh | sean-k-mooney, I can't use queens/requirements because sphinx is not limited in this version | 09:11 |
| sean-k-mooney | why would the upper-constratints be useless | 09:11 |
| sean-k-mooney | then you need to update the requirements repo to limit it | 09:12 |
| ralonsoh | sean-k-mooney, OK, and then submit a patch only for queens/os-vif to include it | 09:12 |
| ralonsoh | sean-k-mooney, is that correct? | 09:12 |
| *** tkajinam has quit IRC | 09:13 | |
| sean-k-mooney | ya so cap sphix in the requrement repo for stable queens and then backport https://github.com/openstack/os-vif/commit/96b5a11d35d74faf7c9866dceef66984dbcddae6 | 09:14 |
| sean-k-mooney | actully i can go start backporting ^ | 09:14 |
| sean-k-mooney | well if you dont get to it today | 09:14 |
| sean-k-mooney | i need to go do something first but we shoudl not be capping locally in os-vif | 09:15 |
| sean-k-mooney | ralonsoh: actully sphinx is already capped in queens | 09:16 |
| sean-k-mooney | https://github.com/openstack/requirements/blob/stable/queens/upper-constraints.txt#L365 | 09:16 |
| sean-k-mooney | os-vif just need to use the constratis file | 09:16 |
| ralonsoh | sean-k-mooney, that's right | 09:16 |
| ralonsoh | sean-k-mooney, I don't need to modify requirements | 09:16 |
| sean-k-mooney | right just backport that patch | 09:16 |
| ralonsoh | sean-k-mooney, I'll submit a patch for os-vif today modifying tox.ini | 09:16 |
| sean-k-mooney | i whould have done that when i wrote it | 09:17 |
| ralonsoh | sean-k-mooney, thanks! | 09:17 |
| sean-k-mooney | can you submit it to all active stable brances | 09:17 |
| *** boxiang has joined #openstack-nova | 09:17 | |
| ralonsoh | sean-k-mooney, hahahaha | 09:18 |
| ralonsoh | sean-k-mooney, https://review.opendev.org/#/c/658780/ | 09:18 |
| sean-k-mooney | right i had tought you had done this already | 09:18 |
| mrch_ | anyone tapped into ^10:47 | 09:18 |
| ralonsoh | sean-k-mooney, my short memory | 09:18 |
| *** minmin has joined #openstack-nova | 09:18 | |
| *** jchhatba_ has joined #openstack-nova | 09:18 | |
| sean-k-mooney | ralonsoh: it looks like you did not rebase ontop of the constratists fix when you updated https://review.opendev.org/#/c/655694/7 | 09:20 |
| ralonsoh | sean-k-mooney, you are right | 09:21 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655694 | 09:21 |
| *** jchhatbar has quit IRC | 09:21 | |
| *** aarents__ has joined #openstack-nova | 09:23 | |
| openstackgerrit | Balazs Gibizer proposed openstack/os-traits master: Add REPORT_PARENT_INTERFACE_NAME_FOR_SRIOV_NIC trait https://review.opendev.org/658852 | 09:25 |
| gibi | lyarwood: hi! I've replied in https://review.opendev.org/#/c/512553/12//COMMIT_MSG@12 If we could agree with the way forward then I can redo the patch series | 09:30 |
| lyarwood | gibi: ack thanks, I'll check shortly | 09:31 |
| *** ykarel|lunch is now known as ykarel | 09:33 | |
| kashyap | lyarwood: Do you also have an opinion on the question I asked in the commit message: https://review.opendev.org/#/c/661574/ ("Document mitigation for Intel MDS security flaws") | 09:34 |
| kashyap | (Thanks for the review, BTW) | 09:34 |
| lyarwood | kashyap: replied, lets open another review for the meltdown doc if you already have something written. | 09:39 |
| kashyap | lyarwood: Yeah, it would be another change indeed. Just wanted to make sure if we _want_ to do it or not. | 09:39 |
| *** markvoelker has quit IRC | 09:40 | |
| lyarwood | kashyap: I can't think why we wouldn't if you already have some text etc | 09:40 |
| lyarwood | gibi: replied, I'd be happy with that approach. | 09:41 |
| kashyap | lyarwood: Heh, yeah. (The text has been sitting there for a while) | 09:41 |
| gibi | lyarwood: thanks. I will re-shuffle the changes accordingly | 09:43 |
| *** jcosmao has joined #openstack-nova | 09:48 | |
| *** sapd1_x has joined #openstack-nova | 09:54 | |
| *** ricolin_ has quit IRC | 10:02 | |
| *** dpawlik has quit IRC | 10:06 | |
| *** cdent has joined #openstack-nova | 10:07 | |
| *** dpawlik has joined #openstack-nova | 10:18 | |
| *** frankwang has quit IRC | 10:19 | |
| *** aarents__ has quit IRC | 10:22 | |
| *** dpawlik has quit IRC | 10:22 | |
| *** tetsuro has quit IRC | 10:26 | |
| *** dpawlik has joined #openstack-nova | 10:35 | |
| *** markvoelker has joined #openstack-nova | 10:37 | |
| *** dpawlik has quit IRC | 10:40 | |
| *** jaypipes has joined #openstack-nova | 10:42 | |
| *** tbachman has quit IRC | 10:42 | |
| *** guozijn has quit IRC | 10:43 | |
| *** bbowen has quit IRC | 10:43 | |
| *** k4bi has quit IRC | 10:44 | |
| *** jaypipes has quit IRC | 10:46 | |
| *** odyssey4me has left #openstack-nova | 10:49 | |
| *** awalende has joined #openstack-nova | 10:52 | |
| *** jaypipes has joined #openstack-nova | 10:58 | |
| *** dpawlik has joined #openstack-nova | 11:02 | |
| *** sridharg has joined #openstack-nova | 11:06 | |
| *** markvoelker has quit IRC | 11:11 | |
| *** dave-mccowan has joined #openstack-nova | 11:13 | |
| *** psachin has quit IRC | 11:14 | |
| *** guozijn has joined #openstack-nova | 11:16 | |
| *** ttsiouts has joined #openstack-nova | 11:33 | |
| *** ratailor has quit IRC | 11:35 | |
| *** ttsiouts has quit IRC | 11:38 | |
| *** macza has joined #openstack-nova | 11:39 | |
| *** Spencer_Yu has quit IRC | 11:40 | |
| *** macza has quit IRC | 11:43 | |
| *** psachin has joined #openstack-nova | 11:57 | |
| *** bbowen has joined #openstack-nova | 11:58 | |
| *** aarents has joined #openstack-nova | 12:00 | |
| *** markvoelker has joined #openstack-nova | 12:06 | |
| *** tbachman has joined #openstack-nova | 12:07 | |
| *** lbragstad has joined #openstack-nova | 12:09 | |
| *** guozijn_ has joined #openstack-nova | 12:12 | |
| *** priteau has quit IRC | 12:13 | |
| *** priteau has joined #openstack-nova | 12:14 | |
| *** guozijn has quit IRC | 12:15 | |
| *** guozijn_ is now known as guozijn | 12:15 | |
| *** cmart has joined #openstack-nova | 12:26 | |
| *** _erlon_ has joined #openstack-nova | 12:26 | |
| *** derekh has quit IRC | 12:27 | |
| *** chason has joined #openstack-nova | 12:31 | |
| openstackgerrit | Merged openstack/nova stable/stein: [stable-only] Improve the reno for consoleauth upgrade check https://review.opendev.org/661123 | 12:33 |
| artom | cdent, you know, you'd think with an extensive portfolio of NFV customer who use NUMA but seldom participate upstream, you'd think RH would have a way of asking them en masse about their preferred use cases | 12:35 |
| cdent | one would hope so, but it seems hard for everyone, not just RH | 12:36 |
| *** boxiang has quit IRC | 12:36 | |
| *** boxiang has joined #openstack-nova | 12:37 | |
| artom | cdent, well, with the "upstream" operators, we can just send off a thing to the mailing list. It's not perfect, but it's a start | 12:37 |
| artom | To my knowledge, no such mechanism exists for our customers | 12:37 |
| sean-k-mooney | we try to infer that based on the bugs that get reported but ya we dotn really have a good way of doing it | 12:37 |
| cdent | one gets the impression that the number of operators actively engaged with email is ... limited | 12:38 |
| sean-k-mooney | there is proably some marketing list that you can opt in to get survays and such but i doubt that apporch would get much feedback | 12:39 |
| artom | I suspect the majority of operators are paying customers | 12:39 |
| artom | So they expect their provider to do that work for them | 12:39 |
| cdent | I'm worried in this instance that we are solving a real/legit problem in the wrong place, but I have nothing other than "feelings" to support that | 12:40 |
| artom | As we all | 12:41 |
| cdent | and I certainly don't have any internal customer stuff to support any of that: we continue to not expose any numa details | 12:41 |
| sean-k-mooney | was tehre a partical thing that propted this topic? | 12:41 |
| artom | And I suspect this isn't the first or last occurence of such problem solving | 12:41 |
| artom | sean-k-mooney, https://review.opendev.org/#/c/658510/ | 12:41 |
| cdent | sean-k-mooney: we're taling about can_split | 12:41 |
| sean-k-mooney | of declaring that a resouce class can come form multiple rps for numa an dsuch | 12:41 |
| cdent | sean-k-mooney: I'm trying to make sure that we are solving for the real problem, rather than what is possible. | 12:42 |
| cdent | there's lots of useful interaction on the spec, please join in if you've got thoughts | 12:42 |
| artom | We do have a thing that analyses sosreports (our "all the things" automated log reporting tool for bugs) | 12:43 |
| sean-k-mooney | ill try too but it will be a while | 12:43 |
| sean-k-mooney | e.g later today/tomorrow | 12:43 |
| artom | We could try to pull hardware/workload info out of that | 12:43 |
| sean-k-mooney | im currentlytrying to find a downstream bug fix | 12:43 |
| cdent | i'm feeling a bit "sure we _can_ split, but do we want to?" | 12:43 |
| artom | There's selection bias for those who actually report logs, but it's a start | 12:43 |
| *** donnyd has joined #openstack-nova | 12:43 | |
| artom | Don't think we could get instance to host mapping info out of it, though | 12:44 |
| artom | *report bugs | 12:44 |
| sean-k-mooney | cdent: the only use case i have for can split i think is when i ask for more cpu then might resonable fit on one numa node so i say you can split that if that is required | 12:44 |
| sean-k-mooney | but that only really makes sese for non numa guests | 12:44 |
| sean-k-mooney | *sense | 12:45 |
| artom | Well that was the main driver IIUC - fitting non-NUMA guests on NUMA host when every host is presenting itself as a tree | 12:45 |
| artom | Anyways, need to drive kids to daycare | 12:46 |
| sean-k-mooney | artom: right you only want to use can split for cpus ro memroy if you dont care about numa toplogy | 12:47 |
| sean-k-mooney | all hosta are numa hosts even most high end mainstream desktop systems these days | 12:47 |
| *** derekh has joined #openstack-nova | 12:57 | |
| *** cmart has quit IRC | 12:58 | |
| *** igordc has joined #openstack-nova | 12:59 | |
| *** sridharg has quit IRC | 12:59 | |
| *** dave-mccowan has quit IRC | 13:00 | |
| cdent | sean-k-mooney: they are, but they don't have to declare that they are | 13:02 |
| *** sridharg has joined #openstack-nova | 13:02 | |
| sean-k-mooney | that is true. i think its clean to always declare them as such but im not oposed to not doing that | 13:06 |
| sean-k-mooney | i kind of always felt that the root resouce provdier shoudl not be owned by any one service and we should therefor not have inventories in it | 13:07 |
| sean-k-mooney | mainly to make it simpler for neutron cyborg and other serivce to creat resouces on the same host that are not managed by nova in plcement | 13:08 |
| sean-k-mooney | but that is tangentel to split vs non split | 13:08 |
| *** jchhatba_ has quit IRC | 13:08 | |
| *** jchhatba_ has joined #openstack-nova | 13:08 | |
| *** mriedem has joined #openstack-nova | 13:15 | |
| *** guozijn_ has joined #openstack-nova | 13:16 | |
| *** yonglihe_ has joined #openstack-nova | 13:17 | |
| *** beekneemech is now known as bnemec | 13:18 | |
| *** BjoernT has joined #openstack-nova | 13:19 | |
| *** guozijn has quit IRC | 13:19 | |
| *** guozijn_ is now known as guozijn | 13:19 | |
| *** purplerbot has quit IRC | 13:20 | |
| yonglihe_ | sean-k-mooney: would you like to put this on your review queue, thanks. https://review.opendev.org/#/c/658716/ | 13:20 |
| *** purplerbot has joined #openstack-nova | 13:20 | |
| *** priteau has quit IRC | 13:20 | |
| sean-k-mooney | ah reporting the numa toplogy via the api sure ill take a look | 13:20 |
| yonglihe_ | sean-k-mooney: thanks, looking forward to your comments! | 13:21 |
| *** psachin has quit IRC | 13:24 | |
| *** _alastor_ has joined #openstack-nova | 13:27 | |
| *** BjoernT has quit IRC | 13:32 | |
| *** bbowen has quit IRC | 13:34 | |
| *** guozijn_ has joined #openstack-nova | 13:35 | |
| *** guozijn has quit IRC | 13:37 | |
| *** guozijn_ is now known as guozijn | 13:37 | |
| *** guozijn_ has joined #openstack-nova | 13:40 | |
| *** BjoernT has joined #openstack-nova | 13:41 | |
| zigo | When I attempt to migrate an instance, I get this in nova-api.log: http://paste.openstack.org/show/752159/ | 13:42 |
| zigo | What's going on, and how to fix? | 13:42 |
| *** guozijn has quit IRC | 13:42 | |
| *** guozijn_ is now known as guozijn | 13:42 | |
| *** rnoriega_ is now known as rnoriega|afk | 13:42 | |
| *** DinaBelova has joined #openstack-nova | 13:43 | |
| *** dkehn has joined #openstack-nova | 13:46 | |
| *** priteau has joined #openstack-nova | 13:46 | |
| *** rnoriega|afk is now known as rnoriega_ | 13:47 | |
| *** rnoriega_ is now known as rnoriega | 13:51 | |
| *** jchhatba_ has quit IRC | 13:55 | |
| *** awalende has quit IRC | 13:57 | |
| *** awalende has joined #openstack-nova | 13:57 | |
| *** wwriverrat has joined #openstack-nova | 13:59 | |
| *** Woutifier has joined #openstack-nova | 14:00 | |
| *** awalende_ has joined #openstack-nova | 14:00 | |
| *** amodi has joined #openstack-nova | 14:01 | |
| *** awalende has quit IRC | 14:02 | |
| zigo | cdent: Any idea what can cause this? http://paste.openstack.org/show/752159/ | 14:02 |
| cdent | zigo: looking | 14:02 |
| zigo | Is Nova looking for a server group that doesn't exist? | 14:03 |
| *** awalende_ has quit IRC | 14:05 | |
| mriedem | zigo: what release? | 14:06 |
| zigo | mriedem: Rocky. | 14:06 |
| * cdent passes ball to mriedem | 14:06 | |
| zigo | :P | 14:06 |
| mriedem | was the server group deleted? | 14:06 |
| cdent | zigo: i would have flailed | 14:07 |
| zigo | mriedem: I don't think so, it just went into our availability zone called "AZ3" ... | 14:07 |
| zigo | So I get "properties group='AZ3'" when doing server show. | 14:08 |
| *** rpittau is now known as rpittau|afk | 14:08 | |
| mriedem | so it's blowing up here https://github.com/openstack/nova/blob/stable/rocky/nova/objects/request_spec.py#L523 which makes me think the request spec was stored with an instance group without a uuid | 14:10 |
| mriedem | is this an old instance? | 14:10 |
| zigo | mriedem: No. | 14:11 |
| zigo | It's a fairly recent deployment. | 14:11 |
| aarents | Hello! Do you still have any concern regarding this: https://review.opendev.org/#/c/659054 can we workflow+1 ? mriedem | 14:11 |
| mriedem | zigo: so you just created a server in a group and then tried to cold migrate or resize it and it blows up like this? | 14:12 |
| zigo | mriedem: Someone created a server, the compute had a hardware issue, it rebooted, then I get no connectivity with that instance anymore (ovs-vsctl shows some qvo devices missing) so I'm trying to migrate it to fix the networking problem. | 14:13 |
| zigo | Then I get a 500 error ... | 14:14 |
| zigo | I'm trying to cold migrate indeed. | 14:14 |
| zigo | And the trace is what is shown in nova-api.log when doing "nova server migrate" of that instance. | 14:14 |
| mriedem | ok are you able to dump the request_specs entry for that instance? it should be a json blob. | 14:15 |
| zigo | mriedem: How do I do that? | 14:15 |
| zigo | You mean debugging ? | 14:15 |
| zigo | Or just looking in the db? | 14:15 |
| mriedem | select spec from nova_api.request_specs where instance_uuid=<instance id>; | 14:15 |
| zigo | mriedem: http://paste.openstack.org/show/752161/ | 14:18 |
| *** itlinux has quit IRC | 14:19 | |
| mriedem | i could see where we could hit an issue by setting an instance_group on the request spec without a uuid here https://github.com/openstack/nova/blob/stable/rocky/nova/objects/request_spec.py#L228 but that is meant to be some legacy code | 14:19 |
| mriedem | which is why i asked if it were an old instance | 14:19 |
| zigo | mriedem: Migrating worked perfectly for other instances ... | 14:20 |
| zigo | mriedem: How do I migrate to another availability zone? | 14:20 |
| mriedem | the server group and the az are different things | 14:21 |
| mriedem | server group is a grouping of ... servers. az is a grouping of compute hosts | 14:21 |
| zigo | Right. | 14:21 |
| zigo | :) | 14:21 |
| mriedem | since this server was created in a specific az, you can't migrate it out of that az unless you bypass the az filter in the scheduler | 14:21 |
| mriedem | like by forcefully bypassing the scheduler, which you can't do with cold migrate | 14:22 |
| zigo | mriedem: I find it annoying that it seems like Nova picks-up an availability zone and stick every instance to it, even if in some cases, I don't want it to do that. | 14:22 |
| mriedem | there is definitely a busted request spec for this instance though http://paste.openstack.org/show/752162/ | 14:22 |
| mriedem | zigo: nova doesn't make servers go into an az by default | 14:23 |
| zigo | Ah... | 14:23 |
| zigo | :) | 14:23 |
| *** mlavalle has joined #openstack-nova | 14:23 | |
| mriedem | the user either requests an az during server create or the operator configures the cloud to default to a specific az | 14:23 |
| mriedem | in fact i have a docs patch for that :) https://review.opendev.org/#/c/650444/2 | 14:24 |
| *** jdillaman has joined #openstack-nova | 14:24 | |
| *** guozijn has quit IRC | 14:24 | |
| *** guozijn has joined #openstack-nova | 14:24 | |
| sean-k-mooney | yonglihe_: comments are on the spec. mainly some typos other then that the content seams fine | 14:25 |
| zigo | Weird, the instance spec shows: | 14:25 |
| zigo | "group": [ "295c99ea-2db6-469a-877f-454a3903a8d8" ] (which has the name "dockerdev") | 14:25 |
| zigo | However, nova server show tells me: group='AZ3' | 14:25 |
| mriedem | zigo: i think somehow we're hitting this https://github.com/openstack/nova/blob/stable/rocky/nova/objects/request_spec.py#L228 and that's causing the problem, but i'm not sure how yet | 14:25 |
| mriedem | i can see AZ3 is the az from the request spec | 14:27 |
| mriedem | "availability_zone": "AZ3", | 14:27 |
| zigo | Yes. | 14:27 |
| *** dpawlik has quit IRC | 14:29 | |
| *** lpetrut has quit IRC | 14:30 | |
| mriedem | i'm not sure what that group field is in nova server show... | 14:31 |
| mriedem | nova cli or osc? | 14:31 |
| zigo | osc | 14:32 |
| mriedem | zigo: do you know if this server has been moved before? | 14:32 |
| zigo | mriedem: I don't think it has. | 14:32 |
| zigo | It has not. | 14:32 |
| mriedem | did you check the instance actions records? | 14:33 |
| *** itlinux has joined #openstack-nova | 14:33 | |
| * zigo is checking | 14:33 | |
| zigo | mriedem: Nothing except my attempts. | 14:34 |
| mriedem | and you're sure this instance was created from that rocky deployment? | 14:35 |
| *** ykarel has quit IRC | 14:35 | |
| *** dasp has quit IRC | 14:36 | |
| mriedem | i think we're somehow saving off a half-baked RequestSpec.instance_group after one failed attempt maybe and then that's causing a new issue loading the group from that busted request spec where the group.uuid isn't set | 14:37 |
| zigo | mriedem: Yes, this cloud deployment has never been using something older. | 14:37 |
| mriedem | i.e. we're hitting https://github.com/openstack/nova/blob/stable/rocky/nova/objects/request_spec.py#L228, saving that, and then failing later here https://github.com/openstack/nova/blob/stable/rocky/nova/objects/request_spec.py#L523 | 14:37 |
| zigo | mriedem: Can I somehow just patch my request_spec db entry? | 14:38 |
| mriedem | you'd have to load http://paste.openstack.org/show/752161/ from json, update the instance_group["nova_object.data"] and set the uuid field to "295c99ea-2db6-469a-877f-454a3903a8d8" | 14:39 |
| mriedem | to match that group scheduler hint | 14:39 |
| mriedem | and then serialize and update that db record | 14:39 |
| mriedem | could also be hitting a reschedule loop which in rocky, the compute didn't pass the request spec back to conductor on reschedule (during resize/cold-migrate) so conductor has to build it's own request spec, that might be why we're only getting a half-baked version | 14:43 |
| *** guozijn has quit IRC | 14:44 | |
| mriedem | anyway, i'm not sure what the recreate is, but i can definitely see where we could not have a requestspec.instance_group.uuid so we should probably have a check for that in RequestSpec._from_db_object | 14:45 |
| mriedem | zigo: have you reported a bug? | 14:45 |
| zigo | mriedem: I don't think I'd be a good reporter for this one, I don't know enough about the internals of this request_spec stuff to know what's going on. | 14:46 |
| zigo | That's the first time I see this json output in fact. | 14:46 |
| mriedem | you don't need to know the internals to report the bug, just what is happening and how you think you got here | 14:47 |
| zigo | Ok. | 14:47 |
| zigo | mriedem: Has nova moved to storyboard yet? | 14:47 |
| mriedem | no | 14:47 |
| mriedem | still lp | 14:47 |
| mriedem | my guess is something like this happened: 1. create server in a group, 2. cold migrate the server which fails on host A and does a reschedule to host B which maybe also fails (would be good to know if previous cold migration attempts failed with reschedules), 3. try to cold migrate again which fails with the instance_group.uuid thing | 14:48 |
| *** tbachman has quit IRC | 14:49 | |
| mriedem | the reschedule might be the key b/c like i said conductor has to rebuild a request spec and i think that's probably where we're doing a partial build of the request spec but missing the group uuid | 14:49 |
| *** AmanKSinha__ has joined #openstack-nova | 14:51 | |
| *** ykarel has joined #openstack-nova | 14:53 | |
| zigo | mriedem: https://bugs.launchpad.net/nova/+bug/1830747 | 14:56 |
| openstack | Launchpad bug 1830747 in OpenStack Compute (nova) "Error 500 trying to migrate an instance after wrong request_spec" [Undecided,New] | 14:56 |
| mriedem | zigo: yup, thanks | 14:56 |
| zigo | mriedem: I'm trying to add the uuid to the db entry, as you suggested. | 14:56 |
| *** bbowen has joined #openstack-nova | 14:56 | |
| *** lpetrut has joined #openstack-nova | 14:59 | |
| *** dklyle has joined #openstack-nova | 14:59 | |
| *** cfriesen has joined #openstack-nova | 15:00 | |
| *** udesale has joined #openstack-nova | 15:00 | |
| *** hemna has joined #openstack-nova | 15:01 | |
| *** cmart has joined #openstack-nova | 15:02 | |
| zigo | mriedem: I think it all starts with this: | 15:03 |
| zigo | 2019-05-28 15:02:35.534 30706 ERROR nova.compute.manager [instance: ae6f8afe-9c64-4aaf-90e8-be8175fee8e4] nova.exception.UnableToMigrateToSelf: Unable to migrate instance (ae6f8afe-9c64-4aaf-90e8-be8175fee8e4) to current host (clint1-compute-5.infomaniak.ch). | 15:03 |
| zigo | (not sure) | 15:03 |
| *** ivve has quit IRC | 15:03 | |
| mriedem | are you requesting a target host when doing the cold migration? | 15:04 |
| zigo | Nop. | 15:08 |
| zigo | There's 3 computes on this AZ. | 15:08 |
| zigo | mriedem: I just migrated another VM on the same compute, and it went fine. | 15:09 |
| zigo | For that one instance, I had request_spec: "instance_group": null | 15:09 |
| mriedem | yeah so that server wasn't in a group | 15:10 |
| zigo | Right. | 15:10 |
| zigo | mriedem: Maybe I can just remove the group from that other instance then? | 15:10 |
| zigo | (that one failing ...) | 15:10 |
| mriedem | that would break the affinity policy for that server | 15:10 |
| *** yan0s has quit IRC | 15:11 | |
| mriedem | zigo: i can generate a patch for you quick if you're in a position to try it | 15:13 |
| zigo | I can ... :) | 15:13 |
| mriedem | ok i'll work on something quick | 15:13 |
| zigo | I can always apt-get install --reinstall python3-nova to go back to what it was. | 15:13 |
| *** ykarel is now known as ykarel|away | 15:13 | |
| zigo | (safely) | 15:13 |
| zigo | mriedem: I'll have to go back home in 40 minutes though. | 15:14 |
| openstackgerrit | Merged openstack/python-novaclient master: Add a description of --on-shared-storage https://review.opendev.org/661527 | 15:15 |
| mriedem | ack, should have this up in 5 min | 15:16 |
| *** hamzy has quit IRC | 15:18 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: extract baselineCPU API call from _get_cpu_traits() https://review.opendev.org/661782 | 15:18 |
| *** hemna has quit IRC | 15:19 | |
| *** AmanKSinha__ has quit IRC | 15:19 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: extract baselineCPU API call from _get_cpu_traits() https://review.opendev.org/661782 | 15:20 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add functional test for bug 1550919 https://review.opendev.org/631294 | 15:20 |
| openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | 15:20 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846 | 15:20 |
| *** hemna has joined #openstack-nova | 15:21 | |
| aspiers | kashyap: hope that refactoring is OK ^^^ | 15:22 |
| *** guozijn has joined #openstack-nova | 15:27 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/661786 | 15:27 |
| mriedem | zigo: ^ needs tests and to be prettied up but it should workaround the issue given the request spec you showed me | 15:27 |
| kashyap | aspiers: Hiya | 15:29 |
| *** tbachman has joined #openstack-nova | 15:31 | |
| zigo | mriedem: Is this for nova-conductor ? | 15:31 |
| zigo | In which node should I apply it? | 15:31 |
| mriedem | api and conductor | 15:31 |
| zigo | mriedem: Ok, then restart conductor and API, I guess ... | 15:32 |
| mriedem | yup | 15:32 |
| *** mrch_ has quit IRC | 15:33 | |
| kashyap | aspiers: Nice; no test to prove that "nothing is broken" with the refactoring, I presume? | 15:34 |
| aspiers | kashyap: the existing tests should cover it. Refactoring => no change in functionality to test :) | 15:35 |
| *** itlinux has quit IRC | 15:35 | |
| kashyap | aspiers: Right | 15:35 |
| kashyap | I like the change, it makes things clearer. (And I intend to refactor _get_guest_baseline_cpu_features() in turn later as part of the CPU modelling spec) | 15:36 |
| *** ykarel|away has quit IRC | 15:38 | |
| *** lpetrut has quit IRC | 15:38 | |
| aspiers | kashyap: the follow-up patch to add the SEV trait will rename _get_cpu_traits() to _get_cpu_feature_traits() and _get_cpu_traits() will wrap around it | 15:38 |
| *** guozijn has quit IRC | 15:40 | |
| kashyap | aspiers: Yep, nod. | 15:40 |
| aspiers | kashyap: coming up in a few secs | 15:40 |
| gibi | mriedem: I've fixed your comments in https://review.opendev.org/#/c/652608/ | 15:41 |
| zigo | mriedem: I still get a 500 error ... | 15:41 |
| *** macza has joined #openstack-nova | 15:41 | |
| *** jdillaman has quit IRC | 15:42 | |
| *** jdillaman has joined #openstack-nova | 15:42 | |
| mriedem | zigo: do you have a paste of the logs? | 15:43 |
| mriedem | note i added some debug logging | 15:43 |
| zigo | mriedem: name "LOG" is undefined ... | 15:44 |
| zigo | Problem with the logging ... :P | 15:44 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Provide HW_CPU_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | 15:44 |
| *** macza has quit IRC | 15:44 | |
| *** JamesBenson has joined #openstack-nova | 15:44 | |
| mriedem | ah the LOG didn't exist in rocky... | 15:44 |
| mriedem | i'll remove the logging | 15:44 |
| aspiers | kashyap: https://review.opendev.org/#/c/638680/15/nova/virt/libvirt/driver.py@9638 | 15:44 |
| *** macza has joined #openstack-nova | 15:45 | |
| aspiers | kashyap: keeps the SEV bit nicely separated from the CPU feature code | 15:45 |
| aspiers | efried: this should make you happy too :) | 15:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/661786 | 15:46 |
| mriedem | zigo: ^ | 15:46 |
| mriedem | gibi: huh i thought that was approved by now | 15:46 |
| efried | aspiers: Sans click, I'm still gonna say "what about the HW_CPU_X86_AMD_SEV trait?" | 15:46 |
| kashyap | aspiers: A naming nit: "_kernel_supports_amd_sev" --> "_kernel_support_for_amd_sev"? | 15:47 |
| aspiers | efried: haha, thanks for the reminder | 15:47 |
| gibi | mriedem: I would like to get it approved :) | 15:47 |
| aspiers | kashyap: why? | 15:47 |
| efried | aspiers: Maybe kashyap incorporated it in his patch, I haven't looked yet. | 15:47 |
| kashyap | aspiers: Maybe not. It returns either true or false, so as it stands is okay :-) | 15:48 |
| * aspiers finally goes to catch up on the epic traits renaming reviews | 15:48 | |
| zigo | mriedem: Thanks a lot, unfortunately, I have to go, so I'll try tomorrow. | 15:48 |
| kashyap | efried: Morning; I addressed your remarks and made them part of the older PS; and even added a note in your patch to adjust the Depends-On ID | 15:48 |
| efried | kashyap: ack, saw it go by, haven't looked yet. Will take me a day or two to catch up from "holiday". | 15:49 |
| *** hamzy has joined #openstack-nova | 15:49 | |
| efried | kashyap: and thank you :) | 15:49 |
| kashyap | efried: Take your sweet time | 15:49 |
| * efried 's time is sweet | 15:49 | |
| aspiers | efried: OK now here's a reoccurrence of that gerrit limitation we discussed before, but it's worse this time, because I'm not in control of all the reviews involved | 15:49 |
| efried | aspiers: which one? | 15:50 |
| efried | oh, can't branch upside down? | 15:50 |
| aspiers | right | 15:50 |
| mriedem | zigo: ack - also i have triaged how we get here in rocky | 15:50 |
| mriedem | zigo: will have the details in the bug report | 15:50 |
| mriedem | it | 15:50 |
| mriedem | it's the reschedule and such that is the problem as i suspected | 15:50 |
| aspiers | 638680 depends on some of my stuff (e.g. the patch_open helper and the _get_cpu_traits() refactor I just submitted), but now it also needs to depend on kashyap's traits reworking | 15:50 |
| mriedem | request spec bites me in the ass yet again | 15:50 |
| aspiers | efried: which are distinctly orthogonal strands of development | 15:51 |
| efried | aspiers: traits reworking in os-traits or traits reworking in nova? | 15:51 |
| *** helenafm has quit IRC | 15:51 | |
| aspiers | efried: ahhh good point! can use Depends-On here | 15:52 |
| efried | aspiers: Well, theoretically yes | 15:52 |
| aspiers | ... I think | 15:52 |
| efried | except I figured out last week that it doesn't bloody work | 15:52 |
| aspiers | :-/ | 15:52 |
| aspiers | I'll give it a go anyway | 15:52 |
| efried | You would have to hack up .zuul.yaml to make os-traits a required project for all the jobs. | 15:52 |
| efried | which is a regal PITA | 15:53 |
| aspiers | why? | 15:53 |
| efried | but go ahead and depends-on it and we'll just get the damn thing merged and released and requirementsed | 15:53 |
| efried | why what? | 15:53 |
| aspiers | why would .zuul.yaml need to be hacked? | 15:53 |
| efried | because otherwise zuul will ignore your depends-on. | 15:53 |
| mriedem | depends-on won't pull in your os-traits change w/o changing required-projects | 15:53 |
| mriedem | we shouldn't do that anyway imo | 15:54 |
| efried | and we don't want to make that ^ permanent, because we generally want to test against released os-traits | 15:54 |
| mriedem | b/c we could forget to release os-traits and bump the min required versions | 15:54 |
| mriedem | correct | 15:54 |
| efried | mriedem: My take is that we should be allowed to do it as long as the dep switches off as soon as it merges | 15:55 |
| mriedem | that's putting a lot of trust into people remembering all of these knobs | 15:55 |
| efried | that is, nova X depends on os-traits Y, so while Y is still open, X will build against it. As soon as Y merges, X goes back to testing against whatever the requirements-specified version is. | 15:55 |
| aspiers | are the zuul folks aware of this issue? | 15:55 |
| mriedem | aspiers: it's by design | 15:55 |
| efried | aspiers: Yes, it's a feature, not a bug. | 15:56 |
| efried | what mriedem said | 15:56 |
| mriedem | it's like how LIBS_FROM_GIT worked in the old days | 15:56 |
| aspiers | without thinking hard or having the experience of you two, it sounds like a deficiency in the design? | 15:56 |
| efried | aspiers: I agree it would be nice if there was a (straightforward) way around it, for just this reason. | 15:56 |
| aspiers | like mriedem says, requiring people to remember sounds like a UX bug to me | 15:57 |
| efried | I want to make sure my nova patch will build against the os-traits I'm about to release, without having to release it first to try it. | 15:57 |
| efried | I can test locally to some extent by hacking up my venv | 15:57 |
| efried | but I can't e.g. test the dsvms locally. | 15:57 |
| efried | or even run all of unit and/or functional locally without the fire department standing by. | 15:57 |
| aspiers | is there a good reason *not* to honour Depends-On if the dependency is missing from required-projects? | 15:58 |
| kashyap | Trying to open nova/tests/unit/virt/libvirt/test_driver.py in GitHub tells me: "(Sorry about that, but we can’t show files that are this big right now.)" | 15:58 |
| kashyap | ["But we can render lots of crap that clutters your view"] | 15:58 |
| efried | aspiers: Point is, Depends-On will normally build against the dep, but block your patch from merging until the dep merges. If we allowed your patch to merge once the dep merges, world breaks because nova is still building against released os-traits and your os-traits patch hasn't been released yet. | 15:59 |
| * efried <== meeting... | 15:59 | |
| *** cmart has quit IRC | 15:59 | |
| mriedem | aspiers: this is not a new problem, this is how things have always worked for depending on library changes | 15:59 |
| aspiers | mriedem: OK thanks | 15:59 |
| mriedem | which is why i -1 changes that depend on the library change directly rather than the upper-constraints bump for whatever released version of the library contains that change | 15:59 |
| mriedem | you can test the things in the gate with the required-projects hack | 16:00 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: cleanup evacuated instances not on hypervisor https://review.opendev.org/512623 | 16:01 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove global state from the FakeDriver https://review.opendev.org/656709 | 16:01 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.opendev.org/512552 | 16:01 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add functional test coverage for bug 1724172 https://review.opendev.org/512553 | 16:01 |
| openstack | bug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,In progress] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer) | 16:01 |
| aspiers | kashyap: see also https://github.com/isaacs/github/issues/587 | 16:01 |
| mriedem | bauzas: you may enjoy https://bugs.launchpad.net/nova/+bug/1830747 | 16:01 |
| openstack | Launchpad bug 1830747 in OpenStack Compute (nova) "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] - Assigned to Matt Riedemann (mriedem) | 16:01 |
| kashyap | aspiers: Ah, thanks | 16:02 |
| kashyap | aspiers: It is the Website Obesity problem: https://idlewords.com/talks/website_obesity.htm | 16:02 |
| aspiers | kashyap: although that's for diffs | 16:02 |
| gibi | lyarwood: made it backportable as we discussed https://review.opendev.org/#/c/512623 | 16:03 |
| *** wwriverrat has quit IRC | 16:03 | |
| aspiers | kashyap: "I contend that text-based websites should not exceed in size the major works of Russian literature." ROFL | 16:03 |
| kashyap | aspiers: Indeed! | 16:04 |
| aspiers | This page is amazing. "In a misguided attempt at cultural sensitivity, I have chosen to represent the consumer with a kangaroo." | 16:05 |
| kashyap | aspiers: I appreciate websites like npr.org (although, I only rarely read it) that provide plain text websites, without all the bloat that is, JavaScript and the advertizing bat shit | 16:05 |
| kashyap | aspiers: Yeah, it's a very well-written article. | 16:06 |
| *** yonglihe_ has quit IRC | 16:06 | |
| *** tesseract has quit IRC | 16:06 | |
| aspiers | I might have to watch the video | 16:07 |
| *** ykarel|away has joined #openstack-nova | 16:09 | |
| *** ricolin_ has joined #openstack-nova | 16:10 | |
| mriedem | gibi: i'll re-review your spec quick if you can review this quick https://review.opendev.org/#/c/661398/ | 16:12 |
| *** rha has quit IRC | 16:12 | |
| mriedem | *not if, just pelase | 16:12 |
| mriedem | *please | 16:12 |
| *** rha has joined #openstack-nova | 16:14 | |
| *** mrch_ has joined #openstack-nova | 16:14 | |
| mriedem | gibi: a few nits in your spec if you can respin quick, but you might be done already | 16:18 |
| mriedem | if so i can address those quick and +2 | 16:18 |
| *** gyee has joined #openstack-nova | 16:20 | |
| *** maciejjozefczyk has quit IRC | 16:21 | |
| *** ivve has joined #openstack-nova | 16:22 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Server move operations with ports having resource request https://review.opendev.org/652608 | 16:23 |
| *** minmin has quit IRC | 16:31 | |
| *** itlinux has joined #openstack-nova | 16:35 | |
| *** hemna has quit IRC | 16:39 | |
| *** itlinux has quit IRC | 16:43 | |
| *** hemna has joined #openstack-nova | 16:46 | |
| cdent | cfriesen: you might have thoughts on the discussion that starts near http://eavesdrop.openstack.org/irclogs/%23openstack-placement/%23openstack-placement.2019-05-28.log.html#t2019-05-28T16:20:51 | 16:46 |
| *** itlinux has joined #openstack-nova | 16:46 | |
| cfriesen | looking | 16:46 |
| cdent | cfriesen: the spec in question is https://review.opendev.org/658510 | 16:47 |
| cfriesen | cdent: there is a flaw in the current handling of 4K pages which means that you can't mix numa and non-numa instances using 4k pages on the same host. | 16:48 |
| *** dpawlik has joined #openstack-nova | 16:48 | |
| *** wwriverrat has joined #openstack-nova | 16:54 | |
| cdent | cfriesen: if you've got a chance to dig at that spec that would be great. i've got to take off for today | 16:55 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | 16:55 |
| *** wwriverrat has quit IRC | 16:55 | |
| cfriesen | cdent: will try. I left a comment elaborating a bit on the 4k page thing | 16:56 |
| cdent | thanks | 16:56 |
| *** cdent has left #openstack-nova | 16:57 | |
| aspiers | efried, mriedem: https://review.opendev.org/#/c/638680/16 temporarily adds os-traits to .zuul.yaml. I've put W-1 since IIUC we don't want to merge it like that. | 16:57 |
| aspiers | kashyap: I guess you should be aware too ^^^ | 16:57 |
| *** itlinux has quit IRC | 16:58 | |
| aspiers | mriedem: you want the comment inline, or in the commit message? | 16:59 |
| aspiers | would be nice if there was a magic string in commit messages which prevented zuul from merging | 16:59 |
| *** derekh has quit IRC | 17:00 | |
| mriedem | aspiers: i have a magic -2 | 17:00 |
| mriedem | aspiers: inline | 17:00 |
| *** ricolin_ has quit IRC | 17:00 | |
| mriedem | and prefix your commit title with WIP: | 17:00 |
| mriedem | so -W isn't lost between rebases | 17:00 |
| aspiers | OK | 17:00 |
| aspiers | IIRC, -2 is sticky across patchsets and has to be explicitly removed? | 17:01 |
| aspiers | would be good if mortals could achieve something equivalent | 17:01 |
| *** itlinux has joined #openstack-nova | 17:01 | |
| aspiers | I'm suggesting it in #zuul | 17:01 |
| aspiers | probably more of a Gerrit thing actually | 17:04 |
| *** sapd1_x has quit IRC | 17:05 | |
| *** sridharg has quit IRC | 17:05 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | 17:06 |
| *** irclogbot_3 has quit IRC | 17:17 | |
| *** irclogbot_3 has joined #openstack-nova | 17:19 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | 17:19 |
| efried | aspiers: I'm pretty confused about the rebasing state of all your patches. | 17:25 |
| aspiers | efried: how can I help with that? | 17:25 |
| efried | are you working on rebasing all of them to be in one chain? | 17:25 |
| aspiers | only where necessary | 17:25 |
| aspiers | my goals, in decreasing order, are: 1) correctness, 2) ease of review, 3) minimise churn on CI resources | 17:26 |
| *** spatel has joined #openstack-nova | 17:27 | |
| aspiers | it did recently occur to me that I could (theoretically, in a parallel universe where time is unconstrained) teach git-review to automatically rebase as necessary by using my git-deps module | 17:27 |
| efried | what I mean is, for example, https://review.opendev.org/#/c/661782/2 is based on https://review.opendev.org/#/c/661266/3 when PS4 is available (and merging). And then https://review.opendev.org/#/c/638680/18 is based on https://review.opendev.org/#/c/661782/2, but https://review.opendev.org/#/c/636334/5 is based on https://review.opendev.org/#/c/638680/14 | 17:29 |
| aspiers | efried: that's because I forgot that you submitted PS4 | 17:30 |
| aspiers | efried: I just based it on the latest PS I had locally, without thinking | 17:30 |
| efried | okay, my fault on that one | 17:30 |
| aspiers | haha, hardly :) | 17:30 |
| aspiers | but I'll generously share some of the blame with you if you insist ;) | 17:31 |
| efried | anyway, as a reviewer I'm basically too confused to jump in atm | 17:31 |
| aspiers | looking at the other ones now | 17:31 |
| efried | which is fine, I have lots to keep me busy, not like I'm sitting on my hands waiting for this to be ready. | 17:31 |
| efried | just want you to be aware that I'm likely to wait until there's no orange dots or green tildes on the right before I dig in. | 17:32 |
| spatel | sean-k-mooney: hey | 17:32 |
| efried | aspiers: (are you aware of the meaning of the orange dots and green tildes?) | 17:32 |
| aspiers | OK, so essentially you want me to ditch my third goal? which is totally fine by me | 17:32 |
| aspiers | yep, I had figured that out | 17:32 |
| aspiers | I can understand the desire to eliminate orange dots. Why do you want to avoid green tildes though? | 17:33 |
| efried | aspiers: well, I may be telling you that you may be reversing goals 2 and 3 :) at least from my pov | 17:34 |
| aspiers | ACK, just trying to understand the cause of the confusion | 17:34 |
| efried | because it means that those patches are based on older versions of these | 17:34 |
| efried | it's usually a signal that you're still in the process of rebasing and cleaning things up. | 17:34 |
| *** igordc has quit IRC | 17:34 | |
| aspiers | ... which in the third example you listed is true | 17:34 |
| *** ykarel|away has quit IRC | 17:34 | |
| efried | which is reinforced by having just WIP'd one near the bottom | 17:35 |
| efried | anyway, again, I'm not trying to hurry you along. | 17:35 |
| aspiers | I don't mind being hurried :) | 17:35 |
| *** ykarel|away has joined #openstack-nova | 17:35 | |
| efried | just wanted to confirm that you're still shuffling the paperwork, as opposed to thinking you're ready for reviews and then getting frustrated when they don't happen | 17:35 |
| aspiers | Well, this is a very useful discussion | 17:36 |
| aspiers | It highlights that the unavoidable impact of deciding not to review anything within a given topic until all tildes and dots are gone, is that every time I need to change something minor lower in the dependency tree, I have to rebase every single thing above it before the new patchset gets reviewed | 17:37 |
| aspiers | To me this highlights a failure in Gerrit's UI | 17:37 |
| efried | or a failure in my method of working. | 17:38 |
| aspiers | Ideally reviews would only be blocked if stale stuff is *below* them, not above | 17:38 |
| efried | "blocked" is a bit strong | 17:38 |
| efried | It's just the typical workflow I see (and use) is, when something needs to be fixed on a lower patch, download the whole series, git restack, fix the issues below, which automatically rebases the rest of the way up, and resubmit the whole series. | 17:39 |
| efried | Agree that consumes a lot of CI resources | 17:39 |
| efried | but it also ensures that the top changes will legitimately work with however the lower changes have been altered. | 17:39 |
| aspiers | Sure | 17:39 |
| aspiers | I'm not saying I want to avoid rebasing things | 17:39 |
| aspiers | Just wondering if the presence of WIP higher up the tree should have an impact on stuff lower in the tree | 17:40 |
| aspiers | If I understand the Gerrit UI correctly, we're talking about whether a patch in the Related Changes list has dots or tildes *below* it, right? | 17:41 |
| efried | I'm not sure it's possible to have tildes below or dots above. | 17:42 |
| aspiers | Oh, good point | 17:42 |
| efried | I mean, technically possible, but you would really have to be trying. | 17:42 |
| efried | ...unless you're looking at a PS that itself has a dot | 17:42 |
| efried | anyway | 17:42 |
| efried | the presence of WIP higher in the tree (which is not the same thing as a tilde, btw) should not impact reviews lower. | 17:42 |
| efried | so this is probably just me being used to one workflow and you using a different one to (rightly) try to conserve CI resources. | 17:43 |
| aspiers | Well, it's also about me needing to pay more attention to orange dots in Related Changes, so I can spot when rebases are needed | 17:44 |
| efried | moot right now because I've reviewed everything up to the first one that's actually titled WIP, so regardless of colored decorations, I'm stopping here. | 17:44 |
| aspiers | the WIP one is only marked WIP because of the required-projects hack. Other than that I think it's ready to go | 17:44 |
| efried | but yeah, usually a patch that's riding an orange dot should be rebased if it's to get serious attention. | 17:44 |
| aspiers | At least, other than rebasing (which I'll do now) I've run out of improvements to make to it | 17:45 |
| aspiers | I put WIP on it because mriedem asked me to, but the only element of WIP there is that kashyap's os-traits patch hasn't landed and been released yet. | 17:46 |
| aspiers | efried: also, since we're putting the workflow under the microscope, should I be putting the SEV blueprint: in the commit message and topic for changes like refactorings, which aren't per se SEV-related, but still form part of the SEV series? | 17:48 |
| efried | nah | 17:48 |
| aspiers | ok | 17:48 |
| *** ttsiouts has joined #openstack-nova | 17:49 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: extract baselineCPU API call from _get_cpu_traits() https://review.opendev.org/661782 | 17:50 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | 17:53 |
| *** igordc has joined #openstack-nova | 17:55 | |
| *** igordc has quit IRC | 17:55 | |
| *** igordc has joined #openstack-nova | 17:55 | |
| *** priteau has quit IRC | 17:56 | |
| openstackgerrit | Merged openstack/nova-specs master: Update SEV work item to new approach based on MEM_ENCRYPTION_CONTEXT https://review.opendev.org/655717 | 17:58 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | 17:59 |
| *** ttsiouts has quit IRC | 17:59 | |
| aspiers | efried: got rid of some orange dots | 18:01 |
| *** ykarel|away has quit IRC | 18:01 | |
| *** itlinux has quit IRC | 18:02 | |
| *** hongbin has joined #openstack-nova | 18:03 | |
| * aspiers wonders how the hell the Linux kernel and git communities get anything done at all reviewing by email | 18:04 | |
| *** cmart has joined #openstack-nova | 18:05 | |
| aspiers | (and that's from someone who's worked with them) | 18:05 |
| *** hemna has quit IRC | 18:15 | |
| *** hemna has joined #openstack-nova | 18:16 | |
| *** itlinux has joined #openstack-nova | 18:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/661786 | 18:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression recreate test for bug 1830747 https://review.opendev.org/661822 | 18:17 |
| openstack | bug 1830747 in OpenStack Compute (nova) "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] https://launchpad.net/bugs/1830747 - Assigned to Matt Riedemann (mriedem) | 18:17 |
| mriedem | zigo: with a functional recreate test of the issue ^ | 18:17 |
| *** efried has quit IRC | 18:17 | |
| *** efried has joined #openstack-nova | 18:18 | |
| *** wwriverrat has joined #openstack-nova | 18:19 | |
| *** wwriverrat has quit IRC | 18:21 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Reduce logging of host hypervisor capabilities to DEBUG level https://review.opendev.org/661379 | 18:24 |
| *** imacdonn has quit IRC | 18:33 | |
| ganso | lyarwood, melwitt, dansmith, tonyb: Hello! When you have a minute, could you please take a look at those backports? https://review.opendev.org/#/c/652153 , https://review.opendev.org/#/c/658136 and https://review.opendev.org/#/c/661349 ? Thanks in advance! =) | 18:34 |
| *** wwriverrat has joined #openstack-nova | 18:41 | |
| *** wwriverrat has quit IRC | 18:42 | |
| *** wwriverrat has joined #openstack-nova | 18:43 | |
| aspiers | efried: if CONF.libvirt.num_memory_encrypted_guests is not set and therefore defaults to None (meaning as we agreed in the spec, "auto-detect the inventory, if if this isn't possible, don't impose any limit), what should the MEM_ENCRYPTION_CONTEXT inventory get set to? | 18:44 |
| aspiers | I'm not sure we came to a consensus with jaypipes on this http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-04-23.log.html#t2019-04-23T17:55:57 | 18:44 |
| *** lpetrut has joined #openstack-nova | 18:47 | |
| *** wwriverrat has quit IRC | 18:47 | |
| efried | aspiers: MAXINT | 18:48 |
| jaypipes | aspiers: not sure you need any consensus. :) | 18:49 |
| aspiers | jaypipes: OK :) | 18:51 |
| *** lpetrut has quit IRC | 18:51 | |
| *** itlinux has quit IRC | 19:09 | |
| *** tstrul has joined #openstack-nova | 19:11 | |
| *** itlinux has joined #openstack-nova | 19:13 | |
| *** hemna has quit IRC | 19:27 | |
| *** takamatsu has joined #openstack-nova | 19:28 | |
| *** pcaruana has quit IRC | 19:30 | |
| *** BjoernT has quit IRC | 19:41 | |
| *** tstrul has quit IRC | 19:48 | |
| *** ralonsoh has quit IRC | 19:53 | |
| *** imacdonn has joined #openstack-nova | 19:56 | |
| *** licanwei has quit IRC | 19:56 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Integrating with unified limits https://review.opendev.org/615180 | 19:57 |
| *** hemna has joined #openstack-nova | 20:01 | |
| *** takamatsu has quit IRC | 20:02 | |
| *** mriedem has quit IRC | 20:07 | |
| *** wwriverrat has joined #openstack-nova | 20:14 | |
| *** wwriverrat has quit IRC | 20:19 | |
| *** dasp has joined #openstack-nova | 20:20 | |
| *** hamzy has quit IRC | 20:21 | |
| *** wwriverrat has joined #openstack-nova | 20:29 | |
| *** wwriverrat has quit IRC | 20:30 | |
| *** dpawlik has quit IRC | 20:31 | |
| *** wwriverrat has joined #openstack-nova | 20:31 | |
| *** wwriverrat has quit IRC | 20:32 | |
| *** wwriverrat has joined #openstack-nova | 20:35 | |
| *** wwriverrat has quit IRC | 20:36 | |
| *** dasp has quit IRC | 20:38 | |
| *** dasp has joined #openstack-nova | 20:38 | |
| *** takamatsu has joined #openstack-nova | 20:42 | |
| *** xek_ has quit IRC | 20:44 | |
| *** boxiang has quit IRC | 20:48 | |
| *** slaweq has quit IRC | 20:49 | |
| *** mriedem has joined #openstack-nova | 20:51 | |
| mriedem | yikun: looks like we have an api-ref bug on the server group policy parameter type, can you confirm? https://bugs.launchpad.net/nova/+bug/1830800 | 20:51 |
| openstack | Launchpad bug 1830800 in OpenStack Compute (nova) "Compute API in nova - server group "policy" field is a string rather than an object" [Medium,Triaged] | 20:51 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 20:53 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration https://review.opendev.org/653498 | 20:53 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] use iptables in nova-multinode https://review.opendev.org/660782 | 20:53 |
| *** dave-mccowan has joined #openstack-nova | 21:08 | |
| *** slaweq has joined #openstack-nova | 21:11 | |
| *** itlinux has quit IRC | 21:20 | |
| *** dave-mccowan has quit IRC | 21:23 | |
| *** itlinux has joined #openstack-nova | 21:23 | |
| *** slaweq has quit IRC | 21:24 | |
| *** udesale has quit IRC | 21:31 | |
| *** bbowen has quit IRC | 21:52 | |
| *** bbowen has joined #openstack-nova | 21:53 | |
| *** JamesBenson has quit IRC | 21:57 | |
| *** awalende has joined #openstack-nova | 22:00 | |
| *** itlinux has quit IRC | 22:02 | |
| *** bbowen has quit IRC | 22:02 | |
| *** spatel has quit IRC | 22:03 | |
| *** awalende has quit IRC | 22:05 | |
| *** rcernin has quit IRC | 22:06 | |
| *** whoami-rajat has quit IRC | 22:11 | |
| *** dave-mccowan has joined #openstack-nova | 22:12 | |
| *** slaweq has joined #openstack-nova | 22:16 | |
| *** cmart has quit IRC | 22:19 | |
| *** slaweq has quit IRC | 22:24 | |
| *** mriedem has quit IRC | 22:29 | |
| *** wwriverrat has joined #openstack-nova | 22:29 | |
| *** dave-mccowan has quit IRC | 22:31 | |
| eandersson | What is the network cache used for on the computes? | 22:45 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: extract baselineCPU API call from _get_cpu_traits() https://review.opendev.org/661782 | 22:45 |
| eandersson | We found that with a high number of computes, the whole heal instance info cache got a little too chatty on the default setting. | 22:45 |
| aspiers | efried: at risk of highlighting my own incompetence, this is the kind of change where normally I'd be inclined to avoid a rebase of everything sitting on top: https://review.opendev.org/#/c/661782/3..4/nova/virt/libvirt/driver.py | 22:46 |
| aspiers | efried: that said, I'm totally fine with rebasing if you'd prefer that | 22:47 |
| aspiers | ah actually, since splitting out some other patches, there's only one patch sitting on top | 22:47 |
| aspiers | so maybe I will anyway | 22:48 |
| aspiers | hah, especially considering zuul absolutely hates that change sitting on top | 22:49 |
| efried | aspiers: I respect your green-ness. And maybe you'll start a sea change in nova. All I'm saying is that all the series contributions I've seen in my (albeit limited) time here have been managed in a series-as-a-whole fashion. | 22:49 |
| *** amodi has quit IRC | 22:49 | |
| aspiers | efried: fine by me :) I maintain the belief that Gerrit should visualise the dependency tree in a way which would make this kind of stuff a no-brainer | 22:50 |
| aspiers | but until it gets smarter, I'm happy to do whatever to make reviews easier | 22:50 |
| efried | aspiers: I use the tree-shaped version of git log locally, do you? | 22:51 |
| efried | To me, that sounds more or less like the visualization you're talking about... | 22:52 |
| aspiers | I use gitk, but that shows the history, not the real dependency tree | 22:52 |
| efried | ...and in that visualization, the way it's expressed is bang on. | 22:52 |
| efried | i.e. you can't say that PS4 of X is based on PS2 of Y when it's in fact based on PS1 of Y. | 22:52 |
| aspiers | I'm talking about semantic dependencies https://aspiers.github.io/nashville-git-automagic-april-2019/#/git-deps-concept | 22:53 |
| efried | Because PS1 and PS2 of Y could be *wildly* bifferent. | 22:53 |
| efried | or even different. | 22:53 |
| aspiers | I like bifferent, it should be a word | 22:53 |
| efried | Back to the Future referential, somehow. | 22:53 |
| aspiers | :) | 22:53 |
| efried | like how a guy can be a jerk until you go back in time and kick his ass, then when you come back to the present, he's bifferent. | 22:54 |
| aspiers | exactly :) | 22:54 |
| aspiers | actually that was misleading - git-deps deals in textual dependencies, but here I mean semantic ones | 22:55 |
| *** tkajinam has joined #openstack-nova | 23:02 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix hard-delete of instance with soft-deleted referential constraints https://review.opendev.org/661398 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.opendev.org/641806 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/658904 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.opendev.org/614012 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.opendev.org/614353 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration https://review.opendev.org/661859 | 23:09 |
| *** mriedem has joined #openstack-nova | 23:10 | |
| *** spatel has joined #openstack-nova | 23:10 | |
| mriedem | melwitt: you might be interested in https://review.opendev.org/#/c/661859/ since it's related to the setup_instance_group group.hosts lazy-load / cell context stuff you worked on before | 23:10 |
| mriedem | turns out the move operation assumptions in there don't work for cross-cell migration with an anti-affinity group but the anti-affinity server group filter doesn't look at request_spec.instance_group.hosts since rocky anyway | 23:11 |
| mriedem | so it magically just sort of works | 23:11 |
| *** slaweq has joined #openstack-nova | 23:11 | |
| *** spatel has quit IRC | 23:14 | |
| *** _erlon_ has quit IRC | 23:16 | |
| *** lbragstad has quit IRC | 23:19 | |
| *** rcernin has joined #openstack-nova | 23:21 | |
| *** lbragstad has joined #openstack-nova | 23:23 | |
| *** slaweq has quit IRC | 23:24 | |
| *** mriedem has quit IRC | 23:27 | |
| *** JamesBenson has joined #openstack-nova | 23:36 | |
| *** macza has quit IRC | 23:36 | |
| *** gyee has quit IRC | 23:40 | |
| *** JamesBenson has quit IRC | 23:40 | |
| *** mlavalle has quit IRC | 23:41 | |
| *** dave-mccowan has joined #openstack-nova | 23:47 | |
| *** frankwang has joined #openstack-nova | 23:48 | |
| *** dave-mccowan has quit IRC | 23:53 | |
| *** takamatsu has quit IRC | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!