| *** luksky has quit IRC | 00:02 | |
| *** sapd1_x has quit IRC | 00:12 | |
| *** stakeda has joined #openstack-nova | 00:37 | |
| *** wolverineav has joined #openstack-nova | 00:38 | |
| *** wolverineav has quit IRC | 00:42 | |
| *** ileixe has joined #openstack-nova | 00:51 | |
| *** wolverineav has joined #openstack-nova | 00:51 | |
| *** tbachman has joined #openstack-nova | 00:56 | |
| *** hongbin has joined #openstack-nova | 01:05 | |
| *** tiendc has joined #openstack-nova | 01:05 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: Replace glance command with openstack command https://review.openstack.org/637060 | 01:14 |
|---|---|---|
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106 | 01:15 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110 | 01:15 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113 | 01:17 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113 | 01:17 |
| *** tetsuro has joined #openstack-nova | 01:48 | |
| gmann | efried: melwitt matt, i replied on removing the tempest-multinode-full job ML, review. We should not remove it instead we should make it voting. we are losing the coverage now and potentially in future also when slow marked tests will be made non-slow | 01:52 |
| *** psachin has joined #openstack-nova | 01:57 | |
| *** Dinesh_Bhor has quit IRC | 02:07 | |
| *** tbachman has quit IRC | 02:21 | |
| *** tbachman has joined #openstack-nova | 02:25 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974 | 02:30 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311 | 02:30 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581 | 02:30 |
| *** whoami-rajat has joined #openstack-nova | 02:43 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Fix warnings in the document generation https://review.openstack.org/631150 | 02:43 |
| *** tssurya has joined #openstack-nova | 03:00 | |
| *** udesale has joined #openstack-nova | 03:16 | |
| *** hongbin_ has joined #openstack-nova | 03:21 | |
| *** hongbin has quit IRC | 03:23 | |
| *** tssurya has quit IRC | 03:23 | |
| *** elbragstad has joined #openstack-nova | 03:25 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Re-enable testing of console with TLS in nova-next job https://review.openstack.org/645432 | 03:46 |
| *** wolverineav has quit IRC | 03:54 | |
| *** wolverineav has joined #openstack-nova | 03:56 | |
| *** janki has joined #openstack-nova | 03:56 | |
| *** hongbin_ has quit IRC | 03:59 | |
| *** kaiokmo has joined #openstack-nova | 04:16 | |
| kaiokmo | hi Nova folks. I was wondering if it is possible to change permissions of the directories used by nova to launch new instances (when using local storage on the compute-node) | 04:23 |
| kaiokmo | for example: I have an instance dir which is /var/lib/nova/instances/some_hash/. this directory permissions are 755 and nova:nova (user:group) | 04:24 |
| *** ileixe has quit IRC | 04:25 | |
| kaiokmo | it is possible to change (on config files or something) new directories to be created with 775 instead of 755? | 04:25 |
| *** wolverineav has quit IRC | 04:29 | |
| *** zhubx has quit IRC | 04:41 | |
| *** zhubx has joined #openstack-nova | 04:42 | |
| *** ileixe has joined #openstack-nova | 04:46 | |
| openstackgerrit | Thomas Bechtold proposed openstack/os-vif master: Drop testtools from test-requirements.txt https://review.openstack.org/647286 | 04:46 |
| *** wolverineav has joined #openstack-nova | 04:47 | |
| *** sajauddin has joined #openstack-nova | 05:11 | |
| *** ratailor has joined #openstack-nova | 05:13 | |
| *** wolverineav has quit IRC | 05:21 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974 | 05:29 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311 | 05:30 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581 | 05:31 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581 | 05:31 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311 | 05:31 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581 | 05:32 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017 | 05:32 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017 | 05:32 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018 | 05:33 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018 | 05:33 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019 | 05:34 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019 | 05:34 |
| openstackgerrit | Tony Breeds proposed openstack/nova stable/queens: Document unset/reset wrinkle for *_allocation_ratio options https://review.openstack.org/647291 | 05:35 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020 | 05:35 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020 | 05:35 |
| openstackgerrit | Tony Breeds proposed openstack/nova stable/queens: Don't persist zero allocation ratios in ResourceTracker https://review.openstack.org/613271 | 05:35 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027 | 05:36 |
| openstackgerrit | Tony Breeds proposed openstack/nova stable/queens: Update resources once in update_available_resource https://review.openstack.org/612294 | 05:36 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027 | 05:36 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031 | 05:37 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031 | 05:37 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299 | 05:38 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299 | 05:38 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344 | 05:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344 | 05:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673 | 05:40 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673 | 05:40 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676 | 05:41 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676 | 05:41 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689 | 05:42 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689 | 05:42 |
| openstackgerrit | Tony Breeds proposed openstack/nova stable/pike: Document unset/reset wrinkle for *_allocation_ratio options https://review.openstack.org/647292 | 05:42 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709 | 05:43 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709 | 05:43 |
| openstackgerrit | Tony Breeds proposed openstack/nova stable/pike: Don't persist zero allocation ratios in ResourceTracker https://review.openstack.org/613263 | 05:43 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712 | 05:43 |
| openstackgerrit | Tony Breeds proposed openstack/nova stable/pike: Update resources once in update_available_resource https://review.openstack.org/612295 | 05:43 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712 | 05:44 |
| *** yonglihe has joined #openstack-nova | 05:44 | |
| *** jaosorior has joined #openstack-nova | 06:02 | |
| *** wolverineav has joined #openstack-nova | 06:11 | |
| *** udesale has quit IRC | 06:15 | |
| *** udesale has joined #openstack-nova | 06:16 | |
| openstackgerrit | Abhishek Kekane proposed openstack/nova-specs master: Support multiple backend of Glance https://review.openstack.org/641210 | 06:19 |
| *** udesale has quit IRC | 06:20 | |
| *** udesale has joined #openstack-nova | 06:20 | |
| *** ivve has joined #openstack-nova | 06:37 | |
| *** elbragstad has quit IRC | 06:45 | |
| *** Luzi has joined #openstack-nova | 06:53 | |
| *** owalsh has quit IRC | 06:54 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.openstack.org/641200 | 06:58 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add TODO note for mox removal https://review.openstack.org/576758 | 06:59 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add TODO note for mox removal https://review.openstack.org/576758 | 07:00 |
| *** wolverineav has quit IRC | 07:00 | |
| *** wolverineav has joined #openstack-nova | 07:01 | |
| *** ratailor has quit IRC | 07:05 | |
| *** pcaruana has joined #openstack-nova | 07:07 | |
| *** brinzhang has joined #openstack-nova | 07:08 | |
| *** ratailor has joined #openstack-nova | 07:09 | |
| *** sapd1_x has joined #openstack-nova | 07:10 | |
| *** sridharg has joined #openstack-nova | 07:18 | |
| *** slaweq has joined #openstack-nova | 07:19 | |
| *** dpawlik has joined #openstack-nova | 07:19 | |
| *** alex_xu has quit IRC | 07:24 | |
| *** sapd1_x has quit IRC | 07:25 | |
| *** wolverineav has quit IRC | 07:34 | |
| *** wolverineav has joined #openstack-nova | 07:35 | |
| *** wolverineav has quit IRC | 07:36 | |
| *** wolverineav has joined #openstack-nova | 07:37 | |
| *** oanson has joined #openstack-nova | 07:37 | |
| *** wolverineav has quit IRC | 07:37 | |
| *** owalsh has joined #openstack-nova | 07:41 | |
| *** ileixe has quit IRC | 07:49 | |
| *** alex_xu has joined #openstack-nova | 07:56 | |
| *** jangutter has joined #openstack-nova | 08:01 | |
| *** ccamacho has joined #openstack-nova | 08:06 | |
| *** awalende has joined #openstack-nova | 08:07 | |
| *** tetsuro has quit IRC | 08:09 | |
| *** tesseract has joined #openstack-nova | 08:10 | |
| *** udesale has quit IRC | 08:14 | |
| *** udesale has joined #openstack-nova | 08:15 | |
| *** udesale has quit IRC | 08:17 | |
| *** udesale has joined #openstack-nova | 08:17 | |
| *** luksky has joined #openstack-nova | 08:18 | |
| *** rpittau|afk is now known as rpittau | 08:22 | |
| openstackgerrit | Martin Schuppert proposed openstack/nova stable/stein: Eventlet monkey patching should be as early as possible https://review.openstack.org/647310 | 08:22 |
| *** ralonsoh has joined #openstack-nova | 08:28 | |
| *** tosky has joined #openstack-nova | 08:28 | |
| *** tssurya has joined #openstack-nova | 08:33 | |
| *** takashin has left #openstack-nova | 08:35 | |
| *** helenafm has joined #openstack-nova | 08:36 | |
| *** brinzh has joined #openstack-nova | 08:40 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:40 | |
| *** tkajinam has quit IRC | 08:42 | |
| *** brinzhang has quit IRC | 08:43 | |
| *** wolverineav has joined #openstack-nova | 08:43 | |
| *** zbr has quit IRC | 08:53 | |
| *** wolverineav has quit IRC | 09:02 | |
| *** yikun has joined #openstack-nova | 09:04 | |
| *** wxy-xiyuan has joined #openstack-nova | 09:07 | |
| *** ivve has quit IRC | 09:10 | |
| *** mdbooth_ has joined #openstack-nova | 09:15 | |
| *** xek has joined #openstack-nova | 09:17 | |
| *** mdbooth has quit IRC | 09:18 | |
| *** maciejjozefczyk has joined #openstack-nova | 09:18 | |
| *** zbr has joined #openstack-nova | 09:20 | |
| *** xek has quit IRC | 09:24 | |
| *** IvensZambrano has joined #openstack-nova | 09:25 | |
| *** jonher has quit IRC | 09:26 | |
| *** dtantsur|afk is now known as dtantsur | 09:32 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support adding the reason behind a server lock https://review.openstack.org/638629 | 09:40 |
| *** xek has joined #openstack-nova | 09:40 | |
| *** derekh has joined #openstack-nova | 09:43 | |
| *** ivve has joined #openstack-nova | 09:52 | |
| *** ttsiouts has joined #openstack-nova | 10:07 | |
| *** wolverineav has joined #openstack-nova | 10:17 | |
| *** ivve has quit IRC | 10:21 | |
| *** erlon has joined #openstack-nova | 10:22 | |
| *** wolverineav has quit IRC | 10:30 | |
| *** jonher has joined #openstack-nova | 10:37 | |
| *** wolverineav has joined #openstack-nova | 10:39 | |
| *** trident has quit IRC | 10:43 | |
| *** stakeda has quit IRC | 10:48 | |
| *** ivve has joined #openstack-nova | 10:50 | |
| *** erlon has quit IRC | 10:51 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add falvor to requested_resources in RequestSpec https://review.openstack.org/647396 | 10:57 |
| *** ratailor has quit IRC | 11:02 | |
| *** kaiokmo has quit IRC | 11:02 | |
| *** trident has joined #openstack-nova | 11:08 | |
| *** ttsiouts has quit IRC | 11:11 | |
| *** ttsiouts has joined #openstack-nova | 11:11 | |
| *** wolverineav has quit IRC | 11:14 | |
| *** kaiokmo has joined #openstack-nova | 11:14 | |
| *** ttsiouts has quit IRC | 11:15 | |
| *** psachin has quit IRC | 11:16 | |
| *** ivve has quit IRC | 11:19 | |
| *** sapd1_x has joined #openstack-nova | 11:22 | |
| *** rcernin has quit IRC | 11:31 | |
| *** hemna has quit IRC | 11:32 | |
| *** hemna has joined #openstack-nova | 11:32 | |
| openstackgerrit | Merged openstack/nova-specs master: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646695 | 11:34 |
| *** ttsiouts has joined #openstack-nova | 11:36 | |
| *** luksky has quit IRC | 11:39 | |
| *** shilpasd has joined #openstack-nova | 11:44 | |
| *** xek_ has joined #openstack-nova | 11:47 | |
| *** wolverineav has joined #openstack-nova | 11:48 | |
| *** panda|drappt is now known as panda | 11:49 | |
| *** xek has quit IRC | 11:49 | |
| *** kaiokmo has quit IRC | 11:55 | |
| *** wolverineav has quit IRC | 11:56 | |
| *** xek has joined #openstack-nova | 11:58 | |
| *** xek_ has quit IRC | 11:59 | |
| *** xek_ has joined #openstack-nova | 12:01 | |
| *** xek has quit IRC | 12:03 | |
| *** xek_ has quit IRC | 12:03 | |
| *** helenafm has quit IRC | 12:03 | |
| *** xek has joined #openstack-nova | 12:04 | |
| *** sajauddin has quit IRC | 12:06 | |
| *** xek has quit IRC | 12:08 | |
| *** xek has joined #openstack-nova | 12:08 | |
| *** jroll has quit IRC | 12:14 | |
| *** luksky has joined #openstack-nova | 12:15 | |
| *** jroll has joined #openstack-nova | 12:15 | |
| *** tiendc has quit IRC | 12:16 | |
| *** kaiokmo has joined #openstack-nova | 12:18 | |
| *** whoami-rajat has quit IRC | 12:24 | |
| *** markvoelker has quit IRC | 12:26 | |
| *** lpetrut has joined #openstack-nova | 12:26 | |
| *** logan- has quit IRC | 12:27 | |
| *** logan- has joined #openstack-nova | 12:31 | |
| *** brinzh has quit IRC | 12:33 | |
| shilpasd | Hi: openstacksdk returning 400 for 'force_service_down' API with version as 2.72, pl refer https://bugs.launchpad.net/ubuntu/+source/python-openstacksdk/+bug/1821584 | 12:36 |
| openstack | Launchpad bug 1821584 in python-openstacksdk (Ubuntu) "Compute 'force_service_down' API returns 400 with current version 2.72 " [Undecided,New] | 12:36 |
| tssurya | melwitt, mriedem: I feel we should fallback to legacy if the queued_for_delete is not migrated and is still NULL like its done for user_id : https://review.openstack.org/#/c/638072/14/nova/objects/instance_mapping.py@386 | 12:36 |
| shilpasd | Hi All: please confirm the same | 12:37 |
| *** cdent has joined #openstack-nova | 12:38 | |
| *** edleafe has joined #openstack-nova | 12:39 | |
| *** awaugama has joined #openstack-nova | 12:57 | |
| efried | shilpasd: Thanks for the bug report. | 12:58 |
| efried | FYI there's a community-wide goal getting set up for Train to try to get more of the CLIs up to parity | 12:59 |
| efried | If you have the means, it would be great if you wanted to propose a fix for this. | 12:59 |
| *** mriedem has joined #openstack-nova | 12:59 | |
| shilpasd | <efried> sure | 13:00 |
| shilpasd | efried: sure | 13:00 |
| sean-k-mooney | efried: in this case its an openstacsdk limitation not a cli issue | 13:00 |
| efried | sean-k-mooney: Yes, I agree. shilpasd opened the bug against the right component. | 13:00 |
| sean-k-mooney | nova cli and osc do not use the sdk for the api currently | 13:00 |
| sean-k-mooney | ah yes they did | 13:00 |
| sean-k-mooney | efried: stephenfin and i were talking internally about ho to improve cli partity | 13:02 |
| sean-k-mooney | efried: we were thinking a phased approch make the most sence. first make osc have partity with nova cli by just delegating to it internall. then port osc to openstack sdk once that is done | 13:04 |
| *** jmlowe has quit IRC | 13:04 | |
| sean-k-mooney | so form a user point of view we get to cli parity first then we can get teh sdk to partity and swap over to useing it | 13:04 |
| *** dklyle has joined #openstack-nova | 13:04 | |
| sean-k-mooney | but there are still big gaps in that plan. e.g. should clint only things like nova host-evac be ported and how to deal with micorverions | 13:05 |
| ganso | Hi folks. I am about to log a bug and would like to confirm if this is an intentional behavior or not: If an exception is raised by the driver during confirm_migration, the migration record is stuck in confirming state and the allocations are not removed. The instance is fine at the destination in this stage, but the source host has allocations that is not possible to clear without going to the database or invoking | 13:07 |
| ganso | the Placement API via curl. After several migration attempts that fail in the same spot, the source node is filled with these allocations that prevent new instances from being created or instances migrated to this node. | 13:07 |
| sean-k-mooney | efried: but ya in anycase i do hope we can make progress on that goal in train | 13:08 |
| *** ivve has joined #openstack-nova | 13:15 | |
| efried | ganso: What release are you running? | 13:16 |
| *** wolverineav has joined #openstack-nova | 13:16 | |
| ganso | efried: I tried pike, queens and stein | 13:16 |
| ganso | efried: same problem in all of them ^ | 13:17 |
| efried | ganso: Well, that doesn't sound great. mriedem is probably your best bet to say whether this is a known issue. If he doesn't chime in here I think you can safely open a bug. | 13:18 |
| ganso | efried: thanks! I will wait for mriedem's confirmation first. | 13:19 |
| *** helenafm has joined #openstack-nova | 13:19 | |
| *** takashin has joined #openstack-nova | 13:19 | |
| *** mvkr has quit IRC | 13:20 | |
| mriedem | looking, but i wouldn't be at all surprised | 13:20 |
| mriedem | ack on the migration.status not being set to error because the @errors_out_migration_ctx decorator is not used here https://github.com/openstack/nova/blob/926753ee6bebee5bacc29073e123ed5c1a0bb647/nova/compute/manager.py#L3933 | 13:21 |
| mriedem | so you never get this far https://github.com/openstack/nova/blob/926753ee6bebee5bacc29073e123ed5c1a0bb647/nova/compute/manager.py#L4011 | 13:22 |
| mriedem | nor do the allocations get cleaned up https://github.com/openstack/nova/blob/926753ee6bebee5bacc29073e123ed5c1a0bb647/nova/compute/manager.py#L4017 | 13:22 |
| *** med_ has joined #openstack-nova | 13:22 | |
| mriedem | so yes it's a big | 13:22 |
| mriedem | setting the migration status to error is easy | 13:22 |
| mriedem | knowing whether or not the allocations should be changed is harder | 13:22 |
| mriedem | ganso: the instance status goes to ERROR right? https://github.com/openstack/nova/blob/926753ee6bebee5bacc29073e123ed5c1a0bb647/nova/compute/manager.py#L3993 | 13:23 |
| ganso | mriedem: yes the instance goes to error | 13:23 |
| mriedem | which means you can't revert the resize after confirm fails | 13:23 |
| mriedem | unless you manually reset the vm_state to 'resized' in the db | 13:23 |
| mriedem | so at this point, the instance is on the dest, the db points the instance at the dest, and confirm fails on the dest and you're stuck in error state, | 13:24 |
| ganso | mriedem: I didn't try that. I noticed I could only change the status to either error or active, so I changed the status to active and could use the instance fine after that, even migrate it again. | 13:24 |
| mriedem | i would say we probably just consider the instance is stuck there now and cleanup the allocations | 13:24 |
| mriedem | ganso: yeah reset status only changes to active/errror | 13:24 |
| mriedem | *error | 13:24 |
| *** elbragstad has joined #openstack-nova | 13:24 | |
| mriedem | so you could have tried hard rebooting the instance to fix it also since you can do that with an error instance | 13:24 |
| mriedem | but that's not going to cleanup the allocations as you found | 13:25 |
| *** elbragstad is now known as lbragstad | 13:25 | |
| mriedem | ganso: anyway, it's definitely a bug | 13:25 |
| ganso | mriedem: hmmm seems to me the migration_confirm runs on the source, and fails there. The libvirt driver only cleans up on that method's implementation | 13:25 |
| mriedem | oh right, yeah confirm_resize runs on the source host | 13:25 |
| mriedem | to cleanup the source host | 13:25 |
| efried | no confirm_resize --force? | 13:26 |
| efried | "I know this thing is copacetic on the destination, make it so" | 13:26 |
| mriedem | probably another good reason to just cleanup the guest on the hypervisor as best effort but still cleanup the allocations | 13:26 |
| ganso | mriedem: thanks! I will log the bug =) | 13:26 |
| mriedem | efried: that would assume you know you need to force it before the instance gets stuck in error status | 13:26 |
| mriedem | you can't confirm resize on an error instance | 13:27 |
| efried | That's what the force would be | 13:27 |
| mriedem | ew | 13:27 |
| efried | "I done checked the instance, and it's good. Make it look good in the databases and stuff" | 13:27 |
| efried | shrug, just spitballing. | 13:27 |
| mriedem | you can fix it up with a hard reboot | 13:27 |
| mriedem | on the dest | 13:27 |
| efried | except the allocations | 13:27 |
| *** trident has quit IRC | 13:27 | |
| mriedem | but that won't clean the allocations | 13:27 |
| mriedem | right, so what i'm saying is we should suck less and care for where errors can happen in a more granular way | 13:28 |
| ganso | efried, mriedem: yea the main problem are the allocations. | 13:28 |
| *** irclogbot_2 has joined #openstack-nova | 13:28 | |
| efried | does nova manage heal_allocations work on something like this? | 13:28 |
| mriedem | these giant compute / conductor manager methods are so convoluted that it gets hard to deal with errors in isolation | 13:28 |
| mriedem | and if they should be fatal or not | 13:28 |
| mriedem | efried: no, that only creates missing allocations, doesn't cleanup ones that shouldn't exist | 13:28 |
| mriedem | mnaser has a script for that though | 13:29 |
| mriedem | sec | 13:29 |
| cdent | I'm gonna get a tattoo of [t c6v1] | 13:29 |
| purplerbot | <mriedem> right, so what i'm saying is we should suck less and care for where errors can happen in a more granular way [2019-03-25 13:28:05.178818] [n c6v1] | 13:29 |
| efried | What I'm getting at is, if there's some way to clean up the allocations other than curl'ing placement, I'm less concerned about this than otherwise | 13:29 |
| *** trident has joined #openstack-nova | 13:29 | |
| mriedem | not built into nova no | 13:29 |
| mriedem | there are various operator scripts floating around | 13:29 |
| *** cdent has quit IRC | 13:31 | |
| *** altlogbot_3 has quit IRC | 13:31 | |
| mriedem | https://bugs.launchpad.net/nova/+bug/1793569 | 13:31 |
| openstack | Launchpad bug 1793569 in OpenStack Compute (nova) "Add placement audit commands" [Wishlist,Confirmed] | 13:32 |
| mriedem | there is a script in there from mnaser and one from larsks about cleaning up allocations in placement based on the nova db | 13:32 |
| *** altlogbot_3 has joined #openstack-nova | 13:32 | |
| mriedem | i can't find the email, but last year i posted to the ML looking for someone to incorporate mnaser's into nova-manage | 13:33 |
| efried | ganso: ^^ :P | 13:34 |
| ganso | efried, mriedem: it would be great if such functionality existed in nova-manage, so the customer can run if they run into this situation. | 13:36 |
| tssurya | mriedem: manser's script: http://paste.openstack.org/show/734146/ | 13:36 |
| efried | ganso: Above was me subtly suggesting that you might be interested in making that a reality :) | 13:36 |
| *** mchlumsky has joined #openstack-nova | 13:37 | |
| tssurya | oh nvm, had a question but got the answer | 13:37 |
| *** cdent has joined #openstack-nova | 13:37 | |
| *** dklyle has quit IRC | 13:37 | |
| *** tosky has quit IRC | 13:38 | |
| *** irclogbot_2 has quit IRC | 13:38 | |
| ganso | efried: on the other hand, it is a workaround for a bug. Once the bug is fixed there shouldn't be a need for the customer to run those scripts. I am not aware of which situations it is acceptable to have stale resources and perform cleanup of them. | 13:39 |
| mriedem | i just re-posted to the ML | 13:39 |
| *** irclogbot_2 has joined #openstack-nova | 13:39 | |
| efried | ganso: Yeah, if we never had bugs, we wouldn't need scripts like this :) | 13:40 |
| mriedem | i'm sure the same problem exists on revert resize | 13:40 |
| mriedem | and lots of other move ops | 13:40 |
| efried | ganso: This won't be the last time we encounter a bug for which this workaround ... yeah, what mriedem said. | 13:40 |
| mriedem | there is an assumption in these 200 LOC methods that we'll get to the things at the end because everything at the top and middle of the method will pass without error | 13:41 |
| *** tetsuro has joined #openstack-nova | 13:41 | |
| mriedem | even when we're trying to help https://github.com/openstack/nova/blob/926753ee6bebee5bacc29073e123ed5c1a0bb647/nova/compute/manager.py#L4703 i'm not sure how correct that is now | 13:42 |
| ganso | efried: yup. What I am trying to say is: if such workaround was common and of easy access, perhaps those bugs wouldn't even be considered bugs and wouldn't be reported by customers. Not sure if that's a good route to go. | 13:42 |
| mriedem | resize_instance changes the instance.host/node to the dest machine, and finish_resize then runs on the dest which could fail and if so, will revert allocations | 13:42 |
| efried | mriedem: Restructure so the critical stuff is in a finally: block? | 13:42 |
| *** temka is now known as artom | 13:42 | |
| efried | ganso: btw, did you figure out what the driver failure was? | 13:43 |
| efried | mriedem: Are we supposed to be fast-approving the s,git://,https://, patches? | 13:43 |
| ganso | efried: no, unfortunately my customer's logs don't go far back. I was able to find out where it fails because of the migration record in 'confirming' state | 13:43 |
| mriedem | efried: which ones? | 13:43 |
| efried | mriedem: https://review.openstack.org/#/c/646682/ | 13:44 |
| efried | and brethren | 13:44 |
| *** BjoernT has joined #openstack-nova | 13:44 | |
| mriedem | i guess i haven't been paying attention to the opendev changes | 13:45 |
| *** mchlumsky has quit IRC | 13:45 | |
| *** belmoreira_ has joined #openstack-nova | 13:45 | |
| mriedem | approved | 13:46 |
| *** mvkr has joined #openstack-nova | 13:47 | |
| *** belmoreira_ has quit IRC | 13:47 | |
| *** mchlumsky has joined #openstack-nova | 13:48 | |
| mriedem | oh god it's on all branches too | 13:49 |
| *** belmoreira has joined #openstack-nova | 13:49 | |
| mriedem | ianw will be king of all stats | 13:49 |
| openstackgerrit | Eric Fried proposed openstack/nova master: s,git://github.com/,https://git.openstack.org/, https://review.openstack.org/647472 | 13:49 |
| *** belmoreira has quit IRC | 13:51 | |
| mriedem | sean-k-mooney: is the kuryr-kubernetes-tempest-daemon-octavia failure in https://review.openstack.org/#/c/646868/ on stable/rocky a known issue? | 13:52 |
| *** jdillaman has joined #openstack-nova | 13:53 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Refactor CONTRIBUTING.rst https://review.openstack.org/640970 | 13:55 |
| bauzas | stephenfin: I'd appreciate some doc-nits ;) | 13:55 |
| mriedem | ganso: let me know when you have a bug posted and i can at least fix the migration.status = 'error' thing quickly | 13:55 |
| bauzas | stephenfin: oops, https://review.openstack.org/640970 | 13:55 |
| mriedem | bauzas: unrelated, but for you https://review.openstack.org/#/c/646006/ | 13:55 |
| bauzas | mriedem: ack, will look | 13:56 |
| ganso | mriedem: https://bugs.launchpad.net/nova/+bug/1821594 | 13:56 |
| openstack | Launchpad bug 1821594 in OpenStack Compute (nova) "Error in confirm_migration leaves stale allocations and 'confirming' migration state" [Undecided,New] | 13:56 |
| ganso | mriedem: thanks! | 13:56 |
| *** jmlowe has joined #openstack-nova | 14:00 | |
| *** munimeha1 has joined #openstack-nova | 14:04 | |
| efried | thanks ganso | 14:05 |
| *** hongbin has joined #openstack-nova | 14:06 | |
| mriedem | i need to email claudiub about https://review.openstack.org/#/c/543971/ | 14:07 |
| *** ivve has quit IRC | 14:11 | |
| *** mlavalle has joined #openstack-nova | 14:12 | |
| sean-k-mooney | mriedem: sorry was on 1:1 will check thatreview now | 14:14 |
| sean-k-mooney | mriedem: we made kuryr-kubernetes-tempest-daemon-octavia non-voting on master and kuryr removed it a few weeks ago so im not surpised that it failed | 14:16 |
| sean-k-mooney | mriedem: it looked like it failed becasue the devstack-plugin-container tried to install linux kernel package that are not found on the repos anymore | 14:20 |
| sean-k-mooney | it looks like it was installin kernel 4.4.0 packages which would correspond to ubuntu 16.04 | 14:20 |
| sean-k-mooney | if this ran on ubunut bionic then it would explain why it was not found | 14:20 |
| sean-k-mooney | actully its a ubuntu-xenial node i would guess the package is just not in te repo anymore | 14:21 |
| *** hamzy_ is now known as hamzy | 14:22 | |
| *** ivve has joined #openstack-nova | 14:23 | |
| openstackgerrit | Merged openstack/nova-specs master: Fix warnings in the document generation https://review.openstack.org/631150 | 14:28 |
| sean-k-mooney | mriedem: ill propose the backport of making that non voting to the sable branches | 14:33 |
| openstackgerrit | Merged openstack/nova master: Update contributor guide for Train https://review.openstack.org/645581 | 14:34 |
| mriedem | thanks | 14:34 |
| *** tetsuro has quit IRC | 14:38 | |
| *** wolverineav has quit IRC | 14:39 | |
| mnaser | btw, I raised this on the mailing list .. I dunno how release-critical this can be considered considering it's been a long time bug -- http://lists.openstack.org/pipermail/openstack-discuss/2019-March/004206.html | 14:43 |
| *** N3l1x has joined #openstack-nova | 14:54 | |
| *** awalende has quit IRC | 15:00 | |
| *** sridharg has quit IRC | 15:00 | |
| *** beekneemech is now known as bnemec | 15:00 | |
| *** awalende has joined #openstack-nova | 15:00 | |
| *** takashin has left #openstack-nova | 15:01 | |
| *** whoami-rajat has joined #openstack-nova | 15:01 | |
| *** awalende has quit IRC | 15:04 | |
| *** Luzi has quit IRC | 15:05 | |
| *** cfriesen has joined #openstack-nova | 15:06 | |
| *** tbachman has quit IRC | 15:07 | |
| openstackgerrit | sean mooney proposed openstack/os-vif stable/rocky: make kuryr-kubernetes-tempest-daemon-octavia non voting https://review.openstack.org/647500 | 15:09 |
| sean-k-mooney | mriedem: that will do it for rocky ^ but i need to check project-conifg for older branches | 15:10 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add falvor to requested_resources in RequestSpec https://review.openstack.org/647396 | 15:10 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add flavor to requested_resources in RequestSpec https://review.openstack.org/647396 | 15:11 |
| *** sapd1_x has quit IRC | 15:13 | |
| sean-k-mooney | actully no never mind | 15:13 |
| sean-k-mooney | we have zuul config in repo for older release se just do not run that job | 15:13 |
| *** tbachman has joined #openstack-nova | 15:15 | |
| openstackgerrit | Matt Riedemann proposed openstack/os-vif stable/rocky: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646868 | 15:16 |
| *** dklyle has joined #openstack-nova | 15:20 | |
| openstackgerrit | Merged openstack/python-novaclient stable/stein: Replace openstack.org git:// URLs with https:// https://review.openstack.org/647075 | 15:22 |
| *** tssurya has quit IRC | 15:24 | |
| *** zhubx has quit IRC | 15:26 | |
| *** zhubx has joined #openstack-nova | 15:28 | |
| *** zhubx has quit IRC | 15:28 | |
| *** zhubx has joined #openstack-nova | 15:29 | |
| *** zhubx has quit IRC | 15:30 | |
| *** zhubx has joined #openstack-nova | 15:32 | |
| openstackgerrit | Merged openstack/os-vif master: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646867 | 15:32 |
| *** tssurya has joined #openstack-nova | 15:32 | |
| *** lpetrut has quit IRC | 15:32 | |
| *** itlinux has quit IRC | 15:37 | |
| *** wolverineav has joined #openstack-nova | 15:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Overwrite RequestSpec.ignore_hosts during evacuate https://review.openstack.org/647512 | 15:37 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Do not persist RequestSpec.ignore_hosts https://review.openstack.org/647513 | 15:37 |
| mriedem | bauzas: cfriesen: dansmith: ^ fixes that super latent bug | 15:37 |
| cfriesen | mriedem: nice. will take a look. | 15:39 |
| mriedem | only took 2+ years | 15:39 |
| *** BjoernT_ has joined #openstack-nova | 15:40 | |
| mriedem | i can't wait until my next "don't persist field x in request spec" adventure | 15:41 |
| *** BjoernT has quit IRC | 15:42 | |
| mriedem | i guess i need to squash the 2nd and 3rd changes anyway...doing that | 15:45 |
| bauzas | mriedem: nice | 15:48 |
| bauzas | mriedem: once I'm done with some internal meeting + the vgpu docs, you're next in the queue | 15:49 |
| *** kaisers has quit IRC | 15:50 | |
| *** idlemind has quit IRC | 15:50 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression test for bug 1669054 https://review.openstack.org/646006 | 15:52 |
| openstack | bug 1669054 in OpenStack Compute (nova) "RequestSpec.ignore_hosts from resize is reused in subsequent evacuate" [Medium,In progress] https://launchpad.net/bugs/1669054 - Assigned to Matt Riedemann (mriedem) | 15:52 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Do not persist RequestSpec.ignore_hosts https://review.openstack.org/647512 | 15:52 |
| *** udesale has quit IRC | 15:55 | |
| cfriesen | found a grammar bug in the commit message for https://review.openstack.org/#/c/647512 | 15:55 |
| cfriesen | mriedem: ^ | 15:55 |
| cfriesen | see review | 15:55 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Remove expiremental note in the VGPU docs https://review.openstack.org/647518 | 15:56 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add doc on VGPU allocs and inventories for nrp https://review.openstack.org/647519 | 15:56 |
| bauzas | mriedem: you could be interested in ^ | 15:56 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Do not persist RequestSpec.ignore_hosts https://review.openstack.org/647512 | 15:59 |
| mriedem | cfriesen: done | 15:59 |
| dansmith | wow a grammar nit in a mriedem patch | 15:59 |
| *** cdent has quit IRC | 16:00 | |
| *** xek has quit IRC | 16:02 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add doc on VGPU allocs and inventories for nrp https://review.openstack.org/647519 | 16:02 |
| *** xek has joined #openstack-nova | 16:08 | |
| openstackgerrit | Merged openstack/python-novaclient stable/queens: Replace openstack.org git:// URLs with https:// https://review.openstack.org/647073 | 16:09 |
| *** wolverineav has quit IRC | 16:09 | |
| mriedem | bauzas: a few nits in that top docs patch but otherwise really nice | 16:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add flavor to requested_resources in RequestSpec https://review.openstack.org/647396 | 16:09 |
| gibi | mriedem: regarding your patch about prefiltering for multiattach capable nodes. I tried to make your first approach (request group) work by creating request group for the flavor resource too ^^ | 16:11 |
| openstackgerrit | Merged openstack/python-novaclient stable/rocky: Replace openstack.org git:// URLs with https:// https://review.openstack.org/647074 | 16:12 |
| openstackgerrit | Merged openstack/python-novaclient stable/ocata: Replace openstack.org git:// URLs with https:// https://review.openstack.org/647071 | 16:12 |
| mriedem | gibi: seems kind of gross to have to call a new helper method in conductor for all move operations | 16:12 |
| openstackgerrit | Merged openstack/python-novaclient stable/pike: Replace openstack.org git:// URLs with https:// https://review.openstack.org/647072 | 16:13 |
| mriedem | i guess it's not all move ops | 16:14 |
| gibi | mriedem: I tried to hook into the RequestSpec.flavor property setter but property setter doesn't seem to work on ovos | 16:15 |
| gibi | mriedem: there are another problem noted in the commit message. The numbering of the request groups are lost during the process | 16:16 |
| mriedem | so if someone is resizing with a flavor that has numbered request groups in it, we could lose that | 16:17 |
| mriedem | and break something later | 16:17 |
| mriedem | because we don't persist requested_resources | 16:17 |
| mriedem | right? | 16:17 |
| gibi | mriedem: we are not loosing the group we are loosing the number used in the flavor extra_spec for a given group | 16:18 |
| dansmith | surely we don't want to persist requested_resources | 16:18 |
| gibi | mriedem: besically the patch renumbers each group when generating the a_c query | 16:18 |
| dansmith | since those could change in format or structure across releases | 16:18 |
| gibi | dansmith: I agree | 16:18 |
| mriedem | gibi: isn't the flavor group number coming from the flavor extra specs? which are persisted in RequestSpec.flavor.extra_specs | 16:18 |
| mriedem | dansmith: i'm not so sure here, persisting things in request spec has really helped us out thus far...... | 16:19 |
| gibi | mriedem: yes. The goal of this patch to create RequestGroup ovos from the flavor | 16:19 |
| dansmith | mriedem: heh | 16:19 |
| dansmith | the resources in the flavor *are* structural and fixed, but the full set that we calculate from the flavor and other requirements (i.e. from the image, etc) shouldn't be persisted I think | 16:19 |
| gibi | mriedem: there is no place currently in the RequestGroup to store it's ident | 16:20 |
| *** imacdonn has quit IRC | 16:21 | |
| *** imacdonn has joined #openstack-nova | 16:22 | |
| *** helenafm has quit IRC | 16:23 | |
| *** luksky has quit IRC | 16:23 | |
| mriedem | gibi: i'm not sure what that means for this | 16:24 |
| mriedem | what is the ident? requester_id? or just the group number? | 16:24 |
| mriedem | index? | 16:24 |
| mriedem | request groups baffle me which is why i've deprioritized that multiattach patch :) | 16:24 |
| gibi | the group number from the flavor.extra_spec | 16:24 |
| mriedem | i thought that was baked into the extra spec key name? | 16:25 |
| mriedem | resources1 etc | 16:25 |
| gibi | the flavor create can use resourceN where N is a positive number | 16:25 |
| gibi | and that N ends up in the a_c query | 16:25 |
| gibi | but the current patch renumbers the groups | 16:25 |
| gibi | it will be 1,2,3,... in the a_c query | 16:26 |
| openstackgerrit | Merged openstack/nova master: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646682 | 16:26 |
| openstackgerrit | Merged openstack/nova stable/stein: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646688 | 16:26 |
| mriedem | gibi: ok so i guess the question is does that matter as long as the groups remain....grouped | 16:26 |
| *** ivve has quit IRC | 16:26 | |
| gibi | they remain grouped. So it only hardens the troubleshooting | 16:27 |
| *** panda is now known as panda|ko | 16:27 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support server power state update through external event https://review.openstack.org/636132 | 16:30 |
| *** ttsiouts has quit IRC | 16:32 | |
| *** igordc has joined #openstack-nova | 16:32 | |
| *** igordc has quit IRC | 16:32 | |
| *** ttsiouts has joined #openstack-nova | 16:32 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support server power state update through external event https://review.openstack.org/636132 | 16:34 |
| *** cdent has joined #openstack-nova | 16:37 | |
| *** ttsiouts has quit IRC | 16:37 | |
| melwitt | mriedem: I was wondering re: counting quotas, since we're doing a blocker migration for user_id this cycle, does that mean we don't need to check whether it's populated and fall back to legacy counting anymore? or do we still need to? | 16:49 |
| *** gyee has joined #openstack-nova | 16:50 | |
| mriedem | melwitt: i think the blocker migration missed stein so it has to be in U now | 16:51 |
| mriedem | but probably a better question for dansmith | 16:51 |
| mriedem | doing the blocker migration right away in Train seems overly aggressive | 16:51 |
| *** tssurya has quit IRC | 16:52 | |
| dansmith | melwitt: if we do a blocker, then yes that's what that means, but if we're going to be a little softer about it, then we'd need to handle the compat | 16:52 |
| melwitt | mriedem: ok, yeah I wasn't sure how that usually works. I was thinking since we landed all of the migration code in stein, then the blocker migration might only be related to that | 16:52 |
| dansmith | generally we do a blocker so we can drop support for something | 16:52 |
| dansmith | and doing that right after we opened the window would be rather aggressive as mriedem said | 16:52 |
| melwitt | oh, I see. yeah, then T would be too early | 16:52 |
| mriedem | i think trying to drop the compat in the same release that we add the new code that depends on that compat seems aggressive | 16:53 |
| dansmith | and remember, | 16:53 |
| dansmith | blocker migrations are a pain for FFU people, so we should use them sparingly for when we need to fully drop support for something vs. just avoiding some compat code | 16:53 |
| dansmith | like if we need to drop a column or something | 16:53 |
| *** janki has quit IRC | 16:54 | |
| melwitt | oh, ok :/ might have to amend the spec in that case | 16:54 |
| melwitt | (since it mentions a blocker migration) | 16:54 |
| dansmith | I'm not saying we can't (I don't remember what the spec says), I'm just saying we should be judicious in our application of that technique | 16:55 |
| melwitt | the spec says blocker migration for being able to remove compat code/stop legacy counting | 16:55 |
| melwitt | understood | 16:55 |
| dansmith | right, so, when we remove that code, we should have a blocker, so depending on how the spec words it, it may not be wrong :) | 16:56 |
| melwitt | (although we have to keep legacy counting indefinitely until partitioning of placement allocations is possible) | 16:56 |
| dansmith | okay | 16:56 |
| dansmith | we could also do it a different way and just roll the blocker and new constraints together in one migration, but we definitely need to give some buffer between adding the thing and requiring the thing I thnk | 16:57 |
| melwitt | yeah, understood and agreed | 16:58 |
| *** igordc has joined #openstack-nova | 16:58 | |
| cdent | melwitt: speaking of partitioning placement allocations. Is that a thing you were planning to spec or is that a broader all of us kind of thing? | 17:01 |
| melwitt | cdent: broader thing | 17:01 |
| cdent | or "dunno" is of course a reasonable answer | 17:01 |
| cdent | ✔ | 17:02 |
| *** jhinman has joined #openstack-nova | 17:08 | |
| melwitt | mriedem, stephenfin, gmann: fyi, I have changes proposed for re-enabling testing of console with TLS in nova-next https://review.openstack.org/#/q/topic:bug/1819794+status:open | 17:11 |
| *** Sundar has joined #openstack-nova | 17:11 | |
| * stephenfin clicks | 17:11 | |
| gmann | melwitt: thanks. | 17:11 |
| sean-k-mooney | cdent: is partioning placemetn allocation the "owner thing" | 17:12 |
| * sean-k-mooney reads scollback | 17:12 | |
| cdent | sean-k-mooney: it's basically a way of saying "this allocation of VCPU is from this thing (which happens to be nova X)" | 17:13 |
| cdent | which is somewhat different from the resource provider allocation, which is supposed to be a way of saying "these rps below to cloud X" | 17:13 |
| cdent | (which I think is something jaypipes has been thinking about, if I remember right) | 17:13 |
| sean-k-mooney | cdent: oh its partioning in the sense of multiple nova sharing the same placment | 17:14 |
| cdent | sean-k-mooney: not necessarily. there could be other things that consume vcpu | 17:14 |
| cdent | which may or may not be a nova | 17:15 |
| sean-k-mooney | sure but i thin this started as an edge usecase. | 17:15 |
| cdent | but as you can see there's a lot of overlap and ambiguity here, which is why it needs a bit more drive and discussion | 17:15 |
| sean-k-mooney | ya | 17:15 |
| *** dustinc has joined #openstack-nova | 17:15 | |
| cdent | yes, it started as an edge usecase, with two different models for the distribution: one placement many clouds, or one placement many novas but same keystone | 17:16 |
| sean-k-mooney | cdent: what are the other consumer of vcpu beyond nova out of interest? | 17:16 |
| cdent | I don't know | 17:16 |
| cdent | I'm not too savvy about either of these use cases, just have heard people mention them | 17:16 |
| cdent | from my standpoint, until somebody steps up a bit more, they aren't yet real | 17:16 |
| cdent | just speculative stuff to think about in the back of the mind | 17:16 |
| sean-k-mooney | i guess maybe zun? but i would have asumed it had its only RP | 17:16 |
| melwitt | to be clear, I didn't mention it because it's a pressing issue right now, just to note that there's another larger reason why we wouldn't be able to remove quota usage counting compat code than just a blocker migration | 17:17 |
| * cdent nods | 17:17 | |
| cdent | It does seem like the sort of thing where if there was somebody who had the cycles to make it go, it would be a good thing to have | 17:18 |
| cdent | but until then... | 17:18 |
| jhinman | I'm trying to get an instance up with ovs-dpdk. but the vif doesn't get exposed because of this code: vifs_to_expose = {vif.address: vif for vif in vifs if ('tag' in vif and vif.tag) or vlans_by_mac.get(vif.address)} | 17:19 |
| sean-k-mooney | cdent: having the list of usecasue for the feature would be a good starting point. im not entirly sure that the usecsue we all vaguly recall someone talking about at some point are actully the same feature or should be :) | 17:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Error out migration when confirm_resize fails https://review.openstack.org/647546 | 17:20 |
| sean-k-mooney | jhinman: where is that code ? | 17:20 |
| cdent | sean-k-mooney: yeah, it is a bit vague | 17:20 |
| jhinman | the code is in /virt/libvirt/driver.py | 17:20 |
| jhinman | where does the tag come from? | 17:21 |
| sean-k-mooney | jhinman: what release are you running | 17:21 |
| sean-k-mooney | vifs_to_expose is not in that file on master | 17:22 |
| * jaypipes reads back | 17:22 | |
| *** rpittau is now known as rpittau|afk | 17:22 | |
| jhinman | rocky release | 17:22 |
| sean-k-mooney | jhinman: its not there on rocky either are you deploying a downstream version of openstack | 17:23 |
| jhinman | I'm deploying kolla-ansible, so whatever that container has | 17:23 |
| sean-k-mooney | jhinman: kolla-ansible has several modes. are you usign ubuntu source vs cento binary | 17:24 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add doc on VGPU allocs and inventories for nrp https://review.openstack.org/647519 | 17:25 |
| jhinman | ubuntu | 17:25 |
| sean-k-mooney | jhinman: the tag i think is the interface tagging feature where you can associate a generic name to an interface and look it up in the metadata service | 17:25 |
| jhinman | but how does the tag get assigned? is it something passed from neutron. or maybe the tag is not the problem? is there supposed to be a vlan associated | 17:27 |
| sean-k-mooney | its passed in by the user on nova boot. it is not related to the neutron segmentation id | 17:27 |
| sean-k-mooney | its a value like "wan" or "lan" | 17:27 |
| efried | stephenfin: Are we waiting to merge https://review.openstack.org/#/c/645991/ ? | 17:28 |
| sean-k-mooney | so this is the code that is failing https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L9284-L9286 | 17:28 |
| sean-k-mooney | looks like we just merged somthing | 17:29 |
| sean-k-mooney | https://github.com/openstack/nova/blob/0dfbcd74642b16432b800b51f304a89d762e3ff1/nova/virt/libvirt/driver.py#L9290-L9292 | 17:29 |
| *** dtantsur is now known as dtantsur|afk | 17:30 | |
| sean-k-mooney | jhinman: there should be nothing ovs-dpdk specific in that code. it shoudl be totally generic | 17:30 |
| sean-k-mooney | jhinman: actully if that is the code that is runnign that should not run for vhost-user interfaces | 17:34 |
| jhinman | ultimately, it ends up with line 9204: LOG.debug('No VIF found with MAC %s, not building metadata', dev.mac_addr) | 17:35 |
| sean-k-mooney | the section i linked if for sriov | 17:35 |
| *** wolverineav has joined #openstack-nova | 17:35 | |
| sean-k-mooney | jhinman: can you provide a paste of the trackback on paste.openstack.org | 17:37 |
| sean-k-mooney | vifs_to_expose = {vif.address: vif for vif in vifs | 17:37 |
| sean-k-mooney | if ('tag' in vif and vif.tag) or | 17:37 |
| sean-k-mooney | vlans_by_mac.get(vif.address)} | 17:37 |
| sean-k-mooney | is in the sriov code path and should not be called when handeling vhost-user | 17:37 |
| *** mvkr has quit IRC | 17:37 | |
| sean-k-mooney | well unless we use that fucntion to do generic dispatch to the others. lets see where is it called | 17:39 |
| sean-k-mooney | actully so yes that is how it is working | 17:39 |
| sean-k-mooney | we get the interface metadata here | 17:39 |
| sean-k-mooney | https://github.com/openstack/nova/blob/0dfbcd74642b16432b800b51f304a89d762e3ff1/nova/virt/libvirt/driver.py#L9310 | 17:39 |
| sean-k-mooney | jhinman: we emiit that debug message when the user does not specify any device role tags | 17:41 |
| sean-k-mooney | so its not a error to see that in the logs | 17:41 |
| openstackgerrit | Elod Illes proposed openstack/nova stable/pike: Fix incompatible version handling in BuildRequest https://review.openstack.org/647557 | 17:42 |
| *** wolverineav has quit IRC | 17:42 | |
| sean-k-mooney | jhinman: this code is for this spec https://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/virt-device-role-tagging.html are you having a specic issue or did you jsut see that debug message and were trying to figure out how to scilance it? | 17:43 |
| jhinman | allright, I was looking at that because I was going back from another error: I can't find any reason for qemu not to have permission to write the socket: Failed to connect socket /var/run/openvswitch/vhu7a90d3cd-d7: Permission denied | 17:45 |
| sean-k-mooney | jhinman: the socket error can happen for two reasons. first apparmor can block it, that should not be an issue with rocky but it was in the past | 17:46 |
| sean-k-mooney | second /var/run/openvswitch need to be writabel by the user that qemu is running with | 17:46 |
| jhinman | I disable apparmor | 17:46 |
| jhinman | but nova is the user of qemu, so should have permission for anything on the instances, right? | 17:47 |
| sean-k-mooney | qemu and nova need to be runign in the same group | 17:47 |
| sean-k-mooney | *qemu and ovs | 17:47 |
| *** wolverineav has joined #openstack-nova | 17:48 | |
| *** ivve has joined #openstack-nova | 17:48 | |
| sean-k-mooney | jhinman: on rocky qemu should be acting as teh vhost-user server and will create the vhost-user socket | 17:49 |
| sean-k-mooney | as such qemu need to have write permission to the /var/run/openvswith directory that is owned by ovs | 17:49 |
| jhinman | so I need to add qemu to the ovs group? | 17:51 |
| sean-k-mooney | jhinman: this should all be done by kolla ansible | 17:51 |
| openstackgerrit | Merged openstack/nova stable/queens: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646685 | 17:53 |
| openstackgerrit | Merged openstack/nova stable/ocata: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646683 | 17:53 |
| sean-k-mooney | jhinman: its been a few years since i implented the support in kolla-ansibel so i cant remember of the top of my head how i fixed this issue | 17:54 |
| jhinman | I think I remember a patch for qemu.conf, to set user to nova. but I think its in the nova group. is there a common group? | 17:54 |
| sean-k-mooney | jhinman: this is where the contain is created https://github.com/openstack/kolla-ansible/blob/stable/rocky/ansible/roles/ovs-dpdk/handlers/main.yml#L56-L76 | 17:56 |
| *** cdent has quit IRC | 17:57 | |
| sean-k-mooney | we are not setting a user in the yaml or in teh command using su no | 17:57 |
| sean-k-mooney | https://github.com/openstack/kolla-ansible/blob/stable/rocky/ansible/roles/ovs-dpdk/templates/ovsdpdk-vswitchd.json.j2 | 17:57 |
| sean-k-mooney | so i think that means ovs woudl be running as root maybe | 17:58 |
| jhinman | not obvious to me what you see, but I'll study it | 17:59 |
| sean-k-mooney | qemu is running as nova | 17:59 |
| sean-k-mooney | https://github.com/openstack/kolla-ansible/blob/stable/rocky/ansible/roles/nova/templates/qemu.conf.j2 | 17:59 |
| *** derekh has quit IRC | 18:00 | |
| jhinman | yes, so how to give it permission to access ovs's file? | 18:00 |
| sean-k-mooney | so nova would have to have write permission to /var/run/openvswitch | 18:00 |
| sean-k-mooney | ya | 18:00 |
| jhinman | sean: in order to get hostconfig stuff working, I added a new start-ovs script, overriding the embedded script. Is that the right way, or can the commands be added to the script in the tools directory (ovs-dpdkctl.sh)? | 18:04 |
| sean-k-mooney | before or after this issue | 18:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete allocations even if _confirm_resize raises https://review.openstack.org/647566 | 18:06 |
| jhinman | if you have a quick answer. I could submit a patch for you to review | 18:06 |
| sean-k-mooney | sure its simpler to anwer questiosn on a review but i would proably put it here https://github.com/openstack/kolla/blob/master/docker/ovsdpdk/ovsdpdk/extend_start.sh | 18:07 |
| dansmith | mriedem: you should be okay to backport a default= change on an object field It hink | 18:07 |
| mriedem | that affects the version of the object doesn't it? | 18:08 |
| dansmith | mriedem: it shouldn't.. it has nothing to do with the wire format | 18:08 |
| sean-k-mooney | mriedem: technicall i think it wont casue our ovo tests to fail as the filde dont change and the default value is not considered part of teh field type | 18:09 |
| dansmith | mriedem: some remote host could not specify a value and then break if a different default is chosen, but that'd be pretty silly | 18:09 |
| sean-k-mooney | jhinman: oh wait its already here https://github.com/openstack/kolla/blob/master/docker/ovsdpdk/ovsdpdk-vswitchd/extend_start.sh | 18:10 |
| dansmith | mriedem: I'm not saying you need to change your patch, but if you want to and/or it's better, then I think you're in the clear | 18:11 |
| mriedem | dansmith: ok i guess i was thinking of takashi's change here https://review.openstack.org/#/c/641200/3/nova/objects/request_spec.py but he's also setting nullable=True on network_metadata | 18:11 |
| mriedem | so maybe i got confused | 18:11 |
| dansmith | mriedem: yeah, nullable is fo' sho' a problem | 18:11 |
| *** xek_ has joined #openstack-nova | 18:11 | |
| mriedem | fo real fo sho? | 18:11 |
| sean-k-mooney | mriedem: nullable will change the db schma for the column | 18:11 |
| dansmith | sean-k-mooney: no it won't | 18:12 |
| mriedem | was just about to say ^ :) | 18:12 |
| mriedem | exact words | 18:12 |
| sean-k-mooney | well it requires you too chagne it right | 18:12 |
| dansmith | no | 18:12 |
| sean-k-mooney | no | 18:12 |
| dansmith | we have many fields which intentionally have different nullability for the db and object | 18:12 |
| dansmith | including one we just did for the quota stuff | 18:12 |
| sean-k-mooney | allowing an object to have a nullable field that was previousl not nullable does not require the db to allow it to be null? | 18:13 |
| sean-k-mooney | ohok | 18:13 |
| dansmith | not necessarily | 18:13 |
| dansmith | totally depends on the thing | 18:13 |
| *** xek has quit IRC | 18:14 | |
| * dansmith steps away for a few | 18:14 | |
| jhinman | sean: that doesn't affect the instance's socket perms, does it? | 18:15 |
| sean-k-mooney | jhinman: its not he socket perms that is the issue | 18:16 |
| sean-k-mooney | qemu is createing the socket so it will be the owner and will have read and write permissions | 18:16 |
| sean-k-mooney | ovs is runnign as root | 18:16 |
| sean-k-mooney | so the issue is the permission on the directory | 18:16 |
| sean-k-mooney | nova need read write permission to create the unix socket | 18:17 |
| sean-k-mooney | 777 should give all users and groups read wite permission to create files there | 18:17 |
| jhinman | but that script has been there all along | 18:20 |
| sean-k-mooney | jhinman: we bind mount the host /run into both the nova-libvirt and ovs vswtichd container | 18:20 |
| sean-k-mooney | can you check the permission on the host | 18:21 |
| sean-k-mooney | ls -al /run/openvswitch/ | 18:21 |
| jhinman | ok, will do. co-worker just told me she has it working on master branch, so something got fixed | 18:22 |
| sean-k-mooney | jhinman: perhaps but none of this code has change in well over 8 month and most is 2+ years old | 18:22 |
| sean-k-mooney | jhinman: that said i wrote most of the ovs-dpdk code in kolla so im not surpised if there are bugs :) | 18:23 |
| jhinman | host has 777 on /run/openvswitch | 18:24 |
| jhinman | I thought the log is saying that it's creating a socket in the VM | 18:26 |
| *** itlinux has joined #openstack-nova | 18:26 | |
| *** luksky has joined #openstack-nova | 18:26 | |
| sean-k-mooney | no its creating a socket for the vm. not in the vm. | 18:26 |
| jhinman | a socket in nova-compute? | 18:26 |
| sean-k-mooney | its created on the host by qemu i recent release. it was previously created by ovs and connected to by qemu in old releases | 18:27 |
| sean-k-mooney | the socket wil be create in the nova-libvirt container which also has the same directory bind monted shared form the host | 18:27 |
| *** xek_ has quit IRC | 18:27 | |
| sean-k-mooney | jhinman: https://github.com/openstack/kolla-ansible/blob/stable/rocky/ansible/roles/nova/defaults/main.yml#L16 | 18:27 |
| *** xek has joined #openstack-nova | 18:27 | |
| jhinman | ok. I'll figure it out. thanks for your help! | 18:28 |
| sean-k-mooney | sorry i couldnt help more. i shoudl really test that code again but i have not been working on kolla for about 18 months so i havent really been aroudn to take care of it | 18:29 |
| sean-k-mooney | jhinman: if you have issue im also on the #openstack-kolla channel so feel free to ping me there not to bother the nova folks. if its not specific feel free to ping me here | 18:30 |
| *** betherly has joined #openstack-nova | 18:32 | |
| *** xek has quit IRC | 18:32 | |
| *** betherly has quit IRC | 18:37 | |
| *** tesseract has quit IRC | 18:44 | |
| *** dustinc is now known as dustinc|away | 18:44 | |
| openstackgerrit | sean mooney proposed openstack/nova-specs master: add spec for image metadata prefiltering https://review.openstack.org/647578 | 18:53 |
| mnaser | would it be ok to add https://review.openstack.org/#/c/645352/ to the rc2 list? and https://review.openstack.org/#/c/641907/ ? | 18:56 |
| *** ivve has quit IRC | 18:57 | |
| sean-k-mooney | mnaser: oh that the fix for the null issue you were looking at last week? | 18:59 |
| *** wolverineav has quit IRC | 19:01 | |
| mnaser | sean-k-mooney: correct, the first one is that, the second one is Oslo.service doing a full restart of the service instead of reload, which breaks some assumptions nova does | 19:01 |
| mnaser | which means reloading to refresh info leaves you in a broken state | 19:01 |
| *** betherly has joined #openstack-nova | 19:02 | |
| sean-k-mooney | mnaser: right i brifly skimed that thread on the mailing list | 19:02 |
| sean-k-mooney | oh so that was how this was getting to None in the first place | 19:02 |
| *** cdent has joined #openstack-nova | 19:03 | |
| mnaser | sean-k-mooney: yeah I could see it in the DB going from "NULL" (sql null) to "null" (son null) | 19:03 |
| sean-k-mooney | or rather how self._bdm_obj.connection_info was | 19:03 |
| mnaser | json* | 19:03 |
| *** jmlowe has quit IRC | 19:03 | |
| *** betherly has quit IRC | 19:07 | |
| sean-k-mooney | mnaser: by the way on the olso service thing my intiall reaction was make oslos reload not call stop and start but i have no idea what other effect that would have | 19:08 |
| *** gbarros has quit IRC | 19:08 | |
| sean-k-mooney | mnaser: but that is more have sane names for things then because it definetly the right thing to do | 19:08 |
| openstackgerrit | sean mooney proposed openstack/nova-specs master: re add for train https://review.openstack.org/647581 | 19:10 |
| openstackgerrit | sean mooney proposed openstack/nova-specs master: forward ported form stien https://review.openstack.org/647582 | 19:15 |
| sean-k-mooney | mriedem: do ^ need to go back through full review or do can they be fast approved. i litrally just copied them updated the history footer? i know we are still focusing on RC2 but im hoping we can land that code before the ptg or m1 | 19:17 |
| sean-k-mooney | mriedem: i know we want to talk about openlab for the numa testing at the ptg but just said i would ask | 19:18 |
| efried | sean-k-mooney: If they were approved in stein, and they're verbatim (except the footer and s/stein/train/i) then they can be fast approved. | 19:19 |
| sean-k-mooney | efried: ya they are | 19:20 |
| efried | sean-k-mooney: However, I would request that you make some reference to the actual blueprint being proposed in the commit title and message body. | 19:20 |
| melwitt | mnaser: are they regressions? I think we're only doing regression fixes for RC2 | 19:20 |
| efried | sean-k-mooney: those titles are going to kill me | 19:20 |
| sean-k-mooney | sure :) | 19:20 |
| efried | thanks | 19:21 |
| sean-k-mooney | i was just going for dinner and wanted to push something | 19:21 |
| efried | cool | 19:21 |
| efried | if you need to run, I can edit and fast approve. | 19:21 |
| *** tssurya has joined #openstack-nova | 19:21 | |
| sean-k-mooney | ill fix them later. should i add them to the metting aggenda? | 19:21 |
| melwitt | sean-k-mooney: instructions, you need the Previously-approved in the commit message https://specs.openstack.org/openstack/nova-specs/readme.html#previously-approved-specifications | 19:21 |
| sean-k-mooney | melwitt ah perfect thanks | 19:22 |
| efried | sean-k-mooney: You mean for the PTG? Unless there's something more to be discussed on them, I wouldn't think so. | 19:22 |
| efried | sean-k-mooney: I guess they will come up in a "what do we prioritize for train" discussion, but that'll be fed by whatever's in the train approved blueprint list at the time anyway. | 19:22 |
| sean-k-mooney | efried: no i wasnt sure if i was ment to add fast approavl spec to the nova team meeting agenda | 19:22 |
| sean-k-mooney | ill just do what the doc says | 19:23 |
| *** Sundar has quit IRC | 19:23 | |
| efried | oh, yeah, that won't be necessary. I (or someone) will push them as soon as they conform to what melwitt linked above. | 19:23 |
| sean-k-mooney | efried: cool in that case ill fix them up and upload them later tonight | 19:24 |
| efried | sean-k-mooney: ++ | 19:24 |
| mnaser | melwitt: no both are long standing upgrade bugs afaik so yeah | 19:25 |
| mriedem | mnaser: i've got a todo to try and recreate that first one with an in-tree functional test, which shouldn't take me long | 19:29 |
| mriedem | idk about that oslo.service one - note that would require a release freeze exception on oslo.service and a minimum required version of oslo.service bump in nova (maybe that'd be optional though) | 19:29 |
| mnaser | well, I think we need to come to consensus on if the issue is in Oslo service or nova. | 19:32 |
| mnaser | Imho it’s Oslo service cause then what’s the point of sighup if you’re gonna stop and start... | 19:32 |
| dansmith | mnaser: I've lost context here, but is there anything nova can do to _not_ be fully torn down and reset? | 19:32 |
| dansmith | because I thought not, based on how we get started and managed from oslo | 19:33 |
| dansmith | as it is, a "systemctl restart nova-compute" is much better than the behavior we're getting from HUP, IMHO | 19:34 |
| mnaser | dansmith: based on my understanding it looks like Oslo service never really provides an API to handle HUP signals. | 19:34 |
| dansmith | mnaser: you mean it grabs HUP itself, but doesn't do what a HUP signal should really do | 19:35 |
| dansmith | and, if so, I agree :) | 19:35 |
| mnaser | Exactly. It calls reload but only after calling stop and start after so that’s a bit useless at that point. | 19:35 |
| dansmith | right | 19:36 |
| mnaser | I think the most portable potential fix is adding a keyword argument to the stop() function call which includes sighup=bool | 19:36 |
| dansmith | that doesn't seem like a reasonable status quo to me, which means I think it's an oslo.service bug, not a "nova should be doing something different" scenario | 19:36 |
| efried | I agree with that | 19:36 |
| mnaser | Yes. I think Nova is doing the right thing as well. | 19:36 |
| dansmith | efried: agree with which? | 19:36 |
| mnaser | Nothing except reload() should be called on SIGHUP. | 19:37 |
| efried | dansmith: `it's an oslo.service bug, not a "nova should be doing something different" scenario` | 19:37 |
| dansmith | efried: ack | 19:37 |
| efried | And we've got stuff documented that is supposed to happen to nova on HUP | 19:37 |
| dansmith | right | 19:37 |
| efried | which currently does happen, but is worthless because it destroys the process | 19:37 |
| dansmith | yarp | 19:37 |
| efried | stuff I have the confidence to say in IRC, but not on the ML | 19:38 |
| efried | but I have been watching that thread with interest | 19:38 |
| mnaser | So my review here solved this but “changed” existing behaviour ... https://review.openstack.org/#/c/641907 | 19:38 |
| mnaser | So is it a bug fix or behaviour change. Up for debate. | 19:38 |
| efried | it can be both | 19:39 |
| dansmith | the only argument not to do that would be to keep the existing behavior because it's always been broken, but that leaves us unable to resolve our issue | 19:39 |
| mnaser | But it looks like nova is a heavy user of sighup and I can’t get other projects to talk about their usage. But it looks like neutron is broken because it makes the same (norms) assumption | 19:39 |
| dansmith | which does not seem reasonable | 19:39 |
| *** _alastor_ has joined #openstack-nova | 19:39 | |
| efried | Zane's comment is valid, though. The first time I heard of SIGHUP for openstack it was in the context of mutable config options. So if the "fix" makes some config options not mutable, that's a problem. | 19:40 |
| *** wolverineav has joined #openstack-nova | 19:40 | |
| dansmith | efried: I don't think it has anything to do with that | 19:40 |
| dansmith | the only thing that would be impacted are things that you only look at on service start | 19:40 |
| efried | like RPC settings? | 19:40 |
| dansmith | however, those kinda by definition shouldn't be mutable, or you need to specifically handle the case where they have changed | 19:40 |
| dansmith | efried: right, db connection and rpc connection have always been "these can't be mutable" | 19:41 |
| dansmith | because it's unlikely people are going to handle them properly (as exposed here) | 19:41 |
| efried | Okay. Can you respond to Zane in https://review.openstack.org/#/c/641907 ? | 19:41 |
| dansmith | I can, but I don't really want to.. he's also not asserting that it makes sense to say that, | 19:42 |
| dansmith | he's just coming up with some guess | 19:42 |
| dansmith | oh, | 19:42 |
| dansmith | I see his latest one | 19:42 |
| dansmith | there, I said things | 19:45 |
| mnaser | I'll try to keep following up on things and get it to land, I just don't know how back portable these things can be | 19:45 |
| *** wolverineav has quit IRC | 19:45 | |
| *** ccamacho has quit IRC | 19:55 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215 | 19:55 |
| *** jhinman has quit IRC | 19:58 | |
| *** jmlowe has joined #openstack-nova | 20:00 | |
| *** wolverineav has joined #openstack-nova | 20:02 | |
| *** wolverineav has quit IRC | 20:07 | |
| *** whoami-rajat has quit IRC | 20:11 | |
| *** betherly has joined #openstack-nova | 20:11 | |
| mriedem | mnaser: there should definitely at least be a "fixes" release note in that oslo.service change if it's changing behavior but fixing a long-standing bug in HUP handling | 20:12 |
| mriedem | related to your "I just don't know how back portable these things can be" comment | 20:12 |
| mriedem | generally don't want to backport changes in behavior, but if we have a good reason to, let's make sure there is a release note | 20:12 |
| mnaser | mriedem: ok, ill wait for zane's comments and try to write up a release note that explains how critical (and how it was pretty much broken in every project I've inspected) | 20:15 |
| *** betherly has quit IRC | 20:16 | |
| mriedem | mnaser: dansmith: efried: i've also dumped some thoughts in there | 20:17 |
| *** wolverineav has joined #openstack-nova | 20:17 | |
| mriedem | trying to compromise but give operators a switch | 20:17 |
| mriedem | which could also be backportable | 20:17 |
| *** cdent has quit IRC | 20:18 | |
| mriedem | essentially add a [workarounds] style option to oslo.service | 20:19 |
| *** itlinux has quit IRC | 20:20 | |
| *** zbr has quit IRC | 20:22 | |
| *** pcaruana has quit IRC | 20:23 | |
| *** tosky has joined #openstack-nova | 20:23 | |
| *** zbr has joined #openstack-nova | 20:23 | |
| *** itlinux has joined #openstack-nova | 20:27 | |
| *** xek has joined #openstack-nova | 20:33 | |
| openstackgerrit | Merged openstack/os-vif master: Drop testtools from test-requirements.txt https://review.openstack.org/647286 | 20:42 |
| *** Sundar has joined #openstack-nova | 20:44 | |
| *** ralonsoh has quit IRC | 20:57 | |
| mriedem | mnaser: i wrote a functional test for bug 1821244 but can't recreate the issue | 20:57 |
| openstack | bug 1821244 in OpenStack Compute (nova) "Failed volume creation can result in invalid `connection_info` field" [Medium,In progress] https://launchpad.net/bugs/1821244 - Assigned to Mohammed Naser (mnaser) | 20:57 |
| efried | mriedem: Some bp questions if you have a mo | 20:57 |
| mriedem | mnaser: i'll post it quick and see if you can poke holes in the test | 20:57 |
| mriedem | efried: i have to run real quick, but should be back before 5 | 20:57 |
| efried | mriedem: k, I'll leave this here for you: | 20:58 |
| efried | 1) Why doesn't https://blueprints.launchpad.net/nova/+spec/add-locked-reason show up in https://blueprints.launchpad.net/nova/train ? | 20:58 |
| efried | 2) Why can't I edit Series goalZ? | 20:58 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: A functional test for bug 1821244 https://review.openstack.org/647603 | 20:58 |
| openstack | bug 1821244 in OpenStack Compute (nova) "Failed volume creation can result in invalid `connection_info` field" [Medium,In progress] https://launchpad.net/bugs/1821244 - Assigned to Mohammed Naser (mnaser) | 20:58 |
| mriedem | efried: i've noticed that sometimes (1) happens and i just have to reset the series and save it then it does, which i just dod | 20:59 |
| mriedem | *did | 20:59 |
| mriedem | so refresh https://blueprints.launchpad.net/nova/train | 20:59 |
| mriedem | efried: you probably can't edit series goals b/c you're not a nova driver team member https://launchpad.net/~nova-drivers | 20:59 |
| efried | ah, you changed it from "proposed for train" to "accepted for train" | 20:59 |
| mriedem | oh | 20:59 |
| mriedem | oh maybe tssurya had set the series goal which was 'proposed' | 21:00 |
| mriedem | efried: now see if you can do #2 | 21:00 |
| mriedem | https://launchpad.net/~nova-drivers | 21:00 |
| efried | which isn't the same thing as approving the bp, which is an awkward distinction that's unnecessary for us. | 21:00 |
| efried | okay... | 21:00 |
| efried | mriedem: yup, thanks. | 21:01 |
| efried | you may go now | 21:01 |
| openstackgerrit | Merged openstack/python-novaclient master: Replace openstack.org git:// URLs with https:// https://review.openstack.org/647070 | 21:02 |
| tssurya | mriedem, efried: err yea I meant "propose for train" I am not sure why it says accepted | 21:03 |
| efried | tssurya: It's possible you can only say "proposed" and we have to say "accepted". | 21:03 |
| efried | Because apparently "proposed" doesn't show up in the useful dashboard, it only shows up in the useless ones, or if you happen to know the exact url. | 21:03 |
| efried | Launchpad woes | 21:04 |
| efried | tssurya: as stated above ("useless distinction") that doesn't mean the bp is approved for train. It just means it... uhh... shows up instead of now showing up? | 21:05 |
| tssurya | efried: should I just unset it or something ? still its strange I did the same for https://blueprints.launchpad.net/nova/+spec/nova-support-instance-power-update | 21:05 |
| tssurya | and that looks okay | 21:05 |
| tssurya | its "proposed" | 21:06 |
| efried | tssurya: But it doesn't show up in https://blueprints.launchpad.net/nova/train | 21:06 |
| efried | so let me fix it | 21:06 |
| efried | now it does | 21:06 |
| tssurya | ah thanks | 21:07 |
| efried | this leaves me with a problem though | 21:07 |
| efried | I need a way of finding blueprints in "proposed for train" status. | 21:07 |
| *** betherly has joined #openstack-nova | 21:07 | |
| efried | Right now I can only chance upon them, like happened here. | 21:07 |
| *** awaugama has quit IRC | 21:07 | |
| tssurya | haha, I always assumed for some reason the bp's get accepted only *after* the spec gets merged | 21:08 |
| tssurya | but guess all bp's don't have specs | 21:08 |
| *** betherly has quit IRC | 21:11 | |
| *** tssurya has quit IRC | 21:15 | |
| *** mdbooth has joined #openstack-nova | 21:17 | |
| *** mdbooth_ has quit IRC | 21:19 | |
| melwitt | efried: there's a link at the bottom of the page https://blueprints.launchpad.net/nova/train that says "have been proposed" | 21:24 |
| efried | melwitt: AHA, THANK you. | 21:35 |
| efried | I was all digging into the lp API, which appears to bear no relation to what it's documented as being. | 21:38 |
| *** betherly has joined #openstack-nova | 21:39 | |
| *** betherly has quit IRC | 21:44 | |
| *** xek_ has joined #openstack-nova | 21:46 | |
| *** xek__ has joined #openstack-nova | 21:47 | |
| *** xek has quit IRC | 21:49 | |
| *** xek_ has quit IRC | 21:50 | |
| *** itlinux has joined #openstack-nova | 21:54 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Do not persist RequestSpec.ignore_hosts https://review.openstack.org/647512 | 21:56 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Update instance.availability_zone during live migration https://review.openstack.org/647623 | 21:58 |
| *** wolverineav has quit IRC | 22:02 | |
| *** mchlumsky has quit IRC | 22:02 | |
| *** wolverineav has joined #openstack-nova | 22:04 | |
| *** wolverineav has quit IRC | 22:08 | |
| *** mlavalle has quit IRC | 22:08 | |
| *** betherly has joined #openstack-nova | 22:11 | |
| *** BjoernT_ has quit IRC | 22:12 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Update instance.availability_zone during live migration https://review.openstack.org/647623 | 22:13 |
| *** wolverineav has joined #openstack-nova | 22:13 | |
| *** rcernin has joined #openstack-nova | 22:14 | |
| *** betherly has quit IRC | 22:16 | |
| *** munimeha1 has quit IRC | 22:20 | |
| *** ivve has joined #openstack-nova | 22:25 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: docs: Dedupe controller install guides https://review.openstack.org/638715 | 22:53 |
| openstackgerrit | Eric Fried proposed openstack/nova master: docs: Dedupe compute install guides https://review.openstack.org/638716 | 22:53 |
| *** IvensZambrano has quit IRC | 22:58 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Update instance.availability_zone during live migration https://review.openstack.org/647630 | 22:58 |
| *** tkajinam has joined #openstack-nova | 23:01 | |
| *** tkajinam has quit IRC | 23:01 | |
| *** tkajinam has joined #openstack-nova | 23:02 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Error out migration when confirm_resize fails https://review.openstack.org/647546 | 23:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete allocations even if _confirm_resize raises https://review.openstack.org/647566 | 23:03 |
| *** mriedem has quit IRC | 23:03 | |
| *** erlon has joined #openstack-nova | 23:12 | |
| openstackgerrit | Merged openstack/nova master: Clean up block_device_allocate_retries config option help https://review.openstack.org/641759 | 23:24 |
| openstackgerrit | Merged openstack/nova master: Set min=0 for block_device_allocate_retries option https://review.openstack.org/641770 | 23:24 |
| openstackgerrit | Merged openstack/nova master: Remove expiremental note in the VGPU docs https://review.openstack.org/647518 | 23:24 |
| *** stakeda has joined #openstack-nova | 23:41 | |
| *** Sundar has quit IRC | 23:53 | |
| *** xek__ has quit IRC | 23:54 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!