| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add description about sort order in API ref guideline https://review.openstack.org/627282 | 00:00 |
|---|---|---|
| *** takashin has joined #openstack-nova | 00:01 | |
| *** wolverineav has quit IRC | 00:02 | |
| dansmith | efried: I meant os-brick is under cinder, afaik.. os-vif is under nova | 00:02 |
| *** wolverineav has joined #openstack-nova | 00:02 | |
| efried | dansmith: Yes, confirmed. I was confused about that aspect. Anyway, the release is proposed and approved, merging. You may go about your business. | 00:04 |
| efried | (why is os-vif under nova and not neutron if os-brick is under cinder and not nova?) | 00:04 |
| *** sapd1 has quit IRC | 00:16 | |
| jungleboyj | efried: I will request a requirements freeze exception here. | 00:18 |
| *** IvensZambrano has quit IRC | 00:19 | |
| *** snevi has joined #openstack-nova | 00:19 | |
| dansmith | efried: neutron doesn't use os-vif | 00:23 |
| dansmith | or hasn't previously, even though that was the evntual goal | 00:24 |
| *** hongbin has quit IRC | 00:24 | |
| dansmith | they might use some of it now, I forget, but it's not central to their stuff like it is to ours (and os-brick is to cinder) | 00:24 |
| *** snevi has quit IRC | 00:26 | |
| *** owalsh has joined #openstack-nova | 00:27 | |
| *** owalsh_ has quit IRC | 00:27 | |
| *** ttsiouts has quit IRC | 00:28 | |
| *** ttsiouts has joined #openstack-nova | 00:29 | |
| *** ttsiouts has quit IRC | 00:33 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: doc: mark the max microversion for stein https://review.openstack.org/641882 | 00:36 |
| *** eharney has quit IRC | 00:37 | |
| *** wolverineav has quit IRC | 00:49 | |
| *** markvoelker has joined #openstack-nova | 00:50 | |
| *** sapd1 has joined #openstack-nova | 00:50 | |
| *** mriedem_away is now known as mriedem | 00:54 | |
| mriedem | efried: os-brick is cinder's thing | 00:57 |
| mriedem | and a non-client lib so it should have been released last week | 00:57 |
| mriedem | nvm i see you've sorted it out | 00:58 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens https://review.openstack.org/637716 | 01:01 |
| *** wolverineav has joined #openstack-nova | 01:03 | |
| *** mriedem has quit IRC | 01:04 | |
| *** artom has joined #openstack-nova | 01:11 | |
| *** gyee has quit IRC | 01:15 | |
| *** igordc has quit IRC | 01:19 | |
| *** whoami-rajat has joined #openstack-nova | 01:23 | |
| *** markvoelker has quit IRC | 01:23 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM: Testing nova legacy jobs on bionic https://review.openstack.org/639017 | 01:23 |
| *** imacdonn has quit IRC | 01:27 | |
| openstackgerrit | Merged openstack/nova master: Remove cells v1 (for the most part) from the docs https://review.openstack.org/636718 | 01:29 |
| *** Sundar has quit IRC | 01:38 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 01:39 |
| *** wolverineav has quit IRC | 01:39 | |
| *** wolverineav has joined #openstack-nova | 01:40 | |
| *** wolverineav has quit IRC | 01:44 | |
| openstackgerrit | xulei proposed openstack/nova master: Check compute_node existence in when nova-compute reports info to placement https://review.openstack.org/641899 | 01:50 |
| openstackgerrit | xulei proposed openstack/nova master: Check compute_node existence in when nova-compute reports info to placement https://review.openstack.org/641899 | 01:52 |
| *** igordc has joined #openstack-nova | 02:04 | |
| *** tbachman has quit IRC | 02:18 | |
| *** markvoelker has joined #openstack-nova | 02:20 | |
| *** sunnaichuan has joined #openstack-nova | 02:27 | |
| *** mlavalle has quit IRC | 02:28 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 02:37 |
| *** hongbin has joined #openstack-nova | 02:42 | |
| *** jhesketh has quit IRC | 02:45 | |
| *** tbachman has joined #openstack-nova | 02:47 | |
| *** jhesketh has joined #openstack-nova | 02:47 | |
| *** markvoelker has quit IRC | 02:53 | |
| *** tbachman has quit IRC | 02:56 | |
| openstackgerrit | Merged openstack/nova master: Add user_id column to the instance_mappings table https://review.openstack.org/633349 | 03:06 |
| openstackgerrit | Merged openstack/nova master: doc: mark the max microversion for stein https://review.openstack.org/641882 | 03:06 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Should not skip volume_size check for bdm.image_id == image_ref case https://review.openstack.org/641282 | 03:11 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Force to schedule even has force_hosts or force_nodes https://review.openstack.org/641908 | 03:15 |
| *** ianw_pto has quit IRC | 03:23 | |
| *** ianw has joined #openstack-nova | 03:23 | |
| *** rmk has quit IRC | 03:25 | |
| *** mgariepy has quit IRC | 03:25 | |
| *** mgariepy has joined #openstack-nova | 03:26 | |
| *** yaawang has quit IRC | 03:31 | |
| *** lbragstad has quit IRC | 03:32 | |
| *** zhubx007 has quit IRC | 03:35 | |
| *** zhubx007 has joined #openstack-nova | 03:35 | |
| *** yaawang has joined #openstack-nova | 03:36 | |
| *** markvoelker has joined #openstack-nova | 03:50 | |
| *** BjoernT has joined #openstack-nova | 03:58 | |
| *** mdbooth_ has joined #openstack-nova | 04:22 | |
| *** markvoelker has quit IRC | 04:23 | |
| *** udesale has joined #openstack-nova | 04:24 | |
| *** mdbooth has quit IRC | 04:25 | |
| *** abhishekk has joined #openstack-nova | 04:30 | |
| *** whoami-rajat has quit IRC | 04:33 | |
| *** mdbooth has joined #openstack-nova | 04:35 | |
| *** mdbooth_ has quit IRC | 04:37 | |
| *** whoami-rajat has joined #openstack-nova | 04:53 | |
| *** lbragstad has joined #openstack-nova | 05:15 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.openstack.org/635433 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 05:17 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826 | 05:17 |
| *** markvoelker has joined #openstack-nova | 05:20 | |
| *** Dinesh_Bhor has quit IRC | 05:29 | |
| *** takashin has left #openstack-nova | 05:30 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:33 | |
| *** janki has joined #openstack-nova | 05:34 | |
| *** tkajinam has quit IRC | 05:38 | |
| *** tkajinam has joined #openstack-nova | 05:39 | |
| *** hongbin has quit IRC | 05:42 | |
| *** sapd1 has quit IRC | 05:42 | |
| *** sapd1 has joined #openstack-nova | 05:52 | |
| *** markvoelker has quit IRC | 05:53 | |
| *** mikal has quit IRC | 05:55 | |
| *** mikal has joined #openstack-nova | 05:55 | |
| *** zhubx007 has quit IRC | 05:57 | |
| *** zhubx007 has joined #openstack-nova | 05:58 | |
| *** zhubx007 has quit IRC | 06:08 | |
| *** zhubx007 has joined #openstack-nova | 06:08 | |
| *** ratailor has joined #openstack-nova | 06:09 | |
| *** zhubx007 has quit IRC | 06:10 | |
| *** zhubx007 has joined #openstack-nova | 06:10 | |
| *** marst has joined #openstack-nova | 06:12 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Should not skip volume_size check for bdm.image_id == image_ref case https://review.openstack.org/641282 | 06:13 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Split up _is_storage_shared_with() in libvirt driver https://review.openstack.org/639933 | 06:33 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 06:33 |
| cfriesen | these are for testing, pls ignore: ^ | 06:34 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 06:36 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova -- testcase test only https://review.openstack.org/641932 | 06:37 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Split up _is_storage_shared_with() in libvirt driver https://review.openstack.org/639933 | 06:44 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 06:44 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.openstack.org/639934 | 06:44 |
| *** sapd1 has quit IRC | 06:44 | |
| *** ivve has joined #openstack-nova | 06:49 | |
| *** markvoelker has joined #openstack-nova | 06:51 | |
| *** Bhujay has joined #openstack-nova | 06:52 | |
| *** Luzi has joined #openstack-nova | 06:53 | |
| *** sridharg has joined #openstack-nova | 07:06 | |
| *** wolverineav has joined #openstack-nova | 07:09 | |
| *** luksky has joined #openstack-nova | 07:17 | |
| *** markvoelker has quit IRC | 07:23 | |
| *** pcaruana has joined #openstack-nova | 07:26 | |
| *** lbragstad has quit IRC | 07:28 | |
| *** phasespace has quit IRC | 07:44 | |
| *** Bhujay has quit IRC | 07:50 | |
| *** Bhujay has joined #openstack-nova | 07:57 | |
| *** BjoernT has quit IRC | 07:57 | |
| *** tkajinam has quit IRC | 08:00 | |
| *** awalende has joined #openstack-nova | 08:03 | |
| *** wolverineav has quit IRC | 08:04 | |
| *** igordc has quit IRC | 08:04 | |
| *** wolverineav has joined #openstack-nova | 08:05 | |
| *** rpittau|afk is now known as rpittau | 08:06 | |
| *** tesseract has joined #openstack-nova | 08:10 | |
| *** markvoelker has joined #openstack-nova | 08:20 | |
| *** jlejeune_ has joined #openstack-nova | 08:22 | |
| *** jlejeune_ is now known as jlejeune | 08:22 | |
| *** mikal has quit IRC | 08:26 | |
| *** xek_ has joined #openstack-nova | 08:26 | |
| *** xek_ has quit IRC | 08:27 | |
| *** tssurya has joined #openstack-nova | 08:28 | |
| *** xek has joined #openstack-nova | 08:28 | |
| *** Bhujay has quit IRC | 08:31 | |
| *** ttsiouts has joined #openstack-nova | 08:32 | |
| *** ttsiouts has quit IRC | 08:37 | |
| *** phasespace has joined #openstack-nova | 08:42 | |
| *** ttsiouts has joined #openstack-nova | 08:42 | |
| *** liuyulong has joined #openstack-nova | 08:45 | |
| *** wolverineav has quit IRC | 08:46 | |
| *** marst has quit IRC | 08:51 | |
| *** markvoelker has quit IRC | 08:53 | |
| *** mcgiggler has joined #openstack-nova | 09:03 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use Selection object to fill request group mapping https://review.openstack.org/638711 | 09:11 |
| *** pcaruana has quit IRC | 09:12 | |
| *** ccamacho has joined #openstack-nova | 09:16 | |
| *** pcaruana has joined #openstack-nova | 09:27 | |
| *** ralonsoh has joined #openstack-nova | 09:35 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use Selection object to fill request group mapping https://review.openstack.org/638711 | 09:43 |
| aspiers | kashyap: I'm intrigued in which ways is the term "domain" Xen-specific? | 09:45 |
| aspiers | AFAICS libvirt uses it everywhere | 09:45 |
| kashyap | aspiers: libvirt's terminology of "domain" for a "guest" is a hold-over from Xen times. | 09:45 |
| kashyap | aspiers: Can you explain what is a "host domain"? :-) | 09:46 |
| kashyap | I mean, not being flippant. Just trying to put myself in an operator's shoes reading the log | 09:46 |
| aspiers | Your point being that KVM doesn't have a dom0? | 09:46 |
| kashyap | Yep | 09:46 |
| kashyap | "host hypervisor" is more generic | 09:46 |
| kashyap | Not sure you agree :-) | 09:47 |
| aspiers | No, it's a good point that operators read logs and are less likely to understand arcane libvirt / Xen terminology | 09:47 |
| aspiers | I do agree | 09:47 |
| *** rcernin has quit IRC | 09:47 | |
| aspiers | I was trying to adhere to libvirt terminology since that's what the code aligns with, but that's not as good for operators so I'll change it. | 09:48 |
| *** IvensZambrano has joined #openstack-nova | 09:49 | |
| kashyap | aspiers: Nod, I did notice you were being careful to use the correct terminology | 09:49 |
| *** markvoelker has joined #openstack-nova | 09:51 | |
| *** wolverineav has joined #openstack-nova | 09:57 | |
| *** wolverineav has quit IRC | 10:02 | |
| *** IvensZambrano is now known as snevi | 10:09 | |
| *** mikal has joined #openstack-nova | 10:12 | |
| *** amodi has quit IRC | 10:15 | |
| *** mikal has quit IRC | 10:17 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855 | 10:20 |
| *** jistr is now known as jistr|biab | 10:21 | |
| *** ccamacho has quit IRC | 10:21 | |
| *** markvoelker has quit IRC | 10:23 | |
| aspiers | kashyap: https://review.openstack.org/#/c/633855/10..11/nova/virt/libvirt/host.py | 10:25 |
| kashyap | Thank you | 10:25 |
| kashyap | aspiers: Also, once again kudos for the very nice doc string | 10:26 |
| aspiers | thanks :) | 10:26 |
| *** cdent has joined #openstack-nova | 10:30 | |
| *** ccamacho has joined #openstack-nova | 10:30 | |
| *** abhishekk has quit IRC | 10:32 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: qemu: Make disk image conversion dramatically faster https://review.openstack.org/640781 | 10:37 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode for Nova instances https://review.openstack.org/641981 | 10:37 |
| kashyap | stephenfin: Commented here: https://review.openstack.org/#/c/640866/; it's a simple phrasing fix that removes any ambiguity whatsover, let's please do it? | 10:48 |
| *** jistr|biab has quit IRC | 10:51 | |
| *** jistr has joined #openstack-nova | 10:54 | |
| *** udesale has quit IRC | 11:03 | |
| *** udesale has joined #openstack-nova | 11:04 | |
| *** luksky has quit IRC | 11:06 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use Selection object to fill request group mapping https://review.openstack.org/638711 | 11:08 |
| *** dtantsur|afk is now known as dtantsur | 11:08 | |
| *** ratailor has quit IRC | 11:17 | |
| *** markvoelker has joined #openstack-nova | 11:20 | |
| *** jaosorior has quit IRC | 11:20 | |
| sean-k-mooney | did we kill force evacuate yesterday when we released python-novaclient | 11:28 |
| sean-k-mooney | http://logs.openstack.org/65/607365/24/gate/nova-live-migration/0e40d39/job-output.txt.gz#_2019-03-08_07_40_10_653566 | 11:28 |
| sean-k-mooney | looks like we broke the nova-live-migration job | 11:30 |
| sean-k-mooney | lets see if i can figure out where to fix that | 11:31 |
| *** jaosorior has joined #openstack-nova | 11:32 | |
| *** cdent has quit IRC | 11:33 | |
| *** liuyulong_zzZZZ is now known as liuyulong_ | 11:34 | |
| *** luksky has joined #openstack-nova | 11:36 | |
| bauzas | sean-k-mooney: that's why we provided a major version | 11:37 |
| sean-k-mooney | ya | 11:37 |
| sean-k-mooney | i found the issue | 11:37 |
| sean-k-mooney | https://github.com/openstack/nova/blob/1554d35834a474514f827449bd7d4f1d2f0af1d6/gate/test_evacuate.sh#L64-L90 | 11:37 |
| sean-k-mooney | not really sure if i should just remove that or what | 11:37 |
| bauzas | the force flag is no longer accepted | 11:37 |
| sean-k-mooney | i know | 11:38 |
| bauzas | unless you provide a specific microversion | 11:38 |
| sean-k-mooney | we removed the api | 11:38 |
| *** erlon has joined #openstack-nova | 11:38 | |
| sean-k-mooney | ha i could use the old microverion yes | 11:38 |
| bauzas | AFAIR, we still need to use the force flag or just using a specific aggregate for forcing to use a compute | 11:39 |
| sean-k-mooney | ya ok ill do that and ill see if we can de evacuate with osc while ime at it | 11:39 |
| bauzas | sean-k-mooney: thanks | 11:39 |
| * bauzas needs to go off | 11:39 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use assertXmlEqual() helper for all XML comparison tests https://review.openstack.org/641852 | 11:43 |
| aspiers | stephenfin: https://review.openstack.org/#/c/641852/2..3/nova/test.py | 11:44 |
| sean-k-mooney | dumb question but --os-compute-api-version is used to set the microverion right | 11:48 |
| sean-k-mooney | wew dont use the term micro version in the help text | 11:48 |
| openstackgerrit | sean mooney proposed openstack/nova master: update gate test for removal of force evacuate https://review.openstack.org/641986 | 11:52 |
| *** markvoelker has quit IRC | 11:54 | |
| *** mikal has joined #openstack-nova | 11:54 | |
| *** panda|rover is now known as panda|rover|lunc | 11:54 | |
| *** mikal has quit IRC | 12:00 | |
| *** tosky has joined #openstack-nova | 12:12 | |
| *** _pewp_ has quit IRC | 12:12 | |
| *** _pewp_ has joined #openstack-nova | 12:13 | |
| *** mcgiggler has quit IRC | 12:18 | |
| *** ttsiouts has quit IRC | 12:19 | |
| *** ttsiouts has joined #openstack-nova | 12:20 | |
| kashyap | mdbooth: On the off-chance you have time today: https://review.openstack.org/#/c/641981/ | 12:20 |
| kashyap | FWIW, the code comment I wrote in there, I got it reviewed by Kevin Wolf of QEMU. | 12:20 |
| *** yaawang has quit IRC | 12:21 | |
| *** cdent has joined #openstack-nova | 12:21 | |
| *** yaawang has joined #openstack-nova | 12:22 | |
| *** shilpasd has joined #openstack-nova | 12:22 | |
| *** ttsiouts has quit IRC | 12:24 | |
| shilpasd | smcginnis: Hi, need review for openstack/releases patch for masakariclient https://review.openstack.org/#/c/641988/1 | 12:25 |
| shilpasd | dtantsur: Hi, need review for openstack/releases patch for masakariclient https://review.openstack.org/#/c/641988/1 | 12:25 |
| dtantsur | shilpasd: hi, why do you want a review from me on that? I have no relationship to either releases or masakari (or nova) | 12:28 |
| shilpasd | dtantsur: ohh, thanks for confirmation, please ignore the request | 12:30 |
| openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.openstack.org/641994 | 12:31 |
| kashyap | aspiers: s/Stein/Train/ in the commit message :-) | 12:33 |
| bauzas | sean-k-mooney: yup, that's the field to use | 12:35 |
| aspiers | kashyap: doh :) | 12:39 |
| openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.openstack.org/641994 | 12:39 |
| *** hemna has joined #openstack-nova | 12:42 | |
| *** ttsiouts has joined #openstack-nova | 12:44 | |
| shilpasd | smcginnis: Thank you for workflow +1 for masakariclient https://review.openstack.org/#/c/641988/1 | 12:48 |
| smcginnis | shilpasd: No problem. Probably best not to use the nova channel to discuss release activities for masakari though. ;) | 12:51 |
| shilpasd | smcginnis: ok, will take a note of it | 12:52 |
| *** sridharg has quit IRC | 12:56 | |
| *** snevi has quit IRC | 12:58 | |
| *** sridharg has joined #openstack-nova | 12:59 | |
| *** snevi has joined #openstack-nova | 13:03 | |
| *** janki has quit IRC | 13:07 | |
| *** ivve has quit IRC | 13:08 | |
| cdent | gibi: is the rest of the bandwidth resource provider expected to land or is it being kicked to train? | 13:11 |
| sean-k-mooney | cdent: on monday i think there were only 3 patches left for stien | 13:12 |
| sean-k-mooney | the rest was going to be in train | 13:12 |
| sean-k-mooney | i dont know if we got those 3 in | 13:12 |
| sean-k-mooney | https://review.openstack.org/#/c/636360/ | 13:13 |
| cdent | thanks sean-k-mooney. trying to make some notes about it in the pupdate | 13:13 |
| sean-k-mooney | cdent: ^ that was the patch that enabled the feature i think] | 13:13 |
| sean-k-mooney | so if i was following correctly we have landed enough for spwaning vms with bandwith request | 13:14 |
| sean-k-mooney | all move opertaions are puntted to train | 13:15 |
| gibi | cdent: the heal_allocation part is train (but will be backportad as that is a nova-manage extension). starts here: https://review.openstack.org/#/c/637953 | 13:16 |
| cdent | thanks gibi | 13:16 |
| sean-k-mooney | gibi: we are going to make this as compelte right https://blueprints.launchpad.net/nova/+spec/bandwidth-resource-provider | 13:16 |
| gibi | cdent: there is two bug like things https://review.openstack.org/#/c/639608/ | 13:16 |
| gibi | cdent: https://review.openstack.org/#/c/638711/ | 13:16 |
| sean-k-mooney | and add a new spec/blueprint for the final bits for train? | 13:16 |
| gibi | sean-k-mooney: I'm not sure, the original spec talked about serve move operations which was not finished (not even started) in Stein | 13:17 |
| *** eharney has joined #openstack-nova | 13:17 | |
| gibi | sean-k-mooney: I have to talk to melwitt and mriedem about the administration | 13:17 |
| sean-k-mooney | sure | 13:17 |
| *** frickler has quit IRC | 13:17 | |
| gibi | cdent: and there is test coverage extension and refactor here https://review.openstack.org/#/c/641679/ | 13:17 |
| *** frickler has joined #openstack-nova | 13:18 | |
| sean-k-mooney | but enough has lannded that wyou can boot a vm with a min bandwith request now? | 13:18 |
| gibi | sean-k-mooney: I'm OK in both ways | 13:18 |
| gibi | sean-k-mooney: yeas, boot, delete, and detach port works | 13:18 |
| cdent | \o/ | 13:18 |
| sean-k-mooney | cool :) i need to go test that i guess but that is good to see | 13:19 |
| *** agopi has joined #openstack-nova | 13:19 | |
| sean-k-mooney | gibi: we dont have any tempest tests for this right? | 13:20 |
| sean-k-mooney | we can praobly add them to the numa/nfv test discussion at the ptg | 13:20 |
| *** panda|rover|lunc is now known as panda|rover | 13:25 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Delete orphaned RS and IM records of archived instances https://review.openstack.org/560042 | 13:26 |
| *** pcaruana has quit IRC | 13:30 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.openstack.org/639091 | 13:30 |
| gibi | sean-k-mooney: there is a tempest test proposed https://review.openstack.org/#/c/629253/ | 13:34 |
| gibi | sean-k-mooney: today I finally able too make an env with real SRIOV so I tested that the SRIOV part of the feature works | 13:35 |
| gibi | so far so good | 13:35 |
| *** mriedem has joined #openstack-nova | 13:38 | |
| mriedem | i heard the gate is broken? | 13:39 |
| *** janki has joined #openstack-nova | 13:40 | |
| mriedem | ah shit i see | 13:42 |
| sean-k-mooney | mriedem: i proposed a patch for the --force issue | 13:42 |
| mriedem | link? | 13:42 |
| mriedem | bauzas: i bit my own ass http://logs.openstack.org/50/633350/16/check/nova-live-migration/86f6551/job-output.txt.gz#_2019-03-08_09_20_42_237644 | 13:42 |
| sean-k-mooney | https://review.openstack.org/#/c/641986/1 | 13:42 |
| sean-k-mooney | wrong link | 13:42 |
| sean-k-mooney | oh no never mind | 13:42 |
| sean-k-mooney | ya that was the failure | 13:43 |
| bauzas | mriedem: yup, sean-k-mooney discovered it | 13:43 |
| mriedem | is there a bug? | 13:43 |
| sean-k-mooney | well technically one of the sriov live migration ptachs discovered it when it was running its gate job | 13:44 |
| sean-k-mooney | no but i can open one quickly | 13:44 |
| sean-k-mooney | then respin the patch | 13:44 |
| *** lbragstad has joined #openstack-nova | 13:44 | |
| mriedem | i'm opening one | 13:45 |
| mriedem | just for e-r | 13:45 |
| sean-k-mooney | ok ill stop creating one so. | 13:45 |
| sean-k-mooney | i also looked and osc still does not have evacuate support | 13:46 |
| sean-k-mooney | do we want to go add it? | 13:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: update gate test for removal of force evacuate https://review.openstack.org/641986 | 13:46 |
| *** zhubx007 has quit IRC | 13:46 | |
| *** zhubx007 has joined #openstack-nova | 13:47 | |
| mriedem | yes osc should have evacuate support at some point | 13:47 |
| sean-k-mooney | e.g. i will be on a plane for a few hours tomorrow should i go play with trying to add it | 13:47 |
| sean-k-mooney | ill pull down osc anyway just to have it. does anyone know if they swapped to useing the sdk yet? | 13:49 |
| *** jiteka has joined #openstack-nova | 13:51 | |
| mriedem | not for nova | 13:53 |
| mriedem | but some things yes, like neutron i think | 13:53 |
| *** derekh has joined #openstack-nova | 13:53 | |
| sean-k-mooney | mriedem: by the way what does e-r stand for. | 13:57 |
| sean-k-mooney | oh elastic recheck | 13:57 |
| mriedem | yeah | 13:57 |
| *** mlavalle has joined #openstack-nova | 14:00 | |
| *** ccamacho has quit IRC | 14:01 | |
| *** marst has joined #openstack-nova | 14:03 | |
| *** snevi has quit IRC | 14:04 | |
| *** cdent has quit IRC | 14:06 | |
| *** BjoernT has joined #openstack-nova | 14:08 | |
| sean-k-mooney | out of interest if i was to add evacuate to osc, would people object to me calling it "recreate" e.g. openstack server recreate or somethign closer to what it actully does? | 14:08 |
| edleafe | sean-k-mooney: generally the osc names are supposed to be saner than the names in the python-*client libraries | 14:09 |
| sean-k-mooney | ya what i would personally prefer is 3 commands | 14:10 |
| sean-k-mooney | openstack server recreate e.g. nova evacuate | 14:10 |
| sean-k-mooney | openstack host evacuate e.g. nova host-evecuate | 14:11 |
| sean-k-mooney | and opentack host evacuate --live fo nova host-evacuate-live | 14:11 |
| *** BjoernT_ has joined #openstack-nova | 14:11 | |
| sean-k-mooney | or actully it could be openstack host migrate and openstack host migrate --live | 14:12 |
| *** awalende has quit IRC | 14:13 | |
| *** BjoernT has quit IRC | 14:13 | |
| *** awalende has joined #openstack-nova | 14:13 | |
| sean-k-mooney | in anycase i have never modifed osc before so ill jsut start with porting nova evacuate and see how things go | 14:13 |
| bauzas | sean-k-mooney: openstack host evacuate doesn't exist from an API PoV | 14:14 |
| bauzas | it's just a client thingy | 14:14 |
| edleafe | yeah, I'm not sure which terms would make the most sense. But yes, names that actually convey what the call does are preferred. :) | 14:14 |
| sean-k-mooney | bauzas: yes i know | 14:14 |
| bauzas | so, no to be an OSC CLI command | 14:14 |
| sean-k-mooney | bauzas: is that a rule that osc cant have things that are not directly supported by the api | 14:15 |
| bauzas | good question | 14:15 |
| sean-k-mooney | but ok i was going to look at those after so no worries ill just focus on nova evacuate first ot figure out how things work | 14:15 |
| bauzas | but honestly, I hate the host-evacuate method | 14:15 |
| *** mcgiggler has joined #openstack-nova | 14:16 | |
| * sean-k-mooney note to self dont add bauzas to the review if i work on it :) | 14:16 | |
| sean-k-mooney | ya i have personally neverr used it but i have used the horizon one in the past but mainly for testing | 14:17 |
| *** awalende has quit IRC | 14:18 | |
| *** sridharg has quit IRC | 14:18 | |
| bauzas | sean-k-mooney: FWIW, I'm planning to ask for some time for me in the next cycle for OSC gap closure | 14:19 |
| bauzas | on the next week :p | 14:19 |
| bauzas | so you could see my name somewhere in your OSC evacuate change :p | 14:20 |
| sean-k-mooney | oh cool we brought it up at the last ptg but stephen and i never really got around to doing it | 14:20 |
| *** markvoelker has joined #openstack-nova | 14:20 | |
| sean-k-mooney | it woudl be nice to swap entirely to osc at some point | 14:21 |
| sean-k-mooney | but ya there are a number of challanges with that at present | 14:21 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.openstack.org/642030 | 14:24 |
| *** sunnaichuan has quit IRC | 14:29 | |
| *** awaugama has joined #openstack-nova | 14:30 | |
| *** sridharg has joined #openstack-nova | 14:31 | |
| *** IvensZambrano has joined #openstack-nova | 14:32 | |
| *** mrch has quit IRC | 14:32 | |
| sean-k-mooney | speaking of spec i need to write and review a few | 14:34 |
| *** pcaruana has joined #openstack-nova | 14:37 | |
| *** jchhatbar has joined #openstack-nova | 14:40 | |
| *** cdent has joined #openstack-nova | 14:41 | |
| *** phasespace has quit IRC | 14:41 | |
| *** jchhatba_ has joined #openstack-nova | 14:42 | |
| *** janki has quit IRC | 14:42 | |
| bauzas | sean-k-mooney: closing OSC gap is one thing, swap to OSC is a totally different thing | 14:44 |
| bauzas | sean-k-mooney: I'm just talking of the next TC goal which is somehow close to the former | 14:44 |
| bauzas | at least at the last consensus point we had | 14:45 |
| *** jchhatbar has quit IRC | 14:45 | |
| *** s10 has joined #openstack-nova | 14:50 | |
| *** snevi has joined #openstack-nova | 14:51 | |
| *** IvensZambrano has quit IRC | 14:51 | |
| *** efried is now known as fried_rice | 14:51 | |
| *** wolverineav has joined #openstack-nova | 14:51 | |
| *** mikal has joined #openstack-nova | 14:53 | |
| *** markvoelker has quit IRC | 14:54 | |
| *** wolverineav has quit IRC | 14:55 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Dont' wait for VIF plugging during revert resize https://review.openstack.org/639396 | 14:57 |
| artom | Alright, I think the tests should pass on ^^ now | 14:57 |
| *** mikal has quit IRC | 14:57 | |
| artom | mriedem, can I ask you to hit that when you get a moment? You're neck-deep in the resize flow anyways ;) | 14:57 |
| dansmith | mriedem: fried_rice: related failure to a novaclient release? http://logs.openstack.org/92/624592/11/gate/nova-live-migration/06aea60/job-output.txt.gz#_2019-03-08_12_45_00_250123 | 14:58 |
| artom | stephenfin, how much do you know about resize? Can I pick you as the lucky RH core for ^^ ? | 14:59 |
| mriedem | dansmith: yes | 15:00 |
| mriedem | dansmith: https://review.openstack.org/#/c/641986/ | 15:00 |
| *** mrch has joined #openstack-nova | 15:01 | |
| dansmith | ah okay | 15:01 |
| mriedem | artom: did you sort that out with dansmith? | 15:01 |
| dansmith | mriedem: he's just removing a wait for events on resize, which is more a you think than me | 15:02 |
| dansmith | it doesn't break the context manager for waiting for events, so I'm happy(er) | 15:02 |
| artom | mriedem, I think so. I also checked with slaweq who's in our Neutron team, and he confirmed that the VIF remains plugged on the source host | 15:03 |
| dansmith | artom: um, what? :) | 15:03 |
| artom | dansmith, what what? | 15:04 |
| artom | Is plugged the right word? Wired? | 15:04 |
| mriedem | i feel like i just had a patch like this | 15:04 |
| mriedem | but was maybe for confirm | 15:04 |
| dansmith | artom: that makes no sense for what you're saying here | 15:04 |
| artom | dansmith, entirely plausible, but explain how :) | 15:04 |
| dansmith | oh, this is finish_revert, I see | 15:04 |
| dansmith | I thought it was finish-finish | 15:05 |
| artom | Swedish finish? | 15:05 |
| aspiers | sean-k-mooney: strong +1 for renaming evacuate, my preferred term would probably be "resurrect" | 15:05 |
| dansmith | but still, you're not asserting this was always broken right? | 15:05 |
| artom | dansmith, always racy | 15:05 |
| dansmith | artom: what's it racing with? | 15:05 |
| artom | Neutron with the virt driver | 15:05 |
| aspiers | sean-k-mooney: "revive" might also work | 15:06 |
| mriedem | artom: so you're reverting this essentially right? https://review.openstack.org/#/q/I9e0cffb889c94713c7f28812918103a5d97cefeb | 15:06 |
| artom | mriedem, err, yes. WTF. | 15:06 |
| mriedem | ok -1 until we have a good explanation of why https://review.openstack.org/#/c/595069/ was wrong | 15:08 |
| *** Luzi has quit IRC | 15:08 | |
| mriedem | but maybe that explains a regression you're seeing downstream? | 15:08 |
| dansmith | artom: okay, so tickling from compute manager will cause that event to start heading towards us because there are still interfaces available for neutron agent to find.. I kinda buy that, I guess... | 15:08 |
| artom | mriedem, fair enough | 15:08 |
| dansmith | I also -1d for the drunk speak in the commit message | 15:09 |
| artom | ... | 15:09 |
| artom | Well now you're just picking on em :( | 15:09 |
| artom | *me | 15:09 |
| dansmith | but yeah, I'd like to hear from lyarwood I guess | 15:09 |
| mriedem | dansmith: it was my change :) | 15:09 |
| mriedem | lyarwood backported it | 15:09 |
| mriedem | and https://review.openstack.org/#/c/179228/ was your change :) | 15:10 |
| mriedem | it's great | 15:10 |
| artom | In a meeting now, I think I'll have to play around with it afterwards | 15:10 |
| artom | Until now I was relying on logs | 15:10 |
| artom | Yo-yo patches... | 15:11 |
| stephenfin | oh, that's interesting | 15:11 |
| dansmith | oh | 15:15 |
| mriedem | artom: dansmith: ok so i see the race in https://review.openstack.org/#/c/595069/ | 15:15 |
| mriedem | the dest triggers the event, | 15:15 |
| mriedem | the source is waiting for it, | 15:15 |
| *** jchhatba_ has quit IRC | 15:15 | |
| mriedem | but it might come before the source is registered for the callback | 15:15 |
| *** janki has joined #openstack-nova | 15:16 | |
| dansmith | so wait, we've gone back and forth twice now? | 15:16 |
| mriedem | dest unplugs vifs when it calls driver.destroy | 15:16 |
| mriedem | yes | 15:16 |
| mriedem | when the original change was made by dansmith we didn't have the code in the API which routes events to both the source and host if the instance had a migration context | 15:16 |
| mriedem | so when i made my change, the source will get the event routed to it, | 15:16 |
| mriedem | but, we might not be registered for the callback on the source by the time the event arrives | 15:17 |
| mriedem | as you can see from my comments in https://review.openstack.org/#/c/179228/ it's all very confusing | 15:17 |
| mriedem | the sequence of events is kind of tribal knowledge with only 1.5 people in the tribe nowadays | 15:18 |
| *** amodi has joined #openstack-nova | 15:18 | |
| mriedem | so we should probably (1) revert my change and (2) add a comment in the libvirt driver finish_revert_migration code about why we don't wait for the event (like there is a comment in finish_migration) | 15:19 |
| mriedem | because the event does come to the source, but we are racing to catch it | 15:20 |
| *** udesale has quit IRC | 15:21 | |
| mriedem | actually...finish_revert_migration does plug vifs, | 15:21 |
| mriedem | so why wouldn't we get an event for that on the source? | 15:21 |
| *** udesale has joined #openstack-nova | 15:21 | |
| mriedem | dest unplugs vifs on revert_resize because of driver.destroy, | 15:21 |
| mriedem | source plugs vifs because of finish_revert_migration which re-spawns the guest | 15:21 |
| mriedem | artom: are you seeing this downstream with OVS or linuxbridge? | 15:22 |
| artom | mriedem, ovs | 15:22 |
| artom | mriedem, we do get the event on the source, just before we wait for it | 15:23 |
| artom | Because as soon as Neutron gets the API call, it's able to wire them and send us the events | 15:23 |
| *** janki has quit IRC | 15:23 | |
| mriedem | the network-vif-plugged event? | 15:23 |
| artom | Yeah | 15:23 |
| mriedem | ok that's from something else then | 15:24 |
| mriedem | because when the source calls plug_vifs during finish_revert_migration, it's doing it within the context to wait for the event | 15:24 |
| artom | mriedem, do you have access to slaweq's notes on our downstream BZ? | 15:25 |
| artom | mriedem, https://bugzilla.redhat.com/show_bug.cgi?id=1678681#c8 | 15:25 |
| openstack | bugzilla.redhat.com bug 1678681 in openstack-nova "REVERT_RESIZE stuck for 300s: "VirtualInterfaceCreateException: Virtual Interface creation failed" [Medium,On_dev] - Assigned to alifshit | 15:25 |
| mriedem | artom: then i'm pretty sure it's what we've talked about before, finish_revert_resize on the source host calls migrate_instance_finish which updates the port binding to point at the source host, which triggers an event | 15:26 |
| mriedem | *before* the driver registers the callback | 15:26 |
| artom | mriedem, right, but there's another thing at play here - Neutron will only wire the ports after we plug them | 15:27 |
| artom | ... I think | 15:27 |
| mriedem | yes i can read his comments and i think they align with what i just said, | 15:28 |
| mriedem | "Nova then asks neutron to bind port on compute-0 again, at it happens:" - that's the migrate_instance_finish call on the source finish_revert_resize to update the port binding | 15:28 |
| mriedem | "And after that, L2 agent on compute-0 wire port again:" - i assume that's the plug_vifs call from the driver's finish_revert_migration on the source host | 15:29 |
| mriedem | artom: how recreateable is this? it would be a lot more clear if we just had some logging on the source that said, "updating port bindings to point at the source host" and then "finish revert migration in the driver which will plug vifs" | 15:30 |
| mriedem | because if we saw the event come between those 2 messages we know it's the port binding change that is triggering the event before we're ready to wait for it | 15:30 |
| artom | mriedem, like, 70% in our CI? | 15:30 |
| mriedem | are you able to test with patches from upstream? | 15:31 |
| artom | I'd need to check with the CI guys, but I could provide them test builds, yeah | 15:31 |
| kashyap | aspiers: You about...? | 15:31 |
| *** s10 has quit IRC | 15:32 | |
| *** s10 has joined #openstack-nova | 15:32 | |
| *** shilpasd has quit IRC | 15:32 | |
| kashyap | aspiers: When you are -- at the risk of adding more work ... wonder if we should simply split out the addition of getDomainCapablities() method into its own patch. | 15:32 |
| *** s10 has quit IRC | 15:32 | |
| mriedem | artom: ew do you have to patch an rpm or something? | 15:33 |
| *** s10 has joined #openstack-nova | 15:33 | |
| kashyap | It is just my OCD of "one logical change per-patch thing". And it allows quicker merge, too. As it'll be easier on the reviewers eyes | 15:33 |
| artom | mriedem, scratch build | 15:33 |
| artom | Backport a patch, build RPMs with that | 15:33 |
| *** s10 has quit IRC | 15:33 | |
| *** s10 has joined #openstack-nova | 15:34 | |
| mriedem | artom: actually you should be able to determine this with existing logs | 15:34 |
| kashyap | (A "scratch build" is something that is short-lived, and will be "scratched" from the build system) | 15:34 |
| *** s10 has quit IRC | 15:34 | |
| *** s10 has joined #openstack-nova | 15:34 | |
| artom | (Backport a patch, build a SRPM without pushing anything, scratch build, I should have said) | 15:34 |
| mriedem | artom: you should see this on the source https://github.com/openstack/nova/blob/4f9bc724010f0c935bf83a6d19bdd805e86b7086/nova/network/neutronv2/api.py#L3355 | 15:35 |
| *** s10 has quit IRC | 15:35 | |
| mriedem | with binding:host_id changing to point at the source host | 15:35 |
| *** s10 has joined #openstack-nova | 15:35 | |
| mriedem | and then you should see this from the driver https://github.com/openstack/nova/blob/4f9bc724010f0c935bf83a6d19bdd805e86b7086/nova/virt/libvirt/driver.py#L8965 | 15:35 |
| artom | mriedem, ack, looking | 15:35 |
| *** s10 has quit IRC | 15:36 | |
| *** s10 has joined #openstack-nova | 15:36 | |
| mriedem | granted there is some other stuff that happens in the driver after that before unplug_vifs happens, so it's a tight window | 15:36 |
| *** s10 has quit IRC | 15:36 | |
| *** s10 has joined #openstack-nova | 15:37 | |
| *** s10 has quit IRC | 15:37 | |
| *** s10 has joined #openstack-nova | 15:38 | |
| *** s10 has quit IRC | 15:38 | |
| *** s10 has joined #openstack-nova | 15:38 | |
| *** jangutter has quit IRC | 15:39 | |
| *** s10 has quit IRC | 15:39 | |
| *** s10 has joined #openstack-nova | 15:39 | |
| *** s10 has quit IRC | 15:40 | |
| *** s10 has joined #openstack-nova | 15:40 | |
| *** s10 has quit IRC | 15:40 | |
| *** s10 has joined #openstack-nova | 15:41 | |
| *** s10 has quit IRC | 15:41 | |
| *** s10 has joined #openstack-nova | 15:42 | |
| aspiers | kashyap: yeah could do, I kind of like there being an incentive to get SEV stuff merged though ;-) | 15:42 |
| *** s10 has quit IRC | 15:42 | |
| *** s10 has joined #openstack-nova | 15:42 | |
| aspiers | when do we fork for stein? | 15:42 |
| *** s10 has quit IRC | 15:43 | |
| kashyap | aspiers: Yeah, I hear you. But as we both know ... it can be used for multiple features :-) | 15:43 |
| *** s10 has joined #openstack-nova | 15:43 | |
| kashyap | (I won't insist on it, though. But if you appetite...) | 15:43 |
| aspiers | we already hit feature freeze, right? | 15:43 |
| aspiers | https://wiki.openstack.org/wiki/Nova/Stein_Release_Schedule | 15:44 |
| kashyap | aspiers: Yes, yesterday | 15:44 |
| *** s10 has quit IRC | 15:44 | |
| kashyap | mriedem: ^ Right? | 15:44 |
| *** s10 has joined #openstack-nova | 15:44 | |
| *** s10 has quit IRC | 15:44 | |
| mriedem | yes | 15:45 |
| mriedem | please don't be approving anything that's not already approved | 15:45 |
| kashyap | aspiers: Also think of it this way: splitting it out allows it to be merged while SEV bits get reviewed :-) | 15:45 |
| *** s10 has joined #openstack-nova | 15:45 | |
| aspiers | I guess | 15:45 |
| kashyap | mriedem: This (AMD SEV work) was already approved for Stein | 15:45 |
| *** s10 has quit IRC | 15:45 | |
| aspiers | I think mriedem means W+1 | 15:45 |
| kashyap | aspiers: But sorry to be "that guy"; you're allowed to hate me for 5 minutes. | 15:45 |
| aspiers | haha | 15:46 |
| sean-k-mooney | aspiers: we will fork stien at RC1 so master is feature frozen for the next 2 ish weeks until that is done i think | 15:46 |
| aspiers | sean-k-mooney: OK thanks | 15:46 |
| kashyap | aspiers: This work will spill over into "Train", yes? | 15:47 |
| sean-k-mooney | rc1 will be around march 21st | 15:47 |
| aspiers | kashyap: https://review.openstack.org/#/c/641994/ | 15:47 |
| aspiers | Oh, you already saw that :) | 15:47 |
| aspiers | I forgot | 15:47 |
| kashyap | Yeah, no worries. | 15:47 |
| *** fried_rice is now known as efried_afk | 15:48 | |
| aspiers | Anyway, ultimately I need to do whatever you guys think is best :) | 15:48 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Documentation for bandwidth support https://review.openstack.org/642064 | 15:48 |
| aspiers | If splitting it out helps then let's do that | 15:48 |
| kashyap | aspiers: Yeah, it also will be less "daunting" to those who don't normally dwell on this area of code | 15:49 |
| aspiers | Sure | 15:49 |
| mriedem | what are you talking about splitting out? | 15:49 |
| aspiers | the call to getDomainCapabilities | 15:49 |
| *** marst has quit IRC | 15:50 | |
| *** TheJulia is now known as needssleep | 15:50 | |
| kashyap | mriedem: Yeah, the adding of getDomainCapablities() in libvirt/host.py | 15:50 |
| aspiers | kashyap: I was also thinking about splitting this code move out https://review.openstack.org/#/c/633855/11/nova/virt/libvirt/utils.py | 15:50 |
| mriedem | aspiers: ok, i see you already put the -W back on your own change that i don't want merged in stein at this point, so you know where i am on this | 15:50 |
| kashyap | mriedem: This bit (line 680): https://review.openstack.org/#/c/633855/11/nova/virt/libvirt/host.py | 15:50 |
| *** markvoelker has joined #openstack-nova | 15:51 | |
| *** luksky has quit IRC | 15:51 | |
| mriedem | sure, split that out even if to just make that change smaller and easier to grok | 15:51 |
| mriedem | too much code in one patch == hard to review | 15:51 |
| aspiers | mriedem: yes, that's also why I submitted https://review.openstack.org/#/c/641994/ | 15:51 |
| kashyap | (Yeah, I agree with mriedem on AMD SEV for Stein, I'm afraid.) | 15:51 |
| kashyap | aspiers: Yes. The machine_type_mappings() in a separate change is good, too. | 15:52 |
| aspiers | There's not even a debate on that, since feature freeze was yesterday :) | 15:52 |
| *** dtantsur is now known as creepy_owlet | 15:52 | |
| mriedem | aspiers: you'd be surprised | 15:52 |
| *** mdbooth has quit IRC | 15:52 | |
| aspiers | Haha OK, well I'm sure some vendors are insane but not us | 15:52 |
| kashyap | It's the same story with upstream _kernel_ as well :D | 15:54 |
| aspiers | Yup | 15:54 |
| aspiers | SUSE knows all about that ... | 15:54 |
| kashyap | Once they start cutting long-term 'stable' release, everyone starts running around headless-chickens | 15:54 |
| kashyap | ... "we need to get this into the "long-term" release!" | 15:54 |
| sean-k-mooney | kashyap: honestly i think that is better the feature backports | 15:54 |
| gibi | mriedem, melwitt: I'm wondering about how to close the https://blueprints.launchpad.net/nova/+spec/bandwidth-resource-provider the spec talks about the server move operations that was not implemented in Stein so if we use that as a scope then the bp cannot be marked implemented | 15:55 |
| kashyap | sean-k-mooney: Not saying it's bad :-) Just the reality and the incentive structure I guess | 15:55 |
| mriedem | gibi: i think we can complete the blueprint in stein and have a separate blueprint for move operations in train | 15:55 |
| aspiers | OK I'm done for the week. I'll look at splitting that out into 3 reviews next week | 15:55 |
| aspiers | Have a good w/e all! o/ | 15:55 |
| kashyap | aspiers: Just a heads-up, next week the first three days I'm travelling; so, if I'm slow on responding ... you know why :-) | 15:56 |
| kashyap | Have a good one! | 15:56 |
| aspiers | OK np :) | 15:56 |
| gibi | mriedem: shall I remove the move operation from the old spec when I update that now? | 15:56 |
| mriedem | gibi: are you going to amend the stein spec for the microversion and all the other stuff that came up? | 15:56 |
| mriedem | i guess i'm not sure what you're asking me :) | 15:57 |
| gibi | mriedem: yeah I'm plannig to amend the spec | 15:57 |
| gibi | mriedem: so I can remove the move from the scope there | 15:57 |
| *** lbragstad is now known as elbragstad | 15:58 | |
| *** ccamacho has joined #openstack-nova | 15:58 | |
| mriedem | ok | 15:58 |
| gibi | mriedem: ok | 15:59 |
| *** dcdawg has joined #openstack-nova | 16:00 | |
| gibi | mriedem: there are two trailing patche for the bandwidth series both can be considered bugfixes, https://review.openstack.org/#/c/638711/ and https://review.openstack.org/#/c/639608/ what do you think, shall I push them forward before RC1? | 16:03 |
| *** artom has quit IRC | 16:05 | |
| *** mmethot has quit IRC | 16:06 | |
| openstackgerrit | guang-yee proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | 16:09 |
| *** awalende has joined #openstack-nova | 16:14 | |
| *** efried_afk is now known as fried_rice | 16:16 | |
| *** awalende has quit IRC | 16:19 | |
| *** artom has joined #openstack-nova | 16:20 | |
| *** markvoelker has quit IRC | 16:23 | |
| *** sean-k-mooney has quit IRC | 16:23 | |
| *** mmethot has joined #openstack-nova | 16:26 | |
| *** dcdawg has quit IRC | 16:27 | |
| mriedem | gibi: on https://review.openstack.org/#/c/639608/ i think that's already a potential bug because of not handling errors from claim_resources | 16:27 |
| mriedem | so it's low priority for me, but i think it's a bug we can report and work on | 16:27 |
| mriedem | as i said before that whole while loop needs to be refactored at some point (that whole damn build_instances method actually) | 16:27 |
| mriedem | gibi: https://review.openstack.org/#/c/638711/ isn't really a bug per se, but it's a performance optimization, so again i don't know that we need to rush it, but it's still good to have | 16:28 |
| mriedem | you could report a low priority bug for tracking that if you wanted - as a perf issue | 16:29 |
| mriedem | like i said, if i'm multi-creating 100 instances in one request, that's 100 separate GET /allocations calls | 16:29 |
| mriedem | although, can you multi-create with a pre-created port...? | 16:29 |
| mriedem | i'm not sure that is supported | 16:29 |
| mriedem | that would be like multi-create with the same pre-created volume | 16:30 |
| mriedem | so that likely doesn't work anyway | 16:30 |
| openstackgerrit | Eric Fried proposed openstack/nova master: update gate test for removal of force evacuate https://review.openstack.org/641986 | 16:31 |
| fried_rice | mriedem: sean-k-mooney stephenfin bauzas tssurya ^ | 16:32 |
| fried_rice | http://logs.openstack.org/86/641986/2/check/nova-live-migration/6f6b678/job-output.txt.gz#_2019-03-08_14_32_56_004357 | 16:32 |
| *** artom has quit IRC | 16:33 | |
| tssurya | fried_rice: oops | 16:33 |
| *** belmoreira has quit IRC | 16:34 | |
| cfriesen | mriedem: pretty sure you can't multi-create with pre-created port | 16:34 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.openstack.org/642030 | 16:34 |
| mriedem | cfriesen: yeah i didn't think so.. | 16:36 |
| mriedem | fried_rice: ah crap | 16:36 |
| fried_rice | mriedem: Did I do it right? I have very little experience with the CLI | 16:37 |
| cfriesen | Could someone take a look at this and clue me in why my new unit test (test_executable_exists_in_path(), in test_utils.py) is failing? Is this a zuul thing? It works fine locally. | 16:38 |
| cfriesen | https://review.openstack.org/#/c/641932 | 16:38 |
| mriedem | cfriesen: i looked at that the last time you asked and i couldn't spot anything obvious, but i'm sure there is some global you're hitting | 16:38 |
| mriedem | fried_rice: yeah i think so, the 'common' options come before the command, and then the per-command options | 16:39 |
| mriedem | i'm not sure if osc is that picky but i think novaclient is | 16:39 |
| fried_rice | cfriesen: Have you tried full-pathing ls? | 16:39 |
| cfriesen | fried_rice: the "ls" is fine, it's the call to libvirt_utils.executable_exists_in_path() that is unexpectedly failing | 16:40 |
| fried_rice | duh, sorry, yeah | 16:40 |
| fried_rice | I hadn't really parsed yet, that was just something that jumped out at a glance. | 16:40 |
| cfriesen | it's totally reliable locally, fails every time in zuul | 16:40 |
| * fried_rice pulls... | 16:40 | |
| fried_rice | cfriesen: ah, `type`. Shell builtins can be funny. There's a way to invoke a builtin as an executable, looking... | 16:42 |
| fried_rice | cfriesen: Tough that it can't be reproduced locally; but you can try changing "type ..." to "builtin type ..." | 16:44 |
| fried_rice | cfriesen: also, based on the comment, if what you truly care about is that it's an executable (as opposed to a function, alias, or builtin), you could use /usr/bin/which instead of type. | 16:45 |
| mriedem | cfriesen: there is also this https://wiki.openstack.org/wiki/Testr#Reproducing_Failures | 16:45 |
| mriedem | if you get desperate | 16:45 |
| mriedem | ^ is how you can try to spot racing globals | 16:45 |
| *** artom has joined #openstack-nova | 16:45 | |
| fried_rice | mriedem: whoosh, that could use some updating for stestr, huh | 16:46 |
| mriedem | yeah probably | 16:46 |
| mriedem | good thing anyone with a lp account can change it :) | 16:47 |
| fried_rice | cfriesen: oh, sorry again, the problem is likely to be with $PATH, which definitely shouldn't include /tmp in real life. | 16:50 |
| fried_rice | cfriesen: I'm able to repro locally. | 16:50 |
| cfriesen | fried_rice: ah, excellent. wonder why it works locally here | 16:52 |
| cfriesen | I don't have /tmp in PATH | 16:52 |
| fried_rice | yeah, that's really strange cfriesen, because even if you had /tmp in your $PATH, mktemp creates in a randomly-named subdirectory. | 16:52 |
| cfriesen | I think my bash must be messed up, with "type -P" returning whether the binary is executable even if it's not in $PATH | 16:56 |
| *** ccamacho has quit IRC | 16:57 | |
| *** ttsiouts has quit IRC | 16:58 | |
| cfriesen | fried_rice: interesting, fedora 29 behaves the same as mine | 16:58 |
| cfriesen | maybe I'll just switch to "which". | 16:58 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Dont' wait for VIF plugging during revert resize https://review.openstack.org/639396 | 16:58 |
| mriedem | gibi: smallish thing in https://review.openstack.org/#/c/638711/ | 16:58 |
| mriedem | artom: are you going to ever fix that typo in your commit title? | 16:58 |
| mriedem | don't make me -5 you | 16:59 |
| artom | Christ :( | 16:59 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Don't wait for VIF plugging during revert resize https://review.openstack.org/639396 | 16:59 |
| artom | It's, err, the possessive form? | 17:00 |
| fried_rice | cfriesen: using type -P with a full path is weird anyway. | 17:01 |
| fried_rice | cfriesen: Are you actually wanting to know if a fully-pathed file is executable, or are you wanting to know if a name (not a full path) is in your PATH *and* executable? | 17:02 |
| fried_rice | cause the former should really be done natively (os.stat | O_EXEC kind of thing) | 17:02 |
| cfriesen | fried_rice: the latter. using the full path was just for the testcase. I'm trying to make sure that "swtpm" exists on the system before advertising support for emulated TPM on that node. | 17:03 |
| fried_rice | cfriesen: Okay. Then the test case shouldn't use the full path either. | 17:04 |
| cfriesen | one could argue that's up to the operator to ensure, in which case I could skip the check entirely. | 17:04 |
| *** udesale has quit IRC | 17:04 | |
| fried_rice | meh, it seems reasonable, if you can get it to work. | 17:05 |
| mriedem | artom: so i don't think you need to change that finish_revert_migration interface at all, | 17:07 |
| mriedem | we just need to be registering an event callback prior to call migrate_instance_fininsh | 17:07 |
| fried_rice | cfriesen: Is / in your $PATH? | 17:07 |
| cfriesen | nope | 17:08 |
| cfriesen | I think it must be a non-exclusive test, where it checks $PATH but also the full path to the executable if specified | 17:08 |
| artom | mriedem, I thought that's what dansmith *didn't* want | 17:09 |
| fried_rice | weird that it's different on different platforms. | 17:09 |
| mriedem | artom: this is the kind of thing that the 3 of us would probably need to get on a hangout to discuss | 17:09 |
| mriedem | so we stop talking past each other while half paying attention | 17:09 |
| dansmith | aren't we just reverting mriedem's patch to expect an event here? | 17:10 |
| artom | dansmith, you just want to +W a mriedem revert, don't you :) | 17:10 |
| artom | I have to go do lunch with colleagues, but I like the hangouts idea | 17:10 |
| mriedem | yes he's reverting my patch but in an uglier way | 17:10 |
| dansmith | artom: no, I want to avoid the other thing, and since we've been in that "don't wait for the event" state a few times now, I think first step is just getting back to that, unless there's some reason not to | 17:10 |
| *** xek has quit IRC | 17:11 | |
| cfriesen | fried_rice: if I modify os.environ['PATH'] in the testcase to include the directory containing the temp dir, do you think that'd work? | 17:11 |
| fried_rice | cfriesen: I tried that locally and it didn't work, no. | 17:11 |
| fried_rice | but I'm not sure why. | 17:11 |
| *** xek has joined #openstack-nova | 17:11 | |
| artom | dansmith, so you'd rather I just straight up revert mriedem's patch? Functionally it's the same | 17:11 |
| cfriesen | guess I'm switching to "which" then. :) | 17:11 |
| mriedem | artom: before doing that i'd like to have a plan, | 17:12 |
| fried_rice | cfriesen: Note that type -P doesn't check whether the thing is executable (at least on my bionic) | 17:12 |
| mriedem | because if we know the event is coming, i don't see why we don't wait for it | 17:12 |
| fried_rice | efried:~/openstack/nova$ PATH=$PATH:/tmp type f | 17:12 |
| fried_rice | f is /tmp/f | 17:12 |
| fried_rice | efried:~/openstack/nova$ ll /tmp/f | 17:12 |
| fried_rice | -rw-r--r-- 1 efried efried 4169 Mar 8 08:53 /tmp/f | 17:12 |
| dansmith | artom: I'm not saying a full revert vs. tactical is important | 17:12 |
| mriedem | clearly my change worked albeit is racy | 17:12 |
| artom | mriedem, ah, I see what you mean | 17:12 |
| dansmith | mriedem: because it's hard to do that based on the arrangement of the code | 17:12 |
| *** pcaruana has quit IRC | 17:12 | |
| mriedem | artom: because i'm pretty sure i made that change b/c of gate failures | 17:12 |
| mriedem | i.e. resize revert + ssh in tempest race fails | 17:13 |
| mriedem | b/c we aren't waiting for plugging | 17:13 |
| mriedem | so you revert this w/o fixing that and we've got new gate failures again | 17:13 |
| dansmith | that's why this whole thing exists, yes | 17:13 |
| mriedem | well, same old gate failures | 17:13 |
| cfriesen | fried_rice: oh, good catch. | 17:13 |
| mriedem | dansmith: we can do the same thing we do for live migration | 17:13 |
| dansmith | can we not wait for the plug event before leaving the compute manager ? | 17:13 |
| fried_rice | cfriesen: `which` is much better, because it also doesn't fire if the file is executable, but not by you. | 17:13 |
| dansmith | like way before we get to the driver.finish_revert_migration() ? | 17:14 |
| *** amodi has quit IRC | 17:14 | |
| artom | dansmith, ah, right. I thought that wasn't possible because we needed the virt driver to plug the vifs | 17:14 |
| dansmith | artom: you've been saying the virt driver isn't causing the vif plug event | 17:14 |
| artom | But if they're already plugged, we can wait in the compute manager, and tell virt not to wait for it | 17:14 |
| dansmith | so which is it? | 17:14 |
| dansmith | right. | 17:14 |
| artom | dansmith, I'm not 100% on how the Neutron agent works, but my understanding is that Neutron will only wire the thing if the virt driver had plugged it | 17:15 |
| dansmith | artom: that contradicts what you said earlier, | 17:15 |
| artom | So we need both: poke Neutron, and plug (or have it be already plugged) | 17:15 |
| dansmith | which is that the vif is already on the source, so the network_api call is what is causing neutron to send the event, which we might miss if we're not fast enough | 17:15 |
| artom | dansmith, because it was never unplugged to begin with | 17:16 |
| mriedem | dansmith: "like way before we get to the driver.finish_revert_migration() ?" yes that's what i' msaying | 17:16 |
| mriedem | artom: right here you are contradicting what you just said, https://review.openstack.org/#/c/639396/3/nova/compute/manager.py@4184 | 17:16 |
| dansmith | mriedem: gotcha, I'm with you now.. I thought yesterday you were saying that a straight revert was the best first step.. with this, we race in control plane code, without this, we race on the instance | 17:17 |
| mriedem | So the times are:18:50:51.138 Update port binding 18:50:54.239 Event received 18:50:54.300 Event ignored on both computes 18:50:54.483 Driver finish_revert_migration start | 17:17 |
| dansmith | and you could argue that the latter is better | 17:17 |
| dansmith | I'm a little frustrated by this whole deal, so how about we table this until artom comes back from lunch and we get on a hangout? | 17:17 |
| mriedem | sure, so we could (1) revert my change saying oopsy we still race and then (2) stack on top of that a change to wait for the event prior to changing the port binding which triggers the event | 17:17 |
| dansmith | I don't care about the mechanics | 17:18 |
| mriedem | yeah hangout for sure, since i'm leaving for lunch soon too | 17:18 |
| artom | Cool. Lunch then hangout. At 13... 30? | 17:18 |
| artom | Err, eastern time, so in an hour and 10? | 17:18 |
| mriedem | a hangout will also give me an opportunity to show off my excessively manly beard | 17:18 |
| mriedem | artom: like 3pm ET for me | 17:19 |
| dansmith | mriedem: I assume you mean your sparse patchy white boy beard? | 17:19 |
| mriedem | which is noon for dan | 17:19 |
| mriedem | dansmith: of course | 17:19 |
| dansmith | um, +1:10 from now is not noon for me | 17:19 |
| dansmith | I can't be on a hangout right at noon, but before or shortly after is fine.. but noon is 2:50 from now | 17:20 |
| mriedem | 2pm CT is noon PT yeah? | 17:20 |
| artom | Speak in deltas :) | 17:20 |
| mriedem | yes i'm saying 3PM ET or thereabouts | 17:20 |
| artom | 1:10 from now? | 17:20 |
| mriedem | no | 17:20 |
| dansmith | omg | 17:20 |
| mriedem | how about we just ping later | 17:20 |
| mriedem | break | 17:20 |
| dansmith | (the sound of a gunshot in oregon echoes through) | 17:20 |
| *** markvoelker has joined #openstack-nova | 17:20 | |
| * artom off | 17:21 | |
| *** tesseract has quit IRC | 17:22 | |
| *** gyee has joined #openstack-nova | 17:22 | |
| *** erlon has quit IRC | 17:23 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 17:26 |
| *** creepy_owlet is now known as dtantsur|afk | 17:29 | |
| *** rpittau is now known as rpittau|afk | 17:31 | |
| *** erlon has joined #openstack-nova | 17:39 | |
| fried_rice | mriedem: I just added https://review.openstack.org/#/c/640879/ to https://etherpad.openstack.org/p/nova-stein-rc-potential -- is that a right thing? | 17:39 |
| mriedem | that's not a regression right? it's latent since pike or queens? | 17:40 |
| fried_rice | not a regression in stein, yes latent since several releases, will need to be backported there. | 17:40 |
| fried_rice | so, not sure how that works; do we get it in now before rc and then backport it, or wait until stein is forked, drop it in master, wait for the dust to settle, then backport it to stable branches (including stein)? | 17:41 |
| mriedem | technically if it's not a regression in stein it doesn't need to be stein-rc-potential (tag) | 17:41 |
| mriedem | so the latter | 17:41 |
| mriedem | if it's latent, we can fix it whenever and backport | 17:41 |
| *** snevi has quit IRC | 17:41 | |
| mriedem | ^ doesn't bar people from reviewing latent bug fixes before stein rc1 if they wnat | 17:42 |
| mriedem | *want | 17:42 |
| mriedem | just dont want to push anything in that is high risk if we don't need to | 17:42 |
| mriedem | and i'm not saying this is high risk | 17:42 |
| mriedem | i haven't looked it over | 17:42 |
| mriedem | what i am saying is i'm going to lunch now | 17:43 |
| *** mriedem is now known as mriedem_burgers | 17:43 | |
| fried_rice | thanks mriedem_burgers | 17:43 |
| *** fried_rice is now known as fried_rolls | 17:43 | |
| *** derekh has quit IRC | 17:44 | |
| *** snevi has joined #openstack-nova | 17:45 | |
| *** cdent has quit IRC | 17:47 | |
| *** panda|rover is now known as panda|rover|baby | 17:48 | |
| *** xek has quit IRC | 17:49 | |
| *** xek has joined #openstack-nova | 17:49 | |
| *** agopi is now known as agopi|afk | 17:50 | |
| *** mcgiggler has quit IRC | 17:51 | |
| *** markvoelker has quit IRC | 17:54 | |
| *** tssurya has quit IRC | 17:55 | |
| *** igordc has joined #openstack-nova | 17:59 | |
| *** wolverineav has joined #openstack-nova | 18:17 | |
| *** dcdawg has joined #openstack-nova | 18:23 | |
| *** cdent has joined #openstack-nova | 18:24 | |
| *** dcdawg has quit IRC | 18:27 | |
| *** wolverineav has quit IRC | 18:31 | |
| *** sridharg has quit IRC | 18:34 | |
| *** betherly has joined #openstack-nova | 18:34 | |
| *** wolverineav has joined #openstack-nova | 18:35 | |
| *** IvensZambrano has joined #openstack-nova | 18:37 | |
| *** igordc has quit IRC | 18:38 | |
| *** betherly has quit IRC | 18:39 | |
| *** igordc has joined #openstack-nova | 18:40 | |
| *** snevi has quit IRC | 18:40 | |
| *** erlon_ has joined #openstack-nova | 18:51 | |
| *** markvoelker has joined #openstack-nova | 18:51 | |
| *** erlon has quit IRC | 18:54 | |
| *** amodi has joined #openstack-nova | 18:55 | |
| artom | mriedem_burgers, dansmith, back, ready when you are | 19:03 |
| *** wolverineav has quit IRC | 19:03 | |
| *** wolverineav has joined #openstack-nova | 19:03 | |
| dansmith | I too am here | 19:04 |
| *** wolverineav has quit IRC | 19:06 | |
| *** wolverineav has joined #openstack-nova | 19:06 | |
| *** snevi has joined #openstack-nova | 19:10 | |
| *** IvensZambrano has quit IRC | 19:10 | |
| *** mriedem_burgers is now known as mriedem | 19:16 | |
| mriedem | i'm back but | 19:16 |
| artom | backbutt | 19:17 |
| dansmith | as opposed to front butt? | 19:17 |
| * artom is a fan of the sidebutt | 19:17 | |
| mriedem | gimme a minute | 19:18 |
| artom | For what it's worth, revert https://review.openstack.org/#/c/595069/ + wait in compute manager is fine | 19:18 |
| artom | Err, *I think that revert blah blah | 19:18 |
| mriedem | https://hangouts.google.com/call/4MUfp6uNnY6ddII9gtXGAEEE | 19:19 |
| *** hemna has quit IRC | 19:20 | |
| *** hemna has joined #openstack-nova | 19:21 | |
| *** markvoelker has quit IRC | 19:24 | |
| mriedem | artom: see _get_neutron_events_for_live_migration for how live migration uses it | 19:25 |
| artom | mriedem, ack | 19:26 |
| mriedem | so i think we just wrap that around the migrate_instance_finish in finish_revert_resize | 19:26 |
| mriedem | i'd probably split that code out to a new helper method for sanity.. | 19:27 |
| *** wolverineav has quit IRC | 19:34 | |
| *** wolverineav has joined #openstack-nova | 19:35 | |
| artom | Right, I gotta run again, I'll try to have those 2 patches up before the weekend | 19:37 |
| *** wolverineav has quit IRC | 19:40 | |
| *** artom has quit IRC | 19:42 | |
| *** waverider has joined #openstack-nova | 19:45 | |
| cfriesen | so in devstack I'm running "nova migrate <uuid>" and I'm getting an error saying that it can't migrate to current host. Shouldn't it be disregarding the current host for migration? | 20:00 |
| dansmith | cfriesen: do you only have one host? | 20:03 |
| *** erlon_ has quit IRC | 20:03 | |
| cfriesen | dansmith: nope, two | 20:03 |
| dansmith | but I think you'll get that if the scheduler doesn't pick the other one as a candidate | 20:04 |
| cfriesen | shed logs see it considering both right up till the weigher | 20:04 |
| cfriesen | but for "migrate" we'd never want the current host | 20:04 |
| cfriesen | only for resize | 20:04 |
| *** mikal has joined #openstack-nova | 20:04 | |
| dansmith | they're the same operation, so if allow-to-same is enabled, I think it'll allow it | 20:04 |
| openstackgerrit | Michael Still proposed openstack/nova master: Make privsep.chown mocking for libvirt snapshot tests less magic. https://review.openstack.org/642134 | 20:06 |
| *** wolverineav has joined #openstack-nova | 20:06 | |
| cfriesen | okay, but that makes no sense logically to the user. a "migrate" operation should mean moving it elsewhere. | 20:06 |
| dansmith | cfriesen: yeah, I'm not arguing that it makes sense, I'm just stating what I think is the case | 20:06 |
| dansmith | also, migrate is admin-only by default I think, so it might not get much visibility because of that | 20:06 |
| *** mikal has quit IRC | 20:07 | |
| cfriesen | I suspect you're right. but it means that with "resize on same host" enabled you currently have to explicitly specify a destination. | 20:07 |
| dansmith | no, | 20:07 |
| *** mikal has joined #openstack-nova | 20:07 | |
| cfriesen | I'm pretty sure this is a regression, just not sure from when | 20:07 |
| dansmith | it only means that if your current host is the most obvious target right? | 20:07 |
| cfriesen | dansmith: okay, fair enough. it means you can't assume it won't land on the current host | 20:08 |
| dansmith | I dunno how common it is to have allow-to-current enabled in production either | 20:08 |
| dansmith | it was supposed to only be for gate testing | 20:08 |
| cfriesen | It's useful in small clouds. | 20:09 |
| dansmith | again, stating the original intent | 20:09 |
| cfriesen | what was the rationale for defaulting it to "off"? | 20:09 |
| dansmith | because it was only for testing | 20:09 |
| cdent | tautology! | 20:10 |
| cfriesen | I get that, but why was it only for testing? You're trying to resize, why would you force a migration too? | 20:10 |
| *** wolverineav has quit IRC | 20:11 | |
| *** mikal has quit IRC | 20:12 | |
| dansmith | cfriesen: there were some reasons discussed originally when it was added, but it's been a long time.. probably mostly around how the major users of this stuff ran their clouds at the time | 20:12 |
| dansmith | i.e. packing like flavors together | 20:12 |
| dansmith | again, not saying it makes sense today, just saying why it was done that way | 20:13 |
| cfriesen | currently I'd expect the scheduler to trigger it to move in that case | 20:13 |
| *** irclogbot_2 has quit IRC | 20:13 | |
| cfriesen | anyways, reported it as a bug: https://bugs.launchpad.net/nova/+bug/1819216 | 20:16 |
| openstack | Launchpad bug 1819216 in OpenStack Compute (nova) "in devstack, "nova migrate <uuid>" will try to migrate to the same host (and then fail)" [Undecided,New] | 20:16 |
| mriedem | did someone say resize to same host problems?! https://review.openstack.org/#/c/638791/ | 20:19 |
| mriedem | if you have servers in an affinity group, you can *only* resize to the same ohst | 20:19 |
| mriedem | *host | 20:19 |
| mriedem | cfriesen: there is also a bug for the thing you hit, semi-related anyway | 20:19 |
| cfriesen | mriedem: right, I knew about the affinity group | 20:20 |
| mriedem | the api says resize to same host, sure, but the compute says 'no way' | 20:20 |
| *** markvoelker has joined #openstack-nova | 20:21 | |
| mriedem | https://bugs.launchpad.net/nova/+bug/1811235 | 20:22 |
| openstack | Launchpad bug 1811235 in OpenStack Compute (nova) "instance's vm-state becomes error when cold-migrate instance to same host failed" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 20:22 |
| mriedem | the api check is here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3626 | 20:23 |
| *** dcdawg has joined #openstack-nova | 20:23 | |
| mriedem | the compute check is here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4287 | 20:23 |
| mriedem | which fails for everything except vmware | 20:24 |
| mriedem | since vmware is a cluster and you can migrate within the same "host" | 20:24 |
| *** mvkr has quit IRC | 20:24 | |
| mriedem | so allow_resize_to_same_host is true if you're doing a resize, but not a cold migration *unless* you've got vcenter | 20:25 |
| *** mvkr has joined #openstack-nova | 20:25 | |
| cfriesen | arguably the scheduler should only allow cold migration to same host for vcenter | 20:26 |
| mriedem | the scheduler doesn't know if it's vcenter | 20:26 |
| cfriesen | I guess it's actually the conductor | 20:26 |
| mriedem | or conductor | 20:26 |
| mriedem | the control plane services are not supposed to know anything about the underlying compute driver | 20:26 |
| cfriesen | can't we look at host capabilities or hypervisor type or something? | 20:26 |
| dansmith | cfriesen: and make assumptions? what about vmware 2 which *can* do that thing.. it's a slippery slope | 20:27 |
| dansmith | separation of responsibilities | 20:27 |
| cdent | vmware even has a downstream patch which adds config for "always resize to same "host" " | 20:27 |
| mriedem | cdent: that's kind of where https://review.openstack.org/#/c/638791/ is going | 20:28 |
| cfriesen | how do we handle it for live migration? | 20:28 |
| mriedem | we always ignore the source host | 20:28 |
| mriedem | same for evac | 20:29 |
| cfriesen | seems weird to make live migration and cold migration behave differently | 20:29 |
| * cdent adds to review queue | 20:29 | |
| mriedem | so, | 20:31 |
| mriedem | now that we report compute driver capabilities as traits, | 20:31 |
| mriedem | and supports_migrate_to_same_host is a driver capability, | 20:31 |
| mriedem | we could technically check the compute node provider traits for the source compute node from the api and determind if it supports cold migrate to the same host and filter the request spec appropriately | 20:32 |
| dansmith | don't you need the opposite of that? | 20:32 |
| dansmith | you need to know if it *needs* the same host for the vmware case, not whether not it *can* yeah? | 20:33 |
| mriedem | yeah maybe, you can't cold migrate across clusters | 20:33 |
| mriedem | right? | 20:33 |
| dansmith | yeah | 20:34 |
| dansmith | so you could exclude the source host unless can-haz-must-be-same-host | 20:34 |
| dansmith | that means looking up traits for the current host and then deciding what to ask the scheduler to do | 20:35 |
| mriedem | yeah that's what i was trying to get to | 20:35 |
| mriedem | from the api, if supports_migrate_to_same_host is false, exclude the source host before calling the scheduler | 20:36 |
| mriedem | if supports_migrate_to_same_host is true, then don't exclude the source host | 20:36 |
| mriedem | right? | 20:36 |
| dansmith | you want libvirt to say it *can't* ? | 20:36 |
| mriedem | it already does | 20:36 |
| mriedem | vmware is the only driver that says supports_migrate_to_same_host=true | 20:36 |
| dansmith | oh okay I'm conflating the migrate and resize to same host cases I guess | 20:37 |
| dansmith | in that case, | 20:37 |
| dansmith | the flag is really backwards, | 20:37 |
| mriedem | yeah we don't have a driver capability for resize to same host | 20:37 |
| *** xek has quit IRC | 20:37 | |
| dansmith | because you don't want to allow the source if it can, you want to limit to the source if it can, else exclude | 20:37 |
| mriedem | you mean supports_migrate_to_same_host should be "must_migrate_to_same_host"? | 20:37 |
| mriedem | oh | 20:37 |
| dansmith | mriedem: right we have the config flag tho | 20:37 |
| *** xek has joined #openstack-nova | 20:38 | |
| mriedem | yeah again that's kind of where i was going with https://review.openstack.org/#/c/638791/1/nova/conf/workarounds.py | 20:38 |
| mriedem | but it's fugly | 20:38 |
| mriedem | i need to work on an alternative to that which doesn't bypass the scheduler filters | 20:39 |
| mriedem | because that patch is really wild west at the moment | 20:39 |
| mriedem | it's more like --force to the source host | 20:39 |
| mriedem | which is like, -4.5 | 20:40 |
| *** artom has joined #openstack-nova | 20:42 | |
| *** phasespace has joined #openstack-nova | 20:44 | |
| mriedem | cfriesen: your test vm went to ERROR state right | 20:47 |
| mriedem | ? | 20:47 |
| cfriesen | mriedem: yep | 20:47 |
| mriedem | https://review.openstack.org/#/q/topic:bug/1811235+(status:open+OR+status:merged) should fix that | 20:48 |
| *** mikal has joined #openstack-nova | 20:48 | |
| *** IvensZambrano has joined #openstack-nova | 20:50 | |
| *** snevi has quit IRC | 20:51 | |
| *** markvoelker has quit IRC | 20:53 | |
| *** fried_rolls is now known as fried_rice | 20:56 | |
| *** artom has quit IRC | 20:57 | |
| *** slaweq has quit IRC | 20:57 | |
| *** slaweq has joined #openstack-nova | 20:58 | |
| *** mikal has quit IRC | 20:59 | |
| *** erlon_ has joined #openstack-nova | 21:01 | |
| *** agopi|afk is now known as agopi | 21:03 | |
| *** erlon_ has quit IRC | 21:15 | |
| mriedem | dansmith: fried_rice: one of you want to hit https://review.openstack.org/#/c/641416/ to cut down the nova-next run time? | 21:16 |
| mriedem | shaves 20-30 minutes | 21:17 |
| fried_rice | ... | 21:17 |
| mriedem | just noticed that the gate blocker fix for evacuate is still sitting on the nova-next job | 21:17 |
| *** bnemec is now known as beekneemech | 21:18 | |
| fried_rice | mriedem: done | 21:20 |
| fried_rice | suggestion inline about further efficientizing | 21:20 |
| mriedem | yeah i don't know what to do about tempest-slow | 21:21 |
| mriedem | i've been pushing back lately on adding more stuff to tempest, which kind of sucks | 21:21 |
| *** artom has joined #openstack-nova | 21:22 | |
| *** dcdawg has quit IRC | 21:23 | |
| *** betherly has joined #openstack-nova | 21:26 | |
| *** wolverineav has joined #openstack-nova | 21:28 | |
| *** wolverineav has quit IRC | 21:30 | |
| *** igordc has quit IRC | 21:31 | |
| *** betherly has quit IRC | 21:31 | |
| *** wolverineav has joined #openstack-nova | 21:32 | |
| *** wolverineav has quit IRC | 21:32 | |
| *** wolverineav has joined #openstack-nova | 21:32 | |
| *** luksky has joined #openstack-nova | 21:35 | |
| *** betherly has joined #openstack-nova | 21:47 | |
| *** IvensZambrano has quit IRC | 21:50 | |
| *** markvoelker has joined #openstack-nova | 21:51 | |
| *** awaugama has quit IRC | 21:52 | |
| *** betherly has quit IRC | 21:52 | |
| *** betherly has joined #openstack-nova | 22:08 | |
| *** wolverineav has quit IRC | 22:08 | |
| *** betherly has quit IRC | 22:13 | |
| *** wolverineav has joined #openstack-nova | 22:18 | |
| *** wolverineav has quit IRC | 22:23 | |
| *** markvoelker has quit IRC | 22:24 | |
| *** Swami has joined #openstack-nova | 22:28 | |
| *** wolverineav has joined #openstack-nova | 22:32 | |
| *** betherly has joined #openstack-nova | 22:50 | |
| *** wolverineav has quit IRC | 22:54 | |
| *** betherly has quit IRC | 22:55 | |
| *** waverider has quit IRC | 22:58 | |
| *** irclogbot_2 has joined #openstack-nova | 23:00 | |
| *** wolverineav has joined #openstack-nova | 23:01 | |
| *** BjoernT_ has quit IRC | 23:14 | |
| *** igordc has joined #openstack-nova | 23:17 | |
| *** dcdawg has joined #openstack-nova | 23:19 | |
| *** markvoelker has joined #openstack-nova | 23:21 | |
| *** xek has quit IRC | 23:22 | |
| *** dcdawg has quit IRC | 23:24 | |
| *** hongbin has joined #openstack-nova | 23:24 | |
| *** mmethot has quit IRC | 23:27 | |
| *** betherly has joined #openstack-nova | 23:32 | |
| *** whoami-rajat has quit IRC | 23:33 | |
| *** Cardoe has quit IRC | 23:33 | |
| *** Cardoe has joined #openstack-nova | 23:34 | |
| *** betherly has quit IRC | 23:36 | |
| *** wolverineav has quit IRC | 23:37 | |
| *** wolverineav has joined #openstack-nova | 23:39 | |
| *** wolverineav has quit IRC | 23:44 | |
| *** wolverineav has joined #openstack-nova | 23:44 | |
| *** markvoelker has quit IRC | 23:54 | |
| *** fried_rice is now known as efried | 23:56 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.openstack.org/635080 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.openstack.org/635646 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.openstack.org/614035 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.openstack.org/635668 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.openstack.org/635684 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.openstack.org/636224 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.openstack.org/614037 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.openstack.org/636253 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source https://review.openstack.org/637058 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add ConfirmResizeTask https://review.openstack.org/637070 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize conductor RPC method https://review.openstack.org/637075 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.openstack.org/637316 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add revert_snapshot_based_resize_at_dest compute method https://review.openstack.org/637630 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.openstack.org/639453 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add finish_revert_snapshot_based_resize_at_source compute method https://review.openstack.org/637647 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask https://review.openstack.org/638046 | 23:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add revert_snapshot_based_resize conductor RPC method https://review.openstack.org/638047 | 23:57 |
| *** agopi has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!