| melwitt | there's an open question on the bottom patch about what table index(es) we should add, need jay's input for that | 00:00 |
|---|---|---|
| mriedem | melwitt: ok...who is dealing with final client release and any tags we need (don't think we do milestone tags for nova anymore) | 00:01 |
| *** erlon has joined #openstack-nova | 00:01 | |
| mriedem | shit this reminds me that we need a python-novaclient bump for 2.72 if we want to supported bw provider ports with nova boot... | 00:01 |
| mriedem | gibi: ^ | 00:01 |
| melwitt | mriedem: I hoped to get https://review.openstack.org/640898 out in the final osc-placement release. I can propose the novaclient release tonight, same with osc-placement if you think the allocation ratio change won't make it | 00:02 |
| mriedem | i haven't reviewed that allocation ratio thing, it's late for that imo | 00:02 |
| mriedem | the instance mapping user_id is valuable in stein if we can get it because it means less data to migrate in train | 00:03 |
| mriedem | i'm also assuming cern is going to be backporting this stuff... | 00:03 |
| efried | cfriesen: still around? | 00:03 |
| melwitt | ok. that's too bad. cdent and I have tested it locally a bit and it has a func test, but yeah | 00:03 |
| mriedem | i.e. the counting quota stuff from train to stein | 00:03 |
| mriedem | well, it was posted 2 days ago so... | 00:03 |
| mriedem | anyway, i can do a novaclient release tomorrow since we need 2.72 for gibi's stuff | 00:04 |
| melwitt | yeah, I spent a long time writing the func test for it. I guess I could have uploaded it in two stages | 00:04 |
| efried | cfriesen: going once... okay, I'm going to update the commit message on https://review.openstack.org/#/c/641480/ and +2 it. | 00:04 |
| mriedem | and i'd like to ge the instance mapping user_id stuff in at least for the 'less data to migrate' thing | 00:04 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add missing libvirt exception during device detach https://review.openstack.org/641480 | 00:04 |
| melwitt | ok. I'll propose the osc-placement release tonight then | 00:05 |
| melwitt | feel free to make whatever changes are needed to the counting quotas migration stuff tomorrow | 00:05 |
| melwitt | (anyone feel free) | 00:05 |
| melwitt | I guess the osc-placement thing isn't so big a deal because could have another release soon-ish and not hard for people to upgrade | 00:06 |
| melwitt | client stuff is a lot easier | 00:06 |
| *** tosky has quit IRC | 00:06 | |
| sean-k-mooney | melwitt: oh you coded up the aggreate allocation raito feature | 00:07 |
| melwitt | sean-k-mooney: yeah :) it took a long time because I added a --dry-run option to it where it'll show all the previewed payloads it would send for each resource provider (since you have to get/set to do updates) | 00:08 |
| melwitt | and I never saw how the command return value formatting works before with cliff, it was an experience xD | 00:09 |
| sean-k-mooney | melwitt: am one question... | 00:09 |
| melwitt | mriedem: I'll address any comments on counting quotas that land tonight/before tomorrow morning. I see you have one -1 on there already | 00:09 |
| sean-k-mooney | the compute service wont stomp on your changes right. did we complete the inial allcoation ratio stuff? | 00:10 |
| melwitt | sean-k-mooney: right. initial allocation ratios landed | 00:10 |
| melwitt | awhile back | 00:10 |
| sean-k-mooney | ah ok cool so as long as you dont set the allcoation ration for cpus exctra in the nova.conf and only set the inital_allocation ratio then this will work as expected | 00:11 |
| *** wolverineav has quit IRC | 00:12 | |
| melwitt | yeah, something like that, I thought maybe you have to set to None and also set the initial ratios. to tell it "take the values from placement" | 00:13 |
| melwitt | I can't remember atm | 00:13 |
| *** wolverineav has joined #openstack-nova | 00:13 | |
| sean-k-mooney | dont worry about it | 00:13 |
| sean-k-mooney | there is a way to do it i just wanted to make sure this would not get overriden | 00:13 |
| mriedem | sean-k-mooney: here you go https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios | 00:13 |
| mriedem | sure am glad someone documented all of that... | 00:14 |
| *** wolverineav has quit IRC | 00:15 | |
| melwitt | haha yup. I was gonna say, we have docs! | 00:15 |
| *** wolverineav has joined #openstack-nova | 00:15 | |
| sean-k-mooney | i mean we spent enough time debating it in the spec we might as well record it in the admin docs too so we dont forget | 00:15 |
| melwitt | yeah, that is not something anyone wants to try and figure out again | 00:16 |
| sean-k-mooney | we do. we also have docs for the downstream issue we were having with the rdo cloud just beneath that | 00:16 |
| *** _alastor_ has quit IRC | 00:18 | |
| *** jogo has quit IRC | 00:24 | |
| *** gyee has quit IRC | 00:26 | |
| *** gyee has joined #openstack-nova | 00:27 | |
| *** dave-mccowan has joined #openstack-nova | 00:36 | |
| sean-k-mooney | the subunit parser but is still a thing :( | 00:36 |
| *** tetsuro has joined #openstack-nova | 00:39 | |
| openstackgerrit | guang-yee proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | 00:40 |
| *** tetsuro has quit IRC | 00:43 | |
| *** markvoelker has joined #openstack-nova | 00:50 | |
| *** erlon has quit IRC | 00:51 | |
| *** stakeda has joined #openstack-nova | 00:51 | |
| openstackgerrit | Merged openstack/nova master: Extend volume for libvirt network volumes (RBD) https://review.openstack.org/613039 | 00:52 |
| *** hongbin has quit IRC | 00:52 | |
| openstackgerrit | Merged openstack/nova master: doc: cleanup pci.alias references https://review.openstack.org/640882 | 00:52 |
| *** xek__ has joined #openstack-nova | 00:58 | |
| *** xek_ has quit IRC | 01:01 | |
| *** bhagyashris has joined #openstack-nova | 01:01 | |
| *** xek_ has joined #openstack-nova | 01:04 | |
| *** whoami-rajat has joined #openstack-nova | 01:07 | |
| *** xek__ has quit IRC | 01:07 | |
| *** lbragstad has quit IRC | 01:09 | |
| *** gyee has quit IRC | 01:11 | |
| *** dave-mccowan has quit IRC | 01:18 | |
| *** takashin has quit IRC | 01:22 | |
| *** markvoelker has quit IRC | 01:22 | |
| *** takashin has joined #openstack-nova | 01:24 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | 01:24 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 01:24 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 01:24 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 01:24 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 01:24 |
| stephenfin | sean-k-mooney: This is the one and only tm | 01:29 |
| stephenfin | *time I'll be online this late | 01:29 |
| * stephenfin goes to look at reviews | 01:29 | |
| stephenfin | (darn waterfall development process...) | 01:29 |
| *** erlon has joined #openstack-nova | 01:30 | |
| *** rcernin has quit IRC | 01:31 | |
| *** rcernin has joined #openstack-nova | 01:32 | |
| *** rchurch has joined #openstack-nova | 01:36 | |
| *** rchurch_ has quit IRC | 01:38 | |
| *** xek__ has joined #openstack-nova | 01:40 | |
| *** xek_ has quit IRC | 01:43 | |
| *** xek_ has joined #openstack-nova | 01:43 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Should not skip volume_size check for bdm.image_id == image_ref case https://review.openstack.org/641282 | 01:46 |
| *** xek__ has quit IRC | 01:46 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add support for microversion v2.72 https://review.openstack.org/637234 | 01:46 |
| *** xek__ has joined #openstack-nova | 01:47 | |
| mriedem | stephenfin: takashin: can one of you approve the 2.72 novaclient change https://review.openstack.org/#/c/637234/ ? it's really just docs, but we need to get it in so we can release novaclient tomorrow. | 01:47 |
| takashin | mriedem: Okay. I will do it. | 01:48 |
| mriedem | thanks | 01:49 |
| *** xek_ has quit IRC | 01:50 | |
| *** erlon has quit IRC | 01:50 | |
| *** mriedem is now known as mriedem_afk | 01:51 | |
| *** xek_ has joined #openstack-nova | 01:54 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 01:57 |
| *** xek__ has quit IRC | 01:57 | |
| *** xek__ has joined #openstack-nova | 01:57 | |
| *** mriedem_afk has quit IRC | 01:59 | |
| *** xek_ has quit IRC | 02:00 | |
| *** xek_ has joined #openstack-nova | 02:02 | |
| *** xek__ has quit IRC | 02:04 | |
| *** igordc has quit IRC | 02:07 | |
| *** dave-mccowan has joined #openstack-nova | 02:18 | |
| *** markvoelker has joined #openstack-nova | 02:20 | |
| *** marst has quit IRC | 02:35 | |
| *** psachin has joined #openstack-nova | 02:42 | |
| *** markvoelker has quit IRC | 02:52 | |
| *** wolverineav has quit IRC | 03:01 | |
| *** wolverineav has joined #openstack-nova | 03:01 | |
| *** wolverineav has quit IRC | 03:06 | |
| *** lbragstad has joined #openstack-nova | 03:11 | |
| *** awalende has joined #openstack-nova | 03:17 | |
| *** marst has joined #openstack-nova | 03:18 | |
| *** wolverineav has joined #openstack-nova | 03:20 | |
| *** awalende has quit IRC | 03:21 | |
| *** udesale has joined #openstack-nova | 03:24 | |
| *** wolverineav has quit IRC | 03:27 | |
| *** wolverineav has joined #openstack-nova | 03:28 | |
| *** wolverineav has quit IRC | 03:29 | |
| *** wolverineav has joined #openstack-nova | 03:29 | |
| *** wolverineav has quit IRC | 03:33 | |
| *** wolverineav has joined #openstack-nova | 03:34 | |
| *** wolverineav has quit IRC | 03:39 | |
| *** markvoelker has joined #openstack-nova | 03:49 | |
| *** takashin has left #openstack-nova | 03:55 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 03:58 |
| *** dave-mccowan has quit IRC | 04:00 | |
| *** wolverineav has joined #openstack-nova | 04:04 | |
| *** sridharg has joined #openstack-nova | 04:05 | |
| *** marst has quit IRC | 04:06 | |
| *** wolverineav has quit IRC | 04:09 | |
| *** _alastor_ has joined #openstack-nova | 04:18 | |
| *** markvoelker has quit IRC | 04:22 | |
| *** _alastor_ has quit IRC | 04:22 | |
| *** bnemec has quit IRC | 04:26 | |
| *** ebbex has quit IRC | 04:26 | |
| *** efried has quit IRC | 04:26 | |
| *** kukacz has quit IRC | 04:26 | |
| *** tomtom001 has quit IRC | 04:26 | |
| *** cburgess has quit IRC | 04:26 | |
| *** penick has quit IRC | 04:26 | |
| *** stephenfin has quit IRC | 04:26 | |
| *** gary_perkins has quit IRC | 04:26 | |
| *** sorrison has quit IRC | 04:26 | |
| *** abhishekk has joined #openstack-nova | 04:29 | |
| *** yaawang has quit IRC | 04:44 | |
| *** yaawang has joined #openstack-nova | 04:45 | |
| *** yonglihe has joined #openstack-nova | 04:53 | |
| *** bnemec has joined #openstack-nova | 04:53 | |
| *** ebbex has joined #openstack-nova | 04:53 | |
| *** efried has joined #openstack-nova | 04:53 | |
| *** kukacz has joined #openstack-nova | 04:53 | |
| *** tomtom001 has joined #openstack-nova | 04:53 | |
| *** cburgess has joined #openstack-nova | 04:53 | |
| *** penick has joined #openstack-nova | 04:53 | |
| *** stephenfin has joined #openstack-nova | 04:53 | |
| *** gary_perkins has joined #openstack-nova | 04:53 | |
| *** sorrison has joined #openstack-nova | 04:53 | |
| *** rcernin has quit IRC | 04:56 | |
| *** ileixe has joined #openstack-nova | 04:59 | |
| *** ratailor has joined #openstack-nova | 05:01 | |
| *** rcernin has joined #openstack-nova | 05:02 | |
| *** janki has joined #openstack-nova | 05:05 | |
| *** markvoelker has joined #openstack-nova | 05:19 | |
| *** lbragstad has quit IRC | 05:33 | |
| *** Bhujay has joined #openstack-nova | 05:34 | |
| *** marst has joined #openstack-nova | 05:39 | |
| *** igordc has joined #openstack-nova | 05:47 | |
| openstackgerrit | Merged openstack/nova master: Move arping to privsep. https://review.openstack.org/624593 | 05:52 |
| openstackgerrit | Merged openstack/nova master: Move cleaning conntrack to privsep. https://review.openstack.org/624594 | 05:52 |
| openstackgerrit | Merged openstack/nova master: Move killing processes to privsep. https://review.openstack.org/635432 | 05:52 |
| openstackgerrit | Merged openstack/nova master: Cleanup the exec_ebtables code a little. https://review.openstack.org/635434 | 05:52 |
| *** markvoelker has quit IRC | 05:53 | |
| *** jhesketh has quit IRC | 05:53 | |
| *** jhesketh has joined #openstack-nova | 05:54 | |
| *** marst has quit IRC | 06:03 | |
| *** marst has joined #openstack-nova | 06:05 | |
| *** janki has quit IRC | 06:08 | |
| *** janki has joined #openstack-nova | 06:08 | |
| *** marst has quit IRC | 06:10 | |
| openstackgerrit | guang-yee proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | 06:10 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 06:17 |
| openstackgerrit | Merged openstack/nova master: fakelibvirt: Add ability to generate fake PCI devices https://review.openstack.org/640409 | 06:40 |
| *** ivve has joined #openstack-nova | 06:49 | |
| *** wolverineav has joined #openstack-nova | 06:49 | |
| *** markvoelker has joined #openstack-nova | 06:50 | |
| *** lxkong has quit IRC | 06:52 | |
| *** Luzi has joined #openstack-nova | 06:54 | |
| *** janki has quit IRC | 06:54 | |
| *** janki has joined #openstack-nova | 06:54 | |
| *** phasespace has quit IRC | 07:00 | |
| *** dpawlik has joined #openstack-nova | 07:05 | |
| *** Bhujay has quit IRC | 07:08 | |
| *** Bhujay has joined #openstack-nova | 07:09 | |
| *** Bhujay has quit IRC | 07:10 | |
| *** Admin__ has joined #openstack-nova | 07:10 | |
| *** Bhujay has joined #openstack-nova | 07:10 | |
| *** Bhujay has quit IRC | 07:11 | |
| *** Bhujay has joined #openstack-nova | 07:12 | |
| *** Bhujay has quit IRC | 07:13 | |
| *** Bhujay has joined #openstack-nova | 07:13 | |
| *** Bhujay has quit IRC | 07:14 | |
| *** Bhujay has joined #openstack-nova | 07:15 | |
| *** Bhujay has quit IRC | 07:16 | |
| *** Bhujay has joined #openstack-nova | 07:16 | |
| *** Bhujay has quit IRC | 07:17 | |
| *** Bhujay has joined #openstack-nova | 07:18 | |
| *** Bhujay has quit IRC | 07:19 | |
| *** Bhujay has joined #openstack-nova | 07:19 | |
| *** Bhujay has quit IRC | 07:20 | |
| *** Bhujay has joined #openstack-nova | 07:21 | |
| *** lxkong has joined #openstack-nova | 07:21 | |
| *** Bhujay has quit IRC | 07:22 | |
| *** markvoelker has quit IRC | 07:22 | |
| *** Bhujay has joined #openstack-nova | 07:23 | |
| *** pcaruana has joined #openstack-nova | 07:25 | |
| *** rcernin has quit IRC | 07:27 | |
| *** david-lyle has joined #openstack-nova | 07:36 | |
| *** dklyle has quit IRC | 07:37 | |
| *** dpawlik has quit IRC | 07:39 | |
| *** dklyle has joined #openstack-nova | 07:41 | |
| *** david-lyle has quit IRC | 07:42 | |
| *** dpawlik has joined #openstack-nova | 07:52 | |
| *** igordc has quit IRC | 07:54 | |
| *** dklyle has quit IRC | 07:55 | |
| *** dklyle has joined #openstack-nova | 07:55 | |
| *** dtantsur|afk is now known as dtantsur | 07:55 | |
| openstackgerrit | Kevin Rasmussen proposed openstack/nova master: created AggregateSubnetAvailabilityFilter https://review.openstack.org/633178 | 08:01 |
| *** tesseract has joined #openstack-nova | 08:01 | |
| *** wolverineav has quit IRC | 08:03 | |
| *** avishay has joined #openstack-nova | 08:05 | |
| *** tkajinam has quit IRC | 08:12 | |
| *** ccamacho has joined #openstack-nova | 08:13 | |
| *** tssurya has joined #openstack-nova | 08:15 | |
| *** wolverineav has joined #openstack-nova | 08:18 | |
| *** awalende has joined #openstack-nova | 08:19 | |
| *** markvoelker has joined #openstack-nova | 08:19 | |
| *** ileixe has quit IRC | 08:20 | |
| *** ileixe has joined #openstack-nova | 08:21 | |
| *** wolverineav has quit IRC | 08:22 | |
| *** ralonsoh has joined #openstack-nova | 08:25 | |
| *** ileixe has quit IRC | 08:26 | |
| *** helenafm has joined #openstack-nova | 08:27 | |
| *** tosky has joined #openstack-nova | 08:27 | |
| tssurya | good morning nova, if any cores are around could you please reinstate the +W here: https://review.openstack.org/#/c/606995/ , I sort of lost it during rebase and FYI: its only a simple doc update | 08:29 |
| *** ttsiouts has joined #openstack-nova | 08:32 | |
| gibi | tssurya: done | 08:36 |
| gibi | tssurya: the functional test failure with parser error was really a nasty thing. | 08:37 |
| gibi | tssurya: got fixed with multiple commit from mriedem | 08:37 |
| *** phasespace has joined #openstack-nova | 08:37 | |
| *** ttsiouts has quit IRC | 08:42 | |
| *** ttsiouts has joined #openstack-nova | 08:43 | |
| *** ttsiouts_ has joined #openstack-nova | 08:46 | |
| *** ttsiouts has quit IRC | 08:47 | |
| tssurya | gibi: thanks a lot! | 08:47 |
| tssurya | yea thanks to you and mriedem for fixing that | 08:47 |
| gibi | tssurya: is there anything you need help before the FF? | 08:49 |
| tssurya | gibi: not really :) the stuff I was working on is all in | 08:49 |
| gibi | tssurya: nice :) | 08:50 |
| *** panda|ruck|off is now known as panda|ruck | 08:52 | |
| *** xek_ has quit IRC | 08:53 | |
| *** markvoelker has quit IRC | 08:53 | |
| *** xek_ has joined #openstack-nova | 08:53 | |
| *** Bhujay has quit IRC | 08:55 | |
| *** Bhujay has joined #openstack-nova | 08:56 | |
| *** Bhujay has quit IRC | 08:57 | |
| *** Bhujay has joined #openstack-nova | 08:58 | |
| *** Bhujay has quit IRC | 08:59 | |
| *** Bhujay has joined #openstack-nova | 08:59 | |
| *** Bhujay has quit IRC | 09:00 | |
| *** Bhujay has joined #openstack-nova | 09:01 | |
| *** Bhujay has quit IRC | 09:02 | |
| *** Bhujay has joined #openstack-nova | 09:02 | |
| *** Bhujay has quit IRC | 09:03 | |
| *** Bhujay has joined #openstack-nova | 09:04 | |
| *** Bhujay has quit IRC | 09:05 | |
| *** Bhujay has joined #openstack-nova | 09:05 | |
| *** Bhujay has quit IRC | 09:06 | |
| *** Bhujay has joined #openstack-nova | 09:07 | |
| *** Bhujay has quit IRC | 09:08 | |
| *** Bhujay has joined #openstack-nova | 09:08 | |
| *** Bhujay has quit IRC | 09:09 | |
| *** Bhujay has joined #openstack-nova | 09:10 | |
| *** Bhujay has quit IRC | 09:11 | |
| *** Bhujay has joined #openstack-nova | 09:11 | |
| *** Bhujay has quit IRC | 09:12 | |
| *** Bhujay has joined #openstack-nova | 09:13 | |
| *** Bhujay has quit IRC | 09:14 | |
| *** Bhujay has joined #openstack-nova | 09:14 | |
| *** Bhujay has quit IRC | 09:15 | |
| *** Bhujay has joined #openstack-nova | 09:16 | |
| *** Bhujay has quit IRC | 09:17 | |
| *** Bhujay has joined #openstack-nova | 09:17 | |
| *** Bhujay has quit IRC | 09:18 | |
| *** Bhujay has joined #openstack-nova | 09:19 | |
| *** Bhujay has quit IRC | 09:20 | |
| *** Bhujay has joined #openstack-nova | 09:20 | |
| *** Bhujay has quit IRC | 09:21 | |
| *** Bhujay has joined #openstack-nova | 09:22 | |
| *** Bhujay has quit IRC | 09:23 | |
| *** Bhujay has joined #openstack-nova | 09:23 | |
| *** Bhujay has quit IRC | 09:24 | |
| *** Bhujay has joined #openstack-nova | 09:25 | |
| *** cdent has joined #openstack-nova | 09:25 | |
| openstackgerrit | Adrian Chiris proposed openstack/nova master: Separate methods to free claimed and allocated devs https://review.openstack.org/616120 | 09:26 |
| openstackgerrit | Adrian Chiris proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365 | 09:26 |
| openstackgerrit | Adrian Chiris proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929 | 09:26 |
| *** Bhujay has quit IRC | 09:26 | |
| *** Bhujay has joined #openstack-nova | 09:26 | |
| *** Bhujay has quit IRC | 09:27 | |
| *** Bhujay has joined #openstack-nova | 09:28 | |
| *** Bhujay has quit IRC | 09:29 | |
| *** Bhujay has joined #openstack-nova | 09:29 | |
| HD|Laptop | hey all. Assuming I have an existing QEMU VM in qcow2 format that needs to be run inside my Openstack environment, how do I best do this? create an image in glance, then spawn an instance based on it? or directly import it in cinder and create a server with no image and just the cinder volume attached? | 09:29 |
| *** Bhujay has quit IRC | 09:30 | |
| *** Bhujay has joined #openstack-nova | 09:31 | |
| *** Bhujay has quit IRC | 09:32 | |
| *** Bhujay has joined #openstack-nova | 09:32 | |
| *** Bhujay has quit IRC | 09:33 | |
| *** Bhujay has joined #openstack-nova | 09:34 | |
| bauzas | HD|Laptop: see https://docs.openstack.org/image-guide/create-images-manually.html | 09:34 |
| *** Bhujay has quit IRC | 09:35 | |
| *** derekh has joined #openstack-nova | 09:35 | |
| bauzas | HD|Laptop: also, see the channel topic, here is only for development questions | 09:35 |
| *** Bhujay has joined #openstack-nova | 09:35 | |
| *** Bhujay has quit IRC | 09:36 | |
| *** Bhujay has joined #openstack-nova | 09:37 | |
| *** Bhujay has quit IRC | 09:38 | |
| *** Bhujay has joined #openstack-nova | 09:38 | |
| openstackgerrit | Adrian Chiris proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929 | 09:38 |
| *** Bhujay has quit IRC | 09:39 | |
| *** Bhujay has joined #openstack-nova | 09:40 | |
| *** Bhujay has quit IRC | 09:41 | |
| *** Bhujay has joined #openstack-nova | 09:41 | |
| *** Bhujay has quit IRC | 09:42 | |
| *** Bhujay has joined #openstack-nova | 09:43 | |
| *** Bhujay has quit IRC | 09:44 | |
| *** Bhujay has joined #openstack-nova | 09:44 | |
| *** Bhujay has quit IRC | 09:45 | |
| *** Bhujay has joined #openstack-nova | 09:46 | |
| *** Bhujay has quit IRC | 09:47 | |
| *** Bhujay has joined #openstack-nova | 09:47 | |
| *** Bhujay has quit IRC | 09:48 | |
| *** Bhujay has joined #openstack-nova | 09:49 | |
| *** Bhujay has quit IRC | 09:50 | |
| *** markvoelker has joined #openstack-nova | 09:50 | |
| *** Bhujay has joined #openstack-nova | 09:50 | |
| *** Bhujay has quit IRC | 09:51 | |
| *** Bhujay has joined #openstack-nova | 09:52 | |
| *** bhagyashris has quit IRC | 09:52 | |
| *** ianw is now known as ianw_pto | 09:52 | |
| *** Bhujay has quit IRC | 09:53 | |
| *** Bhujay has joined #openstack-nova | 09:53 | |
| *** Bhujay has quit IRC | 09:54 | |
| *** Bhujay has joined #openstack-nova | 09:55 | |
| *** Bhujay has quit IRC | 09:56 | |
| *** Bhujay has joined #openstack-nova | 09:56 | |
| *** Bhujay has quit IRC | 09:57 | |
| *** Bhujay has joined #openstack-nova | 09:58 | |
| *** stakeda has quit IRC | 09:59 | |
| *** Bhujay has quit IRC | 09:59 | |
| *** Bhujay has joined #openstack-nova | 09:59 | |
| *** Bhujay has quit IRC | 10:00 | |
| *** Bhujay has joined #openstack-nova | 10:01 | |
| *** Bhujay has quit IRC | 10:02 | |
| *** Bhujay has joined #openstack-nova | 10:02 | |
| *** takashin has joined #openstack-nova | 10:02 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove duplicate cleanup in functional tests https://review.openstack.org/636996 | 10:03 |
| *** Bhujay has quit IRC | 10:03 | |
| *** Bhujay has joined #openstack-nova | 10:04 | |
| *** Bhujay has quit IRC | 10:05 | |
| *** Bhujay has joined #openstack-nova | 10:05 | |
| *** ccamacho has quit IRC | 10:06 | |
| *** Bhujay has quit IRC | 10:06 | |
| *** Bhujay has joined #openstack-nova | 10:07 | |
| *** Bhujay has quit IRC | 10:08 | |
| *** Bhujay has joined #openstack-nova | 10:08 | |
| *** belmoreira has joined #openstack-nova | 10:09 | |
| *** Bhujay has quit IRC | 10:09 | |
| *** Bhujay has joined #openstack-nova | 10:10 | |
| *** Bhujay has quit IRC | 10:11 | |
| *** Bhujay has joined #openstack-nova | 10:11 | |
| *** Bhujay has quit IRC | 10:12 | |
| *** Bhujay has joined #openstack-nova | 10:13 | |
| *** Bhujay has quit IRC | 10:14 | |
| *** Bhujay has joined #openstack-nova | 10:14 | |
| *** Bhujay has quit IRC | 10:15 | |
| *** Bhujay has joined #openstack-nova | 10:16 | |
| *** Bhujay has quit IRC | 10:17 | |
| *** Bhujay has joined #openstack-nova | 10:17 | |
| *** Bhujay has quit IRC | 10:18 | |
| *** Bhujay has joined #openstack-nova | 10:19 | |
| *** Bhujay has quit IRC | 10:20 | |
| *** Bhujay has joined #openstack-nova | 10:20 | |
| *** Bhujay has quit IRC | 10:21 | |
| *** Bhujay has joined #openstack-nova | 10:22 | |
| *** mikal has quit IRC | 10:22 | |
| *** Bhujay has quit IRC | 10:23 | |
| *** markvoelker has quit IRC | 10:23 | |
| *** Bhujay has joined #openstack-nova | 10:23 | |
| *** Bhujay has quit IRC | 10:24 | |
| *** Bhujay has joined #openstack-nova | 10:25 | |
| *** Bhujay has quit IRC | 10:26 | |
| *** Bhujay has joined #openstack-nova | 10:26 | |
| *** abhishekk has quit IRC | 10:27 | |
| *** Bhujay has quit IRC | 10:27 | |
| *** Bhujay has joined #openstack-nova | 10:28 | |
| *** Bhujay has quit IRC | 10:29 | |
| *** Bhujay has joined #openstack-nova | 10:29 | |
| *** sapd1 has joined #openstack-nova | 10:30 | |
| *** Bhujay has quit IRC | 10:30 | |
| *** Bhujay has joined #openstack-nova | 10:31 | |
| *** Bhujay has quit IRC | 10:32 | |
| *** Bhujay has joined #openstack-nova | 10:32 | |
| *** Bhujay has quit IRC | 10:33 | |
| *** Bhujay has joined #openstack-nova | 10:34 | |
| *** Bhujay has quit IRC | 10:35 | |
| openstackgerrit | Merged openstack/nova master: Test proper allocation of devices during reshape https://review.openstack.org/639854 | 10:35 |
| *** Bhujay has joined #openstack-nova | 10:35 | |
| *** Bhujay has quit IRC | 10:36 | |
| *** Bhujay has joined #openstack-nova | 10:37 | |
| *** Bhujay has quit IRC | 10:38 | |
| *** Bhujay has joined #openstack-nova | 10:38 | |
| *** Bhujay has quit IRC | 10:39 | |
| *** Bhujay has joined #openstack-nova | 10:40 | |
| *** Bhujay has quit IRC | 10:41 | |
| *** Bhujay has joined #openstack-nova | 10:41 | |
| *** Bhujay has quit IRC | 10:42 | |
| *** Bhujay has joined #openstack-nova | 10:43 | |
| *** Bhujay has quit IRC | 10:44 | |
| *** Bhujay has joined #openstack-nova | 10:44 | |
| *** Bhujay has quit IRC | 10:45 | |
| *** Bhujay has joined #openstack-nova | 10:46 | |
| *** tetsuro has joined #openstack-nova | 10:52 | |
| *** odyssey4me has quit IRC | 10:53 | |
| *** odyssey4me has joined #openstack-nova | 10:53 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 10:56 |
| *** udesale has quit IRC | 10:59 | |
| *** udesale has joined #openstack-nova | 10:59 | |
| *** tetsuro has quit IRC | 11:00 | |
| *** ileixe has joined #openstack-nova | 11:01 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 11:03 |
| *** ttsiouts_ has quit IRC | 11:18 | |
| *** ttsiouts has joined #openstack-nova | 11:19 | |
| *** dtantsur is now known as dtantsur|bbl | 11:19 | |
| *** markvoelker has joined #openstack-nova | 11:20 | |
| *** beagles has joined #openstack-nova | 11:21 | |
| *** ttsiouts has quit IRC | 11:23 | |
| *** erlon has joined #openstack-nova | 11:24 | |
| *** udesale has quit IRC | 11:28 | |
| *** ccamacho has joined #openstack-nova | 11:31 | |
| *** ileixe has quit IRC | 11:35 | |
| *** ratailor has quit IRC | 11:37 | |
| *** udesale has joined #openstack-nova | 11:45 | |
| *** xek_ has quit IRC | 11:45 | |
| *** markvoelker has quit IRC | 11:53 | |
| mdbooth | lyarwood: I've discovered why your test is failing with failure to delete the volume type | 11:54 |
| mdbooth | lyarwood: Although I haven't worked out what to do about it, yet, or why it appears to work in the py2 tests | 11:54 |
| *** sapd1 has quit IRC | 11:55 | |
| mdbooth | Anyway, when you create a volume from a glance image, it seems that cinder creates a new volume to hold the downloaded glance image with the same type as the volume being created: cinder's image cache | 11:56 |
| mdbooth | The failure to delete the type is because the image cache volume still exists. | 11:56 |
| *** ttsiouts has joined #openstack-nova | 11:56 | |
| mdbooth | lyarwood: Probably easiest to go ask some cinder folks how to handle that. I'll see if I can find some. | 11:58 |
| *** amodi has joined #openstack-nova | 12:05 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move FP device creation and deletion to privsep. https://review.openstack.org/635433 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 12:06 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826 | 12:06 |
| *** mikal has joined #openstack-nova | 12:07 | |
| *** sapd1 has joined #openstack-nova | 12:08 | |
| *** mikal has quit IRC | 12:12 | |
| *** dave-mccowan has joined #openstack-nova | 12:22 | |
| *** sapd1 has quit IRC | 12:36 | |
| *** takashin has quit IRC | 12:39 | |
| *** janki has quit IRC | 12:40 | |
| *** markvoelker has joined #openstack-nova | 12:50 | |
| *** ttsiouts has quit IRC | 12:51 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: tests: Move mocking to setUp https://review.openstack.org/641651 | 12:52 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: tests: Create functional libvirt test base class https://review.openstack.org/641652 | 12:52 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: objects: Store InstancePCIRequest.numa_policy in DB https://review.openstack.org/641653 | 12:52 |
| *** ttsiouts has joined #openstack-nova | 12:52 | |
| *** ttsiouts has quit IRC | 12:55 | |
| *** ttsiouts has joined #openstack-nova | 12:56 | |
| *** takashin has joined #openstack-nova | 12:56 | |
| artom | ~o~ | 12:56 |
| *** panda|ruck is now known as panda|rover | 12:57 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test macvtap port with resource request https://review.openstack.org/641309 | 13:00 |
| *** udesale has quit IRC | 13:02 | |
| *** udesale has joined #openstack-nova | 13:08 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Delete orphaned RS and IM records of archived instances https://review.openstack.org/560042 | 13:09 |
| *** wolverineav has joined #openstack-nova | 13:19 | |
| *** markvoelker has quit IRC | 13:22 | |
| *** wolverineav has quit IRC | 13:23 | |
| yaawang | kashyap: Hi, will you continue doing https://review.openstack.org/#/c/640866/? I want to fix some pep8 issues to pass the test :) | 13:23 |
| *** ttsiouts has quit IRC | 13:24 | |
| *** ttsiouts has joined #openstack-nova | 13:24 | |
| *** ttsiouts_ has joined #openstack-nova | 13:26 | |
| kashyap | yaawang: Oh, yes. Let me fix that right away | 13:27 |
| kashyap | yaawang: Sorry :-) | 13:27 |
| yaawang | kashyap: thk :) | 13:28 |
| *** ttsiouts has quit IRC | 13:28 | |
| *** mriedem has joined #openstack-nova | 13:30 | |
| mriedem | gibi: are you running today's meeting? | 13:31 |
| gibi | mriedem: yes, I can do that | 13:31 |
| gibi | mriedem: I read that melwitt is not here today, and that you will take care of the FF | 13:32 |
| *** jaypipes has joined #openstack-nova | 13:32 | |
| *** phasespace has quit IRC | 13:32 | |
| mriedem | yeah that's why i was wondering who was running the meeting | 13:33 |
| gibi | mriedem: if you would like to run the meeting too then I have no problem with that either | 13:34 |
| mriedem | i shouldn't since i have to get my kid to the bus in about an hour | 13:34 |
| gibi | mriedem: OK, then I will run it | 13:34 |
| *** marst has joined #openstack-nova | 13:34 | |
| mriedem | thanks | 13:35 |
| gibi | np | 13:35 |
| jaypipes | guten morgen | 13:36 |
| *** janki has joined #openstack-nova | 13:36 | |
| mriedem | maybe i should make efried do all the FF stuff today... | 13:37 |
| mriedem | jaypipes: question about indexes for you | 13:37 |
| mriedem | jaypipes: in https://review.openstack.org/#/c/633349/ | 13:37 |
| mriedem | need to add just a user_id index or both user_id + project_id | 13:37 |
| efried | mriedem: I would be down, with coaching. | 13:37 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 13:37 |
| mriedem | efried: well the good news is we don't do milestone tags anymore so there is no need to tag s-3 for nova, right smcginnis? | 13:38 |
| mriedem | mel already released osc-placement last night, | 13:38 |
| mriedem | so i think the only release we have today is novaclient | 13:38 |
| efried | okay, just propose a novaclient release? | 13:39 |
| mriedem | yeah, will need this first https://review.openstack.org/#/c/637234/ | 13:39 |
| efried | ...after checking if there's anything... yeah | 13:39 |
| openstackgerrit | Merged openstack/python-novaclient master: Add support for microversion v2.72 https://review.openstack.org/637234 | 13:41 |
| gibi | and it is merged ^^ | 13:42 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: cpu-model-selection: s/cpu_models/cpu_model_list/ https://review.openstack.org/640866 | 13:43 |
| kashyap | yaawang: ^ Hope that fixes it | 13:43 |
| jaypipes | mriedem: answered. | 13:43 |
| jaypipes | mriedem: fine to put a single index on user_id. was a good catch from dansmith | 13:43 |
| jaypipes | mriedem: in a future patch, we can add a dual index if that is something we see is needed. | 13:44 |
| jaypipes | mriedem: as melwitt stated, the server group members query is on user only, not project, so a dual index on (project_id, user_id) would not help that query. | 13:44 |
| mriedem | jaypipes: but this one does use both https://review.openstack.org/#/c/638072/17/nova/objects/instance_mapping.py@407 | 13:45 |
| jaypipes | ffs... | 13:45 |
| mriedem | so i guess we'd want a user_id and user_id+project_id index? | 13:46 |
| *** marst has quit IRC | 13:46 | |
| jaypipes | mriedem: no, it doesn't actually. | 13:46 |
| jaypipes | mriedem: it's two queries :( | 13:46 |
| jaypipes | mriedem: that ffs wasn't directed at you. | 13:46 |
| jaypipes | mriedem: each .scalar() is a sep query. | 13:46 |
| mriedem | yeah i realize | 13:47 |
| mriedem | this is a pattern in the quota qounting query code... | 13:47 |
| mriedem | in a few places | 13:47 |
| jaypipes | oh, I see.. | 13:47 |
| jaypipes | hrmph | 13:47 |
| *** csatari has joined #openstack-nova | 13:48 | |
| jaypipes | mriedem: ok, well if the pattern is that user_id is always queries along with project_id, then yes, the index should be on (project_id, user_id) | 13:48 |
| *** lbragstad has joined #openstack-nova | 13:48 | |
| mriedem | well project_id isn't always in there https://review.openstack.org/#/c/638324/19/nova/objects/instance_mapping.py@466 | 13:49 |
| *** ccamacho has quit IRC | 13:49 | |
| mriedem | the first one above is a replacement for the "instances" quota counting which is over project and user, | 13:49 |
| mriedem | the latter is the server group members query which is just on user_id | 13:50 |
| mriedem | "server_group_members" quota count query i should say | 13:50 |
| jaypipes | does it need to be, though? | 13:50 |
| jaypipes | in other words, can we add a project filter to the query? | 13:50 |
| openstackgerrit | ya.wang proposed openstack/nova master: Select cpu model from a list of cpu models https://review.openstack.org/637834 | 13:50 |
| gibi | nova meeting starts in 9 minutes on #openstack-meeting | 13:50 |
| mriedem | server group member quota is enforced at the user, not project, level | 13:50 |
| mriedem | jaypipes: https://github.com/openstack/nova/blob/master/nova/quota.py#L1075 | 13:51 |
| *** jmlowe has quit IRC | 13:51 | |
| bauzas | any urgent code review before FF ? | 13:52 |
| bauzas | I looked at the etherpad, but it's a bit messy :( | 13:52 |
| mriedem | it is yes | 13:53 |
| bauzas | disclaimer: long series can't be honestly reviewed | 13:53 |
| mriedem | i'm just trying to sort out the index question on https://review.openstack.org/#/c/633349/ | 13:53 |
| jaypipes | good lord that is an expensive quota check :( | 13:53 |
| mriedem | i don't know if we'll try to merge part of this instance mapping user_id series or not | 13:53 |
| mriedem | it's getting to be too late to be having these types of questions | 13:54 |
| bauzas | mriedem: do you want some other eye's lookup ? | 13:54 |
| *** sapd1 has joined #openstack-nova | 13:54 | |
| bauzas | I saw this series in the etherpad, but I was thinking it was a bit difficult to review it by only 6 hours | 13:54 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Boot a VM with an unaddressed port https://review.openstack.org/641670 | 13:55 |
| mriedem | the bottom 4-5 changes have had a lot of review from me and dansmith actually | 13:55 |
| bauzas | there is a -W from melwitt, can we still review ? | 13:55 |
| jaypipes | mriedem: is there a technical reason why we couldn't still filter by project as well as user on that server group members quota query? | 13:55 |
| mriedem | bauzas: that was procedural while waiting for approval of the changes above | 13:55 |
| jaypipes | (seems like it's just a mistake in the original code) | 13:55 |
| bauzas | mriedem: okay, then I'll look | 13:56 |
| mriedem | jaypipes: i don't think it's an oversight | 13:56 |
| jaypipes | mriedem: why not? | 13:56 |
| mriedem | anyway, i wouldn't want to have to go down that rathole on FF | 13:57 |
| jaypipes | ack | 13:57 |
| mriedem | i'd have to dig into when server group member quota was added | 13:57 |
| mriedem | we do have some per-user quota checks on purpose, | 13:57 |
| mriedem | like keypairs i think | 13:57 |
| *** BlackDex has quit IRC | 13:59 | |
| mriedem | efried: https://review.openstack.org/#/c/637234/ is merged now if you want to start a novaclient release, or after the meeting | 13:59 |
| efried | argh, meeting, thanks for the reminder. | 13:59 |
| efried | mriedem: was just starting the release. | 13:59 |
| jaypipes | mriedem: I understand the keypairs being user_id-specific. not so much the server groups one. | 14:01 |
| *** BlackDex has joined #openstack-nova | 14:02 | |
| *** avishay has quit IRC | 14:06 | |
| efried | mriedem: So microversion parity changes don't count as major bump-worthy? | 14:09 |
| mriedem | efried: no, since they are opt-in features | 14:09 |
| mriedem | major is for backward incompatible changes | 14:09 |
| efried | okay. | 14:09 |
| mriedem | semver baby | 14:09 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Boot a VM with an unaddressed port https://review.openstack.org/641670 | 14:10 |
| *** dtantsur|bbl is now known as dtantsur | 14:10 | |
| *** marst has joined #openstack-nova | 14:17 | |
| *** _alastor_ has joined #openstack-nova | 14:17 | |
| mriedem | yikun: efried: i saw yikun posted a topic proposal for nova/cyborg integration https://etherpad.openstack.org/p/DEN-train-nova-brainstorming - question is if that should be a forum or ptg session? it might be fine to have both. | 14:18 |
| mriedem | forum session to lay out the goals/requirements and ptg session to talk about design/implementation details | 14:19 |
| mriedem | i know our product team wants to focus on fpga integration with nova but it sounds like upstream cyborg team is talking more about gpu support? which we already have in nova. | 14:19 |
| *** markvoelker has joined #openstack-nova | 14:20 | |
| *** mchlumsky has joined #openstack-nova | 14:21 | |
| mriedem | yikun so i'd be in favor of a forum session | 14:22 |
| efried | The more the better as far as I'm concerned. | 14:22 |
| sean-k-mooney | mriedem: for what tis worth fpga integration with openstack is 1 already possible via pci passthrough and 2 on our products teams wishlist too to do without relying on pci passthouhg | 14:22 |
| *** _alastor_ has quit IRC | 14:22 | |
| efried | though I'm kinda hoping to have the nova/cyborg integration design mostly agreed upon before Denver | 14:22 |
| efried | since we already had it agreed upon after *last* Denver. | 14:23 |
| mriedem | ok i guess i didn't know about #1, i only really ever hear about people using gpus | 14:23 |
| sean-k-mooney | efried: by the way i think i have a path forward that jaypipes and you might like on one topic | 14:23 |
| efried | mriedem: "Can do it with PCI passthrough" isn't a thing that should stop us doing stuff with cyborg. We've been trying to make PCI passthrough DIAF for years now. This is the opportunity to do that. | 14:23 |
| mriedem | efried: sure, that's not my point | 14:24 |
| efried | okay, sorry, I didn't get your point then | 14:24 |
| *** psachin has quit IRC | 14:24 | |
| sean-k-mooney | efried: when cyborg reprogams an fpga for mutiple tenatn. why dont we jsut create a child resouce provider form the otrgin device resouce provider with the new capablities listed as traits on the new RP and new invetores of the resouce it provides | 14:25 |
| efried | sean-k-mooney: How does that help anything? | 14:25 |
| sean-k-mooney | efried: we dont need to ever update the traits or resouce clases on the original RP | 14:25 |
| mriedem | considering we'll be lucky to get *anything* of substance done wrt nova/cyborg integration, what is the biggest benefit of a new feature functionality we could add with that integration? gpus w/o passthrough or fpgas? we already have a lot of people using gpus with passthrough in nova, and we have vgpus, so it seems like fpga would be the bigger first "win" from an integration. | 14:26 |
| sean-k-mooney | the orginal RP device inventory can be consumed by cyborg | 14:26 |
| sean-k-mooney | and cyborge can create a dynamic child with the image capablities when its programed | 14:26 |
| efried | how would the claim sequence work? | 14:26 |
| sean-k-mooney | if you want ipsec ofload you make a resouce request for the ipsec class if you want a device you use a fpga device resource class | 14:27 |
| sean-k-mooney | i can write something up | 14:27 |
| efried | It sounds like a really complicated way to do the same thing as the existing design. | 14:28 |
| sean-k-mooney | but basically you should be able to support both multi and singel tenant use of a device | 14:28 |
| efried | for what benefit, preserving architectural purity? | 14:28 |
| sean-k-mooney | efried: well we agreed to not update the rp in the existing desing | 14:28 |
| efried | huh? | 14:28 |
| sean-k-mooney | at least not in phase 1 | 14:28 |
| efried | Not to update its inventory, yes. But we agreed to use dynamic traits to signify bitstreams. | 14:29 |
| *** jmlowe has joined #openstack-nova | 14:30 | |
| sean-k-mooney | efried: yes which means if a bitstream can support 8 concurent consumer fo aes compression we agreed that you cannot create a new inventory to model that | 14:30 |
| edleafe | efried: is "dynamic traits" a euphemism for "tracking state"? | 14:30 |
| sean-k-mooney | without creating new inventories you cannot alleratiors that have mulit tenatn bitstreams | 14:30 |
| sean-k-mooney | edleafe: more or less | 14:31 |
| edleafe | sean-k-mooney: ugh, that's what it sounds like | 14:31 |
| efried | mriedem: https://review.openstack.org/641678 <== python-novaclient release | 14:31 |
| sean-k-mooney | edleafe: the suggestion was to tag the fpga RP with a CUSTOM_ trait for the bitstream it is programed with | 14:31 |
| edleafe | sean-k-mooney: yeah, that was discussed and rejected a while ago. Looks like it's back from the dead. | 14:32 |
| efried | we doing this again? | 14:32 |
| efried | it was not rejected | 14:32 |
| efried | It was not anyone's favorite | 14:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor bandwidth related functional tests https://review.openstack.org/641679 | 14:32 |
| sean-k-mooney | efried: ya i know im not really objecting to it | 14:32 |
| sean-k-mooney | efried: i just thing that there is a better way of modeling it | 14:33 |
| efried | edleafe: but it was agreed upon (by which I mean "consensus" - i.e. not everybody cast an aye vote) as the lesser evil | 14:33 |
| mriedem | efried: ack, will take a look after i'm back from the bus stop | 14:34 |
| *** mriedem is now known as mriedem_afk | 14:34 | |
| sean-k-mooney | efried: for what its worth we never discussed the model im now proposeing and i think jaypipes and other may like it and it will enable more usecase for cyborg to | 14:34 |
| smcginnis | mriedem_afk, efried: Correct, no need to tag milestone beta's unless you know there are downstream consumers that could use it. | 14:34 |
| sean-k-mooney | efried: would you like me to write up a more detailed proposal? | 14:35 |
| efried | sean-k-mooney: We have been in analysis paralysis on this thing for too long. We need to make forward progress. The design as currently represented in the PoC is what we agreed on in Denver after discussing it at every PTG for the past two years. It is simple. It works. It would be counterproductive to try to redesign it yet again at this stage. | 14:35 |
| efried | If a "dynamic child provider" model is really seen as far superior to this design, we can look at switching to it in U or later. | 14:35 |
| cdent | sean-k-mooney, efried, edleafe: didn't we make a decision many months ago that we should just stick with, even if it isn't perfect? | 14:36 |
| efried | this ^ | 14:36 |
| efried | because there is no perfect | 14:36 |
| sean-k-mooney | for the record we also commited to having the poc working by m1 at the latest | 14:37 |
| edleafe | cdent: I guess I don't remember a decision, just lots of back-and-forth discussion. Maybe it was in Berlin, and that's why I don't recall it? | 14:37 |
| cdent | edleafe: not certain. I _think_ I'm remembering Denver. | 14:38 |
| efried | sean-k-mooney: m1 of what? At this point we're proposing it for train, since stein has sailed. The PoC is ready now. | 14:38 |
| sean-k-mooney | cdent: this discusstion predates teh creation of placement. at least my involvement in it does | 14:39 |
| *** imacdonn has quit IRC | 14:39 | |
| cdent | sean-k-mooney: then I think you've proving my point | 14:39 |
| sean-k-mooney | efried: the poc was expected to be completed by m1 of stein | 14:39 |
| efried | sean-k-mooney: if we were going to get it into stein, sure. | 14:39 |
| jaypipes | mriedem: is it a 0% chance of getting the quota-in-placement series reviewed and merged today then? even if I take over the bottom patch? there's actually a lot of good in that series and it opens up much-needed refactoring and cleanup in Train if we can get it done (not to mention a simpler way of reasoning about quotas) | 14:40 |
| efried | cdent, edleafe: Denver is where consensus was reached. | 14:40 |
| dansmith | jaypipes: yes, zero chance of landing the whole thing | 14:40 |
| jaypipes | mriedem_afk: and yes, I realize I'm coming at this way late. | 14:40 |
| dansmith | jaypipes: at best we could land the bottom few to get the data model in place, but the top several functional ones haven't seen review and rushing it today is not okay with me | 14:41 |
| *** mriedem_afk is now known as mriedem | 14:46 | |
| mriedem | jaypipes: dansmith: right if we take over the changes we'd get up through the online data migration, | 14:46 |
| mriedem | which is arguably useful to get done earlier than later so there is less data to migrate in train, | 14:46 |
| jaypipes | ++ | 14:47 |
| mriedem | but if we're unsure of the design at this point then we should defer | 14:47 |
| jaypipes | efried, edleafe, sean-k-mooney: I will remind yet again that there is zero generation protection for multiple threads changing a provider's traits. that protection only exists on the quantitative side of the house -- i.e. inventory and resource classes. | 14:48 |
| mriedem | i'll dig through git history to see if i can find any words around why server group member quota is enforced at the user rather than project leve | 14:49 |
| mriedem | *level | 14:49 |
| sean-k-mooney | jaypipes: yep i know which is part of why i was hoping to avoid that. | 14:49 |
| mriedem | i'm sure this is probably something melwitt would have memorized by now | 14:49 |
| sean-k-mooney | jaypipes: anyway i dont want to get into it now | 14:49 |
| efried | whoah, that I didn't realize. | 14:49 |
| dansmith | mriedem: yeah I think we've been over that before.. definitely doesn't seem like something we can change on a whim regardless of the reason | 14:49 |
| jaypipes | efried: I said it on the hangout the other day with Sundar and I've said it at each of the past PTGs where the whole custom RCs vs traits was discussed. | 14:50 |
| efried | We should fix that regardless. | 14:50 |
| efried | we've got multiple threads potentially dorking with traits already. | 14:50 |
| mriedem | jaypipes: the good news is phil day was good about writing useful commit messages https://review.openstack.org/#/c/104957/ | 14:50 |
| *** sapd1 has quit IRC | 14:51 | |
| dansmith | mriedem: am I missing where in there is justifies being user-only? | 14:52 |
| mriedem | "They can be defined per project or per user within a project" | 14:52 |
| jaypipes | mriedem: "They can be defined per project or per user within a project" <-- shows me that user-specific quota *always* will be "within a project" and therefore should have had the project_id in the query. | 14:52 |
| mriedem | i'm also looking | 14:52 |
| jaypipes | lol. jiunx. | 14:52 |
| edleafe | efried: capabilities don't change dynamically. State does. | 14:52 |
| *** eharney has joined #openstack-nova | 14:53 | |
| jaypipes | edleafe: zactly. | 14:53 |
| dansmith | mriedem: yeah that just doesn't tell me why | 14:53 |
| *** markvoelker has quit IRC | 14:53 | |
| jaypipes | dansmith: fwiw, I wasn't wondering why it's a user-specific quota, just why the query for it wasn't also appending a project_id | 14:53 |
| cdent | efried: we've got generations on adding traits to providers. | 14:54 |
| dansmith | jaypipes: okay | 14:54 |
| jaypipes | cdent: that's not what I'm referring to actually. :) | 14:54 |
| mriedem | yeah idk either on the server group member user-only quota check, | 14:54 |
| mriedem | if it was a mistake, | 14:54 |
| mriedem | it sure farted it's way through several very large changes and different cores | 14:54 |
| mriedem | too bad we don't have people around that maintain this code... | 14:55 |
| cdent | jaypipes: well I kind of assumed not, but got a bit lost trying to track all of this round about | 14:55 |
| mriedem | maybe sdague would remember.... | 14:55 |
| *** Bhujay has quit IRC | 14:56 | |
| cdent | so jaypipes what does "there is zero generation protection for multiple threads changing a provider's traits." | 14:56 |
| jaypipes | cdent: specifically, this is the protection that doesn't exist when traits are used as faux inventory: https://github.com/openstack/placement/blob/master/placement/objects/allocation.py#L427-L447 | 14:56 |
| mriedem | cyeoh and ken'ichi moved it through | 14:56 |
| cdent | jinxish | 14:56 |
| efried | cdent, jaypipes: Updating what traits are set on a resource provider <== has generation controls. Phew. | 14:56 |
| jaypipes | efried: not for claiming resources. | 14:56 |
| efried | oh, sure, traits aren't part of an allocation | 14:57 |
| jaypipes | efried: which is what I've been saying. | 14:57 |
| efried | that's just fine. | 14:57 |
| *** luksky has joined #openstack-nova | 14:57 | |
| efried | had me scared there for a minute | 14:57 |
| cdent | jaypipes: so your concerned about the case where we've chosen a target on which we want to allocate and since we selected it, the traits of that thing have changed? | 14:58 |
| efried | We also don't do ^ for aggregate memberships we originally used to gather the candidate. | 14:58 |
| luksky | hi, I have question about scheduler - how to debug case where I have 26 compute nodes, but in first iteration I see that RetryFilter is getting only 22 at start ? | 14:58 |
| cdent | (that either as "you're concerned about" or "your concern is". your pick) | 14:58 |
| jaypipes | cdent: precisely, which is exactly what their whole "dynamic case" does. | 14:58 |
| efried | We're not talking about changing traits continuously. Just when the characteristics (um, traits) of a resource provider change. | 14:59 |
| cdent | luksky: depends on what release you're on | 14:59 |
| luksky | queens | 14:59 |
| luksky | [root@nova-01 ~]# nova --version | 15:00 |
| luksky | 9.1.1 | 15:00 |
| jaypipes | luksky: check the placement service's logs. | 15:01 |
| cdent | luksky: combination of debug logs from nova-scheduler and nova-placement-api | 15:01 |
| luksky | In logs I see: | 15:01 |
| luksky | INFO nova.filters [req-6553ad52-40f0-41d3-a11e-3682bdccf589 f0b6fd8f6a1a421094fd6259fa0a8d6c a17c1ce3cc114f05b5da8c9553e5e4d1 - default default] Filtering removed all hosts for the request with instance ID 'dbaecc98-c097-4b7b-b4f8-459f1ed1fecc'. Filter results: ['RetryFilter: (start: 22, end: 22)', 'IsolatedTenantFilter: (start: 22, end: 4)', 'AggregateMultiTenancyIsolation: (start: 4, end: 4)', 'AvailabilityZoneFilter: (start: 4, end: 4)', | 15:01 |
| luksky | 'RamFilter: (start: 4, end: 4)', 'DiskFilter: (start: 4, end: 4)', 'ComputeFilter: (start: 4, end: 4)', 'ComputeCapabilitiesFilter: (start: 4, end: 4)', 'ImagePropertiesFilter: (start: 4, end: 4)', 'ServerGroupAntiAffinityFilter: (start: 4, end: 4)', 'ServerGroupAffinityFilter: (start: 4, end: 4)', 'IsolatedHostsFilter: (start: 4, end: 0)'] | 15:01 |
| efried | edleafe: "capabilities don't change dynamically. State does." What an FPGA is "capable" of doing *does* change dynamically, when the thing is programmed. | 15:01 |
| *** takashin has left #openstack-nova | 15:01 | |
| cfriesen | efried: thanks for the update. :) You caught me just after I left. | 15:02 |
| efried | cfriesen: yw | 15:02 |
| sean-k-mooney | luksky: the retry filter will only get the set of host that passed the first iteration - the one that was tried and failed | 15:02 |
| luksky | (os-client) (PROD)[root@test1 ~]# openstack compute service list --service nova-compute | grep nova-compute | wc -l | 15:02 |
| luksky | WARNING: Failed to import plugin clustering. | 15:02 |
| luksky | 26 | 15:02 |
| edleafe | efried: an FPGA region is capable of all available bitstreams for that model. When it is programmed, it is still capable of running any of the other bitstreams | 15:02 |
| edleafe | Calling the current program a capability instead of the current state of the region is kind of a twist in language | 15:03 |
| *** IvensZambrano has joined #openstack-nova | 15:03 | |
| * cdent joins #openstack-epistemology | 15:03 | |
| luksky | hm... don | 15:04 |
| luksky | hm... don't get it | 15:04 |
| edleafe | cdent: try #openstack-etymology instead :) | 15:04 |
| luksky | shouldn't see "'RetryFilter: (start: 26, end: 26)" instead: "'RetryFilter: (start: 22, end: 22)" | 15:04 |
| luksky | ? | 15:04 |
| cdent | naw, I think we need to go deeper | 15:04 |
| efried | again, realizing it's not perfectly pure, this is the best way to get where we want to be. Which is why we've ended up here several times after having discussed it the same way every time. | 15:05 |
| *** efried is now known as efried_mtg | 15:05 | |
| sean-k-mooney | luksky: no | 15:06 |
| sean-k-mooney | luksky: the retry filter on subsequet iterations does not retry host it knows cant pass | 15:06 |
| edleafe | I think calling something "perfectly pure" is a bit condescending. I'm just pointing out that this approach is not the way placement is designed to work, and there may be downsides. If you all have agreed to go ahead with that, your eyes are wide open. | 15:07 |
| sean-k-mooney | luksky: if its the first iteration and no filter have ran then the delta between 26 and 22 is because placemnt determined the other 4 instace did not have space for the instance and elminated them | 15:07 |
| mriedem | jaypipes: i've gone fishing in the ML for the mystery of the server_group_members counting logic | 15:08 |
| mriedem | maybe someone like tim bell will remmeber | 15:09 |
| jaypipes | mriedem: to understand the mystery of the server group member counting, one must first understand the mystery that is the server groups implementation. | 15:10 |
| mriedem | you said you're cool with server groups | 15:11 |
| *** josecastroleon has quit IRC | 15:12 | |
| *** awaugama has joined #openstack-nova | 15:12 | |
| luksky | sean-k-mooney: thank You, does it can have some relation with not running discovered_host on some (i.e 4 compute) computes ? | 15:12 |
| luksky | sean-k-mooney: I mean "nova-manage cell_v2 discover_hosts" | 15:16 |
| *** awalende has quit IRC | 15:16 | |
| *** awalende has joined #openstack-nova | 15:17 | |
| *** awalende has quit IRC | 15:21 | |
| jaypipes | mriedem: the concept? yes. the implementation... erm, not so much. | 15:22 |
| mriedem | efried_mtg: bauzas: commented on the semver version for the novaclient release https://review.openstack.org/#/c/641678/ | 15:23 |
| mriedem | i'm a bit torn | 15:23 |
| mriedem | because of the first bullet here https://docs.openstack.org/releasenotes/python-novaclient/unreleased.html#upgrade-notes | 15:23 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 15:24 |
| bauzas | mriedem: great comment | 15:25 |
| bauzas | I missed that one | 15:25 |
| kashyap | Dead-simple +2/+W, can anyone put this out of its misery: https://review.openstack.org/#/c/640866/ | 15:25 |
| mriedem | kashyap: uh... | 15:26 |
| mriedem | kashyap: if that change isn't going to land in stein, the spec has to be re-proposed for train anyway, | 15:27 |
| mriedem | so why not just make that change in the re-proposed spec with a note in the history abou the change? | 15:27 |
| kashyap | Whatever works; alex_xu was also onboard with the above, FWIW. | 15:28 |
| kashyap | mriedem: Will it / can it land for Stein? | 15:28 |
| kashyap | mriedem: So, to be clear: you want me to repropose the whole spec fo Train? | 15:28 |
| mriedem | kashyap: it would have to merge today | 15:28 |
| kashyap | mriedem: Ah ... right, the freeze | 15:28 |
| mriedem | i see alex_xu and stephenfin were reviewing it, but stephenfin was only reviewing docs | 15:29 |
| mriedem | it looks like | 15:29 |
| kashyap | See Alex's comment on line 548. | 15:29 |
| stephenfin | Nah, it was just the docs/config opt naming that I had comments on | 15:30 |
| stephenfin | rest of it is noddy | 15:30 |
| stephenfin | (IMO) | 15:30 |
| * dansmith wonders wtf "noddy" means | 15:30 | |
| kashyap | stephenfin: Did you see this: https://review.openstack.org/#/c/640866/3 | 15:31 |
| kashyap | dansmith: LOL | 15:31 |
| kashyap | dansmith: Typing: 'define noddy' in Google shows this: | 15:31 |
| kashyap | (1) [DATED] a foolish person. | 15:31 |
| kashyap | (2) a tropical tern with mainly dark-coloured plumage. | 15:31 |
| stephenfin | oops. noddy = easy or simple | 15:31 |
| dansmith | kashyap: yes, I know how to use google and did.. still don't know | 15:32 |
| kashyap | dansmith: Wasn't daring to tell you to LMGTFY ... just sharing the amusement | 15:32 |
| dansmith | stephenfin: as in "something you nod (in agreement) at" ? | 15:32 |
| dansmith | stephenfin: homonym-wise, sounds like "naughty" as in "not good" | 15:32 |
| kashyap | (That's how I read it) | 15:32 |
| mriedem | i want to say something about being offended as an american that i don't understand the language being used here | 15:33 |
| stephenfin | I guess? I've never really though about it, to be honest | 15:33 |
| mriedem | and how i need to take to social media to express my language victimizatoin | 15:33 |
| mriedem | *ion | 15:33 |
| kashyap | mriedem: Do you do social media besides IRC? I doubt that | 15:34 |
| dansmith | I could sue stephenfin in portland for micro-aggression | 15:34 |
| dansmith | (and probably win) | 15:34 |
| kashyap | Yes, you will be quarantined into a "safe space" | 15:34 |
| mriedem | kashyap: i have a linkedin account | 15:35 |
| mriedem | does that count? | 15:35 |
| *** Luzi has quit IRC | 15:35 | |
| kashyap | mriedem: Nah ... unless you're actively talking about marketecture there | 15:35 |
| dansmith | and he treats it like facebook | 15:35 |
| mriedem | dansmith claims to be an angry old man, but i think i have him beat | 15:35 |
| dansmith | mriedem: so what's the deal with the user_id patch? what's the plan? | 15:35 |
| dansmith | I don't want to be around late into the afternoon dealing with this | 15:35 |
| mriedem | dansmith: i agree with what you said earlier, | 15:36 |
| mriedem | "(8:49:57 AM) dansmith: mriedem: yeah I think we've been over that before.. definitely doesn't seem like something we can change on a whim regardless of the reason" | 15:36 |
| dansmith | so, we add user_id, and user_id/project_id then yeah? | 15:36 |
| mriedem | if we assume the server group member quota count is going to continue to be user_id only yeah | 15:37 |
| mriedem | even if we don't, the additional index doesn't hurt does it? | 15:37 |
| mriedem | jaypipes: ^ | 15:37 |
| dansmith | no | 15:37 |
| jaypipes | no, it doesn't really hurt anyuthing | 15:37 |
| dansmith | I've got the set pulled down, I'll fix up the index | 15:38 |
| mriedem | ok so the actual counting functions later in the series don't need to merge in stein | 15:38 |
| dansmith | right, so maybe I'll just orphan them | 15:38 |
| mriedem | sure | 15:40 |
| mriedem | i'm targeting to get to https://review.openstack.org/#/c/633351/ | 15:40 |
| jaypipes | +1 | 15:49 |
| *** markvoelker has joined #openstack-nova | 15:50 | |
| bauzas | mriedem: thanks for giving us the path to the legacy job for comparing, it helps | 15:52 |
| bauzas | context being https://review.openstack.org/#/c/640181 | 15:52 |
| *** snevi has joined #openstack-nova | 15:53 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add user_id column to the instance_mappings table https://review.openstack.org/633349 | 15:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350 | 15:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | 15:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 15:53 |
| bauzas | mriedem: I guess you just copy/pasted the job definition YAML ? | 15:54 |
| bauzas | or do I really need to do my job and diff the files ? | 15:54 |
| *** IvensZambrano has quit IRC | 15:55 | |
| sean-k-mooney | luksky: sorry i was on a call. im just runnig to another one but you only need to run discover hosts wehn you add new nodes | 15:56 |
| *** efried_mtg is now known as efried | 15:57 | |
| efried | mriedem, bauzas: done | 15:57 |
| sean-k-mooney | luksky: and you only need to run nova-manage cellv2 discover_hosts on the contoler nodes not on the compute nodes | 15:57 |
| *** marst has quit IRC | 15:59 | |
| *** tbachman has joined #openstack-nova | 15:59 | |
| *** _alastor_ has joined #openstack-nova | 16:00 | |
| *** marst has joined #openstack-nova | 16:00 | |
| *** mlavalle has joined #openstack-nova | 16:00 | |
| *** udesale has quit IRC | 16:01 | |
| *** priteau has joined #openstack-nova | 16:02 | |
| *** ratailor has joined #openstack-nova | 16:02 | |
| mriedem | dansmith: i just went through https://review.openstack.org/#/c/633351/24 again while you rebased, see if my comments make sense | 16:02 |
| mriedem | bauzas: yes i copied the playbook | 16:03 |
| *** artom has quit IRC | 16:03 | |
| mriedem | and changed the name/description | 16:03 |
| bauzas | mriedem: yeah so blame on you, you forced me to diff | 16:03 |
| jaypipes | dansmith: sorry if I wasn't clear about the multi-column index earlier. | 16:04 |
| jaypipes | dansmith: I've added a comment to the revision you just pushed. If we go with a (user_id, project_id) multi-column index, there's no need for a single-column (user_id) index. | 16:04 |
| dansmith | jaypipes: oh I was sure you said to add both | 16:05 |
| jaypipes | dansmith: tried to explain in that comment, sorry. if you added a (project_id, user_id) index, you'd also want a (user_id) single-column index. | 16:06 |
| dansmith | wait, what? | 16:06 |
| dansmith | oh, it matters the ordering of them? | 16:06 |
| jaypipes | dansmith: yep | 16:06 |
| dansmith | jesus | 16:06 |
| jaypipes | :) | 16:06 |
| dansmith | so, surely these will also be looked up via project only right? | 16:06 |
| dansmith | oh, but we already have one on project | 16:07 |
| dansmith | okay | 16:07 |
| jaypipes | yes, but there is already a single-column on (project_id) | 16:07 |
| jaypipes | single-column index | 16:07 |
| jaypipes | yeagh | 16:07 |
| jaypipes | dansmith: good article on the concepts here: https://www.vividcortex.com/blog/the-left-prefix-index-rule | 16:08 |
| luksky | <sean-k-mooney>: thank You | 16:08 |
| dansmith | jaypipes: don't push your progressive indexes on me | 16:08 |
| jaypipes | heh :) | 16:09 |
| jaypipes | dansmith: sorry for the misunderstanding | 16:09 |
| dansmith | I guess I have to update this test now and fix the nova-manage too | 16:09 |
| *** tssurya has quit IRC | 16:10 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use Selection object to fill request group mapping https://review.openstack.org/638711 | 16:14 |
| mriedem | efried: +1 thanks | 16:20 |
| mriedem | stephenfin: this has you written all over it https://review.openstack.org/#/c/640181/ | 16:21 |
| stephenfin | sure thing | 16:21 |
| *** markvoelker has quit IRC | 16:23 | |
| *** liuyulong is now known as liuyulong_zzZZZ | 16:24 | |
| efried | mriedem: updated with more information (mostly copy/paste) in the commit message. | 16:25 |
| *** ratailor has quit IRC | 16:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow utime call to fail on qcow2 image base file https://review.openstack.org/641315 | 16:27 |
| mriedem | mdbooth: do you fancy addressing review comments on https://review.openstack.org/#/c/641315/ ? | 16:27 |
| mriedem | i'd like to make sure people are on board with that before approving your revert | 16:27 |
| mriedem | efried: beautiful | 16:28 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add user_id column to the instance_mappings table https://review.openstack.org/633349 | 16:28 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350 | 16:28 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | 16:29 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 16:29 |
| *** janki has quit IRC | 16:29 | |
| *** hongbin has joined #openstack-nova | 16:29 | |
| mriedem | cdent: regarding the placement extraction forum session proposal in https://etherpad.openstack.org/p/DEN-train-nova-brainstorming | 16:29 |
| *** igordc has joined #openstack-nova | 16:29 | |
| mriedem | cdent: i'm going to submit that and also propose you as co-presentor or whatever, ok? | 16:29 |
| *** Sundar has joined #openstack-nova | 16:29 | |
| *** luksky has quit IRC | 16:32 | |
| mdbooth | mriedem: Yep | 16:33 |
| *** ivve has quit IRC | 16:33 | |
| mdbooth | mriedem: I did wonder actually if we should confine it further to EPERM | 16:34 |
| mriedem | mdbooth: thanks | 16:34 |
| mriedem | maybe ask neil since he had the recreate | 16:34 |
| mdbooth | ack | 16:34 |
| *** jmlowe has quit IRC | 16:36 | |
| cdent | mriedem: yeah, that's fine | 16:36 |
| mdbooth | EACCES, not EPERM | 16:36 |
| *** helenafm has quit IRC | 16:43 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Fix nits in remote console guide https://review.openstack.org/641098 | 16:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rework all things metadata'y https://review.openstack.org/640730 | 16:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Rename 'configuration drive' to 'config drive' https://review.openstack.org/641723 | 16:44 |
| *** Admin__ has quit IRC | 16:51 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 16:52 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 16:53 |
| mriedem | +2 | 16:53 |
| mriedem | dansmith: thanks for reving those | 16:53 |
| mriedem | jaypipes: i'm +2 on the first 4 in that series now | 16:53 |
| dansmith | aye | 16:53 |
| jaypipes | aye aye. just wrapping up a meeting | 16:54 |
| *** wolverineav has joined #openstack-nova | 16:55 | |
| *** wolverineav has quit IRC | 16:59 | |
| *** ttsiouts_ has quit IRC | 17:02 | |
| *** ttsiouts has joined #openstack-nova | 17:03 | |
| *** tesseract has quit IRC | 17:05 | |
| *** ttsiouts has quit IRC | 17:07 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 17:10 |
| mriedem | johnthetubaguy: are you going to be in denver? i was considering proposing a forum session to get people together about your unified limits spec https://review.openstack.org/#/c/602201/ | 17:15 |
| mriedem | even if you're not, i assume melwitt and/or jaypipes and/or lbragstad can help run that since i'm not qualified to run that session | 17:15 |
| mriedem | but i don't know if jaypipes will be at the forum... | 17:16 |
| *** snevi has quit IRC | 17:16 | |
| mriedem | given his too cool for schoolness | 17:16 |
| lbragstad | i haven't put together my schedule yet, but i'll try and be there for that | 17:16 |
| jaypipes | mriedem: I will | 17:17 |
| *** IvensZambrano has joined #openstack-nova | 17:17 | |
| jaypipes | mriedem: can one be too uncool for school? | 17:17 |
| jaypipes | mriedem: cuz I would be that. | 17:17 |
| mriedem | that question is too philosophical for me to think about right now | 17:18 |
| mriedem | dansmith: i'm sure you'd like to propose a "nova at the edge?!" forum session | 17:18 |
| mriedem | you could even dress up like the edge | 17:18 |
| dansmith | mriedem: I'm sure you're wrong | 17:18 |
| mriedem | what if, we do a reenactment of the movie 'the edge' from the 90s though? | 17:19 |
| mriedem | i'll be alec baldwin | 17:19 |
| dansmith | :| | 17:19 |
| mriedem | we need an anthony hopkins and a bear | 17:20 |
| *** markvoelker has joined #openstack-nova | 17:20 | |
| mriedem | bauzas: ... | 17:20 |
| dansmith | https://www.youtube.com/watch?v=Dn8-4tjPxD8 | 17:20 |
| bauzas | hum, I can wait for shaving | 17:20 |
| mriedem | https://www.dailymotion.com/video/x3s9vt2 | 17:21 |
| dansmith | keep thinking I need to be working that in .. the U2 edge thing is already played | 17:21 |
| mriedem | if we're going to talk about stevie nicks i can't let the fajita roundup go unnoticed | 17:21 |
| aspiers | kashyap (or anyone): need advice on how to reuse some code from libvirt.driver._get_machine_type() inside libvirt.host | 17:26 |
| kashyap | aspiers: Afraid, I'm totally spent for the day :-( And about to go for some air and food | 17:27 |
| aspiers | kashyap: OK maybe someone else can help | 17:27 |
| *** artom has joined #openstack-nova | 17:27 | |
| kashyap | If it's on a particular review, think out loud. I'll see tomm. | 17:27 |
| aspiers | no, it's on how to write my code | 17:27 |
| aspiers | I want to reuse these two lines https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4262 | 17:28 |
| aspiers | but from Host class, which doesn't have access to the driver AFAICS | 17:28 |
| aspiers | maybe there's a utils class or something | 17:28 |
| aspiers | oh look at that, there is :) | 17:28 |
| aspiers | ah no, because it needs access to _machine_type_mappings() also | 17:29 |
| aspiers | hrm, maybe that can also be moved to utils | 17:29 |
| aspiers | I'll try that | 17:29 |
| *** artom has quit IRC | 17:32 | |
| *** dtantsur is now known as dtantsur|afk | 17:34 | |
| *** rpittau is now known as rpittau|afk | 17:36 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Allow utime call to fail on qcow2 image base file https://review.openstack.org/641315 | 17:36 |
| *** imacdonn has joined #openstack-nova | 17:37 | |
| *** igordc has quit IRC | 17:41 | |
| *** marst has quit IRC | 17:41 | |
| sean-k-mooney | mriedem: just reading you reminder tread. regarding melwitt's change to add the user_id to the instance mappings in the api db i assume we shoudl add a nova-status check for that right? | 17:41 |
| *** ivve has joined #openstack-nova | 17:41 | |
| sean-k-mooney | mriedem: we said we would add a blocker migration but this is the kindof thing nova-status should be checking before an op does an upgrade correct? | 17:42 |
| dansmith | sean-k-mooney: for train you mean right? | 17:42 |
| sean-k-mooney | ya | 17:42 |
| sean-k-mooney | we wanted to make the colume non nullable after train so on an upgrade to U we should have a nova-status check to make sure you have run the data migration to populate the colume so that the schame migration can work | 17:44 |
| sean-k-mooney | no one memtioned nova-status the other day so i just tought i would bring it up | 17:44 |
| dansmith | I did in IRC actually, but .. we need to land that in train nova-status, not right now | 17:45 |
| sean-k-mooney | oh ok i missed that then. cool | 17:45 |
| *** marst has joined #openstack-nova | 17:45 | |
| dansmith | adding it in stein would tell them they need to do something they can't do until they deploy stein code | 17:46 |
| sean-k-mooney | right because we are only adding the column in stien | 17:46 |
| *** luksky has joined #openstack-nova | 17:47 | |
| *** jmlowe has joined #openstack-nova | 17:49 | |
| jaypipes | dansmith, mriedem: bottom 3 +W. still plowing through the nova-manage migration in https://review.openstack.org/#/c/633351... | 17:49 |
| *** artom has joined #openstack-nova | 17:50 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Allow utime call to fail on qcow2 image base file https://review.openstack.org/641315 | 17:51 |
| mriedem | jaypipes: don't make me get you a mr plow jacket | 17:51 |
| mriedem | so you can strut around | 17:51 |
| mriedem | https://www.youtube.com/watch?v=fhW3OyifFBE | 17:52 |
| *** markvoelker has quit IRC | 17:53 | |
| dansmith | mriedem: how would you communicate with the other members of the tribe if you didn't have the simpsons and every snippet documented on youtube? | 17:54 |
| mriedem | grunts | 17:54 |
| mriedem | flute sounds | 17:54 |
| jaypipes | heh | 17:55 |
| mriedem | jaypipes: so i think i'll abstain from proposing a unified limits session, it's out of my ability to lead that | 17:55 |
| *** gyee has joined #openstack-nova | 17:57 | |
| jaypipes | mriedem: I can participate in such a session. | 17:57 |
| *** phasespace has joined #openstack-nova | 17:57 | |
| mriedem | i'm going to go participate in a bowl of chili | 17:58 |
| *** mriedem is now known as mriedem_afk | 17:58 | |
| jaypipes | :) | 17:58 |
| cdent | a forum session with a chili bakeoff would be pretty cool | 17:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Fix nits in remote console guide https://review.openstack.org/641098 | 18:00 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rework all things metadata'y https://review.openstack.org/640730 | 18:00 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Rename 'configuration drive' to 'config drive' https://review.openstack.org/641723 | 18:00 |
| *** irclogbot_2 has joined #openstack-nova | 18:02 | |
| jaypipes | mriedem_afk, dansmith: please see my question on https://review.openstack.org/#/c/633351/. it's the only part of that migration I don't get... | 18:03 |
| *** derekh has quit IRC | 18:04 | |
| *** wolverineav has joined #openstack-nova | 18:05 | |
| dansmith | jaypipes: replied | 18:06 |
| *** wolverineav has quit IRC | 18:08 | |
| jaypipes | dansmith: thx | 18:08 |
| *** wolverineav has joined #openstack-nova | 18:08 | |
| *** READ10 has joined #openstack-nova | 18:16 | |
| *** priteau has quit IRC | 18:19 | |
| *** wolverineav has quit IRC | 18:23 | |
| *** psachin has joined #openstack-nova | 18:23 | |
| *** wolverineav has joined #openstack-nova | 18:24 | |
| *** sridharg has quit IRC | 18:27 | |
| *** wolverineav has quit IRC | 18:30 | |
| *** wolverineav has joined #openstack-nova | 18:30 | |
| openstackgerrit | Merged openstack/nova master: FUP for test_reshape https://review.openstack.org/641482 | 18:33 |
| openstackgerrit | Merged openstack/nova master: Update --max-rows parameter description for archive_deleted_rows https://review.openstack.org/606995 | 18:33 |
| openstackgerrit | Merged openstack/nova master: tests: Create PCI tests for NUMA'y tests https://review.openstack.org/640826 | 18:34 |
| *** mriedem_afk is now known as mriedem | 18:40 | |
| mnaser | i'm dealing with a sorts of 'usability' issue. booting a cinder volume from a glance image (where the image is stored on local disk) | 18:41 |
| mnaser | cinder eventually creates the image, but it takes around 15 minutes because it has to download+upload | 18:42 |
| mnaser | nova times out waiting for the volume, even though it's in `downloading` state | 18:42 |
| smcginnis | mnaser: Do you have image cache enabled? | 18:42 |
| smcginnis | That will help after the first one at least. | 18:42 |
| mnaser | smcginnis: interesting, i don't think image cache is enabled for this deployment, but yes, that's a good idea | 18:43 |
| smcginnis | Creating the boot volume via Nova timing out is a known issue of sorts. | 18:43 |
| smcginnis | You need to tweak the timeouts if you do it that way. | 18:43 |
| mnaser | the type of user is one who refuses to create a volume and wait for it to then attach it is the one i'm dealing with :) | 18:43 |
| smcginnis | Really recommended to create the volume first, then boot from it. | 18:43 |
| mnaser | "it should just work <insert a ton of exclamation marks>" | 18:43 |
| mriedem | mnaser: sure, just tell them to pre-cache their images :) | 18:44 |
| smcginnis | I've actually been meaning to see how difficult it would be to just update horizon to look like it's the one path, but do the two separate steps under the covers to make it less likely to time out. | 18:44 |
| mnaser | i'm just trying to see if we can have a better way in terms of usability, if cinder is reporting that its' still 'downloading' really | 18:44 |
| mnaser | also, another fun thing is that it seems like it doesn't properly clean up as it tries to request a delete on a volume that's in downloading process | 18:45 |
| mriedem | mnaser: https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.block_device_allocate_retries and https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.block_device_allocate_retries_interval are the related nova-compute options | 18:45 |
| mnaser | so seems like volumes end in error downloading state or something along those lines, but i haven't dug that far yet | 18:45 |
| mriedem | it's this code https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1308 | 18:45 |
| *** pcaruana has quit IRC | 18:46 | |
| smcginnis | Hmm, error downloading sounds like a bigger issue to address first. | 18:46 |
| mnaser | i just want to avoid changing the timeout to '15 minutes' because they will bring bigger images and then ask me to bump the timeout to '30 minutes' lols | 18:46 |
| mnaser | smcginnis: yeah, let me see if i have tracebacks for that too | 18:46 |
| mriedem | mnaser: this is the code that does the waiting and cleanup https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L689 | 18:47 |
| mriedem | nova won't delete the volume if delete_on_termination is False | 18:47 |
| mriedem | which it is by default i think | 18:47 |
| *** markvoelker has joined #openstack-nova | 18:51 | |
| mnaser | i guess the cleanest way is image cache *but* that does involve booting it once still | 18:51 |
| mnaser | we didn't have this issue when using cinder backend for glance | 18:51 |
| mnaser | but then we have the issue with glance buffering a whole image to disk and then pushing to array | 18:51 |
| smcginnis | I think I've been told if you use ceph it helps a lot. | 18:52 |
| mnaser | yes we're hoping to kill off their dell ps array | 18:52 |
| mnaser | ceph is wonderful for all of this | 18:52 |
| smcginnis | That might be good anyway. PS is no longer going to be supported. | 18:52 |
| mnaser | good, then we can force them to get off | 18:53 |
| mnaser | :-P | 18:53 |
| smcginnis | ;) | 18:53 |
| * mnaser brings out ps, throws on grass with baseball bats ala office space printing scene | 18:54 | |
| openstackgerrit | Merged openstack/nova master: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.openstack.org/640181 | 18:58 |
| openstackgerrit | Jack Ding proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.openstack.org/621646 | 19:01 |
| *** pcaruana has joined #openstack-nova | 19:05 | |
| *** ttsiouts has joined #openstack-nova | 19:07 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Clean up block_device_allocate_retries config option help https://review.openstack.org/641759 | 19:07 |
| mriedem | mnaser: i'm having a problem letting shitty docs slide lately ^ | 19:07 |
| mnaser | mriedem: i like that | 19:08 |
| mnaser | that's a lot more clear | 19:08 |
| openstackgerrit | Merged openstack/nova master: Make nova-grenade-live-migration voting and gating https://review.openstack.org/640182 | 19:10 |
| *** priteau has joined #openstack-nova | 19:11 | |
| *** xek_ has joined #openstack-nova | 19:17 | |
| mnaser | ok i've got this really strange breakage inside OSA that seems to happen within nova | 19:17 |
| mnaser | http://logs.openstack.org/08/641308/2/check/openstack-ansible-deploy-aio_lxc-centos-7/2485c9a/logs/openstack/aio1-nova/nova-compute.log.txt.gz#_2019-03-06_12_35_49_535 | 19:18 |
| mnaser | "Neutron Reported failure on event network-vif-plugged-4095592d-730d-4a32-82b7-1ec3133f5862 for instance a43072b3-43e5-4fce-ae32-c11510b569fc: NovaException: In shutdown, no new events can be scheduled" | 19:18 |
| mnaser | seems to me that the ` NovaException: In shutdown, no new events can be scheduled` portion is actually coming from `prepare_for_instance_event` | 19:18 |
| mnaser | so the error is a bit misleading too | 19:18 |
| mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n317 | 19:18 |
| mnaser | yeah, i dug that out, i need a faster way to link from vscode :< | 19:19 |
| mnaser | i'm not sure what or why self._events is, and why it's set to `None` | 19:19 |
| mnaser | the port seems to be plugging fine from the neutron side of things, according to the logs | 19:19 |
| mriedem | self._events = None generally means nova-compute is stopping | 19:19 |
| mnaser | strange, it doesn't seeeeeeem to be in those logs? you can see it continue to do things | 19:20 |
| mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n397 | 19:20 |
| mriedem | the only thing that calls that is cleanup_host http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n1236 | 19:20 |
| dansmith | that message is exactly what is supposed to happen if compute is shutting down | 19:20 |
| mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/service.py#n286 | 19:20 |
| mnaser | that's so strange, interestingly enough, the logs don't show anything about cleaning up | 19:21 |
| mnaser | or any of the "popping stuff out of event queue" messages | 19:21 |
| mnaser | we did recently merge a change where we had vif_plugging_is_fatal default to true, so this might have exposed something (and it was always failing?! i hope not..) | 19:21 |
| dansmith | vif plugging fatal should be set to true | 19:22 |
| mnaser | sorry, i mean we set it to false | 19:22 |
| dansmith | ack okay | 19:22 |
| dansmith | wait, you mean you had been setting it to false, and recently fixed that yeah? | 19:22 |
| mnaser | yeah | 19:22 |
| dansmith | either way, that won't affect the incoming events, | 19:22 |
| dansmith | just whether or not we wait for them | 19:22 |
| dansmith | and what you show above is just event delivery | 19:22 |
| mnaser | well, if something was broken before, we probably just exposed it (in osa or whatever) | 19:23 |
| mnaser | we might have been just blindly plugging ports and it just worked™ -- this just exposed it | 19:23 |
| *** markvoelker has quit IRC | 19:23 | |
| mnaser | the interesting thing is i dont see "Canceling in-flight event" in the logs anywhere | 19:23 |
| mnaser | but i guess the blocking new events might do it there | 19:23 |
| mriedem | https://review.openstack.org/#/c/420026/ | 19:23 |
| mriedem | ^ is it this? | 19:23 |
| mriedem | did something sighup the service? | 19:23 |
| dansmith | mnaser: you wouldn't if nothing is waiting when the shutdown starts | 19:23 |
| dansmith | mriedem: see my comments/ | 19:24 |
| dansmith | mriedem: we don't call cleanup_host on sighup | 19:24 |
| mnaser | let me check systemd logs | 19:24 |
| mriedem | well i'm all out of ideas :P | 19:24 |
| dansmith | if we did we'd be tearing down rpc and dropping things all over the place, which would be a pretty big problem for what sighup is supposed to do | 19:25 |
| mriedem | mnaser: are you hitting this consistently in osa ci? because a simple debug patch should tell us what is triggering the stop | 19:25 |
| mnaser | http://logs.openstack.org/08/641308/2/check/openstack-ansible-deploy-aio_lxc-centos-7/2485c9a/logs/host/messages.txt.gz#_Mar__6_12_12_43 we reload here, but that's almost 23 minutes before it happened | 19:25 |
| mnaser | yes, we're perma-borked right now | 19:25 |
| dansmith | mnaser: are you maybe starting to shut down nova services before tests have finished or something? | 19:26 |
| mnaser | that's the latest reference to a the nova-compute service | 19:26 |
| dansmith | or maybe tests are done but instances are still coming up or something? | 19:26 |
| mnaser | system logs would have shown us shutting down the service (it's a systemd unit) | 19:26 |
| mnaser | it is possible that a reload might put the nova-compute in a weird state? | 19:27 |
| dansmith | well, if you're using systemd to shut it down, sure | 19:27 |
| dansmith | mnaser: shouldn't and the code does very little on sighup | 19:27 |
| mnaser | oh thats weird | 19:29 |
| mnaser | the change mriedem linked is missing in master | 19:29 |
| mnaser | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L548 | 19:29 |
| dansmith | it's unmerged | 19:29 |
| dansmith | because it's bad | 19:29 |
| mnaser | ah oops | 19:29 |
| mnaser | my eyes failed me | 19:29 |
| dansmith | that change would also mean a sighup will cause any instances waiting to boot when you sighup fail with a timeout | 19:30 |
| dansmith | which would be pretty bad | 19:30 |
| dansmith | especially if you're sighup | 19:30 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set min=0 for block_device_allocate_retries option https://review.openstack.org/641770 | 19:30 |
| dansmith | ping nova-compute so you can turn on debug or something :) | 19:30 |
| mnaser | http://logs.openstack.org/08/641308/2/check/openstack-ansible-deploy-aio_lxc-centos-7/2485c9a/logs/openstack/aio1-nova/nova-compute.log.txt.gz#_2019-03-06_12_12_43_207 | 19:31 |
| mriedem | that matches http://logs.openstack.org/08/641308/2/check/openstack-ansible-deploy-aio_lxc-centos-7/2485c9a/logs/host/messages.txt.gz#_Mar__6_12_12_43 | 19:31 |
| dansmith | mnaser: but it also clearly ran the compute manager reset just a couple lines below "reloading" | 19:32 |
| mriedem | but not http://logs.openstack.org/08/641308/2/check/openstack-ansible-deploy-aio_lxc-centos-7/2485c9a/logs/openstack/aio1-nova/nova-compute.log.txt.gz#_2019-03-06_12_35_49_535 | 19:32 |
| dansmith | maybe some oslo.service regression? | 19:32 |
| mnaser | yeah that's what im wondering, if oslo service isn't doing the right thing, i'm gonna try to see in oslo service | 19:32 |
| dansmith | https://bugs.launchpad.net/neutron/+bug/1780139 | 19:32 |
| openstack | Launchpad bug 1780139 in neutron "Sending SIGHUP to neutron-server process causes it to hang" [Undecided,Triaged] - Assigned to Bernard Cafarelli (bcafarel) | 19:32 |
| dansmith | https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L375 | 19:33 |
| dansmith | should only exit if it's unhandled I think | 19:33 |
| mnaser | yeah it looks like the exiting is a little misleading there | 19:33 |
| *** pcaruana has quit IRC | 19:33 | |
| dansmith | https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L344 | 19:34 |
| dansmith | so unless it redefined the thing we need to override to handle sighup or something | 19:34 |
| dansmith | but clearly not, | 19:35 |
| dansmith | since we did actually do our own reload | 19:35 |
| dansmith | seems fishy | 19:35 |
| mnaser | yeah the logs show that the correct thing happened | 19:35 |
| dansmith | or ... | 19:35 |
| dansmith | maybe there was actually a respawn in between there? | 19:35 |
| dansmith | maybe it did exit? we don't have pid in the logs to tell I think | 19:36 |
| dansmith | mnaser: because after the log dump: http://logs.openstack.org/08/641308/2/check/openstack-ansible-deploy-aio_lxc-centos-7/2485c9a/logs/openstack/aio1-nova/nova-compute.log.txt.gz#_2019-03-06_12_12_55_326 | 19:36 |
| dansmith | er, conf dump | 19:36 |
| dansmith | that seems extremely wrong | 19:36 |
| dansmith | and may explain why people think that "reset events" change is necessary, because we're incorrectly really exiting? | 19:37 |
| mnaser | it looks like a new startup based on the logs | 19:37 |
| dansmith | yeah that's uncool | 19:37 |
| mnaser | esp with things like updating inventory, libvirt baseline cpu checks, etc | 19:38 |
| dansmith | so I'm guessing some oslo.service regression, or some underlying change that nova didn't adapt to | 19:38 |
| mnaser | following the code it looks like service.Service implements .reset() and hits self.manager.reset() | 19:40 |
| dansmith | our service does yeah | 19:40 |
| dansmith | we also need this to work for things like api to be able to re-calculate service versions, rpc pins,e tc | 19:40 |
| dansmith | and clearing the cells cache | 19:41 |
| mnaser | yeah, so it looks like nova is doing what its supposed to | 19:41 |
| *** wolverineav has quit IRC | 19:41 | |
| dansmith | so if this is broken it's a real problem, in addition to apparently causing compute to just drop everything on the floor and bail | 19:41 |
| mnaser | the confirmation is the fact all conf params are being logged | 19:41 |
| mnaser | which shouldnt happen | 19:41 |
| mnaser | i think ? because we are handling reset() in our own way | 19:41 |
| dansmith | well, | 19:42 |
| dansmith | sighup is how you're supposed to reload dynamic conf variables | 19:42 |
| dansmith | so I dunno if it should only dump the reloaded ones or the whole new set | 19:42 |
| dansmith | initially that wouldn't have surprised me, but now that I see it saying "starting..." again, I do wonder | 19:42 |
| dansmith | but yeah, this also kills the ability to hot-reload conf options like debug=True | 19:42 |
| mnaser | we probably don't exactly have gating that reloads services and checks if they're still functional after, but that's awfully hard to test in the first place | 19:43 |
| dansmith | yup, definitely hard to test with a parallel tempest | 19:43 |
| dansmith | we could do a post hook though pretty easy | 19:43 |
| dansmith | like set debug=False, sighup, and make sure the log didn't get another debug-esque message that would have come | 19:44 |
| dansmith | I bet mriedem gets all tingly just thinking about such at hing | 19:44 |
| dansmith | I think he <3's post hook test validation | 19:44 |
| mriedem | shut up gawd | 19:45 |
| * mriedem blushes | 19:45 | |
| mnaser | the only thing i can imagine is | 19:46 |
| mnaser | https://github.com/openstack/oslo.service/blob/471bfe770808a0348fcce1e83753dcc414b361c1/oslo_service/service.py#L395-L397 | 19:46 |
| mnaser | that somehow evaluating to false and calling self.restart() | 19:46 |
| dansmith | because of systemd not running us in daemon mode or something? | 19:46 |
| dansmith | https://github.com/openstack/oslo.service/blob/471bfe770808a0348fcce1e83753dcc414b361c1/oslo_service/service.py#L58 | 19:47 |
| dansmith | yep, | 19:47 |
| dansmith | if stdout is closed or not a tty, then we're in daemon mode, else no | 19:48 |
| mnaser | but stdout is probably open because of how systemd works | 19:48 |
| dansmith | I'm guessing maybe systemd runs us with a pty for stdout in foreground mode and that's fooling it? | 19:48 |
| mnaser | let me | 19:48 |
| mnaser | lsof a running instance now | 19:48 |
| *** jrosser has joined #openstack-nova | 19:48 | |
| dansmith | I'm pretty sure it uses a pty, | 19:48 |
| dansmith | because if you run a python program as a systemd unit, you have to turn off output buffering to see live output | 19:48 |
| dansmith | could probably defeat that by running compute |tee and see if that changes the behavior | 19:50 |
| mnaser | looks like there is a systemd option called 'DefaultStandardOutput' | 19:51 |
| mnaser | which defaults to 'journal' | 19:51 |
| dansmith | well, sure. | 19:51 |
| dansmith | but you want that unless you're using native systemd logging | 19:52 |
| mnaser | yeah, but that also means that stdout is not closed => we're not in daemon mode, right? | 19:52 |
| *** kaiokmo has joined #openstack-nova | 19:52 | |
| dansmith | it's not just closed, it's closed or not a tty | 19:52 |
| dansmith | per that is_daemon() method right? | 19:52 |
| dansmith | # The process group for a foreground process will match the | 19:53 |
| dansmith | # process group of the controlling terminal. If those values do | 19:53 |
| dansmith | # not match, or ioctl() fails on the stdout file handle, we assume | 19:53 |
| dansmith | # the process is running in the background as a daemon. | 19:53 |
| dansmith | if systemd is running us with a pty for stdio, that will assume we're in interactive mode and say we're not a daemon, which means sighup->restarts (for some reason which I'm not even sure is legit) | 19:54 |
| mnaser | ok let me just drop that python code in a simple systemd unit and see what happens | 19:54 |
| dansmith | also would be useful to just take a system running like this and put a debug print() in that thing to see if we're returning !daemon for any reason | 19:58 |
| mnaser | bleh, returning true | 19:59 |
| mnaser | http://paste.openstack.org/show/747426/ | 20:00 |
| dansmith | not sure that's a really legit test, | 20:01 |
| dansmith | because any other service startup stuff could impact that | 20:01 |
| dansmith | like chdir(), close existing fds, logging setup, etc | 20:01 |
| dansmith | I think it'd be more useful to just instrument a misbehaving openstack service | 20:01 |
| mnaser | ok so let me do it on a machine i have here then | 20:01 |
| mnaser | on an actual nova-compute | 20:02 |
| mnaser | _is_sighup_and_daemon: True | 20:04 |
| mnaser | which means | 20:04 |
| mnaser | if not True: .. so it doesn't break and does a restart | 20:04 |
| mnaser | wait what, shouldn't that be if _is_sighup_and_daemon(signo): break ? | 20:05 |
| mnaser | given that we don't want to restart if we get a sighup and running in daemon mode? | 20:05 |
| dansmith | hrm, yeah | 20:06 |
| mnaser | https://github.com/openstack/oslo.service/commit/94e76035c627e003f601c6501c0f414a13160f1f#diff-49ecd82bf041c1fd494a0bc4a96782deR195 | 20:06 |
| dansmith | tbh, I don't know why this logic is here regardless | 20:06 |
| *** eharney has quit IRC | 20:06 | |
| dansmith | ...newton | 20:06 |
| mnaser | yeah it's been a hot minute | 20:07 |
| mnaser | i really hope it hasn't been broken that whole time | 20:07 |
| mnaser | lol | 20:07 |
| dansmith | that was around the time of the great systemdification of devstack, and because sdague | 20:07 |
| dansmith | so really fishy | 20:07 |
| dansmith | but sounds like something is broken to me | 20:07 |
| mnaser | ok ill try to ping doug | 20:08 |
| *** ivve has quit IRC | 20:08 | |
| dansmith | I don't really agree with the assertion made in the commit message of that | 20:09 |
| dansmith | because it assumes that we're only a long-lived service if we've daemonized ourselves | 20:09 |
| dansmith | mnaser: also note that systemd can handle self-daemonizing services, so it depends on how your particular unit is running nova-compute too | 20:09 |
| mnaser | dansmith: yeah, afaik we use type=simple so it's the "run in foreground mode forever" model | 20:11 |
| dansmith | ack | 20:11 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Dont' wait for VIF plugging during revert resize https://review.openstack.org/639396 | 20:11 |
| dansmith | mnaser: assume you don't have a bug open for this yet right? | 20:12 |
| *** wolverineav has joined #openstack-nova | 20:14 | |
| *** IvensZambrano has quit IRC | 20:14 | |
| *** rchurch_ has joined #openstack-nova | 20:15 | |
| *** rchurch has quit IRC | 20:17 | |
| *** psachin has quit IRC | 20:17 | |
| *** wolverineav has quit IRC | 20:19 | |
| mriedem | someone should uh, put some time into figuring out what to do about this old ass statement https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L1380 | 20:19 |
| mnaser | bug | 20:19 |
| mnaser | gah ctrl+f doesnt exist i guess | 20:19 |
| *** IvensZambrano has joined #openstack-nova | 20:20 | |
| *** markvoelker has joined #openstack-nova | 20:20 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Integration tests using gabbi-tempest https://review.openstack.org/613386 | 20:25 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove unused context parameter from RT._get_instance_type https://review.openstack.org/641792 | 20:26 |
| *** marst has quit IRC | 20:32 | |
| *** READ10 has quit IRC | 20:35 | |
| *** wolverineav has joined #openstack-nova | 20:35 | |
| *** wolverineav has quit IRC | 20:40 | |
| openstackgerrit | Merged openstack/nova master: Separate methods to free claimed and allocated devs https://review.openstack.org/616120 | 20:41 |
| *** hemna has quit IRC | 20:41 | |
| *** marst has joined #openstack-nova | 20:42 | |
| *** igordc has joined #openstack-nova | 20:44 | |
| *** priteau has quit IRC | 20:48 | |
| *** markvoelker has quit IRC | 20:53 | |
| *** eharney has joined #openstack-nova | 20:54 | |
| *** awaugama has quit IRC | 20:55 | |
| *** wolverineav has joined #openstack-nova | 21:04 | |
| *** erlon has quit IRC | 21:05 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.openstack.org/641806 | 21:10 |
| *** marst has quit IRC | 21:10 | |
| *** mikal has joined #openstack-nova | 21:11 | |
| *** ralonsoh has quit IRC | 21:12 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.openstack.org/641806 | 21:13 |
| *** priteau has joined #openstack-nova | 21:13 | |
| *** xek_ has quit IRC | 21:15 | |
| mikal | Given the sudden burst of interest in the privsep patches, is it worth asking for a FFE? | 21:16 |
| *** priteau has quit IRC | 21:16 | |
| *** whoami-rajat has quit IRC | 21:17 | |
| mriedem | nope | 21:17 |
| mikal | Fair enough. | 21:17 |
| mikal | I wont rush to deal with new review comments then. | 21:18 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set min=0 for block_device_allocate_retries option https://review.openstack.org/641770 | 21:19 |
| mriedem | mikal: i don't mean to be terse, we just have 2 weeks to rc1 and a lot of other stuff to focus on. | 21:19 |
| *** snevi has joined #openstack-nova | 21:20 | |
| *** IvensZambrano has quit IRC | 21:20 | |
| mikal | mriedem: sure. So I'll just go back to pottering along at my own pace and being mildly surprised when something merges. | 21:20 |
| mriedem | efried: i'm not sure how i feel about linking to release-specific docs | 21:24 |
| mriedem | since those are only published for so long | 21:24 |
| *** mtreinish has quit IRC | 21:25 | |
| *** mtreinish has joined #openstack-nova | 21:26 | |
| efried | mriedem: responded. I'm fine either way, hence the +2. | 21:27 |
| efried | mriedem: Add 'h' in https://review.openstack.org/#/c/641770/ and I'm +2 there too. | 21:27 |
| *** BjoernT has joined #openstack-nova | 21:27 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set min=0 for block_device_allocate_retries option https://review.openstack.org/641770 | 21:32 |
| mriedem | dansmith: jaypipes: looks like the nova-grenade-live-migration playbook change screwed up mel's series in the gate, so i'm going to rebase and re-approve, just fyi | 21:33 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add user_id column to the instance_mappings table https://review.openstack.org/633349 | 21:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350 | 21:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | 21:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 21:34 |
| mriedem | artom: replied in https://review.openstack.org/#/c/641806/ | 21:38 |
| mriedem | but good questions | 21:38 |
| *** artom has quit IRC | 21:40 | |
| mriedem | this RT code dealing with adding/removing usage from flavors during a resize is way too f'ing magical | 21:41 |
| mriedem | and i've done too much staring at it while working on the cross-cell resize stuff | 21:42 |
| mriedem | it also *loves* to fail silently | 21:42 |
| mriedem | SBD | 21:42 |
| dansmith | mriedem: ack | 21:42 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855 | 21:45 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.openstack.org/638680 | 21:46 |
| *** markvoelker has joined #openstack-nova | 21:50 | |
| jaypipes | mriedem: ++ | 21:51 |
| jaypipes | mriedem: and thank you | 21:51 |
| *** priteau has joined #openstack-nova | 21:56 | |
| *** dave-mccowan has quit IRC | 22:02 | |
| *** BjoernT has quit IRC | 22:14 | |
| cfriesen | is it a known issue that during a resize/migrate the resource audit will choke trying to find the instance disk on the source node? | 22:15 |
| *** tosky has quit IRC | 22:22 | |
| *** markvoelker has quit IRC | 22:23 | |
| mriedem | i think so | 22:25 |
| mriedem | i've tried to whack that mole before | 22:25 |
| mriedem | cfriesen: https://review.openstack.org/#/q/Icec2769bf42455853cbe686fb30fda73df791b25 | 22:27 |
| mriedem | cfriesen: https://bugs.launchpad.net/nova/+bug/1774249 is the resize sister to that | 22:28 |
| openstack | Launchpad bug 1774249 in OpenStack Compute (nova) "update_available_resource will raise DiskNotFound after resize but before confirm" [Medium,In progress] - Assigned to Vladyslav Drok (vdrok) | 22:28 |
| mriedem | vdrok: are you working on a fix for ^? | 22:29 |
| *** tosky has joined #openstack-nova | 22:29 | |
| *** cdent has quit IRC | 22:33 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use assertXmlEqual() helper for all XML comparison tests https://review.openstack.org/641852 | 22:37 |
| *** rcernin has joined #openstack-nova | 22:41 | |
| cfriesen | anyone else run into issues with unstack.sh hanging in neutron_ovs_base_cleanup? | 22:41 |
| cfriesen | I had to repeatedly ctrl-C it and rerun it...it was like it wasn't realizing that the command had finished | 22:44 |
| gmann | mriedem: lyarwood FYI: tempest-slow (voting) and tempest-multinode-full(n-v) are running on stable branch gate also - http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003604.html | 22:47 |
| mriedem | cfriesen: unstack is not maintained as far as i know | 22:48 |
| mriedem | gmann: yeah i saw that email but hadn't parsed it yet | 22:48 |
| gmann | mriedem: ssh issue has been fixed on stable branch which i talked to you few days back. now all good and they are running on stable branch too | 22:49 |
| mriedem | what was the ssh issue? | 22:49 |
| gmann | few of the backport fixes - passwordless ssh with stack between nodes | 22:50 |
| *** sapd1 has joined #openstack-nova | 22:51 | |
| *** priteau has quit IRC | 22:51 | |
| *** wolverineav has quit IRC | 22:55 | |
| *** wolverineav has joined #openstack-nova | 22:56 | |
| *** tkajinam has joined #openstack-nova | 22:58 | |
| mriedem | prepare for impact | 22:59 |
| *** IvensZambrano has joined #openstack-nova | 22:59 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1818914 https://review.openstack.org/641521 | 22:59 |
| openstack | bug 1818914 in OpenStack Compute (nova) "Hypervisor resource usage on source still shows old flavor usage after resize confirm until update_available_resource periodic runs" [Low,In progress] https://launchpad.net/bugs/1818914 - Assigned to Matt Riedemann (mriedem) | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove unused context parameter from RT._get_instance_type https://review.openstack.org/641792 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.openstack.org/641806 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell https://review.openstack.org/641179 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.openstack.org/639382 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012 | 22:59 |
| *** snevi has quit IRC | 22:59 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.openstack.org/637605 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 22:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add finish_snapshot_based_resize_at_dest compute method https://review.openstack.org/635080 | 23:00 |
| mriedem | Last commands done (39 commands done) | 23:01 |
| mriedem | oh yeah | 23:01 |
| *** mriedem is now known as mriedem_away | 23:02 | |
| efried | cfriesen: ...assertRaises as context manager, or you can assign from it - see https://review.openstack.org/#/c/633227/5/nova/tests/unit/compute/test_compute_mgr.py@8390 | 23:04 |
| *** owalsh_ has joined #openstack-nova | 23:05 | |
| *** luksky has quit IRC | 23:05 | |
| *** owalsh has quit IRC | 23:06 | |
| cfriesen | I just ran unstack.sh and then stack.sh and now nova-compute is complaining that placement says it can't make a RP record because the resource provider name already exists (but the uuid is different) | 23:13 |
| cfriesen | http://paste.openstack.org/show/747432/ | 23:14 |
| *** markvoelker has joined #openstack-nova | 23:20 | |
| *** purplerbot has quit IRC | 23:26 | |
| *** purplerbot has joined #openstack-nova | 23:26 | |
| vdrok | mriedem_away: yeah patch is here https://review.openstack.org/#/c/571410/ just not shown in the big | 23:31 |
| vdrok | *bug | 23:31 |
| *** tosky has quit IRC | 23:34 | |
| efried | mriedem_away: I don't see an os-brick release. Shouldn't there be one? | 23:36 |
| efried | melwitt, dansmith, jaypipes: ^ ? | 23:36 |
| dansmith | I dunno, does it change much? | 23:37 |
| dansmith | I would have expected it to mostly be on its own release schedule, whenever it needs | 23:37 |
| *** wolverineav has quit IRC | 23:39 | |
| *** wolverineav has joined #openstack-nova | 23:40 | |
| efried | dansmith: It's a non-client lib, type thing. And at least one significant change: https://review.openstack.org/#/c/635530/ | 23:42 |
| efried | jungleboyj: thoughts ^ | 23:43 |
| *** wolverineav has quit IRC | 23:45 | |
| dansmith | yeah I dunno, but figure the cinder peeps are probably on top of it | 23:45 |
| efried | dansmith: When I say not released, I mean not even proposed. | 23:46 |
| *** wolverineav has joined #openstack-nova | 23:46 | |
| *** jmlowe has quit IRC | 23:46 | |
| efried | I guess I'll do it and add jungleboyj. If not needed, won't go. No harm. | 23:46 |
| *** jmlowe has joined #openstack-nova | 23:46 | |
| efried | it's a subsidiary of nova, not cinder, right? | 23:48 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use assertXmlEqual() helper for all XML comparison tests https://review.openstack.org/641852 | 23:49 |
| efried | proposed: https://review.openstack.org/641863 | 23:50 |
| *** markvoelker has quit IRC | 23:52 | |
| dansmith | efried: os-brick? | 23:55 |
| dansmith | thinking os-vif? | 23:55 |
| efried | dansmith: os-vif got a release in late Feb, I think that one is aight. | 23:56 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove duplicate cleanup in functional tests https://review.openstack.org/636996 | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!