| *** ttsiouts has joined #openstack-nova | 00:07 | |
| *** itlinux has joined #openstack-nova | 00:09 | |
| *** sdake has joined #openstack-nova | 00:09 | |
| *** sdake has quit IRC | 00:12 | |
| *** itlinux_ has joined #openstack-nova | 00:13 | |
| *** tetsuro has joined #openstack-nova | 00:13 | |
| *** sdake has joined #openstack-nova | 00:13 | |
| *** itlinux has quit IRC | 00:15 | |
| *** wolverineav has joined #openstack-nova | 00:16 | |
| *** _alastor_ has quit IRC | 00:17 | |
| *** lchabert has quit IRC | 00:19 | |
| *** lchabert has joined #openstack-nova | 00:21 | |
| *** _alastor_ has joined #openstack-nova | 00:23 | |
| *** lbragstad has quit IRC | 00:26 | |
| *** _alastor_ has quit IRC | 00:27 | |
| *** ttsiouts has quit IRC | 00:29 | |
| *** sdake has quit IRC | 00:41 | |
| *** sapd1 has quit IRC | 00:42 | |
| *** wolverineav has quit IRC | 00:47 | |
| *** markvoelker has joined #openstack-nova | 00:48 | |
| *** ericyoung has quit IRC | 00:50 | |
| *** ericyoung has joined #openstack-nova | 00:51 | |
| *** wxy-xiyuan has joined #openstack-nova | 00:53 | |
| *** rchurch has joined #openstack-nova | 00:54 | |
| *** openstackgerrit has joined #openstack-nova | 00:54 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api https://review.openstack.org/612949 | 00:54 |
|---|---|---|
| *** rchurch_ has quit IRC | 00:55 | |
| *** Sundar has joined #openstack-nova | 00:56 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot https://review.openstack.org/580336 | 00:58 |
| *** wolverineav has joined #openstack-nova | 00:58 | |
| *** macza has joined #openstack-nova | 00:59 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot https://review.openstack.org/580336 | 00:59 |
| *** ileixe has joined #openstack-nova | 01:00 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Avoid BadRequest error log on volume attachment https://review.openstack.org/640110 | 01:01 |
| *** macza has quit IRC | 01:03 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api https://review.openstack.org/612949 | 01:05 |
| *** sdake has joined #openstack-nova | 01:08 | |
| *** rchurch has quit IRC | 01:10 | |
| *** rchurch has joined #openstack-nova | 01:11 | |
| *** _alastor_ has joined #openstack-nova | 01:12 | |
| *** _alastor_ has quit IRC | 01:17 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Remove the string check of the flavor attribute 'swap' https://review.openstack.org/639012 | 01:20 |
| *** markvoelker has quit IRC | 01:22 | |
| *** brinzhang has joined #openstack-nova | 01:22 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 01:28 |
| *** macza has joined #openstack-nova | 01:35 | |
| *** dpawlik has joined #openstack-nova | 01:37 | |
| yonglihe | everyone seems tired, take care, just update the patch. jaypipe, forgive my bad English. ping alex_xu, you must be energized. | 01:38 |
| *** macza has quit IRC | 01:39 | |
| *** ileixe has quit IRC | 01:40 | |
| *** dpawlik has quit IRC | 01:42 | |
| *** dave-mccowan has joined #openstack-nova | 01:47 | |
| *** gouthamr has quit IRC | 01:48 | |
| *** ileixe has joined #openstack-nova | 01:51 | |
| *** ileixe has quit IRC | 01:52 | |
| *** sapd1 has joined #openstack-nova | 01:52 | |
| *** ileixe has joined #openstack-nova | 01:53 | |
| *** bhagyashris has joined #openstack-nova | 01:54 | |
| *** wolverineav has quit IRC | 01:57 | |
| *** whoami-rajat has joined #openstack-nova | 02:02 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Add pmem_namespaces field to the NUMACell obj https://review.openstack.org/634547 | 02:05 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Add virtual_pmems fields to the InstanceNUMACell obj https://review.openstack.org/634548 | 02:05 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace when initiating libvirt driver https://review.openstack.org/634549 | 02:05 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Update PMEM namespaces info and usage https://review.openstack.org/634550 | 02:05 |
| *** sdake has quit IRC | 02:05 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report pmem namespaces resources by provider tree https://review.openstack.org/634551 | 02:05 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: API: parse pmem related flavor extra spec https://review.openstack.org/634552 | 02:05 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: scheduler: translate virtual pmems request to placement request group https://review.openstack.org/634553 | 02:05 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: update _numa_fit_instance_cell for the support of virtual_pmems https://review.openstack.org/634554 | 02:05 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: boot VM with vpmems and cleanup vpmems when destroying https://review.openstack.org/634555 | 02:05 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: support VM resizing with vpmem data migration https://review.openstack.org/634556 | 02:05 |
| *** macza has joined #openstack-nova | 02:11 | |
| *** hongbin has joined #openstack-nova | 02:13 | |
| *** macza has quit IRC | 02:15 | |
| *** markvoelker has joined #openstack-nova | 02:19 | |
| *** sdake has joined #openstack-nova | 02:27 | |
| openstackgerrit | Merged openstack/nova master: Use a placement conf when testing report client https://review.openstack.org/640853 | 02:27 |
| *** ircuser-1 has joined #openstack-nova | 02:28 | |
| *** takashin has joined #openstack-nova | 02:30 | |
| *** wolverineav has joined #openstack-nova | 02:33 | |
| *** s1061123 has quit IRC | 02:34 | |
| *** s1061123 has joined #openstack-nova | 02:37 | |
| *** sapd1 has quit IRC | 02:37 | |
| *** psachin has joined #openstack-nova | 02:39 | |
| *** gouthamr has joined #openstack-nova | 02:50 | |
| *** markvoelker has quit IRC | 02:51 | |
| *** wolverineav has quit IRC | 03:00 | |
| *** wolverineav has joined #openstack-nova | 03:01 | |
| *** wolverineav has quit IRC | 03:06 | |
| *** itlinux_ has quit IRC | 03:06 | |
| *** itlinux has joined #openstack-nova | 03:12 | |
| *** alanmeadows has left #openstack-nova | 03:21 | |
| *** itlinux has quit IRC | 03:21 | |
| openstackgerrit | Fan Zhang proposed openstack/nova master: Retry after hitting libvirt error VIR_ERR_OPERATION_INVALID in live migration. https://review.openstack.org/612272 | 03:23 |
| *** itlinux has joined #openstack-nova | 03:25 | |
| *** wolverineav has joined #openstack-nova | 03:31 | |
| *** tbachman has quit IRC | 03:33 | |
| *** dpawlik has joined #openstack-nova | 03:38 | |
| *** dave-mccowan has quit IRC | 03:42 | |
| *** dpawlik has quit IRC | 03:43 | |
| *** markvoelker has joined #openstack-nova | 03:48 | |
| *** sdake has quit IRC | 03:51 | |
| *** gyee has quit IRC | 03:54 | |
| *** wolverineav has quit IRC | 04:07 | |
| *** udesale has joined #openstack-nova | 04:18 | |
| *** markvoelker has quit IRC | 04:22 | |
| *** sridharg has joined #openstack-nova | 04:41 | |
| *** owalsh_ has joined #openstack-nova | 04:50 | |
| *** owalsh has quit IRC | 04:51 | |
| *** wolverineav has joined #openstack-nova | 05:00 | |
| *** wolverineav has quit IRC | 05:06 | |
| *** janki has joined #openstack-nova | 05:08 | |
| *** hongbin has quit IRC | 05:09 | |
| *** markvoelker has joined #openstack-nova | 05:19 | |
| *** udesale has quit IRC | 05:22 | |
| *** ratailor has joined #openstack-nova | 05:23 | |
| *** dpawlik has joined #openstack-nova | 05:39 | |
| *** dpawlik has quit IRC | 05:44 | |
| *** sdake has joined #openstack-nova | 05:47 | |
| *** jhesketh has quit IRC | 05:47 | |
| *** jhesketh has joined #openstack-nova | 05:48 | |
| *** sdake has quit IRC | 05:50 | |
| *** markvoelker has quit IRC | 05:51 | |
| *** pcaruana has joined #openstack-nova | 05:52 | |
| openstackgerrit | Lajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.72 https://review.openstack.org/637234 | 05:55 |
| *** sdake has joined #openstack-nova | 05:57 | |
| *** pcaruana has quit IRC | 06:07 | |
| *** _alastor_ has joined #openstack-nova | 06:08 | |
| *** _alastor_ has quit IRC | 06:12 | |
| *** dpawlik has joined #openstack-nova | 06:19 | |
| *** ccamacho has quit IRC | 06:21 | |
| *** dpawlik has quit IRC | 06:24 | |
| *** dims has quit IRC | 06:24 | |
| *** dims has joined #openstack-nova | 06:26 | |
| *** masber has joined #openstack-nova | 06:28 | |
| masber | good afternoon, I am trying to setup OVS offload but nova fails getting representor port for PF. The question is: How is the representor created? | 06:29 |
| *** itlinux has quit IRC | 06:34 | |
| *** dims has quit IRC | 06:36 | |
| *** dims has joined #openstack-nova | 06:37 | |
| *** markvoelker has joined #openstack-nova | 06:48 | |
| *** wolverineav has joined #openstack-nova | 06:48 | |
| *** Luzi has joined #openstack-nova | 06:51 | |
| *** wolverineav has quit IRC | 06:53 | |
| *** sridharg has quit IRC | 06:57 | |
| *** sridharg has joined #openstack-nova | 07:02 | |
| *** mdbooth has joined #openstack-nova | 07:06 | |
| *** yumapath has joined #openstack-nova | 07:08 | |
| yumapath | Hi team | 07:08 |
| yumapath | while running the CI we are seeing one issue in the master devstack installation | 07:08 |
| yumapath | 2019-03-04 23:54:21.262 | + functions:wait_for_compute:465 : openstack --os-cloud devstack-admin --os-region RegionOne compute service list | 07:08 |
| yumapath | this command is timing out | 07:09 |
| *** mdbooth_ has quit IRC | 07:09 | |
| yumapath | : echo 'Didn'\''t find service registered by hostname after 60 seconds' 2019-03-04 23:54:21.257 | Didn't find service registered by hostname after 60 seconds | 07:09 |
| yumapath | with this error | 07:09 |
| yumapath | the stable releases are all passing | 07:09 |
| yumapath | the issue is seen only with master | 07:09 |
| yumapath | did anything change in the master to cause this issue | 07:09 |
| *** slaweq has joined #openstack-nova | 07:11 | |
| *** wolverineav has joined #openstack-nova | 07:14 | |
| *** wolverineav has quit IRC | 07:14 | |
| *** markvoelker has quit IRC | 07:22 | |
| *** brinzhang has quit IRC | 07:25 | |
| *** dpawlik has joined #openstack-nova | 07:25 | |
| *** brinzhang has joined #openstack-nova | 07:25 | |
| *** stakeda has joined #openstack-nova | 07:30 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 07:30 |
| *** takashin has left #openstack-nova | 07:32 | |
| *** ralonsoh has joined #openstack-nova | 07:34 | |
| *** udesale has joined #openstack-nova | 07:51 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add user_id column to the instance_mappings table https://review.openstack.org/633349 | 07:53 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350 | 07:53 |
| openstackgerrit | melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | 07:53 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 07:53 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 07:53 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 07:53 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 07:53 |
| *** udesale has quit IRC | 08:01 | |
| *** cfriesen has quit IRC | 08:07 | |
| *** tesseract has joined #openstack-nova | 08:09 | |
| *** Sundar has quit IRC | 08:11 | |
| *** tssurya has joined #openstack-nova | 08:16 | |
| *** luksky has joined #openstack-nova | 08:16 | |
| *** awalende has joined #openstack-nova | 08:16 | |
| *** sapd1 has joined #openstack-nova | 08:16 | |
| *** rpittau|afk is now known as rpittau | 08:16 | |
| *** markvoelker has joined #openstack-nova | 08:18 | |
| *** pcaruana has joined #openstack-nova | 08:18 | |
| *** tkajinam has quit IRC | 08:22 | |
| *** owalsh_ is now known as owalsh | 08:24 | |
| *** pcaruana has quit IRC | 08:25 | |
| *** helenfm has joined #openstack-nova | 08:29 | |
| *** ccamacho has joined #openstack-nova | 08:29 | |
| *** yumapath has quit IRC | 08:31 | |
| *** sdake has quit IRC | 08:36 | |
| *** pcaruana has joined #openstack-nova | 08:37 | |
| *** priteau has joined #openstack-nova | 08:42 | |
| *** sajauddin has joined #openstack-nova | 08:43 | |
| *** pcaruana has quit IRC | 08:44 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 08:47 |
| kashyap | gibi: When you can, please put this one through its misery :-) -- https://review.openstack.org/#/c/637578/1 | 08:48 |
| kashyap | (You've looked at it before.) | 08:49 |
| *** markvoelker has quit IRC | 08:51 | |
| *** ttsiouts has joined #openstack-nova | 08:52 | |
| openstackgerrit | Merged openstack/nova master: Improve existing flavor and image metadata validation https://review.openstack.org/640841 | 08:57 |
| *** pcaruana has joined #openstack-nova | 09:01 | |
| *** macza has joined #openstack-nova | 09:01 | |
| openstackgerrit | licanwei proposed openstack/nova master: api-ref: typo service.disable_reason https://review.openstack.org/640956 | 09:01 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: qemu: Make disk image conversion dramatically faster https://review.openstack.org/640781 | 09:03 |
| *** jding1_ has joined #openstack-nova | 09:04 | |
| *** macza has quit IRC | 09:05 | |
| *** ttsiouts has quit IRC | 09:05 | |
| *** ttsiouts has joined #openstack-nova | 09:06 | |
| *** rha has quit IRC | 09:07 | |
| *** jackding has quit IRC | 09:07 | |
| *** rha has joined #openstack-nova | 09:07 | |
| *** phasespace has joined #openstack-nova | 09:08 | |
| *** moshele has joined #openstack-nova | 09:09 | |
| *** ttsiouts has quit IRC | 09:10 | |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run without --user flag in Quobyte driver https://review.openstack.org/554195 | 09:11 |
| *** ttsiouts has joined #openstack-nova | 09:12 | |
| awalende | Is there a way to deny instances who have special characters in their hostnames like "periods" or something? It messes with internal dns | 09:12 |
| *** panda|ruck|off is now known as panda|ruck|flu | 09:13 | |
| *** cdent has joined #openstack-nova | 09:15 | |
| aspiers | cdent: thanks for sorting that so quickly | 09:21 |
| cdent | aspiers: well I was the trigger for the problem, so... | 09:21 |
| *** dtantsur|afk is now known as dtantsur | 09:22 | |
| *** IvensZambrano has joined #openstack-nova | 09:31 | |
| *** stakeda has quit IRC | 09:31 | |
| kashyap | aspiers: If you want a small change in scenery: https://review.openstack.org/640781 :-) | 09:32 |
| *** derekh has joined #openstack-nova | 09:36 | |
| *** mdbooth has quit IRC | 09:38 | |
| *** bhagyashris has quit IRC | 09:38 | |
| *** mdbooth has joined #openstack-nova | 09:39 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: cpu-model-selection: s/cpu_models/cpu_model_list/ https://review.openstack.org/640866 | 09:41 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 09:46 |
| *** markvoelker has joined #openstack-nova | 09:48 | |
| openstackgerrit | Merged openstack/nova master: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 09:50 |
| *** moshele has quit IRC | 09:52 | |
| *** sdake has joined #openstack-nova | 09:56 | |
| aspiers | \o/ capabilities patch landed \o/ | 09:58 |
| aspiers | kashyap: looking | 09:58 |
| kashyap | aspiers: It's a one-worder, but the (long) commit message tells the story | 09:59 |
| kashyap | I'm off from noon; so check back in tonight / tomm. | 09:59 |
| *** sajauddin has quit IRC | 10:02 | |
| aspiers | kashyap: updated https://review.openstack.org/#/c/640483/ but just realised I didn't address Artom's feedback on the commit message | 10:04 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Parse <emulator> elements from virConnectGetCapabilities() https://review.openstack.org/640483 | 10:09 |
| *** _alastor_ has joined #openstack-nova | 10:09 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Refactor CONTRIBUTING.rst https://review.openstack.org/640970 | 10:09 |
| aspiers | kashyap: addressed in PS3 | 10:10 |
| *** mdbooth has quit IRC | 10:10 | |
| bauzas | stephenfin: gibi: I just wrote https://review.openstack.org/640970 based on some good point from ttx | 10:11 |
| bauzas | feedback welcome | 10:12 |
| *** _alastor_ has quit IRC | 10:14 | |
| gibi | bauzas, kashyap: ack for both patches I will try to look at both after lunch | 10:14 |
| bauzas | gibi: it's not a crucial thing | 10:15 |
| *** mdbooth has joined #openstack-nova | 10:18 | |
| openstackgerrit | Merged openstack/nova master: Make move_allocations handle empty source allocations https://review.openstack.org/636412 | 10:20 |
| *** markvoelker has quit IRC | 10:22 | |
| *** luksky has quit IRC | 10:22 | |
| *** tetsuro has quit IRC | 10:25 | |
| *** tetsuro has joined #openstack-nova | 10:29 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 10:40 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: fakelibvirt: Add ability to generate fake PCI devices https://review.openstack.org/640409 | 10:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Create PCI tests for NUMA'y tests https://review.openstack.org/640826 | 10:44 |
| *** erlon has joined #openstack-nova | 10:45 | |
| *** sdake has quit IRC | 10:51 | |
| *** macza has joined #openstack-nova | 10:51 | |
| *** sdake has joined #openstack-nova | 10:54 | |
| *** macza has quit IRC | 10:55 | |
| *** luksky has joined #openstack-nova | 11:02 | |
| *** markvoelker has joined #openstack-nova | 11:19 | |
| *** ttsiouts has quit IRC | 11:19 | |
| *** ttsiouts has joined #openstack-nova | 11:20 | |
| *** janki has quit IRC | 11:22 | |
| *** ttsiouts has quit IRC | 11:24 | |
| openstackgerrit | huanhongda proposed openstack/nova stable/rocky: Fix resource tracker updates during instance evacuation https://review.openstack.org/640982 | 11:24 |
| *** sapd1 has quit IRC | 11:29 | |
| openstackgerrit | Merged openstack/nova master: Fix wrong consumer type in logging https://review.openstack.org/640723 | 11:34 |
| *** tetsuro has quit IRC | 11:40 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 11:49 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 11:49 |
| *** markvoelker has quit IRC | 11:51 | |
| gibi | stephenfin, bauzas, sean-k-mooney: I've fixed / answered the concerns in https://review.openstack.org/623543 | 11:51 |
| sean-k-mooney | gibi: thanks. just going to make tea and il review after. i was more or less happy with it before so i expect it will be fine | 11:54 |
| gibi | sean-k-mooney: thanks | 11:56 |
| stephenfin | sean-k-mooney: Do you know anything about neutron's proxying of the nova metadata service? | 11:57 |
| * stephenfin tried updating the config drive docs and has ended up down a rabbit hole of neutron/nova-net madness | 11:57 | |
| sean-k-mooney | yes | 11:59 |
| sean-k-mooney | it can do it in two ways | 11:59 |
| sean-k-mooney | either via the dhcp agent or the l3 agent | 11:59 |
| sean-k-mooney | the default is to do it via the l3 agent by seting up a dnat rule in the router namespace to proxy the query to the neutron api | 12:00 |
| *** udesale has joined #openstack-nova | 12:00 | |
| *** ttsiouts has joined #openstack-nova | 12:01 | |
| stephenfin | sean-k-mooney: and what determines which way is used? I see references to neutron-metadata-agent, but I'm not sure how that fits in | 12:01 |
| sean-k-mooney | if you have an isolated network(one that is not connect to an extrenal network via routers) then you use the dhcp version which used a dhcp option field to pass a route and it does the same dnat in the dhcp namespace | 12:01 |
| stephenfin | sean-k-mooney: or whether nova-api-metadata or nova-api is used in this scenario | 12:01 |
| sean-k-mooney | stephenfin: its determind by 2 or 3 config optiosn let me get them | 12:05 |
| sean-k-mooney | these in the dhcp agent https://github.com/openstack/neutron/blob/master/neutron/conf/agent/dhcp.py#L41-L67 | 12:06 |
| sean-k-mooney | and these in the l3 agent https://github.com/openstack/neutron/blob/master/neutron/conf/agent/l3/config.py#L49-L51 https://github.com/openstack/neutron/blob/master/neutron/conf/agent/l3/config.py#L92-L98 | 12:07 |
| sean-k-mooney | so by default its enabled in the l3 agent and disabled in the dhcp agent | 12:08 |
| *** zhubx has quit IRC | 12:09 | |
| *** zhubx has joined #openstack-nova | 12:10 | |
| sean-k-mooney | stephenfin: as far as im aware the neutron metadata agent is the thing the proxies the requrest to the nova api and the l3/dhcp agent just nat the requests to the metadata agent | 12:11 |
| sean-k-mooney | so the metadata agent is what actully has the address fo the nova metadata endpong https://github.com/openstack/neutron/blob/a388701ddfe628e9a5bd16a78422164799b11ef8/neutron/conf/agent/metadata/config.py#L47-L53 | 12:12 |
| *** ratailor has quit IRC | 12:13 | |
| *** ociuhandu has quit IRC | 12:14 | |
| *** mmethot has quit IRC | 12:15 | |
| *** awalende has quit IRC | 12:15 | |
| *** awalende has joined #openstack-nova | 12:16 | |
| *** ccamacho has quit IRC | 12:17 | |
| *** dave-mccowan has joined #openstack-nova | 12:20 | |
| *** xek has joined #openstack-nova | 12:27 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | 12:29 |
| *** sdake has quit IRC | 12:39 | |
| *** mriedem has joined #openstack-nova | 12:41 | |
| * cdent is eagerly looking forward to when we can dump python2.x-3.5 | 12:48 | |
| *** tosky has joined #openstack-nova | 12:48 | |
| *** brinzhang has quit IRC | 12:49 | |
| *** markvoelker has joined #openstack-nova | 12:49 | |
| sean-k-mooney | gibi: so when i was talking about macvtap i was refering to sriov in macvtap mode not the macvtap agent | 12:49 |
| sean-k-mooney | gibi: so if you want to say we support sriov minium bandwith we should test both modes not just direct | 12:50 |
| sean-k-mooney | i guess technically we shoudl test direct_physical to but in that case we are alloccatign the pf to the guest so it gets all the bandwith | 12:51 |
| sean-k-mooney | anyway i dont want to block the patch on this point but currently it looks like you have only been looking a sriov in direct mode | 12:51 |
| sean-k-mooney | for vnic_type=direct_physical we shoudl reserve the remaing bandwtih inventory for the pf as no other instances can use it in addtion to the normal allocation | 12:55 |
| sean-k-mooney | techncially we should do that in some case for vnic_type=direct too as vnic_type=direct is allowed to give you a pf | 12:56 |
| sean-k-mooney | direct_pysical was just intoduced to froce the alloction of a pf | 12:56 |
| gibi | sean-k-mooney: regarding macvtap, if this is done by the sriov agent then I can create an extra functional test in nova to see if the nova side works | 12:58 |
| sean-k-mooney | yep its done basically identically to direct jsut the vnic_type will be macvtap | 12:59 |
| gibi | sean-k-mooney: yes | 12:59 |
| gibi | sean-k-mooney: I will add a functional test for it in a separate patch | 12:59 |
| sean-k-mooney | i basically jsut want to confrim that you dont have a hardcoded check for direct somewhere | 13:00 |
| sean-k-mooney | cool | 13:00 |
| gibi | sean-k-mooney: regarding allocating a full pf for vnic_type=direct. When does that happen? | 13:00 |
| sean-k-mooney | it happens if the pf does not have any vfs | 13:00 |
| sean-k-mooney | of if the admin whitelist pf and never allocates vfs then vnic_type=direct is allowed to used them | 13:01 |
| sean-k-mooney | it was how you did pf passthough before we added direct_physical | 13:01 |
| *** mchlumsky has joined #openstack-nova | 13:01 | |
| sean-k-mooney | i can double check if we prevented that when we added direct_physical but i doubt it as it would have been a breaking api change | 13:01 |
| gibi | sean-k-mooney: OK. in this case the first boot will get the whole PF, and the second such boot will fail the pci claim as there is no pci device left | 13:02 |
| sean-k-mooney | yep | 13:02 |
| sean-k-mooney | so it wont break anything but it would be nice to tell placment that the rest of the inventory is reserved/unsuable | 13:03 |
| gibi | sean-k-mooney: so the problem is that placement doesn't track PF inventory to signal that the PF is consumed | 13:03 |
| *** phasespace has quit IRC | 13:03 | |
| sean-k-mooney | basically yes | 13:03 |
| *** panda|ruck|flu is now known as panda|ruck|lunch | 13:03 | |
| sean-k-mooney | ideally we would be asing for two things. 1 pf/vf resouce + x bandwith | 13:03 |
| sean-k-mooney | since we dont track PFs/VFs in placment yet we only ask for the bandwith | 13:04 |
| gibi | sean-k-mooney: OK. as far as I understand the admin needs to configur such PF specially (whitelsit the PF but not the VFs) so we can also ask the admin not to configure bandwidth for that PF as that PF will be consumed in a single piece | 13:04 |
| sean-k-mooney | so this will get fix in train hopefully | 13:04 |
| sean-k-mooney | ya they have to expclity whitelist the pf and that would be resonable intally at least | 13:05 |
| gibi | sean-k-mooney: It will be fun moving the VF inventory to placement | 13:05 |
| gibi | sean-k-mooney: OK then we will handle this case in the documentation for Stein | 13:05 |
| sean-k-mooney | the downside is we wont be able to sue the min bandwith request to select pf with at least X bandwith | 13:05 |
| artom | ~o~ | 13:05 |
| sean-k-mooney | e.g. ask for a 10G pf vs a 1G or 40G or 100G pf | 13:06 |
| sean-k-mooney | gibi: and yes moving vfs/pfs to placement will be "fun" | 13:06 |
| gibi | sean-k-mooney: yeah in a mixed environment it will be a limitation | 13:07 |
| sean-k-mooney | its not somthing they could do before so i think its fine | 13:07 |
| gibi | yeah I feel the same | 13:08 |
| sean-k-mooney | it would just be a nice bonus if we could enable that usecase in the future | 13:08 |
| sean-k-mooney | but to do that we need to get a few other things in place | 13:08 |
| mdbooth | lyarwood: You there? Still looking at your cinder tempest failure. | 13:08 |
| mdbooth | It's pretty weird. Have you had any insight? | 13:09 |
| gibi | sean-k-mooney: totally agree | 13:09 |
| sean-k-mooney | anyway i responded to your replys on patchset 39 and im now going through patchset 40 but honestly i think future change can likely be done in followup patches as part fo train. | 13:10 |
| gibi | sean-k-mooney: and now I've responded in your responses in PS 39 :) | 13:13 |
| *** janki has joined #openstack-nova | 13:17 | |
| *** sdake has joined #openstack-nova | 13:19 | |
| lyarwood | mdbooth: no, are you looking at the latest failures? | 13:19 |
| lyarwood | mdbooth: I was waiting for CI to report back before taking another look | 13:19 |
| mdbooth | lyarwood: I've been looking into the failures from yesterday or the day before? | 13:20 |
| mdbooth | I'm currently suspecting a cinder race, tbh. | 13:21 |
| mdbooth | Rather than a tempest race, that is. | 13:21 |
| *** markvoelker has quit IRC | 13:21 | |
| lyarwood | mdbooth: ack, I updated both changes this morning and they appear to be failing in the check queue. Once they report back I'll take a look to see if it's the same issue. | 13:23 |
| mdbooth | lyarwood: I'll have a look at the new ones. I know what I'm looking for, now. | 13:26 |
| mdbooth | lyarwood: In the one I've been looking into, we can see in both the tempest and c-api logs that cinder returns a 404 for the volume, then fails to delete the type because it still has a volume. | 13:27 |
| mdbooth | I couldn't see any other volume in the logs, so my guess is that the cinder REST api is returning a 404 before updating whatever triggers the failure to delete the type. | 13:28 |
| sean-k-mooney | gibi: oh i didnt know rodolfo had revied the minium bandwith work for ovs. it was merged in the past and then reverted as we found edgecase that did not work. i guess he has figured out how to work aroudn them good to know | 13:29 |
| mdbooth | We can see in the c-vol logs that the volume deletion actually completes *after* the type deletion starts, so c-api is returning a 404 *before* the deletion completes. | 13:29 |
| bauzas | gibi: ack, will review it later | 13:29 |
| *** _alastor_ has joined #openstack-nova | 13:30 | |
| *** dtantsur is now known as dtantsur|brb | 13:31 | |
| gibi | sean-k-mooney: yeah it is good that rodolfo managed to do that | 13:34 |
| gibi | bauzas: thanks | 13:34 |
| *** _alastor_ has quit IRC | 13:35 | |
| *** masber has quit IRC | 13:35 | |
| sean-k-mooney | it looks like tunneled netowrk support is still pendign but that was one of the things that did not work last time that ended up with the feature beign reverted | 13:35 |
| sean-k-mooney | anyway having it work for flat and vlan networks i still a good step forward | 13:36 |
| *** oanson has joined #openstack-nova | 13:36 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | 13:38 |
| *** ivve has joined #openstack-nova | 13:38 | |
| *** marst has joined #openstack-nova | 13:38 | |
| mdbooth | lyarwood: It has failed again. Investigating. | 13:40 |
| *** priteau has quit IRC | 13:41 | |
| *** sapd1 has joined #openstack-nova | 13:43 | |
| *** dpawlik has quit IRC | 13:43 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use Selection object to fill request group mapping https://review.openstack.org/638711 | 13:43 |
| lyarwood | mdbooth: ack thanks | 13:43 |
| mdbooth | It seems to be the py3 version which fails | 13:47 |
| *** sapd1 has quit IRC | 13:47 | |
| *** panda|ruck|lunch is now known as panda|ruck|flu | 13:50 | |
| *** mchlumsky has quit IRC | 13:51 | |
| *** mchlumsky has joined #openstack-nova | 13:53 | |
| *** priteau has joined #openstack-nova | 13:53 | |
| *** ratailor has joined #openstack-nova | 13:56 | |
| *** marst has quit IRC | 13:56 | |
| *** mmethot has joined #openstack-nova | 14:05 | |
| *** lbragstad has joined #openstack-nova | 14:06 | |
| cdent | mriedem: the openstack-dev archives are still there, but not longer reachable by the usual paths: http://lists.openstack.org/pipermail/openstack-dev/ | 14:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle templated cell mappings in nova-status https://review.openstack.org/641021 | 14:10 |
| mriedem | lyarwood: try throwing that as a dependency in your tripleo change ^; dansmith fyi ^ | 14:10 |
| mriedem | cdent: google failed me | 14:10 |
| cdent | aye, it often does | 14:10 |
| *** sdake has quit IRC | 14:11 | |
| *** janki has quit IRC | 14:12 | |
| *** janki has joined #openstack-nova | 14:12 | |
| lyarwood | mriedem: ack thanks | 14:13 |
| *** dklyle has joined #openstack-nova | 14:13 | |
| *** dpawlik has joined #openstack-nova | 14:13 | |
| yonglihe | mriedem: what can i do for https://review.openstack.org/#/c/621476/39 | 14:18 |
| *** sapd1 has joined #openstack-nova | 14:18 | |
| *** markvoelker has joined #openstack-nova | 14:18 | |
| *** sdake has joined #openstack-nova | 14:21 | |
| *** ttsiouts has quit IRC | 14:21 | |
| *** ttsiouts has joined #openstack-nova | 14:22 | |
| *** sdake has quit IRC | 14:23 | |
| *** ttsiouts has quit IRC | 14:25 | |
| *** ttsiouts has joined #openstack-nova | 14:25 | |
| dansmith | mriedem: ah, dangit | 14:27 |
| openstackgerrit | Tim Rozet proposed openstack/nova stable/rocky: Fixes race condition with privsep utime https://review.openstack.org/641023 | 14:27 |
| *** marst has joined #openstack-nova | 14:29 | |
| HD|Laptop | hey | 14:29 |
| HD|Laptop | yesterday I asked if it was possible for nova to use cinder as backing storage for images/instances... now I had an idea | 14:29 |
| HD|Laptop | can I just go ahead and mount /var/lib/nova/instances as a NFS directory? | 14:29 |
| HD|Laptop | that would serve the same purpose | 14:30 |
| HD|Laptop | even better would be if I could share instances/_base, but I guess that this could lead to locking issues if e.g. two compute nodes try to convert the same vmdk image to qcow2? | 14:30 |
| openstackgerrit | Merged openstack/nova master: libvirt: Omit needless check on 'CONF.serial_console' https://review.openstack.org/637578 | 14:30 |
| *** sdake has joined #openstack-nova | 14:35 | |
| mriedem | HD|Laptop: yes you can put the instances_path config on shared storage, many people do | 14:39 |
| mriedem | note that has it's own perils, like https://review.openstack.org/641023 | 14:39 |
| mriedem | and https://review.openstack.org/#/c/633042/ | 14:39 |
| mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#workarounds.ensure_libvirt_rbd_instance_dir_cleanup | 14:40 |
| *** dtantsur|brb is now known as dtantsur | 14:40 | |
| efried | mriedem: Review the "stop using PlacementDirect" changes with whitespace ignores on in gerrit | 14:40 |
| efried | mriedem, cdent, sean-k-mooney: but let me rebase it first... | 14:41 |
| mriedem | what if i don't want to? | 14:41 |
| efried | mriedem: Then it's a bigger review that will make you sad | 14:41 |
| efried | oh, what if you don't want to wait until I've rebased? Sure, then you can +2 it now, I don't mind. | 14:42 |
| mriedem | strike 2 | 14:42 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Stop using PlacementDirect https://review.openstack.org/640887 | 14:45 |
| efried | cdent, mriedem, sean-k-mooney: ^ | 14:45 |
| cdent | one moment please caller | 14:46 |
| HD|Laptop | mriedem: thanks. I'll just give every instance its own nfs base directory then, that should keep me safe from that shit | 14:46 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Stop using PlacementDirect https://review.openstack.org/640887 | 14:46 |
| efried | ^ fix whitespace | 14:47 |
| *** hongbin has joined #openstack-nova | 14:47 | |
| *** sdake has quit IRC | 14:48 | |
| efried | cdent, sean-k-mooney: for a change, the 1..3 diff is actually empty, because the patch removes the whole class that was conflicting. | 14:48 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 14:49 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 14:49 |
| gibi | bauzas: I've fixed up your comments ^^ | 14:49 |
| sean-k-mooney | efried: right cdent change modified one line in schdulerReportClientTEstBase and you are deleteing it out right | 14:50 |
| *** sdake has joined #openstack-nova | 14:50 | |
| *** markvoelker has quit IRC | 14:52 | |
| cdent | efried: other than me continuing to think it is keen and worth doing soon than later, you after anything in particular? | 14:52 |
| efried | sean-k-mooney: three or four lines, but yeah. | 14:52 |
| efried | cdent: no, just letting you know it needed a rebase and that's done now. I agree there's no reason to wait for Train. And I don't want reviewers intimidated by it because it's really like a 20LOC change. | 14:53 |
| * cdent nods | 14:53 | |
| gibi | stephenfin: you were +2 before on https://review.openstack.org/623543 bauzas put +2 on the previous PS. Can you meet on PS 41 and combine your votes? :) | 14:53 |
| cdent | efried: I suppose if you wanted to make it really obvious you could do it in two steps: extracted the indented chunks to their own methods in 1, remove placement direct in 2, but personally I think that's overkill, the diff is readable enough as is | 14:54 |
| bauzas | gibi: I was about +2ing it | 14:55 |
| efried | cdent: Yeah, when I was developing the change, I started off by creating a null _interceptor context manager. I didn't want to go to the effort of removing and outdenting if I wasn't going to be able to get it to work. | 14:55 |
| lyarwood | mriedem: your nova-status cell_mappings change works on a local env btw | 14:56 |
| lyarwood | mriedem: thanks for turning that around so quickly! | 14:57 |
| mriedem | anything for you lee | 14:57 |
| *** pcaruana has quit IRC | 14:57 | |
| *** awaugama has joined #openstack-nova | 14:58 | |
| *** munimeha1 has joined #openstack-nova | 14:59 | |
| *** awalende has quit IRC | 14:59 | |
| *** ratailor has quit IRC | 15:00 | |
| *** awalende has joined #openstack-nova | 15:00 | |
| *** cfriesen has joined #openstack-nova | 15:01 | |
| *** Luzi has quit IRC | 15:02 | |
| *** tbachman has joined #openstack-nova | 15:02 | |
| gibi | bauzas: thanks a lot | 15:03 |
| *** awaugama has quit IRC | 15:03 | |
| *** ccamacho has joined #openstack-nova | 15:03 | |
| *** awalende has quit IRC | 15:04 | |
| *** sdake has quit IRC | 15:04 | |
| *** tbachman_ has joined #openstack-nova | 15:05 | |
| mriedem | mdbooth: fyi that https://review.openstack.org/#/c/625741/ just merged on master | 15:06 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | 15:06 |
| *** tbachman has quit IRC | 15:07 | |
| *** tbachman_ is now known as tbachman | 15:07 | |
| mdbooth | mriedem: Oh, dear. | 15:07 |
| mdbooth | mriedem: Didn't spot that was a backport. | 15:07 |
| *** sdake has joined #openstack-nova | 15:07 | |
| sean-k-mooney | efried: i assume you rebased the patch due to a merge confilt with cdents patch? | 15:07 |
| efried | sean-k-mooney: yes | 15:07 |
| mdbooth | mriedem: Lemme read the review comments on there, perhaps my concern was already addressed. | 15:07 |
| mriedem | mdbooth: i doubt it, no one thinks of the image cache besides you :) | 15:08 |
| sean-k-mooney | ok just +1'd it again i havent used it locally but it makes sense to me | 15:08 |
| mdbooth | mriedem: Hmm. I'd consider reverting that, tbh. | 15:09 |
| *** eharney has joined #openstack-nova | 15:09 | |
| mdbooth | mriedem: The other solution proposed was much more targetted and presumably also works around the same issue. | 15:10 |
| mdbooth | I'd rather fail than risk leaving an empty file in the image cache. | 15:11 |
| mdbooth | The former you can just retry. | 15:11 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle placement error during re-schedule https://review.openstack.org/639608 | 15:11 |
| mriedem | mdbooth: are you talking about this? https://review.openstack.org/#/c/633493/2 | 15:12 |
| sean-k-mooney | any objections to me repoposing the numa and sriov migration specs for train. i think we should be ablt to wrap those up by train m1 so im hoping we can just fast appove the stien specs again? | 15:12 |
| *** dpawlik has quit IRC | 15:13 | |
| sean-k-mooney | there is 3 days to ff so they are not going to get reivewed betwen now and then anyway and that will give us plenty fo time to work on func tests for both | 15:13 |
| *** Aegil has joined #openstack-nova | 15:13 | |
| *** awaugama has joined #openstack-nova | 15:15 | |
| mriedem | sean-k-mooney: no one will object to reproposing specs to train for things that will not land in stein | 15:16 |
| mriedem | and no one is going to review those train specs for awhile either | 15:16 |
| sean-k-mooney | ya i just want to have them up before the ptg | 15:17 |
| sean-k-mooney | i know peopel are going to be focusing on getting RC1 ready for the next few weeks and finalising stien | 15:17 |
| sean-k-mooney | on that note im hoping we can land https://review.openstack.org/#/c/602432/ in stein/rc1 its not a change i think many would want to backport so i would like to close that bug in stien if we can | 15:18 |
| mdbooth | mriedem: Yeah | 15:20 |
| mdbooth | mriedem: Although obviously as you say you wouldn't fix that on a stable branch. | 15:21 |
| mriedem | gibi: random thought on the instance_has_port_with_resource_request check in the API - could we replace the neutron GET /ports call in there now with checking the instance info cache for any VIFs whose profile has the 'allocation' key? | 15:21 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Revert "Fixes race condition with privsep utime" https://review.openstack.org/641038 | 15:24 |
| mdbooth | mriedem: Proposed a revert ^^^ | 15:24 |
| *** sapd1 has quit IRC | 15:25 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | 15:25 |
| *** mlavalle has joined #openstack-nova | 15:25 | |
| mdbooth | Eurgh. | 15:25 |
| * mdbooth reformats that commit message. | 15:25 | |
| sean-k-mooney | mriedem: your suggesting modifying https://github.com/openstack/nova/blob/6516038dea5b80af2d83906a7e23f33e76061a42/nova/api/openstack/common.py#L571-L582 to check the instance info cache. | 15:26 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Revert "Fixes race condition with privsep utime" https://review.openstack.org/641038 | 15:27 |
| sean-k-mooney | assuming its only ever called after the info cache is populated then maybe. if not we might be able to make it condtional | 15:28 |
| *** tbachman has quit IRC | 15:28 | |
| *** openstackgerrit has quit IRC | 15:28 | |
| sean-k-mooney | e.g. if the instance is not in the info cache when this is called hit neutron otherwise us cache versions | 15:28 |
| mriedem | gibi: https://review.openstack.org/#/c/636360/ | 15:29 |
| gibi | mriedem: looking | 15:29 |
| sean-k-mooney | mriedem: it looks like its only called on move operations | 15:30 |
| mriedem | sean-k-mooney: correct | 15:30 |
| mriedem | so the cache should be there | 15:30 |
| mriedem | and ports would already be bound | 15:31 |
| sean-k-mooney | yep so i guess it might be safe to always used the cache values. | 15:31 |
| sean-k-mooney | we are just checkign if a port has allocation too not where they are from and since that should not change over the lifetime of a port it "should" not matter if the allcoation were stale for example because we justed moved. | 15:33 |
| sean-k-mooney | im ignoring that move wont work in stien | 15:33 |
| mriedem | bauzas: are you good with this now? https://review.openstack.org/#/c/509206/ | 15:33 |
| mriedem | you previously approved | 15:33 |
| mriedem | and then we had to fix something for tempest | 15:33 |
| mriedem | Sylvain Bauza Feb 18 5:34 AM Patch Set 10: Code-Review+2 Workflow+1 | 15:34 |
| sean-k-mooney | mriedem: could we have issue with unshelve? | 15:34 |
| mriedem | sean-k-mooney: yes, gdi | 15:34 |
| gibi | mriedem: is it safe to access the instance.info_cache from the API? | 15:34 |
| mriedem | gibi: yes | 15:34 |
| mriedem | gibi: the addresses portion of the server response is built from the cache | 15:34 |
| gibi | ohh, sean-k-mooney has a good point about shelve offloaded instances | 15:34 |
| mriedem | yes he does | 15:35 |
| mriedem | grumble | 15:35 |
| sean-k-mooney | gibi: in that case it would not be in the cache and we can fallback to hitting the api | 15:35 |
| sean-k-mooney | so check the cache if its there use it if not hit api | 15:35 |
| mriedem | sean-k-mooney: but then you're going to always hit the api because not all instances have these types of ports | 15:35 |
| mriedem | so... | 15:35 |
| mriedem | you'd have to condition based on the instance.vm_state, but anyway, let's not worry about this right now | 15:35 |
| *** openstackgerrit has joined #openstack-nova | 15:36 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova stable/queens: Test for plug_contrail_vif with utf8 VM name https://review.openstack.org/641048 | 15:36 |
| sean-k-mooney | ok there is a comment in the code to optimise this anyway so ya we can look at that in train | 15:36 |
| gibi | if in train we can implement the move operations then we can drop the whole check from the aPI | 15:37 |
| gibi | bah, not ture | 15:37 |
| gibi | true | 15:37 |
| mriedem | not true b/c older microversions need to fail right? | 15:37 |
| gibi | yeah | 15:37 |
| gibi | we need to support old microversions | 15:38 |
| gibi | but we have the microversion check in place | 15:38 |
| gibi | so on old microversions we can simply check the microversion not the port allocations | 15:38 |
| gibi | we only need the current check as the current 2.72 is not complete | 15:38 |
| gibi | (or we can go back to the discussion how many microversin we need for this feature) | 15:39 |
| sean-k-mooney | gibi well for old microverion you still need the check as we are only failing move operation if you have a port resouce request | 15:39 |
| mriedem | correct ^ | 15:39 |
| mriedem | just because 2.80 supports moving those types of servers doesn't mean that all of a sudden 2.1 does also | 15:40 |
| gibi | assume we merge the create support in 2.72. and the in Train we fix the move with a bugfix. then if the microversion < 2.72 then we have to check if the instance has ports with allocation | 15:41 |
| gibi | so yeah we cannot drop that check | 15:41 |
| gibi | that looks into the ports | 15:41 |
| gibi | but we can make it smarter by checking the vm state and the info_cache | 15:41 |
| sean-k-mooney | ya but we shoudl definetly be about to optimise it when we have more time | 15:42 |
| sean-k-mooney | *able to | 15:42 |
| *** pcaruana has joined #openstack-nova | 15:42 | |
| mriedem | did we agree to support moves without a new microversion? | 15:42 |
| * gibi making notes that will end up in a new spec / bp | 15:42 | |
| gibi | mriedem: no we haven't yet. | 15:43 |
| mriedem | ok | 15:43 |
| gibi | mriedem: we postponed that decision to Train | 15:43 |
| mriedem | we would at least need a minimum compute service version check | 15:43 |
| * gibi making notes that will end up in a new spec / bp about the remaining work | 15:43 | |
| sean-k-mooney | i think that is dansmith's perference e.g. non new micro | 15:43 |
| gibi | mriedem: is the compute version check due to the virt driver impact? | 15:43 |
| mriedem | gibi: the compute service is what unbinds and binds the ports and stuff right during a move | 15:44 |
| gibi | mriedem: ohh so we need a new compute on both end of the migration for bind/unbind | 15:45 |
| mriedem | so anything you'd need to add to compute in train to support migrations would require an ABI version bump | 15:45 |
| mriedem | correct | 15:45 |
| gibi | understood | 15:45 |
| *** Sundar has joined #openstack-nova | 15:45 | |
| sean-k-mooney | that would be a check in the conductor liek we do for the multiple port bindigns or like we will be doing for numa and sriov migration | 15:46 |
| sean-k-mooney | effectivly if both computes are not new enough reject the migration | 15:47 |
| gibi | sean-k-mooney: ack | 15:48 |
| *** markvoelker has joined #openstack-nova | 15:48 | |
| *** sdake has quit IRC | 15:49 | |
| mriedem | need another novaclient core to hit this https://review.openstack.org/#/c/640657/ | 15:50 |
| *** udesale has quit IRC | 15:50 | |
| mriedem | jaypipes: are you coming back on the libvirt reshaper change today? https://review.openstack.org/#/c/599208/ | 15:51 |
| jaypipes | mriedem: yes. it's on my screen right now. | 15:51 |
| *** zhubx has quit IRC | 15:55 | |
| *** zhubx has joined #openstack-nova | 15:56 | |
| cfriesen | mriedem: should I include the blueprint for the PciInvalidAlias commit, or leave it standalone? | 15:57 |
| *** xek has quit IRC | 15:59 | |
| mriedem | cfriesen: that's fixing a separate bug right? | 15:59 |
| *** xek has joined #openstack-nova | 15:59 | |
| gibi | mriedem: +Ad https://review.openstack.org/#/c/640657/ | 15:59 |
| mriedem | iow, handling PciInvalidAlias separately from the blueprint is so it could be backported right? | 15:59 |
| cfriesen | mriedem: yep | 15:59 |
| mriedem | cfriesen: if not, and it doesn't result in a 500 response today, then we don't need to backport it | 15:59 |
| *** belmoreira has quit IRC | 16:00 | |
| mriedem | cfriesen: btw are you sure that's not handled today? | 16:00 |
| mriedem | by this https://github.com/openstack/nova/blob/c43c1d3fb9da5dd0a13e1f15623a696212f095ff/nova/api/openstack/wsgi.py#L367 | 16:00 |
| *** tbachman has joined #openstack-nova | 16:00 | |
| mriedem | PciInvalidAlias extends Invalid | 16:00 |
| *** sdake has joined #openstack-nova | 16:01 | |
| mriedem | so that should return a 400 | 16:01 |
| cfriesen | yeah, was just trying to track that down | 16:01 |
| mriedem | if it is handled then i don't think we need anything separate | 16:02 |
| mriedem | https://review.openstack.org/#/c/620706/27/nova/api/openstack/compute/servers.py@a857 | 16:02 |
| cfriesen | so Fault will end up being HTTPBadRequest? | 16:02 |
| cfriesen | or I guess Fault(exception.ConvertedException( | 16:03 |
| mriedem | without any testing for it it's hard to say | 16:04 |
| mriedem | so we get that from get_pci_requests_from_flavor which is called today from _validate_and_build_base_options in the api on server create, | 16:05 |
| mriedem | i don't see any existing tests that handle the PciInvalidAlias if it's raised from there | 16:05 |
| mriedem | i suspect it is handled and converted to a 400 response | 16:05 |
| mriedem | but we don't have any testing for that | 16:06 |
| cfriesen | I'll try a test without specially adding it to the list | 16:06 |
| mriedem | unlike https://review.openstack.org/#/c/640841/2/nova/tests/unit/api/openstack/compute/test_serversV21.py | 16:06 |
| cfriesen | mriedem: looks like it fails: http://paste.openstack.org/show/747293/ | 16:10 |
| cfriesen | if I add PciInvalidAlias to the list in ServersController.create() , it passes | 16:11 |
| mriedem | i assume those tests aren't using https://github.com/openstack/nova/blob/c43c1d3fb9da5dd0a13e1f15623a696212f095ff/nova/api/openstack/wsgi.py#L367 | 16:11 |
| mriedem | those are hitting the handler directly | 16:12 |
| mriedem | whereas ^ wraps the handler | 16:12 |
| cfriesen | yeah, just realized that | 16:12 |
| cfriesen | okay, need to hack devstack then | 16:13 |
| mriedem | anywho, i think PciInvalidAlias is probably handled as a 400 and we're OK, and for completeness you could add it to that big ass list of exceptions for the validation stuff | 16:13 |
| cfriesen | works | 16:13 |
| mriedem | you got a 400 for an invalid alias in devstack? | 16:13 |
| cfriesen | haven't done it yet | 16:13 |
| mriedem | oh | 16:14 |
| cfriesen | I get: ERROR (ClientException): Unknown Error (HTTP 500) | 16:16 |
| mriedem | is there a stacktrace in the api logs? | 16:17 |
| cfriesen | whoops...typo. I had "faise" istead of "raise" | 16:18 |
| cfriesen | okay, for real this time I get this: http://paste.openstack.org/show/747294/ checking logs | 16:19 |
| cfriesen | here are the logs: http://paste.openstack.org/show/747295/ | 16:20 |
| cfriesen | adding the exception to the list makes it a 400 as expected | 16:21 |
| *** markvoelker has quit IRC | 16:22 | |
| cfriesen | report a bug or just put it in the git commit message? | 16:22 |
| gibi | mriedem: regarding https://review.openstack.org/#/c/636360/21/releasenotes/notes/support-neutron-ports-with-resource-request-cb9ad5e9757792d0.yaml@21 I think unshelving is possible after a simple shelve without offload. And that operation is supported with bandwith as that does not need a new scheduling | 16:27 |
| *** liuyulong is now known as liuyulong_zzz | 16:27 | |
| mriedem | efried: can we do an assertEqual(1, len(mdevs)) check in here instead? https://review.openstack.org/#/c/639854/4 | 16:29 |
| jaypipes | mriedem: off it goes. | 16:29 |
| efried | ... | 16:29 |
| mriedem | gibi: yeah true | 16:30 |
| jaypipes | wouldn't it be great if Nvidia developers actually participated in the community of people trying to enable their hardware? :( | 16:32 |
| efried | mriedem: responded | 16:33 |
| mriedem | efried: fwiw i also commented in bauzas's change that we should just do that mdev naming conversion from dashes to underscores in _get_mediated_device_information | 16:35 |
| mriedem | so callers, like the libvirt driver and your test, don't need to care about that conversion | 16:35 |
| mriedem | gah https://review.openstack.org/#/c/639647/ | 16:35 |
| *** imacdonn has quit IRC | 16:35 | |
| mriedem | i was going to -1 because there are other follow ups from this series i'd like to see | 16:35 |
| mriedem | i guess i'll do those | 16:35 |
| *** imacdonn has joined #openstack-nova | 16:36 | |
| *** mrch_ has quit IRC | 16:36 | |
| efried | mriedem: So do you want me to fix the test patch, or are you going to fup? | 16:36 |
| mriedem | i'm gonna fup all night long | 16:37 |
| efried | ight | 16:37 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Delete orphaned RS and IM records of archived instances https://review.openstack.org/560042 | 16:39 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 16:40 |
| gibi | mriedem: fixed your comments in ^^ | 16:40 |
| *** janki has quit IRC | 16:41 | |
| *** luksky has quit IRC | 16:41 | |
| sean-k-mooney | jaypipes: ya nvida and opensource is not really a thing... | 16:41 |
| *** janki has joined #openstack-nova | 16:41 | |
| sean-k-mooney | jaypipes: unless its there "opensouce" project | 16:41 |
| mriedem | melwitt: there is a lot of stuff in https://blueprints.launchpad.net/nova/stein that is going to be deferred, do you want to just start moving stuff out now to make that page more clear? | 16:42 |
| mriedem | https://etherpad.openstack.org/p/nova-stein-blueprint-status is getting to be kind of a mess | 16:43 |
| mriedem | so would be nice if the bp pages in lp was cleaned up, or https://etherpad.openstack.org/p/nova-stein-blueprint-status was cleaned up to remove stuff that's either done or not going to make it | 16:43 |
| melwitt | mriedem: yeah :( I can try | 16:43 |
| mriedem | well if you're working on the counting stuff that's probably higher priority | 16:44 |
| *** helenfm has quit IRC | 16:45 | |
| *** tssurya has quit IRC | 16:45 | |
| melwitt | dansmith: I updated the user_id patch last night to remove the loading stuff, fyi. from your comment it sounds like the only thing missing is to do a log message in case someone tries to load an unset user_id | 16:46 |
| sean-k-mooney | am should we just add another heading for defered stuff at the bottom. | 16:46 |
| melwitt | mriedem: oh, sorry I misunderstood "do you want to ...". yeah, I think that is fine | 16:46 |
| bauzas | mriedem: sorry, missed your comments on the naming thing | 16:46 |
| bauzas | and I was off here for an hour | 16:47 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Handle missing exception in instance creation code https://review.openstack.org/641082 | 16:51 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 16:53 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 16:53 |
| *** psachin has quit IRC | 16:54 | |
| cfriesen | mriedem: fix for PciInvalidAlias issue. I reported a bug for it too. | 16:54 |
| mriedem | cfriesen: but you got a 500 for that in the api with devstack? | 16:54 |
| cfriesen | mriedem: yes, see above | 16:55 |
| *** ccamacho has quit IRC | 16:55 | |
| cfriesen | here are the logs: http://paste.openstack.org/show/747295/ | 16:55 |
| cfriesen | CLI output is in the bug: https://bugs.launchpad.net/nova/+bug/1818701 | 16:56 |
| openstack | Launchpad bug 1818701 in OpenStack Compute (nova) "invalid PCI alias in flavor results in HTTP 500 on instance create" [Medium,In progress] - Assigned to Chris Friesen (cbf123) | 16:56 |
| *** mrch_ has joined #openstack-nova | 16:58 | |
| mriedem | cfriesen: ok just robustify the test and i'm +2 | 16:58 |
| *** ivve has quit IRC | 16:58 | |
| *** macza has joined #openstack-nova | 16:58 | |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec https://review.openstack.org/570201 | 17:00 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0 https://review.openstack.org/570203 | 17:00 |
| *** wolverineav has joined #openstack-nova | 17:00 | |
| mriedem | gibi: can we mark this complete? https://blueprints.launchpad.net/nova/+spec/use-nested-allocation-candidates | 17:01 |
| gibi | mriedem: there is one intentionally open patch https://review.openstack.org/#/c/608298/ | 17:02 |
| gibi | mriedem: it is an edge case that we don't need in nova right now | 17:02 |
| mriedem | "This cannot happen today but will in the future, when cpu and memory resource are moved to the NUMA RP and servers" | 17:02 |
| gibi | mriedem: exactly | 17:02 |
| mriedem | correct, so i'd just say it becomes a part of those bps when they happen | 17:02 |
| gibi | mriedem: OK. I agree. Let's mark the bp completed | 17:03 |
| *** macza_ has joined #openstack-nova | 17:04 | |
| mriedem | done | 17:04 |
| *** wolverineav has quit IRC | 17:04 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Handle missing exception in instance creation code https://review.openstack.org/641082 | 17:04 |
| cfriesen | mriedem: I also robustified the other PCI test | 17:05 |
| mriedem | oh my | 17:05 |
| mriedem | that's a -5 | 17:05 |
| mriedem | i hope you ran fast8 | 17:05 |
| mriedem | but +2 | 17:05 |
| cfriesen | I can break out the other test as a separate commit if you want... | 17:06 |
| mriedem | i'm just joking | 17:06 |
| mriedem | -5 is a joke unless we're talking about forced cold migration | 17:06 |
| *** macza has quit IRC | 17:08 | |
| *** xek_ has joined #openstack-nova | 17:10 | |
| -openstackstatus- NOTICE: Gerrit is being restarted for a configuration change, it will be briefly offline. | 17:11 | |
| sean-k-mooney | i tought forced migrations tradtional add a couple fo factorals added on like so -5!! | 17:11 |
| *** xek has quit IRC | 17:12 | |
| mriedem | -5?!?!??!! | 17:12 |
| mriedem | jazz it up however you want | 17:12 |
| melwitt | reshaper + func test is finally on its way to the sarlacc pits \o/ | 17:13 |
| dansmith | melwitt: oh, I saw the comment wasn't on the latest PS, but I hadn't gone back to see what had changed | 17:14 |
| *** jistr|sick is now known as jistr | 17:14 | |
| melwitt | dansmith: understood. just giving you the 411 | 17:15 |
| *** markvoelker has joined #openstack-nova | 17:19 | |
| *** ileixe has quit IRC | 17:20 | |
| mriedem | mdbooth: you might want to take a look at this https://review.openstack.org/#/c/613039/ | 17:21 |
| mriedem | if it has a chance of making stein | 17:21 |
| mriedem | it does have test coverage... https://review.openstack.org/#/c/623483/ | 17:21 |
| mdbooth | mriedem: ack, thanks | 17:21 |
| *** luksky has joined #openstack-nova | 17:23 | |
| *** panda|ruck|flu is now known as panda|ruck|off | 17:27 | |
| *** sridharg has quit IRC | 17:29 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't age swap files in the image cache https://review.openstack.org/641093 | 17:30 |
| *** itlinux has joined #openstack-nova | 17:35 | |
| mriedem | aspiers: correct me if i'm wrong, but up to https://review.openstack.org/#/c/638680/ we advertise that a compute will support sev but up to that point we don't actually configure anything in a guest that requires sev, right? | 17:35 |
| *** sdake has quit IRC | 17:35 | |
| *** artom has quit IRC | 17:35 | |
| mriedem | so if we were to merge that code in stein, we'd be saying "these computes support sev" but you can't actually schedule servers to them and get sev in the guest, yeah? | 17:36 |
| *** ttsiouts has quit IRC | 17:38 | |
| mriedem | i.e. something is yet to build on this https://review.openstack.org/#/c/636318/ | 17:38 |
| mriedem | all of this being done in parallel series makes it hard to track | 17:38 |
| dansmith | someone should +W this: https://review.openstack.org/#/c/641021/ | 17:41 |
| *** xek_ has quit IRC | 17:42 | |
| *** xek_ has joined #openstack-nova | 17:42 | |
| * mriedem breaks | 17:42 | |
| melwitt | you can't +W it bc it's your patch. I can look | 17:43 |
| *** tbachman has quit IRC | 17:44 | |
| bauzas | I can take a look if needed | 17:44 |
| bauzas | I still have 30 mins left | 17:44 |
| dansmith | it's easy, you all should be fighting over it | 17:44 |
| *** tbachman has joined #openstack-nova | 17:44 | |
| bauzas | I haven't followed the cross-cell resize series but looks like it's unrelated | 17:45 |
| bauzas | so I can chime in | 17:45 |
| cfriesen | philosophical question for people. if we resize to the same instance type, should we validate the extra-specs again in case they've been changed since we booted? I kind of think yes. | 17:46 |
| melwitt | bauzas: you can have it :) | 17:47 |
| dansmith | cfriesen: I think yes | 17:47 |
| sean-k-mooney | cfriesen: 1 yes 2 we proably should make exta-specs imunteable at some point once a flavor is in use | 17:47 |
| cfriesen | (or is that disallowed and only actually happens on migrations?) | 17:47 |
| bauzas | cfriesen: yes please | 17:48 |
| cfriesen | it's confusing, there's something related to cell types in here | 17:48 |
| melwitt | cfriesen: I think yes too | 17:48 |
| bauzas | cfriesen: the problem is that we put too many things in extra sepcs | 17:49 |
| sean-k-mooney | is there any reason we dont allow you to set extraspec when creating a flavor so we can make the whole thing readonly | 17:49 |
| bauzas | we should at least validate those specs before calling the scheduler | 17:49 |
| cfriesen | I'm looking at https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3541 which seems to indicate that you're not supposed to resize to the same flavor, but there's an exception for a "compute" cell type | 17:49 |
| sean-k-mooney | i guess maybe because resize is a cold migration? | 17:49 |
| openstackgerrit | Merged openstack/nova master: Stub out port binding create/delete in NeutronFixture https://review.openstack.org/636413 | 17:50 |
| mdbooth | lyarwood: Would you also be able to pontificate upon https://review.openstack.org/#/c/613039/ ? | 17:50 |
| *** agopi has joined #openstack-nova | 17:50 | |
| openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.71 - show server group https://review.openstack.org/640657 | 17:51 |
| mdbooth | lyarwood: FWIW I'll be +1 on that assuming the tests are good, but I don't have time to look now. | 17:51 |
| *** markvoelker has quit IRC | 17:51 | |
| *** marst has quit IRC | 17:51 | |
| cfriesen | sean-k-mooney: yeah, but the comments say that for migration "flavor_id" is None. | 17:52 |
| *** rpittau is now known as rpittau|afk | 17:52 | |
| sean-k-mooney | cfriesen: right well resize and colde migrate are the same thing in nova except resize change the flavor and migrate does not | 17:53 |
| stephenfin | gibi: Sorry for the delay. +2'd now :) | 17:53 |
| *** gyee has joined #openstack-nova | 17:54 | |
| cfriesen | sean-k-mooney: yeah, but there's some cells complication apparently: https://bugs.launchpad.net/nova/+bug/1243816 | 17:54 |
| openstack | Launchpad bug 1243816 in OpenStack Compute (nova) "migrate fails with cells" [Undecided,Fix released] - Assigned to Chris Behrens (cbehrens) | 17:54 |
| sean-k-mooney | cfriesen: so resize to the same flavor whould be expected to do the same thing as migrate however migrate uses the embeded fravor | 17:54 |
| sean-k-mooney | yes well for cells v1 the flavor may not have been the same or replicated across cell. cross cell resize for cellsv2 is something mriedem is working on currently | 17:55 |
| cfriesen | Looks like normally you cannot resize to the same flavor, so my concern is unfounded. | 18:00 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rework all things metadata'y https://review.openstack.org/640730 | 18:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Fix nits in remote console guide https://review.openstack.org/641098 | 18:01 |
| stephenfin | efried: You'd probably be interested in those come Friday ^ | 18:02 |
| efried | ack | 18:03 |
| efried | Friday because... after freeze? | 18:04 |
| *** agopi has quit IRC | 18:04 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Flavor extra spec and image properties validation from API https://review.openstack.org/620706 | 18:05 |
| *** artom has joined #openstack-nova | 18:20 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Improve libvirt image and snapshot handling https://review.openstack.org/616692 | 18:22 |
| cfriesen | any chance of getting some core eyes on this? ^ It's a host filesystem cache optimization patch, has a +1 from mdbooth. (And if you say it's simply not going into S then I'll shut up about it till next week.) | 18:22 |
| *** artom has quit IRC | 18:25 | |
| *** jamesdenton has quit IRC | 18:27 | |
| openstackgerrit | Merged openstack/nova master: libvirt: implement reshaper for vgpu https://review.openstack.org/599208 | 18:27 |
| openstackgerrit | Merged openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559 | 18:28 |
| openstackgerrit | Merged openstack/nova master: FUP: docs nit https://review.openstack.org/639647 | 18:28 |
| dansmith | cfriesen: you mean host buffer cache optimization yeah/ | 18:28 |
| *** jamesdenton has joined #openstack-nova | 18:29 | |
| dansmith | that looks like a nice win and might be why my toy all-in-one openstack at home completely destroys performance while taking snapshots | 18:29 |
| *** xek_ has quit IRC | 18:34 | |
| *** xek has joined #openstack-nova | 18:35 | |
| *** mriedem has quit IRC | 18:37 | |
| *** artom has joined #openstack-nova | 18:38 | |
| *** wolverineav has joined #openstack-nova | 18:38 | |
| *** artom has quit IRC | 18:39 | |
| *** mriedem has joined #openstack-nova | 18:39 | |
| *** artom has joined #openstack-nova | 18:39 | |
| melwitt | dansmith: if something tries to reference unset user_id field, "NotImplementedError: Cannot load 'user_id' in the base class" happens. do you think we need to log a message in addition to that? | 18:41 |
| *** itlinux has quit IRC | 18:42 | |
| dansmith | melwitt: I dunno, that ends up in a lot of places where we have an implementation error, so it's nice to log something about why (i.e. mappings haven't been migrated) but it's also a failing on our part, since it shouldn't be used anywhere anyway | 18:43 |
| dansmith | melwitt: so you decide I guess.. but exploding is the right thing regardless of the, uh, type of explosion It hink | 18:43 |
| melwitt | dansmith: ok, yeah, that makes sense. just log and reraise | 18:44 |
| *** IvensZambrano has quit IRC | 18:46 | |
| *** itlinux has joined #openstack-nova | 18:47 | |
| *** markvoelker has joined #openstack-nova | 18:48 | |
| *** Sundar has quit IRC | 18:53 | |
| mriedem | mdbooth: btw, i hope you've seen office space: https://photos.app.goo.gl/HgzGk3aR2yGHWMv69 | 18:54 |
| *** awaugama has quit IRC | 18:57 | |
| melwitt | lol | 19:04 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | 19:06 |
| melwitt | cfriesen: from the commit message, "so that cache option can be set properly". that makes it sound like it's a bug without that change. is it a bug or no? | 19:06 |
| mriedem | cfriesen: approved your validation change and i'm assuming you're still working on a patch to check get_pci_requests_from_flavor from resize? | 19:06 |
| dansmith | ah dangit, I was just going through that | 19:08 |
| dansmith | melwitt: it's a feature | 19:08 |
| melwitt | oh k | 19:09 |
| dansmith | melwitt: it's not a bug because it's not wrong, but setting the cache properly avoids trashing the host's page cache while doing it, improving performance for everything running while the snapshot is happening | 19:09 |
| melwitt | ah, thanks | 19:09 |
| cfriesen | melwitt: what he said. :) | 19:09 |
| dansmith | aside from the consistency gain of not calling the same external binary manually in multiple places | 19:09 |
| cfriesen | mriedem: yes, just working on tests | 19:10 |
| melwitt | ok, kewl | 19:10 |
| *** awaugama has joined #openstack-nova | 19:11 | |
| *** ivve has joined #openstack-nova | 19:12 | |
| efried | whoops, guess I should have been paying attention here before I +A'd that sucker. | 19:14 |
| melwitt | it's np | 19:16 |
| efried | okay, can pull it if necessary. | 19:16 |
| melwitt | nah, it's ok. looking at it further, it would take me longer to understand all the qemu-img stuff anyway | 19:17 |
| *** mdbooth_ has joined #openstack-nova | 19:21 | |
| *** markvoelker has quit IRC | 19:21 | |
| *** awaugama has quit IRC | 19:22 | |
| *** awaugama has joined #openstack-nova | 19:23 | |
| *** mdbooth has quit IRC | 19:24 | |
| artom | sean-k-mooney, around? I need your Neutron and/or os-vif expertise | 19:28 |
| *** ttsiouts has joined #openstack-nova | 19:31 | |
| *** dtantsur is now known as dtantsur|afk | 19:31 | |
| mriedem | efried: edmondsw: i'm assuming this is ok for powervm since the parameter is just ignored https://review.openstack.org/#/c/613039/4/nova/virt/powervm/driver.py | 19:32 |
| mriedem | maybe could help optimize something with powervm volume extend though | 19:32 |
| efried | mriedem: powervm oot will need to do the same, so thanks for alerting edmondsw | 19:32 |
| *** sdake has joined #openstack-nova | 19:33 | |
| efried | generally I like to see a ML post when we change things like the ComputeDriver interface, since OOT drivers will need to conform. | 19:33 |
| mriedem | ooo as will hyperv http://git.openstack.org/cgit/openstack/compute-hyperv/tree/compute_hyperv/nova/driver.py#n224 | 19:34 |
| efried | mriedem: but yeah, the change itself should be harmless. | 19:34 |
| efried | And I don't see how powervm could take advantage of it to help anything. | 19:37 |
| mriedem | yeah me neither | 19:39 |
| *** wolverineav has quit IRC | 19:41 | |
| artom | Is the "plug" verb overloaded in Neutron and os-vif? | 19:41 |
| artom | Looking at https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5653-L5656, I could be forgiven for thinking that our call to plug_vifs() is what causes the network-vif-plugged event to eventually reach | 19:42 |
| *** wolverineav has joined #openstack-nova | 19:42 | |
| artom | But that's incorrect... right? | 19:42 |
| artom | Way earlier we call Neutron via setup_networks_on_host(), and *that's* how we get the event | 19:42 |
| artom | Because Neutron plugs the port | 19:43 |
| *** wolverineav has quit IRC | 19:43 | |
| *** wolverineav has joined #openstack-nova | 19:43 | |
| artom | ... is that the distinction? Neutron plugs *ports* on the host (ie, sets up host networking) | 19:43 |
| artom | And then Nova plugs the *VIF* to whatever interface Neutron has made for us... | 19:44 |
| artom | ... except the event we get from Neutron is vif-plugged, not port-plugged | 19:45 |
| *** wolverineav has quit IRC | 19:45 | |
| *** wolverineav has joined #openstack-nova | 19:46 | |
| mriedem | i don't think that's accurate | 19:46 |
| mriedem | because we may or may not get a network-vif-plugged event during hard reboot where the port binding host doesn't change | 19:46 |
| *** wolverineav has quit IRC | 19:46 | |
| mriedem | but only certain networking backends in neutron will send the event in that case | 19:46 |
| *** wolverineav has joined #openstack-nova | 19:46 | |
| mriedem | it led to a whole messy situation with dealing with that and reboots for things like opendaylight | 19:46 |
| dansmith | artom: neutron sends us vif-plugged when it sees an appropriately-named interface show up on the system, | 19:47 |
| mriedem | lemme dig up a ghost for you | 19:47 |
| dansmith | which is usually because we have created it as part of starting a vm | 19:48 |
| mriedem | artom: have fun with this https://review.openstack.org/#/c/553035/ | 19:48 |
| dansmith | artom: there's also some plug terminology around hooking that interface up to a bridge | 19:48 |
| dansmith | and some around the work nova does to create an interface in the first place like during spawn | 19:48 |
| artom | dansmith, ok, that answers my "ulterior motive" questions, which was - can we wait for vif-plugged in the compute manager. The answer being: no. Because the VM needs to start. | 19:48 |
| aspiers | mriedem: Yes that's correct, there are more changes by my colleague breton which build on https://review.openstack.org/#/c/638680/ and modify the guest config to activate SEV functionality. Actually they aren't far from code complete but I think still need a bit of polish here and there. 2 or 3 are already in Gerrit and there are maybe 2 or 3 to come after that. | 19:48 |
| dansmith | artom: in the spawn case, that's correct | 19:49 |
| dansmith | artom: which is why we start the instance paused, wait for the interface to show up, neutron to notice, notify us, and then we unpause the guest | 19:49 |
| dansmith | artom: before, we would start the instance right away, and it might time out waiting for dhcp before all that happened | 19:49 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350 | 19:49 |
| openstackgerrit | melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | 19:49 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 19:49 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 19:49 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 19:49 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 19:49 |
| dansmith | which was the initial point of these events | 19:49 |
| artom | dansmith, hrmm, so I've understood the problem wrong then | 19:50 |
| aspiers | mriedem: We've been mostly pushing them in a linear sequence, but there has been a bit of parallelism on the base work not specific to SEV, to avoid superfluous dependencies slowing things down. | 19:50 |
| artom | It's not just that we're not listening for the event when it arrives | 19:50 |
| aspiers | mriedem: I'm more than happy to draw a dependency graph summarising all patches if that helps? | 19:51 |
| dansmith | artom: the initial problem was that some not-insignificant amount of time, we would start the instance (which created the vif) and the instance would be stillborn without networking, because it got to the OS part of the boot that waits for DHCP before neutron noticed, wired us up, setup dhcp for us etc | 19:51 |
| aspiers | I thought I'd seen launchpad doing that actually, but maybe that was just for dependencies between bps | 19:51 |
| artom | In case of spawn, we can't ever hit that situation because we start listening before we start the VM | 19:51 |
| dansmith | artom: in the boot case, we're definitely waiting at the right time, and that's why we don't have 10% DOA instances in the gate since like 2013 | 19:52 |
| dansmith | artom: exactlyu | 19:52 |
| artom | The problem arises in other cases, where the interface is already present on the host | 19:52 |
| dansmith | artom: right, which is because we've possibly blindly applied this to other cases like moves | 19:52 |
| artom | Took me 2 | 19:52 |
| dansmith | artom: which have similar issues, of course, but potentially different timing | 19:52 |
| artom | Took me 2 days, but I got there | 19:52 |
| artom | So it's not a blanket "let's start waiting before we poke Neutron" kinda of thing | 19:53 |
| artom | I need to take it case by case | 19:53 |
| artom | See when we poke Neutron, whether the interface is present when we do, and when do we start waiting | 19:54 |
| artom | Fuuun | 19:54 |
| dansmith | artom: that's why in the previous discussion, I was careful to say "before we do the thing that will trigger the event" | 19:54 |
| dansmith | which may or may not be talking to neutron (in fact, it usually isn't I think) | 19:54 |
| dansmith | and also why I said bringing the trigger under the umbrella context is the right thing, for whichever operations that isn't already the case | 19:54 |
| artom | dansmith, a very carefully worded non-specificity ;) | 19:55 |
| *** dave-mccowan has quit IRC | 19:55 | |
| *** itlinux has quit IRC | 19:56 | |
| artom | And apparently what Neutron does also depend on the VIF type? | 19:56 |
| dansmith | AFAIK, all of this depends on vif type | 19:57 |
| dansmith | which is why we don't wait for events for certain vif types | 19:57 |
| dansmith | and for certain vif types during certain operations, IIRC (i.e. move vs. spawn) | 19:57 |
| artom | Where's the code that decides that? | 19:58 |
| dansmith | there's _get_neutron_events() in libvirt driver, but that doesn't have the vif type filter I was thinking of | 19:59 |
| dansmith | oh, | 19:59 |
| dansmith | sahid wrote a patch that introduced one vif type filter that we reverted | 20:00 |
| artom | Yeah, I was looking at that | 20:00 |
| dansmith | so that's no longer in there | 20:00 |
| dansmith | there's one other place I remember, ahgn on | 20:00 |
| artom | Unless it's implicit in the 'ACTIVE' check | 20:00 |
| dansmith | hmm, I thought there was also a vif type filter in mriedem's more generic check for live migration, but I don't see it there either | 20:01 |
| *** dave-mccowan has joined #openstack-nova | 20:01 | |
| dansmith | so maybe I'm just thinking about that patch from sahid that we reverted | 20:01 |
| artom | And actually in libvirt _create_domain_and_network is the only time we call wait_for_instance_event | 20:01 |
| dansmith | ...in the libvirt driver, yes | 20:01 |
| artom | Ah, there's _get_neutron_events_for_live_migration in the compute manager | 20:03 |
| artom | No vif type filter though | 20:03 |
| *** xek has quit IRC | 20:03 | |
| *** xek has joined #openstack-nova | 20:03 | |
| dansmith | yeah, I really thought that one had a filter on it, maybe mriedem can comment when he sees this | 20:03 |
| dansmith | lemme dig up the sahid patch to prove there was one at least | 20:03 |
| mriedem | vif type == linuxbridge? | 20:04 |
| mriedem | vif type goes out the window because we can't rely on it | 20:04 |
| mriedem | ala https://review.openstack.org/#/c/553035/ | 20:04 |
| mriedem | opendaylight is ovs vif type but doesn't send network-vif-plugged on vif plugging, only port binding | 20:05 |
| mriedem | aspiers: no i don't need a graph of the code patches, | 20:05 |
| dansmith | artom: https://review.openstack.org/#/c/497457/30/nova/virt/libvirt/driver.py@5536 | 20:05 |
| mriedem | aspiers: the reason i was asking is because there doesn't seem to be a reason, to me, to land the sev discovery / exposing the capability from the host change (which jaypipes is +2 on) until we actually have code that can plumb the guest | 20:05 |
| dansmith | mriedem: ah, did we have a check for that before we had to remove because of ODL? | 20:05 |
| artom | dansmith, hrmm, why'd that get reverted out? | 20:06 |
| dansmith | artom: for so many reasons | 20:06 |
| dansmith | artom: amazingly broken :) | 20:06 |
| mriedem | artom: for one thing it was setting up the waiter *after* we'd plugged vifs on the dest | 20:06 |
| mriedem | and the waiter code was waiting on the source | 20:06 |
| mriedem | so a race and all that | 20:06 |
| artom | I was thinking more narrowly in terms of the VIF type logic | 20:06 |
| dansmith | artom: https://review.openstack.org/#/q/Ibf2b5eeafd962e93ae4ab6290015d58c33024132 | 20:07 |
| artom | IOW, is "Currently we only use the mechanism of waiting for neutron events during live-migration for linux-bridge" false? | 20:07 |
| dansmith | artom: it turned out that neutron was sending those events, this just excluded waiting for them because of other bugs.. papering over the real problem | 20:08 |
| dansmith | it's been a while, but there was a LOT of analysis and discussion | 20:08 |
| mriedem | artom: true that is false :) | 20:08 |
| aspiers | mriedem: well one reason is that we (SUSE) will need to carry our own downstream backport to Rocky, so the more which lands in Stein the easier it will get for us ... but if that is in conflict with upstream goals then of course I would entirely understand | 20:08 |
| mriedem | artom: https://docs.openstack.org/nova/latest/configuration/config.html#compute.live_migration_wait_for_vif_plug | 20:08 |
| *** itlinux has joined #openstack-nova | 20:08 | |
| mriedem | ^ we wait for networking events during live migration based on config | 20:08 |
| mriedem | since rocky | 20:09 |
| mriedem | and part of that was backported | 20:09 |
| mriedem | by mr smith | 20:09 |
| mriedem | aspiers: heh, sure - i just don't think we want the sev capability showing up automatically in stein on the compute node resource provider when there is really nothing you can do with it | 20:09 |
| *** dpawlik has joined #openstack-nova | 20:09 | |
| dansmith | ah right, artom, the Note:: in that doc explains why the vif_type thing isn't usable and why you have to config your way out of this for certain backends | 20:10 |
| dansmith | which sucsk | 20:10 |
| aspiers | mriedem: yeah, totally understood ... we were really hoping to get all the patches ready in time for stein but it looks like we just weren't quite quick enough | 20:10 |
| *** ttsiouts has quit IRC | 20:11 | |
| mriedem | aspiers: no problem, you got that capabilities patch landed which i'd abandoned essentially, which is pretty good for your first big contribution to nova | 20:11 |
| *** ttsiouts has joined #openstack-nova | 20:11 | |
| artom | dansmith, I get all of it except for "without an accompanying port binding:host_id" | 20:11 |
| mriedem | plus you had that acid trip of a venn diagram | 20:11 |
| mriedem | artom: that's what i was saying earlier, | 20:12 |
| dansmith | artom: ever get the feeling you stepped into a hornet's nest? | 20:12 |
| mriedem | ODL will only send network-vif-plugged for port binding changes to the host | 20:12 |
| *** eharney has quit IRC | 20:12 | |
| mriedem | if the host doesn't change on the port binding, but we plug/unplug vifs or whatever, ODL doesn't send the event | 20:12 |
| aspiers | mriedem: thanks :) feels good to be giving to upstream not just "taking" (i.e. asking for our own pet feature to be reviewed and merged) | 20:12 |
| mriedem | artom: hence why it had to be reverted from that hard reboot change | 20:12 |
| mriedem | this: https://review.openstack.org/#/c/553035/ | 20:13 |
| artom | dansmith, yes | 20:13 |
| aspiers | mriedem: haha, well my first version of that venn diagram was quite different, you can blame^Wthank efried for a lot of that second version | 20:13 |
| mriedem | linuxbridge also had some problems with that in the neutron lb job because something about polling for changes and it would miss them and not send the event | 20:13 |
| melwitt | I concur, thanks aspiers++ | 20:13 |
| artom | mriedem, ah, so the note is just worded poorly to say "ODL will only send us vif-plugged if the host has changed" | 20:13 |
| dansmith | mriedem: ah, yeah that's the thing I was expecting to find in there, forgot that had to be reverted too | 20:13 |
| aspiers | thanks melwitt :) | 20:13 |
| artom | ... which obviously it doesn't on hard reboot | 20:14 |
| mriedem | artom: it is worded perfectly | 20:14 |
| artom | Nuh uh, communication is only perfect if the thickest of idiots understand it. I didn't understand this. QED. | 20:14 |
| mriedem | of course the port binding host *does* change during live migration, | 20:14 |
| *** itlinux has quit IRC | 20:15 | |
| mriedem | but that happens after / during the guest transfer, not as a result of plug_vifs during pre_live_migration | 20:15 |
| mriedem | which is what that config is used for | 20:15 |
| *** ttsiouts has quit IRC | 20:15 | |
| mriedem | also, let me say, that i'm afraid sean-k-mooney might be dead or something because this entire conversation is the kind of thing he stays up until 3am for | 20:15 |
| artom | Seriously. | 20:16 |
| aspiers | LOL | 20:16 |
| artom | RIP sean I guess. We'll do a minute of silence i Denver. | 20:16 |
| *** dpawlik has quit IRC | 20:16 | |
| *** sdake has quit IRC | 20:17 | |
| artom | mriedem, wait, so why is that note even there? It's talking about not sending events when the host binding doesn't change. | 20:18 |
| artom | That doesn't apply to live migration... | 20:18 |
| jaypipes | mriedem: was I not supposed to +2 something? | 20:18 |
| *** markvoelker has joined #openstack-nova | 20:19 | |
| *** sdake has joined #openstack-nova | 20:19 | |
| aspiers | jaypipes: hopefully +2 is OK, W+1 might not have been though :) | 20:20 |
| artom | So, I think I should ignore the whole Neutron backend thing for now. It's out of scope, and I shouldn't introduce new bugs by ignoring it because it's currently ignored anyways. We can continue to wait for events in the same situations as currently, we just need to change the timing of the waits. | 20:21 |
| *** whoami-rajat has quit IRC | 20:22 | |
| melwitt | poor wording, that reminds me, I was supposed to update the consoleauth reno (or was it nova-status?) yet again to make more sense. I need to find IRC log from that convo with imacdonn | 20:23 |
| *** igordc has joined #openstack-nova | 20:28 | |
| imacdonn | melwitt: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-02-20.log.html#t2019-02-20T18:46:52 | 20:29 |
| *** ralonsoh has quit IRC | 20:29 | |
| edmondsw | mriedem yeah, I agree with you and efried. Should be fine, except that we do need to go update the OOT driver as well, so the heads up is definitely appreciated. | 20:29 |
| melwitt | imacdonn: thanks, you're awesome | 20:30 |
| imacdonn | :) | 20:30 |
| *** awaugama has quit IRC | 20:30 | |
| *** wolverineav has quit IRC | 20:31 | |
| mriedem | artom: ... | 20:32 |
| mriedem | artom: it's saying where this config is used, might not make sense for all networking backends (ODL), | 20:32 |
| *** ttsiouts has joined #openstack-nova | 20:32 | |
| mriedem | because the config is only for vif plugging, not port binding host changes, | 20:32 |
| *** wolverineav has joined #openstack-nova | 20:32 | |
| mriedem | ODL doesn't send events for the former, but does for the latter, | 20:32 |
| mriedem | but the latter is not where that config is used | 20:32 |
| mriedem | port binding happens during/after the guest transfer, | 20:32 |
| mriedem | we're waiting for the event before starting the guest transfer | 20:32 |
| mriedem | because if the dest plug fails or something, we don't want to start transferring the guest | 20:33 |
| mriedem | dansmith: check my comments on takashin's fix here https://review.openstack.org/#/c/636271/ - should i just not care about a functional test for live migration or stack it up on top myself if i care? | 20:33 |
| mriedem | i'm probably reaching | 20:34 |
| mriedem | jaypipes: see my comment on https://review.openstack.org/#/c/638680/ | 20:34 |
| dansmith | mriedem: I dunno, the real change is in that object loader, which seems pretty well covered by two operations, so .. seemed like enough to me | 20:35 |
| artom | mriedem, ah, got it, I think. Sorry, am slow. | 20:35 |
| dansmith | I pulled it down and poked at it too, both fail in the expected way... | 20:35 |
| mriedem | dansmith: yeah ok, i just don't like being told it's not an issue for live migration :) | 20:35 |
| dansmith | well, I don't think stacking one on top is a problem if it makes you feel better | 20:36 |
| mriedem | it won't fill the hole inside | 20:36 |
| dansmith | hah | 20:36 |
| artom | mriedem, oh, ODL *doesn't* send events for binding host changes | 20:36 |
| *** wolverineav has quit IRC | 20:37 | |
| mriedem | WRONG | 20:37 |
| artom | DAMMIT | 20:37 |
| mriedem | it *only* sends events in that case | 20:37 |
| dansmith | ARGH | 20:37 |
| artom | That note is damn confusing, I'm not backing down from that >_< | 20:37 |
| mriedem | is it time for a truth table in that config option note? | 20:38 |
| mriedem | if x and y but not z = False?! | 20:38 |
| artom | ... | 20:38 |
| artom | OK, sorry, it's fine. | 20:39 |
| artom | I misread mriedem's line here. | 20:39 |
| artom | I mean, mostly fine, it could be worded better. | 20:39 |
| dansmith | but, the note is for an operator, | 20:40 |
| dansmith | and all they need to know is ODL is not okay | 20:41 |
| dansmith | it's not meant to explain the inner workings of both services, like you want it to, right? | 20:41 |
| artom | Yeah | 20:41 |
| artom | I just think explicitly saying what "OK" (or "will not currently work") would have been better | 20:41 |
| artom | I need to be off anyways | 20:42 |
| openstackgerrit | Merged openstack/nova master: Fix an error when generating a host ID https://review.openstack.org/639936 | 20:42 |
| mriedem | for those that *need* to know the inner details, the bug report is linked | 20:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855 | 20:44 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855 | 20:46 |
| *** cdent has quit IRC | 20:51 | |
| *** markvoelker has quit IRC | 20:52 | |
| sean-k-mooney | mriedem: :) i was having dinner but i see ye were dicussing how odl breaks all the things when it comes to vif-plugged events | 20:55 |
| sean-k-mooney | artom: by the way i straed on https://review.openstack.org/#/c/635083/ to recored which ml2 driver bound a port so we can use it in nova for thing and i intend to add another feature that report when each ml2 driver sends events. e.g. on portbinding vs when the backend wires it up | 20:57 |
| *** wolverineav has joined #openstack-nova | 21:02 | |
| *** eharney has joined #openstack-nova | 21:03 | |
| mriedem | easy bug fix here https://review.openstack.org/#/c/638821/ | 21:04 |
| sean-k-mooney | artom: what im hpoing we can do in train is take all the guess work out of when the event will be sent and have neutron tell us but i need to bring this up with the neutron folks and work with them to create a spec. | 21:04 |
| *** artom has quit IRC | 21:08 | |
| sean-k-mooney | i know we made the DriverBlockDevice inherit from dict to make tanstioning to it simpler but at some point it would be better to bit the bullet and just make it a reall nova object/ovo | 21:08 |
| *** pcaruana has quit IRC | 21:10 | |
| *** wolverineav has quit IRC | 21:11 | |
| *** wolverineav has joined #openstack-nova | 21:29 | |
| *** janki has quit IRC | 21:29 | |
| *** ivve has quit IRC | 21:44 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Validate PCI aliases early in resize https://review.openstack.org/641131 | 21:45 |
| cfriesen | mriedem: ^ | 21:45 |
| *** rchurch_ has joined #openstack-nova | 21:45 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.openstack.org/638680 | 21:46 |
| *** xek has quit IRC | 21:46 | |
| *** rchurch has quit IRC | 21:47 | |
| *** wolverineav has quit IRC | 21:47 | |
| *** wolverineav has joined #openstack-nova | 21:48 | |
| *** markvoelker has joined #openstack-nova | 21:49 | |
| mriedem | cfriesen: comments inline | 21:49 |
| *** mchlumsky has quit IRC | 21:50 | |
| cfriesen | mriedem: wasn't sure whether to copy the other docstring or refer to it. :) | 21:50 |
| cfriesen | will update based on other comments...do you think I should test that pci is not validated by default? | 21:51 |
| mriedem | well, if you changed validate_pci=True, i'm guessing some existing tests for create/rebuild would fail b/c they haven't mocked something out? | 21:51 |
| mriedem | if so, then you probably don't need an explicit test for that | 21:52 |
| cfriesen | works | 21:52 |
| *** wolverineav has quit IRC | 21:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: De-cruftify the finish_resize methods https://review.openstack.org/635349 | 21:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete the obj_as_admin context manager https://review.openstack.org/635351 | 21:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: neutron: make migrate_instance_finish call setup_instance_network_on_host https://review.openstack.org/635343 | 21:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Temporarily mutate migration object in finish_revert_resize https://review.openstack.org/641137 | 21:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use errors_out_migration decorator on finish_resize https://review.openstack.org/641138 | 21:59 |
| *** priteau has quit IRC | 22:01 | |
| mriedem | dansmith: you might want to gander at https://bugs.launchpad.net/nova/+bug/1818239 | 22:05 |
| openstack | Launchpad bug 1818239 in nova (Ubuntu) "scheduler: build failure high negative weighting" [High,Triaged] | 22:05 |
| *** wolverineav has joined #openstack-nova | 22:12 | |
| *** eharney has quit IRC | 22:14 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix WeighedHost logging regression https://review.openstack.org/641143 | 22:18 |
| mriedem | super easy regression fix that i've now seen in 2 reported bugs ^ | 22:18 |
| *** markvoelker has quit IRC | 22:22 | |
| *** mvkr has quit IRC | 22:25 | |
| *** erlon has quit IRC | 22:25 | |
| *** sdake has quit IRC | 22:28 | |
| mriedem | someone want to send the bw provider microversion change to it's watery grave? https://review.openstack.org/#/c/636360/ | 22:29 |
| *** sdake has joined #openstack-nova | 22:30 | |
| dansmith | mriedem: I think I give up | 22:30 |
| mriedem | on that build failure weigher? heh i know | 22:30 |
| mriedem | "this seems bad if you have build failures...." | 22:30 |
| mriedem | coreycb: maybe you and/or jamespage want to talk with us about bug 1818239 | 22:31 |
| openstack | bug 1818239 in nova (Ubuntu) "scheduler: build failure high negative weighting" [High,Triaged] https://launchpad.net/bugs/1818239 | 22:31 |
| dansmith | it also seems to assume that you can deploy with the completely standard config and expect everything to be fine, regardless of size or the bits of config you want to tweak | 22:31 |
| dansmith | totally cool with charms defaulting it off | 22:31 |
| *** sdake has joined #openstack-nova | 22:32 | |
| *** sdake has quit IRC | 22:32 | |
| dansmith | I tried to make the rationale for the default weight completely sane based on other default weighers and such | 22:32 |
| dansmith | but I dunno what else to do, other than engineer the periodic de-de-prioritizing in the compute manager we discussed | 22:32 |
| *** mmethot has quit IRC | 22:34 | |
| dansmith | the latter of course will demand some config option to allow tweaking the bleed rate | 22:35 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Validate PCI aliases early in resize https://review.openstack.org/641131 | 22:35 |
| mriedem | i tried to summarize https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1818239/comments/16 | 22:35 |
| openstack | Launchpad bug 1818239 in nova (Ubuntu) "scheduler: build failure high negative weighting" [High,Triaged] | 22:35 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move set_vf_interface_vlan to be with its only caller. https://review.openstack.org/624229 | 22:35 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move DHCP releasing to privsep. https://review.openstack.org/624230 | 22:35 |
| openstackgerrit | Michael Still proposed openstack/nova master: Convert additional IP management calls to privsep. https://review.openstack.org/624231 | 22:35 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move route management to privsep. https://review.openstack.org/624232 | 22:35 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move additional IP address management to privsep. https://review.openstack.org/624591 | 22:35 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592 | 22:35 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move arping to privsep. https://review.openstack.org/624593 | 22:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move cleaning conntrack to privsep. https://review.openstack.org/624594 | 22:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431 | 22:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move killing processes to privsep. https://review.openstack.org/635432 | 22:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move FP device creation and deletion to privsep. https://review.openstack.org/635433 | 22:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup the exec_ebtables code a little. https://review.openstack.org/635434 | 22:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435 | 22:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436 | 22:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508 | 22:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280 | 22:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281 | 22:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282 | 22:36 |
| dansmith | mriedem: ack thanks | 22:36 |
| *** sapd1 has joined #openstack-nova | 22:36 | |
| mriedem | no one puts mikal in a corner | 22:37 |
| *** sdake has joined #openstack-nova | 22:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Validate PCI aliases early in resize https://review.openstack.org/641131 | 22:39 |
| cfriesen | mriedem: gah...thanks for the fixup | 22:40 |
| *** sdake has quit IRC | 22:45 | |
| *** wolverineav has quit IRC | 22:47 | |
| *** sdake has joined #openstack-nova | 22:51 | |
| *** munimeha1 has quit IRC | 22:52 | |
| *** tkajinam has joined #openstack-nova | 22:54 | |
| efried | Do we allow backports of fixes to client libs, and corresponding requirements bumps in nova?? | 22:58 |
| mriedem | yes on the former, no on the latter | 22:59 |
| efried | swhat I thought, thanks. | 23:00 |
| efried | mriedem: fyi https://review.openstack.org/#/c/640879/2/nova/virt/ironic/client_wrapper.py@106 | 23:00 |
| efried | mriedem: I guess deployers wanting the bug fix can pull in the updated client lib version, even though it exceeds upper constraints for that release? | 23:01 |
| efried | or do we bump upper constraints for the release? /me confused. | 23:01 |
| mriedem | we can bump upper-constraints in stalbe | 23:02 |
| mriedem | *stalbe | 23:02 |
| mriedem | gah | 23:02 |
| mriedem | we don't bump lower-constraints | 23:02 |
| mriedem | because those could be frozen for people at GA | 23:02 |
| *** sdake has quit IRC | 23:02 | |
| efried | okay, got it. | 23:03 |
| mriedem | so yeah they can backport the ironicclient fix and release it with a patch version on stable | 23:03 |
| mriedem | but we can't depend on it with a requirements/lower-constraints update on stable | 23:03 |
| mriedem | if we can hack around it in a backportable way and then fix on master-only with a lower-constraints bump on ironicclient, then sure | 23:03 |
| efried | ack | 23:05 |
| *** igordc has quit IRC | 23:10 | |
| *** markvoelker has joined #openstack-nova | 23:19 | |
| *** wolverineav has joined #openstack-nova | 23:24 | |
| *** wolverineav has quit IRC | 23:30 | |
| *** sdake has joined #openstack-nova | 23:33 | |
| *** takashin has joined #openstack-nova | 23:35 | |
| *** derekh has quit IRC | 23:36 | |
| *** wolverineav has joined #openstack-nova | 23:38 | |
| *** tesseract has quit IRC | 23:42 | |
| *** markvoelker has quit IRC | 23:52 | |
| mriedem | WOO F TO THE HOO | 23:53 |
| mriedem | time to fix a multi-cell bug in our functional tests | 23:55 |
| openstackgerrit | Merged openstack/nova master: Parse <emulator> elements from virConnectGetCapabilities() https://review.openstack.org/640483 | 23:56 |
| eandersson | Anyone else having issues with soft-anti-affinity etc in Rocky? | 23:56 |
| eandersson | > Invalid input for field/attribute 0. Value: soft-anti-affinity. u'soft-anti-affinity' is not one of ['anti-affinity', 'affinity'] | 23:57 |
| eandersson | > openstack --os-compute-api-version 2.15 server group create anti-affinity-test --policy soft-anti-affinity | 23:57 |
| openstackgerrit | Merged openstack/nova master: Correct instance port binding for rebuilds https://review.openstack.org/603844 | 23:57 |
| eandersson | Tested both with openstack client and terraform | 23:57 |
| openstackgerrit | Merged openstack/nova master: Fix resetting non-persistent fields when saving obj https://review.openstack.org/636271 | 23:57 |
| mriedem | eandersson: that looks correct https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server-group.html#server-group-create | 23:58 |
| mriedem | which version of osc? | 23:58 |
| eandersson | 3.16.3 | 23:58 |
| eandersson | It was working before the upgrade with the same clients | 23:58 |
| mriedem | hmm, this is the last change to the server groups module in osc https://github.com/openstack/python-openstackclient/commit/d0917cd14b94ce13fd92237490efb5722761eda4#diff-f8f1dd5d07b16e47671071cb4fede85d | 23:59 |
| *** wolverineav has quit IRC | 23:59 | |
| eandersson | We havne't changed osc version | 23:59 |
| eandersson | just the nova version | 23:59 |
| eandersson | went to nova rocky | 23:59 |
| *** wolverineav has joined #openstack-nova | 23:59 | |
| eandersson | brb | 23:59 |
| mriedem | that error isn't from nova | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!