| *** luksky has quit IRC | 00:16 | |
| *** vishwanathj has joined #openstack-nova | 00:19 | |
| *** brinzhang has joined #openstack-nova | 00:23 | |
| *** jmlowe has joined #openstack-nova | 00:37 | |
| *** temka has quit IRC | 00:45 | |
| *** ileixe has joined #openstack-nova | 00:47 | |
| *** wolverineav has joined #openstack-nova | 00:55 | |
| *** wolverineav has quit IRC | 01:00 | |
| *** markvoelker has joined #openstack-nova | 01:02 | |
| *** sdake has joined #openstack-nova | 01:06 | |
| *** markvoelker has quit IRC | 01:07 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104 | 01:10 |
|---|---|---|
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106 | 01:10 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110 | 01:11 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113 | 01:11 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974 | 01:11 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311 | 01:11 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581 | 01:11 |
| *** mmethot has quit IRC | 01:27 | |
| *** lchabert has quit IRC | 01:42 | |
| *** sdake has quit IRC | 01:44 | |
| *** sdake has joined #openstack-nova | 01:50 | |
| *** lchabert has joined #openstack-nova | 01:51 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017 | 01:55 |
| *** wolverineav has joined #openstack-nova | 01:56 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018 | 01:56 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019 | 01:56 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020 | 01:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027 | 01:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031 | 01:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299 | 01:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344 | 01:58 |
| *** sdake has quit IRC | 01:59 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673 | 01:59 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676 | 01:59 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689 | 01:59 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709 | 02:00 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712 | 02:00 |
| *** wolverineav has quit IRC | 02:01 | |
| *** markvoelker has joined #openstack-nova | 02:03 | |
| *** sdake has joined #openstack-nova | 02:05 | |
| *** yedongcan has joined #openstack-nova | 02:05 | |
| *** markvoelker has quit IRC | 02:06 | |
| *** sdake has quit IRC | 02:08 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:31 | |
| *** Dinesh_Bhor has quit IRC | 02:31 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:34 | |
| *** vishwanathj has quit IRC | 02:35 | |
| *** chason has quit IRC | 02:36 | |
| *** chason has joined #openstack-nova | 02:38 | |
| *** sdake has joined #openstack-nova | 02:42 | |
| *** wolverineav has joined #openstack-nova | 02:42 | |
| *** sdake has quit IRC | 02:44 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Remove the string check of the flavor attribute 'swap' https://review.openstack.org/639012 | 02:44 |
| *** tbachman has joined #openstack-nova | 02:46 | |
| *** wolverineav has quit IRC | 02:50 | |
| *** sdake has joined #openstack-nova | 02:51 | |
| *** psachin has joined #openstack-nova | 02:52 | |
| *** vishwanathj has joined #openstack-nova | 02:55 | |
| *** wolverineav has joined #openstack-nova | 03:05 | |
| *** sridharg has joined #openstack-nova | 03:14 | |
| *** mlavalle has quit IRC | 03:14 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add descriptions of numbered resource classes and traits https://review.openstack.org/621494 | 03:23 |
| *** sdake has quit IRC | 03:24 | |
| *** sdake has joined #openstack-nova | 03:26 | |
| *** sdake has quit IRC | 03:41 | |
| *** wolverineav has quit IRC | 03:47 | |
| *** wolverineav has joined #openstack-nova | 03:48 | |
| *** janki has joined #openstack-nova | 03:52 | |
| *** vishwanathj has quit IRC | 03:52 | |
| *** wolverineav has quit IRC | 04:14 | |
| *** marst has joined #openstack-nova | 04:18 | |
| *** udesale has joined #openstack-nova | 04:20 | |
| *** jmlowe has quit IRC | 04:29 | |
| *** tbachman has quit IRC | 04:32 | |
| *** marst has quit IRC | 04:35 | |
| *** udesale has quit IRC | 04:39 | |
| *** udesale has joined #openstack-nova | 04:41 | |
| *** tbachman has joined #openstack-nova | 04:41 | |
| *** lbragstad has quit IRC | 04:44 | |
| *** wolverineav has joined #openstack-nova | 04:52 | |
| *** lbragstad has joined #openstack-nova | 04:54 | |
| *** Sundar has joined #openstack-nova | 04:54 | |
| *** sdake has joined #openstack-nova | 05:09 | |
| *** wolverineav has quit IRC | 05:23 | |
| *** udesale has quit IRC | 05:39 | |
| *** udesale has joined #openstack-nova | 05:39 | |
| *** sdake has quit IRC | 05:48 | |
| *** sdake has joined #openstack-nova | 05:54 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix an error when generating a host ID https://review.openstack.org/639936 | 05:55 |
| *** tbachman has quit IRC | 05:55 | |
| *** sdake has quit IRC | 06:01 | |
| *** tbachman has joined #openstack-nova | 06:10 | |
| *** tbachman_ has joined #openstack-nova | 06:12 | |
| *** ratailor has joined #openstack-nova | 06:14 | |
| *** tbachman has quit IRC | 06:15 | |
| *** tbachman_ is now known as tbachman | 06:15 | |
| *** yedongcan has quit IRC | 06:27 | |
| *** tkajinam_ has joined #openstack-nova | 06:36 | |
| *** tkajinam has quit IRC | 06:38 | |
| *** udesale has quit IRC | 06:46 | |
| *** udesale has joined #openstack-nova | 06:47 | |
| *** igordc has quit IRC | 06:47 | |
| *** markvoelker has joined #openstack-nova | 06:48 | |
| *** wolverineav has joined #openstack-nova | 06:54 | |
| *** wolverineav has quit IRC | 07:02 | |
| *** Luzi has joined #openstack-nova | 07:02 | |
| *** udesale has quit IRC | 07:05 | |
| *** belmoreira has joined #openstack-nova | 07:05 | |
| *** udesale has joined #openstack-nova | 07:08 | |
| *** udesale has quit IRC | 07:09 | |
| *** udesale has joined #openstack-nova | 07:09 | |
| *** slaweq has joined #openstack-nova | 07:15 | |
| *** markvoelker has quit IRC | 07:21 | |
| *** ircuser-1 has quit IRC | 07:22 | |
| *** jangutter has joined #openstack-nova | 07:23 | |
| *** wolverineav has joined #openstack-nova | 07:27 | |
| *** wolverineav has quit IRC | 07:31 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 07:39 |
| *** wolverineav has joined #openstack-nova | 07:41 | |
| *** wolverineav has quit IRC | 07:47 | |
| *** bhagyashris_ has joined #openstack-nova | 07:50 | |
| *** sapd1 has joined #openstack-nova | 07:57 | |
| *** lchabert has quit IRC | 07:59 | |
| *** tbachman has quit IRC | 08:00 | |
| *** lchabert has joined #openstack-nova | 08:00 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Implement simple prometheus metrics for nova. https://review.openstack.org/640688 | 08:01 |
| *** tesseract has joined #openstack-nova | 08:05 | |
| *** luksky has joined #openstack-nova | 08:07 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 08:10 |
| *** panda|ruck|off is now known as panda|ruck | 08:12 | |
| *** rpittau|sardegna is now known as rpittau | 08:13 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 08:14 |
| *** dpawlik has joined #openstack-nova | 08:16 | |
| *** markvoelker has joined #openstack-nova | 08:18 | |
| *** tetsuro has joined #openstack-nova | 08:18 | |
| *** shilpasd has joined #openstack-nova | 08:18 | |
| *** sridharg has quit IRC | 08:20 | |
| *** helenafm has joined #openstack-nova | 08:23 | |
| *** pcaruana has joined #openstack-nova | 08:25 | |
| *** tosky has joined #openstack-nova | 08:27 | |
| *** giblet is now known as gibi | 08:33 | |
| *** wolverineav has joined #openstack-nova | 08:33 | |
| *** rha has joined #openstack-nova | 08:36 | |
| *** wolverineav has quit IRC | 08:37 | |
| *** phasespace has quit IRC | 08:39 | |
| *** dtantsur|afk is now known as dtantsur | 08:44 | |
| *** ralonsoh has joined #openstack-nova | 08:46 | |
| *** lbragstad has quit IRC | 08:46 | |
| *** tssurya has joined #openstack-nova | 08:47 | |
| *** tkajinam_ has quit IRC | 08:48 | |
| *** markvoelker has quit IRC | 08:50 | |
| *** rchurch_ has joined #openstack-nova | 08:51 | |
| *** rchurch has quit IRC | 08:53 | |
| *** awalende has joined #openstack-nova | 08:53 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350 | 08:56 |
| openstackgerrit | melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | 08:56 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 08:56 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 08:56 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 08:56 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 08:56 |
| tssurya | melwitt: you are online still ? :o | 08:56 |
| melwitt | tssurya: yeah :( wanted to get this uploaded before mriedem morning | 08:57 |
| melwitt | going to go to bed now | 08:57 |
| tssurya | yea good night! thanks | 08:57 |
| gibi | sean-k-mooney: hi! I can start digging the pf interface name autodetection now. If you have any extra info top of what we discussed on Friday then hit me with it | 08:57 |
| gibi | melwitt: good night! | 08:57 |
| melwitt | goodnight everyone :) | 08:58 |
| * gibi still have a full day ahead :D | 08:58 | |
| *** janki has quit IRC | 09:00 | |
| *** janki has joined #openstack-nova | 09:00 | |
| *** udesale has quit IRC | 09:04 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 09:10 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 09:10 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 09:10 |
| *** ttsiouts has joined #openstack-nova | 09:11 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Implement simple prometheus metrics for nova. https://review.openstack.org/640688 | 09:15 |
| *** zhubx has quit IRC | 09:28 | |
| *** zhubx has joined #openstack-nova | 09:29 | |
| *** derekh has joined #openstack-nova | 09:34 | |
| *** bhagyashris_ has quit IRC | 09:34 | |
| *** sapd1 has quit IRC | 09:41 | |
| *** jaosorior has joined #openstack-nova | 09:41 | |
| *** jistr is now known as jistr|sick | 09:42 | |
| openstackgerrit | Lajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.72 https://review.openstack.org/637234 | 09:45 |
| *** markvoelker has joined #openstack-nova | 09:47 | |
| *** IvensZambrano has joined #openstack-nova | 09:54 | |
| *** cdent has joined #openstack-nova | 09:57 | |
| *** wolverineav has joined #openstack-nova | 10:10 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 10:13 |
| *** tetsuro has quit IRC | 10:15 | |
| *** wolverineav has quit IRC | 10:15 | |
| *** dtantsur has quit IRC | 10:18 | |
| *** dtantsur has joined #openstack-nova | 10:18 | |
| *** takashin has quit IRC | 10:19 | |
| *** markvoelker has quit IRC | 10:21 | |
| *** kashyap has joined #openstack-nova | 10:35 | |
| kashyap | stephenfin: Hi, when you get a moment, I am sure a bug here is required (it might only cause confusion): https://review.openstack.org/#/c/637578/1/nova/virt/libvirt/driver.py ("Omit needless check on 'CONF.serial_console'") | 10:37 |
| kashyap | (And the small refactorings we discussed there should be done as follow-ups.) | 10:37 |
| aspiers | morning kashyap :) | 10:38 |
| kashyap | aspiers: Morning | 10:38 |
| lyarwood | mdbooth: https://review.openstack.org/#/q/topic:bug/1803961+(status:open+OR+status:merged) - can you take a look at this today if you have time? | 10:38 |
| aspiers | kashyap: https://review.openstack.org/#/c/640483/1 is ready for review now | 10:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix wrong consumer type in logging https://review.openstack.org/640723 | 10:39 |
| kashyap | aspiers: Thanks for reworking: https://review.openstack.org/#/c/633855/7/nova/virt/libvirt/host.py | 10:42 |
| kashyap | aspiers: Yep, looking at the 'emulator' one | 10:42 |
| *** takashin has joined #openstack-nova | 10:45 | |
| *** ratailor has quit IRC | 10:51 | |
| *** ratailor has joined #openstack-nova | 10:52 | |
| *** cdent has quit IRC | 10:54 | |
| *** luksky has quit IRC | 11:00 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add nits from Id2beaa7c4e5780199298f8e58fb6c7005e420a69 https://review.openstack.org/640729 | 11:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Rework 'config-drive' user doc https://review.openstack.org/640730 | 11:01 |
| gibi | sean-k-mooney: I made some progress with the pf_interface_name auto detection but I realized that this makes the feature virt driver dependent. As far as I see xenapi also supports VF and PF passthrough but I don't know how to autodetect pf_interface_name in xenapi :/ | 11:01 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750 | 11:04 |
| *** ttsiouts has quit IRC | 11:04 | |
| *** ttsiouts has joined #openstack-nova | 11:05 | |
| kashyap | gibi: It is OK to update a spec file retroactively, yes? Specifically something cosmetic like changing the name of config attribute | 11:05 |
| gibi | kashyap: it is even encuraged to update the spec file if the design diverged | 11:06 |
| kashyap | gibi: E.g. I'm suggesting the patch poster to change from 'cpu_models' to 'cpu_model_list' (to better distinguish from the existing 'cpu_model') | 11:06 |
| kashyap | https://review.openstack.org/#/c/637834/4/nova/conf/libvirt.py@548 | 11:06 |
| kashyap | gibi: Good, thought so. Because that's the most sensible thing. | 11:06 |
| HD|Laptop | hey all | 11:06 |
| HD|Laptop | is there a way to force nova to only use Cinder for all kinds of block storage, both for the images it fetches from Glance as well as for "ordinary" servers created via a simple "openstack server create" without manually allocating/attaching a Cinder volume? | 11:06 |
| *** jangutter_ has joined #openstack-nova | 11:07 | |
| lyarwood | HD|Laptop: no, it has been discussed at recent Forum / PTGs etc but nothing has been worked on AFAIK. | 11:07 |
| HD|Laptop | oh damn. 'cause all my compute nodes have 128GB SSDs only and that's it, for storage I have a nice 80TB QNAP NAS :'D | 11:08 |
| HD|Laptop | another thing: can I somehow specify additional parameters for qemu/kvm? I need to match https://github.com/kholia/OSX-KVM/blob/master/boot-macOS.sh | 11:09 |
| *** jangutte_ has joined #openstack-nova | 11:09 | |
| *** jangutter has quit IRC | 11:09 | |
| HD|Laptop | (and yes I do only run this on original Macs, 9x 2010-era Mac Pro cheesegraters, so I don't violate licenses) | 11:09 |
| *** ttsiouts has quit IRC | 11:09 | |
| lyarwood | HD|Laptop: you can supply additional QEMU params via libvirt but I don't recall a way of doing that part via Nova | 11:10 |
| * lyarwood looks | 11:10 | |
| HD|Laptop | thanks :) | 11:10 |
| *** jangutter_ has quit IRC | 11:11 | |
| lyarwood | HD|Laptop: yeah I can't see a way of passing extra args from Nova to libvirt and down to QEMU tbh | 11:14 |
| kashyap | HD|Laptop: lyarwood: There is no way that Nova provides it either. | 11:14 |
| kashyap | If you go behind libvirt (or Nova's) back and use QEMU command-line options, and if something breaks, you get to keep the pieces :-) | 11:15 |
| lyarwood | kashyap: could you use a custom machine type for this? | 11:15 |
| *** udesale has joined #openstack-nova | 11:15 | |
| kashyap | lyarwood: Machine types won't help in this case. (They are a particular chipset with additional devices) | 11:16 |
| * kashyap reads the context from HD|Laptop | 11:16 | |
| lyarwood | kashyap: yeah just for the additional devices I mean | 11:17 |
| kashyap | That's a bit too heavy-weight :-) | 11:17 |
| kashyap | (Earlier typo: s/additional/default/) | 11:17 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Add initial version of metadata configuration https://review.openstack.org/640733 | 11:17 |
| *** markvoelker has joined #openstack-nova | 11:18 | |
| kashyap | lyarwood: Aside: there's already some discusions upstream to propose a separate machine type for 'x86' that is "legacy-free" | 11:19 |
| kashyap | (Just like how AArch64 has a machine type called 'virt', which is expressely designed for virtual machines.) | 11:19 |
| *** ileixe has quit IRC | 11:19 | |
| HD|Laptop | kashyap: ah damn. How is qemu called in nova, anyway? Tried to read myself through the libvirt driver, but I couldn't even find out where it gets "-machine pc-i440fx-3.1" from, there isn't even any single mention of that machine type anywhere in the nova git repository | 11:23 |
| HD|Laptop | Maybe I can do a hot-patch in there... | 11:23 |
| *** zhubx has quit IRC | 11:25 | |
| kashyap | HD|Laptop: Nova models every guest feature via libvirt classes / objects, which lets libvirt build an opinionated QEMU command-line. | 11:25 |
| *** zhubx has joined #openstack-nova | 11:25 | |
| *** jangutte_ is now known as jangutter | 11:25 | |
| kashyap | HD|Laptop: No specific machine types are hard-coded in Nova, obviously. They're selected by what your host hypervisor supports | 11:26 |
| mdbooth | zhubx: Are you the author of https://review.openstack.org/#/c/640271/ ? | 11:26 |
| mdbooth | lyarwood: Looking now. | 11:26 |
| sean-k-mooney | gibi: you are correct that it would make it virt driver dependent in a way but no more then manually adding the pf_interface_name. for xenapi the compute service i belive will be runnin in dom0 i have not deployed xen in quite a long time but i think you could use sysfs the same way. after all if the sriov_nic agent is running in dom0 and can see the interface netdevs then you can also see the vf and | 11:27 |
| HD|Laptop | kashyap: ah, ok. where do I have to look for the final call to libvirt for starting the qemu process? | 11:27 |
| sean-k-mooney | lookup the pf netdev the same way | 11:27 |
| mdbooth | zhubx: If so, I just hit that again. I think this is the right approach and it'll be good to go if you can fix up a few things and add unit tests. | 11:27 |
| kashyap | HD|Laptop: For machine type handling in Nova, see this: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4221,L4248 | 11:27 |
| stephenfin | kashyap: Is required or is not required? | 11:28 |
| kashyap | HD|Laptop: There is no "final call" in Nova; libvirt takes care of it. | 11:28 |
| kashyap | stephenfin: Not required. | 11:28 |
| kashyap | HD|Laptop: If you want additional command-line options that Nova currently doesn't have; then you have to model that into Nova by providing libvirt config class objects. | 11:29 |
| kashyap | stephenfin: (Sorry, saw the typo in my sentence in the scrollback :-)) | 11:30 |
| sean-k-mooney | kashyap: that is allowed to a point. we do not allow the use of the qemu:args element to be genearted to allow raw qemu commands to be added | 11:30 |
| mdbooth | lyarwood: Did you speak to mriedem about removing the timestamp check from the retype tempest test? | 11:30 |
| sean-k-mooney | kashyap: i have tried in the past to enable features that are not supported by libvirt yet or on older versions | 11:30 |
| mdbooth | I'll take your work for it that they're flaky, but IIUC the purpose was to assert functionally that the volume contains the same data after retype. | 11:31 |
| mdbooth | lyarwood: IIRC mriedem was especially keen on this. | 11:31 |
| lyarwood | mdbooth: I had no idea he was attached to it tbh | 11:32 |
| lyarwood | mdbooth: I'll bring it up with him this afternoon | 11:32 |
| lyarwood | mdbooth: and yeah it has been pretty awful for me locally testing this | 11:33 |
| mdbooth | Yeah, I can imagine. Seems to work ok in the gate, though. | 11:33 |
| kashyap | sean-k-mooney: Yeah, that's what I meant: Nova not allowing libvirt's <qemu:commandline> element which allows arbitrary pass-through. | 11:34 |
| *** cdent has joined #openstack-nova | 11:34 | |
| sean-k-mooney | yep that is the element i was thinking of | 11:34 |
| kashyap | sean-k-mooney: (And yeah, I've used it for one-off hacks in Nova in the past.) | 11:34 |
| sean-k-mooney | ya i used it to demonstarte that you can run ovs-dpdk without hugepages before i got funding to have the libvirt support for file backed memory developed | 11:35 |
| sean-k-mooney | i never got time to add the nova support for file backed memory the way i wanted it but redhat did it a release or two later for other uses | 11:36 |
| sean-k-mooney | <qemu:commandline> is still useful for POCs of thing that will be comming soon so you can write the nova side of the feature and just swap out the xml generation code when it lands in libvirt | 11:38 |
| kashyap | sean-k-mooney: Yeah, is useful in many scenarios; I consider it as a Swiss Army knife. | 11:39 |
| *** shilpasd has quit IRC | 11:41 | |
| *** thgcorrea has joined #openstack-nova | 11:43 | |
| gibi | sean-k-mooney: thanks. I think I will skip the xen support now due to the shortness of time. But I feel that I will manage to push the libvirt support today | 11:49 |
| *** luksky has joined #openstack-nova | 11:50 | |
| *** markvoelker has quit IRC | 11:50 | |
| sean-k-mooney | gibi: good to hear. i ended up spending my weekend hacking time on figuring out how to get vs-code to debug eventlet code which i did but as a result i didnt get much time to look at the auto generation | 11:51 |
| gibi | sean-k-mooney: no worries you helped a lot by point out the code pieces I need | 11:51 |
| *** udesale has quit IRC | 11:52 | |
| *** udesale has joined #openstack-nova | 11:53 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750 | 11:54 |
| *** wolverineav has joined #openstack-nova | 11:59 | |
| *** ttsiouts has joined #openstack-nova | 11:59 | |
| *** wolverineav has quit IRC | 12:04 | |
| cdent | thanks for the response mdbooth, I was doing a run through of patches that touch vmware related stuff (there's an automated thingie that tells me about such stuff). I wasn't sure of the state of that one | 12:10 |
| mdbooth | cdent: thanks | 12:10 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 12:13 |
| *** janki has quit IRC | 12:16 | |
| *** janki has joined #openstack-nova | 12:16 | |
| *** udesale has quit IRC | 12:20 | |
| *** udesale has joined #openstack-nova | 12:21 | |
| *** brinzhang has quit IRC | 12:21 | |
| *** priteau has joined #openstack-nova | 12:30 | |
| *** ttsiouts_ has joined #openstack-nova | 12:36 | |
| *** phasespace has joined #openstack-nova | 12:37 | |
| *** udesale has quit IRC | 12:38 | |
| *** ttsiouts has quit IRC | 12:40 | |
| *** udesale has joined #openstack-nova | 12:41 | |
| *** sapd1 has joined #openstack-nova | 12:45 | |
| *** markvoelker has joined #openstack-nova | 12:48 | |
| *** edmondsw has joined #openstack-nova | 12:49 | |
| kashyap | aspiers: Have you noticed this: https://www.redhat.com/archives/libvir-list/2019-February/msg01730.html (New Feature: Intel MKTME Support) | 12:53 |
| kashyap | aspiers: It ("MKTME": Multi-Key Total Memory Encryption) is Intel's equivalent to AMD SEV | 12:53 |
| *** ratailor has quit IRC | 12:53 | |
| *** ratailor has joined #openstack-nova | 12:54 | |
| aspiers | kashyap: ah interesting, so another alternative to the SGX approach? | 12:54 |
| kashyap | aspiers: I don't know much (if anything) about Intel's SGX | 12:54 |
| kashyap | aspiers: But the MKTME isn't yet merged in the kernel (https://lwn.net/Articles/758313/) | 12:55 |
| kashyap | (Near as I see) | 12:55 |
| kashyap | s/MKTME/"Support for MKTME"/ | 12:55 |
| sean-k-mooney | SGX is intels secure enclave technology that prevent the host kernel and userpace processes form acessing meory that is in the enclave and assigend to a specifc process | 12:55 |
| *** awalende has quit IRC | 12:56 | |
| sean-k-mooney | the SGX enclaves are created and managed via system management mode so even the host kernel cannot read or write to if it is not the owner of the enclve but i dont be think SGX actully encrypts the memory | 12:57 |
| kashyap | sean-k-mooney: Ah, thanks for the nice summary | 12:57 |
| sean-k-mooney | so sgx + mktme would give someting simlar but maybe more secure then SEV as teh memory is not just encrypted but partitioned | 12:59 |
| sean-k-mooney | i dont realy know anyting about mktme however | 12:59 |
| *** artom has joined #openstack-nova | 13:00 | |
| artom | ~o~ | 13:01 |
| *** jistr|sick is now known as jistr|sick|mtg | 13:01 | |
| * mdbooth wonders how the kernel does a context switch to memory it can't access | 13:01 | |
| mdbooth | Perhaps there's some super-small ring -1 which is allowed to do context switches? | 13:01 |
| *** cdent has quit IRC | 13:03 | |
| sean-k-mooney | mdbooth: by the way https://review.openstack.org/#/c/634276/ may have been related to some of the port binding issue you were having with failed migrations | 13:04 |
| *** awalende has joined #openstack-nova | 13:05 | |
| mdbooth | sean-k-mooney: Nice, thanks. | 13:06 |
| *** udesale has quit IRC | 13:08 | |
| sean-k-mooney | mdbooth:for sgx. i dont think so. memory in sgx enclaves is not swapable. so other the createing and destroying them there isnt anything that a ring -1 e.g. hypervior layer process would need to do | 13:09 |
| *** ratailor has quit IRC | 13:09 | |
| *** udesale has joined #openstack-nova | 13:09 | |
| sean-k-mooney | as far as i know the sgx enclaves are mapped into the process virtual memory via the iommu. as such i dont think there is a context switch requried for a process to acess it. that said its been 2 years since i looked at how sgx worked in detail | 13:12 |
| mdbooth | lyarwood: https://review.openstack.org/#/c/639331/ | 13:14 |
| mdbooth | lyarwood: I'd like to get mriedem's opinion on that. | 13:14 |
| mdbooth | Grr, gerrit seems to bogosort the results of a change query. The order changes every time I look at it. | 13:15 |
| openstackgerrit | Merged openstack/nova stable/rocky: Fix legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/640186 | 13:20 |
| openstackgerrit | Merged openstack/nova master: api-ref: explain aggregate set_metadata semantics https://review.openstack.org/640460 | 13:20 |
| openstackgerrit | Merged openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104 | 13:20 |
| *** markvoelker has quit IRC | 13:21 | |
| *** cdent has joined #openstack-nova | 13:21 | |
| *** sdake has joined #openstack-nova | 13:24 | |
| lyarwood | mdbooth: sorry was on the phone | 13:26 |
| lyarwood | mdbooth: ack thanks | 13:26 |
| mdbooth | lyarwood: You've had the same failure 3 times in a row on the migration tempest test, btw. | 13:26 |
| mdbooth | lyarwood: failure to delete type because it's still in use. | 13:26 |
| lyarwood | mdbooth: yeah clean up is racing | 13:26 |
| mdbooth | Have you investigated that already? | 13:26 |
| lyarwood | mdbooth: next on my list | 13:27 |
| *** udesale has quit IRC | 13:36 | |
| *** marst has joined #openstack-nova | 13:37 | |
| *** wolverineav has joined #openstack-nova | 13:47 | |
| *** lbragstad has joined #openstack-nova | 13:49 | |
| *** wolverineav has quit IRC | 13:52 | |
| *** tetsuro has joined #openstack-nova | 13:55 | |
| *** marst has quit IRC | 13:55 | |
| openstackgerrit | Merged openstack/nova master: Fixes race condition with privsep utime https://review.openstack.org/625741 | 14:00 |
| efried | n-sch meeting now in #openstack-meeting-alt | 14:00 |
| openstackgerrit | Merged openstack/nova master: Optimize populate_queued_for_delete online data migration https://review.openstack.org/639840 | 14:04 |
| openstackgerrit | Merged openstack/nova master: Remove wrong description for auto resize confirm https://review.openstack.org/638357 | 14:04 |
| openstackgerrit | Merged openstack/nova stable/rocky: Fix overcommit for NUMA-based instances https://review.openstack.org/633197 | 14:04 |
| *** awaugama has joined #openstack-nova | 14:06 | |
| *** mmethot has joined #openstack-nova | 14:09 | |
| *** sdake has quit IRC | 14:14 | |
| *** ttsiouts_ has quit IRC | 14:18 | |
| *** markvoelker has joined #openstack-nova | 14:18 | |
| *** jmlowe has joined #openstack-nova | 14:18 | |
| *** ttsiouts has joined #openstack-nova | 14:19 | |
| *** janki has quit IRC | 14:19 | |
| *** ttsiouts has quit IRC | 14:21 | |
| *** ttsiouts has joined #openstack-nova | 14:21 | |
| *** janki has joined #openstack-nova | 14:24 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova stable/rocky: ironic: stop hammering ironic API in power sync loop https://review.openstack.org/640771 | 14:24 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova stable/rocky: ironic: check fresh data when sync_power_state doesn't line up https://review.openstack.org/640772 | 14:24 |
| jroll | turns out we never backported that first one >.> | 14:25 |
| *** sdake has joined #openstack-nova | 14:25 | |
| *** sdake has quit IRC | 14:25 | |
| *** pcaruana has quit IRC | 14:31 | |
| *** marst has joined #openstack-nova | 14:31 | |
| stephenfin | lyarwood: Could you look at https://review.openstack.org/#/c/636919/ today? | 14:32 |
| *** phasespace has quit IRC | 14:32 | |
| *** beekneemech is now known as bnemec | 14:33 | |
| *** mriedem has joined #openstack-nova | 14:36 | |
| mriedem | who's ready to rush some crap in | 14:37 |
| *** sdake has joined #openstack-nova | 14:38 | |
| sean-k-mooney | i dont know its only monday :P we have 3 whole days left to rush crap in | 14:38 |
| stephenfin | mriedem: Just tell me what I need to blindly +W | 14:39 |
| * stephenfin grabs blindfold | 14:39 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nits from Id2beaa7c4e5780199298f8e58fb6c7005e420a69 https://review.openstack.org/640729 | 14:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: Rework 'config-drive' user doc https://review.openstack.org/640730 | 14:44 |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 14:49 |
| *** sdake has quit IRC | 14:49 | |
| *** markvoelker has quit IRC | 14:50 | |
| *** tetsuro has quit IRC | 14:53 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Store InstancePCIRequest.numa_policy in DB https://review.openstack.org/624444 | 14:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: fakelibvirt: Add ability to generate fake PCI devices https://review.openstack.org/640409 | 14:53 |
| *** sdake has joined #openstack-nova | 14:55 | |
| * alex_xu can sleep well with learning something new on request group | 14:56 | |
| mriedem | sounds like a nightmare to me | 14:56 |
| bauzas | mriedem: give me some crap, I'm thirsty | 14:57 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: qemu: Make disk image conversion dramatically faster https://review.openstack.org/640781 | 15:00 |
| kashyap | mdbooth: ^ If you have time. | 15:00 |
| kashyap | (Change itself is a "one-worder"; but the commit message is long, with a back-of-the-envelope "benchmark" & context) | 15:01 |
| *** takashin has left #openstack-nova | 15:01 | |
| *** mlavalle has joined #openstack-nova | 15:02 | |
| *** jistr|sick|mtg is now known as jistr|sick | 15:02 | |
| *** eharney has joined #openstack-nova | 15:04 | |
| *** ttsiouts has quit IRC | 15:06 | |
| *** ttsiouts has joined #openstack-nova | 15:07 | |
| *** sapd1 has quit IRC | 15:09 | |
| *** sapd1 has joined #openstack-nova | 15:10 | |
| *** ttsiouts has quit IRC | 15:11 | |
| *** sdake has quit IRC | 15:11 | |
| *** priteau has quit IRC | 15:11 | |
| *** ralonsoh has quit IRC | 15:11 | |
| *** cfriesen has joined #openstack-nova | 15:12 | |
| *** ralonsoh has joined #openstack-nova | 15:12 | |
| *** ralonsoh has quit IRC | 15:12 | |
| *** ralonsoh has joined #openstack-nova | 15:13 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 15:13 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 15:13 |
| *** tbachman has joined #openstack-nova | 15:13 | |
| *** Luzi has quit IRC | 15:13 | |
| gibi | sean-k-mooney, stephenfin: removed the whitelis tag config extension and added the auto detection of the pf interface name ^^ | 15:14 |
| *** sdake has joined #openstack-nova | 15:15 | |
| gibi | any feedback are welcome | 15:16 |
| artom | mriedem, well, *my* crap is going to remain unrushed, and will smell delicious by the time it lands ;) | 15:16 |
| artom | efried, btw, I'm +1 on https://review.openstack.org/#/c/635440/9, but I left a question inline | 15:17 |
| mriedem | umm, what actually puts the instance into ERROR state in ^? | 15:20 |
| artom | Gremlins? | 15:22 |
| jroll | .v 37 | 15:22 |
| jroll | blurhg, sorry | 15:22 |
| * kashyap wonders if he's going to win the "longest commit message" award in Nova: https://review.openstack.org/#/c/640781/ | 15:22 | |
| kashyap | :D | 15:22 |
| * kashyap bbiab | 15:22 | |
| cfriesen | sean-k-mooney: is it expected that PCI aliases will be configured in the nova-api nova.conf the same as all compute nodes? | 15:23 |
| sean-k-mooney | yes | 15:23 |
| cfriesen | mriedem: there you go ^ | 15:23 |
| mriedem | isn't that....weird? | 15:25 |
| *** pcaruana has joined #openstack-nova | 15:25 | |
| mriedem | the computes can have different pci devices right? so wouldn't the alias config be per-compute? | 15:25 |
| cfriesen | mriedem: I assume the idea is that a given alias should mean the same thing across the whole cloud, even if not all computes have that device. | 15:29 |
| mriedem | ok i guess it's true https://docs.openstack.org/nova/latest/admin/pci-passthrough.html#configure-nova-api-controller | 15:31 |
| mriedem | and documented that way | 15:31 |
| sean-k-mooney | mriedem: it is weird but its needed for reasons | 15:31 |
| sean-k-mooney | im trying to rememebr why | 15:31 |
| sean-k-mooney | stephenfin: do you rememebr ? | 15:31 |
| sean-k-mooney | i think i had something to do with either hardwar offloaded ovs or pci numa policies | 15:32 |
| stephenfin | sean-k-mooney: Why they have to be specified on the API node? | 15:33 |
| sean-k-mooney | cfriesen: it was related to scheduling. we needed the content of teh alias to aloow the schulers to make desissions | 15:33 |
| sean-k-mooney | stephenfin: yes | 15:33 |
| sean-k-mooney | i think it was so the numa toplogy filter could take the pci_numa policy into effect | 15:33 |
| cfriesen | I'm not complaining, it's helpful for the flavor/image validation. :) | 15:34 |
| stephenfin | Nah, it's because it's needed for move operations | 15:34 |
| stephenfin | See b4ce2d9f12ef6d50837e4133dff09fa43fd152d2 | 15:34 |
| *** wolverineav has joined #openstack-nova | 15:35 | |
| sean-k-mooney | stephenfin: well the move operations e.g. cold migration need it for schudleing | 15:35 |
| sean-k-mooney | mriedem: the alias does not contain the pci addresses. so it works independenly form the compute nodes for most usecause | 15:37 |
| sean-k-mooney | it does mean if you put the pci vendor and product id in the alias that it has to match across the compute nodes but you are better off haveing 1 alias per device model anyway | 15:38 |
| *** wolverineav has quit IRC | 15:40 | |
| *** luksky has quit IRC | 15:40 | |
| mriedem | sure | 15:41 |
| mriedem | artom: btw, how is your downstream numa live migration whitebox tempest testing stuff passing if the intel people testing it are finding issues? just different issues from what the CI would hit? | 15:42 |
| *** janki has quit IRC | 15:42 | |
| sean-k-mooney | mriedem: i responded on the mailing list | 15:42 |
| sean-k-mooney | mriedem: they were using virsh edit to view the xml instead of virsh dumpxml | 15:43 |
| sean-k-mooney | virsh dumpxml shows the current state of the vm | 15:43 |
| sean-k-mooney | virsh edit shows the xml that the vm would have it you were to reboot it | 15:43 |
| sean-k-mooney | it looks like when we update the xml as part of a migration virsh edit still shows the original xml | 15:44 |
| sean-k-mooney | so that is the reason for the delta. the whitebox test use virsh dumpxml which i belive is correct | 15:44 |
| *** markvoelker has joined #openstack-nova | 15:48 | |
| *** cdent has quit IRC | 15:48 | |
| mriedem | (8:39:26 AM) stephenfin: mriedem: Just tell me what I need to blindly +W | 15:52 |
| mriedem | stephenfin: don't go blind on this, but https://review.openstack.org/#/c/623543/ | 15:53 |
| mriedem | since gibi abandoned https://review.openstack.org/#/c/625311/ | 15:53 |
| stephenfin | mriedem: Yup, already on it (gibi pinged us) | 15:53 |
| mriedem | ok that's a big change so i'll hold off until someone more familiar with the pf/vf/pci stuff has gone through it | 15:53 |
| * stephenfin wonders if adrianc fancies taking a look at it too | 15:54 | |
| *** wolverineav has joined #openstack-nova | 15:57 | |
| gibi | mriedem: sorry about the size of that patch, it organicly grow to that | 15:58 |
| sean-k-mooney | gibi: is your current plan to support but the manual tag in the whitelist + the auto disovery of the tag? | 15:59 |
| *** sdake has quit IRC | 16:00 | |
| sean-k-mooney | gibi: im ok with that by the way as a fallback mechanisum ignoring the similar nameing of pf_interface_name and devname | 16:00 |
| sean-k-mooney | oh you have abandoned it never mind im looking at the wrong patch | 16:01 |
| bauzas | gibi: I just started reviewing https://review.openstack.org/#/c/623543/ and I have a concern | 16:01 |
| gibi | sean-k-mooney: I dropped the whitelist support | 16:01 |
| bauzas | gibi: do we agreed on having a pci claim providing a reschedule ? | 16:01 |
| bauzas | (for this I mean) | 16:02 |
| gibi | bauzas: fixing the PCI filter would be a really big work as the filters doesn't know about allocation candidates | 16:02 |
| sean-k-mooney | gibi: cool that was my perference but i could live with it if it was just a fallback for if we could not auto detect it. | 16:02 |
| bauzas | gibi: sure, I'm just saying we haven't this in the spec, right? | 16:02 |
| gibi | sean-k-mooney: libvirt autodetection was pretty small change so I went for it | 16:02 |
| gibi | bauzas: yeah, devil is in the details so this edge case surfaced during implementation | 16:03 |
| gibi | bauzas: I'm planning to retrofit the spec | 16:03 |
| bauzas | gibi: okay, my point is that I want to make sure people are okay with this | 16:03 |
| gibi | bauzas: sure, I also want to make sure, hence the big commit message | 16:04 |
| bauzas | (fwiw, I have the same problem with any NUMA affinity for vGPUs ;) ) | 16:04 |
| bauzas | changing the filter is difficult | 16:04 |
| gibi | if we end up fearing the re-schedule then I can drop this patch and document the limitation | 16:04 |
| bauzas | gibi: I'm not really bad with this | 16:05 |
| bauzas | also, https://review.openstack.org/#/c/636360/19 is the API microversion that really creates the new feature, right? | 16:05 |
| gibi | bauzas: yes, everything is rejected until https://review.openstack.org/#/c/636360/19 | 16:06 |
| gibi | bauzas: everything involving ports with resource request | 16:06 |
| bauzas | yeah, I'm seeing with https://review.openstack.org/#/c/636360/19/nova/api/openstack/common.py | 16:06 |
| gibi | bauzas: except server delete | 16:06 |
| gibi | bauzas: yepp, that is the key | 16:07 |
| *** wolverineav has quit IRC | 16:07 | |
| *** macza has joined #openstack-nova | 16:07 | |
| *** burt has quit IRC | 16:07 | |
| *** luksky has joined #openstack-nova | 16:11 | |
| stephenfin | gibi: Left a series of nits plus a suggestion to s/pf_interface_name/parent_ifname/, but otherwise +2 on https://review.openstack.org/#/c/623543/ Thanks for tackling that | 16:15 |
| bauzas | gibi: just to make it clear, if you solve https://review.openstack.org/#/c/623543/39//COMMIT_MSG by the compute claim, that means that you check the compute version for all the move ops ? | 16:16 |
| * bauzas tries to look at the spec to see whether we only accept compute versions | 16:16 | |
| gibi | stephenfin: I'm OK to rename the key to parent_ifname | 16:17 |
| stephenfin | and I'm OK to re-review if you do :) | 16:17 |
| bauzas | don't see any of this in https://specs.openstack.org/openstack/nova-specs/specs/stein/approved/bandwidth-resource-provider.html#upgrade-impact | 16:17 |
| gibi | bauzas: I think you found a problem | 16:17 |
| *** tobeass-urdin is now known as tobias-urdin | 16:17 | |
| gibi | bauzas: we did not planned to check the compute version | 16:18 |
| gibi | bauzas: right now if you boot a server and the scheduler select a host that is still Rocky then the pci claim fails as the new pf_interface_name key will be missing from the pci spec | 16:19 |
| gibi | bauzas: so no resource inconsistency but more re-schedule will happen | 16:19 |
| *** mrch_ has quit IRC | 16:20 | |
| bauzas | gibi: wait | 16:20 |
| gibi | bauzas: ohh no. the InstancePCIRequest will not request the new key either if the request lands on an old compute | 16:20 |
| bauzas | gibi: yeah that | 16:20 |
| *** markvoelker has quit IRC | 16:21 | |
| bauzas | it's old code so it doesn't know about anything | 16:21 |
| gibi | bauzas: yeah, the InstancePCIRequest change is also in the compute/manager | 16:21 |
| gibi | BUT if we have an old compute then the old compute will not have bandwidth inventory | 16:22 |
| gibi | so placement will not select it | 16:22 |
| gibi | (assuming that nova-compute is updated along with the neutron agents) | 16:23 |
| bauzas | gibi: that was the original reason why we didn't need a check | 16:23 |
| bauzas | because placement checks it for free | 16:23 |
| bauzas | but | 16:23 |
| bauzas | for a classic move operation, you can end up with the late-check not being read | 16:23 |
| mriedem | there is no move support for this in stein | 16:24 |
| *** wolverineav has joined #openstack-nova | 16:24 | |
| gibi | bauzas: ^^ | 16:24 |
| mriedem | gibi: and we enforce that in the api right? | 16:24 |
| mriedem | yeah i remember | 16:24 |
| gibi | mriedem: yes, the moves are rejected | 16:24 |
| gibi | mriedem: even after the 2.72 | 16:24 |
| bauzas | mriedem: what happens with my instance ? am I able to migrate it with dropping the bandwidth check, or do i get some ERROR ? | 16:24 |
| mriedem | you get a 400 or 409 | 16:25 |
| bauzas | ah, that's an API enforcement | 16:25 |
| mriedem | i can't remember which | 16:25 |
| bauzas | good then | 16:25 |
| * gibi makes a note about possible compute version check needs for move | 16:25 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/evacuate.py#L123 400 | 16:25 |
| bauzas | so that works, at least if neutron agent is upgraded with compute service, which is usually what's done | 16:25 |
| mriedem | if the neutron agent is upgraded before nova-compute it could be reporting inventory before the compute is ready to handle those types of allocations... | 16:26 |
| mriedem | but i'm not sure how realistic that is | 16:26 |
| gibi | bauzas: even if they ugrade the neutron agent they can skip the bw config in the agent until nova-compute is upgraded | 16:26 |
| bauzas | worth a note at least | 16:26 |
| gibi | bauzas: the whole neutron bw inventory is config based | 16:26 |
| bauzas | yeah | 16:26 |
| mriedem | how much of the compute-level stuff is virt-driver specific? | 16:27 |
| bauzas | so, ops can upgrade whenever they want, and once they're done, they set configs | 16:27 |
| mriedem | just the multi-VF on same PF thing? | 16:27 |
| bauzas | gibi: planned to write some ops docs btw. ? | 16:27 |
| bauzas | that would also help me reviewing all of this :) | 16:27 |
| gibi | bauzas: yeah, rubasov already started it for neutron and I will chime in | 16:27 |
| bauzas | I'd be more than happy to review it | 16:28 |
| gibi | mriedem: good question, I think the SRIOV + bandwidth support is now become virt driver specify | 16:28 |
| gibi | bauzas: here is a neutron WIP doc patch https://review.openstack.org/#/c/640390/ | 16:28 |
| dansmith | mriedem: hmm, aren't the two things in runway slot 2 and 3 part of the same effort? | 16:28 |
| mriedem | dansmith: yeah, spot instances | 16:28 |
| dansmith | yeah | 16:29 |
| mriedem | separate blueprints for whatever reason | 16:29 |
| dansmith | hrm | 16:29 |
| dansmith | they're part of the same stack in gerrit, so.. kinda seems like that's one thing:) | 16:29 |
| gibi | mriedem: if there is a InstancePCIRequest then it will have the new tag included even if the compute host only has a single PF | 16:29 |
| mriedem | gibi: but maybe a compute without a supporting virt driver wouldn't configure the neutron agent to report that inventory | 16:29 |
| artom | mriedem, I wasn't checking the database instance_numa_topology | 16:29 |
| artom | So the pins are updated and correct | 16:29 |
| gibi | mriedem: SRIOV without bw is kept intact | 16:30 |
| artom | But Windriver are telling me the DB isn't updated, despite apply_migration_context() being called | 16:30 |
| gibi | mriedem: so if no resource request in the sriov port then we don't need the special key from the virt driver | 16:30 |
| mriedem | artom: are you saving the instance changes after calling apply_migration_context()? | 16:30 |
| mriedem | b/c ^ doesn't persist the changes, it just updates the object fields | 16:31 |
| artom | mriedem, wait, seriously? | 16:31 |
| *** wolverineav has quit IRC | 16:31 | |
| artom | mriedem, huh, but instance.save() is still called after in post_live_migration | 16:31 |
| mriedem | don't take my word for it | 16:31 |
| bauzas | gibi: if that's virt-specific, you should document it in https://docs.openstack.org/nova/latest/user/feature-classification.html | 16:31 |
| gibi | bauzas: thanks for the pointer | 16:31 |
| artom | mriedem, ah, you're right, it's not saved | 16:32 |
| *** gyee has joined #openstack-nova | 16:32 | |
| mriedem | i'm more worried that we send a server create request to a compute that doesn't support it | 16:32 |
| mriedem | and we don't have any kind of feature capability for this port requested resources stuff | 16:32 |
| mriedem | gibi: bauzas: ^ | 16:32 |
| mriedem | and we just drop the request on the floor | 16:32 |
| dansmith | artom: so does that mean some testing gap exists because we never re-migrate the instance a second time or something? | 16:33 |
| mriedem | thinking about https://review.openstack.org/#/c/538498/ coincidentally | 16:33 |
| bauzas | mriedem: that's my -1 | 16:33 |
| dansmith | artom: meaning.. how could we be failing to save that and think that this works? | 16:33 |
| artom | But there's an instance.save 5 lines after https://review.openstack.org/#/c/634606/37/nova/compute/manager.py@6925 | 16:33 |
| gibi | mriedem: yeah if neutron agent is configured to report bandwidth but the nova virt driver does not support it then it will be NoValidHost after a bunch of reschedule | 16:33 |
| bauzas | mriedem: but the question is : should we leave it as docs, or enforce it ? | 16:33 |
| artom | dansmith, I was just testing the XML is updated correctly | 16:33 |
| dansmith | artom: oh :( | 16:33 |
| artom | dansmith, yeah, testing coverage gap :( | 16:34 |
| mriedem | gibi: bauzas: at this point it's probably best to just doc it and clean it up in train with a capability tag a la https://review.openstack.org/#/c/538498/ | 16:34 |
| *** cdent has joined #openstack-nova | 16:34 | |
| bauzas | I'm good with that | 16:35 |
| mriedem | aspiers: efried: btw who is on the hook for documenting ^ now that it's going to be codified? | 16:35 |
| gibi | bauzas, mriedem, sean-k-mooney, stephenfin: this is the cons of the auto detection of the pf_interface_name. It makes the feature virt driver specific. If we go with the a new tag in the passthrough_whitelist then the solution is virt driver agnostic | 16:35 |
| *** imacdonn_ has joined #openstack-nova | 16:35 | |
| mriedem | but then you have to configure more crap | 16:35 |
| *** imacdonn_ is now known as imacdonn | 16:35 | |
| gibi | mriedem: exactly | 16:36 |
| mriedem | this is pretty magical unicorn and i expect 99% of openstack users for nfv stuff are using libvirt anyway | 16:36 |
| gibi | mriedem: I'm OK to add the capability in Train | 16:36 |
| openstackgerrit | Merged openstack/nova stable/rocky: Fix race in test_volume_swap_server_with_error https://review.openstack.org/640595 | 16:36 |
| mriedem | dansmith: regarding the spot instance stuff i have skimmed some of it in the past (over a month ago) noting some obvious concerns, but haven't been back on it since, nor has anyone else from the core team it looks like, so that one is too risky at this point for me, especially without any integration (tempest) testing | 16:38 |
| bauzas | mriedem: gibi: I'm not opposed to have this feature be virt-driver specific for the moment and provide a new abstract trait later | 16:38 |
| mdbooth | lyarwood: I was looking into your tempest failures but got distracted. Just getting back into it. Did you manage to look by any chance? | 16:38 |
| dansmith | mriedem: yeah, same, I was just skimming over it, thinking that since it was two pieces, maybe half of it was simple stuff we could merge, but it seems all tied together | 16:39 |
| mdbooth | Looking at one of them in particular, I note that the type is deleted after a volume of that type is deleted, but before cinder logs that the delete completed. However, it could be, for eg, that cinder has already deleted the volume from the db but doesn't log until some backend stuff is done? I'm still looking. Looks weird. | 16:40 |
| dansmith | artom: so yeah, I dunno why that save() doesn't get you there, but the migration context stuff is complex, so you might just be tripping over some assumption | 16:40 |
| dansmith | artom: honestly, I'd start trying to reproduce (or disprove) that with a functional test before rattling a fix | 16:41 |
| artom | dansmith, yeah, first order is modifying my tests to catch that | 16:41 |
| artom | (Or writing new func tests for the same purpose) | 16:41 |
| artom | Then debugging | 16:41 |
| dansmith | artom: ++ | 16:41 |
| mriedem | btw i do a lot of ^ type stuff in the cross-cell resize functional testing to make sure the db is what i expect it to be | 16:41 |
| *** rpittau is now known as rpittau|afk | 16:42 | |
| mriedem | since i'm farting around with 2 dbs | 16:42 |
| gibi | bauzas: cool, then your current -1 on the patch is just procedural while you reviewing the rest of the patch? | 16:42 |
| *** helenafm has quit IRC | 16:43 | |
| artom | mriedem, I think the DB asserting part will be relatively easy, it's the running 2 services part that's finicky | 16:43 |
| artom | dansmith, while I have you, can we context switch to your thoughts on https://review.openstack.org/#/c/639396/? | 16:44 |
| dansmith | artom: ugh, I really don't want to... I know that is going to be ugly because of whatever has moved out of that scope, but I'm really (really) not in favor of changing how that works.. like REALLY. | 16:45 |
| bauzas | gibi: I left a new comment as a soft -1 | 16:46 |
| gibi | bauzas: looking | 16:46 |
| bauzas | gibi: but I'm continuing to review so I can +1 once I'm done | 16:46 |
| gibi | bauzas: sure | 16:46 |
| bauzas | gibi: just askign docd | 16:46 |
| gibi | bauzas: I will let you go through it before I start updating the patch | 16:46 |
| artom | dansmith, yeah :/ | 16:46 |
| artom | dansmith, as I said in the review, I don't see a way around *some* change, because we race on setting up the event waiter | 16:47 |
| gibi | bauzas: would you accep the documentation in a separate patch? | 16:47 |
| artom | If we don't get to the driver code by the time Neutron sends us the event, it's lost | 16:47 |
| dansmith | artom: yeah, but neutron is sending the event in response to things we're doing, which just means whatever we do to trigger it needs to happen within the context | 16:48 |
| bauzas | gibi: yup | 16:48 |
| gibi | bauzas: coolio | 16:48 |
| bauzas | I can turn into a +1 if you prefer | 16:48 |
| gibi | bauzas: don't worry, I will respin anyhow | 16:48 |
| artom | dansmith, yeah - but we're poking Neutron in the compute manager, and setting up the waiter in the virt driver... | 16:49 |
| gibi | bauzas: just let me know if you spot any other issues | 16:49 |
| dansmith | artom: I understand | 16:49 |
| artom | From the virt driver, I should say. It's a call to the compute manager | 16:49 |
| artom | Hrmm, there's no RPC, mind you | 16:49 |
| artom | Just... a whole bunch of intermediary steps | 16:49 |
| *** wolverineav has joined #openstack-nova | 16:49 | |
| bauzas | gibi: I'm on it | 16:50 |
| gibi | bauzas: thanks a lot | 16:50 |
| bauzas | I wish I could help better, that's it | 16:50 |
| artom | dansmith, anyways, I'll try to come up with a least bad way of doing it, we'll have a strawman to pick apart | 16:51 |
| artom | At least you're on board with the need for change ;) | 16:52 |
| mriedem | artom: so we likely need 2 context managers to wait for separate events right? | 16:54 |
| *** wolverineav has quit IRC | 16:54 | |
| mriedem | one for the port binding host change, and one for the vif plug | 16:54 |
| mriedem | that port binding host change happens in several move operations we'd care about (at least resize and evacuate) | 16:54 |
| mriedem | and unshelve i think... | 16:54 |
| artom | mriedem, hrmm, you lost me, how would 2 context managers solve this? | 16:54 |
| mriedem | couldn't we create a helper method for that neutronv2.api method that updates the host in the port binding to register an event callback | 16:55 |
| mriedem | artom: we have 2 events to wait for yeah? | 16:55 |
| mriedem | so you wait for the first (port binding host change), then call the driver to spawn or whatever which does the vif plug | 16:55 |
| mriedem | which triggers the event we've always waited for | 16:55 |
| artom | mriedem, uhh, I thought it was Nova that PUT'ed the post binding host change? | 16:56 |
| mriedem | it does | 16:56 |
| artom | And that got us a vif-plugged as a "response"? | 16:56 |
| mriedem | and then we get an event from neutron that we're not waiting for | 16:56 |
| *** dpawlik has quit IRC | 16:56 | |
| mriedem | and then we actually plug vifs which produces another event yeah? | 16:57 |
| dansmith | artom: was it not updating instance_extra.migration_context, or was it not persisting the applied-from-context instance attributes? | 16:57 |
| artom | We are, sort us, we just start waiting after it gets to us, but yeah, you're basically right | 16:57 |
| dansmith | artom: I had assumed the former | 16:57 |
| artom | dansmith, the latter | 16:57 |
| dansmith | ah | 16:57 |
| dansmith | artom: which attributes of those specifically? | 16:57 |
| artom | dansmith, so I haven't looked into it in detail, but I'm told the new NUMA topology | 16:58 |
| dansmith | numa_topology? | 16:58 |
| dansmith | you probably need to do something to make those dirty, | 16:58 |
| artom | ... | 16:58 |
| * artom nopes right out. | 16:58 | |
| dansmith | since they're nested objects, they probably only save if the object itself is dirty | 16:58 |
| dansmith | artom: you need to give them "the talk" | 16:58 |
| artom | Right, tell them they've been naughty and need to be saved from their sins? | 16:59 |
| mdbooth | lyarwood: Ok, I can see in the tempest logs that tempest receives a 404 for GET volume *before* deleting the type, and I can see the same in the cinder logs. However, c-vol doesn't log the completion of the delete until some time later, which is *after* the attempted deletion of the type. | 17:00 |
| dansmith | they must not be marked as changed in the migration context, so I'm thinking just applying them to the instance and then calling save doesn't have them included in obj_what_changed() | 17:00 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.71 - show server group https://review.openstack.org/640657 | 17:00 |
| artom | mriedem, wait, plugging the vifs produces *another* event? | 17:00 |
| artom | mriedem, I need to flow through the code again in that case, because it means I don't have a complete picture | 17:01 |
| sean-k-mooney | artom: binding the vif produces a network-chaged event | 17:01 |
| mriedem | artom: that was the original reason for adding the context manager in the virt driver | 17:01 |
| artom | Oh, so binding -> network-changed | 17:01 |
| artom | vig plugging -> vif-plugged | 17:01 |
| mriedem | i don't think that's correct | 17:01 |
| sean-k-mooney | when the neutron agent plugs the vif we get a network-vif-plugged event | 17:01 |
| mriedem | if they were different events, we wouldn't be missing the 2nd event | 17:01 |
| * artom is hungry and can't think straight | 17:02 | |
| dansmith | the problem is the vif shows up on the destination, neutron notices and immediately sends the vif-plugged event right? | 17:02 |
| mdbooth | mriedem: lyarwood was having trouble with the timestamp tests being flaky and removed them in https://review.openstack.org/#/c/639331/ . I vaguely recall you previously expressing an opinion on these tests. | 17:02 |
| sean-k-mooney | i dont think we need to move the handeling of the network-chaged event | 17:02 |
| dansmith | before nova is ready to start it | 17:02 |
| mriedem | as far as i understand the problem, we change the port binding host and then plug vifs, which normally happens close enough that neutron sends a single network-vif-plugged event which we're waiting for by the time we plugged vifs and registered a callback in the virt driver | 17:02 |
| sean-k-mooney | dansmith: yep basically | 17:02 |
| dansmith | mriedem: and this is happening in the migrate case in a different place than it happens during spawn and that's the issue, right? | 17:03 |
| sean-k-mooney | neutron sees the port on the sorce because we have not clean it up yet so when the rollback of the migration happens and we set the host back to the source neturon send the vif-plugged event right away | 17:03 |
| dansmith | oh, it's the rollback case only? | 17:04 |
| artom | dansmith, revert resize is the downstream bug | 17:05 |
| artom | Hrmm, do we actually have 2 problems here? | 17:05 |
| bauzas | gibi: left yet another comment https://review.openstack.org/#/c/623543/39 | 17:05 |
| sean-k-mooney | dansmith: artom is fixing the rollback case. there is another race with sdn controler that send vif-plugged when you bind the port that this will also fix | 17:05 |
| dansmith | okay, I'm even less concerned then :) | 17:05 |
| bauzas | gibi: can't we do all of this on the libvirt driver anyway? | 17:05 |
| dansmith | the rollback case could just not wait for events since it's already on the source, I would think.. that would be a band-aid worth doing I would think | 17:06 |
| bauzas | gibi: but I guess it's not possible because you wanna claim() this | 17:06 |
| gibi | bauzas: looking | 17:06 |
| artom | dansmith, that'd be a weird bit of into to pass down to the virt driver, no? | 17:07 |
| artom | ... cuz we just call spawn there | 17:07 |
| dansmith | we already pass a similar flag in places don't we? | 17:08 |
| mriedem | mdbooth: i don't really remember that, but i'm assuming that timestamp stuff was copied from other scenario tests, and the commit message doesn't really explain the problem with the timestamp stuff | 17:08 |
| mriedem | just "it's bad" isn't very good | 17:08 |
| artom | dansmith, I'd have to check | 17:08 |
| dansmith | maybe I'm thinking about within the driver, but still | 17:08 |
| mriedem | dansmith: upstream it's at least known to be happening in evacuate | 17:08 |
| mriedem | http://status.openstack.org/elastic-recheck/#1813789 | 17:08 |
| gibi | bauzas: yeah we need the info to drive the pci claim | 17:09 |
| dansmith | mriedem: on evacuate, not evacuate and then restart-on-original-host right? | 17:09 |
| sean-k-mooney | ya i was going to say the same. but dan is right we could skip waiting in this case but i kindo of like not have another flag to pass down | 17:09 |
| *** psachin has quit IRC | 17:09 | |
| gibi | bauzas: does compute/manager have access to the ProvideTree? | 17:09 |
| bauzas | gibi: but you understand my concern, right? | 17:09 |
| dansmith | mriedem: the evac case seems ripe for just moving where we wait, but I haven't gone digging | 17:09 |
| sean-k-mooney | the flag would only fix the rollback case. artom change would fix the cisco aci/old odl case | 17:09 |
| bauzas | gibi: that's the problem, I don't think so | 17:09 |
| gibi | bauzas: I understand that we call placement a lot | 17:09 |
| sean-k-mooney | in addtion to rollbacks | 17:09 |
| *** wolverineav has joined #openstack-nova | 17:09 | |
| dansmith | artom: thinking of this: vifs_already_plugged=False, | 17:10 |
| bauzas | gibi: and say you have two pci requests for the same interface... | 17:10 |
| mriedem | gibi: bauzas: pretty sure the compute manager has a handle to the provider tree, | 17:10 |
| bauzas | it's a bit sad to query it twice | 17:10 |
| mriedem | because it has to clear it on sighup | 17:10 |
| *** tbachman has quit IRC | 17:10 | |
| mriedem | dansmith: i don't know the answer to that offhand | 17:10 |
| gibi | mriedem: ooh | 17:10 |
| artom | dansmith, ah, OK. It's still only a bandaid tho... | 17:10 |
| * dansmith has to jump on a call | 17:10 | |
| mriedem | gibi: bauzas: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L551 | 17:10 |
| artom | dansmith, thanks, that'll allow me to eat :P | 17:11 |
| gibi | bauzas: sure your concern is valid either I would like to use a ProviderTree or add a local cache | 17:11 |
| gibi | mriedem: looking | 17:12 |
| mdbooth | mriedem: The purpose of the timestamp stuff IIUC is to assert that the contents of the volume are preserved across the migration. I personally think it's an important test, but if it's problematic in practise we'd need to be pragmatic, e.g. removing or guarding it. NP if you don't have a strong opinion, lyarwood and I can fling fedoras at each other internally :) | 17:12 |
| gibi | bauzas, mriedem: so here in the compute/manager we only need the name of the RP and we know the UUID of it. So I guess I should be able to use the ProvideTree cache for that | 17:13 |
| mriedem | well, give a justifiable reason in the commit message to remove it | 17:13 |
| mriedem | need another core on the 2.71 novaclient change https://review.openstack.org/#/c/640657/ so we can get that into the final release | 17:14 |
| bauzas | gibi: the cache is a non-public information from the reportclient | 17:14 |
| bauzas | gibi: at the moment, I mean | 17:14 |
| bauzas | mriedem: on it | 17:15 |
| gibi | bauzas: but I call reportclient anyhow so I can call something else on the reportclient that uses the internal cache | 17:15 |
| *** agopi has joined #openstack-nova | 17:15 | |
| gibi | bauzas: it I fail then I will add a local cache to my code to query each RP once | 17:16 |
| bauzas | gibi: sure, I'm just saying that if you wanna use its cache, you have to make its attribute accessible | 17:16 |
| bauzas | either thru a getter or whatever | 17:16 |
| *** wolverineav has quit IRC | 17:16 | |
| gibi | bauzas: I will go with a new method (if not exists already) in reportclient that reads an RP from the cache | 17:17 |
| bauzas | I dislike at most accessing internal attributes in python | 17:17 |
| bauzas | even if that's allowed | 17:17 |
| bauzas | gibi: fine with me | 17:17 |
| bauzas | my point being "please don't just access self.reportclient.provider_tree" or whatever it's named | 17:18 |
| *** markvoelker has joined #openstack-nova | 17:18 | |
| *** tbachman has joined #openstack-nova | 17:19 | |
| *** Sundar has quit IRC | 17:20 | |
| gibi | bauzas: understood | 17:20 |
| bauzas | sorry but I have to bail out | 17:20 |
| bauzas | ++ | 17:20 |
| *** awalende has quit IRC | 17:21 | |
| *** sdake has joined #openstack-nova | 17:22 | |
| *** awalende has joined #openstack-nova | 17:22 | |
| gibi | bauzas: thanks a lot | 17:24 |
| gibi | bauzas: I will bail soon as well | 17:24 |
| gibi | bauzas: I will finish updating the patch tomorrow morning | 17:25 |
| *** awalende has quit IRC | 17:26 | |
| *** dtantsur is now known as dtantsur|afk | 17:29 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: fakelibvirt: Add ability to generate fake PCI devices https://review.openstack.org/640409 | 17:29 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Create PCI tests for NUMA'y tests https://review.openstack.org/640826 | 17:29 |
| *** dpawlik has joined #openstack-nova | 17:30 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706 | 17:31 |
| cfriesen | mriedem: this addresses almost all your comments. will split out the hardware.py stuff as you asked in the next revision | 17:32 |
| *** dpawlik has quit IRC | 17:34 | |
| *** wolverineav has joined #openstack-nova | 17:46 | |
| * gibi leaves for today | 17:47 | |
| *** mvkr has quit IRC | 17:48 | |
| *** mrch_ has joined #openstack-nova | 17:51 | |
| *** markvoelker has quit IRC | 17:51 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | 17:56 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: qemu: Make disk image conversion dramatically faster https://review.openstack.org/640781 | 17:57 |
| *** tssurya has quit IRC | 17:58 | |
| mriedem | cfriesen: wouldn't a deactivate image (even if it doesn't change) on resize fail the resize if the dest host can't download the image (and it's not cached)? | 17:58 |
| cfriesen | mriedem: good question. I seem to remember some scenarios where it copies it from the cache on the source...but let me check. | 18:00 |
| mriedem | maybe if you're using shared storage? | 18:04 |
| mriedem | but not everyone does | 18:04 |
| *** derekh has quit IRC | 18:05 | |
| mriedem | i believe the libvirt driver code falls back to pull from the source if it's not in the dest image cache | 18:05 |
| mriedem | or tries to | 18:05 |
| mriedem | mdbooth probably knows better | 18:05 |
| * mriedem runs to lunch, bbl | 18:05 | |
| *** mriedem has quit IRC | 18:05 | |
| *** wolverineav has quit IRC | 18:06 | |
| *** ociuhandu has joined #openstack-nova | 18:11 | |
| *** wolverineav has joined #openstack-nova | 18:14 | |
| aspiers | gah, looks like functional tests for https://review.openstack.org/#/c/538498/ failed in the gate | 18:18 |
| aspiers | http://logs.openstack.org/98/538498/22/gate/nova-tox-functional/d76478b/testr_results.html.gz has a bunch of errors like "oslo_config.cfg.NoSuchOptError: no such option sync_on_startup in group [placement_database]" | 18:18 |
| aspiers | does that make sense to anyone | 18:18 |
| aspiers | ? | 18:18 |
| *** dpawlik has joined #openstack-nova | 18:19 | |
| *** Sundar has joined #openstack-nova | 18:22 | |
| *** ralonsoh has quit IRC | 18:22 | |
| * aspiers finds https://github.com/openstack/placement/commit/da36ad16e15181eb8b72f04cb3b90f8009411c23 and looks at cdent and efried | 18:23 | |
| *** dpawlik has quit IRC | 18:24 | |
| *** whoami-rajat has quit IRC | 18:24 | |
| cdent | aspiers: that's interesting, it should default to false | 18:24 |
| cdent | except that's not what the error says, it says the conf option doesn't exist | 18:25 |
| aspiers | right | 18:25 |
| aspiers | totally weird that this should appear in the gate but not in the check | 18:25 |
| cdent | which means the gate doesn't have the right code... | 18:25 |
| sean-k-mooney | aspiers ist it posble that it was usign the inrepo placement? | 18:25 |
| sean-k-mooney | it does not exist here https://github.com/openstack/nova/blob/master/nova/conf/placement.py | 18:26 |
| cdent | sean-k-mooney: the fix should be using an indepdent conf | 18:27 |
| cdent | and according to the failures it's using the external placement | 18:27 |
| cdent | however | 18:27 |
| cdent | it might be that the fixture needs to be tweakd. | 18:27 |
| cdent | aspiers: if you have the time can you try to run the functional tests locally on a clean tox? | 18:28 |
| * cdent tries too | 18:28 | |
| aspiers | cdent: sure | 18:28 |
| sean-k-mooney | well looking at code search it only exists in placement http://codesearch.openstack.org/?q=sync_on_startup&i=nope&files=&repos= | 18:28 |
| aspiers | right | 18:28 |
| aspiers | cdent: but the zuul check already did that and passed ... | 18:29 |
| cdent | aspiers: yes, but that change (to add that config) merged to placement several minutes ago so maybe it wasn't there in check | 18:30 |
| *** tesseract has quit IRC | 18:30 | |
| sean-k-mooney | cdent: if it only merged a few minuts ago its not in pypi | 18:31 |
| sean-k-mooney | the last relase was feb 13th https://pypi.org/project/osc-placement/#history | 18:31 |
| sean-k-mooney | sorry wrong repo | 18:32 |
| sean-k-mooney | january 7th https://pypi.org/project/openstack-placement/#history | 18:32 |
| cdent | sean-k-mooney: it should be installed a tox-sibling, not from pypi | 18:32 |
| cdent | otherwise it wouldn't work as a fixture-to-use-master | 18:32 |
| cdent | aspiers: i've repeated here | 18:32 |
| cdent | so I reckon it's a bug in the fixture | 18:33 |
| sean-k-mooney | perhaps in which case then ya it could be jsut a a timing window | 18:33 |
| aspiers | ah | 18:33 |
| sean-k-mooney | aspiers: do you have a depends on on that placmenet change | 18:33 |
| sean-k-mooney | aspiers: that would have prevented any race | 18:33 |
| aspiers | no I didn't know about the change until just now | 18:33 |
| cdent | sean-k-mooney: not in the case | 18:33 |
| cdent | the fixture has a real bug | 18:33 |
| sean-k-mooney | cdent: oh ok | 18:33 |
| sean-k-mooney | aspiers: generally depens on helps bug not in all cases | 18:34 |
| aspiers | is it possible to do rechecks on the gate? | 18:34 |
| sean-k-mooney | yep | 18:34 |
| sean-k-mooney | just a normal recheck | 18:34 |
| sean-k-mooney | we used to have reverify years ago but not anymore | 18:34 |
| sean-k-mooney | reverify just ran gate | 18:35 |
| sean-k-mooney | recheck will run check and gate | 18:35 |
| cdent | aspiers: I'll see about fixing this | 18:38 |
| cdent | as in, now | 18:38 |
| sean-k-mooney | im going to grab dinner. be back in an hour or so | 18:39 |
| *** panda|ruck is now known as panda|ruck|off | 18:41 | |
| *** markvoelker has joined #openstack-nova | 18:48 | |
| cdent | ah. aspiers, kind of figured it out. Those tests which are failing are using the placement database fixture directly, not through the Placement fixture, thus the the config opt is not registered, leading to plenty of confusion | 18:49 |
| cdent | aspiers: https://bugs.launchpad.net/nova/+bug/1818560 | 18:53 |
| openstack | Launchpad bug 1818560 in OpenStack Compute (nova) "Nova's use of the placement database fixture from test_report_client doesn't register opts" [Critical,Confirmed] | 18:53 |
| cdent | in case I wasn't clear there, the fix is on the placement side | 18:53 |
| *** pcaruana has quit IRC | 18:56 | |
| *** whoami-rajat has joined #openstack-nova | 18:58 | |
| *** jlvillal has quit IRC | 18:58 | |
| *** jlvillal has joined #openstack-nova | 18:59 | |
| *** IvensZambrano has quit IRC | 19:01 | |
| *** mdbooth_ has joined #openstack-nova | 19:04 | |
| *** mdbooth has quit IRC | 19:07 | |
| *** sdake has quit IRC | 19:07 | |
| *** mriedem has joined #openstack-nova | 19:11 | |
| cdent | aspiers: there are two levels of problem here | 19:15 |
| *** wolverineav has quit IRC | 19:15 | |
| *** wolverineav has joined #openstack-nova | 19:16 | |
| cdent | requires fixes in both placement and nova, mabye | 19:16 |
| cdent | still looking to try to figure out the cleanest way | 19:16 |
| *** agopi has quit IRC | 19:18 | |
| *** agopi_ has joined #openstack-nova | 19:18 | |
| aspiers | cdent: awesome, thanks! | 19:19 |
| mriedem | dansmith: am i missing what you're asking for here? https://review.openstack.org/#/c/636412/1/nova/scheduler/client/report.py@1758 | 19:19 |
| dansmith | mriedem: ah, sorry I missed that the original change was already including one direction | 19:20 |
| *** markvoelker has quit IRC | 19:21 | |
| mriedem | i love one direction | 19:21 |
| aspiers | X-D | 19:21 |
| cfriesen | mriedem: in the case of resize, I think the fact that sometimes it *can* go through (if the image is already cached, or we're using "raw") means that we can't fail the operation due to image inactivity. | 19:22 |
| mriedem | cfriesen: sure | 19:22 |
| mriedem | not a huge sticking point for me | 19:22 |
| *** awalende has joined #openstack-nova | 19:23 | |
| *** openstackgerrit has quit IRC | 19:23 | |
| *** openstackgerrit has joined #openstack-nova | 19:25 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706 | 19:25 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Improve existing flavor and image metadata validation https://review.openstack.org/640841 | 19:25 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Flavor extra spec and image properties validation from API https://review.openstack.org/620706 | 19:26 |
| cfriesen | figured I'd differentiate the two titles a bit better | 19:27 |
| eandersson | nova-hostname (from metadata) is set by dhcp_domain right? | 19:27 |
| eandersson | That is deprecated | 19:27 |
| eandersson | What is supposed to populate that field? | 19:27 |
| *** awalende has quit IRC | 19:28 | |
| mriedem | eandersson: you just stepped into something | 19:28 |
| mriedem | eandersson: https://bugs.launchpad.net/nova/+bug/1698010 | 19:29 |
| openstack | Launchpad bug 1698010 in OpenStack Compute (nova) "neutron-based instances should not use the nova-network 'dhcp_domain' option" [High,In progress] - Assigned to Stephen Finucane (stephenfinucane) | 19:29 |
| sean-k-mooney | eandersson: if you dont have designate deployed i dont think neutron will populate that value. | 19:30 |
| sean-k-mooney | ignoring the nova bug | 19:30 |
| melwitt | dansmith, mriedem: I updated the user_id patch to make the field non-nullable. unit tests are all broken and some/all of the next patch need to be squashed in, but the next patch passes grenade/tempest. I hoped for a sanity check from you before I go ahead and do any commit squashing and unit test fixing https://review.openstack.org/633350 | 19:32 |
| cdent | aspiers: you should be proud, you've found a hole in the space time continuium, I'm looping back on myself | 19:32 |
| aspiers | cdent: just don't destroy the universe in the process | 19:33 |
| *** eharney has quit IRC | 19:33 | |
| cdent | efried: are you back yet? I think I might need to consult with you on this | 19:35 |
| cdent | the issue I'm trying to contend with this that at https://github.com/openstack/nova/blob/master/nova/tests/functional/test_report_client.py#L124 that CONF is a nova conf, not a placement CONF | 19:36 |
| cdent | so now that we've added a new conf item to placement things are awry | 19:36 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Parse <emulator> elements from virConnectGetCapabilities() https://review.openstack.org/640483 | 19:40 |
| mriedem | melwitt: it looks like what i'd expect | 19:42 |
| melwitt | mriedem: thank ya | 19:43 |
| mriedem | jackding: are you able to rebase this? https://review.openstack.org/#/c/603844/ | 19:44 |
| mriedem | jaypipes: ^ i think i answered your question in there | 19:44 |
| dansmith | melwitt: I gotta run to an appt but will try to look when I get back | 19:45 |
| melwitt | dansmith: ok, thank you | 19:45 |
| jackding | mriedem: will do | 19:46 |
| eandersson | thanks mriedem sean-k-mooney | 19:49 |
| cfriesen | jaypipes: FYI, this was based on an instance seen in the wild. | 19:50 |
| *** agopi_ is now known as agopi | 19:50 | |
| cfriesen | jaypipes: (re: your question in jackding's review) | 19:51 |
| openstackgerrit | Jack Ding proposed openstack/nova master: Correct instance port binding for rebuilds https://review.openstack.org/603844 | 19:53 |
| jackding | mriedem: rebase done. Thanks | 19:54 |
| mriedem | cfriesen: real soft -1 on https://review.openstack.org/#/c/640841/ | 19:56 |
| mriedem | just update an existing api unit test and i'm +2 | 19:56 |
| cfriesen | cool, will respin | 19:56 |
| jaypipes | cfriesen: that's why I didn't -1 it... | 20:00 |
| jaypipes | cfriesen: I wasn't 100% sure about it. | 20:00 |
| *** thgcorrea has quit IRC | 20:00 | |
| jaypipes | jackding: I've +2'd 603844 since mriedem was +2 on it previously. | 20:04 |
| *** Sundar has quit IRC | 20:06 | |
| eandersson | Something got a lot more expensive for us after moving to Rocky | 20:08 |
| eandersson | It looks like Neutron is getting a lot more calls | 20:08 |
| *** jmlowe has quit IRC | 20:08 | |
| eandersson | but difficult to say what is causing cpu load to increase so drastically | 20:08 |
| eandersson | We upgraded Nova, Neutron and Cinder | 20:09 |
| eandersson | and CPU load has gone up 5x | 20:09 |
| *** wolverineav has quit IRC | 20:09 | |
| eandersson | Anyone seen this? | 20:09 |
| sean-k-mooney | eandersson: are you using OSP? | 20:09 |
| eandersson | What is OSP? | 20:09 |
| sean-k-mooney | redhat openstack plathform | 20:10 |
| eandersson | nah | 20:10 |
| eandersson | Running something closer to Kolla | 20:10 |
| sean-k-mooney | ok we had a perfromce issue awhile ago that was related to not enableing memcahce to cache keystone auth tokens the slowed everything down | 20:10 |
| eandersson | We do have that enabled | 20:14 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use a placement conf when testing report client https://review.openstack.org/640853 | 20:14 |
| eandersson | Assuming you don't need that con computes right? | 20:14 |
| sean-k-mooney | the compute nodes do hit the neutron and cinder apis | 20:14 |
| sean-k-mooney | i dont know if you need/should configure caching on those too | 20:15 |
| cdent | aspiers: https://review.openstack.org/#/q/topic:bug/1818560 should fix it. mriedem: that's a gate blocker fix for functional/test_report_client | 20:15 |
| mriedem | is that just preventing https://review.openstack.org/#/c/538498/ from merging or are all nova changes now broken? | 20:16 |
| cdent | mriedem: I think all | 20:16 |
| mriedem | what changed/regressed? | 20:17 |
| cdent | the fact that nova's conf was being used to run a placement wsgi app was revealed | 20:17 |
| cdent | by the fact that we added a config on the placement side | 20:17 |
| mriedem | link to the placement change? | 20:18 |
| cdent | so it was going to happen as soon as that divergence happened and it just so happens it was today | 20:18 |
| *** markvoelker has joined #openstack-nova | 20:18 | |
| cdent | mriedem: it's linked from both commit messages at the topic above | 20:18 |
| mriedem | https://review.openstack.org/#/c/619050/ | 20:18 |
| mriedem | ok i was looking at the bug | 20:18 |
| cdent | the bug description wasn't quite right, because I was trying to be hasty | 20:19 |
| *** dpawlik has joined #openstack-nova | 20:20 | |
| cdent | I've udpated the title and description | 20:23 |
| efried | cdent: I'm back now. How can I help? | 20:23 |
| cdent | efried: I figured it out, but if you could review https://review.openstack.org/#/q/topic:bug/1818560 to confirm I figured it out the right way, that would be good | 20:24 |
| *** dpawlik has quit IRC | 20:25 | |
| efried | ... | 20:25 |
| mriedem | cdent: comments inline but if it passes it passes | 20:28 |
| mriedem | we likely need to talk about test coverage for the externally-used placement fixture | 20:29 |
| mriedem | *at some point | 20:29 |
| cdent | yes | 20:30 |
| cdent | but I figured at this stage of the game it was better to just fix it | 20:30 |
| mriedem | yeah i agree | 20:30 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Improve existing flavor and image metadata validation https://review.openstack.org/640841 | 20:30 |
| sean-k-mooney | mriedem: cdent i dont know if we could somehow run the nova functional tests on change to the placement repo or perhaps just that fixture in the placmeent repo? | 20:34 |
| efried | cdent: ugh, I had wanted to get rid of either PlacementFixture or PlacementDirect, and now we've made them inextricably interdependent. | 20:34 |
| cdent | efried: we already had both and we're trying to make a quick fix | 20:35 |
| cdent | that doesn't remove the possibility of fixing it better late | 20:35 |
| efried | yeah, I get it. | 20:35 |
| cdent | I personally think we should get rid of PlacementDirect, probably by exposing the intercept functionality in PlacementFixture | 20:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Flavor extra spec and image properties validation from API https://review.openstack.org/620706 | 20:35 |
| cdent | PlacementDirect is for a _very_ specific thing, in which a placement conf (a real one) is expected to exist | 20:36 |
| cdent | however I have seen zero evidence that PlacementDirect ever should have existed, so I'm not inclined to put a lot of energy into it | 20:36 |
| cdent | (for now) | 20:36 |
| cdent | s/get rid of/get rid of (on the nova side)/ | 20:37 |
| sean-k-mooney | by the way i assume the current lag in jobs starting in the gate is jsut the usual 3 days to feature freeze lag? | 20:37 |
| cfriesen | no, zuul has a personal grudge | 20:38 |
| melwitt | speaking of test coverage, mnaser: how goes it with the OSA job patch? https://review.openstack.org/635852 | 20:38 |
| mriedem | btw http://status.openstack.org/elastic-recheck/data/integrated_gate.html "Generated at: 2019-02-08" so we don't know the true status of the gate right now | 20:38 |
| mriedem | clark is investigating | 20:39 |
| *** BlackDex has quit IRC | 20:39 | |
| sean-k-mooney | cfriesen: :) first jenkins and now zuul well at least the ci is consitnt | 20:39 |
| mnaser | melwitt: that test should be working and pulling down nova | 20:39 |
| mnaser | we could probably add it as non voting | 20:39 |
| mnaser | i need to find time to integrate os_placement into the main tests/roles but | 20:39 |
| mnaser | a lot of our cores were laid off so we're struggling in osa land </3 | 20:39 |
| melwitt | oh :( | 20:40 |
| melwitt | I'm sorry to hear that | 20:40 |
| cfriesen | This is a standalone disk performance optimization patch...has +1 from mdbooth. https://review.openstack.org/#/c/616692/ | 20:40 |
| mnaser | yeah, so just trying to keep things afloat, the placement role is ready but ill make sure we get a job that continues to deploy using in-repo placement, and another one that deploys using out-of-repo | 20:40 |
| melwitt | mnaser: ok, I wasn't sure what the job in that patch is missing/why WIP | 20:41 |
| mnaser | melwitt: i wanted to leave it that way in case someone was to make an OSA change that starts deploying with out-of-repo by default and then the job becomes redundant | 20:41 |
| mnaser | i need to put sometime to add an extra tox target to deploy with in-repo placement, which will ensure we don't accidentally start testing from out-of-tree when we switch the default | 20:42 |
| melwitt | oh, I see | 20:43 |
| *** tbachman has quit IRC | 20:43 | |
| mnaser | i'll get around that eventually | 20:44 |
| mnaser | (and i can help someone if they want to help do it as well) | 20:44 |
| melwitt | ok, and that's different than the TODO here? https://review.openstack.org/#/c/635852/1/.zuul.yaml@211 | 20:45 |
| mnaser | melwitt: oh no that's exactly that todo :P | 20:46 |
| *** jmlowe has joined #openstack-nova | 20:46 | |
| melwitt | "without placement" confused me bc whether it's in-repo or out, I thought that's still "with placement" :P | 20:47 |
| mnaser | pretty much involves creating a new tox.ini target in openstack/openstack-ansible-os_nova and creating an extra var like "nova_use_in_repo_placement=True" | 20:47 |
| mnaser | yeah that should say "without os_placement" (which is our extra role) | 20:47 |
| melwitt | ahhh | 20:47 |
| melwitt | and the role is already merged? I can try the tox target thing but I have no clue what I'm doing | 20:48 |
| *** BlackDex has joined #openstack-nova | 20:48 | |
| *** markvoelker has quit IRC | 20:51 | |
| *** sdake has joined #openstack-nova | 20:51 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use a placement conf when testing report client https://review.openstack.org/640853 | 20:55 |
| *** dpawlik has joined #openstack-nova | 20:55 | |
| cdent | mriedem, efried: it will soon be past my bedtime, if you need/want more changes to that ^ and it's partner please feel free | 20:56 |
| efried | ack | 20:56 |
| *** IvensZambrano has joined #openstack-nova | 20:57 | |
| efried | cdent: what's up with the merge failure? | 20:57 |
| cdent | it's because I submitted the dependent change at the same time | 20:58 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: cpu-model-selection: s/cpu_models/cpu_model_list/ https://review.openstack.org/640866 | 20:59 |
| *** dpawlik has quit IRC | 21:00 | |
| *** wolverineav has joined #openstack-nova | 21:02 | |
| *** whoami-rajat has quit IRC | 21:04 | |
| *** awaugama has quit IRC | 21:14 | |
| *** cdent has quit IRC | 21:25 | |
| *** eharney has joined #openstack-nova | 21:28 | |
| *** mvkr has joined #openstack-nova | 21:29 | |
| mriedem | cfriesen: some questions in https://review.openstack.org/#/c/620706/ | 21:31 |
| mriedem | cfriesen: happy to discuss here | 21:31 |
| cfriesen | checking | 21:31 |
| openstackgerrit | guang-yee proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | 21:31 |
| openstackgerrit | guang-yee proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | 21:33 |
| cfriesen | mriedem: I've got a change queued up for get_pci_requests_from_flavor. can add to existing or do as followup. Happy to split out PciInvalidAlias. | 21:34 |
| cfriesen | rest of comments look reasonable, will address later today. | 21:35 |
| mriedem | cfriesen: i'd split as much as possible for review sanity | 21:35 |
| *** hemna has joined #openstack-nova | 21:35 | |
| cfriesen | the get_pci_requests_from_flavor change is pretty straightforward, just hadn't pushed it yet since I was expecting to respin this. | 21:36 |
| *** sdake has quit IRC | 21:41 | |
| *** sdake has joined #openstack-nova | 21:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: cleanup pci.alias references https://review.openstack.org/640882 | 21:43 |
| *** markvoelker has joined #openstack-nova | 21:49 | |
| *** mriedem has quit IRC | 21:50 | |
| *** tbachman has joined #openstack-nova | 21:51 | |
| *** rnoriega has quit IRC | 21:52 | |
| *** klindgren_ has joined #openstack-nova | 21:52 | |
| *** rnoriega has joined #openstack-nova | 21:52 | |
| *** klindgren has quit IRC | 21:53 | |
| *** smcginnis has quit IRC | 21:53 | |
| *** zzzeek has quit IRC | 21:54 | |
| *** zzzeek has joined #openstack-nova | 21:54 | |
| openstackgerrit | Merged openstack/nova master: Add nits from Id2beaa7c4e5780199298f8e58fb6c7005e420a69 https://review.openstack.org/640729 | 21:58 |
| *** wolverineav has quit IRC | 22:03 | |
| *** wolverineav has joined #openstack-nova | 22:06 | |
| *** betherly has joined #openstack-nova | 22:07 | |
| *** wolverineav has quit IRC | 22:11 | |
| *** betherly has quit IRC | 22:12 | |
| sean-k-mooney | from the description of https://review.openstack.org/#/c/603844/ im not sure if its needed due to https://review.openstack.org/#/c/634276/ | 22:14 |
| sean-k-mooney | it look like we are fixign the same or related bugs in different ways on both the nova and neutron side. | 22:15 |
| sean-k-mooney | that said i need to review https://review.openstack.org/#/c/603844/ properly | 22:15 |
| *** wolverineav has joined #openstack-nova | 22:18 | |
| *** markvoelker has quit IRC | 22:21 | |
| *** Sundar has joined #openstack-nova | 22:29 | |
| *** zhubx has quit IRC | 22:29 | |
| *** zhubx has joined #openstack-nova | 22:30 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Stop using PlacementDirect https://review.openstack.org/640887 | 22:31 |
| efried | mriedem, cdent: A different solution ^ | 22:31 |
| sean-k-mooney | efried: ignore whitespacce helps alot | 22:38 |
| efried | sean-k-mooney: Indeed. | 22:39 |
| efried | Are you telling me that having seen my comment already? | 22:39 |
| sean-k-mooney | initally i tought you rewrote most of the file. and yes i was about to ask if they were fucntuionally the same after then i made that change looked and commented on irc | 22:40 |
| sean-k-mooney | so basically you removed the _interceptor context manager which used placement direct and instead repace teh client with the versionCheckingReportClient after enabling the placemetnFixture | 22:43 |
| *** agopi has quit IRC | 22:44 | |
| *** sdake has quit IRC | 22:50 | |
| sean-k-mooney | efried: im more or less trusting that you ran the fucntional test locally with master placement and it worked but ya droping placement direct form the fuctional test makes sense. | 22:51 |
| sean-k-mooney | is there a similar followup to remove placement direct form placement itself or is there a usecase to keep it in placement | 22:52 |
| efried | sean-k-mooney: I ran those two suites locally. I didn't run the whole world. | 22:52 |
| efried | letting zuul do that. | 22:52 |
| efried | We don't know whether there's a real use case, cdent and I were talking about that (again) earlier. | 22:52 |
| sean-k-mooney | hehe ya thats resonable :) zull is rather slow currently | 22:52 |
| efried | It was deemed a hard requirement for something-or-other (we can't remember exactly what) for extraction, so we did it. | 22:52 |
| efried | but at this point it's not clear that it's needed at all. | 22:53 |
| *** slaweq has quit IRC | 22:53 | |
| efried | I want to say maybe it was going to be a prerequisite for cinder using it in certain cases | 22:53 |
| efried | but then in denver they decided they weren't going to use placement for those cases | 22:53 |
| efried | so it's possible it will never be needed. | 22:53 |
| efried | cdent did point out that it would probably be expected to work better from "real deployment" than from test | 22:54 |
| *** smcginnis has joined #openstack-nova | 22:54 | |
| sean-k-mooney | placement direct just allows you to bypass the placement api is thtat correct? | 22:54 |
| efried | anyway, at this point I think the plan is to let it languish, see if anyone decides they want/need it, and if/when they do, find out if it's broken for whatever problem they're trying to solve. | 22:54 |
| efried | sean-k-mooney: You're not bypassing it. It behaves as a real placement service. It just doesn't go "over the wire" and uses an in-memory database (I think). | 22:55 |
| efried | sean-k-mooney: It really does effectively the same thing as PlacementFixture, just in a slightly different way. | 22:55 |
| sean-k-mooney | oh i tougth you could use placemetn direct to talk to a real database too | 22:55 |
| efried | I don't understand all the "wsgi intercept" magic. | 22:55 |
| *** tbachman has quit IRC | 22:55 | |
| efried | oh, yeah, I think you can. | 22:55 |
| efried | in this case we didn't want to do that, because we wanted to use a fixture. | 22:56 |
| *** dpawlik has joined #openstack-nova | 22:56 | |
| *** tkajinam has joined #openstack-nova | 22:56 | |
| sean-k-mooney | so addmitly flawed understading was it was a way to run a placement api service in process to directly acess and maniupluate placement without needing to go over the wire | 22:56 |
| sean-k-mooney | e.g. just skip the http transprot part | 22:57 |
| efried | yes | 22:57 |
| efried | sorry, I was focused in on the change I just made, where I believe we were faking the database as well. | 22:57 |
| sean-k-mooney | oh ya in the fuctional test i woudl expect us to be using a fake deb or a per test sqlite db | 22:58 |
| *** tbachman has joined #openstack-nova | 22:58 | |
| efried | sean-k-mooney: Yeah, https://review.openstack.org/#/c/640887/1/nova/tests/functional/test_report_client.py@a95 | 22:58 |
| efried | mocking the db | 22:58 |
| sean-k-mooney | right makes sense. | 22:59 |
| *** dpawlik has quit IRC | 23:00 | |
| *** slaweq has joined #openstack-nova | 23:01 | |
| *** luksky has quit IRC | 23:02 | |
| *** slaweq has quit IRC | 23:05 | |
| *** Sundar has quit IRC | 23:12 | |
| *** sdake has joined #openstack-nova | 23:12 | |
| *** mlavalle has quit IRC | 23:16 | |
| *** betherly has joined #openstack-nova | 23:16 | |
| *** markvoelker has joined #openstack-nova | 23:18 | |
| *** betherly has quit IRC | 23:20 | |
| *** openstackgerrit has quit IRC | 23:28 | |
| *** tosky has quit IRC | 23:28 | |
| *** marst has quit IRC | 23:32 | |
| *** sdake has quit IRC | 23:35 | |
| *** dpawlik has joined #openstack-nova | 23:37 | |
| *** dklyle has quit IRC | 23:39 | |
| *** dpawlik has quit IRC | 23:41 | |
| *** mriedem has joined #openstack-nova | 23:43 | |
| mriedem | efried: i'm +2 on cdent's gate fixes https://review.openstack.org/#/q/topic:bug/1818560+(status:open+OR+status:merged) - i see you have an alternative but i can't grok that right now | 23:45 |
| mriedem | and we could do your alternative later yeah? | 23:45 |
| sean-k-mooney | mriedem: looking at cdents change yes there woudl be no real conflcit with merging that quick and then efried change | 23:46 |
| *** macza has quit IRC | 23:48 | |
| sean-k-mooney | efried: change looks resoable to me as it just drops teh use of placement direct an swaps to useing the palcement fixture instead but i also dont review the report clinet stuff often so im +1 but i also am not that familar those tests | 23:48 |
| sean-k-mooney | mriedem: ^ | 23:49 |
| *** eharney has quit IRC | 23:51 | |
| sean-k-mooney | mriedem: for what its work like at the live ci log it just passed all the functional test and should report back in about 3-4 mins | 23:51 |
| *** markvoelker has quit IRC | 23:51 | |
| sean-k-mooney | http://logs.openstack.org/87/640887/1/check/nova-tox-functional/1ba43e5/testr_results.html.gz | 23:51 |
| sean-k-mooney | that ^ is the result of efried alternitve | 23:52 |
| mriedem | the gate is broken and it's 6pm and i literally do not want to spend the time reviewing a new change | 23:52 |
| *** wolverineav has quit IRC | 23:52 | |
| mriedem | i only logged back on to +2 those changes | 23:52 |
| mriedem | and now i'm dropping of | 23:52 |
| mriedem | *off | 23:52 |
| mriedem | o/ | 23:52 |
| *** mriedem has quit IRC | 23:52 | |
| sean-k-mooney | mriedem: sure night o/ | 23:53 |
| *** IvensZambrano has quit IRC | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!