| dansmith | mriedem: melwitt Kevin_Zheng: sent a reply to the list | 00:03 |
|---|---|---|
| *** wolverineav has quit IRC | 00:03 | |
| *** macza has quit IRC | 00:04 | |
| *** wolverineav has joined #openstack-nova | 00:04 | |
| Kevin_Zheng | dansmith: cool, thanks, will check it later | 00:05 |
| dansmith | Kevin_Zheng: no, you will check it now! | 00:06 |
| dansmith | I mean, of course :P | 00:06 |
| mriedem | Kevin_Zheng: i left some comments in that functional test | 00:07 |
| mriedem | Kevin_Zheng: i'd like to see a functional test that exercises that when attaching a new root volume with a new image, we properly update the request spec to ensure we unshelve on a host that only works for that new image | 00:08 |
| *** wolverineav has quit IRC | 00:08 | |
| melwitt | I definitely sympathize with the idea of not wiping the tag on detach. that was my worry, was someone not realizing that would happen | 00:09 |
| melwitt | I need more brain to think about the rest of it right now | 00:10 |
| *** slaweq has joined #openstack-nova | 00:11 | |
| *** munimeha1 has quit IRC | 00:11 | |
| mriedem | where the virus lives | 00:12 |
| mriedem | nice | 00:12 |
| *** itlinux_ has quit IRC | 00:13 | |
| *** mvkr has joined #openstack-nova | 00:14 | |
| *** slaweq has quit IRC | 00:15 | |
| Kevin_Zheng | mriedem: I will try to write one today | 00:17 |
| *** itlinux has joined #openstack-nova | 00:17 | |
| melwitt | a virus? geez kevin | 00:17 |
| *** tosky has quit IRC | 00:18 | |
| artom | mriedem, I don't even know anymore. I saw we revert device tagging altogether, who needs it anyways? | 00:19 |
| artom | *say | 00:19 |
| Kevin_Zheng | melwitt: I will try my best:) | 00:21 |
| Kevin_Zheng | Check the news tomorrow | 00:21 |
| melwitt | :D | 00:22 |
| mriedem | trump told us we can't trust those huawei guys | 00:23 |
| artom | Out of curiosity, do we have a way to scope CONF objects (fixtures?) to a single service in func tests - specifically, I want 2 computes with different vcpu_pin_set (for example) | 00:24 |
| mriedem | dansmith: Kevin_Zheng: replied with some questions for clarification - i know it's getting late so probably have to pick this up tomorrow | 00:24 |
| mriedem | Kevin_Zheng: regardless of the tag decision, my comments on the functional tests are probably enough to keep you busy for a bit | 00:24 |
| mriedem | artom: since CONF is global changes are no | 00:25 |
| mriedem | *chances | 00:25 |
| melwitt | artom: I _think_ you can do that by self.flags(value for compute 1) start compute service 1, self.flags(value for compute 2), start compute service 2 | 00:25 |
| mriedem | there is a ConfFixture, and fixtures are context managers, | 00:25 |
| mriedem | so it's possible you could temporarily set config via context | 00:26 |
| melwitt | but maybe it won't stick, if it's going to look at it after startup | 00:26 |
| mriedem | i'm going to be in big trouble for not getting dinner started so i have to run | 00:26 |
| *** mriedem is now known as mriedem_away | 00:26 | |
| melwitt | yeah, maybe what I said would only work if it's a conf value only considered during init_host | 00:26 |
| artom | Reason I'm asking is - without this, I don't see a way to func test NUMA LM meaningfully | 00:27 |
| artom | melwitt, that'd be enough, I tihnk | 00:27 |
| dansmith | melwitt: only if the values are read and cached at start | 00:27 |
| dansmith | when I wrote the oschown thing, I chased that down | 00:27 |
| dansmith | it's a huge problem | 00:27 |
| melwitt | yeah, I think it won't work if the conf option is read later on | 00:27 |
| dansmith | in that it's completely fundamentally global as heck forever | 00:27 |
| melwitt | but I know I've done something like this before in func test where it was startup only | 00:27 |
| melwitt | haha yeah | 00:27 |
| dansmith | melwitt: right, if it's read at startup and ever again, and it does that before the start returns, then it'll work, but it's fragile | 00:28 |
| melwitt | yeah. definitely not saying it's robust | 00:28 |
| artom | Bleah, vpcu_pin_set is read after startup | 00:28 |
| melwitt | it's the kind of janky thing I do in tests when I find them | 00:28 |
| melwitt | after the desperation sets in | 00:29 |
| artom | dansmith, so, we can follow up on ML, but I think that rules out NUMA LM func testing? | 00:30 |
| artom | I don't see another way to "force a conflict", so to speak | 00:30 |
| *** dpawlik has joined #openstack-nova | 00:30 | |
| dansmith | artom: it means you have to mock something out, which we try to avoid in functional tests, but can't really avoid for hardware things (like virt driver stuff) | 00:31 |
| dansmith | which is why functional is not enough | 00:31 |
| *** wolverineav has joined #openstack-nova | 00:31 | |
| artom | dansmith, mock to different values with 2 compute services running? | 00:31 |
| dansmith | artom: mock somewhere other than config | 00:31 |
| dansmith | artom: we have useful functional tests for other things that depend on global state | 00:32 |
| dansmith | it's not trivial to do, but it's doable | 00:32 |
| artom | dansmith, can I have an example? I'll use that as inspiration :) | 00:32 |
| dansmith | artom: the cells stuff all depends on a completely global DB state | 00:33 |
| dansmith | it's been a challenge to get that stuff working because it's so global, but like numa, it's hard to test multiple cells for real, so they're quite useful | 00:33 |
| artom | dansmith, NUMA is a matter of hardware | 00:34 |
| *** zhubx has quit IRC | 00:34 | |
| dansmith | what's your point | 00:34 |
| *** dpawlik has quit IRC | 00:34 | |
| dansmith | ? | 00:34 |
| artom | Err, good question :) | 00:34 |
| *** zhubx has joined #openstack-nova | 00:34 | |
| dansmith | it still requires a non-trivial environment to test for real, as does multiple cells | 00:35 |
| artom | I guess you only need 1 (or 2, for migrations) NUMA machines | 00:35 |
| artom | For real multi-cell you'd need... how much, actually? | 00:35 |
| dansmith | you can do it all in one box, but it's not trivial to set up | 00:35 |
| dansmith | either way, | 00:35 |
| dansmith | you're drawing parallels that don't matter... it's a complicated thing that is hard to test for real, so extra work in making more-than-unit tests are worthwhile.. It all depends on some unfortunately turbo-global state, which make those hard | 00:36 |
| dansmith | none of that points to "meh, it's hard, so just punt on tests" to me | 00:36 |
| artom | That wasn't really the thinking | 00:37 |
| artom | If func tests are super hard, I'd rather invest time and effort into setting up a real CI | 00:38 |
| dansmith | I was going on this: [16:27:04] <artom>Reason I'm asking is - without this, I don't see a way to func test NUMA LM meaningfully | 00:38 |
| dansmith | and | 00:38 |
| dansmith | [16:30:21] <artom>dansmith, so, we can follow up on ML, but I think that rules out NUMA LM func testing? | 00:38 |
| artom | dansmith, more in the sense of "I won't bother attempting it" | 00:40 |
| artom | I spoke to the openlab guys a bit this morning | 00:40 |
| artom | My request seemed to make sense for them | 00:40 |
| artom | So I'd rather push on that | 00:40 |
| artom | And if that turns out to be impossible, we can revisit func tests | 00:41 |
| *** itlinux has quit IRC | 00:44 | |
| alex_xu | mriedem_away: thanks, let me go through the last around today | 00:52 |
| *** dpawlik has joined #openstack-nova | 01:02 | |
| *** whoami-rajat has joined #openstack-nova | 01:04 | |
| *** _fragatina has quit IRC | 01:04 | |
| *** dpawlik has quit IRC | 01:07 | |
| *** tbachman has joined #openstack-nova | 01:08 | |
| *** itlinux has joined #openstack-nova | 01:09 | |
| *** slaweq has joined #openstack-nova | 01:11 | |
| *** hamzy has joined #openstack-nova | 01:11 | |
| *** itlinux has quit IRC | 01:11 | |
| *** itlinux has joined #openstack-nova | 01:12 | |
| *** slaweq has quit IRC | 01:16 | |
| *** ttsiouts has quit IRC | 01:17 | |
| *** itlinux has quit IRC | 01:18 | |
| *** itlinux has joined #openstack-nova | 01:19 | |
| *** wolverineav has quit IRC | 01:21 | |
| Kevin_Zheng | dansmith: OK, I will check it now | 01:21 |
| *** wolverineav has joined #openstack-nova | 01:26 | |
| *** wolverineav has quit IRC | 01:26 | |
| *** wolverineav has joined #openstack-nova | 01:27 | |
| *** itlinux has quit IRC | 01:51 | |
| *** itlinux has joined #openstack-nova | 01:52 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104 | 01:53 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106 | 01:54 |
| *** wolverineav has quit IRC | 01:54 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110 | 01:54 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113 | 01:54 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974 | 01:54 |
| *** wolverineav has joined #openstack-nova | 01:57 | |
| *** wolverineav has quit IRC | 01:57 | |
| *** wolverineav has joined #openstack-nova | 01:57 | |
| *** mlavalle has quit IRC | 01:58 | |
| *** itlinux has quit IRC | 01:58 | |
| *** tkajinam has quit IRC | 02:02 | |
| *** tkajinam has joined #openstack-nova | 02:03 | |
| *** tkajinam has quit IRC | 02:07 | |
| *** tkajinam has joined #openstack-nova | 02:10 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:21 | |
| *** markvoelker has quit IRC | 02:26 | |
| *** mriedem_away has quit IRC | 02:40 | |
| *** wolverineav has quit IRC | 02:40 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.openstack.org/640181 | 02:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make nova-grenade-live-migration voting and gating https://review.openstack.org/640182 | 02:40 |
| *** gyee has quit IRC | 02:42 | |
| *** hongbin has joined #openstack-nova | 02:46 | |
| *** sdake has joined #openstack-nova | 02:54 | |
| *** dpawlik has joined #openstack-nova | 03:03 | |
| *** awalende has joined #openstack-nova | 03:06 | |
| *** dpawlik has quit IRC | 03:08 | |
| *** awalende has quit IRC | 03:10 | |
| *** slaweq has joined #openstack-nova | 03:11 | |
| *** psachin has joined #openstack-nova | 03:12 | |
| *** slaweq has quit IRC | 03:15 | |
| *** zhubx has quit IRC | 03:17 | |
| *** zhubx has joined #openstack-nova | 03:17 | |
| *** dave-mccowan has joined #openstack-nova | 03:18 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311 | 03:24 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581 | 03:24 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017 | 03:24 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018 | 03:25 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019 | 03:25 |
| *** harlowja has quit IRC | 03:27 | |
| *** markvoelker has joined #openstack-nova | 03:27 | |
| *** zhubx has quit IRC | 03:35 | |
| *** dpawlik has joined #openstack-nova | 03:35 | |
| *** zhubx has joined #openstack-nova | 03:35 | |
| *** awaugama has quit IRC | 03:36 | |
| *** janki has joined #openstack-nova | 03:39 | |
| *** dpawlik has quit IRC | 03:40 | |
| *** zhubx has quit IRC | 03:54 | |
| *** zhubx has joined #openstack-nova | 03:55 | |
| *** bhagyashris has joined #openstack-nova | 03:57 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020 | 04:00 |
| *** markvoelker has quit IRC | 04:00 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027 | 04:00 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031 | 04:01 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299 | 04:01 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344 | 04:02 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673 | 04:02 |
| *** dave-mccowan has quit IRC | 04:04 | |
| *** sridharg has joined #openstack-nova | 04:06 | |
| *** sdake has quit IRC | 04:08 | |
| *** slaweq has joined #openstack-nova | 04:11 | |
| *** wolverineav has joined #openstack-nova | 04:11 | |
| *** slaweq has quit IRC | 04:16 | |
| *** wolverineav has quit IRC | 04:17 | |
| *** Dinesh_Bhor has quit IRC | 04:29 | |
| *** hongbin has quit IRC | 04:40 | |
| *** wolverineav has joined #openstack-nova | 04:42 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:50 | |
| *** tetsuro has joined #openstack-nova | 04:53 | |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | 04:55 |
| *** markvoelker has joined #openstack-nova | 04:57 | |
| yonglihe | mriedem: thanks. | 05:24 |
| *** zhubx has quit IRC | 05:29 | |
| *** zhubx has joined #openstack-nova | 05:30 | |
| *** markvoelker has quit IRC | 05:31 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676 | 05:32 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689 | 05:32 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709 | 05:32 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712 | 05:33 |
| *** dpawlik has joined #openstack-nova | 05:36 | |
| *** dpawlik has quit IRC | 05:41 | |
| *** wxy-xiyuan has quit IRC | 05:41 | |
| *** wolverineav has quit IRC | 05:43 | |
| *** ratailor has joined #openstack-nova | 05:44 | |
| *** igordc has quit IRC | 05:56 | |
| *** Dinesh_Bhor has quit IRC | 05:59 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:02 | |
| *** mtreinish has quit IRC | 06:04 | |
| *** wolverineav has joined #openstack-nova | 06:05 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 06:09 |
| *** slaweq has joined #openstack-nova | 06:11 | |
| *** dpawlik has joined #openstack-nova | 06:12 | |
| *** slaweq has quit IRC | 06:15 | |
| *** dpawlik has quit IRC | 06:17 | |
| *** tetsuro has quit IRC | 06:20 | |
| *** markvoelker has joined #openstack-nova | 06:28 | |
| *** itlinux has joined #openstack-nova | 06:33 | |
| *** ivve has joined #openstack-nova | 06:34 | |
| *** itlinux_ has joined #openstack-nova | 06:37 | |
| *** itlinux has quit IRC | 06:40 | |
| *** zhubx has quit IRC | 06:42 | |
| *** zhubx has joined #openstack-nova | 06:42 | |
| *** Luzi has joined #openstack-nova | 06:43 | |
| *** zhubx has quit IRC | 06:46 | |
| *** lbragstad has quit IRC | 06:49 | |
| *** mtreinish has joined #openstack-nova | 06:50 | |
| *** mdbooth_ has joined #openstack-nova | 06:53 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Remove unnecessary if statement https://review.openstack.org/640266 | 06:54 |
| *** mdbooth has quit IRC | 06:57 | |
| *** wolverineav has quit IRC | 06:57 | |
| *** markvoelker has quit IRC | 07:00 | |
| *** slaweq has joined #openstack-nova | 07:11 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 07:12 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.openstack.org/639934 | 07:12 |
| *** slaweq has quit IRC | 07:15 | |
| *** dpawlik has joined #openstack-nova | 07:15 | |
| *** wolverineav has joined #openstack-nova | 07:25 | |
| *** tetsuro has joined #openstack-nova | 07:28 | |
| *** slaweq has joined #openstack-nova | 07:32 | |
| *** takashin has left #openstack-nova | 07:36 | |
| *** itlinux_ has quit IRC | 07:37 | |
| *** itlinux has joined #openstack-nova | 07:39 | |
| *** sdake has joined #openstack-nova | 07:44 | |
| *** itlinux has quit IRC | 07:55 | |
| *** markvoelker has joined #openstack-nova | 07:57 | |
| *** Dinesh_Bhor has quit IRC | 08:01 | |
| *** tetsuro has quit IRC | 08:01 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:08 | |
| *** wolverineav has quit IRC | 08:10 | |
| *** awalende has joined #openstack-nova | 08:11 | |
| *** tkajinam has quit IRC | 08:18 | |
| *** ccamacho has joined #openstack-nova | 08:19 | |
| *** sdake has quit IRC | 08:23 | |
| *** tssurya has joined #openstack-nova | 08:25 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | 08:26 |
| *** tesseract has joined #openstack-nova | 08:31 | |
| *** markvoelker has quit IRC | 08:31 | |
| kashyap | gibi: Morning, when you get a quick minute: on something 'cosmetic': do you think my comment makes sense here: https://review.openstack.org/#/c/637834/4/nova/conf/libvirt.py | 08:32 |
| *** luksky has joined #openstack-nova | 08:34 | |
| *** mcgiggler has joined #openstack-nova | 08:39 | |
| *** tosky has joined #openstack-nova | 08:42 | |
| openstackgerrit | Merged openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 08:45 |
| tssurya | yonglihe: ^^ finally :) | 08:47 |
| *** sdake has joined #openstack-nova | 08:55 | |
| *** ttsiouts has joined #openstack-nova | 08:56 | |
| *** yan0s has joined #openstack-nova | 08:58 | |
| *** ralonsoh has joined #openstack-nova | 09:02 | |
| gibi | kashyap: I agree with you and alex_xu on that review. | 09:03 |
| *** rambo_li has joined #openstack-nova | 09:04 | |
| kashyap | gibi: Also, afraid that patch is wrong on several levels | 09:04 |
| kashyap | I'll review and comment with suggestions | 09:04 |
| gibi | kashyap: thanks for helping that patch | 09:04 |
| *** panda|ruck|off is now known as panda|ruck | 09:05 | |
| kashyap | gibi: Also, related is this important (IMHO) blueprint that needs to be addressed: https://blueprints.launchpad.net/nova/+spec/cpu-selection-with-hypervisor-consideration | 09:05 |
| kashyap | I added it to the Train Etherpad. | 09:06 |
| gibi | kashyap: is it something that is available for us as we bumped min libvirt and qemu versions? | 09:07 |
| gibi | stephenfin: you might missed my ping yestarday about https://review.openstack.org/#/c/625311/25/doc/source/admin/networking.rst@266 and I'll be on and off this morning but I'd like to make progress on that patch | 09:07 |
| kashyap | gibi: Afraid, no. Those two newer APIs need newer version constants. | 09:08 |
| kashyap | gibi: When you get a moment, can you tell if that requires a specification? | 09:08 |
| kashyap | Maybe I'll just write a short one, it helps to write out background, motivation and why this matters in a spec | 09:08 |
| gibi | kashyap: does it affect any config option or nova API? | 09:09 |
| gibi | as far as I understand it is a libvirt driver only change | 09:09 |
| kashyap | Yes | 09:09 |
| kashyap | gibi: No, doesn't affect config options. At its core: it rips out two older, ineffective APIs, in Nova | 09:09 |
| kashyap | And adds in 'better' and sensible equivalent replacements | 09:09 |
| *** IvensZambrano has joined #openstack-nova | 09:10 | |
| gibi | if there is no config or REST API change then I think we don't need a spec. Still if you think that a sort spec would help then go ahead with that | 09:10 |
| gibi | the more interesting thing is that we cannot rip out the old code before we bump the min versions again | 09:11 |
| kashyap | Yep, noted. Doesn't affect REST API. Nor config. | 09:11 |
| *** priteau has joined #openstack-nova | 09:11 | |
| openstackgerrit | Merged openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653 | 09:13 |
| *** rambo_li has quit IRC | 09:14 | |
| *** wolverineav has joined #openstack-nova | 09:17 | |
| *** rambo_li has joined #openstack-nova | 09:17 | |
| *** rambo_li has quit IRC | 09:21 | |
| *** wolverineav has quit IRC | 09:22 | |
| *** markvoelker has joined #openstack-nova | 09:28 | |
| *** rambo_li has joined #openstack-nova | 09:28 | |
| *** mdbooth_ is now known as mdbooth | 09:35 | |
| mdbooth | cfriesen: Apologies for being obtusely British ;) Seems you managed to decode it. | 09:35 |
| *** dtantsur|afk is now known as dtantsur | 09:37 | |
| *** derekh has joined #openstack-nova | 09:42 | |
| *** rambo_li has quit IRC | 09:43 | |
| *** bhagyashris has quit IRC | 09:49 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750 | 09:54 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 09:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 09:56 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 09:57 |
| *** markvoelker has quit IRC | 10:01 | |
| *** ttx has quit IRC | 10:07 | |
| *** ttx has joined #openstack-nova | 10:08 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add "links" in the response of GET /servers/{server_id} for a down-cell instance https://review.openstack.org/640302 | 10:10 |
| *** cdent has joined #openstack-nova | 10:15 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add "links" in the response of "nova show" for a down-cell instance https://review.openstack.org/640302 | 10:15 |
| *** owalsh has quit IRC | 10:17 | |
| *** sdake has quit IRC | 10:20 | |
| *** eandersson has quit IRC | 10:20 | |
| *** rambo_li has joined #openstack-nova | 10:22 | |
| *** owalsh has joined #openstack-nova | 10:31 | |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec https://review.openstack.org/570201 | 10:34 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0 https://review.openstack.org/570203 | 10:34 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state https://review.openstack.org/566473 | 10:34 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Allow rebuild for instances in PENDING state https://review.openstack.org/637585 | 10:34 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 10:35 |
| *** rambo_li has quit IRC | 10:49 | |
| *** erlon has joined #openstack-nova | 10:55 | |
| *** luksky has quit IRC | 10:56 | |
| *** markvoelker has joined #openstack-nova | 10:58 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Improve libvirt image and snapshot handling https://review.openstack.org/616692 | 11:01 |
| *** IvensZambrano has quit IRC | 11:05 | |
| *** luksky has joined #openstack-nova | 11:09 | |
| *** IvensZambrano has joined #openstack-nova | 11:11 | |
| *** cdent has quit IRC | 11:12 | |
| *** ttsiouts has quit IRC | 11:18 | |
| *** cdent has joined #openstack-nova | 11:20 | |
| stephenfin | mdbooth: Could you test something real quick for me? | 11:21 |
| stephenfin | $ tox -e functional -- -n nova/tests/functional/libvirt/test_pci_sriov_servers.py | 11:21 |
| stephenfin | Does that fail? ^ | 11:22 |
| *** luksky has quit IRC | 11:22 | |
| mdbooth | stephenfin: Sec | 11:23 |
| mdbooth | stephenfin: Do you mean to have .py on the end, there? | 11:23 |
| mdbooth | Seems like that wouldn't match anything? | 11:23 |
| stephenfin | mdbooth: Never mind. I used '--recreate' and it now works. I was seeing privsep warnings previously | 11:23 |
| stephenfin | mdbooth: Yeah, I'm using the '-n' flag | 11:23 |
| stephenfin | Let's me give a path to a file instead of a module path. Makes test runs waaay faster | 11:24 |
| *** Dinesh_Bhor has quit IRC | 11:24 | |
| mdbooth | Not familiar with that | 11:24 |
| mdbooth | Nice | 11:24 |
| mdbooth | Sounds super useful | 11:24 |
| mdbooth | stephenfin: Also lets you find import ordering bugs :) | 11:24 |
| stephenfin | You can also do nova/tests/functional/libvirt/test_pci_sriov_servers.py::SRIOVServersTest.test_create_server_with_PF | 11:24 |
| stephenfin | Indeed | 11:24 |
| *** IvensZambrano is now known as snevi | 11:24 | |
| *** markvoelker has quit IRC | 11:30 | |
| yonglihe | tssurya: thanks. gonna to rebase another one. | 11:31 |
| *** amrith has joined #openstack-nova | 11:33 | |
| *** amrith has quit IRC | 11:35 | |
| *** amrith has joined #openstack-nova | 11:36 | |
| sean-k-mooney | stephenfin: why not just use -- SRIOVServersTest.test_create_server_with_PF | 11:39 |
| stephenfin | sean-k-mooney: You could, but if there are overlapping test names, that lets you be more specific | 11:40 |
| stephenfin | without needing to convert the entire thing to a Python module path | 11:40 |
| sean-k-mooney | wll you cant have overlaping test names in the same module | 11:40 |
| stephenfin | nope, but you can between different modules | 11:40 |
| stephenfin | of different classes, if you didn't specify that | 11:41 |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 11:41 |
| mdbooth | Also you lose the speed advantage, because stestr still has to load everything and then filter for your test | 11:41 |
| mdbooth | Loading everything is what takes such a long time | 11:41 |
| sean-k-mooney | yes SRIOVServersTest is ca class and test_create_server_with_PF is a test function you can add one level o module to make it unique | 11:41 |
| sean-k-mooney | anyway -n is still useful | 11:41 |
| sean-k-mooney | so is --failing | 11:42 |
| stephenfin | I was literally just about to point that out :) | 11:42 |
| mdbooth | Avoiding loading everything is why I have my trivial 'testone' bash alias | 11:42 |
| mdbooth | I can run a single test in a couple of seconds, rather than waiting 20 seconds for stestr to load all tests before filtering to find my 1 test | 11:42 |
| *** erlon_ has joined #openstack-nova | 11:43 | |
| sean-k-mooney | mdbooth: not that long in the grand schme of things a full unit test run takes 8 minues event with the dest discovery running a monudes tests is less then a minute much less typically | 11:43 |
| mdbooth | But super useful when you're iterating on 1 test. | 11:44 |
| sean-k-mooney | mdbooth: ya if i use vscode to click on a test it runs instantly | 11:44 |
| sean-k-mooney | and i can debug it :) | 11:44 |
| *** amrith has quit IRC | 11:44 | |
| stephenfin | sean-k-mooney: Sounds like a blog :) | 11:45 |
| sean-k-mooney | but i typically do most of my deve with nano or emacs and run the test by had out of habit | 11:46 |
| sean-k-mooney | stephenfin: how about i raise you os-vif docs https://review.openstack.org/#/c/638058/4/doc/source/devref/vs-code.rst | 11:46 |
| *** erlon has quit IRC | 11:46 | |
| sean-k-mooney | i need to test that htis works properly for nova and ill write up somthing similar. i have mainly been using it on os-vif lately to debug the functional tests | 11:47 |
| *** Luzi has quit IRC | 11:50 | |
| *** ttsiouts has joined #openstack-nova | 11:51 | |
| *** jchhatbar has joined #openstack-nova | 12:06 | |
| *** janki has quit IRC | 12:07 | |
| *** yaawang has quit IRC | 12:10 | |
| *** yaawang has joined #openstack-nova | 12:13 | |
| *** panda|ruck is now known as panda|ruck|lunch | 12:16 | |
| *** priteau has quit IRC | 12:17 | |
| *** luksky has joined #openstack-nova | 12:18 | |
| *** threestrands has quit IRC | 12:24 | |
| aspiers | hi folks, I found a bug in assertXMLEqual | 12:27 |
| *** markvoelker has joined #openstack-nova | 12:28 | |
| aspiers | I'm fixing it ... hopefully it won't show up other bugs in our tests | 12:28 |
| sean-k-mooney | oh ? what was broken | 12:30 |
| aspiers | sean-k-mooney: hard to explain briefly but will make sense when you see the review | 12:40 |
| aspiers | (hopefully ;-) | 12:40 |
| aspiers | of course I meant assertXmlEqual() - typo | 12:41 |
| *** gibi is now known as giblet | 12:45 | |
| *** amrith__ has joined #openstack-nova | 12:45 | |
| *** amrith__ has left #openstack-nova | 12:46 | |
| aspiers | I wonder why we invented our own xml differ | 12:53 |
| aspiers | https://xmldiff.readthedocs.io/en/stable/api.html#main-diffing-api looks good to me | 12:54 |
| cdent | <sparta> | 12:54 |
| *** wolverineav has joined #openstack-nova | 12:54 | |
| aspiers | maybe xmldiff didn't exist in 2012 when Kevin Mitchell wrote ours | 12:55 |
| sean-k-mooney | aspiers: https://pypi.org/project/xmldiff/#history | 12:55 |
| sean-k-mooney | it did but did not have its 1.0.0 release until 2018 | 12:56 |
| sean-k-mooney | it also did not have any release between 2005 and 2015 | 12:56 |
| sean-k-mooney | so it had been unmaintianed for 7 years at that point | 12:57 |
| aspiers | ahah | 12:57 |
| aspiers | Still a generic xml differ never really belonged in nova. I'm sure other projects could use one | 12:58 |
| sean-k-mooney | ah it also looks like they did a complete rewrite form c to python between 0.6 and 1.0 so it an entirely different code base | 12:58 |
| aspiers | Yes | 12:58 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add "links" in the response of GET /servers/{server_id} for a down-cell instance https://review.openstack.org/640302 | 12:58 |
| aspiers | Maybe we should switch to that in the future | 12:58 |
| *** wolverineav has quit IRC | 12:59 | |
| tssurya | stephenfin: I fixed the nit in https://review.openstack.org/640302, but the +2 went off :( , | 12:59 |
| tssurya | thanks for the review | 13:00 |
| sean-k-mooney | aspiers: yes perhaps. am i the only one who gets suspices of project with 100% test coverage | 13:00 |
| aspiers | haha no you are not ;-) | 13:00 |
| sean-k-mooney | for some reason it always make me trust them less | 13:00 |
| aspiers | xmldiff has been around since 2001 https://github.com/Shoobx/xmldiff/blob/272300bb29b8c2d444971e8051aae7bf513cdb98/ChangeLog | 13:00 |
| aspiers | although as you say it might not have been very palatable for many years | 13:00 |
| *** markvoelker has quit IRC | 13:01 | |
| sean-k-mooney | ya in anycase if its maintained and it works we could use it | 13:01 |
| sean-k-mooney | that said i dont think the code is overly big ofr assertXmlEquals either | 13:01 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add "links" in the response of "nova show" for a down-cell instance https://review.openstack.org/640302 | 13:02 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 13:03 |
| *** panda|ruck|lunch is now known as panda|ruck | 13:04 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 13:04 |
| *** ratailor has quit IRC | 13:07 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 13:11 |
| giblet | jaypipes: Hi! I've replied in https://review.openstack.org/#/c/625310/31/nova/objects/instance_pci_requests.py@39 If you still think we should rename then let me know and I will jump on it | 13:13 |
| jroll | efried: alex_xu: this was rebased, want to re-approve? https://review.openstack.org/#/c/636326/ | 13:15 |
| *** mdbooth_ has joined #openstack-nova | 13:23 | |
| *** mdbooth has quit IRC | 13:24 | |
| bauzas | efried: alex_xu: jaypipes: others, I finally removed my -W because I'm not sure I can provide the fix for the problem I saw by this week | 13:30 |
| bauzas | instead, I'll provide a documentation | 13:30 |
| *** mriedem has joined #openstack-nova | 13:32 | |
| *** eharney has quit IRC | 13:33 | |
| efried | jroll: done | 13:35 |
| efried | bauzas: ack. My +2 is still on there... for now :P | 13:36 |
| jroll | thanks | 13:36 |
| bauzas | efried: heh thanks | 13:36 |
| efried | jroll: you knew there was no way you were going to merge a patch at PS1. | 13:36 |
| jroll | efried: so close though | 13:37 |
| *** tbachman has quit IRC | 13:44 | |
| *** marst has joined #openstack-nova | 13:45 | |
| *** efried is now known as fried_rice | 13:45 | |
| yonglihe | hope this would in reviewing queue -:) https://review.openstack.org/#/c/621476/ | 13:46 |
| openstackgerrit | Merged openstack/nova master: fix up numa-topology live migration hypervisor check https://review.openstack.org/635350 | 13:46 |
| mriedem | yonglihe: are you working on adding the related novaclient change for 2.70? | 13:47 |
| mriedem | *2.71 i mean | 13:47 |
| *** jmlowe has quit IRC | 13:48 | |
| yonglihe | yeah, on my queue. | 13:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.openstack.org/640191 | 13:51 |
| yonglihe | by default , it could show up. i need to dig how to good fit to nova client, might be some documentation work i guss. | 13:51 |
| yonglihe | guess | 13:51 |
| mriedem | it should just work, but you have to at least bump the supported api version and it would be good to modify the fakes response in unit tests to show it in the output for nova show/update/rebuild | 13:52 |
| mriedem | so this https://github.com/openstack/python-novaclient/blob/master/novaclient/__init__.py#L28 | 13:52 |
| yonglihe | sure, got it. | 13:52 |
| mriedem | the fake responses for unit tests are here https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/v2/fakes.py | 13:53 |
| yonglihe | nice, thanks. | 13:53 |
| mriedem | so something like this https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/v2/fakes.py#L647 | 13:53 |
| tssurya | mriedem, melwitt, dansmith: I have this very easy doc change on the archive nova-manage command just to clarify what max-rows means there: https://review.openstack.org/#/c/606995/. Please take a look at it when you have time, | 13:53 |
| mriedem | yonglihe: you can check the requested microversion from the fake method and return the server_groups key in the response | 13:54 |
| *** marst has quit IRC | 13:54 | |
| mriedem | like this https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/v2/fakes.py#L2023 | 13:54 |
| yonglihe | mriedem: ok, thanks. | 13:56 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update --max-rows parameter description for archive_deleted_rows https://review.openstack.org/606995 | 13:57 |
| mriedem | tssurya: done | 13:58 |
| *** markvoelker has joined #openstack-nova | 13:58 | |
| *** mlavalle has joined #openstack-nova | 14:00 | |
| *** sdake has joined #openstack-nova | 14:01 | |
| *** _mlavalle_1 has joined #openstack-nova | 14:01 | |
| *** mlavalle has quit IRC | 14:04 | |
| *** Sundar has joined #openstack-nova | 14:08 | |
| *** nicholas has joined #openstack-nova | 14:09 | |
| fried_rice | Hey folks, especially folks like sean-k-mooney: when we do a resize-to-same-host, do neutron ports get unbound and rebound or do we leave them alone? | 14:14 |
| * fried_rice hopes the latter | 14:14 | |
| *** TheJulia is now known as needssleep | 14:14 | |
| fried_rice | Sundar: ^ | 14:15 |
| ttsiouts | mriedem: I tried to address your comments in https://review.openstack.org/#/c/570203/. would be great to hear your feedback when you have the time. thanks in advance | 14:16 |
| *** mcgiggler has quit IRC | 14:17 | |
| *** snevi has quit IRC | 14:17 | |
| *** snevi has joined #openstack-nova | 14:17 | |
| sean-k-mooney | fried_rice: i would have to check they proable are not but it might be resonable to require that they are | 14:17 |
| sean-k-mooney | i dont htink we allow changing vif_model via flavor im pretty sure that is image only | 14:17 |
| fried_rice | sean-k-mooney: I'm thinking it could be problematic for bandwidth resources, if there are paths in which we would end up binding to different providers somehow - the allocations would wind up screwy. giblet, have you already considered this? | 14:19 |
| *** jchhatbar has quit IRC | 14:19 | |
| sean-k-mooney | am if the numa toplogy changes as part of a resize then in the future the bandwith allcoation might need to be updated | 14:19 |
| *** sdake has quit IRC | 14:19 | |
| fried_rice | sean-k-mooney: And in anticipation of cyborg, similarly, if we had to unbind and rebind accelerators. | 14:19 |
| *** eharney has joined #openstack-nova | 14:19 | |
| sean-k-mooney | fried_rice: well we hit the schudler as part of a resize so if the flavor chagned the device-profile for example in the cyborge case we defiently would need to rebind the device | 14:20 |
| giblet | fried_rice: do you mean changing the flavor might affect the port allocation? | 14:20 |
| fried_rice | giblet: actually I'm more concerned about the case where changing the flavor does/should *not* affect the port allocation/binding. | 14:21 |
| sean-k-mooney | it may | 14:21 |
| *** jmlowe has joined #openstack-nova | 14:21 | |
| fried_rice | like, if all I do is increase VCPU, is it possible that I wind up with my vifs being swizzled? | 14:21 |
| Sundar | sean-k-mooney: What about rebuild? It could be on same host or different host. In the former case, AFAIK, it is only a detach but not an unbind. | 14:21 |
| sean-k-mooney | Sundar: rebuild is confied to the same host | 14:22 |
| sean-k-mooney | Sundar: it will never do a migrate | 14:22 |
| *** sdake has joined #openstack-nova | 14:22 | |
| Sundar | sean-k-mooney: If the rebuild changes the image, and the new image has different traits, is that not a problem? | 14:23 |
| sean-k-mooney | fried_rice: i think there are edgecses such as changin numa toplogy that might require it if you have sriov port or hardwar offload ovs or you use the numa aware vswitch feature | 14:23 |
| sean-k-mooney | Sundar: we will fail the rebuild if its not valid for the current host | 14:23 |
| mriedem | rebuild doesn't mess with port bindings | 14:23 |
| sean-k-mooney | rebuilt with same image bypasses the scheduler | 14:23 |
| sean-k-mooney | rebuilt with different hits the schduler | 14:23 |
| giblet | does resize-to-same host is just allows but never forces the resize to keep the server on the same host | 14:23 |
| mriedem | resize to same host calls the same methods to change port bindings, but i think the neutron api code we have doesn't do the update if the host doesn't change | 14:24 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L3230 | 14:24 |
| *** sdake has quit IRC | 14:24 | |
| * mordred thanks the nova team for having local hacking check infrastructure in place he could steal from | 14:24 | |
| sean-k-mooney | giblet: right if the resize was invalid on the same host it would do a cold migraton to a vliad host if one exits in that case | 14:25 |
| sean-k-mooney | mriedem: in princiable a rebind with a new image could contain tratis that may affect the neutro ports but in practice we have never need to cater for that case todate so ya for rebuild we have never needed to touch the port bindings | 14:27 |
| giblet | fried_rice: to answer your original question server move operations (even resize on same host) are not covered by the current implementation so your question needs to be answered during Train | 14:27 |
| fried_rice | giblet: Okay, good to know. | 14:27 |
| giblet | fried_rice: my general idea regarding move is, to re-query resoruce request from neutron ports, include it to the scheduling. conductor will transparently handle migration allocation for ports then. | 14:28 |
| fried_rice | giblet: It would be nice to prefer candidates where the ports don't move. | 14:28 |
| fried_rice | which sounds like more hacked up matching. | 14:29 |
| giblet | fried_rice: so during resize-to-same-host case it would be nice to keep the ports allocated to from the same RP, I seenow | 14:29 |
| sean-k-mooney | fried_rice: for what it worth the image trait edgecase for neutron port i am tink of would be a a required or forbding trati for a partacalr nic vendor when using sriov. we talked about this as a way for image to expres i have drivers for vendor X but not Y | 14:29 |
| giblet | fried_rice: the problem with that is nova-scheduler always selects the first allocation for a host even if there is more than one candidate is returned for that host | 14:30 |
| giblet | by placement | 14:30 |
| sean-k-mooney | fried_rice: well its not really more hacked up match and more a weigher. | 14:31 |
| *** markvoelker has quit IRC | 14:31 | |
| fried_rice | weighers are by definition hacks | 14:31 |
| fried_rice | ...said someone I'm sure | 14:31 |
| sean-k-mooney | ha perhaps | 14:32 |
| giblet | fried_rice: https://github.com/openstack/nova/blob/68d4cb44edfe7b5f85618254cc906dcef44f7ce3/nova/scheduler/filter_scheduler.py#L238 | 14:32 |
| fried_rice | yup | 14:33 |
| sean-k-mooney | but unlike filter they are intended to handel the optimisation of the best host rather then filter which is what we want in thiscase. although as giblet mething we might need to look at multiple allcoation candiates which the weigher dont play a role in | 14:33 |
| *** ccamacho has quit IRC | 14:33 | |
| *** ccamacho has joined #openstack-nova | 14:34 | |
| giblet | nova filter scheduler does not filter and weigh allocation candidates today | 14:34 |
| giblet | it filter and weigh hosts only | 14:34 |
| sean-k-mooney | yes im aware | 14:34 |
| sean-k-mooney | but i think what fried_rice was asserting sounded like a weigher of the allocation candiates | 14:34 |
| giblet | so we cannot prefer the candidate that keeps the port allocated from the same RP during resize-to-same-host | 14:35 |
| fried_rice | sean-k-mooney: right: prefer candidates with [these ports] | 14:35 |
| fried_rice | giblet: yes. | 14:35 |
| fried_rice | we can't, but we should. | 14:35 |
| sean-k-mooney | can you use in_tree to help | 14:35 |
| *** lbragstad has joined #openstack-nova | 14:35 | |
| giblet | fried_rice: soo we have to extend the filter interface to know about allocation candidates not just hosts | 14:35 |
| sean-k-mooney | i guess that would force the same host | 14:35 |
| fried_rice | well, we should be using in_tree for resize-to-same-host anyway. | 14:35 |
| fried_rice | But that's unrelated to the problem of not moving the ports. | 14:36 |
| fried_rice | giblet: I was just talking to mriedem about that the other day. | 14:36 |
| fried_rice | and Sundar as well. | 14:36 |
| sean-k-mooney | fried_rice: were we not talking about a subtree version too i dont know if we could restict the neutron request to the same RPs they had previously | 14:36 |
| fried_rice | sean-k-mooney: Yes, there's a spec up for that. | 14:36 |
| sean-k-mooney | i dont think the placement sysntax is that granuarly | 14:36 |
| giblet | fried_rice: can we tell our preference to placement about return those a_c first that keeps the port allocated from the same RP? | 14:37 |
| fried_rice | nope, not today. | 14:37 |
| fried_rice | giblet: Not yet, but with the subtree thing we might be able to. | 14:37 |
| sean-k-mooney | ya so resize to same host would basice add in_tree to the numbered requst group for the prot resouce or whatever the spec says | 14:37 |
| sean-k-mooney | fried_rice: sound like a thing to solve in train | 14:38 |
| fried_rice | Re allocation candidates to filters: I was thinking we ought to extend BaseFliter with a new method that accepts the allocation candidate under consideration, as well as the (relevant subset of the) provider_summaries. We do the try/except NotImplemented and fall back to the old method so we don't break existing filters. But new filters can then be written to take that information into account. | 14:38 |
| sean-k-mooney | fried_rice: ya that came up before | 14:39 |
| giblet | fried_rice: hm, do you have a link to subtree a_c spec? | 14:39 |
| fried_rice | sec | 14:39 |
| *** sdake has joined #openstack-nova | 14:39 | |
| sean-k-mooney | fried_rice: i think passing the allcoation candiates to the filters/werigher makes sence. | 14:40 |
| fried_rice | giblet: Hah, it's yours: https://review.openstack.org/#/c/595236/ | 14:40 |
| giblet | fried_rice: but that is subtree for GET /resource_providers not subtree for a_c | 14:41 |
| fried_rice | mm, well, in the spirit of in_tree, we should implement it for GET /a_c as well. | 14:41 |
| fried_rice | giblet: tetsuro has started code: https://review.openstack.org/#/c/636092/ (but for GET /rps) | 14:42 |
| sean-k-mooney | fried_rice: i think that proably should be implemented at the resouce group level not the top level | 14:42 |
| giblet | fried_rice: I haven't tought about that direction yet. The use case in my spec is purely to limit the amount of data neutron needs to read from placemente | 14:42 |
| fried_rice | mriedem: Currently (merged code) does resize-to-same-host even use GET /a_c at all? | 14:42 |
| *** _mlavalle_1 has quit IRC | 14:42 | |
| sean-k-mooney | e.g. this requst_group must be form this sub tree | 14:43 |
| *** mlavalle has joined #openstack-nova | 14:43 | |
| sean-k-mooney | that would allow us to say the general request must be form the compute node sub tree but the neutron bandwith must be form the subtree of the ortinginal RP that the allcoation were form | 14:43 |
| fried_rice | sean-k-mooney: just so. and/or should be from this exact provider. The latter would be better for the case we're talking about. | 14:44 |
| sean-k-mooney | yes the formor would allow nesting to work better when we model sriov nics in placmeent | 14:44 |
| giblet | wait, we don't want to force resize-to-same-host to only work for the same host. We still want to get back candidates for other hosts. So we cannot simply restrict the a_c querty to a given tree | 14:44 |
| giblet | or subtree | 14:45 |
| fried_rice | eh? By definition, resize-to-same-host is... to the same host. Isn't it?? | 14:45 |
| giblet | fried_rice: nope | 14:45 |
| sean-k-mooney | both the bandwith request and vf request woudl be in the same group but they could be in different provdiers depending on how we model it | 14:45 |
| giblet | fried_rice: it is a config option that allows resize to use the same host too | 14:45 |
| *** bnemec is now known as beekneemech | 14:46 | |
| sean-k-mooney | fried_rice: it does not gurarentee it | 14:46 |
| fried_rice | I think mriedem is working on making it so? https://review.openstack.org/#/c/638791/ | 14:46 |
| giblet | fried_rice: allow_resize_to_same_host | 14:46 |
| sean-k-mooney | fried_rice: by default we dont allow resize to same host. when you enable it in the nova.conf it just allows it as a candiate but unlees you also force the host it could be resized to a different host | 14:47 |
| sean-k-mooney | fried_rice: mriedem is working on removing the double allocation problem in the case we actully do resize on the same host | 14:48 |
| fried_rice | mm | 14:48 |
| fried_rice | mriedem: In fact, do we even use GET /a_c for resize in general, or do we just build the new allocs by parsing the new flavor?? | 14:49 |
| giblet | there is a full scheduling for resize including a_c query | 14:50 |
| *** marst has joined #openstack-nova | 14:50 | |
| giblet | only rebuild has a partial scheduling (no a_c) | 14:50 |
| giblet | afaik | 14:50 |
| *** artom is now known as temka | 14:50 | |
| *** ccamacho has quit IRC | 14:51 | |
| giblet | fried_rice: resize is just a cold_migrate with a changing flavor https://github.com/openstack/nova/blob/68d4cb44edfe7b5f85618254cc906dcef44f7ce3/nova/conductor/tasks/migrate.py#L134 | 14:53 |
| *** ccamacho has joined #openstack-nova | 14:53 | |
| fried_rice | hm | 14:53 |
| *** snevi has quit IRC | 14:54 | |
| *** snevi has joined #openstack-nova | 14:54 | |
| giblet | fried_rice: here is the select_destination call https://github.com/openstack/nova/blob/68d4cb44edfe7b5f85618254cc906dcef44f7ce3/nova/conductor/tasks/migrate.py#L235 | 14:54 |
| *** awaugama has joined #openstack-nova | 14:54 | |
| fried_rice | okay. | 14:55 |
| *** awalende has quit IRC | 15:00 | |
| mriedem | fried_rice: yes resize to same host does GET /a_c | 15:00 |
| *** awalende has joined #openstack-nova | 15:00 | |
| fried_rice | okay. | 15:00 |
| fried_rice | mriedem: Then something I just sent on the ML may be entirely wrong. | 15:01 |
| *** jaypipes is now known as leakypipes | 15:01 | |
| fried_rice | o/ leakypipes | 15:01 |
| *** tbachman has joined #openstack-nova | 15:01 | |
| *** itlinux has joined #openstack-nova | 15:01 | |
| tssurya | mriedem: thanks! | 15:02 |
| cfriesen | mdbooth_: no worries. thanks for fixing it up. | 15:03 |
| *** tbachman has quit IRC | 15:03 | |
| *** Sundar is now known as DarthNau | 15:03 | |
| *** tobias-urdin is now known as tobeass-urdin | 15:03 | |
| *** awalende has quit IRC | 15:04 | |
| *** tbachman has joined #openstack-nova | 15:07 | |
| *** lbragstad is now known as elbragstad | 15:08 | |
| cfriesen | mdbooth: I assume that change has your approval since you resubmitted it? | 15:09 |
| *** sdake has quit IRC | 15:10 | |
| *** itlinux has quit IRC | 15:12 | |
| melwitt | o/ | 15:12 |
| fried_rice | jroll: Thanks for that email. Turns out this will affect (at least) nova-powervm's OOT driver https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L230 | 15:13 |
| fried_rice | o/ melwitt | 15:13 |
| *** wolverineav has joined #openstack-nova | 15:15 | |
| melwitt | fried_rice: we were considering adding a warning log to the patch if a driver needs to be updated. do you think that would be useful or do you think the reno alone is good enough? | 15:15 |
| fried_rice | melwitt: I think it's a good idea. | 15:15 |
| fried_rice | since we're going to the trouble of being nice about changing the interface. | 15:16 |
| *** wolverineav has quit IRC | 15:20 | |
| kashyap | mriedem: Thanks for bringing this to my attention: https://review.openstack.org/#/c/637834/ (Select cpu model from a list of cpu models) | 15:20 |
| kashyap | mriedem: Reviewed it this morning. And it needs a lot more rework | 15:20 |
| kashyap | It is doing several things that are terribly ineffective, even poorly duplicating libvirt's work | 15:20 |
| kashyap | Wonder if you (dis)agree with my remarks there | 15:22 |
| *** ratailor has joined #openstack-nova | 15:23 | |
| *** dpawlik has quit IRC | 15:24 | |
| *** ivve has quit IRC | 15:26 | |
| *** markvoelker has joined #openstack-nova | 15:28 | |
| *** itlinux has joined #openstack-nova | 15:29 | |
| *** igordc has joined #openstack-nova | 15:30 | |
| mriedem | kashyap: i'll defer to you | 15:30 |
| mriedem | i haven't been reviewing the change | 15:30 |
| mriedem | bigger fires to fight | 15:31 |
| mriedem | jroll: so i guess you're going to add a log message? | 15:31 |
| mriedem | for the TypeError? | 15:31 |
| kashyap | mriedem: I think all the points I (and Alex Xu) raised should be addressed. | 15:32 |
| kashyap | I'll follow through | 15:32 |
| *** itlinux has quit IRC | 15:36 | |
| *** chason_ has quit IRC | 15:36 | |
| *** itlinux has joined #openstack-nova | 15:38 | |
| *** jistr is now known as jistr|mtg | 15:38 | |
| *** belmoreira has quit IRC | 15:39 | |
| *** chason has joined #openstack-nova | 15:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Stop using "nova" in API samples when creating a server https://review.openstack.org/639874 | 15:43 |
| openstackgerrit | Ben Nemec proposed openstack/nova master: Add oslo.privsep to config-generator list https://review.openstack.org/640404 | 15:45 |
| mriedem | bauzas: so what changed with the reboot issue you were holding https://review.openstack.org/#/c/599208/ up for? | 15:46 |
| *** chason has quit IRC | 15:46 | |
| *** betherly has joined #openstack-nova | 15:48 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Use migration_status during volume migrating and retyping https://review.openstack.org/637224 | 15:49 |
| *** temka has quit IRC | 15:49 | |
| openstackgerrit | Merged openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 15:50 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 15:51 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 15:51 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 15:51 |
| *** chason has joined #openstack-nova | 15:52 | |
| *** artom has joined #openstack-nova | 15:53 | |
| giblet | stephenfin: added an extra sentence about grouping multiple PF in a single expression in https://review.openstack.org/#/c/625311 | 15:53 |
| *** artom is now known as temka | 15:53 | |
| *** betherly has quit IRC | 15:53 | |
| stephenfin | giblet: Sounds good. I'll get to it before EOD. Been working on adding functional tests for https://review.openstack.org/#/c/624444/2 | 15:53 |
| *** ratailor has quit IRC | 15:54 | |
| giblet | stephenfin: thanks. hit me with the link of the functional test and I will review it | 15:54 |
| sean-k-mooney | do you think we will land that in stein by the way. it would be good to backport if we do | 15:55 |
| jroll | fried_rice: mriedem: yeah, I'll add it shortly here | 15:55 |
| jroll | thanks | 15:55 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Store InstancePCIRequest.numa_policy in DB https://review.openstack.org/624444 | 15:55 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: fakelibvirt: Add ability to generate fake PCI devices https://review.openstack.org/640409 | 15:55 |
| fried_rice | ight | 15:56 |
| giblet | sean-k-mooney: the actual fix looked good to me so I can help pushing it through | 15:56 |
| stephenfin | giblet: There you go. I was trying to fix some TODOs in the tests but that can be done some other time https://review.openstack.org/624444 | 15:56 |
| giblet | stephenfin: looking | 15:56 |
| *** sdake has joined #openstack-nova | 15:58 | |
| sean-k-mooney | on a slightly unrelated note i would like to land this bugfix in stien too if we can https://review.openstack.org/#/c/602432/7 but i need to do some more testing of it locally. i think it is correct but i want to be certin before we merge it and say the bugs are closed. | 15:59 |
| *** tssurya has quit IRC | 15:59 | |
| *** yan0s has quit IRC | 15:59 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: fix bug with XML matcher handling missing children https://review.openstack.org/640411 | 16:01 |
| *** markvoelker has quit IRC | 16:01 | |
| *** jistr|mtg is now known as jistr | 16:02 | |
| sean-k-mooney | actully stephenfin giblet should i add a release note for that | 16:02 |
| aspiers | sean-k-mooney: ^^^ | 16:02 |
| stephenfin | sean-k-mooney: For? | 16:02 |
| *** sdake has quit IRC | 16:03 | |
| stephenfin | sean-k-mooney: Can you take a look at https://review.openstack.org/#/c/625311/25/doc/source/admin/networking.rst ? | 16:05 |
| stephenfin | sean-k-mooney: Just because I know you've expressed concerns about using device names as identifiers in the past | 16:05 |
| sean-k-mooney | stephenfin: https://review.openstack.org/#/c/602432/7 since it close https://bugs.launchpad.net/neutron/+bug/1734320 and https://bugs.launchpad.net/neutron/+bug/1815989 | 16:06 |
| openstack | Launchpad bug 1734320 in OpenStack Compute (nova) "Eavesdropping private traffic" [Undecided,In progress] - Assigned to sean mooney (sean-k-mooney) | 16:06 |
| openstack | Launchpad bug 1815989 in neutron "OVS drops RARP packets by QEMU upon live-migration causes up to 40s ping pause in Rocky" [Undecided,In progress] - Assigned to sean mooney (sean-k-mooney) | 16:06 |
| stephenfin | sean-k-mooney: though I am imagining the ship has sailed based on giblet's comments about neutron using them for RP IDs | 16:06 |
| sean-k-mooney | sure ill take a look now | 16:06 |
| *** sdake has joined #openstack-nova | 16:06 | |
| stephenfin | sean-k-mooney: I love release notes and think we should have them for all (user-facing) bugs. However, there's a user visible change being introduced here so I'd definitely say add one, yeah | 16:08 |
| sean-k-mooney | stephenfin: if the pf is directly assignied to a guest and then readdd to the host its may or may not have a netdev associated with it and it may our may not have the same name | 16:08 |
| stephenfin | So | 16:08 |
| sean-k-mooney | so the sriov agent already depend on the pci address in the port profile so why not use that instad of a dev name | 16:09 |
| giblet | sean-k-mooney: the sriov agent is configured with device names in neutron | 16:10 |
| sean-k-mooney | i have not read the full spec | 16:10 |
| lyarwood | mdbooth_: https://review.openstack.org/#/q/topic:bug/1803961+(status:open+OR+status:merged) - would you mind clearing your reviews out of that topic and hitting mine again early next week? | 16:10 |
| sean-k-mooney | giblet: yes and it looks up the pci address | 16:10 |
| stephenfin | Could we add code that says if 'pf_interface_name': 'eth0' is set, that same device can't be included whitelisted itself? | 16:10 |
| sean-k-mooney | giblet: nova passes only the pci address to neutron in the port profile for the vf | 16:10 |
| giblet | sean-k-mooney: yes, that is true | 16:11 |
| giblet | sean-k-mooney: I need the neutron devs of this feature to argue why the device name was choosen for the RP nameing | 16:12 |
| giblet | stephenfin: you want some kind of sanity check on the configured value to see if there are contradictions? | 16:12 |
| *** macza has joined #openstack-nova | 16:12 | |
| *** macza has quit IRC | 16:12 | |
| sean-k-mooney | probaly becasue fo the connetx-3 nic form mellononx which has two pfs on teh same pciaddress | 16:13 |
| stephenfin | giblet: I'm not sure yet. I'm trying to decide if it's a good idea or not :) | 16:13 |
| *** macza has joined #openstack-nova | 16:13 | |
| sean-k-mooney | but that didnt work with openstack until verry verry recently and has been supperseeded | 16:13 |
| *** mdbooth_ is now known as mdbooth | 16:13 | |
| sean-k-mooney | maybe it was connectx-2 | 16:13 |
| mdbooth | lyarwood: phase 1 complete | 16:13 |
| *** wwriverrat has quit IRC | 16:14 | |
| sean-k-mooney | giblet: there may also be confusion between teh existing "devname" field and teh new "pf_interface_name" | 16:14 |
| giblet | stephenfin: if the check only depends on the actula configured value and does not need to call out to the virt driver or other 3rd parties then I can be convinced to add a check | 16:14 |
| lyarwood | mdbooth: ack thanks | 16:14 |
| giblet | sean-k-mooney: jeah the existing devname is a filtering field while the new pf_interface_name is a tag | 16:15 |
| cfriesen | can anyone figure out why this is failing in zuul? http://logs.openstack.org/63/631363/14/check/openstack-tox-py27/f6aa9a3/testr_results.html.gz It works fine for me locally. | 16:15 |
| sean-k-mooney | giblet: ya didnt we say we were not going to add more tag to the whitelist like 3 or 4 cycles ago | 16:15 |
| giblet | sean-k-mooney: if there is devname provided in the filter nova could copy that as a pf_inteface_name tag automatically | 16:15 |
| giblet | sean-k-mooney: I did not know about that rule. what should I use instead to drive the pci claim? | 16:16 |
| stephenfin | giblet: The devname would only match a single PF or VF though | 16:16 |
| sean-k-mooney | giblet: well we can also lookup the pf name via sysfs | 16:16 |
| giblet | sean-k-mooney: if there is more devname for a PF then we don't know which one to use | 16:16 |
| stephenfin | sean-k-mooney: Yeah, but as giblet pointed out, there can be a mismatch for those ConnectX-3 NICs | 16:16 |
| sean-k-mooney | yes that is true but do we want to cater for that edgecase | 16:17 |
| stephenfin | bauzas: Before you knock off for the weekend, fancy hitting https://review.openstack.org/#/c/626932/ up? | 16:17 |
| stephenfin | sean-k-mooney: Aye, that was going to be my question | 16:17 |
| bauzas | stephenfin: looking | 16:17 |
| sean-k-mooney | we could but it feels like we are workign around a silicon/driver bug | 16:17 |
| bauzas | ah this one | 16:17 |
| stephenfin | yuuup. | 16:17 |
| bauzas | +d | 16:17 |
| sean-k-mooney | giblet: stephenfin by the way only the PF had a duplicate pci adress | 16:18 |
| giblet | sean-k-mooney: if nova looks up the name form sysfs and then selects one then the neutron admin needs to use the same one in the config, but we cannot really tell the admin which one nova selected | 16:18 |
| sean-k-mooney | the vf could still be assocated with the pf netdev via sysfs | 16:19 |
| sean-k-mooney | giblet: the admin already has to set up the config correctly on both the nova and neturon side | 16:19 |
| stephenfin | Let's double check this | 16:20 |
| giblet | sean-k-mooney: no not really as so far if the neutron admin selected any of the devname it worked as the ip tool accepted any of the devname. But now the name became a key between the nova and neutron communication to decide which PF the VF is allocated from | 16:20 |
| sean-k-mooney | if we add the pf_interface_name all pci whitelist will have to be updated to make the bandwith based schduling work | 16:20 |
| *** luksky has quit IRC | 16:20 | |
| sean-k-mooney | giblet: but its not a key we send today and modifying the whitelist iis an upgrade impact | 16:21 |
| giblet | sean-k-mooney: yes, as well as every neutron config needs to be updated to enable bandwidth | 16:21 |
| sean-k-mooney | what we use as a key today is the pci address | 16:21 |
| stephenfin | sean-k-mooney: I doubt there's much that can be done about that at this point though | 16:22 |
| *** kmalloc is now known as needscoffee | 16:22 | |
| sean-k-mooney | what you are proposing would work but it feels like a hack that we should be able to avoid without modifing the config | 16:22 |
| giblet | sean-k-mooney: if the admin does not add the bandwith inventory to the neutron agent config then she dont need to modify the whitelist either | 16:22 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 16:22 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.openstack.org/639934 | 16:22 |
| sean-k-mooney | giblet: yes but this can be done without modifying the whitelist at all | 16:22 |
| stephenfin | sean-k-mooney: Let's just make sure it can though | 16:23 |
| stephenfin | We can't access sysfs outside of a driver, right? | 16:23 |
| *** sdake has quit IRC | 16:23 | |
| giblet | sean-k-mooney: yes, if neutron changes the naming to the RPs to use pci address for example | 16:23 |
| sean-k-mooney | stephenfin: the driver could add the pf_interface_tag itself if we really wanted it too automatically | 16:24 |
| giblet | sean-k-mooney: and we change pci claim to allow selecting PF for a PCIrequest by PF pci address | 16:24 |
| sean-k-mooney | so neutron should not force nova to select a pf | 16:24 |
| sean-k-mooney | it does not know the numa affintity so it cant make the right choice | 16:25 |
| giblet | sean-k-mooney: it is nova and placement that forces the pf selection | 16:25 |
| giblet | sean-k-mooney: port has resource request that is fulfilled by a placemetn allocation candidate that will become an allocation | 16:25 |
| giblet | sean-k-mooney: and that forcing the PF | 16:25 |
| giblet | sean-k-mooney: because the bandwidth is allocated from an RP that representes a PF | 16:26 |
| sean-k-mooney | the port cant force the PF | 16:26 |
| sean-k-mooney | it can ask for bandwith but its nova/placemtn aht has to match the port and bandwith up | 16:26 |
| giblet | sean-k-mooney: if the bandwidth is represented in placement then nova, by selectin an a_c, actually forces a PF | 16:26 |
| sean-k-mooney | yes it will... | 16:27 |
| sean-k-mooney | sice we have a bug in our pci affinity policies it wont break existing workloads | 16:28 |
| giblet | so when the allocation is done in placement nova needs to drive the pci claim mechanism to select VF from the same PF as the bandwidth is allocated from | 16:28 |
| sean-k-mooney | yes i know i raised that point a few tiems when i argured we could not remove the reosuce tracker | 16:29 |
| giblet | one way to drive it is to know which RP was used for the bandwidth, get the name of it, and from the name learn the pf device name | 16:29 |
| sean-k-mooney | giblet: so the request in the neutron port does not contain a devename right | 16:30 |
| giblet | sean-k-mooney: right. | 16:30 |
| sean-k-mooney | ok so its placemetn that choses the bandwtih resouce provider and we are just corralting it | 16:30 |
| giblet | sean-k-mooney: yes | 16:31 |
| giblet | sean-k-mooney: we have to make sure the pci claim chooses the same PF as placement | 16:31 |
| sean-k-mooney | i would still prefer if we looked up the pf name automatically in the driver and populated the tag rather then making it a manual step in the whitelist | 16:32 |
| stephenfin | sean-k-mooney: Out of curiosity, doesn't systemd solve the "attach to guest, detach, and still have the same name" issue? https://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/ | 16:32 |
| *** sapd1 has quit IRC | 16:32 | |
| stephenfin | sean-k-mooney, giblet: I must say, so would I | 16:32 |
| sean-k-mooney | no not in all cases | 16:32 |
| giblet | sean-k-mooney: for that nova needs to select the same device name as the neutron admin selected in the neutron config | 16:33 |
| stephenfin | Given that it's information that's very easy to extract, and the only reason I see not to do that is because of a weird bug in an effectively EOL card | 16:33 |
| sean-k-mooney | if the pf is not rebound to the nic driver after its bound to vfio-pci it will not have a netdev anymore | 16:33 |
| sean-k-mooney | giblet: yes that is not that hard to do | 16:34 |
| giblet | sean-k-mooney, stephenfin: is it doable in 4 effective day before FF? | 16:34 |
| sean-k-mooney | we have similar code to do that in os-vif already https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/linux_net.py#L313-L334 | 16:35 |
| cfriesen | could I get some eyes on https://review.openstack.org/#/c/620706/ ? It's on a runway. | 16:36 |
| sean-k-mooney | giblet: we need to look up netdev names form pci address to make hardware offload ovs work | 16:36 |
| *** psachin has quit IRC | 16:38 | |
| sean-k-mooney | giblet: you jsut do open( "/sys/bus/pci/devices/%s/physfn/net" % (pci_addr)).readline().strip() | 16:38 |
| giblet | sean-k-mooney: is it fine to do that during the startup of the nova-compute service while parsing the passthrough_whitelist? | 16:39 |
| sean-k-mooney | i dont know. we do it every time we plug a hardwar offloaed ovs-port and we plug all ports on startup | 16:39 |
| sean-k-mooney | granted its os-vif that executing it but os-vif is run as part of the nova comptue agent so it shoudl be fine | 16:40 |
| stephenfin | giblet: I'm guessing we could just slot it in here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5926-L5940 | 16:41 |
| giblet | stephenfin, sean-k-mooney: thanks for the pointers I have to sit down with a clear mind and play with that codepath to see how can I inject the extra info there in a way that it will be used by the pci claim | 16:44 |
| sean-k-mooney | giblet we also have a call to lookup device by name just after that | 16:44 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5958 | 16:44 |
| sean-k-mooney | so doing the invers should be fine | 16:44 |
| openstackgerrit | Ben Nemec proposed openstack/nova master: Add oslo.privsep to config-generator list https://review.openstack.org/640404 | 16:44 |
| sean-k-mooney | giblet: im not really objecting to useing a tag by the way | 16:45 |
| sean-k-mooney | giblet: i think we can just automate it | 16:46 |
| stephenfin | giblet: Sounds good. If you can't make progress fairly quickly, I'd be willing to hold my nose so we could get it in. Would be good to try avoid it though, given the few issues there are already | 16:46 |
| giblet | sean-k-mooney: I think I understand. I agree in general to automate it if possible. | 16:46 |
| giblet | sean-k-mooney: I'm more affraid that I will not be able to make it work | 16:47 |
| *** DarthNau has quit IRC | 16:47 | |
| giblet | stephenfin: alternatively I can remove this patch from the series, declare the two PF on the same compute on the same physnet as not-supported in Stein | 16:47 |
| stephenfin | e.g. confusion with 'devname', issues if you whitelist more than PF and need for extra (possibly unnecessary) configuration, the first two of which probably need additional code to fix | 16:47 |
| stephenfin | giblet: Aye, I was wondering if it was possible to shove this to the end and de-risk it. If that's an option, it might be a good one | 16:48 |
| sean-k-mooney | giblet: i think that is what we did for vgpus | 16:48 |
| sean-k-mooney | its not ideal but it would work. i would be good to ask leakypipes or dansmith | 16:49 |
| *** sridharg has quit IRC | 16:49 | |
| sean-k-mooney | they tend to have stong opipions on this topic | 16:49 |
| *** itlinux has quit IRC | 16:49 | |
| giblet | stephenfin: yeah, I think the sortness of time will push me to remove this patch from the critical path | 16:50 |
| sean-k-mooney | actully maybe you shouldnt ask them :) | 16:50 |
| *** luksky has joined #openstack-nova | 16:51 | |
| sean-k-mooney | giblet: i can try and hack something up at the weekend to do auto tagging and then you can decide on monday | 16:51 |
| *** Sundar has joined #openstack-nova | 16:51 | |
| giblet | sean-k-mooney: if you hack someting up then I will definitly look at it on Monday but please don't spend your free time on this crazy things :) | 16:52 |
| sean-k-mooney | i spent my free time last weekend trying to autoamte a tox nutika enviorment ot automaticlaly compile nova and then execute the unit test. | 16:54 |
| sean-k-mooney | this might be a less crazy | 16:54 |
| giblet | sean-k-mooney: :) | 16:54 |
| sean-k-mooney | i got it to work for os-vif but nova make it explode | 16:54 |
| leakypipes | sean-k-mooney, stephenfin: ask me what? | 16:55 |
| stephenfin | leakypipes: We're not overly happy about this patch and think pf_interface_name could be figured out dynamically by the driver https://review.openstack.org/#/c/625311/29 | 16:56 |
| sean-k-mooney | noting you will like. unless your opipion on adding tags to the pci whitelist has changed recently | 16:57 |
| stephenfin | leakypipes: giblet is concerned about time constraints though and think maybe declaring that two PF on the same compute on the same physnet as not-supported in Stein would be a safer option | 16:57 |
| stephenfin | *maybe declaring two PFs | 16:58 |
| *** jangutter has quit IRC | 16:58 | |
| leakypipes | stephenfin: ok, that patch is near the top of my queue. will try to comment on it this afternoon. | 16:58 |
| *** markvoelker has joined #openstack-nova | 16:58 | |
| giblet | I'm not too affraid of saying that this edge case is not supported in Stein | 16:59 |
| sean-k-mooney | we are already doing auto discovery of nic offloads exctra on startup and we have code to discover the name of pf form vfs in os-vif so i was suggesing just looking up the pf name on startup as part of the pci device discovery | 16:59 |
| giblet | however I will only be able to declare this case unsupported in the documentation as I don't see an easy way to detect the case from code and reject or just fail the boot request | 17:01 |
| giblet | so if the admin ignores the doc then she can create a situation when the bandwidth is allocated from a PF while the VF is allocated from other PF for the same port | 17:02 |
| stephenfin | giblet: Is there a file missing from https://review.openstack.org/#/c/623543/ ? | 17:04 |
| stephenfin | I'm trying to figure out where "Then the pci claim will enforce that the PF interface name in the request matches the interface name of the PF from where the VF is selected from." happens | 17:04 |
| stephenfin | (from the commit message, line 53) | 17:04 |
| *** gyee has joined #openstack-nova | 17:04 | |
| giblet | stephenfin: I think the pci claim matches the request with the device spec field by field | 17:05 |
| stephenfin | Oh, wait, tags | 17:05 |
| giblet | so if the pf_interface_name is in the request as well as in the device spec then it will be matched | 17:05 |
| stephenfin | yup. duh | 17:05 |
| stephenfin | It's clearly Friday :) | 17:05 |
| giblet | soo Friday | 17:05 |
| sean-k-mooney | https://www.youtube.com/watch?v=kfVsfOSbJY0 | 17:06 |
| *** ttsiouts has quit IRC | 17:06 | |
| sean-k-mooney | its stuck in my head so i give it to you too | 17:07 |
| * stephenfin gives sean-k-mooney the evil eyes (virtually) | 17:07 | |
| *** ivve has joined #openstack-nova | 17:08 | |
| giblet | it is heavy stuff :) | 17:11 |
| *** snevi has quit IRC | 17:18 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: check fresh data when sync_power_state doesn't line up https://review.openstack.org/636699 | 17:20 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Remove TypeError handling for get_info https://review.openstack.org/640043 | 17:20 |
| *** panda|ruck is now known as panda|ruck|off | 17:21 | |
| * giblet goes away for the weekend | 17:22 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206 | 17:25 |
| mriedem | bauzas: i'm good with ^ again | 17:28 |
| mriedem | we should all thank avolkov for his persistence | 17:28 |
| *** cdent has quit IRC | 17:28 | |
| *** markvoelker has quit IRC | 17:31 | |
| *** betherly has joined #openstack-nova | 17:40 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: explain aggregate set_metadata semantics https://review.openstack.org/640460 | 17:41 |
| mriedem | stephenfin: cfriesen: can one of you backport https://review.openstack.org/#/c/635350/ to stable/rocky? | 17:44 |
| cfriesen | mriedem: can do | 17:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: fix up numa-topology live migration hypervisor check https://review.openstack.org/640462 | 17:45 |
| cfriesen | okay | 17:45 |
| cfriesen | :) | 17:45 |
| stephenfin | no merge conflicts :) | 17:45 |
| temka | stephenfin, hey, sean-k-mooney's saying on the mailing list that you somehow managed to get different configs to different services in func tests. Any recollection of that? | 17:46 |
| stephenfin | ummm... | 17:46 |
| temka | (No link to ML post because the web UI is apparently lagging behind) | 17:47 |
| *** sdake has joined #openstack-nova | 17:47 | |
| temka | stephenfin, I'm normally artom, btw, in case you're wondering | 17:47 |
| stephenfin | temka: I'm _guessing_ he's referring to 45662d77a2da77714f8e792e86ebd64a52270ef5 | 17:49 |
| *** betherly has quit IRC | 17:50 | |
| stephenfin | temka: I don't think it's possible to have different nova.conf configurations in functional tests though | 17:50 |
| temka | (Okay, turns out this friday nick idea wasn't necessarily the best, because 'temka' is normally what my mom calls me) | 17:51 |
| stephenfin | that config is global so as soon as you'd change it, every service would see the change | 17:51 |
| temka | stephenfin, that's what I thought | 17:51 |
| * temka proceeds with his original plan | 17:52 | |
| aspiers | melwitt, mriedem: if we are retargeting SEV for Train, what is the correct approach to updating the spec/bp? | 17:54 |
| *** betherly has joined #openstack-nova | 17:54 | |
| mriedem | https://specs.openstack.org/openstack/nova-specs/readme.html#previously-approved-specifications | 17:55 |
| aspiers | hah, sorry - still asking newbie FAQs :) | 17:55 |
| aspiers | breton: ^^^ | 17:55 |
| *** mriedem is now known as mriedem_lunch | 17:56 | |
| *** dtantsur is now known as dtantsur|afk | 18:00 | |
| *** mvkr has quit IRC | 18:02 | |
| *** jaosorior has quit IRC | 18:04 | |
| *** mvkr has joined #openstack-nova | 18:06 | |
| *** IvensZambrano has joined #openstack-nova | 18:07 | |
| *** betherly has quit IRC | 18:07 | |
| *** eharney has quit IRC | 18:09 | |
| *** irclogbot_2 has joined #openstack-nova | 18:09 | |
| *** wolverineav has joined #openstack-nova | 18:10 | |
| *** wolverineav has quit IRC | 18:10 | |
| *** wolverineav has joined #openstack-nova | 18:10 | |
| *** betherly has joined #openstack-nova | 18:11 | |
| *** tesseract has quit IRC | 18:13 | |
| *** IvensZambrano has quit IRC | 18:13 | |
| *** betherly has quit IRC | 18:15 | |
| *** betherly has joined #openstack-nova | 18:17 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: fix bug with XML matcher handling missing children https://review.openstack.org/640411 | 18:20 |
| *** derekh has quit IRC | 18:22 | |
| *** ralonsoh has quit IRC | 18:22 | |
| *** wolverineav has quit IRC | 18:23 | |
| *** wolverineav has joined #openstack-nova | 18:25 | |
| *** mrhillsman is now known as mrhillsman_lunch | 18:28 | |
| *** markvoelker has joined #openstack-nova | 18:28 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Parse <emulator> elements from virConnectGetCapabilities() https://review.openstack.org/640483 | 18:28 |
| *** betherly has quit IRC | 18:30 | |
| *** betherly has joined #openstack-nova | 18:37 | |
| *** ivve has quit IRC | 18:39 | |
| *** betherly has quit IRC | 18:42 | |
| *** betherly has joined #openstack-nova | 18:45 | |
| *** wolverineav has quit IRC | 18:50 | |
| *** wolverineav has joined #openstack-nova | 18:53 | |
| *** mdbooth_ has joined #openstack-nova | 18:55 | |
| *** betherly has quit IRC | 18:57 | |
| *** cdent has joined #openstack-nova | 18:58 | |
| *** mdbooth has quit IRC | 18:58 | |
| *** cdent has quit IRC | 18:58 | |
| *** sdake has quit IRC | 19:00 | |
| *** betherly has joined #openstack-nova | 19:01 | |
| *** markvoelker has quit IRC | 19:01 | |
| *** awalende has joined #openstack-nova | 19:03 | |
| *** ircuser-1 has quit IRC | 19:03 | |
| *** ircuser-1 has joined #openstack-nova | 19:05 | |
| *** awalende_ has joined #openstack-nova | 19:05 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855 | 19:06 |
| *** betherly has quit IRC | 19:07 | |
| *** awalende has quit IRC | 19:08 | |
| *** wolverineav has quit IRC | 19:12 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855 | 19:15 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.openstack.org/638680 | 19:17 |
| *** purplerbot has quit IRC | 19:18 | |
| *** purplerbot has joined #openstack-nova | 19:18 | |
| *** jdillaman has quit IRC | 19:18 | |
| *** betherly has joined #openstack-nova | 19:26 | |
| openstackgerrit | Merged openstack/python-novaclient master: Remove unnecessary if statement https://review.openstack.org/640266 | 19:27 |
| temka | aspiers, btw, going by your commit message in https://review.openstack.org/#/c/638680/4, you know you can submit multiple patches as a stack/series for review, right? | 19:27 |
| aspiers | temka: that's what I've done :) | 19:28 |
| *** mriedem_lunch is now known as mriedem | 19:28 | |
| temka | aspiers, ok cool - you were calling out a dependency needlessly in your commit message, so I wanted to double check | 19:29 |
| aspiers | temka: well, I don't think it's entirely needless. I think it helps explain the dependency | 19:29 |
| temka | aspiers, as you wish :) | 19:29 |
| *** mrhillsman_lunch is now known as mrhillsman | 19:29 | |
| aspiers | I'm a believer in "too much info is better than not enough" - at least in this context | 19:29 |
| temka | I'm not sure I'd agree, actually :) | 19:30 |
| aspiers | not in general | 19:30 |
| temka | Heh, not even in this context | 19:30 |
| aspiers | It's easier for reviewers to skip over stuff which is obvious to them than for them to be forced to figure out non-obvious stuff | 19:30 |
| *** wolverineav has joined #openstack-nova | 19:30 | |
| aspiers | The former is quicker than the latter | 19:30 |
| *** betherly has quit IRC | 19:30 | |
| aspiers | I'm generalizing, of course :) | 19:30 |
| temka | For me at least, it implies that there's a dependencies that's not already apparent in the patch series | 19:31 |
| aspiers | but I think it's true in this particular scenario | 19:31 |
| temka | So I went looking, and realized you were just making it really explicit | 19:31 |
| aspiers | The thing is, a patch series is linear, but a dependency tree is a DAG | 19:31 |
| aspiers | The serialization is lossy, so it is not trivial to infer the tree from the series | 19:32 |
| temka | Heh | 19:32 |
| aspiers | Coincidentally, I've done a lot of work on this topic outside OpenStack: https://github.com/aspiers/git-deps | 19:32 |
| aspiers | But anyway, I welcome all nitpicks, so thanks ;-) | 19:33 |
| temka | aspiers, heh, I can't bring myself to concentrate fully on what I'm trying to do, so instead I nitpick others's work :/ | 19:33 |
| aspiers | LOL I have exactly the same problem ;-) | 19:34 |
| temka | I had no idea of your level of experience with Gerrit, so just wanted to make sure you're not pushing one patch at a time and manually specified the deps | 19:34 |
| aspiers | temka: Yeah thanks, it's definitely worth checking that with unfamiliar faces^Wnicks :-) | 19:35 |
| aspiers | I'm pretty familiar with Gerrit. Attended the last User Summit which was super fun and interesting. | 19:35 |
| *** eharney has joined #openstack-nova | 19:35 | |
| temka | But then you started talking about DAGs and I realized I'm *probably* barking up the wrong tree ;) | 19:35 |
| aspiers | ;) | 19:36 |
| temka | Mind you, I've seen people graduate with CS degress and not be able to write a single line of C, so :P | 19:36 |
| aspiers | This is true | 19:36 |
| aspiers | git and its ecosystem is actually one of my specialist areas | 19:36 |
| aspiers | I've hacked on git a bit, and built a plethora of tools. Since it's Friday, you can find more ramblings at https://blog.adamspiers.org/tag/git/ if you're curious | 19:38 |
| temka | "Structured Procrastination" | 19:38 |
| temka | Sounds about right | 19:38 |
| aspiers | Also will finish adding https://ethercalc.openstack.org/github-gerrit to the Contributor's Guide one of these days ... maybe :-o | 19:39 |
| *** betherly has joined #openstack-nova | 19:39 | |
| temka | aspiers, wanna add https://github.com/berrange/gerrymander in the Gerrit clients square? | 19:41 |
| aspiers | ooh, that's a new one for me I think | 19:41 |
| aspiers | temka: please feel free | 19:41 |
| temka | Not sure it's still maintained, it's been a few years since last commit | 19:42 |
| *** tosky has quit IRC | 19:42 | |
| *** tosky has joined #openstack-nova | 19:43 | |
| aspiers | add it anyway | 19:43 |
| temka | Done | 19:43 |
| aspiers | mriedem: SEV trait successfully detected on real hardware using capabilities :) https://pasteboard.co/I3rPhvJ.png | 19:44 |
| *** ivve has joined #openstack-nova | 19:47 | |
| *** betherly has quit IRC | 19:48 | |
| *** irclogbot_2 has quit IRC | 19:49 | |
| mriedem | get right out of town | 19:52 |
| aspiers | :) | 19:52 |
| aspiers | plus all those new capability traits too of course | 19:53 |
| *** wolverineav has quit IRC | 19:56 | |
| mriedem | aspiers: so you've already worked around the virConnectGetDomainCapabilities thing? | 19:57 |
| cfriesen | sean-k-mooney: ran into a problem with the cold migration with TPM.../var/lib/libvirt/swtpm and the directories under it are owned by root and nova-compute is not running as root. | 19:57 |
| *** wolverineav has joined #openstack-nova | 19:57 | |
| aspiers | mriedem: yes, https://review.openstack.org/#/c/633855/7/nova/virt/libvirt/host.py@711 | 19:57 |
| *** markvoelker has joined #openstack-nova | 19:58 | |
| aspiers | mriedem: for SEV, this is *almost* good enough for now; I think the only possible issue is that if testing on another distro, qemu-kvm might live in a different place | 19:58 |
| aspiers | I don't have a RHEL / Fedora box handy to check | 19:59 |
| aspiers | mriedem: and the code in comments is pretty darn close to what it will look like when that patch does land | 20:00 |
| *** irclogbot_2 has joined #openstack-nova | 20:01 | |
| *** wolverineav has quit IRC | 20:02 | |
| *** Sundar has quit IRC | 20:13 | |
| *** betherly has joined #openstack-nova | 20:16 | |
| *** sdake has joined #openstack-nova | 20:18 | |
| *** sdake has quit IRC | 20:18 | |
| temka | Dammit, even something as simple as 2 different hostnames for the 2 compute services is going to be annoying | 20:19 |
| temka | https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/fakelibvirt.py#L1131 | 20:20 |
| mriedem | melwitt: i'm confused about your comment here https://review.openstack.org/#/c/633350/7/nova/objects/instance_mapping.py@42 | 20:20 |
| *** betherly has quit IRC | 20:21 | |
| mriedem | temka: ah that's where that comes from...i was wondering because that question came up in a functional test that gibi wrote which was using the fakelibvirt stuff | 20:21 |
| mriedem | can't you modify Connection to pass in a hostname which defaults to 'compute1'? | 20:21 |
| mriedem | note that self.start_service() in the tests will allow you to specify the binary (compute) and hostname which is what our multi-host functional tests do, | 20:22 |
| mriedem | but those aren't using the fakelibvirt stuff | 20:22 |
| *** sdake has joined #openstack-nova | 20:22 | |
| temka | mriedem, it's solved in the fake virt driver, but that's different because it's a virt drive | 20:23 |
| temka | fakelibvirt isn't a driver - the real libvirt is the driver | 20:24 |
| temka | fakelibvirt just mocks out the parts that call the libvirt API | 20:24 |
| mriedem | i.e. https://github.com/openstack/nova/blob/master/nova/virt/fake.py#L654 | 20:24 |
| temka | mriedem, right, and virt/fake.py replaces virt/libvirt/driver.py | 20:25 |
| mriedem | yeah i know | 20:25 |
| temka | fakelibvirt.py replaces what virt/libvirt/driver.py calls down to | 20:25 |
| mriedem | right the python-libvirt interface | 20:25 |
| temka | Right | 20:25 |
| *** derekh has joined #openstack-nova | 20:26 | |
| mriedem | dansmith: am i correct in my understanding of what you're asking for here? https://review.openstack.org/#/c/633350/7/nova/objects/instance_mapping.py@42 | 20:27 |
| mriedem | on load of instance mapping, of it doesn't have a user_id, try to get it from the request spec, failing that, try the build request, failing *that* try the instance via the cell mapping | 20:27 |
| mriedem | s/of/if/ | 20:27 |
| *** liuyulong has quit IRC | 20:27 | |
| dansmith | mriedem: right, the nullability has nothing to do with where or how we get the user_id to fill it in | 20:28 |
| *** wolverineav has joined #openstack-nova | 20:28 | |
| temka | I guess I have to mock ComputeManager._get_nodename() | 20:29 |
| temka | ... per service | 20:29 |
| mriedem | dansmith: which means we wouldn't need to update the instance mapping on read of the instance from the api https://review.openstack.org/#/c/638574/4/nova/compute/api.py@2404 | 20:29 |
| mriedem | although, if the request spec doesn't have user_id, and the build request is gone, and the cell the instance is in is down... | 20:29 |
| mriedem | then i guess you're sol? | 20:30 |
| mriedem | temka: you can't override the fakelibvirt.Connection hostname value it uses? | 20:30 |
| aspiers | OK, weekend time. Have a good one everyone o/ | 20:30 |
| *** markvoelker has quit IRC | 20:31 | |
| temka | mriedem, I guess I could, but I can't make it different depending on which compute service is calling it | 20:31 |
| dansmith | temka: mock service.manager._get_nodename() after it's started to return the value it needs to keep returning, instead of mocking the class | 20:32 |
| temka | dansmith, tried that just now, didn't work | 20:33 |
| temka | I think it needs to be mocked *before* (somehow) it's started | 20:33 |
| dansmith | mriedem: yeah, I mean, making that value nullable for the down-cell-and-not-anywhere-else case is not reasonable I think | 20:33 |
| temka | Because upon startup it reports to placement, and there's a hostname conflict | 20:33 |
| dansmith | temka: you have to mock it both places, | 20:33 |
| *** wolverineav has quit IRC | 20:33 | |
| *** betherly has joined #openstack-nova | 20:33 | |
| *** phasespace has joined #openstack-nova | 20:33 | |
| dansmith | temka: which is why I said "needs to keep returning" | 20:34 |
| temka | dansmith, which both places? | 20:34 |
| dansmith | the class will catch the startup case, but be invalid once you move to the next service, so you need to mock the resulting instance of the manager class to keep returning the value ongoing | 20:34 |
| temka | Ah, I see | 20:34 |
| dansmith | we used to be able to pass in a different manager class to start_service i think, which would let you just subclass per node.. can we still do that? | 20:35 |
| temka | So mock fakelibvirt's getHostname, start compute0, mock its get_nodename, mock getHostname to the 2nd thing, start compute1, mock its get_nodename() | 20:35 |
| temka | That feels... racy | 20:35 |
| temka | Actually no | 20:36 |
| dansmith | temka: there are no threads here so, no | 20:36 |
| mriedem | heh you still can technically classload a compute manager class it looks like | 20:37 |
| dansmith | mriedem: yeah that's what I was thinking of | 20:37 |
| *** betherly has quit IRC | 20:37 | |
| mriedem | self.start_service('compute', host='fake-host1', manager='artom.special.fake.ComputeManager') | 20:38 |
| temka | If anyone says 'dependency injection' there's going to be violence | 20:38 |
| dansmith | yeah | 20:38 |
| temka | I *still* have no idea what that is | 20:38 |
| *** betherly has joined #openstack-nova | 20:38 | |
| temka | Despite university's best attempt to drill it into our heads with massive bloated Java frameworks | 20:39 |
| mriedem | i should have gone to university to learn about hospital | 20:39 |
| temka | dansmith, woot, that worked | 20:39 |
| mriedem | colour flavour | 20:39 |
| mriedem | dansmith: so my one reservation on loading the instance mapping user_id from the turducken is that down cell case because i'm not sure what we'd do, likely 500 from the api, but you can't really online data migrate your way out of that b/c the online data migration relies on, you guessed it, the cells being up | 20:40 |
| dansmith | mriedem: yeah | 20:41 |
| dansmith | you're also migrating from a state where cells had to be up, | 20:41 |
| *** jmlowe has quit IRC | 20:41 | |
| dansmith | so until all that data is patched up, it's not surprising that...all cells have to be up | 20:41 |
| *** sdake has quit IRC | 20:42 | |
| openstackgerrit | Merged openstack/nova master: Ironic: bump minimum API version to 1.38 https://review.openstack.org/636326 | 20:44 |
| *** betherly has quit IRC | 20:47 | |
| *** igordc has quit IRC | 20:48 | |
| *** igordc has joined #openstack-nova | 20:49 | |
| *** wolverineav has joined #openstack-nova | 20:51 | |
| temka | "Allocation for resource provider 'e7fbbec5-7f95-4f4e-895c-a14b691bca6e' that does not exist" | 20:56 |
| temka | Looks like I'm missing a placement-y fixture or something | 20:56 |
| mnaser | does nova cache neutron port info somewhere? | 20:57 |
| mriedem | mnaser: instance_info_caches table | 20:57 |
| mnaser | i had a misconfigured n-ovs-agent which lead to resizes failing with binding_failed on the port | 20:57 |
| mnaser | i've reset the info, but its still grabbing the cached value | 20:58 |
| mnaser | ok, i'll dig there, thanks mriedem | 20:58 |
| mriedem | mnaser: see https://review.openstack.org/#/c/591607/ | 20:58 |
| mriedem | the instance_info_caches.network_info is a json blob string so if you're looking to mess with that manually.... | 20:59 |
| mnaser | mriedem: neat. i assume its not a real cache as in i cant really just drop that row | 20:59 |
| mriedem | ummm | 20:59 |
| mriedem | i don't think that will work | 21:01 |
| mriedem | because anything that tries to refresh the cache from neutron will just rely on the existing cache, which will now be empty... | 21:02 |
| mriedem | which is what https://review.openstack.org/#/c/591607/ was trying to address | 21:02 |
| *** tbachman has quit IRC | 21:03 | |
| mriedem | wholesale deleting of the cache would also make nova forget which ports nova created and which were pre-created, so on server delete nova will also delete any pre-existing ports | 21:03 |
| mriedem | which is probably not something your users want | 21:03 |
| mriedem | related change here https://review.openstack.org/#/c/603844/ | 21:04 |
| mriedem | the issue is kind of this code right here https://github.com/openstack/nova/blob/c57d532a306303412d6253f424bee7d665865279/nova/network/neutronv2/api.py#L3055 | 21:05 |
| mriedem | if you wipe out that record in the db, that will result in port_ids being empty | 21:05 |
| mriedem | so https://github.com/openstack/nova/blob/c57d532a306303412d6253f424bee7d665865279/nova/network/neutronv2/api.py#L3061 won't do anything | 21:05 |
| mriedem | it's kind of dumb - if port_ids was empty but current_neutron_port_map is not, we should probably realize "oh we're fully rebuilding the cache b/c the cache was wiped out" | 21:06 |
| mnaser | mriedem: yeah so cache is probably not really cache i guess | 21:07 |
| mnaser | it is tracking state | 21:07 |
| mriedem | well it's a cache in the sense that you don't have to go to neutron every time you want to find out what ports are attached to a server, | 21:07 |
| mriedem | similar to the block_device_mappings table is a "cache" | 21:07 |
| mriedem | of volumes attached to the server | 21:07 |
| mnaser | yeah | 21:08 |
| mriedem | but yeah it's got some state information in there too about the ports nova knows it created | 21:08 |
| *** erlon_ has quit IRC | 21:08 | |
| mnaser | (ps i totally thought this whole detach => delete port thing is silly but thats another topic) | 21:08 |
| mnaser | this whole thing would be so much easier if i just detached the port and attached it again | 21:09 |
| mnaser | but because it was done on boot, detaching the port = deleting it | 21:09 |
| * mnaser thinks an explicit detach should always detach not "delete if it was created by nova" | 21:09 | |
| mriedem | oh there was a spec for that... | 21:09 |
| mriedem | i.e. delete_on_termination for ports | 21:09 |
| mriedem | like volumes | 21:09 |
| *** betherly has joined #openstack-nova | 21:11 | |
| mriedem | anyway like i said if you delete the cache via the db, and port_ids is empty but current_neutron_port_map is not https://github.com/openstack/nova/blob/c57d532a306303412d6253f424bee7d665865279/nova/network/neutronv2/api.py#L3061 you could probably just force a cache refresh | 21:11 |
| cfriesen | can someone take a look at http://logs.openstack.org/63/631363/15/check/openstack-tox-py27/6b108d3/testr_results.html.gz and suggest why test_executable_exists_in_path is failing? It works perfectly on my local box. | 21:13 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Force refresh nw info cache if cache is empty but ports attached https://review.openstack.org/640516 | 21:16 |
| mriedem | mnaser: like this ^ | 21:16 |
| *** awalende has joined #openstack-nova | 21:21 | |
| *** awalende_ has quit IRC | 21:21 | |
| *** betherly has quit IRC | 21:23 | |
| *** tbachman has joined #openstack-nova | 21:24 | |
| mriedem | dansmith: here is another fun side effect of the mox->mock test removal - besides making backports a nightmare, it also makes git blame a real chore | 21:27 |
| mriedem | that is all | 21:27 |
| *** betherly has joined #openstack-nova | 21:27 | |
| dansmith | yeah | 21:27 |
| mriedem | plus most parts of nova you can't git blame in github anymore b/c it times out | 21:27 |
| dansmith | ...really? | 21:28 |
| *** markvoelker has joined #openstack-nova | 21:28 | |
| dansmith | with git or github? | 21:28 |
| mriedem | github | 21:28 |
| mnaser | lol yeah | 21:28 |
| mnaser | github | 21:28 |
| mriedem | not cli | 21:28 |
| dansmith | heh nice | 21:28 |
| mnaser | mriedem: i noticed if you refresh a few times | 21:28 |
| mnaser | it eventually goes through | 21:28 |
| mnaser | i assume that it caches portions of the git blame page | 21:28 |
| mriedem | git blame nova.compute.manager | 21:28 |
| mriedem | or nova.virt.libvirt.driver | 21:28 |
| mnaser | and then eventually caches enough so the request doesnt timeout | 21:29 |
| openstackgerrit | Merged openstack/nova master: Add "links" in the response of "nova show" for a down-cell instance https://review.openstack.org/640302 | 21:29 |
| mriedem | well i see this has come up before https://review.openstack.org/#/q/I3b9f60a2c4aea904f39d6914c8f35c4d682a6b3a | 21:31 |
| mriedem | followed by https://review.openstack.org/#/q/I53d5284907d44ae8b5546993f8fd461b385c39e6 | 21:32 |
| mriedem | we can't seem to make up our mind | 21:32 |
| *** betherly has quit IRC | 21:36 | |
| *** irclogbot_2 has quit IRC | 21:38 | |
| *** betherly has joined #openstack-nova | 21:39 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Force refresh nw info cache if cache is empty but ports attached https://review.openstack.org/640516 | 21:40 |
| *** tbachman has quit IRC | 21:40 | |
| mriedem | melwitt: well i'm kind of stuck on how to proceed with your counting quotas from placement stuff | 21:41 |
| openstackgerrit | Tim Rozet proposed openstack/nova master: Fixes race condition with privsep utime https://review.openstack.org/625741 | 21:44 |
| mriedem | stephenfin: in case you didn't notice it looks like mikal would like you to remove the -2 from https://review.openstack.org/#/c/554438/ | 21:49 |
| *** tbachman has joined #openstack-nova | 21:50 | |
| *** tbachman has quit IRC | 21:52 | |
| *** betherly has quit IRC | 21:52 | |
| *** betherly has joined #openstack-nova | 21:55 | |
| openstackgerrit | Merged openstack/nova master: conf: Deprecate 'disable_libvirt_livesnapshot' option https://review.openstack.org/626932 | 21:56 |
| openstackgerrit | Merged openstack/nova master: Stop using "nova" in API samples when creating a server https://review.openstack.org/639874 | 21:57 |
| openstackgerrit | Merged openstack/nova master: Make Claim._claim_test handle SchedulerLimits object https://review.openstack.org/636410 | 21:57 |
| *** markvoelker has quit IRC | 22:01 | |
| *** wolverineav has quit IRC | 22:04 | |
| *** wolverineav has joined #openstack-nova | 22:05 | |
| *** betherly has quit IRC | 22:08 | |
| *** hongbin has joined #openstack-nova | 22:15 | |
| mriedem | is InstanceNUMACell.id a db primary key or something from the actual host...? | 22:16 |
| *** ivve has quit IRC | 22:16 | |
| mriedem | i guess the latter | 22:17 |
| *** awaugama has quit IRC | 22:22 | |
| melwitt | mriedem: reading through your comments | 22:32 |
| *** jmlowe has joined #openstack-nova | 22:32 | |
| *** wolverineav has quit IRC | 22:35 | |
| *** awalende has quit IRC | 22:36 | |
| *** awalende has joined #openstack-nova | 22:36 | |
| melwitt | mriedem: why stuck? do you and dansmith think the quota counting should try to parse user_id out of request specs? I assumed not | 22:37 |
| mriedem | you mean the InstanceMapping._from_db_object? | 22:37 |
| mriedem | stuck on whether or not InstanceMapping.user_id should be nullable, yes | 22:37 |
| melwitt | oh | 22:39 |
| melwitt | so the desire is to get it from the request spec json blob in _from_db_object | 22:39 |
| *** tbachman has joined #openstack-nova | 22:39 | |
| mriedem | well we have 3 places to look | 22:40 |
| mriedem | request spec, build request, instance in the cell | 22:40 |
| *** awalende has quit IRC | 22:40 | |
| mriedem | if the cell is down, the last one is going to blow up | 22:40 |
| melwitt | build request doesn't have it, AFAICT | 22:40 |
| mriedem | BuildRequest.instance.user_id | 22:40 |
| mriedem | BuildRequest.instance is a json blob | 22:40 |
| melwitt | oh, ok | 22:40 |
| melwitt | I didn't know that was persisted in the db | 22:41 |
| mriedem | yup | 22:41 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L934 | 22:42 |
| mriedem | elbragstad: i waxed policy rule names just for you https://review.openstack.org/#/c/621476/33/nova/policies/server_topology.py@20 | 22:44 |
| *** ajo_ has joined #openstack-nova | 22:45 | |
| *** odyssey4me_ has joined #openstack-nova | 22:45 | |
| *** jbryce_ has joined #openstack-nova | 22:45 | |
| *** betherly has joined #openstack-nova | 22:46 | |
| cfriesen | any chance either one of you could take a quick look at https://review.openstack.org/#/c/620706/ ? It's on a runway and nobody has looked at it since Matt and Alex on the 27th. | 22:46 |
| mriedem | cfriesen: i'll be honest i'm avoiding that one | 22:46 |
| cfriesen | heh | 22:46 |
| cfriesen | good to know | 22:46 |
| mriedem | it's just low priority for me | 22:46 |
| mriedem | can the hardware stuff be split out of that? | 22:47 |
| mriedem | you windriver folk seem to enjoy the larger single patches... | 22:47 |
| mriedem | that would drop 1/3 of the size (and context to load) for the api part of it | 22:49 |
| cfriesen | yeah, I can break out the hardware bit. you're thinking do that part first? | 22:49 |
| mriedem | it's a dependency for the api stuff it looks like | 22:49 |
| cfriesen | or second | 22:49 |
| mriedem | idk honestly | 22:49 |
| cfriesen | I think it could go either way, a bunch of the api stuff is just calling existing checks | 22:50 |
| mriedem | the new hardware stuff is "Added the following validations to _validate_flavor_image(): cpu_policy and cpu_thread_policy values, serial ports, realtime mask, cpu topology." right? | 22:50 |
| *** wolverineav has joined #openstack-nova | 22:50 | |
| cfriesen | no, much less than that | 22:51 |
| mriedem | oh i see https://review.openstack.org/#/c/620706/27/nova/compute/api.py@628 | 22:51 |
| cfriesen | those are all existing functions | 22:52 |
| mriedem | so leakypipes and bauzas approved that spec but haven't reviewed the code at all yet... | 22:52 |
| *** eharney has quit IRC | 22:52 | |
| *** odyssey4me has quit IRC | 22:52 | |
| *** nicolasbock has quit IRC | 22:52 | |
| *** lamt has quit IRC | 22:52 | |
| *** jbryce has quit IRC | 22:52 | |
| *** melwitt has quit IRC | 22:52 | |
| *** ajo has quit IRC | 22:52 | |
| *** ajo_ is now known as ajo | 22:52 | |
| *** odyssey4me_ is now known as odyssey4me | 22:52 | |
| *** jbryce_ is now known as jbryce | 22:52 | |
| mriedem | this just seems like something i'd have to fine-toothed-comb through | 22:53 |
| *** melwitt has joined #openstack-nova | 22:53 | |
| mriedem | and i'm already at mental capacity for lots of other blueprints i'm reviewing right now | 22:53 |
| mriedem | plus it's fucking snowing again and i'm about to lose it | 22:53 |
| mriedem | https://www.kimt.com/content/news/February-has-been-a-record-breaking-month-for-snow-and-it-looks-like-March-will-start-with--506431011.html | 22:54 |
| elbragstad | mriedem mmm - interesting | 22:54 |
| mriedem | elbragstad: not really, but if that floats your boat :) | 22:55 |
| mriedem | i think it might | 22:55 |
| *** lchabert has quit IRC | 22:55 | |
| elbragstad | oh - you know it | 22:55 |
| elbragstad | what does host-info do? | 22:55 |
| elbragstad | lemme guess, gets information about the host? | 22:55 |
| mriedem | shows admin-sensitive details | 22:55 |
| cfriesen | mriedem: I get where you're coming from...but from my end it's frustrating since being on a runway is supposed to mean it gets reviews... | 22:56 |
| mriedem | the api returns stuff that is admin-or-owner and if you're admin you get some extra juicy bits | 22:56 |
| mriedem | cfriesen: yup, i know | 22:56 |
| elbragstad | mmm | 22:56 |
| elbragstad | ideally - it would be nice if the policies for those types of things went away | 22:56 |
| mriedem | elbragstad: what replaces them? | 22:57 |
| *** lchabert has joined #openstack-nova | 22:57 | |
| mriedem | different route? | 22:57 |
| elbragstad | well - i'm not sure if this will work based on the two minutes i've known about this functionality | 22:57 |
| elbragstad | but | 22:57 |
| elbragstad | you could populate those bits if the request was made with a system-scoped token + a certain role | 22:58 |
| mriedem | i knew you'd say something about system scoped tokens | 22:58 |
| elbragstad | mmmm | 22:59 |
| *** eharney has joined #openstack-nova | 22:59 | |
| *** markvoelker has joined #openstack-nova | 22:59 | |
| mriedem | does your wife tell you to stop talking about those at dinner? | 22:59 |
| *** betherly has quit IRC | 22:59 | |
| elbragstad | we don't talk about policy at dinner | 22:59 |
| mriedem | just baby stuff | 22:59 |
| elbragstad | i usually just fall asleep staring at a plate | 23:00 |
| mriedem | alright, anyway, not urgent, just mentioned it since i know it's a thing | 23:00 |
| mriedem | not sure if the host_info is a subaction or attribute based on the policy naming doc | 23:00 |
| mriedem | seems like an 'attribute' | 23:00 |
| elbragstad | yeah - i suppose you could think of it that way, too | 23:00 |
| elbragstad | sinec it's a collection of attributes that only system users get to see, right? | 23:01 |
| mriedem | yeah this is definitely system scope stuff, not project admin | 23:01 |
| mriedem | b/c it's about the physical infra | 23:01 |
| elbragstad | sure | 23:01 |
| openstackgerrit | ya.wang proposed openstack/nova master: Select cpu model from a list of cpu models https://review.openstack.org/637834 | 23:01 |
| elbragstad | ok - so i guess it depends on if you want to maintain two policies for the "same" API | 23:01 |
| mriedem | we have some of that in other places | 23:02 |
| elbragstad | or if you want to just implement a little filtering in the service and have a single policy to protect a single API | 23:02 |
| mriedem | based on scope type... | 23:02 |
| elbragstad | yes | 23:02 |
| mriedem | so rule is admin-or-owner, and you get the extras with a system scope token | 23:02 |
| *** awalende has joined #openstack-nova | 23:02 | |
| elbragstad | the rule would be something like.. | 23:03 |
| elbragstad | (role:admin and system_scope:all) or rule:owner | 23:03 |
| mriedem | ok, which can still be overridden yeah? | 23:04 |
| mriedem | if you want non-system scope but support-level people to be able to see stuff | 23:04 |
| elbragstad | operators can override - if that's the check string | 23:04 |
| elbragstad | support-level people? | 23:05 |
| melwitt | mriedem: replied to your comment. I'll push another PS soon. thanks for raising the unresolved bit that I had missed | 23:05 |
| elbragstad | support-level people to me == someone with the reader role on the system (`openstack role add --user bob --system reader`) | 23:05 |
| mriedem | people that aren't operators, they don't have the keys to the hardware, but they need some kind of admin-y level auth to see things | 23:05 |
| elbragstad | ah | 23:05 |
| mriedem | elbragstad: yeah ok | 23:05 |
| mriedem | that | 23:05 |
| elbragstad | right... | 23:05 |
| elbragstad | so you could rework that policy to be more flexible | 23:06 |
| *** betherly has joined #openstack-nova | 23:06 | |
| elbragstad | by default, to allow for those cases | 23:06 |
| elbragstad | (role:reader and system_scope:all) or rule:owner | 23:06 |
| elbragstad | ^ should do it | 23:06 |
| *** frickler has quit IRC | 23:06 | |
| mriedem | ok, well let's not go crazy here. i have to run pickup the kid before i get snowed in | 23:06 |
| *** frickler has joined #openstack-nova | 23:06 | |
| elbragstad | fwiw - we just started documenting a bunch of this | 23:06 |
| elbragstad | https://review.openstack.org/#/c/638563/ | 23:06 |
| elbragstad | ^ you know - in case you decide you want to read it over dinner | 23:07 |
| mriedem | i just might | 23:07 |
| mriedem | i talk shop at dinner and it just goes into the void | 23:07 |
| elbragstad | lol | 23:07 |
| *** mriedem is now known as mriedem_afk | 23:08 | |
| *** betherly has quit IRC | 23:11 | |
| *** luksky has quit IRC | 23:15 | |
| *** betherly has joined #openstack-nova | 23:16 | |
| marst | mriedem: Hey Matt! Just to confirm that fake nova driver works perfectly with minimal local.conf in stable/rocky devstack. Thanks a lot once again! | 23:19 |
| *** betherly has quit IRC | 23:25 | |
| *** betherly has joined #openstack-nova | 23:29 | |
| *** markvoelker has quit IRC | 23:31 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 23:31 |
| *** awalende_ has joined #openstack-nova | 23:32 | |
| *** sapd1 has joined #openstack-nova | 23:33 | |
| *** awalende has quit IRC | 23:35 | |
| *** awalende_ has quit IRC | 23:36 | |
| *** awalende has joined #openstack-nova | 23:37 | |
| *** awalende has quit IRC | 23:41 | |
| *** betherly has quit IRC | 23:43 | |
| *** wolverineav has quit IRC | 23:55 | |
| *** wolverineav has joined #openstack-nova | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
