| *** hongbin has quit IRC | 00:00 | |
| *** macza_ has quit IRC | 00:03 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706 | 00:04 |
|---|---|---|
| *** sdake has joined #openstack-nova | 00:04 | |
| *** dave-mccowan has quit IRC | 00:07 | |
| *** mriedem has quit IRC | 00:13 | |
| *** mriedem has joined #openstack-nova | 00:19 | |
| *** ircuser-1 has quit IRC | 00:25 | |
| *** lbragstad has quit IRC | 00:32 | |
| *** takashin has joined #openstack-nova | 00:43 | |
| *** agopi has joined #openstack-nova | 00:48 | |
| *** ileixe has joined #openstack-nova | 00:54 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Stop using "nova" in API samples when creating a server https://review.openstack.org/639874 | 00:57 |
| mriedem | uff da | 00:57 |
| *** _hemna has joined #openstack-nova | 00:59 | |
| *** sdake has quit IRC | 01:08 | |
| openstackgerrit | Merged openstack/os-vif master: add additional check and gate jobs for os-vif https://review.openstack.org/639732 | 01:17 |
| *** betherly has joined #openstack-nova | 01:17 | |
| *** betherly has quit IRC | 01:22 | |
| *** _fragatina has quit IRC | 01:22 | |
| *** _hemna has quit IRC | 01:35 | |
| *** gyee has quit IRC | 01:38 | |
| *** liuyulong_ has quit IRC | 01:47 | |
| *** itlinux has quit IRC | 01:54 | |
| *** ileixe has quit IRC | 01:59 | |
| *** ileixe has joined #openstack-nova | 02:00 | |
| *** gbarros has joined #openstack-nova | 02:03 | |
| mriedem | yonglihe: comments inline https://review.openstack.org/#/c/621474/ | 02:06 |
| *** sdake has joined #openstack-nova | 02:09 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:09 | |
| *** betherly has joined #openstack-nova | 02:10 | |
| *** betherly has quit IRC | 02:14 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750 | 02:14 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 02:19 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.openstack.org/634827 | 02:19 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.openstack.org/634828 | 02:19 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.openstack.org/635229 | 02:19 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.openstack.org/634605 | 02:19 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.openstack.org/634606 | 02:19 |
| mriedem | gdi artom | 02:21 |
| mriedem | https://review.openstack.org/#/c/634606/36/nova/conductor/tasks/live_migrate.py@177 | 02:22 |
| yonglihe | mriedem: how about i remove the avaliable zone from request and ignore the returned 'nova' avaliable zone in api-sample? | 02:24 |
| mriedem | yonglihe: if you remove the availability_zone=nova from the server create request, the response will correctly be az=nova | 02:26 |
| mriedem | but that's fine | 02:26 |
| mriedem | just remove the az from the request | 02:26 |
| yonglihe | ok then. | 02:26 |
| yonglihe | mriedem: we can not use self.sg_uuid in generalize_subs, because the api sample json verified failed while running it next time. | 02:30 |
| *** hongbin has joined #openstack-nova | 02:32 | |
| mriedem | I'm not sure why you even need generalize_subs since you are doing this in the tests: | 02:35 |
| mriedem | subs['sg_uuid'] = self.sg_uuid | 02:35 |
| mriedem | as noted, if you just change the template to use %(uuid)s then you don't need the sg_uuid variable | 02:35 |
| mriedem | i know the api samples functional tests are frustrating... | 02:35 |
| mriedem | there is a lot of black magic involved in making them work | 02:36 |
| yonglihe | yeah, I tried, only if I put it in generalize_stub it works..., i changed the template use %(uuid)s, it might conflict with other uuid? i don't know, I gonna try if that works. thanks. | 02:38 |
| *** dcdawg has joined #openstack-nova | 02:39 | |
| mriedem | %(uuid)s is just a regex matcher | 02:40 |
| mriedem | so any uuid will pass | 02:40 |
| mriedem | or should | 02:40 |
| mriedem | yonglihe: see how far you get and push up your changes. if i find more stuff i'll just make the changes myself so we can get this approved. | 02:41 |
| *** itlinux has joined #openstack-nova | 02:41 | |
| yonglihe | thanks, i think then it gonna works, i'm working on that. | 02:42 |
| *** dcdawg has quit IRC | 02:43 | |
| *** sdake has quit IRC | 02:46 | |
| *** Dinesh_Bhor has quit IRC | 02:49 | |
| yonglihe | use 'uuid' instead of 'sg_uuid' ruined response checking. https://www.irccloud.com/pastebin/2YH9pvmK/use%20'uuid'%20instead%20of%20'sg_uuid'%20ruined%20response%20checking. | 02:52 |
| *** Dinesh_Bhor has joined #openstack-nova | 02:53 | |
| *** gbarros has quit IRC | 02:59 | |
| *** psachin has joined #openstack-nova | 03:02 | |
| *** wolverineav has quit IRC | 03:06 | |
| *** dave-mccowan has joined #openstack-nova | 03:07 | |
| *** udesale has joined #openstack-nova | 03:15 | |
| *** sdake has joined #openstack-nova | 03:16 | |
| *** sdake has quit IRC | 03:17 | |
| *** sdake has joined #openstack-nova | 03:23 | |
| *** sdake has quit IRC | 03:23 | |
| mriedem | gibi: bauzas: questions inline for the reshaper functional test https://review.openstack.org/#/c/631559/12 | 03:24 |
| mriedem | yonglihe: i can't see the full paste | 03:24 |
| mriedem | i mean the actual error response | 03:24 |
| mriedem | yonglihe: the %(uuid)s has to be in the response template, not the request | 03:25 |
| mriedem | for the request you have to actually pass the server group uuid | 03:25 |
| yonglihe | ohh, i got.. | 03:25 |
| *** takamatsu has quit IRC | 03:25 | |
| mriedem | in the response template you're saying, i don't care what the server group id is, just that it's present and it's a uuid | 03:26 |
| mriedem | in the request you need to actually pass, via subs, the server group id in the server create request | 03:26 |
| yonglihe | i did add to a wrong place.. | 03:27 |
| *** sdake has joined #openstack-nova | 03:27 | |
| yonglihe | ps, we do need own _test_servers_post to pass the sg_uuid in the request template. | 03:29 |
| *** itlinux has quit IRC | 03:29 | |
| mriedem | ok. i guess we could pass an extra_subs parameter to _post_server to deal with that but it's up to you | 03:31 |
| mriedem | anyway, i need to shut down for the day, i will look at your changes in the morning | 03:31 |
| *** dave-mccowan has quit IRC | 03:32 | |
| *** mriedem has quit IRC | 03:32 | |
| *** itlinux has joined #openstack-nova | 03:33 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 03:33 |
| yonglihe | get some rest, take care, thanks. | 03:34 |
| *** sdake has quit IRC | 03:40 | |
| *** wolverineav has joined #openstack-nova | 03:40 | |
| *** awalende has joined #openstack-nova | 03:43 | |
| *** tbachman has quit IRC | 03:44 | |
| *** wolverineav has quit IRC | 03:47 | |
| *** awalende has quit IRC | 03:47 | |
| *** markvoelker has joined #openstack-nova | 03:48 | |
| *** tbachman has joined #openstack-nova | 03:50 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 03:55 |
| *** wolverineav has joined #openstack-nova | 04:08 | |
| *** spsurya has joined #openstack-nova | 04:14 | |
| *** wolverineav has quit IRC | 04:17 | |
| *** markvoelker has quit IRC | 04:20 | |
| *** ileixe has quit IRC | 04:23 | |
| *** betherly has joined #openstack-nova | 04:26 | |
| *** betherly has quit IRC | 04:31 | |
| *** _fragatina has joined #openstack-nova | 04:54 | |
| *** ileixe has joined #openstack-nova | 05:00 | |
| *** takamatsu has joined #openstack-nova | 05:05 | |
| *** takamatsu has quit IRC | 05:10 | |
| *** zhubx has quit IRC | 05:13 | |
| *** zhubx has joined #openstack-nova | 05:13 | |
| *** wolverineav has joined #openstack-nova | 05:14 | |
| *** hongbin has quit IRC | 05:16 | |
| *** markvoelker has joined #openstack-nova | 05:17 | |
| *** wolverineav has quit IRC | 05:19 | |
| *** sridharg has joined #openstack-nova | 05:25 | |
| *** ShilpaSD has quit IRC | 05:27 | |
| *** ratailor has joined #openstack-nova | 05:28 | |
| *** itlinux has quit IRC | 05:28 | |
| *** sdake has joined #openstack-nova | 05:29 | |
| *** _fragatina has quit IRC | 05:41 | |
| *** brinzhang has joined #openstack-nova | 05:41 | |
| *** liuyulong_ has joined #openstack-nova | 05:45 | |
| *** markvoelker has quit IRC | 05:51 | |
| *** ileixe has quit IRC | 05:52 | |
| *** ileixe has joined #openstack-nova | 05:52 | |
| *** psachin has quit IRC | 05:58 | |
| *** psachin has joined #openstack-nova | 06:00 | |
| *** sdake has quit IRC | 06:02 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350 | 06:05 |
| openstackgerrit | melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | 06:05 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 06:05 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 06:05 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 06:05 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 06:05 |
| *** zhubx has quit IRC | 06:08 | |
| *** zhubx has joined #openstack-nova | 06:08 | |
| *** janki has joined #openstack-nova | 06:15 | |
| *** sdake has joined #openstack-nova | 06:22 | |
| *** moshele has joined #openstack-nova | 06:24 | |
| *** sdake has quit IRC | 06:26 | |
| *** ivve has joined #openstack-nova | 06:36 | |
| *** liuyulong_ has quit IRC | 06:38 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080 | 06:40 |
| *** sdake has joined #openstack-nova | 06:42 | |
| *** markvoelker has joined #openstack-nova | 06:48 | |
| *** Luzi has joined #openstack-nova | 06:50 | |
| *** mdbooth_ has joined #openstack-nova | 06:50 | |
| cfriesen | alex_xu: any chance you could take another look at https://review.openstack.org/#/c/620706/ ? | 06:52 |
| *** mdbooth has quit IRC | 06:53 | |
| openstackgerrit | Merged openstack/nova master: Use the correct mdev allocated from the pGPU https://review.openstack.org/636591 | 06:55 |
| alex_xu | cfriesen: I guess I didn't express myself again https://review.openstack.org/#/c/620706/24/nova/compute/api.py@624, I mean using get_best_cpu_toplogy instead of _get_cpu_topology_constraints, not rename the method | 06:57 |
| cfriesen | alex_xu: ah, I understand now. will take a look | 06:58 |
| *** _hemna has joined #openstack-nova | 07:00 | |
| *** tkajinam_ has joined #openstack-nova | 07:02 | |
| alex_xu | cfriesen: thanks | 07:04 |
| *** tkajinam has quit IRC | 07:05 | |
| *** _hemna has quit IRC | 07:05 | |
| *** dpawlik has joined #openstack-nova | 07:08 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 07:09 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Split up _is_storage_shared_with() in libvirt driver https://review.openstack.org/639933 | 07:09 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.openstack.org/639934 | 07:09 |
| cfriesen | alex_xu: we can't call get_best_cpu_topology() because the values for "allow_threads" and possibly "numa_topology" are not known | 07:15 |
| *** sdake has quit IRC | 07:15 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix an error when generating a host ID https://review.openstack.org/639936 | 07:17 |
| cfriesen | sean-k-mooney: https://review.openstack.org/#/c/639934 is now the top of three commits for emulated vTPM. | 07:18 |
| *** sdake has joined #openstack-nova | 07:18 | |
| *** sdake has quit IRC | 07:19 | |
| *** brinzhang has quit IRC | 07:20 | |
| *** markvoelker has quit IRC | 07:20 | |
| *** brinzhang has joined #openstack-nova | 07:21 | |
| alex_xu | cfriesen: we needn't pass those two parameter, we just want the check in the _get_possible_cpu_topologies | 07:21 |
| alex_xu | cfriesen: oh, vmware driver need allow_threads as False | 07:22 |
| alex_xu | sounds like we have to check the valid cpu topo in the last stage | 07:25 |
| cfriesen | alex_xu: I think the only real risk is that we might hit exception.ImageVCPULimitsRangeImpossible later on | 07:25 |
| alex_xu | cfriesen: yes, that is one I thought we can check in the beginning also | 07:26 |
| cfriesen | if we called it with the default allow_threads=True, it would at least tell us if it's even possible on a libvirt host. It might still fail on a vmware host | 07:28 |
| alex_xu | yes | 07:28 |
| cfriesen | it would mean doing extra work to enumerate and sort the possible topologies though | 07:28 |
| *** ircuser-1 has joined #openstack-nova | 07:29 | |
| cfriesen | if you think it's worth it I'm willing to change it | 07:29 |
| cfriesen | or maybe we could try for a follow-up patch to do it more efficiently | 07:30 |
| cfriesen | maybe a flag to bail out as soon as we find one possibility and avoid the sorting | 07:31 |
| alex_xu | cfriesen: that three level loop is terrible, and sounds like we have no limit on the max value | 07:31 |
| alex_xu | it is ok for flavor, since it is admin api | 07:33 |
| cfriesen | maybe merge this as-is and then work on figuring out an efficient way to check for exception.ImageVCPULimitsRangeImpossible ? | 07:33 |
| alex_xu | yes, it is ok. another thing is '_get_cpu_topology_constraints' is private method with '_' prefix | 07:34 |
| alex_xu | cfriesen: also for https://review.openstack.org/#/c/620706/24/nova/compute/api.py@626, I didn't mean get rid of validate_numa flag, I mean get rid of line 3572 "image['status'] = 'active'" | 07:38 |
| cfriesen | for _get_cpu_topology_constraints(), are you suggesting to remove the prefix? | 07:39 |
| alex_xu | yes, but it can be a followup refactor patch | 07:39 |
| cfriesen | if you look at the final version, you can see I did get rid of what was at 3572 by creating a new function _validate_flavor_image_nostatus() | 07:41 |
| cfriesen | and calling it from the resize code path | 07:41 |
| alex_xu | great, I will take a look at | 07:43 |
| cfriesen | gotta go to bed. goodnight. | 07:51 |
| *** ratailor has quit IRC | 07:51 | |
| *** ccamacho has joined #openstack-nova | 07:59 | |
| *** tesseract has joined #openstack-nova | 08:00 | |
| *** igordc has quit IRC | 08:00 | |
| *** zhubx has quit IRC | 08:07 | |
| *** zhubx has joined #openstack-nova | 08:08 | |
| *** awalende has joined #openstack-nova | 08:11 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 08:15 |
| *** markvoelker has joined #openstack-nova | 08:18 | |
| *** imacdonn_ has quit IRC | 08:18 | |
| *** imacdonn_ has joined #openstack-nova | 08:18 | |
| *** tssurya has joined #openstack-nova | 08:19 | |
| gibi | bauzas: i've started looking into mriedem's questions in the reshape functional test patch. Let me know if you are about to change something in that patch | 08:21 |
| bauzas | gibi: I first need to look at those | 08:21 |
| *** bhagyashris has joined #openstack-nova | 08:22 | |
| *** zhubx has quit IRC | 08:26 | |
| *** zhubx has joined #openstack-nova | 08:26 | |
| gibi | bauzas: If you are OK with that then I will go and fix mriedem's comments in there | 08:28 |
| *** takashin has left #openstack-nova | 08:30 | |
| gibi | bauzas: or shall I post the fix as a followup? | 08:31 |
| *** pcaruana has joined #openstack-nova | 08:32 | |
| bauzas | gibi: /me looking | 08:33 |
| bauzas | given I already updated your change, which is on top, I'm fine with you updating it | 08:33 |
| bauzas | no need for a FUP unless those are nits and we already have a +2 | 08:33 |
| gibi | bauzas: we already have +2 from efried | 08:34 |
| bauzas | oh my bad | 08:35 |
| bauzas | well, your choice | 08:35 |
| *** mvkr has joined #openstack-nova | 08:35 | |
| gibi | bauzas: OK | 08:35 |
| bauzas | I think we can certainly get efried approving it again | 08:35 |
| *** ralonsoh has joined #openstack-nova | 08:36 | |
| bauzas | gibi: ideally, we could also squash efried's patch into it | 08:36 |
| *** helenafm has joined #openstack-nova | 08:37 | |
| *** tkajinam_ has quit IRC | 08:38 | |
| gibi | bauzas: I would ask efried about before we squash | 08:38 |
| bauzas | yup, i agree | 08:38 |
| bauzas | or add him as co-author if you wanna be quick | 08:39 |
| *** tosky has joined #openstack-nova | 08:39 | |
| bauzas | gibi: I also need to write a new change, so I -W'd https://review.openstack.org/#/c/599208/18 | 08:40 |
| bauzas | I'm on it | 08:40 |
| bauzas | should be quick hopefully | 08:40 |
| gibi | bauzas: OK | 08:41 |
| *** ratailor has joined #openstack-nova | 08:42 | |
| *** markvoelker has quit IRC | 08:50 | |
| *** jaosorior has joined #openstack-nova | 09:06 | |
| *** ttsiouts has joined #openstack-nova | 09:11 | |
| *** elod has quit IRC | 09:12 | |
| *** sdake has joined #openstack-nova | 09:15 | |
| *** phasespace has joined #openstack-nova | 09:21 | |
| *** udesale has quit IRC | 09:28 | |
| *** udesale has joined #openstack-nova | 09:29 | |
| *** derekh has joined #openstack-nova | 09:35 | |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API https://review.openstack.org/612626 | 09:37 |
| *** bhagyashris has quit IRC | 09:42 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.openstack.org/537414 | 09:45 |
| *** sdake has quit IRC | 09:46 | |
| *** markvoelker has joined #openstack-nova | 09:47 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559 | 09:47 |
| *** rcernin has quit IRC | 09:48 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Modify PciDevice.uuid generation code https://review.openstack.org/530487 | 09:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add an online migration for PciDevice.uuid https://review.openstack.org/530905 | 09:48 |
| stephenfin | gibi, bauzas: Fancy putting this through? https://review.openstack.org/#/c/608407/ | 09:49 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: FUP: docs nit https://review.openstack.org/639647 | 09:49 |
| *** dtantsur|afk is now known as dtantsur | 09:49 | |
| gibi | stephenfin: looking | 09:49 |
| gibi | stephenfin: done | 09:51 |
| stephenfin | \o/ ta | 09:51 |
| *** panda|ruck|off is now known as panda|ruck | 09:51 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Summarize output of sample configuration generator https://review.openstack.org/625014 | 09:51 |
| bauzas | hah, got one hour meeting from some tax credit https://www.impots.gouv.fr/portail/international-professionnel/tax-incentives | 09:52 |
| bauzas | folks, in case you wanna relocate in France, consider it twice before moving | 09:52 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test proper allocation of devices during reshape https://review.openstack.org/639854 | 09:53 |
| stephenfin | lyarwood: Fancy taking a look at this today? https://review.openstack.org/#/c/626369/ | 09:53 |
| gibi | bauzas: if you have any idea about https://review.openstack.org/#/c/631559/13/nova/tests/unit/virt/libvirt/fakelibvirt.py@1548 then tell me. The current test works if I return nothing but I shoudl return some nvidia-11 mdev_type there | 09:54 |
| bauzas | gibi: looking | 09:55 |
| bauzas | hah | 09:56 |
| bauzas | gibi: it's because of https://github.com/openstack/nova/blob/master/nova/virt/libvirt/host.py#L893 | 09:56 |
| lyarwood | stephenfin: sure | 09:56 |
| bauzas | gibi: sec, giving you the right XML that I used for my UTs | 10:00 |
| bauzas | gibi: try this one https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_driver.py#L298-L322 | 10:02 |
| bauzas | gibi: AFAIR, the libvirt docs is probably badly writtent | 10:02 |
| bauzas | written* | 10:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Summarize output of sample configuration generator https://review.openstack.org/625014 | 10:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove 'disable_libvirt_livesnapshot' option https://review.openstack.org/626932 | 10:06 |
| *** elod has joined #openstack-nova | 10:10 | |
| gibi | bauzas: thanks. let me try | 10:10 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Update docs, API samples for noVNC 1.0.0 https://review.openstack.org/550173 | 10:12 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 10:13 |
| stephenfin | lyarwood: Looks like Ubuntu 19.04 will finally switch to noVNC 1.0, but that leaves this patch in limbo til 20.04 is out at least. I wonder if I should just abandon it or insert a TODO instead? https://review.openstack.org/#/c/550173/ | 10:14 |
| stephenfin | (Ubuntu 19.04 assertion made based on https://packages.ubuntu.com/search?keywords=novnc) | 10:14 |
| lyarwood | stephenfin: I've already bumped the package in Fedora 28 FWIW | 10:15 |
| * lyarwood clicks | 10:15 | |
| openstackgerrit | garyk proposed openstack/nova master: Better handle live migration abort https://review.openstack.org/635440 | 10:16 |
| lyarwood | stephenfin: so with the fedora package at least both URLs should still work | 10:16 |
| stephenfin | lyarwood: Oh, really? Symlink? | 10:17 |
| lyarwood | stephenfin: I'd abandon and return to this with 20.04 | 10:17 |
| lyarwood | stephenfin: yeah | 10:17 |
| lyarwood | stephenfin: https://src.fedoraproject.org/rpms/novnc/blob/master/f/novnc.spec#_36 | 10:18 |
| stephenfin | Nice. I'll abandon that for now so. Trying to clean up my list of open patches (there are a few) | 10:18 |
| openstackgerrit | garyk proposed openstack/nova master: Better handle live migration abort https://review.openstack.org/635440 | 10:20 |
| gibi | bauzas: still seeing some strange behavior, I will push a separate patch up so you can also look at it in parallel | 10:21 |
| bauzas | gibi: okay | 10:21 |
| bauzas | gibi: thanks for helping out | 10:21 |
| *** markvoelker has quit IRC | 10:21 | |
| stephenfin | bauzas, gibi: Actually, input time. I've done two different things in similar scenarios https://review.openstack.org/#/c/626932/ https://review.openstack.org/#/c/608407/ | 10:22 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: handle mdev_type device in fakelibvirt https://review.openstack.org/639974 | 10:22 |
| gibi | bauzas: ^^ | 10:22 |
| stephenfin | bauzas, gibi: Both refer to config options that workaround bugs in older libvirt versions that we no longer support. In the former, I just dropped it. In the latter, I did the full deprecation cycle. Thoughts on which is preferable? | 10:23 |
| bauzas | stephenfin: I'm in favor of being gentle with our ops | 10:23 |
| *** udesale has quit IRC | 10:24 | |
| *** udesale has joined #openstack-nova | 10:24 | |
| bauzas | stephenfin: what's the libvirt min version we support ? | 10:25 |
| bauzas | kashyap: ^? | 10:25 |
| gibi | stephenfin: the config driver format config still works even if it is not needed to set to vfat | 10:25 |
| stephenfin | bauzas: 3.0 | 10:25 |
| gibi | stephenfin: so there keeping the config is meaningful | 10:25 |
| gibi | stephenfin: would disable_libvirt_livesnapshot still disable the snapshot in Stein if we keep it? | 10:26 |
| gibi | if yes, then I would just deprecate that config too | 10:26 |
| stephenfin | gibi: Yeah, it would. I'll deprecate that instead so | 10:26 |
| bauzas | stephenfin: the problem is that we provided a flag which, even if tied to a specific version, allows a specific behaviour | 10:26 |
| bauzas | stephenfin: so people can use it even if they have newer libvirt | 10:27 |
| * gibi goes to fetch something edible | 10:27 | |
| *** sdake has joined #openstack-nova | 10:35 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'disable_libvirt_livesnapshot' option https://review.openstack.org/626932 | 10:37 |
| stephenfin | bauzas, gibi: Updated to deprecate instead of remove outright, if you fancy hitting that too ^ | 10:37 |
| * stephenfin -> reviews | 10:38 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 10:39 |
| *** sridharg has quit IRC | 10:39 | |
| *** wolverineav has joined #openstack-nova | 10:42 | |
| kashyap | bauzas: Hi | 10:42 |
| kashyap | bauzas: Was briefly AFK; it's documented in the driver.py :-) | 10:42 |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 10:42 |
| *** ccamacho has quit IRC | 10:43 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Dedupe controller install guides https://review.openstack.org/638715 | 10:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Dedupe compute install guides https://review.openstack.org/638716 | 10:43 |
| kashyap | bauzas: Currently these: | 10:43 |
| kashyap | MIN_LIBVIRT_VERSION = (3, 0, 0) | 10:43 |
| kashyap | MIN_QEMU_VERSION = (2, 8, 0) | 10:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Call out where pci.alias should be set https://review.openstack.org/624445 | 10:44 |
| *** wolverineav has quit IRC | 10:46 | |
| *** ccamacho has joined #openstack-nova | 10:49 | |
| *** dpawlik has quit IRC | 11:00 | |
| *** cdent has joined #openstack-nova | 11:00 | |
| *** agopi has quit IRC | 11:06 | |
| *** erlon has joined #openstack-nova | 11:08 | |
| *** ttsiouts has quit IRC | 11:10 | |
| *** ttsiouts has joined #openstack-nova | 11:10 | |
| *** mikal has quit IRC | 11:15 | |
| *** ttsiouts has quit IRC | 11:15 | |
| *** markvoelker has joined #openstack-nova | 11:18 | |
| *** ileixe has quit IRC | 11:18 | |
| *** sdake has quit IRC | 11:18 | |
| *** sdake has joined #openstack-nova | 11:19 | |
| *** Dinesh_Bhor has quit IRC | 11:23 | |
| *** brinzh has joined #openstack-nova | 11:28 | |
| *** brinzhang has quit IRC | 11:29 | |
| *** brinzhang has joined #openstack-nova | 11:31 | |
| *** brinzh has quit IRC | 11:33 | |
| *** tbachman has quit IRC | 11:41 | |
| *** mkarpiarz has joined #openstack-nova | 11:44 | |
| mkarpiarz | Hi. Can someone please take a look at https://bugs.launchpad.net/nova/+bug/1780225/comments/3? | 11:46 |
| openstack | Launchpad bug 1780225 in OpenStack Compute (nova) "Libvirt error when using --max > 1 with vGPU" [High,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza) | 11:46 |
| *** _fragatina has joined #openstack-nova | 11:46 | |
| mkarpiarz | I can see 2 ways of fixing this | 11:46 |
| mkarpiarz | 1. Store the list of available mediated devices in some global structure. | 11:48 |
| mkarpiarz | 2. Let the instance fail in launch and return back to spawn(), so it can check available devices again. | 11:49 |
| *** markvoelker has quit IRC | 11:50 | |
| mkarpiarz | Any other ideas? | 11:51 |
| *** dpawlik has joined #openstack-nova | 11:52 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP context: Ensure templated connection URLs are rendered before use https://review.openstack.org/639607 | 11:54 |
| *** sdake has quit IRC | 11:55 | |
| *** ttsiouts has joined #openstack-nova | 12:09 | |
| openstackgerrit | Merged openstack/nova master: conf: Deprecated 'config_drive_format' https://review.openstack.org/608407 | 12:12 |
| *** brinzhang has quit IRC | 12:13 | |
| *** _pewp_ has quit IRC | 12:16 | |
| *** _pewp_ has joined #openstack-nova | 12:16 | |
| *** hemna has quit IRC | 12:17 | |
| *** hemna has joined #openstack-nova | 12:19 | |
| *** ratailor has quit IRC | 12:28 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: CONF.enable_numa_live_migration is not needed >= Stein https://review.openstack.org/640021 | 12:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653 | 12:35 |
| gibi | efried: fixed nits and replied about the retry in ^^ | 12:36 |
| *** ccamacho has quit IRC | 12:38 | |
| *** sridharg has joined #openstack-nova | 12:41 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Add free for claimed, allocated devices https://review.openstack.org/616120 | 12:43 |
| openstackgerrit | sean mooney proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365 | 12:43 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929 | 12:43 |
| openstackgerrit | sean mooney proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | 12:43 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | 12:43 |
| sean-k-mooney | resolved minor merge conflict and rebased to master otherwise no other changes in that series | 12:43 |
| *** panda|ruck is now known as panda|ruck|lunch | 12:44 | |
| *** tacco has joined #openstack-nova | 12:46 | |
| *** markvoelker has joined #openstack-nova | 12:47 | |
| tacco | hi there.. i have a issue with a redeployed hypervisor.. after deployment i see a "ResourceProviderCreationFailed: Failed to create resource provider" error when trying to start nova or migrating a instance to this hypervisor https://pastebin.com/zMHUUYEW | 12:47 |
| yaawang | hi, could anyone please take a review on https://review.openstack.org/#/c/637834/, this a patch about libvirt cpu models select :-) | 12:55 |
| *** erlon has quit IRC | 12:58 | |
| *** ccamacho has joined #openstack-nova | 13:06 | |
| *** dave-mccowan has joined #openstack-nova | 13:10 | |
| *** mchlumsky has joined #openstack-nova | 13:13 | |
| *** erlon has joined #openstack-nova | 13:15 | |
| *** tbachman has joined #openstack-nova | 13:17 | |
| *** rtjure has joined #openstack-nova | 13:17 | |
| *** markvoelker has quit IRC | 13:20 | |
| *** zhubx has quit IRC | 13:23 | |
| *** zhubx has joined #openstack-nova | 13:23 | |
| *** lchabert has quit IRC | 13:29 | |
| *** gbarros has joined #openstack-nova | 13:29 | |
| *** panda|ruck|lunch is now known as panda|ruck | 13:30 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP context: Ensure templated connection URLs are rendered before use https://review.openstack.org/639607 | 13:31 |
| artom | sean-k-mooney, wait, we can have nested virt in nodepool now? mnaser, is vexxhost doing that now? | 13:33 |
| mnaser | artom: we’re doing it but | 13:33 |
| sean-k-mooney | artom: technically. the ci jobs will still try to disable it but we can renable it | 13:33 |
| mnaser | I’m trying not to broadcast it too much | 13:33 |
| artom | mnaser, oops, sorry :) | 13:34 |
| mnaser | I want the jobs that use it are jobs that need to use it, not.. just do it can be faster | 13:34 |
| mnaser | So Magnum is a case where it was useful and that’s why we added it | 13:34 |
| artom | mnaser, well, NUMA live migration *needs* to use it :) | 13:34 |
| sean-k-mooney | mnaser: i brought it up in the context of testing nuam aware live migration | 13:34 |
| mnaser | Yeah then I’d be supportive of it | 13:34 |
| artom | mnaser, sweet! | 13:35 |
| sean-k-mooney | artom: as i said it would have to be non voting however | 13:35 |
| yonglihe | mriedem: alex_xu: https://review.openstack.org/621474 updated per all comments. I have to have rest. have a good one everyone. | 13:35 |
| artom | sean-k-mooney, yeah that's fine, we have to start somewhere | 13:35 |
| artom | Even just being able to trigger a job manually that posts publicly would be a great first step | 13:35 |
| sean-k-mooney | artom: if ovh/packet reenable it in the future we might be able to make it voting eventually | 13:36 |
| *** imacdonn_ has quit IRC | 13:36 | |
| artom | sean-k-mooney, baby steps :) | 13:36 |
| sean-k-mooney | artom: well you could start by adding it to the experimental pipeline | 13:36 |
| sean-k-mooney | that requires a comment ot trigger it | 13:36 |
| artom | sean-k-mooney, wouldn't I have to start by moving whitebox to the openstack namespace? | 13:36 |
| sean-k-mooney | yes | 13:37 |
| sean-k-mooney | i ment after that | 13:37 |
| sean-k-mooney | and you know after we write all the tests | 13:37 |
| artom | Hey, I have some written already :) | 13:37 |
| sean-k-mooney | did you look at the list i gave in the email | 13:38 |
| artom | Yeah | 13:38 |
| sean-k-mooney | feel free to automate those while i test them | 13:38 |
| artom | sean-k-mooney, that'll kinda depend on whether the absence of func tests is a blocker for mriedem | 13:38 |
| artom | If it is, those take priority before FF | 13:39 |
| sean-k-mooney | yep | 13:39 |
| artom | Other than that timing issue, I'll happily hax those up | 13:39 |
| *** gbarros has quit IRC | 13:39 | |
| *** moshele has quit IRC | 13:40 | |
| sean-k-mooney | artom: once you get the first functional test working i suspect the rest will be fairly staight forward | 13:43 |
| sean-k-mooney | if you can add the functional test as a follow up that will reduce churn and make my testing eaisier | 13:44 |
| *** gbarros has joined #openstack-nova | 13:44 | |
| artom | sean-k-mooney, yep, good idea. I can start with the tests in a new patch on top, and we can squash later | 13:44 |
| sean-k-mooney | yep or even just keep it on top | 13:45 |
| sean-k-mooney | squashing them to keep them with the feature code is nice but i dont think its required | 13:45 |
| *** gbarros has quit IRC | 13:46 | |
| *** dpawlik has quit IRC | 13:51 | |
| *** _pewp_ has quit IRC | 13:53 | |
| *** lchabert has joined #openstack-nova | 13:53 | |
| *** _pewp_ has joined #openstack-nova | 13:53 | |
| *** lbragstad has joined #openstack-nova | 13:54 | |
| *** awaugama has joined #openstack-nova | 13:58 | |
| sean-k-mooney | mnaser: by they way do you use kvm on ubuntu 18.04 for vexhost? | 14:00 |
| mnaser | sean-k-mooney: centos 7 | 14:00 |
| sean-k-mooney | ah ok | 14:00 |
| mnaser | but we've managed to get the perfect combo for functional nested virt | 14:00 |
| mnaser | thanks a lot to the kata containers folks | 14:00 |
| sean-k-mooney | there is a bug in the ubunut 18.04 kernel that breaks nested virt | 14:00 |
| sean-k-mooney | i had to replace mine with the mainline 4.20 kernel to fix issues | 14:01 |
| mnaser | yeah our ci is worked out pretty often both by magnum and kata and their nested virt has been super stable | 14:01 |
| *** jmlowe has quit IRC | 14:01 | |
| *** itlinux has joined #openstack-nova | 14:01 | |
| *** betherly has joined #openstack-nova | 14:02 | |
| sean-k-mooney | ya i went with ubuntu 18.04 because kolla-ansibel source deploys work better on ubuntu then centos in my previos experience | 14:02 |
| sean-k-mooney | mnaser: do ye use openstack ansible for your production installation | 14:03 |
| mnaser | sean-k-mooney: yeah | 14:03 |
| *** moshele has joined #openstack-nova | 14:03 | |
| sean-k-mooney | i must get around to checking that out at some point but since its working im not going to touch it untill i need to upgrade :) | 14:03 |
| *** mmethot has joined #openstack-nova | 14:06 | |
| *** mdbooth_ is now known as mdbooth | 14:08 | |
| *** itlinux has quit IRC | 14:08 | |
| mdbooth | bauzas: Do you recall why rebuild is forced to be on the same host? Is it just because the way rebuild is written doesn't allow for a migration, or is it fundamental to the intent of rebuild? Or some other reason? | 14:10 |
| *** jistr is now known as jistr|call | 14:11 | |
| sean-k-mooney | mdbooth: why would a rebuild ever need to migrate if the image does not change | 14:12 |
| sean-k-mooney | if the image does change we hit the schulder | 14:12 |
| mdbooth | bauzas: I ask because I was looking at the attach/detach root volume patches. They look fine, but shelve/unshelve is just distasteful, so having it as the only available option seems undesirable. Reading the original spec, it sounds to me like they want to rebuild on a different host... | 14:12 |
| mdbooth | Which is an evacuate# | 14:12 |
| mdbooth | Evacuate with a different root volume. | 14:12 |
| mdbooth | Hmm | 14:12 |
| mnaser | sean-k-mooney: be happy to help you get setup on OSA | 14:13 |
| mdbooth | sean-k-mooney: Yes, we hit the scheduler but constrain it to return the original host or return NoValidHost | 14:13 |
| *** awaugama has quit IRC | 14:13 | |
| *** mriedem has joined #openstack-nova | 14:13 | |
| mdbooth | Rebuild on a different host with a different root volume... | 14:14 |
| sean-k-mooney | mnaser: its more just i have not taken the time to try it out. i learn how kolla ansible worked a few years ago and it served well enough for my personal needs | 14:14 |
| sean-k-mooney | mdbooth: ah ok | 14:14 |
| *** dpawlik has joined #openstack-nova | 14:14 | |
| bauzas | mdbooth: because it doesn't ask for other resources, just for an image | 14:14 |
| bauzas | unless you evacuate :) | 14:14 |
| mdbooth | bauzas: Given that evacuate exists, I'm guessing most of this is already wired up. | 14:15 |
| bauzas | yeah, that's actually the change in between evacuate and rebuild | 14:15 |
| mdbooth | In fact: cold migrate with a different root volume. | 14:16 |
| bauzas | evacuate is just the same rebuild path but with a different API action :) | 14:16 |
| bauzas | hum no | 14:16 |
| bauzas | cold migrate != evacuate | 14:16 |
| bauzas | evacuate == rebuild(different_host) | 14:16 |
| mdbooth | bauzas: Hmm, no. It doesn't consider a change of image. | 14:16 |
| mdbooth | But I was thinking that you might have a root volume and ephemeral disks, in which case you might want to migrate them. | 14:17 |
| *** jmlowe has joined #openstack-nova | 14:17 | |
| *** jmlowe has quit IRC | 14:17 | |
| *** markvoelker has joined #openstack-nova | 14:18 | |
| *** wolverineav has joined #openstack-nova | 14:18 | |
| mdbooth | bauzas: So, going back to the original question, why do we go to lengths to ensure that rebuild doesn't change host? | 14:19 |
| bauzas | mdbooth: I'm not the rebuild specialist | 14:20 |
| *** phasespace has quit IRC | 14:20 | |
| bauzas | some others hitted so many times issues with rebuild that they're more knowledgable than me, like... mriedem ? :) | 14:20 |
| mdbooth | bauzas: Ah, sorry. I pinged you because you were co-author in a patch which added this constraint. | 14:20 |
| mdbooth | mriedem was the other author. | 14:20 |
| bauzas | knowledgable * (not sure it's a word) | 14:20 |
| mdbooth | bauzas: Yeah, it's a word. Pretty sure that's not how you spell it, but I wouldn't have called you on it as I'm not 100% sure myself ;) | 14:21 |
| *** wolverineav has quit IRC | 14:22 | |
| mriedem | what is the question? | 14:23 |
| mriedem | why doesn't rebuild migrate? | 14:23 |
| mriedem | why do we validate the image against the scheduler when it changes? | 14:23 |
| mriedem | because build is on the same host | 14:23 |
| mriedem | why? because that's the way it originated | 14:23 |
| mdbooth | mriedem: Yeah. Specifically why does it go to length to prevent a change of host even when calling the scheduler? | 14:23 |
| mdbooth | mriedem: Right, that was my first guess. | 14:23 |
| mriedem | then over the years it turned out it was buggy and to maintain the api contract but resolve those bugs we had to build stuff into it | 14:24 |
| mdbooth | So there's no fundamental reason that it shouldn't, it's just that the control flow doesn't support it. | 14:24 |
| mriedem | i wasn't around when rebuild was added | 14:24 |
| sean-k-mooney | mdbooth: it calls the schudler to validate the current host is still valide as changeing the image means the image metadata could invaldate the current host | 14:24 |
| mriedem | fwiw, | 14:24 |
| mriedem | it's also got a latent bug where the image can change numa topology which does not send new numa topology limits to the compute service to do a resource claim | 14:25 |
| sean-k-mooney | mdbooth: you can rebuild instance with sriov | 14:25 |
| mriedem | because rebuild doesn't do any resource claim, because it was assumed that the flavor never changed (because it doesn't in the api) and the scheduler wouldn't be used | 14:25 |
| sean-k-mooney | actully it cold migration ignore that | 14:25 |
| mriedem | so over time we added more features to nova (numa support) which broke existing flows | 14:25 |
| mdbooth | mriedem: Going up a level, I was just considering the shelve/unshelve approach for attach/detach root volume. While that's obviously great if it allows the user to do something which is currently impossible, it still requires shelve/unshelve. I was considering if it could also be added to some other less nasty operation. | 14:25 |
| mriedem | what is nasty about shelve/unshelve? | 14:26 |
| mriedem | i don't see how that's any nastier than trying to make rebuild trigger a migration | 14:26 |
| mriedem | lots of people actually want the stop operation to be a shelve | 14:26 |
| mdbooth | I specifically don't like the way shelve/unshelve abuses the image cache. | 14:26 |
| mdbooth | Probably fixing that would be simpler, I guess. | 14:27 |
| sean-k-mooney | thats specifcally for non bvf instances right. bfv instnace should not mess with the image cache | 14:28 |
| mdbooth | However, if all the user is trying to do is DR an instance (from the spec), going via glance isn't the most efficient solution. | 14:28 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Fix typo in vmware get_info docstring https://review.openstack.org/640042 | 14:29 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Remove TypeError handling for get_info https://review.openstack.org/640043 | 14:29 |
| *** jmlowe has joined #openstack-nova | 14:29 | |
| mdbooth | That's a point... in the DR case you'd presumably be evacuating anyway, so you still couldn't evacuate with a different root volume. | 14:29 |
| sean-k-mooney | mdbooth: that depend some of the usescase in the spec impliend at least to me that the remote fail over sigt may not have direct conectivity at the hyperviosr level. e.g. a migrtion to the second sight may now actully work | 14:30 |
| sean-k-mooney | *sigt -> site sight->site | 14:31 |
| mdbooth | Shelve/unshelve is *extremely* space inefficient. You're basically storing a flattened snapshot at the point of shelve in the image cache forever. | 14:32 |
| mdbooth | But not for BFV, I guess. | 14:32 |
| sean-k-mooney | mdbooth: doesnt ath depend on your glance backend | 14:32 |
| mdbooth | sean-k-mooney: No. It might depend on Nova's imagebackend, though. | 14:33 |
| sean-k-mooney | ah right. i was thinking it might be effienet on ceph backed glance but may ceph imagebackend would help | 14:34 |
| sean-k-mooney | e.g. for non bfv instnaces | 14:34 |
| mdbooth | I don't think we're at all clever about shelve of ceph instance to ceph glance. | 14:35 |
| mdbooth | And ceph glance to ceph instance is efficient but problematic. | 14:35 |
| efried | gibi, bauzas: Sorry, I meant to mention it in the change set - feel free to squash. | 14:38 |
| *** awaugama has joined #openstack-nova | 14:41 | |
| bauzas | efried: thanks | 14:41 |
| *** markvoelker has quit IRC | 14:50 | |
| artom | mriedem, hey, just to get a feel for what I should concentrate on next, is the absence of func tests for NUMA live migration a blocker? If so, I'll start on that now, otherwise, I'll advance integration testing - and can add func tests after FF? | 14:55 |
| artom | (Assuming it merges, that is - but that's just my carebear optimism ;) | 14:56 |
| *** mlavalle has joined #openstack-nova | 14:56 | |
| mriedem | artom: did you see my comments about the compute service version check in the conductor task? | 14:56 |
| artom | mriedem, did, and addressed in a new patch on top | 14:56 |
| artom | (Figured it's legit to split them for easier reviewing) | 14:57 |
| mriedem | artom: ok i didn't know how your integration testing could have even been working with that code the way it was, unless you were enabling that workaround | 14:57 |
| artom | mriedem, that's... actually a good question | 14:57 |
| artom | Because I sure as hell didn't set enable_numa_live_migration, and its default is False, right? | 14:58 |
| mriedem | correct | 14:58 |
| artom | And yet my integration tests *do* work, because they caught a logic flaw and failed when the pinning of 2 instances ended up overlapping | 14:58 |
| mriedem | were you testing with that patch reverted? | 14:59 |
| sean-k-mooney | there is a bug | 14:59 |
| artom | mriedem, nope :/ | 14:59 |
| sean-k-mooney | in the numa migration config code | 14:59 |
| sean-k-mooney | https://review.openstack.org/#/c/635350 | 14:59 |
| mriedem | you mean this if hypervisor_type != obj_fields.HVType.KVM: | 14:59 |
| sean-k-mooney | mriedem: artom cfriesen found and fixed it | 14:59 |
| sean-k-mooney | yep it will be QEMU not kvm | 15:00 |
| mriedem | right so the blocker config doesn't actually do anything | 15:00 |
| sean-k-mooney | right | 15:00 |
| artom | I swear I see stuff like that and I can't help but think "we're all just morons" | 15:00 |
| artom | Nothing against anyone, and I'm including myself in that group | 15:00 |
| tacco | hi there.. i have a issue with a redeployed hypervisor.. after deployment i see a "ResourceProviderCreationFailed: Failed to create resource provider" error when trying to start nova or migrating a instance to this hypervisor https://pastebin.com/zMHUUYEW | 15:01 |
| artom | At least we found and fixed it before release :) | 15:01 |
| tacco | any idea? | 15:01 |
| sean-k-mooney | its not merged yet. imgoing to recheck the patch. that said if we merger your code this is not needed | 15:01 |
| artom | sean-k-mooney, still needed for anything but full Stein deployments | 15:01 |
| artom | See https://review.openstack.org/#/c/640021/ :) | 15:02 |
| sean-k-mooney | ya that is ture | 15:02 |
| mriedem | artom: it's already been backported to stable/rocky | 15:02 |
| artom | mriedem, the CONF workaround? *sigh* | 15:02 |
| sean-k-mooney | ya so we will have to backport the fix too but sice its currently a noop it wont break anything | 15:03 |
| *** awalende has quit IRC | 15:04 | |
| sean-k-mooney | its annoying but thats all | 15:04 |
| *** awalende has joined #openstack-nova | 15:04 | |
| mriedem | artom: yes https://review.openstack.org/#/q/I217fba9138132b107e9d62895d699d238392e761 | 15:05 |
| mriedem | me thinks we should probably start an rc-potential etherpad... | 15:05 |
| sean-k-mooney | cfriesen: do you have time to repsin that by the way? if not ill add https://review.openstack.org/#/c/635350 to my list and ill file a bug | 15:05 |
| mriedem | because there is just too much crap flying around for me to keep in my brain | 15:05 |
| artom | mriedem, you mean rc blocker? | 15:06 |
| * mdbooth found 2 typos in a comment: -2 please abandon | 15:07 | |
| mriedem | https://etherpad.openstack.org/p/nova-stein-rc-potential | 15:08 |
| mriedem | melwitt: ^ | 15:08 |
| sean-k-mooney | artom: not so much blocker but might warrent a second rc or shoudl be merged after ff as part of an rc | 15:08 |
| artom | mriedem, so, sorry to pester, but the func tests blocker thing wasn't resolved | 15:09 |
| *** awalende has quit IRC | 15:09 | |
| mriedem | you want closure from me in other words? | 15:09 |
| artom | mriedem, heh, yeah. A sense of priorities, o wise leader :) | 15:10 |
| mriedem | well i personally think it's pretty risky to land something as complicated as live migration with numa without some functional tests, but at the same time, i guess if it turns out to have bugs then they just get fixed and we trust your integration testing downstream | 15:12 |
| cfriesen | sean-k-mooney: will respin | 15:12 |
| *** ivve has quit IRC | 15:13 | |
| mriedem | in general i loathe landing anything related to pci/numa/sriov when we have no 3rd party integration testing for it | 15:13 |
| cfriesen | we'll be doing integration testing for live migration too | 15:13 |
| dansmith | mriedem: I too think it's fairly risky | 15:13 |
| sean-k-mooney | cfriesen: ok it just need a bug added. | 15:13 |
| sean-k-mooney | cfriesen: so it can be backported | 15:13 |
| dansmith | I haven't really had time to go back through it from a holistic "how do these pieces fit together" sort of view | 15:14 |
| artom | mriedem, I know :/ Which is why I want to replace the Intel CI with something that's actually maintained | 15:14 |
| cfriesen | dansmith: mriedem: totally risky. but is it likely to break anything other than things that are already broken? | 15:14 |
| dansmith | breaking live migration at all is a really bad thing to do | 15:14 |
| dansmith | cfriesen: yes? | 15:14 |
| artom | dansmith, basic live migration is tested in the gate though, right? | 15:15 |
| mriedem | yes, | 15:15 |
| dansmith | artom: during several partial upgrade situations? | 15:15 |
| mriedem | so if worst case scenario you break live migration with numa instances, well, those were already broken anyway - and if you're using that config (once fixed) you can't even initiate it | 15:15 |
| artom | No :( | 15:15 |
| mriedem | dansmith: yes | 15:15 |
| artom | Yes? | 15:15 |
| mriedem | the live migration + grenade job | 15:15 |
| dansmith | mriedem: we have one right? | 15:15 |
| artom | \o/ | 15:15 |
| mriedem | runs n-1 live migration back and forth | 15:15 |
| mriedem | it's non-voting | 15:15 |
| artom | We should *really* check its output on the NUMA LM patches then | 15:16 |
| dansmith | mriedem: but not on systems that will report this stuff, even for non-numa flavors I think | 15:16 |
| mriedem | https://review.openstack.org/#/c/637231/ | 15:16 |
| mriedem | dansmith: correct we don't do any numa stuff in the gate | 15:16 |
| sean-k-mooney | artom: i would start on the functional tests and we can add the whitebox tempest test after ff | 15:17 |
| dansmith | it's not just numa-having instances, | 15:17 |
| dansmith | it's that everyone's systems report numa stuff, and if any of this works on a numaless guest instance for CI but is weird on a real system... we won't have coverage of that | 15:17 |
| mriedem | mrhillsman: would it be possible to use openlab for numa testing for nova? | 15:17 |
| sean-k-mooney | artom: wether they are a blocker on not is seperate form if we should write them an i think we would all like to see functional tests for this eventually | 15:17 |
| artom | sean-k-mooney, oh yeah, they'll be there | 15:18 |
| dansmith | also, some amount of live migration of numa-having instances works today but just doesn't claim or do the right thing, right? | 15:19 |
| artom | I'm wondering more "what gives others better confidence in the code to help it merge, automated integration tests that you have to run manually in your own env, or func tests?" | 15:19 |
| dansmith | if we were to break that in a way that doesn't let people move their instances in an emergency, even if the numaness gets messed up, that's still a big problem I think | 15:19 |
| mrhillsman | mriedem yes sir | 15:19 |
| sean-k-mooney | dansmith: if the cpus are free on the destination then today everything works for pinned instance | 15:20 |
| sean-k-mooney | similarly for hugepage instnace | 15:20 |
| dansmith | right | 15:20 |
| sean-k-mooney | the clamims get updated too i think | 15:21 |
| dansmith | so if we break that in this because we didn't test it on real systems... that's not "the situation can't get worse" to me | 15:21 |
| sean-k-mooney | they are either healed by the periodic task or done explicitly i cant remember | 15:21 |
| *** itlinux has joined #openstack-nova | 15:21 | |
| mrhillsman | so long as we can provide what is needed. filling out https://github.com/theopenlab/openlab/issues/new?template=test-request.md with what is needed is required | 15:22 |
| artom | sean-k-mooney, periodic task | 15:22 |
| *** amorin has joined #openstack-nova | 15:23 | |
| mriedem | mrhillsman: ah cool ok, i'll put this in our ptg agenda for discussion to see what minimum levels of testing we'd hope to get | 15:24 |
| sean-k-mooney | mrhillsman: do numa testing we would need either nested virt on a host with at least 2 numa nodes or a dual numa beremetal host | 15:24 |
| mriedem | mrhillsman: btw, who writes the tests? or is tempest used? | 15:24 |
| cfriesen | sean-k-mooney: mriedem: hypervisor check bug is https://bugs.launchpad.net/nova/+bug/1818092 | 15:24 |
| openstack | Launchpad bug 1818092 in OpenStack Compute (nova) "hypervisor check in _check_instance_has_no_numa() is broken" [Undecided,New] | 15:24 |
| sean-k-mooney | cfriesen: cool can you add "Close-Bug: 1818092" to the commit in your patch | 15:25 |
| cfriesen | yup, doing it now | 15:25 |
| sean-k-mooney | awsome | 15:25 |
| mrhillsman | mriedem you or some volunteers would | 15:25 |
| * artom volunteers | 15:26 | |
| sean-k-mooney | mriedem: we hope to move the redhat whitebox tempest plugin to openstack namespace | 15:26 |
| artom | Unless it's like, in Perl or JS or something. | 15:26 |
| mrhillsman | there is a lot of flexibility in how that works | 15:26 |
| *** Luzi has quit IRC | 15:27 | |
| mrhillsman | i think adding to the ptg is good if it is not a priority right now | 15:27 |
| mriedem | yup done L77 https://etherpad.openstack.org/p/nova-ptg-train | 15:27 |
| mrhillsman | cool, i will be sure to be there | 15:28 |
| mriedem | maybe chenrui's team can help a bit, i.e. Kevin_Zheng since he is familiar with nova | 15:28 |
| mrhillsman | ++ | 15:28 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: fix up numa-topology live migration hypervisor check https://review.openstack.org/635350 | 15:30 |
| *** moshele has quit IRC | 15:30 | |
| cfriesen | sean-k-mooney: mriedem: there you go ^ | 15:31 |
| *** awalende has joined #openstack-nova | 15:32 | |
| mriedem | stephenfin: i saw your patch to deprecate config_drive_format for vfat | 15:34 |
| mriedem | stephenfin: and it reminded me of this https://review.openstack.org/#/c/567860/ | 15:34 |
| cfriesen | anyone know why requirements-check is failing for https://review.openstack.org/#/c/631363 ? It says "Package 'os-traits' is constrained to 0.4.0 which does not match the minimum version specifier 0.11.0 in requirements.txt" | 15:35 |
| mriedem | stephenfin: i'm not 100% but i don't think we actually test live migration in the gate with a config drive on the instance | 15:35 |
| bauzas | mriedem: yeah we agreed on following the deprecation path this morning | 15:35 |
| mriedem | stephenfin: it would be good to have that wrinkle somewhere | 15:35 |
| mriedem | bauzas: sure i understand, but that's not my point | 15:35 |
| bauzas | ok | 15:35 |
| mriedem | my point is we don't test live migration + config drive | 15:35 |
| openstackgerrit | Merged openstack/nova master: conf: Call out where pci.alias should be set https://review.openstack.org/624445 | 15:35 |
| mriedem | i don't think | 15:35 |
| mriedem | so we might want to consider forcing config drive in our nova-live-migration job, | 15:36 |
| mriedem | or the grenade live migration job | 15:36 |
| mriedem | i think we also do everything with qcow2 image backend | 15:37 |
| *** awalende has quit IRC | 15:37 | |
| mriedem | and in https://review.openstack.org/#/c/567860/ i changed it to use raw | 15:37 |
| mriedem | which is another wrinkle we don't really touch | 15:37 |
| cfriesen | okay, why do we specify minimum package versions in both lower-constraints *and* requirements.txt? | 15:39 |
| mriedem | tonyb: ^ | 15:40 |
| jangutter | cfriesen: because the computer likes repetition because the computer likes repetition (paranoia reference) | 15:40 |
| jangutter | cfriesen: I found this ( https://docs.openstack.org/project-team-guide/dependency-management.html ) a while ago and I'm not 100% sure. | 15:42 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 15:42 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.openstack.org/639934 | 15:42 |
| sean-k-mooney | cfriesen: proably pinned in upperconstraitns | 15:44 |
| cfriesen | sean-k-mooney: turns out I missed updating lower_constraints | 15:44 |
| sean-k-mooney | oh ok | 15:44 |
| sean-k-mooney | i chekcked that but you had already fixed it when i did i guess | 15:45 |
| cfriesen | sean-k-mooney: don't know if you saw my comment last night....this patch series ^ is working as far as local resize with emulated TPM. | 15:46 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 15:46 |
| *** markvoelker has joined #openstack-nova | 15:47 | |
| sean-k-mooney | cfriesen: im reworking https://review.openstack.org/#/c/602432/ but that is next on my list | 15:48 |
| cfriesen | cool. I'm working on adding more unit tests to bring it up to the proper level. | 15:49 |
| *** _fragatina has quit IRC | 15:51 | |
| *** janki has quit IRC | 15:52 | |
| *** itlinux_ has joined #openstack-nova | 15:54 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653 | 15:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 15:54 |
| gibi | mriedem, jaypipes: the bottom two patches are up to date ^^ (and I think they are ready to fly) | 15:55 |
| mriedem | looking | 15:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Test live migration with config drive https://review.openstack.org/567860 | 15:55 |
| *** dpawlik has quit IRC | 15:55 | |
| *** itlinux has quit IRC | 15:56 | |
| *** jistr|call is now known as jistr | 16:00 | |
| gibi | mriedem: regarding filing InstancePCIRequest.requester_id with flavor.flavorid or network_id . Which one do you prefere? Fill it properly (e.g. use flavor.flavorid) or keep it None and fill it only when it is needeD? | 16:01 |
| mriedem | gibi: i haven't yet looked at how that is used, | 16:02 |
| mriedem | and i saw avolkov asked about a requester_type, | 16:02 |
| *** sapd1 has quit IRC | 16:02 | |
| mriedem | my one worry is that we have something in that field which isn't a port_id, but we assume it's a port_id and then something fails later because it turns out it was a flavor or network | 16:03 |
| mriedem | so maybe it's better to not set it for flavor/network in order to avoid confusion about when it can be used | 16:03 |
| mriedem | i guess you are future-proofing for when flavor resources are in a RequestGroup in the RequestSpec? | 16:04 |
| gibi | mriedem: InstancePCIRequest.requester_id is matched against RequestGroup.requester_id | 16:04 |
| gibi | mriedem: in https://review.openstack.org/#/c/623543/34/nova/compute/manager.py | 16:04 |
| gibi | so it is a bit of future proofing yes, but now I feel it would be better to keep it empty | 16:05 |
| gibi | so I think I will remove the flavor.id and netwokr_id bits | 16:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use aggregate_add_host in nova-manage https://review.openstack.org/640080 | 16:05 |
| efried | mriedem: This bud's for you ^ | 16:05 |
| efried | ...bud | 16:05 |
| mriedem | gibi: that is probably safest | 16:06 |
| efried | mriedem: LMK if you're on board with it conceptually and I'll fix up the testes. | 16:06 |
| gibi | mriedem: OK, cool | 16:06 |
| efried | mriedem: in particular, if you think I should split out the aggregate_add_host signature change. | 16:07 |
| *** itlinux_ has quit IRC | 16:07 | |
| mriedem | gibi: worst case is we'd set the InstancePCIRequest.request_id to a flavor.flavorid (which makes sense if the pci request comes via the flavor), and then we try finding the matching request group mapping and it's not found, so we just wasted time looking for something that we never setup | 16:07 |
| gibi | mriedem: agreed | 16:07 |
| mriedem | well, i guess worst case is ^ and we log something like "couldn't find mapping" or raise or something | 16:07 |
| gibi | mriedem: it was to early to add it | 16:07 |
| mriedem | you're ahead of your time | 16:07 |
| gibi | yeah | 16:07 |
| mriedem | efried: i can't digest that right now | 16:08 |
| efried | mriedem: No urgency | 16:08 |
| *** udesale has quit IRC | 16:13 | |
| *** mrch_ has quit IRC | 16:14 | |
| *** ttsiouts has quit IRC | 16:16 | |
| *** dave-mccowan has quit IRC | 16:17 | |
| *** ircuser-1 has quit IRC | 16:18 | |
| *** ircuser-1 has joined #openstack-nova | 16:19 | |
| *** wolverineav has joined #openstack-nova | 16:19 | |
| *** markvoelker has quit IRC | 16:21 | |
| *** ttsiouts has joined #openstack-nova | 16:21 | |
| *** IvensZambrano has joined #openstack-nova | 16:23 | |
| *** wolverineav has quit IRC | 16:23 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 16:24 |
| gibi | jaypipes, mriedem: and the third one is up-to-date as well | 16:25 |
| *** psachin has quit IRC | 16:28 | |
| mriedem | gibi: +2 on https://review.openstack.org/#/c/622421/ - nits inline so it's up to you if you want to address those quick or follow up | 16:29 |
| *** Sundar has joined #openstack-nova | 16:29 | |
| gibi | mriedem: I think I can respin it real quick | 16:30 |
| *** dpawlik has joined #openstack-nova | 16:30 | |
| * mriedem stands by | 16:30 | |
| *** itlinux has joined #openstack-nova | 16:32 | |
| gibi | mriedem: FYI ALLOCATIN for https://review.openstack.org/#/c/622421/32/nova/network/neutronv2/api.py@1734 need a rebase first. | 16:33 |
| *** dpawlik has quit IRC | 16:34 | |
| melwitt | o/ | 16:34 |
| mriedem | gibi: yup | 16:35 |
| mriedem | gibi: i'll fast re-approve your bottom change | 16:35 |
| gibi | mriedem: coolio | 16:36 |
| mriedem | cfriesen: comments in https://review.openstack.org/#/c/635350/ | 16:36 |
| cfriesen | okay, will do | 16:36 |
| mriedem | edleafe: i'm glad you picked up on the az name struggle in https://review.openstack.org/#/c/639874/ :) | 16:38 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | 16:40 |
| *** hamzy has quit IRC | 16:40 | |
| edleafe | mriedem: As an east coast native, I felt slighted. :( | 16:40 |
| *** macza has joined #openstack-nova | 16:41 | |
| *** moshele has joined #openstack-nova | 16:42 | |
| mriedem | az=rochester-ne | 16:42 |
| mriedem | there | 16:42 |
| mriedem | locally sourced | 16:42 |
| edleafe | no | 16:43 |
| mriedem | az=building25-floor3-mens-br | 16:43 |
| edleafe | az=teaneck-ne | 16:43 |
| *** jmlowe has quit IRC | 16:43 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: fix up numa-topology live migration hypervisor check https://review.openstack.org/635350 | 16:45 |
| *** moshele has quit IRC | 16:45 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653 | 16:46 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 16:46 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 16:46 |
| gibi | mriedem: fixed ^^ | 16:47 |
| mriedem | ok +2 on https://review.openstack.org/#/c/622421/ now | 16:50 |
| mriedem | jaypipes: ^ | 16:50 |
| openstackgerrit | Merged openstack/nova master: docs: ComputeDriver.update_provider_tree in nova https://review.openstack.org/633375 | 16:52 |
| *** helenafm has quit IRC | 16:53 | |
| cfriesen | can mock.patch.object change an object data member (not a function)? | 16:54 |
| *** ttsiouts has quit IRC | 16:54 | |
| *** dtantsur is now known as dtantsur|afk | 16:55 | |
| *** itlinux has quit IRC | 16:56 | |
| *** itlinux has joined #openstack-nova | 16:56 | |
| *** tssurya has quit IRC | 16:57 | |
| jaypipes | mriedem: yeah, I'm in-progress on that review. | 16:57 |
| *** ttsiouts has joined #openstack-nova | 16:58 | |
| efried | cfriesen: Yes? | 16:58 |
| cfriesen | efried: can you point me to an example? | 16:58 |
| *** ttsiouts has quit IRC | 16:59 | |
| *** betherly has quit IRC | 16:59 | |
| cfriesen | efried: do I use ".return_value" or something else? | 16:59 |
| efried | cfriesen: http://paste.openstack.org/show/746513/ | 16:59 |
| mriedem | gibi: just a question on https://review.openstack.org/#/c/625310/ | 16:59 |
| gibi | looking | 16:59 |
| *** ttsiouts has joined #openstack-nova | 16:59 | |
| cfriesen | efried: sweet, thanks | 17:00 |
| efried | yw | 17:00 |
| mriedem | cfriesen: you can also create the attribute if it might not exist | 17:00 |
| mriedem | https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch create=True | 17:00 |
| mriedem | normally shouldn't have to use that though | 17:00 |
| gibi | mriedem: you are correct | 17:00 |
| gibi | mriedem: it would be better to move the requester_id = request_net.port_id down where it is used | 17:01 |
| gibi | mriedem: let me fix it | 17:01 |
| mriedem | gibi: you might want to wait for jaypipes review to finish | 17:01 |
| gibi | mriedem: OK | 17:02 |
| *** ttsiouts has quit IRC | 17:04 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add support for microversion 2.70 - expose device tags https://review.openstack.org/636779 | 17:07 |
| mriedem | melwitt: can you look at ^ again | 17:07 |
| mriedem | takashin's comments should be addressed | 17:07 |
| melwitt | yep, looking | 17:08 |
| mriedem | dansmith: you want to send cells v1 docs to their watery grave? https://review.openstack.org/#/c/636718/ | 17:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Avoid BadRequest error log on volume attachment https://review.openstack.org/640110 | 17:10 |
| dansmith | mriedem: only if I can go with them | 17:10 |
| mriedem | i'm struggling to make an under-the-sea merman joke here | 17:10 |
| *** moshele has joined #openstack-nova | 17:10 | |
| mriedem | https://i.imgur.com/qiJRWMM.gif | 17:11 |
| melwitt | lol | 17:14 |
| mriedem | gibi: oh i guess jay is reviewing the port detach / deallocate change, so feel free to respin the pci request one | 17:14 |
| *** dpawlik has joined #openstack-nova | 17:15 | |
| gibi | I did the fix locally, and I will publish it before I leave. which is in ~15 minutes | 17:15 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Avoid BadRequest error log on volume attachment https://review.openstack.org/640116 | 17:16 |
| mriedem | gibi: ok then we have 3 more patches to get to what i think is the target goal for stein which is the microversion change | 17:16 |
| mriedem | how are you feeling about the rest of the changes to that point? | 17:16 |
| gibi | mriedem: correct. If we can merge the microversion patch then I'm happy. However heal port allocation is _after_ the microversion patch so that might make people sad | 17:17 |
| mriedem | i think that is backportable | 17:17 |
| mriedem | since it's an edge case | 17:17 |
| gibi | mriedem: yeah, I hope so | 17:17 |
| gibi | mriedem: the microversion patch itself is small and formal but needs some API doc | 17:18 |
| *** markvoelker has joined #openstack-nova | 17:18 | |
| gibi | mriedem: however I can add doc after FF | 17:18 |
| mriedem | sure. i imagine we'll want some more involved docs about this somewhere, probably nova user docs | 17:18 |
| mriedem | because the spec is going to be overwhelming for a user to try and figure out how this all works | 17:18 |
| stephenfin | mriedem: Missed the ping earlier, but I'll take a shot at https://review.openstack.org/#/c/567860/ tomorrow | 17:18 |
| gibi | mriedem: rubasov started creating a networking doc for the whole | 17:19 |
| stephenfin | notifications on Cinnamon suuuuck | 17:19 |
| gibi | mriedem: I will add to it | 17:19 |
| *** dpawlik has quit IRC | 17:19 | |
| sean-k-mooney | stephenfin: you dont like the way they pop up in the corner of the screen | 17:19 |
| stephenfin | sean-k-mooney: Not at all. It's pretty but they're no in your face enough | 17:20 |
| stephenfin | Nor are they duplicated across all screens | 17:20 |
| gibi | mriedem: the other two patches handing an edge case (two PF on the same compute connected to the same physnet) and it needs an extra tag in the passthrough_whitelist config | 17:20 |
| sean-k-mooney | stephenfin: well that is why i like them i hate os notification and i tolerater there because they are non intrusive | 17:20 |
| gibi | mriedem: stephenfin has some issue with that which I trying to explain away right now | 17:20 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 17:21 |
| *** ccamacho has quit IRC | 17:22 | |
| cfriesen | This ^ should be ready to review now | 17:22 |
| mriedem | cfriesen: throw it in runways | 17:25 |
| mriedem | https://etherpad.openstack.org/p/nova-runways-stein | 17:25 |
| mriedem | kashyap: have you looked at this at all? https://review.openstack.org/#/c/637834/ | 17:25 |
| mriedem | i know you like to think about cpu models | 17:26 |
| *** wolverineav has joined #openstack-nova | 17:27 | |
| gibi | stephenfin: I've just replied to your concerns about the pf_interface_name tag in https://review.openstack.org/#/c/625311/25/doc/source/admin/networking.rst@266 | 17:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 17:29 |
| gibi | mriedem: ^^ fixed | 17:29 |
| * gibi is leaving for today | 17:30 | |
| *** marst has joined #openstack-nova | 17:30 | |
| *** mrch_ has joined #openstack-nova | 17:30 | |
| mriedem | gibi: are you sure? https://review.openstack.org/#/c/625310/28..29 | 17:30 |
| mriedem | you only changed the commit message | 17:30 |
| gibi | mriedem: looking | 17:31 |
| gibi | forget to add the cahnge to the commit | 17:31 |
| gibi | :/ | 17:31 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 17:31 |
| mriedem | git review should not allow you to push if you have pending local changes | 17:31 |
| mriedem | but ok :) | 17:31 |
| *** wolverineav has quit IRC | 17:31 | |
| mriedem | i get a rebase conflict if i try doing that | 17:31 |
| gibi | mriedem: I never tried to use git review as that hides to much | 17:31 |
| mriedem | so you're both ahead of your time, | 17:32 |
| mriedem | and stuck in the past | 17:32 |
| gibi | :D | 17:32 |
| gibi | yeah | 17:32 |
| gibi | sort of | 17:32 |
| *** munimeha1 has joined #openstack-nova | 17:32 | |
| gibi | I hope it is good now as I have to run | 17:33 |
| gibi | talk to you tomorrow | 17:33 |
| mriedem | it's not, but i'll fix it :) | 17:33 |
| gibi | mriedem: OK, thanks :) | 17:33 |
| melwitt | fore | 17:33 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 17:34 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 17:34 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 17:34 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 17:34 |
| mriedem | i laugh at your measly 4 patches | 17:34 |
| melwitt | hmph! | 17:35 |
| mriedem | need i remind you https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/cross-cell-resize | 17:35 |
| melwitt | no, I know I can't compete | 17:35 |
| *** _fragatina has joined #openstack-nova | 17:36 | |
| *** wolverineav has joined #openstack-nova | 17:37 | |
| *** panda|ruck is now known as panda|ruck|off | 17:42 | |
| *** gyee has joined #openstack-nova | 17:44 | |
| *** derekh has quit IRC | 17:46 | |
| *** artom has quit IRC | 17:47 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 17:48 |
| *** markvoelker has quit IRC | 17:51 | |
| *** moshele has quit IRC | 18:01 | |
| *** jmlowe has joined #openstack-nova | 18:02 | |
| *** moshele has joined #openstack-nova | 18:05 | |
| *** Sundar has quit IRC | 18:05 | |
| *** sridharg has quit IRC | 18:08 | |
| *** igordc has joined #openstack-nova | 18:09 | |
| mriedem | for people to think about prior to the nova meeting http://lists.openstack.org/pipermail/openstack-discuss/2019-February/003356.html | 18:09 |
| *** itlinux has quit IRC | 18:13 | |
| *** hamzy has joined #openstack-nova | 18:13 | |
| *** itlinux has joined #openstack-nova | 18:15 | |
| openstackgerrit | Merged openstack/nova master: ironic: partition compute services by conductor group https://review.openstack.org/635006 | 18:18 |
| aspiers | efried, mriedem: is this the new understanding? https://pasteboard.co/I3hSwZ5.jpg | 18:24 |
| efried | aspiers: couple things... | 18:25 |
| efried | CUSTOM_ traits owned by drivers are not deprecated (did you mean "discouraged"?). There will always be custom traits for things that are dynamic in nature. To use an example that some people hate, CUSTOM_<PCI_ADDRESS> | 18:26 |
| aspiers | gotcha, I didn't know about those | 18:27 |
| efried | aspiers: When you include the bottom middle bubble in the "things manipulated by admin", you mean that it's *possible* for them to muck with it, but they shouldn't, and we'll "heal" it, per your note at the top. | 18:29 |
| aspiers | right | 18:29 |
| aspiers | I'll clarify that | 18:29 |
| *** wolverineav has quit IRC | 18:30 | |
| *** wolverineav has joined #openstack-nova | 18:30 | |
| efried | Cool. | 18:31 |
| efried | The only other note is use of the word "never" on the right hand side. The top two middle bubbles are supposed to be "exclusive" - i.e. traits that are owned by the driver are a *subset* of the traits the driver will actually *set*. | 18:31 |
| efried | aspiers: So like, I'm not sure if you did this on purpose, but the space in the intersection of the big bubbles, but outside of the three middle bubbles, is that set. | 18:31 |
| efried | ...assuming that yellow bubbles are things that are set, and stuff outside of yellow bubbles is things that are unset. | 18:32 |
| efried | Now in theory, the driver will "always" know what's in that set, and "always" switch off a trait from that set if the admin switches it on. | 18:32 |
| aspiers | ah no, stuff outside yellow bubbles is unspecified other stuff, or nothing at all | 18:33 |
| efried | But knowing the full list of things in that space is... hard. | 18:33 |
| efried | okay, then does what I'm saying above make sense? | 18:33 |
| aspiers | my brain hasn't grokked it yet | 18:33 |
| aspiers | give me a few secs :) | 18:33 |
| *** wolverineav has quit IRC | 18:33 | |
| *** wolverineav has joined #openstack-nova | 18:33 | |
| efried | There's a set of traits the driver owns. A subset of that will be turned on (by the driver). Anything in there that's turned on by the driver, and turned off by the admin, will get turned back on. Conversely, anything in there that's *not* turned on by the driver, but turned on by the admin, is *supposed* to be switched back off by the driver. | 18:34 |
| aspiers | hrm, you are saying the driver will set traits which it *doesn't* own? | 18:34 |
| *** ralonsoh has quit IRC | 18:34 | |
| efried | no, I'm saying it will switch *off* traits that it *does* own but doesn't think *should* be on. I.e. same logic as for the capability traits. | 18:34 |
| efried | but I have low confidence that drivers will succeed in doing that with 100% accuracy. | 18:35 |
| aspiers | Still not sure I understand. Is your point that outside of the new caps->traits code, there are other driver-owned traits for which the driver *should* override admin changes, but currently might not? | 18:37 |
| efried | What we really ought to do is come up with a namespacing convention so that this ^ can be done more accurately. E.g. compute is allowed to switch off anything set by the admin that's [CUSTOM_]COMPUTE_*. And conversely, compute has to leave alone anything not in that namespace that the admin sets. | 18:37 |
| efried | aspiers: Well, yes, "currently might not" because bug, not by design. | 18:38 |
| efried | A pedantic example: Let's say compute decorates a pGPU provider with CUSTOM_PCI_ADDRESS_00_01_02_03. Obviously it should be nonsensical for the admin to decorate the same RP with a trait like CUSTOM_PCI_ADDRESS_FF_AA_BB_CC. So compute should notice that second one and switch it off. | 18:39 |
| efried | but how will it know? | 18:40 |
| aspiers | right, that makes a lot more sense with a concrete example | 18:40 |
| efried | namespacing on every possible infix like _PCI_ADDRESS_ would be craziness. Hence the need for namespacing of some kind. But we don't have that convention in place yet. | 18:40 |
| efried | I guess we'll burn that bridge when we cross it. | 18:40 |
| aspiers | so technically my note with the arrow currently only refers to some of the things in the intersection of the two big bubbles, not all of them | 18:41 |
| aspiers | so not the top middle yellow bubble for a start | 18:41 |
| efried | but it's a correct theory :) | 18:42 |
| aspiers | right, it's describing what *should* happen but not what the patch achieves | 18:42 |
| efried | What this patch achieves is the above philosophy for capability-based standard traits only | 18:42 |
| efried | ...which, by the way, are namespaced COMPUTE_* :) | 18:43 |
| efried | (though probably not with as much intent as I've described) | 18:43 |
| aspiers | ok, let me try to tweak the diagram based on all this | 18:44 |
| aspiers | give me a few mins | 18:44 |
| *** tssurya has joined #openstack-nova | 18:44 | |
| *** sdake has joined #openstack-nova | 18:44 | |
| efried | I think a different angle on your venn diagram would be for everything in the bubbles to be traits; then a bubble within that would be compute-owned traits; then a bubble that overlaps the border of compute-owned would be "traits that are switched on". | 18:46 |
| aspiers | originally it was all traits | 18:46 |
| aspiers | but then I wanted to put capabilities on there to show that not all capabilities get mapped to traits | 18:46 |
| efried | yeah, that can be done. | 18:47 |
| efried | I don't have a drawing program handy, gr. | 18:47 |
| aspiers | this is in google drawings, so you do | 18:47 |
| aspiers | in fact you can even help me fix it in real-time :) | 18:47 |
| *** markvoelker has joined #openstack-nova | 18:47 | |
| * efried learns how to use google drawings | 18:49 | |
| aspiers | there's not much to learn :) | 18:49 |
| efried | I started drawing circles and can't figure out how to get them to be transparent. Off to a good start. | 18:51 |
| mriedem | jroll: rebase? https://review.openstack.org/#/c/636326/1 | 18:52 |
| *** mvkr has quit IRC | 18:52 | |
| aspiers | haha | 18:55 |
| efried | aspiers: combine top two middle bubbles? | 18:55 |
| aspiers | oh yeah, could do | 18:55 |
| aspiers | well | 18:56 |
| efried | "Compute-owned custom/standard traits" | 18:56 |
| aspiers | the point was to emphasise that there can be standard traits not from capabilities | 18:56 |
| aspiers | If we combine them, this point is not nearly as clear | 18:56 |
| efried | okay. | 18:56 |
| aspiers | I'll export to pasteboard.ca and update the commit message | 18:57 |
| efried | what this diagram still lacks is the concept of *unsetting*. | 18:57 |
| aspiers | hrm | 18:57 |
| aspiers | True, it also conflates providing traits with owning them, which is the other side of the same coin | 18:57 |
| efried | So a yellow bubble is a set of traits, but incorporates them being set or unset on the provider. | 18:57 |
| efried | how did you make your bubbles transparent? | 18:58 |
| aspiers | I don't think they are | 18:58 |
| efried | ah, found it. | 18:58 |
| aspiers | Oh, the big ones | 18:58 |
| aspiers | Yeah, custom colour | 18:58 |
| efried | Well, otherwise you can't see the overlap - yeah | 18:59 |
| aspiers | Urgh, this could get way more complicated if we distinguish set from unset | 19:00 |
| aspiers | we have to double the number of small bubbles | 19:00 |
| aspiers | trait bubbles, at least - not the caps ones | 19:01 |
| aspiers | not sure it's worth the effort | 19:01 |
| aspiers | for an image in a commit message | 19:01 |
| aspiers | this was mainly to check my understanding and ensure we're on the same page | 19:01 |
| aspiers | which I think we are | 19:01 |
| *** artom has joined #openstack-nova | 19:02 | |
| efried | aspiers: Yeah, I don't think we have to get this perfect | 19:03 |
| efried | aspiers: And we don't have to combine all those concepts in the same diagram. | 19:03 |
| efried | I just shared you the one I'm doing that just has the set/unset concept. | 19:03 |
| efried | it's not as pretty as yours. | 19:03 |
| aspiers | checking | 19:04 |
| efried | so the way to read this is: all capability traits are owned by compute; some are set and some are not. | 19:04 |
| efried | Of *all* traits owned by compute, some are set and some are not | 19:04 |
| efried | Of all traits that are set, some are compute-owned and some are not. | 19:05 |
| *** IvensZambrano has quit IRC | 19:05 | |
| jroll | mriedem: does it need it? | 19:06 |
| *** tssurya has quit IRC | 19:06 | |
| efried | jroll: yah | 19:06 |
| jroll | oh you're right | 19:07 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: bump minimum API version to 1.38 https://review.openstack.org/636326 | 19:07 |
| jroll | in the future, anyone is welcome to push the rebase button for me :P | 19:07 |
| *** itlinux has quit IRC | 19:07 | |
| efried | aspiers: a bit busy with that last addition, but I think it's right | 19:08 |
| efried | all capability traits are standard traits | 19:09 |
| efried | all capability traits are owned by compute | 19:09 |
| efried | not all capability traits are set at any given time | 19:09 |
| aspiers | efried: I disagree with your most recent edit | 19:12 |
| aspiers | efried: if the admin sets a trait, then it becomes supported, the driver will not unset it | 19:12 |
| aspiers | efried: and if the admin unsets a trait, then it becomes unsupported, the driver will not set it | 19:12 |
| aspiers | I think my previous text was more accurate | 19:13 |
| efried | "becomes unsupported" - this is a snapshot | 19:13 |
| efried | things becoming (un)supported or becoming standard etc. simply move the lines; they don't change the semantics. | 19:14 |
| aspiers | I'm not sure you got the point | 19:14 |
| *** pcaruana has quit IRC | 19:14 | |
| aspiers | there are other scenarios, e.g. | 19:14 |
| aspiers | 1. admin sets a trait | 19:14 |
| efried | uh, except I think those are backwards. | 19:15 |
| efried | ugh, I guess it depends how you're looking at it. | 19:15 |
| aspiers | 2. operator upgrades nova to introduce this patch to the deployment | 19:15 |
| aspiers | 3. nova-compute restarts | 19:15 |
| aspiers | 4. driver does not unset the trait, because it was supposed to be there | 19:16 |
| *** dpawlik has joined #openstack-nova | 19:16 | |
| efried | okay, sure, that's getting off into the weeds and not the point. | 19:16 |
| aspiers | the "will be" statements on this diagram make it span a period of time | 19:16 |
| aspiers | yeah sorry, that wasn't a good illustration | 19:17 |
| efried | Words like "unsupported" and "by the admin" can't be expected to encompass every possible nuance. | 19:17 |
| aspiers | the point is, the values in the capabilities dict are booleans representing whether the capability is supported | 19:18 |
| aspiers | and whether the driver will set or unset the traits depends on those booleans | 19:18 |
| efried | correct | 19:18 |
| aspiers | whereas your text makes it sound like it only depends on whether the traits were previously set by the admin or by the driver | 19:18 |
| aspiers | "if (un)set by admin" is not the correct condition | 19:19 |
| aspiers | "if deemed (un)supported by the driver" is the correct condition | 19:19 |
| efried | Right, this diagram is coming from the assumption that we started in a steady state of capability supported-ness and code level. | 19:19 |
| aspiers | the driver doesn't care who previously set or unset the trait | 19:19 |
| aspiers | whereas the text suggests it does | 19:19 |
| efried | works for me. | 19:20 |
| efried | I feel we've reached the point of diminishing returns here. It has been a useful exercise. Feel free to tweak this diagram/text and paste it off somewhere and use it, or not. | 19:20 |
| *** dpawlik has quit IRC | 19:20 | |
| aspiers | Agreed | 19:20 |
| *** whoami-rajat has quit IRC | 19:20 | |
| aspiers | I think I finally understand what you mean about steady state | 19:20 |
| efried | but for heaven's sake, if you're going to use this diagram, make it pretty with colors like yours. | 19:20 |
| aspiers | LOL | 19:20 |
| *** markvoelker has quit IRC | 19:21 | |
| * efried lunches | 19:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 19:23 |
| mriedem | alex_xu: i'm +2 on this now ^ | 19:23 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 19:24 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.openstack.org/639934 | 19:24 |
| *** _fragatina has quit IRC | 19:29 | |
| cfriesen | speaking of runways...could I get another look at https://review.openstack.org/#/c/620706/ ? Alex was supposed to review it again last night but didn't get around to it. | 19:30 |
| *** _fragatina has joined #openstack-nova | 19:31 | |
| *** _alastor_ has joined #openstack-nova | 19:31 | |
| *** _fragatina has quit IRC | 19:38 | |
| *** wolverineav has quit IRC | 19:39 | |
| *** wolverineav has joined #openstack-nova | 19:40 | |
| *** tbachman has quit IRC | 19:43 | |
| *** moshele has quit IRC | 19:45 | |
| cfriesen | mdbooth: you around? not sure what you meant by your comment in https://review.openstack.org/#/c/616692/20/nova/tests/unit/virt/libvirt/test_utils.py | 19:47 |
| *** wolverineav has quit IRC | 19:48 | |
| aspiers | efried, mriedem: new version https://pasteboard.co/I3iqqNm.jpg | 19:48 |
| aspiers | jaypipes, artom: you might care too | 19:48 |
| *** wolverineav has joined #openstack-nova | 19:48 | |
| aspiers | now I have to make the code actually match the diagram :) | 19:49 |
| artom | aspiers, is that a Venn diagram? It looks like one, but if I try to parse it like it makes no sense | 19:49 |
| aspiers | artom: yes it is | 19:50 |
| *** dpawlik has joined #openstack-nova | 19:50 | |
| artom | aspiers, ah, ok, on second pass it makes more sense | 19:50 |
| jaypipes | aspiers: that is venntastic. | 19:51 |
| aspiers | :) | 19:51 |
| aspiers | almost as venntastic as that pun | 19:51 |
| mriedem | yowser | 19:52 |
| mriedem | if this code ever lands we should probably have that in the docs somewhere | 19:52 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Improve libvirt image and snapshot handling https://review.openstack.org/616692 | 19:52 |
| artom | aspiers, how are some COMPUTE_* traits *not* set on RPs? | 19:53 |
| *** wolverineav has quit IRC | 19:53 | |
| artom | Or did you mean "set on RPs by the admin"? | 19:53 |
| aspiers | artom: if they don't apply? not all traits are set on everything all the time :) | 19:53 |
| artom | Oh, you're using "set" as in actually set, not "capable of being set" | 19:54 |
| aspiers | yes | 19:54 |
| artom | I swear, I dunno what is it about placement | 19:54 |
| aspiers | mriedem: don't scare me with conditional clauses like "if this code ever lands" :-p | 19:54 |
| *** dpawlik has quit IRC | 19:54 | |
| artom | Every time it's a rabbithole of endless taxonomy and modelling debate | 19:54 |
| melwitt | that diagram is art. and agreed please add it to docs along with patch | 19:54 |
| aspiers | melwitt: where would it belong? | 19:55 |
| artom | aspiers, anyways, yeah, seems to make sense, I'll wait for the code :) | 19:55 |
| melwitt | aspiers: do we have any existing driver capability doc? if so, there. if not, maybe we could make a new doc. and in that case, it could be a follow on patch | 19:56 |
| jaypipes | artom: yes. Nova's NUMA code is much clearer than placement's modeling. | 19:56 |
| aspiers | Now I'm wondering why this diagram attracted so much attention, vs. silence for my other two diagrams in the commit message :) | 19:57 |
| melwitt | would just be nice to capture helpful diagrams like that somewhere | 19:57 |
| aspiers | melwitt: I didn't notice any on a brief scan the other day | 19:57 |
| artom | jaypipes, hah, I'm not saying the code is bad | 19:57 |
| melwitt | well, I happened to click on this one and haven't read your commit message yet | 19:57 |
| aspiers | melwitt: I also made https://pasteboard.co/I25qICd.png | 19:58 |
| artom | jaypipes, I'm observing that placement monopolizes discussions every time it's brought up | 19:58 |
| artom | Even in our RH team call this morning | 19:58 |
| aspiers | melwitt: yeah, I was wondering more about the people who *have* already reviewed it ;-) | 19:59 |
| melwitt | aspiers: heh. well, it's not _that_ important about the diagrams, just a general sentiment of, it would be nice if we had more pictures in our docs for features we have. and since you already made those. another thing to throw on the TODO list | 20:00 |
| aspiers | melwitt: agreed, happy to add to docs. I would have already included in the review if I had found a good place for them | 20:01 |
| jaypipes | aspiers: I haven't reviewed the patch yet. | 20:01 |
| jaypipes | aspiers: been languishing in my endless review queue... | 20:02 |
| efried | aspiers: You still have another rev forthcoming, though, right? | 20:02 |
| jaypipes | apologies. | 20:02 |
| melwitt | aspiers: yeah. don't worry much about it, just another TODO for the pile of neverending TODOs :) | 20:02 |
| aspiers | jaypipes: no worries ;) | 20:02 |
| aspiers | efried: yes, working on it right now | 20:02 |
| efried | cool | 20:03 |
| aspiers | efried: I was planning to fix the issues, then submit, and only then rebase and submit again, to keep rebase changes in a separate patchset | 20:03 |
| aspiers | makes sense? | 20:03 |
| efried | aspiers: ++, hate having to review rebase+updates in same PS. | 20:03 |
| * aspiers longs for Gerrit 2.16 | 20:03 | |
| aspiers | efried: one day we will not have to worry about that any more | 20:04 |
| aspiers | o/~ one day ... o/~ | 20:04 |
| efried | yeah, it wasn't long ago that the rebase PS would include all the files from the rebase. | 20:04 |
| efried | ...from all the intervening commits | 20:04 |
| *** tbachman has joined #openstack-nova | 20:04 | |
| efried | so where we are now is at least an improvement on that. | 20:04 |
| aspiers | well, "long ago" depends very much on whether you are using the timeline of our Gerrit deployments, or the upstream Gerrit releases ;-) | 20:05 |
| aspiers | but yeah, I know you meant the former | 20:05 |
| aspiers | I kinda want to volunteer for the infra team *just* to get us on 2.16 | 20:05 |
| aspiers | but I don't have time :-( | 20:05 |
| *** sdake has quit IRC | 20:07 | |
| aspiers | melwitt: would it go under "Nova Major Subsystems"? https://docs.openstack.org/nova/latest/contributor/index.html | 20:07 |
| aspiers | a new doc called "resource provider trees" or something like that? | 20:07 |
| *** tbachman has quit IRC | 20:08 | |
| *** tbachman has joined #openstack-nova | 20:09 | |
| *** ttsiouts has joined #openstack-nova | 20:09 | |
| melwitt | aspiers: yeah, AFAIK, we don't have any nova docs about traits yet. is it only useful to nova contributors or to more ppl? if it's more, then it wouldn't be under contributor/ | 20:12 |
| aspiers | melwitt: I think some would, some wouldn't - depends on whether it's internals | 20:12 |
| aspiers | IMHO this Venn diagram is borderline either way | 20:13 |
| aspiers | I could do a more user-facing version | 20:13 |
| melwitt | no, I think it's ok, was just sanity checking. I think a new subsystem doc would make sense, like you suggested | 20:14 |
| *** tbachman has quit IRC | 20:15 | |
| aspiers | melwitt: any ideas about the title? | 20:15 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.openstack.org/640181 | 20:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make nova-grenade-live-migration voting and gate https://review.openstack.org/640182 | 20:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make nova-grenade-live-migration voting and gating https://review.openstack.org/640182 | 20:17 |
| mriedem | flavors docs talked about traits https://docs.openstack.org/nova/latest/user/flavors.html | 20:17 |
| mriedem | so you'd likely want some reference to how system-driven traits and user-driven traits overlap | 20:18 |
| aspiers | mriedem: good point, thanks | 20:18 |
| mriedem | i'm not sure contributor is really the right place for that information, | 20:19 |
| mriedem | since it is user facing | 20:19 |
| mriedem | user/admin | 20:19 |
| *** wolverineav has joined #openstack-nova | 20:19 | |
| mriedem | i mean we have https://docs.openstack.org/nova/latest/user/#maintenance | 20:19 |
| *** tbachman has joined #openstack-nova | 20:19 | |
| mriedem | and https://docs.openstack.org/nova/latest/reference/#internals | 20:19 |
| mriedem | the latter is where provider tree is documented | 20:20 |
| mriedem | https://docs.openstack.org/nova/latest/reference/update-provider-tree.html | 20:20 |
| mriedem | so you'd also link from ^ likely | 20:20 |
| mriedem | i'd probably throw something under reference/internals like the upt stuff, and reference from wherever it makes sense, like the flavors doc | 20:21 |
| *** umbSublime has joined #openstack-nova | 20:21 | |
| mriedem | "Note that there are compute-managed traits. Details about those can be found <here>." | 20:21 |
| mriedem | some of those compute traits also link to the feature support matrix ... https://docs.openstack.org/nova/latest/user/support-matrix.html#operation_device_tags | 20:22 |
| *** tesseract has quit IRC | 20:22 | |
| mriedem | aspiers: i'd worry about documentation later :) | 20:22 |
| aspiers | yup | 20:23 |
| *** wolverineav has quit IRC | 20:24 | |
| *** tbachman has quit IRC | 20:25 | |
| *** wolverineav has joined #openstack-nova | 20:30 | |
| *** wolverineav has quit IRC | 20:37 | |
| *** wolverineav has joined #openstack-nova | 20:38 | |
| *** wolverineav has quit IRC | 20:38 | |
| *** wolverineav has joined #openstack-nova | 20:38 | |
| *** hamzy has quit IRC | 20:39 | |
| *** hamzy has joined #openstack-nova | 20:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Fix legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/640186 | 20:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.openstack.org/640181 | 20:47 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make nova-grenade-live-migration voting and gating https://review.openstack.org/640182 | 20:47 |
| *** cdent has quit IRC | 20:48 | |
| melwitt | nova meeting in 10 minutes | 20:50 |
| artom | Oh hey, I can actually this one | 20:51 |
| artom | Usually it's smack in the middle of daycare taxi time | 20:51 |
| * artom accidentally a word | 20:54 | |
| *** takashin has joined #openstack-nova | 20:55 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 20:58 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 20:58 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 20:58 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 20:58 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.openstack.org/640181 | 20:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make nova-grenade-live-migration voting and gating https://review.openstack.org/640182 | 20:59 |
| *** wwriverrat has joined #openstack-nova | 21:00 | |
| *** erlon has quit IRC | 21:01 | |
| *** sdake has joined #openstack-nova | 21:04 | |
| *** igordc has quit IRC | 21:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.openstack.org/640191 | 21:09 |
| *** igordc has joined #openstack-nova | 21:09 | |
| *** dave-mccowan has joined #openstack-nova | 21:11 | |
| *** tbachman has joined #openstack-nova | 21:14 | |
| *** wolverineav has quit IRC | 21:18 | |
| *** dave-mccowan has quit IRC | 21:22 | |
| *** sdake has quit IRC | 21:23 | |
| *** sdake has joined #openstack-nova | 21:24 | |
| *** wolverineav has joined #openstack-nova | 21:25 | |
| *** wolverineav has quit IRC | 21:28 | |
| *** s10 has joined #openstack-nova | 21:28 | |
| *** wolverineav has joined #openstack-nova | 21:28 | |
| *** wolverineav has quit IRC | 21:29 | |
| *** wolverineav has joined #openstack-nova | 21:35 | |
| *** rchurch has joined #openstack-nova | 21:36 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Fix legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/640197 | 21:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.openstack.org/640198 | 21:42 |
| *** artom has quit IRC | 21:44 | |
| *** hamzy has quit IRC | 21:47 | |
| *** markvoelker has joined #openstack-nova | 21:48 | |
| marst | Hello. I've installed devstack (with minimal local.conf), how do I create several fake hypervisors? I remember there was a blog post from someone with 1000 hypervisors, but can't find it. | 21:49 |
| *** mchlumsky has quit IRC | 21:50 | |
| marst | Just trying to teach people how nova-scheduler filters work | 21:50 |
| marst | (but first need to understand it myself) | 21:50 |
| *** dpawlik has joined #openstack-nova | 21:51 | |
| mriedem | marst: this would get you partway https://review.openstack.org/#/c/507918/ | 21:51 |
| *** wolverineav has quit IRC | 21:51 | |
| mriedem | the main things are (1) use the fake virt driver (2) noop quota driver and (3) $NUMBER_FAKE_NOVA_COMPUTE | 21:52 |
| mriedem | even with that if you create too many fake computes you can run out of resources on a single host | 21:52 |
| marst | mriedem: Thanks a lot!! This is perfect! | 21:52 |
| mriedem | in fact i think i changed devstack so that if you use the fake virt driver, you get the noop quota driver automatically | 21:53 |
| mriedem | https://review.openstack.org/#/c/571933/ | 21:53 |
| mriedem | yeah so you just need to say VIRT_DRIVER=fake and NUMBER_FAKE_NOVA_COMPUTE=whatever | 21:54 |
| marst | mriedem: awesome! thank you! | 21:54 |
| mriedem | nop | 21:54 |
| mriedem | *np | 21:54 |
| * mriedem should probably document this in the devstack docs | 21:54 | |
| mriedem | i think i've gone up to 20 fake computes with an 8vcpu/8gb ram host and it was ok, but more than that and it starts to fall over, | 21:55 |
| mriedem | because it's using ncpu/2 API workers for conductor/scheduler/api services on the single host | 21:55 |
| *** dpawlik has quit IRC | 21:55 | |
| mriedem | you can set API_WORKERS=1 to trim that down | 21:55 |
| mriedem | so bunch of computes, 1 process per controller service | 21:55 |
| mriedem | i also create servers with networks=none so i don't hit port quota in neutron | 21:56 |
| marst | mriedem: Will give it a try tonight. Thanks a lot once again! :) | 21:57 |
| mriedem | np | 21:57 |
| *** slaweq has quit IRC | 21:58 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: check fresh data when sync_power_state doesn't line up https://review.openstack.org/636699 | 22:00 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Remove TypeError handling for get_info https://review.openstack.org/640043 | 22:00 |
| jroll | efried: you owe me back a +2 :P | 22:00 |
| *** wolverineav has joined #openstack-nova | 22:01 | |
| *** slaweq has joined #openstack-nova | 22:04 | |
| *** _fragatina has joined #openstack-nova | 22:07 | |
| *** wolverineav has quit IRC | 22:09 | |
| *** slaweq has quit IRC | 22:09 | |
| *** slaweq has joined #openstack-nova | 22:11 | |
| *** sdake has quit IRC | 22:13 | |
| *** slaweq has quit IRC | 22:16 | |
| *** markvoelker has quit IRC | 22:22 | |
| *** slaweq has joined #openstack-nova | 22:25 | |
| *** s10 has quit IRC | 22:27 | |
| *** wolverineav has joined #openstack-nova | 22:28 | |
| *** wolverineav has quit IRC | 22:29 | |
| *** wolverineav has joined #openstack-nova | 22:29 | |
| *** dpawlik has joined #openstack-nova | 22:29 | |
| *** slaweq has quit IRC | 22:30 | |
| mriedem | marst: you inspired me https://review.openstack.org/640205 | 22:32 |
| mriedem | feedback appreciated on if any of that doesn't work for you | 22:32 |
| *** wolverineav has quit IRC | 22:33 | |
| *** dpawlik has quit IRC | 22:34 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.openstack.org/640207 | 22:38 |
| *** wolverineav has joined #openstack-nova | 22:45 | |
| *** slaweq has joined #openstack-nova | 22:45 | |
| marst | mriedem: thank you! I'll try it, but pretty sure it'll work as expected. | 22:45 |
| mriedem | easy +w https://review.openstack.org/#/c/635350/5 | 22:46 |
| *** wolverineav has quit IRC | 22:49 | |
| *** slaweq has quit IRC | 22:51 | |
| tonyb | cfriesen: because they have different consumers and a requirements file is different from a constraints file | 22:53 |
| tonyb | cfriesen: I get it's a little duplication but is it really that bad? How would you chnage it? | 22:54 |
| *** luksky has joined #openstack-nova | 22:55 | |
| *** tkajinam has joined #openstack-nova | 22:55 | |
| efried | jroll: done, thanks for the squash. | 22:59 |
| jroll | efried: np, thanks for the reviews | 22:59 |
| *** wolverineav has joined #openstack-nova | 23:01 | |
| efried | mriedem: I'm gonna leave stephenfin to that +W. I would nitpick it to death. | 23:02 |
| mriedem | yar matey | 23:02 |
| *** luksky has quit IRC | 23:03 | |
| *** awalende has joined #openstack-nova | 23:05 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Drop legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/640219 | 23:06 |
| *** wolverineav has quit IRC | 23:07 | |
| melwitt | mriedem: want to make sure this is kosher for backporting (ironic driver virt api change) https://review.openstack.org/636699 | 23:07 |
| mriedem | well i can certainly look | 23:08 |
| *** wolverineav has joined #openstack-nova | 23:08 | |
| *** wolverineav has quit IRC | 23:08 | |
| *** wolverineav has joined #openstack-nova | 23:08 | |
| cfriesen | tonyb: I just was surprised because I was upversioning os-traits and didn't realize it needed to be changed in two places. | 23:09 |
| *** awalende has quit IRC | 23:10 | |
| cfriesen | tonyb: seems silly to specify "I need at least version 0.11.0 of os-traits" in two different ways. | 23:10 |
| melwitt | mriedem: I just looked at it. TypeError handled but no warning log for out-of-tree people. I made a comment | 23:10 |
| melwitt | maybe that's overkill for helping out-of-tree. it's mentioned in the reno already | 23:10 |
| cfriesen | tonyb: I can live with it of course. :) | 23:10 |
| *** slaweq has joined #openstack-nova | 23:11 | |
| mriedem | melwitt: same, plus it's broken | 23:12 |
| mriedem | melwitt: you'd handle the type error and then get another error for an undefined variable | 23:13 |
| melwitt | ohh | 23:13 |
| melwitt | ouch | 23:13 |
| *** threestrands has joined #openstack-nova | 23:13 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 23:13 |
| mriedem | well maybe not | 23:13 |
| mriedem | oh i guess we'd just fallback to doing what we did before right? | 23:14 |
| *** vishwanathj has quit IRC | 23:14 | |
| *** slaweq has quit IRC | 23:15 | |
| aspiers | mriedem, efried: fixed version is now uploaded https://review.openstack.org/#/c/538498/19..20//COMMIT_MSG | 23:15 |
| aspiers | mriedem, efried: now I will rebase and fix the conflict | 23:15 |
| mriedem | jroll: check my logic in here https://review.openstack.org/#/c/636699/ | 23:15 |
| melwitt | seems like it would fall back, given that vm_power_state is passed into the method and the new code just overwrites it if the driver can pull from not cache | 23:16 |
| mriedem | yeah ok | 23:17 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 23:17 |
| *** artom has joined #openstack-nova | 23:17 | |
| aspiers | mriedem, efried: now rebased in patch set 21 | 23:18 |
| *** markvoelker has joined #openstack-nova | 23:18 | |
| efried | aspiers: looking. Will try to get it done before I have to leave for class... | 23:19 |
| aspiers | efried: thanks :) | 23:19 |
| efried | else mañana | 23:20 |
| *** wolverineav has quit IRC | 23:23 | |
| *** markvoelker has quit IRC | 23:24 | |
| *** markvoelker has joined #openstack-nova | 23:24 | |
| efried | aspiers: Done, that was pretty easy. | 23:25 |
| efried | great work there, Adam, really appreciate you picking that up and sticking with it through all our waffling. | 23:26 |
| aspiers | :) | 23:26 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 23:28 |
| aspiers | efried: nit addressed | 23:29 |
| *** wolverineav has joined #openstack-nova | 23:29 | |
| openstackgerrit | Merged openstack/python-novaclient master: Add support for microversion 2.70 - expose device tags https://review.openstack.org/636779 | 23:29 |
| efried | aspiers: +2 again. Assuming others don't notice, we've asserted a design statement there about trait namespacing :) | 23:30 |
| mriedem | melwitt: Kevin_Zheng: artom: dansmith: see if we're in agreement with this summary of the nova meeting discussion about the root volume detach/attach + tag issue http://lists.openstack.org/pipermail/openstack-discuss/2019-February/003367.html | 23:30 |
| aspiers | efried: right ;-) | 23:30 |
| Kevin_Zheng | mriedem: thanks for putting this up, I agree with the current agreement | 23:32 |
| melwitt | mriedem: yeah, matches my understanding. I get that it's not great to go half-baked, but I tend toward it being nicer to make some progress and not have to dump context and start all over again from a mental standpoint. reloading the concept is still necessary but I personally still find it easier when partial support has landed, vs not | 23:34 |
| *** itlinux has joined #openstack-nova | 23:39 | |
| *** sapd1 has joined #openstack-nova | 23:41 | |
| *** itlinux_ has joined #openstack-nova | 23:41 | |
| *** marst has quit IRC | 23:42 | |
| *** itlinux has quit IRC | 23:43 | |
| mriedem | Kevin_Zheng: so i didn't look yet, but you added the code to change the RequestSpec.image when attaching a new root volume? | 23:57 |
| mriedem | so that unshelve will schedule properly? | 23:57 |
| Kevin_Zheng | Yeah I did that and also added a test | 23:58 |
| mriedem | https://review.openstack.org/#/c/623981/21/nova/tests/functional/test_attach_detach_root_volume.py | 23:58 |
| *** tbachman has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
