| *** s10 has joined #openstack-nova | 00:01 | |
| alex_xu | mriedem: want to hear your opinion on https://review.openstack.org/#/c/634827/23/nova/objects/migrate_data.py@99 | 00:07 |
|---|---|---|
| cfriesen | is it still the case that traits in image properties are specified as "trait:HW_SOME_TRAIT=required" with a colon after trait? | 00:08 |
| cfriesen | alex_xu: I've uploaded a new version of the image/flavor validation commit | 00:09 |
| alex_xu | cfriesen: got it, I will try second round today | 00:10 |
| alex_xu | cfriesen: for your trait question http://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/glance-image-traits.html | 00:11 |
| alex_xu | so should be yes | 00:11 |
| * alex_xu needs clear mind for second round | 00:13 | |
| *** macza has quit IRC | 00:14 | |
| *** wolverineav has quit IRC | 00:15 | |
| *** eandersson has quit IRC | 00:16 | |
| *** eandersson_ has joined #openstack-nova | 00:17 | |
| *** s10 has quit IRC | 00:18 | |
| *** hongbin has quit IRC | 00:19 | |
| *** wolverineav has joined #openstack-nova | 00:21 | |
| *** tosky has quit IRC | 00:23 | |
| *** _hemna has joined #openstack-nova | 00:28 | |
| *** markvoelker has joined #openstack-nova | 00:31 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix resetting non-persistent fields when saving obj https://review.openstack.org/636271 | 00:34 |
| *** cdent has quit IRC | 00:39 | |
| *** sapd1 has joined #openstack-nova | 00:45 | |
| *** jobewan has quit IRC | 00:45 | |
| *** markvoelker has quit IRC | 01:04 | |
| *** Swami has quit IRC | 01:04 | |
| mriedem | alex_xu: i'm not sure i understand the question on the review :) | 01:08 |
| mriedem | are you saying, since we already have the migration context, why not just store the information there rather than pass it over rpc with the MigrateData object? | 01:08 |
| alex_xu | mriedem: migration_context has the claimed_instance_numa, and we also need host numa obj, and some host configuration(like shared cpu set?). Then we pass all of those back to the src node, and src node can use existed code to generate libvirt xml. | 01:13 |
| alex_xu | mriedem: the currently way in the patch is only fetching the needed back to the host node, I think that is why we hack the xml in the src node. | 01:14 |
| mriedem | as far as i know this is working similar to how we handle updating the xml on the source host for things like volumes and vifs | 01:15 |
| mriedem | based on data from the dest host | 01:15 |
| alex_xu | yes, I agree, we already have code work as this. Just want to ensure whether we want to change that, if people really thing it is ok, then i will continue review as the current way | 01:16 |
| mriedem | well, there might be better alternatives, but at this point in the release it's probably too late to try them without for sure deferring this change to train | 01:17 |
| melwitt | sorrt | 01:17 |
| openstackgerrit | melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | 01:17 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 01:17 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 01:17 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 01:17 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 01:17 |
| melwitt | *sorry | 01:17 |
| mriedem | alex_xu: i'm assuming artom has already been doing integration testing of this code too | 01:18 |
| alex_xu | actually, just want you ensure whether worth to change that, which i'm not sure and hesitate :) | 01:18 |
| mriedem | alex_xu: yeah i don't know either | 01:18 |
| alex_xu | mriedem: yea, that is also part of my hesitate | 01:18 |
| *** wolverineav has quit IRC | 01:18 | |
| *** eharney has quit IRC | 01:19 | |
| mriedem | takashin: i just have a couple of comments in https://review.openstack.org/#/c/638849/ otherwise it looks ok | 01:19 |
| *** jaosorior has quit IRC | 01:20 | |
| takashin | mriedem: Thank you. I will fix them. | 01:20 |
| *** wolverineav has joined #openstack-nova | 01:24 | |
| *** jaosorior has joined #openstack-nova | 01:32 | |
| *** mrjk_ has quit IRC | 01:33 | |
| *** mrjk_ has joined #openstack-nova | 01:34 | |
| *** tetsuro has joined #openstack-nova | 01:35 | |
| openstackgerrit | Merged openstack/nova master: Add unit tests for missing VirtualInterface in 2.70 os-interface https://review.openstack.org/639141 | 01:38 |
| *** tetsuro has quit IRC | 01:38 | |
| *** tetsuro has joined #openstack-nova | 01:39 | |
| *** mriedem is now known as mriedem_afk | 01:39 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove wrong description for auto resize confirm https://review.openstack.org/638357 | 01:39 |
| *** ondrejme has quit IRC | 01:44 | |
| openstackgerrit | Merged openstack/python-novaclient master: Fix output of interface-attach command https://review.openstack.org/637677 | 01:48 |
| openstackgerrit | Merged openstack/python-novaclient master: Add a note in "nova service-delete" help about deleting computes https://review.openstack.org/627637 | 01:48 |
| *** mlavalle has quit IRC | 01:52 | |
| *** tetsuro has quit IRC | 01:53 | |
| *** hongbin has joined #openstack-nova | 01:55 | |
| *** tetsuro has joined #openstack-nova | 01:57 | |
| *** tetsuro has quit IRC | 02:00 | |
| *** whoami-rajat has joined #openstack-nova | 02:01 | |
| *** _hemna has quit IRC | 02:02 | |
| *** tetsuro has joined #openstack-nova | 02:03 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 02:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 02:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.openstack.org/634828 | 02:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.openstack.org/635229 | 02:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.openstack.org/634605 | 02:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP needs more tests] Full NUMA live migration support https://review.openstack.org/634606 | 02:04 |
| *** artom has joined #openstack-nova | 02:04 | |
| *** _fragatina has quit IRC | 02:05 | |
| *** tetsuro has quit IRC | 02:05 | |
| artom | mriedem_afk, alex_xu, I run https://review.rdoproject.org/r/#/c/18832/ against the Nova patch series | 02:05 |
| *** wolverineav has quit IRC | 02:05 | |
| artom | It's a tempest plugin that massively subverts what tempest is for, but allows us to test stuff like this in an automated fashion | 02:06 |
| artom | In there I have 3 tests for now: test that CPU pinning information is updated, test that emulator thread pinning information is updated, and test that hugepages information is updated. | 02:06 |
| artom | The update I just pushed to the Nova patches passed all 3 tests | 02:07 |
| artom | I'll write an ML or something, to have it in writing in a more permanent fashion | 02:07 |
| artom | But for now, I'm gonna go get swole at the gym, then sleep | 02:08 |
| artom | To be back harder tomorrow morning | 02:08 |
| *** wolverineav has joined #openstack-nova | 02:08 | |
| *** tetsuro has joined #openstack-nova | 02:10 | |
| *** nicholas has quit IRC | 02:10 | |
| *** zhubx007 has quit IRC | 02:24 | |
| *** mriedem_afk has quit IRC | 02:24 | |
| *** zhubx has joined #openstack-nova | 02:24 | |
| *** zhubx has quit IRC | 02:25 | |
| *** zhubx has joined #openstack-nova | 02:25 | |
| *** wolverineav has quit IRC | 02:26 | |
| *** wolverineav has joined #openstack-nova | 02:27 | |
| *** mriedem has joined #openstack-nova | 02:29 | |
| *** wolverineav has quit IRC | 02:32 | |
| *** lbragstad has quit IRC | 02:44 | |
| *** macza has joined #openstack-nova | 02:47 | |
| *** macza has quit IRC | 02:51 | |
| mriedem | yonglihe: alex_xu: comments in https://review.openstack.org/#/c/621474/ but i'm not sure why server_groups is a list - the server can only be in at most 1 server group | 02:52 |
| mriedem | returning a list is misleading | 02:52 |
| mriedem | so i would prefer to have just a key=value, e.g. server_group: <server_group_id or None> | 02:52 |
| mriedem | i've also added tssurya to the review because I think we can also return the server group in the down-cell case | 02:52 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750 | 02:52 |
| *** mgariepy has quit IRC | 02:53 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:53 | |
| yonglihe | mriedem, that suggested by jaypipes, history in the spec review comments. basically idea is that the group should have belong to multi groups . | 02:54 |
| mriedem | "should have" is not "the way it is" | 02:55 |
| mriedem | you currently cannot have a server in more than one group | 02:55 |
| *** psachin has joined #openstack-nova | 02:55 | |
| mriedem | i know people have tried to change the api to allow adding/removing servers to/from groups over time | 02:56 |
| mriedem | but that is not implemented today | 02:56 |
| mriedem | is this a list because windriver allows having a server in more than one group? | 02:56 |
| mriedem | *starlingx | 02:56 |
| yonglihe | no, it's not in starlingx, | 02:56 |
| *** mgariepy has joined #openstack-nova | 02:56 | |
| *** sapd1 has quit IRC | 02:57 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750 | 02:58 |
| openstackgerrit | yenai proposed openstack/nova master: Disconnect volume when encryption is failed https://review.openstack.org/632598 | 02:58 |
| yonglihe | should we switch to just one UUID? | 02:58 |
| mriedem | i'm also wondering why not return the server group name along with the uuid | 03:00 |
| mriedem | while we're looking up the server group | 03:00 |
| mriedem | i know you can get the name of the group via the GET /os-server-groups/{id} api | 03:00 |
| mriedem | anyway, i'm mostly -1 because of the list | 03:01 |
| mriedem | adding the name + uuid is just a thought | 03:01 |
| yonglihe | people think that is redundant, uuid is enough. | 03:01 |
| *** markvoelker has joined #openstack-nova | 03:01 | |
| *** wolverineav has joined #openstack-nova | 03:02 | |
| yonglihe | ok so we should patch the bp and rebase patch to return just UUID, along with address comments. | 03:02 |
| mriedem | ugh, i see jaypipes' comment in the spec now https://review.openstack.org/#/c/612255/11/specs/stein/approved/show-server-group.rst@67 | 03:03 |
| mriedem | exactly the opposite of mine :) | 03:03 |
| yonglihe | should we align that? | 03:03 |
| *** sapd1 has joined #openstack-nova | 03:04 | |
| mriedem | yonglihe: can you ask about it in the mailing list? i see that my last comment in the spec was https://review.openstack.org/#/c/612255/5/specs/stein/approved/list-server-group.rst@38 | 03:04 |
| mriedem | which wasn't the direction taken | 03:04 |
| mriedem | i guess i was thinking something more like this based on what i just said in your patch https://review.openstack.org/#/c/612255/4/specs/stein/approved/list-server-group.rst@62 | 03:05 |
| yonglihe | ok, i gonna re-open this on mail thead. | 03:06 |
| *** wolverineav has quit IRC | 03:07 | |
| mriedem | yonglihe: thanks, and sorry - but this is pretty straight-forward otherwise and i don't see a problem with getting it merged once we decide on the format | 03:09 |
| yonglihe | sure, we do it as good as we can, that's good thing to go, i like it -:) | 03:10 |
| *** mriedem has quit IRC | 03:12 | |
| *** sapd1 has quit IRC | 03:14 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080 | 03:31 |
| *** hongbin has quit IRC | 03:33 | |
| *** tetsuro has quit IRC | 03:34 | |
| *** markvoelker has quit IRC | 03:35 | |
| *** macza has joined #openstack-nova | 03:44 | |
| *** macza has quit IRC | 03:48 | |
| openstackgerrit | Merged openstack/nova master: Create specialist set_macaddr_and_vlan helper. https://review.openstack.org/624227 | 03:51 |
| openstackgerrit | Merged openstack/nova master: Move create_tap_dev into privsep. https://review.openstack.org/624228 | 03:51 |
| *** udesale has joined #openstack-nova | 03:54 | |
| *** ratailor has joined #openstack-nova | 03:56 | |
| *** gyee has quit IRC | 03:58 | |
| *** yaawang has quit IRC | 04:03 | |
| *** sdake has joined #openstack-nova | 04:06 | |
| *** sdake has quit IRC | 04:10 | |
| *** sdake has joined #openstack-nova | 04:12 | |
| *** sdake has quit IRC | 04:13 | |
| *** sdake has joined #openstack-nova | 04:15 | |
| *** sridharg has joined #openstack-nova | 04:15 | |
| *** sdake has quit IRC | 04:23 | |
| *** markvoelker has joined #openstack-nova | 04:32 | |
| *** wolverineav has joined #openstack-nova | 04:33 | |
| *** dave-mccowan has quit IRC | 04:44 | |
| *** lbragstad has joined #openstack-nova | 04:53 | |
| *** _hemna has joined #openstack-nova | 04:59 | |
| *** _hemna has quit IRC | 05:04 | |
| *** markvoelker has quit IRC | 05:05 | |
| *** wolverineav has quit IRC | 05:09 | |
| *** wolverineav has joined #openstack-nova | 05:11 | |
| *** _fragatina has joined #openstack-nova | 05:12 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix changes-before values in an instance action test https://review.openstack.org/638849 | 05:13 |
| *** janki has joined #openstack-nova | 05:26 | |
| *** takashin has left #openstack-nova | 05:31 | |
| openstackgerrit | yenai proposed openstack/nova master: Disconnect volume when encryption is failed https://review.openstack.org/632598 | 05:40 |
| *** _fragatina has quit IRC | 05:47 | |
| *** wolverineav has quit IRC | 06:01 | |
| *** wolverineav has joined #openstack-nova | 06:02 | |
| *** markvoelker has joined #openstack-nova | 06:03 | |
| *** wolverineav has quit IRC | 06:07 | |
| *** tetsuro has joined #openstack-nova | 06:14 | |
| *** wolverineav has joined #openstack-nova | 06:14 | |
| *** ivve has joined #openstack-nova | 06:23 | |
| *** igordc has quit IRC | 06:30 | |
| *** tetsuro has quit IRC | 06:31 | |
| *** masber has joined #openstack-nova | 06:31 | |
| masber | good afternoon all, is this the right place to ask questions about SRIOV? for some reason nova-compute complains that it can't find the device, however I can't find "the device" in the libvirt device list | 06:32 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750 | 06:34 |
| *** markvoelker has quit IRC | 06:35 | |
| *** kashyap has joined #openstack-nova | 06:40 | |
| *** jchhatbar has joined #openstack-nova | 06:43 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 06:45 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 06:45 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 06:45 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 06:45 |
| *** janki has quit IRC | 06:45 | |
| openstackgerrit | Yury Kulazhenkov proposed openstack/nova master: remove deprecated os_brick import from ScaleIO driver https://review.openstack.org/638592 | 06:48 |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 06:49 |
| *** Luzi has joined #openstack-nova | 06:54 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 07:02 |
| *** wolverineav has quit IRC | 07:06 | |
| *** tetsuro has joined #openstack-nova | 07:06 | |
| *** wolverineav has joined #openstack-nova | 07:06 | |
| *** masber has quit IRC | 07:13 | |
| *** wolverineav has quit IRC | 07:13 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080 | 07:16 |
| *** dpawlik has joined #openstack-nova | 07:30 | |
| *** zhubx007 has joined #openstack-nova | 07:33 | |
| *** zhubx has quit IRC | 07:33 | |
| *** zhubx007 has quit IRC | 07:35 | |
| *** logan- has quit IRC | 07:35 | |
| *** mrch has joined #openstack-nova | 07:35 | |
| *** zhubx has joined #openstack-nova | 07:35 | |
| *** logan- has joined #openstack-nova | 07:37 | |
| *** mrch_ has quit IRC | 07:38 | |
| *** _fragatina has joined #openstack-nova | 07:41 | |
| *** lbragstad has quit IRC | 07:44 | |
| *** wolverineav has joined #openstack-nova | 07:47 | |
| *** wolverineav has quit IRC | 07:52 | |
| *** rcernin has quit IRC | 07:56 | |
| *** ccamacho has joined #openstack-nova | 08:02 | |
| *** tesseract has joined #openstack-nova | 08:13 | |
| *** tkajinam has quit IRC | 08:16 | |
| *** Luzi has quit IRC | 08:18 | |
| *** awalende has joined #openstack-nova | 08:18 | |
| *** helenafm has joined #openstack-nova | 08:20 | |
| *** _fragatina has quit IRC | 08:23 | |
| *** wolverineav has joined #openstack-nova | 08:29 | |
| *** tssurya has joined #openstack-nova | 08:30 | |
| *** Luzi has joined #openstack-nova | 08:32 | |
| *** markvoelker has joined #openstack-nova | 08:32 | |
| *** wolverineav has quit IRC | 08:33 | |
| *** pcaruana has joined #openstack-nova | 08:35 | |
| *** tosky has joined #openstack-nova | 08:39 | |
| *** ondrejme has joined #openstack-nova | 08:43 | |
| *** wolverineav has joined #openstack-nova | 08:44 | |
| *** dtantsur|afk is now known as dtantsur | 08:46 | |
| *** wolverineav has quit IRC | 08:49 | |
| *** ttsiouts has joined #openstack-nova | 08:49 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 08:50 |
| *** _fragatina has joined #openstack-nova | 08:54 | |
| *** tetsuro has quit IRC | 08:57 | |
| *** ralonsoh has joined #openstack-nova | 08:57 | |
| *** ccamacho has quit IRC | 08:58 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 08:59 |
| *** priteau has joined #openstack-nova | 08:59 | |
| *** markvoelker has quit IRC | 09:06 | |
| *** ttsiouts has quit IRC | 09:07 | |
| *** ttsiouts has joined #openstack-nova | 09:08 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 09:09 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080 | 09:09 |
| *** zhubx has quit IRC | 09:11 | |
| *** zhubx has joined #openstack-nova | 09:12 | |
| *** ttsiouts has quit IRC | 09:13 | |
| *** ttsiouts has joined #openstack-nova | 09:14 | |
| *** jchhatbar has quit IRC | 09:16 | |
| *** jchhatbar has joined #openstack-nova | 09:16 | |
| *** jchhatbar has quit IRC | 09:22 | |
| *** jchhatbar has joined #openstack-nova | 09:23 | |
| *** dklyle has quit IRC | 09:25 | |
| *** dklyle has joined #openstack-nova | 09:27 | |
| *** lucasagomes has joined #openstack-nova | 09:27 | |
| *** elod_ has joined #openstack-nova | 09:29 | |
| *** FlorianFa has quit IRC | 09:30 | |
| *** elod has quit IRC | 09:30 | |
| *** lyarwood has quit IRC | 09:30 | |
| *** tacco has quit IRC | 09:30 | |
| *** ebbex has quit IRC | 09:30 | |
| *** elod_ is now known as elod | 09:30 | |
| *** tssurya has quit IRC | 09:30 | |
| *** zhubx has quit IRC | 09:31 | |
| *** tssurya has joined #openstack-nova | 09:31 | |
| *** lee1 has joined #openstack-nova | 09:34 | |
| *** jamesdenton has quit IRC | 09:35 | |
| *** rha has quit IRC | 09:35 | |
| *** FlorianFa has joined #openstack-nova | 09:35 | |
| *** jamesdenton has joined #openstack-nova | 09:36 | |
| *** ebbex has joined #openstack-nova | 09:36 | |
| *** _fragatina has quit IRC | 09:39 | |
| *** ccamacho has joined #openstack-nova | 09:39 | |
| *** wolverineav has joined #openstack-nova | 09:41 | |
| *** lee1 is now known as lyarwood | 09:42 | |
| *** cdent has joined #openstack-nova | 09:43 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move set_vf_interface_vlan to be with its only caller. https://review.openstack.org/624229 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move DHCP releasing to privsep. https://review.openstack.org/624230 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Convert additional IP management calls to privsep. https://review.openstack.org/624231 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move route management to privsep. https://review.openstack.org/624232 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move additional IP address management to privsep. https://review.openstack.org/624591 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move arping to privsep. https://review.openstack.org/624593 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move cleaning conntrack to privsep. https://review.openstack.org/624594 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move killing processes to privsep. https://review.openstack.org/635432 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move FP device creation and deletion to privsep. https://review.openstack.org/635433 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup the exec_ebtables code a little. https://review.openstack.org/635434 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280 | 09:43 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281 | 09:44 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282 | 09:44 |
| *** derekh has joined #openstack-nova | 09:46 | |
| *** sapd1 has joined #openstack-nova | 09:49 | |
| *** IvensZambrano has joined #openstack-nova | 09:53 | |
| *** efoley has joined #openstack-nova | 09:56 | |
| *** priteau has quit IRC | 09:57 | |
| *** priteau has joined #openstack-nova | 09:59 | |
| *** markvoelker has joined #openstack-nova | 10:03 | |
| *** dpawlik has quit IRC | 10:05 | |
| *** priteau has quit IRC | 10:06 | |
| *** wolverineav has quit IRC | 10:14 | |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: docs: Use sphinx.ext.autodoc for VIF types https://review.openstack.org/638404 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: docs: Use sphinx.ext.autodoc for profile, datapath offload types https://review.openstack.org/638405 | 10:20 |
| aspiers | cfriesen: your suggestion exactly describes what I already pushed to Gerrit :-) https://review.openstack.org/#/c/638680/ | 10:29 |
| aspiers | kashyap: I was told to ask your advice on this http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-02-25.log.html#t2019-02-25T23:18:05 | 10:30 |
| kashyap | aspiers: Hi | 10:30 |
| kashyap | I'm deeply buried in a different context; will get back to you | 10:31 |
| aspiers | kashyap: ok np, thanks! | 10:31 |
| kashyap | aspiers: I lost all the IRC scrollback from yesterday, that's why I didn't see it. | 10:31 |
| kashyap | aspiers: So it's about machine types and AMD SEV detection | 10:31 |
| aspiers | kashyap: yeah, I noticed you were not in the channel | 10:31 |
| aspiers | correct | 10:31 |
| *** Dinesh_Bhor has quit IRC | 10:32 | |
| kashyap | aspiers: Which TZ are you in? | 10:32 |
| aspiers | and this stack of patches: https://review.openstack.org/#/c/638680/ | 10:32 |
| aspiers | GMT (London, UK) | 10:32 |
| kashyap | Okido; will come back sometime in the afternoon to this. | 10:33 |
| kashyap | aspiers: I'll leave you with a related URL: https://review.openstack.org/#/c/631154/ ("WIP: Gracefully handle QEMU machine types for guests") | 10:33 |
| *** yan0s has joined #openstack-nova | 10:35 | |
| *** markvoelker has quit IRC | 10:36 | |
| sean-k-mooney | stephenfin: looking at the other docs changes you pushed im more or less hapy with the final too in the series. ill take a look at them again when the ci reports back but do you want to include them in the release? | 10:36 |
| aspiers | kashyap: SEV requires q35 but I think that is only loosely related. The main point here is that virConnectGetDomainCapabilities was designed to be invoked just before booting an instance of a specific arch / machine type, not during initialisation of a hypervisor host which can potentially host multiple archs / machine types | 10:36 |
| aspiers | kashyap: but no rush, I will wait patiently ;-) thanks again! | 10:37 |
| stephenfin | sean-k-mooney: If you want, go for it. I'm reviewing ralonsoh's native OVSDB patch atm | 10:37 |
| kashyap | aspiers: Right. One more (couldn't resist), on getDomainCapabilities(), I mentioned it in this WIP spec too (for OVMF): https://review.openstack.org/#/c/506720/6/specs/rocky/approved/ovmf-with-secure-boot-and-smm.rst | 10:37 |
| * kashyap crawls back to his cave; bbiab | 10:37 | |
| aspiers | :) | 10:38 |
| sean-k-mooney | stephenfin: ok, cool let me know if you want me to respin the py3-functional patches. we might leave the +w of rodolfos change to jaypies | 10:38 |
| sean-k-mooney | *to jaypipes | 10:38 |
| *** _fragatina has joined #openstack-nova | 10:39 | |
| stephenfin | yup, that's that my plan | 10:39 |
| *** erlon has joined #openstack-nova | 10:48 | |
| stephenfin | sean-k-mooney: Oh yeah, and no need to respin, though a follow-up would be nice | 10:52 |
| *** zhubx has joined #openstack-nova | 10:54 | |
| *** dcdawg has joined #openstack-nova | 10:59 | |
| *** yaawang has joined #openstack-nova | 11:04 | |
| *** efoley has quit IRC | 11:06 | |
| *** efoley has joined #openstack-nova | 11:06 | |
| *** ttsiouts has quit IRC | 11:07 | |
| *** ttsiouts has joined #openstack-nova | 11:08 | |
| *** ttsiouts has quit IRC | 11:12 | |
| sean-k-mooney | stephenfin: by the way the reason im making the vscode change is so i can run the functional test under a debugger by addign a break piont and clicking on just the test i want to run :) | 11:16 |
| sean-k-mooney | so vim,emacs,nano is fine too and i use them form most of my work but having a real debugger makes writing new tests and validteing them much simpler | 11:18 |
| sean-k-mooney | i have done this in the past with nova but its on my todo list to set it up again and then document it in the nova docs | 11:18 |
| openstackgerrit | Yury Kulazhenkov proposed openstack/nova master: remove deprecated os_brick import from ScaleIO driver https://review.openstack.org/638592 | 11:25 |
| *** udesale has quit IRC | 11:29 | |
| *** zhubx has quit IRC | 11:30 | |
| *** zhubx has joined #openstack-nova | 11:30 | |
| *** ratailor has quit IRC | 11:31 | |
| *** dpawlik has joined #openstack-nova | 11:37 | |
| *** tbachman has quit IRC | 11:39 | |
| *** IvensZambrano has quit IRC | 11:40 | |
| *** psachin has quit IRC | 11:40 | |
| *** IvensZambrano has joined #openstack-nova | 11:41 | |
| *** wolverineav has joined #openstack-nova | 11:41 | |
| *** wolverineav has quit IRC | 11:46 | |
| *** ccamacho has quit IRC | 11:50 | |
| sean-k-mooney | stephenfin: im going to resping the last sriov migration patch. adrianc didnt cherry pick my v14 change so im going to do that and then check if anything else form your comments still needs to be fixed. | 11:51 |
| *** efoley has quit IRC | 11:53 | |
| *** efoley has joined #openstack-nova | 11:53 | |
| *** Luzi has quit IRC | 11:54 | |
| *** Luzi has joined #openstack-nova | 11:55 | |
| *** IvensZambrano has quit IRC | 12:00 | |
| *** IvensZambrano has joined #openstack-nova | 12:01 | |
| *** ttsiouts has joined #openstack-nova | 12:08 | |
| *** ccamacho has joined #openstack-nova | 12:12 | |
| *** janki has joined #openstack-nova | 12:14 | |
| *** jchhatbar has quit IRC | 12:15 | |
| frickler | sean-k-mooney: regarding your comment on https://bugs.launchpad.net/bugs/1801919, we don't use "Fix Committed" anymore, see also https://docs.openstack.org/project-team-guide/bugs.html , though I don't remember the exact reasoning. but it has been this way for a couple of years now I think | 12:15 |
| openstack | Launchpad bug 1801919 in devstack "brctl is obsolete use ip" [Undecided,In progress] - Assigned to Nate Johnston (nate-johnston) | 12:15 |
| sean-k-mooney | frickler: that is quite missleading for a casual on looker | 12:15 |
| sean-k-mooney | frickler: if we were to drop one of the two i woudl have dropped fix released | 12:16 |
| frickler | sean-k-mooney: I think it doesn't work that way round, because the bug then would still show up as open in lp | 12:17 |
| sean-k-mooney | frickler: i have had people email me in the past about bug that were marked as fix released when they were not | 12:17 |
| sean-k-mooney | frickler: they should still show up as open | 12:18 |
| *** phasespace has joined #openstack-nova | 12:18 | |
| sean-k-mooney | the reason i recived email before were because people were trying to deploy with the latest release and they were still hitting the bug because the isse was merged on master be we had not done a release | 12:18 |
| sean-k-mooney | frickler: anyway if its not used anymore ill stop setting it but i thinik the current useage is flawed | 12:20 |
| *** zhubx has quit IRC | 12:21 | |
| phasespace | when running "openstack hypervisor list", where does it retrieve the hostname of the hypervisor from? Is it stored in a particular table? | 12:21 |
| frickler | sean-k-mooney: probably the release team would be to correct addressee if you wanted to continued that discussion, I'm just the messenger ;) | 12:21 |
| *** zhubx has joined #openstack-nova | 12:21 | |
| sean-k-mooney | frickler: i might raise it at the fourm/ptg. it just makes my life harder to determin if things are fixed upstream or not when determining if we need to backport things downstream or not | 12:22 |
| sean-k-mooney | frickler: thanks for letting me know | 12:23 |
| sean-k-mooney | frickler: we proably need to add a new status to storyboard too by the looks of it as it does not track the released status either | 12:23 |
| adrianc | sean-k-mooney: sorry for that, i didnt notice i was working on an older PS for the auto detach/attach of the sriov port commit | 12:23 |
| sean-k-mooney | that said a tag could work too | 12:24 |
| *** janki has quit IRC | 12:24 | |
| sean-k-mooney | adrianc: no worries | 12:24 |
| sean-k-mooney | adrianc: just fixing it up now | 12:24 |
| adrianc | thx ! | 12:24 |
| *** janki has joined #openstack-nova | 12:24 | |
| sean-k-mooney | adrianc: by the way did you see that https://review.openstack.org/#/c/620123/ was being blocked by https://review.openstack.org/#/c/639074/ | 12:25 |
| *** mrjk__ has joined #openstack-nova | 12:26 | |
| sean-k-mooney | ill kick off a recheck now that it has merged | 12:26 |
| *** snevi has joined #openstack-nova | 12:26 | |
| adrianc | yea, saw you mentioning that in the neutron IRC | 12:26 |
| adrianc | was waiting for this to get pushed :) as it will conclude the neutron change for SR-IOV live migration | 12:27 |
| *** logan_ has joined #openstack-nova | 12:27 | |
| *** logan_ is now known as Guest11647 | 12:28 | |
| *** janki has quit IRC | 12:29 | |
| sean-k-mooney | adrianc: ya so the recheck should be running now. you might need to rebase but it sould just do a merge with master and pick up the change | 12:29 |
| *** beekneemech has joined #openstack-nova | 12:29 | |
| *** _pewp_ has quit IRC | 12:30 | |
| *** gouthamr has quit IRC | 12:30 | |
| *** ondrejme has quit IRC | 12:30 | |
| *** NewBruce4 has quit IRC | 12:30 | |
| *** rnoriega has quit IRC | 12:30 | |
| *** mrjk_ has quit IRC | 12:30 | |
| *** mvkr has quit IRC | 12:30 | |
| *** Kunpeng has quit IRC | 12:30 | |
| *** kaisers has quit IRC | 12:30 | |
| *** Gaasmann has quit IRC | 12:30 | |
| *** IvensZambrano has quit IRC | 12:30 | |
| *** dpawlik has quit IRC | 12:30 | |
| *** owalsh has quit IRC | 12:30 | |
| *** jlvillal has quit IRC | 12:30 | |
| *** cdent has quit IRC | 12:30 | |
| *** dosaboy has quit IRC | 12:30 | |
| *** zzzeek has quit IRC | 12:30 | |
| *** ralonsoh has quit IRC | 12:30 | |
| *** logan- has quit IRC | 12:30 | |
| *** mgariepy has quit IRC | 12:30 | |
| *** cfriesen has quit IRC | 12:30 | |
| *** kashyap has quit IRC | 12:30 | |
| *** bnemec has quit IRC | 12:30 | |
| *** openstackgerrit has quit IRC | 12:30 | |
| *** _pewp_ has joined #openstack-nova | 12:31 | |
| *** owalsh_ has joined #openstack-nova | 12:31 | |
| *** dpawlik has joined #openstack-nova | 12:31 | |
| *** zzzeek has joined #openstack-nova | 12:31 | |
| *** mvkr has joined #openstack-nova | 12:31 | |
| *** rnoriega has joined #openstack-nova | 12:31 | |
| *** Guest11647 is now known as logan- | 12:31 | |
| *** jlvillal has joined #openstack-nova | 12:31 | |
| *** kaisers has joined #openstack-nova | 12:32 | |
| *** gouthamr has joined #openstack-nova | 12:33 | |
| *** markvoelker has joined #openstack-nova | 12:33 | |
| adrianc | ack ill keep an eye on it sean-k-mooney | 12:34 |
| *** dcdawg has quit IRC | 12:34 | |
| *** yaawang has quit IRC | 12:36 | |
| *** ralonsoh has joined #openstack-nova | 12:36 | |
| *** yaawang has joined #openstack-nova | 12:37 | |
| *** ralonsoh has quit IRC | 12:41 | |
| *** ralonsoh has joined #openstack-nova | 12:42 | |
| *** _fragatina has quit IRC | 12:44 | |
| *** dpawlik has quit IRC | 12:50 | |
| *** mriedem has joined #openstack-nova | 12:50 | |
| *** ttsiouts has quit IRC | 12:51 | |
| *** alex_xu has quit IRC | 12:51 | |
| *** ttsiouts has joined #openstack-nova | 12:51 | |
| *** alex_xu has joined #openstack-nova | 12:52 | |
| *** ccamacho has quit IRC | 12:52 | |
| mriedem | tssurya: i added you to https://review.openstack.org/#/c/621474/ because we could return server group info for servers in a down cell but that hasn't been implemented in that change, just wondering what you think | 12:53 |
| mriedem | https://review.openstack.org/#/c/621474/23/nova/api/openstack/compute/views/servers.py@203 | 12:54 |
| *** tbachman has joined #openstack-nova | 12:54 | |
| *** ttsiouts has quit IRC | 12:56 | |
| bauzas | efried: when you're up, wanted to discuss with you about https://review.openstack.org/#/c/599208/15 | 12:56 |
| *** ttsiouts has joined #openstack-nova | 13:03 | |
| *** ccamacho has joined #openstack-nova | 13:05 | |
| tssurya | mriedem: looking | 13:05 |
| *** markvoelker has quit IRC | 13:06 | |
| *** kashyap has joined #openstack-nova | 13:08 | |
| aspiers | efried: thanks a lot for the helpful comments. New version up for review https://review.openstack.org/#/c/538498/17 | 13:09 |
| aspiers | looks like reviewbot is AWOL BTW? | 13:10 |
| tssurya | mriedem: its doable, and since we are doing a new microversion to add that we might as well include it into the partial response | 13:14 |
| *** sdake has joined #openstack-nova | 13:15 | |
| gmann | mriedem: do you know anything not backported/setup in live migration setup on devstack side for queens/pike ? | 13:16 |
| gmann | mriedem: i am trying to enable the tempest-multinode-full job for stable branch and all migration test fail - http://logs.openstack.org/92/623992/1/check/tempest-multinode-full/45ca539/testr_results.html.gz | 13:16 |
| gmann | work fine in rocky but fail in queens and pike | 13:16 |
| gmann | seems sudo/public key issue ? - http://logs.openstack.org/92/623992/1/check/tempest-multinode-full/45ca539/controller/logs/screen-n-cpu.txt.gz#_Feb_25_14_59_15_559635 | 13:18 |
| *** mgariepy has joined #openstack-nova | 13:18 | |
| *** dpawlik has joined #openstack-nova | 13:19 | |
| *** owalsh_ is now known as owalsh | 13:19 | |
| mriedem | gmann: i see that job is non-voting, so does it work otherwise for nova stable/queens changes? | 13:22 |
| kashyap | aspiers: You here? Okay, so I just read the scrollback you linked. (And skimmed the patches.) | 13:23 |
| gmann | mriedem: not yet as tempest restrict it to master only. | 13:23 |
| aspiers | kashyap: here but was just about to go for a run in the sun :) | 13:23 |
| kashyap | aspiers: Go for it. More important than staring at the screen. | 13:24 |
| aspiers | kashyap: hehe glad we agree on that! biab | 13:24 |
| kashyap | aspiers: Quick note is that let's not hardcode anything with: virConnectGetDomainCapabilities() | 13:24 |
| kashyap | (Because we'll use it for other purposes.) | 13:24 |
| gmann | mriedem: next question is should we make it enable and work for those stable branch or is it ok to run them from stable/rocky onwards ? | 13:24 |
| kashyap | But let's talk later. | 13:24 |
| aspiers | kashyap: you mean like hardcoding the arch or machine type? | 13:24 |
| aspiers | or emulatorbin? | 13:24 |
| mriedem | gmann: tempest-multinode-full or tempest-slow? that patch seems to be dealing with enabling tempest-slow on stable branches | 13:25 |
| gmann | mriedem: yes boih. | 13:25 |
| kashyap | aspiers: Machine type can _probably_ be hard-coded: as only Q35 supports it? | 13:25 |
| gmann | both | 13:25 |
| aspiers | kashyap: I was considering changing my patch so that the memoized _domaincaps is a dict of dicts mapping arch -> machine type -> caps XML | 13:25 |
| aspiers | or yeah, maybe just arch -> caps | 13:25 |
| mriedem | gmann: well we have the nova-live-migration job on stable so live migration must work | 13:25 |
| kashyap | aspiers: Yeah, meonized _domaincaps sounds like a good start to me; but I want to think this through a bit more. | 13:26 |
| aspiers | kashyap: emulatorbin can be obtained programmatically from the virConnectGetCapabilities() data we already have | 13:26 |
| kashyap | I haven't had time to soak into the details yet. But I just wanted to make a quick note that for Secure Boot, we'll be using the getDomainCapabilities() | 13:26 |
| aspiers | kashyap: it's already memoized, but only the results from a single API call | 13:26 |
| kashyap | aspiers: Yep | 13:27 |
| mriedem | gmann: i'm not sure what's going on with this http://logs.openstack.org/92/623992/1/check/tempest-multinode-full/45ca539/controller/logs/screen-n-cpu.txt.gz?level=TRACE#_Feb_25_14_57_07_488187 | 13:27 |
| aspiers | kashyap: yep, I commented on your q35 spec noting the potential for reuse | 13:27 |
| kashyap | aspiers: Also, on your `virsh` command from the scrollback, for non-Q35, I _do_ get "sev supported = no" on my Fedora-28: | 13:27 |
| kashyap | $> virsh domcapabilities --virttype kvm --emulatorbin /usr/bin/qemu-kvm --arch x86_64 --machine pc-i440fx-1.4 | grep "sev supported" <sev supported='no'/> | 13:27 |
| aspiers | that's what I would expect | 13:27 |
| kashyap | aspiers: Thanks; I need to re-spin it 'soon' | 13:27 |
| aspiers | :) | 13:27 |
| mriedem | gmann: ssh setup between the compute nodes must be messed up | 13:28 |
| aspiers | OK, back in ~1 hour | 13:28 |
| kashyap | Sure. | 13:28 |
| aspiers | maybe a bit more, since I'll also need lunch :) | 13:28 |
| aspiers | and it's *very* sunny here ... | 13:28 |
| kashyap | aspiers: I'm here for ~2-ish hours, then on flaky internet connections on trains | 13:28 |
| aspiers | kashyap: OK | 13:28 |
| aspiers | kashyap: BTW if you need more context / detail: https://specs.openstack.org/openstack/nova-specs/specs/stein/approved/amd-sev-libvirt-support.html | 13:28 |
| kashyap | But we're in the same timezone, we can work it out. | 13:28 |
| aspiers | ok cool | 13:29 |
| kashyap | aspiers: Yeah, I saw it whoosh by in the past; just didn't have time to dig into it. | 13:29 |
| kashyap | Thanks, though. | 13:29 |
| aspiers | yw, catch you soon! | 13:29 |
| *** agopi has quit IRC | 13:29 | |
| gmann | mriedem: yeah, - http://logs.openstack.org/92/623992/1/check/tempest-multinode-full/45ca539/controller/logs/screen-n-cpu.txt.gz#_Feb_25_14_59_15_559635 | 13:30 |
| *** cdent has joined #openstack-nova | 13:30 | |
| *** liuyulong has joined #openstack-nova | 13:30 | |
| mriedem | not sure what's going on there, would probably need to check the devstack code that sets up ssh between the nodes and see if there were any changes since queens | 13:31 |
| gmann | ok, checking that on devstack side. | 13:33 |
| mriedem | tssurya: yeah i agree | 13:35 |
| *** diga has joined #openstack-nova | 13:35 | |
| *** dtantsur is now known as dtantsur|afk | 13:38 | |
| *** liuyulong has quit IRC | 13:40 | |
| *** _hemna has joined #openstack-nova | 13:41 | |
| jaypipes | sean-k-mooney: morning. making final os-vif push. | 13:47 |
| sean-k-mooney | jaypipes: im going to update the help string on rodolfos ovsdb patch shortly to adress my own nit but otherwise it will be the same just and fyi | 13:49 |
| jaypipes | roger | 13:49 |
| tssurya | dansmith: good morning! would you have a look at the doc fix https://review.openstack.org/#/c/638173/ when you have time ? that's the only change left for the bp completion (and the openstack client changes..) | 13:49 |
| tssurya | thanks in advacne | 13:49 |
| tssurya | s/advacne/advance | 13:49 |
| frickler | sean-k-mooney: just noticed when neutron released b2: there will still be comments be added to a bug when a release is made containing a fix, so you still can verify where that fix is released, just not directly by looking at the bug status | 13:51 |
| *** dosaboy has joined #openstack-nova | 13:51 | |
| *** dave-mccowan has joined #openstack-nova | 13:53 | |
| *** _hemna has quit IRC | 13:54 | |
| *** agopi has joined #openstack-nova | 13:58 | |
| *** beekneemech is now known as bnemec | 13:59 | |
| *** mlavalle has joined #openstack-nova | 13:59 | |
| sean-k-mooney | ralonsoh: very minor change https://review.openstack.org/#/c/482226/56/vif_plug_ovs/ovs.py is that ok with you | 14:00 |
| *** liuyulong has joined #openstack-nova | 14:05 | |
| jaypipes | stephenfin: hi doc guru :) do you know the answer to my question in the review comment on https://review.openstack.org/#/c/637009/? | 14:11 |
| * stephenfin looks | 14:11 | |
| *** mdbooth has quit IRC | 14:12 | |
| stephenfin | jaypipes: The Sphinx docs suck. I'm trying to fix them but it's slow. That's referenced here though https://www.sphinx-doc.org/en/1.7/ext/example_google.html | 14:13 |
| stephenfin | Search for '#:' | 14:13 |
| ralonsoh | sean-k-mooney, sure! | 14:13 |
| stephenfin | We're not using that extension but the style is the same | 14:13 |
| efried | bauzas: pong https://review.openstack.org/#/c/599208/ | 14:14 |
| jaypipes | stephenfin: ah! it's a sphinx thing.. | 14:14 |
| stephenfin | Oh, here we go http://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#directive-autoattribute | 14:14 |
| jaypipes | sorry, totally missed that :( | 14:14 |
| stephenfin | "For module data members and class attributes, documentation can either be put into a comment with special formatting (using a #: to start the comment instead of just #), or in a docstring after the definition. " | 14:14 |
| jaypipes | I thought it was a pep thing. | 14:14 |
| stephenfin | Nah, Sphinx magic taken from epydoc, I'd suspect | 14:14 |
| stephenfin | Or Doxygen, maybe | 14:14 |
| jaypipes | once again I am schooled by the illustrious stephenfin. | 14:14 |
| * stephenfin blushes | 14:15 | |
| jangutter | stephenfin, jaypipes: "#:" before or """ after.... drat, I hate choices. | 14:15 |
| jaypipes | stephenfin: ty sir! | 14:15 |
| sean-k-mooney | jaypipes: i stopped questioning him on docs stuff a while ago. after 2 or 3 times it just gets embarassing when he is always right about my questions | 14:15 |
| jaypipes | sean-k-mooney: oh, I definitely don't question his answers :) I just ask away and trust. | 14:16 |
| stephenfin | On a totally unrelated note, has anyone tried to read the argparse source? Oh boy | 14:16 |
| * stephenfin was hoping https://bugs.python.org/issue9338 would be an easy fix. Narp. | 14:17 | |
| jaypipes | stephenfin: better or worse than ConfigParser? :) | 14:17 |
| zhubx | can someone give some suggestions for https://review.openstack.org/#/c/638080/ a bug fix. thanks | 14:18 |
| stephenfin | Oh, that's bad, but this is worse :) | 14:18 |
| stephenfin | (for reference, we can't do live-migration without a destination in openstackclient until that's fixed https://review.openstack.org/#/c/626949/) | 14:19 |
| stephenfin | or we rewrite argparse | 14:19 |
| sean-k-mooney | stephenfin: why because it does not allow the host to be optional? | 14:20 |
| kashyap | zhubx: I agree with Matt Boot there. To avoid format detection, *always* explicitly specify the backing file format. | 14:20 |
| sean-k-mooney | i assume you cant register an arge to optional take a paramater | 14:20 |
| kashyap | zhubx: IOW, if you know the format, explicitly specify it | 14:21 |
| * kashyap goes to add comment in the bug | 14:21 | |
| bauzas | efried: nvm, working on the functest you asked | 14:21 |
| bauzas | it will be a FUP | 14:21 |
| bauzas | given you already +2d | 14:21 |
| *** sdake has quit IRC | 14:21 | |
| *** _hemna has joined #openstack-nova | 14:22 | |
| efried | bauzas: roger that. I'll be happy to +2 once I see that test. | 14:23 |
| stephenfin | sean-k-mooney: Not quite | 14:23 |
| yonglihe | alex_xu, jaypipes, i update topology API , so it's not depending on the server_group API: https://review.openstack.org/#/c/621476/ | 14:24 |
| stephenfin | sean-k-mooney: You can say an optional parameter may or may not take an option, but if you also have a positional argument, it gets swallowed by the optional parameter regardless | 14:24 |
| *** mrch_ has joined #openstack-nova | 14:24 | |
| sean-k-mooney | ah and the instnace we are migratin is a postional arg and that gets eaten by --live | 14:25 |
| stephenfin | 'zactly | 14:25 |
| stephenfin | Only way to work around it is to add '--', but that breaks everyone | 14:26 |
| stephenfin | So we need to fix argparse then vendor it til until if/when it's fixed upstream | 14:26 |
| sean-k-mooney | that or add a --live-migrate as an alternitve to --live when you want to hit the schduler | 14:26 |
| stephenfin | that would be more practical but not as pretty :) | 14:27 |
| *** ivve has quit IRC | 14:27 | |
| jaypipes | yonglihe: ack. I'll add that to my review queue. | 14:27 |
| *** mrch has quit IRC | 14:28 | |
| *** phasespace has quit IRC | 14:29 | |
| dansmith | tssurya: at first glance, stephenfin's grammar nits are things I would have complained about.. can you fix those real quick and I'll just +2+W (after I review) if everything else looks good? | 14:30 |
| dansmith | or I could just do it I guess | 14:31 |
| yonglihe | thanks, | 14:31 |
| jaypipes | stephenfin: the Sarlacc pit beckons. I'll let you nudge https://review.openstack.org/#/c/482226/ off the skiff. | 14:32 |
| *** sdake has joined #openstack-nova | 14:33 | |
| efried | jaypipes clearly hasn't seen the movie | 14:34 |
| *** dave-mccowan has quit IRC | 14:34 | |
| *** tbachman has quit IRC | 14:35 | |
| jaypipes | efried: I have. I just choose to forge a very different plotline in my head. | 14:35 |
| *** tstrul has joined #openstack-nova | 14:35 | |
| efried | jaypipes: you mean one where that whiny brat Luke gets his just desserts? | 14:35 |
| jaypipes | efried: yes. and the Sarlacc itself gets a nice dessert in the desert. | 14:36 |
| efried | well played sir. well played | 14:36 |
| stephenfin | ralonsoh, sean-k-mooney: Quick one: you've marked this as done but I assume you're replying to me, and sean-k-mooney's comment is void because of his second comment? https://review.openstack.org/#/c/482226/54/vif_plug_ovs/ovs.py@60 | 14:39 |
| sean-k-mooney | stephenfin: i fixed my nit in the help sting in v56 | 14:40 |
| sean-k-mooney | so yes i assumed that ralonsoh was replying to you | 14:40 |
| *** lbragstad has joined #openstack-nova | 14:40 | |
| ralonsoh | stephenfin, yes, this "Done" was for you. ovsdb_connection must have a value | 14:40 |
| stephenfin | Gotcha | 14:40 |
| stephenfin | +W'd \o/ | 14:40 |
| *** mrjk__ has quit IRC | 14:41 | |
| *** mrjk has joined #openstack-nova | 14:41 | |
| tssurya | dansmith: sure thing I'll correct those nits | 14:42 |
| dansmith | tssurya: hang on I have a couple other things I'm adding | 14:42 |
| tssurya | ah ok | 14:42 |
| mriedem | heh i just addressed them | 14:43 |
| *** tstrul has quit IRC | 14:43 | |
| * mriedem goes back to cave | 14:43 | |
| tssurya | :) | 14:43 |
| *** awalende has quit IRC | 14:45 | |
| *** awalende has joined #openstack-nova | 14:46 | |
| dansmith | tssurya: mriedem just published my comments | 14:46 |
| *** eharney has joined #openstack-nova | 14:46 | |
| tssurya | dansmith: thanks, on it | 14:47 |
| dansmith | I'm standing by with my +2 finger | 14:47 |
| * efried stfu | 14:50 | |
| *** awalende has quit IRC | 14:51 | |
| *** mdbooth has joined #openstack-nova | 14:54 | |
| *** sdake has quit IRC | 14:55 | |
| *** _hemna has quit IRC | 14:55 | |
| *** awaugama has joined #openstack-nova | 14:57 | |
| *** sdake has joined #openstack-nova | 15:00 | |
| *** hongbin has joined #openstack-nova | 15:03 | |
| *** markvoelker has joined #openstack-nova | 15:07 | |
| *** ttsiouts has quit IRC | 15:13 | |
| *** eharney has quit IRC | 15:13 | |
| *** ttsiouts has joined #openstack-nova | 15:13 | |
| *** spatel has joined #openstack-nova | 15:14 | |
| spatel | sean-k-mooney: morning | 15:14 |
| sean-k-mooney | spatel: o/ | 15:14 |
| spatel | sean-k-mooney: do you have experience with cellv2 deployment? | 15:14 |
| *** eharney has joined #openstack-nova | 15:15 | |
| sean-k-mooney | spatel: dansmith is the expert but a little | 15:15 |
| spatel | i have 150 new compute nodes waiting ready to go and i am just trying to think i of how to scale my cloud | 15:15 |
| sean-k-mooney | spatel: mainly due to the fact all deployments are cellv2 deplpyment of one cell | 15:15 |
| sean-k-mooney | spatel: you are considering if you should add another cell or not | 15:16 |
| spatel | How difficult its going to be in running production cloud migrate over Cellv2? | 15:16 |
| spatel | currently i have 200 compute nodes in production (in-used) 150 in racks waiting to join cloud | 15:16 |
| *** Luzi has quit IRC | 15:17 | |
| sean-k-mooney | what release are you running again? | 15:17 |
| spatel | soon my cloud will be 350 ( I think my current controller can handle that but at some point i have to think big ) | 15:17 |
| spatel | queens | 15:17 |
| *** ttsiouts has quit IRC | 15:18 | |
| sean-k-mooney | spatel: you can handel 500-1000 nodes in a singel cell without too much issue the rabbitmq message bus will be the first bottelneck in the system you will hit. cells of 200 nodes would be fine but you could easily run the 350 nodes you plan to have in the short term in one cell | 15:19 |
| spatel | hmm! currently my rabbitmq rate is 250 mesg/s around :) | 15:20 |
| *** gbarros has joined #openstack-nova | 15:20 | |
| dansmith | mriedem: stephenfin: wanna hit this again or should I just +W for you? https://review.openstack.org/#/c/638173 | 15:20 |
| sean-k-mooney | spatel: you do not have a dynmaic cloud e.g. you dont spawn/kill/migrate instnaces requently for you voip usecases if i understand correctly | 15:21 |
| sean-k-mooney | spatel: you are also not using celomiter so you have less pressure on the message bus | 15:21 |
| spatel | Yes, you are right | 15:21 |
| sean-k-mooney | spatel: in a public cloud env the message bus trafffic is higher | 15:22 |
| spatel | This is my private cloud for my customer.. very few activity so far | 15:22 |
| *** cfriesen has joined #openstack-nova | 15:22 | |
| spatel | I am not using celomiter :) | 15:22 |
| sean-k-mooney | spatel: i think we swapped over to cellsv2 by default in pike | 15:22 |
| sean-k-mooney | dansmith: is ^ right | 15:22 |
| sean-k-mooney | spatel: dan had a talk on this a while back https://www.youtube.com/watch?v=o7jkqzORij8 | 15:23 |
| stephenfin | dansmith: Done, but I'd have been happy with you fast approving too | 15:23 |
| dansmith | sean-k-mooney: I don't really remember, but he's on queens anyway | 15:23 |
| dansmith | stephenfin: I figured, but I had non-grammar comments, so was just trying to be polite :) | 15:23 |
| cfriesen | mdbooth: I made the changes you suggested for https://review.openstack.org/#/c/616692/ I like the idea of adding proper unit tests for convert_image(), but maybe we can do that in T? | 15:23 |
| *** tbachman has joined #openstack-nova | 15:23 | |
| spatel | Yes i am on Queens | 15:24 |
| *** owalsh_ has joined #openstack-nova | 15:24 | |
| mriedem | i'm going to mark https://blueprints.launchpad.net/nova/+spec/handling-down-cell as complete | 15:24 |
| dansmith | mriedem: rock on | 15:24 |
| sean-k-mooney | spatel: so on quees you are already running cellsv2 | 15:24 |
| mriedem | also just figured out my volume attachment tracking issue with the cross-cell resize series and have it fixed, so that's nice | 15:24 |
| sean-k-mooney | so your coices are to expand your current cell or add a new cell for the new nodes | 15:24 |
| spatel | sean-k-mooney: when you say i am already running on cellsv2 ( what does that means, do i need to enable or made some change to create cellsv2? ) | 15:25 |
| *** owalsh has quit IRC | 15:25 | |
| cfriesen | mriedem: is the neutron-grenade-multinode failure here expected? https://review.openstack.org/#/c/616692/ | 15:26 |
| stephenfin | dansmith: Appreciated :) | 15:26 |
| *** yan0s has quit IRC | 15:26 | |
| *** gbarros has quit IRC | 15:26 | |
| *** owalsh_ is now known as owalsh | 15:26 | |
| mriedem | http://logs.openstack.org/92/616692/20/check/neutron-grenade-multinode/ac5746b/logs/grenade.sh.txt.gz#_2019-02-26_00_36_45_216 | 15:26 |
| spatel | Watching youtube... dansmith, looking good you was in Boston man!! :) I am in boston.. | 15:26 |
| *** mchlumsky has joined #openstack-nova | 15:27 | |
| mriedem | cfriesen: known issue http://status.openstack.org/elastic-recheck/#1463631 | 15:27 |
| sean-k-mooney | spatel: all openstack deplopyment form queens/pike timeframe default to using cellsv2 with cellsv1 cells were optional. for cells v2 that was changed so all recent opensatack deployment are deploy using cellsv2 | 15:27 |
| sean-k-mooney | spatel: so what that means is in the db you have an api db and 2 cell dbs | 15:28 |
| mriedem | *ocata | 15:28 |
| sean-k-mooney | cell0 is special, cell1 is where all your compute nodes are | 15:28 |
| *** gbarros has joined #openstack-nova | 15:29 | |
| mriedem | we do have docs for this... https://docs.openstack.org/nova/latest/user/cellsv2-layout.html | 15:29 |
| mriedem | https://docs.openstack.org/nova/latest/user/cells.html#cells-v2 | 15:29 |
| spatel | Reading... | 15:29 |
| sean-k-mooney | oh good point :) | 15:29 |
| mriedem | if those docs don't answer questions, then ask here | 15:30 |
| spatel | mriedem: let me understand basic concept of technology and then i will come back :) | 15:30 |
| spatel | Thanks sean-k-mooney & mriedem | 15:31 |
| sean-k-mooney | stephen do you mind if i add sphinx-autobuild to os-vif docs requirements? | 15:31 |
| stephenfin | autobuild? | 15:31 |
| stephenfin | sean-k-mooney: Oh, didn't know that was a thing. Doesn't it need to into global requirements if you do? | 15:32 |
| sean-k-mooney | if i install it then vs-codes ret extention can automatically run sphix to provide a live preview of the rst file you are editing | 15:32 |
| sean-k-mooney | am i dont think so | 15:32 |
| sean-k-mooney | but i can add it there too if we want | 15:32 |
| mdbooth | cfriesen: Will look, thanks. | 15:33 |
| stephenfin | Maybe ask on #openstack-requirements. If not, I don't mind. I assume you can't just install it on your system? | 15:33 |
| cfriesen | sean-k-mooney: the TPM code should be ready to take for a spin (without cold migration, hoping to do that today) | 15:33 |
| sean-k-mooney | i can but im writing up some dev docs on how to set up vs-code for development of os-vif | 15:34 |
| *** ttsiouts has joined #openstack-nova | 15:34 | |
| cfriesen | sean-k-mooney: no worries. you'll likely need a new os-traits release. | 15:34 |
| sean-k-mooney | stephenfin: for not i can just add a note to pip install it. | 15:34 |
| *** sapd1 has quit IRC | 15:35 | |
| stephenfin | sean-k-mooney: Yeah, it does feel like something that would be better off installed systemwide (like tox) | 15:35 |
| sean-k-mooney | not really | 15:35 |
| sean-k-mooney | you could but i try to avoid poluting my system with lots of random packages. | 15:36 |
| sean-k-mooney | its nicer to have it in the tox venv but its minor | 15:36 |
| cfriesen | incidentally, I've uploaded a new version of the flavor/image validation patch addressing alex_xu's comments. Would appreciate review as it's on a runway. | 15:37 |
| *** markvoelker has quit IRC | 15:37 | |
| mriedem | apparently someone doesn't know how to count https://etherpad.openstack.org/p/nova-runways-stein | 15:43 |
| cfriesen | mriedem: I'm talking about the top one in that list, with "jackding" associated with it. | 15:48 |
| *** hongbin has quit IRC | 15:48 | |
| mriedem | yeah the show topology one was added to the current runways, i fixed it | 15:50 |
| cfriesen | ah, okay. I couldn't figure out what the problem was. :) | 15:51 |
| *** ccamacho has quit IRC | 15:51 | |
| *** ccamacho has joined #openstack-nova | 15:55 | |
| *** sdake has quit IRC | 15:59 | |
| *** tbachman has quit IRC | 16:00 | |
| *** sdake has joined #openstack-nova | 16:02 | |
| *** sdake has quit IRC | 16:02 | |
| *** macza has joined #openstack-nova | 16:08 | |
| *** tssurya has quit IRC | 16:09 | |
| *** gbarros has quit IRC | 16:10 | |
| *** dpawlik has quit IRC | 16:11 | |
| sean-k-mooney | stephenfin: actully auto build is not needed. | 16:12 |
| sean-k-mooney | well it is if you are using sphix specifc stuff | 16:12 |
| *** openstackgerrit has joined #openstack-nova | 16:15 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fup for the bandwidth series https://review.openstack.org/639159 | 16:15 |
| *** gbarros has joined #openstack-nova | 16:16 | |
| *** gbarros has quit IRC | 16:16 | |
| gibi | mriedem, jaypipes, efried: fixed the comments from the already merged patches ^^ | 16:17 |
| *** sdake has joined #openstack-nova | 16:18 | |
| mriedem | gibi: ok, did you see my comments on https://review.openstack.org/#/c/622421/ ? | 16:19 |
| mriedem | there were a lot but it's a big patch | 16:19 |
| gibi | mriedem: that is my next patch to look at | 16:19 |
| gibi | mriedem: do you want me to split out the report client change from https://review.openstack.org/#/c/622421/ ? | 16:20 |
| *** mrch_ has quit IRC | 16:20 | |
| *** belmoreira has quit IRC | 16:20 | |
| *** gbarros has joined #openstack-nova | 16:21 | |
| mriedem | gibi: up to you | 16:22 |
| mriedem | it might help move things along faster | 16:22 |
| gibi | mriedem: OK I will do it | 16:24 |
| *** itlinux has joined #openstack-nova | 16:25 | |
| *** sdake has quit IRC | 16:25 | |
| *** zhubx007 has joined #openstack-nova | 16:25 | |
| *** sdake has joined #openstack-nova | 16:26 | |
| *** zhubx has quit IRC | 16:28 | |
| gibi | mriedem: regarding leaking the port allocation if a port is detached in neutron | 16:29 |
| gibi | mriedem: is this a valid case that nova binds a port in neutron then the admin unbind it in the neturon API? | 16:29 |
| gibi | mriedem: I thought that if the nova bound it the nova needs to unbound it | 16:29 |
| gibi | mriedem: I can start looking at what to do when extrenal event comes if this is a valid use case | 16:30 |
| *** gbarros has quit IRC | 16:30 | |
| *** wwriverrat has joined #openstack-nova | 16:32 | |
| mriedem | gibi: neutron does not prevent it | 16:32 |
| mriedem | like cinder does | 16:32 |
| *** jmlowe has quit IRC | 16:32 | |
| *** pcaruana has quit IRC | 16:32 | |
| mriedem | i don't know how common that could be so i'd be ok with a todo for now to deal with it later. i assume it would only ever happen because something broke and an admin was fumbling around trying to fix things. | 16:32 |
| gibi | mriedem: OK, then I will add a TODO. | 16:34 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: modify functional base.py to allow using vscode https://review.openstack.org/638058 | 16:34 |
| *** wwriverrat has left #openstack-nova | 16:34 | |
| *** diga has quit IRC | 16:34 | |
| *** markvoelker has joined #openstack-nova | 16:35 | |
| *** sdake has quit IRC | 16:35 | |
| mriedem | i have no idea if neutron has policy rules in place to only allow certain users to update a port's device_id | 16:36 |
| mriedem | i know port binding attributes require admin | 16:36 |
| *** sdake has joined #openstack-nova | 16:36 | |
| *** zhubx007 has quit IRC | 16:36 | |
| *** zhubx007 has joined #openstack-nova | 16:37 | |
| gibi | mriedem: I will check with the neutron guys in my team | 16:37 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Fix the leak in the cross-cell revert resize code https://review.openstack.org/638314 | 16:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.openstack.org/639382 | 16:40 |
| *** sdake has quit IRC | 16:40 | |
| *** sdake_ has joined #openstack-nova | 16:41 | |
| *** sdake_ has quit IRC | 16:45 | |
| *** sdake has joined #openstack-nova | 16:45 | |
| openstackgerrit | Merged openstack/os-vif master: docs: Add API docs for profile, datapath offload types https://review.openstack.org/638395 | 16:45 |
| *** tbachman has joined #openstack-nova | 16:46 | |
| *** dcdawg has joined #openstack-nova | 16:49 | |
| *** sdake has quit IRC | 16:50 | |
| *** _hemna has joined #openstack-nova | 16:52 | |
| sean-k-mooney | jaypipes: stephenfin im planning on working on working on some os-vif gate jobs after stien feature freeze. would you object to me skipping the tempest jobs in os-vif if the change is only affecting the docs directory. | 16:52 |
| *** _fragatina has joined #openstack-nova | 16:52 | |
| *** sdake has joined #openstack-nova | 16:53 | |
| sean-k-mooney | the other tox jobs are quick but if it is a docs only change ore release not only change tempest adds little vlaue | 16:54 |
| stephenfin | fine by me | 16:55 |
| *** helenafm has quit IRC | 16:58 | |
| *** ttsiouts has quit IRC | 16:59 | |
| *** ttsiouts has joined #openstack-nova | 17:00 | |
| *** wolverineav has joined #openstack-nova | 17:00 | |
| *** sdake has quit IRC | 17:00 | |
| *** ccamacho has quit IRC | 17:01 | |
| *** sdake_ has joined #openstack-nova | 17:02 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/pike: DNM: For testing only https://review.openstack.org/620592 | 17:04 |
| *** ttsiouts has quit IRC | 17:05 | |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 17:06 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 17:06 |
| *** markvoelker has quit IRC | 17:07 | |
| *** _fragatina has quit IRC | 17:08 | |
| *** _fragatina has joined #openstack-nova | 17:10 | |
| *** itlinux_ has joined #openstack-nova | 17:10 | |
| gibi | mriedem: fyi. If I delete a bound port then nova gets notification from neutron, but If I just update the device_id and device_owner field of the port then nova does not get notification | 17:10 |
| *** gyee has joined #openstack-nova | 17:13 | |
| *** itlinux has quit IRC | 17:13 | |
| openstackgerrit | Merged openstack/nova master: Dump config options on wsgi startup earlier https://review.openstack.org/638691 | 17:16 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | 17:21 |
| *** tbachman_ has joined #openstack-nova | 17:21 | |
| *** imacdonn_ is now known as imacdonn | 17:22 | |
| *** tbachman has quit IRC | 17:23 | |
| jaypipes | sean-k-mooney: +1 to skip func tests if change in docs dir | 17:26 |
| *** _hemna has quit IRC | 17:26 | |
| *** tbachman_ has quit IRC | 17:26 | |
| *** tbachman has joined #openstack-nova | 17:28 | |
| *** dcdawg has quit IRC | 17:29 | |
| *** mrch_ has joined #openstack-nova | 17:31 | |
| mriedem | gibi: hmm ok so i guess we have to handle the network-vif-deleted event right? | 17:33 |
| *** _alastor_ has quit IRC | 17:35 | |
| openstackgerrit | Merged openstack/nova master: [Doc] Best practices for effectively tolerating down cells https://review.openstack.org/638173 | 17:36 |
| *** _alastor_ has joined #openstack-nova | 17:36 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [Broken WIP] Split external events handling into 2 steps https://review.openstack.org/639396 | 17:37 |
| *** spatel has quit IRC | 17:38 | |
| *** jmlowe has joined #openstack-nova | 17:40 | |
| *** tbachman has quit IRC | 17:45 | |
| *** tbachman has joined #openstack-nova | 17:46 | |
| artom | dansmith, so, you've just made me have an epiphany | 17:48 |
| artom | I thought the claims would provide extra checking that the instance will fit | 17:48 |
| artom | But no, the scheduler already does that | 17:48 |
| artom | If the scheduler accepted a host, the claim will work. | 17:48 |
| artom | The problem is that we never updated the XML, not that we allowed unacceptable hosts | 17:49 |
| dansmith | artom: no, that's not true | 17:49 |
| artom | Unless the host was forced | 17:49 |
| artom | dansmith, no? | 17:49 |
| sean-k-mooney | well it does but only to the extent that it check that something else has not raced with you for resouce on that host | 17:49 |
| dansmith | artom: the scheduler may send you four instances that it thinks will fit into the last slot | 17:49 |
| sean-k-mooney | ya ^ | 17:49 |
| artom | Ah, that problem. | 17:49 |
| artom | OK, so my original reply that I'm writing stands. | 17:50 |
| dansmith | artom: since the scheduler does not reserve/lock/claim numa resources when it makes a decision, there's no context between decisions to make sure they don't overlap | 17:50 |
| artom | Lemme finish it up. | 17:50 |
| artom | Essentially, we need the claim to happen before driver.cclmad() | 17:50 |
| artom | dansmith, ok, replies in https://review.openstack.org/#/c/634828/28 | 17:51 |
| sean-k-mooney | cclmad -> check_can_live_migrate_at_destination? | 17:51 |
| artom | Yeah, at some point I need to shorten stuff | 17:52 |
| sean-k-mooney | artom: just dont do tha in the code... | 17:53 |
| *** _hemna has joined #openstack-nova | 17:53 | |
| artom | Hrmm, unless we do manager.cclmad() -> driver.cclmad() -> source.cclmas() -> put instance_numa_topology into migrate_data -> driver.cclmad() returns -> manager checks for presence of instance_numa_topology -> claims -> driver.new_method_that_returns_NUMAMIgrateData | 17:53 |
| dansmith | artom: isn't that what I suggested? | 17:54 |
| artom | dansmith, I hadn't groked that last new_method part | 17:54 |
| artom | Then we'd have some instance live migrating with a claim and migration_context, and some without | 17:55 |
| artom | Is that acceptable? | 17:55 |
| artom | Or do we still do the claim regardless, and just call that new_NUMAMigrateData method conditionally? | 17:56 |
| dansmith | well, I was going to ask somewhere else about this.. it's unfortunate to have a bunch of new hosts that don't do claims until all the hosts are upgraded and then you've migrated everything around one step to the left | 17:57 |
| dansmith | but, obviously if you need the source to do the pin config in the xml, it's tough | 17:57 |
| dansmith | but yeah, I think you always call the new method, and that method does the claim iff the source indicated during its pre-check that it's going to do the xml manip for you | 17:58 |
| dansmith | instead of you doing it before you called to the host based on educated guessing | 17:58 |
| artom | dansmith, ok, and that's a nicely elegant solution to the upgrades problem | 17:59 |
| * artom gets on that | 17:59 | |
| dansmith | s'mah point | 17:59 |
| artom | You know, a gracious "thank you" would have been even better ;) | 18:00 |
| dansmith | GAWD | 18:00 |
| artom | Who do you think you are, Han Solo? With your "I know"s | 18:00 |
| artom | :D | 18:00 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 18:00 |
| dansmith | I'm going to assume that is a very impressive deep reference that, if I got it, would be hilarious | 18:01 |
| artom | I'm secure in my references and don't need no validation | 18:01 |
| artom | (Unlike in my code) | 18:01 |
| dansmith | heh | 18:02 |
| *** wolverineav has quit IRC | 18:02 | |
| *** wolverineav has joined #openstack-nova | 18:03 | |
| *** wolverineav has quit IRC | 18:03 | |
| mriedem | it's when leia tells han she loves him | 18:05 |
| mriedem | duh | 18:05 |
| mriedem | or wait, the other way around? | 18:05 |
| *** spatel has joined #openstack-nova | 18:05 | |
| * mriedem takes the afternoon off to watch star wars | 18:05 | |
| dansmith | mriedem: so artom is leia and I'm solo? I'm okay with that I guess. | 18:06 |
| artom | That backfired slightly | 18:06 |
| mriedem | according to this tshirt, yes https://www.amazon.com/Star-Wars-Shirt-Medium-Heather/dp/B078Z1Z1BG/ref=asc_df_B078Z1Z1BG/?tag=hyprod-20&linkCode=df0&hvadid=319000730304&hvpos=1o1&hvnetw=g&hvrand=18017460218835467438&hvpone=&hvptwo=&hvqmt=&hvdev=c&hvdvcmdl=&hvlocint=&hvlocphy=1020048&hvtargid=pla-659942629837&psc=1 | 18:06 |
| artom | (Nothing against Leia, she's badass - but the implication is that I, err, yeah) | 18:06 |
| mriedem | dansmith is a scruffy looking nerf herder | 18:07 |
| artom | Nerd herder, even - reviewing all our codes | 18:07 |
| dansmith | we should maybe move on | 18:07 |
| *** itlinux_ has quit IRC | 18:13 | |
| *** itlinux has joined #openstack-nova | 18:17 | |
| *** wolverineav has joined #openstack-nova | 18:18 | |
| openstackgerrit | sean mooney proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | 18:22 |
| *** wolverineav has quit IRC | 18:22 | |
| *** wolverineav has joined #openstack-nova | 18:22 | |
| *** wolverineav has quit IRC | 18:23 | |
| *** derekh has quit IRC | 18:25 | |
| *** wolverineav has joined #openstack-nova | 18:26 | |
| *** _hemna has quit IRC | 18:26 | |
| *** panda|ruck is now known as panda|ruck|off | 18:28 | |
| *** sdake_ has quit IRC | 18:30 | |
| *** sridharg has quit IRC | 18:30 | |
| *** sdake has joined #openstack-nova | 18:34 | |
| *** sdake has quit IRC | 18:35 | |
| *** sdake has joined #openstack-nova | 18:36 | |
| *** snevi has quit IRC | 18:42 | |
| *** sdake has quit IRC | 18:46 | |
| *** sdake_ has joined #openstack-nova | 18:48 | |
| *** _fragatina has quit IRC | 18:50 | |
| *** sdake_ has quit IRC | 18:50 | |
| *** Swami has joined #openstack-nova | 18:50 | |
| *** sdake has joined #openstack-nova | 18:51 | |
| *** sdake has quit IRC | 18:55 | |
| *** sdake_ has joined #openstack-nova | 18:55 | |
| *** sdake_ has quit IRC | 18:56 | |
| *** awaugama has quit IRC | 18:57 | |
| *** awaugama_ has joined #openstack-nova | 18:57 | |
| *** sdake has joined #openstack-nova | 18:58 | |
| aspiers | efried: I've pinned down the test failure to an interaction with test_pci_sriov_servers.SRIOVServersTest.test_create_server_with_pci_dev_and_numa_fails | 19:00 |
| aspiers | efried: investigating further now | 19:00 |
| *** sdake has quit IRC | 19:00 | |
| *** sdake_ has joined #openstack-nova | 19:00 | |
| *** wolverineav has quit IRC | 19:03 | |
| *** wolverineav has joined #openstack-nova | 19:04 | |
| *** markvoelker has joined #openstack-nova | 19:04 | |
| *** sdake_ has quit IRC | 19:06 | |
| *** sdake has joined #openstack-nova | 19:06 | |
| *** igordc has joined #openstack-nova | 19:08 | |
| *** sdake has quit IRC | 19:10 | |
| efried | aspiers: cool. And weird. wtf? | 19:11 |
| efried | probably some closure somewhere. | 19:11 |
| aspiers | yeah, right :) | 19:11 |
| aspiers | haha | 19:11 |
| aspiers | probably my fault | 19:11 |
| efried | you try to do something nice... | 19:11 |
| *** sdake has joined #openstack-nova | 19:11 | |
| aspiers | I guess the other test is bringing in different traits, and they are hanging around | 19:11 |
| aspiers | although I thought each test would do sufficient teardown to avoid that | 19:12 |
| cfriesen | sean-k-mooney: do you know if linux supports TPM 2.0 with CRB? | 19:12 |
| *** _alastor1 has joined #openstack-nova | 19:18 | |
| *** mchlumsky_ has joined #openstack-nova | 19:19 | |
| *** itlinux_ has joined #openstack-nova | 19:19 | |
| *** alex_xu has quit IRC | 19:20 | |
| *** sdake has quit IRC | 19:20 | |
| *** sdake_ has joined #openstack-nova | 19:20 | |
| *** _alastor_ has quit IRC | 19:20 | |
| *** gouthamr has quit IRC | 19:20 | |
| *** liuyulong has quit IRC | 19:20 | |
| *** gouthamr_ has joined #openstack-nova | 19:20 | |
| *** itlinux has quit IRC | 19:21 | |
| *** mchlumsky has quit IRC | 19:21 | |
| *** mriedem has quit IRC | 19:21 | |
| *** mvkr has quit IRC | 19:21 | |
| *** mvkr has joined #openstack-nova | 19:21 | |
| *** mriedem has joined #openstack-nova | 19:22 | |
| *** sdake_ has quit IRC | 19:25 | |
| cfriesen | Should nova verify whether helper utilities are present if they're needed by libvirt to provide a service? The alternative would be to fail at instance creation time. | 19:26 |
| cfriesen | (this is in the context of vTPM, I'm wondering if I should check whether "swtpm" is available before advertising TPM support in placement) | 19:27 |
| *** sdake has joined #openstack-nova | 19:27 | |
| *** sdake has quit IRC | 19:35 | |
| *** sdake_ has joined #openstack-nova | 19:35 | |
| *** ralonsoh has quit IRC | 19:36 | |
| mriedem | dansmith: do you happen to remember the thought process when adding the Migration.hidden attribute here? https://review.openstack.org/#/c/181110/ | 19:36 |
| mriedem | nothing ever actually sets that to True anywhere | 19:36 |
| dansmith | it was dubious, but yeah, | 19:36 |
| mriedem | but we expose it in the API | 19:36 |
| dansmith | when we started to expose live migrations as migrations, | 19:37 |
| dansmith | there was concern that operators may want to be able to hide the shuffling they do behind the scenes, | 19:37 |
| dansmith | so we added that for the future backlash | 19:37 |
| dansmith | not sure why we expose it in the api though, it's supposed to be a "do we display this in the api or not" flag | 19:37 |
| mriedem | hmm, but GET /os-migrations is admin-only anyway | 19:38 |
| *** markvoelker has quit IRC | 19:38 | |
| dansmith | by default | 19:38 |
| mriedem | sure | 19:38 |
| dansmith | just sayin' | 19:38 |
| dansmith | that was the reasoning | 19:38 |
| mriedem | anyway, it's come up in https://review.openstack.org/#/c/636224/ as an alternative to filtering duplicate migrations by updated_at | 19:39 |
| mriedem | because with cross-cell resize i'm hiding the instance using this instance.hidden field, and it would be pretty simple to do the same for migration.hidden, | 19:39 |
| mriedem | but i'd have to thnk about implications to that API | 19:39 |
| mriedem | especially because we have changes-since and changes-before filters on GET /os-migrations now too, so filtering duplicates based on updated_at is error prone | 19:40 |
| dansmith | yeah I mean, hiding them using that flag until you're ready for them to be seen is probably reasonable I would think | 19:42 |
| *** wolverineav has quit IRC | 19:42 | |
| *** sdake_ has quit IRC | 19:45 | |
| *** sdake has joined #openstack-nova | 19:47 | |
| mriedem | jaypipes: we should probably sort this out before yonglihe is back online http://lists.openstack.org/pipermail/openstack-discuss/2019-February/003166.html | 19:47 |
| sean-k-mooney | cfriesen: i am not sure. i woudl assume it is the operators responcibilty to install any helper functions needed | 19:48 |
| cfriesen | sean-k-mooney: I just put the check in...you can see what you think when I push the next iteration. It's unfortunate but I couldn't find a way to query libvirt itself about support. | 19:51 |
| *** itlinux_ has quit IRC | 19:52 | |
| *** efoley has quit IRC | 19:54 | |
| *** sdake has quit IRC | 19:55 | |
| *** itlinux has joined #openstack-nova | 19:56 | |
| *** sdake has joined #openstack-nova | 19:56 | |
| *** wolverineav has joined #openstack-nova | 19:56 | |
| *** derekh has joined #openstack-nova | 19:58 | |
| *** wolverineav has quit IRC | 20:01 | |
| *** sdake has quit IRC | 20:03 | |
| *** wolverineav has joined #openstack-nova | 20:04 | |
| *** wolverineav has quit IRC | 20:09 | |
| *** derekh has quit IRC | 20:09 | |
| *** Sundar has joined #openstack-nova | 20:14 | |
| jaypipes | mriedem: by "sort this out" I presume you mean that you convince me I'm wrong? :) | 20:14 |
| mriedem | not necessarily | 20:16 |
| mriedem | i understand your point | 20:16 |
| *** itlinux has quit IRC | 20:16 | |
| mriedem | i also remember server group 'policies' being only exactly ever one | 20:16 |
| mriedem | which seems pretty gross to me | 20:16 |
| mriedem | and writing code to use the server group api i always have to remember that little wart | 20:18 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 20:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.openstack.org/634827 | 20:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.openstack.org/634828 | 20:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.openstack.org/635229 | 20:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.openstack.org/634605 | 20:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP needs more tests] Full NUMA live migration support https://review.openstack.org/634606 | 20:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Make the use of the CastAsCall fixture configurable https://review.openstack.org/639428 | 20:20 |
| mriedem | not sure if edleafe or cdent (api sig) would have an opinion | 20:20 |
| *** itlinux has joined #openstack-nova | 20:20 | |
| *** mdbooth_ has joined #openstack-nova | 20:23 | |
| *** _hemna has joined #openstack-nova | 20:23 | |
| jaypipes | mriedem: well, having more than one policy for the same server group is bonkers. however, having an instance in more than one server group is, IMHO, *not* bonkers and is actually something we'd like to see at Oath. e.g. a user wants to add instances to two server groups, where server group one is a rack anti-affinity and server group two is a power-domain affinity, etc. | 20:26 |
| *** imacdonn has quit IRC | 20:26 | |
| *** mdbooth has quit IRC | 20:26 | |
| mriedem | lots of people over time have tried to add support for adding/removing servers to/from groups, and it's just been rejected every time, so i don't see it happening anytime soon | 20:28 |
| mriedem | i get the request | 20:28 |
| *** imacdonn has joined #openstack-nova | 20:28 | |
| jaypipes | mriedem: ack | 20:29 |
| jaypipes | mriedem: well, like you said, we can always mod the API in the future if ever we support >1 server group on boot. | 20:29 |
| jaypipes | mriedem: I'll relinquish | 20:29 |
| mriedem | up to you, i just know our existing server groups stuff is very flaky so adding support for >1 group would be a big deal | 20:30 |
| mriedem | which i just don't see happening anytime soon | 20:30 |
| jaypipes | ack | 20:32 |
| *** wolverineav has joined #openstack-nova | 20:37 | |
| *** awaugama_ has quit IRC | 20:38 | |
| *** gouthamr_ is now known as gouthamr | 20:42 | |
| *** wolverineav has quit IRC | 20:42 | |
| *** takamatsu_ has quit IRC | 20:48 | |
| *** jmlowe has quit IRC | 20:49 | |
| *** takamatsu_ has joined #openstack-nova | 20:50 | |
| *** _hemna has quit IRC | 20:57 | |
| *** itlinux has quit IRC | 20:59 | |
| *** erlon has quit IRC | 21:02 | |
| *** spsurya has quit IRC | 21:03 | |
| *** cdent has quit IRC | 21:05 | |
| *** cdent has joined #openstack-nova | 21:05 | |
| *** jmlowe has joined #openstack-nova | 21:06 | |
| *** itlinux has joined #openstack-nova | 21:07 | |
| *** tesseract has quit IRC | 21:09 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | 21:13 |
| cfriesen | sean-k-mooney: with this version ^ I can boot instances after setting the version/model in either flavor or image. | 21:13 |
| *** wolverineav has joined #openstack-nova | 21:21 | |
| *** wolverineav has quit IRC | 21:21 | |
| *** wolverineav has joined #openstack-nova | 21:21 | |
| *** manjeets_ has joined #openstack-nova | 21:22 | |
| *** manjeets has quit IRC | 21:24 | |
| *** derekh has joined #openstack-nova | 21:24 | |
| *** derekh has quit IRC | 21:24 | |
| *** eharney has quit IRC | 21:33 | |
| *** manjeets_ is now known as manjeets | 21:35 | |
| *** markvoelker has joined #openstack-nova | 21:35 | |
| *** eandersson_ is now known as eandersson | 21:40 | |
| *** whoami-rajat has quit IRC | 21:41 | |
| *** wolverineav has quit IRC | 21:46 | |
| *** wolverineav has joined #openstack-nova | 21:48 | |
| *** wolverineav has quit IRC | 21:48 | |
| *** wolverineav has joined #openstack-nova | 21:48 | |
| *** itlinux has quit IRC | 21:53 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 21:53 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.openstack.org/634827 | 21:53 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.openstack.org/634828 | 21:53 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.openstack.org/635229 | 21:53 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.openstack.org/634605 | 21:53 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Make the use of the CastAsCall fixture configurable https://review.openstack.org/639428 | 21:53 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP needs more tests] Full NUMA live migration support https://review.openstack.org/634606 | 21:53 |
| artom | ^^ actually pass my integration tests | 21:53 |
| * artom goes off to prepare supper | 21:53 | |
| openstackgerrit | Merged openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | 21:54 |
| *** ttsiouts has joined #openstack-nova | 21:56 | |
| *** cdent has quit IRC | 21:58 | |
| *** mchlumsky_ has quit IRC | 22:00 | |
| aspiers | efried: wow, turns out that testtools.assertItemsEqual is horribly misleading | 22:03 |
| aspiers | efried: I wasted about 5 hours before finding that | 22:03 |
| aspiers | it fails miserably when comparing unicode traits with string traits | 22:04 |
| *** itlinux has joined #openstack-nova | 22:04 | |
| *** rcernin has joined #openstack-nova | 22:05 | |
| *** wolverineav has quit IRC | 22:08 | |
| *** itlinux has quit IRC | 22:08 | |
| *** markvoelker has quit IRC | 22:09 | |
| *** wolverineav has joined #openstack-nova | 22:10 | |
| *** wolverineav has quit IRC | 22:14 | |
| *** ttsiouts has quit IRC | 22:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.openstack.org/639382 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.openstack.org/637605 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add finish_snapshot_based_resize_at_dest compute method https://review.openstack.org/635080 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.openstack.org/635646 | 22:16 |
| *** ttsiouts has joined #openstack-nova | 22:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.openstack.org/614035 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.openstack.org/635668 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.openstack.org/635684 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.openstack.org/636224 | 22:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.openstack.org/614037 | 22:16 |
| *** itlinux has joined #openstack-nova | 22:17 | |
| *** wolverineav has joined #openstack-nova | 22:17 | |
| mriedem | i feel robbed when i push up 33 changes but gerrritbot only shows 20 | 22:17 |
| aspiers | haha | 22:17 |
| aspiers | don't worry, stackalytics will get them all | 22:18 |
| *** slaweq has quit IRC | 22:18 | |
| *** ttsiouts has quit IRC | 22:21 | |
| efried | aspiers: wow. Any idea why that other test was interfering? | 22:24 |
| *** itlinux has quit IRC | 22:24 | |
| aspiers | efried: COMPUTE_VOLUME_MULTI_ATTACH is present when the SRIOV test is run first, I haven't figured out why yet | 22:25 |
| efried | yeah, that's weird. | 22:26 |
| aspiers | I was chasing completely the wrong trait thanks to testtools | 22:26 |
| *** slaweq has joined #openstack-nova | 22:26 | |
| *** itlinux has joined #openstack-nova | 22:26 | |
| *** sdake has joined #openstack-nova | 22:28 | |
| aspiers | efried: https://bugs.launchpad.net/testtools/+bug/1817800 | 22:28 |
| openstack | Launchpad bug 1817800 in testtools "assertItemsEqual output is misleading when comparing unicode with str" [Undecided,New] | 22:28 |
| *** ttsiouts has joined #openstack-nova | 22:28 | |
| mriedem | aspiers: is the driver.capabilities at the class or member level? | 22:29 |
| mriedem | for the LibvirtDriver? | 22:29 |
| mriedem | or FakeDriver - whatever you're using | 22:29 |
| aspiers | in this case it's at the class level, so yeah that would explain the lack of test isolation | 22:30 |
| aspiers | however https://review.openstack.org/#/c/638677/1 | 22:30 |
| mriedem | are your tests using the FakeDriver though? | 22:30 |
| *** slaweq has quit IRC | 22:30 | |
| aspiers | no | 22:30 |
| *** sdake has quit IRC | 22:30 | |
| aspiers | functional tests use libvirt driver | 22:30 |
| *** itlinux has quit IRC | 22:31 | |
| aspiers | (probably foolishly) I stacked that fix on top of your rebased capabilities-to-traits patch which is currently failing | 22:31 |
| aspiers | if I'd put it underneath, it would probably have fixed this | 22:31 |
| aspiers | let me try that now | 22:31 |
| *** sdake has joined #openstack-nova | 22:32 | |
| *** phasespace has joined #openstack-nova | 22:32 | |
| *** _fragatina has joined #openstack-nova | 22:40 | |
| *** sdake has quit IRC | 22:40 | |
| *** sdake_ has joined #openstack-nova | 22:41 | |
| aspiers | BOOM. Works! | 22:42 |
| *** slaweq has joined #openstack-nova | 22:44 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Change LibvirtDriver.capabilities to an instance variable https://review.openstack.org/638677 | 22:45 |
| *** sdake_ has quit IRC | 22:45 | |
| *** sdake has joined #openstack-nova | 22:46 | |
| *** slaweq has quit IRC | 22:49 | |
| *** itlinux has joined #openstack-nova | 22:50 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 22:52 |
| *** _hemna has joined #openstack-nova | 22:54 | |
| *** spatel has quit IRC | 22:54 | |
| *** sdake has quit IRC | 22:56 | |
| *** itlinux has quit IRC | 22:57 | |
| *** sdake has joined #openstack-nova | 22:58 | |
| *** agopi has quit IRC | 22:59 | |
| *** sdake has quit IRC | 23:00 | |
| *** tkajinam has joined #openstack-nova | 23:02 | |
| *** sdake has joined #openstack-nova | 23:02 | |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec https://review.openstack.org/570201 | 23:02 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0 https://review.openstack.org/570203 | 23:02 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state https://review.openstack.org/566473 | 23:03 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Allow rebuild for instances in PENDING state https://review.openstack.org/637585 | 23:03 |
| melwitt | jaypipes: thanks for the reviews :D nice point in patch 2, I replied. maybe I need to redo the whole thing with user_id as non-nullable, and try to populate it in _from_db_object (the way that queued_for_delete does). I began that way originally, but didn't think of using build request for the case where cell_id=NULL :( | 23:05 |
| *** sdake has quit IRC | 23:06 | |
| *** sdake_ has joined #openstack-nova | 23:06 | |
| *** sdake_ has quit IRC | 23:10 | |
| *** sdake has joined #openstack-nova | 23:11 | |
| *** zhubx007 has quit IRC | 23:14 | |
| *** zhubx has joined #openstack-nova | 23:14 | |
| *** _alastor_ has joined #openstack-nova | 23:15 | |
| *** _alastor_ has joined #openstack-nova | 23:15 | |
| *** _alastor1 has quit IRC | 23:16 | |
| *** dave-mccowan has joined #openstack-nova | 23:19 | |
| *** sdake has quit IRC | 23:20 | |
| *** sdake has joined #openstack-nova | 23:22 | |
| *** Sundar has quit IRC | 23:23 | |
| *** sdake has quit IRC | 23:25 | |
| *** sdake has joined #openstack-nova | 23:27 | |
| *** _hemna has quit IRC | 23:27 | |
| *** liuyulong has joined #openstack-nova | 23:30 | |
| *** sdake has quit IRC | 23:30 | |
| *** ttsiouts has quit IRC | 23:30 | |
| *** jdillaman has quit IRC | 23:31 | |
| *** ttsiouts has joined #openstack-nova | 23:31 | |
| *** sdake has joined #openstack-nova | 23:31 | |
| *** sapd1 has joined #openstack-nova | 23:33 | |
| *** sdake has quit IRC | 23:35 | |
| *** ttsiouts has quit IRC | 23:35 | |
| *** sdake has joined #openstack-nova | 23:37 | |
| *** sdake has quit IRC | 23:40 | |
| *** sdake has joined #openstack-nova | 23:42 | |
| *** Sundar has joined #openstack-nova | 23:45 | |
| melwitt | s/queued_for_delete does/BlockDeviceMapping.uuid does/ | 23:46 |
| *** sdake has quit IRC | 23:50 | |
| *** sdake has joined #openstack-nova | 23:51 | |
| *** Sundar has quit IRC | 23:54 | |
| *** sdake has quit IRC | 23:55 | |
| *** sdake has joined #openstack-nova | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!