| *** erlon has quit IRC | 00:00 | |
| *** tbachman has joined #openstack-nova | 00:04 | |
| *** ttsiouts has quit IRC | 00:04 | |
| *** ttsiouts has joined #openstack-nova | 00:05 | |
| *** markvoelker has quit IRC | 00:06 | |
| *** ttsiouts has quit IRC | 00:09 | |
| *** erlon has joined #openstack-nova | 00:27 | |
| *** tbachman has quit IRC | 00:29 | |
| *** sdake has joined #openstack-nova | 00:46 | |
| *** ileixe has joined #openstack-nova | 00:50 | |
| *** ircuser-1 has joined #openstack-nova | 00:58 | |
| *** _fragatina_ has quit IRC | 01:02 | |
| *** _fragatina has joined #openstack-nova | 01:02 | |
| *** sdake has quit IRC | 01:03 | |
| *** wolverineav has joined #openstack-nova | 01:06 | |
| *** sdake has joined #openstack-nova | 01:07 | |
| *** threestrands has joined #openstack-nova | 01:10 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add method to allow reset fields for root bdm in BDM obj https://review.openstack.org/614672 | 01:16 |
|---|---|---|
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | 01:17 |
| *** sdake has quit IRC | 01:19 | |
| *** dave-mccowan has joined #openstack-nova | 01:29 | |
| *** dave-mccowan has quit IRC | 01:35 | |
| *** tbachman has joined #openstack-nova | 01:35 | |
| *** threestrands has quit IRC | 01:35 | |
| *** wolverineav has quit IRC | 01:36 | |
| *** tiendc has joined #openstack-nova | 01:38 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce topology API https://review.openstack.org/621476 | 01:58 |
| yonglihe | mriedem: runway seems already got 3 items, i did not put https://review.openstack.org/#/c/621474/21 in the run way for now. | 02:00 |
| yonglihe | do i still allow to add more? | 02:02 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | 02:03 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | 02:07 |
| *** markvoelker has joined #openstack-nova | 02:07 | |
| *** igordc has quit IRC | 02:16 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:20 | |
| *** jbernard has quit IRC | 02:23 | |
| *** dave-mccowan has joined #openstack-nova | 02:23 | |
| *** jbernard has joined #openstack-nova | 02:25 | |
| *** yaawang has quit IRC | 02:33 | |
| *** markvoelker has quit IRC | 02:37 | |
| *** yaawang has joined #openstack-nova | 02:41 | |
| *** hongbin has joined #openstack-nova | 02:52 | |
| *** wolverineav has joined #openstack-nova | 02:53 | |
| *** dave-mccowan has quit IRC | 02:53 | |
| *** sdake has joined #openstack-nova | 03:02 | |
| *** wolverineav has quit IRC | 03:02 | |
| *** whoami-rajat has joined #openstack-nova | 03:12 | |
| *** hongbin has quit IRC | 03:30 | |
| *** markvoelker has joined #openstack-nova | 03:35 | |
| *** janki has joined #openstack-nova | 03:35 | |
| *** sdake has quit IRC | 03:36 | |
| *** sdake has joined #openstack-nova | 03:41 | |
| *** brault has joined #openstack-nova | 03:45 | |
| *** brault has quit IRC | 03:49 | |
| *** udesale has joined #openstack-nova | 03:51 | |
| *** sdake has quit IRC | 03:56 | |
| *** tbachman has quit IRC | 03:57 | |
| *** markvoelker has quit IRC | 04:03 | |
| *** wolverineav has joined #openstack-nova | 04:12 | |
| *** wolverineav has quit IRC | 04:17 | |
| *** udesale has quit IRC | 04:21 | |
| *** sdake has joined #openstack-nova | 04:21 | |
| *** macza has joined #openstack-nova | 04:22 | |
| *** udesale has joined #openstack-nova | 04:22 | |
| *** spsurya has joined #openstack-nova | 04:24 | |
| *** sdake has quit IRC | 04:25 | |
| *** sdake has joined #openstack-nova | 04:26 | |
| *** sdake has quit IRC | 04:30 | |
| *** sdake has joined #openstack-nova | 04:33 | |
| *** macza has quit IRC | 04:34 | |
| *** sdake has quit IRC | 04:35 | |
| *** sdake has joined #openstack-nova | 04:37 | |
| *** sdake has quit IRC | 04:40 | |
| *** sdake has joined #openstack-nova | 04:44 | |
| *** sdake has quit IRC | 04:45 | |
| *** ShilpaSD has joined #openstack-nova | 04:51 | |
| *** sdake has joined #openstack-nova | 04:51 | |
| *** sdake has quit IRC | 04:55 | |
| *** sdake has joined #openstack-nova | 04:58 | |
| *** tbachman has joined #openstack-nova | 04:58 | |
| *** sdake has quit IRC | 05:00 | |
| *** markvoelker has joined #openstack-nova | 05:00 | |
| *** sdake has joined #openstack-nova | 05:01 | |
| *** janki has quit IRC | 05:02 | |
| *** sdake_ has joined #openstack-nova | 05:10 | |
| *** sdake has quit IRC | 05:10 | |
| *** sdake_ has quit IRC | 05:15 | |
| *** sdake has joined #openstack-nova | 05:18 | |
| zhubx007 | Can anyone help to take a look at this https://review.openstack.org/#/c/638080/? Thanks. | 05:18 |
| *** sdake has quit IRC | 05:21 | |
| *** sdake has joined #openstack-nova | 05:22 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | 05:24 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Add online data migration for populating user_id https://review.openstack.org/633351 | 05:24 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 05:24 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 05:24 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 05:24 |
| *** sdake has quit IRC | 05:26 | |
| *** ratailor has joined #openstack-nova | 05:28 | |
| *** sdake has joined #openstack-nova | 05:28 | |
| *** bhagyashris has joined #openstack-nova | 05:29 | |
| *** sdake has quit IRC | 05:30 | |
| *** sdake_ has joined #openstack-nova | 05:32 | |
| *** markvoelker has quit IRC | 05:33 | |
| *** sdake_ has quit IRC | 05:35 | |
| *** sdake has joined #openstack-nova | 05:36 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Creating a flavor only supports the integer type https://review.openstack.org/639012 | 05:38 |
| *** macza has joined #openstack-nova | 05:39 | |
| *** macza has quit IRC | 05:43 | |
| *** yaawang has quit IRC | 05:45 | |
| *** sdake has quit IRC | 05:45 | |
| *** yaawang has joined #openstack-nova | 05:45 | |
| *** wolverineav has joined #openstack-nova | 05:47 | |
| *** Zhang has joined #openstack-nova | 05:48 | |
| *** wolverineav has quit IRC | 05:48 | |
| *** wolverineav has joined #openstack-nova | 05:48 | |
| *** sdake has joined #openstack-nova | 05:48 | |
| *** sdake has quit IRC | 05:51 | |
| *** sdake has joined #openstack-nova | 05:51 | |
| *** Zhang is now known as Kunpeng | 05:52 | |
| *** sdake has quit IRC | 05:55 | |
| *** tetsuro has joined #openstack-nova | 05:56 | |
| *** sdake has joined #openstack-nova | 05:57 | |
| *** sdake has quit IRC | 06:00 | |
| *** dpawlik has joined #openstack-nova | 06:01 | |
| *** sdake has joined #openstack-nova | 06:02 | |
| *** sdake has quit IRC | 06:06 | |
| *** sdake_ has joined #openstack-nova | 06:07 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce topology API https://review.openstack.org/621476 | 06:09 |
| *** yaawang has quit IRC | 06:09 | |
| *** sdake_ has quit IRC | 06:10 | |
| *** sdake has joined #openstack-nova | 06:10 | |
| *** sdake has quit IRC | 06:10 | |
| yonglihe | alex_xu: Updated the topology subresource per your comments, please check it. and should i put 2 of them on the stein-runway? There is already 3 items. | 06:17 |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 06:21 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: WIP: Testing nova legacy jobs on bionic https://review.openstack.org/639017 | 06:27 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: WIP: Testing nova legacy jobs on bionic https://review.openstack.org/639017 | 06:36 |
| *** tiendc has quit IRC | 06:36 | |
| *** sridharg has joined #openstack-nova | 06:46 | |
| *** Luzi has joined #openstack-nova | 06:51 | |
| *** ileixe has quit IRC | 07:04 | |
| *** slaweq has joined #openstack-nova | 07:11 | |
| *** udesale has quit IRC | 07:27 | |
| *** udesale has joined #openstack-nova | 07:27 | |
| *** ttsiouts has joined #openstack-nova | 07:29 | |
| *** markvoelker has joined #openstack-nova | 07:30 | |
| *** jangutter has joined #openstack-nova | 07:39 | |
| *** belmoreira has joined #openstack-nova | 07:40 | |
| *** ttsiouts has quit IRC | 07:52 | |
| *** ttsiouts has joined #openstack-nova | 07:52 | |
| *** ttsiouts has quit IRC | 07:57 | |
| *** wolverineav has quit IRC | 07:57 | |
| *** awalende has joined #openstack-nova | 07:59 | |
| *** awalende has quit IRC | 08:01 | |
| *** takashin has left #openstack-nova | 08:01 | |
| *** markvoelker has quit IRC | 08:03 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 08:05 |
| *** lyaaaaarwood is now known as lyarwood | 08:06 | |
| kashyap | sean-k-mooney: Hi, when you're about, what is the URL again to see if there's a pattern/trend of this bug: https://bugs.launchpad.net/nova/+bug/1817324 | 08:06 |
| openstack | Launchpad bug 1817324 in OpenStack Compute (nova) "Intermittent "Failed to start libvirt guest: libvirt.libvirtError: monitor socket did not show up: No such file or directory" failures in the gate" [Undecided,Confirmed] | 08:06 |
| kashyap | "Ara" reports I guess | 08:06 |
| *** liuyulong has joined #openstack-nova | 08:11 | |
| kashyap | Hmm, I see indexing is behind by 76 hours: http://status.openstack.org/elastic-recheck/ | 08:14 |
| *** Sundar has joined #openstack-nova | 08:14 | |
| *** tkajinam has quit IRC | 08:14 | |
| *** Sundar has quit IRC | 08:15 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 08:16 |
| *** tesseract has joined #openstack-nova | 08:18 | |
| *** takamatsu_ has quit IRC | 08:19 | |
| *** dtantsur|afk is now known as dtantsur | 08:21 | |
| *** takamatsu_ has joined #openstack-nova | 08:21 | |
| *** takamatsu_ has quit IRC | 08:32 | |
| *** helenafm has joined #openstack-nova | 08:35 | |
| *** yaawang has joined #openstack-nova | 08:37 | |
| *** takamatsu_ has joined #openstack-nova | 08:38 | |
| *** awalende has joined #openstack-nova | 08:42 | |
| *** ccamacho has joined #openstack-nova | 08:45 | |
| *** tssurya has joined #openstack-nova | 08:48 | |
| *** stakeda has joined #openstack-nova | 08:52 | |
| *** tosky has joined #openstack-nova | 08:55 | |
| *** giblet is now known as gibi | 08:55 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova-specs master: Update alloc-candidates-in-tree https://review.openstack.org/639033 | 08:56 |
| *** rcernin has quit IRC | 09:00 | |
| *** ttsiouts has joined #openstack-nova | 09:00 | |
| *** markvoelker has joined #openstack-nova | 09:01 | |
| *** tetsuro has quit IRC | 09:07 | |
| *** snevi has joined #openstack-nova | 09:18 | |
| *** owalsh_ is now known as owalsh | 09:23 | |
| *** ralonsoh has joined #openstack-nova | 09:24 | |
| *** derekh has joined #openstack-nova | 09:30 | |
| *** markvoelker has quit IRC | 09:34 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 09:35 |
| *** wolverineav has joined #openstack-nova | 09:36 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 09:37 |
| *** ccamacho has quit IRC | 09:38 | |
| *** wolverineav has quit IRC | 09:41 | |
| *** cdent has joined #openstack-nova | 09:47 | |
| *** yaawang has quit IRC | 09:53 | |
| *** cdent has quit IRC | 09:56 | |
| *** bhagyashris has quit IRC | 10:02 | |
| *** erlon has quit IRC | 10:03 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: [Doc] Best practices for effectively tolerating down cells https://review.openstack.org/638173 | 10:03 |
| *** ccamacho has joined #openstack-nova | 10:13 | |
| *** jmlowe has quit IRC | 10:16 | |
| *** jmlowe has joined #openstack-nova | 10:17 | |
| *** sambetts_ has quit IRC | 10:28 | |
| *** sambetts_ has joined #openstack-nova | 10:30 | |
| *** markvoelker has joined #openstack-nova | 10:31 | |
| *** nehaalhat has joined #openstack-nova | 10:35 | |
| *** jaosorior has joined #openstack-nova | 10:37 | |
| *** ccamacho has quit IRC | 10:43 | |
| *** cdent has joined #openstack-nova | 10:43 | |
| *** ccamacho has joined #openstack-nova | 10:43 | |
| *** ccamacho has quit IRC | 10:45 | |
| *** trident has quit IRC | 10:47 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.openstack.org/638680 | 10:49 |
| *** trident has joined #openstack-nova | 10:50 | |
| *** stakeda has quit IRC | 10:50 | |
| *** yankcrime has quit IRC | 10:59 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.openstack.org/638680 | 11:00 |
| openstackgerrit | ya.wang proposed openstack/nova master: Select cpu model from a list of cpu models https://review.openstack.org/637834 | 11:02 |
| *** tbachman has quit IRC | 11:03 | |
| *** markvoelker has quit IRC | 11:04 | |
| sean-k-mooney | kashyap: you can go directly into logstack's kiban instance http://logstash.openstack.org/#/dashboard/file/logstash.json | 11:06 |
| *** yankcrime has joined #openstack-nova | 11:07 | |
| *** Dinesh_Bhor has quit IRC | 11:07 | |
| kashyap | sean-k-mooney: Yep, noted | 11:08 |
| *** ccamacho has joined #openstack-nova | 11:12 | |
| lyarwood | mdbooth: https://review.openstack.org/#/c/637527/ - If you have time today would you mind going over this again given our discussion on Friday? | 11:13 |
| *** ccamacho has quit IRC | 11:13 | |
| *** ccamacho has joined #openstack-nova | 11:14 | |
| *** liuyulong has quit IRC | 11:15 | |
| mdbooth | lyarwood: Yep, sure. Will do it now. | 11:18 |
| lyarwood | mdbooth: thanks | 11:18 |
| *** udesale has quit IRC | 11:18 | |
| mdbooth | lyarwood: Although... Hmm. I wonder if my comments are still relevant, despite my previous misunderstanding. | 11:19 |
| mdbooth | lyarwood: Backend_names != hosts, right? | 11:20 |
| lyarwood | mdbooth: they should form part of the hostname itself | 11:21 |
| lyarwood | mdbooth: host@backend#type | 11:21 |
| mdbooth | Ok, so if there's 1 c-vol and 2 backend_names then there are 2 'hosts' as reported by list_hosts()? | 11:22 |
| lyarwood | correct | 11:22 |
| lyarwood | c-api is all over the place tbh | 11:23 |
| *** ttsiouts has quit IRC | 11:23 | |
| mdbooth | https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded=list-all-hosts-for-a-project-detail#hosts-extension-os-hosts | 11:25 |
| mdbooth | The 'cinder-volume' in that case has host@backend | 11:26 |
| *** ccamacho has quit IRC | 11:28 | |
| lyarwood | mdbooth: right sorry, src_host is coming from os-vol-host-attr:host on the volume and that's host@backend#type | 11:29 |
| lyarwood | mdbooth: or at least that can be host@backend#type | 11:29 |
| lyarwood | mdbooth: thus the host_name not in src_host check when trying to find a destination host | 11:29 |
| mdbooth | lyarwood: Does host *always* have #type appended? | 11:33 |
| mdbooth | Because you're doing a straight string comparison | 11:34 |
| *** ttsiouts has joined #openstack-nova | 11:36 | |
| lyarwood | mdbooth: volume['os-vol-host-attr:host'] appears to, again I was wrong about host['host_name'], it doesn't contain #type | 11:39 |
| *** finucannot is now known as stephenfin | 11:40 | |
| mdbooth | lyarwood: Ok, does that mean you need to parse #type out of the former? | 11:44 |
| mdbooth | It would be nice if this was consistent | 11:45 |
| *** sdake has joined #openstack-nova | 11:46 | |
| lyarwood | mdbooth: I don't think so, we only care about the host@backend part here for migrations | 11:46 |
| lyarwood | mdbooth: we are just checking that the host@backend isn't hosting the volume at present | 11:46 |
| lyarwood | mdbooth: the type isn't a factor here | 11:46 |
| mdbooth | lyarwood: Right, but if I've understood what you've just told me, you're doing a string comparson between node@backend#type and node@backend, which is going to fail | 11:47 |
| lyarwood | mdbooth: other way around, node@backend not in node@backend#type | 11:47 |
| mdbooth | Ah, you're doing a not in, not a string comparison... | 11:48 |
| mdbooth | Eww | 11:48 |
| mdbooth | But I see | 11:48 |
| lyarwood | yeah I can spell that out more in a comment | 11:49 |
| *** sdake has quit IRC | 11:50 | |
| *** sdake has joined #openstack-nova | 11:52 | |
| *** yaawang has joined #openstack-nova | 11:53 | |
| *** ratailor has quit IRC | 11:54 | |
| *** sdake has quit IRC | 11:55 | |
| mdbooth | lyarwood: Updated. | 11:56 |
| lyarwood | mdbooth: thanks, would you mind hitting the actual nova bugfix while you're at it | 11:56 |
| lyarwood | mdbooth: https://review.openstack.org/#/c/637224/ | 11:56 |
| mdbooth | lyarwood: I've asked for additional assertions, but I think you can cut/paste them out of my old patch. | 11:56 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 11:57 |
| lyarwood | mdbooth: ack thanks | 11:58 |
| *** sdake has joined #openstack-nova | 11:58 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/636895 | 11:58 |
| lyarwood | finally | 11:58 |
| mdbooth | lyarwood: Thinking about it, you might need to split up the tempest test into the familiar 'assert incorrect behaviour', 'fix incorrect behaviour' 2 part series. | 11:58 |
| mdbooth | lyarwood: Nice :) | 11:59 |
| *** ccamacho has joined #openstack-nova | 11:59 | |
| lyarwood | mdbooth: I don't think we do that with tempest test additions tbh | 11:59 |
| mdbooth | Because I think we want the nova fix to Depends-On the change which asserts the correct behaviour in retype so as to avoid a regression. | 12:00 |
| mdbooth | But once you've landed the assertions I asked for against migration, the tempest test will fail until the nova fix lands. | 12:00 |
| *** sdake has quit IRC | 12:00 | |
| mdbooth | (Which highlights why the assertions are required, btw) | 12:01 |
| *** markvoelker has joined #openstack-nova | 12:01 | |
| lyarwood | mdbooth: The tempest changes will depend on the Nova fix | 12:02 |
| *** panda|ruck is now known as panda|ruck|lunch | 12:02 | |
| lyarwood | mdbooth: we can land some updates to the existing retype assertions outside of that | 12:02 |
| mdbooth | lyarwood: So you want to add the assertions to *retype* before landing the Nova change, because that asserts that you're not regressing retype | 12:02 |
| lyarwood | mdbooth: yeah that's simple enough to land first | 12:03 |
| lyarwood | mdbooth: so retype assertions update, nova fix and finally tempest migration test right? | 12:04 |
| mdbooth | lyarwood: Yeah | 12:04 |
| mdbooth | So the Nova change will depends-on the retype tempest addition. The full tempest test will depends-on the nova change. | 12:05 |
| lyarwood | correct | 12:05 |
| lyarwood | zuul++ | 12:05 |
| *** cdent has quit IRC | 12:17 | |
| *** nehaalhat has quit IRC | 12:22 | |
| *** ttsiouts has quit IRC | 12:31 | |
| *** ttsiouts has joined #openstack-nova | 12:32 | |
| *** cdent has joined #openstack-nova | 12:34 | |
| *** markvoelker has quit IRC | 12:35 | |
| *** ttsiouts has quit IRC | 12:37 | |
| mdbooth | lyarwood: Done. -1 is for discussed tempest change. Unit test change could be a nit, but one I really think we should fix. I'd like to see +1 from a cinder dev before anybody +2s it. | 12:40 |
| *** udesale has joined #openstack-nova | 12:42 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 12:48 |
| *** ttsiouts has joined #openstack-nova | 12:48 | |
| openstackgerrit | Merged openstack/os-vif master: remove brctl from vif_plug_ovs https://review.openstack.org/636821 | 13:02 |
| *** jistr is now known as jistr|mtg | 13:07 | |
| *** jistr|mtg is now known as jistr | 13:08 | |
| zhubx007 | Can anyone help to take a look at this https://review.openstack.org/#/c/638080/? A bug fix. Thanks. | 13:10 |
| *** tbachman has joined #openstack-nova | 13:18 | |
| jaypipes | sean-k-mooney: trying to get through all os-vif patches you list in your email today. | 13:19 |
| mdbooth | zhubx007: That isn't going to fly for a few reasons. One of which is that by using automatic format detection it opens a potential security hole in image import. | 13:19 |
| mdbooth | zhubx007: In fact I'm almost certain that would open a major security hole. | 13:20 |
| sean-k-mooney | jaypipes: thanks. im respinning "make functional tests run on python 3" based on the feedback | 13:20 |
| mdbooth | zhubx007: Allowing any authenticated tenant to read all data from the compute host. | 13:21 |
| jangutter | jaypipes: I think that bridge+routing code is the classic monkeys+bananas thing. | 13:21 |
| sean-k-mooney | jaypipes: does the timeline and porities make sense. once the final brctl patch merges we have reached the mvp for stien the rest are nice to have but dont block features | 13:24 |
| *** panda|ruck|lunch is now known as panda|ruck | 13:26 | |
| gibi | jaypipes: hi! the next couple of patches in the bandwidth series (staring here https://review.openstack.org/#/c/616240) has mriedem's +2 on it. I'm working on a fup to fix his comments. So if you have time could you look at the series again? | 13:31 |
| *** markvoelker has joined #openstack-nova | 13:32 | |
| jaypipes | sean-k-mooney: I'd like to get the native ovslib stuff in if possible. | 13:34 |
| jaypipes | gibi: yup | 13:34 |
| gibi | jaypipes: thanks a lot | 13:34 |
| alex_xu | sean-k-mooney: stephenfin something need your expert https://review.openstack.org/#/c/634828/24/nova/virt/libvirt/driver.py@6783 :) | 13:37 |
| sean-k-mooney | jaypipes: yep that is why its in the prefer section :) its not required but im happy to wait a couple of extra hours to try and get it over the line | 13:37 |
| *** udesale has quit IRC | 13:37 | |
| *** udesale has joined #openstack-nova | 13:38 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.openstack.org/639091 | 13:39 |
| artom | alex_xu, hah, was just about to ask :) | 13:40 |
| sean-k-mooney | alex_xu that is a good question. i dont really think there is a good usecase for different values | 13:40 |
| alex_xu | artom: hah | 13:40 |
| artom | alex_xu, thanks for taking a thorough look at that series, by the way :) | 13:40 |
| alex_xu | np :) | 13:40 |
| sean-k-mooney | alex_xu: that said since it can be set per node it proably should be sent back | 13:40 |
| alex_xu | sean-k-mooney: ok, thanks | 13:41 |
| openstackgerrit | Merged openstack/os-vif master: remove use of brctl from vif_plug_linux_bridge https://review.openstack.org/636822 | 13:41 |
| artom | sean-k-mooney, noted, thanks | 13:41 |
| sean-k-mooney | if there was a good usecase for different values we should be schduling on it and we cant today except via host aggregates | 13:42 |
| sean-k-mooney | we could expose it via a custom trait at some point but i think this is too virtdirer specific to warrent it. | 13:44 |
| *** jmlowe has quit IRC | 13:44 | |
| openstackgerrit | Merged openstack/os-resource-classes master: Add normalize_name utility https://review.openstack.org/634258 | 13:45 |
| sean-k-mooney | technically different prioties of realtime tasks is a thing but i dont think it should be a thing in cloud. im much more comfortable with a boolean form that point of view. e.g. it supprot realtime instance or it doesnt | 13:45 |
| zhubx007 | mdbooth: Got your review. Is there any suggestion to fix the bug? If do not convert the qcow2 to raw here, the instance failed to boot. Thanks. | 13:47 |
| mdbooth | zhubx007: I just added another comment on the review about that. | 13:47 |
| mdbooth | I don't think you need to fix it, because if you leave force_raw_images with its default value of True then the image should be (safely) converted for you anyway. | 13:48 |
| *** sapd1 has joined #openstack-nova | 13:48 | |
| alex_xu | sean-k-mooney: that priorities is also indicated the host whether support realtime? so you mean at least there is way to find out a host support realtime | 13:48 |
| alex_xu | ah, I see now, we won't fix realtime and normal workload on the same host, right? sean-k-mooney | 13:49 |
| alex_xu | s/fix/mix | 13:49 |
| mdbooth | zhubx007: Are you setting force_raw_images to false? | 13:51 |
| sean-k-mooney | alex_xu: well right now you have to use host aggrates to split them | 13:51 |
| mdbooth | If force_raw_images is True and you're hitting this, I think we should go back and open a bug about this to try to work out why before attempting a fix. | 13:51 |
| sean-k-mooney | alex_xu: mainly because we dont know which host have a realtime kernel | 13:51 |
| alex_xu | sean-k-mooney: I see now | 13:52 |
| zhubx007 | mdbooth: :) wait for a minute. I check nova.conf file now. | 13:53 |
| sean-k-mooney | if https://github.com/openstack/nova/blob/master/nova/conf/libvirt.py#L759-L763 did not have a default we could use the presence or absence of that config value to know if we should add a realtime trait to the compute node | 13:53 |
| sean-k-mooney | but since it default to 1 we cant | 13:54 |
| sean-k-mooney | we might want to change that in the future but not in stien | 13:54 |
| sean-k-mooney | alex_xu: ^ likely we would have to add another config to not break backwards compatiblity but the detail should praobly be discussed in a short spec. | 13:55 |
| zhubx007 | mdbooth: yes, force_raw_images is False | 13:56 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | 13:56 |
| yonglihe | call for review, thanks, it's small one: https://review.openstack.org/#/c/621474/22 | 13:57 |
| mdbooth | zhubx007: Cool, that's your problem. | 13:57 |
| mdbooth | zhubx007: As I say it does feel wrong that the we're making it the operator's responsibility to get that right. | 13:58 |
| alex_xu | sean-k-mooney: agree, and we can transulate hw:.... to a required trait in placement request | 13:58 |
| mdbooth | zhubx007: But that would be a much lower priority issue :) Patches welcome. | 13:58 |
| sean-k-mooney | yep we could. ill write something up for train and add you to the reviews list. | 13:59 |
| alex_xu | cool | 13:59 |
| cdent | scheduler placement meeting in #openstack-meeting-alt now ish | 13:59 |
| *** awaugama has joined #openstack-nova | 14:00 | |
| *** elbragstad has joined #openstack-nova | 14:01 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM: Testing nova legacy jobs on bionic https://review.openstack.org/639017 | 14:01 |
| zhubx007 | mdbooth: yeah, you are right. but when setting force_raw_images to False, I think it is still an issue. | 14:01 |
| *** med_ has joined #openstack-nova | 14:01 | |
| *** mmethot has joined #openstack-nova | 14:03 | |
| *** fried_rice is now known as efried | 14:04 | |
| *** ttsiouts has quit IRC | 14:04 | |
| *** markvoelker has quit IRC | 14:05 | |
| *** ttsiouts has joined #openstack-nova | 14:05 | |
| *** ttsiouts has quit IRC | 14:06 | |
| *** dpawlik has quit IRC | 14:06 | |
| *** ttsiouts has joined #openstack-nova | 14:06 | |
| *** dave-mccowan has joined #openstack-nova | 14:07 | |
| *** owalsh_ has joined #openstack-nova | 14:08 | |
| *** owalsh has quit IRC | 14:09 | |
| openstackgerrit | Jan Gutter proposed openstack/os-vif master: Fix nits in brctl removal (vif_plug_linux_bridge) https://review.openstack.org/639099 | 14:09 |
| mdbooth | zhubx007: Right. That setting is incompatible with rbd imagebackend. It would be nice to, for eg, give an error at startup pointing it out. Or perhaps just switching it off automatically and logging a warning. | 14:10 |
| mdbooth | zhubx007: In fact it's only useful for flat and qcow2 imagebackends. LVM would also have a problem with it. | 14:11 |
| stephenfin | jangutter: Some small comments in that patch ^ | 14:12 |
| openstackgerrit | Jan Gutter proposed openstack/os-vif master: Fix nits in brctl removal (vif_plug_linux_bridge) https://review.openstack.org/639099 | 14:15 |
| jangutter | stephenfin: ask and ye shall receive. | 14:16 |
| sean-k-mooney | jangutter: damb looks like i missed leaving the comment by a few seconds | 14:16 |
| sean-k-mooney | jangutter: can ou add the comment too? thanks for doing this by the way | 14:16 |
| jangutter | sean-k-mooney: hahaha, no worries. I don't have my Nagle algorithm turned on today. | 14:17 |
| stephenfin | jangutter: is that correct? | 14:17 |
| stephenfin | x, = (1, 2) gives a ValueError | 14:17 |
| stephenfin | You'd need 'x, _' | 14:17 |
| jangutter | stephenfin: frack, you're right. | 14:18 |
| jangutter | stephenfin: just goes to show that code path is untested so badly. | 14:18 |
| stephenfin | Oh, found an ancient change of mine. does this docs patch make sense to you, jaypipes? https://review.openstack.org/#/c/445436/ | 14:18 |
| sean-k-mooney | oh thats to nova i was like i dont remember that | 14:19 |
| *** owalsh has joined #openstack-nova | 14:19 | |
| *** owalsh_ has quit IRC | 14:20 | |
| openstackgerrit | Jan Gutter proposed openstack/os-vif master: Fix nits in brctl removal (vif_plug_linux_bridge) https://review.openstack.org/639099 | 14:23 |
| jangutter | stephenfin, sean-k-mooney: 3rd time lucky Monday? | 14:23 |
| *** tbachman has quit IRC | 14:24 | |
| *** mvkr has quit IRC | 14:24 | |
| jangutter | I think that code is dead since before I touched OpenStack, but I'm worried that breaking it will cause CERN to accidentally create a black hole or something. | 14:27 |
| *** jmlowe has joined #openstack-nova | 14:30 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/rocky: DNM: Testing nova legacy jobs on rocky still use xenial https://review.openstack.org/639107 | 14:30 |
| sean-k-mooney | jangutter: the linux bridge pluging is partcalarly archane as we spend much less time maintaining it. im hoping that by sharing code with the ovs plugin in train we can impove the quality of both | 14:31 |
| *** tbachman has joined #openstack-nova | 14:32 | |
| sean-k-mooney | jangutter: i would also like to add an sriov plugin intree in train so we can finally remove the last of the vif.py legacy code from nova | 14:32 |
| jangutter | sean-k-mooney: ++ on both of those. | 14:32 |
| sean-k-mooney | we have avoided sharing code so people can copy a sub directly and use that as a base for a new plugin but instead i would like to create a cookiecutter template for that and document it | 14:33 |
| sean-k-mooney | *sub directory | 14:34 |
| *** mvkr has joined #openstack-nova | 14:35 | |
| *** snevi has quit IRC | 14:35 | |
| *** sridharg has quit IRC | 14:36 | |
| *** snevi has joined #openstack-nova | 14:37 | |
| zhubx007 | mdbooth: as you say, it is ok when I set force_raw_images to True. Whether it is great to add checking the image format when call import_image under rbd imagebackend because only raw is good for this backend. | 14:38 |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 14:39 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: make functional tests run on python 3 https://review.openstack.org/638053 | 14:40 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: modify functional base.py to allow using vscode https://review.openstack.org/638058 | 14:40 |
| *** eharney has joined #openstack-nova | 14:40 | |
| *** mriedem has joined #openstack-nova | 14:47 | |
| *** cdent has quit IRC | 14:53 | |
| *** tbachman has quit IRC | 14:55 | |
| *** mlavalle has joined #openstack-nova | 14:58 | |
| *** sapd1 has quit IRC | 14:59 | |
| *** udesale has quit IRC | 15:02 | |
| mriedem | jaypipes: efried: i'm +2 on the current bottom 4 bw provider series changes https://review.openstack.org/#/c/616240/ - nits to be sure but can be addressed in another follow up i think | 15:04 |
| mriedem | i think the api change is the goal for stein https://review.openstack.org/#/c/636360/ so i'm trying to do a review push to get there this week | 15:04 |
| *** tbachman has joined #openstack-nova | 15:10 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.openstack.org/639091 | 15:10 |
| kashyap | mriedem: Blast from the past ^ | 15:10 |
| efried | mriedem: ack. Trying to figure out if it's mathematically possible to have more fups than patches. | 15:11 |
| mriedem | efried: i made a similar joke on one of these | 15:11 |
| mriedem | 1:1 fups | 15:11 |
| efried | I hate being unoriginal. Now I will have to kill you. | 15:11 |
| efried | Never mind, I'll need you to review my code. You live. | 15:12 |
| *** Luzi has quit IRC | 15:13 | |
| gibi | efried, mriedem: I working on a fup that will contain fixes up til https://review.openstack.org/#/c/573317 | 15:16 |
| kashyap | What is a "fup"? | 15:16 |
| gibi | kashyap: Follow up | 15:16 |
| kashyap | My tool doesn't know it: | 15:16 |
| kashyap | $> wtf is fup | 15:16 |
| kashyap | wtf: I don't know what `fup' means! | 15:16 |
| kashyap | gibi: Ah, thanks. | 15:16 |
| efried | or what you were thinking, depending. | 15:16 |
| sean-k-mooney | fix up patch or follow up patch | 15:16 |
| sean-k-mooney | kashyap: ^ | 15:17 |
| kashyap | Please, "follow-up" as keyword. | 15:17 |
| sean-k-mooney | no one uses that^ | 15:17 |
| kashyap | As I accidentally looked at the definition of "fup" on Urban Dictionary ... and "you won't believe what happens next!" | 15:17 |
| kashyap | sean-k-mooney: Yeah, yeah. I know it's just IRC slang | 15:17 |
| efried | Back in the day it was used by IBM support teams for APARs, in caps (FUP), simply shorthand for "follow up", as in "FUP with customer..." | 15:18 |
| efried | and led to all kinds of raunchy (well, for IBM, anyway) jokes. | 15:18 |
| sean-k-mooney | yep and recent slang at that. but i dont think we need to add follow-up: someithg to the commits | 15:18 |
| kashyap | I see | 15:19 |
| efried | Agree with that; though I have to say I'm not a fan of commit titles like "Follow on for <change-id>" with nothing in the body of the message. | 15:19 |
| efried | When I do these, I tend to do "FUP for <brief description>" and then enumerate links to specific comments I'm responding to in the body. | 15:20 |
| efried | and of course, everybody should do it my way. | 15:20 |
| *** jobewan has joined #openstack-nova | 15:20 | |
| sean-k-mooney | haha well that at least makes sense | 15:20 |
| efried | example: https://review.openstack.org/#/c/600474/ | 15:21 |
| *** beekneemech is now known as bnemec | 15:21 | |
| sean-k-mooney | i think this is fine too https://review.openstack.org/#/c/639099/ but a midpoint betwen the too is praobly good too. | 15:22 |
| kashyap | efried: Yeah, I fully agree on "bad commit messages". Reminds me of this excellent guide written by DanPB many moons ago: https://wiki.openstack.org/wiki/GitCommitMessages | 15:23 |
| kashyap | People should take that guide to the heart. | 15:23 |
| sean-k-mooney | the disadvantage of both are you have to click the link/change id to see the context | 15:23 |
| sean-k-mooney | kashyap: there are some thing in the bad examples that i dont fully agree with in that guide but i do reference it frequently | 15:24 |
| kashyap | (And of course this excellent post from a certain Chris Beans: https://chris.beams.io/posts/git-commit/) | 15:24 |
| kashyap | sean-k-mooney: The fundamental rule I follow in commit messages is: provide all the context right there in the commit message. | 15:24 |
| efried | kashyap: I frequently reference the GitCommitMessages wiki page. (That link showed up purple for me :) | 15:24 |
| kashyap | If you have to link to something, summarize it | 15:24 |
| kashyap | (E.g. faciliate the poor suckers working without internet connection and are doing `git log` sleuthing) | 15:25 |
| kashyap | efried: Cool :-) | 15:25 |
| kashyap | sean-k-mooney: That point is actually point 2 in that Wiki page: "Do not assume the reviewer has access to external web services/site." | 15:25 |
| sean-k-mooney | kashyap: one thing that i always tought that wiki discuoraged was bullet point list in the commit which i think are actully good style | 15:25 |
| sean-k-mooney | yep | 15:26 |
| *** tbachman has quit IRC | 15:26 | |
| kashyap | sean-k-mooney: Bullet points are fine -- as long as they are complete, and _coherent_ sentences | 15:26 |
| kashyap | And not no-assed "thoughts" | 15:26 |
| sean-k-mooney | so i think https://review.openstack.org/#/c/638058/2//COMMIT_MSG is a good commit message but that general styple would be discuraged | 15:26 |
| kashyap | sean-k-mooney: Was actually reading that change | 15:27 |
| efried | My understanding is that what's discouraged is changing more than one thing in a commit. A bullet list sometimes (but definitely not always) indicates that that's happening. But a bullet list isn't inherently bad. | 15:28 |
| efried | be like saying, "never use the word 'also' in a commit message" | 15:28 |
| sean-k-mooney | efried: ya that is true the distinciton is not made clear in the example in the wiki | 15:29 |
| kashyap | sean-k-mooney: I have a small 'issue' with that vscode commit message | 15:29 |
| *** awalende has quit IRC | 15:29 | |
| kashyap | It doesn't follow the general "scheme" most of the human brains are used to: describe the problem, then tell the solution. | 15:30 |
| sean-k-mooney | kashyap: there are 2 thing i need to fix | 15:30 |
| *** awalende has joined #openstack-nova | 15:30 | |
| sean-k-mooney | kashyap: so leave a comment and ill adress them shortly | 15:30 |
| kashyap | Lastly, this is my Git commit message 'scheme': | 15:30 |
| kashyap | [One line summary -- in imperative mood] | 15:30 |
| kashyap | Describe the problem. | 15:30 |
| kashyap | Describe your solution. And more importantly, tell *why*. | 15:30 |
| kashyap | (You do that, though. But all of them in bullets :-)) Anyway, don't want to belabor on this. | 15:31 |
| stephenfin | bauzas: Fancy doing me the honour? https://review.openstack.org/#/c/445436/ | 15:32 |
| bauzas | stephenfin: with pleasure | 15:32 |
| bauzas | stephenfin: oh wait, sec. the option is *already* deprecated ? | 15:33 |
| bauzas | stephenfin: if so, it should have a reno note | 15:33 |
| bauzas | if not, we need it | 15:33 |
| stephenfin | that's a good point | 15:34 |
| stephenfin | lemme fix that | 15:34 |
| *** awalende has quit IRC | 15:34 | |
| bauzas | stephenfin: will update the commit msg to stop the zuul check then | 15:35 |
| *** elbragstad is now known as lbragstad | 15:35 | |
| stephenfin | If you remove the -W, it'll take it out of the gate | 15:35 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: conf: Improve documentation for defer_iptables_apply https://review.openstack.org/445436 | 15:35 |
| bauzas | stephenfin: nope, unless zuul changed | 15:37 |
| bauzas | for pushing the change out of the gate pipeline, we need to have a new revision | 15:37 |
| bauzas | anyway, it's done | 15:38 |
| *** agopi has quit IRC | 15:40 | |
| *** macza has joined #openstack-nova | 15:44 | |
| openstackgerrit | Lajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.70 https://review.openstack.org/637234 | 15:46 |
| *** macza has quit IRC | 15:48 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecated 'defer_iptables_apply' https://review.openstack.org/445436 | 15:54 |
| stephenfin | bauzas, jaypipes: That should be better ^ | 15:54 |
| stephenfin | sean-k-mooney tells me what I'm doing is likely correct and I'm going to b̶l̶a̶m̶e̶ ̶h̶i̶m̶ ̶i̶f̶ ̶I̶'̶m̶ ̶w̶r̶o̶n̶g̶ trust him :) | 15:55 |
| jaypipes | heh | 15:56 |
| * sean-k-mooney til you can do stike though text in irc | 15:58 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add unit tests for missing VirtualInterface in 2.70 os-interface https://review.openstack.org/639141 | 15:59 |
| mriedem | can i get another core on the 'expose virtual device tags' api change? https://review.openstack.org/#/c/631948/ alex +2ed it and it's pretty straight-forward. last day in the runway queue for this one. | 16:00 |
| stephenfin | sean-k-mooney: My docs are "nice to have". I feel cheated, Good Sir ;) | 16:00 |
| stephenfin | mriedem: I can take a gawk | 16:00 |
| mriedem | thanks | 16:00 |
| yonglihe | this one in same situation: https://review.openstack.org/#/c/621474/22 | 16:01 |
| sean-k-mooney | stephenfin: docs chagnes are non fuctional and can can be merged after the client lib freeze. since we generally just use the latest version of the docs people should still see them but they also can be backported to stable branches more easily so nice to have | 16:01 |
| sean-k-mooney | stephenfin: hehe but i also think they will be straigt forward to merge so im going to go review them shortly anyway | 16:02 |
| mriedem | yonglihe: i'll try to get to that one | 16:02 |
| *** _alastor_ has joined #openstack-nova | 16:02 | |
| yonglihe | thanks. | 16:03 |
| yonglihe | i suppose all stuff piled up at end of dev cycle, sorry for that. | 16:04 |
| *** markvoelker has joined #openstack-nova | 16:05 | |
| *** mkarpiarz has joined #openstack-nova | 16:08 | |
| *** mkarpiarz has quit IRC | 16:10 | |
| *** ttsiouts has quit IRC | 16:11 | |
| *** tbachman has joined #openstack-nova | 16:11 | |
| *** ttsiouts has joined #openstack-nova | 16:12 | |
| mriedem | np, it always happens | 16:12 |
| *** macza has joined #openstack-nova | 16:14 | |
| *** ttsiouts has quit IRC | 16:16 | |
| *** cdent has joined #openstack-nova | 16:18 | |
| bauzas | stephenfin: +Waboom | 16:20 |
| *** mrch_ has quit IRC | 16:20 | |
| *** ivve has joined #openstack-nova | 16:21 | |
| *** _hemna has joined #openstack-nova | 16:23 | |
| *** imacdonn has joined #openstack-nova | 16:23 | |
| openstackgerrit | Merged openstack/nova master: Refactor "networks" processing in ServersController.create https://review.openstack.org/633594 | 16:25 |
| stephenfin | bauzas: Tank u | 16:27 |
| *** agopi has joined #openstack-nova | 16:28 | |
| stephenfin | .--._____, | 16:28 |
| stephenfin | .-='=='==-, " | 16:28 |
| stephenfin | (O_o_o_o_o_O) | 16:28 |
| * cdent blinks | 16:28 | |
| *** _hemna has quit IRC | 16:30 | |
| yonglihe | -:) | 16:33 |
| *** markvoelker has quit IRC | 16:34 | |
| *** gyee has joined #openstack-nova | 16:37 | |
| *** takamatsu_ has quit IRC | 16:39 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'flavor-extra-spec-image-property-validation' spec https://review.openstack.org/638734 | 16:40 |
| *** dklyle_ has quit IRC | 16:40 | |
| *** takamatsu_ has joined #openstack-nova | 16:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: [Doc] Best practices for effectively tolerating down cells https://review.openstack.org/638173 | 16:42 |
| tssurya | thanks mriedem ^ | 16:43 |
| mriedem | np | 16:43 |
| *** helenafm has quit IRC | 16:44 | |
| *** takamatsu_ has quit IRC | 16:45 | |
| *** takamatsu_ has joined #openstack-nova | 16:51 | |
| *** ttsiouts has joined #openstack-nova | 16:51 | |
| *** dklyle has joined #openstack-nova | 16:55 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fup for the bandwidth series https://review.openstack.org/639159 | 16:57 |
| gibi | mriedem: your comments for the bandwidth series are fixed in ^^ | 16:58 |
| gibi | jaypipes, efried: thanks for the comments in the bandwidth series, I will update https://review.openstack.org/639159 with your comments as well, possibly tomorrow | 16:58 |
| *** ttsiouts has quit IRC | 16:59 | |
| *** ttsiouts has joined #openstack-nova | 16:59 | |
| artom | Object equality in tests in a PITA | 17:00 |
| artom | *is | 17:00 |
| artom | Expect call: Flavor(<some stuff>), Actual call: Flavor(<exact same stuff>) | 17:01 |
| artom | *facepalm* | 17:03 |
| artom | No, that's not i :( | 17:03 |
| artom | *it | 17:03 |
| *** ttsiouts has quit IRC | 17:04 | |
| sean-k-mooney | stephenfin: left some comments on you os-vif docs changes most are minor | 17:04 |
| *** takamatsu_ has quit IRC | 17:06 | |
| *** takamatsu_ has joined #openstack-nova | 17:07 | |
| sean-k-mooney | artom: object equality check pending change so you need to reset changes on both object before comparing them | 17:07 |
| sean-k-mooney | otherwise you get X != X issues | 17:08 |
| *** _fragatina_ has joined #openstack-nova | 17:08 | |
| *** _fragatina has quit IRC | 17:10 | |
| jaypipes | artom: what sean-k-mooney said is almost always the problem with that. | 17:10 |
| *** spotz has joined #openstack-nova | 17:10 | |
| sean-k-mooney | jaypipes: artom we proably should just create a function in the base tescae for comparing objects | 17:10 |
| jaypipes | sean-k-mooney: there was one somewhere I think... maybe dansmith can remember :) | 17:11 |
| sean-k-mooney | e.g. self.assertObjEquals | 17:11 |
| sean-k-mooney | jaypipes: would it break the world if we changed __eq__ in base ovo to ignore the changed state of fields? | 17:12 |
| *** snevi is now known as IvensZambrano | 17:12 | |
| sean-k-mooney | i assume yes since we have not done so before | 17:12 |
| artom | sean-k-mooney, jaypipes, yeah, so it this case it was dumber than that - my main problem was I had an - and an _ in my fake values | 17:12 |
| sean-k-mooney | oh :) | 17:13 |
| artom | But once that hurdle was over, there was still an object I had to replace with a fake string. | 17:13 |
| artom | But yeah, a more intelligent way of comparing objects would be super | 17:13 |
| jaypipes | hah :) | 17:13 |
| artom | It wouldn't even be that hard - implement __eq__ in the base fields, and then recursively compare fields | 17:14 |
| sean-k-mooney | artom: yes but we dont know if anyting depens on the fact that object comparisons current check the changed fields state of the objects | 17:15 |
| sean-k-mooney | os its not that its hard to do but would it break anything | 17:15 |
| *** bjolo has quit IRC | 17:16 | |
| *** snevi has joined #openstack-nova | 17:16 | |
| *** IvensZambrano has quit IRC | 17:16 | |
| sean-k-mooney | artom: https://github.com/openstack/nova/blob/eb5bdd33052166e4375f924456438f11be03310a/nova/test.py#L704 we have this by the way | 17:17 |
| *** snevi has quit IRC | 17:17 | |
| artom | sean-k-mooney, that's not useful when you're asseting call param tho | 17:17 |
| artom | Anyways, it's a pain, but all things considered a minor one | 17:17 |
| *** eharney has quit IRC | 17:17 | |
| *** IvensZambrano has joined #openstack-nova | 17:18 | |
| *** efoley has joined #openstack-nova | 17:18 | |
| *** mrch_ has joined #openstack-nova | 17:18 | |
| *** takamatsu_ has quit IRC | 17:21 | |
| *** takamatsu_ has joined #openstack-nova | 17:22 | |
| *** dtantsur is now known as dtantsur|afk | 17:23 | |
| *** erlon has joined #openstack-nova | 17:23 | |
| *** takamatsu_ has quit IRC | 17:25 | |
| *** sdake has joined #openstack-nova | 17:26 | |
| *** takamatsu_ has joined #openstack-nova | 17:31 | |
| *** markvoelker has joined #openstack-nova | 17:32 | |
| mriedem | artom: i've got some object equality test utils in my cross-cell resize series, sec | 17:33 |
| mriedem | artom: https://review.openstack.org/#/c/627892/15/nova/tests/unit/conductor/tasks/test_cross_cell_migrate.py@193 | 17:36 |
| *** dpawlik has joined #openstack-nova | 17:43 | |
| mriedem | dansmith: random question, when detaching the root volume of a server and attaching a new root volume, would you expect the device name on that bdm to change? or remain vda or whatever? | 17:44 |
| mriedem | i would expect it to *not* change | 17:44 |
| mriedem | since the boot_index is still 0 | 17:44 |
| mriedem | and the disk_bus and device_type can't change | 17:44 |
| *** takamatsu_ has quit IRC | 17:46 | |
| *** takamatsu_ has joined #openstack-nova | 17:48 | |
| sean-k-mooney | mriedem: i think the only time we would expect that it could change would be a rebuild with a different image or perhaps a volume retype operation. so if your question was related to the cross cell resize i think that is a safe assumtion to make | 17:49 |
| mriedem | it's not | 17:50 |
| mriedem | it's for Kevin_Zheng's root bdm attach/detach series | 17:50 |
| sean-k-mooney | oh ok | 17:50 |
| sean-k-mooney | am well if you detach attach anoth volume and then attach the root again i guess it could change | 17:51 |
| *** _fragatina_ has quit IRC | 17:51 | |
| sean-k-mooney | i dont know that code that well however | 17:51 |
| *** dpawlik has quit IRC | 17:52 | |
| mriedem | https://review.openstack.org/#/c/614750/34/nova/compute/manager.py | 17:52 |
| mriedem | if i boot from volume and get vda, then attach a data volume which is vdb, then detach the root volume and attach another root volume, would i expect to have that as vda or vdc? | 17:52 |
| mriedem | i would expect vda because the root volume being higher than the data volume seems wrong | 17:53 |
| dansmith | mriedem: yeah, expect the name to remain stable | 17:54 |
| sean-k-mooney | mriedem: that might depend on the os and the udev rules. but i would expect it to stay the same. i dont know if it actully would | 17:54 |
| * sean-k-mooney reads matts initall comment | 17:55 | |
| mriedem | well, we also don't guarantee the device name the user requests is honored by the hypervisor anyway | 17:56 |
| artom | mriedem, interesting, but I feel like that's specific to what you're doing with them (which is fine!) | 18:01 |
| *** derekh has quit IRC | 18:01 | |
| *** ralonsoh has quit IRC | 18:02 | |
| sean-k-mooney | mriedem: for the detach attach root volume spec | 18:02 |
| sean-k-mooney | mriedem: is it the same volume or can it be any volume that is reattached | 18:02 |
| artom | And as far as I can tell _assertEqualObjects doens't handle nested objects | 18:02 |
| artom | Anyways, as I said, it's an annoyance, but a minor one, though it might be worth it to put in the time to do it properly in a single place so that we stop fixing this each in our little corners | 18:03 |
| sean-k-mooney | mriedem: im wondering if we supprot reading the hw_disk_bus key form image metadata on a volume | 18:04 |
| sean-k-mooney | i think the answer is no but im checking | 18:04 |
| *** takamatsu_ has quit IRC | 18:05 | |
| *** sdake_ has joined #openstack-nova | 18:05 | |
| *** markvoelker has quit IRC | 18:05 | |
| *** sdake has quit IRC | 18:07 | |
| *** sdake_ has quit IRC | 18:10 | |
| *** takamatsu_ has joined #openstack-nova | 18:10 | |
| openstackgerrit | Merged openstack/os-vif master: Fix nits in brctl removal (vif_plug_linux_bridge) https://review.openstack.org/639099 | 18:10 |
| *** sdake has joined #openstack-nova | 18:11 | |
| sean-k-mooney | mriedem: it looks like we can get the image meta form the volume https://github.com/openstack/nova/blob/af78b13c24d4abf393d17ac57e9135204ef12b73/nova/utils.py#L928 | 18:11 |
| sean-k-mooney | mriedem: so if we are allowing attaching an arbiatry volume as the new root volume the diskbus could change | 18:12 |
| sean-k-mooney | if it has to be the same volume it wont | 18:12 |
| sean-k-mooney | that is called form https://github.com/openstack/nova/blob/5a09c81af3b438ecbcf27fa653095ff55abb3ed4/nova/compute/api.py#L1057 | 18:14 |
| *** takamatsu_ has quit IRC | 18:14 | |
| *** sdake_ has joined #openstack-nova | 18:15 | |
| *** Swami has joined #openstack-nova | 18:15 | |
| *** sdake has quit IRC | 18:16 | |
| *** mvkr has quit IRC | 18:16 | |
| *** tesseract has quit IRC | 18:18 | |
| *** takamatsu_ has joined #openstack-nova | 18:20 | |
| *** sdake_ has quit IRC | 18:20 | |
| *** sdake has joined #openstack-nova | 18:22 | |
| sean-k-mooney | mriedem: ah never mind the propsed change stats the detach will be garded by the instance being shelve offloaded | 18:24 |
| sean-k-mooney | ill update my comment on the patch | 18:24 |
| sean-k-mooney | oh thats the mitaka spec... | 18:25 |
| *** sdake has quit IRC | 18:26 | |
| *** sdake_ has joined #openstack-nova | 18:26 | |
| sean-k-mooney | the stein spech allow detach when the instance is powered off which may not work if the iamge changes | 18:27 |
| *** wolverineav has joined #openstack-nova | 18:27 | |
| openstackgerrit | Merged openstack/python-novaclient master: Handle unicode multi-byte characters https://review.openstack.org/632942 | 18:32 |
| *** mvkr has joined #openstack-nova | 18:33 | |
| *** wolverineav has quit IRC | 18:35 | |
| melwitt | o/ | 18:35 |
| sean-k-mooney | melwitt: o/ | 18:35 |
| *** sdake_ has quit IRC | 18:35 | |
| *** sdake has joined #openstack-nova | 18:36 | |
| openstackgerrit | Merged openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240 | 18:36 |
| openstackgerrit | Merged openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529 | 18:36 |
| openstackgerrit | Merged openstack/nova master: Add microversion to expose virtual device tags https://review.openstack.org/631948 | 18:36 |
| openstackgerrit | Merged openstack/nova master: api-ref: mark os-cells as deprecated https://review.openstack.org/636708 | 18:36 |
| openstackgerrit | Merged openstack/nova master: Replace ansible --sudo with --become in live_migration/hooks scripts https://review.openstack.org/635308 | 18:36 |
| *** wolverineav has joined #openstack-nova | 18:37 | |
| *** macza has quit IRC | 18:39 | |
| *** bnemec has quit IRC | 18:40 | |
| *** sdake has quit IRC | 18:41 | |
| *** sdake_ has joined #openstack-nova | 18:41 | |
| *** macza has joined #openstack-nova | 18:41 | |
| *** IvensZambrano has quit IRC | 18:42 | |
| *** bnemec has joined #openstack-nova | 18:45 | |
| *** sdake_ has quit IRC | 18:45 | |
| *** sdake has joined #openstack-nova | 18:47 | |
| *** tssurya has quit IRC | 18:47 | |
| *** belmorei_ has joined #openstack-nova | 18:48 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206 | 18:48 |
| *** jmlowe has quit IRC | 18:49 | |
| mriedem | sean-k-mooney: yeah it can be a different volume | 18:49 |
| *** takamatsu_ has quit IRC | 18:50 | |
| *** sdake has quit IRC | 18:50 | |
| sean-k-mooney | mriedem: do you think my concern regarding powered off instance is vlaid | 18:50 |
| sean-k-mooney | mriedem: i updated the comment on the patch | 18:51 |
| mriedem | how would powered off be different from when we unshelve the instance with a new root volume? | 18:51 |
| sean-k-mooney | a powered off instace is associated with a host | 18:52 |
| sean-k-mooney | we read the image metadata form volumes | 18:52 |
| sean-k-mooney | so if you can change the voluems you can change the requirement for the host | 18:52 |
| *** sdake has joined #openstack-nova | 18:52 | |
| sean-k-mooney | in unshevle we will hit the schuler | 18:52 |
| sean-k-mooney | but for powered off instnace we dont | 18:52 |
| sean-k-mooney | when we we start it again that is | 18:53 |
| *** jmlowe has joined #openstack-nova | 18:53 | |
| *** efoley has quit IRC | 18:54 | |
| mriedem | yes i see the issue, but i don't think he's reading the new root volume image_meta on unshelve either, | 18:55 |
| *** sdake has quit IRC | 18:55 | |
| sean-k-mooney | a concreate example would be if the instance was pinned and the original volume was create from an image with hw:numa_nodes=1 and the new volume was created form an iamge with hw:numa_node=2 it will invalidate the pinnings | 18:55 |
| mriedem | so as far as i know when we unshelve we're not using the new image meta anyway | 18:55 |
| sean-k-mooney | oh well it could be broken in both cases | 18:56 |
| *** takamatsu_ has joined #openstack-nova | 18:56 | |
| sean-k-mooney | i didnt actully check the code | 18:56 |
| *** sdake has joined #openstack-nova | 18:56 | |
| sean-k-mooney | we do get the metadata from the volume when initally spawning the instace | 18:56 |
| mriedem | yeah i know, and on rebuild | 18:57 |
| sean-k-mooney | i assume we would do it again on unselve but maybe not | 18:57 |
| mriedem | no, | 18:58 |
| mriedem | because on unshelve you either boot from the shelve snapshot (if not volume-backed), otherwise you boot from the root volume, | 18:58 |
| mriedem | which before this couldn't change | 18:58 |
| sean-k-mooney | right but on unselve we would have hit the schuler right. i guess it uses the embeded image metadata so it does not have to go back to cinder | 18:59 |
| *** belmorei_ has left #openstack-nova | 18:59 | |
| mriedem | yes unshelve hits the scheduler | 18:59 |
| mriedem | and it would use whatever is in the request spec from the original server create | 19:00 |
| mriedem | which uses the volume image meta here https://github.com/openstack/nova/blob/af78b13c24d4abf393d17ac57e9135204ef12b73/nova/compute/api.py#L886 | 19:00 |
| *** sdake has quit IRC | 19:01 | |
| sean-k-mooney | ya. so we could enable this to work for unselve by updating the request spec or just regtiving the metadata form the volume but i dont know how to "fix" start of a powered off instance | 19:01 |
| sean-k-mooney | i would expect the image to go into an error state on start if its requirements chagne | 19:01 |
| sean-k-mooney | but that is not very friendly | 19:01 |
| sean-k-mooney | or start with the old requirement i guess | 19:02 |
| *** sdake has joined #openstack-nova | 19:02 | |
| mriedem | inititally the spec never said anything about supporting detach/attach of the root volume for powered off instances | 19:02 |
| mriedem | only shelved offloaded | 19:02 |
| mriedem | which is how hpe wrote it up long ago | 19:02 |
| sean-k-mooney | yep in mitaka | 19:02 |
| mriedem | i do remember that the RequestSpec.image.id is *not* set for volume-backed servers, so some of our scheduler filters don't work on volume-backed servers | 19:03 |
| mriedem | like IsolatedHostsFilter | 19:03 |
| mriedem | during server create, we do calculate the numa topology requirements from the flavor and image meta, and for volume-backed we get that image meta from the root volume, like you said | 19:04 |
| mriedem | so technically on unshelve we could screw up and not honor the image meta in the new root volume | 19:04 |
| mriedem | b/c we don't update the request spec | 19:04 |
| *** sdake has quit IRC | 19:05 | |
| sean-k-mooney | right. i think that is just an oversight however. e.g. readign the spec i would have assume we woudl cater for that edgecase in the implemnation and they jsut chose not to document it in the spec | 19:05 |
| *** sdake has joined #openstack-nova | 19:06 | |
| mriedem | i wouldn't be so sure | 19:06 |
| sean-k-mooney | anyway it looks like newton was still only allowing this for shelved instance so its only allowed for powered off instance in the stein spec | 19:06 |
| mriedem | i'm pretty sure i didn't think about the root image meta changing when s10 pushed for supporting attach/detach of the root volume on stopped instances | 19:07 |
| sean-k-mooney | mriedem: im giving people the benifit of the doubt but perhaps it was not taught of | 19:07 |
| *** igordc has joined #openstack-nova | 19:07 | |
| sean-k-mooney | so with 2 weeks to feature freeze i dont really want to reopen the design of this given how long people have been waiting for it. | 19:09 |
| sean-k-mooney | i could propose a revision to the spec to reduce it to only shelved insntace or to document the behavior that will happen for poered off instace | 19:10 |
| *** sdake has quit IRC | 19:11 | |
| sean-k-mooney | *powered off | 19:11 |
| sean-k-mooney | im going to grab dinner but ill be back in an hour or so | 19:11 |
| sean-k-mooney | actully i have to push a small revision to a patch then dinner | 19:12 |
| *** sdake has joined #openstack-nova | 19:13 | |
| mriedem | sean-k-mooney: i commented on https://review.openstack.org/#/c/614750/ as well to recap our irc discussion. i'll talk with Kevin_Zheng about it tonight since we have a meeting anyway | 19:13 |
| mriedem | i don't think we can support the stopped case - that would essentially get us back to volume-backed rebuild with a new image that we don't really honor | 19:14 |
| *** sdake has quit IRC | 19:15 | |
| *** sdake_ has joined #openstack-nova | 19:15 | |
| sean-k-mooney | mriedem: ya that was my feeling too but i could see use allowing it and refusing to boot the instacne if the requirement could not be supported | 19:16 |
| *** eharney has joined #openstack-nova | 19:16 | |
| sean-k-mooney | that felt overly complicated however | 19:16 |
| sean-k-mooney | mriedem: can we shelve a powered off instance? | 19:16 |
| mriedem | yes | 19:17 |
| mriedem | which i think i said in the spec review when this came up, | 19:17 |
| mriedem | just stop the instance, shelve it, swap the root volume, and unshelve, | 19:17 |
| sean-k-mooney | ok so you jsut need to shelve it and then unshelve after changing volumes and you can more or less achive the same use case | 19:17 |
| mriedem | but people thought that was too complicated | 19:17 |
| sean-k-mooney | perhaps but ill take complicated over broken any day | 19:18 |
| *** sdake_ has quit IRC | 19:20 | |
| mriedem | sean-k-mooney: i guess i did think about this https://review.openstack.org/#/c/600628/7/specs/stein/approved/detach-boot-volume.rst@127 | 19:22 |
| *** _fragatina has joined #openstack-nova | 19:22 | |
| sean-k-mooney | mriedem ya looks like you did but it never made it into the spec in the end. | 19:25 |
| sean-k-mooney | mriedem: atleast a concreate proposal for what to do in this case was not added to the spec. your comment are obviously there | 19:26 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: modify functional base.py to allow using vscode https://review.openstack.org/638058 | 19:28 |
| mriedem | yeah i just don't want to get into a case where someone swaps the root volume on a stopped instance, then they rebuild it with what they thought was the original volume and rebuild blows up saying you can't rebuild a volume-backed instance with a new image, or they pass the image_id of the new root volume and the scheduler kicks it out saying it's not valid for the current host | 19:30 |
| mriedem | s/original volume/original image/ | 19:30 |
| *** IvensZambrano has joined #openstack-nova | 19:40 | |
| *** markvoelker has joined #openstack-nova | 20:02 | |
| openstackgerrit | Merged openstack/nova master: quota: remove QuotaEngine.register_resources() https://review.openstack.org/615613 | 20:04 |
| *** IvensZambrano has quit IRC | 20:15 | |
| *** jmlowe has quit IRC | 20:21 | |
| *** dosaboy has quit IRC | 20:34 | |
| *** dosaboy has joined #openstack-nova | 20:36 | |
| *** markvoelker has quit IRC | 20:36 | |
| *** dosaboy has quit IRC | 20:37 | |
| *** wolverineav has quit IRC | 20:37 | |
| *** wolverineav has joined #openstack-nova | 20:37 | |
| *** ccamacho has quit IRC | 20:39 | |
| *** wolverineav has quit IRC | 20:39 | |
| *** _hemna has joined #openstack-nova | 20:41 | |
| *** dosaboy has joined #openstack-nova | 20:46 | |
| *** ivve has quit IRC | 20:50 | |
| *** _hemna has quit IRC | 20:50 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 20:51 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 20:51 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.openstack.org/634828 | 20:51 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.openstack.org/635229 | 20:51 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.openstack.org/634605 | 20:51 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP needs more tests] Full NUMA live migration support https://review.openstack.org/634606 | 20:51 |
| artom | So that was "sync" push - let's run this in my test env to see what I've broken | 20:51 |
| dansmith | dang | 20:57 |
| dansmith | I was just working my way through them | 20:57 |
| dansmith | now I have to start all over aain | 20:57 |
| dansmith | guess I'll wait for next monay | 20:57 |
| dansmith | also, wtf is up with my keys | 20:57 |
| *** agopi has quit IRC | 20:58 | |
| sean-k-mooney | dansmith: are you on vacation until monday? or just monday is the next time you will be able to review it | 20:58 |
| sean-k-mooney | dansmith: just wondering if you will be around later in the week is all | 20:59 |
| *** agopi has joined #openstack-nova | 20:59 | |
| artom | dansmith, I'm sorry, are you asking for "monay"? I thought RH payed you well ;) | 20:59 |
| *** jobewan has quit IRC | 21:00 | |
| *** wolverineav has joined #openstack-nova | 21:00 | |
| dansmith | artom: monay monay | 21:01 |
| artom | It's a Smith-man world! | 21:01 |
| dansmith | sean-k-mooney: I'm giving artom a hard time implying that I only review large, late patch series on monday mornings | 21:01 |
| sean-k-mooney | hehe in that case feel free to add my/adrianc's sriov patch set to that list :P | 21:02 |
| sean-k-mooney | but on a serios note artom i deployed v21 on friday | 21:02 |
| sean-k-mooney | *serious | 21:02 |
| artom | v21? | 21:03 |
| sean-k-mooney | am ill redeploy tomorow ish do you think it will change much | 21:03 |
| sean-k-mooney | this was the top patch in the series on friday https://review.openstack.org/#/c/635229/21 | 21:05 |
| artom | sean-k-mooney, dunno, lemme run my tests against what I have now, see what breaks | 21:05 |
| sean-k-mooney | it looks like https://review.openstack.org/#/c/634606/30 is not the top patchset in the series | 21:05 |
| artom | sean-k-mooney, that's changed. Claim creating and cleanup needs to happen in the same patch, along with a version bump because we need to check that source and/or dest support claims | 21:06 |
| *** agopi_ has joined #openstack-nova | 21:07 | |
| *** jmlowe has joined #openstack-nova | 21:07 | |
| sean-k-mooney | right but https://review.openstack.org/#/c/634606/30 is now the final patch in the series right | 21:07 |
| *** gokhani has quit IRC | 21:07 | |
| artom | So there's 2 service bumps to keep the patches reasonnably sized | 21:07 |
| artom | 1 for the RPC stuff | 21:07 |
| artom | And 1 for the final "we support NUMA LM" switchover | 21:07 |
| artom | sean-k-mooney, correct | 21:08 |
| artom | The overall mechanics haven't really changed, but they way they're presented/ordered and some details have | 21:08 |
| sean-k-mooney | i can put off deploying the it for another few days and just to a code review tomorow and focus on other tasks if that helps. it will take me the better part of a day to run all the test i want too on it so i was going to wait till it sables a bit more | 21:09 |
| *** agopi has quit IRC | 21:10 | |
| *** kashyap has quit IRC | 21:10 | |
| artom | sean-k-mooney, your call, really. Ideally any tests that are missing from https://review.rdoproject.org/r/#/c/18832/ would get added there, so that we don't have to manually redo everything everytime there's a new patchset | 21:10 |
| sean-k-mooney | artom: ok what i want to be able to do is send an email to the list and say i test all these senarios with this reviesion and heres what work and didnt | 21:10 |
| sean-k-mooney | there are quite a lot of tests that arent covered | 21:10 |
| artom | For instance, I realized I wasn't saving the new instance numa topology (fixed now), so I should add that to the tests | 21:11 |
| *** jobewan has joined #openstack-nova | 21:11 | |
| artom | sean-k-mooney, oh I'm sure there are :) So... if you like it, just add them directly, or just write them out in English and I'll code them up | 21:12 |
| sean-k-mooney | i might spend some time writing automated test but i also want to manually run them and verify it. | 21:12 |
| mriedem | efried: jaypipes: i've gone through the next bw provider change in the series https://review.openstack.org/#/c/622421/ - i might be overly harsh on this one | 21:12 |
| openstackgerrit | Merged openstack/nova master: conf: Deprecated 'defer_iptables_apply' https://review.openstack.org/445436 | 21:13 |
| *** agopi__ has joined #openstack-nova | 21:13 | |
| *** agopi_ has quit IRC | 21:16 | |
| *** agopi__ is now known as agopi | 21:16 | |
| jaypipes | mriedem: I'm still trudging through them... sorry for the slowness. :( | 21:20 |
| mriedem | that's fine | 21:21 |
| mriedem | i'm about reviewed out for the day | 21:21 |
| *** cfriesen has joined #openstack-nova | 21:21 | |
| sean-k-mooney | jaypipes: hi am do you want to pushout the os-vif release to tomrow morning. i can send an update to the list with where things are or should i propose a relase with the current master. | 21:22 |
| sean-k-mooney | jaypipes: i would like to get the new release into the gate by tomorrow at the latest but we should be ok to wait anouter few hours e.g. till US moring to tag | 21:23 |
| jroll | dansmith: on https://review.openstack.org/#/c/635006 , this code path is in a periodic. so if we explode, the nova-compute won't crash, just won't expose any resources. that okay with you? | 21:27 |
| *** sdake has joined #openstack-nova | 21:28 | |
| dansmith | jroll: I mean, if it's a case that makes sense to not do anything then sure | 21:28 |
| jroll | dansmith: reworded, do you think operators will see that problem if nova-compute keeps running? | 21:29 |
| jaypipes | sean-k-mooney: yes, that would be good if we can delay one more day. | 21:29 |
| dansmith | jroll: I mean, it's the same deal as if they mis-configured with nothing in that list right? | 21:29 |
| dansmith | jroll: obviously it should be error-logged | 21:30 |
| jroll | dansmith: right, I mean if it's unset | 21:30 |
| sean-k-mooney | jaypipes: sure. i just want to have 1-2 days of gate time before the non-client lib freeze. | 21:30 |
| jaypipes | ack | 21:31 |
| sean-k-mooney | jaypipes: ill propose a patch and -w flow it with the current master and ill updated it tommorow once that feature lands. ill update teh list with all this soon | 21:31 |
| jaypipes | ++ | 21:31 |
| *** markvoelker has joined #openstack-nova | 21:33 | |
| dansmith | jroll: if we have no other option than to log errors in each periodic, then, I think that's about all we can do | 21:33 |
| dansmith | that said, | 21:33 |
| dansmith | we have a place for the virt driver to run during host init, and you could sanity check config there and explode to stop nova-compute I think | 21:34 |
| dansmith | jroll: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1202 | 21:34 |
| jroll | dansmith: ah, good point, I'll do that instead. thanks. | 21:35 |
| *** wolverineav has quit IRC | 21:42 | |
| cfriesen | mriedem: sean-k-mooney: For the vTPM stuff, do we need to be fully feature-complete to merge anything? Or could we review the currently proposed code and then do a followup commit to make cold migrations work? | 21:42 |
| *** wolverineav has joined #openstack-nova | 21:42 | |
| sean-k-mooney | well we can review the code but how is the feature enabled. e.g. will the ablilty to request a vTPM only be enable with the colde migrate code or will it be enabled in an early patch | 21:43 |
| sean-k-mooney | cfriesen: also how likely is it that the coldmigrate code will be ready in the next 2 weeks? | 21:44 |
| sean-k-mooney | cfriesen: is this the full series https://review.openstack.org/#/q/topic:bp/add-emulated-virtual-tpm+(status:open+OR+status:merged) | 21:46 |
| *** rcernin has joined #openstack-nova | 21:46 | |
| *** whoami-rajat has quit IRC | 21:47 | |
| *** sdake has quit IRC | 21:48 | |
| sean-k-mooney | cfriesen: i think we still plan to merge the bwandwith based schduleing patch without migration support but in the case of vTPM livemigration will work right since the vTPM data is copied by qemu it will jsut be colde migrate that is missing? | 21:49 |
| cfriesen | sean-k-mooney: paul-emile got moved internally, so I get to do it now. I'm ramping up, but I think there's a small piece missing to enable the functionality via image property and a piece missing for cold migration. | 21:49 |
| cfriesen | sean-k-mooney: with our earlier implementation live migration just worked, I'm hoping that'll still be true. | 21:50 |
| cfriesen | sean-k-mooney: crap, you're right. there's a bit missing to actually enable it. | 21:52 |
| cfriesen | minor detail. :) | 21:52 |
| melwitt | it's true we're planning to merge bw based scheduling without migration support but we're able to reject it via 403 error (I think is the plan that was landed on?) to be enabled later | 21:52 |
| sean-k-mooney | right so i havent looked at this properly since looking at the spec. | 21:52 |
| sean-k-mooney | cfriesen: so your in luck i have a dev env that i was usign to test artoms numa livemigration stuff that a knew enought version of qemu and libvirt | 21:53 |
| sean-k-mooney | cfriesen: i can try and test this tommorw | 21:54 |
| melwitt | would the vTPM stuff be able to do similar? we'd have to get some consensus about what to do, if so | 21:54 |
| cfriesen | sean-k-mooney: okay, I'll try and get you something usable. | 21:54 |
| sean-k-mooney | melwitt: we might be able to | 21:55 |
| cfriesen | melwitt: currently the code automatically advertises vTPM support if qemu/libvirrt is new enough, but we could add a config option to disable that. | 21:56 |
| sean-k-mooney | melwitt: we can certenly put a check in the conductor to reject the migration if we dont have the support | 21:56 |
| *** takashin has joined #openstack-nova | 21:56 | |
| cfriesen | yeah, we could do the conductor change too | 21:56 |
| * mriedem throws up in mouth over all of the conditional support we have now | 21:56 | |
| sean-k-mooney | cfriesen: the cold migration support should be fairly stright forward right | 21:57 |
| sean-k-mooney | cfriesen: you just need to coppy the backing file for the vtpm? | 21:57 |
| melwitt | yeah... config option for the support isn't something appealing | 21:57 |
| cfriesen | sean-k-mooney: pretty much, yeah. | 21:57 |
| melwitt | it wouldn't be able to reject before conductor? not in the API? | 21:57 |
| sean-k-mooney | melwitt: we dont really want to do a virt dirver specific check in the api | 21:57 |
| mriedem | surprise surprise everyone, resize/cold migrate is an RPC call from api to conductor | 21:58 |
| mriedem | so in that case, conductor is the api | 21:58 |
| melwitt | yeah, like isn't conductor also not a good place to do a virt driver specific check? | 21:58 |
| sean-k-mooney | yes | 21:58 |
| sean-k-mooney | i was about to say that | 21:59 |
| melwitt | ok | 21:59 |
| sean-k-mooney | the condoctor call can live migrate dest/source on the dirver | 21:59 |
| sean-k-mooney | that is where the actual check woudl have to go | 21:59 |
| melwitt | ah, ok | 21:59 |
| mriedem | currently the numa checks happen in conductor | 21:59 |
| mriedem | vgpus also landed in queens with a bunch of caveats https://docs.openstack.org/nova/latest/admin/virtual-gpu.html#caveats | 21:59 |
| mriedem | for resize | 21:59 |
| sean-k-mooney | mriedem: ya we could put the with the numa stuff | 21:59 |
| mriedem | do those not also apply to vtpm, i.e. you can resize but it doesn't transfer your stuff, so you have to rebuild after that - which sucks | 22:00 |
| sean-k-mooney | but numa worksi in hyperver and nova. actull vtpm technically is support in hyperv too | 22:00 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: partition compute services by conductor group https://review.openstack.org/635006 | 22:00 |
| *** agopi has quit IRC | 22:00 | |
| mriedem | with 2 weeks left i don't really want to have to think about hacking in a half-baked feature | 22:01 |
| mriedem | i'd rather just defer to train | 22:01 |
| mriedem | when you can do something with the actual server that has vtpm | 22:01 |
| sean-k-mooney | cfriesen: ill need to check the spec but what did we say we woudl do for shelve ecrta | 22:01 |
| cfriesen | okay. I'll try hard to get it all working then. | 22:01 |
| mriedem | sean-k-mooney: i believe the spec punted on shelve | 22:02 |
| cfriesen | pretty sure we said shelve *could* be supported by saving the TPM data as a glance image. | 22:02 |
| cfriesen | but that we weren't planning on doing that | 22:02 |
| cfriesen | since shelve is already broken for UEFI NVRAM | 22:02 |
| sean-k-mooney | mriedem: right so we always defered part of it to after stien | 22:03 |
| sean-k-mooney | cfriesen: right but i assume you would like to fix those edgecase in trian? | 22:03 |
| *** sdake has joined #openstack-nova | 22:03 | |
| cfriesen | sean-k-mooney: I personally would love to. I don't think shelve is a big deal for our customers though. | 22:03 |
| sean-k-mooney | cfriesen: or rather you would like them to be fix but dont nessisarily want to have to be the one to fix them :) | 22:03 |
| mriedem | windriver doesn't shelve so it doesn't matter to them | 22:03 |
| *** markvoelker has quit IRC | 22:04 | |
| sean-k-mooney | so to summerise i get that the preference would be to punt unless both cold/live migrate and resize work by the end of the week? | 22:05 |
| *** sdake has quit IRC | 22:05 | |
| mriedem | i only have personal preferences | 22:06 |
| mriedem | and right now i feel the crushing weight of a deluge of last minute blueprints that need review right before FF | 22:07 |
| *** sdake has joined #openstack-nova | 22:07 | |
| dansmith | seriously, why are we even considering adding something we know we haven't fully implemented and thus can't move? | 22:07 |
| dansmith | we already have an embarrassing number of "yeah this works, BUT YOU CAN NEVER MOVE IT" things, IMHO | 22:08 |
| sean-k-mooney | dansmith: well live migration should work | 22:08 |
| sean-k-mooney | its just cold/rezise but fair point | 22:08 |
| *** mrjk_ has joined #openstack-nova | 22:08 | |
| sean-k-mooney | for livemigrat qemu copies the vtpm data iteslf but for cold we have to do it if i remember correctly | 22:08 |
| melwitt | mriedem: I guess this convo is as good segue as any to something I was thinking about, FFE process. do we want to do the ML post, etherpad request, sponsor gathering process we have done in the past? | 22:10 |
| *** mrjk has quit IRC | 22:10 | |
| dansmith | sean-k-mooney: so just the thing that *most* users will be able to trigger? | 22:10 |
| *** sdake has quit IRC | 22:10 | |
| *** imacdonn_ has joined #openstack-nova | 22:10 | |
| *** artom has quit IRC | 22:10 | |
| sean-k-mooney | dansmith: yes. i am actully feeling that we should punt unless it works too but it also seams quite small | 22:11 |
| *** imacdonn has quit IRC | 22:11 | |
| *** s10 has joined #openstack-nova | 22:11 | |
| sean-k-mooney | works -> is feature complete includign move operations | 22:11 |
| *** wolverineav has quit IRC | 22:12 | |
| *** _alastor_ has quit IRC | 22:13 | |
| sean-k-mooney | cfriesen: in anycase if you have someting that works im happy to test it with the other live migration feature im planning to test. | 22:13 |
| *** wolverineav has joined #openstack-nova | 22:13 | |
| cfriesen | sean-k-mooney: appreciated. | 22:13 |
| sean-k-mooney | cfriesen: i get the feeling all of them will be punted to train m1 however | 22:13 |
| *** sdake has joined #openstack-nova | 22:13 | |
| *** sdake has quit IRC | 22:13 | |
| cfriesen | :) | 22:13 |
| sean-k-mooney | if we can get numa/sriov/cross-cell migration landed in m1 with vtpm and bandwith mover opertion that would be a.) alot of work and b.) alot of valuable features landed early/late depending on your view point | 22:16 |
| *** erlon has quit IRC | 22:17 | |
| *** hongbin has joined #openstack-nova | 22:17 | |
| dansmith | melwitt: what are the things that are realistically candidates for FFE? | 22:17 |
| *** agopi has joined #openstack-nova | 22:19 | |
| *** _alastor_ has joined #openstack-nova | 22:20 | |
| mriedem | jaypipes: good question on "wtf happens if the port is detached (or deleted) out of band while it has allocations" | 22:20 |
| *** _alastor_ has quit IRC | 22:20 | |
| mriedem | jaypipes: i replied, but tl;dr - we don't handle it, | 22:20 |
| mriedem | and it really kind of sucks that we (nova) are the ones managing that | 22:21 |
| sean-k-mooney | if you delete it in neutron the send an event to nova which causes it to be detach form the vm | 22:21 |
| mriedem | bzzt! | 22:22 |
| mriedem | the nova code relies on getting the allocation information from the port's binding:profile | 22:22 |
| mriedem | so if the port is deleted, we can't very well look it up | 22:22 |
| sean-k-mooney | well it should be in the network info cache but yes that might be an issue | 22:22 |
| mriedem | so either neutron needs to cleanup the allocation, or we have to store information about the allocation in the info cache | 22:23 |
| mriedem | none of this is in the info cache | 22:23 |
| mriedem | none of the requested resources / allocations stuff | 22:23 |
| mriedem | i've asked gibi about that a few times, i.e. "you know if we just stored x in the info cache we could use it here rather than calling neutron" | 22:23 |
| sean-k-mooney | i had tought the vif:port_profile was in the vif object in the info cache but maybe not. i havent looked at it in a while | 22:24 |
| melwitt | dansmith: well, I'm not sure who would request one, but I thought maybe the detach root volume bp or volume-backed rebuild, or other smaller things like adding numa topo or server group to 'nova show' | 22:24 |
| mriedem | sean-k-mooney: oh i guess it is, the binding:profile that is | 22:24 |
| mriedem | i'm not sure it would be up to date... | 22:24 |
| mriedem | melwitt: the volume backed rebuild isn't happening i don't tink | 22:25 |
| mriedem | *think | 22:25 |
| sean-k-mooney | we sore https://github.com/openstack/nova/blob/master/nova/network/model.py#L378-L400 | 22:25 |
| dansmith | melwitt: okay both of those seemed to be too far and too large to be FFE material to me, | 22:25 |
| sean-k-mooney | which has the profile in it | 22:25 |
| dansmith | but granted I've been a bit disconnected | 22:25 |
| mriedem | and i'll be talking about root volume detach with Kevin_Zheng tonight but there are going to be issues with that as well | 22:25 |
| dansmith | to me, FFE is for the final push for something that is almost done and I guess nothing pops out in my head at the moment as obviously fitting that description | 22:25 |
| mriedem | sean-k-mooney: yeah i know yo'ure right, so we might be able to handle the port getting deleted there | 22:25 |
| mriedem | sean-k-mooney: if the cache is up to date | 22:26 |
| melwitt | looks like the FFE process is supposed to kick in the week after freeze anyway, so I guess I'm thinking about it too early https://docs.openstack.org/nova/latest/contributor/process.html#non-priority-feature-freeze | 22:26 |
| mriedem | well how many weeks are there between FF and RC1? | 22:26 |
| mriedem | if it's 2, there isn't really time for FFE unless like dansmith it's a low risk change that is already there | 22:26 |
| melwitt | 2 | 22:27 |
| melwitt | ok. last cycle I didn't raise the FFE process because I assumed there wasn't enough time and this time I wanted to make sure I brought it up | 22:28 |
| sean-k-mooney | so the event we get i think will be a network-vif-unplugged event which is handeled by the periodic task the updated the network info cache. we might be able to hook that event in the periodic job to do the clean up | 22:28 |
| sean-k-mooney | i can try and take a look at that code tomrrow. im a bitt too tired to look this evening | 22:29 |
| mriedem | is it network-vif-unplugged or network-changed? | 22:29 |
| mriedem | because we do different things in that ase | 22:29 |
| mriedem | *case | 22:29 |
| *** avolkov has quit IRC | 22:30 | |
| mriedem | anyway, i left comments on https://review.openstack.org/#/c/622421/ so gibi can sort it out and at least leave TODOs to handle those | 22:30 |
| sean-k-mooney | i think you will get both. you will get an network-vif-unpluged for the ovs agent when it tears down the port and a newtork-changed event form the deletion | 22:30 |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 22:31 |
| mriedem | oh i was talking about the case that someone (the admin?) sets the device_id on the port to None/'' | 22:31 |
| mriedem | so the port isn't deleted, it's just detached from the server | 22:31 |
| mriedem | granted one should probably never do that, and cinder doesn't allow you to detach like that (unless you force it) | 22:32 |
| sean-k-mooney | oh am a.) the whould not do that :) and b.) ... i can test that tomorrow and let you know what happens. neutron will allow note allow you to set it to the python None but it will allow you to set it to the string "None" | 22:33 |
| sean-k-mooney | * a.) they should not... | 22:34 |
| mriedem | melwitt: the api change for this is merged https://review.openstack.org/#/c/636779/ so if you get a minute can you review the novaclient change, it should be pretty simple | 22:41 |
| mriedem | i'm taking that one out of runways though | 22:41 |
| mriedem | takashin: ^ | 22:41 |
| melwitt | mriedem: ok, can do. thanks | 22:41 |
| takashin | mriedem: Okay. I will review it. | 22:42 |
| mriedem | thanks | 22:42 |
| openstackgerrit | Merged openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459 | 22:43 |
| openstackgerrit | Merged openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 22:44 |
| openstackgerrit | Merged openstack/nova master: Use placement.inventory.inuse in report client https://review.openstack.org/568639 | 22:47 |
| melwitt | py27: commands succeeded | 22:50 |
| melwitt | congratulations :) | 22:50 |
| melwitt | *eyes shimmering* | 22:51 |
| sean-k-mooney | melwitt: :) what patch are you working on ? | 22:53 |
| melwitt | counting quota usage from placement | 22:53 |
| melwitt | when I see those green messages it's just like.... yess | 22:53 |
| sean-k-mooney | and that is always nice to see but it kill me when pythone 3 fails after python 2 passes | 22:53 |
| melwitt | oh yeah. that's bitten me before | 22:54 |
| *** tkajinam has joined #openstack-nova | 22:57 | |
| *** markvoelker has joined #openstack-nova | 23:01 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706 | 23:02 |
| *** _alastor_ has joined #openstack-nova | 23:03 | |
| yonglihe | mriedem: just rebase to new microversion. zuul running. | 23:04 |
| mriedem | yonglihe: yup i saw | 23:04 |
| cfriesen | FYI, in the context of this ^ commit, I'm taking over from jackding. | 23:04 |
| sean-k-mooney | cfriesen: ok. are you the only windriver person working on nova currently again? | 23:05 |
| sean-k-mooney | cfriesen: als that is targetign train right? stephen has reproposed the spec for train | 23:06 |
| cfriesen | sean-k-mooney: there are a couple other guys that will hopefully pop their heads up. :) | 23:06 |
| cfriesen | sean-k-mooney: that's targetting stein and is currently on a runway | 23:07 |
| cfriesen | sean-k-mooney: stephen proposed a whole separate thing for train | 23:07 |
| sean-k-mooney | oh ok | 23:07 |
| sean-k-mooney | ill also try and review that tomorrow so. | 23:07 |
| sean-k-mooney | anyway ill call it a day there o/ | 23:08 |
| cfriesen | sean-k-mooney: I just took a quick look at it, need to review it fully. looks like he's proposing defining a proper generic schema for the various properties/extra-specs | 23:08 |
| cfriesen | sean-k-mooney: later | 23:08 |
| sean-k-mooney | stephenfin: spec | 23:08 |
| sean-k-mooney | ya so there is a glance api we could already use | 23:09 |
| sean-k-mooney | but we migth want to seperate it out into a reusable lib or something | 23:09 |
| sean-k-mooney | he would like to have a single source to both use for validation and documentaiton generation acorss favor extraspec/image metatdata/volume metadata | 23:10 |
| *** awaugama has quit IRC | 23:10 | |
| sean-k-mooney | the glance metadef api does that allready but he is also considering other options | 23:10 |
| *** _alastor_ has quit IRC | 23:13 | |
| *** _alastor_ has joined #openstack-nova | 23:14 | |
| *** _alastor_ has quit IRC | 23:16 | |
| *** mlavalle has quit IRC | 23:16 | |
| *** cfriesen has quit IRC | 23:16 | |
| *** _alastor_ has joined #openstack-nova | 23:17 | |
| *** cfriesen has joined #openstack-nova | 23:17 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 23:17 |
| *** _alastor_ has quit IRC | 23:17 | |
| aspiers | who's our resident KVM / machinetype expert? | 23:18 |
| aspiers | I've just discovered a snag with SEV detection | 23:18 |
| aspiers | libvirt's virConnectGetDomainCapabilities() API requires specifying a particular arch and machine type | 23:19 |
| mriedem | aspiers: hook up with kash | 23:19 |
| mriedem | kashyap | 23:19 |
| aspiers | mriedem: thanks | 23:19 |
| *** mlavalle has joined #openstack-nova | 23:20 | |
| aspiers | so the results presumably could vary per architecture and machine type, although in practice it seems that if the SEV feature is supported, it is supported across all (arch, machine type) pairs the host provides | 23:20 |
| aspiers | but in order to detect the SEV capability (and provide a trait), this API call needs to be done during initHost() where arch/machtype is not known, rather than just before booting an instance when it is known | 23:21 |
| aspiers | since currently this getDomainCapabilities API call is only used for SEV detection and nothing else, I could hardcode it to x86_64 and a single machine type | 23:22 |
| *** _alastor_ has joined #openstack-nova | 23:22 | |
| aspiers | but that seems a bit ugly | 23:22 |
| aspiers | or I could call it once for each (arch, machine type) the host provides, and then if SEV is supported for any one of those tuples, mark the SEV capability as supported for the host | 23:23 |
| aspiers | but kashyap isn't currently here it seems ... | 23:24 |
| *** awalende has joined #openstack-nova | 23:31 | |
| melwitt | kashyap is EU time zone | 23:32 |
| aspiers | melwitt: OK thanks | 23:33 |
| *** markvoelker has quit IRC | 23:34 | |
| *** s10 has quit IRC | 23:34 | |
| *** awalende has quit IRC | 23:35 | |
| cfriesen | aspiers: don't we specify arch in the nova config? | 23:36 |
| aspiers | cfriesen: I don't think so | 23:37 |
| aspiers | but actually it's only one of two possibilities in the libvirt driver | 23:38 |
| aspiers | cfriesen: https://github.com/openstack/nova/blob/c7f0d160e4df95cc82706bcd8c4a9890a4dfeb51/nova/virt/libvirt/driver.py#L438 | 23:39 |
| aspiers | so I can iterate over those two, but that still leaves the question of machine type | 23:39 |
| aspiers | of which there are a zillion | 23:39 |
| cfriesen | aspiers: ah...I was actually thinking of the "hw_machine_type" config option | 23:39 |
| aspiers | ah yeah, that's different | 23:40 |
| aspiers | and that's only a default | 23:40 |
| cfriesen | right | 23:40 |
| aspiers | but it seems wrong to call the virConnectGetDomainCapabilities API twice for each known machine-type | 23:40 |
| aspiers | well not wrong, but inelegant at least | 23:40 |
| aspiers | and expensive | 23:41 |
| aspiers | not that initHost() happens often, but still ... | 23:41 |
| cfriesen | that is kind of icky. what if you stopped as soon as you got SEV supported for one machine type? | 23:41 |
| aspiers | well sure, could do that, but if I'm going to hardcode an assumption that this API call is only used for SEV capability detection then I could make it even simpler | 23:41 |
| cfriesen | I think you could just make a "can host support SEV" call which just checks one known-to-be-valid config | 23:42 |
| aspiers | exactly | 23:43 |
| aspiers | but then what if something else in the future needs other data from this API? | 23:43 |
| aspiers | or am I prematurely optimizing :) | 23:43 |
| cfriesen | which API exactly are you talking about? | 23:43 |
| aspiers | the one above | 23:44 |
| aspiers | virConnectGetDomainCapabilities | 23:44 |
| aspiers | actually I think I've just discovered a bug in libvirt | 23:44 |
| aspiers | virsh domcapabilities --virttype kvm --emulatorbin /usr/bin/qemu-kvm --arch x86_64 --machine pc-i440fx-1.4 | xq /domainCapabilities/features/sev/@supported actually returns 'yes' | 23:45 |
| aspiers | but SEV is not supported unless you use a q35 machine type | 23:45 |
| * aspiers reports it ... | 23:46 | |
| cfriesen | I think you could just add a little helper function in virt/libvirt/guest.py that calls virConnectGetDomainCapabilities, then add another "is sev supported" helper function that calls the guest.py routine and is in turn called from LibvirtDriver.init_host() | 23:48 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Improve libvirt image and snapshot handling https://review.openstack.org/616692 | 23:48 |
| *** _alastor_ has quit IRC | 23:57 | |
| *** _alastor_ has joined #openstack-nova | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!