| *** Swami has quit IRC | 00:02 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Add recreate test for bug 1798163 https://review.openstack.org/611314 | 00:42 |
|---|---|---|
| openstack | bug 1798163 in OpenStack Compute (nova) rocky "Placement incomplete consumers online migration fails" [Critical,In progress] https://launchpad.net/bugs/1798163 - Assigned to Matt Riedemann (mriedem) | 00:42 |
| *** tetsuro has joined #openstack-nova | 01:03 | |
| *** brinzhang has joined #openstack-nova | 01:04 | |
| *** brinzhang has quit IRC | 01:04 | |
| *** brinzhang has joined #openstack-nova | 01:05 | |
| *** markvoelker has joined #openstack-nova | 01:05 | |
| *** markvoelker has quit IRC | 01:09 | |
| *** brinzhang has quit IRC | 01:10 | |
| *** brinzhang has joined #openstack-nova | 01:11 | |
| *** brinzhang has quit IRC | 01:12 | |
| *** k_mouza has joined #openstack-nova | 01:12 | |
| *** brinzhang has joined #openstack-nova | 01:13 | |
| *** k_mouza has quit IRC | 01:17 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:20 | |
| *** imacdonn has quit IRC | 01:22 | |
| *** imacdonn has joined #openstack-nova | 01:22 | |
| *** mrsoul has joined #openstack-nova | 01:23 | |
| *** tommylikehu has joined #openstack-nova | 01:27 | |
| *** erlon__ has quit IRC | 01:29 | |
| *** zhanglong has joined #openstack-nova | 01:32 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 01:34 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 01:35 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 01:36 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): support compute node resource provider update https://review.openstack.org/521041 | 01:36 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): support compute node resource provider update https://review.openstack.org/521041 | 01:37 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: os-xenapi(n-rp): add traits for vgpu n-rp https://review.openstack.org/604269 | 01:37 |
| *** bhagyashris has joined #openstack-nova | 01:46 | |
| *** lei-zh has joined #openstack-nova | 01:48 | |
| *** mhen has quit IRC | 01:48 | |
| *** tetsuro has quit IRC | 01:49 | |
| *** mhen has joined #openstack-nova | 01:50 | |
| *** moshele has joined #openstack-nova | 01:50 | |
| *** tetsuro has joined #openstack-nova | 01:52 | |
| *** Dinesh_Bhor has quit IRC | 01:53 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge image_size extension response into image view builder https://review.openstack.org/606845 | 01:59 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove the caching the resource on Request object https://review.openstack.org/609403 | 01:59 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove more code related to extensions and testing https://review.openstack.org/607088 | 02:00 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove the extensions framework from wsgi.py https://review.openstack.org/607092 | 02:01 |
| gmann | stephenfin: alex_xu ^^ rebased the series, need to +A again. | 02:01 |
| *** moshele has quit IRC | 02:02 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:03 | |
| *** munimeha1 has joined #openstack-nova | 02:06 | |
| *** munimeha1 has quit IRC | 02:19 | |
| *** hongbin has joined #openstack-nova | 02:29 | |
| *** Dinesh_Bhor has quit IRC | 02:38 | |
| *** tetsuro has quit IRC | 02:42 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:47 | |
| *** psachin has joined #openstack-nova | 02:53 | |
| *** dave-mccowan has quit IRC | 02:56 | |
| *** lei-zh has quit IRC | 02:57 | |
| *** lei-zh has joined #openstack-nova | 02:58 | |
| *** rcernin has quit IRC | 03:02 | |
| *** bnemec has joined #openstack-nova | 03:05 | |
| *** bnemec has quit IRC | 03:10 | |
| *** deepak_mourya__ has joined #openstack-nova | 03:12 | |
| *** brinzhang has quit IRC | 03:17 | |
| *** brinzhang has joined #openstack-nova | 03:18 | |
| *** rcernin has joined #openstack-nova | 03:28 | |
| *** tetsuro has joined #openstack-nova | 03:35 | |
| *** owalsh_ has joined #openstack-nova | 03:39 | |
| *** owalsh has quit IRC | 03:43 | |
| *** hongbin has quit IRC | 03:57 | |
| *** Dinesh_Bhor has quit IRC | 04:05 | |
| *** brinzhang has quit IRC | 04:20 | |
| *** TuanDA has joined #openstack-nova | 04:40 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:44 | |
| *** udesale has joined #openstack-nova | 04:45 | |
| *** bhagyashris has quit IRC | 04:59 | |
| *** ccamacho has quit IRC | 05:03 | |
| *** Dinesh_Bhor has quit IRC | 05:13 | |
| *** lei-zh has quit IRC | 05:15 | |
| *** liuyulong has quit IRC | 05:24 | |
| *** lbragstad_503 has quit IRC | 05:27 | |
| *** lbragstad_503 has joined #openstack-nova | 05:27 | |
| *** deepak_mourya__ has quit IRC | 05:30 | |
| *** lei-zh has joined #openstack-nova | 05:38 | |
| *** ratailor has joined #openstack-nova | 06:01 | |
| *** hamdyk has joined #openstack-nova | 06:04 | |
| *** moshele has joined #openstack-nova | 06:13 | |
| *** Luzi has joined #openstack-nova | 06:15 | |
| *** TuanDA has quit IRC | 06:22 | |
| *** TuanDA has joined #openstack-nova | 06:23 | |
| *** sahid has joined #openstack-nova | 06:24 | |
| *** bhagyashris has joined #openstack-nova | 06:29 | |
| *** phillu has joined #openstack-nova | 06:31 | |
| *** adrianc has joined #openstack-nova | 06:38 | |
| *** rodolof has joined #openstack-nova | 06:44 | |
| *** phillu has quit IRC | 06:44 | |
| *** elod has quit IRC | 06:46 | |
| *** elod has joined #openstack-nova | 06:47 | |
| *** janki has joined #openstack-nova | 06:51 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova-specs master: Spec: Support filtering by forbidden aggregate https://review.openstack.org/603352 | 06:58 |
| *** rcernin has quit IRC | 07:07 | |
| *** lpetrut has joined #openstack-nova | 07:09 | |
| *** alexchadin has joined #openstack-nova | 07:14 | |
| *** phillu_ has joined #openstack-nova | 07:17 | |
| *** phillu_ has quit IRC | 07:18 | |
| *** phillu has joined #openstack-nova | 07:18 | |
| *** alexchadin has quit IRC | 07:19 | |
| *** janki has quit IRC | 07:19 | |
| *** owalsh_ is now known as owalsh | 07:20 | |
| *** jcosmao has quit IRC | 07:22 | |
| *** helenafm has joined #openstack-nova | 07:22 | |
| *** ralonsoh has joined #openstack-nova | 07:26 | |
| *** ralonsoh has quit IRC | 07:27 | |
| *** ralonsoh has joined #openstack-nova | 07:28 | |
| *** openstackgerrit has quit IRC | 07:35 | |
| *** phillu has quit IRC | 07:39 | |
| *** k_mouza has joined #openstack-nova | 07:42 | |
| *** phillu has joined #openstack-nova | 07:42 | |
| *** k_mouza has quit IRC | 07:50 | |
| *** dpawlik has quit IRC | 07:55 | |
| *** dtantsur|afk is now known as dtantsur | 07:56 | |
| *** slaweq has joined #openstack-nova | 08:02 | |
| *** ttsiouts has joined #openstack-nova | 08:03 | |
| *** jangutter has quit IRC | 08:05 | |
| *** jangutter has joined #openstack-nova | 08:06 | |
| *** TuanDA has quit IRC | 08:06 | |
| *** TuanDA has joined #openstack-nova | 08:07 | |
| *** ttsiouts has quit IRC | 08:09 | |
| *** k_mouza has joined #openstack-nova | 08:11 | |
| gibi | Kevin_Zheng: I've responded to you in https://review.openstack.org/#/c/605785 | 08:12 |
| *** spatel has joined #openstack-nova | 08:12 | |
| *** dpawlik has joined #openstack-nova | 08:13 | |
| Kevin_Zheng | gibi, Oh, yes, I will check ASAP, I was busy on something else, these days, sorry for the late response | 08:13 |
| gibi | Kevin_Zheng: no problem, take your time. :) | 08:13 |
| *** ttsiouts has joined #openstack-nova | 08:15 | |
| *** tssurya has joined #openstack-nova | 08:16 | |
| *** spatel has quit IRC | 08:17 | |
| *** rodolof has quit IRC | 08:18 | |
| bauzas | oh oops my manners | 08:18 |
| bauzas | good morning Novaz | 08:18 |
| gibi | bauzas: good morning | 08:18 |
| Kevin_Zheng | gibi, I still don't get the reason for NoValidHost exception | 08:24 |
| *** ttsiouts has quit IRC | 08:24 | |
| Kevin_Zheng | I got the point you illustrate in both case 1 and 2 | 08:25 |
| gibi | Kevin_Zheng: bottom line, nova cannot always detect if the server would need complex allocation on the destination. When nova cannot detect that Nova cannot raise other than NoValidHost as that is the generic exception used when placement allocation fails | 08:25 |
| *** tetsuro has quit IRC | 08:25 | |
| gibi | Kevin_Zheng: so there will be always cases when nova raise NoValidHost because of complex allocation would be needed | 08:26 |
| *** k_mouza has quit IRC | 08:26 | |
| gibi | Kevin_Zheng: therefore I think it will be even more confusing to raise NoValidHost is some case and ComplexAllocationNotSupported exception in other cases when both situations has the same root casuse, the need for the complex allocation | 08:27 |
| Kevin_Zheng | OK, I got your point | 08:28 |
| *** ralonsoh_ has joined #openstack-nova | 08:29 | |
| gibi | Kevin_Zheng: I can inform the user properly in half of the cases :/ | 08:29 |
| Kevin_Zheng | Hmm, but maybe it will still be miss leading, as an user, I can see that I still have resources in the cloud | 08:30 |
| gibi | Kevin_Zheng: this is basically a chiken-and-egg problem. The need of complex allocation on the destination can only be detected in every case if placement a_c is called. But force flag is defined in a way that it forbids calling the scheduler and placement | 08:30 |
| Kevin_Zheng | but you tell me that there is no valid host? | 08:30 |
| *** ralonsoh has quit IRC | 08:31 | |
| gibi | Kevin_Zheng: only if you specify the force flag | 08:31 |
| gibi | Kevin_Zheng: the root of the problem is the definition of the force flag | 08:31 |
| *** ttsiouts has joined #openstack-nova | 08:31 | |
| gibi | Kevin_Zheng: it forces (sic) nova to decide without the scheduler. But when we introduced placement in the picture nova lost the possibility to decide without consulting placement | 08:32 |
| Kevin_Zheng | Hmm, there is a log, but the logs may only be available for ``operators``, if we had ``admins`` that can use force flag, this might still be confusing? | 08:33 |
| gibi | Kevin_Zheng: there is no specific log in case #2. In case #2 nova tries to blind copy the flat soruce allocation to the dest but on the dest the root RP does not have enough resources therefore it is a NoValidHost | 08:34 |
| gibi | Kevin_Zheng: it is indistinguishable from the case when the dest would allow flat alloaction but we run out of resources on the dest | 08:35 |
| Kevin_Zheng | Hmm, thats true | 08:35 |
| Kevin_Zheng | Ok, I'm convienced | 08:35 |
| Kevin_Zheng | :) | 08:35 |
| *** Dinesh_Bhor has joined #openstack-nova | 08:37 | |
| *** derekh has joined #openstack-nova | 08:39 | |
| gibi | Kevin_Zheng: I understand that it is not a good situation from the user perspective. But force flag cannot be supproted any more as it is defined today. This is why I proposed to remove that flag in the future | 08:39 |
| *** alexchadin has joined #openstack-nova | 08:40 | |
| Kevin_Zheng | yes, I understand, but I think it might be very widely used for admins, as you mentioned, it has already been discussed, and it is free to propose better solutions, I think I will try to dig deeper. | 08:41 |
| *** ttsiouts has quit IRC | 08:43 | |
| *** ratailor has quit IRC | 08:43 | |
| *** ratailor has joined #openstack-nova | 08:43 | |
| gibi | Kevin_Zheng: in the ML post I tried to give alternatives http://lists.openstack.org/pipermail/openstack-dev/2018-October/135551.html | 08:44 |
| gibi | Kevin_Zheng: option #D) would be one way out but that would be bad from other perspective (inconsisten resource allocation) | 08:44 |
| *** Shilpa has joined #openstack-nova | 08:46 | |
| *** pooja-jadhav has joined #openstack-nova | 08:46 | |
| *** ShilpaSD has quit IRC | 08:46 | |
| *** pooja_jadhav has quit IRC | 08:46 | |
| *** ralonsoh_ is now known as ralonsoh | 08:56 | |
| *** k_mouza has joined #openstack-nova | 09:01 | |
| *** dpawlik has quit IRC | 09:02 | |
| *** Dinesh_Bhor has quit IRC | 09:03 | |
| *** sean-k-mooney has joined #openstack-nova | 09:04 | |
| *** dpawlik has joined #openstack-nova | 09:04 | |
| sean-k-mooney | o/ | 09:04 |
| *** k_mouza has quit IRC | 09:06 | |
| jangutter | sean-k-mooney: in your absence, it was discovered that random failures in the gate uncovered a bug: https://review.openstack.org/#/c/611017 | 09:25 |
| *** Dinesh_Bhor has joined #openstack-nova | 09:28 | |
| sean-k-mooney | jangutter: oh looking | 09:31 |
| *** Dinesh_Bhor has quit IRC | 09:31 | |
| sean-k-mooney | jangutter: am.. that should not chage anything | 09:32 |
| sean-k-mooney | the real code check that its sys.platform != 'nt' | 09:32 |
| sean-k-mooney | what you call the linux one has no effect on the code | 09:33 |
| *** pooja-jadhav is now known as pooja_jadhav | 09:33 | |
| sean-k-mooney | although may be im think of os.name | 09:34 |
| sean-k-mooney | oh i see the bug... | 09:35 |
| jangutter | sean-k-mooney: yeah, it basically turned the gate into a handy fuzzer. | 09:35 |
| sean-k-mooney | ya ill quick approve that. its not the first time i have seen people assign directly to a module before and override things | 09:35 |
| *** adrianc has quit IRC | 09:36 | |
| jangutter | sean-k-mooney: the follow-on is a bit hinky, not sure what hyperv should do: does it need to delete anything, or is it just a handle that disappears when the port gets deleted? | 09:36 |
| sean-k-mooney | jangutter: ya there was anothter patch in the past where someone on my team assigned a mock to a module then then sepnt a day trying to figure out why random test were failing | 09:37 |
| jangutter | sean-k-mooney: I hit the trifecta, I triggered this randomly on macos, where the error appeared to say: you can't run this linux command on Windows! | 09:38 |
| sean-k-mooney | jangutter: well osx is not supported at all but ill ignore that | 09:38 |
| *** bhagyashris has quit IRC | 09:39 | |
| sean-k-mooney | so on the delete port thing i was personally thinking of removeing that call from the ovs-lib | 09:39 |
| sean-k-mooney | jangutter: that said there is a delete_netdev flag so im ok with you patch as is for now | 09:40 |
| *** ttsiouts has joined #openstack-nova | 09:40 | |
| jangutter | sean-k-mooney: yah, you know anyone on hyperv able to tell if it's the right thing to do (tm)? | 09:41 |
| sean-k-mooney | i do not really like the depency that delete_netdev adds between ovsdb module and linux_networking | 09:41 |
| sean-k-mooney | jangutter: well iptools and pyroute2 do not work on windows so i would think its correct :) | 09:41 |
| sean-k-mooney | eg your change | 09:42 |
| jangutter | sean-k-mooney: yeah, i also would like it if the ovsdb lib would be "thinner" and just do ovsdb things. | 09:42 |
| sean-k-mooney | jangutter: that is what it is ment to do | 09:43 |
| *** ttsiouts has quit IRC | 09:43 | |
| *** betherly has joined #openstack-nova | 09:43 | |
| sean-k-mooney | other then this one call to delete the nedev device i dont think it does more today | 09:43 |
| jangutter | sean-k-mooney: the set mtu thingy too. | 09:43 |
| sean-k-mooney | well that is tricky but we can split it | 09:44 |
| sean-k-mooney | for vhost user that has to be done via the ovsdb | 09:44 |
| sean-k-mooney | i have no issue with making it explict per vif type however and invoking it in the ovs.py file | 09:45 |
| jangutter | sean-k-mooney: yep, any abstraction eventually becomes leaky. a working fix is better than a perfect fix that's never implemented. | 09:45 |
| sean-k-mooney | ideally the ovsdb module should be cross plathform | 09:46 |
| jangutter | sean-k-mooney: and pushing out the complexity towards the plugin "feels" right in my opinion. | 09:46 |
| sean-k-mooney | jangutter: so on a related topic. i want to improve the testing in os-vif. i will hopefully get around to adding a linux bridge job and mayboe an ovs-iptables job or ovn. | 09:47 |
| sean-k-mooney | we talked in the past about a agilo ovs ci do you have one running on your plugin? | 09:48 |
| sean-k-mooney | if so it might be nice to trigger it on a restited set of os-vif files also | 09:49 |
| jangutter | sean-k-mooney: heh, in theory yes, in practice it's been busted for ages. | 09:49 |
| sean-k-mooney | ok :) | 09:49 |
| jangutter | sean-k-mooney: (on expanding the tests, is this more or less in the right direction for "future os-vif"? https://review.openstack.org/#/c/610636/ ) | 09:50 |
| *** alexchadin has quit IRC | 09:50 | |
| *** ttsiouts has joined #openstack-nova | 09:51 | |
| *** priteau has joined #openstack-nova | 09:52 | |
| sean-k-mooney | i was just opening that :) | 09:54 |
| *** hamdyk has quit IRC | 09:54 | |
| *** hamdyk has joined #openstack-nova | 09:55 | |
| sean-k-mooney | jangutter: so one change to that interface that i think we will need to do is be able to pass in the tree and then filter it | 09:57 |
| jangutter | sean-k-mooney: you mean something like https://github.com/openstack/nova/blob/kilo-eol/nova/objects/instance.py#L257 | 09:58 |
| sean-k-mooney | no | 09:59 |
| jangutter | sean-k-mooney: ah, I see what you mean. Rather than self-editing the object, return a new one with the filtered fields? | 09:59 |
| sean-k-mooney | yes or rather host_info would retrun an unfiltered tree and then we would have a sperate filter function | 10:00 |
| sean-k-mooney | the reason for this is i think we will want to have nova call host info and then filter by what the hypervior can support then serialser it and send it to neutron | 10:01 |
| jangutter | sean-k-mooney: I had the same thought, it feels dirty to self-edit. | 10:01 |
| sean-k-mooney | then neutron will want to filter it again and select a vif type from what is left | 10:01 |
| jangutter | sean-k-mooney: filter should be a static function, not a member function. | 10:01 |
| sean-k-mooney | ya proably it could be a class function that take steh tree as the second argument but a static fucntion would work just as well | 10:03 |
| *** openstackgerrit has joined #openstack-nova | 10:03 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104 | 10:03 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106 | 10:03 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110 | 10:04 |
| jangutter | sean-k-mooney: cool, will refactor the refilter. | 10:05 |
| sean-k-mooney | :) cool the main issue is this part of the api was actully just a poc that was cerated without really thinking about how it would be used | 10:06 |
| *** ttsiouts has quit IRC | 10:06 | |
| *** ttsiouts has joined #openstack-nova | 10:07 | |
| jangutter | sean-k-mooney: yep, and I realised while doing Jay's proposal for the offload metadata that if I don't work on this, it's going to result in another poor idiot thinking about this later. | 10:09 |
| *** tbachman has quit IRC | 10:11 | |
| *** ttsiouts has quit IRC | 10:11 | |
| *** adrianc has joined #openstack-nova | 10:12 | |
| sean-k-mooney | jangutter: ya so this is all laying the ground work for doing the negciation likely in T | 10:12 |
| sean-k-mooney | we could try and start it in Stein but i think that would be too tight to get the nova and neutron work done also | 10:12 |
| *** phillu has quit IRC | 10:23 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Use oslo_db.sqlalchemy.test_fixtures https://review.openstack.org/609352 | 10:29 |
| *** ralonsoh has quit IRC | 10:30 | |
| *** ralonsoh has joined #openstack-nova | 10:31 | |
| *** ralonsoh has quit IRC | 10:38 | |
| *** ralonsoh has joined #openstack-nova | 10:39 | |
| *** ttsiouts has joined #openstack-nova | 10:40 | |
| *** ttsiouts has quit IRC | 10:48 | |
| *** ttsiouts has joined #openstack-nova | 10:49 | |
| *** phillu has joined #openstack-nova | 10:50 | |
| *** zhanglong has quit IRC | 10:59 | |
| *** udesale has quit IRC | 11:04 | |
| *** lei-zh has quit IRC | 11:05 | |
| *** erlon__ has joined #openstack-nova | 11:11 | |
| *** icey has quit IRC | 11:30 | |
| *** ratailor has quit IRC | 11:32 | |
| *** icey has joined #openstack-nova | 11:34 | |
| pooja_jadhav | hi team, I have some doubt in the https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_simple_tenant_usage.py#L135-L143.. In this they are trying to create 10 instances but when I have debug the code, I can see 20 istances. (1 instances repeated again). Can anyone guide me for the same? | 11:36 |
| *** s10 has joined #openstack-nova | 11:36 | |
| *** READ10 has quit IRC | 11:37 | |
| *** tbachman has joined #openstack-nova | 11:37 | |
| *** panda is now known as panda|lunch | 11:39 | |
| *** owalsh has quit IRC | 11:43 | |
| *** tbachman has quit IRC | 11:45 | |
| openstackgerrit | Martin Midolesov proposed openstack/nova master: Implementing graceful shutdown. https://review.openstack.org/608704 | 11:54 |
| *** owalsh has joined #openstack-nova | 11:59 | |
| *** tbachman has joined #openstack-nova | 12:04 | |
| *** tommylikehu has quit IRC | 12:07 | |
| *** TuanDA has quit IRC | 12:07 | |
| *** ttsiouts has quit IRC | 12:11 | |
| *** owalsh_ has joined #openstack-nova | 12:13 | |
| *** panda|lunch is now known as panda | 12:13 | |
| *** spatel has joined #openstack-nova | 12:14 | |
| *** owalsh has quit IRC | 12:15 | |
| *** owalsh_ has quit IRC | 12:16 | |
| *** owalsh has joined #openstack-nova | 12:16 | |
| *** spatel has quit IRC | 12:19 | |
| *** ttsiouts has joined #openstack-nova | 12:23 | |
| pooja_jadhav | sean-k-mooney: Hi | 12:23 |
| sean-k-mooney | jangutter: fyi your patch is still in the gate which is why the next patach has the -2 since its not merged yet | 12:23 |
| sean-k-mooney | pooja_jadhav: hi | 12:23 |
| pooja_jadhav | sean-k-mooney: I have some doubt in the https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_simple_tenant_usage.py#L135-L143.. In this they are trying to create 10 instances but when I have debug the code, I can see 20 instances. (1 instances repeated again). Can you guide me for the same? | 12:24 |
| jangutter | sean-k-mooney: I tried looking for any os-vif patches in the gate and it seemed to have silently disappeared. | 12:26 |
| sean-k-mooney | looking at it. depending on what _fake_instance does it looks like this should create tenahts*servers fake instance objecst | 12:27 |
| *** eharney has joined #openstack-nova | 12:27 | |
| sean-k-mooney | jangutter: ok well its there now http://zuul.openstack.org/status if you put 611017 in the filter | 12:27 |
| *** liuyulong has joined #openstack-nova | 12:27 | |
| sean-k-mooney | sometimes it takes a minute for it to post back after it leaves the queue | 12:28 |
| sean-k-mooney | pooja_jadhav: was there somthing in partcaller that you were confusted by regarding https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_simple_tenant_usage.py#L135-L143 | 12:29 |
| *** dims has quit IRC | 12:30 | |
| pooja_jadhav | sean-k-mooney: sorry, I am not getting what u mean to say | 12:31 |
| *** owalsh has quit IRC | 12:31 | |
| sean-k-mooney | pooja_jadhav: https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_simple_tenant_usage.py#L136-L143 is is construcint an InstanceList by initalisint the objects filed with a list comprehention | 12:32 |
| sean-k-mooney | it is first calulating a rag by multipliying tenants by server then for each x in that range it is calling _fake_instance | 12:32 |
| pooja_jadhav | sean-k-mooney: the issue i am facing like, I am creating 2 instances then in the simple tenant usage api should give me usgaes for that 2 instances only. but I can see 4 instance instead | 12:33 |
| *** dims has joined #openstack-nova | 12:33 | |
| *** lpetrut has quit IRC | 12:33 | |
| pooja_jadhav | correct | 12:34 |
| pooja_jadhav | SERVERS = 5 and TENANTS = 2 (it should create 10 instances) | 12:34 |
| sean-k-mooney | TENANTS and SERVERS are not paramaters to the function | 12:34 |
| pooja_jadhav | correct? | 12:34 |
| sean-k-mooney | yes | 12:34 |
| pooja_jadhav | but when I see the instanceList, in that I can see 20 instances | 12:35 |
| *** ttsiouts has quit IRC | 12:35 | |
| pooja_jadhav | 1 instance is repeating again (twice) | 12:35 |
| pooja_jadhav | for the existing test cases only | 12:35 |
| sean-k-mooney | can yo point me to a failing test? | 12:36 |
| pooja_jadhav | test is not failing right now | 12:36 |
| pooja_jadhav | actually, I am writting new test for simple tenant usage api for my fix | 12:36 |
| pooja_jadhav | at that time, I was able to see this behaviour | 12:36 |
| pooja_jadhav | ideally, if instance_list is giving 2 instances then for simple tenant usage should give usages for 2 instances only. | 12:38 |
| sean-k-mooney | pooja_jadhav: can you push the fialing test case it would be eaier to debug it with logs | 12:38 |
| *** mriedem has joined #openstack-nova | 12:38 | |
| pooja_jadhav | test is not failing | 12:38 |
| pooja_jadhav | mriedem ^^ | 12:39 |
| sean-k-mooney | yes but it would be useful if i could see how you were using this fucntion | 12:39 |
| sean-k-mooney | can you at leat past bin it somehwere | 12:39 |
| pooja_jadhav | yes | 12:39 |
| sean-k-mooney | fake_get_active_by_window_joined intally at least looks correct. | 12:40 |
| sean-k-mooney | im wondering are you calling https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_simple_tenant_usage.py#L116-L132 somehow? | 12:40 |
| pooja_jadhav | http://paste.openstack.org/show/732423/ | 12:41 |
| *** adrianc has quit IRC | 12:41 | |
| *** adrianc has joined #openstack-nova | 12:42 | |
| pooja_jadhav | I am using fake_get_active_by_window_joined() only not fake_get_active_deleted_flavorless() | 12:42 |
| *** owalsh has joined #openstack-nova | 12:46 | |
| *** READ10 has joined #openstack-nova | 12:47 | |
| *** ttsiouts has joined #openstack-nova | 12:49 | |
| sean-k-mooney | pooja_jadhav: why are you patching a test function | 12:49 |
| pooja_jadhav | means? | 12:49 |
| pooja_jadhav | I am trying to add new test | 12:50 |
| *** psachin has quit IRC | 12:50 | |
| sean-k-mooney | sorry you are patching get_active_by_window_joined not fake_get_active_by_window_joined | 12:50 |
| pooja_jadhav | hmm | 12:50 |
| pooja_jadhav | I have mock this get_active_by_window_joined() and return_value set list of 2 instances (1 BFV and other is normal instance). | 12:51 |
| pooja_jadhav | In the simple tenant usage API, in the instance_list I can see 4 instances and same in response dict after get API as well | 12:52 |
| sean-k-mooney | yes so this is not using fake_get_active_by_window_joined at all | 12:52 |
| pooja_jadhav | yes | 12:53 |
| sean-k-mooney | what do you mean by the simple tenant api you can see 4 instances. you are working on unit test currectly so how can you see 4 instance when you dont have openstack running | 12:54 |
| pooja_jadhav | in the unit test, I am calling index method | 12:54 |
| pooja_jadhav | res_dict = self.controller.index(req) | 12:55 |
| sean-k-mooney | right but why are you not mocking out _tenant_usages_for_period and the view builder funcitons | 12:58 |
| sean-k-mooney | if you are wringing a unit test for index you should not be calling https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/simple_tenant_usage.py#L313 or https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/simple_tenant_usage.py#L322 within the test | 12:59 |
| pooja_jadhav | but for existing tests as well, they are moacking these above functions | 12:59 |
| sean-k-mooney | that is true that does not mean the exisiting test are well written. | 13:02 |
| sean-k-mooney | pooja_jadhav: can you try using a patch decorator syntax instead of the with condetex manager | 13:06 |
| sean-k-mooney | so precreate the expected dict before the test fuction and use @mock.patch('nova.objects.InstanceList.get_active_by_window_joined', expceted dicts) | 13:07 |
| sean-k-mooney | actully never mind it should be identical | 13:08 |
| *** cdent has joined #openstack-nova | 13:08 | |
| sean-k-mooney | pooja_jadhav: am i dont have time to dig into this more right now sorry. | 13:13 |
| pooja_jadhav | np | 13:13 |
| pooja_jadhav | i will dig out :) | 13:13 |
| pooja_jadhav | thanks for ur time | 13:13 |
| *** awaugama has joined #openstack-nova | 13:15 | |
| mriedem | cfriesen: i have a buttload of questions in the tpm spec https://review.openstack.org/#/c/571111/ | 13:22 |
| mriedem | mmedvede: any idea if emulated tpm is supported on pkvm? https://libvirt.org/formatdomain.html#elementsTpm | 13:23 |
| mriedem | tonyb: ^ | 13:23 |
| sean-k-mooney | moshele: is the ci testing os-vif broken http://13.74.249.42/16/610916/4/check-os-vif/OVS_HW_offload/1c9af37/logs/n-cpu.service.log.gz | 13:23 |
| sean-k-mooney | moshele: the failures seam to be related to looking up the represntors | 13:24 |
| moshele | sean-k-mooney: we has some environment issues with, but it should be working now | 13:24 |
| moshele | lennyb: right ^ | 13:25 |
| sean-k-mooney | i have approved https://review.openstack.org/#/c/611017 which is makeing a minior change to the unitiest code only and i was seeing this error. | 13:26 |
| sean-k-mooney | the test change cannont cause this faiure so i am assuming this is an ci env issue. | 13:27 |
| *** mvkr has quit IRC | 13:27 | |
| moshele | sean-k-mooney: I run recheck on the mellanox ci just to make sure it is working, if not I will talk to lennyb to fix it | 13:29 |
| *** munimeha1 has joined #openstack-nova | 13:29 | |
| sean-k-mooney | moshele: cool i just wanted to reach out as i do check the result but i also dont block patches if the melonox ci fails and i can determin the failure was unrelated to the current patch as it is in this case | 13:30 |
| *** lbragstad_503 is now known as lbragstad | 13:32 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api-ref: 'vcpus_total' doesn't reflect overcommit ratio https://review.openstack.org/611604 | 13:34 |
| stephenfin | jaypipes, mriedem: Would it ever make sense to remove the vcpus_used, vcpus_total from the hypervisor APIs, given that placement can do this stuff for us now? They're very misleading ^ | 13:36 |
| openstackgerrit | Merged openstack/nova-specs master: Update pypi url to new url https://review.openstack.org/582092 | 13:38 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Use assertRegex instead of assertRegexpMatches https://review.openstack.org/611608 | 13:40 |
| lennyb | moshele, sean-k-mooney I am rechecking the issue | 13:43 |
| *** bnemec has joined #openstack-nova | 13:43 | |
| mriedem | stephenfin: we've talked about it, and at the last ptg too | 13:45 |
| *** mdbooth has joined #openstack-nova | 13:45 | |
| mriedem | or just have that API proxy to placement | 13:45 |
| * stephenfin goes to look at the notes | 13:45 | |
| *** jcosmao has joined #openstack-nova | 13:47 | |
| stephenfin | mriedem: This is the "What does shared storage provider support in nova give us? What does it fix?" section, I assume? | 13:47 |
| mriedem | yes | 13:48 |
| sean-k-mooney | stephenfin: perhaps. we did discuss it in the context of the local_gb field but we also disucssed should we just remove the hypervior api or as mriedem said make be a proxy to the relevent data from plancement in the future | 13:49 |
| stephenfin | My next question was "I thought we don't do proxies any more", but I do vaguely recall a discussion about how this was special. Maybe that was something else though. Is it special? | 13:49 |
| mriedem | it's definitely low priority | 13:50 |
| sean-k-mooney | stephenfin: i would personally prefer to deprecate, document how to query placement for the same infor and remove but is it special. i am sure it is to somemone but i dont think its a vital api | 13:51 |
| mriedem | dansmith: your +W awaits https://review.openstack.org/#/c/611084/ | 13:51 |
| dansmith | mriedem: my +W waits for no man | 13:51 |
| stephenfin | mriedem: ack, just curious after awaugama's struggles yesterday | 13:52 |
| *** mchlumsky has joined #openstack-nova | 13:52 | |
| sean-k-mooney | stephenfin: by the way for https://review.openstack.org/#/c/611604 that is expected | 13:52 |
| mriedem | stephenfin: so what's the tl;dr on that? the vcpus_used/total was a red herring? | 13:53 |
| stephenfin | sean-k-mooney: Expected but not documented, from what I could see. Best to document these things | 13:53 |
| stephenfin | mriedem: I actually don't know. I haven't checked in with him yet today. awaugama? | 13:54 |
| sean-k-mooney | that the field that report how many hypervior cpus you have is not multipled by an over commit | 13:54 |
| stephenfin | sean-k-mooney: Yeah, I know. That's why I'm seeking to explicitly call it out :) | 13:55 |
| stephenfin | (I didn't know that before yesterday as it doesn't matter for dedicated cores) | 13:55 |
| awaugama | mriedem, stephenfin: waiting to sync with bauzas to go over it | 13:56 |
| sean-k-mooney | stephenfin: but you are adding noise... fine but a more meaningful addtion would be to expcitly point or this corresponds to the number of phyical threads availbale on the hyperviors | 13:56 |
| *** mvkr has joined #openstack-nova | 13:57 | |
| *** mchlumsky has quit IRC | 13:57 | |
| stephenfin | sean-k-mooney: Those would make for some good review comments :) | 13:58 |
| *** mchlumsky has joined #openstack-nova | 13:59 | |
| mriedem | i left some | 13:59 |
| sean-k-mooney | stephenfin: i was trying not to have to leave a -1 but ok ill add them | 13:59 |
| mriedem | nova meeting time | 14:00 |
| gibi | nova meeting is starting in #openstack-meeting | 14:00 |
| bauzas | awaugama: sorry, I'm swamped under multiple internal issues | 14:01 |
| awaugama | bauzas, all good. ping me when you've got a chance | 14:01 |
| bauzas | well, I thought I'd have a chance by this morning but then I got a meeting | 14:02 |
| bauzas | live my life | 14:02 |
| *** efried_pto is now known as efried | 14:06 | |
| *** slaweq has quit IRC | 14:06 | |
| *** slaweq has joined #openstack-nova | 14:08 | |
| *** ttsiouts has quit IRC | 14:10 | |
| dansmith | mriedem, tssurya: just FYI, I figured out the big weird functional test failure that was hitting the down cell series | 14:12 |
| dansmith | it's in our fixture, luckily, but I need to figure out how to fix it in a way that isn't terrible | 14:12 |
| tssurya | dansmith: you did ?! | 14:13 |
| dansmith | tssurya: yeah | 14:13 |
| dansmith | tssurya: took me a while because I'm slow | 14:13 |
| mriedem | slow but powerful | 14:13 |
| tssurya | I couldn't.. have been at it for some time, then I got busy with some other stuff downstream | 14:13 |
| dansmith | we're racing to double-lock a lock | 14:13 |
| mriedem | that was our AS400 build process name when i started at ibm... | 14:13 |
| dansmith | so I need to make that safe for recursion somehow | 14:14 |
| *** hamzy has quit IRC | 14:15 | |
| tssurya | just to be sure dansmith, you are talking abotu these tests right ? http://logs.openstack.org/58/591658/10/check/nova-tox-functional-py35/ab65888/testr_results.html.gz | 14:16 |
| dansmith | tssurya: yep | 14:17 |
| tssurya | great :) thanks a lot for investigating, I wanted to bring it up at some point, but got busy | 14:17 |
| *** mlavalle has joined #openstack-nova | 14:21 | |
| *** ttsiouts has joined #openstack-nova | 14:21 | |
| *** phillu has quit IRC | 14:26 | |
| *** hamdykhader has joined #openstack-nova | 14:26 | |
| *** hamdyk has quit IRC | 14:29 | |
| *** ccamacho has joined #openstack-nova | 14:30 | |
| *** sambetts|afk is now known as sambetts | 14:31 | |
| *** hamdykhader has quit IRC | 14:38 | |
| *** hamzy has joined #openstack-nova | 14:42 | |
| *** moshele has quit IRC | 14:45 | |
| *** takashin has quit IRC | 14:51 | |
| *** moshele has joined #openstack-nova | 14:54 | |
| *** cdent has quit IRC | 14:54 | |
| *** egonzalez has quit IRC | 14:55 | |
| *** Swami has joined #openstack-nova | 14:56 | |
| *** egonzalez has joined #openstack-nova | 14:56 | |
| *** jmlowe has quit IRC | 14:57 | |
| *** takashin has joined #openstack-nova | 14:58 | |
| *** s10 has quit IRC | 14:59 | |
| *** ttsiouts has quit IRC | 15:00 | |
| *** Luzi has quit IRC | 15:01 | |
| *** itlinux has quit IRC | 15:01 | |
| mordred | mriedem: I got this bug: https://bugs.launchpad.net/shade/+bug/1798489 which I believe stems from when we switched to making direct rest calls for create_server ... I'm sure it's my fault... | 15:02 |
| openstack | Launchpad bug 1798489 in Shade "v4-fixed-ip / v6-fixed-ip no longer supported in shade for new vms" [Undecided,New] | 15:02 |
| melwitt | 15:02 | |
| mordred | mriedem: but I was looking for any mentoin of v4-fixed-ip in the api docs and can't find one | 15:02 |
| mordred | I suppose I don't actually need to only talk to mriedem about that :) | 15:02 |
| cfriesen | mriedem: geez, you weren't kidding about a bunch of comments on vTPM | 15:02 |
| mordred | anybody know off the top of their head if that's like an old option or something? | 15:03 |
| *** ttsiouts has joined #openstack-nova | 15:03 | |
| mordred | OH - I see it - it's a novaclient thing | 15:04 |
| *** tbachman has quit IRC | 15:05 | |
| *** dklyle has joined #openstack-nova | 15:06 | |
| *** takashin has left #openstack-nova | 15:06 | |
| frickler | mordred: osc has it, too http://git.openstack.org/cgit/openstack/python-openstackclient/tree/openstackclient/compute/v2/server.py#n531 | 15:11 |
| mordred | frickler: yah - so it does. it's just not actually a nova api thing - they all get sent as fixed_ip in the network dict to nova | 15:12 |
| *** betherly has quit IRC | 15:13 | |
| *** eharney has quit IRC | 15:16 | |
| lennyb | moshele, sean-k-mooney both patches passed https://review.openstack.org/#/c/610916/ and https://review.openstack.org/#/c/611017/ | 15:17 |
| sean-k-mooney | lennyb: thanks :) | 15:18 |
| *** tbachman has joined #openstack-nova | 15:18 | |
| *** cdent has joined #openstack-nova | 15:23 | |
| mriedem | mordred: was away - get it figured out? | 15:24 |
| cfriesen | got an interesting bug related to "bus=scsi" that someone else has confirmed....https://bugs.launchpad.net/nova/+bug/1792077 | 15:24 |
| openstack | Launchpad bug 1792077 in OpenStack Compute (nova) "problem specifying multiple "bus=scsi" block devices on nova boot" [Undecided,New] | 15:24 |
| mordred | mriedem: yah- there is an argument novaclient takes that isn't in the rest api that the switch from novaclient to REST lost support for | 15:24 |
| mriedem | ok | 15:24 |
| cfriesen | mdbooth: you might be interested in this ^ | 15:27 |
| *** phillu has joined #openstack-nova | 15:28 | |
| *** devananda has joined #openstack-nova | 15:30 | |
| *** tbachman has quit IRC | 15:32 | |
| mordred | mriedem, frickler: https://review.openstack.org/#/c/611651/ is the fix, just in case you're interested | 15:33 |
| mordred | frickler: I also pushed up an sdk patch for it so that we can support it from osc when we switch over | 15:34 |
| *** ttsiouts has quit IRC | 15:35 | |
| *** tbachman has joined #openstack-nova | 15:35 | |
| *** ccamacho has quit IRC | 15:36 | |
| *** ccamacho has joined #openstack-nova | 15:38 | |
| *** ttsiouts has joined #openstack-nova | 15:39 | |
| *** moshele has quit IRC | 15:40 | |
| *** hamzy has quit IRC | 15:42 | |
| *** hamzy has joined #openstack-nova | 15:43 | |
| *** gyee has joined #openstack-nova | 15:43 | |
| *** tssurya has quit IRC | 15:44 | |
| mriedem | melwitt: need this rocky backport https://review.openstack.org/#/c/611327/ | 15:45 |
| melwitt | on it | 15:46 |
| *** liuyulong has quit IRC | 15:46 | |
| *** liuyulong has joined #openstack-nova | 15:46 | |
| mriedem | we'll likely need a rocky release next week because we have at least 3 upgrade impacting issues | 15:47 |
| *** ccamacho has quit IRC | 15:47 | |
| melwitt | yeah, I was thinking we'd do the usual and do stable releases for everything along with s-1 | 15:47 |
| mriedem | also need https://review.openstack.org/#/c/611337/ | 15:47 |
| melwitt | unless there's a branch that doesn't have enough stuff in it | 15:47 |
| melwitt | but in general I think a lot goes into the stable branches even in a short-ish time | 15:48 |
| *** itlinux has joined #openstack-nova | 15:51 | |
| *** ttsiouts has quit IRC | 15:55 | |
| *** ttsiouts has joined #openstack-nova | 15:56 | |
| *** macza has joined #openstack-nova | 15:56 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Modify get_by_cell_and_project() to get_not_deleted_by_cell_and_project() https://review.openstack.org/607663 | 15:56 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Return a minimal construct for nova list when a cell is down https://review.openstack.org/567785 | 15:56 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Refactor scatter-gather utility to return exception objects https://review.openstack.org/607934 | 15:56 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Return a minimal construct for nova show when a cell is down https://review.openstack.org/591658 | 15:56 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Return a minimal construct for nova service-list when a cell is down https://review.openstack.org/584829 | 15:56 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make CellDatabases fixture reentrant https://review.openstack.org/611665 | 15:56 |
| dansmith | mriedem: that last one there is the fixture change.. would appreciate careful scrutiny | 15:57 |
| dansmith | seems to pass all existing tests and fix the (related) ones in the down cell stuff | 15:57 |
| *** dtantsur is now known as dtantsur|afk | 16:00 | |
| *** eharney has joined #openstack-nova | 16:00 | |
| *** cdent has quit IRC | 16:00 | |
| *** ttsiouts has quit IRC | 16:00 | |
| dansmith | mriedem: on that compute node uuid backport, | 16:02 |
| dansmith | I wanted to go think about it a little | 16:02 |
| *** phillu has quit IRC | 16:02 | |
| dansmith | I thought there were some assumptions that the ironic node uuid was the same as the compute node uuid, so you could correlate the resource provider | 16:02 |
| dansmith | but I also know we use the name (which is the ironic uuid) | 16:02 |
| dansmith | was that all worked out on the original? | 16:03 |
| *** helenafm has quit IRC | 16:03 | |
| mriedem | "I thought there were some assumptions that the ironic node uuid was the same as the compute node uuid" has never been the case | 16:03 |
| mriedem | before that change, the compute node uuid was always randomly generated when we created the record | 16:04 |
| mriedem | the compute node hypervisor_hostname is the ironic uuid | 16:04 |
| mriedem | https://github.com/openstack/nova/blob/stable/queens/nova/compute/resource_tracker.py#L585 | 16:05 |
| dansmith | right | 16:05 |
| mriedem | https://github.com/openstack/nova/blob/stable/queens/nova/objects/compute_node.py#L312 | 16:05 |
| dansmith | okay I see the breaking change was just a "it would be nice" so.. okay | 16:05 |
| mriedem | yeah | 16:05 |
| dansmith | there was that rebalance bug that was fixed, | 16:05 |
| dansmith | so I wanted to make sure it wasn't related to that, | 16:05 |
| *** sahid has quit IRC | 16:06 | |
| dansmith | but I was deep in that fixture debug so I didn't chase | 16:06 |
| dansmith | so cool enough | 16:06 |
| mdbooth | cfriesen: Fun | 16:07 |
| mdbooth | cfriesen: I haven't looked at the code, but I'm imagining it's probably going to be reasonably well confined to the libvirt driver. | 16:07 |
| mdbooth | IIRC the address assignment code is a bit janky | 16:08 |
| *** mriedem is now known as mriedem_lunch | 16:10 | |
| melwitt | mriedem_lunch: I didn't send a reminder email about specs in runways but I updated the text on the etherpad to say "Queue of Approved blueprints" | 16:11 |
| *** liuyulong is now known as liuyulong_zzz | 16:13 | |
| sean-k-mooney | melwitt: by the way im planning to rebase my sriov livemigration spec and add it to next weeks nova team open discussion but i was wondering what i should do with the blueprint. its still pending review/approval. should i add that also? | 16:14 |
| melwitt | sean-k-mooney: add it to open discussion? if you have the spec linked, I think that's enough | 16:14 |
| sean-k-mooney | ok cool. i have some rework to do for the spec but it should be ready for more review by then | 16:15 |
| *** dklyle has quit IRC | 16:16 | |
| *** dklyle has joined #openstack-nova | 16:16 | |
| *** Swami has quit IRC | 16:21 | |
| *** cdent has joined #openstack-nova | 16:24 | |
| *** macza has quit IRC | 16:33 | |
| *** moshele has joined #openstack-nova | 16:37 | |
| *** dklyle has quit IRC | 16:37 | |
| *** Shilpa has quit IRC | 16:37 | |
| melwitt | cfriesen: do you know if 'virtio-scsi' is the same thing as having the disk_info['bus'] == 'scsi' or are they not necessarily the same thing? I added a comment to the lp bug | 16:43 |
| *** s10 has joined #openstack-nova | 16:45 | |
| cfriesen | melwitt: not sure. not my area of expertise. | 16:46 |
| melwitt | oops, sorry. mdbooth maybe then ^ | 16:46 |
| openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Add spec for libvirt driver launching AMD SEV-encrypted instances https://review.openstack.org/609779 | 16:48 |
| *** s10 has quit IRC | 16:51 | |
| openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Add spec for libvirt driver launching AMD SEV-encrypted instances https://review.openstack.org/609779 | 16:52 |
| imacdonn | melwitt: not a specialty area for me either, but it looks like it might also want the controller model to be specified: https://ovirt.org/develop/release-management/features/storage/virtio-scsi/ | 16:53 |
| *** derekh has quit IRC | 16:54 | |
| imacdonn | melwitt: also https://libvirt.org/formatdomain.html#elementsControllers | 16:54 |
| melwitt | thanks imacdonn. I'm also reading through the original RFE that added the virtio-scsi disk numbering to the libvirt driver | 16:54 |
| melwitt | https://bugzilla.redhat.com/show_bug.cgi?id=1269577 | 16:55 |
| openstack | bugzilla.redhat.com bug 1269577 in openstack-nova "[RFE] Support more than six Virtio SCSI disks on a single bus controller" [Medium,Closed: errata] - Assigned to sferdjao | 16:55 |
| dansmith | melwitt: you can expose disks to a guest via scsi in multiple ways, virtio-scsi being one | 16:56 |
| dansmith | there's a sym5cxx model as well, IIRC | 16:56 |
| dansmith | probably not likely to be common these days, but it should still be supported AFAIK | 16:57 |
| imacdonn | "A scsi controller has an optional attribute model, which is one of 'auto', 'buslogic', 'ibmvscsi', 'lsilogic', 'lsisas1068', 'lsisas1078', 'virtio-scsi' or 'vmpvscsi'." | 16:57 |
| dansmith | yeah | 16:57 |
| melwitt | ok, yeah. the idea of that RFE was to have nova control the disk unit numbers only if using the virtio-scsi controller type | 16:57 |
| *** mvkr has quit IRC | 16:58 | |
| melwitt | AFAICT, the scsi controller type is only gettable from the image meta, so we're running into a problem if no image has been specified in the boot request. we initialize the disk numbering if model == 'virtio-scsi' there are other conditionals in the libvirt driver which are incrementing disk unit numbers only if 'bus' == 'scsi' (and not checking the controller model). so we're getting behavior where the disk unit number is being | 17:03 |
| melwitt | incremented but was never initialized | 17:03 |
| melwitt | and guest creation failing with duplicate drive address if more than one bus=scsi devices | 17:04 |
| melwitt | I'm wondering if there's a way to get the scsi controller model without the image meta | 17:05 |
| *** sambetts is now known as sambetts|afk | 17:07 | |
| melwitt | hm, but we are checking if 'unit' is in the disk mapping before incrementing, so you'd think that we're safely not incrementing unless initialized | 17:08 |
| *** munimeha1 has quit IRC | 17:10 | |
| sean-k-mooney | if i remember correctly there used to be a recomendation to use virtio-scsi over virtio block when you volumes were backed by ceph be cause of trim support in virtio scsi that was missing from virtio block | 17:13 |
| *** ircuser-1 has quit IRC | 17:15 | |
| sean-k-mooney | so i would not assume its that unlikely to want 6+ scsis but that said perhaps dansmith's comment was in relation to sym5cxx being uncommon not virtio-scsi | 17:15 |
| dansmith | sean-k-mooney: right, the emulation of a real device being the uncommon thing | 17:15 |
| dansmith | it's for unsupported or older guest operating systems at this point | 17:16 |
| sean-k-mooney | like centos 5 | 17:16 |
| dansmith | or windows 98 | 17:16 |
| sean-k-mooney | centos 5 hates virtio block devices for root disks... | 17:16 |
| sean-k-mooney | i think anything pre windows 7 did not ship virtio driver by default | 17:17 |
| sean-k-mooney | well vista might have | 17:17 |
| dansmith | I didn't know any did | 17:20 |
| dansmith | that's major progress | 17:20 |
| imacdonn | yeah, I didn't think Windows came with any VirtIO drivers either | 17:20 |
| imacdonn | I do know that the drivers have a vendor ID associated with them, and that matters for Windows Update .. because Oracle has our version, which has a different vendor ID than the Red Hat / Fedora ones | 17:21 |
| sean-k-mooney | windows 10 does i belive 7 and 8 both require installation duuring install time either from an iso or a web share but i was under teh impression you could donwloading from windows update during install | 17:21 |
| sean-k-mooney | imacdonn: the vendor id and prodoct id for virtio devices is an oasis standard now as far as i am aware | 17:23 |
| sean-k-mooney | imacdonn: yep https://www.oasis-open.org/committees/virtio/ | 17:23 |
| cfriesen | does anyone know how we handle UEFI NVRAM over shelve/unshelve? I'm guessing it's currently lost, the same way it's lost over cold migration and resize. | 17:29 |
| *** panda is now known as panda|off | 17:30 | |
| *** dklyle has joined #openstack-nova | 17:30 | |
| *** moshele has quit IRC | 17:30 | |
| *** mvkr has joined #openstack-nova | 17:41 | |
| *** dklyle has quit IRC | 17:42 | |
| *** hamzy has quit IRC | 17:44 | |
| *** betherly has joined #openstack-nova | 17:45 | |
| *** hamzy has joined #openstack-nova | 17:45 | |
| *** betherly has quit IRC | 17:49 | |
| *** dklyle has joined #openstack-nova | 17:50 | |
| *** mriedem_lunch is now known as mriedem | 17:51 | |
| *** priteau has quit IRC | 17:52 | |
| *** moshele has joined #openstack-nova | 18:02 | |
| *** dklyle has quit IRC | 18:02 | |
| openstackgerrit | Chris Friesen proposed openstack/nova-specs master: Add support for emulated virtual TPM https://review.openstack.org/571111 | 18:02 |
| *** betherly has joined #openstack-nova | 18:05 | |
| *** betherly has quit IRC | 18:09 | |
| imacdonn | mriedem: re backporting https://review.openstack.org/608091 ... I'd like to... I wonder if we need to do anything special, like a further release note that says that this changed after the initial release, or something.... | 18:16 |
| *** lbragstad has quit IRC | 18:17 | |
| mriedem | there is already an upgrade release note on it saying there is a new return code | 18:17 |
| imacdonn | yeah. I'm just pondering that it wasn't part of the original release ... I may be overthinking it | 18:18 |
| mriedem | original release...being whenever online_data_migrations was added? | 18:19 |
| mriedem | i think you're overthinking it | 18:19 |
| imacdonn | no, I mean, when Rocky was released, this change was not part of it .. but it's going to magically appear in an update release | 18:20 |
| *** dklyle has joined #openstack-nova | 18:20 | |
| mriedem | idk, we could just signal that by bumping the minor version on the release rather than the patch version | 18:20 |
| *** adrianc has quit IRC | 18:21 | |
| *** s10 has joined #openstack-nova | 18:22 | |
| imacdonn | that seems like a reasonable idea ... probably won't make much difference in reality, but trying to do the right thing | 18:23 |
| *** betherly has joined #openstack-nova | 18:24 | |
| imacdonn | it looks like a clean CP for Rocky ... a couple of easy conflicts for Queens .. haven't tried to go further than that yet | 18:24 |
| *** dklyle has quit IRC | 18:29 | |
| *** betherly has quit IRC | 18:29 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Document each libvirt.sysinfo_serial choice https://review.openstack.org/611426 | 18:32 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/pike: Handle volume API failure in _post_live_migration https://review.openstack.org/611093 | 18:32 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make CellDatabases fixture reentrant https://review.openstack.org/611665 | 18:38 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Modify get_by_cell_and_project() to get_not_deleted_by_cell_and_project() https://review.openstack.org/607663 | 18:38 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Return a minimal construct for nova list when a cell is down https://review.openstack.org/567785 | 18:38 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Refactor scatter-gather utility to return exception objects https://review.openstack.org/607934 | 18:38 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Return a minimal construct for nova show when a cell is down https://review.openstack.org/591658 | 18:38 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Return a minimal construct for nova service-list when a cell is down https://review.openstack.org/584829 | 18:38 |
| dansmith | I don't think that fixes all the tests, but a bunch, and figure it'll be quicker to let zuul have a crack at it | 18:39 |
| melwitt | what a slacker | 18:40 |
| *** lifeless has joined #openstack-nova | 18:44 | |
| *** betherly has joined #openstack-nova | 18:44 | |
| *** lbragstad has joined #openstack-nova | 18:48 | |
| *** betherly has quit IRC | 18:49 | |
| mriedem | dansmith: thinking out loud on how to break up my cross-cell-resize patch, i'm thinking: db model changes, versioned objects, compute (manager/rpc), compute API and then conductor at the end. API before conductor because conductor is what will set the Migration.cross_cell_move flag that makes the flow change. sound sane? everything else in the API is keyed off that migration.cross_cell_move flag. | 18:57 |
| *** panda|off has quit IRC | 18:59 | |
| *** panda has joined #openstack-nova | 19:00 | |
| *** tbachman has quit IRC | 19:00 | |
| *** hamzy has quit IRC | 19:07 | |
| *** dklyle has joined #openstack-nova | 19:07 | |
| *** hamzy has joined #openstack-nova | 19:08 | |
| *** dklyle has quit IRC | 19:14 | |
| *** itlinux has quit IRC | 19:16 | |
| openstackgerrit | sean mooney proposed openstack/nova-specs master: Add spec for sriov live migration https://review.openstack.org/605116 | 19:18 |
| dansmith | mriedem: sure | 19:18 |
| mriedem | artom: can you just fix the comment nit in https://review.openstack.org/#/c/587439/ and then i'm +2 | 19:20 |
| *** lbragstad has quit IRC | 19:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Cross-cell resize https://review.openstack.org/603930 | 19:23 |
| *** lbragstad has joined #openstack-nova | 19:24 | |
| openstackgerrit | iain MacDonnell proposed openstack/nova stable/rocky: Handle online_data_migrations exceptions https://review.openstack.org/611701 | 19:26 |
| eandersson | Why is the api version part of the endpoint in keystone? Is this a requirement or just a best practice? | 19:26 |
| eandersson | > "$nova_api_url/v2.1" | 19:27 |
| artom | mriedem, yep, thank you :) Who can we pester for your patch below mine? (This is another downstream pressure type situation) | 19:27 |
| mriedem | probably one of the many red hat cores | 19:27 |
| melwitt | haha, yeah. I was gonna say, you can pester me | 19:28 |
| mriedem | eandersson: good question for mordred | 19:28 |
| mordred | I didn't do it | 19:28 |
| eandersson | :D | 19:28 |
| artom | melwitt, consider yourself pestered :D | 19:29 |
| melwitt | :) | 19:29 |
| mordred | eandersson: either $nova_api_url/v2.1 or $nova_api_url should totally work with keystoneauth/openstacksdk/shade | 19:29 |
| mordred | eandersson: I think there are some older things out there that assume the thing in the catalog has the version appended | 19:29 |
| mordred | but for nova I believe most of them do the right thing either way | 19:30 |
| eandersson | So there might be an edge case that does not handle it properly | 19:30 |
| mordred | I *personally* prefer unversioned endpoint in catalog because putting versioned endpoint in catalog is what got us into the wole volumev2 volumev3 service-type mess | 19:30 |
| mordred | but I'm pretty sure nova isn't going to have a new major version in the new future, so putting a versioned nova endpoint in the catalog should be fine | 19:31 |
| mordred | hopefully you're enjoying how I'm not giving you an answer at all | 19:31 |
| eandersson | Yea I agree on unversioned | 19:33 |
| eandersson | It's also causing minor issues for us with a api proxy | 19:33 |
| eandersson | but might just be my lack of knowledge on nginx | 19:34 |
| eandersson | hehe | 19:34 |
| *** hamzy has quit IRC | 19:41 | |
| *** betherly has joined #openstack-nova | 19:44 | |
| *** devananda has quit IRC | 19:47 | |
| *** betherly has quit IRC | 19:48 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add nova-status upgrade check for consoles https://review.openstack.org/611214 | 19:49 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add rolling upgrade info to enable_consoleauth workaround reno https://review.openstack.org/611218 | 19:49 |
| *** moshele has quit IRC | 19:51 | |
| *** READ10 has quit IRC | 19:52 | |
| *** ralonsoh has quit IRC | 20:00 | |
| *** eharney has quit IRC | 20:03 | |
| *** hamzy has joined #openstack-nova | 20:10 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Ensure attachment cleanup on failure in driver.pre_live_migration https://review.openstack.org/587439 | 20:10 |
| artom | mriedem, ^^ | 20:10 |
| artom | Cheerio :) | 20:15 |
| *** openstackgerrit has quit IRC | 20:36 | |
| mriedem | efried: gibi: hoowee i just went through https://review.openstack.org/#/c/606050/ | 20:36 |
| mriedem | kind of a doozy | 20:36 |
| mriedem | dansmith: i believe ^ will mean that if we ever go down the non-migration-based allocation cleanup route on a same-host resize, we'll wipe out all allocations for the instance, including for the old_flavor | 20:37 |
| mriedem | but, i'm not sure how possible that is today unless you have <queens computes in a cell | 20:37 |
| mriedem | which shouldn't happen if you're running stein | 20:37 |
| tonyb | mriedem: Oh gosh that's a question ... I'll research it and see | 20:37 |
| mriedem | tonyb: i forgot the question | 20:38 |
| tonyb | mriedem: is emulatedTPM supported on kvm on power | 20:38 |
| mriedem | oh | 20:38 |
| tonyb | I have the spec open and I'll go read some code when I get off this meeting | 20:39 |
| mriedem | i'm going to shift gears and do something fun like delete the caching scheduler | 20:40 |
| *** pcaruana has quit IRC | 20:44 | |
| *** betherly has joined #openstack-nova | 20:49 | |
| *** betherly has quit IRC | 20:54 | |
| efried | mriedem: Left responses to some of your queries. The main one I can't answer, though. | 20:57 |
| mriedem | where do babies come from? | 20:57 |
| mriedem | that one? | 20:57 |
| *** erlon__ has quit IRC | 21:01 | |
| *** openstackgerrit has joined #openstack-nova | 21:03 | |
| openstackgerrit | Merged openstack/nova master: Merge image_size extension response into image view builder https://review.openstack.org/606845 | 21:03 |
| *** itlinux has joined #openstack-nova | 21:06 | |
| *** panda has quit IRC | 21:08 | |
| cdent | mriedem: do you recall if somebody already thought about postgresql with regard to https://review.openstack.org/#/c/611115/ ? Since it is a group by it might cause the "must appear in the GROUP BY" error. But I can't remember if that only happens if you use an agg function. | 21:12 |
| *** panda has joined #openstack-nova | 21:12 | |
| cdent | So I started a check experimental on it, but then realized the tempest-pg-full won't run the functional tests that exercise the problem. Is there anything else that will? | 21:13 |
| mriedem | nope | 21:13 |
| mriedem | the only mysql/pg-specific stuff that runs in func/unit tests are the schema migration tests | 21:13 |
| mriedem | the alternative is using DISTINCT in there as efried pointed out | 21:14 |
| efried | I tried ^ locally and it worked, but no idea what that means. | 21:15 |
| efried | I've been wanting to ask jay what the difference is. | 21:15 |
| efried | He +2d the change, so he must've thought GROUP BY was fine, but... | 21:15 |
| cdent | it's perfectly fine as is for mysql, but _might_ be a problem for pg | 21:16 |
| cdent | I can poke at it (/me looks at queue ... ) Monday if nobody else wants/needs to. mriedem do you think this will tickle the problem? | 21:17 |
| cdent | as in: do we need to care about this? | 21:18 |
| mriedem | what will tickle the problem? | 21:18 |
| mriedem | i don't know enough about group by rules for pg | 21:19 |
| mriedem | you could probably recreate it with just placement and a pg db, | 21:19 |
| mriedem | by having a consumer with >1 allocation against a resource provider and there not being any consumers table record for the allocations | 21:20 |
| mriedem | so just hack it up manually | 21:20 |
| *** bnemec is now known as bnemec-bbl | 21:20 | |
| cdent | What I meant was: is this the type of group by that postgresql will wail at? It will be easy enough to mess with manually. But for me, I won't have time before Monday | 21:22 |
| mriedem | i don't know the answer to that | 21:23 |
| mriedem | zzzeek_ might know off the top of his head | 21:23 |
| cdent | i've left a note on the review, if nothing happens before next week, I'll dig | 21:26 |
| *** cdent has quit IRC | 21:34 | |
| *** dklyle has joined #openstack-nova | 21:36 | |
| *** dklyle has quit IRC | 21:45 | |
| *** awaugama has quit IRC | 21:49 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove the CachingScheduler https://review.openstack.org/611723 | 22:02 |
| mriedem | johnthetubaguy: mgagne: ^ | 22:02 |
| mgagne | +1 for me | 22:04 |
| mgagne | didn't review the technical side of your removal, just the idea | 22:04 |
| mriedem | email sent to the ops list as well | 22:07 |
| *** mriedem has quit IRC | 22:12 | |
| *** mchlumsky has quit IRC | 22:21 | |
| *** tbachman has joined #openstack-nova | 22:30 | |
| openstackgerrit | Merged openstack/os-vif master: Fix random test_unplug_ovs failures https://review.openstack.org/611017 | 22:30 |
| openstackgerrit | Merged openstack/os-vif master: Do not call linux_net.delete_net_dev on Windows https://review.openstack.org/610916 | 22:30 |
| *** rcernin has joined #openstack-nova | 22:33 | |
| openstackgerrit | Sundar Nadathur proposed openstack/nova-specs master: Nova Cyborg interaction specification. https://review.openstack.org/603955 | 22:47 |
| *** betherly has joined #openstack-nova | 22:51 | |
| *** ircuser-1 has joined #openstack-nova | 22:52 | |
| *** betherly has quit IRC | 22:56 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Return a minimal construct for nova service-list when a cell is down https://review.openstack.org/584829 | 23:00 |
| *** mlavalle has quit IRC | 23:01 | |
| *** mlavalle has joined #openstack-nova | 23:03 | |
| *** jiaopengju has quit IRC | 23:05 | |
| *** jiaopengju has joined #openstack-nova | 23:08 | |
| *** betherly has joined #openstack-nova | 23:12 | |
| *** betherly has quit IRC | 23:16 | |
| *** erlon__ has joined #openstack-nova | 23:18 | |
| *** mlavalle has quit IRC | 23:31 | |
| openstackgerrit | Merged openstack/nova stable/queens: Handle volume API failure in _post_live_migration https://review.openstack.org/611084 | 23:32 |
| *** betherly has joined #openstack-nova | 23:32 | |
| *** jiaopengju has quit IRC | 23:35 | |
| *** jiaopengju has joined #openstack-nova | 23:36 | |
| *** betherly has quit IRC | 23:37 | |
| openstackgerrit | Merged openstack/nova master: Fix typo in libvirt.hw_machine_type help https://review.openstack.org/611422 | 23:46 |
| openstackgerrit | Merged openstack/nova master: Fix block_device_mapping_v2 mention in server create API reference https://review.openstack.org/611433 | 23:46 |
| *** bnemec has joined #openstack-nova | 23:50 | |
| *** bnemec-bbl has quit IRC | 23:52 | |
| *** gyee has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!