Wednesday, 2018-10-17

*** slaweq has joined #openstack-nova00:11
openstackgerritArtom Lifshitz proposed openstack/nova stable/rocky: Handle volume API failure in _post_live_migration  https://review.openstack.org/61108300:14
*** gyee has quit IRC00:17
*** spatel has joined #openstack-nova00:31
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix best_match() deprecation warning  https://review.openstack.org/61120400:42
*** slaweq has quit IRC00:45
*** lbragstad-503 is now known as lbragstad00:58
*** spatel has joined #openstack-nova01:07
*** hoangcx has quit IRC01:07
*** imacdonn has quit IRC01:09
*** slaweq has joined #openstack-nova01:12
openstackgerritTakashi NATSUME proposed openstack/nova master: Add API ref guideline for body text  https://review.openstack.org/60562801:14
*** dave-mccowan has joined #openstack-nova01:19
*** tetsuro has joined #openstack-nova01:19
*** imacdonn has joined #openstack-nova01:22
*** erlon has quit IRC01:23
*** TuanDA has joined #openstack-nova01:24
*** mrsoul has quit IRC01:27
*** owalsh has quit IRC01:31
*** tetsuro has quit IRC01:32
*** owalsh has joined #openstack-nova01:32
*** jackyzhu has joined #openstack-nova01:32
*** hshiina has joined #openstack-nova01:35
*** slaweq has quit IRC01:44
*** Dinesh_Bhor has joined #openstack-nova01:48
*** spatel has quit IRC01:50
*** hongbin has joined #openstack-nova01:50
*** slaweq has joined #openstack-nova02:12
*** tetsuro has joined #openstack-nova02:19
openstackgerritmelanie witt proposed openstack/nova master: Add nova-status upgrade check for consoles  https://review.openstack.org/61121402:35
*** lei-zh has joined #openstack-nova02:41
*** Dinesh_Bhor has quit IRC02:44
*** slaweq has quit IRC02:44
*** lei-zh has quit IRC02:47
*** lei-zh has joined #openstack-nova02:48
openstackgerritArtom Lifshitz proposed openstack/nova stable/queens: Handle volume API failure in _post_live_migration  https://review.openstack.org/61108402:48
*** whoami-rajat has joined #openstack-nova02:49
*** Dinesh_Bhor has joined #openstack-nova02:49
*** lei-zh1 has joined #openstack-nova02:51
*** psachin has joined #openstack-nova02:52
*** jackyzhu has quit IRC02:55
*** lei-zh1 has quit IRC02:55
openstackgerritmelanie witt proposed openstack/nova master: Add rolling upgrade info to enable_consoleauth workaround reno  https://review.openstack.org/61121802:57
*** slaweq has joined #openstack-nova03:11
*** dklyle has quit IRC03:25
*** dave-mccowan has quit IRC03:33
*** lei-zh has quit IRC03:34
*** lei-zh has joined #openstack-nova03:34
*** slaweq has quit IRC03:44
openstackgerritMerged openstack/nova master: Handle volume API failure in _post_live_migration  https://review.openstack.org/60951703:52
openstackgerritMerged openstack/nova master: Increment versioning with pbr instruction  https://review.openstack.org/61053403:52
*** tetsuro has quit IRC03:55
*** psachin has quit IRC03:56
*** hongbin has quit IRC04:04
*** hshiina has quit IRC04:04
*** hshiina has joined #openstack-nova04:04
*** Dinesh_Bhor has quit IRC04:07
*** slaweq has joined #openstack-nova04:11
*** Dinesh_Bhor has joined #openstack-nova04:39
*** psachin has joined #openstack-nova04:41
*** slaweq has quit IRC04:44
*** pcaruana has quit IRC04:46
*** lei-zh has quit IRC05:06
*** tetsuro has joined #openstack-nova05:10
*** slaweq has joined #openstack-nova05:12
*** janki has joined #openstack-nova05:15
*** lei-zh has joined #openstack-nova05:17
*** annp has quit IRC05:23
*** TuanDA has quit IRC05:23
*** lei-zh has quit IRC05:23
*** lei-zh has joined #openstack-nova05:24
*** slaweq has quit IRC05:30
*** slaweq has joined #openstack-nova05:31
*** ratailor has joined #openstack-nova05:39
*** gryf has quit IRC05:40
*** obre has quit IRC05:40
*** obre has joined #openstack-nova05:41
*** psachin has quit IRC05:43
*** Dinesh_Bhor has quit IRC05:49
*** slaweq has quit IRC05:54
*** icey has joined #openstack-nova05:55
*** Dinesh_Bhor has joined #openstack-nova06:01
*** cfriesen has quit IRC06:01
gmannAPI office hour time06:02
gmannalex_xu: ping06:02
alex_xugmann: pong06:02
gmann#startmeeting nova api06:02
openstackMeeting started Wed Oct 17 06:02:30 2018 UTC and is due to finish in 60 minutes.  The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot.06:02
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.06:02
*** openstack changes topic to " (Meeting topic: nova api)"06:02
openstackThe meeting name has been set to 'nova_api'06:02
gmannwho else here today ?06:02
*** TuanDA has joined #openstack-nova06:03
gmann#link https://wiki.openstack.org/wiki/Meetings/NovaAPI#Agenda_for_next_Office_hours06:04
gmannagenda ^^06:04
gmann#topic API Subteam Tracking06:04
*** openstack changes topic to "API Subteam Tracking (Meeting topic: nova api)"06:04
gmann#link https://etherpad.openstack.org/p/stein-nova-subteam-tracking06:04
gmann1. Boot instance specific storage backend06:06
gmannthis is merged which was in runway06:06
alex_xuyup, we done last week06:06
gmannyeah06:06
*** slaweq has joined #openstack-nova06:06
gmann https://review.openstack.org/#/q/topic:bp/api-extensions-merge-stein+status:open06:06
gmannthis is also next in runway but i saw you already reviewed most of them06:07
alex_xuyea, part of review for the last patch06:07
alex_xuhttps://review.openstack.org/#/c/607088/5/nova/api/openstack/compute/views/servers.py06:08
alex_xugmann: I guess you just forget to remove one line code06:08
gmannyeah, i am sure i did but got restore from rebse form PS4 to 506:09
openstackgerritGhanshyam Mann proposed openstack/nova master: Remove more code related to extensions and testing  https://review.openstack.org/60708806:10
gmannalex_xu: ^^ done06:10
gmannalex_xu: thanks for reviewing that series.06:10
alex_xugmann: np, I'm done also :)06:11
gmannalex_xu: thanks :)06:11
gmannother than that there is no updated from other BP code.06:11
gmannspec review is soemthing we can do.06:11
gmannmelwitt set the 23rd as spec review day.06:12
alex_xuyea06:12
gmanni will cover those during spec day06:12
gmannthat is all from tracking topic, alex_xu  you have anything else06:13
alex_xuno more from me06:13
gmannok06:15
gmann#topic Bug Triage/Discussion06:15
*** openstack changes topic to "Bug Triage/Discussion (Meeting topic: nova api)"06:15
*** Dinesh_Bhor has quit IRC06:15
*** mmedvede has quit IRC06:15
*** obre has quit IRC06:16
*** mmedvede has joined #openstack-nova06:16
gmannno response from previous bug we discussed so i marked incomplete as of now06:16
*** obre has joined #openstack-nova06:17
*** dpawlik has joined #openstack-nova06:18
alex_xuok06:19
alex_xui'm planning to trigger this by a fake cell timeout exception, but I didn't get a chance06:20
*** brinzhang has joined #openstack-nova06:21
gmannthis one ? https://bugs.launchpad.net/nova/+bug/178938206:21
openstackLaunchpad bug 1789382 in OpenStack Compute (nova) "openstack server list error" [Undecided,Incomplete]06:21
alex_xuyes06:21
*** Dinesh_Bhor has joined #openstack-nova06:23
gmannok, not sure it will be reproducible on that  but god to give try06:23
gmanngood06:23
gmannnext is new bug06:24
gmannhttps://bugs.launchpad.net/nova/+bug/179147806:24
openstackLaunchpad bug 1791478 in OpenStack Compute (nova) "nova-api get 504 when keepalived restart" [Undecided,New]06:24
*** gryf has joined #openstack-nova06:24
gmannthis is 504 gateway timeout06:24
openstackgerritBrin Zhang proposed openstack/nova master: Add restrictions on updated_at when getting instance action records  https://review.openstack.org/60780106:26
gmannit seems nova-api does not recognize the new node06:27
gmannuntill it is running on old node06:27
gmanni am not sure why, alex_xu you ?06:28
gmannalso not sure if this is nova-api isssue, or keepalive switch ip issue06:29
alex_xuwhy nova api should recognize the new node?06:29
gmannmight be he means keepalive does not recognize the new node nova-api service (and does not switch the vip)?06:31
*** tetsuro has quit IRC06:32
alex_xudoesn't sounds like nova api problem, it should be his ha configuration problem06:33
gmannyea, sounds like06:33
*** pcaruana has joined #openstack-nova06:34
gmannadded the comment on bug06:35
gmannand keeping it open until next week and then we can make it invalid or incomplete06:35
gmannlast new bug is this- https://bugs.launchpad.net/nova/+bug/179360606:35
openstackLaunchpad bug 1793606 in OpenStack Compute (nova) "Setting vendordata_providers to DynamicJSON causes config drive to stop working" [Undecided,New]06:35
gmanni remember, there was some fix for DynamicJSON option.06:37
alex_xui'm not familar with this one06:39
gmannme too, but i can try to reproduce this on local tomorrow and see whats happening06:41
*** moshele has joined #openstack-nova06:43
gmannits default value is StaticJSON https://github.com/openstack/nova/blob/042f08ee968fc83b80e554efe58270c8dfd6265c/nova/conf/api.py#L8406:43
gmanni will check this later and reply on bug06:44
gmannthat's all on bug side for today06:44
gmannalex_xu: you have any bug to discuss or we can move to open discussion06:44
alex_xuwe can move on06:45
gmann#topic Open Discussion06:46
*** openstack changes topic to "Open Discussion (Meeting topic: nova api)"06:46
gmanni have 1 quick topic06:47
gmannpolicy related change in upgrade-check CLI06:47
gmann#link http://lists.openstack.org/pipermail/openstack-dev/2018-October/135779.html06:47
gmann^^ i replied to matt email on upgrade-check and i feel most of the policy changes are candidate for upgrade-check CLi06:47
gmannalex_xu: what you say ?06:48
alex_xuthat is good idea06:48
alex_xubetter than operator to read the boring release note06:48
gmannthey can be checked  by comparing the previous release policy sample file json and new one and build the upgrade msg06:49
gmannyeah06:49
gmannor some more optimize way.06:49
alex_xuand some action to take for their custom policy config06:49
gmannyeah06:50
gmannthat's all on this from my side.06:51
alex_xume too06:51
gmannanything else alex_xu or we can close the office hour06:51
gmannok06:51
gmannthank alex_xu for joining06:52
gmann#endmeeting06:52
*** openstack changes topic to "Current runways: use-nested-allocation-candidates -- This channel is for Nova development. For support of Nova deployments, please use #openstack."06:52
openstackMeeting ended Wed Oct 17 06:52:10 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)06:52
openstackMinutes:        http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-10-17-06.02.html06:52
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-10-17-06.02.txt06:52
openstackLog:            http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-10-17-06.02.log.html06:52
openstackgerritBrin Zhang proposed openstack/nova master: Add restrictions on updated_at when getting migrations  https://review.openstack.org/60779806:59
*** slaweq has quit IRC06:59
*** slaweq has joined #openstack-nova06:59
openstackgerritliuming proposed openstack/nova master: Deletes evacuated instance files when source host is ok  https://review.openstack.org/60598707:02
*** adrianc has joined #openstack-nova07:02
openstackgerritMerged openstack/nova master: Handle online_data_migrations exceptions  https://review.openstack.org/60809107:07
openstackgerritBrin Zhang proposed openstack/nova master: Add restrictions on updated_at when getting instance action records  https://review.openstack.org/60780107:08
*** rcernin has quit IRC07:09
amorinbauzas: I found out my issue about live migration with image not found07:11
amorinI confirm that the bug is fixed on my newton infra07:11
*** hamdyk has joined #openstack-nova07:12
openstackgerritJie Li proposed openstack/nova-specs master: Support volume-backed server rebuild  https://review.openstack.org/53240707:13
*** slaweq has quit IRC07:13
*** hshiina_ has joined #openstack-nova07:13
*** slaweq has joined #openstack-nova07:14
*** slaweq has quit IRC07:14
*** slaweq has joined #openstack-nova07:14
openstackgerritJie Li proposed openstack/nova-specs master: Support volume-backed server rebuild  https://review.openstack.org/53240707:16
*** hshiina has quit IRC07:17
*** helenafm has joined #openstack-nova07:19
*** ralonsoh has joined #openstack-nova07:20
*** Luzi has joined #openstack-nova07:26
*** jpena|off is now known as jpena07:30
*** jangutter has quit IRC07:34
*** jangutter has joined #openstack-nova07:34
*** brinzhang has quit IRC07:41
*** brinzhang has joined #openstack-nova07:42
bauzasgood morning Nova07:42
bauzasamorin: cool, what was the issue ?07:42
gibibauzas: good morning07:42
*** takashin has quit IRC08:06
openstackgerrithuanhongda proposed openstack/nova master: Fix instance delete stuck in deleting task_state  https://review.openstack.org/59808408:09
*** elod_off is now known as elod08:13
*** slaweq has quit IRC08:14
*** slaweq has joined #openstack-nova08:15
*** brinzhang has quit IRC08:18
*** alexchadin has joined #openstack-nova08:20
*** brinzhang has joined #openstack-nova08:20
*** Dinesh_Bhor has quit IRC08:25
*** tssurya has joined #openstack-nova08:25
*** TuanDA has quit IRC08:36
*** TuanDA has joined #openstack-nova08:49
*** hshiina_ has quit IRC08:56
*** cfriesen has joined #openstack-nova08:57
*** Dinesh_Bhor has joined #openstack-nova09:06
*** dpawlik has quit IRC09:10
*** dtantsur|afk is now known as dtantsur09:12
*** dpawlik has joined #openstack-nova09:29
*** mikeoschen has quit IRC09:34
*** lei-zh has quit IRC09:38
*** Dinesh_Bhor has quit IRC09:42
*** adrianc has quit IRC09:53
*** TuanDA has quit IRC09:59
*** adrianc has joined #openstack-nova10:09
*** yikun has joined #openstack-nova10:19
*** wznoinsk has joined #openstack-nova10:21
*** brinzh has joined #openstack-nova10:26
*** brinzhang has quit IRC10:30
*** Dinesh_Bhor has joined #openstack-nova10:30
openstackgerritMerged openstack/nova master: Add recreate test for bug 1798163  https://review.openstack.org/61111310:38
openstackbug 1798163 in OpenStack Compute (nova) "Placement incomplete consumers online migration fails" [Critical,In progress] https://launchpad.net/bugs/1798163 - Assigned to Matt Riedemann (mriedem)10:38
*** pooja_jadhav has quit IRC10:41
kashyapstephenfin: Hey, is there a less-strain-on-the-eye version of this? -- https://docs.openstack.org/nova/rocky/configuration/sample-config.html10:41
kashyapRenderings for older releases had a table for config files10:42
kashyapNow it is all one big sphaghetti noodle "sample-config.html" file10:42
kashyapAh, found it - https://docs.openstack.org/nova/rocky/configuration/config.html10:44
kashyapstephenfin: Disregard me10:44
*** tbachman has quit IRC10:44
*** tbachman has joined #openstack-nova10:44
*** brinzh has quit IRC10:48
*** Dinesh_Bhor has quit IRC10:50
*** tbachman has quit IRC10:50
*** erlon has joined #openstack-nova11:06
*** panda is now known as panda|lunch11:18
*** moshele has quit IRC11:22
*** pcaruana has quit IRC11:28
*** ShilpaSD has quit IRC11:28
*** moshele has joined #openstack-nova11:29
*** ratailor has quit IRC11:35
*** pooja_jadhav has joined #openstack-nova11:35
*** jpena is now known as jpena|lunch11:37
*** lei-zh has joined #openstack-nova11:39
*** READ10 has quit IRC11:41
*** mvkr has quit IRC11:46
*** dtantsur is now known as dtantsur|brb11:48
*** slaweq has quit IRC11:54
*** slaweq has joined #openstack-nova11:54
*** janki has quit IRC11:57
*** panda|lunch is now known as panda12:03
*** moshele has quit IRC12:04
openstackgerritMartin Midolesov proposed openstack/nova master: Implementing graceful shutdown.  https://review.openstack.org/60870412:04
*** moshele has joined #openstack-nova12:05
*** tbachman has joined #openstack-nova12:08
*** ShilpaSD has joined #openstack-nova12:10
*** dave-mccowan has joined #openstack-nova12:13
*** eharney has joined #openstack-nova12:16
openstackgerritMerged openstack/nova master: Use unique consumer_id when doing online data migration  https://review.openstack.org/61111512:18
*** pcaruana has joined #openstack-nova12:24
*** lei-zh has quit IRC12:35
*** jpena|lunch is now known as jpena12:44
*** moshele has quit IRC12:49
*** moshele has joined #openstack-nova12:51
*** mvkr has joined #openstack-nova12:53
*** dtantsur|brb is now known as dtantsur12:55
*** janki has joined #openstack-nova12:58
openstackgerritMartin Midolesov proposed openstack/nova master: Implementing graceful shutdown.  https://review.openstack.org/60870413:02
*** lei-zh has joined #openstack-nova13:02
openstackgerritMerged openstack/nova master: Fix formatting non-templated cell URLs with no config  https://review.openstack.org/61109413:05
*** mriedem has joined #openstack-nova13:10
*** mchlumsky has joined #openstack-nova13:15
*** dklyle has joined #openstack-nova13:16
pooja_jadhavmriedem: https://review.openstack.org/#/c/608771/1/nova/tests/functional/test_boot_from_volume.py13:21
pooja_jadhav In this functional tests, is it creating instance in real??13:21
mriedemit creates a server in the sqlite database using the fake virt driver13:22
mriedemi'm not sure what you mean by "real"13:22
amorinbauzas the issue is that we are upgrading our openstack from juno to newton13:22
pooja_jadhavreal means in actual environment13:23
pooja_jadhavlike13:23
amorinand some of our hosts were not configured correctly AFAIK13:23
pooja_jadhavwhen we do nova list, we can see that instance13:23
amorinmaybe that was because nova rely on glanceclient, and glanceclient was not upgraded13:23
mriedempooja_jadhav: well the test doesn't list instances, but it's able to show the instance, otherwise it wouldn't be able to wait for its status to be ACTIVE13:23
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Add recreate test for bug 1798163  https://review.openstack.org/61131413:25
openstackbug 1798163 in OpenStack Compute (nova) rocky "Placement incomplete consumers online migration fails" [Critical,Confirmed] https://launchpad.net/bugs/1798163 - Assigned to lihuayuliang (lihuayuliang)13:25
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Use unique consumer_id when doing online data migration  https://review.openstack.org/61131513:25
mriedemlyarwood: bauzas: pretty serious upgrade issue if you can review those backports quick ^13:25
pooja_jadhavmriedem: then after getting test passed, these instance should be deleted. Is it deleting by any existing mechanism or we need to delete by calling delete API.??13:26
mriedempooja_jadhav: each test case has the db setup and torn down13:26
mriedemso we don't need to explicitly delete resources since each test case has a fresh db13:26
pooja_jadhavmriedem: Ohk, Thank you :)13:27
pooja_jadhavmriedem: Can u plz locate to the code where this db setup and tear down is added for the functional tests?13:30
*** dklyle has quit IRC13:31
mriedempooja_jadhav: see nova.test.TestCase.setUp13:31
mriedemthe database fixtures in there13:31
*** lei-zh has quit IRC13:32
pooja_jadhavmriedem : thnnks :)13:32
*** irclogbot_4 has joined #openstack-nova13:32
*** dims has quit IRC13:40
*** munimeha1 has joined #openstack-nova13:47
*** jmlowe has quit IRC13:49
*** mgoddard has quit IRC13:49
*** eharney has quit IRC13:51
openstackgerritMartin Midolesov proposed openstack/nova master: Implementing graceful shutdown.  https://review.openstack.org/60870413:53
*** mhen has joined #openstack-nova13:54
openstackgerritMerged openstack/nova master: Fix NoneType error in _notify_volume_usage_detach  https://review.openstack.org/60951813:54
mriedemtssurya: you want to backport this to rocky? https://review.openstack.org/#/c/611094/13:54
*** mgoddard has joined #openstack-nova13:54
tssuryamriedem: yea, doing it13:55
mriedemartom: i see you wasted no time https://review.openstack.org/#/q/Icb0bdaf454935b3713c35339394d260b33520de513:55
dansmithmriedem: we have some pressure on that one13:56
dansmithrocky should be okay now yeah?13:56
tssuryayea13:56
mriedemdansmith: i just +2d it13:57
*** jmlowe has joined #openstack-nova13:58
*** irclogbot_4 has quit IRC13:58
dansmithah was just looking at the conflict,13:58
dansmithbut I see you called it out13:58
*** irclogbot_4 has joined #openstack-nova13:59
mriedemanyone know if tripleo is running nova-status upgrade check yet?14:03
mriedemeither on install and/or upgrade?14:03
*** Luzi has quit IRC14:03
*** dims has joined #openstack-nova14:03
mriedemlooks like only OSA and kolla-ansible so far14:04
*** READ10 has joined #openstack-nova14:05
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Fix NoneType error in _notify_volume_usage_detach  https://review.openstack.org/61132614:08
openstackgerritSurya Seetharaman proposed openstack/nova stable/rocky: Fix formatting non-templated cell URLs with no config  https://review.openstack.org/61132714:09
*** awaugama has joined #openstack-nova14:09
*** irclogbot_4 has quit IRC14:11
bauzasmriedem: lyarwood is on PTO for the next two weeks, but lemme look14:11
*** sapd1_ has quit IRC14:13
*** sapd1_ has joined #openstack-nova14:16
*** dims has quit IRC14:16
tssuryaif any cores have some time (other than mriedem and efried): would be good to have this in https://review.openstack.org/#/c/611162/14:16
mriedemi was just going to lobby for that :)14:17
mriedemsince it's an upgrade impact14:17
tssurya:)14:17
*** dims has joined #openstack-nova14:19
bauzastssurya: mriedem: mmm, is that only an Ironic thing ?14:21
bauzasmriedem: I was looking for like 2 weeks why some ComputeNode UUID was changing from a libvirt node14:21
tssuryaits an only ironic driver thing14:21
bauzasanyway, +Wing14:21
tssuryathanks bauzas14:22
bauzastssurya: mriedem: can't see a stable/rocky one, please ping me the change once done14:22
tssuryayea proposing one now14:22
bauzasof course, I'll +2 it once the master lands14:22
mriedembauzas: this is a fun reqspec regression thing too https://review.openstack.org/#/q/topic:bug/1797580+(status:open+OR+status:merged)14:24
mriedemgoes back to queens14:24
bauzasmriedem: after 2 weeks of internal bug triage, I love you14:24
bauzasbecause you help me doing other stuff14:24
tssuryayea we hit that too the marker stuff :(14:24
mriedem^ isn't marker stuff14:24
bauzasoh this one14:25
bauzasthe requested_destination field14:25
mriedemtssurya: https://review.openstack.org/#/c/610974/14:25
tssuryaah hehe yea14:25
tssuryasorry14:25
mriedembut yeah would be good to get that in also since it affects upgrades14:26
mriedemjohnthetubaguy: are you around?14:26
openstackgerritSurya Seetharaman proposed openstack/nova stable/rocky: Ignore uuid if already set in ComputeNode.update_from_virt_driver  https://review.openstack.org/61133714:26
artommriedem, yeah, like I said, downstream pressure :)14:27
tssuryabauzas, efried: ^ the backport to rocky for after the master merges14:27
mriedem+114:28
stephenfinCan someone help me understand what's going on here? paste.openstack.org/show/732338/14:34
stephenfinWas discussing it with bauzas earlier today. We've configured 'cpu_allocation=1' and yet it still seems like overallocation is happening14:34
bauzasstephenfin: like I said to you, we should check the instances number14:36
*** openstackgerrit has quit IRC14:36
stephenfinbauzas: Yeah, there's one instance on that host before we do the host-evacuate. Once we do that, two instances land on it14:36
stephenfinOne instance has 2 vcpu, the other has 1 vcpu14:37
bauzasgiven vcpus_used is generated by looking up the instances14:37
bauzashost-evacuate is racy14:37
bauzasyou should really avoid it, and do two evacuations concurrently14:37
bauzasI thought we commented that btw.14:37
stephenfinYup, vcpus_used appears to be correct. Compare lines 24-29 to 90-9514:38
bauzashttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/contrib/host_evacuate.py14:38
stephenfinThe second hypervisor (dcfb3fb7) goes from 5/6 used to 7/614:39
*** logan_ has joined #openstack-nova14:40
stephenfinbauzas: But its done client side. It seems odd that the scheduler wouldn't honour overcommit ratios just because the requests came in at the same time. Is this known behavior?14:41
* stephenfin can't remember the last time he booted an instance without dedicated cores, heh14:41
*** hamzy has quit IRC14:41
mriedemis the target host in an aggregate with an allocation ratio metadata?14:42
stephenfinsec - checking14:42
mriedemcompute-0.localdomain was forced down but was the service actually stopped?14:42
bauzasotp but looking14:44
mriedembecause vcpus_used didn't change on compute-0 after the evacuation14:44
mriedemthough i guess i wouldn't expect them to until compute-0 is restarted and removes locally evacuated instances14:45
mriedembut not really safe to have the guest running on the source and dest at the same time...14:45
stephenfinI don't see vcpus_used reported for compute-0 in those logs. Mixing it up with compute-1?14:45
mriedemoh yeah you're right14:46
mriedempi14:46
mriedemyou're just wondering why they are evacuated to compute-2 rather than compute-0?14:46
mriedemor not spread between them?14:46
stephenfinspread between compute-1 and compute-214:46
stephenfinWell14:47
mriedemright you expect compute_0_instance_1_vcpu to go to compute-1 and compute_0_instance_2_vcpu to go to compute-214:47
mriedemwhich would fill up each of those computes14:47
stephenfinMore that the second migration wouldn't fail because it would bump compute-2 over our overallocation ratio14:47
stephenfinSure, though the opposite could also happen14:47
mriedemwell, which release is this? is the CoreFilter enabled?14:47
awaugamaI'm the one who tried it, the hosts were not in aggregates14:48
stephenfinso compute_0_instance_1_vcpu goes to compute-2 and then compute_0_instance_2_vcpu gets rejected14:48
awaugamaI can retry with that14:48
mriedemif the CoreFilter is not enabled, there will be no cpu limits sent to the compute to claim in the RT14:48
mriedemwhich means you can overcommit14:48
mriedemif this is pike+, the filter scheduler should be claiming allocations in placement and we don't need to care about vcpu claims in the RT14:49
mriedemso i'd take a look at your resource provider inventory/allocations14:49
*** munimeha1 has quit IRC14:49
*** knikolla has quit IRC14:49
*** devananda has quit IRC14:49
*** vabada has quit IRC14:49
*** alex_xu has quit IRC14:49
*** logan- has quit IRC14:49
mriedemusing the osc-placement commands14:49
*** logan_ is now known as logan-14:49
mriedemhttps://docs.openstack.org/osc-placement/latest/14:50
*** eharney has joined #openstack-nova14:50
awaugamaok thanks14:50
*** hamdyk has quit IRC14:51
*** openstackgerrit has joined #openstack-nova14:52
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Handle missing marker during online data migration  https://review.openstack.org/61134314:52
*** mlavalle has joined #openstack-nova14:53
awaugamamriedem: sorry I'm confused about something.  you're saying placement has it's own ratios that will cause the configured compute node ratios to be ignored?14:56
dansmithawaugama: nova's ratios are mostly irrelevant now, yes14:57
awaugamaso that's where the corefilter comes in?14:58
mriedemwell,14:58
mriedemis the CoreFilter enabled? it shouldn't be.14:58
mriedemif you're >=pike and using the filter scheduler14:59
mriedemno one told me what release this is14:59
awaugamaSorry, this is Rocky14:59
mriedemthe compute service will create a resource provider in the placement service and report it's inventory (vcpu/ram/disk) and allocation ratios for each of those resource classes14:59
mriedemthe scheduler will atomically allocate resources from each provider during the evacuate15:00
mriedemso it should only overcommit if the VCPU inventory allocation_ratio in placement is > 1.015:00
mriedemso, find the uuid for the compute-2 resource provider using "openstack resource provider list"15:00
mriedemthen using that uuid, check the inventory for that provider: openstack resource provider inventory show $uuid15:01
mriedemsorry, openstack resource provider inventory list $uuid15:01
mriedemif the allocation_ratio for the VCPU resource class is 1.0 and we still overcommitted, then something else is going on15:02
awaugamais there a microversion I need to use for the openstack cli? openstack resource provider list is giving me no results15:03
mriedemhmm, shouldn't need to15:04
mriedemare you using admin creds?15:04
mriedemyou'd get a 403 otherwise15:04
mriedemif there are no resource providers....you shouldn't have been able to evacuate, you'd get a NoValidHost15:04
awaugamaSorry, I'm getting that openstack resource provider list is not an openstack command15:05
awaugamawasn't clear with no results15:05
mriedemyou probably don't have the osc-placement plugin installed15:06
mriedemi'm assuming you guys have an rpm for that15:06
awaugamayeah, I've done that before, it's not enabled by default.  I'll have to find my logs for that15:06
openstackgerritMatthew Edmonds proposed openstack/nova master: Use tempfile for powervm config drive  https://review.openstack.org/61017415:07
*** slaweq has quit IRC15:09
*** slaweq has joined #openstack-nova15:10
*** hamzy has joined #openstack-nova15:12
*** janki has quit IRC15:13
openstackgerritIvaylo Mitev proposed openstack/nova master: VMware: OVA and StrOpt images as VM templates  https://review.openstack.org/60973615:15
*** alexchadin has quit IRC15:15
*** liuyulong has joined #openstack-nova15:16
*** k_mouza has joined #openstack-nova15:17
*** slaweq has quit IRC15:21
*** slaweq has joined #openstack-nova15:22
mriedemefried: you can drop the -2 on https://review.openstack.org/#/c/521041/15:26
efried...15:26
*** moshele has quit IRC15:27
efriedmriedem: Is this going to be filed under reshaper or vgpu?15:27
mriedemi left a comment that it should be reshaper i think15:27
efriedIf that's the case, then the -2 should be dropped once the commit message references that bp?15:29
awaugamamriedem: The allocation ratio for VCPU is 16.  that's where the issue is coming from15:29
mriedemawaugama: aha15:29
mriedemawaugama: that's the compute_nodes.cpu_allocation_ratio for compute-2 in the nova cell db?15:30
mriedemefried: just -115:30
mriedemawaugama: *what's15:30
awaugamachecking15:31
mriedemyou might be missing this fix https://github.com/openstack/nova/commit/01265b98c4cd2b1377e891a06ce748fc6f8f342515:31
mriedemthat went into 18.0.115:31
mriedemif cpu_allocation_ratio is 0.0 in the compute_nodes table, it will default to 16.0 in code and that's what gets put into the resource provider VCPU inventory in placement15:32
*** macza has joined #openstack-nova15:39
*** vdrok has quit IRC15:41
*** vdrok has joined #openstack-nova15:42
*** jpena is now known as jpena|off15:47
*** itlinux has joined #openstack-nova15:49
mnaserany stable-maint folks around to push https://review.openstack.org/#/c/611314/1 and https://review.openstack.org/#/c/611315/1 out? :)15:53
*** Luzi has joined #openstack-nova15:55
*** k_mouza has quit IRC15:57
artomDammit what do I need to mock so that can_send_version from compute rpcapi returns what I want >_<15:58
*** hamzy has quit IRC16:01
dansmithmnaser: yes16:01
*** hamzy has joined #openstack-nova16:01
mnaserdansmith: thank you, didn't want to keep carrying a patch :)16:01
* dansmith nods16:03
efriedartom: Have you tried mock.patch('oslo_messaging.rpc.client.RPCClient.can_send_version') ?16:06
efriedartom: Or you could mock nova.rpc.get_client and then set its return_value.can_send_version.return_value16:08
efrieddepending how far back you want to go.16:08
*** priteau has joined #openstack-nova16:08
artomefried, so, I was listing the mock_calls incorrectly, turns out mocking oslo_messaging.RPClient.can_send_version is what I need16:08
mriedemanother clean rocky backport ready to go https://review.openstack.org/#/c/611327/16:09
artomI can see the call I care about in here. New problem: it seems to be having no effect :(16:09
efriedartom: cool.16:09
efriedwith that, I must leave you.16:09
*** efried is now known as efried_pto16:09
artomefried, hehe, thanks :) enjoy16:09
awaugamamriedem: cpu_allocation_ratio is set to 1 in the db16:10
awaugamasorry got yanked into a meeting16:10
mriedemawaugama: hmm16:10
awaugamafor compute node 216:10
mriedemwell this is the code that sets the cpu_allocation_ratio in the inventory record we send to placement https://github.com/openstack/nova/blob/stable/rocky/nova/compute/resource_tracker.py#L10616:11
mriedemunless we have some code in rocky that is using a cache and thinks we don't have any updates...16:11
mriedemi.e. the cache might say we already have that allocation ratio even though placement doesn't16:11
awaugamastephenfin: is that the code you saw earlier?16:12
stephenfinawaugama: Yup, that's the one16:12
openstackgerritStephen Finucane proposed openstack/nova master: fixtures: Track volume attachments within CinderFixtureNewAttachFlow  https://review.openstack.org/58701316:12
openstackgerritStephen Finucane proposed openstack/nova master: Add regression test for bug#1784353  https://review.openstack.org/58701416:12
openstackgerritStephen Finucane proposed openstack/nova master: conductor: Recreate volume attachments during a reschedule  https://review.openstack.org/58707116:12
mriedemhave you tried restarting the compute-2 nova-compute service to see if that flushes the cpu_allocation_ratio 1.0 change to placement?16:13
stephenfinmriedem: If I'm reading that right, if we send that once, we'll never be able to update it, right?16:13
mriedemstephenfin: we should be able to update it any time we change config and restart nova-compute16:13
stephenfinBecause placement will always return 'allocation_ratio' once it's been set https://github.com/openstack/nova/blob/stable/rocky/nova/compute/resource_tracker.py#L10516:13
mriedemthe allocation ratio config is read and set on the compute node object here https://github.com/openstack/nova/blob/18.0.0/nova/compute/resource_tracker.py#L62416:14
mriedemno,16:14
*** tssurya has quit IRC16:14
mriedemthat cpu_inv is coming from the virt driver,16:14
mriedemand none of the virt driver's have an allocation_ratio in their inventory dicts16:14
stephenfinCorrect. My mistake16:14
mriedem:param inv_data: Dict, keyed by resource class, of inventory information                                            returned from virt driver's get_inventory() method16:14
mriedemso try restarting compute-2's nova-compute service16:15
mriedemif you changed the config but never restarted the service, the change wouldn't get to placement,16:15
mriedemif you did, but something is f'ed in the local provider tree cache, that should refresh the cache16:15
mriedemthe provider tree cache stuff is all black magic to me16:15
awaugamalet's give it a shot16:17
awaugamaNo luck.  I'm still seeing 16 set for placement for compute node 216:19
stephenfinawaugama: Dumb question but this config option is configured on the compute node 2 and not the controller, right?16:20
awaugamayeah16:20
*** k_mouza has joined #openstack-nova16:21
awaugama[root@compute-2 ~]# cat /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf | grep cpu_allocation16:21
awaugama#cpu_allocation_ratio=0.016:21
awaugamacpu_allocation_ratio=116:21
stephenfinIndeed. Cool, just checking16:21
* stephenfin initially thought that had to be set on the controller before seeing we report it back via the ComputeNode object16:21
bauzaswait, just catching the discussion16:23
bauzasawaugama: so you're saying that placement ratio != nova conf option ?16:24
awaugamayeah16:24
*** munimeha1 has joined #openstack-nova16:24
*** knikolla has joined #openstack-nova16:24
*** vabada has joined #openstack-nova16:24
bauzasawaugama: PM me the compute logs16:26
bauzasthat's... weirdo16:26
*** moshele has joined #openstack-nova16:26
bauzasthe only case where we bypass the ratios is when we have 0.016:26
bauzasbut mriedem fixed it recently16:26
mriedemi mentioned https://github.com/openstack/nova/commit/01265b98c4cd2b1377e891a06ce748fc6f8f3425 but that's kind of a different issue16:27
mriedemawaugama: when nova-compute starts up, it will dump the config options at debug level16:27
*** dtantsur is now known as dtantsur|afk16:27
mriedemare you able to see cpu_allocation_ratio in the logs after you restarted compute-2?16:28
bauzasyup, but we also audit them IIRC16:28
bauzaslemme double check on the gate16:28
awaugamawill check in a little bit, I have an appointment I can't miss that I have to leave for.  will let you know16:28
*** awaugama is now known as awaugama_appoint16:28
*** k_mouza has quit IRC16:33
openstackgerritStephen Finucane proposed openstack/nova master: Fail to live migration if instance has a NUMA topology  https://review.openstack.org/61108816:35
*** helenafm has quit IRC16:35
*** panda is now known as panda|off16:36
*** moshele has quit IRC16:38
*** erlon_ has joined #openstack-nova16:38
*** erlon has quit IRC16:40
melwitt16:45
mriedemwhat's going on with the handling a down cell stuff? seems that is blocked or languishing or other? tssurya is already gone for the day though16:52
dansmithlast I saw I think it was getting nailed by zuul failures16:52
mriedemit also looks like people are putting more specs in runways https://etherpad.openstack.org/p/nova-runways-stein16:53
dansmithI don't think I've seen it pop back up recently16:53
mriedemmelwitt: you might want to send a reminder to the ML that runways aren't for spec reviews16:53
mriedemdansmith: was the full series even passing?16:53
mriedemlike last i looked i thought the change with the microversion wasn't passing tests16:54
dansmithmriedem: I think there is one patch you're holding a -2 on that you can drop, as she moved the microversion stuff to the end and isn't doing the check-for-unmerged-microversion It hink16:54
melwittmriedem: ack16:54
mriedemdansmith: yeah i can do that16:54
dansmithmriedem: yeah the top one looks sick, but the others are fallout from zuul fails I think16:54
mriedemsince it's one of our "themes" i'm worried it's just sitting in a pile of poo16:54
mriedemhttps://review.openstack.org/#/c/609807/16:55
dansmithoh some functional fails on one of them too16:55
mriedemwas there agreement on how exceptions would be returned when a scatter/gather fails?16:55
mriedemhttps://review.openstack.org/#/c/607934/16:55
dansmithyeah I think so16:56
dansmithlemme pull this down and see if I can fix up her functional failures16:56
mriedemso rather than the sentinel, we just return an instance of the thing that failed16:56
dansmithan instance of the exception you mean right?16:57
mriedemright16:59
*** derekh has quit IRC17:00
dansmiththat's what we agreed yeah17:00
*** mvkr has quit IRC17:01
*** Luzi has quit IRC17:02
*** erlon__ has joined #openstack-nova17:04
*** erlon_ has quit IRC17:07
*** hamzy has quit IRC17:07
*** hamzy has joined #openstack-nova17:08
mriedemok -1 on https://review.openstack.org/#/c/567785/ which is the api plumbing patch,17:10
mriedemmostly b/c of tests and lack of docs and not explaining it's plumbing17:11
mriedembut i also think it might be doing the queries wrong17:11
mriedembut i've dropped the -217:11
*** hamzy has quit IRC17:12
mriedemi'd have to look at the spec again, but it's querying instances from down cells for the user's request context project_id,17:12
*** hamzy has joined #openstack-nova17:12
mriedemwhich if it's an admin listing instances for all_tenants, or a specific project_id, would be wrong17:12
dansmithit changes that behavior?17:13
dansmiththat shoudl only be enabled if it's enabled in config and not doing all tenants17:13
dansmithunless I'm misunderstanding what you mean17:13
maczahello, ive run into an issue on ocata using nova with ceph, a compute hypervisor crashed and now all the instances wont connect to their drives after bringing the hypervisor back up17:14
maczahoping i could get some help17:16
*** spatel has joined #openstack-nova17:19
spatelI am seeing very strange issue17:19
spatelIn /etc/default/grub   hugepagesz=2M hugepages=1228817:19
spatel1 instance running on it with 8G17:20
*** adrianc has quit IRC17:20
spateltrying to spin up one more instance but getting error qemu-kvm: cannot set up guest memory 'pc.ram': Cannot allocate memory17:20
spatelI do have 32G memory on compute node17:20
openstackgerritArtom Lifshitz proposed openstack/nova stable/pike: Handle volume API failure in _post_live_migration  https://review.openstack.org/61109317:20
openstackgerritArtom Lifshitz proposed openstack/nova stable/pike: Handle volume API failure in _post_live_migration  https://review.openstack.org/61109317:23
*** k_mouza has joined #openstack-nova17:25
*** Swami has joined #openstack-nova17:31
spatelnevermind, my bad i forgot to add hugepage properties to flavor17:33
cfriesenspatel: that'll do it. :)17:34
mriedemdansmith: i mean this https://review.openstack.org/#/c/567785/20/nova/compute/api.py@229517:39
mriedemwhile listing instances, if there are down cells, it lists instances via the mappings from the down cells but filters on the user's request context17:39
dansmithoh for the minimal fill ins17:39
mriedemand if i'm an admin listing instances for another project via the project_id filter, that woudl be wrong17:39
mriedemright17:39
dansmithyeah I guess17:39
dansmithI was thinking we talked about that and said "kinda meh" but I might be misremembering17:40
mriedemhttps://specs.openstack.org/openstack/nova-specs/specs/stein/approved/handling-down-cell_new.html#edge-cases17:40
mriedemyeah i remember we talked about it too, glad it's in the spec17:40
*** panda|off has quit IRC17:40
dansmithum, is it?17:41
dansmiththe --deleted thing is mentioned there17:41
dansmith--all-tenants is a little different17:41
*** awaugama_appoint is now known as awaugama17:41
mriedem"Filters: If the user is listing servers using filters the results from the down cell will be skipped and no minimalistic construct will be provided since there is no way of validating the filtered results from the down cell if the value of the filter key itself is missing. "17:41
mriedemso like if i'm filtering on status or something17:41
mriedemwe said in the spec we'd just ignore what's in down cells since we can't know17:42
dansmithright17:42
dansmithfor filters17:42
dansmithbut your point was --all-tenants right?17:42
mriedemthat's one of them17:42
mriedemand not called out specifically17:42
mriedemfor --all-tenants,17:42
mriedemi'd think we could just list all instance mappings in down cells,17:42
*** panda has joined #openstack-nova17:42
mriedemnot filtered on project_id17:42
mriedemup to whatever limit17:43
*** ralonsoh has quit IRC17:47
mriedemso apparently filtering on project_id only works if you're also using all_tenants17:49
mriedemotherwise we just filter on the context.project_id17:49
dansmithum, what?17:50
dansmithmeaning --all_tenants is required in order to say --but-only-this-one ?17:51
mriedemhttps://github.com/openstack/nova/blob/9c5d4eb2008df02837985779d87fedb17b4f70bf/nova/api/openstack/compute/servers.py#L206L24817:51
mriedemyes...17:51
*** macza has quit IRC17:52
*** dklyle has joined #openstack-nova17:52
dansmithhmm17:52
*** macza has joined #openstack-nova17:52
*** mgoddard has quit IRC18:11
*** k_mouza has quit IRC18:11
*** mgoddard has joined #openstack-nova18:17
*** k_mouza has joined #openstack-nova18:21
openstackgerritJack Ding proposed openstack/nova master: Add I/O Semaphore to limit concurrent disk ops  https://review.openstack.org/60918018:24
*** k_mouza has quit IRC18:26
*** cdent has joined #openstack-nova18:27
*** david-lyle has joined #openstack-nova18:29
*** dklyle has quit IRC18:29
awaugamamriedem: when you have a chance, it looks like the value is set on the compute node.  after a reboot I saw this in the nova-compute log18:32
awaugama2018-10-17 17:44:00.277 1 DEBUG oslo_service.service [req-c9c4f04c-cfc6-4fe3-868d-206f9329419d - - - - -] cpu_allocation_ratio           = 1.0 log_opt_values /usr/lib/python2.7/site-packages/oslo_config/cfg.py:302318:32
mriedemjroll: where in the ironic API reference would one find anything about conductor_groups? https://developer.openstack.org/api-ref/baremetal/18:33
mriedemi mean i see https://docs.openstack.org/ironic/latest/contributor/webapi-version-history.html#rocky-11-1-018:33
mriedembut nothing in the API reference18:33
jrollmriedem: apparently I forgot to update that when I added it :(18:34
mriedemawaugama: ok so it's 1.0 in config, it's 1.0 in the compute_nodes.cpu_allocation_ratio column in the db, but it's 16.0 in the associated resource provider VCPU inventory in placement18:34
awaugamayeah18:34
mriedemwell wtf18:34
jrollmriedem: it would be in node CRUD as its own field, I'll get that done real quick18:34
mriedemjroll: a uuid or what?18:34
mriedemjroll: and you can update a node's conductor_group?18:35
jrollmriedem: a string, up to 255 characters IIRC: https://github.com/openstack/ironic/blob/b8ffcc0f0298fca5b4b36ad016e2c3b2f0e81710/ironic/common/utils.py#L53018:35
mriedemok so it's just some tag18:35
awaugamaI'll sit down with sylvain tomorrow and we can do some debugging, will let you know if we find anything18:35
mriedemspecial tag18:35
jrollyeah18:35
jrollalphanumeric, plus - _ .18:36
*** moshele has joined #openstack-nova18:37
*** READ10 has quit IRC18:40
artom- _ .  is what I look like after a few drinks18:42
jrollhah18:42
*** tbachman has quit IRC18:51
jrollmriedem: api-ref for you https://review.openstack.org/61141518:53
openstackgerritArtom Lifshitz proposed openstack/nova-specs master: Re-propose numa-aware-live-migration spec  https://review.openstack.org/59958718:53
mriedemjroll: i've brought the wrath18:58
dansmithhrm, pretty sure this functional timeout on the down cell series is a real deadlock on our cell cache18:58
*** manjeets has quit IRC18:59
jrollmriedem: thanks, valid points18:59
jrollfor context I haven't touched our API ref in a long time :P18:59
*** manjeets has joined #openstack-nova19:00
mriedemugh19:00
mriedemso GET /v1/nodes/detail is deprecated for GET /v1/nodes?detail=True,19:00
mriedembut the request filter and response parameters for the latter don't mention anything possible in the former19:01
*** tbachman has joined #openstack-nova19:06
jrollI'm not sure it's even properly deprecated19:08
jrolladded a note to the detail=True parameter19:08
*** tbachman has quit IRC19:10
*** moshele has quit IRC19:15
*** tbachman has joined #openstack-nova19:16
*** awaugama has quit IRC19:20
*** hamzy has quit IRC19:21
*** hamzy has joined #openstack-nova19:21
mriedemso we're deprecating the force flag from the evacuate and live migration apis,19:29
*** READ10 has joined #openstack-nova19:29
mriedemwouldn't it behoove us to deprecate that as an option from nova commands as well?19:29
mriedemor at least doc it up real good that you shouldn't use it?19:29
*** hamzy has quit IRC19:30
*** dklyle has joined #openstack-nova19:31
artommriedem, wait, deprecate or remove?19:32
melwittdansmith: would appreciate your review on mah backport https://review.openstack.org/61067319:33
artomBecause for removal the usual novaclient microversion stuff applies, no?19:33
*** david-lyle has quit IRC19:33
mriedemartom: if we don't want people using the force flag to live migrate or evacuate an instance,19:34
mriedemso much so that we're deprecating the api parameter,19:34
mriedemyou could argue that we should not have it in the CLI either19:34
mriedemlike, at all19:34
mriedemeven for older microversions19:34
artommriedem, but it still exists for old microversions19:34
artomIn the API19:34
mriedemyes i know19:34
artomSo, we have to keep client support19:34
mriedemnot really19:35
artomSo if they specifically --os-compute-version <old>, they have it19:35
artomOtherwise, it's gone19:35
mriedemonce all allocations are nested, you won't be able to force at all19:35
mriedemregardless of microversion19:35
mriedemanyway, it was just a thought19:35
mriedemshould probably start by putting the big fat warnings in the API reference into the CLI option descriptions19:36
*** tbachman has quit IRC19:36
artommriedem, ah I see. Well we still have to keep the old API intact, no? Just now we'll return a 400 or something.19:36
artomIf they send a force flag19:37
*** dklyle has quit IRC19:37
mriedemit'll be some kind of error19:37
*** dklyle has joined #openstack-nova19:38
mriedemdon't know if it's a 400 or 40919:38
mriedemit's in gibi's spec19:38
mriedemaspiers: just a few hundred comments in your spec https://review.openstack.org/#/c/609779/19:40
openstackgerritMatt Riedemann proposed openstack/nova master: Fix typo in libvirt.hw_machine_type help  https://review.openstack.org/61142219:43
*** macza has quit IRC19:43
*** macza has joined #openstack-nova19:44
openstackgerritJack Ding proposed openstack/nova-specs master: High Precision Event Timer (HPET) on x86 guests  https://review.openstack.org/60798919:48
*** moshele has joined #openstack-nova19:49
openstackgerritMatt Riedemann proposed openstack/nova master: Document each libvirt.sysinfo_serial choice  https://review.openstack.org/61142619:51
*** dklyle has quit IRC19:52
*** spatel has quit IRC19:53
artommriedem, you led me astray, I demand a refund: https://review.openstack.org/#/c/587439/4/nova/tests/unit/compute/test_compute_mgr.py@743919:55
*** dklyle has joined #openstack-nova19:55
openstackgerritArtom Lifshitz proposed openstack/nova master: Ensure attachment cleanup on failure in driver.pre_live_migration  https://review.openstack.org/58743919:59
mriedemumm20:00
mriedemwhat's the point of even asserting those then20:00
artomI guess Matt was trying to make sure we call all of the things? But... in a for loop, because he didn't feel like writing out each individual method name?20:01
mriedem^O^20:01
mriedemthat's me shrugging, not a bat20:01
artomOr a yelling Asian person?20:02
artom(Can I say that? Is that racist?)20:02
*** moshele has quit IRC20:02
mriedemit's very racist20:02
artomDammit. Hilter 2.0 right here, friends.20:03
openstackgerritMerged openstack/nova master: Merge used_limits extension response into limit view builder  https://review.openstack.org/60603120:05
*** erlon__ has quit IRC20:05
openstackgerritMatt Riedemann proposed openstack/nova master: Fix block_device_mapping_v2 mention in server create API reference  https://review.openstack.org/61143320:15
*** dklyle has quit IRC20:15
*** hamzy has joined #openstack-nova20:17
*** tbachman has joined #openstack-nova20:20
*** mchlumsky has quit IRC20:22
*** READ10 has quit IRC20:34
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Recommend against using --force for evacuate/live migration  https://review.openstack.org/61143620:34
*** dklyle has joined #openstack-nova20:46
*** eharney has quit IRC20:55
*** dklyle has quit IRC20:59
*** dklyle has joined #openstack-nova20:59
*** dklyle has quit IRC21:10
*** dklyle has joined #openstack-nova21:10
openstackgerritmelanie witt proposed openstack/nova master: Add nova-status upgrade check for consoles  https://review.openstack.org/61121421:15
openstackgerritmelanie witt proposed openstack/nova master: Add rolling upgrade info to enable_consoleauth workaround reno  https://review.openstack.org/61121821:15
*** dklyle has quit IRC21:17
*** rcernin has joined #openstack-nova21:18
*** dklyle has joined #openstack-nova21:18
*** slaweq has quit IRC21:25
*** dklyle has quit IRC21:40
*** cdent has quit IRC21:44
*** dklyle has joined #openstack-nova21:44
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Support initial allocation ratios  https://review.openstack.org/55210521:48
*** priteau has quit IRC21:50
mriedemholy fart i'm +2 on the initial allocation ratios spec https://review.openstack.org/#/c/552105/21:51
*** takashin has joined #openstack-nova21:51
*** dklyle has quit IRC21:52
melwittand the peasants rejoiced!21:52
*** dklyle has joined #openstack-nova21:57
*** mriedem has quit IRC22:00
*** bnemec has quit IRC22:01
*** mvkr has joined #openstack-nova22:04
*** mlavalle has quit IRC22:14
*** munimeha1 has quit IRC22:20
*** itlinux has quit IRC22:22
*** dklyle has quit IRC22:36
openstackgerritTakashi NATSUME proposed openstack/nova master: Add API ref guideline for examples  https://review.openstack.org/60406022:37
*** READ10 has joined #openstack-nova23:04
*** macza has quit IRC23:17
openstackgerritMerged openstack/nova stable/rocky: Handle volume API failure in _post_live_migration  https://review.openstack.org/61108323:19
openstackgerritMerged openstack/nova master: Ignore uuid if already set in ComputeNode.update_from_virt_driver  https://review.openstack.org/61116223:19
*** itlinux has joined #openstack-nova23:22
*** lbragstad is now known as lbragstad_50323:26
*** erlon__ has joined #openstack-nova23:33
*** alex_xu has joined #openstack-nova23:44

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!