| *** jamesdenton has quit IRC | 00:36 | |
| *** takashin has joined #openstack-nova | 00:41 | |
| *** tetsuro has joined #openstack-nova | 00:47 | |
| *** macza has joined #openstack-nova | 00:47 | |
| *** yikun has joined #openstack-nova | 00:52 | |
| *** macza has quit IRC | 00:52 | |
| openstackgerrit | Tao Li proposed openstack/nova master: Rollback instance vm_state to original where instance claims failed https://review.openstack.org/592252 | 01:04 |
|---|---|---|
| *** wxy-xiyuan has joined #openstack-nova | 01:05 | |
| *** litao has joined #openstack-nova | 01:09 | |
| *** Kevin_Zheng has joined #openstack-nova | 01:13 | |
| openstackgerrit | Tao Li proposed openstack/nova master: Don't persist retry information into database https://review.openstack.org/605011 | 01:14 |
| *** mrsoul has joined #openstack-nova | 01:19 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:23 | |
| openstackgerrit | Merged openstack/nova stable/queens: Fix nova-status "_check_resource_providers" check https://review.openstack.org/600101 | 01:23 |
| *** hshiina has joined #openstack-nova | 01:26 | |
| *** owalsh_ has joined #openstack-nova | 01:29 | |
| *** owalsh has quit IRC | 01:33 | |
| *** hongbin has joined #openstack-nova | 01:39 | |
| *** jamesdenton has joined #openstack-nova | 01:46 | |
| *** tbachman has quit IRC | 01:49 | |
| *** erlon has quit IRC | 02:01 | |
| *** Dinesh_Bhor has quit IRC | 02:02 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Specifies the storage backend to boot instance https://review.openstack.org/579360 | 02:03 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add volume_type field to BlockDeviceMapping object https://review.openstack.org/604687 | 02:07 |
| *** Dinesh_Bhor has joined #openstack-nova | 02:11 | |
| *** macza has joined #openstack-nova | 02:18 | |
| *** macza has quit IRC | 02:22 | |
| *** psachin has joined #openstack-nova | 02:39 | |
| openstackgerrit | tianhui proposed openstack/nova master: doc: update availability zone doc https://review.openstack.org/605306 | 02:42 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Specifies the storage backend to boot instance https://review.openstack.org/579360 | 02:46 |
| *** Bhujay has joined #openstack-nova | 02:49 | |
| *** imacdonn has quit IRC | 02:50 | |
| *** imacdonn has joined #openstack-nova | 02:50 | |
| *** takashin has left #openstack-nova | 03:02 | |
| *** Bhujay has quit IRC | 03:07 | |
| *** naichuans has joined #openstack-nova | 03:16 | |
| naichuans | Hi, melwitt: has stein runways in use? https://etherpad.openstack.org/p/nova-runways-stein | 03:17 |
| *** cfriesen has quit IRC | 03:19 | |
| openstackgerrit | Merged openstack/nova master: Option "scheduler_default_filters" is deprecated. https://review.openstack.org/604148 | 03:30 |
| openstackgerrit | Merged openstack/nova master: doc:update virtual gpu doc https://review.openstack.org/605012 | 03:30 |
| *** dave-mccowan has quit IRC | 03:44 | |
| *** dave-mccowan has joined #openstack-nova | 03:46 | |
| *** udesale has joined #openstack-nova | 03:53 | |
| *** itlinux has joined #openstack-nova | 03:56 | |
| *** hongbin has quit IRC | 03:59 | |
| *** tetsuro has quit IRC | 04:00 | |
| *** macza has joined #openstack-nova | 04:09 | |
| *** pcaruana has joined #openstack-nova | 04:14 | |
| openstackgerrit | iain MacDonnell proposed openstack/nova master: nova-manage - fix online_data_migrations counts https://review.openstack.org/605329 | 04:33 |
| *** pcaruana has quit IRC | 04:38 | |
| *** Dinesh_Bhor has quit IRC | 04:47 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:54 | |
| *** hshiina has quit IRC | 05:10 | |
| *** hshiina has joined #openstack-nova | 05:13 | |
| *** tbachman has joined #openstack-nova | 05:14 | |
| *** tbachman_ has joined #openstack-nova | 05:16 | |
| *** tbachman has quit IRC | 05:19 | |
| *** tbachman_ is now known as tbachman | 05:19 | |
| openstackgerrit | Merged openstack/nova master: Consumer gen support for put allocations https://review.openstack.org/591647 | 05:25 |
| *** Bhujay has joined #openstack-nova | 05:26 | |
| *** macza_ has joined #openstack-nova | 05:28 | |
| *** macza has quit IRC | 05:32 | |
| *** Bhujay has quit IRC | 05:32 | |
| *** macza_ has quit IRC | 05:33 | |
| *** dave-mccowan has quit IRC | 05:39 | |
| *** pcaruana has joined #openstack-nova | 05:43 | |
| *** Bhujay has joined #openstack-nova | 05:49 | |
| *** jistr has quit IRC | 05:55 | |
| *** jistr has joined #openstack-nova | 05:56 | |
| gmann | api office hour time | 06:03 |
| gmann | #startmeeting nova api | 06:04 |
| openstack | Meeting started Wed Sep 26 06:04:33 2018 UTC and is due to finish in 60 minutes. The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot. | 06:04 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 06:04 |
| *** openstack changes topic to " (Meeting topic: nova api)" | 06:04 | |
| openstack | The meeting name has been set to 'nova_api' | 06:04 |
| gmann | PING List: gmann, alex_xu | 06:04 |
| *** adrianc has joined #openstack-nova | 06:12 | |
| *** ratailor has joined #openstack-nova | 06:12 | |
| gmann | i will be around here for some time. | 06:12 |
| gmann | also updating the bug report and subteam tracking etherpad | 06:13 |
| *** dpawlik has joined #openstack-nova | 06:23 | |
| *** cfriesen has joined #openstack-nova | 06:23 | |
| *** qinglin has joined #openstack-nova | 06:41 | |
| *** qinglin has left #openstack-nova | 06:42 | |
| *** skatsaounis has joined #openstack-nova | 06:42 | |
| openstackgerrit | Sam Morrison proposed openstack/python-novaclient master: Fix user-data argument to rebuild. https://review.openstack.org/605341 | 06:49 |
| gmann | #endmeeting | 06:51 |
| *** openstack changes topic to "RC todo: https://etherpad.openstack.org/p/nova-rocky-release-candidate-todo -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 06:51 | |
| openstack | Meeting ended Wed Sep 26 06:51:50 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 06:51 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-09-26-06.04.html | 06:51 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-09-26-06.04.txt | 06:51 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-09-26-06.04.log.html | 06:51 |
| *** ralonsoh has joined #openstack-nova | 07:02 | |
| *** rcernin has quit IRC | 07:02 | |
| *** alexchadin has joined #openstack-nova | 07:03 | |
| *** tetsuro has joined #openstack-nova | 07:06 | |
| *** cfriesen has quit IRC | 07:13 | |
| *** Dinesh_Bhor has quit IRC | 07:15 | |
| *** psachin has quit IRC | 07:21 | |
| *** helenafm has joined #openstack-nova | 07:25 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: os-xenapi(n-rp): add traits for vgpu n-rp https://review.openstack.org/604269 | 07:25 |
| *** alexchadin has quit IRC | 07:25 | |
| *** psachin has joined #openstack-nova | 07:27 | |
| openstackgerrit | Przemyslaw Lal proposed openstack/os-vif master: add nested DPDK VIF classes for kuryr-kubernetes https://review.openstack.org/604992 | 07:32 |
| gibi | mdbooth: takashi already commented on your missing local delete notification bug that the solution is in the gate queue https://review.openstack.org/#/c/410297/ | 07:35 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Detach and attach boot volumes - Stein https://review.openstack.org/600628 | 07:42 |
| gibi | mdbooth: so you will need a rebase https://review.openstack.org/#/c/604859 on top of https://review.openstack.org/#/c/410297 | 07:42 |
| *** pvc has joined #openstack-nova | 07:42 | |
| *** alexchadin has joined #openstack-nova | 07:51 | |
| *** jpena|off is now known as jpena | 07:51 | |
| *** rcernin has joined #openstack-nova | 07:56 | |
| *** alexchadin has quit IRC | 07:57 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:58 | |
| *** alexchadin has joined #openstack-nova | 07:59 | |
| bauzas | good morning nova | 08:02 |
| *** moshele has joined #openstack-nova | 08:12 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Add Result wrapper class to nova common https://review.openstack.org/605251 | 08:15 |
| *** jistr has quit IRC | 08:30 | |
| *** jistr has joined #openstack-nova | 08:31 | |
| *** adrianc has quit IRC | 08:33 | |
| *** adrianc has joined #openstack-nova | 08:33 | |
| *** derekh has joined #openstack-nova | 08:33 | |
| *** derekh has quit IRC | 08:33 | |
| *** derekh has joined #openstack-nova | 08:34 | |
| naichuans | Good morning, bauzas: have a question to consult, has stein runways in use? https://etherpad.openstack.org/p/nova-runways-stein | 08:39 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add volume-backed evacuate test https://review.openstack.org/604397 | 08:42 |
| *** owalsh_ is now known as owalsh | 08:45 | |
| *** tssurya has joined #openstack-nova | 08:54 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: more tests for delete allocation cases https://review.openstack.org/591811 | 09:01 |
| *** Dinesh_Bhor has quit IRC | 09:03 | |
| *** alexchadin has quit IRC | 09:06 | |
| *** tetsuro has quit IRC | 09:07 | |
| *** moshele has quit IRC | 09:10 | |
| *** dtantsur|afk is now known as dtantsur | 09:10 | |
| *** rcernin has quit IRC | 09:16 | |
| bauzas | naichuans: it has, yes | 09:16 |
| naichuans | bauzas: thanks | 09:17 |
| *** alexchadin has joined #openstack-nova | 09:20 | |
| *** k_mouza has joined #openstack-nova | 09:23 | |
| *** alexchadin has quit IRC | 09:25 | |
| k_mouza | hello all! I'm working on a server with a couple of NVMe drives in it and I want to configure nova to create the instances' ephemeral disks on the NVMes. Is there a way I can set that? Thanks! | 09:26 |
| *** Dinesh_Bhor has joined #openstack-nova | 09:28 | |
| lyarwood | k_mouza: there's an NVMe cinder volume driver iirc | 09:28 |
| *** a-pugachev has joined #openstack-nova | 09:30 | |
| a-pugachev | nova | 09:30 |
| kashyap | johnthetubaguy: Heya, when you get a moment, the Oracle Linux and SLES folks confirmed: https://review.openstack.org/#/c/605060/ | 09:31 |
| lyarwood | k_mouza: https://www.openstack.org/assets/presentation-media/nvmeof-tsg.pptx | 09:31 |
| *** adrianc has quit IRC | 09:33 | |
| *** priteau has joined #openstack-nova | 09:41 | |
| *** alexchadin has joined #openstack-nova | 09:42 | |
| k_mouza | thanks lyarwood! That's nvme-over-fabrics though. I'd want to locally use the NVMEs on the host when an instance is spawned up on that host. Any option for this? I found the "instances_path" option in nova.conf where I can add one mount point (haven't tested this yet), but is there a way to add more than one? | 09:43 |
| *** gameon has quit IRC | 09:46 | |
| *** adrianc has joined #openstack-nova | 09:47 | |
| lyarwood | k_mouza: aside from using the LVM imagebackend (image_type=lvm in nova.conf) no, there's no direct option. | 09:53 |
| tobias-urdin | quick question if somebody feels they have some input, we've been talking for a long time about the images_type cinder backend driver that is not yet written, if one were to prepare for this one would it make sense to place images_type backend instances on the same ceph pool as cinder so that there would be no need to data migration and one could only use the "manage" feature in cinder to impo | 09:54 |
| tobias-urdin | rt that data as a volume? | 09:54 |
| tobias-urdin | there is a lot of stuff in between there though, having the data left but removing the instance for example | 09:54 |
| lyarwood | tobias-urdin: as a migration path between the two? | 10:00 |
| tobias-urdin | yeah | 10:01 |
| lyarwood | tobias-urdin: I'm not sure it would tbh, you would need cinder to know about the volumes in the original images pool, their metadata etc | 10:01 |
| lyarwood | tobias-urdin: I guess we could get that from nova but it's kinda awkward | 10:01 |
| tobias-urdin | iirc cinder can import a ceph rbd volume i would just need to boot the instance from that, is what i was thinking atleast | 10:02 |
| *** ttsiouts has joined #openstack-nova | 10:02 | |
| tobias-urdin | but i'm unsure how i would get nova to detach (read: remove instance) without deleting that rbd volume | 10:02 |
| lyarwood | tobias-urdin: yeah, you can boot from a volume that imports the original image | 10:02 |
| lyarwood | tobias-urdin: there's a boot root disk spec up for review at the moment that would help there | 10:02 |
| lyarwood | tobias-urdin: snapshot the instance into an image, detach the root disk, create a volume from the snapshot image, attach it as the new root disk. | 10:03 |
| lyarwood | tobias-urdin: that's without images_type=cinder btw | 10:03 |
| tobias-urdin | yeah, so if i place images_type=rbd instances on the same pool as cinder creates it's volumes i would (hopefully) be able to snapshot like that and spawn a new instance from that | 10:04 |
| tobias-urdin | and dont have to migrate a whole ceph pool | 10:04 |
| *** ralonsoh has quit IRC | 10:04 | |
| tobias-urdin | that is, when images_type=cinder is available so I somehow could move over images_type=rbd instances | 10:05 |
| tobias-urdin | until then I'll simply hide the option to not spawn from a volume in horizon and instruct API users to spawn from volume-backed but I will assume there will be some stuff spawned with images_type=rbd | 10:05 |
| tobias-urdin | lyarwood: which is what I wanted to plan for, having images_type=cinder would have been awesome right about now :D | 10:06 |
| *** Dinesh_Bhor has quit IRC | 10:10 | |
| lyarwood | tobias-urdin: going to summit? https://www.openstack.org/summit/berlin-2018/vote-for-speakers#/22786 we should add that to the list | 10:11 |
| *** ralonsoh has joined #openstack-nova | 10:11 | |
| *** rmulugu__ has joined #openstack-nova | 10:13 | |
| tobias-urdin | lyarwood: unfortunately not, i'm pushing for backing to go to next summit and ptg, but right now no :( | 10:14 |
| tobias-urdin | our use case(s) is pretty much bfv only | 10:15 |
| k_mouza | thanks for the help lyarwood! | 10:15 |
| tobias-urdin | second that, thanks lyarwood! :) | 10:16 |
| lyarwood | np | 10:16 |
| *** Dinesh_Bhor has joined #openstack-nova | 10:16 | |
| *** Dinesh_Bhor has quit IRC | 10:18 | |
| *** rmulugu__ has quit IRC | 10:21 | |
| *** rmulugu has joined #openstack-nova | 10:21 | |
| *** rmulugu has quit IRC | 10:21 | |
| *** rmulugu has joined #openstack-nova | 10:24 | |
| *** ttsiouts has quit IRC | 10:24 | |
| *** ttsiouts has joined #openstack-nova | 10:25 | |
| *** ttsiouts has quit IRC | 10:29 | |
| *** ttsiouts has joined #openstack-nova | 10:30 | |
| *** Luzi has joined #openstack-nova | 10:42 | |
| *** alexchadin has quit IRC | 10:49 | |
| mdbooth | efried: Are you involved at all with https://bugs.launchpad.net/nova/+bug/1763181 btw? (test_parallel_evacuate_with_server_group) | 10:50 |
| openstack | Launchpad bug 1763181 in OpenStack Compute (nova) "test_parallel_evacuate_with_server_group intermittently fails" [Medium,Confirmed] | 10:50 |
| mdbooth | I only ask because you mentioned it the other day, and a patch I was looking at just hit it | 10:51 |
| *** alexchadin has joined #openstack-nova | 10:58 | |
| *** rmulugu has quit IRC | 10:59 | |
| *** ttsiouts has quit IRC | 11:02 | |
| *** alexchadin has quit IRC | 11:03 | |
| *** erlon has joined #openstack-nova | 11:07 | |
| openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: Live migration of instances https://review.openstack.org/270116 | 11:08 |
| *** k_mouza has quit IRC | 11:10 | |
| openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: Live migration of instances https://review.openstack.org/270116 | 11:11 |
| *** udesale has quit IRC | 11:12 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: Pick next minimum libvirt / QEMU versions for "T" release https://review.openstack.org/605060 | 11:12 |
| *** psachin has quit IRC | 11:13 | |
| *** pcaruana has quit IRC | 11:15 | |
| *** jaypipes has joined #openstack-nova | 11:17 | |
| *** k_mouza has joined #openstack-nova | 11:18 | |
| *** jpena is now known as jpena|lunch | 11:21 | |
| *** psachin has joined #openstack-nova | 11:27 | |
| pooja-jadhav | hi team, I am facing issue for AMQP driver issue, can anyone help me to sort it out | 11:30 |
| *** k_mouza has quit IRC | 11:32 | |
| *** pvc has quit IRC | 11:32 | |
| *** pooja-jadhav is now known as pooja_jadhav | 11:33 | |
| *** oanson has quit IRC | 11:35 | |
| *** k_mouza has joined #openstack-nova | 11:40 | |
| *** brinzhang has joined #openstack-nova | 11:42 | |
| *** ttsiouts has joined #openstack-nova | 11:49 | |
| *** alexchadin has joined #openstack-nova | 11:57 | |
| *** dpawlik has quit IRC | 11:58 | |
| *** alexchadin has quit IRC | 12:17 | |
| *** dtantsur is now known as dtantsur|brb | 12:18 | |
| *** ratailor has quit IRC | 12:20 | |
| *** panda|off is now known as panda | 12:21 | |
| *** tbachman has quit IRC | 12:22 | |
| mdbooth | Eurgh | 12:22 |
| * mdbooth curses python yet again for the python3 debacle | 12:23 | |
| * mdbooth can't use contextlib.nullcontext(), because it's py3 only | 12:23 | |
| *** alexchadin has joined #openstack-nova | 12:25 | |
| sean-k-mooney | mdbooth: is there a six compatiblity shim you can use? | 12:27 |
| mdbooth | sean-k-mooney: Looked, didn't see one | 12:27 |
| *** jpena|lunch is now known as jpena | 12:28 | |
| *** hshiina has quit IRC | 12:29 | |
| *** udesale has joined #openstack-nova | 12:30 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: more tests for delete allocation cases https://review.openstack.org/591811 | 12:31 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: support claim_resources https://review.openstack.org/583667 | 12:31 |
| sean-k-mooney | mdbooth: well looking at the pull request that intoduced it its a its a trival thing to implement yourself https://github.com/python/cpython/pull/4464/files#diff-edbcdd20abc32f8b018deb2353ae925aR474 | 12:32 |
| mdbooth | sean-k-mooney: Right. It's just messy. | 12:33 |
| sean-k-mooney | mdbooth: infact it look like itss python2 compatiable so just copy past it somewhere under a utils moduel or in common and a test for the python versions and eiterh user our veriosn or the upstream | 12:34 |
| mdbooth | The only reason I even went looking for one is because it's such an obvious thing to want which is likely duplicated all over the place. | 12:34 |
| mdbooth | If you don't need everything, presumably you don't need more than: | 12:34 |
| mdbooth | @contextlib.contextmanager: | 12:34 |
| mdbooth | def null() | 12:34 |
| mdbooth | yield | 12:34 |
| mdbooth | But still... python3-- | 12:35 |
| mdbooth | For pointlessly dividing effort | 12:35 |
| sean-k-mooney | mdbooth: ya we already have this https://github.com/openstack/nova/blob/957f4818b0d89cd71552effb8b5a5b231a68de7b/nova/test.py#L79-L85 so i think its fine to add the same for null | 12:35 |
| jroll | you could also blame it on py2 not being dead yet :P | 12:35 |
| mdbooth | jroll: py2 was a vibrant language with bazillions of lines written. Why kill it and create a new language at all? | 12:36 |
| * mdbooth imagines somebody trying to deprecate C because C++ was invented. | 12:36 | |
| mdbooth | Fortunately that community has more sense | 12:37 |
| mdbooth | Argh, contextlib.nested() went away in py3 | 12:40 |
| mdbooth | And the new with syntax doesn't support composition | 12:40 |
| *** psachin has quit IRC | 12:41 | |
| sean-k-mooney | mdbooth: i mean if i had the choice then i would depercate C in favor of c++ but that ship has sailed | 12:41 |
| * mdbooth considers writing if PY2: else: | 12:41 | |
| *** ralonsoh has quit IRC | 12:41 | |
| mdbooth | sean-k-mooney: Indeed. The python answer to that was to fire a missile at the departed ship over the horizon anyway. | 12:41 |
| *** ralonsoh has joined #openstack-nova | 12:42 | |
| *** Tomatosoup- has quit IRC | 12:42 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable nested allocation candidates in scheduler https://review.openstack.org/585672 | 12:45 |
| openstackgerrit | Chen proposed openstack/nova master: doc: update availability zone doc https://review.openstack.org/605306 | 12:46 |
| mdbooth | Oh, ffs. contextlib.ExitStack looks like what I want, but it's py3 only | 12:48 |
| *** liuyulong has joined #openstack-nova | 12:50 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use provider tree in virt FakeDriver https://review.openstack.org/604083 | 12:54 |
| *** janki has joined #openstack-nova | 12:55 | |
| *** ttsiouts has quit IRC | 12:55 | |
| efried | mdbooth: No. I've just hit it a bazillion times. | 12:58 |
| mdbooth | efried: I can see a relatively simple solution, but I'm currently trying to formulate a syntax which would work in both py2 and py3 | 12:59 |
| mdbooth | efried: Not related to the other thing I'm working on, btw | 13:00 |
| mdbooth | Amusingly, the bug is called out explicitly in a comment to the other caller of _validate_instance_group_policy: | 13:00 |
| efried | mdbooth: what are you trying to do? | 13:01 |
| mdbooth | # NOTE(russellb) It's important that this validation be done | 13:01 |
| mdbooth | # *after* the resource tracker instance claim, as that is where | 13:01 |
| mdbooth | # the host is set on the instance. | 13:01 |
| mdbooth | efried: Have an optional context manager | 13:01 |
| efried | optional based on what? | 13:01 |
| mdbooth | Whether or not a lock is required | 13:01 |
| efried | can't you have the context manager itself contain the condition? | 13:02 |
| *** alexchadin has quit IRC | 13:02 | |
| efried | @contextmanager | 13:02 |
| efried | def cm(...): | 13:02 |
| efried | if lock_required: | 13:02 |
| efried | do things | 13:02 |
| efried | yield | 13:02 |
| efried | if lock_required: | 13:02 |
| efried | do things | 13:02 |
| efried | ? | 13:02 |
| mdbooth | Then I'd have to refactor that whole method to be a context manager | 13:03 |
| *** ttsiouts has joined #openstack-nova | 13:03 | |
| efried | or the callers? | 13:03 |
| efried | if lock_required: | 13:03 |
| efried | with cm: | 13:03 |
| efried | do things | 13:03 |
| efried | else: | 13:03 |
| efried | do things | 13:03 |
| efried | ? | 13:03 |
| *** mriedem has joined #openstack-nova | 13:03 | |
| mdbooth | efried: Anyway, there are a bunch of obvious ways to do this. It's frustrating that they're all ugly though as they're deprecated/removed in py2 and not available in py3, or available only in py2 | 13:04 |
| mdbooth | py3 even | 13:04 |
| efried | okay | 13:05 |
| efried | I'm sure I'll understand better when I see it | 13:05 |
| mdbooth | Some language/library designers failed to consider their users | 13:05 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Block automatic transport_url update for cell0 https://review.openstack.org/605414 | 13:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Skip more rebuild tests for cells v1 job https://review.openstack.org/605416 | 13:08 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Block automatic transport_url update for cell0 https://review.openstack.org/605414 | 13:08 |
| edleafe | mdbooth: more likely is that someone proposed the ExitStack addition after py2 was put into maintenance mode. The mistake was OpenStack starting with py2 just because some vendors didn't distribute py3 yet | 13:08 |
| sean-k-mooney | mdbooth: well to be fair they have said they will continue to support it byond 2020 if enough people have not migrated to py3 earlier this year and python3 is 10 years old in december so we have had time to stop using it | 13:08 |
| mdbooth | edleafe: py3 wasn't a safe choice in 2010 :/ | 13:09 |
| edleafe | Sure it was | 13:09 |
| sean-k-mooney | mdbooth: it was not in 2010 but it was in 2014 when 3.4 shipped | 13:10 |
| mdbooth | Ok | 13:10 |
| edleafe | It's just that Ubuntu didn't include it by default, and Xen required py2.4 | 13:10 |
| mdbooth | edleafe: That's 2 reasons right there | 13:10 |
| mdbooth | There were many, many more | 13:10 |
| edleafe | Right, so it isn't python that's the issue; it's the vendors dragging their butts | 13:10 |
| mdbooth | And libraries | 13:11 |
| sean-k-mooney | mdbooth: yes but at this point its well past the time that libary mantains can claim they did not have time to migrate. | 13:11 |
| edleafe | It's chicken-and-egg: if big projects like OpenStack adopt py3, vendors would have motivation to update. If they stay with py2, well, why bother | 13:11 |
| stephenfin | sean-k-mooney: http://py3readiness.org/ | 13:11 |
| mdbooth | edleafe: It was a brand new language which had been around a little over a year whose future was not assured, not least because it marked an epoch in the language. | 13:12 |
| mdbooth | I'd go so far as to say it would have been an insane choice in 2010 | 13:12 |
| sean-k-mooney | almost there what are teh last 11 | 13:12 |
| sean-k-mooney | stephenfin: nothing too critical bar may uwsgi | 13:13 |
| stephenfin | sean-k-mooney: Aye, and I'd imagine that's wrong | 13:13 |
| stephenfin | assuming uWSGI isn't dead | 13:13 |
| stephenfin | https://uwsgi-docs.readthedocs.io/en/latest/Python.html#python-3 | 13:13 |
| sean-k-mooney | stephenfin: was just going to say i assume its outdated | 13:13 |
| stephenfin | Yup https://github.com/unbit/uwsgi/blob/master/setup.py | 13:14 |
| sean-k-mooney | stephenfin: im surprised entrypoints is not updated. | 13:14 |
| sean-k-mooney | stephenfin: has that been pulled into setuptools | 13:15 |
| stephenfin | I don't know that is. We use pkg_resources (or whatever it's called) from setuptools | 13:15 |
| stephenfin | sean-k-mooney: Yeah, I think so. Not sure what that is, tbh | 13:15 |
| *** tbachman has joined #openstack-nova | 13:16 | |
| stephenfin | Looks like pykube also supports it so that's also wrong https://github.com/kelproject/pykube/blob/master/setup.py#L16-L19 | 13:16 |
| sean-k-mooney | aprarently 200 ish lines of code that has not been update in a while https://github.com/takluyver/entrypoints/blob/master/entrypoints.py#L1 | 13:16 |
| *** alexchadin has joined #openstack-nova | 13:17 | |
| stephenfin | Which also supports Python 3 https://github.com/takluyver/entrypoints/blob/master/flit.ini | 13:18 |
| stephenfin | (they use https://github.com/takluyver/flit) | 13:18 |
| *** ttsiouts has quit IRC | 13:19 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run ServerMovingTests with nested resources https://review.openstack.org/604084 | 13:21 |
| *** mrsoul has quit IRC | 13:26 | |
| *** panda has quit IRC | 13:32 | |
| *** dtantsur|brb is now known as dtantsur | 13:33 | |
| *** _hemna has joined #openstack-nova | 13:35 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs https://review.openstack.org/604125 | 13:36 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Specifies the storage backend to boot instance https://review.openstack.org/579360 | 13:42 |
| *** alexchadin has quit IRC | 13:44 | |
| *** lbragstad has quit IRC | 13:45 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands https://review.openstack.org/487405 | 13:45 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Remove IPTools deprecated implementation https://review.openstack.org/605422 | 13:45 |
| *** slaweq has quit IRC | 13:45 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Block automatic transport_url update for cell0 https://review.openstack.org/605414 | 13:46 |
| *** alexchadin has joined #openstack-nova | 13:46 | |
| *** brinzhang has quit IRC | 13:49 | |
| *** lbragstad has joined #openstack-nova | 13:50 | |
| *** alexchadin has quit IRC | 13:50 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add request_spec.RequestGroup versioned object https://review.openstack.org/568840 | 13:51 |
| *** awaugama has joined #openstack-nova | 13:55 | |
| *** k_mouza has quit IRC | 14:01 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add requested_resources field to RequestSpec https://review.openstack.org/567267 | 14:02 |
| *** ttsiouts has joined #openstack-nova | 14:03 | |
| *** k_mouza has joined #openstack-nova | 14:06 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth related standard resource classes https://review.openstack.org/570847 | 14:10 |
| *** janki has quit IRC | 14:12 | |
| *** ttsiouts has quit IRC | 14:14 | |
| *** udesale has quit IRC | 14:15 | |
| *** mlavalle has joined #openstack-nova | 14:20 | |
| *** ttsiouts has joined #openstack-nova | 14:21 | |
| *** panda has joined #openstack-nova | 14:21 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add hide server address tests in test_serversV21.py https://review.openstack.org/605435 | 14:22 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Fix a race evacuating instances in an anti-affinity group https://review.openstack.org/605436 | 14:24 |
| openstackgerrit | Merged openstack/nova master: Consumer gen: remove_provider_from_instance_allocation https://review.openstack.org/591784 | 14:24 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Remove IPTools deprecated implementation https://review.openstack.org/605422 | 14:25 |
| mdbooth | efried: Lets see if ^^^ passes tests. | 14:25 |
| stephenfin | bauzas, mriedem, tonyb: Could one of you do me a solid and abandon these unnecessary stable requirements patches? They're around since forever https://review.openstack.org/#/c/493146/ https://review.openstack.org/#/c/490256/ | 14:25 |
| mdbooth | efried: NB: it's not central to what I'm working on, and I don't really care what colour the bike shed is. If it doesn't merge, I'll still sleep like a baby. | 14:25 |
| bauzas | stephenfin: sure, lemme look | 14:25 |
| bauzas | stephenfin: thanks for helping me to do something else but writing UTs :p | 14:26 |
| stephenfin | You're...welcome? :) | 14:26 |
| * bauzas curses at TDD | 14:26 | |
| stephenfin | bauzas: Oh, and this one https://review.openstack.org/#/c/543705/ | 14:26 |
| bauzas | stephenfin: wait | 14:26 |
| bauzas | stephenfin: if I'm abandoning a bot change, will the bot be able to give us another change? | 14:27 |
| stephenfin | bauzas: I think that bot is dead now? | 14:27 |
| *** Luzi has quit IRC | 14:27 | |
| bauzas | oh right, now that we have the minimums | 14:27 |
| bauzas | mriedem: this ^ ? | 14:28 |
| stephenfin | If not, I'll personally go harass -infra to resolve the issue | 14:28 |
| mdbooth | mriedem: https://review.openstack.org/#/c/604397/ \o/ | 14:29 |
| mdbooth | mriedem: I'll rebase the other patches on it | 14:29 |
| * mdbooth checks the actual output | 14:30 | |
| efried | mdbooth: I'll add it to my watchlist, but not sure I can give it a real review. | 14:30 |
| mdbooth | efried: Yeah, np. Just saying I'm kinda throwing it over the fence. If it inspires somebody else to write a better patch then I'm cool with that, but kinks aside I suspect it'll fix the issue at hand today. | 14:32 |
| mdbooth | If somebody wants a massive rewrite they're welcome to massively rewrite it :) | 14:32 |
| *** artom has quit IRC | 14:34 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Run evacuate tests with local/lvm and shared/rbd storage https://review.openstack.org/604400 | 14:37 |
| efried | bauzas: please have a quick look at new comments on https://review.openstack.org/#/c/599208/ before you put up a new patch set. | 14:38 |
| bauzas | efried: ack, thanks for the notice, I was writing the UTs :) | 14:39 |
| efried | I figgered | 14:39 |
| *** Bhujay has quit IRC | 14:44 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268 | 14:44 |
| bauzas | efried: about your two points, fair enough for the type, but maybe it's YAGNI | 14:46 |
| *** helenafm has quit IRC | 14:47 | |
| efried | bauzas: surely doesn't do any harm | 14:47 |
| openstackgerrit | Merged openstack/nova stable/queens: Skip ServerActionsTestJSON.test_rebuild_server for cells v1 job https://review.openstack.org/605115 | 14:49 |
| mriedem | stephenfin: done | 14:50 |
| stephenfin | mriedem: Ta | 14:50 |
| *** adrianc_ has joined #openstack-nova | 14:50 | |
| sean-k-mooney | mriedem: i tried to review https://review.openstack.org/#/c/605199/ this morning. | 14:53 |
| sean-k-mooney | mriedem: your logic makes sense to me but i dont know why its failing | 14:53 |
| *** adrianc has quit IRC | 14:54 | |
| melwitt | naichuans: yes, stein runways are open. feel free to add approved ready-for-review blueprints to the queue | 14:55 |
| *** adrianc_ has quit IRC | 14:55 | |
| *** cfriesen has joined #openstack-nova | 14:57 | |
| *** k_mouza has quit IRC | 14:58 | |
| mriedem | sean-k-mooney: yeah idk either, it's not very important right now, i have a workaround in nova, and it can wait for dan to come back | 14:59 |
| bauzas | naichuans: keep in mind we need first to have both the consumer-gen series and the scheduler using nested allocations series to be merged before your one | 15:00 |
| bauzas | naichuans: and we also need a reshaping change for the xen driver | 15:00 |
| *** pcaruana has joined #openstack-nova | 15:01 | |
| bauzas | efried: I left a reply on my change | 15:06 |
| efried | ack | 15:06 |
| bauzas | efried: tl;dr if someday nvidia wants to name a type "nvidia-mysuperawesometypeforaimlcoinminingandotherbuzzword', they just need to release a new driver version | 15:07 |
| bauzas | and I just don't want to have a vendors war on the placement API :) | 15:08 |
| sean-k-mooney | bauzas: mdev types? ya they can be anything but i think there is a lenght limit in the kernel | 15:09 |
| bauzas | sean-k-mooney: sure, TEXT ? | 15:09 |
| bauzas | or whatever crazy | 15:09 |
| efried | these type strings correspond to what you need to put in the config, right? | 15:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send resource allocations in the port binding https://review.openstack.org/569459 | 15:09 |
| bauzas | efried: yup, and I hate that | 15:10 |
| sean-k-mooney | dansmith: looking at the kernel docs its not clare i would have to check the cheder for the mdev device | 15:11 |
| sean-k-mooney | dansmith: sorry that was for bauzas ^ | 15:11 |
| bauzas | efried: but there is a big difference in having a vendor-specific information in a config file, and something set in the DB and shown on the API side :) | 15:11 |
| bauzas | s/, and/vs. | 15:11 |
| bauzas | god dammit, my fucking English | 15:11 |
| sean-k-mooney | bauzas: is that different then your normal english :) | 15:12 |
| bauzas | aber ich lerne Deutch | 15:12 |
| bauzas | sean-k-mooney: https://www.kernel.org/doc/Documentation/vfio-mediated-device.txt | 15:14 |
| sean-k-mooney | bauzas: i read that it does not have the max size of a mdev type specified | 15:16 |
| bauzas | yeah it's a struct | 15:16 |
| bauzas | sean-k-mooney: open bar then, right? | 15:16 |
| sean-k-mooney | bauzas: more or less | 15:17 |
| bauzas | oh and look the header | 15:17 |
| bauzas | who wrote this | 15:17 |
| *** janki has joined #openstack-nova | 15:17 | |
| bauzas | now, you'll understand | 15:17 |
| bauzas | it's totally free | 15:17 |
| bauzas | the less I expose, the safer I am :) | 15:18 |
| mnaser | did nova-scheduler go multiprocess in rocky? | 15:18 |
| bauzas | multi-workers yes | 15:20 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 15:21 |
| bauzas | mnaser: https://review.openstack.org/#/c/159382/ | 15:21 |
| mnaser | proposed in 2015, merged in 2018: nice | 15:22 |
| mriedem | it was abandoned for a few years | 15:22 |
| bauzas | mnaser: we had concerns in the past that were resolved | 15:22 |
| mnaser | oh yeah of course | 15:22 |
| mnaser | it makes sense now with placement being there | 15:22 |
| mnaser | running 3 schedulers across 3 nodes was one big game of luck too | 15:23 |
| *** artom has joined #openstack-nova | 15:23 | |
| sean-k-mooney | mnaser: when we stated clamin in placement you could jsut run multiple schuler process to scale without multiprocess support | 15:23 |
| jaypipes | it was only the caching scheduler that was unsafe for multi-workers. | 15:25 |
| sean-k-mooney | jaypipes: post placement | 15:26 |
| mriedem | oh i'm not sure that's true | 15:26 |
| mriedem | you could still race with filter scheduler | 15:26 |
| *** ShilpaSD has joined #openstack-nova | 15:26 | |
| mriedem | since there was no claim in the scheduler | 15:26 |
| sean-k-mooney | mriedem: for numa/sriov resouces? | 15:27 |
| mriedem | for anything | 15:27 |
| sean-k-mooney | for a normal vm request i did not tihnk we coudl | 15:27 |
| mriedem | before pike | 15:27 |
| sean-k-mooney | mriedem: was pike when we started claiming cpus ram and disk in placmenent? | 15:27 |
| jaypipes | right. before pike. | 15:27 |
| mriedem | sean-k-mooney: yes | 15:28 |
| sean-k-mooney | mriedem: ok so ya pre pike you could race post pike bar late claimes on the compute node for pinning/sriov/hugepages no race | 15:28 |
| mriedem | or if you're using server groups... | 15:30 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: Re-propose numa-aware-live-migration spec https://review.openstack.org/599587 | 15:31 |
| mriedem | so all of the NFV things = still race-tastic | 15:31 |
| mriedem | and ironically the scheduler is the one thing that NFV things hate most because they already know exactly where they want to put the goodies | 15:31 |
| sean-k-mooney | mriedem: thats true for multi process works and multi schduler too right they are both as rachy for nfv stuff | 15:32 |
| *** dpawlik has joined #openstack-nova | 15:32 | |
| mriedem | even single scheduler | 15:32 |
| mriedem | single worker | 15:32 |
| mriedem | this is why a late affinity check exists in the compute | 15:32 |
| *** dpawlik has quit IRC | 15:36 | |
| *** janki has quit IRC | 15:36 | |
| mdbooth | efried: Just wondering about external, non-libvirt CI in the context of https://review.openstack.org/#/c/602174/ | 15:39 |
| mdbooth | efried: Do you have one of those? If so, do you write your own jobs 'from scratch', or would the changes to the playbooks/.zuul.yaml in there cause it to fail? | 15:40 |
| efried | mdbooth: We have an external, non-libvirt CI, yes. It runs tempest stuffs. I'm not an expert on it. | 15:41 |
| mdbooth | efried: Ok. Just wondering if you'd end up running gate/test_evacuate.sh by default. | 15:42 |
| mdbooth | If you did, it would fail. | 15:42 |
| mdbooth | mriedem: Do you know how external CI is typically configured ^^^ ? | 15:42 |
| efried | "typically"? | 15:42 |
| efried | not really, no. | 15:42 |
| efried | I couldn't really even tell you how ours is configured :) | 15:42 |
| efried | edmondsw: Any ideas ^ ? | 15:43 |
| edmondsw | not sure what gate/test_evacuate.sh is | 15:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add attach kwarg to base/nova-net allocate_for_instance methods https://review.openstack.org/605464 | 15:43 |
| jaypipes | gibi: question for you on https://review.openstack.org/#/c/591811/. I'm sure I'm just missing something silly... | 15:43 |
| mriedem | mdbooth: they wouldn't | 15:43 |
| efried | mdbooth: It looks to me like this is only going to change the legacy nova-live-migration job. Does that even get triggered anymore? | 15:43 |
| mdbooth | edmondsw: It's new in https://review.openstack.org/#/c/602174/ | 15:44 |
| mriedem | efried: yes | 15:44 |
| gibi | jaypipes: looking | 15:44 |
| mriedem | devstack-gate can run post-test hook scripts | 15:44 |
| mdbooth | Basically if it's 'opt-in' then failing if libvirt isn't configured is the correct behaviour | 15:44 |
| mriedem | some 3rd party CI still uses devstack-gate, some are moving to zuul v3 which doesn't use devstack-gate (unless you define a legacy-style job, like nova-live-migration) | 15:44 |
| mriedem | it's definitely opt-in | 15:44 |
| mdbooth | If we always run it we'd probably want it to just skip | 15:44 |
| mdbooth | mriedem: Thanks | 15:44 |
| *** dklyle has joined #openstack-nova | 15:45 | |
| edmondsw | mdbooth our CI is currently using devstack all-in-ones for each run, so it can't do things like evacuate that require multiple nodes yet... working on that | 15:45 |
| *** munimeha1 has joined #openstack-nova | 15:45 | |
| mriedem | tempest doesn't test evacuate anyway | 15:46 |
| *** macza has joined #openstack-nova | 15:46 | |
| efried | and we're using zuulv3, right? | 15:46 |
| mriedem | that's why this in a separate script, when tempest isn't running | 15:46 |
| *** Bhujay has joined #openstack-nova | 15:46 | |
| openstackgerrit | Merged openstack/nova stable/queens: Follow devstack-plugin-ceph job rename https://review.openstack.org/602019 | 15:46 |
| openstackgerrit | Merged openstack/nova stable/queens: nova-status - don't count deleted compute_nodes https://review.openstack.org/604786 | 15:46 |
| gibi | jaypipes: you are right we are not catching AllocationDeleteFailed explicitly above in the call stack. Fortunately there are generic exception handling in place alreasy that puts the instance in ERROR state. | 15:47 |
| gibi | jaypipes: the move operations are async on the API so when the fault happens there is no way to return that back to the API user anyhow | 15:47 |
| *** xyang has joined #openstack-nova | 15:47 | |
| edmondsw | efried we are not using zuulv3 in PowerVM CI yet, if that's what you were asking | 15:49 |
| efried | dah, okay, thought we were | 15:49 |
| edmondsw | last I heard, zuulv3 wasn't really ready for 3rd party CI usage yet | 15:50 |
| melwitt | mriedem: I was looking at whether I should add the vmware live migration patch (in the queue) to a runway but saw it's failing vmware CI, and I see you've been discussing it with rado https://review.openstack.org/#/c/270116 | 15:51 |
| *** macza has quit IRC | 15:51 | |
| *** panda is now known as panda|bbl | 15:52 | |
| *** macza has joined #openstack-nova | 15:52 | |
| mriedem | i haven't looked at it since my last comments | 15:53 |
| mriedem | it's also failing unit test | 15:53 |
| melwitt | ok. I'll make a note next to it in the queue | 15:54 |
| *** dave-mccowan has joined #openstack-nova | 15:54 | |
| *** tssurya has quit IRC | 15:55 | |
| *** dave-mccowan has quit IRC | 15:57 | |
| mriedem | a shiny donkey to whoever can bring me the head of https://bugs.launchpad.net/nova/+bug/1789998 | 15:57 |
| openstack | Launchpad bug 1789998 in OpenStack Compute (nova) "ResourceProviderAllocationRetrievalFailed ERROR log message on fresh n-cpu startup" [Low,Triaged] | 15:57 |
| efried | F, I forgot *again* to collect my shiny nickel in Denver. | 15:58 |
| mriedem | it's still in my backpack | 15:58 |
| efried | That should probably be my bug. But I'm not likely to have time to look at it today. | 15:58 |
| efried | also, /me wonders what "shiny donkey" means. Sounds like a euphemism for something. | 15:59 |
| efried | Will it also fit in your backpack? | 16:00 |
| *** dave-mccowan has joined #openstack-nova | 16:00 | |
| mdbooth | mriedem: Speaking of common gate bugs: https://review.openstack.org/#/c/605436/ | 16:01 |
| mriedem | efried: https://www.youtube.com/watch?v=UNV44oqUF6k | 16:01 |
| mdbooth | Although I didn't to a full test run on it locally first, so I won't be surprised if there's a kink to work out. | 16:01 |
| mriedem | evacuate + affinity + locks = my head will explode | 16:02 |
| mdbooth | mriedem: Add in a context manager which is a closure and some tail recursion ;) | 16:03 |
| melwitt | I added cfriesen to the review | 16:05 |
| mdbooth | cfriesen: https://review.openstack.org/#/c/605436/ | 16:05 |
| mdbooth | melwitt: Yeah, I was going to ping him earlier but he wasn't around | 16:05 |
| mdbooth | I saw on the bug he looked at it before, and I assume there's some alternative solution in StarlingX | 16:05 |
| melwitt | yeah | 16:06 |
| cfriesen | for the "validate flavor extra-specs and image properties" work item, do we need a spec since it'll presumably result in an error message to the user? or are we allowed to return new error messages? | 16:07 |
| mdbooth | Like I said it's not central to anything on my plate right now, though, so if somebody else wants to do a better job I'm cool with that. I probably won't spend a huge amount of time on it myself, though. | 16:07 |
| mdbooth | I just fixed it because I saw it. | 16:08 |
| cfriesen | mdbooth: taking a look | 16:08 |
| *** dtantsur is now known as dtantsur|afk | 16:08 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add volume-backed evacuate test https://review.openstack.org/604397 | 16:11 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Run evacuate tests with local/lvm and shared/rbd storage https://review.openstack.org/604400 | 16:11 |
| cfriesen | second question, for the "vcpu model extension" change where we'd allow specifying a list of CPU models in nova.conf instead of a single model, would we need a spec even though we're not changing the API? | 16:11 |
| mgariepy | hello, I am upgrading from Pike to Queens but when running nova-manage db online_data_migrations, i get Some instances are still missing keypair information. Unable to run keypair migration at this time | 16:11 |
| *** gibi has quit IRC | 16:14 | |
| mgariepy | i found a few bug in lp concerning a workaround for kilo > liberty upgrade but the fix doesn't work for me as i don't have missing instance in my db. | 16:14 |
| mgariepy | https://bugs.launchpad.net/nova/+bug/1684861 | 16:14 |
| openstack | Launchpad bug 1684861 in OpenStack Compute (nova) newton "Mitaka -> Newton: Database online_data_migrations in newton fail due to missing keypairs" [Medium,In progress] - Assigned to Lee Yarwood (lyarwood) | 16:14 |
| mgariepy | I have 845 entry for select count(instance_uuid) from instance_extra where keypairs is NULL; | 16:15 |
| mdbooth | mgariepy: See #topic. You should probably try #openstack instead | 16:15 |
| mgariepy | well it's a nova issue. | 16:15 |
| mgariepy | i've been upgrading to N o p q. and it fails a Q. | 16:16 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Raise error on timeout in wait_for_versioned_notifications https://review.openstack.org/604859 | 16:16 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add regression test for bug 1550919 https://review.openstack.org/591733 | 16:16 |
| openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | 16:16 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846 | 16:16 |
| melwitt | cfriesen: for extra spec and image properties validation, I think we would do a spec for it because it's an API change. for the cpu model list, from the ptg notes it looks like we thought we'd need a spec, maybe just to capture all of the related information. any opinion on either of these, mriedem? | 16:17 |
| mdbooth | mgariepy: Indeed, but kilo and liberty are long out of support. Perhaps try your vendor? | 16:17 |
| mdbooth | mriedem: We don't have any NFS CI jobs, do we? | 16:18 |
| mgariepy | i'm upgrading from pike to queens. | 16:18 |
| mdbooth | mriedem: I probably asked this before: my memory is terrible. | 16:19 |
| *** a-pugachev has quit IRC | 16:23 | |
| imacdonn | mgariepy: you should at least try in #openstack ... "how do I...?" questions should start there. This channel is about development, not deployment .. if it's determined that there's a current bug, it could be brought here | 16:23 |
| mriedem | mdbooth: we do, | 16:24 |
| mriedem | it's in the experimental queue | 16:24 |
| mriedem | melwitt: yes for api spec for extra spec validation in the api | 16:24 |
| mriedem | as for cpu models stuff in nova.conf, idk, wasn't paying attention to that at the ptg | 16:24 |
| mriedem | mdbooth: pro tip: look in nova's .zuul.yaml file | 16:25 |
| mriedem | ye shall behold legacy-tempest-dsvm-full-devstack-plugin-nfs | 16:25 |
| cfriesen | mdbooth: the starlingx server group validation stuff is here: https://github.com/starlingx-staging/stx-nova/blob/master/nova/compute/manager.py#L1408-L1436 and the check against "older" instances is here: https://github.com/starlingx-staging/stx-nova/blob/master/nova/objects/instance_group.py#L550-L572 | 16:26 |
| cfriesen | melwitt: okay, specs it is. | 16:26 |
| mriedem | cfriesen: i think i might have mentioned this to you before, but you know how starlingx has a patched/upgraded flag it sets on the HostState object in the scheduler and then has a weigher for those? | 16:26 |
| melwitt | thanks. cfriesen ^ you could try the cpu models as a specless bp and when we ask for approval during the nova meeting, someone might point out why it should be a spec, so you might have to write one at that point | 16:26 |
| mriedem | i think the idea being, send new requests to patched/upgraded hosts? | 16:26 |
| mriedem | cfriesen: any reason to not just check the compute's service version to see if it's the latest? | 16:27 |
| mriedem | that would tell you if it's upgraded | 16:27 |
| melwitt | mgariepy: you said earlier that you have not manually deleted any instances from the database? | 16:28 |
| cfriesen | mriedem: one issue was that patching for a bugfix might not affect the service version | 16:28 |
| cfriesen | mriedem: but that would work for the upgrade case | 16:28 |
| mgariepy | melwitt, nop i didn't | 16:29 |
| mriedem | weighing based on bug fix patches seems excessive | 16:29 |
| mgariepy | i think the upgrade db didn't updated the deleted instances attrbutes. | 16:29 |
| *** Bhujay has quit IRC | 16:29 | |
| mriedem | but i guess i get it | 16:29 |
| cfriesen | mriedem: so in the original model due to limitations we had to reboot the compute node when patching, so when rolling out a patch we really didn't want to have to migrate instances multiple times if we could avoid it. Probably less of an issue now. | 16:30 |
| mgariepy | melwitt, updated the keypairs fields in the db.. | 16:31 |
| imacdonn | efried: ping me if you want to discuss https://review.openstack.org/#/c/605329/ - there's probably a sexier way to do it | 16:34 |
| *** panda|bbl is now known as panda | 16:35 | |
| *** ttsiouts has quit IRC | 16:35 | |
| mriedem | imacdonn: gonna need tests | 16:35 |
| mriedem | b/c clearly we weren't testing this before which is why it's a bug | 16:35 |
| imacdonn | mriedem: yeah, I figured that'd come up ... but there aren't any tests at all for this stuff currently, or I failed to find them | 16:35 |
| imacdonn | Trying to verify the contents of a PrettyTable didn't seem appealing :/ | 16:36 |
| mriedem | https://github.com/openstack/nova/blob/41ac87f812f239e38ad3b72c2f2108523ad3444d/nova/tests/unit/test_nova_manage.py#L749 | 16:36 |
| mriedem | there are tests for each individual migration method but you're right that they aren't tested together in aggregate | 16:37 |
| imacdonn | oh. Why isn't that under "cmd" ? | 16:37 |
| mriedem | b/c history | 16:37 |
| imacdonn | mmkay | 16:37 |
| mriedem | no reason we couldn't move it | 16:37 |
| mriedem | except it makes backports a pain in the ass | 16:37 |
| melwitt | mgariepy: oh, hm. ok, we have had online data migrations before that skip deleted records, so that sounds legit but I need to look and double check. it's surprising though that we haven't had this reported before, I'd think it would be common | 16:37 |
| imacdonn | k, I'll look into why the test didn't catch the bug | 16:38 |
| imacdonn | oh, I guess because it didn't have more than 50 of any migration type | 16:38 |
| melwitt | tssurya, mriedem: I've got a call at the top of the hour, so I won't be able to participate much in a cells meeting if we have one | 16:40 |
| mgariepy | melwitt, the cloud i'm upgarding lives from some times. first install was kilo and upgraded | 16:43 |
| mgariepy | but depending on the when it's upgraded, it can cause inconsistency some times.. | 16:43 |
| melwitt | mgariepy: yeah, so I'm looking at this and the migration is that it's moving keypairs from the "main" database to the api database. and it's counting only the non-deleted InstanceExtra. InstanceExtra are marked as deleted when instances are deleted through the nova API https://github.com/openstack/nova/blob/stable/queens/nova/objects/keypair.py#L245 | 16:46 |
| *** dave-mccowan has quit IRC | 16:49 | |
| melwitt | I don't yet understand how this works, I see the migration creates a keypair in the api db, deletes the keypair from the cell db, but I'm not yet seeing the connection with instance_extra | 16:50 |
| melwitt | it looks like the instance_extra part is a separate migration that should have happened before this cell db => api db one that I'm looking at | 16:51 |
| melwitt | ok yeah, instance_obj.migrate_instance_keypairs | 16:52 |
| melwitt | from newton | 16:52 |
| mgariepy | i'm currently using : nova_git_install_branch: d7864fbb9c2c558c409559e1d5989f84c7403832 # HEAD of "stable/queens" as of 23.07.2018 | 16:53 |
| mgariepy | melwitt, can you point me to the commit ? | 16:53 |
| melwitt | mgariepy: here's the code https://github.com/openstack/nova/blob/stable/ocata/nova/objects/instance.py#L1398 that should have run when you upgraded to newton, when you ran the nova-manage db online_data_migrations. did you do that for newton? | 16:54 |
| melwitt | the code no longer exists in queens, so if you missed running that online data migration in newton, you can't run it with the queens code | 16:55 |
| mgariepy | i ran it for sure. | 16:56 |
| *** artom has quit IRC | 16:58 | |
| melwitt | and there were no errors? because while this is only migrating non-deleted records, the check that is blocking you in queens is also only considering non-deleted records, so I don't see how this could be happening unless the online migration from newton was missed or had errors | 16:58 |
| openstackgerrit | Merged openstack/nova master: placement: Always reset conf.CONF when starting the wsgi app https://review.openstack.org/604693 | 16:58 |
| melwitt | as for getting out of it, if the unmigrated instance_extra records are associated with non-deleted instances, I think you're going to have to do something like use the old newton code to migrate the records. if they unmigrated instance_extra records are associated with deleted instances, you're going to have to delete them manually | 17:00 |
| *** derekh has quit IRC | 17:01 | |
| mgariepy | the Ocata code i was runnig wasn't the latest | 17:02 |
| mgariepy | anyway seems to be fixed now. | 17:03 |
| *** artom has joined #openstack-nova | 17:04 | |
| mgariepy | is there a script to validate the database ? | 17:04 |
| mgariepy | i run this cloud since kilo | 17:07 |
| mgariepy | maybe some stuff didn't migrate well, it's just not fun to find out the day you upgrade it | 17:08 |
| *** jpena is now known as jpena|off | 17:09 | |
| melwitt | yeah, so there's this tool called the upgrade status check | 17:11 |
| *** slaweq has joined #openstack-nova | 17:11 | |
| * melwitt looks for docs | 17:11 | |
| melwitt | https://docs.openstack.org/nova/pike/cli/nova-status.html | 17:12 |
| cfriesen | mriedem: re: weighing based on patching, the main usecase currently is for things that fundamentally require taking the node out of service (kernel and kernel modules, for example). But it's coupled with our proprietary patching orchestrator, so it's not really upstreamable. | 17:12 |
| *** slaweq has quit IRC | 17:15 | |
| *** dpawlik has joined #openstack-nova | 17:16 | |
| *** dpawlik has quit IRC | 17:16 | |
| *** dpawlik has joined #openstack-nova | 17:17 | |
| mgariepy | anyway, thanks for you help melwitt, | 17:30 |
| melwitt | mgariepy: yeah, take a look at the nova-status command, that should help you out during each upgrade to make sure you've done all the steps needed for the upgrade to succeed | 17:33 |
| *** ralonsoh has quit IRC | 17:41 | |
| mriedem | melwitt: i assumed the cells meeting was not happening since tssurya isn't around and dan is out | 17:44 |
| cfriesen | melwitt: for the "image properties and flavor extra-spec validation", can we use the fact that rebuild/resize/create can all already return a 400 error to avoid the need for a new microversion? | 17:45 |
| cfriesen | mriedem: maybe you could answer this too. ^ | 17:46 |
| melwitt | yeah, I was thinking mriedem would be better for answering that | 17:46 |
| *** dpawlik has quit IRC | 17:47 | |
| mriedem | cfriesen: uh, no | 17:48 |
| mriedem | because on cloud A i can do something which i can't on cloud B | 17:48 |
| cfriesen | mriedem: what about the argument that it silently failed before (you have to check the instance state to see it go to ERROR) but now we'll return an error? | 17:49 |
| mriedem | i could maybe buy that, but this is a big enough change that i think it's hard to justify | 17:50 |
| mriedem | tbc, i don't think a spec is warranted just b/c of a microversion, but also about how this is going to work and which specs will be validated and how | 17:50 |
| cfriesen | mriedem: okay, new microversion it is. I'm not going to be the one writing this spec, I'm just establishing the parameters for someone else to write it up. | 17:51 |
| cfriesen | (someone else on our side, I mean) | 17:52 |
| mriedem | i'm also only one person | 17:52 |
| mriedem | others might have other opinions | 17:52 |
| mriedem | like alex_xu and gmann | 17:53 |
| cfriesen | we can write it up assuming a new microversion and call it out in the review. easy enough to remove if not needed | 17:54 |
| mriedem | yeah just use the alternatives sectoin | 17:55 |
| mriedem | *section | 17:55 |
| openstackgerrit | iain MacDonnell proposed openstack/nova master: nova-manage - fix online_data_migrations counts https://review.openstack.org/605329 | 18:07 |
| *** slaweq has joined #openstack-nova | 18:12 | |
| *** gibi has joined #openstack-nova | 18:18 | |
| *** dpawlik has joined #openstack-nova | 18:21 | |
| *** slaweq has quit IRC | 18:22 | |
| *** pcaruana has quit IRC | 18:24 | |
| *** lbragstad has quit IRC | 18:24 | |
| *** dpawlik has quit IRC | 18:25 | |
| *** lbragstad has joined #openstack-nova | 18:25 | |
| *** maciejjozefczyk has joined #openstack-nova | 18:33 | |
| openstackgerrit | Jonte Watford proposed openstack/nova master: Add __str__ method to NUMACell related objects https://review.openstack.org/600269 | 18:46 |
| openstackgerrit | Jonte Watford proposed openstack/nova master: Add __str__ method to NUMACell related objects https://review.openstack.org/600269 | 18:49 |
| *** jdillaman has quit IRC | 18:58 | |
| *** jdillaman has joined #openstack-nova | 18:59 | |
| *** dave-mccowan has joined #openstack-nova | 19:05 | |
| *** rtjure has quit IRC | 19:05 | |
| *** rtjure has joined #openstack-nova | 19:08 | |
| openstackgerrit | Jonte Watford proposed openstack/nova master: Add __str__ method to NUMACell related objects https://review.openstack.org/600269 | 19:18 |
| *** slaweq has joined #openstack-nova | 19:24 | |
| *** Sundar has joined #openstack-nova | 19:32 | |
| efried | imacdonn: The test will hopefully help me understand it - or at least prove to myself that you've fixed something. | 19:37 |
| imacdonn | efried: I pasted example output of the failure case in the bug report | 19:38 |
| mriedem | i could use a hashable ovo right about now | 19:39 |
| efried | imacdonn: Yeah, I saw that and it helped me understand the problem, but looking at the code I couldn't see a) how the problem was happening, or b) how you fixed it. It's been a few hours now, maybe a second look will do the trick. | 19:40 |
| mriedem | i've got a sorted list of things, but some of those things could be duplicates, and i need to filter out the duplicates, but ovos are'nt hashable as far as i can tell | 19:40 |
| efried | mriedem: set()? | 19:40 |
| efried | oh, you have a sorted list of OVOs. | 19:41 |
| mriedem | right | 19:41 |
| efried | got it | 19:41 |
| efried | are the __eq__ able? | 19:41 |
| imacdonn | efried: heh. the problem was that each invocation of the inner method was returning a dict with counts from that run, and it was being used to update() a dict in the outer functions .. that replaced the values in the outer one, instead of adding to them | 19:41 |
| mriedem | specifically, 2 of the Migration objects in the same list have the same uuid | 19:41 |
| mriedem | but their updated_at values are different and i just need to remove the older one | 19:41 |
| efried | mriedem: So you sorted by UUID? | 19:41 |
| mriedem | not necessarily | 19:41 |
| mriedem | default sort keys are: sort_keys=['created_at', 'id'] | 19:42 |
| mriedem | http://paste.openstack.org/show/730960/ | 19:43 |
| efried | mriedem: You could use filter() to bastardize set() logic | 19:43 |
| *** k_mouza has joined #openstack-nova | 19:43 | |
| efried | but, yeah, one way or another you're not getting out of this without a loop. | 19:45 |
| mriedem | right i've got a loop | 19:45 |
| mriedem | but it's fugly | 19:45 |
| efried | You could monkey-patch a __hash__ function onto the objects... | 19:45 |
| mriedem | plus, i have to maintain the sort order of the list | 19:45 |
| efried | this is nova.objects.Migration? | 19:46 |
| mriedem | yeah | 19:46 |
| mriedem | ovo actually has a ComparableVersionedObject mixin | 19:46 |
| mriedem | we only use it in one place in nova's objects, the Selection object | 19:47 |
| efried | but you only want to use the UUID to compare the lists? | 19:47 |
| *** k_mouza has quit IRC | 19:47 | |
| mriedem | i think i might have it | 19:54 |
| *** maciejjozefczyk has quit IRC | 19:54 | |
| mriedem | yup got it | 19:55 |
| mriedem | ffs, you know how sometimes you come across a programming problem which seems like something you dealt with on a daily basis when you were a junior in college? | 19:55 |
| mriedem | and now, getting paid high professional tech person salary, you feel dumb as a brick | 19:56 |
| efried | college is way harder than real life | 19:56 |
| efried | imacdonn: Okay, I'm there. The bug is the .update, which is patently wrong. | 19:57 |
| efried | imacdonn: I convinced myself by solving it a different way: http://paste.openstack.org/show/730962/ | 19:57 |
| efried | which isn't better than what you've done, just different. | 19:58 |
| imacdonn | efried: I tried to do it your way, but I got a complaint about tuples ... oh, you changed it to a list | 19:59 |
| efried | yeah | 19:59 |
| efried | no reason for it to be a tuple afaics | 19:59 |
| efried | anyway, I'm approving your patch. Good catch, good fix. | 19:59 |
| imacdonn | cool, thanks! | 19:59 |
| *** bnemec has quit IRC | 20:10 | |
| *** evrardjp has joined #openstack-nova | 20:11 | |
| *** gibi has quit IRC | 20:12 | |
| *** bnemec has joined #openstack-nova | 20:15 | |
| *** priteau has quit IRC | 20:33 | |
| *** munimeha1 has quit IRC | 20:40 | |
| *** gibi has joined #openstack-nova | 20:45 | |
| openstackgerrit | Merged openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | 20:51 |
| openstackgerrit | Merged openstack/nova master: cells: Be explicit in docs about service restarts https://review.openstack.org/603588 | 20:51 |
| openstackgerrit | Merged openstack/nova master: api-ref: add 'migrations' param to GET /os-migrations https://review.openstack.org/605232 | 20:51 |
| openstackgerrit | Merged openstack/nova master: Ignore VirtDriverNotReady in _sync_power_states periodic task https://review.openstack.org/604376 | 20:51 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Ignore VirtDriverNotReady in _sync_power_states periodic task https://review.openstack.org/605533 | 20:58 |
| *** erlon has quit IRC | 21:04 | |
| *** slaweq has quit IRC | 21:06 | |
| *** panda is now known as panda|off | 21:13 | |
| imacdonn | mriedem: something's troubling me about this online migrations stuff | 21:27 |
| imacdonn | https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L374-L386 | 21:27 |
| imacdonn | if there are more than max-count non-migratable rows, wouldn't the method return 50 found and 0 done... even though there could be some that are migratable ? | 21:28 |
| imacdonn | is the migration method supposed to be smart enough to attempt the migratable ones first ? | 21:29 |
| mriedem | i'm not sure what a non-migrateable record is | 21:44 |
| mriedem | dansmith would be the best person to ask about that comment but he's out the rest of this week | 21:44 |
| imacdonn | my interpretation was that there are some migrations that cannot always be applied to all rows .... tho it's not clear what the implications would be | 21:45 |
| *** mgariepy has quit IRC | 21:59 | |
| *** awaugama has quit IRC | 22:00 | |
| *** dklyle has quit IRC | 22:02 | |
| openstackgerrit | Chris Friesen proposed openstack/nova-specs master: Add support for emulated virtual TPM https://review.openstack.org/571111 | 22:05 |
| openstackgerrit | Chris Friesen proposed openstack/nova-specs master: Add support for emulated virtual TPM https://review.openstack.org/571111 | 22:08 |
| *** mgariepy has joined #openstack-nova | 22:13 | |
| *** mlavalle has quit IRC | 22:21 | |
| *** rcernin has joined #openstack-nova | 22:35 | |
| *** dpawlik has joined #openstack-nova | 22:48 | |
| *** dpawlik has quit IRC | 22:52 | |
| *** rcernin has quit IRC | 22:53 | |
| *** rcernin has joined #openstack-nova | 22:55 | |
| *** Sundar has quit IRC | 23:05 | |
| mriedem | holy god 609 things in the check queue | 23:08 |
| *** macza has quit IRC | 23:09 | |
| *** macza has joined #openstack-nova | 23:10 | |
| *** macza has quit IRC | 23:14 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Revert "Deprecate the nova-consoleauth service" https://review.openstack.org/605250 | 23:23 |
| openstackgerrit | melanie witt proposed openstack/nova master: Un-deprecate the nova-consoleauth service https://review.openstack.org/605255 | 23:23 |
| *** jlvillal has joined #openstack-nova | 23:24 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Revert "Deprecate the nova-consoleauth service" https://review.openstack.org/605250 | 23:25 |
| openstackgerrit | melanie witt proposed openstack/nova master: Un-deprecate the nova-consoleauth service https://review.openstack.org/605255 | 23:25 |
| *** dklyle has joined #openstack-nova | 23:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Cross-cell resize https://review.openstack.org/603930 | 23:29 |
| *** mriedem is now known as mriedem_away | 23:30 | |
| *** macza has joined #openstack-nova | 23:34 | |
| *** macza has quit IRC | 23:39 | |
| *** rcernin_ has joined #openstack-nova | 23:41 | |
| *** rcernin has quit IRC | 23:43 | |
| *** liuyulong has quit IRC | 23:47 | |
| *** openstackgerrit has quit IRC | 23:49 | |
| *** hshiina has joined #openstack-nova | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!