| *** dpawlik has joined #openstack-nova | 00:00 | |
| *** dpawlik has quit IRC | 00:04 | |
| *** zigo has quit IRC | 00:05 | |
| *** mriedem_away has quit IRC | 00:10 | |
| *** mlavalle has quit IRC | 00:10 | |
| openstackgerrit | Merged openstack/nova stable/queens: libvirt: Reduce calls to qemu-img during update_available_resource https://review.openstack.org/603358 | 00:11 |
|---|---|---|
| openstackgerrit | Merged openstack/nova stable/rocky: libvirt: Use os.stat and os.path.getsize for RAW disk inspection https://review.openstack.org/603488 | 00:12 |
| *** mvkr has quit IRC | 00:27 | |
| openstackgerrit | Jonte Watford proposed openstack/nova master: Modified version of 0027-Numa-object-string-representations.patch with some updates from the current numa files for nova: numa.py instance_numa_topology.py https://review.openstack.org/600269 | 00:29 |
| *** brinzhang has joined #openstack-nova | 00:31 | |
| *** icey has quit IRC | 00:36 | |
| *** mvkr has joined #openstack-nova | 00:38 | |
| *** sorrison has joined #openstack-nova | 00:52 | |
| *** hongbin has joined #openstack-nova | 01:00 | |
| *** skatsaounis has quit IRC | 01:01 | |
| *** icey has joined #openstack-nova | 01:02 | |
| *** marvin_mhg has joined #openstack-nova | 01:05 | |
| *** marvin_mhg has quit IRC | 01:11 | |
| brinzhang | dansmith: hello, I have a question with this patch(https://review.openstack.org/#/c/604687) ^^ | 01:14 |
| brinzhang | dansmith: Is this using NEW_COLUMN_NAME(volume_type) to represent name or uuid in the block_device_mapping table? | 01:16 |
| *** tbachman has quit IRC | 01:17 | |
| *** erlon has quit IRC | 01:21 | |
| *** mrsoul has quit IRC | 01:24 | |
| *** swamireddy has joined #openstack-nova | 01:31 | |
| *** swamireddy has quit IRC | 01:31 | |
| *** swamireddy has joined #openstack-nova | 01:31 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:41 | |
| *** Dinesh_Bhor has quit IRC | 01:41 | |
| openstackgerrit | Merged openstack/python-novaclient master: docs: Add redirects https://review.openstack.org/604796 | 01:51 |
| *** yingjun has joined #openstack-nova | 02:16 | |
| *** alex_xu has joined #openstack-nova | 02:27 | |
| *** Bhujay has joined #openstack-nova | 02:29 | |
| *** dave-mccowan has quit IRC | 02:29 | |
| *** Bhujay has quit IRC | 02:30 | |
| *** Bhujay has joined #openstack-nova | 02:30 | |
| openstackgerrit | Tao Li proposed openstack/nova master: Rollback instance vm_state to original where instance claims failed https://review.openstack.org/592252 | 02:31 |
| *** sapd1_ has quit IRC | 02:37 | |
| *** sapd1 has joined #openstack-nova | 02:39 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform volume.usage notification https://review.openstack.org/580345 | 02:41 |
| *** psachin has joined #openstack-nova | 02:43 | |
| *** hoangcx has quit IRC | 02:45 | |
| *** hoangcx has joined #openstack-nova | 02:45 | |
| *** dave-mccowan has joined #openstack-nova | 02:50 | |
| *** imacdonn has quit IRC | 02:50 | |
| *** imacdonn has joined #openstack-nova | 02:50 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform compute_task notifications https://review.openstack.org/482629 | 03:20 |
| *** vipul has quit IRC | 03:20 | |
| *** yingjun has quit IRC | 03:36 | |
| *** yingjun has joined #openstack-nova | 03:37 | |
| *** yingjun has quit IRC | 03:38 | |
| *** yingjun has joined #openstack-nova | 03:39 | |
| *** yingjun has quit IRC | 03:39 | |
| *** Bhujay has quit IRC | 03:41 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:46 | |
| *** Dinesh_Bhor has quit IRC | 03:48 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:48 | |
| *** udesale has joined #openstack-nova | 03:57 | |
| *** dpawlik has joined #openstack-nova | 04:00 | |
| *** hoangcx has quit IRC | 04:01 | |
| *** Dinesh_Bhor has quit IRC | 04:01 | |
| *** hoangcx has joined #openstack-nova | 04:01 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add volume_type field to BlockDeviceMapping object https://review.openstack.org/604687 | 04:04 |
| *** tetsuro has quit IRC | 04:05 | |
| *** dpawlik has quit IRC | 04:05 | |
| *** vivsoni has quit IRC | 04:08 | |
| *** vivsoni has joined #openstack-nova | 04:18 | |
| *** Cardoe_ has joined #openstack-nova | 04:22 | |
| *** Cardoe has quit IRC | 04:23 | |
| *** Cardoe_ is now known as Cardoe | 04:23 | |
| *** rcernin has quit IRC | 04:24 | |
| *** ratailor has joined #openstack-nova | 04:25 | |
| *** hongbin has quit IRC | 04:33 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:34 | |
| *** Bhujay has joined #openstack-nova | 04:37 | |
| *** rcernin has joined #openstack-nova | 04:37 | |
| *** tbachman has joined #openstack-nova | 04:40 | |
| *** tbachman_ has joined #openstack-nova | 04:42 | |
| *** tbachman has quit IRC | 04:45 | |
| *** tbachman_ is now known as tbachman | 04:45 | |
| *** vivsoni has quit IRC | 04:48 | |
| *** vivsoni has joined #openstack-nova | 04:58 | |
| *** Dinesh_Bhor has quit IRC | 05:00 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:08 | |
| *** rcernin_ has joined #openstack-nova | 05:17 | |
| *** cfriesen has quit IRC | 05:17 | |
| *** lbragstad has quit IRC | 05:18 | |
| *** rcernin has quit IRC | 05:19 | |
| *** jaosorior has joined #openstack-nova | 05:20 | |
| *** lbragstad has joined #openstack-nova | 05:22 | |
| *** Tomatosoup- has quit IRC | 05:25 | |
| *** Tomatosoup- has joined #openstack-nova | 05:25 | |
| *** vivsoni has quit IRC | 05:33 | |
| *** pcaruana has joined #openstack-nova | 05:41 | |
| *** vivsoni has joined #openstack-nova | 05:44 | |
| *** vivsoni has quit IRC | 05:49 | |
| *** vivsoni has joined #openstack-nova | 05:49 | |
| *** belmoreira has joined #openstack-nova | 05:58 | |
| openstackgerrit | Merged openstack/osc-placement stable/rocky: import zuul job settings from project-config https://review.openstack.org/601402 | 06:00 |
| *** Bhujay has quit IRC | 06:00 | |
| *** tbachman has quit IRC | 06:04 | |
| *** adrianc has joined #openstack-nova | 06:10 | |
| *** bandini has joined #openstack-nova | 06:10 | |
| *** Bhujay has joined #openstack-nova | 06:14 | |
| *** Bhujay has quit IRC | 06:15 | |
| *** Bhujay has joined #openstack-nova | 06:16 | |
| *** slaweq has joined #openstack-nova | 06:18 | |
| *** dpawlik has joined #openstack-nova | 06:21 | |
| openstackgerrit | Merged openstack/python-novaclient master: Add support changes-before for microversion 2.66 https://review.openstack.org/603549 | 06:24 |
| *** brinzh has joined #openstack-nova | 06:29 | |
| *** Bhujay has quit IRC | 06:32 | |
| *** brinzhang has quit IRC | 06:32 | |
| *** Bhujay has joined #openstack-nova | 06:33 | |
| *** s10 has joined #openstack-nova | 06:37 | |
| *** pvc_ has joined #openstack-nova | 06:39 | |
| pvc_ | anyone guys? | 06:39 |
| pvc_ | ResourceProviderTraitRetrievalFailed: Failed to get traits for resource provider with UUID 206fd270-1c55-4601-947c-a2584ed9be68 | 06:39 |
| openstackgerrit | Tao Li proposed openstack/nova master: Rollback instance vm_state to original where instance claims failed https://review.openstack.org/592252 | 06:45 |
| *** sahid has joined #openstack-nova | 06:46 | |
| *** s10 has quit IRC | 06:51 | |
| *** Luzi has joined #openstack-nova | 06:53 | |
| *** lpetrut has joined #openstack-nova | 06:54 | |
| *** lpetrut has quit IRC | 06:56 | |
| *** lpetrut has joined #openstack-nova | 06:56 | |
| *** ralonsoh has joined #openstack-nova | 06:58 | |
| *** slaweq has quit IRC | 06:58 | |
| openstackgerrit | Merged openstack/nova master: Wait for network-vif-plugged on resize revert https://review.openstack.org/595069 | 07:01 |
| openstackgerrit | Tao Li proposed openstack/nova master: Rollback instance vm_state to original where instance claims failed https://review.openstack.org/592252 | 07:01 |
| *** rcernin_ has quit IRC | 07:05 | |
| *** icey has quit IRC | 07:05 | |
| *** Dinesh_Bhor has quit IRC | 07:07 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix wrong bold decoration https://review.openstack.org/604986 | 07:12 |
| *** helenafm has joined #openstack-nova | 07:34 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:36 | |
| *** psachin has quit IRC | 07:41 | |
| *** alexchadin has joined #openstack-nova | 07:42 | |
| *** psachin has joined #openstack-nova | 07:49 | |
| openstackgerrit | Przemyslaw Lal proposed openstack/os-vif master: add nested DPDK VIF class for kuryr-kubernetes https://review.openstack.org/604992 | 07:50 |
| bauzas | good morning Nova | 07:51 |
| *** jpena|off is now known as jpena | 07:53 | |
| *** s10 has joined #openstack-nova | 08:01 | |
| openstackgerrit | huanhongda proposed openstack/nova master: Allow ability for non admin users to use status=DELETED filter on server list https://review.openstack.org/604995 | 08:05 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: os-xenapi(n-rp): add traits for vgpu n-rp https://review.openstack.org/604269 | 08:16 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: os-xenapi(n-rp): add traits for vgpu n-rp https://review.openstack.org/604269 | 08:18 |
| *** hshiina has quit IRC | 08:20 | |
| *** ttsiouts has joined #openstack-nova | 08:27 | |
| *** Dinesh_Bhor has quit IRC | 08:28 | |
| *** dtantsur|afk is now known as dtantsur | 08:38 | |
| *** derekh has joined #openstack-nova | 08:38 | |
| *** pvc_ has quit IRC | 08:42 | |
| *** jiaopengju has quit IRC | 08:42 | |
| *** jiaopengju has joined #openstack-nova | 08:42 | |
| openstackgerrit | Merged openstack/os-vif stable/rocky: import zuul job settings from project-config https://review.openstack.org/601404 | 08:43 |
| *** ttsiouts has quit IRC | 08:46 | |
| *** ttsiouts has joined #openstack-nova | 08:47 | |
| *** slaweq has joined #openstack-nova | 08:49 | |
| *** ttsiouts has quit IRC | 08:51 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:53 | |
| *** alex_xu has quit IRC | 08:54 | |
| *** priteau has joined #openstack-nova | 08:54 | |
| openstackgerrit | Merged openstack/nova stable/queens: Fix service list for disabled compute using MC driver https://review.openstack.org/592311 | 08:55 |
| openstackgerrit | Tao Li proposed openstack/nova master: Don't persist retry information to database https://review.openstack.org/605011 | 08:56 |
| *** alex_xu has joined #openstack-nova | 08:56 | |
| openstackgerrit | Jason SUN proposed openstack/nova master: doc:update virtual gpu doc https://review.openstack.org/605012 | 08:57 |
| *** panda|off is now known as panda | 09:01 | |
| openstackgerrit | Jason SUN proposed openstack/nova master: doc:update virtual gpu doc https://review.openstack.org/605012 | 09:01 |
| *** dpawlik has quit IRC | 09:05 | |
| *** zhubx007 has joined #openstack-nova | 09:06 | |
| *** dpawlik has joined #openstack-nova | 09:06 | |
| *** ttsiouts has joined #openstack-nova | 09:07 | |
| *** zhubx007 has quit IRC | 09:07 | |
| *** ttsiouts has quit IRC | 09:10 | |
| *** ttsiouts has joined #openstack-nova | 09:10 | |
| *** zhubx007 has joined #openstack-nova | 09:10 | |
| *** tetsuro has joined #openstack-nova | 09:11 | |
| *** zhubx007 has left #openstack-nova | 09:11 | |
| *** owalsh_ is now known as owalsh | 09:11 | |
| *** alexchadin has quit IRC | 09:12 | |
| *** alexchadin has joined #openstack-nova | 09:16 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consumer gen support for delete instance allocations https://review.openstack.org/591597 | 09:16 |
| *** tssurya has joined #openstack-nova | 09:17 | |
| gibi | jaypipes, efried: ^^ I had to respin it as I failed to create a py3 compatible test | 09:17 |
| bauzas | gibi: I'm working on a respin, but you're next in my todolist | 09:18 |
| gibi | bauzas: cool, thanks | 09:19 |
| * gibi leaves for an early lunch | 09:19 | |
| *** janki has joined #openstack-nova | 09:20 | |
| *** AJaeger_ has left #openstack-nova | 09:20 | |
| *** vivsoni has quit IRC | 09:22 | |
| *** fanzhang_ has joined #openstack-nova | 09:23 | |
| *** jackyzhu has joined #openstack-nova | 09:25 | |
| *** jackyzhu has quit IRC | 09:29 | |
| *** vivsoni has joined #openstack-nova | 09:32 | |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: Clean up instance on target node if evacuate fails https://review.openstack.org/375623 | 09:34 |
| openstackgerrit | Merged openstack/nova stable/queens: Filter deleted computes from get_all_by_uuids() https://review.openstack.org/604448 | 09:35 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Specifies the storage backend to boot instance https://review.openstack.org/579360 | 09:38 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Raise error on timeout in wait_for_versioned_notifications https://review.openstack.org/604859 | 09:51 |
| *** s10 has quit IRC | 09:51 | |
| *** adrianc has quit IRC | 09:53 | |
| *** moshele has joined #openstack-nova | 10:02 | |
| *** takashin has left #openstack-nova | 10:03 | |
| *** janki has quit IRC | 10:07 | |
| openstackgerrit | Merged openstack/nova master: Validate transport_url in nova-manage cell_v2 commands https://review.openstack.org/569858 | 10:10 |
| *** adrianc has joined #openstack-nova | 10:17 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Specifies the storage backend to boot instance https://review.openstack.org/579360 | 10:17 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add regression test for bug 1550919 https://review.openstack.org/591733 | 10:31 |
| openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | 10:31 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846 | 10:31 |
| *** Bhujay has quit IRC | 10:31 | |
| *** Bhujay has joined #openstack-nova | 10:32 | |
| *** ttsiouts has quit IRC | 10:35 | |
| *** s10 has joined #openstack-nova | 10:42 | |
| *** ratailor_ has joined #openstack-nova | 10:43 | |
| *** rcernin_ has joined #openstack-nova | 10:43 | |
| *** ratailor has quit IRC | 10:44 | |
| *** s10 has quit IRC | 10:47 | |
| *** s10 has joined #openstack-nova | 10:47 | |
| *** stephenfin_ is now known as stephenfin | 10:48 | |
| *** janki has joined #openstack-nova | 10:50 | |
| stephenfin | moshele: It seems I can use the mstflint package to configure MLX cards and the mlx4_en driver can be configured as-is. Is there any reason to download and run the mlnxofedinstall tool described here https://community.mellanox.com/docs/DOC-2365 | 10:52 |
| *** rcernin_ has quit IRC | 10:52 | |
| *** alexchadin has quit IRC | 10:52 | |
| stephenfin | Just making sure I'm not shooting myself in the foot, heh | 10:52 |
| lyarwood | sigh | 10:53 |
| lyarwood | ops | 10:53 |
| lyarwood | wrong channel, ignore ;) | 10:53 |
| *** s10 has quit IRC | 10:54 | |
| *** Dinesh_Bhor has quit IRC | 10:56 | |
| jaypipes | gibi: ack | 10:59 |
| *** artom has quit IRC | 11:00 | |
| *** erlon has joined #openstack-nova | 11:00 | |
| jaypipes | gibi: the remainder of that series seems to need a rebase.. are you working on that? | 11:00 |
| gibi | jaypipes: sure, I'm doing that right now. Also I have to fix general comments from efried there as well | 11:01 |
| gibi | jaypipes: I will ping you when the next patch is up | 11:01 |
| jaypipes | gibi: ok dokey, no prob. just making sure :) | 11:01 |
| gibi | :) | 11:01 |
| kashyap | Hey any SLES folks here? | 11:02 |
| kashyap | If so, can you please respond to the open question here: http://lists.openstack.org/pipermail/openstack-dev/2018-September/135007.html | 11:03 |
| kashyap | (Also for Oracle Linux) | 11:03 |
| *** ttsiouts has joined #openstack-nova | 11:04 | |
| *** janki has quit IRC | 11:07 | |
| kashyap | imacdonn: Hi, seems like last I pinged you on this subject; mind having a gander at the above thread and answering the open question? | 11:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consumer gen support for put allocations https://review.openstack.org/591647 | 11:09 |
| gibi | jaypipes: here is the next patch rebased ^^ | 11:10 |
| *** helenafm has quit IRC | 11:10 | |
| jaypipes | gibi: Kösz! | 11:14 |
| *** pcaruana has quit IRC | 11:15 | |
| gibi | jaypipes: én köszönöm a review-t | 11:15 |
| jaypipes | gibi: Nagyon szívesen :) | 11:16 |
| jaypipes | gibi: I can do this all day thanks to trusty Google Translate. :P | 11:16 |
| *** udesale has quit IRC | 11:17 | |
| gibi | jaypipes: I will do that as well as it is soo inconvenient to switch to the hu keyboard layout to type those exta dots over letters :P | 11:17 |
| adrianc | stephenfin: you can use mstflint package (use mstconfig utility to enable SR-IOV), mlnxofedinstall is used to install MLNX_OFED package which includes mlxconfig utility. | 11:17 |
| gibi | jaypipes: be aware that google translate only trusty for simple expressions and standalon words and it tend to fail hard on grammar :) | 11:18 |
| *** panda is now known as panda|afk | 11:19 | |
| jaypipes | gibi: :) | 11:21 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Validate transport_url in nova-manage cell_v2 commands https://review.openstack.org/605040 | 11:21 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Wait for network-vif-plugged on resize revert https://review.openstack.org/605041 | 11:21 |
| *** dtantsur is now known as dtantsur|bbl | 11:25 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consumer gen: remove_provider_from_instance_allocation https://review.openstack.org/591784 | 11:26 |
| *** moshele has quit IRC | 11:27 | |
| *** brinzh has quit IRC | 11:29 | |
| *** moshele has joined #openstack-nova | 11:33 | |
| sean-k-mooney | jaypipes: o/ quick question, when opening a blueprint should i set the series goal to stein or leave that to the approver when they review? | 11:36 |
| sean-k-mooney | similarly for milestone target | 11:36 |
| *** jpena is now known as jpena|lunch | 11:38 | |
| sean-k-mooney | stephenfin: gibi efried same question ^ i would like to target https://blueprints.launchpad.net/nova/+spec/libvirt-neutron-sriov-livemigration to stein and m2 but not sure if its rude too do that myself or should i leave that to the approver if approved? | 11:41 |
| jaypipes | sean-k-mooney: leave that to the approver | 11:42 |
| sean-k-mooney | jaypipes: cool will do thanks | 11:43 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add volume-backed evacuate test https://review.openstack.org/604397 | 11:46 |
| openstackgerrit | Przemyslaw Lal proposed openstack/os-vif master: add nested DPDK VIF classes for kuryr-kubernetes https://review.openstack.org/604992 | 11:54 |
| *** alexchadin has joined #openstack-nova | 11:56 | |
| *** helenafm has joined #openstack-nova | 11:57 | |
| *** psachin has quit IRC | 12:07 | |
| *** ttsiouts has quit IRC | 12:09 | |
| bauzas | jaypipes: efried: thanks for the super fast review of https://review.openstack.org/#/c/599208/ | 12:15 |
| bauzas | I'll provide a new revision hopefully today EOB | 12:16 |
| openstackgerrit | Merged openstack/nova stable/rocky: nova-status - don't count deleted compute_nodes https://review.openstack.org/604785 | 12:16 |
| bauzas | that said, I need to AWOL for 30 mins (paperwork) | 12:16 |
| jaypipes | bauzas: np | 12:19 |
| *** ttsiouts has joined #openstack-nova | 12:21 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: scheduler: Increase alternate count in smaller environments https://review.openstack.org/593074 | 12:23 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: scheduler: rename index to num_instances https://review.openstack.org/605054 | 12:23 |
| *** vivsoni has quit IRC | 12:26 | |
| *** tetsuro has quit IRC | 12:28 | |
| mdbooth | gibi: We jumped the gun on my notification timeout fix :) | 12:29 |
| lyarwood | bauzas: ^ would you mind taking another swing at the above scheduler bugfix? | 12:29 |
| mdbooth | TimeoutError isn't a thing in python2, apparently | 12:29 |
| mdbooth | But the python3 functional test actually uncovered an error in another test \o/ | 12:30 |
| gibi | mdbooth: interestingly I did google that exception before I +2d the patch and it seemd legit | 12:30 |
| mdbooth | gibi: Should probably increase that timeout globally, tbh. In the notification tests it's 10 secs. | 12:31 |
| gibi | mdbooth: then I suggest to use AssertionError as unittest asserts raises that as well | 12:31 |
| *** Bhujay has quit IRC | 12:31 | |
| mdbooth | gibi: ack. Will change it now. | 12:31 |
| mdbooth | gibi: What do you think about increasing the timeout? | 12:31 |
| mdbooth | http://logs.openstack.org/59/604859/2/check/nova-tox-functional-py35/1a5d5b7/job-output.txt.gz | 12:31 |
| mdbooth | ^^^ is a failure in python3 functional | 12:31 |
| gibi | mdbooth: if that helps with those test locally for you then I'm fine with it | 12:32 |
| *** Bhujay has joined #openstack-nova | 12:32 | |
| mdbooth | I know we hit these regularly, because I've been scratching my head about random failures in my evacuate test for a couple of weeks | 12:32 |
| mdbooth | Until I found this | 12:32 |
| gibi | mdbooth: ohh this is the root cause of the evac failure. good catch! | 12:32 |
| *** Bhujay has quit IRC | 12:33 | |
| *** Bhujay has joined #openstack-nova | 12:33 | |
| *** lpetrut has quit IRC | 12:33 | |
| mdbooth | gibi: Ok, will change to AssertionError and bump timeout to 10s | 12:34 |
| *** tbachman has joined #openstack-nova | 12:35 | |
| mdbooth | I *almost* wrote a meta-testcase, but didn't. | 12:35 |
| mdbooth | I think I'll write a small meta-testcase this time, too. | 12:35 |
| *** alexchadin has quit IRC | 12:36 | |
| *** lpetrut has joined #openstack-nova | 12:36 | |
| *** alexchadin has joined #openstack-nova | 12:37 | |
| *** alexchadin has quit IRC | 12:37 | |
| *** ratailor_ has quit IRC | 12:37 | |
| *** alexchadin has joined #openstack-nova | 12:37 | |
| *** alexchadin has quit IRC | 12:38 | |
| *** alexchadin has joined #openstack-nova | 12:38 | |
| *** alexchadin has quit IRC | 12:38 | |
| *** alexchadin has joined #openstack-nova | 12:39 | |
| *** alexchadin has quit IRC | 12:39 | |
| *** jpena|lunch is now known as jpena | 12:40 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: Pick next minimum libvirt / QEMU versions for "T" release https://review.openstack.org/605060 | 12:41 |
| *** lbragstad has quit IRC | 12:47 | |
| stephenfin | adrianc: Do 'mlxconfig' and 'mstconfig' fulfil the same role, in that case? | 12:48 |
| *** panda|afk is now known as panda | 12:49 | |
| *** alexchadin has joined #openstack-nova | 12:49 | |
| adrianc | stephenfin: Yes | 12:51 |
| *** ralonsoh has quit IRC | 12:53 | |
| *** alexchadin has quit IRC | 12:54 | |
| *** lbragstad has joined #openstack-nova | 12:59 | |
| *** tssurya has quit IRC | 13:01 | |
| *** tssurya has joined #openstack-nova | 13:01 | |
| *** ralonsoh has joined #openstack-nova | 13:02 | |
| *** belmoreira has quit IRC | 13:05 | |
| *** ujjain- has joined #openstack-nova | 13:06 | |
| *** ujjain- is now known as ujjain | 13:09 | |
| *** lbragstad has quit IRC | 13:09 | |
| *** ujjain has left #openstack-nova | 13:10 | |
| *** alexchadin has joined #openstack-nova | 13:16 | |
| *** lbragstad has joined #openstack-nova | 13:23 | |
| *** lbragstad has quit IRC | 13:24 | |
| *** lbragstad has joined #openstack-nova | 13:24 | |
| *** lbragstad has quit IRC | 13:26 | |
| *** lbragstad_ has joined #openstack-nova | 13:26 | |
| *** lbragstad_ has quit IRC | 13:26 | |
| *** lbragstad has joined #openstack-nova | 13:27 | |
| *** ttsiouts has quit IRC | 13:27 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: doc:update virtual gpu doc https://review.openstack.org/605012 | 13:28 |
| *** icey has joined #openstack-nova | 13:28 | |
| *** belmoreira has joined #openstack-nova | 13:29 | |
| efried | mdbooth: Why is that suddenly failing in every spot?? | 13:32 |
| efried | (I mean even in py3) | 13:32 |
| mdbooth | efried: Which one? | 13:33 |
| mdbooth | My functional test? | 13:33 |
| mdbooth | for evac? | 13:33 |
| efried | yeah | 13:33 |
| mdbooth | Because I rebased it on top of a patch with a bug :) | 13:33 |
| *** jdillaman has quit IRC | 13:34 | |
| mdbooth | which I'm just fixing, btw | 13:34 |
| efried | I'm confused. It appears to be on bottom. | 13:34 |
| mdbooth | Nah, there's a new one on the bottom | 13:34 |
| mdbooth | Raise error on timeout in wait_for_versioned_notifications | 13:34 |
| mdbooth | I broke it this morning | 13:35 |
| efried | I'm looking at https://review.openstack.org/#/c/604859/ itself. | 13:35 |
| mdbooth | Yeah, there are 2 problems with that patch | 13:36 |
| efried | Forget the py2 - TimeoutError ENOENT - I'm looking at the py3 failures and can't figure out why they are *all* failing now. | 13:36 |
| mdbooth | First is a py2 error (novel) | 13:36 |
| mdbooth | Right, that's because it's uncovering bugs in other tests | 13:36 |
| efried | But even the ones that were already checking the result are now failing. | 13:37 |
| *** munimeha1 has joined #openstack-nova | 13:37 | |
| mdbooth | Well, it uncovered one of those | 13:37 |
| mdbooth | Wait, has it run again? I only saw a single failre | 13:37 |
| efried | omg, is this going to fix the famed and fabled bug #1763181 ?? | 13:37 |
| openstack | bug 1763181 in OpenStack Compute (nova) "test_parallel_evacuate_with_server_group intermittently fails" [Medium,Confirmed] https://launchpad.net/bugs/1763181 | 13:37 |
| mdbooth | efried: It's probably because the gate is currently rammed | 13:37 |
| *** jdillaman has joined #openstack-nova | 13:38 | |
| efried | okay, well, I'll leave you to it. | 13:38 |
| mdbooth | efried: i.e. I suspect they're actually races | 13:38 |
| mdbooth | efried: I'm going to check properly, though | 13:39 |
| efried | okay, never mind what I said about the existing ones failing. They're not. | 13:39 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Raise error on timeout in wait_for_versioned_notifications https://review.openstack.org/604859 | 13:47 |
| mdbooth | efried: Incidentally, the other possibility is that in some of these tests the notification has never been emitted | 13:49 |
| mdbooth | Because that would previously have been silently ignored | 13:49 |
| efried | yup | 13:51 |
| mdbooth | I've just thrown that patch back into the gate with fixes, but it's going to fail again | 13:51 |
| efried | mdbooth: But IMO if we want that to be okay, we should explicitly try/except+ignore the wait_for_notifications call in the test case. | 13:51 |
| mdbooth | efried: ack, for sure | 13:52 |
| efried | so ++ to your change, at least in principle :) | 13:52 |
| *** mlavalle has joined #openstack-nova | 13:54 | |
| *** awaugama has joined #openstack-nova | 14:00 | |
| *** dtantsur|bbl is now known as dtantsur | 14:04 | |
| *** ttsiouts has joined #openstack-nova | 14:05 | |
| *** alexchadin has quit IRC | 14:07 | |
| mdbooth | efried gibi: In the case of nova.tests.functional.regressions.test_bug_1735407.TestParallelEvacuationWithServerGroup.test_parallel_evacuate_with_server_group the test appears to be incorrect | 14:08 |
| mdbooth | It's calling evacuate on 2 instances, one of which is going to fail due to anti-affinity | 14:08 |
| mdbooth | It's then asserting it got 2 instances of instance.rebuild.start | 14:08 |
| mdbooth | Problem is that request validation happens before that notification is sent | 14:09 |
| mdbooth | So it has never received those notifications | 14:09 |
| mdbooth | However, it does sound wrong that the notification isn't emitted first | 14:09 |
| gibi | mdbooth: doesn't this test want to assert that the late validate of the server groups catches the parallel evacuation? | 14:09 |
| mdbooth | I believe so, yes | 14:10 |
| mdbooth | However, I think it's expecting the start notification to be emitted before the failure occurs | 14:11 |
| mdbooth | Which imho isn't unreasonable | 14:11 |
| mdbooth | But that's not the reality | 14:11 |
| *** alexchadin has joined #openstack-nova | 14:12 | |
| mdbooth | See ComputeManager._do_rebuild_instance | 14:12 |
| mdbooth | We call _validate_instance_group way at the top | 14:12 |
| mdbooth | Notification is emitted below that | 14:12 |
| gibi | mdbooth: ohh I see now. So we can expect one rebuild.start but the second evac will never reach that point | 14:15 |
| mdbooth | gibi: ack | 14:16 |
| gibi | mdbooth: I thin it is OK to change that to wait only for a single notification | 14:17 |
| *** alexchadin has quit IRC | 14:17 | |
| gibi | mdbooth: as the two self._wait_for_migration_status(server1, ['done', 'failed']) calls will make sure that the test waits for the evac to finish/fail | 14:17 |
| *** alexchadin has joined #openstack-nova | 14:19 | |
| *** mriedem has joined #openstack-nova | 14:26 | |
| mnaser | https://review.openstack.org/#/q/I811e84af46d678c3fdbf94ee400eabe659fc3d4e if anyone wants to continue with the backporting +2s | 14:28 |
| mriedem | done | 14:31 |
| mdbooth | mriedem: I messed with your script again, btw. Still waiting to see how it gets on in the gate. | 14:31 |
| *** lamt has joined #openstack-nova | 14:33 | |
| *** Luzi has quit IRC | 14:33 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: move_allocations https://review.openstack.org/591810 | 14:33 |
| gibi | mriedem: hi, do you have anything for the notification meeting? | 14:34 |
| mriedem | mdbooth: ok, there is a bug in there | 14:34 |
| mriedem | comment inline | 14:34 |
| mriedem | gibi: nope | 14:34 |
| mdbooth | mriedem: Not unexpected :) | 14:34 |
| gibi | mriedem: then there will be no meeting today | 14:34 |
| mdbooth | mriedem: Are you able to run this locally, btw? | 14:34 |
| mriedem | mdbooth: i don't have a setup for it atm so no | 14:35 |
| mriedem | i could, but don't right now | 14:35 |
| *** moshele has quit IRC | 14:35 | |
| gibi | mriedem, jaypipes: I think https://review.openstack.org/#/c/591597 is good to go now | 14:38 |
| mriedem | looking | 14:40 |
| *** vivsoni has joined #openstack-nova | 14:42 | |
| mriedem | +W | 14:46 |
| *** yikun has quit IRC | 14:47 | |
| gibi | mriedem: thanks | 14:48 |
| gibi | mriedem: the next 3 patches also ready from my perspective | 14:48 |
| gibi | mriedem: the rest is still in my queue | 14:50 |
| *** wxy-xiyuan has quit IRC | 14:50 | |
| openstackgerrit | caoyuan proposed openstack/nova master: Option "scheduler_default_filters" is deprecated. https://review.openstack.org/604148 | 14:50 |
| mriedem | ok | 14:51 |
| *** dpawlik has quit IRC | 14:52 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add volume-backed evacuate test https://review.openstack.org/604397 | 14:54 |
| *** cfriesen has joined #openstack-nova | 14:54 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Option "scheduler_default_filters" is deprecated. https://review.openstack.org/604148 | 14:55 |
| *** dpawlik has joined #openstack-nova | 14:57 | |
| *** alexchadin has quit IRC | 14:57 | |
| openstackgerrit | Merged openstack/nova master: api-ref: Fix wrong bold decoration https://review.openstack.org/604986 | 15:00 |
| *** Bhujay has quit IRC | 15:03 | |
| *** david-lyle has quit IRC | 15:04 | |
| *** lpetrut has quit IRC | 15:04 | |
| *** dklyle has joined #openstack-nova | 15:05 | |
| mdbooth | efried: All the failures I've fixed so far have been deterministic, btw. | 15:05 |
| efried | That's goodness. | 15:05 |
| mdbooth | Either asserting a notification which doesn't happen, or asserting a notification without having first mocked fake_notifier | 15:06 |
| mdbooth | race -> deterministic failure == goodness | 15:07 |
| *** ttsiouts has quit IRC | 15:08 | |
| *** ttsiouts has joined #openstack-nova | 15:10 | |
| *** udesale has joined #openstack-nova | 15:12 | |
| *** maciejjozefczyk has quit IRC | 15:13 | |
| *** dave-mccowan has quit IRC | 15:14 | |
| sean-k-mooney | mdbooth: i mean its now race -> deterministic sucsses but definetly a step in the right direction. | 15:15 |
| mdbooth | sean-k-mooney: Nah, they're failing. They were previously asserting things which weren't true, but were silently ignored. | 15:16 |
| sean-k-mooney | ya i have fixed incorerectly mocked thest in the past that always assered things that were incorrect. they always make me sad when i find them | 15:17 |
| *** sapd1_ has joined #openstack-nova | 15:19 | |
| *** dpawlik has quit IRC | 15:25 | |
| mriedem | gibi: some comments on https://review.openstack.org/#/c/591647/ | 15:33 |
| imacdonn | kashyap: I already responded on the ops list: http://lists.openstack.org/pipermail/openstack-operators/2018-September/015931.html | 15:35 |
| cfriesen | mdbooth: what's the story on the functional test failures for https://review.openstack.org/#/c/578846/ ? | 15:36 |
| kashyap | imacdonn: Most excellent. I missed to notice it | 15:36 |
| mdbooth | cfriesen: It's in a parent commit. Working on it. | 15:37 |
| mdbooth | cfriesen: I'm getting sucked into fixing all the things again :/ | 15:37 |
| * mdbooth forsees doom and abandoned patches | 15:37 | |
| mdbooth | gibi: In ComputeManager and ComputeAPI, is self.notifier always a legacy notifier? | 15:39 |
| *** ttsiouts has quit IRC | 15:40 | |
| kashyap | imacdonn: So, no problem with the chosen future versions. Thanks for confirming! | 15:40 |
| *** sapd1_ has quit IRC | 15:42 | |
| imacdonn | kashyap: np | 15:43 |
| *** adrianc has quit IRC | 15:43 | |
| *** ttsiouts has joined #openstack-nova | 15:43 | |
| mdbooth | gibi: Oh, this one looks like it might be an actual bug | 15:43 |
| imacdonn | mriedem: not sure if you're following the bug or not - (I believe) I figured out what's causing that volume extend intermittent failure - https://bugs.launchpad.net/nova/+bug/1732199 | 15:44 |
| openstack | Launchpad bug 1732199 in OpenStack Compute (nova) "test_extend_attached_volume fails with Unexpected compute_extend_volume result 'Error'" [Medium,Confirmed] | 15:44 |
| *** helenafm has quit IRC | 15:44 | |
| mdbooth | gibi: If an instance is deleted locally by compute api, it only sends an unversioned delete.end, whereas a proper delete by compute manager sends both | 15:44 |
| imacdonn | mriedem: prob should discuss in #openstack-cinder I suppose | 15:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Skip ServerActionsTestJSON.test_rebuild_server for cells v1 job https://review.openstack.org/605115 | 15:46 |
| *** artom has joined #openstack-nova | 15:49 | |
| *** belmoreira has quit IRC | 15:52 | |
| openstackgerrit | sean mooney proposed openstack/nova-specs master: Add spec for sriov live migration https://review.openstack.org/605116 | 15:54 |
| openstackgerrit | Eric Fried proposed openstack/nova master: consumer gen: move_allocations https://review.openstack.org/591810 | 15:56 |
| *** _d34dh0r53_ is now known as d34dh0r53 | 16:05 | |
| *** pcaruana has joined #openstack-nova | 16:07 | |
| *** adrianc has joined #openstack-nova | 16:10 | |
| *** eandersson has joined #openstack-nova | 16:14 | |
| *** sahid has quit IRC | 16:17 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Raise error on timeout in wait_for_versioned_notifications https://review.openstack.org/604859 | 16:18 |
| *** ttsiouts has quit IRC | 16:20 | |
| *** ttsiouts has joined #openstack-nova | 16:20 | |
| mdbooth | gibi: Please could you have a look at ^^^. It contains a fix to non-test code. The problem is a call to _delete_and_check_allocations() in a test. | 16:21 |
| mdbooth | The problem is it results in a local delete, which only currently emits a legacy notification, which I suspect is a real bug. | 16:21 |
| mdbooth | I'd vastly prefer not to fix that in this change. | 16:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Explicitly fail if trying to attach SR-IOV port https://review.openstack.org/605118 | 16:22 |
| *** ttsiouts has quit IRC | 16:25 | |
| *** udesale has quit IRC | 16:27 | |
| *** adrianc has quit IRC | 16:29 | |
| *** s10 has joined #openstack-nova | 16:37 | |
| *** dklyle has quit IRC | 16:40 | |
| openstackgerrit | Merged openstack/nova master: Consumer gen support for delete instance allocations https://review.openstack.org/591597 | 16:43 |
| melwitt | . | 16:43 |
| mriedem | blarg, you can't instance.create() from one cell to another b/c _from_db_object resets the fields and instance.create() only saves what fields are changed | 16:44 |
| *** dklyle has joined #openstack-nova | 16:44 | |
| *** dtantsur is now known as dtantsur|afk | 16:45 | |
| *** s10 has quit IRC | 16:46 | |
| *** adrianc has joined #openstack-nova | 16:50 | |
| *** dtantsur|afk has quit IRC | 16:51 | |
| *** panda is now known as panda|off | 16:52 | |
| *** dtantsur has joined #openstack-nova | 16:57 | |
| *** dtantsur is now known as dtantsur|afk | 16:58 | |
| *** derekh has quit IRC | 17:00 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Raise error on timeout in wait_for_versioned_notifications https://review.openstack.org/604859 | 17:08 |
| mdbooth | gibi: nm, took it out ^^^ | 17:08 |
| mdbooth | Just have to wait on an unversioned notification instead | 17:09 |
| *** Kevin_Zheng has quit IRC | 17:12 | |
| *** priteau has quit IRC | 17:13 | |
| *** ralonsoh has quit IRC | 17:15 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Restore nova-consoleauth to install docs https://review.openstack.org/605154 | 17:15 |
| melwitt | mriedem: in the lp bug, you also mentioned adding a warning about the deprecation of nova-consoleauth. did you have a place for the warning in mind in the install guides? ^ | 17:19 |
| mdbooth | Is it a bug that the api node only emits a legacy notification on local delete, but a full delete emits both? | 17:20 |
| mdbooth | Sounds like a bug, but notifications aren't my thing. | 17:21 |
| mdbooth | If it's a bug, I'll file it and reference it in a comment. | 17:21 |
| *** jpena is now known as jpena|off | 17:29 | |
| tssurya | dansmith: if we use scatter-gather-cells function is there a way to differentiate legit exceptions upon which we should fail versus the ones we want to handle ? | 17:30 |
| tssurya | at this point, all just raise the "raised_exception_sentinel" | 17:31 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Raise error on timeout in wait_for_versioned_notifications https://review.openstack.org/604859 | 17:31 |
| * mdbooth decided it's a bug, filed it, and added it as a comment | 17:31 | |
| mdbooth | The check queue is toast | 17:32 |
| melwitt | tssurya: currently there isn't a way, as you point out. I've been thinking about that too and it would be nice if we could include the actual exception raised per cell. I think we still want the sentinel though, so we'd need a new format for the value side of the results dict | 17:33 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add regression test for bug 1550919 https://review.openstack.org/591733 | 17:33 |
| openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | 17:33 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846 | 17:33 |
| tssurya | melwitt: yea we would have to tweak the return part I guess | 17:34 |
| melwitt | tssurya: I suppose we could just change things to include the exception object instead of the sentinel, then you just have to check isinstance(x, Exception) instead of checking "if sentinel" | 17:34 |
| melwitt | to know whether you've got a good result vs an exception | 17:35 |
| tssurya | so you mean at this point https://github.com/openstack/nova/blob/ebab3adb2849c17ebb0249277da89d0d8111e591/nova/context.py#L445 ? | 17:37 |
| melwitt | yeah, one way would be to just store the exception object in 'result' instead of the sentinel. then obviously anywhere in the code that checks "if raised_exception_sentinel" would have to be updated to check isinstance(x, Exception) instead | 17:38 |
| sean-k-mooney | melwitt: i was not following but is that not an anti pattern | 17:40 |
| *** panda|off has quit IRC | 17:41 | |
| melwitt | sean-k-mooney: is it? I said earlier if we wanted to keep the sentinels, we'd have to do something to change the format of the value side to be able to include optional additional data (where the exception object could go) | 17:42 |
| sean-k-mooney | melwitt: oh your talking about scatter_gather_cells | 17:42 |
| melwitt | yes | 17:42 |
| sean-k-mooney | the antipattern is the explcit type check in python e.g. isinstance checks but this is not a standard case | 17:43 |
| *** panda has joined #openstack-nova | 17:45 | |
| melwitt | oh, I see. yeah, if results = {cell_uuid: (result or sentinel, optional data)}, then the optional data type could be assumed based on the sentinel | 17:45 |
| sean-k-mooney | melwitt: if the was c++ or pyton3 only i would lean towrods makeing result a concurrent future or std::expected type | 17:45 |
| melwitt | sean-k-mooney: I don't know much about that but the expected type will be different depending on whether the cell returned a result or an exception | 17:46 |
| tssurya | melwitt: for me the requirement came because of wanting to differentiate between InstanceNotFound valid exception versus an actuall cell down exception here: https://review.openstack.org/#/c/591658/7/nova/compute/api.py@2327 , feel free to leave a comment and we can also raise it at tomorrow's cells meeting; need to leave office now | 17:47 |
| *** panda is now known as panda|off | 17:47 | |
| *** AJaeger has joined #openstack-nova | 17:47 | |
| sean-k-mooney | in c++ std::expect models a type that either pacages the expected result or and error type. when you use it you can test if it it has an error or not with an if expect ... | 17:47 |
| melwitt | tssurya: ok, will look there. I was thinking we would need to be able to differentiate exceptions but didn't see a concrete example till now | 17:48 |
| melwitt | sean-k-mooney: oh, nice | 17:48 |
| AJaeger | nova stable team, could you review a simple zuul job change, please? https://review.openstack.org/602018 https://review.openstack.org/602019 https://review.openstack.org/602022 https://review.openstack.org/602023 | 17:49 |
| AJaeger | mriedem: I answered your comment on https://review.openstack.org/#/c/602018/1/.zuul.yaml | 17:49 |
| sean-k-mooney | melwitt: so my preference would be have result be a type that you can just do "if result: #handel sucess else : # handel error" | 17:49 |
| melwitt | sean-k-mooney: we also have "did not respond" i.e. timeout waiting for result | 17:50 |
| sean-k-mooney | melwitt: to do that you would have to override __bool__ in the wrapper class to see if the value was an exception type or not | 17:51 |
| melwitt | which could be an error, but then you have to check the type of the error | 17:51 |
| melwitt | but I guess we have to do that anyway if we're differentiating | 17:51 |
| *** tssurya has quit IRC | 17:51 | |
| sean-k-mooney | melwitt: ya. if you stuff the exeption into the value field you can just rerais it and cactch it polymorifclly assuming the timeout is a different exception type | 17:52 |
| melwitt | yeah, could do that | 17:53 |
| sean-k-mooney | melwitt: so basically its the same as what you suggted but your hiding the type checking in a dedicated class that does it for you instead of doing it in multiple places | 17:53 |
| sean-k-mooney | melwitt: python3's concurrent futures basically wrap this up nicly for you too but they are python 3 only https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.Future | 17:55 |
| melwitt | sean-k-mooney: thanks | 17:56 |
| sean-k-mooney | melwitt: want me to mock up an example of using what i described so you can see how it would work. im not sure its the correct solution in this case but its what i would try personally. | 17:59 |
| melwitt | sean-k-mooney: an example that would work for python2 also? I would be interested in looking at it if you mock it up | 18:05 |
| sean-k-mooney | melwitt: yes i can make it work for python too. ill mock something up and push it with some unit tests showing its usage later tonight | 18:05 |
| sean-k-mooney | *python 2 | 18:06 |
| melwitt | thanks | 18:06 |
| *** macza has joined #openstack-nova | 18:11 | |
| openstackgerrit | Jack Ding proposed openstack/nova master: Handle missing marker during online data migration https://review.openstack.org/605164 | 18:16 |
| jaypipes | man I fucking hate the scheduler unit tests. | 18:17 |
| jaypipes | what a pile of shit. | 18:17 |
| sean-k-mooney | jaypipes: let me guess asserting behavior 3 levles deep then just the local function behvior? | 18:17 |
| sean-k-mooney | anyone know where the devstack log is stored by default? ther eused to be an xstack log in /opt/stack/logs but that seams to not be a thing anymore | 18:19 |
| jaypipes | sean-k-mooney: more the endless hierarchy of copy/pasted test case classes. | 18:20 |
| sean-k-mooney | jaypipes: yeah OOP | 18:20 |
| sean-k-mooney | jaypipes: did i mention im playing with creating a programming language. it "object orianted" current it does not allow inheritence but you can have objects :P | 18:22 |
| *** adrianc has quit IRC | 18:22 | |
| AJaeger | mriedem: could you review the other stable backports of that ceph change as well, please? | 18:26 |
| mriedem | yeah | 18:26 |
| AJaeger | thanks | 18:28 |
| melwitt | what is going on with the gate lately? changes that have been in the queue for 26 hours | 18:31 |
| AJaeger | melwitt: high failure rate plus one of our clouds down, see clark's email from a week ago or so | 18:33 |
| melwitt | found it, thank you | 18:33 |
| AJaeger | melwitt: http://lists.openstack.org/pipermail/openstack-dev/2018-September/134867.html | 18:33 |
| AJaeger | melwitt: still applies regarding cloud down - clarkb is testing a fix right now | 18:34 |
| *** jitek4 has joined #openstack-nova | 18:44 | |
| openstackgerrit | Jonte Watford proposed openstack/nova master: This commit adds __str__ and __repr__ methods to objects InstanceNUMACell and NUMACell. These will generate more readable representations of the objects for use in logs. https://review.openstack.org/600269 | 18:46 |
| mriedem | AJaeger: waiting to see the renamed job run on ocata https://review.openstack.org/#/c/602023/ | 18:48 |
| AJaeger | mriedem: good catch - you won't see it. We miss the parent devstack job there. This needs different handling - I'll fix... | 18:49 |
| *** gouthamr has quit IRC | 18:52 | |
| openstackgerrit | Jonte Watford proposed openstack/nova master: This commit adds __str__ method to objects InstanceNUMACell and NUMACell. These will generate more readable representations of the objects for use in logs. https://review.openstack.org/600269 | 18:54 |
| mriedem | jaypipes: i've got an o.vo problem that maybe you can help solve, | 19:01 |
| mriedem | i've got an Instance object from cell1, pulled fresh from the db so there are no fields marked as 'changed', | 19:01 |
| mriedem | i want to clone that object and re-create it in cell2 which should mean just changing the context to point at cell2 db and delete the id field so Instance.create() won't puke on it, | 19:02 |
| mriedem | the problem is, the cloned object doesn't have any changed fields marked, so Instance.create() doesn't actually save anything into the cell2 db for the instance for things like vm_state, task_state, etc | 19:03 |
| mriedem | know of any way to dirty up the object so it looks new? I tried a obj_from_primitive(obj.obj_to_primitive()) dance but that doesn't work b/c it maintains the 'changes' list of dirty fields | 19:03 |
| mriedem | i'm thinking i might just have to do something like, new_obj = objects.Instance(new_context, **instance.obj_to_primitive()['data']) | 19:04 |
| *** toabctl has quit IRC | 19:05 | |
| melwitt | mriedem: I think the only precedent we have for that is the get_new_instance in build request https://github.com/openstack/nova/blob/master/nova/objects/build_request.py#L237 | 19:05 |
| sean-k-mooney | mriedem: can you do a deep copy and then instead update the cell and then instaead of resetting the fileds just mark them as dirty? | 19:07 |
| mriedem | blech, ok i'll hack that up the same | 19:07 |
| *** toabctl has joined #openstack-nova | 19:07 | |
| melwitt | there might be a better way to do it, just mentioning that as a data point | 19:08 |
| mriedem | yeah i'll copy that, | 19:08 |
| mriedem | as i've seen and from dansmith's comment in that code, | 19:08 |
| mriedem | keeping the fields dirty would involve ovo internals | 19:09 |
| melwitt | aye | 19:09 |
| mriedem | like passing a dirty_white_boy=True kwarg to obj_from_primitive | 19:09 |
| *** gouthamr has joined #openstack-nova | 19:12 | |
| jaypipes | mriedem: yeah, it's blech. | 19:19 |
| mriedem | i'm still waiting for someone to get my foreigner reference | 19:20 |
| jaypipes | heh | 19:24 |
| melwitt | sorry, I only know the major foreigner hits | 19:24 |
| mriedem | hey it made it to the top 12 https://en.wikipedia.org/wiki/Dirty_White_Boy_(song)#Chart_performance | 19:26 |
| melwitt | huh. | 19:26 |
| sean-k-mooney | yeah cirros does not have sriov drivers for 1gb intel nics ... | 19:37 |
| mriedem | ok i've got something hacked up for now | 19:38 |
| mriedem | http://paste.openstack.org/show/730743/ | 19:38 |
| sean-k-mooney | mriedem: without messing with internal that looks resonably clean | 19:39 |
| sean-k-mooney | mriedem: it would be nice to a "mark_dirty" function instead of setattr(new_obj, field, getattr(obj, field)) but that works | 19:40 |
| mriedem | i'll post something to ovo that dan can look at while he's pooing in a cave | 19:40 |
| *** erlon has quit IRC | 19:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Option "scheduler_default_filters" is deprecated. https://review.openstack.org/604148 | 19:50 |
| imacdonn | mriedem: is there an easy way to see what 'nova-manage db online_data_migrations' would do, without actually doing it ? | 19:51 |
| sean-k-mooney | melwitt: im going to call it a night an grab a beer. am im going to start hacking on that exection wrapper class and ill push something up in an hour or so while i wait for dinner. ill add you as a reviewer when i submit the patch. | 19:51 |
| mriedem | imacdonn: as in a dry run option? | 19:52 |
| mriedem | no there isn't | 19:52 |
| mriedem | jaypipes: sean-k-mooney: like this https://review.openstack.org/605199 | 19:53 |
| melwitt | sean-k-mooney: cool, thanks | 19:53 |
| imacdonn | mriedem: yeah. ok. I think that would be useful. I tried hacking out the check for max-count being greater than zero, but it's not that simple, apparently | 19:53 |
| *** AJaeger has left #openstack-nova | 19:54 | |
| mriedem | imacdonn: well, you'd have to plumb that down through all of the online data migration routines | 19:54 |
| mriedem | to not actually commit any changes | 19:54 |
| mriedem | so it's not trivial | 19:54 |
| imacdonn | mriedem: also, this doesn't seem right. The counts in the table should be non-zero? Caveat: it's Queens, so if anything's been fixed since then .... http://paste.openstack.org/show/730819/ | 19:54 |
| sean-k-mooney | mriedem: is the condition on line 401 reversed? e.g. should it be if leave_dirty? | 19:55 |
| sean-k-mooney | mriedem: i would have expected the changed filed to be the dirty fields personally but i have not really looked at how this works closely | 19:57 |
| mriedem | no | 19:58 |
| mriedem | if not False (True): set the same changed fields on the copy as were on the primitive | 19:58 |
| mriedem | which defaults to no changed fields | 19:58 |
| openstackgerrit | Jonte Watford proposed openstack/nova master: Add __str__ method to objects NUMACell instances https://review.openstack.org/600269 | 19:59 |
| sean-k-mooney | mriedem: i have added myself as a review and ill step through it properlly tomorow. | 20:01 |
| openstackgerrit | Merged openstack/nova stable/rocky: Follow devstack-plugin-ceph job rename https://review.openstack.org/602018 | 20:01 |
| mriedem | imacdonn: well that table definitely looks wrong... | 20:01 |
| imacdonn | mriedem: yeah. Trying to figure out how that could happen | 20:01 |
| mriedem | my guess is you're dumping the last result set, | 20:02 |
| mriedem | which is when there were no more things to migrate | 20:02 |
| mriedem | so you get 0s at the end | 20:02 |
| imacdonn | I'm just running the command :) | 20:02 |
| imacdonn | but yeah | 20:02 |
| mriedem | you said you hacked something | 20:02 |
| imacdonn | Oh, I only hacked out the check that max-count has to be >0 .. but I'm not applying that here | 20:03 |
| mriedem | however, | 20:03 |
| mriedem | http://logs.openstack.org/87/604687/4/check/neutron-grenade/6c10d43/logs/grenade.sh.txt.gz | 20:03 |
| mriedem | shows that the table output is also busted in our grenade run | 20:03 |
| mriedem | http://logs.openstack.org/87/604687/4/check/neutron-grenade/6c10d43/logs/grenade.sh.txt.gz#_2018-09-25_09_44_39_645 | 20:03 |
| mriedem | well... | 20:03 |
| imacdonn | I think you're right .. I think that each call to _run_migration clobbers the previous result, instead of adding to it | 20:04 |
| mriedem | maybe not, if we just don't have anything to migrate | 20:04 |
| *** gouthamr_ has joined #openstack-nova | 20:05 | |
| mriedem | that populate_uuids migration was added in queens, and looking at a grenade run from queens, we should see bdms getting migrated to have a uuid, and i'm not seeing any results in the table for a grenade run on queens | 20:05 |
| mriedem | http://logs.openstack.org/48/604448/1/check/neutron-grenade/19d8166/logs/grenade.sh.txt.gz | 20:05 |
| mriedem | so yeah, likely busted | 20:05 |
| mriedem | imacdonn: please report a bug | 20:05 |
| imacdonn | I think the clobberation is happening at https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L720 | 20:05 |
| imacdonn | will bug | 20:06 |
| mriedem | yeah because of https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L689 | 20:06 |
| mriedem | resets everything to 0 | 20:06 |
| imacdonn | it makes a new "migrations" dict, with all of the members, for each pass | 20:07 |
| *** janki has joined #openstack-nova | 20:12 | |
| imacdonn | https://bugs.launchpad.net/nova/+bug/1794364 | 20:18 |
| openstack | Launchpad bug 1794364 in OpenStack Compute (nova) "'nova-manage db online_data_migrations' count fail" [Undecided,New] | 20:18 |
| *** gouthamr has quit IRC | 20:38 | |
| *** gouthamr_ is now known as gouthamr | 20:39 | |
| *** pcaruana has quit IRC | 20:43 | |
| mriedem | melwitt: can you this this queens change? https://review.openstack.org/#/c/600101/ | 20:44 |
| mriedem | *hit | 20:44 |
| melwitt | sure | 20:44 |
| *** awaugama has quit IRC | 20:50 | |
| *** ttsiouts has joined #openstack-nova | 20:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Cross-cell resize https://review.openstack.org/603930 | 20:58 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: add 'migrations' param to GET /os-migrations https://review.openstack.org/605232 | 21:07 |
| *** janki has quit IRC | 21:08 | |
| mriedem | https://www.openstack.org/summit/berlin-2018/vote-for-speakers#/22793 | 21:18 |
| mriedem | dansmith: ^ lemme know if you want to moderate that instead of me | 21:18 |
| mriedem | i'm pretty sure you do | 21:19 |
| *** awaugama has joined #openstack-nova | 21:19 | |
| melwitt | when is dan coming back? | 21:20 |
| mriedem | next week | 21:23 |
| *** awaugama has quit IRC | 21:24 | |
| *** slaweq has quit IRC | 21:27 | |
| *** slaweq has joined #openstack-nova | 21:27 | |
| imacdonn | Error attempting to run <function create_incomplete_consumers at 0x7f60e7498668> | 21:40 |
| imacdonn | but it didn't log anything :/ This migrations stuff is finicky ..... ? | 21:40 |
| *** awaugama has joined #openstack-nova | 21:42 | |
| * imacdonn finds https://bugs.launchpad.net/nova/+bug/1790701 | 21:45 | |
| openstack | Launchpad bug 1790701 in OpenStack Compute (nova) rocky "online_data_migrations fail in rocky+" [Critical,Fix committed] - Assigned to Matt Riedemann (mriedem) | 21:45 |
| openstackgerrit | Jonte Watford proposed openstack/nova master: Add __str__ method to objects NUMACell objects https://review.openstack.org/600269 | 21:47 |
| mriedem | imacdonn: https://review.openstack.org/#/c/600085/ | 21:48 |
| imacdonn | mriedem: ack | 21:49 |
| mriedem | just haven't updated that yet | 21:49 |
| melwitt | mriedem: I made the mistake of thinking nova-consoleauth wasn't required anymore because the proxy code defaults to only using the db backend to verify a console. but the nova-compute code is still storing the token auth in both nova-consoleauth and the database backend, for reasons I don't know, when I took over the patch series | 22:00 |
| * imacdonn recalls reporting that issue :) | 22:01 | |
| melwitt | this cycle, I can remove the nova-compute code that stores the token auth in nova-consoleauth, at which point nova-consoleauth would not be needed on a fresh install | 22:01 |
| melwitt | as for the deprecation, we could un-deprecate it | 22:03 |
| mriedem | well, | 22:03 |
| mriedem | if nova-compute in stein doesn't need it, | 22:03 |
| mriedem | that would be the time to deprecate it, | 22:03 |
| *** munimeha1 has quit IRC | 22:03 | |
| mriedem | but rocky wasn't really the right time to deprecate it sounds like | 22:03 |
| mriedem | since something was still using it | 22:03 |
| mriedem | i do'nt think i recall a retroactive undeprecate on stable | 22:04 |
| *** scarab_ has joined #openstack-nova | 22:05 | |
| melwitt | yeah, I think that's accurate, that rocky was not the right time. the only benefit to it that I can think of is, a heads up the cycle before it's no longer needed. but that's a stretch, I guess | 22:05 |
| *** ttsiouts has quit IRC | 22:05 | |
| *** ttsiouts has joined #openstack-nova | 22:06 | |
| *** scarab_ has quit IRC | 22:06 | |
| *** scarab_ has joined #openstack-nova | 22:06 | |
| mriedem | i don't think there would be anything wrong with undeprecating it on stable/rocky, | 22:08 |
| *** scarab_ has quit IRC | 22:08 | |
| mriedem | if it's wrong, we shouldn't report it as deprecated b/c people will be getting warnings | 22:08 |
| mriedem | we have done something like this in the past when we removed the original [placement_database] options b/c they weren't used | 22:08 |
| mriedem | and them being in config made people think they could use them | 22:08 |
| imacdonn | I discovered this issue because I was trying to be a good boy, and not to deprecated things, when looking at rocky upgrade, so I turned off the service, and things broke | 22:08 |
| imacdonn | not do* deprecated things | 22:09 |
| melwitt | yeah. I have caused a fair bit of operator pain with this mistake. sorry for that | 22:09 |
| mriedem | yeah if there is no way to *not* use it in rocky, then saying it's deprecated (but still required) is weird | 22:09 |
| imacdonn | not complaining .. just sharing my experience ;) | 22:10 |
| mriedem | if ^ is true, then we likely want to undeprecate in stable/rocky | 22:10 |
| melwitt | I'm sure it was not pleasant :P | 22:10 |
| mriedem | gotta run | 22:10 |
| *** mriedem has quit IRC | 22:10 | |
| *** ttsiouts has quit IRC | 22:10 | |
| melwitt | yeah, there's no way to not use it in rocky. I'll propose some reverts, because we need to undo the deprecation | 22:10 |
| melwitt | s/nova-compute/nova-api/ earlier | 22:16 |
| openstackgerrit | melanie witt proposed openstack/nova master: Revert "Deprecate the nova-consoleauth service" https://review.openstack.org/605250 | 22:20 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add Result wrapper class to nova common https://review.openstack.org/605251 | 22:21 |
| sean-k-mooney | melwitt: ^ i think this is what we want for the cell gather thing | 22:21 |
| melwitt | thanks | 22:22 |
| *** mvkr has quit IRC | 22:22 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Revert "Deprecate the nova-consoleauth service" https://review.openstack.org/605250 | 22:25 |
| sean-k-mooney | melwitt: no worries it was fun. i like creating special pourpose data structure like this. i rarely have a need to do it however :) | 22:26 |
| melwitt | :) | 22:28 |
| *** mvkr has joined #openstack-nova | 22:35 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Un-deprecate the nova-consoleauth service https://review.openstack.org/605255 | 22:45 |
| *** dklyle has quit IRC | 22:48 | |
| *** awaugama has quit IRC | 22:59 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Enforce case-sensitive hostnames in aggregate host add https://review.openstack.org/604906 | 23:00 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Revert "Make host_aggregate_map dictionary case-insensitive" https://review.openstack.org/604898 | 23:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Enforce case-sensitive hostnames in aggregate host add https://review.openstack.org/604906 | 23:05 |
| *** rcernin has joined #openstack-nova | 23:07 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Revert "Make host_aggregate_map dictionary case-insensitive" https://review.openstack.org/605260 | 23:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Enforce case-sensitive hostnames in aggregate host add https://review.openstack.org/605261 | 23:09 |
| *** macza has quit IRC | 23:17 | |
| *** macza has joined #openstack-nova | 23:17 | |
| *** dave-mccowan has joined #openstack-nova | 23:18 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Revert "Make host_aggregate_map dictionary case-insensitive" https://review.openstack.org/605266 | 23:21 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Enforce case-sensitive hostnames in aggregate host add https://review.openstack.org/605267 | 23:21 |
| *** jaypipes has quit IRC | 23:21 | |
| *** macza has quit IRC | 23:22 | |
| *** hoangcx has quit IRC | 23:22 | |
| *** hoangcx has joined #openstack-nova | 23:23 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Revert "Make host_aggregate_map dictionary case-insensitive" https://review.openstack.org/605268 | 23:25 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Enforce case-sensitive hostnames in aggregate host add https://review.openstack.org/605269 | 23:25 |
| *** erlon has joined #openstack-nova | 23:27 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Skip ServerShowV254Test.test_rebuild_server in cells v1 job https://review.openstack.org/605270 | 23:27 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Skip ServerShowV247Test.test_update_rebuild_list_server in nova-cells-v1 job https://review.openstack.org/605271 | 23:27 |
| *** mlavalle has quit IRC | 23:34 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!