| openstackgerrit | xhzhf proposed openstack/nova master: [vmware] add missing os types in vSphere sdk 6.5 https://review.openstack.org/591771 | 00:20 |
|---|---|---|
| *** dklyle has quit IRC | 00:20 | |
| *** slagle has joined #openstack-nova | 00:24 | |
| *** takashin has joined #openstack-nova | 00:28 | |
| mriedem | melwitt: ack, just got online | 00:29 |
| *** Nel1x has joined #openstack-nova | 00:31 | |
| *** slaweq_ has joined #openstack-nova | 00:32 | |
| mriedem | dansmith: lyarwood: fwiw, i backported the live migration revert from master to stable/rocky b/c i was sure that would be clean since we just cut stable/rocky, but assumed we'd have to revert per-branch for queens and pike | 00:35 |
| *** yedongcan has joined #openstack-nova | 00:35 | |
| *** slaweq_ has quit IRC | 00:36 | |
| mriedem | efried: re: https://github.com/openstack/nova/blob/61f854ff6445dd7bc797fdde7361e47f3dc3b1bd/nova/tests/functional/compute/test_resource_tracker.py#L215 have we removed the compat code in the RT for that yet? or are you saying we can now because master is stein? i would hold off on merging any big code removals this early until we've cut rc2 | 00:39 |
| *** gyee has quit IRC | 00:39 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: placement: ignore policy scope check failures if not enforcing scope https://review.openstack.org/591872 | 00:43 |
| *** hongbin has joined #openstack-nova | 00:44 | |
| mriedem | melwitt: on backporting https://review.openstack.org/#/c/591129/ to rc2, idk, would ask the release team (smcginnis or dhellmann) | 00:44 |
| mriedem | or maybe ajaegar | 00:45 |
| *** brinzhang has joined #openstack-nova | 00:47 | |
| *** slagle has quit IRC | 00:48 | |
| *** slaweq_ has joined #openstack-nova | 00:53 | |
| *** slaweq_ has quit IRC | 00:57 | |
| mriedem | melwitt: we don't need to backport the translations | 00:59 |
| *** sapd1 has joined #openstack-nova | 01:15 | |
| *** mhen has quit IRC | 01:18 | |
| *** mhen has joined #openstack-nova | 01:21 | |
| *** mrsoul has joined #openstack-nova | 01:28 | |
| *** slaweq_ has joined #openstack-nova | 01:32 | |
| *** slaweq_ has quit IRC | 01:37 | |
| *** gbarros has joined #openstack-nova | 01:51 | |
| *** hemna_ has quit IRC | 01:59 | |
| openstackgerrit | Merged openstack/nova master: Make Xen code py3-compatible https://review.openstack.org/591061 | 02:01 |
| openstackgerrit | Merged openstack/nova master: Update really old comments about vmware hosts managing multiple nodes https://review.openstack.org/589666 | 02:01 |
| openstackgerrit | Merged openstack/nova master: Ironic: report 0 for vcpus/memory_mb/disk_gb resources https://review.openstack.org/565841 | 02:01 |
| *** tetsuro has joined #openstack-nova | 02:01 | |
| mriedem | efried: ok i guess https://review.openstack.org/#/c/565841/ is merged... note there are other things to cleanup related to this from the ptg etherpad, ~L25 https://etherpad.openstack.org/p/nova-ptg-stein | 02:04 |
| *** yedongcan has quit IRC | 02:07 | |
| *** yedongcan has joined #openstack-nova | 02:07 | |
| *** hemna_ has joined #openstack-nova | 02:09 | |
| *** lei-zh has joined #openstack-nova | 02:09 | |
| *** slaweq_ has joined #openstack-nova | 02:11 | |
| *** slaweq_ has quit IRC | 02:15 | |
| *** dave-mccowan has quit IRC | 02:19 | |
| *** openstack has joined #openstack-nova | 02:34 | |
| *** ChanServ sets mode: +o openstack | 02:34 | |
| alex_xu | Kevin_Zheng: few comments on https://review.openstack.org/#/c/486850 | 02:46 |
| alex_xu | Kevin_Zheng: I think using PATH_INFO is right. just need refine the code a little bit. And I found we will strip any work start with 'v', if we have a url called '/volume', then it will be stripped. although we don't have it, but it is trap for any url start with 'v' | 02:48 |
| alex_xu | in the future | 02:48 |
| *** lei-zh has quit IRC | 02:50 | |
| *** slaweq_ has joined #openstack-nova | 02:53 | |
| *** lei-zh has joined #openstack-nova | 02:55 | |
| *** slaweq_ has quit IRC | 02:57 | |
| *** takashin has left #openstack-nova | 03:00 | |
| *** mardim has quit IRC | 03:07 | |
| *** skatsaounis_ has quit IRC | 03:08 | |
| *** Nel1x has quit IRC | 03:11 | |
| melwitt | mriedem: thanks. I guess I don't know what all the hubbub about "rc2 translations" used to be about then | 03:14 |
| Kevin_Zheng | alex_xu, thanks alot, I will look into that | 03:14 |
| *** hemna_ has quit IRC | 03:15 | |
| *** gbarros has quit IRC | 03:18 | |
| sapd1 | melwitt: Can I workaround to attach SR-IOV to exist instance? :D | 03:22 |
| *** hongbin has quit IRC | 03:23 | |
| melwitt | sapd1: not that I know of. I haven't gotten around to asking artom about the bug https://bugs.launchpad.net/nova/+bug/1708433 | 03:26 |
| openstack | Launchpad bug 1708433 in OpenStack Compute (nova) "Attaching sriov nic VM fail with keyError pci_slot" [Undecided,New] | 03:26 |
| *** hongbin has joined #openstack-nova | 03:28 | |
| *** tetsuro has quit IRC | 03:31 | |
| alex_xu | mriedem: enjoy...Xi'an food :) | 03:31 |
| mriedem | alex_xu: biang biang noodle! | 03:32 |
| mriedem | chinese hamburger | 03:32 |
| *** slaweq_ has joined #openstack-nova | 03:32 | |
| alex_xu | mriedem: hahaha | 03:32 |
| mriedem | sapd1: you can't attach sriov ports to existing instances | 03:33 |
| mriedem | beyond just the KeyError | 03:33 |
| mriedem | we should likely just 400 those types of requestse | 03:34 |
| melwitt | yeah, sean-k-mooney was saying he thought it used to 400 but that artom might know about patch(es) that might have inadvertently changed it? | 03:34 |
| sapd1 | mriedem: so we don't have any way to attach sriov ports, do you? | 03:34 |
| mriedem | sapd1: it's not currently supported no | 03:36 |
| mriedem | see https://review.openstack.org/#/c/139910/ | 03:36 |
| *** slaweq_ has quit IRC | 03:37 | |
| mriedem | it would definitely be a microversion to start saying we support that type of attach | 03:38 |
| mriedem | so i think we essentially need to check the vnic_type on the port and if it's not 'normal' we need to fail | 03:39 |
| mriedem | sean-k-mooney: nova never pre-creates sriov ports right because you have to specify that in the binding:vnic_type when creating the port | 03:41 |
| mriedem | therefore if a user tries to attach a port to a server by passing a network id rather than a port id and nova creates the port on the network, it will always be vnic_type 'normal' today | 03:42 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Force refresh instance info_cache during heal https://review.openstack.org/591607 | 03:48 |
| *** hongbin_ has joined #openstack-nova | 03:48 | |
| *** hongbin has quit IRC | 03:50 | |
| *** slaweq_ has joined #openstack-nova | 03:53 | |
| *** slaweq_ has quit IRC | 03:57 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:58 | |
| *** lei-zh has quit IRC | 04:01 | |
| openstackgerrit | Chen proposed openstack/nova master: Revisons on notifications doc https://review.openstack.org/591621 | 04:11 |
| sapd1 | mriedem: I saw in neutron-sriov-agent log, When launch instance It update profile of sr-iov port, But when attach port to exist instance It does not. | 04:12 |
| *** hongbin_ has quit IRC | 04:14 | |
| *** eharney has quit IRC | 04:15 | |
| *** liuyulong has joined #openstack-nova | 04:23 | |
| *** eharney has joined #openstack-nova | 04:27 | |
| *** slaweq_ has joined #openstack-nova | 04:32 | |
| *** oanson has quit IRC | 04:33 | |
| *** slaweq_ has quit IRC | 04:36 | |
| gmann | alex_xu: do you have anything for today API office hour ? i am little busy on QA releases so if nothing much i would like to skip it. | 04:58 |
| *** oanson has joined #openstack-nova | 05:00 | |
| mriedem | sapd1: because attaching sriov interfaces to existing instances is not supported in nova | 05:04 |
| mriedem | the api might say the interface is attached, but nova-compute doesn't actually allocate any pci device | 05:04 |
| *** slaweq_ has joined #openstack-nova | 05:11 | |
| *** hemna_ has joined #openstack-nova | 05:12 | |
| *** pcaruana has joined #openstack-nova | 05:12 | |
| *** slaweq_ has quit IRC | 05:16 | |
| *** hemna_ has quit IRC | 05:17 | |
| *** Bhujay has joined #openstack-nova | 05:18 | |
| *** lei-zh has joined #openstack-nova | 05:27 | |
| alex_xu | gmann: we can skip it today | 05:31 |
| *** slaweq_ has joined #openstack-nova | 05:32 | |
| *** slaweq_ has quit IRC | 05:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Explicitly fail if trying to attach SR-IOV port https://review.openstack.org/591898 | 05:40 |
| gmann | ok | 05:48 |
| *** mriedem has quit IRC | 06:03 | |
| *** slaweq_ has joined #openstack-nova | 06:11 | |
| *** slaweq_ has quit IRC | 06:16 | |
| *** mriedem has joined #openstack-nova | 06:19 | |
| *** jaosorior has joined #openstack-nova | 06:25 | |
| *** jaosorior has quit IRC | 06:40 | |
| *** adrianc has joined #openstack-nova | 06:41 | |
| *** slaweq_ has joined #openstack-nova | 06:53 | |
| mriedem | so quiet in here | 06:54 |
| mriedem | is everyone on wechat? | 06:54 |
| *** slaweq_ has quit IRC | 06:57 | |
| *** alexchadin has joined #openstack-nova | 06:59 | |
| *** mriedem has quit IRC | 07:05 | |
| sapd1 | mriedem: I'm still here | 07:09 |
| openstackgerrit | Merged openstack/nova master: Remove blacklisted py3 xen tests https://review.openstack.org/591419 | 07:10 |
| brinzhang | mriedem: If we use wechat, we can speak Chinese? :) | 07:10 |
| *** s10 has joined #openstack-nova | 07:11 | |
| brinzhang | anyone know a project of masakari? It has too few document. | 07:14 |
| *** jaosorior has joined #openstack-nova | 07:15 | |
| *** s10 has quit IRC | 07:22 | |
| *** alex_xu has quit IRC | 07:50 | |
| *** davidsha has joined #openstack-nova | 07:53 | |
| *** yedongcan has quit IRC | 08:06 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: move_allocations https://review.openstack.org/591810 | 08:07 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: more tests for delete allocation cases https://review.openstack.org/591811 | 08:07 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: support claim_resources https://review.openstack.org/583667 | 08:07 |
| *** sgordon has quit IRC | 08:08 | |
| *** Dinesh_Bhor has quit IRC | 08:14 | |
| *** cdent has joined #openstack-nova | 08:14 | |
| *** dtantsur|afk is now known as dtantsur | 08:26 | |
| *** derekh has joined #openstack-nova | 08:31 | |
| *** rha has quit IRC | 08:34 | |
| *** tssurya has joined #openstack-nova | 08:35 | |
| *** lennyb has joined #openstack-nova | 08:35 | |
| *** alex_xu has joined #openstack-nova | 08:48 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:48 | |
| sean-k-mooney | mriedem i noticed the same thing for the last week or so | 08:59 |
| *** alexchadin has quit IRC | 09:00 | |
| sean-k-mooney | basically since we started requireing registered nics that chat has been much more quite, and there have been less nics i have not seen before | 09:00 |
| *** josecastroleon has quit IRC | 09:00 | |
| *** josecastroleon has joined #openstack-nova | 09:00 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter https://review.openstack.org/591976 | 09:04 |
| *** samueldmq_ has joined #openstack-nova | 09:16 | |
| *** andreaf has quit IRC | 09:16 | |
| *** andreaf has joined #openstack-nova | 09:17 | |
| *** alexchadin has joined #openstack-nova | 09:17 | |
| *** bzhao__ has quit IRC | 09:18 | |
| *** samueldmq has quit IRC | 09:18 | |
| *** xgerman_ has quit IRC | 09:18 | |
| *** samueldmq_ is now known as samueldmq | 09:18 | |
| *** mriedem has joined #openstack-nova | 09:18 | |
| *** liuyulong has quit IRC | 09:19 | |
| *** johnthetubaguy has quit IRC | 09:21 | |
| *** johnthetubaguy has joined #openstack-nova | 09:24 | |
| *** rtjure has joined #openstack-nova | 09:35 | |
| *** Dinesh_Bhor has quit IRC | 09:42 | |
| *** mriedem has quit IRC | 09:44 | |
| *** Dinesh_Bhor has joined #openstack-nova | 09:57 | |
| *** lei-zh has quit IRC | 10:01 | |
| *** josecastroleon has quit IRC | 10:09 | |
| *** dave-mccowan has joined #openstack-nova | 10:12 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter https://review.openstack.org/591976 | 10:14 |
| *** adrianc has quit IRC | 10:30 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter https://review.openstack.org/591976 | 10:39 |
| *** s10 has joined #openstack-nova | 10:41 | |
| *** priteau has joined #openstack-nova | 10:45 | |
| *** Dinesh_Bhor has quit IRC | 10:49 | |
| *** adrianc has joined #openstack-nova | 10:50 | |
| *** alexchadin has quit IRC | 10:59 | |
| *** sapd1 has quit IRC | 10:59 | |
| *** alexchadin has joined #openstack-nova | 11:00 | |
| *** alexchadin has quit IRC | 11:00 | |
| *** alexchadin has joined #openstack-nova | 11:01 | |
| *** alexchadin has quit IRC | 11:01 | |
| *** alexchadin has joined #openstack-nova | 11:01 | |
| *** alexchadin has quit IRC | 11:02 | |
| *** pvc has joined #openstack-nova | 11:03 | |
| pvc | hi guys | 11:03 |
| pvc | Volume size extension is not supported by the hypervisor.: ExtendVolumeNotSupported: Volume size extension is not supported by the hypervisor. | 11:03 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove the deprecated API extensions policies https://review.openstack.org/586872 | 11:15 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove the deprecated API extensions policies https://review.openstack.org/586872 | 11:16 |
| pvc | hi guys | 11:22 |
| pvc | anyone | 11:22 |
| pvc | here | 11:22 |
| *** panda|ruck is now known as panda|ruck|lunch | 11:25 | |
| *** alexchadin has joined #openstack-nova | 11:33 | |
| *** alexchadin has quit IRC | 11:38 | |
| *** brinzhang has quit IRC | 11:39 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge extended availability zone response into server controller https://review.openstack.org/502859 | 11:49 |
| *** panda|ruck|lunch is now known as panda|ruck | 11:53 | |
| *** alexchadin has joined #openstack-nova | 11:56 | |
| *** eharney has quit IRC | 11:58 | |
| *** josecastroleon has joined #openstack-nova | 12:00 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge config drive extension response into server controller https://review.openstack.org/584223 | 12:03 |
| *** slaweq_ has joined #openstack-nova | 12:15 | |
| sean-k-mooney | sorry for the delay, alot of people are on vacation in europe and most of the us folks are not online yet | 12:18 |
| sean-k-mooney | pvc: ^ | 12:18 |
| sean-k-mooney | pvc: alot of eu people that are working today are also gone to lunch | 12:19 |
| *** gcb_ has joined #openstack-nova | 12:19 | |
| sean-k-mooney | pvc: you were getting an error with exetending voluems "ExtendVolumeNotSupported" | 12:19 |
| *** slaweq_ has quit IRC | 12:20 | |
| sean-k-mooney | pvc: im not sure i can help but if you have a specifc question/issue i might at least be able to point you in the right direction | 12:21 |
| *** alexchadin has quit IRC | 12:23 | |
| *** alexchadin has joined #openstack-nova | 12:30 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge extended server attributes extension response https://review.openstack.org/584590 | 12:31 |
| *** erlon has joined #openstack-nova | 12:34 | |
| edmondsw | pvc which virt driver are you using? | 12:47 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge keypair extension response into server view builder https://review.openstack.org/584748 | 12:47 |
| gibi | btw I will take Thursday and Friday afternoon off and then Monday is public holiday here and I will take Tuesday out as well | 12:47 |
| *** josecastroleon has quit IRC | 12:54 | |
| *** josecastroleon has joined #openstack-nova | 12:54 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge server usage extension response into server view builder https://review.openstack.org/585262 | 13:00 |
| *** eharney has joined #openstack-nova | 13:09 | |
| *** mvkr has quit IRC | 13:10 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: [placement] split gigantor SQL query, add logging https://review.openstack.org/590041 | 13:14 |
| efried | mriedem: I was approaching it from "I just happened to notice this while I was doing something else," not, "Hey, we need to clean up a big thing and this is one of the pieces." I'm sure it makes sense to go looking for the chunk of code that guy tests... | 13:20 |
| efried | jaypipes: Did you run that locally? I'm wondering if you need to do list(traits.keys()) else you'd wind up with output like <Generator at 0x0a7e0a> etc. | 13:22 |
| efried | whoops, wrong channel. | 13:23 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: [placement] split gigantor SQL query, add logging https://review.openstack.org/590041 | 13:25 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: [placement] split gigantor SQL query, add logging https://review.openstack.org/590041 | 13:29 |
| *** dklyle has joined #openstack-nova | 13:31 | |
| openstackgerrit | Merged openstack/nova master: api-ref: fix GET /flavors?is_public description https://review.openstack.org/588092 | 13:33 |
| efried | mriedem: Why are we waiting until rocky rc2 to merge things into stein? | 13:36 |
| efried | dansmith: maybe you know this answer? | 13:36 |
| dansmith | efried: um we're not? | 13:36 |
| dansmith | stable/rocky exists which means master is stein | 13:37 |
| efried | okay. Matt said something weird earlier. | 13:37 |
| dansmith | which was what? | 13:37 |
| efried | http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-08-15.log.html#t2018-08-15T00:39:03 | 13:37 |
| dansmith | well, first off, | 13:37 |
| dansmith | he said master was stein, | 13:38 |
| dansmith | but his point was that if you do big removals or refactors, | 13:38 |
| dansmith | and we then suddenly need to backport a fix, | 13:38 |
| dansmith | it may be much uglier | 13:38 |
| dansmith | when the big code removal shouldn't be any huge rush | 13:38 |
| efried | okay, I figured if it was anything it was that. | 13:38 |
| dansmith | I imagine that was his point | 13:38 |
| efried | fair enuf | 13:38 |
| efried | though I think that one probably could have been removed in rocky anyway. | 13:38 |
| efried | since it was testing an ocata->pike thing. | 13:39 |
| *** mriedem has joined #openstack-nova | 13:39 | |
| mriedem | slurm | 13:39 |
| *** mvkr has joined #openstack-nova | 13:40 | |
| openstackgerrit | Gaudenz Steinlin proposed openstack/nova master: Ignore some updates from virt driver https://review.openstack.org/523006 | 13:43 |
| *** gbarros has joined #openstack-nova | 13:43 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge security groups extension response into server view builder https://review.openstack.org/585475 | 13:45 |
| *** david-lyle has joined #openstack-nova | 13:48 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Regex consts for placement schema https://review.openstack.org/591863 | 13:48 |
| *** dklyle has quit IRC | 13:49 | |
| *** david-lyle has quit IRC | 13:49 | |
| *** david-lyle has joined #openstack-nova | 13:49 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add regression test for bug 1550919 https://review.openstack.org/591733 | 13:52 |
| openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | 13:52 |
| *** alex_xu has quit IRC | 13:52 | |
| *** hvvcben has joined #openstack-nova | 13:53 | |
| lyarwood | dansmith: https://review.openstack.org/#/c/591761/ is good to go right? | 13:53 |
| lyarwood | dansmith: you didn't want to wait until your other backport was ready or anything? | 13:53 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Py3 fix in fake image service https://review.openstack.org/592056 | 13:54 |
| dansmith | lyarwood: no, I don't think we should wait and yes I think it's good to go | 13:54 |
| lyarwood | dansmith: ack thanks | 13:54 |
| mriedem | dansmith: just replied in the other | 13:58 |
| mriedem | will check it over in the morning | 13:58 |
| dansmith | mriedem: coolt hanks | 13:59 |
| gmann | mriedem: melwitt can either of you approve this BP. i have rebased the patches and added stein BP link - https://blueprints.launchpad.net/nova/+spec/api-extensions-merge-stein | 13:59 |
| openstackgerrit | xhzhf proposed openstack/nova master: VMware: add missing os types in vSphere sdk 6.5 https://review.openstack.org/591771 | 13:59 |
| *** hvvcben has quit IRC | 14:00 | |
| gmann | tssurya: done, 3 more view builder left which i am working and push soon - https://review.openstack.org/#/q/topic:bp/api-extensions-merge-stein+(status:open+OR+status:merged) | 14:00 |
| mriedem | gmann: done | 14:00 |
| gmann | mriedem: thanks | 14:01 |
| *** awaugama has joined #openstack-nova | 14:02 | |
| *** davidsha has quit IRC | 14:02 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove the deprecated API extensions policies https://review.openstack.org/586872 | 14:07 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge extended availability zone response into server controller https://review.openstack.org/502859 | 14:08 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge config drive extension response into server controller https://review.openstack.org/584223 | 14:09 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge extended server attributes extension response https://review.openstack.org/584590 | 14:09 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge keypair extension response into server view builder https://review.openstack.org/584748 | 14:09 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge server usage extension response into server view builder https://review.openstack.org/585262 | 14:10 |
| *** tbachman has joined #openstack-nova | 14:17 | |
| mriedem | dansmith: anything i should fast approve before going to bed? | 14:18 |
| dansmith | mriedem: sounds like a recipe for disaster | 14:18 |
| dansmith | but nothing that I know of this morning.. you got the revert backports I think | 14:18 |
| mriedem | yup | 14:18 |
| dansmith | I'll have this real backport up in a little while, but if you can look tomorrow I think that's fine | 14:18 |
| mriedem | yeah i will | 14:19 |
| dansmith | 祝你晚安 | 14:19 |
| mriedem | o/ then | 14:19 |
| mriedem | ha | 14:20 |
| mriedem | tai gui | 14:20 |
| dansmith | g'nite | 14:20 |
| *** mriedem has quit IRC | 14:20 | |
| *** erlon has quit IRC | 14:21 | |
| dansmith | too expensive? | 14:21 |
| dansmith | hmm | 14:21 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge security groups extension response into server view builder https://review.openstack.org/585475 | 14:21 |
| *** erlon has joined #openstack-nova | 14:24 | |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Wait for network-vif-plugged before starting live migration https://review.openstack.org/591735 | 14:27 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: DNM: Debug patch to test live migration waiting https://review.openstack.org/591775 | 14:27 |
| *** gbarros has quit IRC | 14:28 | |
| mdbooth | Eurgh | 14:28 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add regression test for bug 1550919 https://review.openstack.org/591733 | 14:30 |
| openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | 14:30 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Py3 fix in fake image service https://review.openstack.org/592056 | 14:30 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846 | 14:30 |
| mdbooth | melwitt: ^^^ No refactor, change is confined to libvirt driver, no need to look at task state :) | 14:31 |
| *** alexchadin has quit IRC | 14:32 | |
| mdbooth | Grr, I forgot to re-run pep8 after fixing tests :/ | 14:32 |
| *** Bhujay has quit IRC | 14:33 | |
| *** _ix has joined #openstack-nova | 14:33 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846 | 14:34 |
| efried | jaypipes: Would you please cast your eye upon https://review.openstack.org/#/c/468560/ when you get a chance? update_provider_tree for PowerVM driver. | 14:39 |
| openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 14:47 |
| openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | 14:47 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598 | 14:47 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | 14:47 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | 14:47 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | 14:47 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | 14:47 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 14:47 |
| openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Regex consts for placement schema https://review.openstack.org/591863 | 14:47 |
| *** sapd1 has joined #openstack-nova | 14:48 | |
| sapd1 | melwitt: I would like to develop this feature (https://review.openstack.org/#/c/139910/) How can I start? Because I would like to use SR-IOV with Octavia. | 14:54 |
| sean-k-mooney | sapd1: specifcally you wish to enale sriov atach/detach | 14:55 |
| sapd1 | In Octavia flow, Port in VIP Network was created after instance launched, If I use SR-IOV Network for VIP Network, I can't attach VIP Port. | 14:56 |
| sapd1 | sean-k-mooney: Yep. I wish | 14:56 |
| sean-k-mooney | sapd1: by sriov network you mean sriov port | 14:56 |
| sean-k-mooney | our rather vnic_type=dircet,macvtap or drict-phyical | 14:57 |
| sean-k-mooney | sapd1: the first thing you would need to do is repropose the spec for stien | 14:57 |
| sapd1 | sean-k-mooney: yes. Because in this flow (https://github.com/openstack/octavia/blob/master/octavia/network/drivers/neutron/allowed_address_pairs.py#L87) | 14:58 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add regression test for bug 1550919 https://review.openstack.org/591733 | 14:58 |
| openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | 14:58 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Py3 fix in fake image service https://review.openstack.org/592056 | 14:58 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846 | 14:58 |
| sapd1 | octavia-lb-vrrp port is created and attached to amphora instance after instance is created. | 14:59 |
| sean-k-mooney | sapd1: right. so im personally ok with adding attach/detach for sriov interfaces but are you aware that the process is more complicated now then it was in newton | 15:00 |
| sean-k-mooney | one of the hopes for stien is that we would start tracking VFs in placement, so you would have to update the instance allocation in placement | 15:01 |
| *** david-lyle is now known as dklyle | 15:01 | |
| *** betherly-afk is now known as betherly_ | 15:02 | |
| sean-k-mooney | addtionaly assuming the vm is on a host that has an available VF attached to the correct physnet | 15:02 |
| sapd1 | sean-k-mooney: yep. It's more complicated with me | 15:02 |
| sean-k-mooney | the vm may or may not have enough pci slots available for the VF to be attached. this also changes depending on if the vm is using the qemu Q35 chipset in the libvirt driver case | 15:03 |
| efried | sapd1: keep an eye on https://review.openstack.org/#/c/591898/ -- I'm hoping this evolves to make SRIOV hot (un)plug based on a driver capability, but either way you'll need to work with it to do your support. | 15:04 |
| *** tikitavi__ has joined #openstack-nova | 15:04 | |
| sean-k-mooney | efried: we used to hard fail in old releases for sriov attach | 15:05 |
| sean-k-mooney | efried: do you know if the current attach api call is blocking | 15:05 |
| efried | sean-k-mooney: According to that patch, which *adds* a hard fail... | 15:06 |
| sean-k-mooney | efried: we used to have an api check at some point before this | 15:07 |
| sapd1 | sean-k-mooney: yep. I think we have to check number of pci slots available when attach. | 15:07 |
| sean-k-mooney | sapd1: yes my concern with that is is attach blocking or async | 15:08 |
| sean-k-mooney | sapd1: if its a blocking call that means the api must wait for the hyperviror to try to attach the interface to the guest before returning assuming a device is available to attach | 15:09 |
| tssurya | gmann: thanks a ton! | 15:09 |
| *** masayukig has joined #openstack-nova | 15:10 | |
| sean-k-mooney | sapd1: well that is it would have to wait if we wanted to comunicate a good error message as to why the attach failed | 15:10 |
| sapd1 | sean-k-mooney: So we have to save number of pci slots available in database like CPU and ram. as you said, in placement database | 15:11 |
| sapd1 | then when attach port, we have to check in database. | 15:11 |
| sean-k-mooney | sapd1: that is virtdriver specific. we cannot track that in placement | 15:11 |
| sean-k-mooney | sapd1: we may be able to recored that in the nova db but im not sure it would apply to all drivers | 15:12 |
| sapd1 | sean-k-mooney: But I don't know how to push profile of sriov port from nova-api to nova-compute | 15:13 |
| jaypipes | efried: done | 15:13 |
| sean-k-mooney | sapd1: profile? | 15:13 |
| sean-k-mooney | sapd1: as in vif:binding_profile? | 15:13 |
| sapd1 | sean-k-mooney: http://paste.openstack.org/show/726723/ | 15:14 |
| sapd1 | I saw the profile of the port is not updated | 15:14 |
| *** cdent_ has joined #openstack-nova | 15:15 | |
| sean-k-mooney | ya that is because we dont generate it in the api on attach. | 15:15 |
| *** cdent has quit IRC | 15:15 | |
| *** cdent_ is now known as cdent | 15:15 | |
| sean-k-mooney | sapd1: you wil not be able to set that value form neutron or nova apis | 15:16 |
| sapd1 | sean-k-mooney: how can I generate it? | 15:16 |
| sean-k-mooney | sapd1: normally that is set by the virt_driver on the compute node during instace spawn when it does a port bind | 15:17 |
| sean-k-mooney | sapd1: the virt driver is the only thing that can generate it | 15:17 |
| sapd1 | sean-k-mooney: I think so, But in this (https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py#L70) | 15:18 |
| sapd1 | nova notify port update to neutron, but port has not profile (pci_slot) so It can't update port | 15:19 |
| sean-k-mooney | you cannot set this in neutron. neuton does not know what hypervior th vm is booting on | 15:19 |
| sean-k-mooney | sapd1: correct. | 15:19 |
| sapd1 | so I'm confusing because where can I write a patch to fix this. :D | 15:21 |
| sean-k-mooney | sapd1: you would need several patches :) but the pci_slot is extracted from the pci_request_spec here https://github.com/openstack/nova/blob/c9b7c3577f373477d003706bb5ca748a51bbf023/nova/network/neutronv2/api.py#L1367-L1377 | 15:23 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Wait for network-vif-plugged before starting live migration https://review.openstack.org/591735 | 15:25 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: DNM: Debug patch to test live migration waiting https://review.openstack.org/591775 | 15:25 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Fix cancel_all_events event name parsing https://review.openstack.org/592086 | 15:26 |
| sean-k-mooney | sapd1: that gets indrectly called from _populate_neutron_extension_values whcih is called form _update_ports_for_instance which is called from allocate_for_instance on vm boot | 15:27 |
| sapd1 | sean-k-mooney: too complicated | 15:28 |
| sean-k-mooney | sapd1: i looked at doing this a few year ago. its non trival. the point is _populate_neutron_extension_values when we are doing an attach | 15:30 |
| *** derekh has quit IRC | 15:30 | |
| sean-k-mooney | we also dont genartate a pci_request_spec object and ask the resouce tracker for a VF | 15:31 |
| sapd1 | sean-k-mooney: Can you help me with path which can generate port profile I don't need update allocated database because I would like to use with octavia only. | 15:32 |
| *** gyee has joined #openstack-nova | 15:32 | |
| sean-k-mooney | sapd1: the first step is to reporpose the spec for stien. | 15:33 |
| sean-k-mooney | to add this fuctionality so that octavia can use it it will need to be done properly end to end | 15:34 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge extended_status extension response into server view builder https://review.openstack.org/592092 | 15:35 |
| sapd1 | sean-k-mooney: wait me | 15:35 |
| *** gbarros has joined #openstack-nova | 15:37 | |
| openstackgerrit | Merged openstack/python-novaclient master: Replace os-client-config to openstacksdk https://review.openstack.org/590141 | 15:38 |
| *** mvkr has quit IRC | 15:46 | |
| *** adrianc has quit IRC | 15:48 | |
| *** adrianc has joined #openstack-nova | 15:48 | |
| openstackgerrit | Chen proposed openstack/nova master: Revisons on notifications doc https://review.openstack.org/591621 | 15:50 |
| *** pvc_ has joined #openstack-nova | 15:52 | |
| pvc_ | hi | 15:52 |
| *** itlinux has joined #openstack-nova | 15:52 | |
| pvc_ | im currently using ceph backend for my voluems | 15:52 |
| pvc_ | but when i extending it on a attached state it have an error | 15:52 |
| pvc_ | Hypervisor is not supported the volume extension | 15:53 |
| *** FracKen has joined #openstack-nova | 15:55 | |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Wait for network-vif-plugged before starting live migration https://review.openstack.org/591735 | 16:04 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: DNM: Debug patch to test live migration waiting https://review.openstack.org/591775 | 16:04 |
| tikitavi__ | Hi, can anybody help me with starting an instance with fake driver ? | 16:08 |
| tikitavi__ | I have devstack with VIRT_DRIVER=fake in localrc, when I’m trying to start instance it fails with error “{"message": "Binding failed for port c38ac68b-3417-4443-b10d-a0d65647e9bd, please check neutron logs for more information.", "code": 400, "created": "2018-08-13T12:55:26Z”}” | 16:08 |
| tikitavi__ | The error in neutron sac logs is neutron-server[23609]: ERROR neutron.plugins.ml2.managers [None req-a779fdba-0b67-4ac1-983e-551bd58cc566 service neutron] Failed to bind port c38ac68b-3417-4443-b10d-a0d65647e9bd on host ubuntu-xenial-ovh-bhs1-00012954471 for vnic_type normal using segments [{'network_id': '755c91d8-76ef-4ff4-8997-717897309695', 'segmentation_id': 86, 'physical_network': None, 'id': 'e1fb3dff-bf9c-41df-89 | 16:09 |
| *** tikitavi_ has joined #openstack-nova | 16:11 | |
| *** cdent has quit IRC | 16:14 | |
| *** tikitavi__ has quit IRC | 16:15 | |
| *** sayalilunkad has quit IRC | 16:16 | |
| *** tikitavi_ has quit IRC | 16:18 | |
| *** sayalilunkad has joined #openstack-nova | 16:20 | |
| *** panda|ruck is now known as panda|off | 16:22 | |
| sapd1 | pvc_: you have to detach volume from instance then extend volume | 16:22 |
| *** Tikitavi has joined #openstack-nova | 16:24 | |
| pvc_ | my goal is to extend it even if it is in attached state | 16:25 |
| *** Tikitavi has quit IRC | 16:28 | |
| *** efried is now known as efried_rollin | 16:28 | |
| prometheanfire | looks like only pike remains :D https://review.openstack.org/#/c/591762 | 16:29 |
| *** sayalilunkad has quit IRC | 16:32 | |
| *** Bhujay has joined #openstack-nova | 16:33 | |
| sapd1 | pvc_: * only iscsi and fibre channel volume types are supported on the nova side currently. | 16:35 |
| sapd1 | https://review.openstack.org/#/c/454287/23/releasenotes/notes/support-extend-inuse-volume-9e4atf8912qaye99.yaml | 16:35 |
| pvc_ | is there a blueprint for rbd? | 16:36 |
| mdbooth | melwitt: Looks like there's a bug in the functional test for https://review.openstack.org/#/c/578846/ as it's failing non-deterministically. I'll try to get to the bottom of that tomorrow. However, if you could take a view on the patch itself, if only at a high level, I'd be very grateful. | 16:40 |
| melwitt | mdbooth: sure, will take a look | 16:40 |
| openstackgerrit | Doug Hellmann proposed openstack/nova master: use static pages for mitaka and newton release notes https://review.openstack.org/592150 | 16:41 |
| mdbooth | melwitt: Thanks | 16:41 |
| melwitt | sapd1: if you are interested in developing the attach/detach feature, you must first propose it as a spec for the stein release, where it can be reviewed. here is the docs on how to submit a spec: https://specs.openstack.org/openstack/nova-specs/readme.html | 16:44 |
| *** pvc_ has quit IRC | 16:45 | |
| *** sayalilunkad has joined #openstack-nova | 16:47 | |
| dansmith | melwitt: tssurya: I'm assuming no cells meeting, matt is in china and I have nothing | 16:50 |
| dansmith | presumably we just need to get back on the down-cell reviews... | 16:50 |
| tssurya | dansmith: me neither, yea working on tests for the API stuff ^ | 16:50 |
| melwitt | I don't have anything either. my server group patch has been receiving review | 16:51 |
| dansmith | schweeeeet | 16:51 |
| *** sayalilunkad has quit IRC | 16:51 | |
| melwitt | we still have those other bugs around build request/instance mapping getting out-of-sync so we should get thinking about and reviewing those too | 16:51 |
| *** sayalilunkad has joined #openstack-nova | 16:52 | |
| *** openstackstatus has joined #openstack-nova | 16:57 | |
| *** ChanServ sets mode: +v openstackstatus | 16:57 | |
| *** priteau has quit IRC | 17:06 | |
| *** sayalilunkad has quit IRC | 17:09 | |
| *** s10 has quit IRC | 17:11 | |
| sapd1 | melwitt: I'm trying to repropose . | 17:17 |
| melwitt | sapd1: oh, hm, it looks like we don't yet have the stein directory available in nova-specs | 17:18 |
| melwitt | dansmith: could you hit this to add the stein directory to nova-specs? https://review.openstack.org/573602 | 17:20 |
| dansmith | cha | 17:20 |
| melwitt | thx | 17:20 |
| *** eharney has quit IRC | 17:26 | |
| openstackgerrit | Merged openstack/nova-specs master: Create specs directory for Stein https://review.openstack.org/573602 | 17:27 |
| *** tssurya has quit IRC | 17:28 | |
| melwitt | sapd1: okay, you'll just need to rebase to get the stein directory ^ and then you'll be able to copy the spec file there for proposal | 17:30 |
| melwitt | *copy the spec into the stein directory | 17:30 |
| sapd1 | Thanks melwitt | 17:30 |
| openstackgerrit | Merged openstack/nova stable/queens: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/591761 | 17:32 |
| prometheanfire | :D | 17:36 |
| *** gbarros has quit IRC | 17:38 | |
| *** sapd1 has quit IRC | 17:39 | |
| openstackgerrit | Dmitry Sutyagin proposed openstack/nova master: libvirt: add disabling KSM via flavor extra specs https://review.openstack.org/591854 | 17:40 |
| *** dtantsur is now known as dtantsur|afk | 17:40 | |
| dansmith | prometheanfire: pike one is in the queue now | 17:42 |
| prometheanfire | yep, I'm watching it | 17:43 |
| *** gyee has quit IRC | 17:54 | |
| *** mvkr has joined #openstack-nova | 17:56 | |
| *** slaweq_ has joined #openstack-nova | 18:07 | |
| prometheanfire | am I right in thinking that this patch makes it so that images with the hypervisor_type of qemu will not boot on nova nodes having virt_type=kvm? https://git.openstack.org/cgit/openstack/nova/commit/?id=eaa766ee2093c24fd61c61e52f46bdd9ff9e93d2 | 18:09 |
| *** slaweq_ has quit IRC | 18:15 | |
| *** eharney has joined #openstack-nova | 18:19 | |
| melwitt | I think so. dansmith? ^ | 18:26 |
| dansmith | that's the point I think yeah | 18:26 |
| melwitt | prometheanfire ^ | 18:29 |
| *** gbarros has joined #openstack-nova | 18:31 | |
| dansmith | I think the goal was kindof the opposite, to make sure that kvm-requiring instances didn't boot on qemu-only hosts, but the result for your case is the same I think | 18:32 |
| prometheanfire | dansmith: ok, it sounds like that means I'll have to upload images twice (once for each hypervisor_type) if I want the image to boot on both (I have other images that are ironic, which is why I need to specify type in the first place) | 18:33 |
| dansmith | prometheanfire: why do you ever have images that specify qemu? | 18:33 |
| *** burt has joined #openstack-nova | 18:33 | |
| *** priteau has joined #openstack-nova | 18:37 | |
| prometheanfire | gating on hosts that don't allow nested virt | 18:38 |
| prometheanfire | it's for that reason alone | 18:38 |
| dansmith | um | 18:40 |
| dansmith | just because something uses kvm type doesn't mean it supports nested virt | 18:41 |
| *** adrianc has quit IRC | 18:41 | |
| prometheanfire | that's not what I was trying to say | 18:41 |
| prometheanfire | I was trying to say some of our hosts don't have kvm | 18:41 |
| dansmith | ...really? | 18:41 |
| dansmith | by policy or soemthing? | 18:42 |
| dansmith | I mean running in actual qemu mode is so slow, it's hard to make any real-world use case for it | 18:42 |
| prometheanfire | ya | 18:42 |
| prometheanfire | it's stupid | 18:42 |
| dansmith | alright :D | 18:42 |
| *** gbarros has quit IRC | 18:43 | |
| prometheanfire | ok, looks like just uploading the cirros image twice will work for this usage at least | 18:45 |
| *** gbarros has joined #openstack-nova | 18:49 | |
| dansmith | prometheanfire: you and your crazy requests.. next I'm sure you'll be asking us to run live migrations at more than 1MB/s! | 18:55 |
| prometheanfire | dansmith: well, that would be nice, but seems you already did that :P | 18:56 |
| dansmith | hehe | 18:56 |
| *** gbarros has quit IRC | 18:58 | |
| *** slaweq_ has joined #openstack-nova | 19:13 | |
| *** openstackgerrit has quit IRC | 19:19 | |
| *** rosey99_ has joined #openstack-nova | 19:21 | |
| *** mdbooth has quit IRC | 19:32 | |
| *** gbarros has joined #openstack-nova | 19:33 | |
| *** awaugama has quit IRC | 19:38 | |
| *** hamzy has quit IRC | 19:43 | |
| *** hamzy has joined #openstack-nova | 19:46 | |
| *** efried_rollin is now known as efried | 19:53 | |
| *** priteau has quit IRC | 20:05 | |
| efried | cfriesen: Re https://review.openstack.org/#/c/590041/ -- do the examples in the commit message look appropriately useful to you? Any suggestions for improvement or whatever? | 20:30 |
| *** openstackgerrit has joined #openstack-nova | 20:50 | |
| openstackgerrit | Doug Hellmann proposed openstack/nova master: use static pages for mitaka and newton release notes https://review.openstack.org/592150 | 20:50 |
| openstackgerrit | Dmitry Sutyagin proposed openstack/nova master: libvirt: add disabling KSM via flavor extra specs https://review.openstack.org/591854 | 20:54 |
| *** gbarros has quit IRC | 20:58 | |
| *** gbarros has joined #openstack-nova | 20:59 | |
| *** masayukig has quit IRC | 21:12 | |
| *** rcernin has joined #openstack-nova | 21:29 | |
| cfriesen | efried: that looks useful. It occurs to me that it might be useful to list *which* providers were found to see which ones were ruled out at each step. (Not sure if that'd be too verbose or not.) | 21:29 |
| efried | cfriesen: Yeah, and we'd probably be talking about printing a bunch of UUIDs, which might not be especially readable anyway. | 21:30 |
| efried | cfriesen: Though something like that could be considered for TRACE level... | 21:30 |
| cfriesen | sounds reasonable. what you've got is still a significant improvement | 21:32 |
| *** gbarros has quit IRC | 21:40 | |
| *** slaweq_ has quit IRC | 21:42 | |
| *** gbarros has joined #openstack-nova | 21:43 | |
| *** erlon has quit IRC | 21:50 | |
| openstackgerrit | Merged openstack/nova master: Add placement perf info gathering hook to end of nova-next https://review.openstack.org/591367 | 21:52 |
| *** EmilienM has joined #openstack-nova | 22:03 | |
| *** EmilienM has left #openstack-nova | 22:03 | |
| *** gbarros has quit IRC | 22:18 | |
| *** masayukig has joined #openstack-nova | 22:18 | |
| *** FracKen has left #openstack-nova | 22:21 | |
| efried | melwitt: Agree that https://review.openstack.org/#/c/591854/ should have a reno? | 22:21 |
| *** itlinux has quit IRC | 22:22 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Merge extended availability zone response into server controller https://review.openstack.org/502859 | 22:25 |
| melwitt | efried: looking | 22:31 |
| melwitt | efried: I agree it should have a reno to signal the availability of something new people can use. but I'm not clear on whether this is proposing a brand new extra spec? if it is, I think that would need at least a specless blueprint | 22:35 |
| efried | melwitt: Okay, swhat I thought on the reno. You da boss on the bp. | 22:35 |
| efried | thanks | 22:36 |
| efried | melwitt: And yes, IIUC it's a brand new extra_spec. | 22:36 |
| melwitt | okay. I'll ask mriedem about it when he's around, to get his input | 22:36 |
| efried | melwitt: Okay, I added a note to that effect, with a reference to the doc. | 22:38 |
| *** imacdonn has quit IRC | 22:38 | |
| *** imacdonn has joined #openstack-nova | 22:38 | |
| melwitt | ok, thanks | 22:38 |
| efried | melwitt: Based on what I'm reading at https://docs.openstack.org/nova/latest/contributor/blueprints.html and https://specs.openstack.org/openstack/nova-specs/readme.html#trivial-specifications I think you're probably right. | 22:39 |
| melwitt | efried: thanks. yeah, was also looking at the git blame to see how other extra specs were added, for example one was from https://specs.openstack.org/openstack/nova-specs/specs/ocata/approved/libvirt-emulator-threads-policy.html | 22:41 |
| efried | mm, that one clearly not specless | 22:42 |
| melwitt | yeah. but for this one, it seems small enough that specless is my expectation, but I'll run it by mriedem and dansmith because sometimes a lot of questions arise and if that happens, a spec would be more appropriate | 22:43 |
| melwitt | I can't say I know anyting about KSM myself | 22:44 |
| melwitt | *anything | 22:44 |
| *** erlon has joined #openstack-nova | 22:52 | |
| efried | melwitt: Oh, technically I'm relying on sahid and sean-k-mooney to vet it. Procedurally... yeah, Matt and Dan. | 22:59 |
| dansmith | I dunno about the claim that windows crashes when KSM is used.. can't really think of any reason that would be | 23:00 |
| dansmith | normally I think of KSM as being a host decision or not, | 23:00 |
| dansmith | so I'm kinda unsure about why we'd want it to be per-flavor | 23:00 |
| dansmith | especially since it would affect your memory overcommit calculations | 23:01 |
| dansmith | I would think you'd want to keep KSMing and non-KSMing instances separated by aggregate anyway | 23:01 |
| *** _ix has quit IRC | 23:01 | |
| dansmith | so I mean, that all leads me to think that it's probably worth a spec just on that basis | 23:01 |
| dansmith | the other being that we want to make sure that we're not just plumbing a libvirt feature straight out the API | 23:02 |
| melwitt | ack, thanks dansmith | 23:02 |
| dansmith | and we should get input from the other virt drivers on whether they have similar technologies and make sure we can drive them with the same tunable | 23:02 |
| dansmith | like, whether or not they allow it per-VM or only per-host | 23:02 |
| dansmith | and whether it's just on or off, ro, rw, off, etc | 23:03 |
| dansmith | I'd surely not want to add this just because someone thinks windows is destabilized by KSM, or because they have some weird unstable driver and turning KSM off changes some race semantics or something | 23:04 |
| cfriesen | I could see KSM causing brief interruptions to the guest, but I wouldn't expect it to cause actual hangs. | 23:05 |
| dansmith | right, | 23:06 |
| dansmith | it can change timing semantics for sure | 23:06 |
| dansmith | hence the buggy driver example | 23:07 |
| dansmith | but so can swapping on the host to a much larger degree | 23:07 |
| openstackgerrit | Dmitry Sutyagin proposed openstack/nova master: libvirt: add disabling KSM via flavor extra specs https://review.openstack.org/591854 | 23:08 |
| openstackgerrit | Merged openstack/nova stable/pike: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/591762 | 23:16 |
| *** rcernin has quit IRC | 23:18 | |
| *** rcernin has joined #openstack-nova | 23:19 | |
| *** gbarros has joined #openstack-nova | 23:20 | |
| dansmith | prometheanfire: ^ | 23:24 |
| prometheanfire | :D | 23:26 |
| *** takashin has joined #openstack-nova | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!