| *** rcernin_ has joined #openstack-nova | 00:02 | |
| *** rcernin has quit IRC | 00:03 | |
| *** takashin has joined #openstack-nova | 00:06 | |
| *** namnh has quit IRC | 00:17 | |
| *** eharney has quit IRC | 00:18 | |
| *** brinzhang has joined #openstack-nova | 00:22 | |
| *** tbachman_ has joined #openstack-nova | 00:27 | |
| *** rcernin has joined #openstack-nova | 00:29 | |
| *** tbachman has quit IRC | 00:29 | |
| *** tbachman_ is now known as tbachman | 00:29 | |
| *** rcernin has quit IRC | 00:29 | |
| *** rcernin has joined #openstack-nova | 00:30 | |
| *** rcernin_ has quit IRC | 00:32 | |
| *** slaweq_ has joined #openstack-nova | 00:32 | |
| *** mriedem has joined #openstack-nova | 00:33 | |
| *** zhurong has joined #openstack-nova | 00:33 | |
| mriedem | o/ | 00:33 |
|---|---|---|
| *** slaweq_ has quit IRC | 00:37 | |
| Kevin_Zheng | too early | 00:40 |
| *** nicolasbock has quit IRC | 00:45 | |
| Kevin_Zheng | mriedem, got something interesting, as we can provide metadata with this API, https://developer.openstack.org/api-ref/compute/#create-image-createimage-action it might override the system generated metadata: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2877 | 00:45 |
| Kevin_Zheng | and we did it again in https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2911 | 00:45 |
| Kevin_Zheng | seems redundant, and should we limit the key? | 00:46 |
| Kevin_Zheng | like don't allow set user_id | 00:46 |
| Kevin_Zheng | image_type | 00:46 |
| mriedem | my network needs to catch up... | 00:47 |
| Kevin_Zheng | OK | 00:47 |
| *** yedongcan has joined #openstack-nova | 00:47 | |
| *** slaweq_ has joined #openstack-nova | 00:53 | |
| mriedem | Kevin_Zheng: hmm, yeah, not sure | 00:55 |
| mriedem | looks like this could be used to change the owner of the snapshot to another user | 00:55 |
| *** jpenag has joined #openstack-nova | 00:56 | |
| Kevin_Zheng | yeah | 00:56 |
| *** vivsoni has quit IRC | 00:57 | |
| *** gmann has quit IRC | 00:57 | |
| *** jpena|off has quit IRC | 00:57 | |
| *** lennyb has quit IRC | 00:57 | |
| *** DinaBelova has quit IRC | 00:57 | |
| *** yankcrime has quit IRC | 00:57 | |
| Kevin_Zheng | Yeah | 00:57 |
| Kevin_Zheng | And the uuid might not be important | 00:57 |
| Kevin_Zheng | Instance uuid | 00:57 |
| *** slaweq_ has quit IRC | 00:57 | |
| *** nicolasbock has joined #openstack-nova | 00:58 | |
| *** panda|ruck has quit IRC | 00:59 | |
| *** namnh has joined #openstack-nova | 00:59 | |
| *** johnthetubaguy has quit IRC | 01:00 | |
| mriedem | i would think if this were a major issue, someone would have reported/fixed it by now after 10 years | 01:01 |
| *** johnthetubaguy has joined #openstack-nova | 01:02 | |
| *** panda has joined #openstack-nova | 01:02 | |
| *** vivsoni has joined #openstack-nova | 01:03 | |
| *** 18WAA8G2G has joined #openstack-nova | 01:04 | |
| *** gmann has joined #openstack-nova | 01:04 | |
| *** DinaBelova has joined #openstack-nova | 01:04 | |
| *** yankcrime has joined #openstack-nova | 01:04 | |
| *** 18WAA8G2G has quit IRC | 01:04 | |
| *** DinaBelova has quit IRC | 01:04 | |
| *** namnh has quit IRC | 01:04 | |
| Kevin_Zheng | mriedem, got it | 01:04 |
| *** DinaBelova has joined #openstack-nova | 01:05 | |
| *** mriedem has quit IRC | 01:05 | |
| *** panda has quit IRC | 01:06 | |
| *** openstackgerrit has quit IRC | 01:06 | |
| *** panda has joined #openstack-nova | 01:07 | |
| *** slaweq_ has joined #openstack-nova | 01:11 | |
| *** Nel1x has joined #openstack-nova | 01:13 | |
| *** slaweq_ has quit IRC | 01:16 | |
| *** hemna_ has quit IRC | 01:17 | |
| *** mhen has quit IRC | 01:18 | |
| *** mhen has joined #openstack-nova | 01:22 | |
| *** mriedem has joined #openstack-nova | 01:24 | |
| *** tbachman_ has joined #openstack-nova | 01:26 | |
| *** tbachman has quit IRC | 01:28 | |
| *** tbachman_ is now known as tbachman | 01:28 | |
| *** mrsoul has quit IRC | 01:31 | |
| *** slaweq_ has joined #openstack-nova | 01:32 | |
| *** slaweq_ has quit IRC | 01:37 | |
| *** zhurong has quit IRC | 01:39 | |
| *** namnh has joined #openstack-nova | 01:44 | |
| *** mriedem1 has joined #openstack-nova | 01:47 | |
| mriedem1 | blarg! | 01:47 |
| *** lei-zh has joined #openstack-nova | 01:52 | |
| *** hongbin has joined #openstack-nova | 02:01 | |
| mriedem1 | are we waiting for anything on this? https://review.openstack.org/#/c/590445/ it's marked for RC2 | 02:05 |
| mriedem1 | but hasn't yet been merged on master | 02:05 |
| *** openstackgerrit has joined #openstack-nova | 02:09 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Fix service list for disabled compute using MC driver https://review.openstack.org/583936 | 02:09 |
| *** slaweq_ has joined #openstack-nova | 02:11 | |
| *** mriedem has quit IRC | 02:11 | |
| *** mriedem1 is now known as mriedem | 02:11 | |
| *** zhurong has joined #openstack-nova | 02:15 | |
| *** slaweq_ has quit IRC | 02:16 | |
| *** lei-zh has quit IRC | 02:31 | |
| *** lei-zh has joined #openstack-nova | 02:31 | |
| *** slaweq_ has joined #openstack-nova | 02:32 | |
| *** psachin has joined #openstack-nova | 02:36 | |
| *** slaweq_ has quit IRC | 02:36 | |
| takashin | 02:43 | |
| *** tbachman_ has joined #openstack-nova | 02:48 | |
| *** tbachman has quit IRC | 02:52 | |
| *** tbachman_ is now known as tbachman | 02:52 | |
| *** vivsoni has quit IRC | 03:01 | |
| *** takashin has left #openstack-nova | 03:02 | |
| naichuans | mriedem: Hi, Matt, because Rocky feather has been freezed while bp: vgpu_rocky hasn't finished, I reprose a new bp here: https://blueprints.launchpad.net/nova/+spec/vgpu-stein. Please check if it is OK. Thank you very much. | 03:03 |
| *** Bhujay has joined #openstack-nova | 03:04 | |
| openstackgerrit | liuyamin proposed openstack/python-novaclient master: Replace os-client-config to openstacksdk https://review.openstack.org/590141 | 03:05 |
| *** slaweq_ has joined #openstack-nova | 03:11 | |
| *** Nel1x has quit IRC | 03:12 | |
| *** zhurong has quit IRC | 03:14 | |
| *** slaweq_ has quit IRC | 03:16 | |
| *** slaweq_ has joined #openstack-nova | 03:32 | |
| *** slaweq_ has quit IRC | 03:37 | |
| *** hongbin has quit IRC | 03:39 | |
| mriedem | naichuans: ok, i guess we'll just obsolete the rocky bp since none of the changes merged | 03:40 |
| *** Bhujay has quit IRC | 03:40 | |
| *** namnh has quit IRC | 03:40 | |
| *** slaweq_ has joined #openstack-nova | 03:53 | |
| *** udesale has joined #openstack-nova | 03:53 | |
| *** slaweq_ has quit IRC | 03:57 | |
| *** vivsoni has joined #openstack-nova | 04:00 | |
| naichuans | mriedem: Got it, thanks | 04:04 |
| *** dave-mccowan has quit IRC | 04:12 | |
| *** lei-zh has quit IRC | 04:16 | |
| *** Bhujay has joined #openstack-nova | 04:21 | |
| *** janki has joined #openstack-nova | 04:28 | |
| *** slaweq_ has joined #openstack-nova | 04:32 | |
| *** slaweq_ has quit IRC | 04:36 | |
| *** links has joined #openstack-nova | 04:43 | |
| *** abhishekk has joined #openstack-nova | 04:55 | |
| *** gyee has quit IRC | 05:05 | |
| *** slaweq_ has joined #openstack-nova | 05:11 | |
| *** slaweq_ has quit IRC | 05:16 | |
| *** slaweq_ has joined #openstack-nova | 05:32 | |
| *** slaweq_ has quit IRC | 05:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete instance_id_mappings record in instance_destroy https://review.openstack.org/591558 | 05:45 |
| mriedem | Kevin_Zheng: yikun: bingo ^ | 05:46 |
| *** ratailor has joined #openstack-nova | 05:47 | |
| *** slaweq_ has joined #openstack-nova | 05:53 | |
| *** lei-zh has joined #openstack-nova | 05:56 | |
| *** slaweq_ has quit IRC | 05:57 | |
| mriedem | do you guys use pypi mirrors in china? otherwise tox times out | 05:57 |
| Kevin_Zheng | Hmm, it should automatically connect to the fastest one, no? | 06:00 |
| fanzhang | mriedem Kevin_Zheng I am using index-url = https://pypi.tuna.tsinghua.edu.cn/simple ;-) | 06:04 |
| *** vivsoni has quit IRC | 06:13 | |
| *** odyssey4me has quit IRC | 06:14 | |
| *** odyssey4me has joined #openstack-nova | 06:14 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Fix service list for disabled compute using MC driver https://review.openstack.org/583936 | 06:15 |
| Kevin_Zheng | fanzhang Are you doing it in Linux or windows | 06:21 |
| fanzhang | Kevin_Zheng Linux and MacOS | 06:22 |
| Kevin_Zheng | Thanks, we will try latter | 06:24 |
| fanzhang | np | 06:24 |
| *** lpetrut has joined #openstack-nova | 06:26 | |
| *** slaweq_ has joined #openstack-nova | 06:32 | |
| *** lei-zh1 has joined #openstack-nova | 06:33 | |
| *** lei-zh has quit IRC | 06:36 | |
| *** slaweq_ has quit IRC | 06:36 | |
| *** pcaruana has joined #openstack-nova | 06:44 | |
| *** adrianc has joined #openstack-nova | 06:44 | |
| *** slaweq_ has joined #openstack-nova | 06:53 | |
| *** slaweq_ has quit IRC | 06:57 | |
| *** slaweq_ has joined #openstack-nova | 07:00 | |
| *** ccamacho has joined #openstack-nova | 07:01 | |
| *** rcernin has quit IRC | 07:02 | |
| gibi | mriedem: hi! I'm not planning to have a notification meeting also I assume your timezone is not friendly for that meeting | 07:20 |
| *** lbragstad has joined #openstack-nova | 07:23 | |
| *** sahid has joined #openstack-nova | 07:29 | |
| sean-k-mooney | mriedem: o/ i have been doing some livemigration testing between different backends and different OSs and have been finding issues. im going to keep refining my testing but while it is posible to move the vms i dont think its working correctly | 07:39 |
| sean-k-mooney | mriedem: live migration from cetos to ubuntu is broken. that used to work but the emltor path is nolonger the same and we use the emulator path of the src for the dest when checnking compatablity | 07:41 |
| sean-k-mooney | live migration from lb to ovs appears to work but ovs to lb times out waiting for the plug event | 07:41 |
| sean-k-mooney | from neutron | 07:41 |
| *** sapcc-bot1 has quit IRC | 07:42 | |
| sean-k-mooney | im going to add a few more nodes to my testing to confirm all the behavior. ill send an email to the list with a summary when done | 07:42 |
| *** ygk_12345 has joined #openstack-nova | 07:47 | |
| *** holser_ has joined #openstack-nova | 07:47 | |
| *** sapcc-bot2 has quit IRC | 07:51 | |
| *** janki is now known as janki|lunch | 07:52 | |
| *** tssurya has joined #openstack-nova | 07:54 | |
| *** alexchadin has joined #openstack-nova | 07:57 | |
| gryf | sean-k-mooney, I've answered your review. | 08:01 |
| gryf | erm. comments. | 08:01 |
| ygk_12345 | hi all | 08:02 |
| gryf | johnthetubaguy, could you please also look at https://review.openstack.org/#/c/536351 ? | 08:02 |
| ygk_12345 | what does negative number indicate for RAM in hypervisor stats ? | 08:03 |
| ygk_12345 | does it mean no more memory available for vms on the computes ? | 08:03 |
| *** Bhujay has quit IRC | 08:10 | |
| *** mchlumsky has quit IRC | 08:12 | |
| *** openstackstatus has quit IRC | 08:12 | |
| *** mchlumsky has joined #openstack-nova | 08:13 | |
| *** dtantsur|afk is now known as dtantsur | 08:15 | |
| sean-k-mooney | gryf: thanks, you are correct that the disk filter is deprcated rather than removed. | 08:15 |
| sean-k-mooney | the disk fileter is calulating the avialble space its self form the host_state.free_diks_mb and host_state.total_usable_disk_gb | 08:17 |
| sean-k-mooney | i am not sure how host_state.total_usable_disk_gb is related to the migrtion_data disk available_gb | 08:18 |
| sean-k-mooney | they apepar to be independent | 08:19 |
| *** mvkr has quit IRC | 08:20 | |
| mriedem | gibi: yeah i won't be around for the notification meeting | 08:21 |
| sean-k-mooney | ygk_12345: it means that the total memory used is grater than total ram - reserved ram | 08:21 |
| gibi | mriedem: no problem | 08:21 |
| mriedem | sean-k-mooney: ok i think lb plug events is a known issue isn't it? | 08:22 |
| ygk_12345 | sean-k-mooney: also I am getting warnings in the nova logs that enough memory cant be allocated . what does this mean ? | 08:22 |
| sean-k-mooney | mriedem: well live migration between 2 lb nodes seams to work. i thikn libvirt is using the souce xml without the updated network interfaces in the ovs case and that is breaking things. i have not really had time to dig into it yet | 08:24 |
| sean-k-mooney | ygk_12345: can you post the error message to paste.openstack.org | 08:24 |
| sean-k-mooney | ygk_12345: also on the node with the error can you tell me how much ram do you have, what is the reseved memory set in the config and how much is used by instance on that node? | 08:26 |
| *** jpenag is now known as jpena | 08:27 | |
| *** ygk_12345 has quit IRC | 08:27 | |
| *** derekh has joined #openstack-nova | 08:29 | |
| *** Bhujay has joined #openstack-nova | 08:34 | |
| mriedem | dims: http://docs.sqlalchemy.org/en/latest/core/metadata.html?highlight=class%20column#sqlalchemy.schema.Column.params.onupdate | 08:39 |
| *** tbachman has quit IRC | 08:40 | |
| *** kaisers has joined #openstack-nova | 08:40 | |
| mriedem | e.g. Column('last_modified', DateTime, onupdate=func.utc_timestamp()) | 08:41 |
| *** janki|lunch is now known as janki | 08:42 | |
| *** cdent has joined #openstack-nova | 08:43 | |
| *** mvkr has joined #openstack-nova | 08:52 | |
| *** jaosorior has quit IRC | 08:53 | |
| sean-k-mooney | mdbooth: regarding https://review.openstack.org/#/c/536351 can you confirm that this is never used in the disk filter. looking at https://github.com/openstack/nova/blob/master/nova/scheduler/filters/disk_filter.py#L38-L59 we appear to purely calulate the availe disk from the host_state | 08:58 |
| mdbooth | sean-k-mooney: Don't they have the same source? | 09:01 |
| sean-k-mooney | mdbooth: i can not find any use of the migrate_data.disk_available_mb in the condoctor before the downcall to the compute | 09:02 |
| sean-k-mooney | mdbooth: which the host_state object and where we are constuction the migration data | 09:03 |
| mdbooth | sean-k-mooney: Can you restate your original question. Can I confirm that *what*? is never used... | 09:03 |
| sean-k-mooney | mdbooth: so looking at https://review.openstack.org/#/c/536351/3/nova/virt/libvirt/driver.py the migrate_data object constructed in this fuction is not used before the downcall to the compute node. | 09:04 |
| sean-k-mooney | but there is also a comment about this change relating to the disk filter however the disk filter appears to calulate the availabel disk space independly via the info in the host state object | 09:05 |
| sean-k-mooney | so im trying to figure out at what point is the value store in the migarte_data.disk_available_mb actully used | 09:06 |
| *** alexchadin has quit IRC | 09:07 | |
| *** huanxie has joined #openstack-nova | 09:09 | |
| mdbooth | sean-k-mooney: It's used in check_can_live_migrate_source | 09:12 |
| mdbooth | But only if disk_over_commit is set | 09:12 |
| gryf | its verified in _assert_dest_node_has_enough_disk method and only for block_migration | 09:13 |
| sean-k-mooney | mdbooth: where is mdbooth gryf i am not seeing either of those methods in the condoctor live_migrate.py are they performed on the compute node via rpc | 09:15 |
| mdbooth | iirc check_can_live_migrate_source is called from check_can_live_migrate_dest | 09:16 |
| gryf | sean-k-mooney, they are performed in driver | 09:16 |
| mdbooth | Nah, they're called from compute manager | 09:16 |
| gryf | and called from compute manager | 09:16 |
| mdbooth | The code's in the driver | 09:16 |
| gryf | yeah | 09:16 |
| *** ratailor has quit IRC | 09:17 | |
| mdbooth | Oh, _dest is called from conductor | 09:17 |
| gryf | compute.manager.check_can_live_migrate_destination | 09:18 |
| mdbooth | Which then calls _source | 09:18 |
| openstackgerrit | Merged openstack/nova master: placement: ignore policy scope check failures if not enforcing scope https://review.openstack.org/590445 | 09:19 |
| *** ratailor has joined #openstack-nova | 09:19 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: DNM: Add placement perf info gathering to end of nova-next https://review.openstack.org/591367 | 09:20 |
| mriedem | mdbooth: https://docs.openstack.org/nova/latest/reference/live-migration.html :) | 09:21 |
| mdbooth | mriedem: It's so simple they even drew a picture about it. | 09:21 |
| sean-k-mooney | mdbooth: gryf so yes looking at https://github.com/openstack/nova/blob/0502b0ffaf20ef3735e633715ba0f9dda976cb7a/nova/virt/libvirt/driver.py#L6774 | 09:22 |
| sean-k-mooney | i do not see the disk allocation ratio being used in that check | 09:23 |
| sean-k-mooney | so would that not imply we have to take account of it when we first calulate disk_avaiable_mb | 09:24 |
| mdbooth | sean-k-mooney: So this code isn't related to DiskFilter | 09:25 |
| gryf | sean-k-mooney, possibly, but that's another thing, isn't it? | 09:25 |
| sean-k-mooney | mdbooth: yes i know | 09:25 |
| sean-k-mooney | gryf: well the bug is fixing how we calulate the available diskspace. if it does so by not allowing over allocation of disk when its turned on that jsut creates another bug | 09:26 |
| gryf | hm. | 09:26 |
| mdbooth | I would hope that disk_available_mb would be calculated as the amount of available disk, in mb. | 09:26 |
| mdbooth | If anybody makes it anything else, I want to know where they live. | 09:27 |
| mdbooth | If we need to take disk allocation ratio into account, we should do that at the point of use. | 09:27 |
| mdbooth | Or call it something else. | 09:27 |
| sean-k-mooney | it should be eitehr available disk = ((total diskspcae - reserved disk space) * disk allocation ratio) - used disk space or available disk = ((total diskspcae - reserved disk space)) - used disk space | 09:27 |
| sean-k-mooney | if its the later then we never take account of disk overcomit when live migrating | 09:28 |
| mdbooth | I'd argue that overcommit has always been a job for the scheduler, anyway. | 09:28 |
| gryf | sean-k-mooney, i'd move out reserved disk space out of equation | 09:28 |
| openstackgerrit | Chris Dent proposed openstack/nova stable/pike: [placement] Retry allocation writes server side https://review.openstack.org/590745 | 09:28 |
| mdbooth | I think live migration should fail only if there aren't physically enough bits on the destination to hold the source bits. | 09:29 |
| gryf | we don;t want to change that by allocation ratio if it's something else from 1 | 09:29 |
| sean-k-mooney | gryf: why not | 09:29 |
| sean-k-mooney | the allocation ratio should only be applied to the portion of the disk that is not reserved | 09:30 |
| gryf | so, isn't it be (total disk space - used disk space - reserved disk space) * allocation ratio? | 09:32 |
| cdent | "If we need to take disk allocation ratio into account, we should do that at the point of use." yes | 09:33 |
| gryf | or even (total disk space - used disk space) * allocation ratio - reserved disk space | 09:33 |
| *** markvoelker has joined #openstack-nova | 09:33 | |
| sean-k-mooney | actully gryf no we dont want to multiple the used disk space by the allocation ratio | 09:33 |
| sean-k-mooney | but its not needed in either case | 09:34 |
| sean-k-mooney | i just realised https://github.com/openstack/nova/blob/0502b0ffaf20ef3735e633715ba0f9dda976cb7a/nova/virt/libvirt/driver.py#L6768 | 09:34 |
| mdbooth | There are 2 ways to get a live migration destination: | 09:34 |
| mdbooth | 1. From the scheduler, which will take this stuff into account | 09:34 |
| sean-k-mooney | is using the actul size of the disk not the virtual size | 09:34 |
| mdbooth | 2. From the admin, who doesn't care about your pesky artificial resource constraints. | 09:34 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consumer gen support for delete instance allocations https://review.openstack.org/591597 | 09:35 |
| sean-k-mooney | in the overcomit case that is so the driver only compares bytes need to copy the disk to actul bytes free on the dest and the schduler/placement operates on teh virtual disk size with allocation ratios taken into account | 09:35 |
| *** alexchadin has joined #openstack-nova | 09:36 | |
| mdbooth | sean-k-mooney: That's the only thing it should ever compare. Anything else is legacy. | 09:36 |
| sean-k-mooney | mdbooth: yes just trying to get the full end to end effect of this change right in my head to make sure there was no edge case missed | 09:37 |
| mdbooth | Right. If an admin wants to move a workload to compute X, the only reason we should say no is if it physically won't fit. Any future problems caused by that are the admin's to deal with. | 09:37 |
| gryf | mdbooth, by "phisically fit" do you mean current src image size, or the maximum one? | 09:39 |
| mdbooth | But hopefully the admin only does that if they really, really need to, and usually they ask the scheduler. | 09:39 |
| mdbooth | gryf: I mean current, allocated disk. | 09:39 |
| gryf | ack | 09:39 |
| sean-k-mooney | mdbooth: gryf cool im much happier this this change then. its sutle but makes sense in context | 09:39 |
| *** openstackstatus has joined #openstack-nova | 09:41 | |
| *** ChanServ sets mode: +v openstackstatus | 09:41 | |
| *** hoonetorg has quit IRC | 09:43 | |
| openstackgerrit | Surya Seetharaman proposed openstack/python-novaclient master: [WIP/POC] Client changes for down cell https://review.openstack.org/579563 | 09:44 |
| *** ratailor has quit IRC | 09:48 | |
| *** lpetrut has quit IRC | 09:48 | |
| *** ratailor has joined #openstack-nova | 09:49 | |
| *** lei-zh1 has quit IRC | 09:51 | |
| gryf | sean-k-mooney, do you want me to rebase and correct typo on commit message? | 09:54 |
| gryf | typos* | 09:54 |
| sean-k-mooney | gryf: they are just nits so no its fine | 09:54 |
| gryf | cool. thanks | 09:55 |
| sean-k-mooney | gryf: if you have to respin the patch for some other reason then sure but no need to respin just for that. that said my spelling is terrible so other may have a different view | 09:55 |
| gryf | sean-k-mooney, I'd just like to have it merged :) | 09:56 |
| *** hoonetorg has joined #openstack-nova | 09:57 | |
| sean-k-mooney | gryf: by the way im not sure if johnthetubaguy is around at the moment to review this or not | 09:57 |
| gryf | I guess he is not | 09:57 |
| sean-k-mooney | gryf: his time upstream has been limited this cycle i belive given his current positon | 09:58 |
| gryf | Right. | 09:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Force refresh instance info_cache during heal https://review.openstack.org/591607 | 10:02 |
| sean-k-mooney | mriedem: i dont know if your still about but your pretty familar with the livemigration code perhaps you could take a look at https://review.openstack.org/#/c/536351/3 in johnthetubaguy absence. that said not sure this is high enough prority to make it into RC2 so maybe it will have to wait till stein in anycase | 10:02 |
| mriedem | Kevin_Zheng: see https://review.openstack.org/591607 | 10:03 |
| mriedem | sean-k-mooney: just going to dinner | 10:03 |
| *** dpawlik has quit IRC | 10:03 | |
| mriedem | sean-k-mooney: oh that one, idk | 10:03 |
| sean-k-mooney | mriedem: no worries i was just trying to think who was about to take a look at it. | 10:04 |
| *** dpawlik has joined #openstack-nova | 10:05 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: order multi-row INSERT by PK https://review.openstack.org/591609 | 10:05 |
| *** markvoelker has quit IRC | 10:07 | |
| *** mdbooth has quit IRC | 10:10 | |
| *** lbragstad has quit IRC | 10:12 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: order multi-row INSERT by PK https://review.openstack.org/591609 | 10:15 |
| *** mvkr has quit IRC | 10:22 | |
| *** panda is now known as panda|ruck | 10:24 | |
| *** adrianc has quit IRC | 10:25 | |
| *** adrianc has joined #openstack-nova | 10:26 | |
| *** abhishekk has quit IRC | 10:50 | |
| *** jaosorior has joined #openstack-nova | 10:51 | |
| openstackgerrit | Chen proposed openstack/nova master: Typo fixes on notifications doc https://review.openstack.org/591621 | 10:58 |
| *** udesale has quit IRC | 10:59 | |
| *** markvoelker has joined #openstack-nova | 11:04 | |
| *** jpena is now known as jpena|lunch | 11:15 | |
| *** jaosorior has quit IRC | 11:17 | |
| *** holser_ has quit IRC | 11:17 | |
| *** jaosorior has joined #openstack-nova | 11:17 | |
| *** s10 has joined #openstack-nova | 11:27 | |
| *** josecastroleon has quit IRC | 11:28 | |
| *** josecastroleon has joined #openstack-nova | 11:28 | |
| *** markvoelker has quit IRC | 11:37 | |
| *** yedongcan has left #openstack-nova | 11:44 | |
| *** nicolasbock has quit IRC | 11:49 | |
| *** slagle has joined #openstack-nova | 11:53 | |
| *** alexchadin has quit IRC | 11:55 | |
| *** ratailor has quit IRC | 12:09 | |
| sean-k-mooney | mriedem: so far i have found 3 neutron bugs and 1 nova bug in my livemigration testing :( im taking notes and will open them later. ovs-ovs and lb-lb migration seam to be fine however | 12:14 |
| tssurya | gmann: around ? | 12:15 |
| kosamara | efried: Hi! You say that pci subsys_vendor_id etc should appear in libvirt. I checked what libvirt.Host.device_lookup_by_name returns (calls libvirt) and it doesn't report those properties. | 12:16 |
| *** holser_ has joined #openstack-nova | 12:17 | |
| sean-k-mooney | kosamara: if you do virsh nodedev-list and then virsh nodedev-dumpxml pci_0000_00_00_0 you will see the xml fragment that nova parses form libvirt | 12:19 |
| *** dpawlik has quit IRC | 12:20 | |
| sean-k-mooney | kosamara: if you do a nodedev-dumpxml on a network device it will also return the feature supported by that nic http://paste.openstack.org/show/728005/ | 12:21 |
| *** jpena|lunch is now known as jpena | 12:21 | |
| sean-k-mooney | kosamara: we currently store does as netwrok_capablites in the pci_devcice table and they will need to be translated to traits in the future | 12:21 |
| *** erlon has joined #openstack-nova | 12:26 | |
| sean-k-mooney | kosamara: this is where we currently parse all the pcidevice info in the libvirt driver https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5855-L5935 | 12:28 |
| *** tbachman has joined #openstack-nova | 12:28 | |
| sean-k-mooney | kosamara: we invoke that in _get_pcidev_info which is called in get_available_resource | 12:29 |
| *** tbachman has quit IRC | 12:29 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consumer gen support for put allocations https://review.openstack.org/591647 | 12:33 |
| *** udesale has joined #openstack-nova | 12:33 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consumer gen support for put allocations https://review.openstack.org/591647 | 12:35 |
| *** josecastroleon has quit IRC | 12:39 | |
| *** jaosorior has quit IRC | 12:39 | |
| *** rnoriega has quit IRC | 12:39 | |
| *** dpawlik has joined #openstack-nova | 12:42 | |
| *** dave-mccowan has joined #openstack-nova | 12:43 | |
| *** josecastroleon has joined #openstack-nova | 12:46 | |
| kosamara | sean-k-mooney: Still, it doesn't show the subsystem vendor/prod, rev id or class. | 12:49 |
| kosamara | sean-k-mooney but maybe this is just missing from libvirt and should be there, because it makes sense. | 12:50 |
| sean-k-mooney | kosamara: the vendor id is in the parent pci device | 12:52 |
| sean-k-mooney | kosamara: http://paste.openstack.org/show/728011/ | 12:53 |
| *** sahid has quit IRC | 12:54 | |
| kosamara | sean-k-mooney: subsystem vendor (SVendor in lspci) is a separate property. Eg an Evga-made GPU might have a different SVendor than a Gigabyte one. | 12:55 |
| kosamara | but the same "vendor_id" (nvidia) | 12:56 |
| *** awaugama has joined #openstack-nova | 12:56 | |
| sean-k-mooney | hum perhaps. we dont track that difference in nova | 12:56 |
| sean-k-mooney | from a driver/guest perspective we would not be able to tell the differecne really provided its the same model number. | 12:57 |
| sean-k-mooney | yes i know evga may have the same part running at a different clockrate then gagabyte or asusu but we are not that detailed in our tracking | 12:58 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Return a minimal construct for nova list when a cell is down https://review.openstack.org/567785 | 13:00 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Return a minimal construct for nova service-list when a cell is down https://review.openstack.org/584829 | 13:00 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add get_by_cell_and_project() method to InstanceMappingList https://review.openstack.org/591656 | 13:00 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion bump for handling-down-cell https://review.openstack.org/591657 | 13:00 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Return a minimal construct for nova show when a cell is down https://review.openstack.org/591658 | 13:00 |
| kosamara | sean-k-mooney efried: so in the end, does it make sense to leave that open in the inventory yaml spec? maybe for a future use? | 13:02 |
| *** gbarros has joined #openstack-nova | 13:04 | |
| *** psachin has quit IRC | 13:06 | |
| *** Bhujay has quit IRC | 13:07 | |
| *** Bhujay has joined #openstack-nova | 13:07 | |
| sean-k-mooney | kosamara: i dont think so. i think that might be leaking too much host specific info to the enduser. we could leave a comment but i dont think we should whoudl consider 2 GTX1080s form differend ODMs to be different | 13:08 |
| *** alexchadin has joined #openstack-nova | 13:09 | |
| sean-k-mooney | kosamara: your other option is to modify libvirt. the reaosn we get the nic feature flags from libvirt instead of ethtool is because we were not allow to bypass libvirt to look this up form ethool or sysfs in the past so going to sysfs to get the subvendor will likely not be allow nor is lspci likely to be accepted but you could document those approches. | 13:11 |
| *** gbarros has quit IRC | 13:11 | |
| gmann | tssurya: hi | 13:12 |
| sean-k-mooney | anyway im really goint to lunch now. | 13:12 |
| *** eharney has joined #openstack-nova | 13:13 | |
| kosamara | sean-k-mooney: I agree, just mentioning the possibilities | 13:14 |
| *** sahid has joined #openstack-nova | 13:16 | |
| *** gbarros has joined #openstack-nova | 13:20 | |
| *** _ix has joined #openstack-nova | 13:26 | |
| tssurya | gmann: nothing urgent, was just wondering if https://review.openstack.org/#/c/502859/ - this series could be rebased | 13:29 |
| tssurya | also thanks for https://review.openstack.org/#/q/topic:bp/api-extensions-merge-rocky+(status:open) in general, for the handling-down-cell, I guess the two more dependencies are that of extended status and extended volumes part | 13:30 |
| *** hvvcben has joined #openstack-nova | 13:30 | |
| gmann | tssurya: ack, ll do. i am waiting to do policy removal first. anyways will check it tomorrow. | 13:30 |
| tssurya | gmann: np, thanks! | 13:30 |
| *** _ix has quit IRC | 13:34 | |
| *** hvvcben has quit IRC | 13:35 | |
| *** Bhujay has quit IRC | 13:40 | |
| *** josecastroleon has quit IRC | 13:40 | |
| *** jaosorior has joined #openstack-nova | 13:44 | |
| *** burt has joined #openstack-nova | 13:46 | |
| openstackgerrit | Surya Seetharaman proposed openstack/python-novaclient master: Client changes for handling-down-cell with microversion bump https://review.openstack.org/579563 | 13:51 |
| *** _ix has joined #openstack-nova | 13:51 | |
| *** _ix has quit IRC | 13:57 | |
| *** brinzhang has quit IRC | 13:57 | |
| efried | kosamara: I think I would like to converge on an approach where the schema allows the union of what's recognized by all the drivers, for identification. And then each driver documents which fields it pays attention to. | 13:58 |
| efried | kosamara: I haven't caught up yet, in case you've responded to the comments I left last night, but how do you feel about making the spec address both libvirt and powervm? | 13:58 |
| sean-k-mooney | still eating lunch but +1 on a single schema that could be used for any virt dirver | 13:59 |
| sean-k-mooney | it would also be nice the schema wa genreic ennough to support device beyond pci also but that is a streach | 14:01 |
| efried | sean-k-mooney: That's the point. The schema is restrictive to whatever we support right now, but extensible to incorporate other things in the future. And the design statement is explicitly that drivers pay attention to whichever fields they support, and ignore the rest. | 14:05 |
| *** brtknr has quit IRC | 14:05 | |
| efried | It's less about the schema being generic and more about it being inclusive. | 14:05 |
| sean-k-mooney | well when i said generic i kind of was infering that we can assume what type of device it is and what bus it is attached to. | 14:07 |
| sean-k-mooney | we have to declar that in the file | 14:07 |
| *** josecastroleon has joined #openstack-nova | 14:08 | |
| efried | You would determine the "bus" by parsing the PCI address, right? | 14:08 |
| sean-k-mooney | no | 14:08 |
| sean-k-mooney | that wont work for power where we dont have an adress correct | 14:08 |
| sean-k-mooney | we would know the bus by saying bus: pcie | 14:08 |
| efried | We have an address. It just doesn't look like domain:bus:device.function | 14:08 |
| efried | anyway, determining "device type" (whatever that means) and "bus" (whatever that is) would be the purview of the specific driver. | 14:10 |
| efried | If we can identify common fields, like prod and vendor IDs, great. | 14:10 |
| cdent | (specific driver)++ | 14:10 |
| efried | But something like PCI address is going to be ignored by PowerVM; and something like DRC name is going to be ignored by libvirt. | 14:10 |
| sean-k-mooney | efried: im mocking somthin up one sec | 14:11 |
| sean-k-mooney | you know what i might as well jsut use etherpad for this | 14:15 |
| sean-k-mooney | https://etherpad.openstack.org/p/generic-device-schema | 14:16 |
| *** alexchadin has quit IRC | 14:20 | |
| *** hongbin has joined #openstack-nova | 14:21 | |
| *** eharney has quit IRC | 14:24 | |
| *** dpawlik has quit IRC | 14:25 | |
| kosamara | efried: I haven't replied yet, I'm halfway through them :) I do think it's best to have a general YAML spec that caters to the union of the drivers' needs as you say. | 14:27 |
| kosamara | This is the first part, then implementing the "update_provider_tree" algo including understanding the YAML should be driver-specific. | 14:28 |
| sean-k-mooney | kosamara: efried cdent what to you think of somthing like this https://etherpad.openstack.org/p/generic-device-schema | 14:28 |
| kosamara | For the implementation, I don't have any experience on powervm, but I see your reasoning and it makes sense to address both, since it would basically copy over your work on powervm. What I don't know is how much extra attention will have to be paid to the powervm-specific parts, and if this would hold back the rest | 14:30 |
| efried | kosamara: I am developing the powervm bits anyway, so would be delighted to propose them in tree as well as in nova-powervm. | 14:32 |
| kosamara | Sorry, I'll be back in 1h and check it out | 14:32 |
| efried | kosamara: If you're talking about holding up the spec, I think we absolutely need to hold up the spec if we can't agree on an approach that's going to work for powervm as well as libvirt. | 14:33 |
| *** ccamacho has quit IRC | 14:34 | |
| kosamara | efried: of course, it should pave the way for both, I'm only considering the part of the powervm implementation. Let me fix the YAML part first with your comments and we'll have a clearer picture. | 14:34 |
| *** eharney has joined #openstack-nova | 14:37 | |
| *** _ix has joined #openstack-nova | 14:40 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Add placement perf info gathering hook to end of nova-next https://review.openstack.org/591367 | 14:43 |
| openstackgerrit | Chris Dent proposed openstack/nova master: placement: order multi-row INSERT by PK https://review.openstack.org/591609 | 14:46 |
| *** Bhujay has joined #openstack-nova | 14:52 | |
| *** ccamacho has joined #openstack-nova | 14:56 | |
| *** dpawlik has joined #openstack-nova | 15:03 | |
| *** dpawlik has quit IRC | 15:07 | |
| prometheanfire | dansmith: mriedem: not that I'm rushing or anything, but is there an ETA for backports to pike/queens for https://bugs.launchpad.net/nova/+bug/1786346 | 15:08 |
| openstack | Launchpad bug 1786346 in OpenStack Compute (nova) rocky "live migrations slow" [High,In progress] - Assigned to Matt Riedemann (mriedem) | 15:08 |
| dansmith | prometheanfire: I think we should be good to go on backporting that now | 15:08 |
| dansmith | we need to commit the one to rocky too for rc2 | 15:08 |
| prometheanfire | yarp | 15:09 |
| prometheanfire | iirc the backport isn't going to be clean | 15:09 |
| dansmith | melwitt: I assume we just need another stabler to hit it | 15:09 |
| dansmith | prometheanfire: likely not, the revert was messy :/ | 15:09 |
| dansmith | lyarwood: can you hit this patch we need for rc2? https://review.openstack.org/#/c/591275/ | 15:09 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add regression test for bug 1550919 https://review.openstack.org/591733 | 15:10 |
| openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | 15:10 |
| *** mdbooth has joined #openstack-nova | 15:11 | |
| mdbooth | lyarwood mriedem: https://review.openstack.org/#/c/591733/ Regression test for evacuate on shared storage deleting data | 15:13 |
| mdbooth | It's funky because it actually runs the libvirt driver | 15:13 |
| mdbooth | (but not libvirt) | 15:13 |
| dansmith | mdbooth: just fyi, mriedem is in china this week | 15:14 |
| mdbooth | dansmith: Yeah, I noticed he's been around disturbingly early. | 15:14 |
| mdbooth | Need to be careful what I say about him in the morning ;) | 15:14 |
| * dansmith nods | 15:15 | |
| mdbooth | dansmith: You may also be interested in ^^^ btw | 15:15 |
| dansmith | you may be surprised | 15:15 |
| mdbooth | Hehe | 15:15 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: WIP: Wait for network-vif-plugged before starting live migration https://review.openstack.org/591735 | 15:17 |
| mdbooth | dansmith: Is ^^^ a continuation of the problem originally addressed by sahid's patch? | 15:18 |
| *** ccamacho has quit IRC | 15:19 | |
| dansmith | mdbooth: it's a test backport of a more generic solution that already landed in master, but with a non-backportable rpc change that I don't think we actually needed to make it work | 15:19 |
| dansmith | so I'm floating that to see if it's possible | 15:19 |
| dansmith | since we have to revert his, I'm hoping we can replace it with that | 15:19 |
| mdbooth | Ah, ok. | 15:19 |
| mdbooth | I didn't follow the whole discussion, but I was under the impression that perhaps linux bridge remained a problem? | 15:20 |
| mdbooth | Or are we good there, too? | 15:20 |
| dansmith | we should be good there to as far as all the evidence we've collected shows | 15:20 |
| mdbooth | Cool | 15:20 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Move static _get_power_off_values to compute_utils https://review.openstack.org/578822 | 15:21 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846 | 15:21 |
| dansmith | prometheanfire: yeah the backport of the revert to queens is even worse than the original revert | 15:22 |
| dansmith | to the point that I wonder if it's even worth trying to do a normal backport | 15:23 |
| lyarwood | a normal revert you mean, of the stable/queens patch | 15:24 |
| dansmith | what I mean is, a backport of the revert patch from master and rocky might not be worth it, | 15:25 |
| dansmith | but we could do a straight revert of the queens patch on queens yeah | 15:25 |
| dansmith | lyarwood: do you know of any precedent for that? | 15:25 |
| lyarwood | kk, in the past we've just done a straight revert of the stable changes, not backporting anything from branch to branch | 15:25 |
| dansmith | really? | 15:25 |
| prometheanfire | ya, that's kinda what I was thinking | 15:25 |
| dansmith | I'm confident that we've backported reverts, and that's what mriedem did for stable/rocky | 15:26 |
| prometheanfire | iirc, a clean revert isn't possible either for pike at least | 15:26 |
| *** psachin has joined #openstack-nova | 15:26 | |
| dansmith | but if that's kosher, that's likely way easier | 15:26 |
| lyarwood | dansmith: I assume it was clean? | 15:26 |
| dansmith | which? I haven't tried the direct revert yet | 15:26 |
| lyarwood | dansmith: once things start to conflict the revert backports get awkward | 15:26 |
| dansmith | yup | 15:26 |
| lyarwood | dansmith: the master to rocky revert sorry, and I assume it was as rocky was only just cut | 15:27 |
| dansmith | yeah, I assume it was, matt did it | 15:27 |
| dansmith | lyarwood: so, different change-id for the revert on queens? or force it to be the same so gerrit shows it properly? | 15:28 |
| lyarwood | dansmith: it has to be different doesn't it? | 15:29 |
| *** adrianc has quit IRC | 15:29 | |
| dansmith | no, I can force it to be the same | 15:29 |
| lyarwood | dansmith: I didn't think gerrit allowed the same change-id twice on the same branch | 15:29 |
| *** adrianc has joined #openstack-nova | 15:29 | |
| dansmith | I mean the same change-id as the reverts on master and rocky | 15:29 |
| dansmith | meaning, use that change id on queens too, even though it's not a direct cherry-pick | 15:30 |
| lyarwood | dansmith: ah right, yeah the same change id for the reverts | 15:30 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/591761 | 15:30 |
| dansmith | okay, queens was clean ^ | 15:30 |
| dansmith | as was pike | 15:31 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/pike: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/591762 | 15:32 |
| prometheanfire | nice | 15:33 |
| openstackgerrit | Eric Fried proposed openstack/nova master: [placement] split gigantor SQL query, add logging https://review.openstack.org/591510 | 15:35 |
| *** janki has quit IRC | 15:36 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: [placement] split gigantor SQL query, add logging https://review.openstack.org/590041 | 15:37 |
| *** links has quit IRC | 15:41 | |
| *** Sundar_ has joined #openstack-nova | 15:43 | |
| Sundar_ | efried: Please ping me when you have the time. Thanks. | 15:45 |
| openstackgerrit | xhzhf proposed openstack/nova master: [vmware] add missing os types in vSphere sdk 6.5 https://review.openstack.org/591771 | 15:51 |
| *** itlinux has joined #openstack-nova | 15:54 | |
| efried | Sundar_: Yo, what's up? | 15:54 |
| *** tssurya has quit IRC | 15:54 | |
| *** ccamacho has joined #openstack-nova | 15:56 | |
| Sundar_ | Hi efried, please look at my email to you on merge conflict. | 15:57 |
| efried | Sundar_: Roger that, looking. | 15:57 |
| efried | Sundar_: You probably just need to rebase to master. | 15:57 |
| efried | Sundar_: Right, so I see you tried that, let me see what I can do. | 15:58 |
| *** cdent has quit IRC | 15:58 | |
| *** gyee has joined #openstack-nova | 16:02 | |
| *** pcaruana has quit IRC | 16:02 | |
| efried | Sundar_: What problem did you have rebasing this? It's working out okay for me. | 16:02 |
| efried | Sundar_: Fixed, uploaded PS8 | 16:05 |
| *** sahid has quit IRC | 16:05 | |
| *** rpittau has quit IRC | 16:09 | |
| melwitt | . | 16:11 |
| *** jpena is now known as jpena|off | 16:13 | |
| Sundar_ | Thanks, efried! I explained the problem in the email. | 16:14 |
| efried | Sundar_: I responded to the email. Hopefully I understood the problem correctly. Let me know if PS8 looks correct. | 16:15 |
| efried | Sundar_: Looks like you uploaded a no-op PS9 :) | 16:16 |
| efried | (no op other than to change the committer back to yourself) | 16:16 |
| Sundar_ | efried: Yes. I retried my steps to see where the issue is, and there were no issues. The 'git review' succeeded too. Not sure if the no-op patch is an issue. Should we revert that? | 16:18 |
| sean-k-mooney | Sundar_: your noop patch just changed the commiter field in the reivew. it wont have any real effect | 16:19 |
| efried | Sundar_: Right, leave it as is. | 16:19 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: DNM: Debug patch to test live migration waiting https://review.openstack.org/591775 | 16:19 |
| Sundar_ | sean-k-mooney, efried: Thanks. Hopefully I have included all previous input from both of you and others. But there were tons of them, so I will do another review myself. Please LMK if I missed anything. | 16:20 |
| efried | ack | 16:20 |
| sean-k-mooney | dansmith: regardin the live migration waiting is there any testing i can help with. im currently testing migraitng between different backend / configuration but i have that flag set also | 16:22 |
| dansmith | sean-k-mooney: confirming the new thing works for LB would be great | 16:23 |
| sean-k-mooney | dansmith: lb->lb seams to work fine on master | 16:23 |
| dansmith | as expected, cool | 16:23 |
| sean-k-mooney | well master as of yesterday | 16:23 |
| sean-k-mooney | is there a partcalar patch i should check i have | 16:23 |
| sean-k-mooney | i have the Merge "Revert "libvirt: slow live-migration to ensure network is ready"" patch | 16:25 |
| dansmith | that | 16:25 |
| dansmith | and did you turn on the manager waiter? | 16:25 |
| dansmith | the thing I'm forcing to true in this test patch: https://review.openstack.org/591775 | 16:26 |
| sean-k-mooney | live_migration_wait_for_vif_plug = True | 16:26 |
| dansmith | yep | 16:26 |
| dansmith | cool | 16:26 |
| sean-k-mooney | in the compute section. ya i copied the stuff form the gate job | 16:26 |
| dansmith | sweet | 16:27 |
| dansmith | that's super helpful thanks :) | 16:27 |
| kosamara | sean-k-mooney: I didn't get your affinity/anti-affinity comment. Affinity has meaning per physical device? | 16:27 |
| *** Sundar_ has quit IRC | 16:27 | |
| sean-k-mooney | livemigration between ovs and linux bridge is not workigk. looks like we missed a few thing on the neutron side. im goint to test live migration between host with and without iptable firewall driver next | 16:27 |
| *** s10 has quit IRC | 16:28 | |
| sean-k-mooney | kosamara: in the granualar resouce provider spec we expcitly say if different resouce request groups are allowed to come form teh same resouce provier or may not come form the same resource provider | 16:29 |
| sean-k-mooney | kosamara: this is so we can model affinity or anti afinity for different usecases | 16:29 |
| sean-k-mooney | kosamara: i dont think you have to worry about that in your spec. its more on the consumtion side then whitelisting | 16:30 |
| kosamara | sean-k-mooney: right. The question is between modelling each physical device as an RP vs aggregating inventories with same traits into 1 RP. Does affinity affect this? | 16:30 |
| sean-k-mooney | if each device is a seperate RP we can say i want 2 devices from teh same resouce provider. e.g. 2 dispaly heads from the same gpu | 16:32 |
| sean-k-mooney | well you might be able to i would have to think about it. | 16:33 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove blacklisted py3 xen tests https://review.openstack.org/591419 | 16:34 |
| kosamara | You have a good point there. Also, I don't know if anyone has a use for sound devices, but some GPUs provide 2 pci devices (functions), a VGA and a sound, that can't be given to separate VMs. | 16:34 |
| kosamara | Also relevant for supporting NVlink, which appears as many individual pci devices | 16:35 |
| sean-k-mooney | kosamara: ya i would hope this should effect how we model the config file but will effect how the device are consumed from placement. | 16:36 |
| sean-k-mooney | i mean i could but i guess it comes down to how granular things are | 16:37 |
| kosamara | sean-k-mooney for sure if there is a use case for requesting 2 display heads from the *same physical device*, aggregating would break it. | 16:39 |
| *** ccamacho has quit IRC | 16:39 | |
| sean-k-mooney | kosamara: you also have the inverse. i want to dispaly heads from different devices. which not aggregating make much more complicated :) | 16:40 |
| sean-k-mooney | a better example of the anti afinity is sriov VF for nics. i want to ensure that they comre form 2 differnet phyical cards for HA | 16:42 |
| kosamara | again aggregating would break this | 16:42 |
| sean-k-mooney | not how aggreting is propsed to work the aggreation point for VFs is the PR so one RP per pf and each PF RP would have an inventory of VFs | 16:46 |
| sean-k-mooney | /PR/PF/ | 16:46 |
| mdbooth | melwitt: Incidentally, I'm not actually convinced that adding destroy_disks_on_failure to spawn is right either. We already have a functional entry point to the driver for this case: rebuild. | 16:47 |
| kosamara | aggregating: I meant many PFs -> 1 RP | 16:47 |
| mdbooth | melwitt: Still undecided. | 16:47 |
| sean-k-mooney | kosamara: if the PF have no VF the you can safly aggreate them at the numa node level assume the PF are other wise identical | 16:48 |
| sean-k-mooney | kosamara: anyway we dont need to cover all the edgecases on irc :) | 16:48 |
| kosamara | sean-k-mooney: ok, etherpad :) | 16:49 |
| *** gbarros has quit IRC | 16:51 | |
| melwitt | mdbooth: okay | 16:54 |
| *** udesale has quit IRC | 16:54 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consumer gen: remove_provider_from_instance_allocation https://review.openstack.org/591784 | 16:57 |
| efried | jroll, jaypipes: Can this test be deleted at this point? https://github.com/openstack/nova/blob/61f854ff6445dd7bc797fdde7361e47f3dc3b1bd/nova/tests/functional/compute/test_resource_tracker.py#L215 | 17:02 |
| mdbooth | melwitt: I'm not keen on anything involving task state, though: it's a wild west. It's basically impossible to verify, and almost guaranteed to suffer bitrot. | 17:02 |
| jaypipes | efried: should be able to, yes. | 17:03 |
| jaypipes | efried: double check with mriedem and dansmith | 17:03 |
| efried | jaypipes: ight, will do so via review I guess. | 17:03 |
| jroll | I thought we had a patch out to drop those things | 17:03 |
| mdbooth | I think it's robust to verify task state set vs not set, anything else is asking for trouble. | 17:03 |
| melwitt | mdbooth: yeah. that would only be for the sake of the backport. I agree it's not ideal, but the copying of code from manager to driver is more prone to bitrot IMHO | 17:03 |
| dansmith | efried: I'm sure we can because we don't technically support that mix of versions anyway | 17:03 |
| mdbooth | melwitt: Yeah. I also don't love that. | 17:04 |
| *** derekh has quit IRC | 17:04 | |
| efried | dansmith: ack, proposing... | 17:04 |
| mdbooth | melwitt: I think the behaviour being tested by the regression test, namely relying on instance_on_disk() is ok. | 17:04 |
| mdbooth | The principal being: if we created it, we should clean it up. If we didn't, we shouldn't. | 17:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove obsolete func test_ironic_ocata_to_pike https://review.openstack.org/591785 | 17:05 |
| mdbooth | I think that's moderately robust, although as noted in the comment I think we can also do better with a bit more work. | 17:05 |
| efried | dansmith, jaypipes, jroll, mriedem: ^ | 17:05 |
| *** adrianc has quit IRC | 17:06 | |
| jroll | efried: thanks. you reminded me I need to pick this one back up too https://review.openstack.org/#/c/565841/ | 17:07 |
| jaypipes | efried: terrible code. -3. | 17:07 |
| sean-k-mooney | mriedem: just an FYI livemigratin between an ovs host with ip tables firewall and openvswtich firewall and back appear to work correctly. | 17:07 |
| efried | jroll: I was just looking at that a few minutes ago. | 17:07 |
| sean-k-mooney | mriedem: im going to do a bit more testing but the xml is corerctly updated so i just going to check that the firewall actully works during the live migration | 17:08 |
| jroll | heh | 17:08 |
| * jroll does the thing | 17:08 | |
| *** Swami has joined #openstack-nova | 17:10 | |
| *** Bhujay has quit IRC | 17:22 | |
| *** psachin has quit IRC | 17:22 | |
| mdbooth | dansmith melwitt: Rather than changing rebuild specifically, how about if I changed spawn() in the libvirt driver such that, unconditionally, it only deletes the instance directory if it created it, and it only deletes disks if it created them. | 17:23 |
| *** dpawlik has joined #openstack-nova | 17:24 | |
| mdbooth | spawn() is called by compute manager for: boot, unshelve, rebuild. | 17:24 |
| mdbooth | For the first 2 nothing should exist already, but the current behaviour is to ignore that. | 17:24 |
| mdbooth | So the only case where it might legitimately exist already is rebuild on shared storage. | 17:25 |
| *** dpawlik has quit IRC | 17:29 | |
| *** hongbin has quit IRC | 17:35 | |
| *** gbarros has joined #openstack-nova | 17:37 | |
| sean-k-mooney | mdbooth: for rebuild on shared stroage the disk might exists and the instance directory but we have to recreate teh disk from the new iamage anyway right | 17:37 |
| *** janki has joined #openstack-nova | 17:45 | |
| *** holser_ has quit IRC | 17:45 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: report 0 for vcpus/memory_mb/disk_gb resources https://review.openstack.org/565841 | 17:47 |
| jroll | efried: I think that does it ^ | 17:47 |
| melwitt | mdbooth: my initial thought is, I'm not sure that sounds good for a backport, but rather a possible refactor. I'm not sure what all would be involved there or any gotchas | 17:48 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: DNM: Debug patch to test live migration waiting https://review.openstack.org/591775 | 17:48 |
| *** holser_ has joined #openstack-nova | 17:49 | |
| *** holser_ has quit IRC | 17:49 | |
| *** holser_ has joined #openstack-nova | 17:50 | |
| *** holser_ has quit IRC | 18:01 | |
| *** eharney has quit IRC | 18:12 | |
| *** dtantsur is now known as dtantsur|afk | 18:15 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consumer gen support for put allocations https://review.openstack.org/591647 | 18:15 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consumer gen: remove_provider_from_instance_allocation https://review.openstack.org/591784 | 18:16 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: support claim_resources https://review.openstack.org/583667 | 18:16 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: move_allocations https://review.openstack.org/591810 | 18:16 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: more tests for delete allocation cases https://review.openstack.org/591811 | 18:16 |
| openstackgerrit | Merged openstack/nova stable/rocky: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/591275 | 18:19 |
| *** hemna_ has joined #openstack-nova | 18:35 | |
| efried | jroll: Soft -1 on the reno (as well as pep8) | 18:36 |
| *** sapd1 has quit IRC | 18:38 | |
| jroll | ughhhhhhh | 18:41 |
| jroll | thanks efried | 18:43 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: report 0 for vcpus/memory_mb/disk_gb resources https://review.openstack.org/565841 | 18:44 |
| efried | much clearer, thanks jroll | 18:51 |
| jroll | :) | 18:51 |
| *** eharney has joined #openstack-nova | 19:17 | |
| *** jaosorior has quit IRC | 19:45 | |
| *** cdent has joined #openstack-nova | 19:53 | |
| *** jaosorior has joined #openstack-nova | 19:58 | |
| *** awaugama has quit IRC | 20:07 | |
| *** slaweq_ has quit IRC | 20:09 | |
| *** slaweq_ has joined #openstack-nova | 20:11 | |
| *** gbarros has quit IRC | 20:11 | |
| *** slaweq_ has quit IRC | 20:15 | |
| cfriesen | maybe odd question, but if I boot an instance from a flavor with trait:HW_CPU_X86_AVX2=required, the exact CPU model chosen seems to depend on the nova-compute config. Suppose I then try to live-migrate...I'm guaranteed that the dest node will support AVX2, but Is there somewhere that we verify that the dest node can support the same CPU model as is currently being used by the running VM? | 20:19 |
| *** gbarros has joined #openstack-nova | 20:21 | |
| cfriesen | never mind, found the code. the scheduler filters don't check, but check_can_live_migrate_destination() should catch it. | 20:31 |
| *** slaweq_ has joined #openstack-nova | 20:32 | |
| *** slaweq_ has quit IRC | 20:36 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: DNM: test possible deadlock cause https://review.openstack.org/591845 | 20:42 |
| *** hemna_ has quit IRC | 20:47 | |
| *** gbarros has quit IRC | 20:56 | |
| *** jaosorior has quit IRC | 20:56 | |
| *** hemna_ has joined #openstack-nova | 20:56 | |
| *** slaweq_ has joined #openstack-nova | 21:11 | |
| *** slaweq_ has quit IRC | 21:15 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Add explanatory prefix to post_test_perf output https://review.openstack.org/591850 | 21:15 |
| openstackgerrit | Chris Dent proposed openstack/nova master: DNM: test possible deadlock cause https://review.openstack.org/591845 | 21:19 |
| efried | cdent: Love it. | 21:21 |
| * cdent is glad | 21:21 | |
| cdent | I suppose once we've all memorized those words we can read right over them | 21:22 |
| *** slagle has quit IRC | 21:23 | |
| efried | cdent: One concern is tying that behavior to a specific version of placeload. | 21:25 |
| efried | Perhaps a TODO to vet that periodically. | 21:25 |
| cdent | but where will we put the todo to remind us to look for todos? | 21:26 |
| openstackgerrit | Dmitry Sutyagin proposed openstack/nova master: Implement disabling KSM via flavor's extra specs https://review.openstack.org/591854 | 21:27 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM: update_provider_tree() (compatible) https://review.openstack.org/468560 | 21:30 |
| efried | edmondsw, jaypipes: ^ | 21:30 |
| *** s10 has joined #openstack-nova | 21:30 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: report 0 for vcpus/memory_mb/disk_gb resources https://review.openstack.org/565841 | 21:32 |
| *** slaweq_ has joined #openstack-nova | 21:32 | |
| jroll | efried: jaypipes: ^ had a syntax error in release note :( | 21:32 |
| efried | jroll: Wish somebody had been paying attention to your release note | 21:33 |
| jroll | heh | 21:33 |
| jroll | I did your suggestion too :) | 21:33 |
| efried | d'oh, I should have caught that. | 21:33 |
| efried | thanks. | 21:33 |
| efried | jroll: +A | 21:34 |
| jroll | thanks | 21:35 |
| *** slaweq_ has quit IRC | 21:36 | |
| *** slaweq_ has joined #openstack-nova | 21:53 | |
| *** itlinux has quit IRC | 21:54 | |
| *** slaweq_ has quit IRC | 21:57 | |
| *** cdent has quit IRC | 21:59 | |
| *** janki has quit IRC | 22:01 | |
| *** slaweq_ has joined #openstack-nova | 22:11 | |
| *** slaweq_ has quit IRC | 22:15 | |
| *** burt has quit IRC | 22:19 | |
| *** erlon has quit IRC | 22:21 | |
| *** s10 has quit IRC | 22:23 | |
| *** s10 has joined #openstack-nova | 22:23 | |
| *** s10 has quit IRC | 22:24 | |
| *** s10 has joined #openstack-nova | 22:24 | |
| *** s10 has quit IRC | 22:24 | |
| *** s10 has joined #openstack-nova | 22:25 | |
| *** s10 has quit IRC | 22:25 | |
| *** s10 has joined #openstack-nova | 22:26 | |
| *** s10 has quit IRC | 22:26 | |
| *** s10 has joined #openstack-nova | 22:26 | |
| *** s10 has quit IRC | 22:27 | |
| *** slaweq_ has joined #openstack-nova | 22:32 | |
| melwitt | mriedem: fyi added a question to the RC todos etherpad about translations | 22:35 |
| *** slaweq_ has quit IRC | 22:36 | |
| *** imacdonn has quit IRC | 22:38 | |
| *** imacdonn has joined #openstack-nova | 22:38 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Regex consts for placement schema https://review.openstack.org/591863 | 22:40 |
| *** slaweq_ has joined #openstack-nova | 22:53 | |
| *** _ix has quit IRC | 22:57 | |
| *** slaweq_ has quit IRC | 22:57 | |
| *** mvkr has joined #openstack-nova | 23:05 | |
| *** slaweq_ has joined #openstack-nova | 23:32 | |
| *** slaweq_ has quit IRC | 23:36 | |
| *** Swami has quit IRC | 23:45 | |
| *** slaweq_ has joined #openstack-nova | 23:53 | |
| *** slaweq_ has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!