| *** shaohe_feng has joined #openstack-nova | 00:01 | |
| *** jangutter has joined #openstack-nova | 00:03 | |
| *** rcernin has joined #openstack-nova | 00:03 | |
| *** medberry has quit IRC | 00:06 | |
| *** shaohe_feng has quit IRC | 00:09 | |
| *** shaohe_feng has joined #openstack-nova | 00:10 | |
| *** wolverineav has joined #openstack-nova | 00:17 | |
| *** itlinux has quit IRC | 00:17 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Making consistent used of GiB and MiB in API ref https://review.openstack.org/559985 | 00:19 |
|---|---|---|
| *** shaohe_feng has quit IRC | 00:20 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 00:20 |
| *** wolverineav has quit IRC | 00:21 | |
| *** shaohe_feng has joined #openstack-nova | 00:22 | |
| *** lyan has joined #openstack-nova | 00:28 | |
| *** lyan is now known as Guest25520 | 00:29 | |
| *** shaohe_feng has quit IRC | 00:30 | |
| *** shaohe_feng has joined #openstack-nova | 00:31 | |
| *** owalsh_ is now known as owalsh | 00:32 | |
| *** hamzy has joined #openstack-nova | 00:38 | |
| *** shaohe_feng has quit IRC | 00:40 | |
| *** shaohe_feng has joined #openstack-nova | 00:41 | |
| *** shaohe_feng has quit IRC | 00:50 | |
| *** shaohe_feng has joined #openstack-nova | 00:51 | |
| *** Guest7854 has joined #openstack-nova | 00:55 | |
| Guest7854 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 00:55 |
| Guest7854 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 00:55 |
| *** Guest7854 has quit IRC | 00:55 | |
| *** namnh has joined #openstack-nova | 00:56 | |
| *** cdent has joined #openstack-nova | 00:58 | |
| *** shaohe_feng has quit IRC | 01:01 | |
| *** namnh has quit IRC | 01:01 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Extract base functional test case from test_direct https://review.openstack.org/585777 | 01:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use base test in placement functional tests https://review.openstack.org/585778 | 01:01 |
| *** phuongnh has joined #openstack-nova | 01:02 | |
| *** shaohe_feng has joined #openstack-nova | 01:03 | |
| *** cdent has quit IRC | 01:08 | |
| *** gyee has quit IRC | 01:08 | |
| *** BrinZhang has joined #openstack-nova | 01:09 | |
| *** shaohe_feng has quit IRC | 01:11 | |
| openstackgerrit | Merged openstack/nova master: Remove support for /os-floating-ips-bulk REST API https://review.openstack.org/582912 | 01:11 |
| *** shaohe_feng has joined #openstack-nova | 01:13 | |
| *** aOssed15 has joined #openstack-nova | 01:13 | |
| aOssed15 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 01:13 |
| *** aOssed15 has quit IRC | 01:13 | |
| *** annp has quit IRC | 01:13 | |
| *** trungnv has quit IRC | 01:13 | |
| *** mrsoul` has joined #openstack-nova | 01:13 | |
| *** trungnv has joined #openstack-nova | 01:13 | |
| openstackgerrit | Merged openstack/nova master: Remove support for /os-floating-ip-dns REST API https://review.openstack.org/582943 | 01:14 |
| *** annp has joined #openstack-nova | 01:14 | |
| openstackgerrit | Merged openstack/nova master: Remove "DEPRECATED" tag from Obsolete APIs https://review.openstack.org/583092 | 01:14 |
| openstackgerrit | Merged openstack/nova stable/pike: cleanup mapping/reqspec after archive instance https://review.openstack.org/580775 | 01:14 |
| openstackgerrit | Merged openstack/nova master: doc: remove rocky-specific nova-scheduler min placement version https://review.openstack.org/585520 | 01:14 |
| *** mrsoul has quit IRC | 01:16 | |
| *** hongbin has joined #openstack-nova | 01:16 | |
| *** edmondsw has joined #openstack-nova | 01:17 | |
| *** dtruong_ has quit IRC | 01:20 | |
| *** yamahata has quit IRC | 01:20 | |
| *** shaohe_feng has quit IRC | 01:21 | |
| *** edmondsw has quit IRC | 01:21 | |
| *** shaohe_feng has joined #openstack-nova | 01:22 | |
| *** bast-anon12 has joined #openstack-nova | 01:23 | |
| bast-anon12 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 01:23 |
| bast-anon12 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 01:23 |
| *** bast-anon12 has quit IRC | 01:23 | |
| *** tiendc has joined #openstack-nova | 01:26 | |
| *** wolverineav has joined #openstack-nova | 01:31 | |
| *** shaohe_feng has quit IRC | 01:31 | |
| *** shaohe_feng has joined #openstack-nova | 01:32 | |
| *** wolverineav has quit IRC | 01:35 | |
| *** shaohe_feng has quit IRC | 01:42 | |
| *** markvoelker has joined #openstack-nova | 01:43 | |
| *** markvoelker_ has quit IRC | 01:44 | |
| *** shaohe_feng has joined #openstack-nova | 01:45 | |
| *** markvoelker_ has joined #openstack-nova | 01:46 | |
| *** tbachman has quit IRC | 01:46 | |
| *** namnh has joined #openstack-nova | 01:47 | |
| *** markvoelker has quit IRC | 01:48 | |
| *** namnh has quit IRC | 01:50 | |
| *** namnh has joined #openstack-nova | 01:50 | |
| *** namnh has quit IRC | 01:52 | |
| *** shaohe_feng has quit IRC | 01:52 | |
| *** shaohe_feng has joined #openstack-nova | 01:53 | |
| *** shaohe_feng has quit IRC | 02:02 | |
| *** shaohe_feng has joined #openstack-nova | 02:03 | |
| naichuans | Txt files which store openstack IRC history reported as trojan and deleted by McAFee, anyone meet such kind of issues before? | 02:06 |
| *** wolverineav has joined #openstack-nova | 02:06 | |
| *** wolverineav has quit IRC | 02:11 | |
| *** shaohe_feng has quit IRC | 02:12 | |
| *** shaohe_feng has joined #openstack-nova | 02:13 | |
| *** armaan has quit IRC | 02:13 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM? Extra logs for volume detach device tags cleanup https://review.openstack.org/584032 | 02:16 |
| openstackgerrit | Xiaohan Zhang proposed openstack/nova master: compute node local_gb_used include swap disks The ComputeNode.local_gb_used value is set in the ResourceTracker._update_usage() method: https://review.openstack.org/585928 | 02:18 |
| *** Dinesh_Bhor has joined #openstack-nova | 02:19 | |
| *** shaohe_feng has quit IRC | 02:23 | |
| *** pathfinder6 has joined #openstack-nova | 02:23 | |
| *** ensyde6 has joined #openstack-nova | 02:23 | |
| ensyde6 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 02:23 |
| ensyde6 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 02:23 |
| *** ensyde6 has quit IRC | 02:23 | |
| pathfinder6 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 02:23 |
| *** pathfinder6 has quit IRC | 02:23 | |
| *** artom has quit IRC | 02:25 | |
| *** shaohe_feng has joined #openstack-nova | 02:25 | |
| *** gongysh has joined #openstack-nova | 02:27 | |
| *** sapd has joined #openstack-nova | 02:28 | |
| *** lei-zh has joined #openstack-nova | 02:29 | |
| *** tbachman has joined #openstack-nova | 02:31 | |
| *** shaohe_feng has quit IRC | 02:33 | |
| *** shaohe_feng has joined #openstack-nova | 02:37 | |
| *** shaohe_feng has quit IRC | 02:43 | |
| *** shaohe_feng has joined #openstack-nova | 02:44 | |
| *** openstack has joined #openstack-nova | 02:49 | |
| *** ChanServ sets mode: +o openstack | 02:49 | |
| *** tbachman has quit IRC | 02:51 | |
| *** shaohe_feng has quit IRC | 02:53 | |
| *** hongbin has quit IRC | 02:56 | |
| *** shaohe_feng has joined #openstack-nova | 02:56 | |
| *** vladikr has quit IRC | 02:57 | |
| *** vladikr has joined #openstack-nova | 02:57 | |
| *** dave-mcc_ has quit IRC | 03:02 | |
| *** shaohe_feng has quit IRC | 03:04 | |
| *** edmondsw has joined #openstack-nova | 03:05 | |
| *** shaohe_feng has joined #openstack-nova | 03:05 | |
| *** jmlowe has joined #openstack-nova | 03:06 | |
| *** yamahata has joined #openstack-nova | 03:08 | |
| *** edmondsw has quit IRC | 03:09 | |
| *** jmlowe has quit IRC | 03:13 | |
| *** shaohe_feng has quit IRC | 03:14 | |
| *** edleafe has quit IRC | 03:14 | |
| *** edleafe has joined #openstack-nova | 03:16 | |
| *** shaohe_feng has joined #openstack-nova | 03:17 | |
| *** mriedem_afk has quit IRC | 03:20 | |
| *** shaohe_feng has quit IRC | 03:24 | |
| *** shaohe_feng has joined #openstack-nova | 03:25 | |
| *** Sukhdev has joined #openstack-nova | 03:27 | |
| *** lei-zh has quit IRC | 03:28 | |
| *** shaohe_feng has quit IRC | 03:34 | |
| *** shaohe_feng has joined #openstack-nova | 03:35 | |
| *** shaohe_feng has quit IRC | 03:45 | |
| *** shaohe_feng has joined #openstack-nova | 03:45 | |
| *** udesale has joined #openstack-nova | 03:48 | |
| *** slaweq has quit IRC | 03:50 | |
| *** Guest25520 has quit IRC | 03:52 | |
| *** lpetrut has joined #openstack-nova | 03:53 | |
| *** shaohe_feng has quit IRC | 03:55 | |
| *** shaohe_feng has joined #openstack-nova | 03:56 | |
| *** slaweq has joined #openstack-nova | 03:58 | |
| *** itlinux has joined #openstack-nova | 03:58 | |
| *** lpetrut has quit IRC | 04:03 | |
| *** shaohe_feng has quit IRC | 04:05 | |
| *** mschuppert has joined #openstack-nova | 04:05 | |
| *** dtruong_ has joined #openstack-nova | 04:06 | |
| *** Dinesh_Bhor has quit IRC | 04:06 | |
| *** wolverineav has joined #openstack-nova | 04:07 | |
| *** shaohe_feng has joined #openstack-nova | 04:07 | |
| *** janki has joined #openstack-nova | 04:11 | |
| *** itlinux has quit IRC | 04:11 | |
| *** wolverineav has quit IRC | 04:12 | |
| *** psachin`` has joined #openstack-nova | 04:14 | |
| *** shaohe_feng has quit IRC | 04:15 | |
| *** shaohe_feng has joined #openstack-nova | 04:16 | |
| *** mdnadeem has joined #openstack-nova | 04:17 | |
| *** vladikr has quit IRC | 04:17 | |
| *** vladikr has joined #openstack-nova | 04:18 | |
| *** shaohe_feng has quit IRC | 04:26 | |
| *** shaohe_feng has joined #openstack-nova | 04:27 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:33 | |
| *** shaohe_feng has quit IRC | 04:36 | |
| *** shaohe_feng has joined #openstack-nova | 04:37 | |
| *** fpinna has joined #openstack-nova | 04:37 | |
| *** gongysh has quit IRC | 04:38 | |
| *** fpinna has left #openstack-nova | 04:39 | |
| *** fpinna has joined #openstack-nova | 04:42 | |
| *** bladernr28 has joined #openstack-nova | 04:43 | |
| bladernr28 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 04:43 |
| *** bladernr28 has quit IRC | 04:43 | |
| *** Sukhdev has quit IRC | 04:44 | |
| *** vishakha has quit IRC | 04:45 | |
| *** shaohe_feng has quit IRC | 04:46 | |
| *** gongysh has joined #openstack-nova | 04:46 | |
| *** Sukhdev has joined #openstack-nova | 04:47 | |
| *** fpinna has quit IRC | 04:47 | |
| *** shaohe_feng has joined #openstack-nova | 04:47 | |
| *** spsurya_ has quit IRC | 04:48 | |
| *** spsurya_ has joined #openstack-nova | 04:49 | |
| *** edmondsw has joined #openstack-nova | 04:53 | |
| *** gongysh has quit IRC | 04:54 | |
| *** gbarros has joined #openstack-nova | 04:55 | |
| *** shaohe_feng has quit IRC | 04:56 | |
| *** armaan has joined #openstack-nova | 04:57 | |
| *** edmondsw has quit IRC | 04:58 | |
| *** shaohe_feng has joined #openstack-nova | 05:00 | |
| *** armaan has quit IRC | 05:01 | |
| *** tbachman has joined #openstack-nova | 05:01 | |
| *** lynxis27 has joined #openstack-nova | 05:03 | |
| lynxis27 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 05:03 |
| *** lynxis27 has quit IRC | 05:03 | |
| *** tbachman has quit IRC | 05:06 | |
| *** Tahvok has quit IRC | 05:06 | |
| *** shaohe_feng has quit IRC | 05:07 | |
| *** spsurya_ is now known as spsurya | 05:07 | |
| *** shaohe_feng has joined #openstack-nova | 05:08 | |
| *** Tahvok has joined #openstack-nova | 05:10 | |
| *** tbachman has joined #openstack-nova | 05:13 | |
| *** shaohe_feng has quit IRC | 05:17 | |
| *** abhishekk has joined #openstack-nova | 05:17 | |
| *** shaohe_feng has joined #openstack-nova | 05:18 | |
| *** gbarros has quit IRC | 05:18 | |
| *** gongysh has joined #openstack-nova | 05:24 | |
| *** shaohe_feng has quit IRC | 05:27 | |
| *** lei-zh has joined #openstack-nova | 05:30 | |
| *** shaohe_feng has joined #openstack-nova | 05:30 | |
| *** ratailor has joined #openstack-nova | 05:30 | |
| *** Sukhdev has quit IRC | 05:31 | |
| *** shaohe_feng has quit IRC | 05:37 | |
| *** gongysh has quit IRC | 05:38 | |
| *** shaohe_feng has joined #openstack-nova | 05:38 | |
| *** tbachman has quit IRC | 05:42 | |
| *** spot18 has joined #openstack-nova | 05:43 | |
| spot18 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 05:43 |
| *** spot18 has quit IRC | 05:43 | |
| *** ratailor_ has joined #openstack-nova | 05:47 | |
| *** shaohe_feng has quit IRC | 05:48 | |
| *** shaohe_feng has joined #openstack-nova | 05:48 | |
| *** links has joined #openstack-nova | 05:48 | |
| *** flwang1 has quit IRC | 05:50 | |
| *** ratailor has quit IRC | 05:50 | |
| *** dklyle has quit IRC | 05:52 | |
| *** dklyle has joined #openstack-nova | 05:53 | |
| *** itlinux has joined #openstack-nova | 05:57 | |
| *** sridharg has joined #openstack-nova | 05:58 | |
| *** shaohe_feng has quit IRC | 05:58 | |
| *** shaohe_feng has joined #openstack-nova | 05:59 | |
| *** Luzi has joined #openstack-nova | 06:04 | |
| *** udesale has quit IRC | 06:04 | |
| *** udesale has joined #openstack-nova | 06:04 | |
| *** wolverineav has joined #openstack-nova | 06:08 | |
| *** shaohe_feng has quit IRC | 06:08 | |
| *** itlinux has quit IRC | 06:08 | |
| *** shaohe_feng has joined #openstack-nova | 06:09 | |
| *** wolverineav has quit IRC | 06:12 | |
| *** shaohe_feng has quit IRC | 06:18 | |
| *** shaohe_feng has joined #openstack-nova | 06:20 | |
| *** Eran_Kuris has joined #openstack-nova | 06:22 | |
| openstackgerrit | huanhongda proposed openstack/nova master: hypervisor-stats shows wrong disk usages with shared storage https://review.openstack.org/149878 | 06:22 |
| *** shaohe_feng has quit IRC | 06:29 | |
| *** shaohe_feng has joined #openstack-nova | 06:30 | |
| *** Dinesh_Bhor has quit IRC | 06:35 | |
| *** flwang1 has joined #openstack-nova | 06:36 | |
| *** shaohe_feng has quit IRC | 06:39 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:39 | |
| *** mgoddard has joined #openstack-nova | 06:41 | |
| *** edmondsw has joined #openstack-nova | 06:41 | |
| *** shaohe_feng has joined #openstack-nova | 06:42 | |
| *** maciejjozefczyk1 has left #openstack-nova | 06:42 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:43 | |
| *** ratailor_ has quit IRC | 06:43 | |
| *** ratailor_ has joined #openstack-nova | 06:44 | |
| *** edmondsw has quit IRC | 06:47 | |
| *** vladikr has quit IRC | 06:48 | |
| *** flwang1 has quit IRC | 06:49 | |
| *** shaohe_feng has quit IRC | 06:49 | |
| *** vladikr has joined #openstack-nova | 06:49 | |
| *** mgoddard has quit IRC | 06:50 | |
| *** shaohe_feng has joined #openstack-nova | 06:51 | |
| *** damien_r has quit IRC | 06:56 | |
| *** hoonetorg has quit IRC | 06:57 | |
| *** damien_r has joined #openstack-nova | 06:59 | |
| *** shaohe_feng has quit IRC | 06:59 | |
| *** shaohe_feng has joined #openstack-nova | 07:01 | |
| *** Jovan17 has joined #openstack-nova | 07:03 | |
| Jovan17 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 07:03 |
| Jovan17 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 07:03 |
| *** Jovan17 has quit IRC | 07:03 | |
| *** ispp has joined #openstack-nova | 07:06 | |
| *** shaohe_feng has quit IRC | 07:10 | |
| *** ttsiouts has joined #openstack-nova | 07:10 | |
| *** flwang1 has joined #openstack-nova | 07:10 | |
| *** liuzz has joined #openstack-nova | 07:11 | |
| *** tssurya has joined #openstack-nova | 07:12 | |
| karimull | Hello , do the code freeze for the release applies to bugs related to documentation? | 07:12 |
| *** gongysh has joined #openstack-nova | 07:12 | |
| *** shaohe_feng has joined #openstack-nova | 07:12 | |
| *** Pugabyte4 has joined #openstack-nova | 07:13 | |
| Pugabyte4 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 07:13 |
| Pugabyte4 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 07:13 |
| *** Pugabyte4 has quit IRC | 07:13 | |
| *** hoonetorg has joined #openstack-nova | 07:13 | |
| *** flwang1 has quit IRC | 07:17 | |
| *** flwang1 has joined #openstack-nova | 07:17 | |
| *** shaohe_feng has quit IRC | 07:20 | |
| *** shaohe_feng has joined #openstack-nova | 07:21 | |
| openstackgerrit | Xiaohan Zhang proposed openstack/nova master: compute node local_gb_used include swap disks https://review.openstack.org/585928 | 07:22 |
| *** Dinesh_Bhor has quit IRC | 07:22 | |
| *** slaweq has quit IRC | 07:23 | |
| *** vladikr has quit IRC | 07:23 | |
| *** slaweq has joined #openstack-nova | 07:23 | |
| *** vishakha has joined #openstack-nova | 07:25 | |
| *** pcaruana has joined #openstack-nova | 07:25 | |
| *** vladikr has joined #openstack-nova | 07:26 | |
| *** ccamacho has joined #openstack-nova | 07:27 | |
| *** shaohe_feng has quit IRC | 07:30 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Increase sleep time in ServerGroupTestV21 to avoid potential failure https://review.openstack.org/585978 | 07:31 |
| *** mgoddard has joined #openstack-nova | 07:31 | |
| *** shaohe_feng has joined #openstack-nova | 07:31 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:32 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:33 | |
| *** ttsiouts has quit IRC | 07:33 | |
| *** ispp has quit IRC | 07:40 | |
| *** shaohe_feng has quit IRC | 07:40 | |
| *** shaohe_feng has joined #openstack-nova | 07:42 | |
| *** phoe16 has joined #openstack-nova | 07:44 | |
| *** brault has joined #openstack-nova | 07:44 | |
| phoe16 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 07:44 |
| *** phoe16 has quit IRC | 07:44 | |
| *** dtantsur|afk is now known as dtantsur | 07:46 | |
| *** alexchadin has joined #openstack-nova | 07:48 | |
| *** shaohe_feng has quit IRC | 07:51 | |
| *** shaohe_feng has joined #openstack-nova | 07:52 | |
| openstackgerrit | Merged openstack/nova master: Online data migration for queued_for_delete flag https://review.openstack.org/584504 | 07:52 |
| openstackgerrit | Merged openstack/nova master: Annotate flows and handle PortBindingDeletionFailed in ComputeManager https://review.openstack.org/551371 | 07:53 |
| openstackgerrit | Merged openstack/nova master: Remove stevedore extensions server_create method https://review.openstack.org/583882 | 07:53 |
| *** FiendKing04 has joined #openstack-nova | 07:54 | |
| FiendKing04 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 07:54 |
| *** FiendKing04 has quit IRC | 07:54 | |
| *** avolkov has joined #openstack-nova | 07:56 | |
| *** qassim24 has joined #openstack-nova | 07:58 | |
| qassim24 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 07:58 |
| qassim24 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 07:58 |
| *** qassim24 has quit IRC | 07:58 | |
| *** flwang1 has quit IRC | 07:58 | |
| kashyap | ttx: Morning, do you have mod privileges on this channel? If so, can you kick the above spammers out, please? | 07:59 |
| *** shaohe_feng has quit IRC | 08:01 | |
| *** shaohe_feng has joined #openstack-nova | 08:02 | |
| lyarwood | kashyap: They are being kicked pretty quickly already | 08:02 |
| kashyap | lyarwood: Nod; some channels like Freenode's #kvm are still litterred with them :-( | 08:03 |
| kashyap | lyarwood: But you're right, the Freenode Team is working on it | 08:03 |
| kashyap | lyarwood: Morning, do you have a minute to look at something here? | 08:04 |
| kashyap | lyarwood: It's seemingly embarssing PEP8 failure | 08:04 |
| lyarwood | my forte | 08:04 |
| kashyap | lyarwood: Hehe, so here we go: | 08:04 |
| kashyap | On this line here: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/guest.py#L668 | 08:04 |
| kashyap | If I remove that: "# noqa" | 08:04 |
| *** alexchad_ has joined #openstack-nova | 08:05 | |
| kashyap | I get this: ./nova/virt/libvirt/guest.py:665:60: F821 undefined name 'unicode' | 08:05 |
| kashyap | How is the comment "solving" it? | 08:05 |
| *** ispp has joined #openstack-nova | 08:05 | |
| kashyap | lyarwood: It (that "# noqa") came in via this commit that was trying to fix the PEP8 on Py3 failures: a91af59f | 08:06 |
| lyarwood | http://pep8.readthedocs.io/en/release-1.7.x/intro.html#error-codes - it's not a comment | 08:06 |
| kashyap | lyarwood: Sorry for baiting you in the morning. If you're still making coffee or something, please go on. This can wait. | 08:06 |
| lyarwood | ^ search for noqa | 08:06 |
| * kashyap clicks | 08:06 | |
| kashyap | lyarwood: Most excellent, thanks for the (non-null) pointer! | 08:07 |
| *** alexchadin has quit IRC | 08:07 | |
| lyarwood | kashyap: so unicode isn't a keyword in py3 but is in py2 | 08:08 |
| kashyap | lyarwood: Ha! So we indeed need to retain that "# noqa" | 08:08 |
| lyarwood | yup | 08:08 |
| kashyap | lyarwood: Thanks, I was going a bit mental right in the morning | 08:09 |
| *** wolverineav has joined #openstack-nova | 08:09 | |
| kashyap | mdbooth: When you are about, per above discussion with lyarwood, we can't "undent" the "# noqa" here: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/guest.py#L668 | 08:09 |
| *** ttsiouts has joined #openstack-nova | 08:10 | |
| *** shaohe_feng has quit IRC | 08:11 | |
| lyarwood | kashyap: well you can, the #noqa is just to catch the unicode issue | 08:11 |
| *** avolkov has quit IRC | 08:11 | |
| *** shaohe_feng has joined #openstack-nova | 08:12 | |
| lyarwood | anyway /me goes back to downstream paper work | 08:12 |
| kashyap | lyarwood: Alright, I'll look into it. | 08:12 |
| kashyap | mdbooth: Disregard the above for now; more to come soon in the review | 08:12 |
| *** wolverineav has quit IRC | 08:13 | |
| *** Bhujay has joined #openstack-nova | 08:14 | |
| *** armaan has joined #openstack-nova | 08:19 | |
| *** shaohe_feng has quit IRC | 08:21 | |
| *** shaohe_feng has joined #openstack-nova | 08:22 | |
| bauzas | re: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/guest.py#L668 | 08:29 |
| bauzas | kashyap: lyarwood: ^ | 08:29 |
| *** edmondsw has joined #openstack-nova | 08:30 | |
| bauzas | kashyap: lyarwood: there is a six method for it | 08:30 |
| kashyap | bauzas: I see | 08:30 |
| kashyap | bauzas: Got a link? | 08:30 |
| *** tetsuro has quit IRC | 08:31 | |
| bauzas | kashyap: https://pythonhosted.org/six/#six.text_type | 08:31 |
| *** shaohe_feng has quit IRC | 08:32 | |
| * kashyap clicks | 08:32 | |
| *** shaohe_feng has joined #openstack-nova | 08:32 | |
| *** spot18 has joined #openstack-nova | 08:33 | |
| spot18 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 08:33 |
| *** spot18 has quit IRC | 08:33 | |
| *** edmondsw has quit IRC | 08:34 | |
| bauzas | kashyap: http://paste.openstack.org/show/726668/ | 08:35 |
| * kashyap clicks | 08:35 | |
| bauzas | a 'kéké' in French is a 'lad' | 08:36 |
| *** Bhujay has quit IRC | 08:37 | |
| *** Dinesh_Bhor has quit IRC | 08:37 | |
| *** Bhujay has joined #openstack-nova | 08:37 | |
| bauzas | kashyap: of course a bytestring is not unicode | 08:38 |
| kashyap | Hehe | 08:38 |
| kashyap | bauzas: Thanks! | 08:40 |
| *** shaohe_feng has quit IRC | 08:42 | |
| *** tesseract has joined #openstack-nova | 08:42 | |
| bauzas | kashyap: final explanation between bytestrings and unicode strings : http://paste.openstack.org/show/726669/ | 08:43 |
| bauzas | using .decode() will translate it into unicode with the encoding you want | 08:43 |
| *** vladikr has quit IRC | 08:43 | |
| *** derekh has joined #openstack-nova | 08:43 | |
| *** vladikr has joined #openstack-nova | 08:44 | |
| *** udesale_ has joined #openstack-nova | 08:44 | |
| *** janki has quit IRC | 08:45 | |
| *** shaohe_feng has joined #openstack-nova | 08:46 | |
| *** udesale has quit IRC | 08:46 | |
| *** as1 has joined #openstack-nova | 08:48 | |
| *** as1 has quit IRC | 08:48 | |
| *** namnh has joined #openstack-nova | 08:49 | |
| *** shaohe_feng has quit IRC | 08:52 | |
| *** shaohe_feng has joined #openstack-nova | 08:53 | |
| *** liuyulong_ has joined #openstack-nova | 08:53 | |
| *** cdent has joined #openstack-nova | 08:54 | |
| kashyap | Nod | 08:56 |
| *** liuyulong__ has quit IRC | 08:57 | |
| *** sambetts|afk has quit IRC | 08:57 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:59 | |
| *** alexchadin has joined #openstack-nova | 08:59 | |
| *** sambetts_ has joined #openstack-nova | 08:59 | |
| *** alexchad_ has quit IRC | 09:01 | |
| *** dtruong_ has quit IRC | 09:02 | |
| mdbooth | kashyap: That's barely worthy of discussion :) Did I call it a nit? If not, I should have done. | 09:02 |
| *** shaohe_feng has quit IRC | 09:02 | |
| *** brynjar24 has joined #openstack-nova | 09:03 | |
| brynjar24 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 09:03 |
| brynjar24 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 09:03 |
| *** brynjar24 has quit IRC | 09:03 | |
| *** sean-k-mooney has joined #openstack-nova | 09:03 | |
| *** RichiH23 has joined #openstack-nova | 09:03 | |
| RichiH23 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 09:03 |
| RichiH23 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 09:03 |
| *** RichiH23 has quit IRC | 09:03 | |
| kashyap | mdbooth: Hehe, I just make sure every point a reviewer raises is addressed, and not coldly ignore :P | 09:06 |
| kashyap | Address, if it makes sense, i.e. | 09:07 |
| mdbooth | kashyap: Yeah. I couldn't even tell, by eyeball, if the line was short enough. | 09:07 |
| mdbooth | But I thought it probably was. | 09:07 |
| *** shaohe_feng has joined #openstack-nova | 09:08 | |
| kashyap | mdbooth: Ah, by "undent", I actually thought you wanted me to use a different way than the "# noqa" special comment | 09:08 |
| kashyap | Look for "# noqa" there: http://pep8.readthedocs.io/en/release-1.7.x/intro.html#error-codes | 09:09 |
| mdbooth | I assumed it was there for line length? | 09:09 |
| mdbooth | That's how it's normally used. | 09:09 |
| kashyap | The line was 74 lines. | 09:10 |
| kashyap | Err | 09:10 |
| kashyap | 74 chars | 09:10 |
| kashyap | So, it's within the range, though. | 09:10 |
| * kashyap bbiab | 09:10 | |
| mdbooth | Weird. Wonder what the pep8 issue was. | 09:10 |
| *** ispp has quit IRC | 09:10 | |
| kashyap | mdbooth: PEP8 issue was due me not knowing about the special comment "# noqa" (& accidentally removing it) | 09:12 |
| *** shaohe_feng has quit IRC | 09:13 | |
| *** shaohe_feng has joined #openstack-nova | 09:14 | |
| lyarwood | mdbooth: unicode is only used in py2, pep8 now runs under py3 by default and without #noqa that fails, bauzas pointed to a six method to handle this better above. | 09:15 |
| *** namnh has quit IRC | 09:16 | |
| bauzas | lyarwood: mdbooth: tbh, we don't need to check the python version | 09:16 |
| lyarwood | yup, just use six | 09:17 |
| *** fanzhang has quit IRC | 09:17 | |
| *** fanzhang has joined #openstack-nova | 09:17 | |
| mdbooth | bauzas: We do need the python version check there, I think. | 09:18 |
| bauzas | mdbooth: the problem is that libvirtd is only py2 right? | 09:18 |
| mdbooth | bauzas: No, it's both. The problem is that it handles strings differently in py2 and py3. | 09:19 |
| bauzas | mdbooth: so it's waiting for a byte string | 09:19 |
| mdbooth | in py2 it *must* be byte string. In py3 it *must* be unicode. | 09:19 |
| bauzas | mdbooth: so that's a libvirt problem | 09:19 |
| mdbooth | Yeah. | 09:19 |
| bauzas | grr | 09:19 |
| bauzas | so, yeah we need to check the python version | 09:20 |
| bauzas | I thought it was only need a byte string | 09:20 |
| bauzas | that's a terrible interface | 09:20 |
| mdbooth | In fairness it's a bug. | 09:21 |
| bauzas | yeah | 09:21 |
| bauzas | a libvirt bug | 09:21 |
| mdbooth | But one which can't be fixed now. | 09:21 |
| mdbooth | Indeed, a libvirt bug. | 09:21 |
| bauzas | oh and FWIW, params.items() only works because that's checked for py2 | 09:21 |
| *** armaan has quit IRC | 09:22 | |
| mdbooth | IIRC params.items() is the recommended way to migration py2 -> py3 unless you really can't handle a list or a generator | 09:22 |
| *** armaan has joined #openstack-nova | 09:23 | |
| *** shaohe_feng has quit IRC | 09:23 | |
| *** ratailor_ has quit IRC | 09:23 | |
| mdbooth | Yeah, params.items() would have the same behaviour there in py2 and py3. | 09:24 |
| *** shaohe_feng has joined #openstack-nova | 09:24 | |
| mdbooth | lyarwood: Chance of thunderstorms this afternoon, apparently \o/ | 09:25 |
| mdbooth | But not for you | 09:25 |
| bauzas | mdbooth: while py2 returns a dict, py3 returns a generator | 09:26 |
| mdbooth | bauzas: Right, and they'll both do the same thing there. | 09:26 |
| *** ttsiouts has quit IRC | 09:29 | |
| *** Bhujay has quit IRC | 09:30 | |
| *** Bhujay has joined #openstack-nova | 09:30 | |
| *** ttsiouts has joined #openstack-nova | 09:31 | |
| lyarwood | mdbooth: getting three days of rain from tomorrow so tis all good :) | 09:32 |
| *** shaohe_feng has quit IRC | 09:33 | |
| *** shaohe_feng has joined #openstack-nova | 09:34 | |
| *** Yes_ma`am has joined #openstack-nova | 09:35 | |
| Yes_ma`am | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 09:35 |
| Yes_ma`am | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 09:35 |
| *** Yes_ma`am has quit IRC | 09:35 | |
| *** shaohe_feng has quit IRC | 09:43 | |
| *** shaohe_feng has joined #openstack-nova | 09:44 | |
| *** stakeda has quit IRC | 09:46 | |
| *** Bhujay has quit IRC | 09:48 | |
| *** Bhujay has joined #openstack-nova | 09:48 | |
| *** armaan has quit IRC | 09:50 | |
| *** armaan has joined #openstack-nova | 09:51 | |
| *** Bhujay has quit IRC | 09:51 | |
| *** yedongcan has joined #openstack-nova | 09:52 | |
| *** Bhujay has joined #openstack-nova | 09:52 | |
| *** x49F has joined #openstack-nova | 09:53 | |
| x49F | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 09:53 |
| *** x49F has quit IRC | 09:53 | |
| *** shaohe_feng has quit IRC | 09:54 | |
| *** Bhujay has quit IRC | 09:54 | |
| *** shaohe_feng has joined #openstack-nova | 09:54 | |
| *** Bhujay has joined #openstack-nova | 09:55 | |
| *** Bhujay has quit IRC | 09:57 | |
| *** Bhujay has joined #openstack-nova | 09:58 | |
| *** cdent has quit IRC | 09:58 | |
| *** cdent has joined #openstack-nova | 09:58 | |
| *** armaan has quit IRC | 10:01 | |
| *** armaan has joined #openstack-nova | 10:02 | |
| *** shaohe_feng has quit IRC | 10:04 | |
| *** shaohe_feng has joined #openstack-nova | 10:05 | |
| *** namnh has joined #openstack-nova | 10:06 | |
| *** namnh has quit IRC | 10:06 | |
| *** janki has joined #openstack-nova | 10:06 | |
| *** namnh has joined #openstack-nova | 10:07 | |
| *** namnh_ has joined #openstack-nova | 10:07 | |
| *** udesale__ has joined #openstack-nova | 10:08 | |
| *** alexchadin has quit IRC | 10:08 | |
| *** wolverineav has joined #openstack-nova | 10:10 | |
| *** ttsiouts has quit IRC | 10:10 | |
| *** dtruong_ has joined #openstack-nova | 10:10 | |
| *** udesale_ has quit IRC | 10:10 | |
| *** lei-zh has quit IRC | 10:11 | |
| openstackgerrit | Merged openstack/nova master: ironic: Report resources as reserved when needed https://review.openstack.org/517921 | 10:11 |
| *** namnh has quit IRC | 10:11 | |
| *** shaohe_feng has quit IRC | 10:14 | |
| *** wolverineav has quit IRC | 10:14 | |
| *** shaohe_feng has joined #openstack-nova | 10:15 | |
| kashyap | I thought you might be interested in getting banned! | 10:17 |
| *** edmondsw has joined #openstack-nova | 10:18 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | 10:18 |
| *** alexchadin has joined #openstack-nova | 10:18 | |
| kashyap | mdbooth: I will leave the uncode / byte string change as-is. Not going to muck with it in this change. | 10:20 |
| *** abhishekk has quit IRC | 10:20 | |
| mdbooth | kashyap: Right. I was only ever suggesting a formatting change following a change of indentation :) | 10:21 |
| mdbooth | kashyap: Changing the unicode thing in that change would be inappropriate. | 10:22 |
| kashyap | mdbooth: I would have parsed the word "unindent" correctly. But you said: "undent", my brain went: "Can we remove this wrinkle / dent" :P | 10:22 |
| *** Bhujay has quit IRC | 10:22 | |
| kashyap | mdbooth: Absolutely | 10:22 |
| * kashyap doesn't want to violate the sensible rule of "one logical change per commit" | 10:22 | |
| kashyap | Okido, mooooooooooving on. | 10:23 |
| *** Bhujay has joined #openstack-nova | 10:23 | |
| *** 18WAA3F2A has joined #openstack-nova | 10:23 | |
| 18WAA3F2A | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 10:23 |
| 18WAA3F2A | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 10:23 |
| *** 18WAA3F2A has quit IRC | 10:23 | |
| *** edmondsw has quit IRC | 10:23 | |
| *** ispp has joined #openstack-nova | 10:24 | |
| *** shaohe_feng has quit IRC | 10:24 | |
| *** shaohe_feng has joined #openstack-nova | 10:25 | |
| *** namnh_ has quit IRC | 10:26 | |
| *** alexchadin has quit IRC | 10:29 | |
| *** namnh has joined #openstack-nova | 10:29 | |
| *** namnh has quit IRC | 10:30 | |
| *** shaohe_feng has quit IRC | 10:35 | |
| *** phuongnh has quit IRC | 10:35 | |
| *** shaohe_feng has joined #openstack-nova | 10:35 | |
| *** namnh has joined #openstack-nova | 10:37 | |
| *** alexchadin has joined #openstack-nova | 10:38 | |
| *** liuzz has quit IRC | 10:40 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI{2} APIs https://review.openstack.org/567258 | 10:42 |
| *** sapcc-bot2 has quit IRC | 10:44 | |
| *** d063130_2 has quit IRC | 10:44 | |
| *** d063130_ has joined #openstack-nova | 10:45 | |
| *** sapcc-bot has joined #openstack-nova | 10:45 | |
| *** shaohe_feng has quit IRC | 10:45 | |
| *** shaohe_feng has joined #openstack-nova | 10:45 | |
| *** edmondsw has joined #openstack-nova | 10:49 | |
| *** alexchad_ has joined #openstack-nova | 10:49 | |
| *** armaan has quit IRC | 10:50 | |
| *** armaan has joined #openstack-nova | 10:50 | |
| *** alexchadin has quit IRC | 10:51 | |
| *** shaohe_feng has quit IRC | 10:55 | |
| *** Bhujay has quit IRC | 10:56 | |
| *** shaohe_feng has joined #openstack-nova | 10:56 | |
| *** Bhujay has joined #openstack-nova | 10:57 | |
| *** takashin_ has joined #openstack-nova | 10:57 | |
| *** Bhujay has quit IRC | 10:57 | |
| *** flwang1 has joined #openstack-nova | 10:58 | |
| *** Bhujay has joined #openstack-nova | 10:58 | |
| *** linkmark has joined #openstack-nova | 10:58 | |
| *** takashin has quit IRC | 10:58 | |
| *** brault_ has joined #openstack-nova | 10:59 | |
| *** Bhujay has quit IRC | 10:59 | |
| *** Bhujay has joined #openstack-nova | 10:59 | |
| *** brault has quit IRC | 11:00 | |
| *** rcernin has quit IRC | 11:04 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Retry allocation writes server side https://review.openstack.org/586048 | 11:05 |
| *** shaohe_feng has quit IRC | 11:05 | |
| *** shaohe_feng has joined #openstack-nova | 11:06 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] api-ref: add traits parameter https://review.openstack.org/578048 | 11:07 |
| *** namnh has quit IRC | 11:07 | |
| *** dave-mccowan has joined #openstack-nova | 11:08 | |
| *** BrinZhang has quit IRC | 11:09 | |
| *** namnh has joined #openstack-nova | 11:09 | |
| *** Bhujay has quit IRC | 11:11 | |
| *** Bhujay has joined #openstack-nova | 11:11 | |
| *** namnh has quit IRC | 11:13 | |
| *** ttsiouts has joined #openstack-nova | 11:15 | |
| *** shaohe_feng has quit IRC | 11:16 | |
| *** shaohe_feng has joined #openstack-nova | 11:17 | |
| *** labviking has joined #openstack-nova | 11:23 | |
| labviking | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 11:23 |
| *** labviking has quit IRC | 11:23 | |
| *** udesale__ has quit IRC | 11:25 | |
| *** liuzz has joined #openstack-nova | 11:26 | |
| *** shaohe_feng has quit IRC | 11:26 | |
| *** Bhujay has quit IRC | 11:27 | |
| *** shaohe_feng has joined #openstack-nova | 11:27 | |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Get resource provider by uuid or name https://review.openstack.org/527791 | 11:27 |
| *** Bhujay has joined #openstack-nova | 11:27 | |
| *** Bhujay has quit IRC | 11:33 | |
| *** shaohe_feng has quit IRC | 11:36 | |
| *** shaohe_feng has joined #openstack-nova | 11:37 | |
| *** xeroks18 has joined #openstack-nova | 11:38 | |
| xeroks18 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 11:38 |
| xeroks18 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 11:38 |
| *** xeroks18 has quit IRC | 11:38 | |
| *** Bhujay has joined #openstack-nova | 11:38 | |
| *** gongysh has quit IRC | 11:44 | |
| *** shaohe_feng has quit IRC | 11:46 | |
| *** shaohe_feng has joined #openstack-nova | 11:47 | |
| *** ispp has quit IRC | 11:48 | |
| *** ispp has joined #openstack-nova | 11:48 | |
| *** flwang1 has quit IRC | 11:50 | |
| *** medberry has joined #openstack-nova | 11:51 | |
| *** flwang1 has joined #openstack-nova | 11:51 | |
| *** Dinesh_Bhor has quit IRC | 11:51 | |
| *** lyan has joined #openstack-nova | 11:56 | |
| *** lyan is now known as Guest22237 | 11:56 | |
| *** shaohe_feng has quit IRC | 11:57 | |
| *** shaohe_feng has joined #openstack-nova | 11:57 | |
| *** ccamacho1 has joined #openstack-nova | 11:58 | |
| *** ccamacho has quit IRC | 11:58 | |
| *** sean-k-mooney has quit IRC | 11:59 | |
| *** gongysh has joined #openstack-nova | 11:59 | |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Provide a useful message in the case of 500-error https://review.openstack.org/586056 | 12:00 |
| *** Bhujay has quit IRC | 12:00 | |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Provide a useful message in the case of 500-error https://review.openstack.org/586056 | 12:01 |
| *** armaan has quit IRC | 12:03 | |
| *** armaan has joined #openstack-nova | 12:04 | |
| *** vladikr has quit IRC | 12:05 | |
| *** vladikr has joined #openstack-nova | 12:06 | |
| *** shaohe_feng has quit IRC | 12:07 | |
| *** armaan has quit IRC | 12:07 | |
| *** armaan has joined #openstack-nova | 12:08 | |
| *** shaohe_feng has joined #openstack-nova | 12:08 | |
| *** liuzz_ has joined #openstack-nova | 12:09 | |
| *** liuzz has quit IRC | 12:10 | |
| *** vladikr has quit IRC | 12:11 | |
| *** armaan has quit IRC | 12:11 | |
| *** armaan has joined #openstack-nova | 12:12 | |
| *** hamzy has quit IRC | 12:14 | |
| *** jamesde__ has joined #openstack-nova | 12:16 | |
| *** shaohe_feng has quit IRC | 12:17 | |
| *** wolverineav has joined #openstack-nova | 12:18 | |
| *** hamzy has joined #openstack-nova | 12:19 | |
| *** shaohe_feng has joined #openstack-nova | 12:19 | |
| *** jamesden_ has quit IRC | 12:19 | |
| *** wolverineav has quit IRC | 12:20 | |
| *** wolverineav has joined #openstack-nova | 12:20 | |
| *** tiendc has quit IRC | 12:21 | |
| *** abhishekk has joined #openstack-nova | 12:21 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use placement 1.28 in scheduler report client https://review.openstack.org/583667 | 12:23 |
| *** vladikr has joined #openstack-nova | 12:24 | |
| *** Mr_Sheesh has joined #openstack-nova | 12:26 | |
| Mr_Sheesh | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 12:26 |
| Mr_Sheesh | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 12:26 |
| *** Mr_Sheesh has quit IRC | 12:26 | |
| *** psachin`` has quit IRC | 12:26 | |
| *** armaan has quit IRC | 12:27 | |
| *** shaohe_feng has quit IRC | 12:27 | |
| *** armaan has joined #openstack-nova | 12:27 | |
| *** shaohe_feng has joined #openstack-nova | 12:28 | |
| *** vladikr has quit IRC | 12:29 | |
| *** vladikr has joined #openstack-nova | 12:32 | |
| *** mdnadeem has quit IRC | 12:34 | |
| *** armaan has quit IRC | 12:35 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-traits stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/586101 | 12:35 |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-traits stable/rocky: Update UPPER_CONSTRAINTS_FILE for stable/rocky https://review.openstack.org/586102 | 12:35 |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-traits master: Update reno for stable/rocky https://review.openstack.org/586103 | 12:35 |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-vif stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/586104 | 12:36 |
| *** armaan has joined #openstack-nova | 12:36 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-vif stable/rocky: Update UPPER_CONSTRAINTS_FILE for stable/rocky https://review.openstack.org/586105 | 12:36 |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-vif master: Update reno for stable/rocky https://review.openstack.org/586106 | 12:36 |
| openstackgerrit | OpenStack Release Bot proposed openstack/osc-placement stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/586113 | 12:36 |
| openstackgerrit | OpenStack Release Bot proposed openstack/osc-placement stable/rocky: Update UPPER_CONSTRAINTS_FILE for stable/rocky https://review.openstack.org/586114 | 12:36 |
| *** openstackgerrit has quit IRC | 12:36 | |
| *** mriedem has joined #openstack-nova | 12:36 | |
| *** shaohe_feng has quit IRC | 12:38 | |
| *** shaohe_feng has joined #openstack-nova | 12:38 | |
| mriedem | gmann: i'm going to close out https://blueprints.launchpad.net/nova/+spec/api-extensions-merge-rocky for rocky which is a nice cut off point since what remains is the view builder stuff | 12:39 |
| mriedem | i'll open a bp for stein | 12:39 |
| gmann | mriedem: sure. Thanks | 12:39 |
| *** gongysh has quit IRC | 12:43 | |
| mriedem | i need some core love on the last 2 changes of the port binding live migration series https://review.openstack.org/#/c/434870/ | 12:44 |
| mriedem | the 2nd change has a +2 already | 12:45 |
| mriedem | gibi: bauzas: dansmith: ^ | 12:45 |
| gibi | mriedem: I'm in the process of reading it right now | 12:45 |
| mriedem | cool, thanks | 12:46 |
| *** armaan has quit IRC | 12:46 | |
| mriedem | melwitt: need a final +2 on https://review.openstack.org/#/c/566813/ to get the queued_for_delete stuff plumbed into the API | 12:46 |
| *** links has quit IRC | 12:46 | |
| *** armaan has joined #openstack-nova | 12:46 | |
| *** shaohe_feng has quit IRC | 12:48 | |
| *** shaohe_feng has joined #openstack-nova | 12:49 | |
| *** namnh has joined #openstack-nova | 12:50 | |
| *** mdbooth has quit IRC | 12:50 | |
| *** vivsoni_ has quit IRC | 12:51 | |
| *** vladikr has quit IRC | 12:53 | |
| *** namnh has quit IRC | 12:54 | |
| *** Sukhdev has joined #openstack-nova | 12:56 | |
| *** mdbooth has joined #openstack-nova | 12:56 | |
| *** medberry has quit IRC | 12:57 | |
| *** shaohe_feng has quit IRC | 12:58 | |
| *** shaohe_feng has joined #openstack-nova | 13:00 | |
| *** tbachman has joined #openstack-nova | 13:00 | |
| *** armaan has quit IRC | 13:00 | |
| *** Sukhdev has quit IRC | 13:01 | |
| efried | Hey folks. We should talk about the reshaper series. Does it have a FFE? If not, it's going to need a lot of focus today, particularly since Jay is in pirate mode. | 13:01 |
| *** vivsoni has joined #openstack-nova | 13:03 | |
| *** vladikr has joined #openstack-nova | 13:03 | |
| *** namnh has joined #openstack-nova | 13:05 | |
| *** armaan has joined #openstack-nova | 13:05 | |
| mriedem | efried: i think we defer | 13:08 |
| *** armaan has quit IRC | 13:08 | |
| mriedem | we'll be lucky to merge stuff that's already been approved for 24 hours | 13:08 |
| mriedem | this is why i asked the "what if we don't get this done in rocky" question in the ML | 13:08 |
| *** shaohe_feng has quit IRC | 13:08 | |
| *** alexchad_ has quit IRC | 13:09 | |
| *** shaohe_feng has joined #openstack-nova | 13:09 | |
| mriedem | i think it just means the same thing, but in stein - you can't use the new fancy wizbang NRP stuff until you've migrated existing inventory/allocations, right? | 13:09 |
| *** savvas has joined #openstack-nova | 13:09 | |
| mriedem | so rather than the migration happening *before* getting to stein, it happens *once* you get to stein | 13:09 |
| efried | mriedem: I think that sounds right. | 13:10 |
| mriedem | melwitt: i think the only client releases today are osc-placement and python-novaclient right? | 13:10 |
| mriedem | the various os-* lib releases were last week | 13:11 |
| efried | mriedem: Obviously any of the bps wanting to do nrp with inventory moves won't happen in Rocky, but that was surely the case anyway at this point. | 13:11 |
| efried | So given that, what can I put my eyeballs on today that will help most? | 13:13 |
| mriedem | efried: i was just going through the bp etherpad https://etherpad.openstack.org/p/nova-rocky-blueprint-status | 13:15 |
| mriedem | i've got 2 functional changes left in the port binding series https://review.openstack.org/#/c/434870/ | 13:16 |
| mriedem | https://review.openstack.org/#/c/566813/ is easy | 13:16 |
| mriedem | needs final +2 for the queued for delete cells v2 stuff | 13:16 |
| mriedem | and then i think we're just rechecking stuff that's already approved | 13:16 |
| efried | I haven't been following the down-cell stuff; am I going to be able to make sense of https://review.openstack.org/#/c/566813/ without context? | 13:17 |
| mriedem | should be able to, commit message explains it - we are just setting a flag on the instance mapping when deleting (or restoring) an instance | 13:18 |
| mriedem | so that if the cell goes down for that instance, we have something in the api db to key off to know if the instance was in the process of being deleted | 13:18 |
| mriedem | the actual down cell handling code will be done in stein | 13:18 |
| mriedem | this is all framework building at this point | 13:18 |
| *** shaohe_feng has quit IRC | 13:19 | |
| mriedem | oh and we also have https://review.openstack.org/#/c/566813/ for mgagne's metadata api changes for listing multiple ips/subnets per network attached to the vm | 13:19 |
| efried | k, was gonna ask. Nothing is checking this yet | 13:19 |
| mriedem | efried: right | 13:19 |
| mriedem | so low risk | 13:19 |
| efried | mriedem: wrong link for mgagne's thing? | 13:20 |
| *** shaohe_feng has joined #openstack-nova | 13:20 | |
| mriedem | yes... | 13:20 |
| mriedem | https://review.openstack.org/#/c/580742/ | 13:20 |
| *** jmlowe has joined #openstack-nova | 13:20 | |
| *** fpinna has joined #openstack-nova | 13:21 | |
| *** eharney has joined #openstack-nova | 13:21 | |
| *** ispp has quit IRC | 13:21 | |
| * mriedem takes daughter to daycare | 13:25 | |
| *** mriedem is now known as mriedem_afk | 13:25 | |
| *** med_ has quit IRC | 13:28 | |
| gibi | mriedem_afk: besides the question in https://review.openstack.org/#/c/434870/37/nova/tests/unit/compute/test_compute_mgr.py@182 I'm +2 | 13:28 |
| *** shaohe_feng has quit IRC | 13:29 | |
| bauzas | mriedem_afk: ack, sorry was away | 13:29 |
| *** jistr is now known as jistr|mtg | 13:29 | |
| *** shaohe_feng has joined #openstack-nova | 13:29 | |
| mgagne | mriedem_afk, melwitt: if you feel the multi fixed-ips spec needs more work, I don't mind postponing to the next release. I want to make sure all concerns are addressed before implementing it. | 13:31 |
| *** gongysh has joined #openstack-nova | 13:35 | |
| *** ispp has joined #openstack-nova | 13:35 | |
| *** shaohe_feng has quit IRC | 13:39 | |
| *** r-daneel has joined #openstack-nova | 13:40 | |
| *** antosh has joined #openstack-nova | 13:41 | |
| *** shaohe_feng has joined #openstack-nova | 13:42 | |
| *** namnh has quit IRC | 13:43 | |
| *** alexchadin has joined #openstack-nova | 13:44 | |
| bauzas | mriedem_afk: dansmith: humpf, I'm torn by https://review.openstack.org/#/c/434870/37/nova/compute/manager.py@1054 | 13:45 |
| *** Eran_Kuris has quit IRC | 13:46 | |
| *** Bhujay has joined #openstack-nova | 13:47 | |
| *** ttsiouts has quit IRC | 13:47 | |
| *** Bhujay has quit IRC | 13:47 | |
| *** jmlowe has quit IRC | 13:47 | |
| *** shaohe_feng has quit IRC | 13:49 | |
| *** jcosmao has joined #openstack-nova | 13:49 | |
| *** shaohe_feng has joined #openstack-nova | 13:50 | |
| *** ttsiouts has joined #openstack-nova | 13:50 | |
| *** mchlumsky has joined #openstack-nova | 13:52 | |
| *** hongbin has joined #openstack-nova | 13:52 | |
| melwitt | nova meeting in 7 minutes | 13:53 |
| mriedem_afk | gibi: looking | 13:53 |
| *** mriedem_afk is now known as mriedem | 13:53 | |
| mriedem | mgagne: i approved the spec update | 13:53 |
| mriedem | bauzas: the lazy load thing can be done in the follow up patch right? if we care about that. | 13:54 |
| mriedem | gibi: you're right, good eye | 13:55 |
| melwitt | mgagne: I think it's okay, just wanted to sanity check the 'networks' and 'services' part with dansmith | 13:55 |
| dansmith | mriedem: I think the lazy-load thing is important to fix, personally | 13:55 |
| dansmith | melwitt: link? | 13:56 |
| dansmith | mriedem: I'm having a hard time with encoding this level of libvirtness into that manager-level event handler | 13:56 |
| mriedem | dansmith: gibi: bauzas: ok i'll fix the lazy-load thing to make it conditional and fix that unit test | 13:56 |
| melwitt | dansmith: https://review.openstack.org/#/c/580742/4/releasenotes/notes/multiple-fixed-ips-network-information-e2eabb992b7c1e33.yaml@9 | 13:56 |
| mriedem | dansmith: that's the way this compute manager thing has kind of always been | 13:56 |
| bauzas | mriedem: ack | 13:56 |
| dansmith | mriedem: If you'll do it afterwards I'm okay with that, but I do think it needs to be fixed | 13:56 |
| mriedem | the only other driver that uses the callback is the hyperv driver i think | 13:57 |
| mriedem | i would prefer handling the lazy-load in the follow up if possible given the gate | 13:57 |
| dansmith | mriedem: yes, hyperv does, and I know, but.. this is next level invasiveness | 13:57 |
| mriedem | i don't know what alternative we'd have | 13:57 |
| mriedem | but i do know this works in the post-copy trigger, it shows up in the n-cpu logs in the next patch in the series in the live migration job | 13:57 |
| dansmith | I don't understand why we need this handler to know about both of these states | 13:57 |
| *** ispp has quit IRC | 13:58 | |
| *** artom has joined #openstack-nova | 13:58 | |
| *** awaugama has joined #openstack-nova | 13:58 | |
| *** ispp has joined #openstack-nova | 13:58 | |
| gibi | mriedem: I have one thing to consider in the next patch in that series as well https://review.openstack.org/#/c/522537/35/nova/conductor/tasks/live_migrate.py@279 | 13:59 |
| *** shaohe_feng has quit IRC | 14:00 | |
| *** jmlowe has joined #openstack-nova | 14:00 | |
| *** eharney has quit IRC | 14:00 | |
| dansmith | o/ | 14:00 |
| *** shaohe_feng has joined #openstack-nova | 14:00 | |
| dansmith | oops :) | 14:00 |
| *** josecastroleon has quit IRC | 14:01 | |
| *** josecastroleon has joined #openstack-nova | 14:01 | |
| mriedem | gibi: replied | 14:02 |
| mriedem | dansmith: replied about instance.migration_context - answer is 'no' because that's only set during claims which we don't do for live migration | 14:03 |
| *** avolkov has joined #openstack-nova | 14:03 | |
| dansmith | ugh | 14:03 |
| *** mlavalle has joined #openstack-nova | 14:03 | |
| mriedem | that might change with artom's numa-aware live migration stuff, idk | 14:04 |
| artom | mriedem, that's not the plan currently | 14:04 |
| artom | I'd rather just wait/help NUMA in placement along, so we can handle allocations there | 14:04 |
| gibi | mriedem, dansmith: thanks for the explanation about the behaviour of setting a non ovo field. I'm +2 now | 14:07 |
| *** markmc has quit IRC | 14:07 | |
| *** rnoriega has quit IRC | 14:07 | |
| *** weshay_PTO has quit IRC | 14:07 | |
| *** kashyap has quit IRC | 14:07 | |
| *** kashyap has joined #openstack-nova | 14:07 | |
| *** markmc has joined #openstack-nova | 14:07 | |
| *** rnoriega has joined #openstack-nova | 14:07 | |
| mriedem | gibi: thanks | 14:08 |
| *** weshay has joined #openstack-nova | 14:08 | |
| *** armaan has joined #openstack-nova | 14:09 | |
| *** jmlowe has quit IRC | 14:09 | |
| *** Luzi has quit IRC | 14:09 | |
| *** shaohe_feng has quit IRC | 14:10 | |
| *** shaohe_feng has joined #openstack-nova | 14:11 | |
| *** gongysh has quit IRC | 14:14 | |
| *** eharney has joined #openstack-nova | 14:14 | |
| *** shaohe_feng has quit IRC | 14:15 | |
| *** diga has joined #openstack-nova | 14:16 | |
| *** armaan has quit IRC | 14:20 | |
| *** tssurya has quit IRC | 14:23 | |
| dansmith | mriedem: so, just spitballing, | 14:24 |
| dansmith | but we could just assign the migration context to the instance in live_migrate when we create the migration to make it easier for everything that needs this | 14:24 |
| dansmith | this isn't the first time we've needed the context and couldn't get it for live migration | 14:25 |
| *** gongysh has joined #openstack-nova | 14:26 | |
| mriedem | that's not really a change i want to mess with in the 11th hour | 14:26 |
| *** psachin`` has joined #openstack-nova | 14:27 | |
| kashyap | Hi folks, can anyone remind me how to re-run the 'nova-live-migration' CI job? I don't want to do a blind recheck to not waste CI resources. | 14:27 |
| dansmith | mriedem: no, not saying we should | 14:27 |
| mriedem | kashyap: you ask this same question at least once per month | 14:30 |
| mriedem | you can't just recheck specific jobs | 14:30 |
| mriedem | that defeats the purpose of co-gating | 14:30 |
| kashyap | Ah, I just remembered that | 14:30 |
| kashyap | Sorry, goldfish like memory | 14:30 |
| kashyap | And the goddamned 37C heat isn't helping | 14:30 |
| *** shaohe_feng has joined #openstack-nova | 14:31 | |
| mriedem | you're gonna have to speak F around these parts | 14:31 |
| dansmith | veryhotF | 14:31 |
| kashyap | Hehe, ~97F | 14:32 |
| kashyap | More closer to 99F, actually. | 14:32 |
| *** avolkov has quit IRC | 14:32 | |
| *** gongysh has quit IRC | 14:33 | |
| *** josecastroleon has quit IRC | 14:40 | |
| *** josecastroleon has joined #openstack-nova | 14:40 | |
| mriedem | psh | 14:40 |
| kashyap | Not sure how high it goes there in Minnesota | 14:41 |
| *** shaohe_feng has quit IRC | 14:41 | |
| *** shaohe_feng has joined #openstack-nova | 14:41 | |
| * kashyap knows Texas gets 100F or more sometimes (learnt from a novel, "Echo Burning", during university days) | 14:41 | |
| *** josecastroleon has quit IRC | 14:42 | |
| *** josecastroleon1 has joined #openstack-nova | 14:42 | |
| *** josecastroleon1 is now known as josecastroleon | 14:42 | |
| *** abhishekk has quit IRC | 14:43 | |
| *** tidwellr has joined #openstack-nova | 14:44 | |
| mriedem | the level of passive aggressive in MN is off the charts, if that helps | 14:45 |
| kashyap | Hehe | 14:46 |
| *** hongbin has quit IRC | 14:46 | |
| *** josecastroleon has quit IRC | 14:47 | |
| efried | We've had several triple-digit days over the past week. | 14:47 |
| *** josecastroleon has joined #openstack-nova | 14:49 | |
| *** takashin_ has left #openstack-nova | 14:50 | |
| *** takashin has joined #openstack-nova | 14:50 | |
| *** Sukhdev has joined #openstack-nova | 14:50 | |
| mriedem | it's like 100F+ across the board in china | 14:51 |
| dansmith | kashyap: it gets well over 100F in oregon all the time | 14:51 |
| *** shaohe_feng has quit IRC | 14:51 | |
| mriedem | i'll be over there in 2 weeks in short shorts, flip flops and a belly t | 14:51 |
| dansmith | mriedem: I left some very non-passive aggressive comments in that patch, let me know what you think | 14:51 |
| *** imacdonn has quit IRC | 14:51 | |
| *** imacdonn has joined #openstack-nova | 14:52 | |
| bauzas | dansmith: your comment is understandable :) | 14:53 |
| *** shaohe_feng has joined #openstack-nova | 14:53 | |
| mriedem | wfm, and i don't disagree | 14:53 |
| mriedem | i'd think a different callback would be in order which only the libvirt driver would implement for this, but idk | 14:53 |
| bauzas | mriedem: the problem I have with this change is that's a big one and I'm not really a big expert on it | 14:53 |
| dansmith | yeah, something in virtapi | 14:54 |
| dansmith | should be fairly trivial to implement | 14:54 |
| bauzas | mriedem: so, +Wing it means a lot of time for me to make sure | 14:54 |
| mriedem | i will add a todo in the follow up to explore options to extract this into it's own thing | 14:54 |
| *** psachin`` has quit IRC | 14:54 | |
| mriedem | bauzas: let gibi +W i then :) | 14:54 |
| mriedem | *it | 14:54 |
| dansmith | mriedem: you can TODO(dansmith) it if you want | 14:54 |
| bauzas | if gibi is fine with it... | 14:54 |
| bauzas | I just want to be honest | 14:54 |
| bauzas | (and FWIW, 38°C here) | 14:55 |
| bauzas | (and I can't swim !) | 14:55 |
| *** jistr|mtg is now known as jistr | 14:56 | |
| mriedem | gibi: ok to +W and then i'll fix the test(s) in the follow up patch? https://review.openstack.org/#/c/434870/ | 14:56 |
| mriedem | god stephen's bottom change hasn't even made it through the gate yet | 14:57 |
| * mriedem is very concerned about stephen's bottom | 14:57 | |
| dansmith | I know | 14:57 |
| *** gongysh has joined #openstack-nova | 14:57 | |
| *** avolkov has joined #openstack-nova | 14:58 | |
| mriedem | gmann: so i don't know why we don't just have a tempest-slow job | 14:58 |
| mriedem | looking at https://review.openstack.org/#/c/567697/1/playbooks/legacy/nova-slow/run.yaml@26 | 14:59 |
| mriedem | what i had originally proposed as a compute-specific job that would run only compute api and scenario tests marked slow | 14:59 |
| mriedem | *was a | 14:59 |
| gmann | mriedem: just commented on patch. i thought of giving try to run all sceanrio tests in parallel which tempest-full does not do | 14:59 |
| gmann | but yes, running scenario tests twice is not good way. | 15:00 |
| gmann | i can make tempest-scenario-all job to slow job only and bring back the scenario tests running as parallel in tempest-full as end goal. | 15:01 |
| *** shaohe_feng has quit IRC | 15:01 | |
| *** gongysh has quit IRC | 15:01 | |
| mriedem | why do we need to tinker with tempest-full at all? | 15:01 |
| mriedem | leave that alone, | 15:01 |
| mriedem | add a tempest-slow job that just runs slow tests | 15:02 |
| mriedem | the end | 15:02 |
| *** yedongcan has left #openstack-nova | 15:02 | |
| mriedem | tempest-slow could run slow scenario tests concurrently, that doesn't matter to me | 15:02 |
| gmann | but we should run scenario tests in parallel somewhere. making tempest-full to run scenario tests as serial was temporary work around | 15:02 |
| mriedem | but i thought the reason for running scenario tests in serial was more about random failures than it was overall time | 15:02 |
| *** josecastroleon has quit IRC | 15:02 | |
| mriedem | work around for what? | 15:03 |
| gmann | yeah ssh timeout mainly | 15:03 |
| *** shaohe_feng has joined #openstack-nova | 15:03 | |
| *** takashin has left #openstack-nova | 15:03 | |
| mriedem | ok, | 15:03 |
| mriedem | as far as i know, that's not fixed | 15:03 |
| mriedem | so the workaround would need to be in place | 15:03 |
| mriedem | but imo it shouldn't block adding a purely tempest-slow job that is the same as tempest-full except it runs slow tests | 15:04 |
| pooja_jadhav | mriedem: Hello, need some help | 15:04 |
| gmann | yeah, i am not saying changing that now but if we move scenatio-slow to run only slow then at some point we need scenario parallel testing | 15:04 |
| gmann | "tempest-slow job that is the same as tempest-full except it runs slow tests" - you mean tempest-slow will run all tests including slow? | 15:05 |
| mriedem | ONLY slow | 15:05 |
| gmann | ok. | 15:05 |
| pooja_jadhav | mriedem: If I am doing live migrate, my both nodes(source, destination) referring to nfs shared storage then it should not shh to the destination node. but its going for ssh. | 15:05 |
| *** josecastroleon has joined #openstack-nova | 15:06 | |
| gmann | mriedem: make sense. | 15:06 |
| mriedem | gmann: that's what i originally proposed in the ML thread | 15:06 |
| mriedem | http://lists.openstack.org/pipermail/openstack-dev/2018-May/130394.html | 15:06 |
| gmann | mriedem: ok, ll re iterate that job and update patch. but after rocky | 15:07 |
| *** josecastroleon has quit IRC | 15:08 | |
| *** alexchadin has quit IRC | 15:08 | |
| * gmann need to go to bed it's seems ~16 hours day today... | 15:09 | |
| *** josecastroleon has joined #openstack-nova | 15:10 | |
| mriedem | o/ | 15:10 |
| *** shaohe_feng has quit IRC | 15:11 | |
| *** shaohe_feng has joined #openstack-nova | 15:12 | |
| *** Guest19794 is now known as kklimonda | 15:13 | |
| *** kklimonda has quit IRC | 15:14 | |
| *** kklimonda has joined #openstack-nova | 15:14 | |
| *** alexpilotti has quit IRC | 15:14 | |
| *** janki has quit IRC | 15:15 | |
| *** josecastroleon has quit IRC | 15:17 | |
| *** Sukhdev has quit IRC | 15:17 | |
| * gibi is on a spotty connection but still try to work... | 15:19 | |
| dansmith | gibi: want to hit this? https://review.openstack.org/#/c/434870/ | 15:20 |
| gibi | mriedem: I'm +Wing the bottom... | 15:20 |
| gibi | dansmith, mriedem: +W | 15:21 |
| dansmith | thanks | 15:21 |
| mriedem | thanks | 15:21 |
| dansmith | what else needs attention on that set? | 15:22 |
| *** shaohe_feng has quit IRC | 15:22 | |
| mriedem | i need to update the nits patch | 15:22 |
| dansmith | gerrit seems kinda confused | 15:22 |
| mriedem | was just looking at that | 15:22 |
| dansmith | is that it? | 15:22 |
| mriedem | yeah | 15:22 |
| dansmith | alright | 15:22 |
| mriedem | once https://review.openstack.org/#/c/522537/ merges it's bp complete | 15:22 |
| *** shaohe_feng has joined #openstack-nova | 15:22 | |
| dansmith | okay | 15:22 |
| dansmith | the check queue just dropped by 25% | 15:23 |
| dansmith | I wonder if a bunch of things merged or something else | 15:23 |
| *** ttsiouts has quit IRC | 15:24 | |
| gibi | We are at FF so it needs to be something else at this time of the year ;) | 15:25 |
| *** savvas has quit IRC | 15:27 | |
| *** savvas has joined #openstack-nova | 15:27 | |
| *** shaohe_feng has quit IRC | 15:27 | |
| *** savvas has quit IRC | 15:29 | |
| *** savvas has joined #openstack-nova | 15:30 | |
| *** avolkov has quit IRC | 15:31 | |
| *** shaohe_feng has joined #openstack-nova | 15:32 | |
| *** shaohe_feng has quit IRC | 15:32 | |
| *** avolkov has joined #openstack-nova | 15:33 | |
| *** shaohe_feng has joined #openstack-nova | 15:34 | |
| *** ispp has quit IRC | 15:36 | |
| *** pcaruana has quit IRC | 15:38 | |
| *** hamzy has quit IRC | 15:41 | |
| *** hamzy has joined #openstack-nova | 15:41 | |
| *** shaohe_feng has quit IRC | 15:42 | |
| *** shaohe_feng has joined #openstack-nova | 15:44 | |
| *** hongbin has joined #openstack-nova | 15:49 | |
| *** psachin`` has joined #openstack-nova | 15:50 | |
| *** shaohe_feng has quit IRC | 15:52 | |
| *** shaohe_feng has joined #openstack-nova | 15:54 | |
| dansmith | so, if -merges is still accurate, nova hasn't merged anything since midnight | 15:56 |
| dansmith | and a bunch of stuff just flushed out of the gate queue it seems, | 15:56 |
| dansmith | which I assume means a failure | 15:56 |
| dansmith | maybe things will come back via re-queue | 15:57 |
| *** edmondsw has quit IRC | 15:57 | |
| *** edmondsw has joined #openstack-nova | 15:57 | |
| *** edmondsw has quit IRC | 15:59 | |
| *** gyee has joined #openstack-nova | 15:59 | |
| *** itlinux has joined #openstack-nova | 16:01 | |
| Shilpa | mordred: HI | 16:02 |
| *** shaohe_feng has quit IRC | 16:03 | |
| *** mchlumsky_ has joined #openstack-nova | 16:03 | |
| *** shaohe_feng has joined #openstack-nova | 16:03 | |
| mriedem | dansmith: doesn't have to be for FF but we should get this in before RC1 so we can drop the reqspec compat code in stein https://review.openstack.org/#/c/581813/ | 16:04 |
| dansmith | ack | 16:05 |
| *** yamahata has quit IRC | 16:06 | |
| *** mchlumsky has quit IRC | 16:06 | |
| *** savvas has quit IRC | 16:06 | |
| *** alexpilotti has joined #openstack-nova | 16:10 | |
| *** AlexeyAbashkin has quit IRC | 16:10 | |
| dansmith | mriedem: do you not want to batch those instance queries a bit? | 16:13 |
| *** shaohe_feng has quit IRC | 16:13 | |
| dansmith | you're going to end up with a sql query to the api database that has every (live) instance uuid in it | 16:13 |
| dansmith | oh, no | 16:13 |
| dansmith | N queries I guess | 16:13 |
| *** savvas has joined #openstack-nova | 16:14 | |
| *** alexpilotti has quit IRC | 16:14 | |
| *** shaohe_feng has joined #openstack-nova | 16:16 | |
| *** savvas has quit IRC | 16:18 | |
| mriedem | oh i see, using IN (instance_uuids) LIMIT 50 | 16:21 |
| mriedem | and then sorting out from the results what is missing | 16:21 |
| mriedem | we also stop once we find at least one per cell | 16:22 |
| *** shaohe_feng has quit IRC | 16:23 | |
| *** savvas has joined #openstack-nova | 16:23 | |
| *** shaohe_feng has joined #openstack-nova | 16:24 | |
| dansmith | you do stop once per cell right? | 16:27 |
| dansmith | oh, read that wrong | 16:27 |
| dansmith | yeah, do stop | 16:27 |
| *** mdbooth has quit IRC | 16:27 | |
| mriedem | right iterate cells, get instances, lookup reqspec per instance | 16:27 |
| mriedem | stop per cell if one is missing | 16:28 |
| * dansmith nods | 16:28 | |
| *** savvas has quit IRC | 16:28 | |
| *** andymccr_ has joined #openstack-nova | 16:29 | |
| *** savvas has joined #openstack-nova | 16:32 | |
| *** andymccr_ has quit IRC | 16:33 | |
| *** andymccr_ has joined #openstack-nova | 16:33 | |
| *** shaohe_feng has quit IRC | 16:33 | |
| *** andymccr_ has quit IRC | 16:34 | |
| *** shaohe_feng has joined #openstack-nova | 16:34 | |
| *** andymccr_ has joined #openstack-nova | 16:34 | |
| *** psachin`` has quit IRC | 16:35 | |
| * gibi is logging off for today | 16:36 | |
| *** savvas has quit IRC | 16:36 | |
| *** diga has quit IRC | 16:37 | |
| *** dtantsur is now known as dtantsur|afk | 16:38 | |
| *** andymccr_ has quit IRC | 16:38 | |
| *** andymccr_ has joined #openstack-nova | 16:38 | |
| *** tesseract has quit IRC | 16:39 | |
| *** andymccr_ has quit IRC | 16:39 | |
| *** yamahata has joined #openstack-nova | 16:41 | |
| *** savvas has joined #openstack-nova | 16:41 | |
| *** med_ has joined #openstack-nova | 16:42 | |
| *** shaohe_feng has quit IRC | 16:44 | |
| *** andymccr_ has joined #openstack-nova | 16:44 | |
| *** shaohe_feng has joined #openstack-nova | 16:44 | |
| tbachman | SRIOV question: does a user have the ability to influence which SRIOV device nova selects when it schedules an instance to a compute host that happens to have multiple SRIOV devices (and in this case, the devices have the same vendor/product IDs)? | 16:48 |
| mriedem | tbachman: you mean in the case that the user doesn't provide a specific port to attach when the server is created? | 16:49 |
| tbachman | I saw the use of flavors to select an SRIOV NIC based on the vendor/product ID, but not something that can uniquely identify a NIC (and yes, this is a pet, not cattle case :-( ) | 16:49 |
| mriedem | if you know which nic you want, provide the port when creating the server | 16:49 |
| tbachman | mriedem: is there a way to specify it in the port object? | 16:49 |
| *** openstackgerrit has joined #openstack-nova | 16:49 | |
| mriedem | i believe there is some wonky port profile stuff | 16:49 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Retry allocation writes server side https://review.openstack.org/586048 | 16:49 |
| tbachman | heh | 16:50 |
| mriedem | with the vendor info in it | 16:50 |
| tbachman | ah | 16:50 |
| mriedem | https://docs.openstack.org/neutron/latest/admin/config-sriov.html | 16:50 |
| tbachman | so, are you saying the user can populate this, and not Nova? | 16:50 |
| tbachman | the binding:profile bits? | 16:50 |
| tbachman | (and Nova will use it | 16:50 |
| tbachman | ) | 16:50 |
| tbachman | yeah, I’d been looking at this | 16:51 |
| mriedem | https://docs.openstack.org/neutron/latest/admin/config-sriov.html#launching-instances-with-sr-iov-ports | 16:51 |
| tbachman | so, I see it adding “trusted” to the profile | 16:51 |
| mriedem | i'm not totally sure about the auto policy on the port binding profile | 16:51 |
| mriedem | *auth | 16:51 |
| mriedem | sahid is likely the person to ask about this, | 16:52 |
| mriedem | or sean-k-mooney[m] | 16:52 |
| *** abhishekk has joined #openstack-nova | 16:52 | |
| tbachman | If nova will accept (and use) the information in the profile, then I’m set | 16:52 |
| tbachman | mriedem: thx! | 16:52 |
| *** savvas has quit IRC | 16:52 | |
| *** savvas has joined #openstack-nova | 16:52 | |
| mriedem | tbachman: yeah the magic starts here in nova https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1825 | 16:53 |
| mriedem | that's called from the api to translate the requested port to a pci request which the compute will process | 16:53 |
| *** andymccr_ has quit IRC | 16:53 | |
| tbachman | cool | 16:53 |
| *** andymccr_ has joined #openstack-nova | 16:54 | |
| tbachman | mriedem: thanks for that tip! | 16:54 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use base test in placement functional tests https://review.openstack.org/585778 | 16:54 |
| *** shaohe_feng has quit IRC | 16:54 | |
| *** andymccr_ has quit IRC | 16:55 | |
| *** andymccr_ has joined #openstack-nova | 16:55 | |
| mriedem | grep VNIC_TYPES_SRIOV in there for other pci thingies with the binding profile | 16:55 |
| mriedem | and if the planets align it might work | 16:56 |
| tbachman | hmmm — I see it add things to the request, but unfortunately I don’t see the PCI device itself | 16:56 |
| tbachman | I’ll follow this path a bit more tho | 16:56 |
| * tbachman hopes for planetary alignment | 16:56 | |
| *** shaohe_feng has joined #openstack-nova | 16:58 | |
| *** derekh has quit IRC | 17:00 | |
| dansmith | mriedem: I left that rebuild test in there because it wasn't failing, but didn't really even look at it | 17:04 |
| *** shaohe_feng has quit IRC | 17:04 | |
| dansmith | just needs the unstub treatment yeah? | 17:05 |
| mriedem | dansmith: i'd have to look again, but it didn't do anything | 17:05 |
| mriedem | i mean, i removed some stuff and it didn't fail | 17:05 |
| dansmith | yeah, because of the stub | 17:05 |
| mriedem | i added some things which made it fail | 17:05 |
| dansmith | because it's checking the straight line | 17:05 |
| mriedem | right, so, | 17:05 |
| dansmith | point being, do you want to just remove that like the other one I nuked, or fix it? | 17:06 |
| melwitt | mriedem: need advice from a release perspective, is this considered critical enough to ask for a FFE to fix the install of the NoOp plugin that was the main feature released in 0.11.1? https://review.openstack.org/585530 | 17:06 |
| mriedem | well, also because it's not changing the image during rebuild so it doesn't go through the scheduler | 17:06 |
| mriedem | dansmith: i was thinking we could fix the test and add the negative wrinkle | 17:06 |
| melwitt | *1.11.0 | 17:06 |
| dansmith | mriedem: yup the other test did the image change | 17:06 |
| mriedem | there were 2 rebuild tests? | 17:06 |
| mriedem | i must have missed that | 17:06 |
| dansmith | yup | 17:06 |
| mriedem | dansmith: oh also, this brings up something i was going to talk with you about, | 17:06 |
| dansmith | mriedem: this was supposed to be the "make sure the completely normal case still works | 17:07 |
| dansmith | " | 17:07 |
| mriedem | which is that if the user attaches a port in a network that doesn't fit the host, and rebuilds with a new image, it will fail | 17:07 |
| mriedem | which is kind of a weird place to fail (on the rebuild but not the port attach) | 17:07 |
| *** shaohe_feng has joined #openstack-nova | 17:07 | |
| dansmith | yeah, but here are two alternatives: | 17:08 |
| dansmith | 1. don't fail and they wonder why things suck all the sudden | 17:08 |
| dansmith | 2. fail so they know | 17:08 |
| mriedem | melwitt: i'd probably ask in the -release channel, and ask doug | 17:08 |
| dansmith | 1. generates more support traffic I'd assume | 17:08 |
| mriedem | i didn't worry too much about it because i figured we could do #2 later if we wanted | 17:09 |
| melwitt | mriedem: okay thanks | 17:10 |
| *** r-daneel_ has joined #openstack-nova | 17:10 | |
| *** r-daneel has quit IRC | 17:10 | |
| *** r-daneel_ is now known as r-daneel | 17:10 | |
| dansmith | mriedem: was that "didn't worry" statement aimed at me? | 17:10 |
| mriedem | dansmith: yeah | 17:11 |
| dansmith | mriedem: replies in there | 17:12 |
| *** Sukhdev has joined #openstack-nova | 17:13 | |
| *** shaohe_feng has quit IRC | 17:14 | |
| *** r-daneel has quit IRC | 17:14 | |
| *** shaohe_feng has joined #openstack-nova | 17:16 | |
| dansmith | mriedem: so, I might be out of my element here, but when I un-stub things, I get a failure to attach on the same network | 17:16 |
| dansmith | because of a unique constraint on address.. i.e we can't have two on the same network (that aren't deleted) | 17:16 |
| dansmith | you didn't hit thatbecause you were trying to break it with another network, | 17:17 |
| dansmith | but.. | 17:17 |
| dansmith | presumably there is more mock stuff to do to get me a different attachment on the second go or something | 17:17 |
| dansmith | maybe I can work that out, hang oin | 17:18 |
| *** sridharg has quit IRC | 17:18 | |
| *** r-daneel has joined #openstack-nova | 17:22 | |
| *** sridharg has joined #openstack-nova | 17:22 | |
| dansmith | artom: | 17:22 |
| dansmith | around? | 17:22 |
| dansmith | did we or did we not skip the scheduler entirely when we rebuild to the same image? | 17:22 |
| *** vivsoni__ has joined #openstack-nova | 17:22 | |
| dansmith | now I'm confused because his tests all seem to assume we'll still hit the scheduler for a same-image rebuild | 17:22 |
| cfriesen_ | that seems wrong | 17:24 |
| *** shaohe_feng has quit IRC | 17:25 | |
| dansmith | yeah | 17:25 |
| dansmith | I think it is wrong | 17:25 |
| *** shaohe_feng has joined #openstack-nova | 17:27 | |
| cfriesen_ | I think the relevent code is rebuild_instance in the conductor | 17:27 |
| cfriesen_ | only calls the scheduler if "host" is not set | 17:27 |
| *** med_ has quit IRC | 17:29 | |
| dansmith | ooh, I think I might've found a bug in the code with this | 17:30 |
| *** sridharg has quit IRC | 17:30 | |
| dansmith | we get a 500 on NoValidHost in rebuild | 17:31 |
| artom | dansmith, I thought we did | 17:31 |
| dansmith | although we cast so we won't get that in the real world | 17:32 |
| artom | I'd have to check the code I guess, but a thing that happened was if you rebuilt with the same new image after the first rebuild request with that image was refused, we'd let it pass | 17:32 |
| dansmith | only because of CastAsCall | 17:32 |
| artom | Until we added rolling back of the image_ref | 17:32 |
| *** sridharg has joined #openstack-nova | 17:32 | |
| *** vladikr_ has joined #openstack-nova | 17:32 | |
| dansmith | mriedem: how do you handle that? Just check for 500 in the test or do more monkey work? | 17:32 |
| *** vladikr has quit IRC | 17:34 | |
| *** shaohe_feng has quit IRC | 17:35 | |
| *** sridharg has quit IRC | 17:38 | |
| *** shaohe_feng has joined #openstack-nova | 17:39 | |
| dansmith | feels wrong to handle NoValidHost in the api when it will only happen in tests | 17:39 |
| *** savvas has quit IRC | 17:41 | |
| *** savvas has joined #openstack-nova | 17:42 | |
| mriedem | assert the 500 in the test | 17:43 |
| dansmith | okay | 17:43 |
| mriedem | self.assertRaises(client.OpenStackAPIException, ...) or whatever | 17:43 |
| *** savvas_ has joined #openstack-nova | 17:43 | |
| *** savvas_ has quit IRC | 17:43 | |
| mriedem | ex.response.status_code | 17:43 |
| dansmith | yup | 17:43 |
| mriedem | the server likely also has a fault on it | 17:44 |
| *** savvas_ has joined #openstack-nova | 17:44 | |
| dansmith | I don't see any other uses of asserting the 500.. did I miss them? | 17:44 |
| mriedem | some tests assert the fault | 17:45 |
| *** shaohe_feng has quit IRC | 17:45 | |
| dansmith | I can't get the reason in the 500 unfortunately | 17:45 |
| mriedem | self.assertIn('No valid host', six.text_type(ex)) | 17:45 |
| dansmith | s'not in there | 17:46 |
| dansmith | oh, the exception name is though | 17:46 |
| dansmith | but not the string like normal | 17:46 |
| *** shaohe_feng has joined #openstack-nova | 17:46 | |
| *** savvas has quit IRC | 17:46 | |
| mriedem | good enough for a test | 17:46 |
| dansmith | ytup | 17:46 |
| *** sridharg has joined #openstack-nova | 17:47 | |
| mriedem | fwiw i've tried to write new functional tests without CastAsCall as much as possible to avoid stuff like this, and force the functional tests to be written from a user perspective so we have to get faults and stuff like that | 17:47 |
| *** mvk_ has quit IRC | 17:47 | |
| mriedem | doesn't help you in these b/c of the layers of base class setup | 17:48 |
| *** edmondsw has joined #openstack-nova | 17:48 | |
| dansmith | yeah | 17:49 |
| mriedem | it's like a bean dip after the sour cream at the bottom has gone bad | 17:49 |
| dansmith | that rebuild test is fairly useful now, fwiw | 17:49 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add additional functional tests for NUMA networks https://review.openstack.org/585385 | 17:49 |
| dansmith | heh | 17:49 |
| dansmith | man I should get a C-A-B on this at this point | 17:50 |
| *** baoli has joined #openstack-nova | 17:52 | |
| mriedem | do it | 17:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add additional functional tests for NUMA networks https://review.openstack.org/585385 | 17:55 |
| dansmith | omg I feel so much better | 17:55 |
| *** shaohe_feng has quit IRC | 17:55 | |
| *** shaohe_feng has joined #openstack-nova | 17:57 | |
| *** dklyle has quit IRC | 18:01 | |
| *** Multiple_ has joined #openstack-nova | 18:03 | |
| *** vivsoni__ has quit IRC | 18:04 | |
| Multiple_ | Looking for further review from sometime , please have a look https://review.openstack.org/#/c/563418/ | 18:04 |
| *** DuncanT_ has left #openstack-nova | 18:04 | |
| *** shaohe_feng has quit IRC | 18:06 | |
| *** shaohe_feng has joined #openstack-nova | 18:07 | |
| *** Multiple_ has quit IRC | 18:11 | |
| *** sridharg has quit IRC | 18:13 | |
| *** sridharg has joined #openstack-nova | 18:13 | |
| *** shaohe_feng has quit IRC | 18:16 | |
| *** shaohe_feng has joined #openstack-nova | 18:18 | |
| openstackgerrit | Merged openstack/nova master: [placement] Extract base functional test case from test_direct https://review.openstack.org/585777 | 18:19 |
| mriedem | efried: commented on https://review.openstack.org/#/c/583994/1/nova/network/neutronv2/api.py@410 - just let me know which you prefer | 18:22 |
| *** shaohe_feng has quit IRC | 18:26 | |
| *** shaohe_feng has joined #openstack-nova | 18:27 | |
| melwitt | efried: can you remind me please again, is NRP done or are there remaining bits that will go after reshaper? | 18:28 |
| openstackgerrit | karim proposed openstack/nova master: Updated AggregateImagePropertiesIsolation filter illustration https://review.openstack.org/586317 | 18:29 |
| mriedem | dansmith: now that you co-own that, are you going to make the updates to both it and the nit cleanup patch below it? | 18:32 |
| mriedem | dansmith: or shall i? | 18:32 |
| efried | mriedem: Responded. | 18:32 |
| dansmith | mriedem: to the functional test one? | 18:32 |
| efried | melwitt: are you tracking a specific nrp blueprint? | 18:32 |
| mriedem | dansmith: yeah | 18:32 |
| dansmith | mriedem: are there comments on the nits one? | 18:33 |
| mriedem | dansmith: yeah a few things that came from later patches in the series before he wrote the nit cleanup patch, | 18:34 |
| mriedem | a couple of which are yours from the api change with the docs | 18:34 |
| mriedem | i can update both if you are busy | 18:34 |
| melwitt | efried: no, was just getting confused about where NRP is as a feature, in general. I think my understanding has been, it's not complete yet, and we're focusing on reshaper first to make sure the path to migration is clear and complete, then finishing NRP after that | 18:34 |
| mriedem | as long as allocation candidates handles NRP it's done isn't it? | 18:34 |
| mriedem | https://blueprints.launchpad.net/nova/+spec/nested-resource-providers-allocation-candidates | 18:35 |
| mriedem | and https://blueprints.launchpad.net/nova/+spec/placement-return-all-resources i guess | 18:35 |
| *** sridharg has quit IRC | 18:35 | |
| *** shaohe_feng has quit IRC | 18:36 | |
| efried | melwitt: In the sense that reshaper (which is a bp) is part of nrp, we're not done with nrp yet. There's also client-side work to be done on nrp that we haven't really even figured out the scope of. | 18:36 |
| efried | But yes, besides reshaper, the actual placement API ought to be complete as far as nrp goes. | 18:37 |
| *** shaohe_feng has joined #openstack-nova | 18:38 | |
| mriedem | and with granular requests, | 18:39 |
| mriedem | you should be able to create flavors that request resources which could be found on nested resource providers in the tree right? | 18:39 |
| mriedem | during GET /allocation_candidates? | 18:39 |
| mriedem | reshaper is, in a nutshell, needed to fix a cheat we made in queens for vgpus | 18:40 |
| mriedem | is that fair? | 18:40 |
| efried | mriedem: All of that is true, but we're definitely not yet set up to where we can properly track allocations for nested providers in nova. | 18:41 |
| *** baoli has quit IRC | 18:41 | |
| efried | I.e. if you try to create a nrp and make a flavor that exploits it, I can guarantee you that the best that will happen is the allocations will be wrong. More likely the compute service will shit all over itself. | 18:42 |
| efried | But everything from the flavor through to the GET /a_c response will be peachy. | 18:42 |
| mriedem | the compute doesn't create those allocations though, scheduler does | 18:43 |
| mriedem | based on the allocation request from GET /alloc_cands | 18:43 |
| mriedem | if the allocations are wrong, it's because GET /allocation_candidates told us the wrong thing, yeah? | 18:43 |
| dansmith | mriedem: sorry, just tending to other things, I'll look in a few | 18:43 |
| mriedem | or the scheduler didn't allocate against the correct providers | 18:44 |
| mriedem | i'd think the latter is the issue.. | 18:44 |
| dansmith | melwitt: I wouldn't consider NRP done until we can actually use it in nova | 18:44 |
| mriedem | but it shouldn't be....the providers are in the allocation request PUT body | 18:44 |
| dansmith | melwitt: and that's on the other side of reshaper being done, plus the actual migration path | 18:44 |
| mriedem | i'm saying i think it can be used by now, minus reshaper, | 18:45 |
| *** mgoddard has quit IRC | 18:45 | |
| efried | dansmith: The latter maybe but not the former. | 18:45 |
| mriedem | otherwise i don't know what our goal is | 18:45 |
| efried | mriedem: I'm saying try it, you will find nontrivial bugs with it. | 18:45 |
| mriedem | that would involve some work.... | 18:45 |
| * mriedem runs | 18:45 | |
| dansmith | efried: I'm not sure what that means | 18:45 |
| melwitt | okay, sorry I find this all pretty confusing | 18:45 |
| efried | dansmith: We don't need reshaper for nrp to work. Only for situations where resources that were already being exposed on the comput node RP need to be moved. | 18:46 |
| dansmith | efried: if people can't move from their cloud now to one that uses it, it doesn't work at all, IMHO | 18:46 |
| dansmith | no migration path means it's a toy | 18:46 |
| *** shaohe_feng has quit IRC | 18:47 | |
| dansmith | and, imHO, | 18:47 |
| efried | Oh, that kind of migration, I thought you meant properly migrating a VM | 18:47 |
| efried | ...that uses nrp | 18:47 |
| dansmith | it's not considered done unless everyone can be using it like they should, | 18:47 |
| efried | "everyone"? | 18:47 |
| dansmith | and not "we disabled it because we can't migrate our existing cloud" | 18:47 |
| dansmith | like "users that created their cloud fresh in rocky" vs. "everyone else" | 18:47 |
| efried | Right, that's not what I'm talking about. | 18:47 |
| efried | Support for nrp isn't going to be a nova-wide thing, it's going to be a per-driver thing like any feature. | 18:48 |
| mriedem | i think efried is saying that's only an issue for libvirt and xenserver which have vgpu inventory and allocations on the root provider yeah? but not something like powervm. | 18:48 |
| efried | more specifically in fact, the features will look more like "VGPU" | 18:48 |
| efried | mriedem: Yes, that. | 18:48 |
| dansmith | mriedem: no, it's for everyone running libvirt with any two-socket box | 18:48 |
| dansmith | which is 99% of the deployments | 18:48 |
| mriedem | right, i was going to say, having said that, powervm in tree doesn't have any NRP type stuff anyway | 18:49 |
| dansmith | everyone with a two-socket box from the last decade has numa | 18:49 |
| efried | mriedem: Right, not yet. But very soon. | 18:49 |
| *** shaohe_feng has joined #openstack-nova | 18:49 | |
| efried | mriedem: And we're not blocked on reshaper, is my point. | 18:49 |
| mriedem | so theoreticals aside... | 18:49 |
| *** sridharg has joined #openstack-nova | 18:49 | |
| mriedem | efried: right i know | 18:49 |
| mriedem | libvirt and xenserver are blocked on reshaper | 18:49 |
| efried | It's not clear to me that dansmith knows. | 18:49 |
| efried | Yes | 18:49 |
| efried | However, it's possible that powervm is blocked on "client side nrp stuff we haven't exercised yet". | 18:50 |
| mriedem | i think we just, generally, speak in libvirt terms, given the adoption | 18:50 |
| mriedem | and how libvirt is the first to have most any new feature | 18:50 |
| dansmith | yes, I understand that boutique virt drivers are not blocked in the strictest sense | 18:50 |
| dansmith | from a nova project perspective, | 18:50 |
| dansmith | libvirt being blocked means it's blocked, IMHO | 18:51 |
| mriedem | now, cyborg or whatever could maybe totally use whatever is available today, idk | 18:51 |
| efried | We should consider nrp to be the framework, and things like NUMA & VGPU support to be the features we're talking about having "nova" support. | 18:51 |
| *** jangutter has quit IRC | 18:51 | |
| efried | So from that point of view, NUMA & VGPU are blocked "in nova" (i.e. libvirt). But the nrp framework is (probably, mostly) ready, pending working out the kinks on the client side in the scheduler. | 18:52 |
| mriedem | melwitt: let me guess, you're writing up the nova release highlights thing in the releases repo? | 18:52 |
| mriedem | efried: that's a good summary i think | 18:53 |
| dansmith | efried: IMHO, nova's notion of NRP being done would be that existing resources we're currently lying about are converted to the new thing | 18:53 |
| mriedem | melwitt: if/when you do, you should definitely mention the is_bfv disk_gb tracking stuff finally being fixed | 18:53 |
| dansmith | efried: otherwise we've just created a data structure and protocol to speak about it, | 18:53 |
| dansmith | but no user will perceive anything as being different | 18:53 |
| efried | mriedem: Example of client-side allocation stuff that's broke: put_allocations in the report client only works for the cn rp and ignores the rest. | 18:53 |
| dansmith | therefore.. we've basically accomplished nothing visible | 18:53 |
| mriedem | right so lots of *nova* isn't nrp-aware | 18:54 |
| mriedem | like lots of nova isn't shared storage provider aware | 18:54 |
| mriedem | you can model that in placement externally, | 18:54 |
| mriedem | but nova won't honor it | 18:54 |
| efried | right, swhat I'm sayin. | 18:54 |
| efried | So nrp in placement is done, but nrp (i.e. the framework that the actual features need) in nova is not. | 18:55 |
| dansmith | yeah, so call some specific blueprint done if you want, | 18:55 |
| dansmith | but when I get asked "can we do any of the things that NRP is supposed to enable for us?" I still have to answer no | 18:55 |
| melwitt | mriedem: just trying to get an idea of what's currently going on there ... and taking notes | 18:56 |
| efried | dansmith: Yes, I will agree with that, stipulating s/we/nova/ (as opposed to some other placement consumer). | 18:56 |
| dansmith | efried: yep, been trying to tag my comments with nova when I say stuff like that | 18:56 |
| dansmith | that's my intent at least | 18:56 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix accumulated nits from port binding for live migration series https://review.openstack.org/583994 | 18:57 |
| mriedem | efried: ^ | 18:57 |
| *** shaohe_feng has quit IRC | 18:57 | |
| efried | ack | 18:57 |
| mriedem | dansmith: i got our lazy load thing right here too https://review.openstack.org/#/c/583994/2/nova/compute/manager.py | 18:57 |
| dansmith | mriedem: ack | 18:59 |
| *** shaohe_feng has joined #openstack-nova | 18:59 | |
| mriedem | i intentionally said that jersey-style | 18:59 |
| mriedem | unrelated, but it seems that stephen's bottom change 564440 is perpetually stuck in the check queue or something weird | 19:01 |
| mriedem | it's in both queues at the same time at least twice today | 19:01 |
| *** hamzy has quit IRC | 19:02 | |
| *** hamzy_ has joined #openstack-nova | 19:02 | |
| *** jangutter has joined #openstack-nova | 19:02 | |
| mriedem | and it's already failed in the gate again, | 19:03 |
| mriedem | and queued in check | 19:03 |
| dansmith | cripes | 19:05 |
| dansmith | and some guys keep naking the later patches too | 19:05 |
| dansmith | GAWD | 19:05 |
| mriedem | i nak while nak'ed | 19:06 |
| dansmith | naked nak? | 19:06 |
| mriedem | too far | 19:06 |
| *** shaohe_feng has quit IRC | 19:07 | |
| *** brault_ has quit IRC | 19:08 | |
| *** abhishekk has quit IRC | 19:09 | |
| melwitt | mriedem: so the shared storage counting local usage for volume-backed instances saga is finally over? | 19:10 |
| *** med_ has joined #openstack-nova | 19:10 | |
| *** med_ has quit IRC | 19:10 | |
| *** med_ has joined #openstack-nova | 19:10 | |
| *** brault has joined #openstack-nova | 19:10 | |
| *** shaohe_feng has joined #openstack-nova | 19:11 | |
| mriedem | not shared storage | 19:11 |
| mriedem | volume-backed root_gb | 19:11 |
| mriedem | https://review.openstack.org/#/q/(status:open+OR+status:merged)+project:openstack/nova+branch:master+topic:bug/1469179 | 19:12 |
| melwitt | oh, I think I got that confused with shared storage reporting. that's still not done | 19:12 |
| melwitt | ok | 19:12 |
| mriedem | we will no longer claim root_gb for volume-backed instances against DISK_GB inventory in placement for new instances | 19:12 |
| mriedem | and heal on moves | 19:12 |
| dansmith | shared ephemeral reporting is also fixed in rocky I think | 19:13 |
| mriedem | via placement? | 19:13 |
| dansmith | we no longer report DISK_GB in inventory if MISC_SHARES_VIA_AGGREGATE is set | 19:13 |
| mriedem | for the libvirt driver* | 19:14 |
| mriedem | i wouldn't talk much about that in rocky though, because we have several places in the code that don't handle that | 19:14 |
| dansmith | not sure, I would have expected that to be applied to each as they converted to update_provider_tree(), unless the others are still using get_inventory() | 19:14 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Assorted cleanups from numa-aware-vswitches series https://review.openstack.org/582651 | 19:15 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add additional functional tests for NUMA networks https://review.openstack.org/585385 | 19:15 |
| mriedem | yeah that's only libvirt and ironic that implement upt | 19:15 |
| mriedem | and it doesn't apply to ironic | 19:15 |
| dansmith | I didn't follow that change in, | 19:15 |
| mriedem | but like, we don't have any docs on it, we don't have any CI on it, and we have lots of places that aren't aware of it (like move operations) | 19:15 |
| dansmith | but I was hoping that if we're removing that inventory that we handle it the other places we need, | 19:16 |
| dansmith | otherwise we're not going to be able to boot anything on computes that are configured that way :) | 19:16 |
| *** sridharg has quit IRC | 19:16 | |
| mriedem | https://review.openstack.org/#/c/560459/ | 19:16 |
| mriedem | well, we should, | 19:17 |
| mriedem | the allocations could go against the provider that has the DISK_GB inventory | 19:17 |
| dansmith | I'm not sure that move ops need to change? | 19:17 |
| *** pcaruana has joined #openstack-nova | 19:17 | |
| mriedem | which is in the MISC_SHARES_VIA_AGGREGATE relationship | 19:17 |
| dansmith | right | 19:17 |
| dansmith | so I'm not sure what you're saying... | 19:17 |
| mriedem | there was something i look up every time this comes up that i know is broken | 19:17 |
| *** shaohe_feng has quit IRC | 19:17 | |
| mriedem | i've beaten cdent over the head with a few times already :) | 19:18 |
| *** mdrabe has joined #openstack-nova | 19:18 | |
| dansmith | have we updated the ceph job to do the right thing? | 19:18 |
| dansmith | that'd be a good way to either show it's broken or show that it works | 19:18 |
| dansmith | and you should be able to osc-placement one-shot yourself a sharing provider during setup | 19:18 |
| mriedem | nope, and that's what i suggested in one of the placement update ML threads | 19:19 |
| dansmith | okay | 19:19 |
| dansmith | not sure why we merged that patch without that testing then | 19:19 |
| dansmith | ^ that was rhetorical :D | 19:19 |
| *** shaohe_feng has joined #openstack-nova | 19:20 | |
| dansmith | mriedem: you're still trying to remember what the missing thing is right? | 19:20 |
| mriedem | well, this is one https://github.com/openstack/nova/blob/master/nova/conductor/tasks/migrate.py#L57 | 19:21 |
| *** r-daneel has quit IRC | 19:21 | |
| dansmith | ooh right | 19:21 |
| mriedem | and _revert_allocation in compute | 19:22 |
| *** r-daneel has joined #openstack-nova | 19:22 | |
| mriedem | resize to same host probably doesn't handle it either, not sure | 19:22 |
| dansmith | yeah, I remember now.. I was thinking those were only problems we had with the doubling approach, but I remember now | 19:22 |
| mriedem | anywho, | 19:22 |
| mriedem | CI testing with ceph + modeling shared is a todo for the ptg etherpad most likely | 19:22 |
| mriedem | i'll add it | 19:22 |
| dansmith | yeah, that probably needs to be a priority for someone, | 19:23 |
| *** fpinna has quit IRC | 19:23 | |
| dansmith | because right now if you associate a sharing provider, things are going to break in unhelpful ways | 19:23 |
| mriedem | i'll assign it to my cat | 19:23 |
| dansmith | melwitt: ^ | 19:23 |
| mriedem | yeah - that's why i've tried to temper enthusiasm / communication that "now it's fixed" | 19:24 |
| mriedem | also because i'm a debby downer | 19:24 |
| dansmith | fair enough, I just saw it had merged when I was triaging a bug related to that stuff | 19:24 |
| dansmith | and figured it had actually been finished | 19:25 |
| melwitt | I've been summoned for ceph stuff eh? | 19:25 |
| dansmith | melwitt: no, for ptl stuff | 19:25 |
| melwitt | oh, thought you were referring to the ceph CI testing add | 19:26 |
| dansmith | I am, | 19:26 |
| dansmith | I'm saying we probably need to be making sure that the test gets updated to validate whether this created a worse hole, | 19:26 |
| dansmith | and maybe decide if we want to either patch that out, | 19:26 |
| dansmith | or reno a known issue or whatever | 19:26 |
| cdent | mriedem: on [t 1fky] | 19:26 |
| purplerbot | <mriedem> i've beaten cdent over the head with a few times already :) [2018-07-26 19:18:01.246831] [n 1fky] | 19:26 |
| melwitt | dansmith: I see, okay | 19:27 |
| cdent | I'm trying to make sure that people are aware, but I'm not sure anybody really reads the weekly pupdates and I'm only willing to take full responsibility for the placement side (where it's ready) | 19:27 |
| cdent | but I agree we have some holes to fill before much more time passes | 19:28 |
| *** shaohe_feng has quit IRC | 19:28 | |
| *** shaohe_feng has joined #openstack-nova | 19:28 | |
| mriedem | L65 https://etherpad.openstack.org/p/nova-ptg-stein | 19:28 |
| mriedem | i will check to see if we have an existing ceph multinode job, but i know the nova-live-migration job is multinode and re-configures itself to use ceph in the 2nd part | 19:29 |
| mriedem | but live migration is less interesting since we don't do claims in the compute or anything | 19:29 |
| dansmith | we really just need a multinode ceph job that boots an instance for base level verification, | 19:30 |
| dansmith | but yeah it should do a cold migration at least | 19:30 |
| dansmith | can we just convert the ceph job to multinode? | 19:30 |
| mriedem | we can do anything we want | 19:31 |
| cdent | anything? | 19:31 |
| mriedem | but i'd rather re-use something than add yet another job | 19:31 |
| * cdent runs around naked | 19:31 | |
| mriedem | cdent: with zuul all things are possible (tm) | 19:32 |
| dansmith | mriedem: well just converting the existing one to multinode I mean | 19:32 |
| mriedem | dansmith: i know | 19:32 |
| cdent | chris-runs-around-naked -1 | 19:32 |
| dansmith | heck, even just the ceph job as a single node with the sharing flag would be enough to shake out some of it | 19:33 |
| mriedem | true, it would be like offloading the DISK_GB management to another project which isn't untrue or unlike a 2 node job | 19:33 |
| mriedem | s/project/provider/ | 19:33 |
| dansmith | yeah | 19:33 |
| mriedem | just don't get to test the interesting move bits | 19:33 |
| dansmith | well, | 19:33 |
| dansmith | single node resize is an interesting bit too | 19:34 |
| mriedem | btw, we should probably make the ceph job voting again at some point... | 19:34 |
| mriedem | i think it's been fairly healthy for awhile again | 19:34 |
| melwitt | I am in support of that idea | 19:35 |
| dansmith | just a DNM patch to set the flag and see how bad it's broken is probably important to decide if we need a "don't set this, it'll break" reno | 19:35 |
| mriedem | i can probably wip that up | 19:35 |
| openstackgerrit | Merged openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | 19:35 |
| melwitt | sounds like a good plan | 19:35 |
| dansmith | dear god | 19:35 |
| dansmith | something merged | 19:35 |
| * melwitt faints | 19:35 | |
| melwitt | thanks mriedem that would be a big help | 19:36 |
| mriedem | i dont' know how to look at graphite.openstack.org anymore to see if legacy-tempest-dsvm-full-devstack-plugin-ceph has been trending with the tempest-full job | 19:37 |
| mriedem | and http://grafana.openstack.org/d/-iKINcImz/ceph-failure-rate?orgId=1 is broken | 19:37 |
| *** vladikr_ has quit IRC | 19:38 | |
| *** shaohe_feng has quit IRC | 19:38 | |
| *** shaohe_feng has joined #openstack-nova | 19:39 | |
| melwitt | me neither. could try to regenerate it with https://github.com/sdague/failopotamus but I'm not sure whether that works with zuul or not | 19:39 |
| mriedem | doesn't work anymore | 19:40 |
| mriedem | the graphite stats_count structure has changed so it's by project rather than by job now | 19:40 |
| mriedem | i'm asking in -infra | 19:40 |
| melwitt | gotcha | 19:40 |
| dansmith | I assume that we're good to keep rechecking things that are already +Wd past the end of the day, given the gate yeah? | 19:43 |
| *** ccamacho1 has quit IRC | 19:43 | |
| melwitt | that's been my understanding | 19:45 |
| openstackgerrit | Merged openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | 19:45 |
| *** awaugama has quit IRC | 19:45 | |
| *** pcaruana has quit IRC | 19:45 | |
| mriedem | melwitt: dansmith: http://graphite.openstack.org/render/?width=1531&height=592&_salt=1532634445.928&from=00%3A00_20180428&until=23%3A59_20180726&target=stats_counts.zuul.tenant.openstack.pipeline.check.project.git_openstack_org.openstack_nova.master.job.legacy-tempest-dsvm-full-devstack-plugin-ceph.FAILURE&target=stats_counts.zuul.tenant.openstack.pipeline.check.project.git_openstack_org.openstack_nova.master.job.tempest-full | 19:47 |
| mriedem | LURE&title=ceph%20vs%20tempest-full%20fail%20rates%20over%203%20months | 19:47 |
| mriedem | so something big got fixed the first week of may | 19:48 |
| *** shaohe_feng has quit IRC | 19:48 | |
| *** felipemonteiro has joined #openstack-nova | 19:48 | |
| mriedem | anyway it looks pretty stable over 3 months | 19:49 |
| *** shaohe_feng has joined #openstack-nova | 19:49 | |
| dansmith | so we eff it up by setting the sharing flag yeah? :) | 19:49 |
| melwitt | :***( | 19:50 |
| dansmith | I'm joking.. turning that on should generate a constant level of fail or success | 19:50 |
| dansmith | so if it totally doesn't work, then we don't merge it | 19:51 |
| *** flwang1 has quit IRC | 19:51 | |
| *** dklyle has joined #openstack-nova | 19:51 | |
| melwitt | mriedem: IIRC, the fixes were https://review.openstack.org/563870 and https://review.openstack.org/563313 | 19:52 |
| melwitt | that was slightly before may though | 19:53 |
| melwitt | or a week before | 19:54 |
| mriedem | same timeframe | 19:55 |
| mriedem | the query goes to April 28 | 19:55 |
| melwitt | can you paste the link, it got cutoff weirdly for me trying to use it | 19:57 |
| melwitt | *pastebin | 19:58 |
| *** shaohe_feng has quit IRC | 19:58 | |
| mriedem | https://goo.gl/WbXoW5 | 19:58 |
| mriedem | there are no multinode ceph jobs except for our usage of it in the nova-live-migration job which only runs live migration tests | 19:59 |
| *** cdent has quit IRC | 19:59 | |
| melwitt | thanks. it's weird it cuts off the bottom part of the graph for me | 19:59 |
| *** shaohe_feng has joined #openstack-nova | 20:00 | |
| melwitt | https://imgur.com/a/3Fdstt9 | 20:01 |
| *** jmlowe has joined #openstack-nova | 20:02 | |
| *** savvas has joined #openstack-nova | 20:03 | |
| dansmith | that's at the 1.0 mark I think | 20:04 |
| dansmith | and no fails at zero | 20:04 |
| dansmith | you have to null the missing points and do connected mode to get it to look right IIRC | 20:04 |
| *** eharney has quit IRC | 20:05 | |
| mriedem | what's gonna be the best way to get the disk info for the provider DISK_GB inventory? df -P /root ? | 20:05 |
| dansmith | there's a ceph command you can run I think | 20:06 |
| mriedem | oo even better | 20:06 |
| mriedem | which would match the libvirt driver's reporting so i should probably use that | 20:06 |
| *** savvas_ has quit IRC | 20:07 | |
| mriedem | whatever get_cluster_stats does | 20:07 |
| mriedem | http://docs.ceph.com/docs/jewel/man/8/ceph/#status ? | 20:08 |
| *** alexpilotti has joined #openstack-nova | 20:08 | |
| dansmith | I dunno, I've seen people paste output of it but I don't know exactly | 20:08 |
| *** shaohe_feng has quit IRC | 20:09 | |
| mriedem | i'd have to get a devstack setup with the same ceph config to play with this | 20:09 |
| mriedem | but seems pretty straight forward | 20:09 |
| dansmith | ceph osd df -h ? | 20:09 |
| *** shaohe_feng has joined #openstack-nova | 20:09 | |
| dansmith | or just ceph df maybe | 20:10 |
| dansmith | http://docs.ceph.com/docs/master/rados/operations/monitoring/#checking-a-cluster-s-usage-stats | 20:10 |
| *** vladikr has joined #openstack-nova | 20:10 | |
| mriedem | cool | 20:11 |
| openstackgerrit | melanie witt proposed openstack/os-vif stable/rocky: Add vif_plug_noop to setup.cfg packages https://review.openstack.org/586340 | 20:11 |
| *** alexpilo_ has joined #openstack-nova | 20:12 | |
| mriedem | well i shall start the stack while writing my monthly report... | 20:13 |
| melwitt | how can I tell who is stable/core for $project? I haven't noticed a way to figure that out for libs like os-vif | 20:14 |
| melwitt | figure out via gerrit | 20:14 |
| mriedem | people | 20:16 |
| mriedem | oh well, | 20:16 |
| *** alexpilotti has quit IRC | 20:17 | |
| mriedem | i thought it was in project-config but can't find it | 20:17 |
| melwitt | ok, just curious. since I keep asking, was wondering if there was a way to avoid bugging people | 20:17 |
| melwitt | I assume for os-vif it's the same stable team as for nova | 20:18 |
| melwitt | I need stable review for a FFE release of os-vif https://review.openstack.org/586340 | 20:18 |
| *** med_ has quit IRC | 20:18 | |
| *** shaohe_feng has quit IRC | 20:19 | |
| mriedem | oh i found it | 20:19 |
| *** shaohe_feng has joined #openstack-nova | 20:20 | |
| mriedem | https://github.com/openstack-infra/project-config/blob/master/gerrit/acls/openstack/os-vif.config | 20:20 |
| melwitt | cool! thanks | 20:20 |
| mriedem | +2 | 20:20 |
| melwitt | thanks 2x | 20:21 |
| *** med_ has joined #openstack-nova | 20:22 | |
| *** med_ has quit IRC | 20:22 | |
| *** med_ has joined #openstack-nova | 20:22 | |
| melwitt | dansmith: plz https://review.openstack.org/586340 | 20:23 |
| mriedem | commence to stacking | 20:24 |
| *** shaohe_feng has quit IRC | 20:29 | |
| *** shaohe_feng has joined #openstack-nova | 20:30 | |
| *** felipemonteiro has quit IRC | 20:33 | |
| *** felipemonteiro has joined #openstack-nova | 20:33 | |
| *** mdrabe has quit IRC | 20:36 | |
| melwitt | thx dansmith | 20:36 |
| dansmith | aye | 20:36 |
| melwitt | mriedem: fyi https://review.openstack.org/586307 sorry I didn't get your ack before osc-placement got released | 20:37 |
| melwitt | I meant to | 20:38 |
| *** shaohe_feng has quit IRC | 20:39 | |
| mriedem | doesn't that need to branch? | 20:40 |
| *** shaohe_feng has joined #openstack-nova | 20:41 | |
| melwitt | are we supposed to branch manually in the release? I thought that would happen automatically | 20:41 |
| mriedem | no it's a designated thing in the deliverable yaml | 20:41 |
| mriedem | i.e. what was removed on the left side https://review.openstack.org/#/c/586307/1/deliverables/rocky/osc-placement.yaml | 20:41 |
| mriedem | you'd need that for 1.3.0 to be where they branch stable/rocky | 20:41 |
| melwitt | gdi | 20:42 |
| mriedem | i don't know what "And it removes the stable/rocky branch that had to be manually deleted because of the mis-categorization of the library as a non-client." all means but that's what i've done in the past | 20:42 |
| melwitt | what happened was that osc-placement has been categorized as a 'non-client library' up to now, | 20:43 |
| mriedem | oh i see https://github.com/openstack/releases/commit/8dadc73479e3c303c4f5ee3975628c3e333d61cc#diff-64bede2e011f3f457420a6313880e97b | 20:43 |
| mriedem | so smcginnis did it for you | 20:43 |
| mriedem | i did it in queens https://github.com/openstack/releases/commit/a5a77d24664a2502c68cc5b0cba17db8373499c2#diff-b9ac789921c8d258691218b7fcbeaefb | 20:44 |
| melwitt | and I had asked around in -releases about whether it should be considered a client library since it's a osc plugin, we agreed it should be a client lib and smcginnis had meant to omit it in the branch cutting that happened last week for non client libs, and that I would propose a change to the library 'type' when I released it this week | 20:44 |
| melwitt | so, they ended up deleting the stable/rocky branch for us to go ahead and do the release today as a client library | 20:44 |
| mriedem | yup so i guess push a patch to branch stable/rocky at 1.3.0 | 20:45 |
| mriedem | have you done a python-novaclient release? | 20:45 |
| mriedem | b/c same thing there | 20:45 |
| melwitt | sounds like it, I'll ask in -releases. it looks like this branch thing might be part of their (release team) process | 20:45 |
| melwitt | not yet, putting that together now | 20:45 |
| *** alexpilo_ has quit IRC | 20:45 | |
| mriedem | i've always done it myself | 20:45 |
| *** alexpilotti has joined #openstack-nova | 20:46 | |
| mriedem | i never trusted smcginnis touching my sweet sweet deliverables | 20:46 |
| melwitt | heh :) | 20:47 |
| melwitt | yeah, that was his 'clean up after people' script that did it. I'm a terrible release proposer | 20:48 |
| smcginnis | :) | 20:49 |
| *** shaohe_feng has quit IRC | 20:50 | |
| smcginnis | I've thought of so many responses to that. None of which I feel I should write here. | 20:50 |
| *** shaohe_feng has joined #openstack-nova | 20:50 | |
| smcginnis | Not to your comment melwitt, to mriedem's. :) | 20:50 |
| melwitt | I figured :) | 20:50 |
| mriedem | dansmith: yup thar she blar http://paste.openstack.org/show/726714/ | 20:53 |
| dansmith | nice | 20:53 |
| *** mdrabe has joined #openstack-nova | 20:54 | |
| *** brault has quit IRC | 20:55 | |
| *** savvas has quit IRC | 20:56 | |
| *** r-daneel_ has joined #openstack-nova | 20:59 | |
| *** alexpilotti has quit IRC | 20:59 | |
| *** r-daneel has quit IRC | 21:00 | |
| *** r-daneel_ is now known as r-daneel | 21:00 | |
| *** shaohe_feng has quit IRC | 21:00 | |
| *** shaohe_feng has joined #openstack-nova | 21:01 | |
| melwitt | mriedem: novaclient release proposed https://review.openstack.org/586350 | 21:01 |
| mriedem | my awk skills are not going to be good enough to parse out that df output | 21:08 |
| mriedem | i can parse out: ceph status | grep usage | 21:08 |
| dansmith | is that a challenge? | 21:08 |
| mriedem | it is | 21:08 |
| melwitt | mriedem: you can pass --format=json to make it return json if that helps | 21:09 |
| mriedem | ooo | 21:09 |
| mriedem | $ sudo ceph df | awk 'NR==3{print $1}END{$1}' | 21:09 |
| mriedem | 24564M | 21:09 |
| mriedem | melwitt: doesn't really help me in bash | 21:10 |
| *** shaohe_feng has quit IRC | 21:10 | |
| mriedem | although, | 21:10 |
| mriedem | pipe that into python -m json.tool | 21:10 |
| *** shaohe_feng has joined #openstack-nova | 21:10 | |
| mriedem | "stats": { | 21:10 |
| mriedem | "total_avail_bytes": 25482182656, | 21:10 |
| mriedem | "total_bytes": 25757220864, | 21:10 |
| mriedem | "total_used_bytes": 275038208 | 21:10 |
| mriedem | } | 21:10 |
| dansmith | echo $((`cat ceph | grep vms | awk '{print $5}' | egrep -o '[0-9]+'` / 1024)) | 21:11 |
| dansmith | 22 | 21:11 |
| *** flwang1 has joined #openstack-nova | 21:11 | |
| dansmith | oh json format is nice | 21:11 |
| dansmith | is jq on the worker nodes? I bet it is | 21:11 |
| mriedem | except the comma | 21:12 |
| mriedem | $ sudo ceph df --format=json | python -m json.tool | grep total_avail_bytes | awk 'END{print $2}' | 21:12 |
| mriedem | 25482182656, | 21:12 |
| dansmith | hold up | 21:12 |
| mriedem | haha | 21:13 |
| mriedem | $ sudo ceph df --format=json | python -m json.tool | grep total_avail_bytes | awk 'END{print $2}' | egrep -o '[0-9]+' | 21:13 |
| mriedem | 25481973760 | 21:13 |
| dansmith | ceph df --format=json | | 21:13 |
| dansmith | ceph df --format=json | jq .total_bytes | 21:13 |
| dansmith | er | 21:13 |
| dansmith | ceph df --format=json | jq stats.total_bytes | 21:13 |
| dansmith | I think | 21:13 |
| mriedem | don't have jq | 21:14 |
| dansmith | ceph df --format=json | jq .stats.total_bytes | 21:14 |
| dansmith | ^ works | 21:14 |
| dansmith | on the worker nodes? | 21:14 |
| dansmith | that sucks | 21:14 |
| mriedem | $ sudo ceph df --format=json | jq .stats.total_bytes | 21:14 |
| mriedem | 25757220864 | 21:14 |
| mriedem | i mean, we can install it... | 21:14 |
| mriedem | but this also works | 21:14 |
| mriedem | $ sudo ceph df --format=json | python -m json.tool | grep total_avail_bytes | egrep -o '[0-9]+' | 21:14 |
| mriedem | 25481973760 | 21:14 |
| dansmith | yup | 21:15 |
| dansmith | convert to GB of course | 21:15 |
| mriedem | yup; even shorter with json-pretty | 21:16 |
| mriedem | $ sudo ceph df --format=json-pretty | grep total_avail_bytes | egrep -o '[0-9]+' | 21:16 |
| mriedem | 25481887744 | 21:16 |
| *** r-daneel has quit IRC | 21:17 | |
| *** mdrabe has quit IRC | 21:19 | |
| *** shaohe_feng has quit IRC | 21:20 | |
| *** shaohe_feng has joined #openstack-nova | 21:22 | |
| mriedem | oh do we have to pull from the vms pool specifically? | 21:27 |
| mriedem | i suppose huh | 21:27 |
| dansmith | I assume it's all the same space since it's the same size | 21:28 |
| melwitt | rc todo etherpad https://etherpad.openstack.org/p/nova-rocky-release-candidate-todo | 21:28 |
| dansmith | and you're only going to update it once (and it's just inventory) | 21:28 |
| dansmith | so, probably meh | 21:28 |
| *** antosh has quit IRC | 21:29 | |
| *** shaohe_feng has quit IRC | 21:31 | |
| mriedem | the max available is the same for the 3 pools | 21:31 |
| dansmith | yeah, I dunno what that's showing really | 21:32 |
| mriedem | oh i see | 21:32 |
| mriedem | /dev/loop0 24G 228M 24G 1% /var/lib/ceph | 21:32 |
| dansmith | could be that if you allocate some from the images you'll lose max on the vms | 21:32 |
| dansmith | like ZFS in a pool | 21:32 |
| mriedem | yeah so it's the same 24GB block shared across 3 pools? | 21:32 |
| dansmith | yeah I'm sure | 21:32 |
| dansmith | hard to say what the right thing to do is, but for testing just saying it's 24G is probably fine | 21:33 |
| *** savvas has joined #openstack-nova | 21:33 | |
| *** tidwellr has quit IRC | 21:33 | |
| mriedem | was trying to think what we should put for reserved | 21:33 |
| mriedem | or just leave that 0 | 21:33 |
| dansmith | it won't be right regardless, | 21:33 |
| *** shaohe_feng has joined #openstack-nova | 21:33 | |
| dansmith | other than maybe reserving enough for whatever images and snaps we do in a regular tempest run | 21:33 |
| dansmith | but still, it's just a gamble | 21:34 |
| mriedem | yeah so i can really just use CEPH_LOOPBACK_DISK_SIZE in devstack, and don't need to parse ceph df output then.. | 21:35 |
| dansmith | hah | 21:36 |
| mriedem | but this has been fun | 21:38 |
| *** shaohe_feng has quit IRC | 21:41 | |
| *** shaohe_feng has joined #openstack-nova | 21:42 | |
| *** wolverineav has quit IRC | 21:42 | |
| *** edmondsw has quit IRC | 21:43 | |
| *** wolverineav has joined #openstack-nova | 21:43 | |
| *** jmlowe has quit IRC | 21:43 | |
| *** edmondsw has joined #openstack-nova | 21:45 | |
| *** itlinux has quit IRC | 21:47 | |
| *** med_ has quit IRC | 21:48 | |
| *** wolverineav has quit IRC | 21:48 | |
| *** bandini has quit IRC | 21:48 | |
| *** bandini has joined #openstack-nova | 21:48 | |
| *** edmondsw has quit IRC | 21:49 | |
| *** shaohe_feng has quit IRC | 21:51 | |
| *** slaweq has quit IRC | 21:52 | |
| *** shaohe_feng has joined #openstack-nova | 21:53 | |
| *** jangutter has quit IRC | 22:00 | |
| *** shaohe_feng has quit IRC | 22:01 | |
| *** shaohe_feng has joined #openstack-nova | 22:02 | |
| mriedem | easy bug https://bugs.launchpad.net/placement-osc-plugin/+bug/1783896 | 22:03 |
| openstack | Launchpad bug 1783896 in placement-osc-plugin "openstack resource provider aggregate set <name> should be <uuid>" [Medium,Triaged] | 22:03 |
| melwitt | mriedem: this patch for the metadata API bp, it looks good to me but I wasn't 100% sure the vmware CI fail on it is legit https://review.openstack.org/580742 forgot to mention it this morning | 22:05 |
| melwitt | the other third party CI fails on it look unrelated | 22:05 |
| mriedem | can't really dig into that atm | 22:06 |
| mriedem | already shouldn't be working anymore | 22:06 |
| melwitt | ok | 22:06 |
| *** Sukhdev has quit IRC | 22:08 | |
| *** burt has quit IRC | 22:09 | |
| melwitt | mriedem: so we're Depends-On https://review.openstack.org/566813 and https://review.openstack.org/564452 for r-3, is there anything else that you know of? | 22:11 |
| mriedem | dansmith: melwitt: https://review.openstack.org/586363 | 22:11 |
| melwitt | oh yeah, guh. | 22:11 |
| mriedem | those are the 2 i'm watching | 22:12 |
| *** shaohe_feng has quit IRC | 22:12 | |
| *** mvk_ has joined #openstack-nova | 22:12 | |
| mriedem | no, https://review.openstack.org/#/c/586363/ is the ceph job using a shared provider in placement for disk | 22:12 |
| mriedem | efried: ^ | 22:12 |
| *** shaohe_feng has joined #openstack-nova | 22:12 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-novaclient stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/586364 | 22:13 |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-novaclient stable/rocky: Update UPPER_CONSTRAINTS_FILE for stable/rocky https://review.openstack.org/586365 | 22:13 |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-novaclient master: Update reno for stable/rocky https://review.openstack.org/586366 | 22:13 |
| *** wolverineav has joined #openstack-nova | 22:13 | |
| melwitt | mriedem: oh, coincidence, ok. but you reminded me, we need your test to determine whether or not to reno a warning not to use the shared aggregate thing. does that have to be done before my EOD or just before RC1? | 22:13 |
| mriedem | we don't have to warn about that in a reno | 22:14 |
| mriedem | it's totally undocumented | 22:14 |
| mriedem | we don't need to say "yup this still doesn't work" | 22:14 |
| *** mriedem is now known as mriedem_afk | 22:14 | |
| melwitt | ok, thanks | 22:14 |
| *** wolverineav has quit IRC | 22:16 | |
| *** wolverineav has joined #openstack-nova | 22:16 | |
| *** wolverineav has quit IRC | 22:16 | |
| *** rcernin has joined #openstack-nova | 22:19 | |
| *** shaohe_feng has quit IRC | 22:22 | |
| *** slaweq has joined #openstack-nova | 22:24 | |
| dansmith | we have it in specs, | 22:25 |
| dansmith | and before this, setting it would do nothing | 22:25 |
| dansmith | people do read and try stuff that are in specs | 22:25 |
| dansmith | so I think we should just patch it out of the driver if we're not going to mention it personally (assuming it's broken like we expect) | 22:26 |
| dansmith | just MHO | 22:26 |
| dansmith | if we start claiming in stein that it works, people will try it in older releases too | 22:26 |
| *** shaohe_feng has joined #openstack-nova | 22:26 | |
| *** slaweq has quit IRC | 22:29 | |
| melwitt | mriedem_afk: fyi nova r-3 release patch https://review.openstack.org/586368 | 22:30 |
| dansmith | first hit: https://docs.openstack.org/nova/latest/reference/update-provider-tree.html | 22:31 |
| *** shaohe_feng has quit IRC | 22:32 | |
| *** shaohe_feng has joined #openstack-nova | 22:33 | |
| melwitt | ok ... thinking. the change was done as a bug fix, https://bugs.launchpad.net/nova/+bug/1771728 which was found via someone setting MISC_SHARES_VIA_AGGREGATE | 22:33 |
| openstack | Launchpad bug 1771728 in OpenStack Compute (nova) "libvirt: Shared Resource Provider (RP) DISK_GB is NOT taken into account if it's configured with Compute Node RPs" [Undecided,Fix released] - Assigned to Bhagyashri Shewale (bhagyashri-shewale) | 22:33 |
| melwitt | if we patch the bug fix out, then it goes back to setting it does nothing. but that still seems weird because people think they can use it (because of this doc, possibly) | 22:35 |
| *** wolverineav has joined #openstack-nova | 22:35 | |
| *** alexpilotti has joined #openstack-nova | 22:36 | |
| dansmith | yeah, so someone thought they could use it and reported it did nothing, | 22:36 |
| melwitt | I dunno, maybe just a doc update to this page saying MISC_SHARES_VIA_AGGREGATE isn't tested in tempest? | 22:36 |
| melwitt | like a warning? | 22:37 |
| dansmith | but if that's the case and it actually breaks resource reporting and probably migrations... | 22:37 |
| dansmith | if it totally doesn't do anything other than break things we should probably not do it until the rest of the feature works | 22:37 |
| dansmith | but at least a known issue reno, IMHO | 22:37 |
| dansmith | not tested in tempest is different than "totally broken and we know it" | 22:38 |
| melwitt | what I mean is, was the previous state of it doing nothing actually doing nothing? or could it have been breaking things underneath? | 22:38 |
| *** avolkov has quit IRC | 22:38 | |
| dansmith | no, it was just being ignored when people expected it to magically make the compute node do the shared storage accounting right | 22:38 |
| dansmith | now, setting it will cause the compute node to not expose disk inventory, | 22:39 |
| dansmith | and likely in a migration situation we will clobber the allocation against the shared pool, | 22:39 |
| dansmith | which will result in instances with no disk allocation, | 22:39 |
| melwitt | okay ... so maybe, revert the bug fix, add a warning to the doc to mention MISC_SHARES_VIA_AGGREGATE isn't usable in nova yet, and then don't allow the bug fix back in until we have tempest setup with ceph etc? | 22:40 |
| dansmith | which we'll have to fix via migration somehow, and potentially result in oversubscribing the pool since anything that has migrated once will have no disk allocation | 22:40 |
| dansmith | that's certainly one approach yeah | 22:40 |
| dansmith | the other being just a reno that warns that it's half implemented and known broken | 22:40 |
| *** alexpilo_ has joined #openstack-nova | 22:41 | |
| melwitt | I'm worried people will miss that reno, I guess | 22:41 |
| dansmith | yup, and they'll corrupt their data if they do and try it | 22:41 |
| *** itlinux has joined #openstack-nova | 22:41 | |
| melwitt | and the price for missing it is high | 22:41 |
| melwitt | efried: are you around? what do you think about ^ | 22:42 |
| *** shaohe_feng has quit IRC | 22:42 | |
| *** shaohe_feng has joined #openstack-nova | 22:43 | |
| *** alexpilotti has quit IRC | 22:44 | |
| *** namnh has joined #openstack-nova | 22:46 | |
| *** mriedem_afk is now known as mriedem | 22:47 | |
| mriedem | rather than revert, you could just comment out the one line in the libvirt driver | 22:48 |
| *** Guest22237 has quit IRC | 22:48 | |
| dansmith | yeah, revert is too old I'm sure | 22:48 |
| dansmith | just have to mangle it manually | 22:48 |
| melwitt | yeah, okay. I think we should because from what dansmith has explained, using this in its current state could badly corrupt a deployment and then we'd have to come up with some code to migrate people out of it if it happens to them | 22:50 |
| dansmith | it'd be heal_allocations I guess | 22:50 |
| dansmith | but still | 22:50 |
| *** shaohe_feng has quit IRC | 22:53 | |
| dansmith | might be able to functional test our way | 22:54 |
| melwitt | I'll put this on the rc1 todo list https://etherpad.openstack.org/p/nova-rocky-release-candidate-todo | 22:55 |
| melwitt | and get efried's thoughts tomorrow morning | 22:55 |
| *** shaohe_feng has joined #openstack-nova | 22:56 | |
| *** alexpilotti has joined #openstack-nova | 22:57 | |
| *** hongbin has quit IRC | 23:00 | |
| *** lbragstad_ has joined #openstack-nova | 23:01 | |
| *** alexpilo_ has quit IRC | 23:01 | |
| *** lbragstad has quit IRC | 23:01 | |
| *** knikolla has quit IRC | 23:01 | |
| *** shaohe_feng has quit IRC | 23:03 | |
| *** mschuppert has quit IRC | 23:04 | |
| *** shaohe_feng has joined #openstack-nova | 23:06 | |
| *** shaohe_feng has quit IRC | 23:13 | |
| *** itlinux has quit IRC | 23:16 | |
| *** shaohe_feng has joined #openstack-nova | 23:16 | |
| *** arvindn05 has joined #openstack-nova | 23:17 | |
| *** arvindn05 has left #openstack-nova | 23:18 | |
| *** med_ has joined #openstack-nova | 23:19 | |
| *** med_ has quit IRC | 23:19 | |
| *** med_ has joined #openstack-nova | 23:19 | |
| rm_work | hey nova folks! the deprecation discussed here: https://review.openstack.org/#/c/522027/ / https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/deprecate-file-injection.html -- is that what we're using here? https://github.com/openstack/octavia/blob/master/octavia/compute/drivers/nova_driver.py#L150 | 23:22 |
| *** wolverineav has quit IRC | 23:23 | |
| *** shaohe_feng has quit IRC | 23:23 | |
| *** shaohe_feng has joined #openstack-nova | 23:24 | |
| *** david-lyle has joined #openstack-nova | 23:24 | |
| melwitt | rm_work: yes, that is file injection, deprecated with microversion 2.57 https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L1210-L1215 | 23:26 |
| rm_work | johnsom: ^^ | 23:26 |
| *** dklyle has quit IRC | 23:26 | |
| johnsom | melwitt What? You removed the ability to load data via config drive? That will break a ton of services. | 23:27 |
| melwitt | johnsom: no, the ability to specify files to inject into the server. the supported way to do that is user data | 23:27 |
| johnsom | melwitt but user_data was supposed to go away given it's non-standard and significantly limited in size. | 23:28 |
| melwitt | I think you might be reversing the two? user_data isn't going away and is supported by cloud-init | 23:29 |
| johnsom | Wow, this went under the radar. I know it impacts Octavia and Trove, probably manila and a few others | 23:29 |
| johnsom | The file method we were using is supported by cloud-init via config drive. | 23:30 |
| johnsom | What we are talking about is in the "content" folder in config drive | 23:31 |
| rm_work | it's interesting because in https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/deprecate-file-injection.html#problem-description | 23:31 |
| rm_work | #1 is not a problem for services that use fixed images, #2 is a GOOD thing (for security), and #3 is simply false, because the alternatives are worse (bad security) | 23:32 |
| johnsom | Yeah user-data has a ridiculously small size limitation too. Like you can't even get a full certificate chain in it. | 23:33 |
| *** shaohe_feng has quit IRC | 23:34 | |
| *** shaohe_feng has joined #openstack-nova | 23:34 | |
| melwitt | okay, I don't know that much detail about the deprecation. so it'd be best to visit the channel tomorrow when people who know more about it are around | 23:35 |
| melwitt | as for the use case, the only other way I know of to handle something like that would be vendor data | 23:35 |
| *** knikolla has joined #openstack-nova | 23:36 | |
| dansmith | rm_work: johnsom just to be clear, you're talking about putting stuff in the "personality" part of the server post right? | 23:37 |
| johnsom | no | 23:37 |
| rm_work | https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L1298-L1300 | 23:37 |
| rm_work | https://github.com/openstack/octavia/blob/master/octavia/compute/drivers/nova_driver.py#L150 | 23:37 |
| dansmith | johnsom: cool, then this isn't what you're looking for | 23:37 |
| rm_work | ^^ dansmith see that | 23:37 |
| rm_work | I think the answer is yes? | 23:37 |
| rm_work | we pass "files" to the server create | 23:38 |
| dansmith | yeah, I think files in the client goes to personality | 23:38 |
| rm_work | https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L688-L692 | 23:38 |
| johnsom | Does "files" in the client get converted to personalities in the nova API? | 23:38 |
| rm_work | yes | 23:38 |
| dansmith | so this has been disabled by default for libvirt for a long time, | 23:38 |
| dansmith | and strongly encouraged not to be used for longer | 23:39 |
| dansmith | I guess you have been turning it on in the compute node? | 23:39 |
| rm_work | we even say as much here: https://github.com/openstack/octavia/blob/920a15c620eada38f40d827c89fb9881ffd29fdb/octavia/common/config.py#L368-L370 | 23:39 |
| rm_work | dansmith: i don't think we have done anything to force it to be enabled in our gates... | 23:39 |
| dansmith | rm_work: it's off by default | 23:39 |
| dansmith | in the libvirt driver | 23:39 |
| rm_work | could we tell from nova logs from a gate run? | 23:39 |
| dansmith | not sure if the other drivers even support it | 23:39 |
| dansmith | rm_work: just look at the config files from the gate run, like inject_file_partition or whatever | 23:40 |
| dansmith | I didn't think that goes into the config drive, fwiw.. and that would be bad for security if it did and you use it for sensitive things, | 23:40 |
| johnsom | Yeah, this is what we were told to use to drop cert chains in via config drive years ago. The issue was user-data was not secure as it is stored in the DB and it had a really small max content size | 23:40 |
| rm_work | which config file | 23:40 |
| dansmith | because we're totally willy-nilly with that | 23:40 |
| dansmith | johnsom: who told you that? | 23:41 |
| rm_work | like, this? http://logs.openstack.org/49/552549/13/check/octavia-v2-dsvm-scenario/f7f027d/controller/logs/etc/nova/nova_conf.txt.gz | 23:41 |
| dansmith | johnsom: this has been on its death bed for, gosh, five years at least | 23:41 |
| *** namnh has quit IRC | 23:41 | |
| dansmith | rm_work: that's on a controller | 23:41 |
| rm_work | don't know where else to look? | 23:42 |
| johnsom | The nova PTL at the time we were spinning this project up. I know I tried to use user-data last year and it was still pretty small. I couldn't load the test app I was hoping to drop into cirros | 23:42 |
| rm_work | this is a single-node test | 23:42 |
| dansmith | rm_work: okay, then probably the same, so yeah it's disabled there for actual file injection | 23:42 |
| johnsom | We don't do anything special to enable that on devstack in the gates | 23:42 |
| rm_work | then ... how is this working | 23:42 |
| dansmith | I'll have to look and see if and how it ends up in the config drive | 23:42 |
| dansmith | but, your assertion about the "it isn't stored is good for security" is a huge problem, because we can't migrate or rebuild or anything the instance | 23:43 |
| dansmith | and don't have a way to provide that stuff again you know | 23:43 |
| dansmith | and | 23:43 |
| *** itlinux has joined #openstack-nova | 23:43 | |
| *** mlavalle has quit IRC | 23:43 | |
| dansmith | storing anything sensitive in configdrive is kinda crazy :) | 23:43 |
| rm_work | we don't WANT to migrate or restore the instances | 23:43 |
| rm_work | that would explicitly be bad | 23:44 |
| rm_work | if an instance dies, it's dead and we trash it | 23:44 |
| rm_work | and we will handle making a replacement | 23:44 |
| *** shaohe_feng has quit IRC | 23:44 | |
| johnsom | Well some have use cases for migrate, but the content should migrate with the config drive | 23:44 |
| dansmith | rm_work: okay but you understand that nova is a thing that lots of people use, and most want to be able to migrate, and if we break that model for users that don't know anything then, that's like bad and stuff yeah? :) | 23:45 |
| dansmith | I mean, | 23:45 |
| dansmith | nova has a wider audience :) | 23:45 |
| dansmith | if you want to enforce different lifecycle semantics on the thing you use nova for, then that's cool, but.. | 23:45 |
| johnsom | Yeah, we have use cases for migrating. I think that is one operator talking | 23:45 |
| rm_work | yes, but BECAUSE of that philosophy, because something doesn't work for a couple of use cases, you shouldn't remove it when it still works for others? | 23:45 |
| rm_work | seems like it should work both ways :P | 23:45 |
| johnsom | Is the supported data size for "user-data" documented? I can't find it | 23:46 |
| rm_work | isn't saying "we should kill your use-case, because nova has to be generic for lots of use-cases" seems kinda backward | 23:46 |
| johnsom | beyond "a small opaque blob of data" | 23:46 |
| dansmith | here's where it shows up in the config drive: https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L191-L194 | 23:46 |
| *** shaohe_feng has joined #openstack-nova | 23:47 | |
| dansmith | rm_work: naw dude, but you know, we try to make features that are rather predictable and understandable from the outside, especially by the users that don't have a view into the config of the deployment | 23:48 |
| dansmith | rm_work: it's kindof what we do here. we're trying to be an abstraction | 23:48 |
| dansmith | rm_work: and, as we said, we have a method that *does* work for all cases, except it has a size limitation for you, which I get | 23:48 |
| dansmith | and the other thing had some really terrible security semantics that I guess you didn't know about :) | 23:49 |
| melwitt | johnsom: looks like this is the size limit 16384 bytes https://help.ubuntu.com/community/CloudInit#fnref-6a17aff5cf9eab5a99b5ab3dbd49854b0e9681c1 | 23:49 |
| dansmith | johnsom: it's a MediumText in the db | 23:49 |
| dansmith | so that's likely the real limit | 23:49 |
| melwitt | oh, okay | 23:49 |
| rm_work | what are the terrible security semantics for the other thing? it mentions "evil images could do whatever with the data", but if we only boot with a known good image... | 23:50 |
| johnsom | lol, yeah, 16k seems about what I ran into last year. | 23:50 |
| openstackgerrit | Merged openstack/nova master: Stop using HostAPI.service_delete https://review.openstack.org/582680 | 23:50 |
| dansmith | api limits it at 64k, FWIW | 23:50 |
| *** felipemonteiro has quit IRC | 23:50 | |
| johnsom | Yeah, I mean if you don't trust the images... the whole guest OS is at risk | 23:50 |
| dansmith | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L212-L216 | 23:50 |
| *** stakeda has joined #openstack-nova | 23:50 | |
| *** david-lyle has quit IRC | 23:51 | |
| rm_work | so what is the new alternative? we have to create a cinder volume for every VM we boot, and pass that to the server create? | 23:51 |
| *** itlinux has quit IRC | 23:52 | |
| rm_work | since user_data is obviously unacceptable for multiple reasons | 23:52 |
| rm_work | and I'm not seeing how that helps at all with the "evil image" case | 23:52 |
| *** dklyle has joined #openstack-nova | 23:52 | |
| dansmith | the new alternative is user_data, and providing this feedback not on FF day at 5pm when we can actually do something for you :) | 23:52 |
| *** takashin has joined #openstack-nova | 23:52 | |
| rm_work | user_data is explicitly insecure | 23:53 |
| rm_work | and size-limited to a point where it is not even possible to use for a very common use-case (passing in a cert chain) | 23:53 |
| rm_work | we'll just have to revisit this later, it just happened that we discovered this *just now* | 23:53 |
| dansmith | how much data do you expect nova to keep track of for you through our control API? | 23:53 |
| rm_work | i don't want nova to keep track of ANY data | 23:54 |
| *** Sundar has joined #openstack-nova | 23:54 | |
| rm_work | i just want the data passed once to the booting VM | 23:54 |
| rm_work | and not tracked | 23:54 |
| dansmith | how much data do you want to be able to pass to nova once? | 23:54 |
| dansmith | like, should we let you include a 50G custom image instead of a ref? | 23:54 |
| *** shaohe_feng has quit IRC | 23:54 | |
| Sundar | efried: please ping me when you have the time. | 23:54 |
| rm_work | i mean, i understand the sarcasm (?), but it does seem seriously small | 23:55 |
| rm_work | but even if it wasn't too small, user_data is even more insecure | 23:55 |
| dansmith | well, obviously I'm being hyperbolic here, but 16k for an identifier or something that lets you fetch larger things from something intended to serve such things seems pretty reasonable to me | 23:55 |
| rm_work | it just stores the data directly in the DB unencrypted | 23:55 |
| *** shaohe_feng has joined #openstack-nova | 23:56 | |
| rm_work | which means it's just not viable from the get-go | 23:56 |
| dansmith | I think you're missing the point of how insecure config drive is, but also, | 23:56 |
| rm_work | please inform me! | 23:56 |
| dansmith | we have a real problem with several of our major lifecycle operations not being possible if we let you pass us stuff that we can't reproduce later | 23:56 |
| rm_work | I want to know what the security considerations you keep referring to are | 23:56 |
| *** felipemonteiro has joined #openstack-nova | 23:57 | |
| * penick skims backscroll | 23:57 | |
| dansmith | we stored config drive unencrypted on the disk, we built it from writing the tree out somewhere in /tmp first, we sent all your data over the unencrytped message bus to anyone claiming with no auth to be the compute node in question | 23:57 |
| rm_work | 1) unencrypted on the HV's disk? | 23:58 |
| dansmith | yup, or on nfs if you're using that, so that's even better | 23:58 |
| rm_work | 2) unencrypted message bus? you mean RMQ? we use TLS for that with client cert auth -- don't others? | 23:58 |
| dansmith | rm_work: sure, some do, but there's no auth at the application layer.. if I can connect to RMQ, I can impersonate any compute node on the system until they realize and cut me off | 23:59 |
| rm_work | for 1, if we lose the HV's integrity, it barely matters what else is secure | 23:59 |
| rm_work | a HV-level breakout is basically game-over | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!